{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/47070863","id":47070863,"diff_hunk":"@@ -95,7 +95,7 @@ complete -c docker -A -f -n '__fish_seen_subcommand_from build' -l force-rm -d '\n complete -c docker -A -f -n '__fish_seen_subcommand_from build' -l help -d 'Print usage'\n complete -c docker -A -f -n '__fish_seen_subcommand_from build' -l no-cache -d 'Do not use cache when building the image'\n complete -c docker -A -f -n '__fish_seen_subcommand_from build' -l pull -d 'Always attempt to pull a newer version of the image'\n-complete -c docker -A -f -n '__fish_seen_subcommand_from build' -s q -l quiet -d 'Suppress the verbose output generated by the containers'\n+complete -c docker -A -f -n '__fish_seen_subcommand_from build' -s q -l quiet -d 'Suppress the build output and print image ID, if succeed'","path":"contrib/completion/fish/docker.fish","position":5,"original_position":5,"commit_id":"05c1372d8617b2c922bc87657d1cbd01c711f056","original_commit_id":"05c1372d8617b2c922bc87657d1cbd01c711f056","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2015-12-09T10:01:58Z","updated_at":"2015-12-09T10:01:58Z","html_url":"https://github.com/docker/docker/pull/17428#discussion_r47070863","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/17428","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/47070863"},"html":{"href":"https://github.com/docker/docker/pull/17428#discussion_r47070863"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/17428"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/17428","id":48972914,"html_url":"https://github.com/docker/docker/pull/17428","diff_url":"https://github.com/docker/docker/pull/17428.diff","patch_url":"https://github.com/docker/docker/pull/17428.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/17428","number":17428,"state":"open","locked":false,"title":"Change the quiet flag behavior in the build command [closes #17623]","user":{"login":"ripcurld00d","id":2453279,"avatar_url":"https://avatars.githubusercontent.com/u/2453279?v=3","gravatar_id":"","url":"https://api.github.com/users/ripcurld00d","html_url":"https://github.com/ripcurld00d","followers_url":"https://api.github.com/users/ripcurld00d/followers","following_url":"https://api.github.com/users/ripcurld00d/following{/other_user}","gists_url":"https://api.github.com/users/ripcurld00d/gists{/gist_id}","starred_url":"https://api.github.com/users/ripcurld00d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripcurld00d/subscriptions","organizations_url":"https://api.github.com/users/ripcurld00d/orgs","repos_url":"https://api.github.com/users/ripcurld00d/repos","events_url":"https://api.github.com/users/ripcurld00d/events{/privacy}","received_events_url":"https://api.github.com/users/ripcurld00d/received_events","type":"User","site_admin":false},"body":"This PR answers the requirement in #7727 and closes #17623\r\n\r\nCloses #17623\r\n\r\n>    Right now, the quiet (-q, --quiet) flag ignores the output\r\n>    generated from within the container.\r\n    \r\n>    However, it ought to be a quiet in a way that all kind\r\n>    of diagnostic output should be ignored, unless the build\r\n>    process fails.\r\n>    \r\n>    This patch makes the quiet flag behave in the following way:\r\n>     1. If the build process succeeds, stdout contains the image ID\r\n>           and stderr is empty.\r\n>     2. If the build process fails, stdout is empty and stderr\r\n>           has the error message and the diagnostic output of that process.\r\n>    \r\n>    If the quiet flag is not set, then everything goes to stdout\r\n>    and error messages, if there are any, go to stderr.\r\n\r\nTODO:\r\n* ~~Change the `quiet` part in the `docker build` docs~~\r\n* ~~Write a cli-integration test~~\r\n* ~~Apparently figure out why the tests fail~~","created_at":"2015-10-28T07:37:08Z","updated_at":"2015-12-09T10:01:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8223235e1c3f7ea278dcd6195390c736a4035d64","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/17428/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/17428/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/17428/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/05c1372d8617b2c922bc87657d1cbd01c711f056","head":{"label":"ripcurld00d:cli_ninja_build","ref":"cli_ninja_build","sha":"05c1372d8617b2c922bc87657d1cbd01c711f056","user":{"login":"ripcurld00d","id":2453279,"avatar_url":"https://avatars.githubusercontent.com/u/2453279?v=3","gravatar_id":"","url":"https://api.github.com/users/ripcurld00d","html_url":"https://github.com/ripcurld00d","followers_url":"https://api.github.com/users/ripcurld00d/followers","following_url":"https://api.github.com/users/ripcurld00d/following{/other_user}","gists_url":"https://api.github.com/users/ripcurld00d/gists{/gist_id}","starred_url":"https://api.github.com/users/ripcurld00d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripcurld00d/subscriptions","organizations_url":"https://api.github.com/users/ripcurld00d/orgs","repos_url":"https://api.github.com/users/ripcurld00d/repos","events_url":"https://api.github.com/users/ripcurld00d/events{/privacy}","received_events_url":"https://api.github.com/users/ripcurld00d/received_events","type":"User","site_admin":false},"repo":{"id":44489970,"name":"docker","full_name":"ripcurld00d/docker","owner":{"login":"ripcurld00d","id":2453279,"avatar_url":"https://avatars.githubusercontent.com/u/2453279?v=3","gravatar_id":"","url":"https://api.github.com/users/ripcurld00d","html_url":"https://github.com/ripcurld00d","followers_url":"https://api.github.com/users/ripcurld00d/followers","following_url":"https://api.github.com/users/ripcurld00d/following{/other_user}","gists_url":"https://api.github.com/users/ripcurld00d/gists{/gist_id}","starred_url":"https://api.github.com/users/ripcurld00d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripcurld00d/subscriptions","organizations_url":"https://api.github.com/users/ripcurld00d/orgs","repos_url":"https://api.github.com/users/ripcurld00d/repos","events_url":"https://api.github.com/users/ripcurld00d/events{/privacy}","received_events_url":"https://api.github.com/users/ripcurld00d/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ripcurld00d/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/ripcurld00d/docker","forks_url":"https://api.github.com/repos/ripcurld00d/docker/forks","keys_url":"https://api.github.com/repos/ripcurld00d/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripcurld00d/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripcurld00d/docker/teams","hooks_url":"https://api.github.com/repos/ripcurld00d/docker/hooks","issue_events_url":"https://api.github.com/repos/ripcurld00d/docker/issues/events{/number}","events_url":"https://api.github.com/repos/ripcurld00d/docker/events","assignees_url":"https://api.github.com/repos/ripcurld00d/docker/assignees{/user}","branches_url":"https://api.github.com/repos/ripcurld00d/docker/branches{/branch}","tags_url":"https://api.github.com/repos/ripcurld00d/docker/tags","blobs_url":"https://api.github.com/repos/ripcurld00d/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripcurld00d/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripcurld00d/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripcurld00d/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripcurld00d/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/ripcurld00d/docker/languages","stargazers_url":"https://api.github.com/repos/ripcurld00d/docker/stargazers","contributors_url":"https://api.github.com/repos/ripcurld00d/docker/contributors","subscribers_url":"https://api.github.com/repos/ripcurld00d/docker/subscribers","subscription_url":"https://api.github.com/repos/ripcurld00d/docker/subscription","commits_url":"https://api.github.com/repos/ripcurld00d/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripcurld00d/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripcurld00d/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripcurld00d/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripcurld00d/docker/contents/{+path}","compare_url":"https://api.github.com/repos/ripcurld00d/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripcurld00d/docker/merges","archive_url":"https://api.github.com/repos/ripcurld00d/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripcurld00d/docker/downloads","issues_url":"https://api.github.com/repos/ripcurld00d/docker/issues{/number}","pulls_url":"https://api.github.com/repos/ripcurld00d/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/ripcurld00d/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/ripcurld00d/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripcurld00d/docker/labels{/name}","releases_url":"https://api.github.com/repos/ripcurld00d/docker/releases{/id}","created_at":"2015-10-18T18:11:19Z","updated_at":"2015-10-18T18:11:32Z","pushed_at":"2015-12-07T20:58:35Z","git_url":"git://github.com/ripcurld00d/docker.git","ssh_url":"git@github.com:ripcurld00d/docker.git","clone_url":"https://github.com/ripcurld00d/docker.git","svn_url":"https://github.com/ripcurld00d/docker","homepage":"http://www.docker.com","size":76335,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"41ae615aa13508b8f8958dc1c338fce5bccb8e6b","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-12-09T09:32:17Z","pushed_at":"2015-12-09T08:50:51Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":119315,"stargazers_count":26896,"watchers_count":26896,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7308,"mirror_url":null,"open_issues_count":1226,"forks":7308,"open_issues":1226,"watchers":26896,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/17428"},"html":{"href":"https://github.com/docker/docker/pull/17428"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/17428"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/17428/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/17428/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/17428/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/05c1372d8617b2c922bc87657d1cbd01c711f056"}}}}