{"action":"closed","number":6631,"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/6631","id":30991042,"html_url":"https://github.com/Wikia/app/pull/6631","diff_url":"https://github.com/Wikia/app/pull/6631.diff","patch_url":"https://github.com/Wikia/app/pull/6631.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/6631","number":6631,"state":"closed","locked":false,"title":"Update WikiaView to allow for finer grain template locations/names","user":{"login":"garthwebb","id":72574,"avatar_url":"https://avatars.githubusercontent.com/u/72574?v=3","gravatar_id":"","url":"https://api.github.com/users/garthwebb","html_url":"https://github.com/garthwebb","followers_url":"https://api.github.com/users/garthwebb/followers","following_url":"https://api.github.com/users/garthwebb/following{/other_user}","gists_url":"https://api.github.com/users/garthwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/garthwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garthwebb/subscriptions","organizations_url":"https://api.github.com/users/garthwebb/orgs","repos_url":"https://api.github.com/users/garthwebb/repos","events_url":"https://api.github.com/users/garthwebb/events{/privacy}","received_events_url":"https://api.github.com/users/garthwebb/received_events","type":"User","site_admin":false},"body":"This allows controller methods to define a @template annotation which will determine what base template name will be used to render that method's output, e.g.:\r\n```php\r\nclass FooController {\r\n  const DEFAULT_TEMPLATE_ENGINE = \\WikiaResponse::TEMPLATE_ENGINE_MUSTACHE;\r\n\r\n  /**\r\n   * @template myView\r\n   */\r\n  public function bar() {\r\n    // code\r\n  }\r\n}\r\n```\r\nThe view will look for a series of possible template names, falling back until it finds one that exists.  So in the above example it will check:\r\n\r\n* extensions/wikia/Foo/templates/myView.mustache\r\n* extensions/wikia/Foo/templates/Foo_bar.mustache\r\n* extensions/wikia/Foo/templates/FooController_bar.mustache\r\n\r\nThis pull request also allows the controller to define an alternate template path via a ```getTemplateDir``` method.  If this method exists, the return value will be used as the template directory:\r\n\r\n```php\r\nclass FooController {\r\n  public static function getTemplateDir() {\r\n    return dirname( __FILE__ ) . '/subfolder/templates';\r\n  }\r\n}\r\n```\r\nIn this case the search paths will look like:\r\n\r\n* extensions/wikia/Foo/subfolder/templates/myView.mustache\r\n* extensions/wikia/Foo/subfolder/templates/Foo_bar.mustache\r\n* extensions/wikia/Foo/subfolder/templates/FooController_bar.mustache\r\n\r\nNote if the directory given does not exist, it will fall back to the default location.\r\n\r\n@Wikia/platform-team ","created_at":"2015-03-11T22:17:36Z","updated_at":"2015-03-19T17:17:06Z","closed_at":"2015-03-19T17:17:06Z","merged_at":"2015-03-19T17:17:06Z","merge_commit_sha":"b280d88950937cc0f14a12f9e62a94c3502bd222","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/6631/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/6631/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/6631/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/5836058ae9b99b0ab3b65f3823f136997d79d518","head":{"label":"Wikia:TemplateAnnotations","ref":"TemplateAnnotations","sha":"5836058ae9b99b0ab3b65f3823f136997d79d518","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-03-19T17:17:07Z","pushed_at":"2015-03-19T17:17:06Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1380660,"stargazers_count":74,"watchers_count":74,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":62,"forks":54,"open_issues":62,"watchers":74,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"edf9165710c13f41d6d37c665e23bb50187bc764","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-03-19T17:17:07Z","pushed_at":"2015-03-19T17:17:06Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1380660,"stargazers_count":74,"watchers_count":74,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":62,"forks":54,"open_issues":62,"watchers":74,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/6631"},"html":{"href":"https://github.com/Wikia/app/pull/6631"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/6631"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/6631/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/6631/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/6631/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/5836058ae9b99b0ab3b65f3823f136997d79d518"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"garthwebb","id":72574,"avatar_url":"https://avatars.githubusercontent.com/u/72574?v=3","gravatar_id":"","url":"https://api.github.com/users/garthwebb","html_url":"https://github.com/garthwebb","followers_url":"https://api.github.com/users/garthwebb/followers","following_url":"https://api.github.com/users/garthwebb/following{/other_user}","gists_url":"https://api.github.com/users/garthwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/garthwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garthwebb/subscriptions","organizations_url":"https://api.github.com/users/garthwebb/orgs","repos_url":"https://api.github.com/users/garthwebb/repos","events_url":"https://api.github.com/users/garthwebb/events{/privacy}","received_events_url":"https://api.github.com/users/garthwebb/received_events","type":"User","site_admin":false},"comments":4,"review_comments":5,"commits":6,"additions":132,"deletions":39,"changed_files":3}}