{"action":"created","issue":{"url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/327","labels_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/327/labels{/name}","comments_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/327/comments","events_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/327/events","html_url":"https://github.com/madebymany/sir-trevor-js/issues/327","id":65716616,"number":327,"title":"Implementation of Scribe.js causes issues with browserify","user":{"login":"bartek","id":5839,"avatar_url":"https://avatars.githubusercontent.com/u/5839?v=3","gravatar_id":"","url":"https://api.github.com/users/bartek","html_url":"https://github.com/bartek","followers_url":"https://api.github.com/users/bartek/followers","following_url":"https://api.github.com/users/bartek/following{/other_user}","gists_url":"https://api.github.com/users/bartek/gists{/gist_id}","starred_url":"https://api.github.com/users/bartek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartek/subscriptions","organizations_url":"https://api.github.com/users/bartek/orgs","repos_url":"https://api.github.com/users/bartek/repos","events_url":"https://api.github.com/users/bartek/events{/privacy}","received_events_url":"https://api.github.com/users/bartek/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-01T15:51:25Z","updated_at":"2015-04-01T17:11:09Z","closed_at":"2015-04-01T17:11:08Z","body":"Hi there,\r\n\r\nI just pulled in the latest 5.x beta using `npm install sir-trevor`\r\n\r\nI took a peak at what Scribe.js is and see it's a project by the Guardian (cool!), but the entire module is AMD-only. When I bundle my simple app (which simply includes SirTrevor and React), I am resulted with:\r\n\r\n```\r\nvar React = require('react'),\r\n   DocumentTitle = require('react-document-title'),\r\n   SirTrevor = require('sir-trevor')\r\n\r\nmodule.exports = React.createClass({\r\n   render: function() {\r\n     return (\r\n       <DocumentTitle title=\"Hello There\" />\r\n     )\r\n   }\r\n}\r\n```\r\n\r\n`Uncaught ReferenceError: define is not defined` Which seems to be coming from the `define` calls in scribe.js.\r\n\r\nIs this because this is the beta branch? It seems like a lot of work is going on right now to convert SirTrevor so I'm hesitant in using the 4.x branch if there'll be a lot of breaking changes?\r\n\r\nThanks!\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/comments/88559333","html_url":"https://github.com/madebymany/sir-trevor-js/issues/327#issuecomment-88559333","issue_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/327","id":88559333,"user":{"login":"bartek","id":5839,"avatar_url":"https://avatars.githubusercontent.com/u/5839?v=3","gravatar_id":"","url":"https://api.github.com/users/bartek","html_url":"https://github.com/bartek","followers_url":"https://api.github.com/users/bartek/followers","following_url":"https://api.github.com/users/bartek/following{/other_user}","gists_url":"https://api.github.com/users/bartek/gists{/gist_id}","starred_url":"https://api.github.com/users/bartek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartek/subscriptions","organizations_url":"https://api.github.com/users/bartek/orgs","repos_url":"https://api.github.com/users/bartek/repos","events_url":"https://api.github.com/users/bartek/events{/privacy}","received_events_url":"https://api.github.com/users/bartek/received_events","type":"User","site_admin":false},"created_at":"2015-04-01T17:11:08Z","updated_at":"2015-04-01T17:11:08Z","body":"@zgryw Cool, thanks. I guess I can close this issue if you're aware of it :)\r\n\r\nI'll try the 4.x branch. If there's some migration pains that's not a big deal, since it'll unblock me today.\r\n\r\nCheers,"}}