{"action":"created","comment":{"url":"https://api.github.com/repos/jdbi/jdbi/pulls/comments/43027545","id":43027545,"diff_hunk":"@@ -88,12 +91,23 @@\n         this.timingCollector = timingCollector;\n         this.params = params;\n         this.locator = locator;\n+        this.collectorFactoryRegistry = collectorFactoryRegistry.createChild();\n \n         ctx.setConnection(handle.getConnection());\n         ctx.setRawSql(sql);\n         ctx.setBinding(params);\n     }\n \n+    CollectorFactoryRegistry getCollectorFactoryRegistry()\n+    {\n+        return collectorFactoryRegistry;\n+    }\n+\n+    @SuppressWarnings(\"unchecked\")\n+    public SelfType registerContainerFactory(CollectorFactory<?,?, ?> collectorFactory) {","path":"core/src/main/java/org/jdbi/v3/SQLStatement.java","position":43,"original_position":43,"commit_id":"f84fa0e780b416f8747c83a605cfb5f7916220d9","original_commit_id":"f84fa0e780b416f8747c83a605cfb5f7916220d9","user":{"login":"qualidafial","id":38629,"avatar_url":"https://avatars.githubusercontent.com/u/38629?v=3","gravatar_id":"","url":"https://api.github.com/users/qualidafial","html_url":"https://github.com/qualidafial","followers_url":"https://api.github.com/users/qualidafial/followers","following_url":"https://api.github.com/users/qualidafial/following{/other_user}","gists_url":"https://api.github.com/users/qualidafial/gists{/gist_id}","starred_url":"https://api.github.com/users/qualidafial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qualidafial/subscriptions","organizations_url":"https://api.github.com/users/qualidafial/orgs","repos_url":"https://api.github.com/users/qualidafial/repos","events_url":"https://api.github.com/users/qualidafial/events{/privacy}","received_events_url":"https://api.github.com/users/qualidafial/received_events","type":"User","site_admin":false},"body":"This one still needs to be renamed.","created_at":"2015-10-26T17:47:26Z","updated_at":"2015-10-26T17:47:26Z","html_url":"https://github.com/jdbi/jdbi/pull/199#discussion_r43027545","pull_request_url":"https://api.github.com/repos/jdbi/jdbi/pulls/199","_links":{"self":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/comments/43027545"},"html":{"href":"https://github.com/jdbi/jdbi/pull/199#discussion_r43027545"},"pull_request":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/jdbi/jdbi/pulls/199","id":48679034,"html_url":"https://github.com/jdbi/jdbi/pull/199","diff_url":"https://github.com/jdbi/jdbi/pull/199.diff","patch_url":"https://github.com/jdbi/jdbi/pull/199.patch","issue_url":"https://api.github.com/repos/jdbi/jdbi/issues/199","number":199,"state":"open","locked":false,"title":"Resurrect container builders in JDBI 3","user":{"login":"arteam","id":1717632,"avatar_url":"https://avatars.githubusercontent.com/u/1717632?v=3","gravatar_id":"","url":"https://api.github.com/users/arteam","html_url":"https://github.com/arteam","followers_url":"https://api.github.com/users/arteam/followers","following_url":"https://api.github.com/users/arteam/following{/other_user}","gists_url":"https://api.github.com/users/arteam/gists{/gist_id}","starred_url":"https://api.github.com/users/arteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arteam/subscriptions","organizations_url":"https://api.github.com/users/arteam/orgs","repos_url":"https://api.github.com/users/arteam/repos","events_url":"https://api.github.com/users/arteam/events{/privacy}","received_events_url":"https://api.github.com/users/arteam/received_events","type":"User","site_admin":false},"body":"Container builders are actually quite useful for collecting query results into types that are not shipped with the JDK.  For example, Google Guava's immutable collections and optional values.\r\n\r\nAlso, they are indispensable for SQLObject API, where we don't have Stream API for providing implementations of custom types.","created_at":"2015-10-25T14:01:30Z","updated_at":"2015-10-26T17:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2985987f25d29921d047815ea459741fbe9e10b","assignee":{"login":"qualidafial","id":38629,"avatar_url":"https://avatars.githubusercontent.com/u/38629?v=3","gravatar_id":"","url":"https://api.github.com/users/qualidafial","html_url":"https://github.com/qualidafial","followers_url":"https://api.github.com/users/qualidafial/followers","following_url":"https://api.github.com/users/qualidafial/following{/other_user}","gists_url":"https://api.github.com/users/qualidafial/gists{/gist_id}","starred_url":"https://api.github.com/users/qualidafial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qualidafial/subscriptions","organizations_url":"https://api.github.com/users/qualidafial/orgs","repos_url":"https://api.github.com/users/qualidafial/repos","events_url":"https://api.github.com/users/qualidafial/events{/privacy}","received_events_url":"https://api.github.com/users/qualidafial/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/jdbi/jdbi/pulls/199/commits","review_comments_url":"https://api.github.com/repos/jdbi/jdbi/pulls/199/comments","review_comment_url":"https://api.github.com/repos/jdbi/jdbi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jdbi/jdbi/issues/199/comments","statuses_url":"https://api.github.com/repos/jdbi/jdbi/statuses/f84fa0e780b416f8747c83a605cfb5f7916220d9","head":{"label":"arteam:ressurect_container_builder","ref":"ressurect_container_builder","sha":"f84fa0e780b416f8747c83a605cfb5f7916220d9","user":{"login":"arteam","id":1717632,"avatar_url":"https://avatars.githubusercontent.com/u/1717632?v=3","gravatar_id":"","url":"https://api.github.com/users/arteam","html_url":"https://github.com/arteam","followers_url":"https://api.github.com/users/arteam/followers","following_url":"https://api.github.com/users/arteam/following{/other_user}","gists_url":"https://api.github.com/users/arteam/gists{/gist_id}","starred_url":"https://api.github.com/users/arteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arteam/subscriptions","organizations_url":"https://api.github.com/users/arteam/orgs","repos_url":"https://api.github.com/users/arteam/repos","events_url":"https://api.github.com/users/arteam/events{/privacy}","received_events_url":"https://api.github.com/users/arteam/received_events","type":"User","site_admin":false},"repo":{"id":19196987,"name":"jdbi","full_name":"arteam/jdbi","owner":{"login":"arteam","id":1717632,"avatar_url":"https://avatars.githubusercontent.com/u/1717632?v=3","gravatar_id":"","url":"https://api.github.com/users/arteam","html_url":"https://github.com/arteam","followers_url":"https://api.github.com/users/arteam/followers","following_url":"https://api.github.com/users/arteam/following{/other_user}","gists_url":"https://api.github.com/users/arteam/gists{/gist_id}","starred_url":"https://api.github.com/users/arteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arteam/subscriptions","organizations_url":"https://api.github.com/users/arteam/orgs","repos_url":"https://api.github.com/users/arteam/repos","events_url":"https://api.github.com/users/arteam/events{/privacy}","received_events_url":"https://api.github.com/users/arteam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arteam/jdbi","description":"jDBI is designed to provide convenient tabular data access in Java(tm). It uses the Java collections framework for query results, provides a convenient means of externalizing sql statements, and provides named parameter support for any database being used.","fork":true,"url":"https://api.github.com/repos/arteam/jdbi","forks_url":"https://api.github.com/repos/arteam/jdbi/forks","keys_url":"https://api.github.com/repos/arteam/jdbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arteam/jdbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arteam/jdbi/teams","hooks_url":"https://api.github.com/repos/arteam/jdbi/hooks","issue_events_url":"https://api.github.com/repos/arteam/jdbi/issues/events{/number}","events_url":"https://api.github.com/repos/arteam/jdbi/events","assignees_url":"https://api.github.com/repos/arteam/jdbi/assignees{/user}","branches_url":"https://api.github.com/repos/arteam/jdbi/branches{/branch}","tags_url":"https://api.github.com/repos/arteam/jdbi/tags","blobs_url":"https://api.github.com/repos/arteam/jdbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arteam/jdbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arteam/jdbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/arteam/jdbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arteam/jdbi/statuses/{sha}","languages_url":"https://api.github.com/repos/arteam/jdbi/languages","stargazers_url":"https://api.github.com/repos/arteam/jdbi/stargazers","contributors_url":"https://api.github.com/repos/arteam/jdbi/contributors","subscribers_url":"https://api.github.com/repos/arteam/jdbi/subscribers","subscription_url":"https://api.github.com/repos/arteam/jdbi/subscription","commits_url":"https://api.github.com/repos/arteam/jdbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/arteam/jdbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/arteam/jdbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/arteam/jdbi/issues/comments{/number}","contents_url":"https://api.github.com/repos/arteam/jdbi/contents/{+path}","compare_url":"https://api.github.com/repos/arteam/jdbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arteam/jdbi/merges","archive_url":"https://api.github.com/repos/arteam/jdbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arteam/jdbi/downloads","issues_url":"https://api.github.com/repos/arteam/jdbi/issues{/number}","pulls_url":"https://api.github.com/repos/arteam/jdbi/pulls{/number}","milestones_url":"https://api.github.com/repos/arteam/jdbi/milestones{/number}","notifications_url":"https://api.github.com/repos/arteam/jdbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arteam/jdbi/labels{/name}","releases_url":"https://api.github.com/repos/arteam/jdbi/releases{/id}","created_at":"2014-04-27T05:55:15Z","updated_at":"2014-12-31T19:04:48Z","pushed_at":"2015-10-26T16:53:05Z","git_url":"git://github.com/arteam/jdbi.git","ssh_url":"git@github.com:arteam/jdbi.git","clone_url":"https://github.com/arteam/jdbi.git","svn_url":"https://github.com/arteam/jdbi","homepage":"http://jdbi.org/","size":12245,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jdbi:jdbi3","ref":"jdbi3","sha":"b98273e95dcf24667d71ac6a5ab1061faaece1c4","user":{"login":"jdbi","id":9668860,"avatar_url":"https://avatars.githubusercontent.com/u/9668860?v=3","gravatar_id":"","url":"https://api.github.com/users/jdbi","html_url":"https://github.com/jdbi","followers_url":"https://api.github.com/users/jdbi/followers","following_url":"https://api.github.com/users/jdbi/following{/other_user}","gists_url":"https://api.github.com/users/jdbi/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbi/subscriptions","organizations_url":"https://api.github.com/users/jdbi/orgs","repos_url":"https://api.github.com/users/jdbi/repos","events_url":"https://api.github.com/users/jdbi/events{/privacy}","received_events_url":"https://api.github.com/users/jdbi/received_events","type":"Organization","site_admin":false},"repo":{"id":229738,"name":"jdbi","full_name":"jdbi/jdbi","owner":{"login":"jdbi","id":9668860,"avatar_url":"https://avatars.githubusercontent.com/u/9668860?v=3","gravatar_id":"","url":"https://api.github.com/users/jdbi","html_url":"https://github.com/jdbi","followers_url":"https://api.github.com/users/jdbi/followers","following_url":"https://api.github.com/users/jdbi/following{/other_user}","gists_url":"https://api.github.com/users/jdbi/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbi/subscriptions","organizations_url":"https://api.github.com/users/jdbi/orgs","repos_url":"https://api.github.com/users/jdbi/repos","events_url":"https://api.github.com/users/jdbi/events{/privacy}","received_events_url":"https://api.github.com/users/jdbi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jdbi/jdbi","description":"jDBI is designed to provide convenient tabular data access in Java(tm). It uses the Java collections framework for query results, provides a convenient means of externalizing sql statements, and provides named parameter support for any database being used.","fork":false,"url":"https://api.github.com/repos/jdbi/jdbi","forks_url":"https://api.github.com/repos/jdbi/jdbi/forks","keys_url":"https://api.github.com/repos/jdbi/jdbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdbi/jdbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdbi/jdbi/teams","hooks_url":"https://api.github.com/repos/jdbi/jdbi/hooks","issue_events_url":"https://api.github.com/repos/jdbi/jdbi/issues/events{/number}","events_url":"https://api.github.com/repos/jdbi/jdbi/events","assignees_url":"https://api.github.com/repos/jdbi/jdbi/assignees{/user}","branches_url":"https://api.github.com/repos/jdbi/jdbi/branches{/branch}","tags_url":"https://api.github.com/repos/jdbi/jdbi/tags","blobs_url":"https://api.github.com/repos/jdbi/jdbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdbi/jdbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdbi/jdbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdbi/jdbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdbi/jdbi/statuses/{sha}","languages_url":"https://api.github.com/repos/jdbi/jdbi/languages","stargazers_url":"https://api.github.com/repos/jdbi/jdbi/stargazers","contributors_url":"https://api.github.com/repos/jdbi/jdbi/contributors","subscribers_url":"https://api.github.com/repos/jdbi/jdbi/subscribers","subscription_url":"https://api.github.com/repos/jdbi/jdbi/subscription","commits_url":"https://api.github.com/repos/jdbi/jdbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdbi/jdbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdbi/jdbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdbi/jdbi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdbi/jdbi/contents/{+path}","compare_url":"https://api.github.com/repos/jdbi/jdbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdbi/jdbi/merges","archive_url":"https://api.github.com/repos/jdbi/jdbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdbi/jdbi/downloads","issues_url":"https://api.github.com/repos/jdbi/jdbi/issues{/number}","pulls_url":"https://api.github.com/repos/jdbi/jdbi/pulls{/number}","milestones_url":"https://api.github.com/repos/jdbi/jdbi/milestones{/number}","notifications_url":"https://api.github.com/repos/jdbi/jdbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdbi/jdbi/labels{/name}","releases_url":"https://api.github.com/repos/jdbi/jdbi/releases{/id}","created_at":"2009-06-17T16:36:36Z","updated_at":"2015-10-23T23:55:35Z","pushed_at":"2015-10-26T17:21:48Z","git_url":"git://github.com/jdbi/jdbi.git","ssh_url":"git@github.com:jdbi/jdbi.git","clone_url":"https://github.com/jdbi/jdbi.git","svn_url":"https://github.com/jdbi/jdbi","homepage":"http://jdbi.org/","size":17818,"stargazers_count":528,"watchers_count":528,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":122,"mirror_url":null,"open_issues_count":27,"forks":122,"open_issues":27,"watchers":528,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/199"},"html":{"href":"https://github.com/jdbi/jdbi/pull/199"},"issue":{"href":"https://api.github.com/repos/jdbi/jdbi/issues/199"},"comments":{"href":"https://api.github.com/repos/jdbi/jdbi/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/jdbi/jdbi/statuses/f84fa0e780b416f8747c83a605cfb5f7916220d9"}}}}