{"push_id":764713202,"size":538,"distinct_size":538,"ref":"refs/heads/master","head":"53b1ce2c5003fd29fb27c95e83cddb8982b911ff","before":"8620019f9240b7ab00b9636cc2b6e8d0c39bcd52","commits":[{"sha":"c918e740391d3d228cb6a927a33ed474455cacfb","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"Put common network start and stop code in one place.\n\nPrefer to use safer self.is_connected() as it checks interface\nis not None.\n\nUsing common code gives small observable changes in behaviour:\n\n - slightly different print_error() messages\n - network restarts now enter status 'connecting' which they\n   didn't before, which seems correct\n - status 'connecting' is done with set_status() rather than\n   simply assigning the status, which seems more correct.  Now\n   that the response_queue is available in the constructor this\n   works; it used to fail with 'response_queue is not defined'","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/c918e740391d3d228cb6a927a33ed474455cacfb"},{"sha":"86626d8080824c46886cf0ebf7e305290da68c5e","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"Consistency in handling of self.interface\n\nswitch_to_interface() becomes the common place where\nself.interface is set; therefore self.interface is not None\nprecisely when self.default_server is connected.  Previously some\nplaces required it to be connected and some didn't.  Also an\ninterface change now sends the 'updated' notification\nconsistently - previously some did and some didn't.\n\nHave network_start() call start_interfaces() - this also means\nnetwork restarts now do this.\n\nFix apparent off-by-one in start_interfaces()","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/86626d8080824c46886cf0ebf7e305290da68c5e"},{"sha":"b3f1f04312210a8c7009302850d4f80267545392","author":{"email":"27377a673db3eb1910df341068f93b222fcc13ef@gmail.com","name":"ThomasV"},"message":"Merge pull request #1224 from kyuupichan/netstartstop\n\nPut common network start and stop code in one place.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/b3f1f04312210a8c7009302850d4f80267545392"},{"sha":"68580164110bc0f72b38527b508345d8eacda73f","author":{"email":"27377a673db3eb1910df341068f93b222fcc13ef@gmail.com","name":"ThomasV"},"message":"Merge pull request #1225 from kyuupichan/net-interface\n\nConsistency in handling of self.interface","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/68580164110bc0f72b38527b508345d8eacda73f"},{"sha":"05dd3104315f6bd701d2c3de916092ce53eb0df3","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"Set 'connecting' status in one place.\n\nAlso means when switching to an already connected server our\nstatus doesn't quickly change to connecting and back again.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/05dd3104315f6bd701d2c3de916092ce53eb0df3"},{"sha":"20ee265683a637ef12950a26ace0ada99fb7868c","author":{"email":"27377a673db3eb1910df341068f93b222fcc13ef@gmail.com","name":"ThomasV"},"message":"Merge pull request #1227 from kyuupichan/connecting_status\n\nSet 'connecting' status in one place.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/20ee265683a637ef12950a26ace0ada99fb7868c"},{"sha":"4873c455b987c11f3a0764f67df262708760a50e","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"Add documentation string.  Fix uninitialized f error.\n\n    Traceback (most recent call last):\n      File \"src/electrum/lib/network.py\", line 411, in process_request\n        out['result'] = f(*params)\n    UnboundLocalError: local variable 'f' referenced before assignment\n    [Network] network error local variable 'f' referenced before assignment","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/4873c455b987c11f3a0764f67df262708760a50e"},{"sha":"d09d5e5dacf16e9a6657e3892c45815047304682","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"Plain number formatting for URIs.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/d09d5e5dacf16e9a6657e3892c45815047304682"},{"sha":"c7b33a9e4a2956b79356e6e3c2fb1e192f731097","author":{"email":"27377a673db3eb1910df341068f93b222fcc13ef@gmail.com","name":"ThomasV"},"message":"Merge pull request #1228 from kyuupichan/net-interfaces\n\nAdd documentation string.  Fix uninitialized f error.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/c7b33a9e4a2956b79356e6e3c2fb1e192f731097"},{"sha":"274965468ec1094fa750fdce97c6d36029ed807e","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"Remove interfaces in one place only\n\nswitch_to_random_interface used to do is_connected()\nchecks and remove interfaces when switching.  This\nis redundant: interfaces are only added to self.interfaces\nonce in is_connected() state from process_if_notification().\nWhen they are disconnected, a notification is also received\nand process_if_notification() performs the removal.  Furthermore,\ntwo other callers of switch_to_interface do not do explicit\nis_connected() checks before calling it.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/274965468ec1094fa750fdce97c6d36029ed807e"},{"sha":"e13e42a00c84d4a1aa9afc1e69c0caf176dddd6e","author":{"email":"27377a673db3eb1910df341068f93b222fcc13ef@gmail.com","name":"ThomasV"},"message":"Merge pull request #1229 from kyuupichan/uri-format\n\nPlain number formatting for URIs.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/e13e42a00c84d4a1aa9afc1e69c0caf176dddd6e"},{"sha":"0b201d98ab379c625193e54cadd6ae18cdf3826b","author":{"email":"27377a673db3eb1910df341068f93b222fcc13ef@gmail.com","name":"ThomasV"},"message":"Merge pull request #1230 from kyuupichan/switch-random-if\n\nRemove interfaces in one place only","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/0b201d98ab379c625193e54cadd6ae18cdf3826b"},{"sha":"346e38674b5cfc3cc86727027754370902d0a560","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"Absorb add_interface and remove_interface\n\nThey are now only called from the same place; it's simpler\nand clearer to put them inline.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/346e38674b5cfc3cc86727027754370902d0a560"},{"sha":"16b23a18324e96f3eab0093594a327adcc26eb9d","author":{"email":"27377a673db3eb1910df341068f93b222fcc13ef@gmail.com","name":"ThomasV"},"message":"Merge pull request #1231 from kyuupichan/if-add-remove\n\nAbsorb add_interface and remove_interface","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/16b23a18324e96f3eab0093594a327adcc26eb9d"},{"sha":"31ffd4b3819ed2b5a5f2880223beb4090ea3e90a","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"switch_to_interface() to start interface if not connected\n\nTwo places currently have switch-to-or-start-interface logic.\nPut that common logic into switch_to_interface().","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/31ffd4b3819ed2b5a5f2880223beb4090ea3e90a"},{"sha":"2f34f3db2151e12138d568feb69bbec12c0d9dd8","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"Only start if not already in pending_servers\n\nThis was only in one call site previously, not both.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/2f34f3db2151e12138d568feb69bbec12c0d9dd8"},{"sha":"b029589fc10ba2b210e79b32b4ba5588144c0760","author":{"email":"a18ade7952250adaaa164309d618d8d2923b68ff@gitorious","name":"ThomasV"},"message":"fix issue #1233","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/b029589fc10ba2b210e79b32b4ba5588144c0760"},{"sha":"33a8348d4896e8369e46191f94569b958c2cdd61","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"Prevent race with two electrum instances on same wallet.\n\nWhilst it's not a good idea to have two electrum instances\nopen on the same wallet, we should avoid throwing an\nexception.  Also note how the old code's handling of the\nexception (caused by both renaming the file almost at the\nsame time, rather than a non-POSIX system not supporting\nthe atomic rename) can lead to the wallet file being lost\nenirely because os.remove(self.path) succeeds and the\nrename of the temporary no-longer-existing file then fails.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/33a8348d4896e8369e46191f94569b958c2cdd61"},{"sha":"77490e47649777ee9a11a36d5fb9617dad0eddeb","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"Flush wallet storage once for a sequence of puts.\n\nThis speeds up save_transactions by 2 to 3 times for me.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/77490e47649777ee9a11a36d5fb9617dad0eddeb"},{"sha":"22d180f8fef49117989513ba15c295ac29e00d9e","author":{"email":"6dfb4e1bbe0130fb5cd3e4819961751b7350695b@gmail.com","name":"Neil Booth"},"message":"Tweak RELEASE-NOTES\n\nThe claim to show thousands separators has already confused\nsome people who didn't see it.","distinct":true,"url":"https://api.github.com/repos/dabura667/electrum/commits/22d180f8fef49117989513ba15c295ac29e00d9e"}]}