{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/45922234","id":45922234,"diff_hunk":"@@ -143,10 +143,50 @@ class Offer_test : public beast::unit_test::suite\n         expect (isOffer (env, \"alice\", XRP (300), USD (100)) &&\n             isOffer (env, \"alice\", XRP (400), USD (200)));\n     }\n+    void testTinyPayment ()\n+    {\n+        // Regression test for tiny payments\n+        using namespace jtx;\n+        auto const alice = Account (\"alice\");\n+        auto const bob = Account (\"bob\");\n+        auto const carol = Account (\"carol\");\n+        auto const gw = Account (\"gw\");\n+\n+        auto const USD = gw[\"USD\"];\n+        auto const EUR = gw[\"EUR\"];\n+\n+        Env env (*this);\n+\n+\n+        env.fund (XRP (10000), alice, bob, carol, gw);\n+        env.trust (USD (1000), alice, bob, carol);\n+        env.trust (EUR (1000), alice, bob, carol);\n+        env (pay (gw, alice, USD (100)));\n+        env (pay (gw, carol, EUR (100)));\n+\n+        // Create more offers than the loop max count in DeliverNodeReverse\n+        for (int i=0;i<101;++i)\n+            env (offer (carol, USD (1), EUR (2)));\n+\n+        auto const switchoverTime = STAmountCalcSwitchovers::enableUnderflowFixCloseTime ();\n+\n+        for (auto timeDelta : {-10, 10}){\n+            auto const closeTime = switchoverTime + timeDelta;\n+            STAmountCalcSwitchovers switchover (closeTime);\n+            env.close (NetClock::time_point (std::chrono::seconds (closeTime)));\n+            // Will fail without the underflow fix\n+            auto expectedResult = switchover.enableUnderflowFix () ?\n+                    tesSUCCESS : tecPATH_PARTIAL;\n+            log << switchoverTime << \" \" << closeTime << \" \"<< timeDelta << \" \" << expectedResult;","path":"src/ripple/app/tests/Offer.test.cpp","position":38,"original_position":38,"commit_id":"f1a24a382dffbbbee325419a0a5b1cbf42c6a36c","original_commit_id":"f1a24a382dffbbbee325419a0a5b1cbf42c6a36c","user":{"login":"seelabs","id":5853458,"avatar_url":"https://avatars.githubusercontent.com/u/5853458?v=3","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false},"body":"You're right, that was for debugging. Will remove.","created_at":"2015-11-25T21:40:55Z","updated_at":"2015-11-25T21:40:55Z","html_url":"https://github.com/ripple/rippled/pull/1386#discussion_r45922234","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/1386","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/45922234"},"html":{"href":"https://github.com/ripple/rippled/pull/1386#discussion_r45922234"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1386"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1386","id":49881949,"html_url":"https://github.com/ripple/rippled/pull/1386","diff_url":"https://github.com/ripple/rippled/pull/1386.diff","patch_url":"https://github.com/ripple/rippled/pull/1386.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1386","number":1386,"state":"open","locked":false,"title":"Fix underflow rounding issue","user":{"login":"seelabs","id":5853458,"avatar_url":"https://avatars.githubusercontent.com/u/5853458?v=3","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false},"body":"Very small payment could fail when STAmount::mulRound underflowed\r\nand returned zero, when it should have rounded up to the smallest\r\nrepresentable value.","created_at":"2015-11-05T21:17:19Z","updated_at":"2015-11-25T21:40:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff0008a5b6578111f4d77578c22e1509108dd4d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/1386/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/1386/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1386/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/f1a24a382dffbbbee325419a0a5b1cbf42c6a36c","head":{"label":"seelabs:dnr","ref":"dnr","sha":"f1a24a382dffbbbee325419a0a5b1cbf42c6a36c","user":{"login":"seelabs","id":5853458,"avatar_url":"https://avatars.githubusercontent.com/u/5853458?v=3","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false},"repo":{"id":28865026,"name":"rippled","full_name":"seelabs/rippled","owner":{"login":"seelabs","id":5853458,"avatar_url":"https://avatars.githubusercontent.com/u/5853458?v=3","gravatar_id":"","url":"https://api.github.com/users/seelabs","html_url":"https://github.com/seelabs","followers_url":"https://api.github.com/users/seelabs/followers","following_url":"https://api.github.com/users/seelabs/following{/other_user}","gists_url":"https://api.github.com/users/seelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/seelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seelabs/subscriptions","organizations_url":"https://api.github.com/users/seelabs/orgs","repos_url":"https://api.github.com/users/seelabs/repos","events_url":"https://api.github.com/users/seelabs/events{/privacy}","received_events_url":"https://api.github.com/users/seelabs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seelabs/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/seelabs/rippled","forks_url":"https://api.github.com/repos/seelabs/rippled/forks","keys_url":"https://api.github.com/repos/seelabs/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seelabs/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seelabs/rippled/teams","hooks_url":"https://api.github.com/repos/seelabs/rippled/hooks","issue_events_url":"https://api.github.com/repos/seelabs/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/seelabs/rippled/events","assignees_url":"https://api.github.com/repos/seelabs/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/seelabs/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/seelabs/rippled/tags","blobs_url":"https://api.github.com/repos/seelabs/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seelabs/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seelabs/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/seelabs/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seelabs/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/seelabs/rippled/languages","stargazers_url":"https://api.github.com/repos/seelabs/rippled/stargazers","contributors_url":"https://api.github.com/repos/seelabs/rippled/contributors","subscribers_url":"https://api.github.com/repos/seelabs/rippled/subscribers","subscription_url":"https://api.github.com/repos/seelabs/rippled/subscription","commits_url":"https://api.github.com/repos/seelabs/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/seelabs/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/seelabs/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/seelabs/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/seelabs/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/seelabs/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seelabs/rippled/merges","archive_url":"https://api.github.com/repos/seelabs/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seelabs/rippled/downloads","issues_url":"https://api.github.com/repos/seelabs/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/seelabs/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/seelabs/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/seelabs/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seelabs/rippled/labels{/name}","releases_url":"https://api.github.com/repos/seelabs/rippled/releases{/id}","created_at":"2015-01-06T13:36:16Z","updated_at":"2015-05-08T17:27:12Z","pushed_at":"2015-11-25T18:57:13Z","git_url":"git://github.com/seelabs/rippled.git","ssh_url":"git@github.com:seelabs/rippled.git","clone_url":"https://github.com/seelabs/rippled.git","svn_url":"https://github.com/seelabs/rippled","homepage":"https://ripple.com","size":58481,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"01c9baf8cab38da0acb7f515d950a550aa19008c","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","created_at":"2011-11-07T04:40:15Z","updated_at":"2015-11-24T19:08:08Z","pushed_at":"2015-11-25T18:08:19Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":96263,"stargazers_count":1004,"watchers_count":1004,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":290,"mirror_url":null,"open_issues_count":125,"forks":290,"open_issues":125,"watchers":1004,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1386"},"html":{"href":"https://github.com/ripple/rippled/pull/1386"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/1386"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/1386/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1386/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1386/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/f1a24a382dffbbbee325419a0a5b1cbf42c6a36c"}}}}