{"action":"created","comment":{"url":"https://api.github.com/repos/google/UIforETW/pulls/comments/30299137","id":30299137,"diff_hunk":"@@ -68,13 +73,16 @@ void CWorkingSetMonitor::SampleWorkingSets()\n \t\tfor (const auto& name : processes_)\r\n \t\t{\r\n \t\t\tif (_wcsicmp(peInfo.szExeFile, name.c_str()) == 0)\r\n+\t\t\t{\r\n \t\t\t\tmatch = true;\r\n+\t\t\t}\r\n \t\t}\r\n \t\tif (match)\r\n \t\t{\r\n \t\t\tDWORD pid = peInfo.th32ProcessID;\r\n \t\t\t// Get a handle to the process.\r\n-\t\t\tHANDLE hProcess = OpenProcess(PROCESS_QUERY_INFORMATION |\r\n+\t\t\tHANDLE hProcess =\r","path":"UIforETW/WorkingSet.cpp","position":29,"original_position":29,"commit_id":"06337d1ca7a26317dd43e8d4e6278e16132c3615","original_commit_id":"06337d1ca7a26317dd43e8d4e6278e16132c3615","user":{"login":"randomascii","id":10800041,"avatar_url":"https://avatars.githubusercontent.com/u/10800041?v=3","gravatar_id":"","url":"https://api.github.com/users/randomascii","html_url":"https://github.com/randomascii","followers_url":"https://api.github.com/users/randomascii/followers","following_url":"https://api.github.com/users/randomascii/following{/other_user}","gists_url":"https://api.github.com/users/randomascii/gists{/gist_id}","starred_url":"https://api.github.com/users/randomascii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randomascii/subscriptions","organizations_url":"https://api.github.com/users/randomascii/orgs","repos_url":"https://api.github.com/users/randomascii/repos","events_url":"https://api.github.com/users/randomascii/events{/privacy}","received_events_url":"https://api.github.com/users/randomascii/received_events","type":"User","site_admin":false},"body":"Beware of reformatting the code for minor taste reasons...","created_at":"2015-05-14T05:42:17Z","updated_at":"2015-05-14T05:42:17Z","html_url":"https://github.com/google/UIforETW/pull/33#discussion_r30299137","pull_request_url":"https://api.github.com/repos/google/UIforETW/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/google/UIforETW/pulls/comments/30299137"},"html":{"href":"https://github.com/google/UIforETW/pull/33#discussion_r30299137"},"pull_request":{"href":"https://api.github.com/repos/google/UIforETW/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/google/UIforETW/pulls/33","id":35390060,"html_url":"https://github.com/google/UIforETW/pull/33","diff_url":"https://github.com/google/UIforETW/pull/33.diff","patch_url":"https://github.com/google/UIforETW/pull/33.patch","issue_url":"https://api.github.com/repos/google/UIforETW/issues/33","number":33,"state":"open","locked":false,"title":"ETWProviders cleanup","user":{"login":"ariccio","id":2142308,"avatar_url":"https://avatars.githubusercontent.com/u/2142308?v=3","gravatar_id":"","url":"https://api.github.com/users/ariccio","html_url":"https://github.com/ariccio","followers_url":"https://api.github.com/users/ariccio/followers","following_url":"https://api.github.com/users/ariccio/following{/other_user}","gists_url":"https://api.github.com/users/ariccio/gists{/gist_id}","starred_url":"https://api.github.com/users/ariccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariccio/subscriptions","organizations_url":"https://api.github.com/users/ariccio/orgs","repos_url":"https://api.github.com/users/ariccio/repos","events_url":"https://api.github.com/users/ariccio/events{/privacy}","received_events_url":"https://api.github.com/users/ariccio/received_events","type":"User","site_admin":false},"body":"Contrary to the name of this branch, I didn't actually investigate the Working Set monitoring performance issues. I did a bunch of cleanup instead.\r\n\r\nThe cleanup involved:\r\n- Increasing warning level from 3 to 4\r\n- Enabling Code Analysis for all builds (build time is still very fast)\r\n- Adding annotations\r\n- Converting private & unimplemented copy constructors to `delete`d functions\r\n- etc...\r\n\r\nThere's one `/analyze` warning that I haven't yet figured out, but it's not a critical issue.\r\n\r\nI have NOT included the recompiled `.lib`/`.dll` in this PR, as I figured that you might want to do that.","created_at":"2015-05-14T02:53:54Z","updated_at":"2015-05-14T05:42:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b012486ac7f39d0072dfbade7ba0aab7bfed4d16","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/UIforETW/pulls/33/commits","review_comments_url":"https://api.github.com/repos/google/UIforETW/pulls/33/comments","review_comment_url":"https://api.github.com/repos/google/UIforETW/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/UIforETW/issues/33/comments","statuses_url":"https://api.github.com/repos/google/UIforETW/statuses/06337d1ca7a26317dd43e8d4e6278e16132c3615","head":{"label":"ariccio:working-set-performance-investigation","ref":"working-set-performance-investigation","sha":"06337d1ca7a26317dd43e8d4e6278e16132c3615","user":{"login":"ariccio","id":2142308,"avatar_url":"https://avatars.githubusercontent.com/u/2142308?v=3","gravatar_id":"","url":"https://api.github.com/users/ariccio","html_url":"https://github.com/ariccio","followers_url":"https://api.github.com/users/ariccio/followers","following_url":"https://api.github.com/users/ariccio/following{/other_user}","gists_url":"https://api.github.com/users/ariccio/gists{/gist_id}","starred_url":"https://api.github.com/users/ariccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariccio/subscriptions","organizations_url":"https://api.github.com/users/ariccio/orgs","repos_url":"https://api.github.com/users/ariccio/repos","events_url":"https://api.github.com/users/ariccio/events{/privacy}","received_events_url":"https://api.github.com/users/ariccio/received_events","type":"User","site_admin":false},"repo":{"id":33953307,"name":"UIforETW","full_name":"ariccio/UIforETW","owner":{"login":"ariccio","id":2142308,"avatar_url":"https://avatars.githubusercontent.com/u/2142308?v=3","gravatar_id":"","url":"https://api.github.com/users/ariccio","html_url":"https://github.com/ariccio","followers_url":"https://api.github.com/users/ariccio/followers","following_url":"https://api.github.com/users/ariccio/following{/other_user}","gists_url":"https://api.github.com/users/ariccio/gists{/gist_id}","starred_url":"https://api.github.com/users/ariccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariccio/subscriptions","organizations_url":"https://api.github.com/users/ariccio/orgs","repos_url":"https://api.github.com/users/ariccio/repos","events_url":"https://api.github.com/users/ariccio/events{/privacy}","received_events_url":"https://api.github.com/users/ariccio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ariccio/UIforETW","description":"User interface for recording and managing ETW traces","fork":true,"url":"https://api.github.com/repos/ariccio/UIforETW","forks_url":"https://api.github.com/repos/ariccio/UIforETW/forks","keys_url":"https://api.github.com/repos/ariccio/UIforETW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ariccio/UIforETW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ariccio/UIforETW/teams","hooks_url":"https://api.github.com/repos/ariccio/UIforETW/hooks","issue_events_url":"https://api.github.com/repos/ariccio/UIforETW/issues/events{/number}","events_url":"https://api.github.com/repos/ariccio/UIforETW/events","assignees_url":"https://api.github.com/repos/ariccio/UIforETW/assignees{/user}","branches_url":"https://api.github.com/repos/ariccio/UIforETW/branches{/branch}","tags_url":"https://api.github.com/repos/ariccio/UIforETW/tags","blobs_url":"https://api.github.com/repos/ariccio/UIforETW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ariccio/UIforETW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ariccio/UIforETW/git/refs{/sha}","trees_url":"https://api.github.com/repos/ariccio/UIforETW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ariccio/UIforETW/statuses/{sha}","languages_url":"https://api.github.com/repos/ariccio/UIforETW/languages","stargazers_url":"https://api.github.com/repos/ariccio/UIforETW/stargazers","contributors_url":"https://api.github.com/repos/ariccio/UIforETW/contributors","subscribers_url":"https://api.github.com/repos/ariccio/UIforETW/subscribers","subscription_url":"https://api.github.com/repos/ariccio/UIforETW/subscription","commits_url":"https://api.github.com/repos/ariccio/UIforETW/commits{/sha}","git_commits_url":"https://api.github.com/repos/ariccio/UIforETW/git/commits{/sha}","comments_url":"https://api.github.com/repos/ariccio/UIforETW/comments{/number}","issue_comment_url":"https://api.github.com/repos/ariccio/UIforETW/issues/comments{/number}","contents_url":"https://api.github.com/repos/ariccio/UIforETW/contents/{+path}","compare_url":"https://api.github.com/repos/ariccio/UIforETW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ariccio/UIforETW/merges","archive_url":"https://api.github.com/repos/ariccio/UIforETW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ariccio/UIforETW/downloads","issues_url":"https://api.github.com/repos/ariccio/UIforETW/issues{/number}","pulls_url":"https://api.github.com/repos/ariccio/UIforETW/pulls{/number}","milestones_url":"https://api.github.com/repos/ariccio/UIforETW/milestones{/number}","notifications_url":"https://api.github.com/repos/ariccio/UIforETW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ariccio/UIforETW/labels{/name}","releases_url":"https://api.github.com/repos/ariccio/UIforETW/releases{/id}","created_at":"2015-04-14T19:47:38Z","updated_at":"2015-05-05T07:00:31Z","pushed_at":"2015-05-14T02:41:13Z","git_url":"git://github.com/ariccio/UIforETW.git","ssh_url":"git@github.com:ariccio/UIforETW.git","clone_url":"https://github.com/ariccio/UIforETW.git","svn_url":"https://github.com/ariccio/UIforETW","homepage":"","size":2965,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"360d4f333c2bf034ab8603a71500224afc22f398","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":33694418,"name":"UIforETW","full_name":"google/UIforETW","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/UIforETW","description":"User interface for recording and managing ETW traces","fork":false,"url":"https://api.github.com/repos/google/UIforETW","forks_url":"https://api.github.com/repos/google/UIforETW/forks","keys_url":"https://api.github.com/repos/google/UIforETW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/UIforETW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/UIforETW/teams","hooks_url":"https://api.github.com/repos/google/UIforETW/hooks","issue_events_url":"https://api.github.com/repos/google/UIforETW/issues/events{/number}","events_url":"https://api.github.com/repos/google/UIforETW/events","assignees_url":"https://api.github.com/repos/google/UIforETW/assignees{/user}","branches_url":"https://api.github.com/repos/google/UIforETW/branches{/branch}","tags_url":"https://api.github.com/repos/google/UIforETW/tags","blobs_url":"https://api.github.com/repos/google/UIforETW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/UIforETW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/UIforETW/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/UIforETW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/UIforETW/statuses/{sha}","languages_url":"https://api.github.com/repos/google/UIforETW/languages","stargazers_url":"https://api.github.com/repos/google/UIforETW/stargazers","contributors_url":"https://api.github.com/repos/google/UIforETW/contributors","subscribers_url":"https://api.github.com/repos/google/UIforETW/subscribers","subscription_url":"https://api.github.com/repos/google/UIforETW/subscription","commits_url":"https://api.github.com/repos/google/UIforETW/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/UIforETW/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/UIforETW/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/UIforETW/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/UIforETW/contents/{+path}","compare_url":"https://api.github.com/repos/google/UIforETW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/UIforETW/merges","archive_url":"https://api.github.com/repos/google/UIforETW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/UIforETW/downloads","issues_url":"https://api.github.com/repos/google/UIforETW/issues{/number}","pulls_url":"https://api.github.com/repos/google/UIforETW/pulls{/number}","milestones_url":"https://api.github.com/repos/google/UIforETW/milestones{/number}","notifications_url":"https://api.github.com/repos/google/UIforETW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/UIforETW/labels{/name}","releases_url":"https://api.github.com/repos/google/UIforETW/releases{/id}","created_at":"2015-04-09T21:46:04Z","updated_at":"2015-05-07T11:19:00Z","pushed_at":"2015-05-14T05:35:44Z","git_url":"git://github.com/google/UIforETW.git","ssh_url":"git@github.com:google/UIforETW.git","clone_url":"https://github.com/google/UIforETW.git","svn_url":"https://github.com/google/UIforETW","homepage":"https://randomascii.wordpress.com/2015/04/14/uiforetw-windows-performance-made-easier/","size":3188,"stargazers_count":58,"watchers_count":58,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":9,"forks":6,"open_issues":9,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/UIforETW/pulls/33"},"html":{"href":"https://github.com/google/UIforETW/pull/33"},"issue":{"href":"https://api.github.com/repos/google/UIforETW/issues/33"},"comments":{"href":"https://api.github.com/repos/google/UIforETW/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/google/UIforETW/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/google/UIforETW/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/UIforETW/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/google/UIforETW/statuses/06337d1ca7a26317dd43e8d4e6278e16132c3615"}}}}