{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/comments/34065809","id":34065809,"diff_hunk":"@@ -164,7 +163,7 @@\n       plugin = LogStash::Inputs::Jdbc.new(mixin_settings.merge(settings))\n       plugin.register\n \n-      insist { File.exists?(settings[\"last_run_metadata_path\"]) }\n+      expect(File).not_to(be_exists(settings[\"last_run_metadata_path\"]))","path":"spec/inputs/jdbc_spec.rb","position":205,"original_position":205,"commit_id":"0329219b3af3f3ee4f70ce8d0ea2b343272939ff","original_commit_id":"0329219b3af3f3ee4f70ce8d0ea2b343272939ff","user":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"body":"thanks! I like that\r\n\r\ncc @jordansissel ","created_at":"2015-07-07T17:23:12Z","updated_at":"2015-07-07T17:23:12Z","html_url":"https://github.com/logstash-plugins/logstash-input-jdbc/pull/14#discussion_r34065809","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/comments/34065809"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-jdbc/pull/14#discussion_r34065809"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/14","id":39337393,"html_url":"https://github.com/logstash-plugins/logstash-input-jdbc/pull/14","diff_url":"https://github.com/logstash-plugins/logstash-input-jdbc/pull/14.diff","patch_url":"https://github.com/logstash-plugins/logstash-input-jdbc/pull/14.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/issues/14","number":14,"state":"open","locked":false,"title":"rspec updates and cleanup","user":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"body":"In response to a lapse in previous reviews :) here goes a PR for updating the tests to remove `insist` and try and be more DRY.","created_at":"2015-07-07T05:58:08Z","updated_at":"2015-07-07T17:23:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c534141a41a777dcde56d94b14b846743b583e10","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/14/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/14/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/issues/14/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/statuses/0329219b3af3f3ee4f70ce8d0ea2b343272939ff","head":{"label":"talevy:fix/clean-rspec","ref":"fix/clean-rspec","sha":"0329219b3af3f3ee4f70ce8d0ea2b343272939ff","user":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"repo":{"id":36683244,"name":"logstash-input-jdbc","full_name":"talevy/logstash-input-jdbc","owner":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/talevy/logstash-input-jdbc","description":"Logstash Plugin for JDBC Inputs","fork":true,"url":"https://api.github.com/repos/talevy/logstash-input-jdbc","forks_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/forks","keys_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/teams","hooks_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/hooks","issue_events_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/issues/events{/number}","events_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/events","assignees_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/assignees{/user}","branches_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/branches{/branch}","tags_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/tags","blobs_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/languages","stargazers_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/stargazers","contributors_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/contributors","subscribers_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/subscribers","subscription_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/subscription","commits_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/contents/{+path}","compare_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/merges","archive_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/downloads","issues_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/issues{/number}","pulls_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/labels{/name}","releases_url":"https://api.github.com/repos/talevy/logstash-input-jdbc/releases{/id}","created_at":"2015-06-01T19:21:13Z","updated_at":"2015-06-01T19:21:13Z","pushed_at":"2015-07-07T05:57:12Z","git_url":"git://github.com/talevy/logstash-input-jdbc.git","ssh_url":"git@github.com:talevy/logstash-input-jdbc.git","clone_url":"https://github.com/talevy/logstash-input-jdbc.git","svn_url":"https://github.com/talevy/logstash-input-jdbc","homepage":null,"size":113,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"74b18e907f81207d35a71f35bfc114c1d81d52e6","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":31391612,"name":"logstash-input-jdbc","full_name":"logstash-plugins/logstash-input-jdbc","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-input-jdbc","description":"Logstash Plugin for JDBC Inputs","fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/releases{/id}","created_at":"2015-02-26T22:12:38Z","updated_at":"2015-06-28T06:42:52Z","pushed_at":"2015-07-07T05:58:08Z","git_url":"git://github.com/logstash-plugins/logstash-input-jdbc.git","ssh_url":"git@github.com:logstash-plugins/logstash-input-jdbc.git","clone_url":"https://github.com/logstash-plugins/logstash-input-jdbc.git","svn_url":"https://github.com/logstash-plugins/logstash-input-jdbc","homepage":null,"size":176,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/14"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-jdbc/pull/14"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/issues/14"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-jdbc/statuses/0329219b3af3f3ee4f70ce8d0ea2b343272939ff"}}}}