{"action":"opened","number":3929,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/3929","id":39165981,"html_url":"https://github.com/netty/netty/pull/3929","diff_url":"https://github.com/netty/netty/pull/3929.diff","patch_url":"https://github.com/netty/netty/pull/3929.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/3929","number":3929,"state":"open","locked":false,"title":"Make sure bytesToReturn > 0 before calling flowController.consumeByte…","user":{"login":"Apache9","id":4958168,"avatar_url":"https://avatars.githubusercontent.com/u/4958168?v=3","gravatar_id":"","url":"https://api.github.com/users/Apache9","html_url":"https://github.com/Apache9","followers_url":"https://api.github.com/users/Apache9/followers","following_url":"https://api.github.com/users/Apache9/following{/other_user}","gists_url":"https://api.github.com/users/Apache9/gists{/gist_id}","starred_url":"https://api.github.com/users/Apache9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apache9/subscriptions","organizations_url":"https://api.github.com/users/Apache9/orgs","repos_url":"https://api.github.com/users/Apache9/repos","events_url":"https://api.github.com/users/Apache9/events{/privacy}","received_events_url":"https://api.github.com/users/Apache9/received_events","type":"User","site_admin":false},"body":"…s when ignoring frame in FrameReadListener.onDataRead.\r\n\r\nMotivation:\r\n\r\nSometimes people use a data frame with length 0 to end a stream(such as jetty http2-server). So it is possible that data.readableBytes and padding are all 0 for a data frame, and cause a IllegalArgumentException when calling flowController.consumeBytes.\r\n\r\nModifications:\r\n\r\nAdd a 'bytesToReturn > 0' check before calling flowController.consumeBytes.\r\n\r\nResult:\r\n\r\nFix IllegalArgumentException.","created_at":"2015-07-03T10:59:57Z","updated_at":"2015-07-03T10:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/3929/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/3929/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/3929/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/08510fefaa19c6b9d83cdb4022fb4072dea1cca6","head":{"label":"Apache9:IAE","ref":"IAE","sha":"08510fefaa19c6b9d83cdb4022fb4072dea1cca6","user":{"login":"Apache9","id":4958168,"avatar_url":"https://avatars.githubusercontent.com/u/4958168?v=3","gravatar_id":"","url":"https://api.github.com/users/Apache9","html_url":"https://github.com/Apache9","followers_url":"https://api.github.com/users/Apache9/followers","following_url":"https://api.github.com/users/Apache9/following{/other_user}","gists_url":"https://api.github.com/users/Apache9/gists{/gist_id}","starred_url":"https://api.github.com/users/Apache9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apache9/subscriptions","organizations_url":"https://api.github.com/users/Apache9/orgs","repos_url":"https://api.github.com/users/Apache9/repos","events_url":"https://api.github.com/users/Apache9/events{/privacy}","received_events_url":"https://api.github.com/users/Apache9/received_events","type":"User","site_admin":false},"repo":{"id":37699053,"name":"netty","full_name":"Apache9/netty","owner":{"login":"Apache9","id":4958168,"avatar_url":"https://avatars.githubusercontent.com/u/4958168?v=3","gravatar_id":"","url":"https://api.github.com/users/Apache9","html_url":"https://github.com/Apache9","followers_url":"https://api.github.com/users/Apache9/followers","following_url":"https://api.github.com/users/Apache9/following{/other_user}","gists_url":"https://api.github.com/users/Apache9/gists{/gist_id}","starred_url":"https://api.github.com/users/Apache9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apache9/subscriptions","organizations_url":"https://api.github.com/users/Apache9/orgs","repos_url":"https://api.github.com/users/Apache9/repos","events_url":"https://api.github.com/users/Apache9/events{/privacy}","received_events_url":"https://api.github.com/users/Apache9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Apache9/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/Apache9/netty","forks_url":"https://api.github.com/repos/Apache9/netty/forks","keys_url":"https://api.github.com/repos/Apache9/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Apache9/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Apache9/netty/teams","hooks_url":"https://api.github.com/repos/Apache9/netty/hooks","issue_events_url":"https://api.github.com/repos/Apache9/netty/issues/events{/number}","events_url":"https://api.github.com/repos/Apache9/netty/events","assignees_url":"https://api.github.com/repos/Apache9/netty/assignees{/user}","branches_url":"https://api.github.com/repos/Apache9/netty/branches{/branch}","tags_url":"https://api.github.com/repos/Apache9/netty/tags","blobs_url":"https://api.github.com/repos/Apache9/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Apache9/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Apache9/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/Apache9/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Apache9/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/Apache9/netty/languages","stargazers_url":"https://api.github.com/repos/Apache9/netty/stargazers","contributors_url":"https://api.github.com/repos/Apache9/netty/contributors","subscribers_url":"https://api.github.com/repos/Apache9/netty/subscribers","subscription_url":"https://api.github.com/repos/Apache9/netty/subscription","commits_url":"https://api.github.com/repos/Apache9/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/Apache9/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/Apache9/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/Apache9/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/Apache9/netty/contents/{+path}","compare_url":"https://api.github.com/repos/Apache9/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Apache9/netty/merges","archive_url":"https://api.github.com/repos/Apache9/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Apache9/netty/downloads","issues_url":"https://api.github.com/repos/Apache9/netty/issues{/number}","pulls_url":"https://api.github.com/repos/Apache9/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/Apache9/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/Apache9/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Apache9/netty/labels{/name}","releases_url":"https://api.github.com/repos/Apache9/netty/releases{/id}","created_at":"2015-06-19T03:16:05Z","updated_at":"2015-06-19T03:16:13Z","pushed_at":"2015-07-03T10:51:18Z","git_url":"git://github.com/Apache9/netty.git","ssh_url":"git@github.com:Apache9/netty.git","clone_url":"https://github.com/Apache9/netty.git","svn_url":"https://github.com/Apache9/netty","homepage":"http://netty.io/","size":43484,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:master","ref":"master","sha":"c15aa42d3201f9183ee9f2d89b32f6e808dc953e","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2015-07-03T10:03:46Z","pushed_at":"2015-07-03T04:18:59Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":129191,"stargazers_count":4856,"watchers_count":4856,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2413,"mirror_url":null,"open_issues_count":293,"forks":2413,"open_issues":293,"watchers":4856,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/3929"},"html":{"href":"https://github.com/netty/netty/pull/3929"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/3929"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/3929/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/3929/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/3929/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/08510fefaa19c6b9d83cdb4022fb4072dea1cca6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}