{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/315","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/315/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/315/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/315/events","html_url":"https://github.com/ocaml/ocaml/pull/315","id":119193962,"number":315,"title":"\"All clauses guarded\" warning (25) now part of standard \"non exhaustive\" warning (8)","user":{"login":"alainfrisch","id":3305274,"avatar_url":"https://avatars.githubusercontent.com/u/3305274?v=3","gravatar_id":"","url":"https://api.github.com/users/alainfrisch","html_url":"https://github.com/alainfrisch","followers_url":"https://api.github.com/users/alainfrisch/followers","following_url":"https://api.github.com/users/alainfrisch/following{/other_user}","gists_url":"https://api.github.com/users/alainfrisch/gists{/gist_id}","starred_url":"https://api.github.com/users/alainfrisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alainfrisch/subscriptions","organizations_url":"https://api.github.com/users/alainfrisch/orgs","repos_url":"https://api.github.com/users/alainfrisch/repos","events_url":"https://api.github.com/users/alainfrisch/events{/privacy}","received_events_url":"https://api.github.com/users/alainfrisch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-11-27T13:11:15Z","updated_at":"2015-11-30T10:14:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/315","html_url":"https://github.com/ocaml/ocaml/pull/315","diff_url":"https://github.com/ocaml/ocaml/pull/315.diff","patch_url":"https://github.com/ocaml/ocaml/pull/315.patch"},"body":"See http://caml.inria.fr/mantis/view.php?id=7059,  http://caml.inria.fr/mantis/view.php?id=6438 .\r\n\r\nPreviously, one could compile with warning 8 enabled and still get a runtime error because of a non-exhaustive warning (all clauses guarded raised warning 25 but not warning 8).\r\n\r\nA non-consensual aspect of this PR might be that I keep using two different constructors in Warnings, both mapped to number 8.  I don't see anything wrong with it, though."},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/160586904","html_url":"https://github.com/ocaml/ocaml/pull/315#issuecomment-160586904","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/315","id":160586904,"user":{"login":"alainfrisch","id":3305274,"avatar_url":"https://avatars.githubusercontent.com/u/3305274?v=3","gravatar_id":"","url":"https://api.github.com/users/alainfrisch","html_url":"https://github.com/alainfrisch","followers_url":"https://api.github.com/users/alainfrisch/followers","following_url":"https://api.github.com/users/alainfrisch/following{/other_user}","gists_url":"https://api.github.com/users/alainfrisch/gists{/gist_id}","starred_url":"https://api.github.com/users/alainfrisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alainfrisch/subscriptions","organizations_url":"https://api.github.com/users/alainfrisch/orgs","repos_url":"https://api.github.com/users/alainfrisch/repos","events_url":"https://api.github.com/users/alainfrisch/events{/privacy}","received_events_url":"https://api.github.com/users/alainfrisch/received_events","type":"User","site_admin":false},"created_at":"2015-11-30T10:14:01Z","updated_at":"2015-11-30T10:14:01Z","body":"Thanks, this is clearer.  So you are not arguing against the merger of warning 8 and 25, only about improving the text to show a certain counter-example.  I propose to accept the current PR and postpone the discussion.  FWIW, I don't like the \"binary\" logic you propose:  if some clauses are non-guarded, it would still be useful to report certain counter-examples (i.e. values which are not matched by any clause even without taking their guard into account); I guess the argument against this approach is that running the check twice can be costly."}}