{"action":"created","comment":{"url":"https://api.github.com/repos/beberlei/metrics/pulls/comments/42602939","id":42602939,"diff_hunk":"@@ -71,15 +97,20 @@ public function measure($variable, $value)\n         );\n     }\n \n+    /**\n+     * {@inheritDoc}\n+     */\n     public function flush()\n     {\n         if (!$this->data['gauges'] && !$this->data['counters']) {\n             return;\n         }\n \n+        $authToken = base64_encode($this->username.':'.$this->password);","path":"src/Beberlei/Metrics/Collector/Librato.php","position":84,"original_position":84,"commit_id":"ee65dcd48f2e5152dd11454a2c63825c6299d875","original_commit_id":"ee65dcd48f2e5152dd11454a2c63825c6299d875","user":{"login":"eexit","id":57098,"avatar_url":"https://avatars.githubusercontent.com/u/57098?v=3","gravatar_id":"","url":"https://api.github.com/users/eexit","html_url":"https://github.com/eexit","followers_url":"https://api.github.com/users/eexit/followers","following_url":"https://api.github.com/users/eexit/following{/other_user}","gists_url":"https://api.github.com/users/eexit/gists{/gist_id}","starred_url":"https://api.github.com/users/eexit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eexit/subscriptions","organizations_url":"https://api.github.com/users/eexit/orgs","repos_url":"https://api.github.com/users/eexit/repos","events_url":"https://api.github.com/users/eexit/events{/privacy}","received_events_url":"https://api.github.com/users/eexit/received_events","type":"User","site_admin":false},"body":"Easier to debug, avoid having too many things in a single line of code that's already concatenating two strings.","created_at":"2015-10-21T09:44:11Z","updated_at":"2015-10-21T09:44:11Z","html_url":"https://github.com/beberlei/metrics/pull/38#discussion_r42602939","pull_request_url":"https://api.github.com/repos/beberlei/metrics/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/beberlei/metrics/pulls/comments/42602939"},"html":{"href":"https://github.com/beberlei/metrics/pull/38#discussion_r42602939"},"pull_request":{"href":"https://api.github.com/repos/beberlei/metrics/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/beberlei/metrics/pulls/38","id":48085993,"html_url":"https://github.com/beberlei/metrics/pull/38","diff_url":"https://github.com/beberlei/metrics/pull/38.diff","patch_url":"https://github.com/beberlei/metrics/pull/38.patch","issue_url":"https://api.github.com/repos/beberlei/metrics/issues/38","number":38,"state":"open","locked":false,"title":"Better interface and minor improvements","user":{"login":"eexit","id":57098,"avatar_url":"https://avatars.githubusercontent.com/u/57098?v=3","gravatar_id":"","url":"https://api.github.com/users/eexit","html_url":"https://github.com/eexit","followers_url":"https://api.github.com/users/eexit/followers","following_url":"https://api.github.com/users/eexit/following{/other_user}","gists_url":"https://api.github.com/users/eexit/gists{/gist_id}","starred_url":"https://api.github.com/users/eexit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eexit/subscriptions","organizations_url":"https://api.github.com/users/eexit/orgs","repos_url":"https://api.github.com/users/eexit/repos","events_url":"https://api.github.com/users/eexit/events{/privacy}","received_events_url":"https://api.github.com/users/eexit/received_events","type":"User","site_admin":false},"body":"Hi there,\r\n\r\nThank you for this OS project which we use in different projects. I took some time to improve the overall lib public interface in order to clarify its integration.\r\n\r\n## Done\r\n- [x] Added `GaugeableCollector` interface\r\n- [x] Resets of `InfluxDB::$data` in `InfluxDB::flush()`\r\n- [x] Comment consistency\r\n- [x] Double-quote converted into single-quote when possible\r\n- [x] Small code reformatting\r\n\r\nHope this PR will be a small step to better the project.\r\n\r\nThanks!","created_at":"2015-10-19T15:23:05Z","updated_at":"2015-10-21T09:44:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebabb7c1518bcdf490ca6357f393e0864d091b85","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/beberlei/metrics/pulls/38/commits","review_comments_url":"https://api.github.com/repos/beberlei/metrics/pulls/38/comments","review_comment_url":"https://api.github.com/repos/beberlei/metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/beberlei/metrics/issues/38/comments","statuses_url":"https://api.github.com/repos/beberlei/metrics/statuses/ee65dcd48f2e5152dd11454a2c63825c6299d875","head":{"label":"eexit:master","ref":"master","sha":"ee65dcd48f2e5152dd11454a2c63825c6299d875","user":{"login":"eexit","id":57098,"avatar_url":"https://avatars.githubusercontent.com/u/57098?v=3","gravatar_id":"","url":"https://api.github.com/users/eexit","html_url":"https://github.com/eexit","followers_url":"https://api.github.com/users/eexit/followers","following_url":"https://api.github.com/users/eexit/following{/other_user}","gists_url":"https://api.github.com/users/eexit/gists{/gist_id}","starred_url":"https://api.github.com/users/eexit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eexit/subscriptions","organizations_url":"https://api.github.com/users/eexit/orgs","repos_url":"https://api.github.com/users/eexit/repos","events_url":"https://api.github.com/users/eexit/events{/privacy}","received_events_url":"https://api.github.com/users/eexit/received_events","type":"User","site_admin":false},"repo":{"id":44536923,"name":"metrics","full_name":"eexit/metrics","owner":{"login":"eexit","id":57098,"avatar_url":"https://avatars.githubusercontent.com/u/57098?v=3","gravatar_id":"","url":"https://api.github.com/users/eexit","html_url":"https://github.com/eexit","followers_url":"https://api.github.com/users/eexit/followers","following_url":"https://api.github.com/users/eexit/following{/other_user}","gists_url":"https://api.github.com/users/eexit/gists{/gist_id}","starred_url":"https://api.github.com/users/eexit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eexit/subscriptions","organizations_url":"https://api.github.com/users/eexit/orgs","repos_url":"https://api.github.com/users/eexit/repos","events_url":"https://api.github.com/users/eexit/events{/privacy}","received_events_url":"https://api.github.com/users/eexit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eexit/metrics","description":"Simple library that abstracts different metrics collectors. I find this necessary to have a consistent and simple metrics (functional) API that doesn't cause vendor lock-in.","fork":true,"url":"https://api.github.com/repos/eexit/metrics","forks_url":"https://api.github.com/repos/eexit/metrics/forks","keys_url":"https://api.github.com/repos/eexit/metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eexit/metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eexit/metrics/teams","hooks_url":"https://api.github.com/repos/eexit/metrics/hooks","issue_events_url":"https://api.github.com/repos/eexit/metrics/issues/events{/number}","events_url":"https://api.github.com/repos/eexit/metrics/events","assignees_url":"https://api.github.com/repos/eexit/metrics/assignees{/user}","branches_url":"https://api.github.com/repos/eexit/metrics/branches{/branch}","tags_url":"https://api.github.com/repos/eexit/metrics/tags","blobs_url":"https://api.github.com/repos/eexit/metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eexit/metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eexit/metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/eexit/metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eexit/metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/eexit/metrics/languages","stargazers_url":"https://api.github.com/repos/eexit/metrics/stargazers","contributors_url":"https://api.github.com/repos/eexit/metrics/contributors","subscribers_url":"https://api.github.com/repos/eexit/metrics/subscribers","subscription_url":"https://api.github.com/repos/eexit/metrics/subscription","commits_url":"https://api.github.com/repos/eexit/metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/eexit/metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/eexit/metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/eexit/metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/eexit/metrics/contents/{+path}","compare_url":"https://api.github.com/repos/eexit/metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eexit/metrics/merges","archive_url":"https://api.github.com/repos/eexit/metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eexit/metrics/downloads","issues_url":"https://api.github.com/repos/eexit/metrics/issues{/number}","pulls_url":"https://api.github.com/repos/eexit/metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/eexit/metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/eexit/metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eexit/metrics/labels{/name}","releases_url":"https://api.github.com/repos/eexit/metrics/releases{/id}","created_at":"2015-10-19T13:32:06Z","updated_at":"2015-10-19T13:32:07Z","pushed_at":"2015-10-20T20:53:45Z","git_url":"git://github.com/eexit/metrics.git","ssh_url":"git@github.com:eexit/metrics.git","clone_url":"https://github.com/eexit/metrics.git","svn_url":"https://github.com/eexit/metrics","homepage":null,"size":153,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"beberlei:master","ref":"master","sha":"2a2133994d707d0b06548ef0be5ab7e140bbe054","user":{"login":"beberlei","id":26936,"avatar_url":"https://avatars.githubusercontent.com/u/26936?v=3","gravatar_id":"","url":"https://api.github.com/users/beberlei","html_url":"https://github.com/beberlei","followers_url":"https://api.github.com/users/beberlei/followers","following_url":"https://api.github.com/users/beberlei/following{/other_user}","gists_url":"https://api.github.com/users/beberlei/gists{/gist_id}","starred_url":"https://api.github.com/users/beberlei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beberlei/subscriptions","organizations_url":"https://api.github.com/users/beberlei/orgs","repos_url":"https://api.github.com/users/beberlei/repos","events_url":"https://api.github.com/users/beberlei/events{/privacy}","received_events_url":"https://api.github.com/users/beberlei/received_events","type":"User","site_admin":false},"repo":{"id":4423633,"name":"metrics","full_name":"beberlei/metrics","owner":{"login":"beberlei","id":26936,"avatar_url":"https://avatars.githubusercontent.com/u/26936?v=3","gravatar_id":"","url":"https://api.github.com/users/beberlei","html_url":"https://github.com/beberlei","followers_url":"https://api.github.com/users/beberlei/followers","following_url":"https://api.github.com/users/beberlei/following{/other_user}","gists_url":"https://api.github.com/users/beberlei/gists{/gist_id}","starred_url":"https://api.github.com/users/beberlei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beberlei/subscriptions","organizations_url":"https://api.github.com/users/beberlei/orgs","repos_url":"https://api.github.com/users/beberlei/repos","events_url":"https://api.github.com/users/beberlei/events{/privacy}","received_events_url":"https://api.github.com/users/beberlei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beberlei/metrics","description":"Simple library that abstracts different metrics collectors. I find this necessary to have a consistent and simple metrics (functional) API that doesn't cause vendor lock-in.","fork":false,"url":"https://api.github.com/repos/beberlei/metrics","forks_url":"https://api.github.com/repos/beberlei/metrics/forks","keys_url":"https://api.github.com/repos/beberlei/metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beberlei/metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beberlei/metrics/teams","hooks_url":"https://api.github.com/repos/beberlei/metrics/hooks","issue_events_url":"https://api.github.com/repos/beberlei/metrics/issues/events{/number}","events_url":"https://api.github.com/repos/beberlei/metrics/events","assignees_url":"https://api.github.com/repos/beberlei/metrics/assignees{/user}","branches_url":"https://api.github.com/repos/beberlei/metrics/branches{/branch}","tags_url":"https://api.github.com/repos/beberlei/metrics/tags","blobs_url":"https://api.github.com/repos/beberlei/metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beberlei/metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beberlei/metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/beberlei/metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beberlei/metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/beberlei/metrics/languages","stargazers_url":"https://api.github.com/repos/beberlei/metrics/stargazers","contributors_url":"https://api.github.com/repos/beberlei/metrics/contributors","subscribers_url":"https://api.github.com/repos/beberlei/metrics/subscribers","subscription_url":"https://api.github.com/repos/beberlei/metrics/subscription","commits_url":"https://api.github.com/repos/beberlei/metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/beberlei/metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/beberlei/metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/beberlei/metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/beberlei/metrics/contents/{+path}","compare_url":"https://api.github.com/repos/beberlei/metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beberlei/metrics/merges","archive_url":"https://api.github.com/repos/beberlei/metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beberlei/metrics/downloads","issues_url":"https://api.github.com/repos/beberlei/metrics/issues{/number}","pulls_url":"https://api.github.com/repos/beberlei/metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/beberlei/metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/beberlei/metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beberlei/metrics/labels{/name}","releases_url":"https://api.github.com/repos/beberlei/metrics/releases{/id}","created_at":"2012-05-23T18:20:36Z","updated_at":"2015-10-20T13:47:24Z","pushed_at":"2015-10-20T20:53:45Z","git_url":"git://github.com/beberlei/metrics.git","ssh_url":"git@github.com:beberlei/metrics.git","clone_url":"https://github.com/beberlei/metrics.git","svn_url":"https://github.com/beberlei/metrics","homepage":null,"size":499,"stargazers_count":134,"watchers_count":134,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":3,"forks":16,"open_issues":3,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/beberlei/metrics/pulls/38"},"html":{"href":"https://github.com/beberlei/metrics/pull/38"},"issue":{"href":"https://api.github.com/repos/beberlei/metrics/issues/38"},"comments":{"href":"https://api.github.com/repos/beberlei/metrics/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/beberlei/metrics/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/beberlei/metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/beberlei/metrics/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/beberlei/metrics/statuses/ee65dcd48f2e5152dd11454a2c63825c6299d875"}}}}