{"action":"closed","number":768,"pull_request":{"url":"https://api.github.com/repos/google/web-starter-kit/pulls/768","id":49276573,"html_url":"https://github.com/google/web-starter-kit/pull/768","diff_url":"https://github.com/google/web-starter-kit/pull/768.diff","patch_url":"https://github.com/google/web-starter-kit/pull/768.patch","issue_url":"https://api.github.com/repos/google/web-starter-kit/issues/768","number":768,"state":"closed","locked":false,"title":"Use different ports for serve & serve:dist","user":{"login":"jeffposnick","id":1749548,"avatar_url":"https://avatars.githubusercontent.com/u/1749548?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffposnick","html_url":"https://github.com/jeffposnick","followers_url":"https://api.github.com/users/jeffposnick/followers","following_url":"https://api.github.com/users/jeffposnick/following{/other_user}","gists_url":"https://api.github.com/users/jeffposnick/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffposnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffposnick/subscriptions","organizations_url":"https://api.github.com/users/jeffposnick/orgs","repos_url":"https://api.github.com/users/jeffposnick/repos","events_url":"https://api.github.com/users/jeffposnick/events{/privacy}","received_events_url":"https://api.github.com/users/jeffposnick/received_events","type":"User","site_admin":false},"body":"R: @addyosmani \r\n\r\nThis PR adds explicit port choices of 3000 for the `serve` task and 3001 for the `serve:dist` task. This ensures that the \"real\" service worker that's registered while running `serve:dist` doesn't impact the dev environment, in which serving fresh responses directly from the disk is desired. Service worker registrations scopes are limited by the origin, including the port number.\r\n\r\nWe did something similar for PSK.","created_at":"2015-10-30T14:36:49Z","updated_at":"2015-10-30T17:48:20Z","closed_at":"2015-10-30T17:48:20Z","merged_at":"2015-10-30T17:48:20Z","merge_commit_sha":"6a0071ba570243506cae1486834f7d7ca4d3e054","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/web-starter-kit/pulls/768/commits","review_comments_url":"https://api.github.com/repos/google/web-starter-kit/pulls/768/comments","review_comment_url":"https://api.github.com/repos/google/web-starter-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/web-starter-kit/issues/768/comments","statuses_url":"https://api.github.com/repos/google/web-starter-kit/statuses/5d02814c5ff3abc98248354db6ed9760fc627aee","head":{"label":"jeffposnick:dev-dist-ports","ref":"dev-dist-ports","sha":"5d02814c5ff3abc98248354db6ed9760fc627aee","user":{"login":"jeffposnick","id":1749548,"avatar_url":"https://avatars.githubusercontent.com/u/1749548?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffposnick","html_url":"https://github.com/jeffposnick","followers_url":"https://api.github.com/users/jeffposnick/followers","following_url":"https://api.github.com/users/jeffposnick/following{/other_user}","gists_url":"https://api.github.com/users/jeffposnick/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffposnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffposnick/subscriptions","organizations_url":"https://api.github.com/users/jeffposnick/orgs","repos_url":"https://api.github.com/users/jeffposnick/repos","events_url":"https://api.github.com/users/jeffposnick/events{/privacy}","received_events_url":"https://api.github.com/users/jeffposnick/received_events","type":"User","site_admin":false},"repo":{"id":29696943,"name":"web-starter-kit","full_name":"jeffposnick/web-starter-kit","owner":{"login":"jeffposnick","id":1749548,"avatar_url":"https://avatars.githubusercontent.com/u/1749548?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffposnick","html_url":"https://github.com/jeffposnick","followers_url":"https://api.github.com/users/jeffposnick/followers","following_url":"https://api.github.com/users/jeffposnick/following{/other_user}","gists_url":"https://api.github.com/users/jeffposnick/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffposnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffposnick/subscriptions","organizations_url":"https://api.github.com/users/jeffposnick/orgs","repos_url":"https://api.github.com/users/jeffposnick/repos","events_url":"https://api.github.com/users/jeffposnick/events{/privacy}","received_events_url":"https://api.github.com/users/jeffposnick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffposnick/web-starter-kit","description":"Google Web Starter Kit (Beta)","fork":true,"url":"https://api.github.com/repos/jeffposnick/web-starter-kit","forks_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/forks","keys_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/teams","hooks_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/hooks","issue_events_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/events","assignees_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/tags","blobs_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/languages","stargazers_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/stargazers","contributors_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/contributors","subscribers_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/subscribers","subscription_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/subscription","commits_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/merges","archive_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/downloads","issues_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/jeffposnick/web-starter-kit/releases{/id}","created_at":"2015-01-22T19:50:10Z","updated_at":"2015-01-22T19:50:10Z","pushed_at":"2015-10-30T17:46:13Z","git_url":"git://github.com/jeffposnick/web-starter-kit.git","ssh_url":"git@github.com:jeffposnick/web-starter-kit.git","clone_url":"https://github.com/jeffposnick/web-starter-kit.git","svn_url":"https://github.com/jeffposnick/web-starter-kit","homepage":"http://developers.google.com/web/starter-kit","size":12241,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"135e611311f7c54ca8f522881114184d63df0c3d","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":18511024,"name":"web-starter-kit","full_name":"google/web-starter-kit","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/web-starter-kit","description":"Google Web Starter Kit","fork":false,"url":"https://api.github.com/repos/google/web-starter-kit","forks_url":"https://api.github.com/repos/google/web-starter-kit/forks","keys_url":"https://api.github.com/repos/google/web-starter-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/web-starter-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/web-starter-kit/teams","hooks_url":"https://api.github.com/repos/google/web-starter-kit/hooks","issue_events_url":"https://api.github.com/repos/google/web-starter-kit/issues/events{/number}","events_url":"https://api.github.com/repos/google/web-starter-kit/events","assignees_url":"https://api.github.com/repos/google/web-starter-kit/assignees{/user}","branches_url":"https://api.github.com/repos/google/web-starter-kit/branches{/branch}","tags_url":"https://api.github.com/repos/google/web-starter-kit/tags","blobs_url":"https://api.github.com/repos/google/web-starter-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/web-starter-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/web-starter-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/web-starter-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/web-starter-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/google/web-starter-kit/languages","stargazers_url":"https://api.github.com/repos/google/web-starter-kit/stargazers","contributors_url":"https://api.github.com/repos/google/web-starter-kit/contributors","subscribers_url":"https://api.github.com/repos/google/web-starter-kit/subscribers","subscription_url":"https://api.github.com/repos/google/web-starter-kit/subscription","commits_url":"https://api.github.com/repos/google/web-starter-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/web-starter-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/web-starter-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/web-starter-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/web-starter-kit/contents/{+path}","compare_url":"https://api.github.com/repos/google/web-starter-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/web-starter-kit/merges","archive_url":"https://api.github.com/repos/google/web-starter-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/web-starter-kit/downloads","issues_url":"https://api.github.com/repos/google/web-starter-kit/issues{/number}","pulls_url":"https://api.github.com/repos/google/web-starter-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/google/web-starter-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/google/web-starter-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/web-starter-kit/labels{/name}","releases_url":"https://api.github.com/repos/google/web-starter-kit/releases{/id}","created_at":"2014-04-07T08:45:18Z","updated_at":"2015-10-30T17:26:05Z","pushed_at":"2015-10-30T17:48:20Z","git_url":"git://github.com/google/web-starter-kit.git","ssh_url":"git@github.com:google/web-starter-kit.git","clone_url":"https://github.com/google/web-starter-kit.git","svn_url":"https://github.com/google/web-starter-kit","homepage":"http://developers.google.com/web/starter-kit","size":17234,"stargazers_count":11271,"watchers_count":11271,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1734,"mirror_url":null,"open_issues_count":41,"forks":1734,"open_issues":41,"watchers":11271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/web-starter-kit/pulls/768"},"html":{"href":"https://github.com/google/web-starter-kit/pull/768"},"issue":{"href":"https://api.github.com/repos/google/web-starter-kit/issues/768"},"comments":{"href":"https://api.github.com/repos/google/web-starter-kit/issues/768/comments"},"review_comments":{"href":"https://api.github.com/repos/google/web-starter-kit/pulls/768/comments"},"review_comment":{"href":"https://api.github.com/repos/google/web-starter-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/web-starter-kit/pulls/768/commits"},"statuses":{"href":"https://api.github.com/repos/google/web-starter-kit/statuses/5d02814c5ff3abc98248354db6ed9760fc627aee"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"addyosmani","id":110953,"avatar_url":"https://avatars.githubusercontent.com/u/110953?v=3","gravatar_id":"","url":"https://api.github.com/users/addyosmani","html_url":"https://github.com/addyosmani","followers_url":"https://api.github.com/users/addyosmani/followers","following_url":"https://api.github.com/users/addyosmani/following{/other_user}","gists_url":"https://api.github.com/users/addyosmani/gists{/gist_id}","starred_url":"https://api.github.com/users/addyosmani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addyosmani/subscriptions","organizations_url":"https://api.github.com/users/addyosmani/orgs","repos_url":"https://api.github.com/users/addyosmani/repos","events_url":"https://api.github.com/users/addyosmani/events{/privacy}","received_events_url":"https://api.github.com/users/addyosmani/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":4,"deletions":2,"changed_files":1}}