{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/6358","labels_url":"https://api.github.com/repos/openshift/origin/issues/6358/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/6358/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/6358/events","html_url":"https://github.com/openshift/origin/pull/6358","id":122649468,"number":6358,"title":"[WIP] [DO-NOT-MERGE] Web console: display and attach persistent volume claims","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openshift/origin/labels/component/web","name":"component/web","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-12-17T02:51:08Z","updated_at":"2015-12-17T21:51:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/6358","html_url":"https://github.com/openshift/origin/pull/6358","diff_url":"https://github.com/openshift/origin/pull/6358.diff","patch_url":"https://github.com/openshift/origin/pull/6358.patch"},"body":"Code is **not yet ready for review** but I'm opening this for design feedback. PTAL @jwforres @ajacobs21e @spadgett @benjaminapetersen \r\n\r\nList all existing persistent volume claims, this is under *Browse/Storage*. The \"Status\" column represents the fulfilment of a claim against actual volumes in the cluster. You can click a claim to see the detail page with a little more information.\r\n\r\n![pvcs](https://cloud.githubusercontent.com/assets/158611/11859716/eefae26c-a454-11e5-83e0-072ce7021c14.png)\r\n\r\nNow how do we attach an existing persistent volume claim to pods? Volumes allow you to attach a pvc to *any resource that declares a pod spec*, so deployment configs, deployments (replication controllers in practice), etc. It does not seem possible to attach to a pod directly, and attaching to a deployment does not seem to make much sense (will not cause a new deployment so I think the pods would only be affected if a redeployment occurs). So I'm only supporting attaching to deployment configs at the moment, but other kinds can be added easily. \r\n\r\nI'm doing this in the deployment config details page using the *Attach persistent volume claim* link (similar to how it's done in *Create route*). Volumes were not yet present in the deployment config details page, so I added it mostly with the same design it's displayed in pod details, but together with the \"Template\" section (since it's not volumes *of the deployment config*, but of the template that will result in the dc's pods).\r\n\r\n![dc-attach-pvc](https://cloud.githubusercontent.com/assets/158611/11859720/f73ae314-a454-11e5-9d83-2a7474163430.png)\r\n\r\nHere is where you attach an existing persistent volume claim to a deployment config. I'm not particularly happy with the dropdown for the pvcs, it would be interesting to have more information (probably capacity, status and access modes) instead of just the name, so that it's more clear to users what's the pvc they are attaching to. What would you suggest, maybe radios? Also, it's still missing a few simple inputs (mount path, volume name, etc).\r\n\r\n![attach-storage](https://cloud.githubusercontent.com/assets/158611/11859721/fcc58bf4-a454-11e5-92b4-11e1b4eb155b.png)\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/165592512","html_url":"https://github.com/openshift/origin/pull/6358#issuecomment-165592512","issue_url":"https://api.github.com/repos/openshift/origin/issues/6358","id":165592512,"user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T21:51:28Z","updated_at":"2015-12-17T21:51:28Z","body":"How about just Browse -> Persistent Volume Claims and use menu sections labels when we add other storage options?  \"Storage - Persistent Volume Claims\" is pretty wordy.\r\n\r\nhttps://www.patternfly.org/patterns/vertical-with-persistent-secondary/"}}