{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/update_engine/pulls/comments/30191423","id":30191423,"diff_hunk":"@@ -18,6 +18,10 @@ namespace {\n const char kPostinstallScript[] = \"/postinst\";\n }\n \n+PostinstallRunnerAction::PostinstallRunnerAction(\n+    std::string app_id)\n+    : app_id_(app_id) {}","path":"src/update_engine/postinstall_runner_action.cc","position":6,"original_position":6,"commit_id":"5aea58b81fbbc2487235f1ef7421f0c461de722a","original_commit_id":"5aea58b81fbbc2487235f1ef7421f0c461de722a","user":{"login":"mjg59","id":1420843,"avatar_url":"https://avatars.githubusercontent.com/u/1420843?v=3","gravatar_id":"","url":"https://api.github.com/users/mjg59","html_url":"https://github.com/mjg59","followers_url":"https://api.github.com/users/mjg59/followers","following_url":"https://api.github.com/users/mjg59/following{/other_user}","gists_url":"https://api.github.com/users/mjg59/gists{/gist_id}","starred_url":"https://api.github.com/users/mjg59/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjg59/subscriptions","organizations_url":"https://api.github.com/users/mjg59/orgs","repos_url":"https://api.github.com/users/mjg59/repos","events_url":"https://api.github.com/users/mjg59/events{/privacy}","received_events_url":"https://api.github.com/users/mjg59/received_events","type":"User","site_admin":false},"body":"Actually, no - this isn't build as C++11, so std::move isn't available.","created_at":"2015-05-12T23:37:24Z","updated_at":"2015-05-12T23:37:24Z","html_url":"https://github.com/coreos/update_engine/pull/71#discussion_r30191423","pull_request_url":"https://api.github.com/repos/coreos/update_engine/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/coreos/update_engine/pulls/comments/30191423"},"html":{"href":"https://github.com/coreos/update_engine/pull/71#discussion_r30191423"},"pull_request":{"href":"https://api.github.com/repos/coreos/update_engine/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/update_engine/pulls/71","id":35171912,"html_url":"https://github.com/coreos/update_engine/pull/71","diff_url":"https://github.com/coreos/update_engine/pull/71.diff","patch_url":"https://github.com/coreos/update_engine/pull/71.patch","issue_url":"https://api.github.com/repos/coreos/update_engine/issues/71","number":71,"state":"open","locked":false,"title":"Support kernel payloads in Update Engine","user":{"login":"mjg59","id":1420843,"avatar_url":"https://avatars.githubusercontent.com/u/1420843?v=3","gravatar_id":"","url":"https://api.github.com/users/mjg59","html_url":"https://github.com/mjg59","followers_url":"https://api.github.com/users/mjg59/followers","following_url":"https://api.github.com/users/mjg59/following{/other_user}","gists_url":"https://api.github.com/users/mjg59/gists{/gist_id}","starred_url":"https://api.github.com/users/mjg59/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjg59/subscriptions","organizations_url":"https://api.github.com/users/mjg59/orgs","repos_url":"https://api.github.com/users/mjg59/repos","events_url":"https://api.github.com/users/mjg59/events{/privacy}","received_events_url":"https://api.github.com/users/mjg59/received_events","type":"User","site_admin":false},"body":"Distributing the kernel outside the filesystem is necessary for the combination of Secure Boot and verified filesystems, so we need Update Engine to be able to handle update images that contain a separate kernel payload and copy it to the right place.","created_at":"2015-05-11T21:32:55Z","updated_at":"2015-05-12T23:37:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f44139c3713ea758ab2f8b16c738cb4852d2d6cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/update_engine/pulls/71/commits","review_comments_url":"https://api.github.com/repos/coreos/update_engine/pulls/71/comments","review_comment_url":"https://api.github.com/repos/coreos/update_engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/update_engine/issues/71/comments","statuses_url":"https://api.github.com/repos/coreos/update_engine/statuses/5aea58b81fbbc2487235f1ef7421f0c461de722a","head":{"label":"mjg59:master","ref":"master","sha":"5aea58b81fbbc2487235f1ef7421f0c461de722a","user":{"login":"mjg59","id":1420843,"avatar_url":"https://avatars.githubusercontent.com/u/1420843?v=3","gravatar_id":"","url":"https://api.github.com/users/mjg59","html_url":"https://github.com/mjg59","followers_url":"https://api.github.com/users/mjg59/followers","following_url":"https://api.github.com/users/mjg59/following{/other_user}","gists_url":"https://api.github.com/users/mjg59/gists{/gist_id}","starred_url":"https://api.github.com/users/mjg59/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjg59/subscriptions","organizations_url":"https://api.github.com/users/mjg59/orgs","repos_url":"https://api.github.com/users/mjg59/repos","events_url":"https://api.github.com/users/mjg59/events{/privacy}","received_events_url":"https://api.github.com/users/mjg59/received_events","type":"User","site_admin":false},"repo":{"id":34420711,"name":"update_engine","full_name":"mjg59/update_engine","owner":{"login":"mjg59","id":1420843,"avatar_url":"https://avatars.githubusercontent.com/u/1420843?v=3","gravatar_id":"","url":"https://api.github.com/users/mjg59","html_url":"https://github.com/mjg59","followers_url":"https://api.github.com/users/mjg59/followers","following_url":"https://api.github.com/users/mjg59/following{/other_user}","gists_url":"https://api.github.com/users/mjg59/gists{/gist_id}","starred_url":"https://api.github.com/users/mjg59/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjg59/subscriptions","organizations_url":"https://api.github.com/users/mjg59/orgs","repos_url":"https://api.github.com/users/mjg59/repos","events_url":"https://api.github.com/users/mjg59/events{/privacy}","received_events_url":"https://api.github.com/users/mjg59/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjg59/update_engine","description":"update daemon for CoreOS","fork":true,"url":"https://api.github.com/repos/mjg59/update_engine","forks_url":"https://api.github.com/repos/mjg59/update_engine/forks","keys_url":"https://api.github.com/repos/mjg59/update_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjg59/update_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjg59/update_engine/teams","hooks_url":"https://api.github.com/repos/mjg59/update_engine/hooks","issue_events_url":"https://api.github.com/repos/mjg59/update_engine/issues/events{/number}","events_url":"https://api.github.com/repos/mjg59/update_engine/events","assignees_url":"https://api.github.com/repos/mjg59/update_engine/assignees{/user}","branches_url":"https://api.github.com/repos/mjg59/update_engine/branches{/branch}","tags_url":"https://api.github.com/repos/mjg59/update_engine/tags","blobs_url":"https://api.github.com/repos/mjg59/update_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjg59/update_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjg59/update_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjg59/update_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjg59/update_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/mjg59/update_engine/languages","stargazers_url":"https://api.github.com/repos/mjg59/update_engine/stargazers","contributors_url":"https://api.github.com/repos/mjg59/update_engine/contributors","subscribers_url":"https://api.github.com/repos/mjg59/update_engine/subscribers","subscription_url":"https://api.github.com/repos/mjg59/update_engine/subscription","commits_url":"https://api.github.com/repos/mjg59/update_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjg59/update_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjg59/update_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjg59/update_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjg59/update_engine/contents/{+path}","compare_url":"https://api.github.com/repos/mjg59/update_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjg59/update_engine/merges","archive_url":"https://api.github.com/repos/mjg59/update_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjg59/update_engine/downloads","issues_url":"https://api.github.com/repos/mjg59/update_engine/issues{/number}","pulls_url":"https://api.github.com/repos/mjg59/update_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/mjg59/update_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/mjg59/update_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjg59/update_engine/labels{/name}","releases_url":"https://api.github.com/repos/mjg59/update_engine/releases{/id}","created_at":"2015-04-22T22:59:32Z","updated_at":"2015-04-30T23:40:11Z","pushed_at":"2015-05-12T00:18:46Z","git_url":"git://github.com/mjg59/update_engine.git","ssh_url":"git@github.com:mjg59/update_engine.git","clone_url":"https://github.com/mjg59/update_engine.git","svn_url":"https://github.com/mjg59/update_engine","homepage":"","size":3159,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"e33c5a1f955ce73c6bde39ee33d7e858b9824f47","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":8620073,"name":"update_engine","full_name":"coreos/update_engine","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/update_engine","description":"update daemon for CoreOS","fork":false,"url":"https://api.github.com/repos/coreos/update_engine","forks_url":"https://api.github.com/repos/coreos/update_engine/forks","keys_url":"https://api.github.com/repos/coreos/update_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/update_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/update_engine/teams","hooks_url":"https://api.github.com/repos/coreos/update_engine/hooks","issue_events_url":"https://api.github.com/repos/coreos/update_engine/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/update_engine/events","assignees_url":"https://api.github.com/repos/coreos/update_engine/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/update_engine/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/update_engine/tags","blobs_url":"https://api.github.com/repos/coreos/update_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/update_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/update_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/update_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/update_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/update_engine/languages","stargazers_url":"https://api.github.com/repos/coreos/update_engine/stargazers","contributors_url":"https://api.github.com/repos/coreos/update_engine/contributors","subscribers_url":"https://api.github.com/repos/coreos/update_engine/subscribers","subscription_url":"https://api.github.com/repos/coreos/update_engine/subscription","commits_url":"https://api.github.com/repos/coreos/update_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/update_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/update_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/update_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/update_engine/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/update_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/update_engine/merges","archive_url":"https://api.github.com/repos/coreos/update_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/update_engine/downloads","issues_url":"https://api.github.com/repos/coreos/update_engine/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/update_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/update_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/update_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/update_engine/labels{/name}","releases_url":"https://api.github.com/repos/coreos/update_engine/releases{/id}","created_at":"2013-03-07T04:33:28Z","updated_at":"2015-04-30T21:28:51Z","pushed_at":"2015-05-12T23:17:50Z","git_url":"git://github.com/coreos/update_engine.git","ssh_url":"git@github.com:coreos/update_engine.git","clone_url":"https://github.com/coreos/update_engine.git","svn_url":"https://github.com/coreos/update_engine","homepage":"","size":3655,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":7,"forks":18,"open_issues":7,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/update_engine/pulls/71"},"html":{"href":"https://github.com/coreos/update_engine/pull/71"},"issue":{"href":"https://api.github.com/repos/coreos/update_engine/issues/71"},"comments":{"href":"https://api.github.com/repos/coreos/update_engine/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/update_engine/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/update_engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/update_engine/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/update_engine/statuses/5aea58b81fbbc2487235f1ef7421f0c461de722a"}}}}