{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/36","labels_url":"https://api.github.com/repos/nodejs/node/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/36/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/36/events","html_url":"https://github.com/nodejs/node/issues/36","id":79594060,"number":36,"title":"[Converge] test: Env variable to specify directory for pipes","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/pull-from-joyent-node","name":"pull-from-joyent-node","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-22T20:18:17Z","updated_at":"2015-05-22T20:36:34Z","closed_at":null,"body":"See https://github.com/joyent/node/commit/5dd5ce75d7d9a1470f4e35b6b4046bc933714f2d\r\n/cc: @mhdawson \r\n\r\nOriginal commit message:\r\n```\r\nAt the uv layer pipes are connected with uv_pipe_connect.\r\nThe current spec for this method indicates that the maximum\r\nlength is limited to the size of length of\r\nsizeof(sockaddr_un.sun_path), typically between 92 and\r\n108 bytes. Anything longer than that just gets truncated.\r\n\r\nThe simple testsuite currently creates pipes in directories\r\nunder the directory where node was built.  In our jenkins\r\njobs this sometimes ends up being a deep enough path that\r\nthe path for the pipes is getting truncated.  The result\r\nis that tests using pipes fail with errors that don't\r\nmake it obvious what the problem is.\r\n\r\nEven if the errors were helpful, we still need a way\r\nto avoid the truncation.\r\n\r\nThis patch adds the environment variable NODE_PIPE_DIR.\r\nIf set the tests create pipes in this directory instead of\r\nthe current defaults.  In addition the test harness is\r\nupdated to remove/delete this directory before/after\r\neach test is run.\r\n\r\n\tmodified:   test/common.js\r\n\tmodified:   test/simple/test-net-pipe-connect-errors.js\r\n\tmodified:   test/testpy/__init__.py\r\n\tmodified:   test/simple/test-cluster-eaccess.js\r\n```"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/104761283","html_url":"https://github.com/nodejs/node/issues/36#issuecomment-104761283","issue_url":"https://api.github.com/repos/nodejs/node/issues/36","id":104761283,"user":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"created_at":"2015-05-22T20:36:33Z","updated_at":"2015-05-22T20:36:33Z","body":"Interesting, @mhdawson do you remember which tests failed prior to this?"}}