{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments/29628221","id":29628221,"diff_hunk":"@@ -57,104 +62,105 @@ Seed.prototype.parse_passphrase = function(j) {\n   return this;\n };\n \n+Seed.prototype.parse_base58 = function(j) {\n+  var result = Base.decode_multi(j, Seed.width);\n+\n+  if (result.error) {\n+    this._value = NaN;\n+  } else if (lodash.isEqual(result.version, [Base.VER_FAMILY_SEED]) ||\n+        lodash.isEqual(result.version, Base.VER_ED25519_SEED)) {\n+      this._version = result.version;\n+      this._value = sjcl.bn.fromBits(sjcl.codec.bytes.toBits(result.bytes));\n+  }\n+\n+  return this;\n+};\n+\n Seed.prototype.to_json = function() {\n   if (!(this.is_valid())) {\n     return NaN;\n   }\n \n-  var output = Base.encode_check(Base.VER_FAMILY_SEED, this.to_bytes());\n+  var version = this._version; // Base.VER_FAMILY_SEED;\n+  var output = Base.encode_check(version, this.to_bytes());\n \n   return output;\n };\n \n-function append_int(a, i) {\n-  return [].concat(a, i >> 24, (i >> 16) & 0xff, (i >> 8) & 0xff, i & 0xff);\n-}\n-\n-function firstHalfOfSHA512(bytes) {\n-  return sjcl.bitArray.bitSlice(\n-    sjcl.hash.sha512.hash(sjcl.codec.bytes.toBits(bytes)),\n-    0, 256\n-  );\n-}\n-\n-// Removed a `*` so this JSDoc-ish syntax is ignored.\n-// This will soon all change anyway.\n-/*\n-* @param account\n-*        {undefined}                 take first, default, KeyPair\n-*\n-*        {Number}                    specifies the account number of the KeyPair\n-*                                    desired.\n-*\n-*        {Uint160} (from_json able), specifies the address matching the KeyPair\n-*                                    that is desired.\n+Seed.prototype.get_key = function(opts) {","path":"src/js/ripple/seed.js","position":89,"original_position":89,"commit_id":"c6a61631a68b8adee41297f9a43d4480af7d710d","original_commit_id":"681ae3086e8106551f7dbdd676a9f3f9c668d49a","user":{"login":"geertweening","id":966236,"avatar_url":"https://avatars.githubusercontent.com/u/966236?v=3","gravatar_id":"","url":"https://api.github.com/users/geertweening","html_url":"https://github.com/geertweening","followers_url":"https://api.github.com/users/geertweening/followers","following_url":"https://api.github.com/users/geertweening/following{/other_user}","gists_url":"https://api.github.com/users/geertweening/gists{/gist_id}","starred_url":"https://api.github.com/users/geertweening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geertweening/subscriptions","organizations_url":"https://api.github.com/users/geertweening/orgs","repos_url":"https://api.github.com/users/geertweening/repos","events_url":"https://api.github.com/users/geertweening/events{/privacy}","received_events_url":"https://api.github.com/users/geertweening/received_events","type":"User","site_admin":false},"body":"Depending on the who uses this api I'm fine with deprecating it. Up to you @sublimator  and @wltsmrz ","created_at":"2015-05-04T21:59:40Z","updated_at":"2015-05-04T21:59:40Z","html_url":"https://github.com/ripple/ripple-lib/pull/327#discussion_r29628221","pull_request_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/327","_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments/29628221"},"html":{"href":"https://github.com/ripple/ripple-lib/pull/327#discussion_r29628221"},"pull_request":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/327"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/ripple-lib/pulls/327","id":33472286,"html_url":"https://github.com/ripple/ripple-lib/pull/327","diff_url":"https://github.com/ripple/ripple-lib/pull/327.diff","patch_url":"https://github.com/ripple/ripple-lib/pull/327.patch","issue_url":"https://api.github.com/repos/ripple/ripple-lib/issues/327","number":327,"state":"open","locked":false,"title":"Add keypair service and ed25519 support","user":{"login":"wltsmrz","id":1746394,"avatar_url":"https://avatars.githubusercontent.com/u/1746394?v=3","gravatar_id":"","url":"https://api.github.com/users/wltsmrz","html_url":"https://github.com/wltsmrz","followers_url":"https://api.github.com/users/wltsmrz/followers","following_url":"https://api.github.com/users/wltsmrz/following{/other_user}","gists_url":"https://api.github.com/users/wltsmrz/gists{/gist_id}","starred_url":"https://api.github.com/users/wltsmrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wltsmrz/subscriptions","organizations_url":"https://api.github.com/users/wltsmrz/orgs","repos_url":"https://api.github.com/users/wltsmrz/repos","events_url":"https://api.github.com/users/wltsmrz/events{/privacy}","received_events_url":"https://api.github.com/users/wltsmrz/received_events","type":"User","site_admin":false},"body":"Minor cleanup of https://github.com/sublimator/ripple-lib/tree/ed25519","created_at":"2015-04-16T17:10:08Z","updated_at":"2015-05-04T21:59:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56cceb6187ff97df9b5e715dd77a4f269c903680","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/327/commits","review_comments_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/327/comments","review_comment_url":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/issues/327/comments","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/c6a61631a68b8adee41297f9a43d4480af7d710d","head":{"label":"ripple:ed25519","ref":"ed25519","sha":"c6a61631a68b8adee41297f9a43d4480af7d710d","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":9681561,"name":"ripple-lib","full_name":"ripple/ripple-lib","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/ripple-lib","description":"A JavaScript API for interacting with Ripple in Node.js and the browser","fork":false,"url":"https://api.github.com/repos/ripple/ripple-lib","forks_url":"https://api.github.com/repos/ripple/ripple-lib/forks","keys_url":"https://api.github.com/repos/ripple/ripple-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/ripple-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/ripple-lib/teams","hooks_url":"https://api.github.com/repos/ripple/ripple-lib/hooks","issue_events_url":"https://api.github.com/repos/ripple/ripple-lib/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/ripple-lib/events","assignees_url":"https://api.github.com/repos/ripple/ripple-lib/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/ripple-lib/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/ripple-lib/tags","blobs_url":"https://api.github.com/repos/ripple/ripple-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/ripple-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/ripple-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/ripple-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/ripple-lib/languages","stargazers_url":"https://api.github.com/repos/ripple/ripple-lib/stargazers","contributors_url":"https://api.github.com/repos/ripple/ripple-lib/contributors","subscribers_url":"https://api.github.com/repos/ripple/ripple-lib/subscribers","subscription_url":"https://api.github.com/repos/ripple/ripple-lib/subscription","commits_url":"https://api.github.com/repos/ripple/ripple-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/ripple-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/ripple-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/ripple-lib/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/ripple-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/ripple-lib/merges","archive_url":"https://api.github.com/repos/ripple/ripple-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/ripple-lib/downloads","issues_url":"https://api.github.com/repos/ripple/ripple-lib/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/ripple-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/ripple-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/ripple-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/ripple-lib/labels{/name}","releases_url":"https://api.github.com/repos/ripple/ripple-lib/releases{/id}","created_at":"2013-04-25T21:17:19Z","updated_at":"2015-05-04T17:03:58Z","pushed_at":"2015-05-04T20:12:01Z","git_url":"git://github.com/ripple/ripple-lib.git","ssh_url":"git@github.com:ripple/ripple-lib.git","clone_url":"https://github.com/ripple/ripple-lib.git","svn_url":"https://github.com/ripple/ripple-lib","homepage":"","size":17822,"stargazers_count":405,"watchers_count":405,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":22,"forks":138,"open_issues":22,"watchers":405,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"5e2c26a4a2605264aace3dd4be2bc35f4f00439f","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":9681561,"name":"ripple-lib","full_name":"ripple/ripple-lib","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/ripple-lib","description":"A JavaScript API for interacting with Ripple in Node.js and the browser","fork":false,"url":"https://api.github.com/repos/ripple/ripple-lib","forks_url":"https://api.github.com/repos/ripple/ripple-lib/forks","keys_url":"https://api.github.com/repos/ripple/ripple-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/ripple-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/ripple-lib/teams","hooks_url":"https://api.github.com/repos/ripple/ripple-lib/hooks","issue_events_url":"https://api.github.com/repos/ripple/ripple-lib/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/ripple-lib/events","assignees_url":"https://api.github.com/repos/ripple/ripple-lib/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/ripple-lib/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/ripple-lib/tags","blobs_url":"https://api.github.com/repos/ripple/ripple-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/ripple-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/ripple-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/ripple-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/ripple-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/ripple-lib/languages","stargazers_url":"https://api.github.com/repos/ripple/ripple-lib/stargazers","contributors_url":"https://api.github.com/repos/ripple/ripple-lib/contributors","subscribers_url":"https://api.github.com/repos/ripple/ripple-lib/subscribers","subscription_url":"https://api.github.com/repos/ripple/ripple-lib/subscription","commits_url":"https://api.github.com/repos/ripple/ripple-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/ripple-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/ripple-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/ripple-lib/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/ripple-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/ripple-lib/merges","archive_url":"https://api.github.com/repos/ripple/ripple-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/ripple-lib/downloads","issues_url":"https://api.github.com/repos/ripple/ripple-lib/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/ripple-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/ripple-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/ripple-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/ripple-lib/labels{/name}","releases_url":"https://api.github.com/repos/ripple/ripple-lib/releases{/id}","created_at":"2013-04-25T21:17:19Z","updated_at":"2015-05-04T17:03:58Z","pushed_at":"2015-05-04T20:12:01Z","git_url":"git://github.com/ripple/ripple-lib.git","ssh_url":"git@github.com:ripple/ripple-lib.git","clone_url":"https://github.com/ripple/ripple-lib.git","svn_url":"https://github.com/ripple/ripple-lib","homepage":"","size":17822,"stargazers_count":405,"watchers_count":405,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":22,"forks":138,"open_issues":22,"watchers":405,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/327"},"html":{"href":"https://github.com/ripple/ripple-lib/pull/327"},"issue":{"href":"https://api.github.com/repos/ripple/ripple-lib/issues/327"},"comments":{"href":"https://api.github.com/repos/ripple/ripple-lib/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/ripple-lib/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/ripple-lib/statuses/c6a61631a68b8adee41297f9a43d4480af7d710d"}}}}