{"action":"created","comment":{"url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/comments/29604450","id":29604450,"diff_hunk":"@@ -48,15 +51,32 @@ public void setTimeSheetDao(TimeSheetDao timeSheetDao) {\n     }\n \n     \n+    /**\n+     * Gets Time sheets - limited to most recent 80 results\n+     * @param modelMap\n+     * @return the most recent timesheets, limited to 80\n+     */\n     @Secured({\"ROLE_VIEW_WEB_CLOCK\", \"ROLE_VIEW_TIME_CLOCK\", \"ROLE_VIEW_TIME_SHEET\"})\n     @ResourceMapping(\"timeSheets\")\n     public String getTimeSheets(ModelMap modelMap) {\n         final String emplid = PrimaryAttributeUtils.getPrimaryId();\n \n         final List<TimeSheet> timeSheets = this.timeSheetDao.getTimeSheets(emplid);\n-\n-        modelMap.addAttribute(\"report\", timeSheets);\n         \n+        //sorts the list from most recent time sheets to oldest time sheets\n+        Collections.sort(timeSheets, new Comparator<TimeSheet>(){","path":"hrs-portlets-webapp/src/main/java/edu/wisc/portlet/hrs/web/timeabs/TimeSheetDataController.java","position":36,"original_position":36,"commit_id":"080c663d6e7ebb9005bae1b88e865247b63155f7","original_commit_id":"080c663d6e7ebb9005bae1b88e865247b63155f7","user":{"login":"apetro","id":952283,"avatar_url":"https://avatars.githubusercontent.com/u/952283?v=3","gravatar_id":"","url":"https://api.github.com/users/apetro","html_url":"https://github.com/apetro","followers_url":"https://api.github.com/users/apetro/followers","following_url":"https://api.github.com/users/apetro/following{/other_user}","gists_url":"https://api.github.com/users/apetro/gists{/gist_id}","starred_url":"https://api.github.com/users/apetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apetro/subscriptions","organizations_url":"https://api.github.com/users/apetro/orgs","repos_url":"https://api.github.com/users/apetro/repos","events_url":"https://api.github.com/users/apetro/events{/privacy}","received_events_url":"https://api.github.com/users/apetro/received_events","type":"User","site_admin":false},"body":"I'd have implemented an external `TimeSheetComparator` class so as to unit test it, but it'd be a trivial unit test and I accept that some developers prefer this style of code.","created_at":"2015-05-04T17:34:42Z","updated_at":"2015-05-04T17:34:42Z","html_url":"https://github.com/UW-Madison-DoIT/hrs-portlets/pull/30#discussion_r29604450","pull_request_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/comments/29604450"},"html":{"href":"https://github.com/UW-Madison-DoIT/hrs-portlets/pull/30#discussion_r29604450"},"pull_request":{"href":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/30","id":34656151,"html_url":"https://github.com/UW-Madison-DoIT/hrs-portlets/pull/30","diff_url":"https://github.com/UW-Madison-DoIT/hrs-portlets/pull/30.diff","patch_url":"https://github.com/UW-Madison-DoIT/hrs-portlets/pull/30.patch","issue_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/issues/30","number":30,"state":"open","locked":false,"title":"HRSPLT-224 Fixes HRS Time Entry Failures","user":{"login":"vertein","id":5521429,"avatar_url":"https://avatars.githubusercontent.com/u/5521429?v=3","gravatar_id":"","url":"https://api.github.com/users/vertein","html_url":"https://github.com/vertein","followers_url":"https://api.github.com/users/vertein/followers","following_url":"https://api.github.com/users/vertein/following{/other_user}","gists_url":"https://api.github.com/users/vertein/gists{/gist_id}","starred_url":"https://api.github.com/users/vertein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vertein/subscriptions","organizations_url":"https://api.github.com/users/vertein/orgs","repos_url":"https://api.github.com/users/vertein/repos","events_url":"https://api.github.com/users/vertein/events{/privacy}","received_events_url":"https://api.github.com/users/vertein/received_events","type":"User","site_admin":false},"body":"Before:\r\n![image](https://cloud.githubusercontent.com/assets/5521429/7458066/ec89d4a8-f256-11e4-9d77-e163e7163081.png)\r\n\r\nAfter:\r\n![image](https://cloud.githubusercontent.com/assets/5521429/7457998/6be1f3da-f256-11e4-8f5c-e9fe38b8d354.png)","created_at":"2015-05-04T17:25:41Z","updated_at":"2015-05-04T17:34:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"819c6f5bd1456f9d761916cebfa517f1029cdab6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/30/commits","review_comments_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/30/comments","review_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/issues/30/comments","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/statuses/080c663d6e7ebb9005bae1b88e865247b63155f7","head":{"label":"UW-Madison-DoIT:timeEntryBug","ref":"timeEntryBug","sha":"080c663d6e7ebb9005bae1b88e865247b63155f7","user":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"repo":{"id":8800718,"name":"hrs-portlets","full_name":"UW-Madison-DoIT/hrs-portlets","owner":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Madison-DoIT/hrs-portlets","description":"Human Resources System integration portlets for MyUW.","fork":true,"url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets","forks_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/forks","keys_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/teams","hooks_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/hooks","issue_events_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/events","assignees_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/tags","blobs_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/languages","stargazers_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/stargazers","contributors_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/contributors","subscribers_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/subscribers","subscription_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/subscription","commits_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/issues/comments{/number}","contents_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/merges","archive_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/downloads","issues_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/labels{/name}","releases_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/releases{/id}","created_at":"2013-03-15T14:13:33Z","updated_at":"2015-04-17T13:51:25Z","pushed_at":"2015-05-04T17:25:41Z","git_url":"git://github.com/UW-Madison-DoIT/hrs-portlets.git","ssh_url":"git@github.com:UW-Madison-DoIT/hrs-portlets.git","clone_url":"https://github.com/UW-Madison-DoIT/hrs-portlets.git","svn_url":"https://github.com/UW-Madison-DoIT/hrs-portlets","homepage":"","size":1369,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"uw-master"}},"base":{"label":"UW-Madison-DoIT:uw-master","ref":"uw-master","sha":"fd34a8e449207946985fb72b43ea84be525aac90","user":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"repo":{"id":8800718,"name":"hrs-portlets","full_name":"UW-Madison-DoIT/hrs-portlets","owner":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Madison-DoIT/hrs-portlets","description":"Human Resources System integration portlets for MyUW.","fork":true,"url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets","forks_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/forks","keys_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/teams","hooks_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/hooks","issue_events_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/events","assignees_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/tags","blobs_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/languages","stargazers_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/stargazers","contributors_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/contributors","subscribers_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/subscribers","subscription_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/subscription","commits_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/issues/comments{/number}","contents_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/merges","archive_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/downloads","issues_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/labels{/name}","releases_url":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/releases{/id}","created_at":"2013-03-15T14:13:33Z","updated_at":"2015-04-17T13:51:25Z","pushed_at":"2015-05-04T17:25:41Z","git_url":"git://github.com/UW-Madison-DoIT/hrs-portlets.git","ssh_url":"git@github.com:UW-Madison-DoIT/hrs-portlets.git","clone_url":"https://github.com/UW-Madison-DoIT/hrs-portlets.git","svn_url":"https://github.com/UW-Madison-DoIT/hrs-portlets","homepage":"","size":1369,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"uw-master"}},"_links":{"self":{"href":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/30"},"html":{"href":"https://github.com/UW-Madison-DoIT/hrs-portlets/pull/30"},"issue":{"href":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/issues/30"},"comments":{"href":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/UW-Madison-DoIT/hrs-portlets/statuses/080c663d6e7ebb9005bae1b88e865247b63155f7"}}}}