{"action":"created","issue":{"url":"https://api.github.com/repos/contiki-os/contiki/issues/987","labels_url":"https://api.github.com/repos/contiki-os/contiki/issues/987/labels{/name}","comments_url":"https://api.github.com/repos/contiki-os/contiki/issues/987/comments","events_url":"https://api.github.com/repos/contiki-os/contiki/issues/987/events","html_url":"https://github.com/contiki-os/contiki/pull/987","id":60429767,"number":987,"title":"Send the first NS attempt inside tcpip_ipv6_output()","user":{"login":"ioannisg","id":2333931,"avatar_url":"https://avatars.githubusercontent.com/u/2333931?v=3","gravatar_id":"","url":"https://api.github.com/users/ioannisg","html_url":"https://github.com/ioannisg","followers_url":"https://api.github.com/users/ioannisg/followers","following_url":"https://api.github.com/users/ioannisg/following{/other_user}","gists_url":"https://api.github.com/users/ioannisg/gists{/gist_id}","starred_url":"https://api.github.com/users/ioannisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioannisg/subscriptions","organizations_url":"https://api.github.com/users/ioannisg/orgs","repos_url":"https://api.github.com/users/ioannisg/repos","events_url":"https://api.github.com/users/ioannisg/events{/privacy}","received_events_url":"https://api.github.com/users/ioannisg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/contiki-os/contiki/labels/Core","name":"Core","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-09T23:53:18Z","updated_at":"2015-08-28T21:46:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/contiki-os/contiki/pulls/987","html_url":"https://github.com/contiki-os/contiki/pull/987","diff_url":"https://github.com/contiki-os/contiki/pull/987.diff","patch_url":"https://github.com/contiki-os/contiki/pull/987.patch"},"body":"This pull request enables tcpip_ipv6_output() to send the first of the (possibly multiple) NS messages for a new IPv6 neighbor immediately after this neighbor is added to the neighbor list.\r\n\r\nUnder the current implementation, tcpip_ipv6_output() prepares a new NS packet, places it in the uip buffer, but returns, before sending it, relying on the periodic calls of the IPv6 engine to send the pending frame. However, if a packet arrival from the underlying MAC layer (e.g. sicslowpan) occurs before the following call of uip_ds6_periodic, the pending NS frame is lost (sicslowpan overwrites the uip_buf and uip_len may be set to 0 after processing the incoming frame). This pull request will force the NS transmission before tcpip_ipv6_output() releases the control."},"comment":{"url":"https://api.github.com/repos/contiki-os/contiki/issues/comments/135895751","html_url":"https://github.com/contiki-os/contiki/pull/987#issuecomment-135895751","issue_url":"https://api.github.com/repos/contiki-os/contiki/issues/987","id":135895751,"user":{"login":"simonduq","id":1425999,"avatar_url":"https://avatars.githubusercontent.com/u/1425999?v=3","gravatar_id":"","url":"https://api.github.com/users/simonduq","html_url":"https://github.com/simonduq","followers_url":"https://api.github.com/users/simonduq/followers","following_url":"https://api.github.com/users/simonduq/following{/other_user}","gists_url":"https://api.github.com/users/simonduq/gists{/gist_id}","starred_url":"https://api.github.com/users/simonduq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonduq/subscriptions","organizations_url":"https://api.github.com/users/simonduq/orgs","repos_url":"https://api.github.com/users/simonduq/repos","events_url":"https://api.github.com/users/simonduq/events{/privacy}","received_events_url":"https://api.github.com/users/simonduq/received_events","type":"User","site_admin":false},"created_at":"2015-08-28T21:46:05Z","updated_at":"2015-08-28T21:46:05Z","body":"Ok I approve the fix and so does @joakimeriksson, so I will merge it in a month if nobody disapproves.\r\n(see [new PR merging policy](https://github.com/contiki-os/contiki/wiki/Code-Contributions#pull-request-merging-policy))"}}