{"action":"created","comment":{"url":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/comments/28333532","id":28333532,"diff_hunk":"@@ -2174,6 +2177,69 @@ static GstElement * on_rtpbin_request_aux_receiver(G_GNUC_UNUSED GstElement *rtp\n     return NULL;\n }\n \n+static void print_rtcp_feedback_type(guint fbtype, guint media_ssrc,\n+    GstRTCPType packet_type, guint8 *fci, gboolean is_received)\n+{\n+    if (fbtype == GST_RTCP_FB_TYPE_INVALID) {\n+        GST_INFO(\"%s RTCP feedback for %u: Invalid type\\n\",\n+            is_received ? \"Received\" : \"Sent\", media_ssrc);\n+    } else if (packet_type == GST_RTCP_TYPE_RTPFB) {\n+        switch (fbtype) {\n+        case GST_RTCP_RTPFB_TYPE_NACK:\n+            GST_INFO(\"%s RTCP feedback for %u: Generic NACK\\n\",\n+                is_received ? \"Received\" : \"Sent\", media_ssrc);\n+            break;\n+        case GST_RTCP_RTPFB_TYPE_TMMBR:\n+            GST_INFO(\"%s RTCP feedback for %u: Temporary Maximum Media Stream Bit Rate Request\\n\",\n+                is_received ? \"Received\" : \"Sent\", media_ssrc);\n+            break;\n+        case GST_RTCP_RTPFB_TYPE_TMMBN:\n+            GST_INFO(\"%s RTCP feedback for %u: Temporary Maximum Media Stream Bit Rate Notification\\n\",\n+                is_received ? \"Received\" : \"Sent\", media_ssrc);\n+            break;\n+        case GST_RTCP_RTPFB_TYPE_RCTP_SR_REQ:\n+            GST_INFO(\"%s RTCP feedback for %u: Request an SR packet for early synchronization\\n\",\n+                is_received ? \"Received\" : \"Sent\", media_ssrc);\n+            break;","path":"transport/owr_transport_agent.c","position":44,"original_position":44,"commit_id":"7672e8fb8f053db8b27b7edff5f55c970e667331","original_commit_id":"7672e8fb8f053db8b27b7edff5f55c970e667331","user":{"login":"superdump","id":302146,"avatar_url":"https://avatars.githubusercontent.com/u/302146?v=3","gravatar_id":"","url":"https://api.github.com/users/superdump","html_url":"https://github.com/superdump","followers_url":"https://api.github.com/users/superdump/followers","following_url":"https://api.github.com/users/superdump/following{/other_user}","gists_url":"https://api.github.com/users/superdump/gists{/gist_id}","starred_url":"https://api.github.com/users/superdump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdump/subscriptions","organizations_url":"https://api.github.com/users/superdump/orgs","repos_url":"https://api.github.com/users/superdump/repos","events_url":"https://api.github.com/users/superdump/events{/privacy}","received_events_url":"https://api.github.com/users/superdump/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2015-04-14T14:50:13Z","updated_at":"2015-04-14T14:50:13Z","html_url":"https://github.com/EricssonResearch/openwebrtc/pull/320#discussion_r28333532","pull_request_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/320","_links":{"self":{"href":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/comments/28333532"},"html":{"href":"https://github.com/EricssonResearch/openwebrtc/pull/320#discussion_r28333532"},"pull_request":{"href":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/320"}}},"pull_request":{"url":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/320","id":32800685,"html_url":"https://github.com/EricssonResearch/openwebrtc/pull/320","diff_url":"https://github.com/EricssonResearch/openwebrtc/pull/320.diff","patch_url":"https://github.com/EricssonResearch/openwebrtc/pull/320.patch","issue_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/issues/320","number":320,"state":"open","locked":false,"title":"OwrTransportAgent: Print debug output for all sent/received RTCP feedback","user":{"login":"superdump","id":302146,"avatar_url":"https://avatars.githubusercontent.com/u/302146?v=3","gravatar_id":"","url":"https://api.github.com/users/superdump","html_url":"https://github.com/superdump","followers_url":"https://api.github.com/users/superdump/followers","following_url":"https://api.github.com/users/superdump/following{/other_user}","gists_url":"https://api.github.com/users/superdump/gists{/gist_id}","starred_url":"https://api.github.com/users/superdump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdump/subscriptions","organizations_url":"https://api.github.com/users/superdump/orgs","repos_url":"https://api.github.com/users/superdump/repos","events_url":"https://api.github.com/users/superdump/events{/privacy}","received_events_url":"https://api.github.com/users/superdump/received_events","type":"User","site_admin":false},"body":"This helps with debugging. I haven't investigated whether the fci needs parsing for feedback types other than FIR but the information printed should be helpful anyway.","created_at":"2015-04-07T20:11:29Z","updated_at":"2015-04-14T14:50:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9e0a71479300d920f6b57c6c11def736230c1c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/320/commits","review_comments_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/320/comments","review_comment_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/issues/320/comments","statuses_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/statuses/7672e8fb8f053db8b27b7edff5f55c970e667331","head":{"label":"superdump:rtcp-fb-debug","ref":"rtcp-fb-debug","sha":"7672e8fb8f053db8b27b7edff5f55c970e667331","user":{"login":"superdump","id":302146,"avatar_url":"https://avatars.githubusercontent.com/u/302146?v=3","gravatar_id":"","url":"https://api.github.com/users/superdump","html_url":"https://github.com/superdump","followers_url":"https://api.github.com/users/superdump/followers","following_url":"https://api.github.com/users/superdump/following{/other_user}","gists_url":"https://api.github.com/users/superdump/gists{/gist_id}","starred_url":"https://api.github.com/users/superdump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdump/subscriptions","organizations_url":"https://api.github.com/users/superdump/orgs","repos_url":"https://api.github.com/users/superdump/repos","events_url":"https://api.github.com/users/superdump/events{/privacy}","received_events_url":"https://api.github.com/users/superdump/received_events","type":"User","site_admin":false},"repo":{"id":24715883,"name":"openwebrtc","full_name":"superdump/openwebrtc","owner":{"login":"superdump","id":302146,"avatar_url":"https://avatars.githubusercontent.com/u/302146?v=3","gravatar_id":"","url":"https://api.github.com/users/superdump","html_url":"https://github.com/superdump","followers_url":"https://api.github.com/users/superdump/followers","following_url":"https://api.github.com/users/superdump/following{/other_user}","gists_url":"https://api.github.com/users/superdump/gists{/gist_id}","starred_url":"https://api.github.com/users/superdump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdump/subscriptions","organizations_url":"https://api.github.com/users/superdump/orgs","repos_url":"https://api.github.com/users/superdump/repos","events_url":"https://api.github.com/users/superdump/events{/privacy}","received_events_url":"https://api.github.com/users/superdump/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/superdump/openwebrtc","description":"A flexible cross-platform WebRTC client framework based on GStreamer","fork":true,"url":"https://api.github.com/repos/superdump/openwebrtc","forks_url":"https://api.github.com/repos/superdump/openwebrtc/forks","keys_url":"https://api.github.com/repos/superdump/openwebrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superdump/openwebrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superdump/openwebrtc/teams","hooks_url":"https://api.github.com/repos/superdump/openwebrtc/hooks","issue_events_url":"https://api.github.com/repos/superdump/openwebrtc/issues/events{/number}","events_url":"https://api.github.com/repos/superdump/openwebrtc/events","assignees_url":"https://api.github.com/repos/superdump/openwebrtc/assignees{/user}","branches_url":"https://api.github.com/repos/superdump/openwebrtc/branches{/branch}","tags_url":"https://api.github.com/repos/superdump/openwebrtc/tags","blobs_url":"https://api.github.com/repos/superdump/openwebrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superdump/openwebrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superdump/openwebrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/superdump/openwebrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superdump/openwebrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/superdump/openwebrtc/languages","stargazers_url":"https://api.github.com/repos/superdump/openwebrtc/stargazers","contributors_url":"https://api.github.com/repos/superdump/openwebrtc/contributors","subscribers_url":"https://api.github.com/repos/superdump/openwebrtc/subscribers","subscription_url":"https://api.github.com/repos/superdump/openwebrtc/subscription","commits_url":"https://api.github.com/repos/superdump/openwebrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/superdump/openwebrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/superdump/openwebrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/superdump/openwebrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/superdump/openwebrtc/contents/{+path}","compare_url":"https://api.github.com/repos/superdump/openwebrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superdump/openwebrtc/merges","archive_url":"https://api.github.com/repos/superdump/openwebrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superdump/openwebrtc/downloads","issues_url":"https://api.github.com/repos/superdump/openwebrtc/issues{/number}","pulls_url":"https://api.github.com/repos/superdump/openwebrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/superdump/openwebrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/superdump/openwebrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superdump/openwebrtc/labels{/name}","releases_url":"https://api.github.com/repos/superdump/openwebrtc/releases{/id}","created_at":"2014-10-02T11:07:42Z","updated_at":"2014-10-30T08:07:51Z","pushed_at":"2015-04-14T14:21:04Z","git_url":"git://github.com/superdump/openwebrtc.git","ssh_url":"git@github.com:superdump/openwebrtc.git","clone_url":"https://github.com/superdump/openwebrtc.git","svn_url":"https://github.com/superdump/openwebrtc","homepage":"www.openwebrtc.io","size":1353,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EricssonResearch:master","ref":"master","sha":"8cdc5fd8f95334d4c4b16318dbf3bcd63ab4f133","user":{"login":"EricssonResearch","id":611464,"avatar_url":"https://avatars.githubusercontent.com/u/611464?v=3","gravatar_id":"","url":"https://api.github.com/users/EricssonResearch","html_url":"https://github.com/EricssonResearch","followers_url":"https://api.github.com/users/EricssonResearch/followers","following_url":"https://api.github.com/users/EricssonResearch/following{/other_user}","gists_url":"https://api.github.com/users/EricssonResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/EricssonResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricssonResearch/subscriptions","organizations_url":"https://api.github.com/users/EricssonResearch/orgs","repos_url":"https://api.github.com/users/EricssonResearch/repos","events_url":"https://api.github.com/users/EricssonResearch/events{/privacy}","received_events_url":"https://api.github.com/users/EricssonResearch/received_events","type":"Organization","site_admin":false},"repo":{"id":24327512,"name":"openwebrtc","full_name":"EricssonResearch/openwebrtc","owner":{"login":"EricssonResearch","id":611464,"avatar_url":"https://avatars.githubusercontent.com/u/611464?v=3","gravatar_id":"","url":"https://api.github.com/users/EricssonResearch","html_url":"https://github.com/EricssonResearch","followers_url":"https://api.github.com/users/EricssonResearch/followers","following_url":"https://api.github.com/users/EricssonResearch/following{/other_user}","gists_url":"https://api.github.com/users/EricssonResearch/gists{/gist_id}","starred_url":"https://api.github.com/users/EricssonResearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricssonResearch/subscriptions","organizations_url":"https://api.github.com/users/EricssonResearch/orgs","repos_url":"https://api.github.com/users/EricssonResearch/repos","events_url":"https://api.github.com/users/EricssonResearch/events{/privacy}","received_events_url":"https://api.github.com/users/EricssonResearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EricssonResearch/openwebrtc","description":"A mobile-first WebRTC client framework for building native apps","fork":false,"url":"https://api.github.com/repos/EricssonResearch/openwebrtc","forks_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/forks","keys_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/teams","hooks_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/hooks","issue_events_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/issues/events{/number}","events_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/events","assignees_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/assignees{/user}","branches_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/branches{/branch}","tags_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/tags","blobs_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/languages","stargazers_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/stargazers","contributors_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/contributors","subscribers_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/subscribers","subscription_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/subscription","commits_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/contents/{+path}","compare_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/merges","archive_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/downloads","issues_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/issues{/number}","pulls_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/labels{/name}","releases_url":"https://api.github.com/repos/EricssonResearch/openwebrtc/releases{/id}","created_at":"2014-09-22T12:23:46Z","updated_at":"2015-04-14T13:14:55Z","pushed_at":"2015-04-14T13:14:54Z","git_url":"git://github.com/EricssonResearch/openwebrtc.git","ssh_url":"git@github.com:EricssonResearch/openwebrtc.git","clone_url":"https://github.com/EricssonResearch/openwebrtc.git","svn_url":"https://github.com/EricssonResearch/openwebrtc","homepage":"www.openwebrtc.io","size":5973,"stargazers_count":487,"watchers_count":487,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":64,"forks":239,"open_issues":64,"watchers":487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/320"},"html":{"href":"https://github.com/EricssonResearch/openwebrtc/pull/320"},"issue":{"href":"https://api.github.com/repos/EricssonResearch/openwebrtc/issues/320"},"comments":{"href":"https://api.github.com/repos/EricssonResearch/openwebrtc/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EricssonResearch/openwebrtc/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/EricssonResearch/openwebrtc/statuses/7672e8fb8f053db8b27b7edff5f55c970e667331"}}}}