{"action":"created","comment":{"url":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/comments/45313365","id":45313365,"diff_hunk":"@@ -199,6 +200,8 @@ def update_network_precommit(self, context):\n         network state. It is up to the mechanism driver to ignore\n         state or state changes that it does not know or care about.\n         \"\"\"\n+        # NOTE(kevinbenton): you can just remove these methods that you\n+        # don't use.","path":"generic_switch/generic_switch_mech.py","position":22,"original_position":22,"commit_id":"b166aa0c779422b714cb355f7ccff65501402a62","original_commit_id":"b166aa0c779422b714cb355f7ccff65501402a62","user":{"login":"jumpojoy","id":11338441,"avatar_url":"https://avatars.githubusercontent.com/u/11338441?v=3","gravatar_id":"","url":"https://api.github.com/users/jumpojoy","html_url":"https://github.com/jumpojoy","followers_url":"https://api.github.com/users/jumpojoy/followers","following_url":"https://api.github.com/users/jumpojoy/following{/other_user}","gists_url":"https://api.github.com/users/jumpojoy/gists{/gist_id}","starred_url":"https://api.github.com/users/jumpojoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jumpojoy/subscriptions","organizations_url":"https://api.github.com/users/jumpojoy/orgs","repos_url":"https://api.github.com/users/jumpojoy/repos","events_url":"https://api.github.com/users/jumpojoy/events{/privacy}","received_events_url":"https://api.github.com/users/jumpojoy/received_events","type":"User","site_admin":false},"body":"I will remove them later, It was added to figure out when method is called.","created_at":"2015-11-19T08:38:36Z","updated_at":"2015-11-19T08:38:36Z","html_url":"https://github.com/jumpojoy/generic_switch/pull/1#discussion_r45313365","pull_request_url":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/comments/45313365"},"html":{"href":"https://github.com/jumpojoy/generic_switch/pull/1#discussion_r45313365"},"pull_request":{"href":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/1","id":51058253,"html_url":"https://github.com/jumpojoy/generic_switch/pull/1","diff_url":"https://github.com/jumpojoy/generic_switch/pull/1.diff","patch_url":"https://github.com/jumpojoy/generic_switch/pull/1.patch","issue_url":"https://api.github.com/repos/jumpojoy/generic_switch/issues/1","number":1,"state":"open","locked":false,"title":"Review comments","user":{"login":"kevinbenton","id":1017708,"avatar_url":"https://avatars.githubusercontent.com/u/1017708?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinbenton","html_url":"https://github.com/kevinbenton","followers_url":"https://api.github.com/users/kevinbenton/followers","following_url":"https://api.github.com/users/kevinbenton/following{/other_user}","gists_url":"https://api.github.com/users/kevinbenton/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinbenton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinbenton/subscriptions","organizations_url":"https://api.github.com/users/kevinbenton/orgs","repos_url":"https://api.github.com/users/kevinbenton/repos","events_url":"https://api.github.com/users/kevinbenton/events{/privacy}","received_events_url":"https://api.github.com/users/kevinbenton/received_events","type":"User","site_admin":false},"body":"I left several review comments inline. Also, does this\r\ndriver need to be able to setup the baremetal nodes to talk\r\nto regular compute nodes as well, or can we safely assume that\r\ncompute nodes already have all VLANs tagged to them?","created_at":"2015-11-18T09:07:34Z","updated_at":"2015-11-19T08:38:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00eb9e936f04f6997879bef43d7c179599daab43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jumpojoy/generic_switch/issues/1/comments","statuses_url":"https://api.github.com/repos/jumpojoy/generic_switch/statuses/b166aa0c779422b714cb355f7ccff65501402a62","head":{"label":"kevinbenton:review_comments","ref":"review_comments","sha":"b166aa0c779422b714cb355f7ccff65501402a62","user":{"login":"kevinbenton","id":1017708,"avatar_url":"https://avatars.githubusercontent.com/u/1017708?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinbenton","html_url":"https://github.com/kevinbenton","followers_url":"https://api.github.com/users/kevinbenton/followers","following_url":"https://api.github.com/users/kevinbenton/following{/other_user}","gists_url":"https://api.github.com/users/kevinbenton/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinbenton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinbenton/subscriptions","organizations_url":"https://api.github.com/users/kevinbenton/orgs","repos_url":"https://api.github.com/users/kevinbenton/repos","events_url":"https://api.github.com/users/kevinbenton/events{/privacy}","received_events_url":"https://api.github.com/users/kevinbenton/received_events","type":"User","site_admin":false},"repo":{"id":46372329,"name":"generic_switch","full_name":"kevinbenton/generic_switch","owner":{"login":"kevinbenton","id":1017708,"avatar_url":"https://avatars.githubusercontent.com/u/1017708?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinbenton","html_url":"https://github.com/kevinbenton","followers_url":"https://api.github.com/users/kevinbenton/followers","following_url":"https://api.github.com/users/kevinbenton/following{/other_user}","gists_url":"https://api.github.com/users/kevinbenton/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinbenton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinbenton/subscriptions","organizations_url":"https://api.github.com/users/kevinbenton/orgs","repos_url":"https://api.github.com/users/kevinbenton/repos","events_url":"https://api.github.com/users/kevinbenton/events{/privacy}","received_events_url":"https://api.github.com/users/kevinbenton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevinbenton/generic_switch","description":"","fork":true,"url":"https://api.github.com/repos/kevinbenton/generic_switch","forks_url":"https://api.github.com/repos/kevinbenton/generic_switch/forks","keys_url":"https://api.github.com/repos/kevinbenton/generic_switch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinbenton/generic_switch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinbenton/generic_switch/teams","hooks_url":"https://api.github.com/repos/kevinbenton/generic_switch/hooks","issue_events_url":"https://api.github.com/repos/kevinbenton/generic_switch/issues/events{/number}","events_url":"https://api.github.com/repos/kevinbenton/generic_switch/events","assignees_url":"https://api.github.com/repos/kevinbenton/generic_switch/assignees{/user}","branches_url":"https://api.github.com/repos/kevinbenton/generic_switch/branches{/branch}","tags_url":"https://api.github.com/repos/kevinbenton/generic_switch/tags","blobs_url":"https://api.github.com/repos/kevinbenton/generic_switch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinbenton/generic_switch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinbenton/generic_switch/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinbenton/generic_switch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinbenton/generic_switch/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinbenton/generic_switch/languages","stargazers_url":"https://api.github.com/repos/kevinbenton/generic_switch/stargazers","contributors_url":"https://api.github.com/repos/kevinbenton/generic_switch/contributors","subscribers_url":"https://api.github.com/repos/kevinbenton/generic_switch/subscribers","subscription_url":"https://api.github.com/repos/kevinbenton/generic_switch/subscription","commits_url":"https://api.github.com/repos/kevinbenton/generic_switch/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinbenton/generic_switch/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinbenton/generic_switch/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinbenton/generic_switch/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevinbenton/generic_switch/contents/{+path}","compare_url":"https://api.github.com/repos/kevinbenton/generic_switch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinbenton/generic_switch/merges","archive_url":"https://api.github.com/repos/kevinbenton/generic_switch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinbenton/generic_switch/downloads","issues_url":"https://api.github.com/repos/kevinbenton/generic_switch/issues{/number}","pulls_url":"https://api.github.com/repos/kevinbenton/generic_switch/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinbenton/generic_switch/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinbenton/generic_switch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinbenton/generic_switch/labels{/name}","releases_url":"https://api.github.com/repos/kevinbenton/generic_switch/releases{/id}","created_at":"2015-11-17T20:08:25Z","updated_at":"2015-11-17T20:08:25Z","pushed_at":"2015-11-18T09:06:52Z","git_url":"git://github.com/kevinbenton/generic_switch.git","ssh_url":"git@github.com:kevinbenton/generic_switch.git","clone_url":"https://github.com/kevinbenton/generic_switch.git","svn_url":"https://github.com/kevinbenton/generic_switch","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jumpojoy:master","ref":"master","sha":"a1bf3b45c88e01e0980455abec497b64e5f525d0","user":{"login":"jumpojoy","id":11338441,"avatar_url":"https://avatars.githubusercontent.com/u/11338441?v=3","gravatar_id":"","url":"https://api.github.com/users/jumpojoy","html_url":"https://github.com/jumpojoy","followers_url":"https://api.github.com/users/jumpojoy/followers","following_url":"https://api.github.com/users/jumpojoy/following{/other_user}","gists_url":"https://api.github.com/users/jumpojoy/gists{/gist_id}","starred_url":"https://api.github.com/users/jumpojoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jumpojoy/subscriptions","organizations_url":"https://api.github.com/users/jumpojoy/orgs","repos_url":"https://api.github.com/users/jumpojoy/repos","events_url":"https://api.github.com/users/jumpojoy/events{/privacy}","received_events_url":"https://api.github.com/users/jumpojoy/received_events","type":"User","site_admin":false},"repo":{"id":46335839,"name":"generic_switch","full_name":"jumpojoy/generic_switch","owner":{"login":"jumpojoy","id":11338441,"avatar_url":"https://avatars.githubusercontent.com/u/11338441?v=3","gravatar_id":"","url":"https://api.github.com/users/jumpojoy","html_url":"https://github.com/jumpojoy","followers_url":"https://api.github.com/users/jumpojoy/followers","following_url":"https://api.github.com/users/jumpojoy/following{/other_user}","gists_url":"https://api.github.com/users/jumpojoy/gists{/gist_id}","starred_url":"https://api.github.com/users/jumpojoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jumpojoy/subscriptions","organizations_url":"https://api.github.com/users/jumpojoy/orgs","repos_url":"https://api.github.com/users/jumpojoy/repos","events_url":"https://api.github.com/users/jumpojoy/events{/privacy}","received_events_url":"https://api.github.com/users/jumpojoy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jumpojoy/generic_switch","description":"","fork":false,"url":"https://api.github.com/repos/jumpojoy/generic_switch","forks_url":"https://api.github.com/repos/jumpojoy/generic_switch/forks","keys_url":"https://api.github.com/repos/jumpojoy/generic_switch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jumpojoy/generic_switch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jumpojoy/generic_switch/teams","hooks_url":"https://api.github.com/repos/jumpojoy/generic_switch/hooks","issue_events_url":"https://api.github.com/repos/jumpojoy/generic_switch/issues/events{/number}","events_url":"https://api.github.com/repos/jumpojoy/generic_switch/events","assignees_url":"https://api.github.com/repos/jumpojoy/generic_switch/assignees{/user}","branches_url":"https://api.github.com/repos/jumpojoy/generic_switch/branches{/branch}","tags_url":"https://api.github.com/repos/jumpojoy/generic_switch/tags","blobs_url":"https://api.github.com/repos/jumpojoy/generic_switch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jumpojoy/generic_switch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jumpojoy/generic_switch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jumpojoy/generic_switch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jumpojoy/generic_switch/statuses/{sha}","languages_url":"https://api.github.com/repos/jumpojoy/generic_switch/languages","stargazers_url":"https://api.github.com/repos/jumpojoy/generic_switch/stargazers","contributors_url":"https://api.github.com/repos/jumpojoy/generic_switch/contributors","subscribers_url":"https://api.github.com/repos/jumpojoy/generic_switch/subscribers","subscription_url":"https://api.github.com/repos/jumpojoy/generic_switch/subscription","commits_url":"https://api.github.com/repos/jumpojoy/generic_switch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jumpojoy/generic_switch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jumpojoy/generic_switch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jumpojoy/generic_switch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jumpojoy/generic_switch/contents/{+path}","compare_url":"https://api.github.com/repos/jumpojoy/generic_switch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jumpojoy/generic_switch/merges","archive_url":"https://api.github.com/repos/jumpojoy/generic_switch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jumpojoy/generic_switch/downloads","issues_url":"https://api.github.com/repos/jumpojoy/generic_switch/issues{/number}","pulls_url":"https://api.github.com/repos/jumpojoy/generic_switch/pulls{/number}","milestones_url":"https://api.github.com/repos/jumpojoy/generic_switch/milestones{/number}","notifications_url":"https://api.github.com/repos/jumpojoy/generic_switch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jumpojoy/generic_switch/labels{/name}","releases_url":"https://api.github.com/repos/jumpojoy/generic_switch/releases{/id}","created_at":"2015-11-17T09:13:57Z","updated_at":"2015-11-17T09:56:30Z","pushed_at":"2015-11-18T09:07:35Z","git_url":"git://github.com/jumpojoy/generic_switch.git","ssh_url":"git@github.com:jumpojoy/generic_switch.git","clone_url":"https://github.com/jumpojoy/generic_switch.git","svn_url":"https://github.com/jumpojoy/generic_switch","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/1"},"html":{"href":"https://github.com/jumpojoy/generic_switch/pull/1"},"issue":{"href":"https://api.github.com/repos/jumpojoy/generic_switch/issues/1"},"comments":{"href":"https://api.github.com/repos/jumpojoy/generic_switch/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jumpojoy/generic_switch/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jumpojoy/generic_switch/statuses/b166aa0c779422b714cb355f7ccff65501402a62"}}}}