{"action":"created","issue":{"url":"https://api.github.com/repos/Eonblast/Emysql/issues/168","labels_url":"https://api.github.com/repos/Eonblast/Emysql/issues/168/labels{/name}","comments_url":"https://api.github.com/repos/Eonblast/Emysql/issues/168/comments","events_url":"https://api.github.com/repos/Eonblast/Emysql/issues/168/events","html_url":"https://github.com/Eonblast/Emysql/pull/168","id":91883421,"number":168,"title":"using os:timestamp/0 since erlang:now/0 is deprecated","user":{"login":"marcelog","id":527356,"avatar_url":"https://avatars.githubusercontent.com/u/527356?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelog","html_url":"https://github.com/marcelog","followers_url":"https://api.github.com/users/marcelog/followers","following_url":"https://api.github.com/users/marcelog/following{/other_user}","gists_url":"https://api.github.com/users/marcelog/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelog/subscriptions","organizations_url":"https://api.github.com/users/marcelog/orgs","repos_url":"https://api.github.com/users/marcelog/repos","events_url":"https://api.github.com/users/marcelog/events{/privacy}","received_events_url":"https://api.github.com/users/marcelog/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-29T19:09:21Z","updated_at":"2015-06-30T12:24:10Z","closed_at":"2015-06-30T12:24:10Z","pull_request":{"url":"https://api.github.com/repos/Eonblast/Emysql/pulls/168","html_url":"https://github.com/Eonblast/Emysql/pull/168","diff_url":"https://github.com/Eonblast/Emysql/pull/168.diff","patch_url":"https://github.com/Eonblast/Emysql/pull/168.patch"},"body":"Hello,\r\n\r\nThis replaces the call to erlang:now/0 (now fully deprecated) with a call to os:timestamp/0.\r\n\r\nAny thoughts?\r\n\r\nThanks in advance!"},"comment":{"url":"https://api.github.com/repos/Eonblast/Emysql/issues/comments/117157869","html_url":"https://github.com/Eonblast/Emysql/pull/168#issuecomment-117157869","issue_url":"https://api.github.com/repos/Eonblast/Emysql/issues/168","id":117157869,"user":{"login":"marcelog","id":527356,"avatar_url":"https://avatars.githubusercontent.com/u/527356?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelog","html_url":"https://github.com/marcelog","followers_url":"https://api.github.com/users/marcelog/followers","following_url":"https://api.github.com/users/marcelog/following{/other_user}","gists_url":"https://api.github.com/users/marcelog/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelog/subscriptions","organizations_url":"https://api.github.com/users/marcelog/orgs","repos_url":"https://api.github.com/users/marcelog/repos","events_url":"https://api.github.com/users/marcelog/events{/privacy}","received_events_url":"https://api.github.com/users/marcelog/received_events","type":"User","site_admin":false},"created_at":"2015-06-30T12:24:10Z","updated_at":"2015-06-30T12:24:10Z","body":"Thanks @jlouis that is a good point. What I thought in this particular scenario, is that since this is only used to send a ping through the connection (here: https://github.com/Eonblast/Emysql/blob/master/src/emysql_conn.erl#L331) it wouldn't hurt as much as a delay caused by using `erlang:now/0` when waiting to compensate time differences.\r\n\r\nI'll close this one anyway if this project is not mantained anymore.\r\n\r\nThank you!\r\n\r\nBest Regards,"}}