{"action":"created","issue":{"url":"https://api.github.com/repos/astropy/astropy/issues/3701","labels_url":"https://api.github.com/repos/astropy/astropy/issues/3701/labels{/name}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/3701/comments","events_url":"https://api.github.com/repos/astropy/astropy/issues/3701/events","html_url":"https://github.com/astropy/astropy/pull/3701","id":70006833,"number":3701,"title":"Implement sigma_to_logp and its inverse plus tests","user":{"login":"aarchiba","id":136867,"avatar_url":"https://avatars.githubusercontent.com/u/136867?v=3","gravatar_id":"","url":"https://api.github.com/users/aarchiba","html_url":"https://github.com/aarchiba","followers_url":"https://api.github.com/users/aarchiba/followers","following_url":"https://api.github.com/users/aarchiba/following{/other_user}","gists_url":"https://api.github.com/users/aarchiba/gists{/gist_id}","starred_url":"https://api.github.com/users/aarchiba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarchiba/subscriptions","organizations_url":"https://api.github.com/users/aarchiba/orgs","repos_url":"https://api.github.com/users/aarchiba/repos","events_url":"https://api.github.com/users/aarchiba/events{/privacy}","received_events_url":"https://api.github.com/users/aarchiba/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/astropy/astropy/labels/Affects-release","name":"Affects-release","color":"0052cc"},{"url":"https://api.github.com/repos/astropy/astropy/labels/Enhancement","name":"Enhancement","color":"fad8c7"},{"url":"https://api.github.com/repos/astropy/astropy/labels/stats","name":"stats","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-04-22T02:52:38Z","updated_at":"2015-09-29T17:21:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/3701","html_url":"https://github.com/astropy/astropy/pull/3701","diff_url":"https://github.com/astropy/astropy/pull/3701.diff","patch_url":"https://github.com/astropy/astropy/pull/3701.patch"},"body":"Provide functions to convert between a log-probability and a number of sigma that work even for probabilities too small to represent as doubles."},"comment":{"url":"https://api.github.com/repos/astropy/astropy/issues/comments/144126747","html_url":"https://github.com/astropy/astropy/pull/3701#issuecomment-144126747","issue_url":"https://api.github.com/repos/astropy/astropy/issues/3701","id":144126747,"user":{"login":"crawfordsm","id":1107188,"avatar_url":"https://avatars.githubusercontent.com/u/1107188?v=3","gravatar_id":"","url":"https://api.github.com/users/crawfordsm","html_url":"https://github.com/crawfordsm","followers_url":"https://api.github.com/users/crawfordsm/followers","following_url":"https://api.github.com/users/crawfordsm/following{/other_user}","gists_url":"https://api.github.com/users/crawfordsm/gists{/gist_id}","starred_url":"https://api.github.com/users/crawfordsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawfordsm/subscriptions","organizations_url":"https://api.github.com/users/crawfordsm/orgs","repos_url":"https://api.github.com/users/crawfordsm/repos","events_url":"https://api.github.com/users/crawfordsm/events{/privacy}","received_events_url":"https://api.github.com/users/crawfordsm/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T17:21:27Z","updated_at":"2015-09-29T17:21:27Z","body":"Hi @aarchiba, sorry for getting back to this so late, but overall it looks pretty good.  There is a conflict with this and your previous, now merged pull request.  If you can rebase this, I would be happy to see this merged.   \r\n\r\nA couple of  minor comments:\r\n- I didn't see a test for if a negative value is passed to sigma_to_logp in the case where two_sided is True (an exception is raised and this should be tested for)\r\n- Likewise, please add a test for when a value greater 0 is passed to logp_to_sigma\r\n- also if there are any relevant references please include them in the doc_string"}}