{"action":"created","issue":{"url":"https://api.github.com/repos/rackt/react-router/issues/2229","labels_url":"https://api.github.com/repos/rackt/react-router/issues/2229/labels{/name}","comments_url":"https://api.github.com/repos/rackt/react-router/issues/2229/comments","events_url":"https://api.github.com/repos/rackt/react-router/issues/2229/events","html_url":"https://github.com/rackt/react-router/pull/2229","id":110761034,"number":2229,"title":"Add test for index links on dynamic routes.","user":{"login":"Agrosis","id":2617549,"avatar_url":"https://avatars.githubusercontent.com/u/2617549?v=3","gravatar_id":"","url":"https://api.github.com/users/Agrosis","html_url":"https://github.com/Agrosis","followers_url":"https://api.github.com/users/Agrosis/followers","following_url":"https://api.github.com/users/Agrosis/following{/other_user}","gists_url":"https://api.github.com/users/Agrosis/gists{/gist_id}","starred_url":"https://api.github.com/users/Agrosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Agrosis/subscriptions","organizations_url":"https://api.github.com/users/Agrosis/orgs","repos_url":"https://api.github.com/users/Agrosis/repos","events_url":"https://api.github.com/users/Agrosis/events{/privacy}","received_events_url":"https://api.github.com/users/Agrosis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-10T02:12:32Z","updated_at":"2015-10-20T22:25:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rackt/react-router/pulls/2229","html_url":"https://github.com/rackt/react-router/pull/2229","diff_url":"https://github.com/rackt/react-router/pull/2229.diff","patch_url":"https://github.com/rackt/react-router/pull/2229.patch"},"body":"@mjackson, so this is what I've got for a test #2072. \r\n\r\nI didn't see any tests for dynamic routes and I didn't know where it should go best, so I went ahead and created a new file for that, as well as a directory for the routes that should be dynamically loaded. Lemme know if that's wrong or you've got something better in mind!\r\n\r\nAnd second, I couldn't actually test this, I'm assuming that its because dynamic routing is done through webpack. How should I actually make sure the test works?"},"comment":{"url":"https://api.github.com/repos/rackt/react-router/issues/comments/149720356","html_url":"https://github.com/rackt/react-router/pull/2229#issuecomment-149720356","issue_url":"https://api.github.com/repos/rackt/react-router/issues/2229","id":149720356,"user":{"login":"knowbody","id":3802023,"avatar_url":"https://avatars.githubusercontent.com/u/3802023?v=3","gravatar_id":"","url":"https://api.github.com/users/knowbody","html_url":"https://github.com/knowbody","followers_url":"https://api.github.com/users/knowbody/followers","following_url":"https://api.github.com/users/knowbody/following{/other_user}","gists_url":"https://api.github.com/users/knowbody/gists{/gist_id}","starred_url":"https://api.github.com/users/knowbody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knowbody/subscriptions","organizations_url":"https://api.github.com/users/knowbody/orgs","repos_url":"https://api.github.com/users/knowbody/repos","events_url":"https://api.github.com/users/knowbody/events{/privacy}","received_events_url":"https://api.github.com/users/knowbody/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T22:25:03Z","updated_at":"2015-10-20T22:25:03Z","body":"@Agrogis any chance we could merge that? mind rebasing?"}}