{"action":"created","comment":{"url":"https://api.github.com/repos/yegor256/s3auth/pulls/comments/22417188","id":22417188,"diff_hunk":"@@ -56,58 +58,58 @@\n  * Abstraction on top of DynamoDB SDK.\n  *\n  * <p>The class is mutable and thread-safe.\n- *\n  * @author Yegor Bugayenko (yegor@tpc2.com)\n  * @version $Id$\n- * @since 0.0.1\n  * @checkstyle ClassDataAbstractionCoupling (500 lines)\n  * @todo #1 Would be nice to migrate to jcabi-dynamo\n+ * @since 0.0.1\n  */\n @Immutable\n @ToString\n-@EqualsAndHashCode(of = { \"client\", \"table\" })\n+@EqualsAndHashCode(of = {\"table\" })\n @Loggable(Loggable.INFO)\n final class DefaultDynamo implements Dynamo {\n \n     /**\n      * Dynamo DB key, URN of a user.\n      */\n-    public static final String USER = \"user.urn\";\n+    public static final String USER = \"user_urn\";\n \n     /**\n      * Dynamo DB key, name of domain.\n      */\n-    public static final String NAME = \"domain.name\";\n+    public static final String NAME = \"domain_name\";\n \n     /**\n      * Dynamo DB key, AWS key of bucket.\n      */\n-    public static final String KEY = \"domain.key\";\n+    public static final String KEY = \"domain_key\";\n \n     /**\n      * Dynamo DB key, AWS secret of bucket.\n      */\n-    public static final String SECRET = \"domain.secret\";\n+    public static final String SECRET = \"domain_secret\";\n \n     /**\n      * Dynamo DB key, Name of bucket.\n      */\n-    public static final String BUCKET = \"domain.bucket\";\n+    public static final String BUCKET = \"domain_bucket\";","path":"s3auth-hosts/src/main/java/com/s3auth/hosts/DefaultDynamo.java","position":80,"original_position":80,"commit_id":"1485604bb7dc1bdb53f370b4a16650f02d154dd6","original_commit_id":"1485604bb7dc1bdb53f370b4a16650f02d154dd6","user":{"login":"carlosmiranda","id":1917892,"avatar_url":"https://avatars.githubusercontent.com/u/1917892?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosmiranda","html_url":"https://github.com/carlosmiranda","followers_url":"https://api.github.com/users/carlosmiranda/followers","following_url":"https://api.github.com/users/carlosmiranda/following{/other_user}","gists_url":"https://api.github.com/users/carlosmiranda/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosmiranda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosmiranda/subscriptions","organizations_url":"https://api.github.com/users/carlosmiranda/orgs","repos_url":"https://api.github.com/users/carlosmiranda/repos","events_url":"https://api.github.com/users/carlosmiranda/events{/privacy}","received_events_url":"https://api.github.com/users/carlosmiranda/received_events","type":"User","site_admin":false},"body":"Same here.","created_at":"2015-01-02T18:11:37Z","updated_at":"2015-01-02T18:11:37Z","html_url":"https://github.com/yegor256/s3auth/pull/239#discussion_r22417188","pull_request_url":"https://api.github.com/repos/yegor256/s3auth/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/yegor256/s3auth/pulls/comments/22417188"},"html":{"href":"https://github.com/yegor256/s3auth/pull/239#discussion_r22417188"},"pull_request":{"href":"https://api.github.com/repos/yegor256/s3auth/pulls/239"}}},"pull_request":{"url":"https://api.github.com/repos/yegor256/s3auth/pulls/239","id":26624669,"html_url":"https://github.com/yegor256/s3auth/pull/239","diff_url":"https://github.com/yegor256/s3auth/pull/239.diff","patch_url":"https://github.com/yegor256/s3auth/pull/239.patch","issue_url":"https://api.github.com/repos/yegor256/s3auth/issues/239","number":239,"state":"open","locked":false,"title":"Task 90, updated code","user":{"login":"dpisarenko","id":1143055,"avatar_url":"https://avatars.githubusercontent.com/u/1143055?v=3","gravatar_id":"","url":"https://api.github.com/users/dpisarenko","html_url":"https://github.com/dpisarenko","followers_url":"https://api.github.com/users/dpisarenko/followers","following_url":"https://api.github.com/users/dpisarenko/following{/other_user}","gists_url":"https://api.github.com/users/dpisarenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dpisarenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpisarenko/subscriptions","organizations_url":"https://api.github.com/users/dpisarenko/orgs","repos_url":"https://api.github.com/users/dpisarenko/repos","events_url":"https://api.github.com/users/dpisarenko/events{/privacy}","received_events_url":"https://api.github.com/users/dpisarenko/received_events","type":"User","site_admin":false},"body":"Second pull request for fixing the issue https://github.com/yegor256/s3auth/issues/90 .\r\n\r\n**Notes:**\r\n\r\n1) Please not that in order to build the project, I need to use the 1.0-SNAPSHOT version of the jcabi-ssl-maven-plugin until the issue https://github.com/jcabi/jcabi-ssl-maven-plugin/issues/4 is fixed. I created a pull request with changes that will fix it.\r\n\r\n2) I'm getting lots of code quality errors like shown below, which I'm fixing now.\r\n\r\n```\r\n[ERROR] \\src\\main\\java\\com\\s3auth\\hosts\\DefaultDynamo.java[30]: Lines in file sh\r\nould end with Unix-like end of line (RegexpMultilineCheck)\r\n[ERROR] \\src\\main\\java\\com\\s3auth\\hosts\\DefaultDynamo.java[55]: Lines in file sh\r\nould end with Unix-like end of line (RegexpMultilineCheck)\r\n[ERROR] \\src\\main\\java\\com\\s3auth\\hosts\\DefaultDynamo.java[71]: Lines in file sh\r\nould end with Unix-like end of line (RegexpMultilineCheck)\r\n```\r\n\r\n3) The tests seem to run.","created_at":"2014-12-28T14:49:14Z","updated_at":"2015-01-02T18:11:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dec3149e73f7fae867bc5a6e7e4011deb83665fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yegor256/s3auth/pulls/239/commits","review_comments_url":"https://api.github.com/repos/yegor256/s3auth/pulls/239/comments","review_comment_url":"https://api.github.com/repos/yegor256/s3auth/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yegor256/s3auth/issues/239/comments","statuses_url":"https://api.github.com/repos/yegor256/s3auth/statuses/1485604bb7dc1bdb53f370b4a16650f02d154dd6","head":{"label":"dpisarenko:task-90","ref":"task-90","sha":"1485604bb7dc1bdb53f370b4a16650f02d154dd6","user":{"login":"dpisarenko","id":1143055,"avatar_url":"https://avatars.githubusercontent.com/u/1143055?v=3","gravatar_id":"","url":"https://api.github.com/users/dpisarenko","html_url":"https://github.com/dpisarenko","followers_url":"https://api.github.com/users/dpisarenko/followers","following_url":"https://api.github.com/users/dpisarenko/following{/other_user}","gists_url":"https://api.github.com/users/dpisarenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dpisarenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpisarenko/subscriptions","organizations_url":"https://api.github.com/users/dpisarenko/orgs","repos_url":"https://api.github.com/users/dpisarenko/repos","events_url":"https://api.github.com/users/dpisarenko/events{/privacy}","received_events_url":"https://api.github.com/users/dpisarenko/received_events","type":"User","site_admin":false},"repo":{"id":28488566,"name":"s3auth","full_name":"dpisarenko/s3auth","owner":{"login":"dpisarenko","id":1143055,"avatar_url":"https://avatars.githubusercontent.com/u/1143055?v=3","gravatar_id":"","url":"https://api.github.com/users/dpisarenko","html_url":"https://github.com/dpisarenko","followers_url":"https://api.github.com/users/dpisarenko/followers","following_url":"https://api.github.com/users/dpisarenko/following{/other_user}","gists_url":"https://api.github.com/users/dpisarenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dpisarenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpisarenko/subscriptions","organizations_url":"https://api.github.com/users/dpisarenko/orgs","repos_url":"https://api.github.com/users/dpisarenko/repos","events_url":"https://api.github.com/users/dpisarenko/events{/privacy}","received_events_url":"https://api.github.com/users/dpisarenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpisarenko/s3auth","description":"Amazon S3 HTTP Basic Auth Gateway","fork":true,"url":"https://api.github.com/repos/dpisarenko/s3auth","forks_url":"https://api.github.com/repos/dpisarenko/s3auth/forks","keys_url":"https://api.github.com/repos/dpisarenko/s3auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpisarenko/s3auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpisarenko/s3auth/teams","hooks_url":"https://api.github.com/repos/dpisarenko/s3auth/hooks","issue_events_url":"https://api.github.com/repos/dpisarenko/s3auth/issues/events{/number}","events_url":"https://api.github.com/repos/dpisarenko/s3auth/events","assignees_url":"https://api.github.com/repos/dpisarenko/s3auth/assignees{/user}","branches_url":"https://api.github.com/repos/dpisarenko/s3auth/branches{/branch}","tags_url":"https://api.github.com/repos/dpisarenko/s3auth/tags","blobs_url":"https://api.github.com/repos/dpisarenko/s3auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpisarenko/s3auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpisarenko/s3auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpisarenko/s3auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpisarenko/s3auth/statuses/{sha}","languages_url":"https://api.github.com/repos/dpisarenko/s3auth/languages","stargazers_url":"https://api.github.com/repos/dpisarenko/s3auth/stargazers","contributors_url":"https://api.github.com/repos/dpisarenko/s3auth/contributors","subscribers_url":"https://api.github.com/repos/dpisarenko/s3auth/subscribers","subscription_url":"https://api.github.com/repos/dpisarenko/s3auth/subscription","commits_url":"https://api.github.com/repos/dpisarenko/s3auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpisarenko/s3auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpisarenko/s3auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpisarenko/s3auth/issues/comments/{number}","contents_url":"https://api.github.com/repos/dpisarenko/s3auth/contents/{+path}","compare_url":"https://api.github.com/repos/dpisarenko/s3auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpisarenko/s3auth/merges","archive_url":"https://api.github.com/repos/dpisarenko/s3auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpisarenko/s3auth/downloads","issues_url":"https://api.github.com/repos/dpisarenko/s3auth/issues{/number}","pulls_url":"https://api.github.com/repos/dpisarenko/s3auth/pulls{/number}","milestones_url":"https://api.github.com/repos/dpisarenko/s3auth/milestones{/number}","notifications_url":"https://api.github.com/repos/dpisarenko/s3auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpisarenko/s3auth/labels{/name}","releases_url":"https://api.github.com/repos/dpisarenko/s3auth/releases{/id}","created_at":"2014-12-25T18:37:07Z","updated_at":"2014-12-27T11:24:11Z","pushed_at":"2015-01-02T13:56:56Z","git_url":"git://github.com/dpisarenko/s3auth.git","ssh_url":"git@github.com:dpisarenko/s3auth.git","clone_url":"https://github.com/dpisarenko/s3auth.git","svn_url":"https://github.com/dpisarenko/s3auth","homepage":"www.s3auth.com","size":2064,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yegor256:master","ref":"master","sha":"3d3dee4cc3bf26dbe1eb9af984f926f9fcaa1394","user":{"login":"yegor256","id":526301,"avatar_url":"https://avatars.githubusercontent.com/u/526301?v=3","gravatar_id":"","url":"https://api.github.com/users/yegor256","html_url":"https://github.com/yegor256","followers_url":"https://api.github.com/users/yegor256/followers","following_url":"https://api.github.com/users/yegor256/following{/other_user}","gists_url":"https://api.github.com/users/yegor256/gists{/gist_id}","starred_url":"https://api.github.com/users/yegor256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yegor256/subscriptions","organizations_url":"https://api.github.com/users/yegor256/orgs","repos_url":"https://api.github.com/users/yegor256/repos","events_url":"https://api.github.com/users/yegor256/events{/privacy}","received_events_url":"https://api.github.com/users/yegor256/received_events","type":"User","site_admin":false},"repo":{"id":5509523,"name":"s3auth","full_name":"yegor256/s3auth","owner":{"login":"yegor256","id":526301,"avatar_url":"https://avatars.githubusercontent.com/u/526301?v=3","gravatar_id":"","url":"https://api.github.com/users/yegor256","html_url":"https://github.com/yegor256","followers_url":"https://api.github.com/users/yegor256/followers","following_url":"https://api.github.com/users/yegor256/following{/other_user}","gists_url":"https://api.github.com/users/yegor256/gists{/gist_id}","starred_url":"https://api.github.com/users/yegor256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yegor256/subscriptions","organizations_url":"https://api.github.com/users/yegor256/orgs","repos_url":"https://api.github.com/users/yegor256/repos","events_url":"https://api.github.com/users/yegor256/events{/privacy}","received_events_url":"https://api.github.com/users/yegor256/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yegor256/s3auth","description":"Amazon S3 HTTP Basic Auth Gateway","fork":false,"url":"https://api.github.com/repos/yegor256/s3auth","forks_url":"https://api.github.com/repos/yegor256/s3auth/forks","keys_url":"https://api.github.com/repos/yegor256/s3auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yegor256/s3auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yegor256/s3auth/teams","hooks_url":"https://api.github.com/repos/yegor256/s3auth/hooks","issue_events_url":"https://api.github.com/repos/yegor256/s3auth/issues/events{/number}","events_url":"https://api.github.com/repos/yegor256/s3auth/events","assignees_url":"https://api.github.com/repos/yegor256/s3auth/assignees{/user}","branches_url":"https://api.github.com/repos/yegor256/s3auth/branches{/branch}","tags_url":"https://api.github.com/repos/yegor256/s3auth/tags","blobs_url":"https://api.github.com/repos/yegor256/s3auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yegor256/s3auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yegor256/s3auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/yegor256/s3auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yegor256/s3auth/statuses/{sha}","languages_url":"https://api.github.com/repos/yegor256/s3auth/languages","stargazers_url":"https://api.github.com/repos/yegor256/s3auth/stargazers","contributors_url":"https://api.github.com/repos/yegor256/s3auth/contributors","subscribers_url":"https://api.github.com/repos/yegor256/s3auth/subscribers","subscription_url":"https://api.github.com/repos/yegor256/s3auth/subscription","commits_url":"https://api.github.com/repos/yegor256/s3auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/yegor256/s3auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/yegor256/s3auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/yegor256/s3auth/issues/comments/{number}","contents_url":"https://api.github.com/repos/yegor256/s3auth/contents/{+path}","compare_url":"https://api.github.com/repos/yegor256/s3auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yegor256/s3auth/merges","archive_url":"https://api.github.com/repos/yegor256/s3auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yegor256/s3auth/downloads","issues_url":"https://api.github.com/repos/yegor256/s3auth/issues{/number}","pulls_url":"https://api.github.com/repos/yegor256/s3auth/pulls{/number}","milestones_url":"https://api.github.com/repos/yegor256/s3auth/milestones{/number}","notifications_url":"https://api.github.com/repos/yegor256/s3auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yegor256/s3auth/labels{/name}","releases_url":"https://api.github.com/repos/yegor256/s3auth/releases{/id}","created_at":"2012-08-22T13:05:16Z","updated_at":"2014-12-30T11:16:28Z","pushed_at":"2014-12-30T11:16:28Z","git_url":"git://github.com/yegor256/s3auth.git","ssh_url":"git@github.com:yegor256/s3auth.git","clone_url":"https://github.com/yegor256/s3auth.git","svn_url":"https://github.com/yegor256/s3auth","homepage":"www.s3auth.com","size":3566,"stargazers_count":48,"watchers_count":48,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":21,"forks":10,"open_issues":21,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yegor256/s3auth/pulls/239"},"html":{"href":"https://github.com/yegor256/s3auth/pull/239"},"issue":{"href":"https://api.github.com/repos/yegor256/s3auth/issues/239"},"comments":{"href":"https://api.github.com/repos/yegor256/s3auth/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/yegor256/s3auth/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/yegor256/s3auth/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yegor256/s3auth/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/yegor256/s3auth/statuses/1485604bb7dc1bdb53f370b4a16650f02d154dd6"}}}}