{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/33906715","id":33906715,"diff_hunk":"@@ -0,0 +1,106 @@\n+/*\n+ * Licensed to the University of California, Berkeley under one or more contributor license\n+ * agreements. See the NOTICE file distributed with this work for additional information regarding\n+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance with the License. You may obtain a\n+ * copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+\n+package tachyon.worker.block;\n+\n+import java.net.InetSocketAddress;\n+import java.util.LinkedHashMap;\n+import java.util.Map;\n+\n+import org.junit.AfterClass;\n+import org.junit.Assert;\n+import org.junit.Before;\n+import org.junit.BeforeClass;\n+import org.junit.Test;\n+\n+import tachyon.Constants;\n+import tachyon.conf.TachyonConf;\n+import tachyon.util.NetworkUtils;\n+\n+public class BlockWorkerUtilsTest {\n+  private static Map<String, String> sTestProperties = new LinkedHashMap<String, String>();\n+  private static Map<String, String> sNullMasterHostNameTestProperties =\n+      new LinkedHashMap<String, String>();\n+  private static Map<String, String> sNullMasterPortTestProperties =\n+      new LinkedHashMap<String, String>();\n+  private static Map<String, String> sNullTestProperties =\n+      new LinkedHashMap<String, String>();\n+\n+  private TachyonConf mCustomPropsTachyonConf;\n+  private TachyonConf mNullMasterHostNameTachyonConf;\n+  private TachyonConf mNullMasterPortTachyonConf;\n+  private TachyonConf mNullTachyonConf;\n+\n+  @BeforeClass\n+  public static void beforeClass() {\n+    // initialize the test properties.\n+    sTestProperties.put(Constants.MASTER_HOSTNAME, \"RemoteMaster1\");\n+    sTestProperties.put(Constants.MASTER_PORT, \"10000\");\n+    sTestProperties.put(Constants.WORKER_PORT, \"10001\");\n+\n+    // initialize the null master host name test properties.\n+    sNullMasterHostNameTestProperties.put(Constants.MASTER_PORT, \"20000\");\n+\n+    // initialize the null master port test properties.\n+    sNullMasterPortTestProperties.put(Constants.MASTER_HOSTNAME, \"RemoteMaster3\");\n+\n+  }\n+\n+  @Before\n+  public void beforeTests() {\n+    // init TachyonConf\n+    mCustomPropsTachyonConf = new TachyonConf(sTestProperties);\n+    mNullMasterHostNameTachyonConf = new TachyonConf(sNullMasterHostNameTestProperties);\n+    mNullMasterPortTachyonConf = new TachyonConf(sNullMasterPortTestProperties);\n+    mNullTachyonConf = new TachyonConf(sNullTestProperties);\n+  }\n+","path":"servers/src/test/java/tachyon/worker/block/BlockWorkerUtilsTest.java","position":69,"original_position":69,"commit_id":"aa24f15b8f598a24f9e7349e0f12e0a46d3cc69b","original_commit_id":"aa24f15b8f598a24f9e7349e0f12e0a46d3cc69b","user":{"login":"apc999","id":1413748,"avatar_url":"https://avatars.githubusercontent.com/u/1413748?v=3","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"body":"NIT: one extra line here?","created_at":"2015-07-06T05:25:28Z","updated_at":"2015-07-06T05:25:28Z","html_url":"https://github.com/amplab/tachyon/pull/1039#discussion_r33906715","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/1039","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/33906715"},"html":{"href":"https://github.com/amplab/tachyon/pull/1039#discussion_r33906715"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1039"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/1039","id":39233197,"html_url":"https://github.com/amplab/tachyon/pull/1039","diff_url":"https://github.com/amplab/tachyon/pull/1039.diff","patch_url":"https://github.com/amplab/tachyon/pull/1039.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/1039","number":1039,"state":"open","locked":false,"title":"[TACHYON-549] General Utilities","user":{"login":"Yours-shupeng","id":8843442,"avatar_url":"https://avatars.githubusercontent.com/u/8843442?v=3","gravatar_id":"","url":"https://api.github.com/users/Yours-shupeng","html_url":"https://github.com/Yours-shupeng","followers_url":"https://api.github.com/users/Yours-shupeng/followers","following_url":"https://api.github.com/users/Yours-shupeng/following{/other_user}","gists_url":"https://api.github.com/users/Yours-shupeng/gists{/gist_id}","starred_url":"https://api.github.com/users/Yours-shupeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yours-shupeng/subscriptions","organizations_url":"https://api.github.com/users/Yours-shupeng/orgs","repos_url":"https://api.github.com/users/Yours-shupeng/repos","events_url":"https://api.github.com/users/Yours-shupeng/events{/privacy}","received_events_url":"https://api.github.com/users/Yours-shupeng/received_events","type":"User","site_admin":false},"body":"We make `getMasterAddress()` and `getWorkerAddress()` utilities functions which are used in many classes. \r\nFollowing the last PR [1032](https://github.com/amplab/tachyon/pull/1032)","created_at":"2015-07-06T03:07:12Z","updated_at":"2015-07-06T05:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"feadb6c092fa7386853fa061435c38018dab9734","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/1039/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/1039/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/1039/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/aa24f15b8f598a24f9e7349e0f12e0a46d3cc69b","head":{"label":"PasaLab:TACHYON-549-V1","ref":"TACHYON-549-V1","sha":"aa24f15b8f598a24f9e7349e0f12e0a46d3cc69b","user":{"login":"PasaLab","id":6230048,"avatar_url":"https://avatars.githubusercontent.com/u/6230048?v=3","gravatar_id":"","url":"https://api.github.com/users/PasaLab","html_url":"https://github.com/PasaLab","followers_url":"https://api.github.com/users/PasaLab/followers","following_url":"https://api.github.com/users/PasaLab/following{/other_user}","gists_url":"https://api.github.com/users/PasaLab/gists{/gist_id}","starred_url":"https://api.github.com/users/PasaLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PasaLab/subscriptions","organizations_url":"https://api.github.com/users/PasaLab/orgs","repos_url":"https://api.github.com/users/PasaLab/repos","events_url":"https://api.github.com/users/PasaLab/events{/privacy}","received_events_url":"https://api.github.com/users/PasaLab/received_events","type":"Organization","site_admin":false},"repo":{"id":21603565,"name":"tachyon","full_name":"PasaLab/tachyon","owner":{"login":"PasaLab","id":6230048,"avatar_url":"https://avatars.githubusercontent.com/u/6230048?v=3","gravatar_id":"","url":"https://api.github.com/users/PasaLab","html_url":"https://github.com/PasaLab","followers_url":"https://api.github.com/users/PasaLab/followers","following_url":"https://api.github.com/users/PasaLab/following{/other_user}","gists_url":"https://api.github.com/users/PasaLab/gists{/gist_id}","starred_url":"https://api.github.com/users/PasaLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PasaLab/subscriptions","organizations_url":"https://api.github.com/users/PasaLab/orgs","repos_url":"https://api.github.com/users/PasaLab/repos","events_url":"https://api.github.com/users/PasaLab/events{/privacy}","received_events_url":"https://api.github.com/users/PasaLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PasaLab/tachyon","description":"Memory-centric Storage System for Big Data Analytics","fork":true,"url":"https://api.github.com/repos/PasaLab/tachyon","forks_url":"https://api.github.com/repos/PasaLab/tachyon/forks","keys_url":"https://api.github.com/repos/PasaLab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PasaLab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PasaLab/tachyon/teams","hooks_url":"https://api.github.com/repos/PasaLab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/PasaLab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/PasaLab/tachyon/events","assignees_url":"https://api.github.com/repos/PasaLab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/PasaLab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/PasaLab/tachyon/tags","blobs_url":"https://api.github.com/repos/PasaLab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PasaLab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PasaLab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/PasaLab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PasaLab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/PasaLab/tachyon/languages","stargazers_url":"https://api.github.com/repos/PasaLab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/PasaLab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/PasaLab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/PasaLab/tachyon/subscription","commits_url":"https://api.github.com/repos/PasaLab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/PasaLab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/PasaLab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/PasaLab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/PasaLab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/PasaLab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PasaLab/tachyon/merges","archive_url":"https://api.github.com/repos/PasaLab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PasaLab/tachyon/downloads","issues_url":"https://api.github.com/repos/PasaLab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/PasaLab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/PasaLab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/PasaLab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PasaLab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/PasaLab/tachyon/releases{/id}","created_at":"2014-07-08T07:42:41Z","updated_at":"2015-04-07T02:58:33Z","pushed_at":"2015-07-06T05:10:03Z","git_url":"git://github.com/PasaLab/tachyon.git","ssh_url":"git@github.com:PasaLab/tachyon.git","clone_url":"https://github.com/PasaLab/tachyon.git","svn_url":"https://github.com/PasaLab/tachyon","homepage":"http://tachyon-project.org","size":15243,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"07c56bbb4de0fa0a223aa0ecebce34bc0aeb0eab","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-07-06T01:53:21Z","pushed_at":"2015-07-06T03:21:38Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":34278,"stargazers_count":1468,"watchers_count":1468,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":539,"mirror_url":null,"open_issues_count":24,"forks":539,"open_issues":24,"watchers":1468,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1039"},"html":{"href":"https://github.com/amplab/tachyon/pull/1039"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1039"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1039/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1039/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1039/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/aa24f15b8f598a24f9e7349e0f12e0a46d3cc69b"}}}}