{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/38963722","id":38963722,"diff_hunk":"@@ -35,6 +35,8 @@ def parse_item(self):\n     Returning None will set the default frequency to one_time.\n     \"\"\"\n     if not self.raw_value:\n+      self.add_error(errors.MISSING_COLUMN, s=\"\",","path":"src/ggrc_workflows/converters/handlers.py","position":4,"original_position":4,"commit_id":"bca731526a98dc37647f3c4a01a672dbc66219b5","original_commit_id":"bca731526a98dc37647f3c4a01a672dbc66219b5","user":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"body":"I think that mandatory columns are handeled elesewhere. \r\n\r\nPlease just make sure that the frequency column is marked as mandatory and the error should be handeled.","created_at":"2015-09-08T18:42:18Z","updated_at":"2015-09-08T18:42:18Z","html_url":"https://github.com/google/ggrc-core/pull/3094#discussion_r38963722","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/3094","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/38963722"},"html":{"href":"https://github.com/google/ggrc-core/pull/3094#discussion_r38963722"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3094"}}},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/3094","id":44450702,"html_url":"https://github.com/google/ggrc-core/pull/3094","diff_url":"https://github.com/google/ggrc-core/pull/3094.diff","patch_url":"https://github.com/google/ggrc-core/pull/3094.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/3094","number":3094,"state":"open","locked":false,"title":"CORE-2330 Add missing column check to workflow frequency","user":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"body":"I still need to discuss with prasanna whether or not the Creator should always become the manager of the workflow he created.","created_at":"2015-09-08T16:03:21Z","updated_at":"2015-09-08T18:42:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e3c283c788e135a25616477579e8f2dc2f0c9e4","assignee":null,"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/18","html_url":"https://github.com/google/ggrc-core/milestones/0.9.4-Plum-P2","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/18/labels","id":1276098,"number":18,"title":"0.9.4-Plum-P2","description":null,"creator":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":27,"state":"open","created_at":"2015-08-27T16:20:13Z","updated_at":"2015-09-08T16:03:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/3094/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/3094/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/3094/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/bca731526a98dc37647f3c4a01a672dbc66219b5","head":{"label":"Smotko:feature/CORE-2330","ref":"feature/CORE-2330","sha":"bca731526a98dc37647f3c4a01a672dbc66219b5","user":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"repo":{"id":34512049,"name":"ggrc-core","full_name":"Smotko/ggrc-core","owner":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Smotko/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/Smotko/ggrc-core","forks_url":"https://api.github.com/repos/Smotko/ggrc-core/forks","keys_url":"https://api.github.com/repos/Smotko/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Smotko/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Smotko/ggrc-core/teams","hooks_url":"https://api.github.com/repos/Smotko/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/Smotko/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/Smotko/ggrc-core/events","assignees_url":"https://api.github.com/repos/Smotko/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/Smotko/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/Smotko/ggrc-core/tags","blobs_url":"https://api.github.com/repos/Smotko/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Smotko/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Smotko/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Smotko/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Smotko/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Smotko/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/Smotko/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/Smotko/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/Smotko/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/Smotko/ggrc-core/subscription","commits_url":"https://api.github.com/repos/Smotko/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Smotko/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Smotko/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Smotko/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Smotko/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/Smotko/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Smotko/ggrc-core/merges","archive_url":"https://api.github.com/repos/Smotko/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Smotko/ggrc-core/downloads","issues_url":"https://api.github.com/repos/Smotko/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/Smotko/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Smotko/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Smotko/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Smotko/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/Smotko/ggrc-core/releases{/id}","created_at":"2015-04-24T10:16:18Z","updated_at":"2015-04-28T09:04:59Z","pushed_at":"2015-09-08T16:02:22Z","git_url":"git://github.com/Smotko/ggrc-core.git","ssh_url":"git@github.com:Smotko/ggrc-core.git","clone_url":"https://github.com/Smotko/ggrc-core.git","svn_url":"https://github.com/Smotko/ggrc-core","homepage":null,"size":39713,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"google:develop","ref":"develop","sha":"f8938c8f2032978528f04896f4a72b01888d6bbf","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","created_at":"2013-04-08T19:16:28Z","updated_at":"2015-08-19T07:29:37Z","pushed_at":"2015-09-08T16:03:21Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":71287,"stargazers_count":34,"watchers_count":34,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":14,"forks":26,"open_issues":14,"watchers":34,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3094"},"html":{"href":"https://github.com/google/ggrc-core/pull/3094"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/3094"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/3094/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3094/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3094/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/bca731526a98dc37647f3c4a01a672dbc66219b5"}}}}