{"action":"closed","number":45,"pull_request":{"url":"https://api.github.com/repos/uProxy/ufo-management-server/pulls/45","id":53153971,"html_url":"https://github.com/uProxy/ufo-management-server/pull/45","diff_url":"https://github.com/uProxy/ufo-management-server/pull/45.diff","patch_url":"https://github.com/uProxy/ufo-management-server/pull/45.patch","issue_url":"https://api.github.com/repos/uProxy/ufo-management-server/issues/45","number":45,"state":"closed","locked":false,"title":"Requiring Dasher Admin Status as a Decorator for Using the Management Server","user":{"login":"xwsxethan","id":6269245,"avatar_url":"https://avatars.githubusercontent.com/u/6269245?v=3","gravatar_id":"","url":"https://api.github.com/users/xwsxethan","html_url":"https://github.com/xwsxethan","followers_url":"https://api.github.com/users/xwsxethan/followers","following_url":"https://api.github.com/users/xwsxethan/following{/other_user}","gists_url":"https://api.github.com/users/xwsxethan/gists{/gist_id}","starred_url":"https://api.github.com/users/xwsxethan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwsxethan/subscriptions","organizations_url":"https://api.github.com/users/xwsxethan/orgs","repos_url":"https://api.github.com/users/xwsxethan/repos","events_url":"https://api.github.com/users/xwsxethan/events{/privacy}","received_events_url":"https://api.github.com/users/xwsxethan/received_events","type":"User","site_admin":false},"body":"In order to implement this, we require some kind of oauth so that we can query the directory API for admin status. In the future, we could lessen the oauth grant to require only user access (since that is all that is needed to verify an admin) on most pages. The exception would be the add_user page which would still require group and member access (read only) in order to allow users to be imported via group. For now, all access is required for everything, which doesn't make things easier for users, but it does make us more secure until we implement different oauth decorators for different access levels.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/uproxy/ufo-management-server/45)\n<!-- Reviewable:end -->\n","created_at":"2015-12-09T17:51:39Z","updated_at":"2015-12-12T01:16:10Z","closed_at":"2015-12-12T01:16:10Z","merged_at":"2015-12-12T01:16:10Z","merge_commit_sha":"af1559a1f14a40266569033b058649773eb66169","assignee":{"login":"blueandgold","id":6977544,"avatar_url":"https://avatars.githubusercontent.com/u/6977544?v=3","gravatar_id":"","url":"https://api.github.com/users/blueandgold","html_url":"https://github.com/blueandgold","followers_url":"https://api.github.com/users/blueandgold/followers","following_url":"https://api.github.com/users/blueandgold/following{/other_user}","gists_url":"https://api.github.com/users/blueandgold/gists{/gist_id}","starred_url":"https://api.github.com/users/blueandgold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueandgold/subscriptions","organizations_url":"https://api.github.com/users/blueandgold/orgs","repos_url":"https://api.github.com/users/blueandgold/repos","events_url":"https://api.github.com/users/blueandgold/events{/privacy}","received_events_url":"https://api.github.com/users/blueandgold/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/uProxy/ufo-management-server/pulls/45/commits","review_comments_url":"https://api.github.com/repos/uProxy/ufo-management-server/pulls/45/comments","review_comment_url":"https://api.github.com/repos/uProxy/ufo-management-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uProxy/ufo-management-server/issues/45/comments","statuses_url":"https://api.github.com/repos/uProxy/ufo-management-server/statuses/6b2451e899e95c6752513c054384f232009a064b","head":{"label":"uProxy:admin","ref":"admin","sha":"6b2451e899e95c6752513c054384f232009a064b","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":42617495,"name":"ufo-management-server","full_name":"uProxy/ufo-management-server","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/ufo-management-server","description":"Management Server component of uProxy for Orgs","fork":false,"url":"https://api.github.com/repos/uProxy/ufo-management-server","forks_url":"https://api.github.com/repos/uProxy/ufo-management-server/forks","keys_url":"https://api.github.com/repos/uProxy/ufo-management-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/ufo-management-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/ufo-management-server/teams","hooks_url":"https://api.github.com/repos/uProxy/ufo-management-server/hooks","issue_events_url":"https://api.github.com/repos/uProxy/ufo-management-server/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/ufo-management-server/events","assignees_url":"https://api.github.com/repos/uProxy/ufo-management-server/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/ufo-management-server/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/ufo-management-server/tags","blobs_url":"https://api.github.com/repos/uProxy/ufo-management-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/ufo-management-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/ufo-management-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/ufo-management-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/ufo-management-server/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/ufo-management-server/languages","stargazers_url":"https://api.github.com/repos/uProxy/ufo-management-server/stargazers","contributors_url":"https://api.github.com/repos/uProxy/ufo-management-server/contributors","subscribers_url":"https://api.github.com/repos/uProxy/ufo-management-server/subscribers","subscription_url":"https://api.github.com/repos/uProxy/ufo-management-server/subscription","commits_url":"https://api.github.com/repos/uProxy/ufo-management-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/ufo-management-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/ufo-management-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/ufo-management-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/ufo-management-server/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/ufo-management-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/ufo-management-server/merges","archive_url":"https://api.github.com/repos/uProxy/ufo-management-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/ufo-management-server/downloads","issues_url":"https://api.github.com/repos/uProxy/ufo-management-server/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/ufo-management-server/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/ufo-management-server/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/ufo-management-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/ufo-management-server/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/ufo-management-server/releases{/id}","created_at":"2015-09-16T22:51:04Z","updated_at":"2015-12-08T15:10:48Z","pushed_at":"2015-12-12T01:16:10Z","git_url":"git://github.com/uProxy/ufo-management-server.git","ssh_url":"git@github.com:uProxy/ufo-management-server.git","clone_url":"https://github.com/uProxy/ufo-management-server.git","svn_url":"https://github.com/uProxy/ufo-management-server","homepage":null,"size":253,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"uProxy:master","ref":"master","sha":"4a3fcf639c8dbb26f5f2a6519144aa52bb7a753d","user":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"repo":{"id":42617495,"name":"ufo-management-server","full_name":"uProxy/ufo-management-server","owner":{"login":"uProxy","id":6548286,"avatar_url":"https://avatars.githubusercontent.com/u/6548286?v=3","gravatar_id":"","url":"https://api.github.com/users/uProxy","html_url":"https://github.com/uProxy","followers_url":"https://api.github.com/users/uProxy/followers","following_url":"https://api.github.com/users/uProxy/following{/other_user}","gists_url":"https://api.github.com/users/uProxy/gists{/gist_id}","starred_url":"https://api.github.com/users/uProxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uProxy/subscriptions","organizations_url":"https://api.github.com/users/uProxy/orgs","repos_url":"https://api.github.com/users/uProxy/repos","events_url":"https://api.github.com/users/uProxy/events{/privacy}","received_events_url":"https://api.github.com/users/uProxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uProxy/ufo-management-server","description":"Management Server component of uProxy for Orgs","fork":false,"url":"https://api.github.com/repos/uProxy/ufo-management-server","forks_url":"https://api.github.com/repos/uProxy/ufo-management-server/forks","keys_url":"https://api.github.com/repos/uProxy/ufo-management-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uProxy/ufo-management-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uProxy/ufo-management-server/teams","hooks_url":"https://api.github.com/repos/uProxy/ufo-management-server/hooks","issue_events_url":"https://api.github.com/repos/uProxy/ufo-management-server/issues/events{/number}","events_url":"https://api.github.com/repos/uProxy/ufo-management-server/events","assignees_url":"https://api.github.com/repos/uProxy/ufo-management-server/assignees{/user}","branches_url":"https://api.github.com/repos/uProxy/ufo-management-server/branches{/branch}","tags_url":"https://api.github.com/repos/uProxy/ufo-management-server/tags","blobs_url":"https://api.github.com/repos/uProxy/ufo-management-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uProxy/ufo-management-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uProxy/ufo-management-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/uProxy/ufo-management-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uProxy/ufo-management-server/statuses/{sha}","languages_url":"https://api.github.com/repos/uProxy/ufo-management-server/languages","stargazers_url":"https://api.github.com/repos/uProxy/ufo-management-server/stargazers","contributors_url":"https://api.github.com/repos/uProxy/ufo-management-server/contributors","subscribers_url":"https://api.github.com/repos/uProxy/ufo-management-server/subscribers","subscription_url":"https://api.github.com/repos/uProxy/ufo-management-server/subscription","commits_url":"https://api.github.com/repos/uProxy/ufo-management-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/uProxy/ufo-management-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/uProxy/ufo-management-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/uProxy/ufo-management-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/uProxy/ufo-management-server/contents/{+path}","compare_url":"https://api.github.com/repos/uProxy/ufo-management-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uProxy/ufo-management-server/merges","archive_url":"https://api.github.com/repos/uProxy/ufo-management-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uProxy/ufo-management-server/downloads","issues_url":"https://api.github.com/repos/uProxy/ufo-management-server/issues{/number}","pulls_url":"https://api.github.com/repos/uProxy/ufo-management-server/pulls{/number}","milestones_url":"https://api.github.com/repos/uProxy/ufo-management-server/milestones{/number}","notifications_url":"https://api.github.com/repos/uProxy/ufo-management-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uProxy/ufo-management-server/labels{/name}","releases_url":"https://api.github.com/repos/uProxy/ufo-management-server/releases{/id}","created_at":"2015-09-16T22:51:04Z","updated_at":"2015-12-08T15:10:48Z","pushed_at":"2015-12-12T01:16:10Z","git_url":"git://github.com/uProxy/ufo-management-server.git","ssh_url":"git@github.com:uProxy/ufo-management-server.git","clone_url":"https://github.com/uProxy/ufo-management-server.git","svn_url":"https://github.com/uProxy/ufo-management-server","homepage":null,"size":253,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uProxy/ufo-management-server/pulls/45"},"html":{"href":"https://github.com/uProxy/ufo-management-server/pull/45"},"issue":{"href":"https://api.github.com/repos/uProxy/ufo-management-server/issues/45"},"comments":{"href":"https://api.github.com/repos/uProxy/ufo-management-server/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/uProxy/ufo-management-server/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/uProxy/ufo-management-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uProxy/ufo-management-server/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/uProxy/ufo-management-server/statuses/6b2451e899e95c6752513c054384f232009a064b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"xwsxethan","id":6269245,"avatar_url":"https://avatars.githubusercontent.com/u/6269245?v=3","gravatar_id":"","url":"https://api.github.com/users/xwsxethan","html_url":"https://github.com/xwsxethan","followers_url":"https://api.github.com/users/xwsxethan/followers","following_url":"https://api.github.com/users/xwsxethan/following{/other_user}","gists_url":"https://api.github.com/users/xwsxethan/gists{/gist_id}","starred_url":"https://api.github.com/users/xwsxethan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwsxethan/subscriptions","organizations_url":"https://api.github.com/users/xwsxethan/orgs","repos_url":"https://api.github.com/users/xwsxethan/repos","events_url":"https://api.github.com/users/xwsxethan/events{/privacy}","received_events_url":"https://api.github.com/users/xwsxethan/received_events","type":"User","site_admin":false},"comments":6,"review_comments":9,"commits":8,"additions":137,"deletions":76,"changed_files":9}}