{"action":"created","comment":{"url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/comments/30614870","id":30614870,"diff_hunk":"@@ -66,33 +79,65 @@ def get_idp_metadata(url, validate_cert)\n         meta_text\n       end\n \n+      # @return [String|nil] IdP Entity ID value if exists\n+      #\n       def idp_entity_id\n-        node = REXML::XPath.first(document, \"/md:EntityDescriptor/@entityID\", { \"md\" => METADATA })\n+        node = REXML::XPath.first(","path":"lib/onelogin/ruby-saml/idp_metadata_parser.rb","position":55,"original_position":55,"commit_id":"3290ed45f6af8fbf21ba293ff242692dc7a89f01","original_commit_id":"3290ed45f6af8fbf21ba293ff242692dc7a89f01","user":{"login":"irvingreid","id":3908011,"avatar_url":"https://avatars.githubusercontent.com/u/3908011?v=3","gravatar_id":"","url":"https://api.github.com/users/irvingreid","html_url":"https://github.com/irvingreid","followers_url":"https://api.github.com/users/irvingreid/followers","following_url":"https://api.github.com/users/irvingreid/following{/other_user}","gists_url":"https://api.github.com/users/irvingreid/gists{/gist_id}","starred_url":"https://api.github.com/users/irvingreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irvingreid/subscriptions","organizations_url":"https://api.github.com/users/irvingreid/orgs","repos_url":"https://api.github.com/users/irvingreid/repos","events_url":"https://api.github.com/users/irvingreid/events{/privacy}","received_events_url":"https://api.github.com/users/irvingreid/received_events","type":"User","site_admin":false},"body":"Do all of these value accessors guarantee that the value was fetched from a part of the SAML response that was covered by the XMLDSIG signature? There have been successful attacks on SAML implementations by sending assertions with additional fields that were not covered by the signature, but were trusted because the parts of the assertion that were signed were valid.","created_at":"2015-05-19T15:58:50Z","updated_at":"2015-05-19T15:58:50Z","html_url":"https://github.com/onelogin/ruby-saml/pull/197#discussion_r30614870","pull_request_url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/197","_links":{"self":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/comments/30614870"},"html":{"href":"https://github.com/onelogin/ruby-saml/pull/197#discussion_r30614870"},"pull_request":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/197"}}},"pull_request":{"url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/197","id":30411741,"html_url":"https://github.com/onelogin/ruby-saml/pull/197","diff_url":"https://github.com/onelogin/ruby-saml/pull/197.diff","patch_url":"https://github.com/onelogin/ruby-saml/pull/197.patch","issue_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/197","number":197,"state":"open","locked":false,"title":"Add SAML Response, Logout Request and Logout Response validations. Add also tests and documentation","user":{"login":"pitbulk","id":600897,"avatar_url":"https://avatars.githubusercontent.com/u/600897?v=3","gravatar_id":"","url":"https://api.github.com/users/pitbulk","html_url":"https://github.com/pitbulk","followers_url":"https://api.github.com/users/pitbulk/followers","following_url":"https://api.github.com/users/pitbulk/following{/other_user}","gists_url":"https://api.github.com/users/pitbulk/gists{/gist_id}","starred_url":"https://api.github.com/users/pitbulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitbulk/subscriptions","organizations_url":"https://api.github.com/users/pitbulk/orgs","repos_url":"https://api.github.com/users/pitbulk/repos","events_url":"https://api.github.com/users/pitbulk/events{/privacy}","received_events_url":"https://api.github.com/users/pitbulk/received_events","type":"User","site_admin":false},"body":"This PR is a meta-PR:\r\n* Add SAML Response, Logout Request and Logout Response validations. (based on this old PR: https://github.com/onelogin/ruby-saml/pull/115)\r\n* Add tests (high coverage, use of Minitest)\r\n* Add HTTP-Redirect Binding Validation Sign (https://github.com/onelogin/ruby-saml/commit/42a7bbd04b730bf248e33591aa0139da2098b4d5)\r\n* Add documentation to the README (https://github.com/onelogin/ruby-saml/issues/187, https://github.com/onelogin/ruby-saml/issues/186) and in the code (YARD style)\r\n* Fix XMLSecurity class: (SHA1 vs RSA_SHA1 issue)\r\n* Ensure IdP certificate is formatted properly (Related to https://github.com/onelogin/ruby-saml/pull/176)\r\n","created_at":"2015-03-03T20:56:38Z","updated_at":"2015-05-19T15:58:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"847e2a5c6a4afb77493264484f869ea3bc6b19e2","assignee":{"login":"pitbulk","id":600897,"avatar_url":"https://avatars.githubusercontent.com/u/600897?v=3","gravatar_id":"","url":"https://api.github.com/users/pitbulk","html_url":"https://github.com/pitbulk","followers_url":"https://api.github.com/users/pitbulk/followers","following_url":"https://api.github.com/users/pitbulk/following{/other_user}","gists_url":"https://api.github.com/users/pitbulk/gists{/gist_id}","starred_url":"https://api.github.com/users/pitbulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitbulk/subscriptions","organizations_url":"https://api.github.com/users/pitbulk/orgs","repos_url":"https://api.github.com/users/pitbulk/repos","events_url":"https://api.github.com/users/pitbulk/events{/privacy}","received_events_url":"https://api.github.com/users/pitbulk/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/197/commits","review_comments_url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/197/comments","review_comment_url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/197/comments","statuses_url":"https://api.github.com/repos/onelogin/ruby-saml/statuses/3290ed45f6af8fbf21ba293ff242692dc7a89f01","head":{"label":"onelogin:response_validations","ref":"response_validations","sha":"3290ed45f6af8fbf21ba293ff242692dc7a89f01","user":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?v=3","gravatar_id":"","url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"repo":{"id":644899,"name":"ruby-saml","full_name":"onelogin/ruby-saml","owner":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?v=3","gravatar_id":"","url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onelogin/ruby-saml","description":"SAML SSO for Ruby","fork":false,"url":"https://api.github.com/repos/onelogin/ruby-saml","forks_url":"https://api.github.com/repos/onelogin/ruby-saml/forks","keys_url":"https://api.github.com/repos/onelogin/ruby-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onelogin/ruby-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onelogin/ruby-saml/teams","hooks_url":"https://api.github.com/repos/onelogin/ruby-saml/hooks","issue_events_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/events{/number}","events_url":"https://api.github.com/repos/onelogin/ruby-saml/events","assignees_url":"https://api.github.com/repos/onelogin/ruby-saml/assignees{/user}","branches_url":"https://api.github.com/repos/onelogin/ruby-saml/branches{/branch}","tags_url":"https://api.github.com/repos/onelogin/ruby-saml/tags","blobs_url":"https://api.github.com/repos/onelogin/ruby-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onelogin/ruby-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onelogin/ruby-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/onelogin/ruby-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onelogin/ruby-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/onelogin/ruby-saml/languages","stargazers_url":"https://api.github.com/repos/onelogin/ruby-saml/stargazers","contributors_url":"https://api.github.com/repos/onelogin/ruby-saml/contributors","subscribers_url":"https://api.github.com/repos/onelogin/ruby-saml/subscribers","subscription_url":"https://api.github.com/repos/onelogin/ruby-saml/subscription","commits_url":"https://api.github.com/repos/onelogin/ruby-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/onelogin/ruby-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/onelogin/ruby-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/onelogin/ruby-saml/contents/{+path}","compare_url":"https://api.github.com/repos/onelogin/ruby-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onelogin/ruby-saml/merges","archive_url":"https://api.github.com/repos/onelogin/ruby-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onelogin/ruby-saml/downloads","issues_url":"https://api.github.com/repos/onelogin/ruby-saml/issues{/number}","pulls_url":"https://api.github.com/repos/onelogin/ruby-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/onelogin/ruby-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/onelogin/ruby-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onelogin/ruby-saml/labels{/name}","releases_url":"https://api.github.com/repos/onelogin/ruby-saml/releases{/id}","created_at":"2010-05-03T18:39:04Z","updated_at":"2015-05-18T07:17:17Z","pushed_at":"2015-05-19T00:21:10Z","git_url":"git://github.com/onelogin/ruby-saml.git","ssh_url":"git@github.com:onelogin/ruby-saml.git","clone_url":"https://github.com/onelogin/ruby-saml.git","svn_url":"https://github.com/onelogin/ruby-saml","homepage":"http://support.onelogin.com/entries/165434-saml-toolkit-for-ruby-on-rails","size":4190,"stargazers_count":318,"watchers_count":318,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":263,"mirror_url":null,"open_issues_count":22,"forks":263,"open_issues":22,"watchers":318,"default_branch":"master"}},"base":{"label":"onelogin:master","ref":"master","sha":"f5e5a1b907f2618eeea689029c04a2cf9d9f4d3b","user":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?v=3","gravatar_id":"","url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"repo":{"id":644899,"name":"ruby-saml","full_name":"onelogin/ruby-saml","owner":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?v=3","gravatar_id":"","url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onelogin/ruby-saml","description":"SAML SSO for Ruby","fork":false,"url":"https://api.github.com/repos/onelogin/ruby-saml","forks_url":"https://api.github.com/repos/onelogin/ruby-saml/forks","keys_url":"https://api.github.com/repos/onelogin/ruby-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onelogin/ruby-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onelogin/ruby-saml/teams","hooks_url":"https://api.github.com/repos/onelogin/ruby-saml/hooks","issue_events_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/events{/number}","events_url":"https://api.github.com/repos/onelogin/ruby-saml/events","assignees_url":"https://api.github.com/repos/onelogin/ruby-saml/assignees{/user}","branches_url":"https://api.github.com/repos/onelogin/ruby-saml/branches{/branch}","tags_url":"https://api.github.com/repos/onelogin/ruby-saml/tags","blobs_url":"https://api.github.com/repos/onelogin/ruby-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onelogin/ruby-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onelogin/ruby-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/onelogin/ruby-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onelogin/ruby-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/onelogin/ruby-saml/languages","stargazers_url":"https://api.github.com/repos/onelogin/ruby-saml/stargazers","contributors_url":"https://api.github.com/repos/onelogin/ruby-saml/contributors","subscribers_url":"https://api.github.com/repos/onelogin/ruby-saml/subscribers","subscription_url":"https://api.github.com/repos/onelogin/ruby-saml/subscription","commits_url":"https://api.github.com/repos/onelogin/ruby-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/onelogin/ruby-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/onelogin/ruby-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/onelogin/ruby-saml/contents/{+path}","compare_url":"https://api.github.com/repos/onelogin/ruby-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onelogin/ruby-saml/merges","archive_url":"https://api.github.com/repos/onelogin/ruby-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onelogin/ruby-saml/downloads","issues_url":"https://api.github.com/repos/onelogin/ruby-saml/issues{/number}","pulls_url":"https://api.github.com/repos/onelogin/ruby-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/onelogin/ruby-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/onelogin/ruby-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onelogin/ruby-saml/labels{/name}","releases_url":"https://api.github.com/repos/onelogin/ruby-saml/releases{/id}","created_at":"2010-05-03T18:39:04Z","updated_at":"2015-05-18T07:17:17Z","pushed_at":"2015-05-19T00:21:10Z","git_url":"git://github.com/onelogin/ruby-saml.git","ssh_url":"git@github.com:onelogin/ruby-saml.git","clone_url":"https://github.com/onelogin/ruby-saml.git","svn_url":"https://github.com/onelogin/ruby-saml","homepage":"http://support.onelogin.com/entries/165434-saml-toolkit-for-ruby-on-rails","size":4190,"stargazers_count":318,"watchers_count":318,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":263,"mirror_url":null,"open_issues_count":22,"forks":263,"open_issues":22,"watchers":318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/197"},"html":{"href":"https://github.com/onelogin/ruby-saml/pull/197"},"issue":{"href":"https://api.github.com/repos/onelogin/ruby-saml/issues/197"},"comments":{"href":"https://api.github.com/repos/onelogin/ruby-saml/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onelogin/ruby-saml/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/onelogin/ruby-saml/statuses/3290ed45f6af8fbf21ba293ff242692dc7a89f01"}}}}