{"action":"created","issue":{"url":"https://api.github.com/repos/deis/deis/issues/2888","labels_url":"https://api.github.com/repos/deis/deis/issues/2888/labels{/name}","comments_url":"https://api.github.com/repos/deis/deis/issues/2888/comments","events_url":"https://api.github.com/repos/deis/deis/issues/2888/events","html_url":"https://github.com/deis/deis/pull/2888","id":54199270,"number":2888,"title":"fix(builder): return the error message from the controller","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=3","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/deis/milestones/34","labels_url":"https://api.github.com/repos/deis/deis/milestones/34/labels","id":898360,"number":34,"title":"v1.3","description":"","creator":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=3","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":17,"state":"open","created_at":"2014-12-10T04:45:39Z","updated_at":"2015-01-15T16:21:34Z","due_on":"2015-02-03T07:00:00Z","closed_at":null},"comments":2,"created_at":"2015-01-13T14:27:08Z","updated_at":"2015-01-15T18:39:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/deis/deis/pulls/2888","html_url":"https://github.com/deis/deis/pull/2888","diff_url":"https://github.com/deis/deis/pull/2888.diff","patch_url":"https://github.com/deis/deis/pull/2888.patch"},"body":"Append the message after the generic error message\r\n\r\nhelps to #2883"},"comment":{"url":"https://api.github.com/repos/deis/deis/issues/comments/70137116","html_url":"https://github.com/deis/deis/pull/2888#issuecomment-70137116","issue_url":"https://api.github.com/repos/deis/deis/issues/2888","id":70137116,"user":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=3","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"created_at":"2015-01-15T18:39:19Z","updated_at":"2015-01-15T18:39:19Z","body":"This didn't seem to work for me in testing, I was still getting the generic error message even through the controller had this:\r\n```\r\nJan 15 18:36:43 deis-2 sh[3011]: File \"/app/api/models.py\", line 168, in scale\r\nJan 15 18:36:43 deis-2 sh[3011]: 'Container type {} does not exist in application'.format(container_type))\r\nJan 15 18:36:43 deis-2 sh[3011]: EnvironmentError: Container type web does not exist in application\r\nJan 15 18:36:43 deis-2 sh[3011]: 172.17.8.100 \"POST /v1/hooks/build HTTP/1.1\" 500 - \"deis-builder\"\r\n```\r\nI got the same generic error message when I tried to `git push deis master` without having added a key. Should this PR be covering those cases, or should I be testing other specific failures?"}}