{"action":"created","issue":{"url":"https://api.github.com/repos/opf/openproject/issues/3296","labels_url":"https://api.github.com/repos/opf/openproject/issues/3296/labels{/name}","comments_url":"https://api.github.com/repos/opf/openproject/issues/3296/comments","events_url":"https://api.github.com/repos/opf/openproject/issues/3296/events","html_url":"https://github.com/opf/openproject/pull/3296","id":98690522,"number":3296,"title":"Git adapter encoding handling","user":{"login":"oliverguenther","id":459462,"avatar_url":"https://avatars.githubusercontent.com/u/459462?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverguenther","html_url":"https://github.com/oliverguenther","followers_url":"https://api.github.com/users/oliverguenther/followers","following_url":"https://api.github.com/users/oliverguenther/following{/other_user}","gists_url":"https://api.github.com/users/oliverguenther/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverguenther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverguenther/subscriptions","organizations_url":"https://api.github.com/users/oliverguenther/orgs","repos_url":"https://api.github.com/users/oliverguenther/repos","events_url":"https://api.github.com/users/oliverguenther/events{/privacy}","received_events_url":"https://api.github.com/users/oliverguenther/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/opf/openproject/labels/bugfix","name":"bugfix","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/opf/openproject/milestones/3","html_url":"https://github.com/opf/openproject/milestones/4.3","labels_url":"https://api.github.com/repos/opf/openproject/milestones/3/labels","id":1104474,"number":3,"title":"4.3","description":"","creator":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":21,"state":"open","created_at":"2015-05-11T10:04:28Z","updated_at":"2015-08-04T07:32:45Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-08-03T07:53:44Z","updated_at":"2015-08-04T09:45:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/3296","html_url":"https://github.com/opf/openproject/pull/3296","diff_url":"https://github.com/opf/openproject/pull/3296.diff","patch_url":"https://github.com/opf/openproject/pull/3296.patch"},"body":"The git adapter currently has a bug that denies to annotate regular\r\ntext files when the author name has an umlaut.\r\n\r\nThis commit changes the binary file detection by simply counting null\r\nbytes. This may not detect all binary files correctly, but that isn't a\r\nrequirement.\r\n\r\nThe original check was arguably used to avoid rendering large binary\r\nfiles in the browser.\r\n\r\nThis also re-introduces the path encoding from 4.2, which was seemingly lost in the new form.\r\n\r\nRelevant bug report: https://community.openproject.org/work_packages/20883"},"comment":{"url":"https://api.github.com/repos/opf/openproject/issues/comments/127545403","html_url":"https://github.com/opf/openproject/pull/3296#issuecomment-127545403","issue_url":"https://api.github.com/repos/opf/openproject/issues/3296","id":127545403,"user":{"login":"NobodysNightmare","id":453584,"avatar_url":"https://avatars.githubusercontent.com/u/453584?v=3","gravatar_id":"","url":"https://api.github.com/users/NobodysNightmare","html_url":"https://github.com/NobodysNightmare","followers_url":"https://api.github.com/users/NobodysNightmare/followers","following_url":"https://api.github.com/users/NobodysNightmare/following{/other_user}","gists_url":"https://api.github.com/users/NobodysNightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/NobodysNightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NobodysNightmare/subscriptions","organizations_url":"https://api.github.com/users/NobodysNightmare/orgs","repos_url":"https://api.github.com/users/NobodysNightmare/repos","events_url":"https://api.github.com/users/NobodysNightmare/events{/privacy}","received_events_url":"https://api.github.com/users/NobodysNightmare/received_events","type":"User","site_admin":false},"created_at":"2015-08-04T09:45:03Z","updated_at":"2015-08-04T09:45:03Z","body":"> This commit changes the binary file detection by simply counting null bytes.\r\n\r\nI think this is not a good idea, thinking of UTF-16 encoded text files..."}}