{"action":"created","comment":{"url":"https://api.github.com/repos/mesos/mesos-go/pulls/comments/31315835","id":31315835,"diff_hunk":"@@ -124,21 +128,51 @@ func (md *MasterDetector) childrenChanged(zkc *Client, path string, obs detector\n \n \tvar masterInfo *mesos.MasterInfo\n \tif md.leaderNode != \"\" {\n-\t\tdata, err := zkc.data(fmt.Sprintf(\"%s/%s\", path, topNode))\n-\t\tif err != nil {\n-\t\t\tlog.Errorf(\"unable to retrieve leader data: %v\", err.Error())\n-\t\t\treturn\n+\t\tvar err error\n+\t\tif masterInfo, err = md.pullMasterInfo(path, topNode); err != nil {\n+\t\t\tlog.Errorln(err.Error())\n \t\t}\n+\t}\n+\tlog.V(2).Infof(\"detected master info: %+v\", masterInfo)\n+\n+\t//TODO(jdef) recover from possible client callback panic here, so that it doesn't","path":"detector/zoo/detect.go","position":29,"original_position":29,"commit_id":"a645799bf4cc98534fa7bdd2b3eaec3301123f57","original_commit_id":"a645799bf4cc98534fa7bdd2b3eaec3301123f57","user":{"login":"vladimirvivien","id":309126,"avatar_url":"https://avatars.githubusercontent.com/u/309126?v=3","gravatar_id":"","url":"https://api.github.com/users/vladimirvivien","html_url":"https://github.com/vladimirvivien","followers_url":"https://api.github.com/users/vladimirvivien/followers","following_url":"https://api.github.com/users/vladimirvivien/following{/other_user}","gists_url":"https://api.github.com/users/vladimirvivien/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimirvivien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimirvivien/subscriptions","organizations_url":"https://api.github.com/users/vladimirvivien/orgs","repos_url":"https://api.github.com/users/vladimirvivien/repos","events_url":"https://api.github.com/users/vladimirvivien/events{/privacy}","received_events_url":"https://api.github.com/users/vladimirvivien/received_events","type":"User","site_admin":false},"body":"@tsenart Why the explicit panic recovery ?","created_at":"2015-05-29T11:10:42Z","updated_at":"2015-05-29T11:10:42Z","html_url":"https://github.com/mesos/mesos-go/pull/111#discussion_r31315835","pull_request_url":"https://api.github.com/repos/mesos/mesos-go/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/comments/31315835"},"html":{"href":"https://github.com/mesos/mesos-go/pull/111#discussion_r31315835"},"pull_request":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/mesos/mesos-go/pulls/111","id":33073790,"html_url":"https://github.com/mesos/mesos-go/pull/111","diff_url":"https://github.com/mesos/mesos-go/pull/111.diff","patch_url":"https://github.com/mesos/mesos-go/pull/111.patch","issue_url":"https://api.github.com/repos/mesos/mesos-go/issues/111","number":111,"state":"open","locked":false,"title":"zk api extension","user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"body":"/cc @kozyraki\r\n\r\nresolves #110 \r\n\r\nTODO:\r\n- [x] unit tests","created_at":"2015-04-10T18:58:51Z","updated_at":"2015-05-29T11:10:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e845d41c7eeefa23bc8b1aa0555661175ffcbb00","assignee":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mesos/mesos-go/pulls/111/commits","review_comments_url":"https://api.github.com/repos/mesos/mesos-go/pulls/111/comments","review_comment_url":"https://api.github.com/repos/mesos/mesos-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesos/mesos-go/issues/111/comments","statuses_url":"https://api.github.com/repos/mesos/mesos-go/statuses/a645799bf4cc98534fa7bdd2b3eaec3301123f57","head":{"label":"mesos:zk_api_extension","ref":"zk_api_extension","sha":"a645799bf4cc98534fa7bdd2b3eaec3301123f57","user":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"repo":{"id":14454411,"name":"mesos-go","full_name":"mesos/mesos-go","owner":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesos/mesos-go","description":"Go language bindings for Apache Mesos","fork":false,"url":"https://api.github.com/repos/mesos/mesos-go","forks_url":"https://api.github.com/repos/mesos/mesos-go/forks","keys_url":"https://api.github.com/repos/mesos/mesos-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesos/mesos-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesos/mesos-go/teams","hooks_url":"https://api.github.com/repos/mesos/mesos-go/hooks","issue_events_url":"https://api.github.com/repos/mesos/mesos-go/issues/events{/number}","events_url":"https://api.github.com/repos/mesos/mesos-go/events","assignees_url":"https://api.github.com/repos/mesos/mesos-go/assignees{/user}","branches_url":"https://api.github.com/repos/mesos/mesos-go/branches{/branch}","tags_url":"https://api.github.com/repos/mesos/mesos-go/tags","blobs_url":"https://api.github.com/repos/mesos/mesos-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesos/mesos-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesos/mesos-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesos/mesos-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesos/mesos-go/statuses/{sha}","languages_url":"https://api.github.com/repos/mesos/mesos-go/languages","stargazers_url":"https://api.github.com/repos/mesos/mesos-go/stargazers","contributors_url":"https://api.github.com/repos/mesos/mesos-go/contributors","subscribers_url":"https://api.github.com/repos/mesos/mesos-go/subscribers","subscription_url":"https://api.github.com/repos/mesos/mesos-go/subscription","commits_url":"https://api.github.com/repos/mesos/mesos-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesos/mesos-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesos/mesos-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesos/mesos-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesos/mesos-go/contents/{+path}","compare_url":"https://api.github.com/repos/mesos/mesos-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesos/mesos-go/merges","archive_url":"https://api.github.com/repos/mesos/mesos-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesos/mesos-go/downloads","issues_url":"https://api.github.com/repos/mesos/mesos-go/issues{/number}","pulls_url":"https://api.github.com/repos/mesos/mesos-go/pulls{/number}","milestones_url":"https://api.github.com/repos/mesos/mesos-go/milestones{/number}","notifications_url":"https://api.github.com/repos/mesos/mesos-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesos/mesos-go/labels{/name}","releases_url":"https://api.github.com/repos/mesos/mesos-go/releases{/id}","created_at":"2013-11-16T20:40:30Z","updated_at":"2015-05-29T07:12:44Z","pushed_at":"2015-05-28T15:28:15Z","git_url":"git://github.com/mesos/mesos-go.git","ssh_url":"git@github.com:mesos/mesos-go.git","clone_url":"https://github.com/mesos/mesos-go.git","svn_url":"https://github.com/mesos/mesos-go","homepage":"","size":10360,"stargazers_count":199,"watchers_count":199,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":25,"forks":46,"open_issues":25,"watchers":199,"default_branch":"master"}},"base":{"label":"mesos:master","ref":"master","sha":"764179593f8c074e376b836113e39b35fa1ad000","user":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"repo":{"id":14454411,"name":"mesos-go","full_name":"mesos/mesos-go","owner":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesos/mesos-go","description":"Go language bindings for Apache Mesos","fork":false,"url":"https://api.github.com/repos/mesos/mesos-go","forks_url":"https://api.github.com/repos/mesos/mesos-go/forks","keys_url":"https://api.github.com/repos/mesos/mesos-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesos/mesos-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesos/mesos-go/teams","hooks_url":"https://api.github.com/repos/mesos/mesos-go/hooks","issue_events_url":"https://api.github.com/repos/mesos/mesos-go/issues/events{/number}","events_url":"https://api.github.com/repos/mesos/mesos-go/events","assignees_url":"https://api.github.com/repos/mesos/mesos-go/assignees{/user}","branches_url":"https://api.github.com/repos/mesos/mesos-go/branches{/branch}","tags_url":"https://api.github.com/repos/mesos/mesos-go/tags","blobs_url":"https://api.github.com/repos/mesos/mesos-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesos/mesos-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesos/mesos-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesos/mesos-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesos/mesos-go/statuses/{sha}","languages_url":"https://api.github.com/repos/mesos/mesos-go/languages","stargazers_url":"https://api.github.com/repos/mesos/mesos-go/stargazers","contributors_url":"https://api.github.com/repos/mesos/mesos-go/contributors","subscribers_url":"https://api.github.com/repos/mesos/mesos-go/subscribers","subscription_url":"https://api.github.com/repos/mesos/mesos-go/subscription","commits_url":"https://api.github.com/repos/mesos/mesos-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesos/mesos-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesos/mesos-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesos/mesos-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesos/mesos-go/contents/{+path}","compare_url":"https://api.github.com/repos/mesos/mesos-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesos/mesos-go/merges","archive_url":"https://api.github.com/repos/mesos/mesos-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesos/mesos-go/downloads","issues_url":"https://api.github.com/repos/mesos/mesos-go/issues{/number}","pulls_url":"https://api.github.com/repos/mesos/mesos-go/pulls{/number}","milestones_url":"https://api.github.com/repos/mesos/mesos-go/milestones{/number}","notifications_url":"https://api.github.com/repos/mesos/mesos-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesos/mesos-go/labels{/name}","releases_url":"https://api.github.com/repos/mesos/mesos-go/releases{/id}","created_at":"2013-11-16T20:40:30Z","updated_at":"2015-05-29T07:12:44Z","pushed_at":"2015-05-28T15:28:15Z","git_url":"git://github.com/mesos/mesos-go.git","ssh_url":"git@github.com:mesos/mesos-go.git","clone_url":"https://github.com/mesos/mesos-go.git","svn_url":"https://github.com/mesos/mesos-go","homepage":"","size":10360,"stargazers_count":199,"watchers_count":199,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":25,"forks":46,"open_issues":25,"watchers":199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/111"},"html":{"href":"https://github.com/mesos/mesos-go/pull/111"},"issue":{"href":"https://api.github.com/repos/mesos/mesos-go/issues/111"},"comments":{"href":"https://api.github.com/repos/mesos/mesos-go/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesos/mesos-go/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/mesos/mesos-go/statuses/a645799bf4cc98534fa7bdd2b3eaec3301123f57"}}}}