{"action":"created","comment":{"url":"https://api.github.com/repos/wmde/DataTypes/pulls/comments/36440249","id":36440249,"diff_hunk":"@@ -2,19 +2,11 @@\n \n namespace DataTypes;\n \n-use InvalidArgumentException;\n use OutOfBoundsException;\n-use RuntimeException;\n+use Wikimedia\\Assert\\Assert;\n \n /**\n- * @deprecated since 0.1","path":"src/DataTypeFactory.php","position":10,"original_position":10,"commit_id":"1948efc95068e00fbfc85ffb20f1102432aa09ca","original_commit_id":"1948efc95068e00fbfc85ffb20f1102432aa09ca","user":{"login":"brightbyte","id":664717,"avatar_url":"https://avatars.githubusercontent.com/u/664717?v=3","gravatar_id":"","url":"https://api.github.com/users/brightbyte","html_url":"https://github.com/brightbyte","followers_url":"https://api.github.com/users/brightbyte/followers","following_url":"https://api.github.com/users/brightbyte/following{/other_user}","gists_url":"https://api.github.com/users/brightbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/brightbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brightbyte/subscriptions","organizations_url":"https://api.github.com/users/brightbyte/orgs","repos_url":"https://api.github.com/users/brightbyte/repos","events_url":"https://api.github.com/users/brightbyte/events{/privacy}","received_events_url":"https://api.github.com/users/brightbyte/received_events","type":"User","site_admin":false},"body":"This class has existed from the beginning, I think.","created_at":"2015-08-06T17:16:00Z","updated_at":"2015-08-06T17:16:00Z","html_url":"https://github.com/wmde/DataTypes/pull/34#discussion_r36440249","pull_request_url":"https://api.github.com/repos/wmde/DataTypes/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/wmde/DataTypes/pulls/comments/36440249"},"html":{"href":"https://github.com/wmde/DataTypes/pull/34#discussion_r36440249"},"pull_request":{"href":"https://api.github.com/repos/wmde/DataTypes/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/wmde/DataTypes/pulls/34","id":41576582,"html_url":"https://github.com/wmde/DataTypes/pull/34","diff_url":"https://github.com/wmde/DataTypes/pull/34.diff","patch_url":"https://github.com/wmde/DataTypes/pull/34.patch","issue_url":"https://api.github.com/repos/wmde/DataTypes/issues/34","number":34,"state":"open","locked":false,"title":"Simplify DataType and DataTypeFactory","user":{"login":"brightbyte","id":664717,"avatar_url":"https://avatars.githubusercontent.com/u/664717?v=3","gravatar_id":"","url":"https://api.github.com/users/brightbyte","html_url":"https://github.com/brightbyte","followers_url":"https://api.github.com/users/brightbyte/followers","following_url":"https://api.github.com/users/brightbyte/following{/other_user}","gists_url":"https://api.github.com/users/brightbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/brightbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brightbyte/subscriptions","organizations_url":"https://api.github.com/users/brightbyte/orgs","repos_url":"https://api.github.com/users/brightbyte/repos","events_url":"https://api.github.com/users/brightbyte/events{/privacy}","received_events_url":"https://api.github.com/users/brightbyte/received_events","type":"User","site_admin":false},"body":"[BREAKING] This removes ValueValidators from DataType, which was unused.\r\nDataType is no a simple pair of data type name and the associated value type id.\r\n\r\nDataTypeFactory is accordingly simplified to no longer use callbacks, but instead\r\njust take an array mapping data type names to value type ids.\r\n\r\nNeeded by https://gerrit.wikimedia.org/r/#/c/228848\r\n\r\nThis is a breaking change, since it modifies the constructor signature of DataType and DataTypeFactory.","created_at":"2015-08-04T14:35:29Z","updated_at":"2015-08-06T17:16:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59106400cb8bb3f3303e8714e9a7905399d17832","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wmde/DataTypes/pulls/34/commits","review_comments_url":"https://api.github.com/repos/wmde/DataTypes/pulls/34/comments","review_comment_url":"https://api.github.com/repos/wmde/DataTypes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wmde/DataTypes/issues/34/comments","statuses_url":"https://api.github.com/repos/wmde/DataTypes/statuses/1948efc95068e00fbfc85ffb20f1102432aa09ca","head":{"label":"wmde:Simplify_DataTypeFactory","ref":"Simplify_DataTypeFactory","sha":"1948efc95068e00fbfc85ffb20f1102432aa09ca","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":15206382,"name":"DataTypes","full_name":"wmde/DataTypes","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/DataTypes","description":"Provides a class to define a type of value","fork":false,"url":"https://api.github.com/repos/wmde/DataTypes","forks_url":"https://api.github.com/repos/wmde/DataTypes/forks","keys_url":"https://api.github.com/repos/wmde/DataTypes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/DataTypes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/DataTypes/teams","hooks_url":"https://api.github.com/repos/wmde/DataTypes/hooks","issue_events_url":"https://api.github.com/repos/wmde/DataTypes/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/DataTypes/events","assignees_url":"https://api.github.com/repos/wmde/DataTypes/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/DataTypes/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/DataTypes/tags","blobs_url":"https://api.github.com/repos/wmde/DataTypes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/DataTypes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/DataTypes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/DataTypes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/DataTypes/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/DataTypes/languages","stargazers_url":"https://api.github.com/repos/wmde/DataTypes/stargazers","contributors_url":"https://api.github.com/repos/wmde/DataTypes/contributors","subscribers_url":"https://api.github.com/repos/wmde/DataTypes/subscribers","subscription_url":"https://api.github.com/repos/wmde/DataTypes/subscription","commits_url":"https://api.github.com/repos/wmde/DataTypes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/DataTypes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/DataTypes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/DataTypes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/DataTypes/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/DataTypes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/DataTypes/merges","archive_url":"https://api.github.com/repos/wmde/DataTypes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/DataTypes/downloads","issues_url":"https://api.github.com/repos/wmde/DataTypes/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/DataTypes/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/DataTypes/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/DataTypes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/DataTypes/labels{/name}","releases_url":"https://api.github.com/repos/wmde/DataTypes/releases{/id}","created_at":"2013-12-15T16:07:16Z","updated_at":"2015-07-22T13:17:06Z","pushed_at":"2015-08-04T22:11:41Z","git_url":"git://github.com/wmde/DataTypes.git","ssh_url":"git@github.com:wmde/DataTypes.git","clone_url":"https://github.com/wmde/DataTypes.git","svn_url":"https://github.com/wmde/DataTypes","homepage":null,"size":944,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"e9d2604d7d14f7c13ad2b2e95ee4fca3c5e52ff3","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":15206382,"name":"DataTypes","full_name":"wmde/DataTypes","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/DataTypes","description":"Provides a class to define a type of value","fork":false,"url":"https://api.github.com/repos/wmde/DataTypes","forks_url":"https://api.github.com/repos/wmde/DataTypes/forks","keys_url":"https://api.github.com/repos/wmde/DataTypes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/DataTypes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/DataTypes/teams","hooks_url":"https://api.github.com/repos/wmde/DataTypes/hooks","issue_events_url":"https://api.github.com/repos/wmde/DataTypes/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/DataTypes/events","assignees_url":"https://api.github.com/repos/wmde/DataTypes/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/DataTypes/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/DataTypes/tags","blobs_url":"https://api.github.com/repos/wmde/DataTypes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/DataTypes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/DataTypes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/DataTypes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/DataTypes/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/DataTypes/languages","stargazers_url":"https://api.github.com/repos/wmde/DataTypes/stargazers","contributors_url":"https://api.github.com/repos/wmde/DataTypes/contributors","subscribers_url":"https://api.github.com/repos/wmde/DataTypes/subscribers","subscription_url":"https://api.github.com/repos/wmde/DataTypes/subscription","commits_url":"https://api.github.com/repos/wmde/DataTypes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/DataTypes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/DataTypes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/DataTypes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/DataTypes/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/DataTypes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/DataTypes/merges","archive_url":"https://api.github.com/repos/wmde/DataTypes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/DataTypes/downloads","issues_url":"https://api.github.com/repos/wmde/DataTypes/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/DataTypes/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/DataTypes/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/DataTypes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/DataTypes/labels{/name}","releases_url":"https://api.github.com/repos/wmde/DataTypes/releases{/id}","created_at":"2013-12-15T16:07:16Z","updated_at":"2015-07-22T13:17:06Z","pushed_at":"2015-08-04T22:11:41Z","git_url":"git://github.com/wmde/DataTypes.git","ssh_url":"git@github.com:wmde/DataTypes.git","clone_url":"https://github.com/wmde/DataTypes.git","svn_url":"https://github.com/wmde/DataTypes","homepage":null,"size":944,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/DataTypes/pulls/34"},"html":{"href":"https://github.com/wmde/DataTypes/pull/34"},"issue":{"href":"https://api.github.com/repos/wmde/DataTypes/issues/34"},"comments":{"href":"https://api.github.com/repos/wmde/DataTypes/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/DataTypes/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/DataTypes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wmde/DataTypes/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/DataTypes/statuses/1948efc95068e00fbfc85ffb20f1102432aa09ca"}}}}