{"action":"created","comment":{"url":"https://api.github.com/repos/fguillot/picoFeed/pulls/comments/33336479","id":33336479,"diff_hunk":"@@ -161,8 +169,14 @@ public function execute()\n         $this->findFeedLogo($xml, $feed);\n         $this->findFeedIcon($xml, $feed);\n \n+        $indexItemTree = 0;\n+\n         foreach ($this->getItemsTree($xml) as $entry) {","path":"lib/PicoFeed/Parser/Parser.php","position":21,"original_position":21,"commit_id":"04035de6654cc92b6ab8439b946e029f58747d52","original_commit_id":"04035de6654cc92b6ab8439b946e029f58747d52","user":{"login":"ccarnino","id":161903,"avatar_url":"https://avatars.githubusercontent.com/u/161903?v=3","gravatar_id":"","url":"https://api.github.com/users/ccarnino","html_url":"https://github.com/ccarnino","followers_url":"https://api.github.com/users/ccarnino/followers","following_url":"https://api.github.com/users/ccarnino/following{/other_user}","gists_url":"https://api.github.com/users/ccarnino/gists{/gist_id}","starred_url":"https://api.github.com/users/ccarnino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccarnino/subscriptions","organizations_url":"https://api.github.com/users/ccarnino/orgs","repos_url":"https://api.github.com/users/ccarnino/repos","events_url":"https://api.github.com/users/ccarnino/events{/privacy}","received_events_url":"https://api.github.com/users/ccarnino/received_events","type":"User","site_admin":false},"body":"I didn't want to impact the code too much, that's why I kept the foreach-loop.\r\nAnyway I can do that.","created_at":"2015-06-26T08:12:57Z","updated_at":"2015-06-26T08:12:57Z","html_url":"https://github.com/fguillot/picoFeed/pull/171#discussion_r33336479","pull_request_url":"https://api.github.com/repos/fguillot/picoFeed/pulls/171","_links":{"self":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/comments/33336479"},"html":{"href":"https://github.com/fguillot/picoFeed/pull/171#discussion_r33336479"},"pull_request":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/fguillot/picoFeed/pulls/171","id":38521907,"html_url":"https://github.com/fguillot/picoFeed/pull/171","diff_url":"https://github.com/fguillot/picoFeed/pull/171.diff","patch_url":"https://github.com/fguillot/picoFeed/pull/171.patch","issue_url":"https://api.github.com/repos/fguillot/picoFeed/issues/171","number":171,"state":"open","locked":false,"title":"Added the ability to limit the number of items to parse from the XML tree","user":{"login":"ccarnino","id":161903,"avatar_url":"https://avatars.githubusercontent.com/u/161903?v=3","gravatar_id":"","url":"https://api.github.com/users/ccarnino","html_url":"https://github.com/ccarnino","followers_url":"https://api.github.com/users/ccarnino/followers","following_url":"https://api.github.com/users/ccarnino/following{/other_user}","gists_url":"https://api.github.com/users/ccarnino/gists{/gist_id}","starred_url":"https://api.github.com/users/ccarnino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccarnino/subscriptions","organizations_url":"https://api.github.com/users/ccarnino/orgs","repos_url":"https://api.github.com/users/ccarnino/repos","events_url":"https://api.github.com/users/ccarnino/events{/privacy}","received_events_url":"https://api.github.com/users/ccarnino/received_events","type":"User","site_admin":false},"body":"I have added the Parser option to limit the number of items to parse in the XML tree. So when the items tree is too big, we can stop before. By default it's disabled.\r\n\r\nI am using this library in my product.\r\nI use the content-grabber option, so the time it takes to get all the items in the tree is considerable.\r\n\r\nI was parsing this feed `http://www.sketchappsources.com/rss.xml` that has 1325 items in the tree. Well it  doesn't end parsing, because it takes way too long.\r\nWith the limit option I can limit the number of items parsed to something more reasonable.","created_at":"2015-06-25T08:11:55Z","updated_at":"2015-06-26T08:12:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a3c7200a9f17417a2aab7916dc208718b7345ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fguillot/picoFeed/pulls/171/commits","review_comments_url":"https://api.github.com/repos/fguillot/picoFeed/pulls/171/comments","review_comment_url":"https://api.github.com/repos/fguillot/picoFeed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fguillot/picoFeed/issues/171/comments","statuses_url":"https://api.github.com/repos/fguillot/picoFeed/statuses/04035de6654cc92b6ab8439b946e029f58747d52","head":{"label":"ccarnino:master","ref":"master","sha":"04035de6654cc92b6ab8439b946e029f58747d52","user":{"login":"ccarnino","id":161903,"avatar_url":"https://avatars.githubusercontent.com/u/161903?v=3","gravatar_id":"","url":"https://api.github.com/users/ccarnino","html_url":"https://github.com/ccarnino","followers_url":"https://api.github.com/users/ccarnino/followers","following_url":"https://api.github.com/users/ccarnino/following{/other_user}","gists_url":"https://api.github.com/users/ccarnino/gists{/gist_id}","starred_url":"https://api.github.com/users/ccarnino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccarnino/subscriptions","organizations_url":"https://api.github.com/users/ccarnino/orgs","repos_url":"https://api.github.com/users/ccarnino/repos","events_url":"https://api.github.com/users/ccarnino/events{/privacy}","received_events_url":"https://api.github.com/users/ccarnino/received_events","type":"User","site_admin":false},"repo":{"id":38035259,"name":"picoFeed","full_name":"ccarnino/picoFeed","owner":{"login":"ccarnino","id":161903,"avatar_url":"https://avatars.githubusercontent.com/u/161903?v=3","gravatar_id":"","url":"https://api.github.com/users/ccarnino","html_url":"https://github.com/ccarnino","followers_url":"https://api.github.com/users/ccarnino/followers","following_url":"https://api.github.com/users/ccarnino/following{/other_user}","gists_url":"https://api.github.com/users/ccarnino/gists{/gist_id}","starred_url":"https://api.github.com/users/ccarnino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccarnino/subscriptions","organizations_url":"https://api.github.com/users/ccarnino/orgs","repos_url":"https://api.github.com/users/ccarnino/repos","events_url":"https://api.github.com/users/ccarnino/events{/privacy}","received_events_url":"https://api.github.com/users/ccarnino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ccarnino/picoFeed","description":"Modern PHP library to parse RSS/Atom feeds","fork":true,"url":"https://api.github.com/repos/ccarnino/picoFeed","forks_url":"https://api.github.com/repos/ccarnino/picoFeed/forks","keys_url":"https://api.github.com/repos/ccarnino/picoFeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccarnino/picoFeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccarnino/picoFeed/teams","hooks_url":"https://api.github.com/repos/ccarnino/picoFeed/hooks","issue_events_url":"https://api.github.com/repos/ccarnino/picoFeed/issues/events{/number}","events_url":"https://api.github.com/repos/ccarnino/picoFeed/events","assignees_url":"https://api.github.com/repos/ccarnino/picoFeed/assignees{/user}","branches_url":"https://api.github.com/repos/ccarnino/picoFeed/branches{/branch}","tags_url":"https://api.github.com/repos/ccarnino/picoFeed/tags","blobs_url":"https://api.github.com/repos/ccarnino/picoFeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccarnino/picoFeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccarnino/picoFeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccarnino/picoFeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccarnino/picoFeed/statuses/{sha}","languages_url":"https://api.github.com/repos/ccarnino/picoFeed/languages","stargazers_url":"https://api.github.com/repos/ccarnino/picoFeed/stargazers","contributors_url":"https://api.github.com/repos/ccarnino/picoFeed/contributors","subscribers_url":"https://api.github.com/repos/ccarnino/picoFeed/subscribers","subscription_url":"https://api.github.com/repos/ccarnino/picoFeed/subscription","commits_url":"https://api.github.com/repos/ccarnino/picoFeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccarnino/picoFeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccarnino/picoFeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccarnino/picoFeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccarnino/picoFeed/contents/{+path}","compare_url":"https://api.github.com/repos/ccarnino/picoFeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccarnino/picoFeed/merges","archive_url":"https://api.github.com/repos/ccarnino/picoFeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccarnino/picoFeed/downloads","issues_url":"https://api.github.com/repos/ccarnino/picoFeed/issues{/number}","pulls_url":"https://api.github.com/repos/ccarnino/picoFeed/pulls{/number}","milestones_url":"https://api.github.com/repos/ccarnino/picoFeed/milestones{/number}","notifications_url":"https://api.github.com/repos/ccarnino/picoFeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccarnino/picoFeed/labels{/name}","releases_url":"https://api.github.com/repos/ccarnino/picoFeed/releases{/id}","created_at":"2015-06-25T07:39:08Z","updated_at":"2015-06-25T07:39:08Z","pushed_at":"2015-06-25T07:56:02Z","git_url":"git://github.com/ccarnino/picoFeed.git","ssh_url":"git@github.com:ccarnino/picoFeed.git","clone_url":"https://github.com/ccarnino/picoFeed.git","svn_url":"https://github.com/ccarnino/picoFeed","homepage":"","size":3888,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fguillot:master","ref":"master","sha":"efa4a3ff139d147ac294070d8b60005abefa19ad","user":{"login":"fguillot","id":323546,"avatar_url":"https://avatars.githubusercontent.com/u/323546?v=3","gravatar_id":"","url":"https://api.github.com/users/fguillot","html_url":"https://github.com/fguillot","followers_url":"https://api.github.com/users/fguillot/followers","following_url":"https://api.github.com/users/fguillot/following{/other_user}","gists_url":"https://api.github.com/users/fguillot/gists{/gist_id}","starred_url":"https://api.github.com/users/fguillot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fguillot/subscriptions","organizations_url":"https://api.github.com/users/fguillot/orgs","repos_url":"https://api.github.com/users/fguillot/repos","events_url":"https://api.github.com/users/fguillot/events{/privacy}","received_events_url":"https://api.github.com/users/fguillot/received_events","type":"User","site_admin":false},"repo":{"id":8106011,"name":"picoFeed","full_name":"fguillot/picoFeed","owner":{"login":"fguillot","id":323546,"avatar_url":"https://avatars.githubusercontent.com/u/323546?v=3","gravatar_id":"","url":"https://api.github.com/users/fguillot","html_url":"https://github.com/fguillot","followers_url":"https://api.github.com/users/fguillot/followers","following_url":"https://api.github.com/users/fguillot/following{/other_user}","gists_url":"https://api.github.com/users/fguillot/gists{/gist_id}","starred_url":"https://api.github.com/users/fguillot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fguillot/subscriptions","organizations_url":"https://api.github.com/users/fguillot/orgs","repos_url":"https://api.github.com/users/fguillot/repos","events_url":"https://api.github.com/users/fguillot/events{/privacy}","received_events_url":"https://api.github.com/users/fguillot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fguillot/picoFeed","description":"Modern PHP library to parse RSS/Atom feeds","fork":false,"url":"https://api.github.com/repos/fguillot/picoFeed","forks_url":"https://api.github.com/repos/fguillot/picoFeed/forks","keys_url":"https://api.github.com/repos/fguillot/picoFeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fguillot/picoFeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fguillot/picoFeed/teams","hooks_url":"https://api.github.com/repos/fguillot/picoFeed/hooks","issue_events_url":"https://api.github.com/repos/fguillot/picoFeed/issues/events{/number}","events_url":"https://api.github.com/repos/fguillot/picoFeed/events","assignees_url":"https://api.github.com/repos/fguillot/picoFeed/assignees{/user}","branches_url":"https://api.github.com/repos/fguillot/picoFeed/branches{/branch}","tags_url":"https://api.github.com/repos/fguillot/picoFeed/tags","blobs_url":"https://api.github.com/repos/fguillot/picoFeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fguillot/picoFeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fguillot/picoFeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/fguillot/picoFeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fguillot/picoFeed/statuses/{sha}","languages_url":"https://api.github.com/repos/fguillot/picoFeed/languages","stargazers_url":"https://api.github.com/repos/fguillot/picoFeed/stargazers","contributors_url":"https://api.github.com/repos/fguillot/picoFeed/contributors","subscribers_url":"https://api.github.com/repos/fguillot/picoFeed/subscribers","subscription_url":"https://api.github.com/repos/fguillot/picoFeed/subscription","commits_url":"https://api.github.com/repos/fguillot/picoFeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/fguillot/picoFeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/fguillot/picoFeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/fguillot/picoFeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/fguillot/picoFeed/contents/{+path}","compare_url":"https://api.github.com/repos/fguillot/picoFeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fguillot/picoFeed/merges","archive_url":"https://api.github.com/repos/fguillot/picoFeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fguillot/picoFeed/downloads","issues_url":"https://api.github.com/repos/fguillot/picoFeed/issues{/number}","pulls_url":"https://api.github.com/repos/fguillot/picoFeed/pulls{/number}","milestones_url":"https://api.github.com/repos/fguillot/picoFeed/milestones{/number}","notifications_url":"https://api.github.com/repos/fguillot/picoFeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fguillot/picoFeed/labels{/name}","releases_url":"https://api.github.com/repos/fguillot/picoFeed/releases{/id}","created_at":"2013-02-09T04:16:49Z","updated_at":"2015-06-23T05:34:18Z","pushed_at":"2015-06-25T08:11:56Z","git_url":"git://github.com/fguillot/picoFeed.git","ssh_url":"git@github.com:fguillot/picoFeed.git","clone_url":"https://github.com/fguillot/picoFeed.git","svn_url":"https://github.com/fguillot/picoFeed","homepage":"","size":3888,"stargazers_count":174,"watchers_count":174,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":12,"forks":38,"open_issues":12,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/171"},"html":{"href":"https://github.com/fguillot/picoFeed/pull/171"},"issue":{"href":"https://api.github.com/repos/fguillot/picoFeed/issues/171"},"comments":{"href":"https://api.github.com/repos/fguillot/picoFeed/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fguillot/picoFeed/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/fguillot/picoFeed/statuses/04035de6654cc92b6ab8439b946e029f58747d52"}}}}