{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/32391184","id":32391184,"diff_hunk":"@@ -914,6 +914,42 @@ object functions {\n   def ceil(columnName: String): Column = ceil(Column(columnName))\n \n   /**\n+   * Computes the concat of the given values.\n+   *\n+   * @group normal_funcs\n+   * @since 1.5.0\n+   */\n+  @scala.annotation.varargs\n+  def concat(exprs: Column*): Column = Concat(exprs.map(_.expr): _*)\n+\n+  /**\n+   * Computes the concat of the given column names.\n+   *\n+   * @group normal_funcs\n+   * @since 1.5.0\n+   */\n+  @scala.annotation.varargs\n+  def concat(columnName: String, columnNames: String*): Column =\n+    concat((columnName +: columnNames).map(Column.apply): _*)\n+\n+  /**\n+   * Computes the concat_ws of the given columns with given separator.\n+   *\n+   * @group normal_funcs\n+   * @since 1.5.0\n+   */\n+  @scala.annotation.varargs\n+  def concat_ws(sep: Column, exprs: Column*): Column = concat_ws(sep, array(exprs: _*))\n+\n+  /**\n+   * Computes the concat_ws of the given columns with given separator.\n+   *\n+   * @group normal_funcs\n+   * @since 1.5.0\n+   */\n+  def concat_ws(sep: Column, exprs: Column): Column = ConcatWS(sep.expr, exprs.expr)","path":"sql/core/src/main/scala/org/apache/spark/sql/functions.scala","position":37,"original_position":37,"commit_id":"d7b01f87041980eb9f65a4284936d22036f59c57","original_commit_id":"d7b01f87041980eb9f65a4284936d22036f59c57","user":{"login":"chenghao-intel","id":2367031,"avatar_url":"https://avatars.githubusercontent.com/u/2367031?v=3","gravatar_id":"","url":"https://api.github.com/users/chenghao-intel","html_url":"https://github.com/chenghao-intel","followers_url":"https://api.github.com/users/chenghao-intel/followers","following_url":"https://api.github.com/users/chenghao-intel/following{/other_user}","gists_url":"https://api.github.com/users/chenghao-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/chenghao-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenghao-intel/subscriptions","organizations_url":"https://api.github.com/users/chenghao-intel/orgs","repos_url":"https://api.github.com/users/chenghao-intel/repos","events_url":"https://api.github.com/users/chenghao-intel/events{/privacy}","received_events_url":"https://api.github.com/users/chenghao-intel/received_events","type":"User","site_admin":false},"body":"In `functions.scala`, we are manipulating the `column`, not the `value`, so we probably don't care about its type behind the column.","created_at":"2015-06-15T04:26:48Z","updated_at":"2015-06-15T04:26:48Z","html_url":"https://github.com/apache/spark/pull/6775#discussion_r32391184","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/6775","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/32391184"},"html":{"href":"https://github.com/apache/spark/pull/6775#discussion_r32391184"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/6775"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/6775","id":37527099,"html_url":"https://github.com/apache/spark/pull/6775","diff_url":"https://github.com/apache/spark/pull/6775.diff","patch_url":"https://github.com/apache/spark/pull/6775.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/6775","number":6775,"state":"open","locked":false,"title":"[SPARK-8240] [SPARK-8241] [SQL] string function: concat/concat_ws","user":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-12T02:28:26Z","updated_at":"2015-06-15T04:26:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"603e8327d2e2ddd88661186fcf3daf957f8d748e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/6775/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/6775/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/6775/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/d7b01f87041980eb9f65a4284936d22036f59c57","head":{"label":"adrian-wang:udfconcat","ref":"udfconcat","sha":"d7b01f87041980eb9f65a4284936d22036f59c57","user":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"repo":{"id":18545588,"name":"spark","full_name":"adrian-wang/spark","owner":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrian-wang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/adrian-wang/spark","forks_url":"https://api.github.com/repos/adrian-wang/spark/forks","keys_url":"https://api.github.com/repos/adrian-wang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrian-wang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrian-wang/spark/teams","hooks_url":"https://api.github.com/repos/adrian-wang/spark/hooks","issue_events_url":"https://api.github.com/repos/adrian-wang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/adrian-wang/spark/events","assignees_url":"https://api.github.com/repos/adrian-wang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/adrian-wang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/adrian-wang/spark/tags","blobs_url":"https://api.github.com/repos/adrian-wang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrian-wang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrian-wang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrian-wang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrian-wang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/adrian-wang/spark/languages","stargazers_url":"https://api.github.com/repos/adrian-wang/spark/stargazers","contributors_url":"https://api.github.com/repos/adrian-wang/spark/contributors","subscribers_url":"https://api.github.com/repos/adrian-wang/spark/subscribers","subscription_url":"https://api.github.com/repos/adrian-wang/spark/subscription","commits_url":"https://api.github.com/repos/adrian-wang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrian-wang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrian-wang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrian-wang/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrian-wang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/adrian-wang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrian-wang/spark/merges","archive_url":"https://api.github.com/repos/adrian-wang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrian-wang/spark/downloads","issues_url":"https://api.github.com/repos/adrian-wang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/adrian-wang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/adrian-wang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/adrian-wang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrian-wang/spark/labels{/name}","releases_url":"https://api.github.com/repos/adrian-wang/spark/releases{/id}","created_at":"2014-04-08T04:42:25Z","updated_at":"2014-07-17T08:04:57Z","pushed_at":"2015-06-12T06:54:34Z","git_url":"git://github.com/adrian-wang/spark.git","ssh_url":"git@github.com:adrian-wang/spark.git","clone_url":"https://github.com/adrian-wang/spark.git","svn_url":"https://github.com/adrian-wang/spark","homepage":null,"size":105797,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"767cc94ca6d397ba19226996ccb3c8e57083c549","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-06-15T04:25:08Z","pushed_at":"2015-06-15T04:12:16Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1470777,"stargazers_count":4349,"watchers_count":4349,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3823,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":360,"forks":3823,"open_issues":360,"watchers":4349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/6775"},"html":{"href":"https://github.com/apache/spark/pull/6775"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/6775"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/6775/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/6775/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/6775/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/d7b01f87041980eb9f65a4284936d22036f59c57"}}}}