{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/38758990","id":38758990,"diff_hunk":"@@ -83,11 +83,24 @@ NValue getRandomValue(ValueType type) {\n             return ValueFactory::getIntegerValue(rand() % (1 << 31));\n         case VALUE_TYPE_BIGINT:\n             return ValueFactory::getBigIntValue(rand());\n+        case VALUE_TYPE_DECIMAL: {\n+            char characters[29];\n+            int i;\n+            for (i = 0; i < 15; ++i) {\n+                characters[i] = (char)(48 + (rand() % 10));\n+            }\n+            characters[i] = '.';\n+            for (i = 16; i < 28; ++i) {\n+                characters[i] = (char)(48 + (rand() % 10));\n+            }\n+            characters[i] = '\\0';\n+            return ValueFactory::getDecimalValueFromString(string(characters));\n+        }\n         case VALUE_TYPE_DOUBLE:\n             return ValueFactory::getDoubleValue((rand() % 10000) / (double)(rand() % 10000));\n         case VALUE_TYPE_VARCHAR: {\n-            int length = (rand() % 10);\n-            char characters[11];\n+            int length = (rand() % 8);","path":"src/ee/common/types.cpp","position":22,"original_position":22,"commit_id":"37e75cac0ba2554732a7de0dd1cd44b918362fa9","original_commit_id":"37e75cac0ba2554732a7de0dd1cd44b918362fa9","user":{"login":"luyangco","id":919119,"avatar_url":"https://avatars.githubusercontent.com/u/919119?v=3","gravatar_id":"","url":"https://api.github.com/users/luyangco","html_url":"https://github.com/luyangco","followers_url":"https://api.github.com/users/luyangco/followers","following_url":"https://api.github.com/users/luyangco/following{/other_user}","gists_url":"https://api.github.com/users/luyangco/gists{/gist_id}","starred_url":"https://api.github.com/users/luyangco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luyangco/subscriptions","organizations_url":"https://api.github.com/users/luyangco/orgs","repos_url":"https://api.github.com/users/luyangco/repos","events_url":"https://api.github.com/users/luyangco/events{/privacy}","received_events_url":"https://api.github.com/users/luyangco/received_events","type":"User","site_admin":false},"body":"I don't understand why we need to change the constant here. Same as below.","created_at":"2015-09-04T14:50:02Z","updated_at":"2015-09-04T14:50:02Z","html_url":"https://github.com/VoltDB/voltdb/pull/2783#discussion_r38758990","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2783","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/38758990"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2783#discussion_r38758990"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2783"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2783","id":44221999,"html_url":"https://github.com/VoltDB/voltdb/pull/2783","diff_url":"https://github.com/VoltDB/voltdb/pull/2783.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/2783.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2783","number":2783,"state":"open","locked":false,"title":"Add EE to frontend callback interface for logging DR conflicts","user":{"login":"luyangco","id":919119,"avatar_url":"https://avatars.githubusercontent.com/u/919119?v=3","gravatar_id":"","url":"https://api.github.com/users/luyangco","html_url":"https://github.com/luyangco","followers_url":"https://api.github.com/users/luyangco/followers","following_url":"https://api.github.com/users/luyangco/following{/other_user}","gists_url":"https://api.github.com/users/luyangco/gists{/gist_id}","starred_url":"https://api.github.com/users/luyangco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luyangco/subscriptions","organizations_url":"https://api.github.com/users/luyangco/orgs","repos_url":"https://api.github.com/users/luyangco/repos","events_url":"https://api.github.com/users/luyangco/events{/privacy}","received_events_url":"https://api.github.com/users/luyangco/received_events","type":"User","site_admin":false},"body":"Add test for new function in TupleSchema\r\n\r\nDelete global refs in destructor of JNITopend\r\n\r\nAdd NULL check for output table parameter\r\n\r\nCount length placeholder for variable length columns\r\n\r\nENG-8596, rename function to make the intention more obiviously.\r\n\r\nChange-Id: I48a68c0e22dff20baecc11a7f74eb86182695a8a","created_at":"2015-09-04T14:12:45Z","updated_at":"2015-09-04T14:50:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24e5eb4ea295ecd1523a0121bc1e8ec0c9fd948f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2783/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2783/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2783/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/37e75cac0ba2554732a7de0dd1cd44b918362fa9","head":{"label":"VoltDB:ENG-8596-log-dr-conflict","ref":"ENG-8596-log-dr-conflict","sha":"37e75cac0ba2554732a7de0dd1cd44b918362fa9","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-08-30T16:26:16Z","pushed_at":"2015-09-04T14:49:27Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":889861,"stargazers_count":618,"watchers_count":618,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":37,"forks":180,"open_issues":37,"watchers":618,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"62ba54d76af7c6d09873fdbfdf852fbdb8f845ae","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-08-30T16:26:16Z","pushed_at":"2015-09-04T14:49:27Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":889861,"stargazers_count":618,"watchers_count":618,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":37,"forks":180,"open_issues":37,"watchers":618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2783"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2783"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2783"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2783/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2783/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2783/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/37e75cac0ba2554732a7de0dd1cd44b918362fa9"}}}}