{"action":"created","issue":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3100","labels_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3100/labels{/name}","comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3100/comments","events_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3100/events","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/3100","id":111688785,"number":3100,"title":"Force UTF-8 conversion on upgrade","user":{"login":"Oldiesmann","id":89023,"avatar_url":"https://avatars.githubusercontent.com/u/89023?v=3","gravatar_id":"","url":"https://api.github.com/users/Oldiesmann","html_url":"https://github.com/Oldiesmann","followers_url":"https://api.github.com/users/Oldiesmann/followers","following_url":"https://api.github.com/users/Oldiesmann/following{/other_user}","gists_url":"https://api.github.com/users/Oldiesmann/gists{/gist_id}","starred_url":"https://api.github.com/users/Oldiesmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oldiesmann/subscriptions","organizations_url":"https://api.github.com/users/Oldiesmann/orgs","repos_url":"https://api.github.com/users/Oldiesmann/repos","events_url":"https://api.github.com/users/Oldiesmann/events{/privacy}","received_events_url":"https://api.github.com/users/Oldiesmann/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/labels/Language","name":"Language","color":"d4c5f9"},{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/labels/MySQL","name":"MySQL","color":"fad8c7"},{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/labels/Upgrader","name":"Upgrader","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/milestones/5","html_url":"https://github.com/SimpleMachines/SMF2.1/milestones/Beta%203","labels_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/milestones/5/labels","id":1203187,"number":5,"title":"Beta 3","description":"","creator":{"login":"live627","id":431799,"avatar_url":"https://avatars.githubusercontent.com/u/431799?v=3","gravatar_id":"","url":"https://api.github.com/users/live627","html_url":"https://github.com/live627","followers_url":"https://api.github.com/users/live627/followers","following_url":"https://api.github.com/users/live627/following{/other_user}","gists_url":"https://api.github.com/users/live627/gists{/gist_id}","starred_url":"https://api.github.com/users/live627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/live627/subscriptions","organizations_url":"https://api.github.com/users/live627/orgs","repos_url":"https://api.github.com/users/live627/repos","events_url":"https://api.github.com/users/live627/events{/privacy}","received_events_url":"https://api.github.com/users/live627/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":72,"state":"open","created_at":"2015-07-11T01:16:53Z","updated_at":"2015-10-15T19:19:31Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-10-15T19:19:13Z","updated_at":"2015-11-06T18:31:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3100","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/3100","diff_url":"https://github.com/SimpleMachines/SMF2.1/pull/3100.diff","patch_url":"https://github.com/SimpleMachines/SMF2.1/pull/3100.patch"},"body":"Here is the initial commit to force UTF-8 on upgrade. Note that this hasn't been tested yet - it's mostly just modified from the previous convertutf8() function in ManageMaintenance.php. Also, it doesn't properly handle unsupported character sets at the moment. Currently if an unsupported character set is detected, SMF shows the user a warning and defaults to converting from ISO-8859-1 (the user can choose which supported character set they want to convert from). We need to either figure out how to properly handle those or just skip trying to convert for those as well.\r\n\r\nSigned-off-by: Michael Eshom <oldiesmann@oldiesmann.us>"},"comment":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/comments/154494054","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/3100#issuecomment-154494054","issue_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3100","id":154494054,"user":{"login":"Oldiesmann","id":89023,"avatar_url":"https://avatars.githubusercontent.com/u/89023?v=3","gravatar_id":"","url":"https://api.github.com/users/Oldiesmann","html_url":"https://github.com/Oldiesmann","followers_url":"https://api.github.com/users/Oldiesmann/followers","following_url":"https://api.github.com/users/Oldiesmann/following{/other_user}","gists_url":"https://api.github.com/users/Oldiesmann/gists{/gist_id}","starred_url":"https://api.github.com/users/Oldiesmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oldiesmann/subscriptions","organizations_url":"https://api.github.com/users/Oldiesmann/orgs","repos_url":"https://api.github.com/users/Oldiesmann/repos","events_url":"https://api.github.com/users/Oldiesmann/events{/privacy}","received_events_url":"https://api.github.com/users/Oldiesmann/received_events","type":"User","site_admin":false},"created_at":"2015-11-06T18:31:02Z","updated_at":"2015-11-06T18:31:02Z","body":"Antes has said that this does work as intended, but it doesn't really show what it's doing, and the code to exit if your forum is already UTF-8 doesn't work properly, so I guess we need to tweak that some. I'll try to look into this more in the coming days."}}