{"action":"created","issue":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1651","labels_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1651/labels{/name}","comments_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1651/comments","events_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1651/events","html_url":"https://github.com/pyinstaller/pyinstaller/pull/1651","id":114798360,"number":1651,"title":"Fix excludedimports, more predictable order how hooks are applied.","user":{"login":"matysek","id":527280,"avatar_url":"https://avatars.githubusercontent.com/u/527280?v=3","gravatar_id":"","url":"https://api.github.com/users/matysek","html_url":"https://github.com/matysek","followers_url":"https://api.github.com/users/matysek/followers","following_url":"https://api.github.com/users/matysek/following{/other_user}","gists_url":"https://api.github.com/users/matysek/gists{/gist_id}","starred_url":"https://api.github.com/users/matysek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matysek/subscriptions","organizations_url":"https://api.github.com/users/matysek/orgs","repos_url":"https://api.github.com/users/matysek/repos","events_url":"https://api.github.com/users/matysek/events{/privacy}","received_events_url":"https://api.github.com/users/matysek/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/labels/hooks","name":"hooks","color":"fef2c0"},{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/labels/test-suite","name":"test-suite","color":"fef2c0"}],"state":"open","locked":false,"assignee":{"login":"htgoebel","id":784161,"avatar_url":"https://avatars.githubusercontent.com/u/784161?v=3","gravatar_id":"","url":"https://api.github.com/users/htgoebel","html_url":"https://github.com/htgoebel","followers_url":"https://api.github.com/users/htgoebel/followers","following_url":"https://api.github.com/users/htgoebel/following{/other_user}","gists_url":"https://api.github.com/users/htgoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/htgoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htgoebel/subscriptions","organizations_url":"https://api.github.com/users/htgoebel/orgs","repos_url":"https://api.github.com/users/htgoebel/repos","events_url":"https://api.github.com/users/htgoebel/events{/privacy}","received_events_url":"https://api.github.com/users/htgoebel/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/milestones/11","html_url":"https://github.com/pyinstaller/pyinstaller/milestones/PyInstaller%203.1","labels_url":"https://api.github.com/repos/pyinstaller/pyinstaller/milestones/11/labels","id":1290827,"number":11,"title":"PyInstaller 3.1","description":"* close all feature- and enhancement-requests known at the time 3.0 was released\r\n* clean up the code base (which seams to be necessary after integrating modulegraph)\r\n* update manual and explain better how !PyInstaller works internally.","creator":{"login":"htgoebel","id":784161,"avatar_url":"https://avatars.githubusercontent.com/u/784161?v=3","gravatar_id":"","url":"https://api.github.com/users/htgoebel","html_url":"https://github.com/htgoebel","followers_url":"https://api.github.com/users/htgoebel/followers","following_url":"https://api.github.com/users/htgoebel/following{/other_user}","gists_url":"https://api.github.com/users/htgoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/htgoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htgoebel/subscriptions","organizations_url":"https://api.github.com/users/htgoebel/orgs","repos_url":"https://api.github.com/users/htgoebel/repos","events_url":"https://api.github.com/users/htgoebel/events{/privacy}","received_events_url":"https://api.github.com/users/htgoebel/received_events","type":"User","site_admin":false},"open_issues":103,"closed_issues":51,"state":"open","created_at":"2015-09-04T16:32:45Z","updated_at":"2015-11-03T11:46:31Z","due_on":"2015-12-30T23:00:00Z","closed_at":null},"comments":1,"created_at":"2015-11-03T11:46:31Z","updated_at":"2015-11-03T11:47:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/1651","html_url":"https://github.com/pyinstaller/pyinstaller/pull/1651","diff_url":"https://github.com/pyinstaller/pyinstaller/pull/1651.diff","patch_url":"https://github.com/pyinstaller/pyinstaller/pull/1651.patch"},"body":"This pull request fixes `excludedimports` and makes it more reliable:\r\n* `excludedimports` are parsed before any hook is applied\r\n* modules are really not created in module graph when being excluded\r\n\r\nImport hooks processing:\r\n* list of hooks is first sorted\r\n* Hooks for parent packages `package` are processed before hook for `package.module_name`.\r\n\r\nFix some tests by using `excludedimports`.\r\n\r\nThis pull request introduces a completely new behavior of PyInstaller and hooks processing. Any comments and suggestion welcome.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/comments/153328202","html_url":"https://github.com/pyinstaller/pyinstaller/pull/1651#issuecomment-153328202","issue_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1651","id":153328202,"user":{"login":"matysek","id":527280,"avatar_url":"https://avatars.githubusercontent.com/u/527280?v=3","gravatar_id":"","url":"https://api.github.com/users/matysek","html_url":"https://github.com/matysek","followers_url":"https://api.github.com/users/matysek/followers","following_url":"https://api.github.com/users/matysek/following{/other_user}","gists_url":"https://api.github.com/users/matysek/gists{/gist_id}","starred_url":"https://api.github.com/users/matysek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matysek/subscriptions","organizations_url":"https://api.github.com/users/matysek/orgs","repos_url":"https://api.github.com/users/matysek/repos","events_url":"https://api.github.com/users/matysek/events{/privacy}","received_events_url":"https://api.github.com/users/matysek/received_events","type":"User","site_admin":false},"created_at":"2015-11-03T11:47:23Z","updated_at":"2015-11-03T11:47:23Z","body":"@htgoebel please merge it if you are ok with these changes."}}