{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4044","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4044/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4044/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4044/events","html_url":"https://github.com/ManageIQ/manageiq/pull/4044","id":103039226,"number":4044,"title":"For tenant, use use_settings instead of root?","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/tenancy","name":"tenancy","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-25T14:50:02Z","updated_at":"2015-08-25T21:36:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4044","html_url":"https://github.com/ManageIQ/manageiq/pull/4044","diff_url":"https://github.com/ManageIQ/manageiq/pull/4044.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4044.patch"},"body":"The logic to decide if we should read a tenant's attributes from configurations turns out to be tricky.\r\nThere are too many nuances.\r\n\r\nJust adding a flag that says 'read from settings' is better documenting and simpler.\r\n\r\n/cc @h-kataria this affects you\r\n/cc @gtanzillo this is what we spoke about\r\n\r\n---\r\nA few notes:\r\n\r\n- `defaults_value_for` fights with setting the name to nil (which is necessary to read from settings).\r\n- saving a ui form often populates settings values into tenants table and disables the feature.\r\n- explaining how it works and where it breaks down just takes too long. worried about supporting this.\r\n- this will only be used by 10 customers max. But clearly documenting it removes confusion."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/134748837","html_url":"https://github.com/ManageIQ/manageiq/pull/4044#issuecomment-134748837","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4044","id":134748837,"user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T21:36:24Z","updated_at":"2015-08-25T21:36:24Z","body":"kicking off again - bogus build failure\r\n\r\n/cc @Fryguy "}}