{"action":"created","issue":{"url":"https://api.github.com/repos/ndmitchell/hlint/issues/146","labels_url":"https://api.github.com/repos/ndmitchell/hlint/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/ndmitchell/hlint/issues/146/comments","events_url":"https://api.github.com/repos/ndmitchell/hlint/issues/146/events","html_url":"https://github.com/ndmitchell/hlint/pull/146","id":95944915,"number":146,"title":"Necessary adjustments to automatically apply suggestions.","user":{"login":"mpickering","id":1216657,"avatar_url":"https://avatars.githubusercontent.com/u/1216657?v=3","gravatar_id":"","url":"https://api.github.com/users/mpickering","html_url":"https://github.com/mpickering","followers_url":"https://api.github.com/users/mpickering/followers","following_url":"https://api.github.com/users/mpickering/following{/other_user}","gists_url":"https://api.github.com/users/mpickering/gists{/gist_id}","starred_url":"https://api.github.com/users/mpickering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpickering/subscriptions","organizations_url":"https://api.github.com/users/mpickering/orgs","repos_url":"https://api.github.com/users/mpickering/repos","events_url":"https://api.github.com/users/mpickering/events{/privacy}","received_events_url":"https://api.github.com/users/mpickering/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-19T20:12:45Z","updated_at":"2015-07-21T05:47:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ndmitchell/hlint/pulls/146","html_url":"https://github.com/ndmitchell/hlint/pull/146","diff_url":"https://github.com/ndmitchell/hlint/pull/146.diff","patch_url":"https://github.com/ndmitchell/hlint/pull/146.patch"},"body":"I will squash this once everything settles down but I think everything is nearly ready to merge. \r\n\r\nWhen you get the chance could you please review the changes and suggest any improvements you would like to see.\r\n\r\nThere was one part where I couldn't properly specify the refactoring. The unification algorithm does some rearranging in the middle to match `f . g $ x` as `f (g x)` but in doing this, it is possible to variables to unify with expressions which don't exist in the AST (namely `g x`). I tried a few things to solve this but couldn't get anything to stick so if you have any ideas about how to either move this rearrangement out of the unification step or another way to solve this problem it would be appreciated. \r\n\r\nApart from that, I thought that the integration was quite clean for the most part. There are some additional places where some locations needed to be threaded around properly but most refactorings were easily specifiable with only a few primitives. The application library is also only about 700 LOC. "},"comment":{"url":"https://api.github.com/repos/ndmitchell/hlint/issues/comments/123170009","html_url":"https://github.com/ndmitchell/hlint/pull/146#issuecomment-123170009","issue_url":"https://api.github.com/repos/ndmitchell/hlint/issues/146","id":123170009,"user":{"login":"ndmitchell","id":1651197,"avatar_url":"https://avatars.githubusercontent.com/u/1651197?v=3","gravatar_id":"","url":"https://api.github.com/users/ndmitchell","html_url":"https://github.com/ndmitchell","followers_url":"https://api.github.com/users/ndmitchell/followers","following_url":"https://api.github.com/users/ndmitchell/following{/other_user}","gists_url":"https://api.github.com/users/ndmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/ndmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndmitchell/subscriptions","organizations_url":"https://api.github.com/users/ndmitchell/orgs","repos_url":"https://api.github.com/users/ndmitchell/repos","events_url":"https://api.github.com/users/ndmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/ndmitchell/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T05:47:13Z","updated_at":"2015-07-21T05:47:13Z","body":"OK, I suggest we think about the representation for SrcSpan (you might decide to do nothing, but if it does change, easier now than later) and once that's figured out, I do a final review, and then we merge."}}