{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/5617","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5617/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5617/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5617/events","html_url":"https://github.com/mozilla/pdf.js/pull/5617","id":53460263,"number":5617,"title":"Don't layout sidebar when hidden","user":{"login":"fkaelberer","id":4624768,"avatar_url":"https://avatars.githubusercontent.com/u/4624768?v=3","gravatar_id":"","url":"https://api.github.com/users/fkaelberer","html_url":"https://github.com/fkaelberer","followers_url":"https://api.github.com/users/fkaelberer/followers","following_url":"https://api.github.com/users/fkaelberer/following{/other_user}","gists_url":"https://api.github.com/users/fkaelberer/gists{/gist_id}","starred_url":"https://api.github.com/users/fkaelberer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkaelberer/subscriptions","organizations_url":"https://api.github.com/users/fkaelberer/orgs","repos_url":"https://api.github.com/users/fkaelberer/repos","events_url":"https://api.github.com/users/fkaelberer/events{/privacy}","received_events_url":"https://api.github.com/users/fkaelberer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/1-viewer","name":"1-viewer","color":"DDDDDD"},{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/4-work-in-progress","name":"4-work-in-progress","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-01-05T23:11:40Z","updated_at":"2015-01-07T07:58:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/5617","html_url":"https://github.com/mozilla/pdf.js/pull/5617","diff_url":"https://github.com/mozilla/pdf.js/pull/5617.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/5617.patch"},"body":"This PR removes the ```visibility: hidden``` property from the ```sidebarContainer```, and sets the \r\n```\r\n.hidden { display: none !important }\r\n``` \r\nclass instead.\r\n\r\nThe ```.hidden``` class is added at launch and after the closing transition (at the ```transitionend``` event) and it is removed before opening the sidebar again. Since the ```display: none``` property removes the burden of layouting the elements, it is much faster than ```visibility: hidden```.\r\n\r\nThis PR carries the [WIP] label in its title because the ```scrollThumbnailIntoView``` functionality does not work for ```.hidden``` elements, but it should work once #5586 is merged (because #5586 calls ```scrollThumbnailsIntoView``` when the sidebar is opened).\r\n\r\nSee also the discussion in https://github.com/mozilla/pdf.js/pull/5586#issuecomment-68638537\r\n(Btw, setting the max-size properties did not work).\r\n"},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/68989522","html_url":"https://github.com/mozilla/pdf.js/pull/5617#issuecomment-68989522","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5617","id":68989522,"user":{"login":"fkaelberer","id":4624768,"avatar_url":"https://avatars.githubusercontent.com/u/4624768?v=3","gravatar_id":"","url":"https://api.github.com/users/fkaelberer","html_url":"https://github.com/fkaelberer","followers_url":"https://api.github.com/users/fkaelberer/followers","following_url":"https://api.github.com/users/fkaelberer/following{/other_user}","gists_url":"https://api.github.com/users/fkaelberer/gists{/gist_id}","starred_url":"https://api.github.com/users/fkaelberer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkaelberer/subscriptions","organizations_url":"https://api.github.com/users/fkaelberer/orgs","repos_url":"https://api.github.com/users/fkaelberer/repos","events_url":"https://api.github.com/users/fkaelberer/events{/privacy}","received_events_url":"https://api.github.com/users/fkaelberer/received_events","type":"User","site_admin":false},"created_at":"2015-01-07T07:58:03Z","updated_at":"2015-01-07T07:58:03Z","body":"@Snuffleupagus You're right, I fixed your points."}}