{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/comments/47825840","id":47825840,"diff_hunk":"@@ -38,7 +38,8 @@ program\n   .option(\"--debug\", \"Enable the add-on debugger when running the add-on\")\n   .option(\"--check-memory\", \"Enable leaked tracker that attempts to report compartments leaked\")\n   .option(\"--profile-memory\", \"Enable profiling of memory usage\")\n-  .option(\"--retro\", \"In development flag for transitioning to new style addons; forces the lack of install.rdf/bootstrap.js creation regardless of what engine versions are running\");\n+  .option(\"--retro\", \"In development flag for transitioning to new style addons; forces the lack of install.rdf/bootstrap.js creation regardless of what engine versions are running\")\n+  .option(\"--out <fname>\", \"Save xpi file with this name. Use with `jpm xpi`.\");","path":"bin/jpm","position":6,"original_position":6,"commit_id":"ee35695da541988e63b74fcb70491f60360d4b78","original_commit_id":"ee35695da541988e63b74fcb70491f60360d4b78","user":{"login":"rpl","id":11484,"avatar_url":"https://avatars.githubusercontent.com/u/11484?v=3","gravatar_id":"","url":"https://api.github.com/users/rpl","html_url":"https://github.com/rpl","followers_url":"https://api.github.com/users/rpl/followers","following_url":"https://api.github.com/users/rpl/following{/other_user}","gists_url":"https://api.github.com/users/rpl/gists{/gist_id}","starred_url":"https://api.github.com/users/rpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpl/subscriptions","organizations_url":"https://api.github.com/users/rpl/orgs","repos_url":"https://api.github.com/users/rpl/repos","events_url":"https://api.github.com/users/rpl/events{/privacy}","received_events_url":"https://api.github.com/users/rpl/received_events","type":"User","site_admin":false},"body":"@kumar303 @matraska23 I would prefer an option name which is more specific than \"--out\", even better if it doesn't start with an 'o' (which is already used in the \"-o, --overloading\" option)\r\n\r\ne.g. \"--xpi-out-path\"","created_at":"2015-12-16T19:58:51Z","updated_at":"2015-12-16T19:58:51Z","html_url":"https://github.com/mozilla-jetpack/jpm/pull/419#discussion_r47825840","pull_request_url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/419","_links":{"self":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/comments/47825840"},"html":{"href":"https://github.com/mozilla-jetpack/jpm/pull/419#discussion_r47825840"},"pull_request":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/419"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/419","id":52851392,"html_url":"https://github.com/mozilla-jetpack/jpm/pull/419","diff_url":"https://github.com/mozilla-jetpack/jpm/pull/419.diff","patch_url":"https://github.com/mozilla-jetpack/jpm/pull/419.patch","issue_url":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/419","number":419,"state":"open","locked":false,"title":"Localization for description and title at manifest file, set xpi file name at coomand line","user":{"login":"matraska23","id":665443,"avatar_url":"https://avatars.githubusercontent.com/u/665443?v=3","gravatar_id":"","url":"https://api.github.com/users/matraska23","html_url":"https://github.com/matraska23","followers_url":"https://api.github.com/users/matraska23/followers","following_url":"https://api.github.com/users/matraska23/following{/other_user}","gists_url":"https://api.github.com/users/matraska23/gists{/gist_id}","starred_url":"https://api.github.com/users/matraska23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matraska23/subscriptions","organizations_url":"https://api.github.com/users/matraska23/orgs","repos_url":"https://api.github.com/users/matraska23/repos","events_url":"https://api.github.com/users/matraska23/events{/privacy}","received_events_url":"https://api.github.com/users/matraska23/received_events","type":"User","site_admin":false},"body":"Hi everybody!\r\n\r\nI'm developing a one plugin for Firefox browser, and i was needed at some features for automatically add on building.\r\nSo i add them at my jpm fork...\r\n\r\n1) Set xpi file name with option\r\n```\r\n#: jpm xpi --out <filename>\r\n```\r\n2) Add localization for description and title at manifest file\r\nI know there exist a similar bug (https://bugzilla.mozilla.org/show_bug.cgi?id=436344). But i think, it's not correct, because jetpack don't do anything with language preference files.\r\nSo i add localized variants of description at manifest file.\r\n```\r\n\"localized_description\": {\r\n \"ru\": {\r\n    \"title\": \"Addon tittle on another language\",\r\n    \"description\": \"Addon description on another language\"\r\n }\r\n},\r\n```\r\n3) Add page for addon configuration at manifest\r\n\r\nSet link on addon settings page:\r\n```\r\n\"optionsURL\": \"data/page/option_page.html\",\r\n```","created_at":"2015-12-07T14:34:40Z","updated_at":"2015-12-16T19:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bce76b38e37c85d866504f5a3b0f0a9193348d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/419/commits","review_comments_url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/419/comments","review_comment_url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/419/comments","statuses_url":"https://api.github.com/repos/mozilla-jetpack/jpm/statuses/ee35695da541988e63b74fcb70491f60360d4b78","head":{"label":"matraska23:master","ref":"master","sha":"ee35695da541988e63b74fcb70491f60360d4b78","user":{"login":"matraska23","id":665443,"avatar_url":"https://avatars.githubusercontent.com/u/665443?v=3","gravatar_id":"","url":"https://api.github.com/users/matraska23","html_url":"https://github.com/matraska23","followers_url":"https://api.github.com/users/matraska23/followers","following_url":"https://api.github.com/users/matraska23/following{/other_user}","gists_url":"https://api.github.com/users/matraska23/gists{/gist_id}","starred_url":"https://api.github.com/users/matraska23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matraska23/subscriptions","organizations_url":"https://api.github.com/users/matraska23/orgs","repos_url":"https://api.github.com/users/matraska23/repos","events_url":"https://api.github.com/users/matraska23/events{/privacy}","received_events_url":"https://api.github.com/users/matraska23/received_events","type":"User","site_admin":false},"repo":{"id":40592441,"name":"jpm","full_name":"matraska23/jpm","owner":{"login":"matraska23","id":665443,"avatar_url":"https://avatars.githubusercontent.com/u/665443?v=3","gravatar_id":"","url":"https://api.github.com/users/matraska23","html_url":"https://github.com/matraska23","followers_url":"https://api.github.com/users/matraska23/followers","following_url":"https://api.github.com/users/matraska23/following{/other_user}","gists_url":"https://api.github.com/users/matraska23/gists{/gist_id}","starred_url":"https://api.github.com/users/matraska23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matraska23/subscriptions","organizations_url":"https://api.github.com/users/matraska23/orgs","repos_url":"https://api.github.com/users/matraska23/repos","events_url":"https://api.github.com/users/matraska23/events{/privacy}","received_events_url":"https://api.github.com/users/matraska23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matraska23/jpm","description":"Jetpack Manager for Node.js","fork":true,"url":"https://api.github.com/repos/matraska23/jpm","forks_url":"https://api.github.com/repos/matraska23/jpm/forks","keys_url":"https://api.github.com/repos/matraska23/jpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matraska23/jpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matraska23/jpm/teams","hooks_url":"https://api.github.com/repos/matraska23/jpm/hooks","issue_events_url":"https://api.github.com/repos/matraska23/jpm/issues/events{/number}","events_url":"https://api.github.com/repos/matraska23/jpm/events","assignees_url":"https://api.github.com/repos/matraska23/jpm/assignees{/user}","branches_url":"https://api.github.com/repos/matraska23/jpm/branches{/branch}","tags_url":"https://api.github.com/repos/matraska23/jpm/tags","blobs_url":"https://api.github.com/repos/matraska23/jpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matraska23/jpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matraska23/jpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/matraska23/jpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matraska23/jpm/statuses/{sha}","languages_url":"https://api.github.com/repos/matraska23/jpm/languages","stargazers_url":"https://api.github.com/repos/matraska23/jpm/stargazers","contributors_url":"https://api.github.com/repos/matraska23/jpm/contributors","subscribers_url":"https://api.github.com/repos/matraska23/jpm/subscribers","subscription_url":"https://api.github.com/repos/matraska23/jpm/subscription","commits_url":"https://api.github.com/repos/matraska23/jpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/matraska23/jpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/matraska23/jpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/matraska23/jpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/matraska23/jpm/contents/{+path}","compare_url":"https://api.github.com/repos/matraska23/jpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matraska23/jpm/merges","archive_url":"https://api.github.com/repos/matraska23/jpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matraska23/jpm/downloads","issues_url":"https://api.github.com/repos/matraska23/jpm/issues{/number}","pulls_url":"https://api.github.com/repos/matraska23/jpm/pulls{/number}","milestones_url":"https://api.github.com/repos/matraska23/jpm/milestones{/number}","notifications_url":"https://api.github.com/repos/matraska23/jpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matraska23/jpm/labels{/name}","releases_url":"https://api.github.com/repos/matraska23/jpm/releases{/id}","created_at":"2015-08-12T09:33:52Z","updated_at":"2015-08-12T09:33:52Z","pushed_at":"2015-12-15T13:52:17Z","git_url":"git://github.com/matraska23/jpm.git","ssh_url":"git@github.com:matraska23/jpm.git","clone_url":"https://github.com/matraska23/jpm.git","svn_url":"https://github.com/matraska23/jpm","homepage":"https://www.npmjs.org/package/jpm","size":597,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-jetpack:master","ref":"master","sha":"6c12f1bd648e4a05fe182be9beaae336e6f7d9b5","user":{"login":"mozilla-jetpack","id":13967888,"avatar_url":"https://avatars.githubusercontent.com/u/13967888?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-jetpack","html_url":"https://github.com/mozilla-jetpack","followers_url":"https://api.github.com/users/mozilla-jetpack/followers","following_url":"https://api.github.com/users/mozilla-jetpack/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-jetpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-jetpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-jetpack/subscriptions","organizations_url":"https://api.github.com/users/mozilla-jetpack/orgs","repos_url":"https://api.github.com/users/mozilla-jetpack/repos","events_url":"https://api.github.com/users/mozilla-jetpack/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-jetpack/received_events","type":"Organization","site_admin":false},"repo":{"id":14935921,"name":"jpm","full_name":"mozilla-jetpack/jpm","owner":{"login":"mozilla-jetpack","id":13967888,"avatar_url":"https://avatars.githubusercontent.com/u/13967888?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-jetpack","html_url":"https://github.com/mozilla-jetpack","followers_url":"https://api.github.com/users/mozilla-jetpack/followers","following_url":"https://api.github.com/users/mozilla-jetpack/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-jetpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-jetpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-jetpack/subscriptions","organizations_url":"https://api.github.com/users/mozilla-jetpack/orgs","repos_url":"https://api.github.com/users/mozilla-jetpack/repos","events_url":"https://api.github.com/users/mozilla-jetpack/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-jetpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-jetpack/jpm","description":"Jetpack Manager for Node.js","fork":false,"url":"https://api.github.com/repos/mozilla-jetpack/jpm","forks_url":"https://api.github.com/repos/mozilla-jetpack/jpm/forks","keys_url":"https://api.github.com/repos/mozilla-jetpack/jpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-jetpack/jpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-jetpack/jpm/teams","hooks_url":"https://api.github.com/repos/mozilla-jetpack/jpm/hooks","issue_events_url":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-jetpack/jpm/events","assignees_url":"https://api.github.com/repos/mozilla-jetpack/jpm/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-jetpack/jpm/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-jetpack/jpm/tags","blobs_url":"https://api.github.com/repos/mozilla-jetpack/jpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-jetpack/jpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-jetpack/jpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-jetpack/jpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-jetpack/jpm/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-jetpack/jpm/languages","stargazers_url":"https://api.github.com/repos/mozilla-jetpack/jpm/stargazers","contributors_url":"https://api.github.com/repos/mozilla-jetpack/jpm/contributors","subscribers_url":"https://api.github.com/repos/mozilla-jetpack/jpm/subscribers","subscription_url":"https://api.github.com/repos/mozilla-jetpack/jpm/subscription","commits_url":"https://api.github.com/repos/mozilla-jetpack/jpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-jetpack/jpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-jetpack/jpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-jetpack/jpm/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-jetpack/jpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-jetpack/jpm/merges","archive_url":"https://api.github.com/repos/mozilla-jetpack/jpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-jetpack/jpm/downloads","issues_url":"https://api.github.com/repos/mozilla-jetpack/jpm/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-jetpack/jpm/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-jetpack/jpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-jetpack/jpm/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-jetpack/jpm/releases{/id}","created_at":"2013-12-04T21:09:56Z","updated_at":"2015-12-15T17:44:20Z","pushed_at":"2015-12-16T19:00:46Z","git_url":"git://github.com/mozilla-jetpack/jpm.git","ssh_url":"git@github.com:mozilla-jetpack/jpm.git","clone_url":"https://github.com/mozilla-jetpack/jpm.git","svn_url":"https://github.com/mozilla-jetpack/jpm","homepage":"https://www.npmjs.org/package/jpm","size":991,"stargazers_count":140,"watchers_count":140,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":108,"forks":55,"open_issues":108,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/419"},"html":{"href":"https://github.com/mozilla-jetpack/jpm/pull/419"},"issue":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/419"},"comments":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/issues/419/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/419/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/pulls/419/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-jetpack/jpm/statuses/ee35695da541988e63b74fcb70491f60360d4b78"}}}}