{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/11391","labels_url":"https://api.github.com/repos/docker/docker/issues/11391/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/11391/comments","events_url":"https://api.github.com/repos/docker/docker/issues/11391/events","html_url":"https://github.com/docker/docker/pull/11391","id":61743128,"number":11391,"title":"Show warning message when icc is false and bridge-nf-call-iptables is disabled","user":{"login":"mizzy","id":3620,"avatar_url":"https://avatars.githubusercontent.com/u/3620?v=3","gravatar_id":"","url":"https://api.github.com/users/mizzy","html_url":"https://github.com/mizzy","followers_url":"https://api.github.com/users/mizzy/followers","following_url":"https://api.github.com/users/mizzy/following{/other_user}","gists_url":"https://api.github.com/users/mizzy/gists{/gist_id}","starred_url":"https://api.github.com/users/mizzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mizzy/subscriptions","organizations_url":"https://api.github.com/users/mizzy/orgs","repos_url":"https://api.github.com/users/mizzy/repos","events_url":"https://api.github.com/users/mizzy/events{/privacy}","received_events_url":"https://api.github.com/users/mizzy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/0-triage","name":"0-triage","color":"dddddd"},{"url":"https://api.github.com/repos/docker/docker/labels/dco/yes","name":"dco/yes","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-15T04:11:57Z","updated_at":"2015-03-15T14:54:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/11391","html_url":"https://github.com/docker/docker/pull/11391","diff_url":"https://github.com/docker/docker/pull/11391.diff","patch_url":"https://github.com/docker/docker/pull/11391.patch"},"body":"This pull request is for showing a warning message when --icc=false and net.bridge.bridge-nf-call-iptables is disabled.\r\n\r\nIf net.bridge.bridge-nf-call-iptables is disabled, iptables does not see bridge traffic. So contaniers can communicate with each other even though icc option is false.\r\n\r\nI found this problem when I tested Docker on CoreOS. Since Linux kernel 3.18 rc-1, you have to modprobe br_netfilter explicitly to enable net.bridge.bridge-nf-call-iptables.\r\n\r\nIt took very long time to investigate this problem because there were no messages and Docker worked correctly other than --icc=false did not work.\r\n\r\nSo it is kind to show this warning message to find the problem easily.\r\n\r\nPlease check it.\r\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/81061470","html_url":"https://github.com/docker/docker/pull/11391#issuecomment-81061470","issue_url":"https://api.github.com/repos/docker/docker/issues/11391","id":81061470,"user":{"login":"mizzy","id":3620,"avatar_url":"https://avatars.githubusercontent.com/u/3620?v=3","gravatar_id":"","url":"https://api.github.com/users/mizzy","html_url":"https://github.com/mizzy","followers_url":"https://api.github.com/users/mizzy/followers","following_url":"https://api.github.com/users/mizzy/following{/other_user}","gists_url":"https://api.github.com/users/mizzy/gists{/gist_id}","starred_url":"https://api.github.com/users/mizzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mizzy/subscriptions","organizations_url":"https://api.github.com/users/mizzy/orgs","repos_url":"https://api.github.com/users/mizzy/repos","events_url":"https://api.github.com/users/mizzy/events{/privacy}","received_events_url":"https://api.github.com/users/mizzy/received_events","type":"User","site_admin":false},"created_at":"2015-03-15T14:54:07Z","updated_at":"2015-03-15T14:54:07Z","body":"> I'm wondering if this should be just a warning, or a full error. Just outputting a warning doesn't sound logical to me if --icc=false is being ignored.\r\n\r\nI'm wondering it, too.  But exiting with error is not compatible with current version.\r\nSo I fixed to show just warn message tentatively.\r\n\r\nIf exiting with error is better, I will fix it."}}