{"action":"created","comment":{"url":"https://api.github.com/repos/novoda/image-loader/pulls/comments/23836455","id":23836455,"diff_hunk":"@@ -74,7 +74,6 @@ public void load(String url, Void metadata, ImageView view) {\n             if (Tag.shouldSkip(url, view)) {\n                 return;\n             }\n-            view.setImageResource(PLACEHOLDER_RES_ID);","path":"core/src/main/java/com/novoda/pxfetcher/PixelFetchers.java","position":4,"original_position":4,"commit_id":"66b2c69331120a7e919aa86f6543d04c5382a0aa","original_commit_id":"66b2c69331120a7e919aa86f6543d04c5382a0aa","user":{"login":"friedger","id":1449049,"avatar_url":"https://avatars.githubusercontent.com/u/1449049?v=3","gravatar_id":"","url":"https://api.github.com/users/friedger","html_url":"https://github.com/friedger","followers_url":"https://api.github.com/users/friedger/followers","following_url":"https://api.github.com/users/friedger/following{/other_user}","gists_url":"https://api.github.com/users/friedger/gists{/gist_id}","starred_url":"https://api.github.com/users/friedger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedger/subscriptions","organizations_url":"https://api.github.com/users/friedger/orgs","repos_url":"https://api.github.com/users/friedger/repos","events_url":"https://api.github.com/users/friedger/events{/privacy}","received_events_url":"https://api.github.com/users/friedger/received_events","type":"User","site_admin":false},"body":"The DefaultPixelFetcher does set the placeholder. This is done in the retrievers. So no need to do it here.","created_at":"2015-01-30T11:19:31Z","updated_at":"2015-01-30T11:19:31Z","html_url":"https://github.com/novoda/image-loader/pull/211#discussion_r23836455","pull_request_url":"https://api.github.com/repos/novoda/image-loader/pulls/211","_links":{"self":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/comments/23836455"},"html":{"href":"https://github.com/novoda/image-loader/pull/211#discussion_r23836455"},"pull_request":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/211"}}},"pull_request":{"url":"https://api.github.com/repos/novoda/image-loader/pulls/211","id":28260776,"html_url":"https://github.com/novoda/image-loader/pull/211","diff_url":"https://github.com/novoda/image-loader/pull/211.diff","patch_url":"https://github.com/novoda/image-loader/pull/211.patch","issue_url":"https://api.github.com/repos/novoda/image-loader/issues/211","number":211,"state":"closed","locked":false,"title":"Simplify/Default fetcher","user":{"login":"friedger","id":1449049,"avatar_url":"https://avatars.githubusercontent.com/u/1449049?v=3","gravatar_id":"","url":"https://api.github.com/users/friedger","html_url":"https://github.com/friedger","followers_url":"https://api.github.com/users/friedger/followers","following_url":"https://api.github.com/users/friedger/following{/other_user}","gists_url":"https://api.github.com/users/friedger/gists{/gist_id}","starred_url":"https://api.github.com/users/friedger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedger/subscriptions","organizations_url":"https://api.github.com/users/friedger/orgs","repos_url":"https://api.github.com/users/friedger/repos","events_url":"https://api.github.com/users/friedger/events{/privacy}","received_events_url":"https://api.github.com/users/friedger/received_events","type":"User","site_admin":false},"body":"To simplify the default implementation of PixelFetcher \r\n- a duplicate placeholder setting was removed\r\n- an unnecessary if clause was removed","created_at":"2015-01-29T08:21:48Z","updated_at":"2015-01-30T11:19:31Z","closed_at":"2015-01-30T10:45:24Z","merged_at":"2015-01-30T10:45:24Z","merge_commit_sha":"b75cf9904738405127127412201b46b11b8c1ae6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/novoda/image-loader/pulls/211/commits","review_comments_url":"https://api.github.com/repos/novoda/image-loader/pulls/211/comments","review_comment_url":"https://api.github.com/repos/novoda/image-loader/pulls/comments/{number}","comments_url":"https://api.github.com/repos/novoda/image-loader/issues/211/comments","statuses_url":"https://api.github.com/repos/novoda/image-loader/statuses/66b2c69331120a7e919aa86f6543d04c5382a0aa","head":{"label":"novoda:simplify/default_fetcher","ref":"simplify/default_fetcher","sha":"66b2c69331120a7e919aa86f6543d04c5382a0aa","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":2161802,"name":"image-loader","full_name":"novoda/image-loader","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/image-loader","description":"Library for async image loading and caching on Android","fork":false,"url":"https://api.github.com/repos/novoda/image-loader","forks_url":"https://api.github.com/repos/novoda/image-loader/forks","keys_url":"https://api.github.com/repos/novoda/image-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/image-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/image-loader/teams","hooks_url":"https://api.github.com/repos/novoda/image-loader/hooks","issue_events_url":"https://api.github.com/repos/novoda/image-loader/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/image-loader/events","assignees_url":"https://api.github.com/repos/novoda/image-loader/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/image-loader/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/image-loader/tags","blobs_url":"https://api.github.com/repos/novoda/image-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/image-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/image-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/image-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/image-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/image-loader/languages","stargazers_url":"https://api.github.com/repos/novoda/image-loader/stargazers","contributors_url":"https://api.github.com/repos/novoda/image-loader/contributors","subscribers_url":"https://api.github.com/repos/novoda/image-loader/subscribers","subscription_url":"https://api.github.com/repos/novoda/image-loader/subscription","commits_url":"https://api.github.com/repos/novoda/image-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/image-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/image-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/image-loader/issues/comments/{number}","contents_url":"https://api.github.com/repos/novoda/image-loader/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/image-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/image-loader/merges","archive_url":"https://api.github.com/repos/novoda/image-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/image-loader/downloads","issues_url":"https://api.github.com/repos/novoda/image-loader/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/image-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/image-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/image-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/image-loader/labels{/name}","releases_url":"https://api.github.com/repos/novoda/image-loader/releases{/id}","created_at":"2011-08-05T18:05:02Z","updated_at":"2015-01-30T10:45:24Z","pushed_at":"2015-01-30T10:45:27Z","git_url":"git://github.com/novoda/image-loader.git","ssh_url":"git@github.com:novoda/image-loader.git","clone_url":"https://github.com/novoda/image-loader.git","svn_url":"https://github.com/novoda/image-loader","homepage":"","size":6307,"stargazers_count":889,"watchers_count":889,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":321,"mirror_url":null,"open_issues_count":34,"forks":321,"open_issues":34,"watchers":889,"default_branch":"develop"}},"base":{"label":"novoda:develop","ref":"develop","sha":"fb80ba87fc00477aa1c679ea871f28bacb46b816","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":2161802,"name":"image-loader","full_name":"novoda/image-loader","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/image-loader","description":"Library for async image loading and caching on Android","fork":false,"url":"https://api.github.com/repos/novoda/image-loader","forks_url":"https://api.github.com/repos/novoda/image-loader/forks","keys_url":"https://api.github.com/repos/novoda/image-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/image-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/image-loader/teams","hooks_url":"https://api.github.com/repos/novoda/image-loader/hooks","issue_events_url":"https://api.github.com/repos/novoda/image-loader/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/image-loader/events","assignees_url":"https://api.github.com/repos/novoda/image-loader/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/image-loader/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/image-loader/tags","blobs_url":"https://api.github.com/repos/novoda/image-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/image-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/image-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/image-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/image-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/image-loader/languages","stargazers_url":"https://api.github.com/repos/novoda/image-loader/stargazers","contributors_url":"https://api.github.com/repos/novoda/image-loader/contributors","subscribers_url":"https://api.github.com/repos/novoda/image-loader/subscribers","subscription_url":"https://api.github.com/repos/novoda/image-loader/subscription","commits_url":"https://api.github.com/repos/novoda/image-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/image-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/image-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/image-loader/issues/comments/{number}","contents_url":"https://api.github.com/repos/novoda/image-loader/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/image-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/image-loader/merges","archive_url":"https://api.github.com/repos/novoda/image-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/image-loader/downloads","issues_url":"https://api.github.com/repos/novoda/image-loader/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/image-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/image-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/image-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/image-loader/labels{/name}","releases_url":"https://api.github.com/repos/novoda/image-loader/releases{/id}","created_at":"2011-08-05T18:05:02Z","updated_at":"2015-01-30T10:45:24Z","pushed_at":"2015-01-30T10:45:27Z","git_url":"git://github.com/novoda/image-loader.git","ssh_url":"git@github.com:novoda/image-loader.git","clone_url":"https://github.com/novoda/image-loader.git","svn_url":"https://github.com/novoda/image-loader","homepage":"","size":6307,"stargazers_count":889,"watchers_count":889,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":321,"mirror_url":null,"open_issues_count":34,"forks":321,"open_issues":34,"watchers":889,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/211"},"html":{"href":"https://github.com/novoda/image-loader/pull/211"},"issue":{"href":"https://api.github.com/repos/novoda/image-loader/issues/211"},"comments":{"href":"https://api.github.com/repos/novoda/image-loader/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/image-loader/statuses/66b2c69331120a7e919aa86f6543d04c5382a0aa"}}}}