{"action":"created","issue":{"url":"https://api.github.com/repos/SafirSDK/safir-sdk-core/issues/244","labels_url":"https://api.github.com/repos/SafirSDK/safir-sdk-core/issues/244/labels{/name}","comments_url":"https://api.github.com/repos/SafirSDK/safir-sdk-core/issues/244/comments","events_url":"https://api.github.com/repos/SafirSDK/safir-sdk-core/issues/244/events","html_url":"https://github.com/SafirSDK/safir-sdk-core/issues/244","id":109548948,"number":244,"title":"Stop Orders are not sent if safir_control is stopped using the close button on Windows","user":{"login":"DonOregano","id":3583175,"avatar_url":"https://avatars.githubusercontent.com/u/3583175?v=3","gravatar_id":"","url":"https://api.github.com/users/DonOregano","html_url":"https://github.com/DonOregano","followers_url":"https://api.github.com/users/DonOregano/followers","following_url":"https://api.github.com/users/DonOregano/following{/other_user}","gists_url":"https://api.github.com/users/DonOregano/gists{/gist_id}","starred_url":"https://api.github.com/users/DonOregano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonOregano/subscriptions","organizations_url":"https://api.github.com/users/DonOregano/orgs","repos_url":"https://api.github.com/users/DonOregano/repos","events_url":"https://api.github.com/users/DonOregano/events{/privacy}","received_events_url":"https://api.github.com/users/DonOregano/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"anderswiden","id":7148145,"avatar_url":"https://avatars.githubusercontent.com/u/7148145?v=3","gravatar_id":"","url":"https://api.github.com/users/anderswiden","html_url":"https://github.com/anderswiden","followers_url":"https://api.github.com/users/anderswiden/followers","following_url":"https://api.github.com/users/anderswiden/following{/other_user}","gists_url":"https://api.github.com/users/anderswiden/gists{/gist_id}","starred_url":"https://api.github.com/users/anderswiden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anderswiden/subscriptions","organizations_url":"https://api.github.com/users/anderswiden/orgs","repos_url":"https://api.github.com/users/anderswiden/repos","events_url":"https://api.github.com/users/anderswiden/events{/privacy}","received_events_url":"https://api.github.com/users/anderswiden/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/SafirSDK/safir-sdk-core/milestones/1","html_url":"https://github.com/SafirSDK/safir-sdk-core/milestones/6.1","labels_url":"https://api.github.com/repos/SafirSDK/safir-sdk-core/milestones/1/labels","id":1266179,"number":1,"title":"6.1","description":"","creator":{"login":"DonOregano","id":3583175,"avatar_url":"https://avatars.githubusercontent.com/u/3583175?v=3","gravatar_id":"","url":"https://api.github.com/users/DonOregano","html_url":"https://github.com/DonOregano","followers_url":"https://api.github.com/users/DonOregano/followers","following_url":"https://api.github.com/users/DonOregano/following{/other_user}","gists_url":"https://api.github.com/users/DonOregano/gists{/gist_id}","starred_url":"https://api.github.com/users/DonOregano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonOregano/subscriptions","organizations_url":"https://api.github.com/users/DonOregano/orgs","repos_url":"https://api.github.com/users/DonOregano/repos","events_url":"https://api.github.com/users/DonOregano/events{/privacy}","received_events_url":"https://api.github.com/users/DonOregano/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":21,"state":"open","created_at":"2015-08-21T11:52:55Z","updated_at":"2015-10-12T14:38:51Z","due_on":"2015-10-30T23:00:00Z","closed_at":null},"comments":2,"created_at":"2015-10-02T18:42:49Z","updated_at":"2015-10-12T14:38:51Z","closed_at":null,"body":"If I do Ctrl-C in the safir_control console on Windows dose_main sends stop orders to all applications (e.g. dope_main), but if I instead press the close button no stop orders are sent!\r\n\r\nIf possible we should have the same behaviour for both cases.\r\n\r\nWhat happens on Linux?"},"comment":{"url":"https://api.github.com/repos/SafirSDK/safir-sdk-core/issues/comments/147416099","html_url":"https://github.com/SafirSDK/safir-sdk-core/issues/244#issuecomment-147416099","issue_url":"https://api.github.com/repos/SafirSDK/safir-sdk-core/issues/244","id":147416099,"user":{"login":"DonOregano","id":3583175,"avatar_url":"https://avatars.githubusercontent.com/u/3583175?v=3","gravatar_id":"","url":"https://api.github.com/users/DonOregano","html_url":"https://github.com/DonOregano","followers_url":"https://api.github.com/users/DonOregano/followers","following_url":"https://api.github.com/users/DonOregano/following{/other_user}","gists_url":"https://api.github.com/users/DonOregano/gists{/gist_id}","starred_url":"https://api.github.com/users/DonOregano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonOregano/subscriptions","organizations_url":"https://api.github.com/users/DonOregano/orgs","repos_url":"https://api.github.com/users/DonOregano/repos","events_url":"https://api.github.com/users/DonOregano/events{/privacy}","received_events_url":"https://api.github.com/users/DonOregano/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T14:38:51Z","updated_at":"2015-10-12T14:38:51Z","body":"The fix is more of a workaround than a real fix.\r\nI was not able to get handling of CTRL_CLOSE_EVENT to work together with Boost.Asio, so instead I just disabled the Close button on the terminal window...\r\nNasty side effect is that if you start safir_control in a command prompt the close button will be disabled, and when you stop safir_control it will not be reenabled.\r\n\r\nA proper fix is needed, really... But maybe this is good enough for 6.1?"}}