{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/1321","labels_url":"https://api.github.com/repos/angular/angular/issues/1321/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/1321/comments","events_url":"https://api.github.com/repos/angular/angular/issues/1321/events","html_url":"https://github.com/angular/angular/pull/1321","id":67830159,"number":1321,"title":"feat(build): enforce formatting of some files.","user":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/angular/angular/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"mprobst","id":7208,"avatar_url":"https://avatars.githubusercontent.com/u/7208?v=3","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-04-11T20:30:48Z","updated_at":"2015-04-11T21:22:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/1321","html_url":"https://github.com/angular/angular/pull/1321","diff_url":"https://github.com/angular/angular/pull/1321.diff","patch_url":"https://github.com/angular/angular/pull/1321.patch"},"body":"Our style guide includes formatting conventions. Instead of wasting time in reviewing PRs discussing things like indenting, and to avoid later deltas to fix bad formatting in earlier commits, we want to enforce these in the build.\r\nThe intent in this change is to fail the build as quickly as possible in travis, so those sending a PR immediately know they should run clang-format and update their commit. When running locally, we want users to know about formatting, but they may not want to act on it immediately, until they are done working. For this reason, it is only a warning outside of the continuous build.\r\nThis is done by having a check-format task which should run on most local builds, and an enforce-format task only run by travis."},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/91928200","html_url":"https://github.com/angular/angular/pull/1321#issuecomment-91928200","issue_url":"https://api.github.com/repos/angular/angular/issues/1321","id":91928200,"user":{"login":"alexeagle","id":47395,"avatar_url":"https://avatars.githubusercontent.com/u/47395?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeagle","html_url":"https://github.com/alexeagle","followers_url":"https://api.github.com/users/alexeagle/followers","following_url":"https://api.github.com/users/alexeagle/following{/other_user}","gists_url":"https://api.github.com/users/alexeagle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeagle/subscriptions","organizations_url":"https://api.github.com/users/alexeagle/orgs","repos_url":"https://api.github.com/users/alexeagle/repos","events_url":"https://api.github.com/users/alexeagle/events{/privacy}","received_events_url":"https://api.github.com/users/alexeagle/received_events","type":"User","site_admin":false},"created_at":"2015-04-11T21:22:20Z","updated_at":"2015-04-11T21:22:20Z","body":"Hmm, clang-format doesn't work on the travis arch:\r\n\r\nhttps://travis-ci.org/angular/angular/jobs/58104564#L809\r\n\r\n/home/travis/build/angular/angular/node_modules/gulp-clang-format/node_modules/clang-format/bin/linux_x64/clang-format: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.17' not found (required by /home/travis/build/angular/angular/node_modules/gulp-clang-format/node_modules/clang-format/bin/linux_x64/clang-format)\r\n"}}