{"action":"created","issue":{"url":"https://api.github.com/repos/plasmodic/ecto_opencv/issues/29","labels_url":"https://api.github.com/repos/plasmodic/ecto_opencv/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/plasmodic/ecto_opencv/issues/29/comments","events_url":"https://api.github.com/repos/plasmodic/ecto_opencv/issues/29/events","html_url":"https://github.com/plasmodic/ecto_opencv/pull/29","id":53277695,"number":29,"title":"Only add -msse4.2 if it is supported by the compiler","user":{"login":"cottsay","id":1144588,"avatar_url":"https://avatars.githubusercontent.com/u/1144588?v=3","gravatar_id":"","url":"https://api.github.com/users/cottsay","html_url":"https://github.com/cottsay","followers_url":"https://api.github.com/users/cottsay/followers","following_url":"https://api.github.com/users/cottsay/following{/other_user}","gists_url":"https://api.github.com/users/cottsay/gists{/gist_id}","starred_url":"https://api.github.com/users/cottsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cottsay/subscriptions","organizations_url":"https://api.github.com/users/cottsay/orgs","repos_url":"https://api.github.com/users/cottsay/repos","events_url":"https://api.github.com/users/cottsay/events{/privacy}","received_events_url":"https://api.github.com/users/cottsay/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-02T21:02:05Z","updated_at":"2015-01-03T22:03:54Z","closed_at":"2015-01-03T22:03:54Z","pull_request":{"url":"https://api.github.com/repos/plasmodic/ecto_opencv/pulls/29","html_url":"https://github.com/plasmodic/ecto_opencv/pull/29","diff_url":"https://github.com/plasmodic/ecto_opencv/pull/29.diff","patch_url":"https://github.com/plasmodic/ecto_opencv/pull/29.patch"},"body":"Using CMake's `check_cxx_compiler_flag()`, determine if the compiler supports `-msse4.2` and add it only if it does.\r\n\r\nThe primary motivation is that the flag is not supported on ARM platforms for obvious reasons, and causes the build to fail. This is currently (01/02/2015) the only `Jade` package not building on ARM in Fedora.\r\n\r\nThe check does output the result to the console so it can be verified that it is working correctly. Look for `GCC_HAS_SSE`.\r\n\r\nExample ARM build failure: http://csc.mcs.sdsmt.edu/jenkins/job/ros-jade-ecto-opencv_binaryrpm_21_armhfp/1/consoleFull\r\nExample ARM build after patch: http://csc.mcs.sdsmt.edu/jenkins/job/ros-jade-ecto-opencv_binaryrpm_21_armhfp/3/consoleFull\r\nExample x86 build after patch: http://csc.mcs.sdsmt.edu/jenkins/job/ros-jade-ecto-opencv_binaryrpm_21_x86_64/3/consoleFull\r\n\r\nThanks,\r\n\r\n--scott"},"comment":{"url":"https://api.github.com/repos/plasmodic/ecto_opencv/issues/comments/68611410","html_url":"https://github.com/plasmodic/ecto_opencv/pull/29#issuecomment-68611410","issue_url":"https://api.github.com/repos/plasmodic/ecto_opencv/issues/29","id":68611410,"user":{"login":"vrabaud","id":700766,"avatar_url":"https://avatars.githubusercontent.com/u/700766?v=3","gravatar_id":"","url":"https://api.github.com/users/vrabaud","html_url":"https://github.com/vrabaud","followers_url":"https://api.github.com/users/vrabaud/followers","following_url":"https://api.github.com/users/vrabaud/following{/other_user}","gists_url":"https://api.github.com/users/vrabaud/gists{/gist_id}","starred_url":"https://api.github.com/users/vrabaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrabaud/subscriptions","organizations_url":"https://api.github.com/users/vrabaud/orgs","repos_url":"https://api.github.com/users/vrabaud/repos","events_url":"https://api.github.com/users/vrabaud/events{/privacy}","received_events_url":"https://api.github.com/users/vrabaud/received_events","type":"User","site_admin":false},"created_at":"2015-01-03T22:03:54Z","updated_at":"2015-01-03T22:03:54Z","body":"Hi, though your pull request is totally valid (and thx for showing me that !), this SSE check is actually useless as that code has been moved to opencv_candidate (which actually does not need that flag anymore). I'll make a new release for you. Thx !"}}