{"action":"created","issue":{"url":"https://api.github.com/repos/OmniLayer/omnicore/issues/65","labels_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/65/comments","events_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/65/events","html_url":"https://github.com/OmniLayer/omnicore/issues/65","id":82545189,"number":65,"title":"Windows build is laggy","user":{"login":"dexX7","id":5836089,"avatar_url":"https://avatars.githubusercontent.com/u/5836089?v=3","gravatar_id":"","url":"https://api.github.com/users/dexX7","html_url":"https://github.com/dexX7","followers_url":"https://api.github.com/users/dexX7/followers","following_url":"https://api.github.com/users/dexX7/following{/other_user}","gists_url":"https://api.github.com/users/dexX7/gists{/gist_id}","starred_url":"https://api.github.com/users/dexX7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexX7/subscriptions","organizations_url":"https://api.github.com/users/dexX7/orgs","repos_url":"https://api.github.com/users/dexX7/repos","events_url":"https://api.github.com/users/dexX7/events{/privacy}","received_events_url":"https://api.github.com/users/dexX7/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OmniLayer/omnicore/labels/bug","name":"bug","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2015-05-29T18:58:53Z","updated_at":"2015-05-30T07:53:11Z","closed_at":null,"body":"I've tested a Windows build based on [7239539](https://github.com/dexX7/bitcoin/commit/7239539a5eca5d2c18b4778da63d3a60efea1e0b) yesterday (ping me or @CraigSellars, if you want binaries) on Windows 8.1 x64.\r\n\r\nFirst, the good things:\r\n\r\n - the UI elements are all where they should be :)\r\n - OmniJ regtests pass\r\n\r\nHowever:\r\n\r\n - while catching up with the network (block download), the client was mostly frozen and inactive\r\n - after sending a trade, the client never returned from the frozen or inactive state\r\n\r\nThe tests were done on mainnet, and the last log entry shows an entry for the newly created transaction, though the \"transaction sent\" dialog never popped up."},"comment":{"url":"https://api.github.com/repos/OmniLayer/omnicore/issues/comments/107005022","html_url":"https://github.com/OmniLayer/omnicore/issues/65#issuecomment-107005022","issue_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/65","id":107005022,"user":{"login":"dexX7","id":5836089,"avatar_url":"https://avatars.githubusercontent.com/u/5836089?v=3","gravatar_id":"","url":"https://api.github.com/users/dexX7","html_url":"https://github.com/dexX7","followers_url":"https://api.github.com/users/dexX7/followers","following_url":"https://api.github.com/users/dexX7/following{/other_user}","gists_url":"https://api.github.com/users/dexX7/gists{/gist_id}","starred_url":"https://api.github.com/users/dexX7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexX7/subscriptions","organizations_url":"https://api.github.com/users/dexX7/orgs","repos_url":"https://api.github.com/users/dexX7/repos","events_url":"https://api.github.com/users/dexX7/events{/privacy}","received_events_url":"https://api.github.com/users/dexX7/received_events","type":"User","site_admin":false},"created_at":"2015-05-30T07:53:11Z","updated_at":"2015-05-30T07:53:11Z","body":"Alright:\r\n\r\n- The state, after a fresh start, is indeed persisted, and I confirmed this by checking the existence of state files, and shutting down (and restarting) the client gently (without triggering a freeze).\r\n\r\n- I'm able to create transactions with `setautocommit_OMNI false` via debug console and `send_OMNI` and `sendtrade_OMNI` via debug console\r\n\r\n- I'm able to create transactions with `setautocommit_OMNI false` via UI (trades and sends)\r\n\r\n- When using `setautocommit_OMNI true`, and sending a transaction with `send_OMNI`, the client froze for about ~20-60 sec, but there was a log entry for the pending transaction within the same second where the `ClassAgnosticWalletTXBuilder` entry was written.\r\n\r\n- When sending a transaction (not a trade) via UI, the client appears to stuck, at least that's what I experience at the very moment (~10 minutes waiting). The last log entry is the one from `ClassAgnosticWalletTXBuilder`. The Bitcoin Core log does not yet show an entry for `CommitTransaction`. \r\n\r\nTo pin it further down, it stops somewhere here:\r\n```c++\r\nPrintToLog(\"%s():%s; nFeeRet = %lu, line %d, file: %s\\n\", __FUNCTION__, wtxNew.ToString(), nFeeRet, __LINE__, __FILE__);\r\nif (!wallet->CommitTransaction(wtxNew, reserveKey)) return MP_ERR_COMMIT_TX;\r\n```\r\n```c++\r\nbool CWallet::CommitTransaction(CWalletTx& wtxNew, CReserveKey& reservekey)\r\n{\r\n    {\r\n        LOCK2(cs_main, cs_wallet);\r\n        LogPrintf(\"CommitTransaction:\\n%s\", wtxNew.ToString()); // <--- not yet reached\r\n```\r\n\r\nSo either the `LOCK2` is causing the freeze, or the `LogPrintf`.\r\n\r\n\r\nI'm going to recompile with `CXXFLAGS=\"-DDEBUG_LOCKORDER -g\"` now, which may reveal some locking related issues."}}