{"action":"created","issue":{"url":"https://api.github.com/repos/joyent/node/issues/25291","labels_url":"https://api.github.com/repos/joyent/node/issues/25291/labels{/name}","comments_url":"https://api.github.com/repos/joyent/node/issues/25291/comments","events_url":"https://api.github.com/repos/joyent/node/issues/25291/events","html_url":"https://github.com/joyent/node/pull/25291","id":75856208,"number":25291,"title":"test: relax timing constraints for child process","user":{"login":"gireeshpunathil","id":6447530,"avatar_url":"https://avatars.githubusercontent.com/u/6447530?v=3","gravatar_id":"","url":"https://api.github.com/users/gireeshpunathil","html_url":"https://github.com/gireeshpunathil","followers_url":"https://api.github.com/users/gireeshpunathil/followers","following_url":"https://api.github.com/users/gireeshpunathil/following{/other_user}","gists_url":"https://api.github.com/users/gireeshpunathil/gists{/gist_id}","starred_url":"https://api.github.com/users/gireeshpunathil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gireeshpunathil/subscriptions","organizations_url":"https://api.github.com/users/gireeshpunathil/orgs","repos_url":"https://api.github.com/users/gireeshpunathil/repos","events_url":"https://api.github.com/users/gireeshpunathil/events{/privacy}","received_events_url":"https://api.github.com/users/gireeshpunathil/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joyent/node/labels/P-3","name":"P-3","color":"009800"},{"url":"https://api.github.com/repos/joyent/node/labels/pr","name":"pr","color":"006b75"},{"url":"https://api.github.com/repos/joyent/node/labels/v0.12","name":"v0.12","color":"ededed"}],"state":"closed","locked":false,"assignee":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/joyent/node/milestones/35","html_url":"https://github.com/joyent/node/milestones/0.12.4","labels_url":"https://api.github.com/repos/joyent/node/milestones/35/labels","id":1047992,"number":35,"title":"0.12.4","description":"","creator":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":2,"state":"open","created_at":"2015-04-01T02:01:12Z","updated_at":"2015-05-15T17:11:25Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-05-13T05:40:52Z","updated_at":"2015-05-15T17:11:25Z","closed_at":"2015-05-15T17:11:25Z","pull_request":{"url":"https://api.github.com/repos/joyent/node/pulls/25291","html_url":"https://github.com/joyent/node/pull/25291","diff_url":"https://github.com/joyent/node/pull/25291.diff","patch_url":"https://github.com/joyent/node/pull/25291.patch"},"body":"In windows we were seeing failures in the Node test:\r\n\r\ntest-child-process-spawnsync.js\r\n\r\n\r\nassert.js:86\r\nthrow new assert.AssertionError({\r\nˆ\r\nAssertionError: sleep should not take longer or less than 1 second\r\n\r\nat Object.<anonymous> (test\\simple\\test-child-process-spawnsync.js:44:8)\r\nat Module._compile (module.js:460:26)\r\nat Object.Module._extensions..js (module.js:478:10)\r\nat Module.load (module.js:355:32)\r\nat Function.Module._load (module.js:310:12)\r\nat Function.Module.runMain (module.js:501:10)\r\nat startup (node.js:129:16) # at node.js:814:3\r\n\r\n\r\nThis is easily reproducible by adding additional load to \r\nthe system while the test runs.\r\nWe see that the additional load can cause the sleep\r\nto wakeup after 2 seconds or more instead of the usual/expected\r\n1 second.\r\n\r\nWhile the intent of the test is to test \r\nthe functionality of spawnSync and the child process \r\nin general, in effect it is testing the system command sleep,\r\nand further, it's responsiveness.\r\n\r\nSince from the name the purpose of the test seems to be\r\nunrelated to the sleep behavior, I believe a more meaningful\r\nassertion would be to see the time taken is more than 1 second.\r\n\r\nAnd hence the pull request."},"comment":{"url":"https://api.github.com/repos/joyent/node/issues/comments/102460703","html_url":"https://github.com/joyent/node/pull/25291#issuecomment-102460703","issue_url":"https://api.github.com/repos/joyent/node/issues/25291","id":102460703,"user":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"created_at":"2015-05-15T17:11:25Z","updated_at":"2015-05-15T17:11:25Z","body":"Landed as ebbb3560fabc757b06efa4caff07b2ab4b68b5ba"}}