{"action":"closed","number":3123,"pull_request":{"url":"https://api.github.com/repos/Automattic/mongoose/pulls/3123","id":38875347,"html_url":"https://github.com/Automattic/mongoose/pull/3123","diff_url":"https://github.com/Automattic/mongoose/pull/3123.diff","patch_url":"https://github.com/Automattic/mongoose/pull/3123.patch","issue_url":"https://api.github.com/repos/Automattic/mongoose/issues/3123","number":3123,"state":"closed","locked":false,"title":"Fix incorrect examples of some String validators","user":{"login":"rhmeeuwisse","id":6862247,"avatar_url":"https://avatars.githubusercontent.com/u/6862247?v=3","gravatar_id":"","url":"https://api.github.com/users/rhmeeuwisse","html_url":"https://github.com/rhmeeuwisse","followers_url":"https://api.github.com/users/rhmeeuwisse/followers","following_url":"https://api.github.com/users/rhmeeuwisse/following{/other_user}","gists_url":"https://api.github.com/users/rhmeeuwisse/gists{/gist_id}","starred_url":"https://api.github.com/users/rhmeeuwisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhmeeuwisse/subscriptions","organizations_url":"https://api.github.com/users/rhmeeuwisse/orgs","repos_url":"https://api.github.com/users/rhmeeuwisse/repos","events_url":"https://api.github.com/users/rhmeeuwisse/events{/privacy}","received_events_url":"https://api.github.com/users/rhmeeuwisse/received_events","type":"User","site_admin":false},"body":"On String validators minlength and maxlength:\r\n- the special tokens {MINLENGTH} and {MAXLENGTH} were said to be replaced by the 'invalid value'. Changed that to 'minimum allowed length' and 'maximum allowed length'.\r\n- validate() was called on variable s instead of address.\r\n- The minlength example validated min 10, but shows error msg for min 5. Changed to validate 5\r\n- The maxlength example validated max 10, but validates a max 10 string. Changed to validate 9 and show error msg for 9.","created_at":"2015-06-30T13:07:40Z","updated_at":"2015-06-30T15:38:31Z","closed_at":"2015-06-30T15:38:31Z","merged_at":"2015-06-30T15:38:31Z","merge_commit_sha":"2868d353907a1995cbc9b1173c2dd1007bef7ba5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/mongoose/pulls/3123/commits","review_comments_url":"https://api.github.com/repos/Automattic/mongoose/pulls/3123/comments","review_comment_url":"https://api.github.com/repos/Automattic/mongoose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/mongoose/issues/3123/comments","statuses_url":"https://api.github.com/repos/Automattic/mongoose/statuses/e02c9333bfddb1c0ac30ca4596882bf365334dd1","head":{"label":"rhmeeuwisse:patch-2","ref":"patch-2","sha":"e02c9333bfddb1c0ac30ca4596882bf365334dd1","user":{"login":"rhmeeuwisse","id":6862247,"avatar_url":"https://avatars.githubusercontent.com/u/6862247?v=3","gravatar_id":"","url":"https://api.github.com/users/rhmeeuwisse","html_url":"https://github.com/rhmeeuwisse","followers_url":"https://api.github.com/users/rhmeeuwisse/followers","following_url":"https://api.github.com/users/rhmeeuwisse/following{/other_user}","gists_url":"https://api.github.com/users/rhmeeuwisse/gists{/gist_id}","starred_url":"https://api.github.com/users/rhmeeuwisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhmeeuwisse/subscriptions","organizations_url":"https://api.github.com/users/rhmeeuwisse/orgs","repos_url":"https://api.github.com/users/rhmeeuwisse/repos","events_url":"https://api.github.com/users/rhmeeuwisse/events{/privacy}","received_events_url":"https://api.github.com/users/rhmeeuwisse/received_events","type":"User","site_admin":false},"repo":{"id":38301956,"name":"mongoose","full_name":"rhmeeuwisse/mongoose","owner":{"login":"rhmeeuwisse","id":6862247,"avatar_url":"https://avatars.githubusercontent.com/u/6862247?v=3","gravatar_id":"","url":"https://api.github.com/users/rhmeeuwisse","html_url":"https://github.com/rhmeeuwisse","followers_url":"https://api.github.com/users/rhmeeuwisse/followers","following_url":"https://api.github.com/users/rhmeeuwisse/following{/other_user}","gists_url":"https://api.github.com/users/rhmeeuwisse/gists{/gist_id}","starred_url":"https://api.github.com/users/rhmeeuwisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhmeeuwisse/subscriptions","organizations_url":"https://api.github.com/users/rhmeeuwisse/orgs","repos_url":"https://api.github.com/users/rhmeeuwisse/repos","events_url":"https://api.github.com/users/rhmeeuwisse/events{/privacy}","received_events_url":"https://api.github.com/users/rhmeeuwisse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhmeeuwisse/mongoose","description":"MongoDB object modeling designed to work in an asynchronous environment.","fork":true,"url":"https://api.github.com/repos/rhmeeuwisse/mongoose","forks_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/forks","keys_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/teams","hooks_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/hooks","issue_events_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/issues/events{/number}","events_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/events","assignees_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/assignees{/user}","branches_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/branches{/branch}","tags_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/tags","blobs_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/statuses/{sha}","languages_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/languages","stargazers_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/stargazers","contributors_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/contributors","subscribers_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/subscribers","subscription_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/subscription","commits_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/contents/{+path}","compare_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/merges","archive_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/downloads","issues_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/issues{/number}","pulls_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/pulls{/number}","milestones_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/milestones{/number}","notifications_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/labels{/name}","releases_url":"https://api.github.com/repos/rhmeeuwisse/mongoose/releases{/id}","created_at":"2015-06-30T10:04:13Z","updated_at":"2015-06-30T10:04:17Z","pushed_at":"2015-06-30T13:07:19Z","git_url":"git://github.com/rhmeeuwisse/mongoose.git","ssh_url":"git@github.com:rhmeeuwisse/mongoose.git","clone_url":"https://github.com/rhmeeuwisse/mongoose.git","svn_url":"https://github.com/rhmeeuwisse/mongoose","homepage":"http://mongoosejs.com","size":40085,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"6eaa848c3478d0597166e31b099095fc865f55d0","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":597879,"name":"mongoose","full_name":"Automattic/mongoose","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/mongoose","description":"MongoDB object modeling designed to work in an asynchronous environment.","fork":false,"url":"https://api.github.com/repos/Automattic/mongoose","forks_url":"https://api.github.com/repos/Automattic/mongoose/forks","keys_url":"https://api.github.com/repos/Automattic/mongoose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/mongoose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/mongoose/teams","hooks_url":"https://api.github.com/repos/Automattic/mongoose/hooks","issue_events_url":"https://api.github.com/repos/Automattic/mongoose/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/mongoose/events","assignees_url":"https://api.github.com/repos/Automattic/mongoose/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/mongoose/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/mongoose/tags","blobs_url":"https://api.github.com/repos/Automattic/mongoose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/mongoose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/mongoose/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/mongoose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/mongoose/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/mongoose/languages","stargazers_url":"https://api.github.com/repos/Automattic/mongoose/stargazers","contributors_url":"https://api.github.com/repos/Automattic/mongoose/contributors","subscribers_url":"https://api.github.com/repos/Automattic/mongoose/subscribers","subscription_url":"https://api.github.com/repos/Automattic/mongoose/subscription","commits_url":"https://api.github.com/repos/Automattic/mongoose/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/mongoose/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/mongoose/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/mongoose/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/mongoose/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/mongoose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/mongoose/merges","archive_url":"https://api.github.com/repos/Automattic/mongoose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/mongoose/downloads","issues_url":"https://api.github.com/repos/Automattic/mongoose/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/mongoose/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/mongoose/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/mongoose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/mongoose/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/mongoose/releases{/id}","created_at":"2010-04-06T21:39:05Z","updated_at":"2015-06-30T14:48:19Z","pushed_at":"2015-06-30T15:38:31Z","git_url":"git://github.com/Automattic/mongoose.git","ssh_url":"git@github.com:Automattic/mongoose.git","clone_url":"https://github.com/Automattic/mongoose.git","svn_url":"https://github.com/Automattic/mongoose","homepage":"http://mongoosejs.com","size":40085,"stargazers_count":7114,"watchers_count":7114,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1089,"mirror_url":null,"open_issues_count":377,"forks":1089,"open_issues":377,"watchers":7114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/mongoose/pulls/3123"},"html":{"href":"https://github.com/Automattic/mongoose/pull/3123"},"issue":{"href":"https://api.github.com/repos/Automattic/mongoose/issues/3123"},"comments":{"href":"https://api.github.com/repos/Automattic/mongoose/issues/3123/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/mongoose/pulls/3123/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/mongoose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/mongoose/pulls/3123/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/mongoose/statuses/e02c9333bfddb1c0ac30ca4596882bf365334dd1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vkarpov15","id":1620265,"avatar_url":"https://avatars.githubusercontent.com/u/1620265?v=3","gravatar_id":"","url":"https://api.github.com/users/vkarpov15","html_url":"https://github.com/vkarpov15","followers_url":"https://api.github.com/users/vkarpov15/followers","following_url":"https://api.github.com/users/vkarpov15/following{/other_user}","gists_url":"https://api.github.com/users/vkarpov15/gists{/gist_id}","starred_url":"https://api.github.com/users/vkarpov15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkarpov15/subscriptions","organizations_url":"https://api.github.com/users/vkarpov15/orgs","repos_url":"https://api.github.com/users/vkarpov15/repos","events_url":"https://api.github.com/users/vkarpov15/events{/privacy}","received_events_url":"https://api.github.com/users/vkarpov15/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":6,"deletions":6,"changed_files":1}}