{"action":"created","comment":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/comments/42297201","id":42297201,"diff_hunk":"@@ -111,6 +111,16 @@ public void testTypeInDocAndSyntax() {\n     parse(\"var /** string */ foo: string = 'hello';\");\n   }\n \n+  public void testTypedGetterSetterDeclaration() {\n+    Node n = parse(\"var x = {get a(): number {\\n}};\", LanguageMode.ECMASCRIPT6_TYPED);\n+    assertDeclaredType(\"number type\", numberType(),\n+        n.getFirstChild().getFirstChild().getFirstChild().getFirstChild().getFirstChild());\n+    n = parse(\"var x = {set a(v: number) {\\n}};\", LanguageMode.ECMASCRIPT6_TYPED);\n+    assertDeclaredType(\"number type\", numberType(),\n+        n.getFirstChild().getFirstChild().getFirstChild().getFirstChild().getFirstChild().getChildAtIndex(1)","path":"test/com/google/javascript/jscomp/parsing/TypeSyntaxTest.java","position":10,"original_position":10,"commit_id":"62987b4a279d1d853740b134e7c74e3670920d1d","original_commit_id":"62987b4a279d1d853740b134e7c74e3670920d1d","user":{"login":"mprobst","id":7208,"avatar_url":"https://avatars.githubusercontent.com/u/7208?v=3","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"body":"nit: I think there were some test utilities that allowed you to search a tree for a node of a particular type - that might be more readable than this tree navigation style.","created_at":"2015-10-16T22:32:38Z","updated_at":"2015-10-16T22:32:38Z","html_url":"https://github.com/google/closure-compiler/pull/1217#discussion_r42297201","pull_request_url":"https://api.github.com/repos/google/closure-compiler/pulls/1217","_links":{"self":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/comments/42297201"},"html":{"href":"https://github.com/google/closure-compiler/pull/1217#discussion_r42297201"},"pull_request":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1217"}}},"pull_request":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/1217","id":47893282,"html_url":"https://github.com/google/closure-compiler/pull/1217","diff_url":"https://github.com/google/closure-compiler/pull/1217.diff","patch_url":"https://github.com/google/closure-compiler/pull/1217.patch","issue_url":"https://api.github.com/repos/google/closure-compiler/issues/1217","number":1217,"state":"open","locked":false,"title":"fix issue #1216","user":{"login":"rikuayanokozy","id":10336620,"avatar_url":"https://avatars.githubusercontent.com/u/10336620?v=3","gravatar_id":"","url":"https://api.github.com/users/rikuayanokozy","html_url":"https://github.com/rikuayanokozy","followers_url":"https://api.github.com/users/rikuayanokozy/followers","following_url":"https://api.github.com/users/rikuayanokozy/following{/other_user}","gists_url":"https://api.github.com/users/rikuayanokozy/gists{/gist_id}","starred_url":"https://api.github.com/users/rikuayanokozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rikuayanokozy/subscriptions","organizations_url":"https://api.github.com/users/rikuayanokozy/orgs","repos_url":"https://api.github.com/users/rikuayanokozy/repos","events_url":"https://api.github.com/users/rikuayanokozy/events{/privacy}","received_events_url":"https://api.github.com/users/rikuayanokozy/received_events","type":"User","site_admin":false},"body":"fix issue [#1216](https://github.com/google/closure-compiler/issues/1216)","created_at":"2015-10-16T10:18:53Z","updated_at":"2015-10-16T22:32:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2283738cd19aab96fc36652d7eb031b26fe68d2d","assignee":{"login":"mprobst","id":7208,"avatar_url":"https://avatars.githubusercontent.com/u/7208?v=3","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/google/closure-compiler/pulls/1217/commits","review_comments_url":"https://api.github.com/repos/google/closure-compiler/pulls/1217/comments","review_comment_url":"https://api.github.com/repos/google/closure-compiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/closure-compiler/issues/1217/comments","statuses_url":"https://api.github.com/repos/google/closure-compiler/statuses/62987b4a279d1d853740b134e7c74e3670920d1d","head":{"label":"rikuayanokozy:fix-es6typedgettersetter","ref":"fix-es6typedgettersetter","sha":"62987b4a279d1d853740b134e7c74e3670920d1d","user":{"login":"rikuayanokozy","id":10336620,"avatar_url":"https://avatars.githubusercontent.com/u/10336620?v=3","gravatar_id":"","url":"https://api.github.com/users/rikuayanokozy","html_url":"https://github.com/rikuayanokozy","followers_url":"https://api.github.com/users/rikuayanokozy/followers","following_url":"https://api.github.com/users/rikuayanokozy/following{/other_user}","gists_url":"https://api.github.com/users/rikuayanokozy/gists{/gist_id}","starred_url":"https://api.github.com/users/rikuayanokozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rikuayanokozy/subscriptions","organizations_url":"https://api.github.com/users/rikuayanokozy/orgs","repos_url":"https://api.github.com/users/rikuayanokozy/repos","events_url":"https://api.github.com/users/rikuayanokozy/events{/privacy}","received_events_url":"https://api.github.com/users/rikuayanokozy/received_events","type":"User","site_admin":false},"repo":{"id":44263019,"name":"closure-compiler","full_name":"rikuayanokozy/closure-compiler","owner":{"login":"rikuayanokozy","id":10336620,"avatar_url":"https://avatars.githubusercontent.com/u/10336620?v=3","gravatar_id":"","url":"https://api.github.com/users/rikuayanokozy","html_url":"https://github.com/rikuayanokozy","followers_url":"https://api.github.com/users/rikuayanokozy/followers","following_url":"https://api.github.com/users/rikuayanokozy/following{/other_user}","gists_url":"https://api.github.com/users/rikuayanokozy/gists{/gist_id}","starred_url":"https://api.github.com/users/rikuayanokozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rikuayanokozy/subscriptions","organizations_url":"https://api.github.com/users/rikuayanokozy/orgs","repos_url":"https://api.github.com/users/rikuayanokozy/repos","events_url":"https://api.github.com/users/rikuayanokozy/events{/privacy}","received_events_url":"https://api.github.com/users/rikuayanokozy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rikuayanokozy/closure-compiler","description":"A JavaScript checker and optimizer.","fork":true,"url":"https://api.github.com/repos/rikuayanokozy/closure-compiler","forks_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/forks","keys_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/teams","hooks_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/events","assignees_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/tags","blobs_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/languages","stargazers_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/subscription","commits_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/merges","archive_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/downloads","issues_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/rikuayanokozy/closure-compiler/releases{/id}","created_at":"2015-10-14T17:01:34Z","updated_at":"2015-10-14T17:01:47Z","pushed_at":"2015-10-16T10:17:09Z","git_url":"git://github.com/rikuayanokozy/closure-compiler.git","ssh_url":"git@github.com:rikuayanokozy/closure-compiler.git","clone_url":"https://github.com/rikuayanokozy/closure-compiler.git","svn_url":"https://github.com/rikuayanokozy/closure-compiler","homepage":" https://developers.google.com/closure/compiler/","size":112071,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"888703ceb0cb8a4bd188322638566fc50e0826dd","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":18845024,"name":"closure-compiler","full_name":"google/closure-compiler","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/closure-compiler","description":"A JavaScript checker and optimizer.","fork":false,"url":"https://api.github.com/repos/google/closure-compiler","forks_url":"https://api.github.com/repos/google/closure-compiler/forks","keys_url":"https://api.github.com/repos/google/closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/closure-compiler/teams","hooks_url":"https://api.github.com/repos/google/closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/google/closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/google/closure-compiler/events","assignees_url":"https://api.github.com/repos/google/closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/google/closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/google/closure-compiler/tags","blobs_url":"https://api.github.com/repos/google/closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/google/closure-compiler/languages","stargazers_url":"https://api.github.com/repos/google/closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/google/closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/google/closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/google/closure-compiler/subscription","commits_url":"https://api.github.com/repos/google/closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/google/closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/closure-compiler/merges","archive_url":"https://api.github.com/repos/google/closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/closure-compiler/downloads","issues_url":"https://api.github.com/repos/google/closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/google/closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/google/closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/google/closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/google/closure-compiler/releases{/id}","created_at":"2014-04-16T15:30:36Z","updated_at":"2015-10-16T22:00:03Z","pushed_at":"2015-10-16T18:44:50Z","git_url":"git://github.com/google/closure-compiler.git","ssh_url":"git@github.com:google/closure-compiler.git","clone_url":"https://github.com/google/closure-compiler.git","svn_url":"https://github.com/google/closure-compiler","homepage":" https://developers.google.com/closure/compiler/","size":112071,"stargazers_count":1714,"watchers_count":1714,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":387,"mirror_url":null,"open_issues_count":417,"forks":387,"open_issues":417,"watchers":1714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1217"},"html":{"href":"https://github.com/google/closure-compiler/pull/1217"},"issue":{"href":"https://api.github.com/repos/google/closure-compiler/issues/1217"},"comments":{"href":"https://api.github.com/repos/google/closure-compiler/issues/1217/comments"},"review_comments":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1217/comments"},"review_comment":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1217/commits"},"statuses":{"href":"https://api.github.com/repos/google/closure-compiler/statuses/62987b4a279d1d853740b134e7c74e3670920d1d"}}}}