{"action":"created","comment":{"url":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/comments/41185506","id":41185506,"diff_hunk":"@@ -261,6 +261,48 @@ object Tasks {\n     }\n   }\n \n+  val duplicateAars = Def.task {\n+    Resources\n+      .collectdeps(libraryProjects.value)\n+      .collect { case a @ AarLibrary(_) ⇒ a }\n+      .groupBy(_.moduleID.name)\n+      .filter(_._2.length > 1)\n+  }\n+\n+  val checkAarsTaskDef = Def.task {\n+    implicit val log = streams.value.log\n+    implicit val struct = buildStructure.value\n+    val deps = thisProjectRef.value.deepDeps\n+    def revDependents(aar: AarLibrary) = deps.filter(_.dependsOnAar(aar))\n+    def pkgDependents(data: (String, Seq[AarLibrary])) = {\n+      (data._1, data._2, data._2 map(revDependents))\n+    }\n+    val broken = duplicateAars.value","path":"src/tasks.scala","position":20,"original_position":20,"commit_id":"4498ca5d4632a831d5054984c86514ba259f9cdc","original_commit_id":"4498ca5d4632a831d5054984c86514ba259f9cdc","user":{"login":"tek","id":2632,"avatar_url":"https://avatars.githubusercontent.com/u/2632?v=3","gravatar_id":"","url":"https://api.github.com/users/tek","html_url":"https://github.com/tek","followers_url":"https://api.github.com/users/tek/followers","following_url":"https://api.github.com/users/tek/following{/other_user}","gists_url":"https://api.github.com/users/tek/gists{/gist_id}","starred_url":"https://api.github.com/users/tek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tek/subscriptions","organizations_url":"https://api.github.com/users/tek/orgs","repos_url":"https://api.github.com/users/tek/repos","events_url":"https://api.github.com/users/tek/events{/privacy}","received_events_url":"https://api.github.com/users/tek/received_events","type":"User","site_admin":false},"body":"Alright, I'm on vacation until Wednesday, will fix it then\nOn Oct 5, 2015 8:54 PM, \"Perry\" <notifications@github.com> wrote:\n\n> In src/tasks.scala\n> <https://github.com/pfn/android-sdk-plugin/pull/211#discussion_r41182275>:\n>\n> > +    Resources\n> > +      .collectdeps(libraryProjects.value)\n> > +      .collect { case a @ AarLibrary(_) ⇒ a }\n> > +      .groupBy(_.moduleID.name)\n> > +      .filter(_._2.length > 1)\n> > +  }\n> > +\n> > +  val checkAarsTaskDef = Def.task {\n> > +    implicit val log = streams.value.log\n> > +    implicit val struct = buildStructure.value\n> > +    val deps = thisProjectRef.value.deepDeps\n> > +    def revDependents(aar: AarLibrary) = deps.filter(_.dependsOnAar(aar))\n> > +    def pkgDependents(data: (String, Seq[AarLibrary])) = {\n> > +      (data._1, data._2, data._2 map(revDependents))\n> > +    }\n> > +    val broken = duplicateAars.value\n>\n> neat, didn't know you could .value on arbitrary task values\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/pfn/android-sdk-plugin/pull/211/files#r41182275>.\n>\n","created_at":"2015-10-05T19:23:03Z","updated_at":"2015-10-05T19:23:03Z","html_url":"https://github.com/pfn/android-sdk-plugin/pull/211#discussion_r41185506","pull_request_url":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/211","_links":{"self":{"href":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/comments/41185506"},"html":{"href":"https://github.com/pfn/android-sdk-plugin/pull/211#discussion_r41185506"},"pull_request":{"href":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/211"}}},"pull_request":{"url":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/211","id":46707073,"html_url":"https://github.com/pfn/android-sdk-plugin/pull/211","diff_url":"https://github.com/pfn/android-sdk-plugin/pull/211.diff","patch_url":"https://github.com/pfn/android-sdk-plugin/pull/211.patch","issue_url":"https://api.github.com/repos/pfn/android-sdk-plugin/issues/211","number":211,"state":"open","locked":false,"title":"checkAars task","user":{"login":"tek","id":2632,"avatar_url":"https://avatars.githubusercontent.com/u/2632?v=3","gravatar_id":"","url":"https://api.github.com/users/tek","html_url":"https://github.com/tek","followers_url":"https://api.github.com/users/tek/followers","following_url":"https://api.github.com/users/tek/following{/other_user}","gists_url":"https://api.github.com/users/tek/gists{/gist_id}","starred_url":"https://api.github.com/users/tek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tek/subscriptions","organizations_url":"https://api.github.com/users/tek/orgs","repos_url":"https://api.github.com/users/tek/repos","events_url":"https://api.github.com/users/tek/events{/privacy}","received_events_url":"https://api.github.com/users/tek/received_events","type":"User","site_admin":false},"body":"collect all AarLibrary deps and determines duplicates with different versions\n\nsearches the complete sbt project dep tree for the source of the duplicate depspecs","created_at":"2015-10-03T15:11:12Z","updated_at":"2015-10-05T19:23:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13ba370a51e7d90fb228daeb9298c5a0575b2815","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/211/commits","review_comments_url":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/211/comments","review_comment_url":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pfn/android-sdk-plugin/issues/211/comments","statuses_url":"https://api.github.com/repos/pfn/android-sdk-plugin/statuses/4498ca5d4632a831d5054984c86514ba259f9cdc","head":{"label":"tek:check_aars_task","ref":"check_aars_task","sha":"4498ca5d4632a831d5054984c86514ba259f9cdc","user":{"login":"tek","id":2632,"avatar_url":"https://avatars.githubusercontent.com/u/2632?v=3","gravatar_id":"","url":"https://api.github.com/users/tek","html_url":"https://github.com/tek","followers_url":"https://api.github.com/users/tek/followers","following_url":"https://api.github.com/users/tek/following{/other_user}","gists_url":"https://api.github.com/users/tek/gists{/gist_id}","starred_url":"https://api.github.com/users/tek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tek/subscriptions","organizations_url":"https://api.github.com/users/tek/orgs","repos_url":"https://api.github.com/users/tek/repos","events_url":"https://api.github.com/users/tek/events{/privacy}","received_events_url":"https://api.github.com/users/tek/received_events","type":"User","site_admin":false},"repo":{"id":29141312,"name":"android-sdk-plugin","full_name":"tek/android-sdk-plugin","owner":{"login":"tek","id":2632,"avatar_url":"https://avatars.githubusercontent.com/u/2632?v=3","gravatar_id":"","url":"https://api.github.com/users/tek","html_url":"https://github.com/tek","followers_url":"https://api.github.com/users/tek/followers","following_url":"https://api.github.com/users/tek/following{/other_user}","gists_url":"https://api.github.com/users/tek/gists{/gist_id}","starred_url":"https://api.github.com/users/tek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tek/subscriptions","organizations_url":"https://api.github.com/users/tek/orgs","repos_url":"https://api.github.com/users/tek/repos","events_url":"https://api.github.com/users/tek/events{/privacy}","received_events_url":"https://api.github.com/users/tek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tek/android-sdk-plugin","description":"An easy-to-use sbt plugin for working with all Android projects","fork":true,"url":"https://api.github.com/repos/tek/android-sdk-plugin","forks_url":"https://api.github.com/repos/tek/android-sdk-plugin/forks","keys_url":"https://api.github.com/repos/tek/android-sdk-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tek/android-sdk-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tek/android-sdk-plugin/teams","hooks_url":"https://api.github.com/repos/tek/android-sdk-plugin/hooks","issue_events_url":"https://api.github.com/repos/tek/android-sdk-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/tek/android-sdk-plugin/events","assignees_url":"https://api.github.com/repos/tek/android-sdk-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/tek/android-sdk-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/tek/android-sdk-plugin/tags","blobs_url":"https://api.github.com/repos/tek/android-sdk-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tek/android-sdk-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tek/android-sdk-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/tek/android-sdk-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tek/android-sdk-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/tek/android-sdk-plugin/languages","stargazers_url":"https://api.github.com/repos/tek/android-sdk-plugin/stargazers","contributors_url":"https://api.github.com/repos/tek/android-sdk-plugin/contributors","subscribers_url":"https://api.github.com/repos/tek/android-sdk-plugin/subscribers","subscription_url":"https://api.github.com/repos/tek/android-sdk-plugin/subscription","commits_url":"https://api.github.com/repos/tek/android-sdk-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/tek/android-sdk-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/tek/android-sdk-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/tek/android-sdk-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/tek/android-sdk-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/tek/android-sdk-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tek/android-sdk-plugin/merges","archive_url":"https://api.github.com/repos/tek/android-sdk-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tek/android-sdk-plugin/downloads","issues_url":"https://api.github.com/repos/tek/android-sdk-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/tek/android-sdk-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/tek/android-sdk-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/tek/android-sdk-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tek/android-sdk-plugin/labels{/name}","releases_url":"https://api.github.com/repos/tek/android-sdk-plugin/releases{/id}","created_at":"2015-01-12T15:18:12Z","updated_at":"2015-01-12T15:18:12Z","pushed_at":"2015-10-03T15:08:11Z","git_url":"git://github.com/tek/android-sdk-plugin.git","ssh_url":"git@github.com:tek/android-sdk-plugin.git","clone_url":"https://github.com/tek/android-sdk-plugin.git","svn_url":"https://github.com/tek/android-sdk-plugin","homepage":"","size":4242,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pfn:master","ref":"master","sha":"25889b1a6e26448baf6d641711ec6bc25229786e","user":{"login":"pfn","id":512197,"avatar_url":"https://avatars.githubusercontent.com/u/512197?v=3","gravatar_id":"","url":"https://api.github.com/users/pfn","html_url":"https://github.com/pfn","followers_url":"https://api.github.com/users/pfn/followers","following_url":"https://api.github.com/users/pfn/following{/other_user}","gists_url":"https://api.github.com/users/pfn/gists{/gist_id}","starred_url":"https://api.github.com/users/pfn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfn/subscriptions","organizations_url":"https://api.github.com/users/pfn/orgs","repos_url":"https://api.github.com/users/pfn/repos","events_url":"https://api.github.com/users/pfn/events{/privacy}","received_events_url":"https://api.github.com/users/pfn/received_events","type":"User","site_admin":false},"repo":{"id":3532660,"name":"android-sdk-plugin","full_name":"pfn/android-sdk-plugin","owner":{"login":"pfn","id":512197,"avatar_url":"https://avatars.githubusercontent.com/u/512197?v=3","gravatar_id":"","url":"https://api.github.com/users/pfn","html_url":"https://github.com/pfn","followers_url":"https://api.github.com/users/pfn/followers","following_url":"https://api.github.com/users/pfn/following{/other_user}","gists_url":"https://api.github.com/users/pfn/gists{/gist_id}","starred_url":"https://api.github.com/users/pfn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfn/subscriptions","organizations_url":"https://api.github.com/users/pfn/orgs","repos_url":"https://api.github.com/users/pfn/repos","events_url":"https://api.github.com/users/pfn/events{/privacy}","received_events_url":"https://api.github.com/users/pfn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfn/android-sdk-plugin","description":"An easy-to-use sbt plugin for working with all Android projects","fork":false,"url":"https://api.github.com/repos/pfn/android-sdk-plugin","forks_url":"https://api.github.com/repos/pfn/android-sdk-plugin/forks","keys_url":"https://api.github.com/repos/pfn/android-sdk-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfn/android-sdk-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfn/android-sdk-plugin/teams","hooks_url":"https://api.github.com/repos/pfn/android-sdk-plugin/hooks","issue_events_url":"https://api.github.com/repos/pfn/android-sdk-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/pfn/android-sdk-plugin/events","assignees_url":"https://api.github.com/repos/pfn/android-sdk-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/pfn/android-sdk-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/pfn/android-sdk-plugin/tags","blobs_url":"https://api.github.com/repos/pfn/android-sdk-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfn/android-sdk-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfn/android-sdk-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfn/android-sdk-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfn/android-sdk-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/pfn/android-sdk-plugin/languages","stargazers_url":"https://api.github.com/repos/pfn/android-sdk-plugin/stargazers","contributors_url":"https://api.github.com/repos/pfn/android-sdk-plugin/contributors","subscribers_url":"https://api.github.com/repos/pfn/android-sdk-plugin/subscribers","subscription_url":"https://api.github.com/repos/pfn/android-sdk-plugin/subscription","commits_url":"https://api.github.com/repos/pfn/android-sdk-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfn/android-sdk-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfn/android-sdk-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfn/android-sdk-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfn/android-sdk-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/pfn/android-sdk-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfn/android-sdk-plugin/merges","archive_url":"https://api.github.com/repos/pfn/android-sdk-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfn/android-sdk-plugin/downloads","issues_url":"https://api.github.com/repos/pfn/android-sdk-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/pfn/android-sdk-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/pfn/android-sdk-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfn/android-sdk-plugin/labels{/name}","releases_url":"https://api.github.com/repos/pfn/android-sdk-plugin/releases{/id}","created_at":"2012-02-24T04:11:36Z","updated_at":"2015-10-03T16:15:40Z","pushed_at":"2015-10-05T17:12:41Z","git_url":"git://github.com/pfn/android-sdk-plugin.git","ssh_url":"git@github.com:pfn/android-sdk-plugin.git","clone_url":"https://github.com/pfn/android-sdk-plugin.git","svn_url":"https://github.com/pfn/android-sdk-plugin","homepage":"","size":5880,"stargazers_count":377,"watchers_count":377,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":8,"forks":51,"open_issues":8,"watchers":377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/211"},"html":{"href":"https://github.com/pfn/android-sdk-plugin/pull/211"},"issue":{"href":"https://api.github.com/repos/pfn/android-sdk-plugin/issues/211"},"comments":{"href":"https://api.github.com/repos/pfn/android-sdk-plugin/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pfn/android-sdk-plugin/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/pfn/android-sdk-plugin/statuses/4498ca5d4632a831d5054984c86514ba259f9cdc"}}}}