{"action":"created","issue":{"url":"https://api.github.com/repos/bitwiseworks/mozilla-os2/issues/89","labels_url":"https://api.github.com/repos/bitwiseworks/mozilla-os2/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/bitwiseworks/mozilla-os2/issues/89/comments","events_url":"https://api.github.com/repos/bitwiseworks/mozilla-os2/issues/89/events","html_url":"https://github.com/bitwiseworks/mozilla-os2/issues/89","id":53325360,"number":89,"title":"Make xul.dll work better with high memory","user":{"login":"dryeo","id":399667,"avatar_url":"https://avatars.githubusercontent.com/u/399667?v=3","gravatar_id":"","url":"https://api.github.com/users/dryeo","html_url":"https://github.com/dryeo","followers_url":"https://api.github.com/users/dryeo/followers","following_url":"https://api.github.com/users/dryeo/following{/other_user}","gists_url":"https://api.github.com/users/dryeo/gists{/gist_id}","starred_url":"https://api.github.com/users/dryeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryeo/subscriptions","organizations_url":"https://api.github.com/users/dryeo/orgs","repos_url":"https://api.github.com/users/dryeo/repos","events_url":"https://api.github.com/users/dryeo/events{/privacy}","received_events_url":"https://api.github.com/users/dryeo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitwiseworks/mozilla-os2/labels/bug","name":"bug","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/bitwiseworks/mozilla-os2/milestones/11","labels_url":"https://api.github.com/repos/bitwiseworks/mozilla-os2/milestones/11/labels","id":917792,"number":11,"title":"Firefox 24 Beta 4","description":"Forth beta of Firefox 24 to address the Java plugin hang and other critical issues.","creator":{"login":"SilvanScherrer","id":1235738,"avatar_url":"https://avatars.githubusercontent.com/u/1235738?v=3","gravatar_id":"","url":"https://api.github.com/users/SilvanScherrer","html_url":"https://github.com/SilvanScherrer","followers_url":"https://api.github.com/users/SilvanScherrer/followers","following_url":"https://api.github.com/users/SilvanScherrer/following{/other_user}","gists_url":"https://api.github.com/users/SilvanScherrer/gists{/gist_id}","starred_url":"https://api.github.com/users/SilvanScherrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilvanScherrer/subscriptions","organizations_url":"https://api.github.com/users/SilvanScherrer/orgs","repos_url":"https://api.github.com/users/SilvanScherrer/repos","events_url":"https://api.github.com/users/SilvanScherrer/events{/privacy}","received_events_url":"https://api.github.com/users/SilvanScherrer/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":0,"state":"open","created_at":"2014-12-30T17:33:57Z","updated_at":"2015-01-05T09:59:41Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-01-04T04:59:39Z","updated_at":"2015-01-05T16:59:17Z","closed_at":null,"body":"While the updated os2lib and os2safe.h helped with making Firefox 10.0.12's xul.dll work with high memory, it didn't with 24.8.1. Seems that xpcom/io/nsLocalfileOS2.cpp no longer includes os2safe.h before os2.h. Examining the symbols shows that it is using DosQueryDBCSEnv rather then SafeDosQueryDBCSEnv \r\nThanks to os4user for finding this problem, I fixed it with this,\r\n```\r\ndiff --git a/xpcom/io/nsLocalFileOS2.h b/xpcom/io/nsLocalFileOS2.h\r\nindex 5f02de1..2087077 100644\r\n--- a/xpcom/io/nsLocalFileOS2.h\r\n+++ b/xpcom/io/nsLocalFileOS2.h\r\n@@ -24,6 +24,8 @@\r\n #include \"nsIHashable.h\"\r\n #include \"nsIClassInfoImpl.h\"\r\n\r\n+#include <os2safe.h>\r\n+\r\n #define INCL_DOS\r\n #define INCL_DOSERRORS\r\n #define INCL_WINCOUNTRY\r\n``` "},"comment":{"url":"https://api.github.com/repos/bitwiseworks/mozilla-os2/issues/comments/68738112","html_url":"https://github.com/bitwiseworks/mozilla-os2/issues/89#issuecomment-68738112","issue_url":"https://api.github.com/repos/bitwiseworks/mozilla-os2/issues/89","id":68738112,"user":{"login":"dryeo","id":399667,"avatar_url":"https://avatars.githubusercontent.com/u/399667?v=3","gravatar_id":"","url":"https://api.github.com/users/dryeo","html_url":"https://github.com/dryeo","followers_url":"https://api.github.com/users/dryeo/followers","following_url":"https://api.github.com/users/dryeo/following{/other_user}","gists_url":"https://api.github.com/users/dryeo/gists{/gist_id}","starred_url":"https://api.github.com/users/dryeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryeo/subscriptions","organizations_url":"https://api.github.com/users/dryeo/orgs","repos_url":"https://api.github.com/users/dryeo/repos","events_url":"https://api.github.com/users/dryeo/events{/privacy}","received_events_url":"https://api.github.com/users/dryeo/received_events","type":"User","site_admin":false},"created_at":"2015-01-05T16:59:17Z","updated_at":"2015-01-05T16:59:17Z","body":"On 01/05/15 01:50 AM, wztest wrote:\n> Is this also true for the latest beta3 build of Firefox 24.8.1?\n>\n\nYes."}}