{"action":"created","comment":{"url":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/comments/28195200","id":28195200,"diff_hunk":"@@ -2095,7 +2105,7 @@ def _band_pass_filter(ica, sources, target, l_freq, h_freq, verbose=None):\n \n @verbose\n def corrmap(icas, template, threshold=\"auto\", label=\"bads\",\n-            plot=True, inplace=False, ch_type=\"eeg\"):\n+            plot=True, copy=False, ch_type=\"eeg\"):","path":"mne/preprocessing/ica.py","position":58,"original_position":58,"commit_id":"f3529270cc12fa740a94bd09edc9122d3761a670","original_commit_id":"f3529270cc12fa740a94bd09edc9122d3761a670","user":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"body":"everywhere else ...","created_at":"2015-04-11T14:12:43Z","updated_at":"2015-04-11T14:12:43Z","html_url":"https://github.com/jona-sassenhagen/mne-python/pull/1#discussion_r28195200","pull_request_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/comments/28195200"},"html":{"href":"https://github.com/jona-sassenhagen/mne-python/pull/1#discussion_r28195200"},"pull_request":{"href":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/1","id":33103583,"html_url":"https://github.com/jona-sassenhagen/mne-python/pull/1","diff_url":"https://github.com/jona-sassenhagen/mne-python/pull/1.diff","patch_url":"https://github.com/jona-sassenhagen/mne-python/pull/1.patch","issue_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/issues/1","number":1,"state":"open","locked":false,"title":"some cleanup + bug fixes","user":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"body":"@jona-sassenhagen 1 pass of cleaning up your PR code. I'm btw. not really happy with the corrmap return signature. The plot is done inside, no figure is returned, etc. We need to think about a better API for that. Maybe we can have a function that takes a list of ICA solutions and plots one figure per label. To be discussed. ","created_at":"2015-04-11T13:56:31Z","updated_at":"2015-04-11T14:12:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65678a6a8a556f41d20642b0347f86285a7b373f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/issues/1/comments","statuses_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/statuses/f3529270cc12fa740a94bd09edc9122d3761a670","head":{"label":"dengemann:patch-3","ref":"patch-3","sha":"f3529270cc12fa740a94bd09edc9122d3761a670","user":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"repo":{"id":5578745,"name":"mne-python","full_name":"dengemann/mne-python","owner":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dengemann/mne-python","description":"MNE scripting with Python","fork":true,"url":"https://api.github.com/repos/dengemann/mne-python","forks_url":"https://api.github.com/repos/dengemann/mne-python/forks","keys_url":"https://api.github.com/repos/dengemann/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dengemann/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dengemann/mne-python/teams","hooks_url":"https://api.github.com/repos/dengemann/mne-python/hooks","issue_events_url":"https://api.github.com/repos/dengemann/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/dengemann/mne-python/events","assignees_url":"https://api.github.com/repos/dengemann/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/dengemann/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/dengemann/mne-python/tags","blobs_url":"https://api.github.com/repos/dengemann/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dengemann/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dengemann/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dengemann/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dengemann/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dengemann/mne-python/languages","stargazers_url":"https://api.github.com/repos/dengemann/mne-python/stargazers","contributors_url":"https://api.github.com/repos/dengemann/mne-python/contributors","subscribers_url":"https://api.github.com/repos/dengemann/mne-python/subscribers","subscription_url":"https://api.github.com/repos/dengemann/mne-python/subscription","commits_url":"https://api.github.com/repos/dengemann/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dengemann/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dengemann/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dengemann/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dengemann/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/dengemann/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dengemann/mne-python/merges","archive_url":"https://api.github.com/repos/dengemann/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dengemann/mne-python/downloads","issues_url":"https://api.github.com/repos/dengemann/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/dengemann/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dengemann/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dengemann/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dengemann/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/dengemann/mne-python/releases{/id}","created_at":"2012-08-28T00:07:46Z","updated_at":"2014-09-16T13:18:12Z","pushed_at":"2015-04-11T13:54:06Z","git_url":"git://github.com/dengemann/mne-python.git","ssh_url":"git@github.com:dengemann/mne-python.git","clone_url":"https://github.com/dengemann/mne-python.git","svn_url":"https://github.com/dengemann/mne-python","homepage":"http://martinos.org/mne/","size":107177,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jona-sassenhagen:patch-3","ref":"patch-3","sha":"2f82e21f1679dcb576b1855b08942daed3eb16c9","user":{"login":"jona-sassenhagen","id":4321826,"avatar_url":"https://avatars.githubusercontent.com/u/4321826?v=3","gravatar_id":"","url":"https://api.github.com/users/jona-sassenhagen","html_url":"https://github.com/jona-sassenhagen","followers_url":"https://api.github.com/users/jona-sassenhagen/followers","following_url":"https://api.github.com/users/jona-sassenhagen/following{/other_user}","gists_url":"https://api.github.com/users/jona-sassenhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/jona-sassenhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jona-sassenhagen/subscriptions","organizations_url":"https://api.github.com/users/jona-sassenhagen/orgs","repos_url":"https://api.github.com/users/jona-sassenhagen/repos","events_url":"https://api.github.com/users/jona-sassenhagen/events{/privacy}","received_events_url":"https://api.github.com/users/jona-sassenhagen/received_events","type":"User","site_admin":false},"repo":{"id":26366770,"name":"mne-python","full_name":"jona-sassenhagen/mne-python","owner":{"login":"jona-sassenhagen","id":4321826,"avatar_url":"https://avatars.githubusercontent.com/u/4321826?v=3","gravatar_id":"","url":"https://api.github.com/users/jona-sassenhagen","html_url":"https://github.com/jona-sassenhagen","followers_url":"https://api.github.com/users/jona-sassenhagen/followers","following_url":"https://api.github.com/users/jona-sassenhagen/following{/other_user}","gists_url":"https://api.github.com/users/jona-sassenhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/jona-sassenhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jona-sassenhagen/subscriptions","organizations_url":"https://api.github.com/users/jona-sassenhagen/orgs","repos_url":"https://api.github.com/users/jona-sassenhagen/repos","events_url":"https://api.github.com/users/jona-sassenhagen/events{/privacy}","received_events_url":"https://api.github.com/users/jona-sassenhagen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jona-sassenhagen/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/jona-sassenhagen/mne-python","forks_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/forks","keys_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/teams","hooks_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/hooks","issue_events_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/events","assignees_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/tags","blobs_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/languages","stargazers_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/stargazers","contributors_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/contributors","subscribers_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/subscribers","subscription_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/subscription","commits_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/merges","archive_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/downloads","issues_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/jona-sassenhagen/mne-python/releases{/id}","created_at":"2014-11-08T16:37:16Z","updated_at":"2015-03-21T16:54:38Z","pushed_at":"2015-04-11T13:56:31Z","git_url":"git://github.com/jona-sassenhagen/mne-python.git","ssh_url":"git@github.com:jona-sassenhagen/mne-python.git","clone_url":"https://github.com/jona-sassenhagen/mne-python.git","svn_url":"https://github.com/jona-sassenhagen/mne-python","homepage":"http://martinos.org/mne/","size":75952,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/1"},"html":{"href":"https://github.com/jona-sassenhagen/mne-python/pull/1"},"issue":{"href":"https://api.github.com/repos/jona-sassenhagen/mne-python/issues/1"},"comments":{"href":"https://api.github.com/repos/jona-sassenhagen/mne-python/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jona-sassenhagen/mne-python/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jona-sassenhagen/mne-python/statuses/f3529270cc12fa740a94bd09edc9122d3761a670"}}}}