{"action":"created","issue":{"url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/623","labels_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/623/labels{/name}","comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/623/comments","events_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/623/events","html_url":"https://github.com/BabylonJS/Babylon.js/pull/623","id":95643572,"number":623,"title":"Added subdivisions handling for CreateCylinder","user":{"login":"jahow","id":10629150,"avatar_url":"https://avatars.githubusercontent.com/u/10629150?v=3","gravatar_id":"","url":"https://api.github.com/users/jahow","html_url":"https://github.com/jahow","followers_url":"https://api.github.com/users/jahow/followers","following_url":"https://api.github.com/users/jahow/following{/other_user}","gists_url":"https://api.github.com/users/jahow/gists{/gist_id}","starred_url":"https://api.github.com/users/jahow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahow/subscriptions","organizations_url":"https://api.github.com/users/jahow/orgs","repos_url":"https://api.github.com/users/jahow/repos","events_url":"https://api.github.com/users/jahow/events{/privacy}","received_events_url":"https://api.github.com/users/jahow/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-17T12:00:51Z","updated_at":"2015-07-17T16:54:21Z","closed_at":"2015-07-17T16:54:21Z","pull_request":{"url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/623","html_url":"https://github.com/BabylonJS/Babylon.js/pull/623","diff_url":"https://github.com/BabylonJS/Babylon.js/pull/623.diff","patch_url":"https://github.com/BabylonJS/Babylon.js/pull/623.patch"},"body":"Better now: http://www.babylonjs-playground.com/#1S6POH#2"},"comment":{"url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/comments/122341641","html_url":"https://github.com/BabylonJS/Babylon.js/pull/623#issuecomment-122341641","issue_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/623","id":122341641,"user":{"login":"jahow","id":10629150,"avatar_url":"https://avatars.githubusercontent.com/u/10629150?v=3","gravatar_id":"","url":"https://api.github.com/users/jahow","html_url":"https://github.com/jahow","followers_url":"https://api.github.com/users/jahow/followers","following_url":"https://api.github.com/users/jahow/following{/other_user}","gists_url":"https://api.github.com/users/jahow/gists{/gist_id}","starred_url":"https://api.github.com/users/jahow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahow/subscriptions","organizations_url":"https://api.github.com/users/jahow/orgs","repos_url":"https://api.github.com/users/jahow/repos","events_url":"https://api.github.com/users/jahow/events{/privacy}","received_events_url":"https://api.github.com/users/jahow/received_events","type":"User","site_admin":false},"created_at":"2015-07-17T16:54:21Z","updated_at":"2015-07-17T16:54:21Z","body":"That was my intention, but the issue is that CreateTube only exists on the Mesh class.\r\n\r\nThe only parametric shape VertexData does is CreateRibbon. whereas the Mesh class has:\r\n- CreateRibbon\r\n- CreateTube\r\n- CreateCylinder\r\n(+ extrusion methods)\r\n\r\nI think it's consistent to transfer the actual logic of CreateTube and CreateCylinder to the VertexData class, I'll add it to the PR (closed in the meantime)"}}