{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/46011485","id":46011485,"diff_hunk":"@@ -606,9 +606,17 @@ abstract class HadoopFsRelation private[sql](\n         // we need to cast into the data type that user specified.\n         def castPartitionValuesToUserSchema(row: InternalRow) = {\n           InternalRow((0 until row.numFields).map { i =>\n-            Cast(\n-              Literal.create(row.getString(i), StringType),\n-              userProvidedSchema.fields(i).dataType).eval()\n+            row.isNullAt(i) match {","path":"sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala","position":7,"original_position":7,"commit_id":"af508deafa1f1ba3ff46fc98a0e2fbbc81c6a4c8","original_commit_id":"af508deafa1f1ba3ff46fc98a0e2fbbc81c6a4c8","user":{"login":"dilipbiswal","id":14225158,"avatar_url":"https://avatars.githubusercontent.com/u/14225158?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"body":"@davies Thanks for reviewing the change. In cases when we know in advance that schema does not allow nulls , sometimes we can skip this null check. By moving it to internalRow , would we loose the opportunity to optimize ? Pl. let me know.","created_at":"2015-11-27T00:39:42Z","updated_at":"2015-11-27T00:39:42Z","html_url":"https://github.com/apache/spark/pull/10001#discussion_r46011485","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/10001","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/46011485"},"html":{"href":"https://github.com/apache/spark/pull/10001#discussion_r46011485"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/10001"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/10001","id":51897486,"html_url":"https://github.com/apache/spark/pull/10001","diff_url":"https://github.com/apache/spark/pull/10001.diff","patch_url":"https://github.com/apache/spark/pull/10001.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/10001","number":10001,"state":"open","locked":false,"title":"[SPARK-11997][SQL] NPE when save a DataFrame as parquet and partitioned by long column","user":{"login":"dilipbiswal","id":14225158,"avatar_url":"https://avatars.githubusercontent.com/u/14225158?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"body":"Check for partition column null-ability while building the partition spec. ","created_at":"2015-11-26T10:49:04Z","updated_at":"2015-11-27T00:39:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"053c3a6e0155864579854a3ace2a49ee6f6aad1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/10001/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/10001/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/10001/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/af508deafa1f1ba3ff46fc98a0e2fbbc81c6a4c8","head":{"label":"dilipbiswal:spark-11997","ref":"spark-11997","sha":"af508deafa1f1ba3ff46fc98a0e2fbbc81c6a4c8","user":{"login":"dilipbiswal","id":14225158,"avatar_url":"https://avatars.githubusercontent.com/u/14225158?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"repo":{"id":42921897,"name":"spark","full_name":"dilipbiswal/spark","owner":{"login":"dilipbiswal","id":14225158,"avatar_url":"https://avatars.githubusercontent.com/u/14225158?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipbiswal","html_url":"https://github.com/dilipbiswal","followers_url":"https://api.github.com/users/dilipbiswal/followers","following_url":"https://api.github.com/users/dilipbiswal/following{/other_user}","gists_url":"https://api.github.com/users/dilipbiswal/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipbiswal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipbiswal/subscriptions","organizations_url":"https://api.github.com/users/dilipbiswal/orgs","repos_url":"https://api.github.com/users/dilipbiswal/repos","events_url":"https://api.github.com/users/dilipbiswal/events{/privacy}","received_events_url":"https://api.github.com/users/dilipbiswal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dilipbiswal/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/dilipbiswal/spark","forks_url":"https://api.github.com/repos/dilipbiswal/spark/forks","keys_url":"https://api.github.com/repos/dilipbiswal/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dilipbiswal/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dilipbiswal/spark/teams","hooks_url":"https://api.github.com/repos/dilipbiswal/spark/hooks","issue_events_url":"https://api.github.com/repos/dilipbiswal/spark/issues/events{/number}","events_url":"https://api.github.com/repos/dilipbiswal/spark/events","assignees_url":"https://api.github.com/repos/dilipbiswal/spark/assignees{/user}","branches_url":"https://api.github.com/repos/dilipbiswal/spark/branches{/branch}","tags_url":"https://api.github.com/repos/dilipbiswal/spark/tags","blobs_url":"https://api.github.com/repos/dilipbiswal/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dilipbiswal/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dilipbiswal/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/dilipbiswal/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dilipbiswal/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/dilipbiswal/spark/languages","stargazers_url":"https://api.github.com/repos/dilipbiswal/spark/stargazers","contributors_url":"https://api.github.com/repos/dilipbiswal/spark/contributors","subscribers_url":"https://api.github.com/repos/dilipbiswal/spark/subscribers","subscription_url":"https://api.github.com/repos/dilipbiswal/spark/subscription","commits_url":"https://api.github.com/repos/dilipbiswal/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/dilipbiswal/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/dilipbiswal/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/dilipbiswal/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/dilipbiswal/spark/contents/{+path}","compare_url":"https://api.github.com/repos/dilipbiswal/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dilipbiswal/spark/merges","archive_url":"https://api.github.com/repos/dilipbiswal/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dilipbiswal/spark/downloads","issues_url":"https://api.github.com/repos/dilipbiswal/spark/issues{/number}","pulls_url":"https://api.github.com/repos/dilipbiswal/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/dilipbiswal/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/dilipbiswal/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dilipbiswal/spark/labels{/name}","releases_url":"https://api.github.com/repos/dilipbiswal/spark/releases{/id}","created_at":"2015-09-22T08:39:46Z","updated_at":"2015-09-22T08:40:18Z","pushed_at":"2015-11-26T08:26:32Z","git_url":"git://github.com/dilipbiswal/spark.git","ssh_url":"git@github.com:dilipbiswal/spark.git","clone_url":"https://github.com/dilipbiswal/spark.git","svn_url":"https://github.com/dilipbiswal/spark","homepage":null,"size":136966,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"001f0528a851ac314b390e65eb0583f89e69a949","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-11-26T22:17:35Z","pushed_at":"2015-11-27T00:34:19Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":387226,"stargazers_count":6366,"watchers_count":6366,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5854,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":382,"forks":5854,"open_issues":382,"watchers":6366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/10001"},"html":{"href":"https://github.com/apache/spark/pull/10001"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/10001"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/10001/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/10001/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/10001/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/af508deafa1f1ba3ff46fc98a0e2fbbc81c6a4c8"}}}}