{"action":"created","issue":{"url":"https://api.github.com/repos/playframework/playframework/issues/4082","labels_url":"https://api.github.com/repos/playframework/playframework/issues/4082/labels{/name}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/4082/comments","events_url":"https://api.github.com/repos/playframework/playframework/issues/4082/events","html_url":"https://github.com/playframework/playframework/pull/4082","id":61433031,"number":4082,"title":"HikariCP as the default JDBC connection pool","user":{"login":"megazord","id":3894326,"avatar_url":"https://avatars.githubusercontent.com/u/3894326?v=3","gravatar_id":"","url":"https://api.github.com/users/megazord","html_url":"https://github.com/megazord","followers_url":"https://api.github.com/users/megazord/followers","following_url":"https://api.github.com/users/megazord/following{/other_user}","gists_url":"https://api.github.com/users/megazord/gists{/gist_id}","starred_url":"https://api.github.com/users/megazord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megazord/subscriptions","organizations_url":"https://api.github.com/users/megazord/orgs","repos_url":"https://api.github.com/users/megazord/repos","events_url":"https://api.github.com/users/megazord/events{/privacy}","received_events_url":"https://api.github.com/users/megazord/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-03-14T05:33:30Z","updated_at":"2015-03-17T06:12:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/4082","html_url":"https://github.com/playframework/playframework/pull/4082","diff_url":"https://github.com/playframework/playframework/pull/4082.diff","patch_url":"https://github.com/playframework/playframework/pull/4082.patch"},"body":"This is related to issue #2445. I know this is a huge commit, but as far as I know, you guys prefer single commits since they are easier to revert if necessary. Please, feel free to suggest any improvement and I will do my best to implement it as soon as possible.\r\n\r\n## Changes\r\n\r\n1. Supports HikariCP configuration, but keep support for\r\n   url and driver properties, to minimize change and also\r\n   helps with compatibility with third party modules\r\n2. Documents this change in the highlights of the new version\r\n   and in the migration guide to version 2.4.0\r\n3. Updates documentation to reference HikariCP module and\r\n   configuration\r\n4. Keep BoneCP so users can turn off HikariCP module and\r\n   replace it with the old one\r\n5. It does not supports SQL logging, which can added by\r\n   jdbcdslog-exp\r\n6. Updates h2 and acolyte dependencies"},"comment":{"url":"https://api.github.com/repos/playframework/playframework/issues/comments/82130825","html_url":"https://github.com/playframework/playframework/pull/4082#issuecomment-82130825","issue_url":"https://api.github.com/repos/playframework/playframework/issues/4082","id":82130825,"user":{"login":"jroper","id":105833,"avatar_url":"https://avatars.githubusercontent.com/u/105833?v=3","gravatar_id":"","url":"https://api.github.com/users/jroper","html_url":"https://github.com/jroper","followers_url":"https://api.github.com/users/jroper/followers","following_url":"https://api.github.com/users/jroper/following{/other_user}","gists_url":"https://api.github.com/users/jroper/gists{/gist_id}","starred_url":"https://api.github.com/users/jroper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroper/subscriptions","organizations_url":"https://api.github.com/users/jroper/orgs","repos_url":"https://api.github.com/users/jroper/repos","events_url":"https://api.github.com/users/jroper/events{/privacy}","received_events_url":"https://api.github.com/users/jroper/received_events","type":"User","site_admin":false},"created_at":"2015-03-17T06:12:33Z","updated_at":"2015-03-17T06:12:33Z","body":"> How this pool selection will play with DI? I can only think about an additional abstraction that will use HikariCPModule or BoneCPModule but that will abstract them (and other implementations configured using fqcn) to the DBApi and Database classes.\r\n\r\nMay require some refactoring here, but I think providers for both pools will exist."}}