{"action":"created","issue":{"url":"https://api.github.com/repos/redis/redis-rb/issues/502","labels_url":"https://api.github.com/repos/redis/redis-rb/issues/502/labels{/name}","comments_url":"https://api.github.com/repos/redis/redis-rb/issues/502/comments","events_url":"https://api.github.com/repos/redis/redis-rb/issues/502/events","html_url":"https://github.com/redis/redis-rb/pull/502","id":55669188,"number":502,"title":"Fix inconsistent connections when using Timeout under MRI 2.1+.","user":{"login":"djanowski","id":2268,"avatar_url":"https://avatars.githubusercontent.com/u/2268?v=3","gravatar_id":"","url":"https://api.github.com/users/djanowski","html_url":"https://github.com/djanowski","followers_url":"https://api.github.com/users/djanowski/followers","following_url":"https://api.github.com/users/djanowski/following{/other_user}","gists_url":"https://api.github.com/users/djanowski/gists{/gist_id}","starred_url":"https://api.github.com/users/djanowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djanowski/subscriptions","organizations_url":"https://api.github.com/users/djanowski/orgs","repos_url":"https://api.github.com/users/djanowski/repos","events_url":"https://api.github.com/users/djanowski/events{/privacy}","received_events_url":"https://api.github.com/users/djanowski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-01-27T20:20:36Z","updated_at":"2015-01-28T07:23:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/redis/redis-rb/pulls/502","html_url":"https://github.com/redis/redis-rb/pull/502","diff_url":"https://github.com/redis/redis-rb/pull/502.diff","patch_url":"https://github.com/redis/redis-rb/pull/502.patch"},"body":"This should address #501.\r\n\r\nI like this solution because the performance and complexity penalty of keeping counters is limited to the pure Ruby driver. Edit: From the comments below, I'll test what happens with Hiredis (I thought it wasn't an issue).\r\n\r\nThe 'test cases' were [this](https://gist.github.com/tarcieri/303c5dcf803b0e5d021d) and [this](https://gist.github.com/stevehodgkiss/10204388). I'll try to make those proper tests cases in our code base."},"comment":{"url":"https://api.github.com/repos/redis/redis-rb/issues/comments/71791744","html_url":"https://github.com/redis/redis-rb/pull/502#issuecomment-71791744","issue_url":"https://api.github.com/repos/redis/redis-rb/issues/502","id":71791744,"user":{"login":"yaauie","id":210924,"avatar_url":"https://avatars.githubusercontent.com/u/210924?v=3","gravatar_id":"","url":"https://api.github.com/users/yaauie","html_url":"https://github.com/yaauie","followers_url":"https://api.github.com/users/yaauie/followers","following_url":"https://api.github.com/users/yaauie/following{/other_user}","gists_url":"https://api.github.com/users/yaauie/gists{/gist_id}","starred_url":"https://api.github.com/users/yaauie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaauie/subscriptions","organizations_url":"https://api.github.com/users/yaauie/orgs","repos_url":"https://api.github.com/users/yaauie/repos","events_url":"https://api.github.com/users/yaauie/events{/privacy}","received_events_url":"https://api.github.com/users/yaauie/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T07:23:32Z","updated_at":"2015-01-28T07:23:32Z","body":"I think this approach makes a lot of sense, and that the additional overhead is both small & justified. :+1:"}}