{"action":"opened","number":49,"pull_request":{"url":"https://api.github.com/repos/ndoit/fenrir/pulls/49","id":50387347,"html_url":"https://github.com/ndoit/fenrir/pull/49","diff_url":"https://github.com/ndoit/fenrir/pull/49.diff","patch_url":"https://github.com/ndoit/fenrir/pull/49.patch","issue_url":"https://api.github.com/repos/ndoit/fenrir/issues/49","number":49,"state":"open","locked":false,"title":"Photo security","user":{"login":"RyanSnodgrass","id":7104855,"avatar_url":"https://avatars.githubusercontent.com/u/7104855?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanSnodgrass","html_url":"https://github.com/RyanSnodgrass","followers_url":"https://api.github.com/users/RyanSnodgrass/followers","following_url":"https://api.github.com/users/RyanSnodgrass/following{/other_user}","gists_url":"https://api.github.com/users/RyanSnodgrass/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanSnodgrass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanSnodgrass/subscriptions","organizations_url":"https://api.github.com/users/RyanSnodgrass/orgs","repos_url":"https://api.github.com/users/RyanSnodgrass/repos","events_url":"https://api.github.com/users/RyanSnodgrass/events{/privacy}","received_events_url":"https://api.github.com/users/RyanSnodgrass/received_events","type":"User","site_admin":false},"body":"New Features\r\n===\r\n### Report images being completely handled by the Rails server\r\nThere was a security issue where because the client was grabbing the url of the images served by S3, the access was public and open to the whole internet. This can cause an issue when a user unwittingly uploads a sensitive screen capture of a report. The solution is ongoing to further restrict who can access the images. Now the only thing setting and getting images is the rails server.\r\n\r\n### Misc\r\n- refactored style based on style guides.\r\n\r\nBug Fixes\r\n===\r\n- In the term download to excel feature, if a term doesn't have any stakeholders, it caused an `undefined method for Nil Class` error when trying to grab the name. This was resolved by adding a `#try` method.","created_at":"2015-11-11T14:15:16Z","updated_at":"2015-11-11T14:15:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ndoit/fenrir/pulls/49/commits","review_comments_url":"https://api.github.com/repos/ndoit/fenrir/pulls/49/comments","review_comment_url":"https://api.github.com/repos/ndoit/fenrir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ndoit/fenrir/issues/49/comments","statuses_url":"https://api.github.com/repos/ndoit/fenrir/statuses/3d555616e173f94abffc37394a97ffacd7c3ab58","head":{"label":"ndoit:photo-security","ref":"photo-security","sha":"3d555616e173f94abffc37394a97ffacd7c3ab58","user":{"login":"ndoit","id":6223716,"avatar_url":"https://avatars.githubusercontent.com/u/6223716?v=3","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"repo":{"id":39837938,"name":"fenrir","full_name":"ndoit/fenrir","owner":{"login":"ndoit","id":6223716,"avatar_url":"https://avatars.githubusercontent.com/u/6223716?v=3","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndoit/fenrir","description":"BI Portal","fork":false,"url":"https://api.github.com/repos/ndoit/fenrir","forks_url":"https://api.github.com/repos/ndoit/fenrir/forks","keys_url":"https://api.github.com/repos/ndoit/fenrir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndoit/fenrir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndoit/fenrir/teams","hooks_url":"https://api.github.com/repos/ndoit/fenrir/hooks","issue_events_url":"https://api.github.com/repos/ndoit/fenrir/issues/events{/number}","events_url":"https://api.github.com/repos/ndoit/fenrir/events","assignees_url":"https://api.github.com/repos/ndoit/fenrir/assignees{/user}","branches_url":"https://api.github.com/repos/ndoit/fenrir/branches{/branch}","tags_url":"https://api.github.com/repos/ndoit/fenrir/tags","blobs_url":"https://api.github.com/repos/ndoit/fenrir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndoit/fenrir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndoit/fenrir/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndoit/fenrir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndoit/fenrir/statuses/{sha}","languages_url":"https://api.github.com/repos/ndoit/fenrir/languages","stargazers_url":"https://api.github.com/repos/ndoit/fenrir/stargazers","contributors_url":"https://api.github.com/repos/ndoit/fenrir/contributors","subscribers_url":"https://api.github.com/repos/ndoit/fenrir/subscribers","subscription_url":"https://api.github.com/repos/ndoit/fenrir/subscription","commits_url":"https://api.github.com/repos/ndoit/fenrir/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndoit/fenrir/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndoit/fenrir/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndoit/fenrir/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndoit/fenrir/contents/{+path}","compare_url":"https://api.github.com/repos/ndoit/fenrir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndoit/fenrir/merges","archive_url":"https://api.github.com/repos/ndoit/fenrir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndoit/fenrir/downloads","issues_url":"https://api.github.com/repos/ndoit/fenrir/issues{/number}","pulls_url":"https://api.github.com/repos/ndoit/fenrir/pulls{/number}","milestones_url":"https://api.github.com/repos/ndoit/fenrir/milestones{/number}","notifications_url":"https://api.github.com/repos/ndoit/fenrir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndoit/fenrir/labels{/name}","releases_url":"https://api.github.com/repos/ndoit/fenrir/releases{/id}","created_at":"2015-07-28T14:14:01Z","updated_at":"2015-07-28T14:17:00Z","pushed_at":"2015-11-10T19:19:43Z","git_url":"git://github.com/ndoit/fenrir.git","ssh_url":"git@github.com:ndoit/fenrir.git","clone_url":"https://github.com/ndoit/fenrir.git","svn_url":"https://github.com/ndoit/fenrir","homepage":"https://data.nd.edu","size":10300,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ndoit:dev","ref":"dev","sha":"6427146ecafbcef9a99b2392b03e630b85c90665","user":{"login":"ndoit","id":6223716,"avatar_url":"https://avatars.githubusercontent.com/u/6223716?v=3","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"repo":{"id":39837938,"name":"fenrir","full_name":"ndoit/fenrir","owner":{"login":"ndoit","id":6223716,"avatar_url":"https://avatars.githubusercontent.com/u/6223716?v=3","gravatar_id":"","url":"https://api.github.com/users/ndoit","html_url":"https://github.com/ndoit","followers_url":"https://api.github.com/users/ndoit/followers","following_url":"https://api.github.com/users/ndoit/following{/other_user}","gists_url":"https://api.github.com/users/ndoit/gists{/gist_id}","starred_url":"https://api.github.com/users/ndoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndoit/subscriptions","organizations_url":"https://api.github.com/users/ndoit/orgs","repos_url":"https://api.github.com/users/ndoit/repos","events_url":"https://api.github.com/users/ndoit/events{/privacy}","received_events_url":"https://api.github.com/users/ndoit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndoit/fenrir","description":"BI Portal","fork":false,"url":"https://api.github.com/repos/ndoit/fenrir","forks_url":"https://api.github.com/repos/ndoit/fenrir/forks","keys_url":"https://api.github.com/repos/ndoit/fenrir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndoit/fenrir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndoit/fenrir/teams","hooks_url":"https://api.github.com/repos/ndoit/fenrir/hooks","issue_events_url":"https://api.github.com/repos/ndoit/fenrir/issues/events{/number}","events_url":"https://api.github.com/repos/ndoit/fenrir/events","assignees_url":"https://api.github.com/repos/ndoit/fenrir/assignees{/user}","branches_url":"https://api.github.com/repos/ndoit/fenrir/branches{/branch}","tags_url":"https://api.github.com/repos/ndoit/fenrir/tags","blobs_url":"https://api.github.com/repos/ndoit/fenrir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndoit/fenrir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndoit/fenrir/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndoit/fenrir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndoit/fenrir/statuses/{sha}","languages_url":"https://api.github.com/repos/ndoit/fenrir/languages","stargazers_url":"https://api.github.com/repos/ndoit/fenrir/stargazers","contributors_url":"https://api.github.com/repos/ndoit/fenrir/contributors","subscribers_url":"https://api.github.com/repos/ndoit/fenrir/subscribers","subscription_url":"https://api.github.com/repos/ndoit/fenrir/subscription","commits_url":"https://api.github.com/repos/ndoit/fenrir/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndoit/fenrir/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndoit/fenrir/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndoit/fenrir/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndoit/fenrir/contents/{+path}","compare_url":"https://api.github.com/repos/ndoit/fenrir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndoit/fenrir/merges","archive_url":"https://api.github.com/repos/ndoit/fenrir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndoit/fenrir/downloads","issues_url":"https://api.github.com/repos/ndoit/fenrir/issues{/number}","pulls_url":"https://api.github.com/repos/ndoit/fenrir/pulls{/number}","milestones_url":"https://api.github.com/repos/ndoit/fenrir/milestones{/number}","notifications_url":"https://api.github.com/repos/ndoit/fenrir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndoit/fenrir/labels{/name}","releases_url":"https://api.github.com/repos/ndoit/fenrir/releases{/id}","created_at":"2015-07-28T14:14:01Z","updated_at":"2015-07-28T14:17:00Z","pushed_at":"2015-11-10T19:19:43Z","git_url":"git://github.com/ndoit/fenrir.git","ssh_url":"git@github.com:ndoit/fenrir.git","clone_url":"https://github.com/ndoit/fenrir.git","svn_url":"https://github.com/ndoit/fenrir","homepage":"https://data.nd.edu","size":10300,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/49"},"html":{"href":"https://github.com/ndoit/fenrir/pull/49"},"issue":{"href":"https://api.github.com/repos/ndoit/fenrir/issues/49"},"comments":{"href":"https://api.github.com/repos/ndoit/fenrir/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ndoit/fenrir/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/ndoit/fenrir/statuses/3d555616e173f94abffc37394a97ffacd7c3ab58"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":108,"deletions":83,"changed_files":10}}