{"action":"created","comment":{"url":"https://api.github.com/repos/gamechanger/dusty/pulls/comments/35816085","id":35816085,"diff_hunk":"@@ -1,7 +1,7 @@\n-from ...constants import NGINX_MAX_FILE_SIZE\n+from ...constants import NGINX_MAX_FILE_SIZE, VM_IP_FROM_DOCKER\n \n def _nginx_proxy_string(port_spec):\n-    return \"proxy_pass http://{}:{};\".format(port_spec['boot2docker_ip'], port_spec['proxied_port'])\n+    return \"proxy_pass http://{}:{};\".format(VM_IP_FROM_DOCKER, port_spec['proxied_port'])","path":"dusty/compiler/nginx/__init__.py","position":6,"original_position":6,"commit_id":"6ceb205aa1b17d81a4016c413d01dd12969a3f16","original_commit_id":"6ceb205aa1b17d81a4016c413d01dd12969a3f16","user":{"login":"paetling","id":3281726,"avatar_url":"https://avatars.githubusercontent.com/u/3281726?v=3","gravatar_id":"","url":"https://api.github.com/users/paetling","html_url":"https://github.com/paetling","followers_url":"https://api.github.com/users/paetling/followers","following_url":"https://api.github.com/users/paetling/following{/other_user}","gists_url":"https://api.github.com/users/paetling/gists{/gist_id}","starred_url":"https://api.github.com/users/paetling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paetling/subscriptions","organizations_url":"https://api.github.com/users/paetling/orgs","repos_url":"https://api.github.com/users/paetling/repos","events_url":"https://api.github.com/users/paetling/events{/privacy}","received_events_url":"https://api.github.com/users/paetling/received_events","type":"User","site_admin":false},"body":"why is this better?","created_at":"2015-07-29T21:46:28Z","updated_at":"2015-07-29T21:46:28Z","html_url":"https://github.com/gamechanger/dusty/pull/423#discussion_r35816085","pull_request_url":"https://api.github.com/repos/gamechanger/dusty/pulls/423","_links":{"self":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/comments/35816085"},"html":{"href":"https://github.com/gamechanger/dusty/pull/423#discussion_r35816085"},"pull_request":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/423"}}},"pull_request":{"url":"https://api.github.com/repos/gamechanger/dusty/pulls/423","id":40793356,"html_url":"https://github.com/gamechanger/dusty/pull/423","diff_url":"https://github.com/gamechanger/dusty/pull/423.diff","patch_url":"https://github.com/gamechanger/dusty/pull/423.patch","issue_url":"https://api.github.com/repos/gamechanger/dusty/issues/423","number":423,"state":"closed","locked":false,"title":"Remove nginx dependency!","user":{"login":"thieman","id":1414305,"avatar_url":"https://avatars.githubusercontent.com/u/1414305?v=3","gravatar_id":"","url":"https://api.github.com/users/thieman","html_url":"https://github.com/thieman","followers_url":"https://api.github.com/users/thieman/followers","following_url":"https://api.github.com/users/thieman/following{/other_user}","gists_url":"https://api.github.com/users/thieman/gists{/gist_id}","starred_url":"https://api.github.com/users/thieman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thieman/subscriptions","organizations_url":"https://api.github.com/users/thieman/orgs","repos_url":"https://api.github.com/users/thieman/repos","events_url":"https://api.github.com/users/thieman/events{/privacy}","received_events_url":"https://api.github.com/users/thieman/received_events","type":"User","site_admin":false},"body":"@jsingle https://www.youtube.com/watch?v=GGXzlRoNtHU\r\n\r\nI've got it working, gonna stress test it a bit and make sure all the docs and such get updated properly.\r\n\r\nCloses #393.","created_at":"2015-07-24T16:43:11Z","updated_at":"2015-07-29T21:46:28Z","closed_at":"2015-07-24T17:30:21Z","merged_at":"2015-07-24T17:30:21Z","merge_commit_sha":"e83ca102c9b11a9550cd100d14e466fd997e08ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gamechanger/dusty/pulls/423/commits","review_comments_url":"https://api.github.com/repos/gamechanger/dusty/pulls/423/comments","review_comment_url":"https://api.github.com/repos/gamechanger/dusty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gamechanger/dusty/issues/423/comments","statuses_url":"https://api.github.com/repos/gamechanger/dusty/statuses/6ceb205aa1b17d81a4016c413d01dd12969a3f16","head":{"label":"gamechanger:tnt-nginx-into-container","ref":"tnt-nginx-into-container","sha":"6ceb205aa1b17d81a4016c413d01dd12969a3f16","user":{"login":"gamechanger","id":43876,"avatar_url":"https://avatars.githubusercontent.com/u/43876?v=3","gravatar_id":"","url":"https://api.github.com/users/gamechanger","html_url":"https://github.com/gamechanger","followers_url":"https://api.github.com/users/gamechanger/followers","following_url":"https://api.github.com/users/gamechanger/following{/other_user}","gists_url":"https://api.github.com/users/gamechanger/gists{/gist_id}","starred_url":"https://api.github.com/users/gamechanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamechanger/subscriptions","organizations_url":"https://api.github.com/users/gamechanger/orgs","repos_url":"https://api.github.com/users/gamechanger/repos","events_url":"https://api.github.com/users/gamechanger/events{/privacy}","received_events_url":"https://api.github.com/users/gamechanger/received_events","type":"Organization","site_admin":false},"repo":{"id":35429030,"name":"dusty","full_name":"gamechanger/dusty","owner":{"login":"gamechanger","id":43876,"avatar_url":"https://avatars.githubusercontent.com/u/43876?v=3","gravatar_id":"","url":"https://api.github.com/users/gamechanger","html_url":"https://github.com/gamechanger","followers_url":"https://api.github.com/users/gamechanger/followers","following_url":"https://api.github.com/users/gamechanger/following{/other_user}","gists_url":"https://api.github.com/users/gamechanger/gists{/gist_id}","starred_url":"https://api.github.com/users/gamechanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamechanger/subscriptions","organizations_url":"https://api.github.com/users/gamechanger/orgs","repos_url":"https://api.github.com/users/gamechanger/repos","events_url":"https://api.github.com/users/gamechanger/events{/privacy}","received_events_url":"https://api.github.com/users/gamechanger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gamechanger/dusty","description":"Docker-powered development environments","fork":false,"url":"https://api.github.com/repos/gamechanger/dusty","forks_url":"https://api.github.com/repos/gamechanger/dusty/forks","keys_url":"https://api.github.com/repos/gamechanger/dusty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gamechanger/dusty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gamechanger/dusty/teams","hooks_url":"https://api.github.com/repos/gamechanger/dusty/hooks","issue_events_url":"https://api.github.com/repos/gamechanger/dusty/issues/events{/number}","events_url":"https://api.github.com/repos/gamechanger/dusty/events","assignees_url":"https://api.github.com/repos/gamechanger/dusty/assignees{/user}","branches_url":"https://api.github.com/repos/gamechanger/dusty/branches{/branch}","tags_url":"https://api.github.com/repos/gamechanger/dusty/tags","blobs_url":"https://api.github.com/repos/gamechanger/dusty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gamechanger/dusty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gamechanger/dusty/git/refs{/sha}","trees_url":"https://api.github.com/repos/gamechanger/dusty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gamechanger/dusty/statuses/{sha}","languages_url":"https://api.github.com/repos/gamechanger/dusty/languages","stargazers_url":"https://api.github.com/repos/gamechanger/dusty/stargazers","contributors_url":"https://api.github.com/repos/gamechanger/dusty/contributors","subscribers_url":"https://api.github.com/repos/gamechanger/dusty/subscribers","subscription_url":"https://api.github.com/repos/gamechanger/dusty/subscription","commits_url":"https://api.github.com/repos/gamechanger/dusty/commits{/sha}","git_commits_url":"https://api.github.com/repos/gamechanger/dusty/git/commits{/sha}","comments_url":"https://api.github.com/repos/gamechanger/dusty/comments{/number}","issue_comment_url":"https://api.github.com/repos/gamechanger/dusty/issues/comments{/number}","contents_url":"https://api.github.com/repos/gamechanger/dusty/contents/{+path}","compare_url":"https://api.github.com/repos/gamechanger/dusty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gamechanger/dusty/merges","archive_url":"https://api.github.com/repos/gamechanger/dusty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gamechanger/dusty/downloads","issues_url":"https://api.github.com/repos/gamechanger/dusty/issues{/number}","pulls_url":"https://api.github.com/repos/gamechanger/dusty/pulls{/number}","milestones_url":"https://api.github.com/repos/gamechanger/dusty/milestones{/number}","notifications_url":"https://api.github.com/repos/gamechanger/dusty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gamechanger/dusty/labels{/name}","releases_url":"https://api.github.com/repos/gamechanger/dusty/releases{/id}","created_at":"2015-05-11T14:27:56Z","updated_at":"2015-07-29T20:54:46Z","pushed_at":"2015-07-29T19:13:04Z","git_url":"git://github.com/gamechanger/dusty.git","ssh_url":"git@github.com:gamechanger/dusty.git","clone_url":"https://github.com/gamechanger/dusty.git","svn_url":"https://github.com/gamechanger/dusty","homepage":"http://dusty.gc.com","size":14398,"stargazers_count":174,"watchers_count":174,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":12,"forks":4,"open_issues":12,"watchers":174,"default_branch":"master"}},"base":{"label":"gamechanger:master","ref":"master","sha":"d690a77350fd33c67ac18dab889f2c3f738d5461","user":{"login":"gamechanger","id":43876,"avatar_url":"https://avatars.githubusercontent.com/u/43876?v=3","gravatar_id":"","url":"https://api.github.com/users/gamechanger","html_url":"https://github.com/gamechanger","followers_url":"https://api.github.com/users/gamechanger/followers","following_url":"https://api.github.com/users/gamechanger/following{/other_user}","gists_url":"https://api.github.com/users/gamechanger/gists{/gist_id}","starred_url":"https://api.github.com/users/gamechanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamechanger/subscriptions","organizations_url":"https://api.github.com/users/gamechanger/orgs","repos_url":"https://api.github.com/users/gamechanger/repos","events_url":"https://api.github.com/users/gamechanger/events{/privacy}","received_events_url":"https://api.github.com/users/gamechanger/received_events","type":"Organization","site_admin":false},"repo":{"id":35429030,"name":"dusty","full_name":"gamechanger/dusty","owner":{"login":"gamechanger","id":43876,"avatar_url":"https://avatars.githubusercontent.com/u/43876?v=3","gravatar_id":"","url":"https://api.github.com/users/gamechanger","html_url":"https://github.com/gamechanger","followers_url":"https://api.github.com/users/gamechanger/followers","following_url":"https://api.github.com/users/gamechanger/following{/other_user}","gists_url":"https://api.github.com/users/gamechanger/gists{/gist_id}","starred_url":"https://api.github.com/users/gamechanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamechanger/subscriptions","organizations_url":"https://api.github.com/users/gamechanger/orgs","repos_url":"https://api.github.com/users/gamechanger/repos","events_url":"https://api.github.com/users/gamechanger/events{/privacy}","received_events_url":"https://api.github.com/users/gamechanger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gamechanger/dusty","description":"Docker-powered development environments","fork":false,"url":"https://api.github.com/repos/gamechanger/dusty","forks_url":"https://api.github.com/repos/gamechanger/dusty/forks","keys_url":"https://api.github.com/repos/gamechanger/dusty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gamechanger/dusty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gamechanger/dusty/teams","hooks_url":"https://api.github.com/repos/gamechanger/dusty/hooks","issue_events_url":"https://api.github.com/repos/gamechanger/dusty/issues/events{/number}","events_url":"https://api.github.com/repos/gamechanger/dusty/events","assignees_url":"https://api.github.com/repos/gamechanger/dusty/assignees{/user}","branches_url":"https://api.github.com/repos/gamechanger/dusty/branches{/branch}","tags_url":"https://api.github.com/repos/gamechanger/dusty/tags","blobs_url":"https://api.github.com/repos/gamechanger/dusty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gamechanger/dusty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gamechanger/dusty/git/refs{/sha}","trees_url":"https://api.github.com/repos/gamechanger/dusty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gamechanger/dusty/statuses/{sha}","languages_url":"https://api.github.com/repos/gamechanger/dusty/languages","stargazers_url":"https://api.github.com/repos/gamechanger/dusty/stargazers","contributors_url":"https://api.github.com/repos/gamechanger/dusty/contributors","subscribers_url":"https://api.github.com/repos/gamechanger/dusty/subscribers","subscription_url":"https://api.github.com/repos/gamechanger/dusty/subscription","commits_url":"https://api.github.com/repos/gamechanger/dusty/commits{/sha}","git_commits_url":"https://api.github.com/repos/gamechanger/dusty/git/commits{/sha}","comments_url":"https://api.github.com/repos/gamechanger/dusty/comments{/number}","issue_comment_url":"https://api.github.com/repos/gamechanger/dusty/issues/comments{/number}","contents_url":"https://api.github.com/repos/gamechanger/dusty/contents/{+path}","compare_url":"https://api.github.com/repos/gamechanger/dusty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gamechanger/dusty/merges","archive_url":"https://api.github.com/repos/gamechanger/dusty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gamechanger/dusty/downloads","issues_url":"https://api.github.com/repos/gamechanger/dusty/issues{/number}","pulls_url":"https://api.github.com/repos/gamechanger/dusty/pulls{/number}","milestones_url":"https://api.github.com/repos/gamechanger/dusty/milestones{/number}","notifications_url":"https://api.github.com/repos/gamechanger/dusty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gamechanger/dusty/labels{/name}","releases_url":"https://api.github.com/repos/gamechanger/dusty/releases{/id}","created_at":"2015-05-11T14:27:56Z","updated_at":"2015-07-29T20:54:46Z","pushed_at":"2015-07-29T19:13:04Z","git_url":"git://github.com/gamechanger/dusty.git","ssh_url":"git@github.com:gamechanger/dusty.git","clone_url":"https://github.com/gamechanger/dusty.git","svn_url":"https://github.com/gamechanger/dusty","homepage":"http://dusty.gc.com","size":14398,"stargazers_count":174,"watchers_count":174,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":12,"forks":4,"open_issues":12,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/423"},"html":{"href":"https://github.com/gamechanger/dusty/pull/423"},"issue":{"href":"https://api.github.com/repos/gamechanger/dusty/issues/423"},"comments":{"href":"https://api.github.com/repos/gamechanger/dusty/issues/423/comments"},"review_comments":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/423/comments"},"review_comment":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/423/commits"},"statuses":{"href":"https://api.github.com/repos/gamechanger/dusty/statuses/6ceb205aa1b17d81a4016c413d01dd12969a3f16"}}}}