{"action":"created","comment":{"url":"https://api.github.com/repos/kaltura/server/pulls/comments/47079912","id":47079912,"diff_hunk":"@@ -141,7 +132,10 @@ function appendRecordingAction($entryId, $assetId, $mediaServerIndex, KalturaDat\n \t\t\t$dbEntry->save();\n \t\t}\n \n-\t\tkJobsManager::addConvertLiveSegmentJob(null, $dbAsset, $mediaServerIndex, $filename, $currentDuration);","path":"api_v3/lib/KalturaLiveEntryService.php","position":20,"original_position":20,"commit_id":"0fb9e73dbe86a69a41a74a5635d7c80a5261e30e","original_commit_id":"0fb9e73dbe86a69a41a74a5635d7c80a5261e30e","user":{"login":"tan-tan-kanarek","id":1793469,"avatar_url":"https://avatars.githubusercontent.com/u/1793469?v=3","gravatar_id":"","url":"https://api.github.com/users/tan-tan-kanarek","html_url":"https://github.com/tan-tan-kanarek","followers_url":"https://api.github.com/users/tan-tan-kanarek/followers","following_url":"https://api.github.com/users/tan-tan-kanarek/following{/other_user}","gists_url":"https://api.github.com/users/tan-tan-kanarek/gists{/gist_id}","starred_url":"https://api.github.com/users/tan-tan-kanarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tan-tan-kanarek/subscriptions","organizations_url":"https://api.github.com/users/tan-tan-kanarek/orgs","repos_url":"https://api.github.com/users/tan-tan-kanarek/repos","events_url":"https://api.github.com/users/tan-tan-kanarek/events{/privacy}","received_events_url":"https://api.github.com/users/tan-tan-kanarek/received_events","type":"User","site_admin":false},"body":"I would move the parsing into the convert-live-segment to be done asynchronously on the batch side.","created_at":"2015-12-09T11:36:11Z","updated_at":"2015-12-09T11:36:11Z","html_url":"https://github.com/kaltura/server/pull/3582#discussion_r47079912","pull_request_url":"https://api.github.com/repos/kaltura/server/pulls/3582","_links":{"self":{"href":"https://api.github.com/repos/kaltura/server/pulls/comments/47079912"},"html":{"href":"https://github.com/kaltura/server/pull/3582#discussion_r47079912"},"pull_request":{"href":"https://api.github.com/repos/kaltura/server/pulls/3582"}}},"pull_request":{"url":"https://api.github.com/repos/kaltura/server/pulls/3582","id":52832237,"html_url":"https://github.com/kaltura/server/pull/3582","diff_url":"https://github.com/kaltura/server/pull/3582.diff","patch_url":"https://github.com/kaltura/server/pull/3582.patch","issue_url":"https://api.github.com/repos/kaltura/server/issues/3582","number":3582,"state":"closed","locked":false,"title":"Webc 631 try2","user":{"login":"asafrob","id":7020203,"avatar_url":"https://avatars.githubusercontent.com/u/7020203?v=3","gravatar_id":"","url":"https://api.github.com/users/asafrob","html_url":"https://github.com/asafrob","followers_url":"https://api.github.com/users/asafrob/followers","following_url":"https://api.github.com/users/asafrob/following{/other_user}","gists_url":"https://api.github.com/users/asafrob/gists{/gist_id}","starred_url":"https://api.github.com/users/asafrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asafrob/subscriptions","organizations_url":"https://api.github.com/users/asafrob/orgs","repos_url":"https://api.github.com/users/asafrob/repos","events_url":"https://api.github.com/users/asafrob/events{/privacy}","received_events_url":"https://api.github.com/users/asafrob/received_events","type":"User","site_admin":false},"body":"Don't store kRecordedSegmentsInfo on the entry (remove it) and pass the segment AMF data to the converLiveSegment job which will pass it to the concat job.\r\n\r\ndon't keep AMFs if at least one min haven't passed / there was no change between the delta of the ts and the delta of the pts.\r\n\r\nin kCuePointManager register to job status changes, and process the cue points when the processing of the first segment ends, or when a concat ends.\r\n\r\nanother pull request to the SaaS-Config branch will be fallowed with the changed clients for the batch","created_at":"2015-12-07T11:17:28Z","updated_at":"2015-12-09T11:36:12Z","closed_at":"2015-12-08T13:13:01Z","merged_at":"2015-12-08T13:13:01Z","merge_commit_sha":"fd5efcb9b9eb9c2bdf66a9251cccf7ba9efe2009","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/server/pulls/3582/commits","review_comments_url":"https://api.github.com/repos/kaltura/server/pulls/3582/comments","review_comment_url":"https://api.github.com/repos/kaltura/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/server/issues/3582/comments","statuses_url":"https://api.github.com/repos/kaltura/server/statuses/0fb9e73dbe86a69a41a74a5635d7c80a5261e30e","head":{"label":"kaltura:WEBC-631-Try2","ref":"WEBC-631-Try2","sha":"0fb9e73dbe86a69a41a74a5635d7c80a5261e30e","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":11364783,"name":"server","full_name":"kaltura/server","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/server","description":"The official Kaltura server. ","fork":false,"url":"https://api.github.com/repos/kaltura/server","forks_url":"https://api.github.com/repos/kaltura/server/forks","keys_url":"https://api.github.com/repos/kaltura/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/server/teams","hooks_url":"https://api.github.com/repos/kaltura/server/hooks","issue_events_url":"https://api.github.com/repos/kaltura/server/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/server/events","assignees_url":"https://api.github.com/repos/kaltura/server/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/server/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/server/tags","blobs_url":"https://api.github.com/repos/kaltura/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/server/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/server/languages","stargazers_url":"https://api.github.com/repos/kaltura/server/stargazers","contributors_url":"https://api.github.com/repos/kaltura/server/contributors","subscribers_url":"https://api.github.com/repos/kaltura/server/subscribers","subscription_url":"https://api.github.com/repos/kaltura/server/subscription","commits_url":"https://api.github.com/repos/kaltura/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/server/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/server/merges","archive_url":"https://api.github.com/repos/kaltura/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/server/downloads","issues_url":"https://api.github.com/repos/kaltura/server/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/server/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/server/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/server/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/server/releases{/id}","created_at":"2013-07-12T08:59:26Z","updated_at":"2015-12-02T05:32:44Z","pushed_at":"2015-12-09T11:32:55Z","git_url":"git://github.com/kaltura/server.git","ssh_url":"git@github.com:kaltura/server.git","clone_url":"https://github.com/kaltura/server.git","svn_url":"https://github.com/kaltura/server","homepage":"http://www.kaltura.org","size":227035,"stargazers_count":70,"watchers_count":70,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":81,"forks":83,"open_issues":81,"watchers":70,"default_branch":"Kajam-11.4.0"}},"base":{"label":"kaltura:Kajam-11.4.0","ref":"Kajam-11.4.0","sha":"50cf2cf9d360662f739b4ad755f7256047549048","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":11364783,"name":"server","full_name":"kaltura/server","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/server","description":"The official Kaltura server. ","fork":false,"url":"https://api.github.com/repos/kaltura/server","forks_url":"https://api.github.com/repos/kaltura/server/forks","keys_url":"https://api.github.com/repos/kaltura/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/server/teams","hooks_url":"https://api.github.com/repos/kaltura/server/hooks","issue_events_url":"https://api.github.com/repos/kaltura/server/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/server/events","assignees_url":"https://api.github.com/repos/kaltura/server/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/server/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/server/tags","blobs_url":"https://api.github.com/repos/kaltura/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/server/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/server/languages","stargazers_url":"https://api.github.com/repos/kaltura/server/stargazers","contributors_url":"https://api.github.com/repos/kaltura/server/contributors","subscribers_url":"https://api.github.com/repos/kaltura/server/subscribers","subscription_url":"https://api.github.com/repos/kaltura/server/subscription","commits_url":"https://api.github.com/repos/kaltura/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/server/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/server/merges","archive_url":"https://api.github.com/repos/kaltura/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/server/downloads","issues_url":"https://api.github.com/repos/kaltura/server/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/server/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/server/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/server/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/server/releases{/id}","created_at":"2013-07-12T08:59:26Z","updated_at":"2015-12-02T05:32:44Z","pushed_at":"2015-12-09T11:32:55Z","git_url":"git://github.com/kaltura/server.git","ssh_url":"git@github.com:kaltura/server.git","clone_url":"https://github.com/kaltura/server.git","svn_url":"https://github.com/kaltura/server","homepage":"http://www.kaltura.org","size":227035,"stargazers_count":70,"watchers_count":70,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":81,"forks":83,"open_issues":81,"watchers":70,"default_branch":"Kajam-11.4.0"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/server/pulls/3582"},"html":{"href":"https://github.com/kaltura/server/pull/3582"},"issue":{"href":"https://api.github.com/repos/kaltura/server/issues/3582"},"comments":{"href":"https://api.github.com/repos/kaltura/server/issues/3582/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/server/pulls/3582/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/server/pulls/3582/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/server/statuses/0fb9e73dbe86a69a41a74a5635d7c80a5261e30e"}}}}