{"action":"created","issue":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4628","labels_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4628/labels{/name}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4628/comments","events_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4628/events","html_url":"https://github.com/HabitRPG/habitrpg/issues/4628","id":56551688,"number":4628,"title":"0.0 damage to boss","user":{"login":"NotShivering","id":10851608,"avatar_url":"https://avatars.githubusercontent.com/u/10851608?v=3","gravatar_id":"","url":"https://api.github.com/users/NotShivering","html_url":"https://github.com/NotShivering","followers_url":"https://api.github.com/users/NotShivering/followers","following_url":"https://api.github.com/users/NotShivering/following{/other_user}","gists_url":"https://api.github.com/users/NotShivering/gists{/gist_id}","starred_url":"https://api.github.com/users/NotShivering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NotShivering/subscriptions","organizations_url":"https://api.github.com/users/NotShivering/orgs","repos_url":"https://api.github.com/users/NotShivering/repos","events_url":"https://api.github.com/users/NotShivering/events{/privacy}","received_events_url":"https://api.github.com/users/NotShivering/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/HabitRPG/habitrpg/labels/suggestion-discussion","name":"suggestion-discussion","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-02-04T16:39:17Z","updated_at":"2015-02-04T21:46:24Z","closed_at":null,"body":"User ID: 57ab6504-1fd6-493e-b984-9b4ad2946c62\r\nGroup ID: 30fea9dc-239d-4d99-b529-1258cc9d87df\r\n\r\nOn 3 Feb 2015, Party had Rooster Rampage quest active.\r\nI log in, and did 257.2 damage to Rooster.  Rooster has 43 HP left.\r\nCast Burst of Flames (6x)\r\nChecked off 7 Habits.  Did 2 Criticals (350%).\r\nChecked off 10 Dailies.\r\nFed 7 Food items to Pets.\r\nParty member logs in, does 148.8 damage to Rooster, and Rooster is defeated.\r\nSent Quest Invite for The Icy Arachnid.\r\nParty accepted quest.\r\nI log out of HabitRPG.\r\n\r\nOn 4 Feb 2015, I log in and do 0.0 damage to Spider.\r\n\r\nIt appears that the tasks for 3 Feb are not counted towards the quest after cron.  Is this due to the fact that my tasks were checked while the previous quest was still active, even though the quest was completed prior to cron?\r\n\r\nI did notice that if there's a pending quest and I check off tasks, they correctly apply damage the next day once the quest has been accepted.  \r\n\r\n\r\n\r\n<bountysource-plugin>\r\n\r\n---\r\nWant to back this issue? **[Place a bounty on it!](https://www.bountysource.com/issues/8286260-0-0-damage-to-boss?utm_campaign=plugin&utm_content=tracker%2F68393&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F68393&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/comments/72946381","html_url":"https://github.com/HabitRPG/habitrpg/issues/4628#issuecomment-72946381","issue_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/4628","id":72946381,"user":{"login":"Alys","id":1495809,"avatar_url":"https://avatars.githubusercontent.com/u/1495809?v=3","gravatar_id":"","url":"https://api.github.com/users/Alys","html_url":"https://github.com/Alys","followers_url":"https://api.github.com/users/Alys/followers","following_url":"https://api.github.com/users/Alys/following{/other_user}","gists_url":"https://api.github.com/users/Alys/gists{/gist_id}","starred_url":"https://api.github.com/users/Alys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alys/subscriptions","organizations_url":"https://api.github.com/users/Alys/orgs","repos_url":"https://api.github.com/users/Alys/repos","events_url":"https://api.github.com/users/Alys/events{/privacy}","received_events_url":"https://api.github.com/users/Alys/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T21:46:24Z","updated_at":"2015-02-04T21:46:24Z","body":"_\"At least if the damage was being dealt in real time, everyone would get a\nchance to hit it!\"_ Not necessarily. If a Mage or Warrior cast their skills\nearly in the day (sensible if you have close to max mana) then the boss\nwould be defeated straight away. One-shotting is possible with the Warrior\nattack skill too, and still will be with BoF after nerfing with weak bosses\nand a full mana bar.\n\nOn 5 February 2015 at 07:33, lemoness <notifications@github.com> wrote:\n\n> People do sometimes request an \"overkill\" mechanic where there are bonus\n> points after everyone's cron occurs. After all, even in the current system,\n> it's common for people to not land a blow. Back when I played a Mage, I'd\n> frequently take down the boss before anyone else could land a single hit,\n> just because I could sign in first thing in the morning instead of after\n> work. (It's a big reason that I stopped being a Mage.). At least if the\n> damage was being dealt in real time, everyone would get a chance to hit it!\n> Plus, I think it is more satisfying from a game perspective. That being\n> said, it does make completing Dailies less necessary in cases like yours.\n> I'm not sure how common those will be, though, especially once we nerf BoF.\n>\n> Collection quests are hard enough that I think that we should count\n> previous tasks towards the total of new quests started.\n>\n> On Wednesday, February 4, 2015, Alice Harris <notifications@github.com>\n> wrote:\n>\n> > *\"Ground is still on fire/brutally smashed when the boss shows up\"* --- I\n> > love it! :)\n> >\n> > *\"Since Brutal Smash and Burst of Flames damage is calculated at cast,\n> > rather than at cron, I'd really like to see it damage the boss in real\n> > time.\"*\n> >\n> > Damage from tasks is calculated at task checkoff too. I think skills and\n> > tasks should be treated identically for when the damage is applied. I\n> also\n> > think that should be at cron. The primary purpose of quests is to\n> encourage\n> > you to do your Dailies before your day start time, and having much of\n> your\n> > interaction with the quest happen at cron supports that. Here's one\n> > (admittedly selfish) use-case where damage being applied immediately\n> would\n> > be detrimental:\n> >\n> > In the party I'm in, we usually finish one boss quest every day. I, as a\n> > mage, will cast enough skills to kill it. I have my custom day start time\n> > set so that my cron happens after my other party members' crons, meaning\n> > that they still have motivation to do their Dailies. If damage was\n> applied\n> > immediately, then the boss would die during the day, long before the day\n> > start time for any of us; even my own Dailies wouldn't have motivation\n> from\n> > the quest.\n> >\n> > - One \"solution\" to that is prohibiting people from killing bosses in\n> > one day, but I really don't like that approach. It adds complexity, and\n> > removes the one-shot ability that I am sure a lot of people like, and\n> > reduces revenue because instead of one quest being bought each day, it\n> > would be one quest every two days.\n> > - Another solution is for the party to run more than one quest a day\n> > -- good for revenue but it really does de-couple the quest system from\n> > Dailies motivation.\n> > - A third solution is to have the boss defeated but still hanging\n> > around until cron has happened for all party members, but I don't like\n> the\n> > code complexity for that, and we'd need to consider what happens if\n> members\n> > don't log in for a few days (and aren't in the inn), and it also makes\n> > little sense for a defeated boss to be doing damage to players hours\n> later.\n> >\n> > *\"Right now the quest damage counter resets once the boss is defeated...\n> > So, in short, a change DOES need to be made to the code. Just not sure\n> what\n> > that change should be.\"* From memory, that should be easy enough. The\n> > place in the code where the quest ends will wipe out the party.quest\n> > object for each participant. Instead of doing that, you'd just wipe those\n> > parts of it that are relevant to the specific quest (e.g., key) and leave\n> > in place the progress part. Then the only time the progress was removed\n> > would be at cron (and it always *should* be removed at cron, otherwise if\n> > you don't start a quest for many days, you could be one-shotting it from\n> > purely your task completions over those days). There'd been to be an\n> > exemption for collection quests, because we probably do want to start\n> > afresh for each quest, since the collection type is specific to the\n> quest.\n> >\n> > —\n> > Reply to this email directly or view it on GitHub\n> > <https://github.com/HabitRPG/habitrpg/issues/4628#issuecomment-72940682\n> >.\n> >\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/HabitRPG/habitrpg/issues/4628#issuecomment-72943976>.\n>\n"}}