{"action":"created","comment":{"url":"https://api.github.com/repos/Islandora/islandora_importer/pulls/comments/38201092","id":38201092,"diff_hunk":"@@ -421,6 +440,16 @@ EOXML;\n   }\n \n   /**\n+   *   Implements the PHP magic method __wakeup \n+   *\n+   */\n+  public function __wakeup() {\n+\n+    self::initialize_paths();","path":"modules/zip_importer/includes/importer.inc","position":79,"original_position":79,"commit_id":"5743337802fa58b77d40f1b9afd3f1b835ee66ec","original_commit_id":"5743337802fa58b77d40f1b9afd3f1b835ee66ec","user":{"login":"adam-vessey","id":607975,"avatar_url":"https://avatars.githubusercontent.com/u/607975?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-vessey","html_url":"https://github.com/adam-vessey","followers_url":"https://api.github.com/users/adam-vessey/followers","following_url":"https://api.github.com/users/adam-vessey/following{/other_user}","gists_url":"https://api.github.com/users/adam-vessey/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-vessey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-vessey/subscriptions","organizations_url":"https://api.github.com/users/adam-vessey/orgs","repos_url":"https://api.github.com/users/adam-vessey/repos","events_url":"https://api.github.com/users/adam-vessey/events{/privacy}","received_events_url":"https://api.github.com/users/adam-vessey/received_events","type":"User","site_admin":false},"body":"Should call with `static` instead of `self`, to permit late static binding.","created_at":"2015-08-28T13:51:23Z","updated_at":"2015-08-28T13:51:23Z","html_url":"https://github.com/Islandora/islandora_importer/pull/82#discussion_r38201092","pull_request_url":"https://api.github.com/repos/Islandora/islandora_importer/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/Islandora/islandora_importer/pulls/comments/38201092"},"html":{"href":"https://github.com/Islandora/islandora_importer/pull/82#discussion_r38201092"},"pull_request":{"href":"https://api.github.com/repos/Islandora/islandora_importer/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/Islandora/islandora_importer/pulls/82","id":43625464,"html_url":"https://github.com/Islandora/islandora_importer/pull/82","diff_url":"https://github.com/Islandora/islandora_importer/pull/82.diff","patch_url":"https://github.com/Islandora/islandora_importer/pull/82.patch","issue_url":"https://api.github.com/repos/Islandora/islandora_importer/issues/82","number":82,"state":"open","locked":false,"title":"Batch Importing Zip file with marcxml of more than 30 - 50 entries fails","user":{"login":"allupaku","id":305495,"avatar_url":"https://avatars.githubusercontent.com/u/305495?v=3","gravatar_id":"","url":"https://api.github.com/users/allupaku","html_url":"https://github.com/allupaku","followers_url":"https://api.github.com/users/allupaku/followers","following_url":"https://api.github.com/users/allupaku/following{/other_user}","gists_url":"https://api.github.com/users/allupaku/gists{/gist_id}","starred_url":"https://api.github.com/users/allupaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allupaku/subscriptions","organizations_url":"https://api.github.com/users/allupaku/orgs","repos_url":"https://api.github.com/users/allupaku/repos","events_url":"https://api.github.com/users/allupaku/events{/privacy}","received_events_url":"https://api.github.com/users/allupaku/received_events","type":"User","site_admin":false},"body":"Hello\r\n\r\nIn our installation of islandora we tried to import batch of more than 5000 marc xml file as a zip file and we found that the objects were getting created in fedora but with invalid fields. When i debugged it , found that the database entries were getting created but found that the xsl passed in for the method to serialize ::runXSLTransform was empty. After lot of debugging i found the reason why it is happening.\r\nIt goes like this : Objects are created -> stored in the database after serializing -> but only object properties not static properties are stored. -> (in case of less than 30 objects, it is unserialized quite early before the garbage collector clears the variables etc.) -> hence every thing works well. -> but when it is the case with more than 200(my test case) -> it is stored in the database and unserialized and calling the objects method getMODS -> there is no static variable for the paths. -> hence the conversion to MODS fails.\r\n\r\nSo i moved the static initializers to a static function called initialize_paths and called it from the wakeup magic method and the constructor - so that it will be available when the batch op tries to getMODS from it.\r\n\r\nBy doing this we have fixed the issue we were facing with the marc xml imports of big zip files.\r\n","created_at":"2015-08-28T13:03:37Z","updated_at":"2015-08-28T13:51:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe5d56cbfd528c37611b8315875920d456a7e794","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Islandora/islandora_importer/pulls/82/commits","review_comments_url":"https://api.github.com/repos/Islandora/islandora_importer/pulls/82/comments","review_comment_url":"https://api.github.com/repos/Islandora/islandora_importer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Islandora/islandora_importer/issues/82/comments","statuses_url":"https://api.github.com/repos/Islandora/islandora_importer/statuses/5743337802fa58b77d40f1b9afd3f1b835ee66ec","head":{"label":"allupaku:7.x","ref":"7.x","sha":"5743337802fa58b77d40f1b9afd3f1b835ee66ec","user":{"login":"allupaku","id":305495,"avatar_url":"https://avatars.githubusercontent.com/u/305495?v=3","gravatar_id":"","url":"https://api.github.com/users/allupaku","html_url":"https://github.com/allupaku","followers_url":"https://api.github.com/users/allupaku/followers","following_url":"https://api.github.com/users/allupaku/following{/other_user}","gists_url":"https://api.github.com/users/allupaku/gists{/gist_id}","starred_url":"https://api.github.com/users/allupaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allupaku/subscriptions","organizations_url":"https://api.github.com/users/allupaku/orgs","repos_url":"https://api.github.com/users/allupaku/repos","events_url":"https://api.github.com/users/allupaku/events{/privacy}","received_events_url":"https://api.github.com/users/allupaku/received_events","type":"User","site_admin":false},"repo":{"id":41544244,"name":"islandora_importer","full_name":"allupaku/islandora_importer","owner":{"login":"allupaku","id":305495,"avatar_url":"https://avatars.githubusercontent.com/u/305495?v=3","gravatar_id":"","url":"https://api.github.com/users/allupaku","html_url":"https://github.com/allupaku","followers_url":"https://api.github.com/users/allupaku/followers","following_url":"https://api.github.com/users/allupaku/following{/other_user}","gists_url":"https://api.github.com/users/allupaku/gists{/gist_id}","starred_url":"https://api.github.com/users/allupaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allupaku/subscriptions","organizations_url":"https://api.github.com/users/allupaku/orgs","repos_url":"https://api.github.com/users/allupaku/repos","events_url":"https://api.github.com/users/allupaku/events{/privacy}","received_events_url":"https://api.github.com/users/allupaku/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/allupaku/islandora_importer","description":"A pluggable batch ingester module for Islandora.","fork":true,"url":"https://api.github.com/repos/allupaku/islandora_importer","forks_url":"https://api.github.com/repos/allupaku/islandora_importer/forks","keys_url":"https://api.github.com/repos/allupaku/islandora_importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allupaku/islandora_importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allupaku/islandora_importer/teams","hooks_url":"https://api.github.com/repos/allupaku/islandora_importer/hooks","issue_events_url":"https://api.github.com/repos/allupaku/islandora_importer/issues/events{/number}","events_url":"https://api.github.com/repos/allupaku/islandora_importer/events","assignees_url":"https://api.github.com/repos/allupaku/islandora_importer/assignees{/user}","branches_url":"https://api.github.com/repos/allupaku/islandora_importer/branches{/branch}","tags_url":"https://api.github.com/repos/allupaku/islandora_importer/tags","blobs_url":"https://api.github.com/repos/allupaku/islandora_importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allupaku/islandora_importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allupaku/islandora_importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/allupaku/islandora_importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allupaku/islandora_importer/statuses/{sha}","languages_url":"https://api.github.com/repos/allupaku/islandora_importer/languages","stargazers_url":"https://api.github.com/repos/allupaku/islandora_importer/stargazers","contributors_url":"https://api.github.com/repos/allupaku/islandora_importer/contributors","subscribers_url":"https://api.github.com/repos/allupaku/islandora_importer/subscribers","subscription_url":"https://api.github.com/repos/allupaku/islandora_importer/subscription","commits_url":"https://api.github.com/repos/allupaku/islandora_importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/allupaku/islandora_importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/allupaku/islandora_importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/allupaku/islandora_importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/allupaku/islandora_importer/contents/{+path}","compare_url":"https://api.github.com/repos/allupaku/islandora_importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allupaku/islandora_importer/merges","archive_url":"https://api.github.com/repos/allupaku/islandora_importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allupaku/islandora_importer/downloads","issues_url":"https://api.github.com/repos/allupaku/islandora_importer/issues{/number}","pulls_url":"https://api.github.com/repos/allupaku/islandora_importer/pulls{/number}","milestones_url":"https://api.github.com/repos/allupaku/islandora_importer/milestones{/number}","notifications_url":"https://api.github.com/repos/allupaku/islandora_importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allupaku/islandora_importer/labels{/name}","releases_url":"https://api.github.com/repos/allupaku/islandora_importer/releases{/id}","created_at":"2015-08-28T11:39:33Z","updated_at":"2015-08-28T11:39:34Z","pushed_at":"2015-08-28T13:31:46Z","git_url":"git://github.com/allupaku/islandora_importer.git","ssh_url":"git@github.com:allupaku/islandora_importer.git","clone_url":"https://github.com/allupaku/islandora_importer.git","svn_url":"https://github.com/allupaku/islandora_importer","homepage":null,"size":1229,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"7.x"}},"base":{"label":"Islandora:7.x","ref":"7.x","sha":"a0e70173506a1e83601f2cab036a4b7ac8161a0a","user":{"login":"Islandora","id":494054,"avatar_url":"https://avatars.githubusercontent.com/u/494054?v=3","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"repo":{"id":6830820,"name":"islandora_importer","full_name":"Islandora/islandora_importer","owner":{"login":"Islandora","id":494054,"avatar_url":"https://avatars.githubusercontent.com/u/494054?v=3","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Islandora/islandora_importer","description":"A pluggable batch ingester module for Islandora.","fork":false,"url":"https://api.github.com/repos/Islandora/islandora_importer","forks_url":"https://api.github.com/repos/Islandora/islandora_importer/forks","keys_url":"https://api.github.com/repos/Islandora/islandora_importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Islandora/islandora_importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Islandora/islandora_importer/teams","hooks_url":"https://api.github.com/repos/Islandora/islandora_importer/hooks","issue_events_url":"https://api.github.com/repos/Islandora/islandora_importer/issues/events{/number}","events_url":"https://api.github.com/repos/Islandora/islandora_importer/events","assignees_url":"https://api.github.com/repos/Islandora/islandora_importer/assignees{/user}","branches_url":"https://api.github.com/repos/Islandora/islandora_importer/branches{/branch}","tags_url":"https://api.github.com/repos/Islandora/islandora_importer/tags","blobs_url":"https://api.github.com/repos/Islandora/islandora_importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Islandora/islandora_importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Islandora/islandora_importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Islandora/islandora_importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Islandora/islandora_importer/statuses/{sha}","languages_url":"https://api.github.com/repos/Islandora/islandora_importer/languages","stargazers_url":"https://api.github.com/repos/Islandora/islandora_importer/stargazers","contributors_url":"https://api.github.com/repos/Islandora/islandora_importer/contributors","subscribers_url":"https://api.github.com/repos/Islandora/islandora_importer/subscribers","subscription_url":"https://api.github.com/repos/Islandora/islandora_importer/subscription","commits_url":"https://api.github.com/repos/Islandora/islandora_importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Islandora/islandora_importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Islandora/islandora_importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Islandora/islandora_importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Islandora/islandora_importer/contents/{+path}","compare_url":"https://api.github.com/repos/Islandora/islandora_importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Islandora/islandora_importer/merges","archive_url":"https://api.github.com/repos/Islandora/islandora_importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Islandora/islandora_importer/downloads","issues_url":"https://api.github.com/repos/Islandora/islandora_importer/issues{/number}","pulls_url":"https://api.github.com/repos/Islandora/islandora_importer/pulls{/number}","milestones_url":"https://api.github.com/repos/Islandora/islandora_importer/milestones{/number}","notifications_url":"https://api.github.com/repos/Islandora/islandora_importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Islandora/islandora_importer/labels{/name}","releases_url":"https://api.github.com/repos/Islandora/islandora_importer/releases{/id}","created_at":"2012-11-23T17:22:44Z","updated_at":"2015-08-18T20:46:11Z","pushed_at":"2015-08-28T13:31:47Z","git_url":"git://github.com/Islandora/islandora_importer.git","ssh_url":"git@github.com:Islandora/islandora_importer.git","clone_url":"https://github.com/Islandora/islandora_importer.git","svn_url":"https://github.com/Islandora/islandora_importer","homepage":null,"size":1229,"stargazers_count":1,"watchers_count":1,"language":"XSLT","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":1,"forks":28,"open_issues":1,"watchers":1,"default_branch":"7.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Islandora/islandora_importer/pulls/82"},"html":{"href":"https://github.com/Islandora/islandora_importer/pull/82"},"issue":{"href":"https://api.github.com/repos/Islandora/islandora_importer/issues/82"},"comments":{"href":"https://api.github.com/repos/Islandora/islandora_importer/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/Islandora/islandora_importer/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/Islandora/islandora_importer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Islandora/islandora_importer/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/Islandora/islandora_importer/statuses/5743337802fa58b77d40f1b9afd3f1b835ee66ec"}}}}