{"action":"created","issue":{"url":"https://api.github.com/repos/techtalk/SpecFlow/issues/527","labels_url":"https://api.github.com/repos/techtalk/SpecFlow/issues/527/labels{/name}","comments_url":"https://api.github.com/repos/techtalk/SpecFlow/issues/527/comments","events_url":"https://api.github.com/repos/techtalk/SpecFlow/issues/527/events","html_url":"https://github.com/techtalk/SpecFlow/pull/527","id":121516338,"number":527,"title":"Step transformation value retriever (fix)","user":{"login":"gasparnagy","id":144701,"avatar_url":"https://avatars.githubusercontent.com/u/144701?v=3","gravatar_id":"","url":"https://api.github.com/users/gasparnagy","html_url":"https://github.com/gasparnagy","followers_url":"https://api.github.com/users/gasparnagy/followers","following_url":"https://api.github.com/users/gasparnagy/following{/other_user}","gists_url":"https://api.github.com/users/gasparnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/gasparnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasparnagy/subscriptions","organizations_url":"https://api.github.com/users/gasparnagy/orgs","repos_url":"https://api.github.com/users/gasparnagy/repos","events_url":"https://api.github.com/users/gasparnagy/events{/privacy}","received_events_url":"https://api.github.com/users/gasparnagy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-12-10T15:49:53Z","updated_at":"2015-12-15T15:06:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/techtalk/SpecFlow/pulls/527","html_url":"https://github.com/techtalk/SpecFlow/pull/527","diff_url":"https://github.com/techtalk/SpecFlow/pull/527.diff","patch_url":"https://github.com/techtalk/SpecFlow/pull/527.patch"},"body":"This is a reopen #505 to address integration issues. \r\n\r\nI have added integration tests in the Tests\\TechTalk.SpecFlow.Specs\\Features\\Assist\\CreateSet.feature\r\n\r\nThe related scenario fails, because of the reasons:\r\n1. The StepTransformationValueRetriever is the last one in the prio list and the DateTimeValueRetriever returns true on canretrieve earlier, so StepTransformationValueRetriever is never called\r\n2. If I move the StepTransformationValueRetriever as a first, it fails because it cannot resolve CultureInfo from the container. (fixed)\r\n3. It looks to me, that in `MemberHandler.GetValue()`, `PropertyType` should be passed to `valueRetriever.Retrieve` as a target type and not `Type`\r\n\r\nThis is the related scenario\r\n```\r\nScenario: Should use step atgument transformations when converting a table to a list of entities\r\n\tGiven the following class\r\n\t\t\"\"\"\r\n\t\tpublic class Account\r\n\t\t{\r\n\t\t\tpublic string Name { get; set; }\r\n\t\t\tpublic DateTime Birthdate { get; set; }\r\n\t\t\tpublic decimal Balance { get; set; }\r\n\t\t}\r\n\t\t\"\"\"\r\n\tAnd a scenario 'Simple Scenario' as\r\n\t\t\"\"\"\r\n\t\tGiven the following accounts\r\n\t\t\t| Name      | Birthdate     | Balance |\r\n\t\t\t| John Galt | my magic date | 1234.56 |\r\n\t\t\"\"\"\r\n\tAnd the following step argument transformation\r\n         \"\"\"\r\n         [StepArgumentTransformation(@\"my magic date\")]\r\n\t\t public DateTime ConvertMagicDate()\r\n\t\t {\r\n\t\t\treturn new DateTime(2000,1,1);\r\n\t\t }\r\n         \"\"\"\r\n\tAnd the following step definition\r\n\t\t\"\"\"\r\n\t\t[Given(@\"the following accounts\")]\r\n\t\tpublic void GivenTheFollowingAccounts(Table accountsTable)\r\n\t\t{\r\n\t\t\tvar accounts = accountsTable.CreateSet<Account>();\r\n\t\t\tforeach (var account in accounts)\r\n\t\t\t\tConsole.WriteLine(account.Birthdate);\r\n\t\t}\r\n\t\t\"\"\"\r\n\tAnd the 'TechTalk.SpecFlow.Assist' namespace is added to the namespace usings\r\n\tWhen I execute the tests\r\n\tThen all tests should pass\r\n\tAnd the execution log should contain text '1/1/2000'\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/techtalk/SpecFlow/issues/comments/164791634","html_url":"https://github.com/techtalk/SpecFlow/pull/527#issuecomment-164791634","issue_url":"https://api.github.com/repos/techtalk/SpecFlow/issues/527","id":164791634,"user":{"login":"gasparnagy","id":144701,"avatar_url":"https://avatars.githubusercontent.com/u/144701?v=3","gravatar_id":"","url":"https://api.github.com/users/gasparnagy","html_url":"https://github.com/gasparnagy","followers_url":"https://api.github.com/users/gasparnagy/followers","following_url":"https://api.github.com/users/gasparnagy/following{/other_user}","gists_url":"https://api.github.com/users/gasparnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/gasparnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasparnagy/subscriptions","organizations_url":"https://api.github.com/users/gasparnagy/orgs","repos_url":"https://api.github.com/users/gasparnagy/repos","events_url":"https://api.github.com/users/gasparnagy/events{/privacy}","received_events_url":"https://api.github.com/users/gasparnagy/received_events","type":"User","site_admin":false},"created_at":"2015-12-15T15:06:46Z","updated_at":"2015-12-15T15:06:46Z","body":"@darrencauthon i would not do that (merge something that will surely break in parallel). Parallel will be one of the bigger new features of v2, so people will try it out. My other concern is that it is out of balance because it only supports the StepArgumentTransformation for the create case and not for the compare. Maybe there is no way to support the compare case anyway, but I need to think it over on a calm day -- that is not really realistic for me before January. The stress does not come from Assist, but from the end-of-year rush... :)\r\n\r\nMy plan is to make a pre-release package on Nuget until Friday and make the final release in Jan."}}