{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/demos/pulls/comments/37468225","id":37468225,"diff_hunk":"@@ -0,0 +1,72 @@\n+// Copyright 2015 Open Source Robotics Foundation, Inc.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+#include <functional>\n+#include <iostream>\n+\n+#include <rclcpp/rclcpp.hpp>\n+\n+#include <std_msgs/msg/string.hpp>\n+\n+void on_message(const std_msgs::msg::String::ConstSharedPtr & msg)","path":"intra_process_comms/src/intrapc.cpp","position":22,"original_position":22,"commit_id":"6a23ec7fc8c03ae265bd2876278905bb593aacc7","original_commit_id":"6a23ec7fc8c03ae265bd2876278905bb593aacc7","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"> The reference & is not needed for shared pointers.\r\n\r\nThis is the signature for subscription callbacks, e.g.: https://github.com/ros2/examples/blob/master/rclcpp_examples/src/topics/listener.cpp#L22\r\n\r\nWhy not take them by reference?","created_at":"2015-08-19T21:07:23Z","updated_at":"2015-08-19T21:07:23Z","html_url":"https://github.com/ros2/demos/pull/5#discussion_r37468225","pull_request_url":"https://api.github.com/repos/ros2/demos/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/ros2/demos/pulls/comments/37468225"},"html":{"href":"https://github.com/ros2/demos/pull/5#discussion_r37468225"},"pull_request":{"href":"https://api.github.com/repos/ros2/demos/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/demos/pulls/5","id":41526230,"html_url":"https://github.com/ros2/demos/pull/5","diff_url":"https://github.com/ros2/demos/pull/5.diff","patch_url":"https://github.com/ros2/demos/pull/5.patch","issue_url":"https://api.github.com/repos/ros2/demos/issues/5","number":5,"state":"open","locked":false,"title":"Demo for intra process communication","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"Work in progress, not ready for review.\r\n\r\nConnects to ros2/ros2#59","created_at":"2015-08-04T01:18:08Z","updated_at":"2015-08-19T21:07:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f914fa1dbb1417dd937d762d1870d311376651e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros2/demos/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ros2/demos/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ros2/demos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/demos/issues/5/comments","statuses_url":"https://api.github.com/repos/ros2/demos/statuses/6a23ec7fc8c03ae265bd2876278905bb593aacc7","head":{"label":"ros2:intra_process","ref":"intra_process","sha":"6a23ec7fc8c03ae265bd2876278905bb593aacc7","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":39266291,"name":"demos","full_name":"ros2/demos","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/demos","description":"","fork":false,"url":"https://api.github.com/repos/ros2/demos","forks_url":"https://api.github.com/repos/ros2/demos/forks","keys_url":"https://api.github.com/repos/ros2/demos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/demos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/demos/teams","hooks_url":"https://api.github.com/repos/ros2/demos/hooks","issue_events_url":"https://api.github.com/repos/ros2/demos/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/demos/events","assignees_url":"https://api.github.com/repos/ros2/demos/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/demos/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/demos/tags","blobs_url":"https://api.github.com/repos/ros2/demos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/demos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/demos/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/demos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/demos/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/demos/languages","stargazers_url":"https://api.github.com/repos/ros2/demos/stargazers","contributors_url":"https://api.github.com/repos/ros2/demos/contributors","subscribers_url":"https://api.github.com/repos/ros2/demos/subscribers","subscription_url":"https://api.github.com/repos/ros2/demos/subscription","commits_url":"https://api.github.com/repos/ros2/demos/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/demos/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/demos/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/demos/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/demos/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/demos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/demos/merges","archive_url":"https://api.github.com/repos/ros2/demos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/demos/downloads","issues_url":"https://api.github.com/repos/ros2/demos/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/demos/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/demos/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/demos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/demos/labels{/name}","releases_url":"https://api.github.com/repos/ros2/demos/releases{/id}","created_at":"2015-07-17T17:24:00Z","updated_at":"2015-07-17T17:24:09Z","pushed_at":"2015-08-19T20:58:27Z","git_url":"git://github.com/ros2/demos.git","ssh_url":"git@github.com:ros2/demos.git","clone_url":"https://github.com/ros2/demos.git","svn_url":"https://github.com/ros2/demos","homepage":null,"size":312,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"3c16f93bdd56fb04cffc4a26a83544c6aee337ca","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":39266291,"name":"demos","full_name":"ros2/demos","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/demos","description":"","fork":false,"url":"https://api.github.com/repos/ros2/demos","forks_url":"https://api.github.com/repos/ros2/demos/forks","keys_url":"https://api.github.com/repos/ros2/demos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/demos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/demos/teams","hooks_url":"https://api.github.com/repos/ros2/demos/hooks","issue_events_url":"https://api.github.com/repos/ros2/demos/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/demos/events","assignees_url":"https://api.github.com/repos/ros2/demos/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/demos/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/demos/tags","blobs_url":"https://api.github.com/repos/ros2/demos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/demos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/demos/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/demos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/demos/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/demos/languages","stargazers_url":"https://api.github.com/repos/ros2/demos/stargazers","contributors_url":"https://api.github.com/repos/ros2/demos/contributors","subscribers_url":"https://api.github.com/repos/ros2/demos/subscribers","subscription_url":"https://api.github.com/repos/ros2/demos/subscription","commits_url":"https://api.github.com/repos/ros2/demos/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/demos/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/demos/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/demos/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/demos/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/demos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/demos/merges","archive_url":"https://api.github.com/repos/ros2/demos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/demos/downloads","issues_url":"https://api.github.com/repos/ros2/demos/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/demos/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/demos/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/demos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/demos/labels{/name}","releases_url":"https://api.github.com/repos/ros2/demos/releases{/id}","created_at":"2015-07-17T17:24:00Z","updated_at":"2015-07-17T17:24:09Z","pushed_at":"2015-08-19T20:58:27Z","git_url":"git://github.com/ros2/demos.git","ssh_url":"git@github.com:ros2/demos.git","clone_url":"https://github.com/ros2/demos.git","svn_url":"https://github.com/ros2/demos","homepage":null,"size":312,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/demos/pulls/5"},"html":{"href":"https://github.com/ros2/demos/pull/5"},"issue":{"href":"https://api.github.com/repos/ros2/demos/issues/5"},"comments":{"href":"https://api.github.com/repos/ros2/demos/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/demos/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/demos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/demos/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/demos/statuses/6a23ec7fc8c03ae265bd2876278905bb593aacc7"}}}}