{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/38439300","id":38439300,"diff_hunk":"@@ -44,7 +45,9 @@\n  *\n  * <p>The channel is intended to be fully-featured, high performance, and useful in testing.\n  */\n-public class InProcessChannelBuilder extends AbstractChannelBuilder<InProcessChannelBuilder> {\n+@Internal","path":"core/src/main/java/io/grpc/inprocess/InProcessChannelBuilder.java","position":15,"original_position":15,"commit_id":"d0e97f9bb4a54ee46a7d33aba0169ac3a68ac7ce","original_commit_id":"d0e97f9bb4a54ee46a7d33aba0169ac3a68ac7ce","user":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars.githubusercontent.com/u/2811396?v=3","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"body":"In what way is this internal? Did you mean ExperimentalApi?","created_at":"2015-09-01T16:24:24Z","updated_at":"2015-09-01T16:24:24Z","html_url":"https://github.com/grpc/grpc-java/pull/914#discussion_r38439300","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/914","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/38439300"},"html":{"href":"https://github.com/grpc/grpc-java/pull/914#discussion_r38439300"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/914"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/914","id":43894402,"html_url":"https://github.com/grpc/grpc-java/pull/914","diff_url":"https://github.com/grpc/grpc-java/pull/914.diff","patch_url":"https://github.com/grpc/grpc-java/pull/914.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/914","number":914,"state":"open","locked":false,"title":"Refactoring channel API.","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"body":"Client:\r\n* New ManagedChannel abstract class.\r\n* Adding ping to Channel.\r\n* Moving builders and implementations to internal.\r\n\r\nServer:\r\n* Added lifecycle management API to Server (mirroring ManagedChannel).\r\n* Moved ServerImpl, AbstractServerBuilder and handler registries to internal.\r\n* New ServerBuilder abstract class (mirroring ManagedChannelBuilder).\r\n\r\nFixes #545","created_at":"2015-09-01T16:05:29Z","updated_at":"2015-09-01T16:24:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57e8889f938f9227e80044037575d92973b4af3b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/914/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/914/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/914/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/d0e97f9bb4a54ee46a7d33aba0169ac3a68ac7ce","head":{"label":"nmittler:channel_refactor","ref":"channel_refactor","sha":"d0e97f9bb4a54ee46a7d33aba0169ac3a68ac7ce","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"repo":{"id":31379300,"name":"grpc-java","full_name":"nmittler/grpc-java","owner":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmittler/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/nmittler/grpc-java","forks_url":"https://api.github.com/repos/nmittler/grpc-java/forks","keys_url":"https://api.github.com/repos/nmittler/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmittler/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmittler/grpc-java/teams","hooks_url":"https://api.github.com/repos/nmittler/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/nmittler/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/nmittler/grpc-java/events","assignees_url":"https://api.github.com/repos/nmittler/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/nmittler/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/nmittler/grpc-java/tags","blobs_url":"https://api.github.com/repos/nmittler/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmittler/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmittler/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmittler/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmittler/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/nmittler/grpc-java/languages","stargazers_url":"https://api.github.com/repos/nmittler/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/nmittler/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/nmittler/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/nmittler/grpc-java/subscription","commits_url":"https://api.github.com/repos/nmittler/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmittler/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmittler/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmittler/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmittler/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/nmittler/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmittler/grpc-java/merges","archive_url":"https://api.github.com/repos/nmittler/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmittler/grpc-java/downloads","issues_url":"https://api.github.com/repos/nmittler/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/nmittler/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/nmittler/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/nmittler/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmittler/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/nmittler/grpc-java/releases{/id}","created_at":"2015-02-26T17:29:20Z","updated_at":"2015-03-03T21:47:37Z","pushed_at":"2015-09-01T16:03:41Z","git_url":"git://github.com/nmittler/grpc-java.git","ssh_url":"git@github.com:nmittler/grpc-java.git","clone_url":"https://github.com/nmittler/grpc-java.git","svn_url":"https://github.com/nmittler/grpc-java","homepage":"","size":4334,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"d3ab427fca9440bc2c4c74d5460088e229143793","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","created_at":"2014-12-08T19:00:00Z","updated_at":"2015-09-01T10:10:01Z","pushed_at":"2015-09-01T16:05:30Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"","size":22294,"stargazers_count":853,"watchers_count":853,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":206,"mirror_url":null,"open_issues_count":99,"forks":206,"open_issues":99,"watchers":853,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/914"},"html":{"href":"https://github.com/grpc/grpc-java/pull/914"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/914"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/914/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/914/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/914/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/d0e97f9bb4a54ee46a7d33aba0169ac3a68ac7ce"}}}}