{"action":"created","issue":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3302","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3302/labels{/name}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3302/comments","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3302/events","html_url":"https://github.com/crosswalk-project/crosswalk/pull/3302","id":111166440,"number":3302,"title":"[Android] Fix the issue about manifest.json was always used.","user":{"login":"wuhengzhi","id":1527639,"avatar_url":"https://avatars.githubusercontent.com/u/1527639?v=3","gravatar_id":"","url":"https://api.github.com/users/wuhengzhi","html_url":"https://github.com/wuhengzhi","followers_url":"https://api.github.com/users/wuhengzhi/followers","following_url":"https://api.github.com/users/wuhengzhi/following{/other_user}","gists_url":"https://api.github.com/users/wuhengzhi/gists{/gist_id}","starred_url":"https://api.github.com/users/wuhengzhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuhengzhi/subscriptions","organizations_url":"https://api.github.com/users/wuhengzhi/orgs","repos_url":"https://api.github.com/users/wuhengzhi/repos","events_url":"https://api.github.com/users/wuhengzhi/events{/privacy}","received_events_url":"https://api.github.com/users/wuhengzhi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-10-13T12:08:54Z","updated_at":"2015-10-15T09:21:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3302","html_url":"https://github.com/crosswalk-project/crosswalk/pull/3302","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/3302.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/3302.patch"},"body":"This patch is to fix manifest.json was always used issue.\r\nIn application's folder, if manifest.json was existed, it will be\r\nalways used even if it was not specified in command line.\r\ne.g. if manifest.json was existed and app was packaged by \"make_apk.py\r\n--package=org.xwalk.test --name=test --app-root=path-to-app\r\n--app-local-path=index.html\", this way won't work, manifest.json will be\r\nused.\r\n\r\nBUG=XWALK-5131"},"comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments/148328318","html_url":"https://github.com/crosswalk-project/crosswalk/pull/3302#issuecomment-148328318","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3302","id":148328318,"user":{"login":"rakuco","id":36417,"avatar_url":"https://avatars.githubusercontent.com/u/36417?v=3","gravatar_id":"","url":"https://api.github.com/users/rakuco","html_url":"https://github.com/rakuco","followers_url":"https://api.github.com/users/rakuco/followers","following_url":"https://api.github.com/users/rakuco/following{/other_user}","gists_url":"https://api.github.com/users/rakuco/gists{/gist_id}","starred_url":"https://api.github.com/users/rakuco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakuco/subscriptions","organizations_url":"https://api.github.com/users/rakuco/orgs","repos_url":"https://api.github.com/users/rakuco/repos","events_url":"https://api.github.com/users/rakuco/events{/privacy}","received_events_url":"https://api.github.com/users/rakuco/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T09:21:34Z","updated_at":"2015-10-15T09:21:34Z","body":"btw, one thing that worries me a little is that nothing had to be changed in the make apk tests, which means that part was not being checked. did you verify both code paths? is it possible to add a test for it, or adapt an existing one?"}}