{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/30118325","id":30118325,"diff_hunk":"@@ -129,12 +121,13 @@ public long append( TransactionRepresentation transaction, LogAppendEvent logApp\n                 {\n                     transactionId = transactionIdStore.nextCommittingTransactionId();\n                     phase = 1;\n-                    commit = append0( transaction, transactionId );\n+                    commit = serializeToTransactionLog( transaction, transactionId );","path":"community/kernel/src/main/java/org/neo4j/kernel/impl/transaction/log/BatchingTransactionAppender.java","position":158,"original_position":158,"commit_id":"32610e21d1abb619ee0126d3cec9fe1acdbc670a","original_commit_id":"32610e21d1abb619ee0126d3cec9fe1acdbc670a","user":{"login":"tinwelint","id":187292,"avatar_url":"https://avatars.githubusercontent.com/u/187292?v=3","gravatar_id":"","url":"https://api.github.com/users/tinwelint","html_url":"https://github.com/tinwelint","followers_url":"https://api.github.com/users/tinwelint/followers","following_url":"https://api.github.com/users/tinwelint/following{/other_user}","gists_url":"https://api.github.com/users/tinwelint/gists{/gist_id}","starred_url":"https://api.github.com/users/tinwelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinwelint/subscriptions","organizations_url":"https://api.github.com/users/tinwelint/orgs","repos_url":"https://api.github.com/users/tinwelint/repos","events_url":"https://api.github.com/users/tinwelint/events{/privacy}","received_events_url":"https://api.github.com/users/tinwelint/received_events","type":"User","site_admin":false},"body":"Same here about `serialize` (which has a different spelling than above btw) --> `append` methinks.","created_at":"2015-05-12T09:38:45Z","updated_at":"2015-05-12T09:38:45Z","html_url":"https://github.com/neo4j/neo4j/pull/4578#discussion_r30118325","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4578","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/30118325"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4578#discussion_r30118325"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4578"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/4578","id":34719660,"html_url":"https://github.com/neo4j/neo4j/pull/4578","diff_url":"https://github.com/neo4j/neo4j/pull/4578.diff","patch_url":"https://github.com/neo4j/neo4j/pull/4578.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/4578","number":4578,"state":"open","locked":false,"title":"Refactoring and cleanup around transaction appenders","user":{"login":"chrisvest","id":7993,"avatar_url":"https://avatars.githubusercontent.com/u/7993?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvest","html_url":"https://github.com/chrisvest","followers_url":"https://api.github.com/users/chrisvest/followers","following_url":"https://api.github.com/users/chrisvest/following{/other_user}","gists_url":"https://api.github.com/users/chrisvest/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvest/subscriptions","organizations_url":"https://api.github.com/users/chrisvest/orgs","repos_url":"https://api.github.com/users/chrisvest/repos","events_url":"https://api.github.com/users/chrisvest/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvest/received_events","type":"User","site_admin":false},"body":"* Collapses the AbstractPhysicalTransactionAppender hierarchy.\r\n* Removes non-batched appending and obsoletes the `batched_writes` configuration option.\r\n* Rename a couple of methods for clarity.\r\n* Move InMemoryLogChannel to test sources.","created_at":"2015-05-05T12:34:48Z","updated_at":"2015-05-12T09:38:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bd3b1b10d1c4e4cdc2334b0fcfec380d2650d0f","assignee":{"login":"tinwelint","id":187292,"avatar_url":"https://avatars.githubusercontent.com/u/187292?v=3","gravatar_id":"","url":"https://api.github.com/users/tinwelint","html_url":"https://github.com/tinwelint","followers_url":"https://api.github.com/users/tinwelint/followers","following_url":"https://api.github.com/users/tinwelint/following{/other_user}","gists_url":"https://api.github.com/users/tinwelint/gists{/gist_id}","starred_url":"https://api.github.com/users/tinwelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinwelint/subscriptions","organizations_url":"https://api.github.com/users/tinwelint/orgs","repos_url":"https://api.github.com/users/tinwelint/repos","events_url":"https://api.github.com/users/tinwelint/events{/privacy}","received_events_url":"https://api.github.com/users/tinwelint/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4578/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4578/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/4578/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/32610e21d1abb619ee0126d3cec9fe1acdbc670a","head":{"label":"chrisvest:2.3-bta-cleanup","ref":"2.3-bta-cleanup","sha":"32610e21d1abb619ee0126d3cec9fe1acdbc670a","user":{"login":"chrisvest","id":7993,"avatar_url":"https://avatars.githubusercontent.com/u/7993?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvest","html_url":"https://github.com/chrisvest","followers_url":"https://api.github.com/users/chrisvest/followers","following_url":"https://api.github.com/users/chrisvest/following{/other_user}","gists_url":"https://api.github.com/users/chrisvest/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvest/subscriptions","organizations_url":"https://api.github.com/users/chrisvest/orgs","repos_url":"https://api.github.com/users/chrisvest/repos","events_url":"https://api.github.com/users/chrisvest/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvest/received_events","type":"User","site_admin":false},"repo":{"id":12541371,"name":"neo4j","full_name":"chrisvest/neo4j","owner":{"login":"chrisvest","id":7993,"avatar_url":"https://avatars.githubusercontent.com/u/7993?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvest","html_url":"https://github.com/chrisvest","followers_url":"https://api.github.com/users/chrisvest/followers","following_url":"https://api.github.com/users/chrisvest/following{/other_user}","gists_url":"https://api.github.com/users/chrisvest/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvest/subscriptions","organizations_url":"https://api.github.com/users/chrisvest/orgs","repos_url":"https://api.github.com/users/chrisvest/repos","events_url":"https://api.github.com/users/chrisvest/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisvest/neo4j","description":"The World's Leading Graph Database","fork":true,"url":"https://api.github.com/repos/chrisvest/neo4j","forks_url":"https://api.github.com/repos/chrisvest/neo4j/forks","keys_url":"https://api.github.com/repos/chrisvest/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisvest/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisvest/neo4j/teams","hooks_url":"https://api.github.com/repos/chrisvest/neo4j/hooks","issue_events_url":"https://api.github.com/repos/chrisvest/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/chrisvest/neo4j/events","assignees_url":"https://api.github.com/repos/chrisvest/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/chrisvest/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/chrisvest/neo4j/tags","blobs_url":"https://api.github.com/repos/chrisvest/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisvest/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisvest/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisvest/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisvest/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisvest/neo4j/languages","stargazers_url":"https://api.github.com/repos/chrisvest/neo4j/stargazers","contributors_url":"https://api.github.com/repos/chrisvest/neo4j/contributors","subscribers_url":"https://api.github.com/repos/chrisvest/neo4j/subscribers","subscription_url":"https://api.github.com/repos/chrisvest/neo4j/subscription","commits_url":"https://api.github.com/repos/chrisvest/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisvest/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisvest/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisvest/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisvest/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/chrisvest/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisvest/neo4j/merges","archive_url":"https://api.github.com/repos/chrisvest/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisvest/neo4j/downloads","issues_url":"https://api.github.com/repos/chrisvest/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/chrisvest/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisvest/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisvest/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisvest/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/chrisvest/neo4j/releases{/id}","created_at":"2013-09-02T14:05:14Z","updated_at":"2015-03-27T13:31:38Z","pushed_at":"2015-05-10T20:37:58Z","git_url":"git://github.com/chrisvest/neo4j.git","ssh_url":"git@github.com:chrisvest/neo4j.git","clone_url":"https://github.com/chrisvest/neo4j.git","svn_url":"https://github.com/chrisvest/neo4j","homepage":"http://neo4j.org","size":191136,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:2.3","ref":"2.3","sha":"e23e79e46693267c25545970a978fab76282ef57","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-05-12T03:38:34Z","pushed_at":"2015-05-12T09:27:15Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":461449,"stargazers_count":1662,"watchers_count":1662,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":673,"mirror_url":null,"open_issues_count":428,"forks":673,"open_issues":428,"watchers":1662,"default_branch":"2.3"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4578"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4578"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4578"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4578/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4578/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4578/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/32610e21d1abb619ee0126d3cec9fe1acdbc670a"}}}}