{"action":"created","issue":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3498","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3498/labels{/name}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3498/comments","events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3498/events","html_url":"https://github.com/zfsonlinux/zfs/pull/3498","id":88564507,"number":3498,"title":"RFC [buildbot] Illumos-5701 zpool list reports incorrect \"alloc\" value for cache devices","user":{"login":"kernelOfTruth","id":4529709,"avatar_url":"https://avatars.githubusercontent.com/u/4529709?v=3","gravatar_id":"","url":"https://api.github.com/users/kernelOfTruth","html_url":"https://github.com/kernelOfTruth","followers_url":"https://api.github.com/users/kernelOfTruth/followers","following_url":"https://api.github.com/users/kernelOfTruth/following{/other_user}","gists_url":"https://api.github.com/users/kernelOfTruth/gists{/gist_id}","starred_url":"https://api.github.com/users/kernelOfTruth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernelOfTruth/subscriptions","organizations_url":"https://api.github.com/users/kernelOfTruth/orgs","repos_url":"https://api.github.com/users/kernelOfTruth/repos","events_url":"https://api.github.com/users/kernelOfTruth/events{/privacy}","received_events_url":"https://api.github.com/users/kernelOfTruth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-15T23:13:12Z","updated_at":"2015-06-24T20:09:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3498","html_url":"https://github.com/zfsonlinux/zfs/pull/3498","diff_url":"https://github.com/zfsonlinux/zfs/pull/3498.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/3498.patch"},"body":"Reviewed by: Matthew Ahrens <mahrens@delphix.com>\r\nReviewed by: George Wilson <george@delphix.com>\r\nReviewed by: Alek Pinchuk <alek.pinchuk@nexenta.com>\r\nApproved by: Dan McDonald <danmcd@omniti.com>\r\n\r\narc_space_return(HDR_L2ONLY_SIZE, ARC_SPACE_L2HDRS);\r\n\r\ncorrectly placed at\r\n\r\n@arc_hdr_l2hdr_destroy(arc_buf_hdr_t *hdr)\r\n\r\n?\r\n\r\n\r\nBlock:\r\n\r\n```\r\n+\t/*\r\n+\t * If the l2hdr's b_daddr is equal to L2ARC_ADDR_UNSET, then\r\n+\t * this header is being processed by l2arc_write_buffers() (i.e.\r\n+\t * it's in the first stage of l2arc_write_buffers()).\r\n+\t * Re-affirming that truth here, just to serve as a reminder. If\r\n+\t * b_daddr does not equal L2ARC_ADDR_UNSET, then the header may or\r\n+\t * may not have its HDR_L2_WRITING flag set. (the write may have\r\n+\t * completed, in which case HDR_L2_WRITING will be false and the\r\n+\t * b_daddr field will point to the address of the buffer on disk).\r\n+\t */\r\n+//\tIMPLY(l2hdr->b_daddr == L2ARC_ADDR_UNSET, HDR_L2_WRITING(hdr));\r\n```\r\n\r\n1883 to 1893 applicable to ZFSOnLinux ?"},"comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments/114995668","html_url":"https://github.com/zfsonlinux/zfs/pull/3498#issuecomment-114995668","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3498","id":114995668,"user":{"login":"kernelOfTruth","id":4529709,"avatar_url":"https://avatars.githubusercontent.com/u/4529709?v=3","gravatar_id":"","url":"https://api.github.com/users/kernelOfTruth","html_url":"https://github.com/kernelOfTruth","followers_url":"https://api.github.com/users/kernelOfTruth/followers","following_url":"https://api.github.com/users/kernelOfTruth/following{/other_user}","gists_url":"https://api.github.com/users/kernelOfTruth/gists{/gist_id}","starred_url":"https://api.github.com/users/kernelOfTruth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernelOfTruth/subscriptions","organizations_url":"https://api.github.com/users/kernelOfTruth/orgs","repos_url":"https://api.github.com/users/kernelOfTruth/repos","events_url":"https://api.github.com/users/kernelOfTruth/events{/privacy}","received_events_url":"https://api.github.com/users/kernelOfTruth/received_events","type":"User","site_admin":false},"created_at":"2015-06-24T20:09:31Z","updated_at":"2015-06-24T20:09:31Z","body":"@behlendorf is the block with\r\n\r\n> IMPLY(l2hdr->b_daddr == L2ARC_ADDR_UNSET, HDR_L2_WRITING(hdr));\r\n\r\nneeded on ZFSOnLinux - it seems to be specific to Illumos derivatives and a previous \"incarnation\" of this patch has been tested positively with that part commented out"}}