{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/263","labels_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/263/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/263/events","html_url":"https://github.com/vaadin/vaadin-grid/pull/263","id":117587058,"number":263,"title":"Refactor/header api","user":{"login":"tomivirkki","id":1222264,"avatar_url":"https://avatars.githubusercontent.com/u/1222264?v=3","gravatar_id":"","url":"https://api.github.com/users/tomivirkki","html_url":"https://github.com/tomivirkki","followers_url":"https://api.github.com/users/tomivirkki/followers","following_url":"https://api.github.com/users/tomivirkki/following{/other_user}","gists_url":"https://api.github.com/users/tomivirkki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomivirkki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomivirkki/subscriptions","organizations_url":"https://api.github.com/users/tomivirkki/orgs","repos_url":"https://api.github.com/users/tomivirkki/repos","events_url":"https://api.github.com/users/tomivirkki/events{/privacy}","received_events_url":"https://api.github.com/users/tomivirkki/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vaadin/vaadin-grid/labels/in%20review","name":"in review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-11-18T13:29:55Z","updated_at":"2015-11-19T06:49:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-grid/pulls/263","html_url":"https://github.com/vaadin/vaadin-grid/pull/263","diff_url":"https://github.com/vaadin/vaadin-grid/pull/263.diff","patch_url":"https://github.com/vaadin/vaadin-grid/pull/263.patch"},"body":"Fixes #232 \r\n\r\nRelease notes:\r\n- \"header-text\" attribute removed from \"col\" element, \"thead\" is the only way to customize the column headers declaratively (#232)\r\n- grid.columns[...].headerContent was removed. Instead, header.getCell(...).content API can be used to access the default header row cell content (#232)\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-grid/263)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/comments/157969445","html_url":"https://github.com/vaadin/vaadin-grid/pull/263#issuecomment-157969445","issue_url":"https://api.github.com/repos/vaadin/vaadin-grid/issues/263","id":157969445,"user":{"login":"tomivirkki","id":1222264,"avatar_url":"https://avatars.githubusercontent.com/u/1222264?v=3","gravatar_id":"","url":"https://api.github.com/users/tomivirkki","html_url":"https://github.com/tomivirkki","followers_url":"https://api.github.com/users/tomivirkki/followers","following_url":"https://api.github.com/users/tomivirkki/following{/other_user}","gists_url":"https://api.github.com/users/tomivirkki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomivirkki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomivirkki/subscriptions","organizations_url":"https://api.github.com/users/tomivirkki/orgs","repos_url":"https://api.github.com/users/tomivirkki/repos","events_url":"https://api.github.com/users/tomivirkki/events{/privacy}","received_events_url":"https://api.github.com/users/tomivirkki/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T06:49:38Z","updated_at":"2015-11-19T06:49:38Z","body":"\n\n\n\n\n\n\n\n_[demo/details.html, line 69 \\[r1\\]](https://reviewable.io:443/reviews/vaadin/vaadin-grid/263#-K3PmOp-z002hbt1eLza-r1-69:-K3TUmIqGJ5ESYR0k71T:1172069069) ([raw file](https://github.com/vaadin/vaadin-grid/blob/28f6ecdc44b7ace7675a2246d601017beab384de/demo/details.html#L69)):_\nWell no, I was kind of under the impression that thead shouldn't be added to demos that already define names and that their formatting is left for #251 to handle. Was there something I missed?\n\n---\n\n\n_Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/vaadin/vaadin-grid/263)_\n<!-- Sent from Reviewable.io -->\n"}}