{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/comments/36114029","id":36114029,"diff_hunk":"@@ -2,9 +2,17 @@ import cmdm = require('../lib/tfcommand');\n import cm = require('../lib/common');\n import buildifm = require('vso-node-api/interfaces/BuildInterfaces');\n import buildm = require('vso-node-api/BuildApi');\n+import parameternames = require('../lib/parameternames');","path":"app/exec/build-list.ts","position":4,"original_position":4,"commit_id":"2c01eec45d36294b2ad973b2c7dadbeeaac6df85","original_commit_id":"2c01eec45d36294b2ad973b2c7dadbeeaac6df85","user":{"login":"bryanmacfarlane","id":919564,"avatar_url":"https://avatars.githubusercontent.com/u/919564?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanmacfarlane","html_url":"https://github.com/bryanmacfarlane","followers_url":"https://api.github.com/users/bryanmacfarlane/followers","following_url":"https://api.github.com/users/bryanmacfarlane/following{/other_user}","gists_url":"https://api.github.com/users/bryanmacfarlane/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanmacfarlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanmacfarlane/subscriptions","organizations_url":"https://api.github.com/users/bryanmacfarlane/orgs","repos_url":"https://api.github.com/users/bryanmacfarlane/repos","events_url":"https://api.github.com/users/bryanmacfarlane/events{/privacy}","received_events_url":"https://api.github.com/users/bryanmacfarlane/received_events","type":"User","site_admin":false},"body":"nit - change to 'params' - makes code downstream not so verbose","created_at":"2015-08-03T18:19:50Z","updated_at":"2015-08-03T18:19:50Z","html_url":"https://github.com/Microsoft/tfs-cli/pull/2#discussion_r36114029","pull_request_url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/comments/36114029"},"html":{"href":"https://github.com/Microsoft/tfs-cli/pull/2#discussion_r36114029"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/2","id":41490560,"html_url":"https://github.com/Microsoft/tfs-cli/pull/2","diff_url":"https://github.com/Microsoft/tfs-cli/pull/2.diff","patch_url":"https://github.com/Microsoft/tfs-cli/pull/2.patch","issue_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues/2","number":2,"state":"open","locked":false,"title":"upload and delete build tasks, list --all, error handling, some refactoring","user":{"login":"teddyward","id":5324890,"avatar_url":"https://avatars.githubusercontent.com/u/5324890?v=3","gravatar_id":"","url":"https://api.github.com/users/teddyward","html_url":"https://github.com/teddyward","followers_url":"https://api.github.com/users/teddyward/followers","following_url":"https://api.github.com/users/teddyward/following{/other_user}","gists_url":"https://api.github.com/users/teddyward/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyward/subscriptions","organizations_url":"https://api.github.com/users/teddyward/orgs","repos_url":"https://api.github.com/users/teddyward/repos","events_url":"https://api.github.com/users/teddyward/events{/privacy}","received_events_url":"https://api.github.com/users/teddyward/received_events","type":"User","site_admin":false},"body":"opened a new pull request because the old one was getting ugly with line number changes and there are more major changes now.  I think I've dealt with the error handling issues from the first pull request.  Also added the list --all option to build-tasks-list and tried to un-hardcode argument names / formatting out to make commands more consistent.\r\n\r\nI can probably refactor the individual exec() methods a lot but wanted to make sure the overall structure was okay first.  Some refactoring will require changing controller methods -- eg I think we want listing only the newest version of build tasks to be an option on the getTaskDefinitions() server operation.\r\n\r\nThanks for the feedback on the old PR... hoping this one is a bit more complete","created_at":"2015-08-03T17:33:53Z","updated_at":"2015-08-03T18:19:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5acb0d3ec125a1f1ae35413b5e08c7ab9c20f940","assignee":{"login":"bryanmacfarlane","id":919564,"avatar_url":"https://avatars.githubusercontent.com/u/919564?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanmacfarlane","html_url":"https://github.com/bryanmacfarlane","followers_url":"https://api.github.com/users/bryanmacfarlane/followers","following_url":"https://api.github.com/users/bryanmacfarlane/following{/other_user}","gists_url":"https://api.github.com/users/bryanmacfarlane/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanmacfarlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanmacfarlane/subscriptions","organizations_url":"https://api.github.com/users/bryanmacfarlane/orgs","repos_url":"https://api.github.com/users/bryanmacfarlane/repos","events_url":"https://api.github.com/users/bryanmacfarlane/events{/privacy}","received_events_url":"https://api.github.com/users/bryanmacfarlane/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues/2/comments","statuses_url":"https://api.github.com/repos/Microsoft/tfs-cli/statuses/2c01eec45d36294b2ad973b2c7dadbeeaac6df85","head":{"label":"Microsoft:users/teddyward/buildtasks","ref":"users/teddyward/buildtasks","sha":"2c01eec45d36294b2ad973b2c7dadbeeaac6df85","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":39497254,"name":"tfs-cli","full_name":"Microsoft/tfs-cli","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/tfs-cli","description":"TFS Cross Platform Command Line","fork":false,"url":"https://api.github.com/repos/Microsoft/tfs-cli","forks_url":"https://api.github.com/repos/Microsoft/tfs-cli/forks","keys_url":"https://api.github.com/repos/Microsoft/tfs-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/tfs-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/tfs-cli/teams","hooks_url":"https://api.github.com/repos/Microsoft/tfs-cli/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/tfs-cli/events","assignees_url":"https://api.github.com/repos/Microsoft/tfs-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/tfs-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/tfs-cli/tags","blobs_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/tfs-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/tfs-cli/languages","stargazers_url":"https://api.github.com/repos/Microsoft/tfs-cli/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/tfs-cli/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/tfs-cli/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/tfs-cli/subscription","commits_url":"https://api.github.com/repos/Microsoft/tfs-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/tfs-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/tfs-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/tfs-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/tfs-cli/merges","archive_url":"https://api.github.com/repos/Microsoft/tfs-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/tfs-cli/downloads","issues_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/tfs-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/tfs-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/tfs-cli/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/tfs-cli/releases{/id}","created_at":"2015-07-22T09:23:42Z","updated_at":"2015-08-03T17:23:33Z","pushed_at":"2015-08-03T17:33:54Z","git_url":"git://github.com/Microsoft/tfs-cli.git","ssh_url":"git@github.com:Microsoft/tfs-cli.git","clone_url":"https://github.com/Microsoft/tfs-cli.git","svn_url":"https://github.com/Microsoft/tfs-cli","homepage":null,"size":296,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"349afb0e4f2afae33c72b1c9b90f01de87a80111","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":39497254,"name":"tfs-cli","full_name":"Microsoft/tfs-cli","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/tfs-cli","description":"TFS Cross Platform Command Line","fork":false,"url":"https://api.github.com/repos/Microsoft/tfs-cli","forks_url":"https://api.github.com/repos/Microsoft/tfs-cli/forks","keys_url":"https://api.github.com/repos/Microsoft/tfs-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/tfs-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/tfs-cli/teams","hooks_url":"https://api.github.com/repos/Microsoft/tfs-cli/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/tfs-cli/events","assignees_url":"https://api.github.com/repos/Microsoft/tfs-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/tfs-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/tfs-cli/tags","blobs_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/tfs-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/tfs-cli/languages","stargazers_url":"https://api.github.com/repos/Microsoft/tfs-cli/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/tfs-cli/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/tfs-cli/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/tfs-cli/subscription","commits_url":"https://api.github.com/repos/Microsoft/tfs-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/tfs-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/tfs-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/tfs-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/tfs-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/tfs-cli/merges","archive_url":"https://api.github.com/repos/Microsoft/tfs-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/tfs-cli/downloads","issues_url":"https://api.github.com/repos/Microsoft/tfs-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/tfs-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/tfs-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/tfs-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/tfs-cli/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/tfs-cli/releases{/id}","created_at":"2015-07-22T09:23:42Z","updated_at":"2015-08-03T17:23:33Z","pushed_at":"2015-08-03T17:33:54Z","git_url":"git://github.com/Microsoft/tfs-cli.git","ssh_url":"git@github.com:Microsoft/tfs-cli.git","clone_url":"https://github.com/Microsoft/tfs-cli.git","svn_url":"https://github.com/Microsoft/tfs-cli","homepage":null,"size":296,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/2"},"html":{"href":"https://github.com/Microsoft/tfs-cli/pull/2"},"issue":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/issues/2"},"comments":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/tfs-cli/statuses/2c01eec45d36294b2ad973b2c7dadbeeaac6df85"}}}}