{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/comments/47300186","id":47300186,"diff_hunk":"@@ -1858,6 +1858,43 @@ _dispatch_timers_get_delay(uint64_t nows[], struct dispatch_timer_s timer[],\n \treturn ridx;\n }\n \n+\n+#ifdef __linux__ \n+// in linux we map the _dispatch_kevent_qos_s  to struct kevent instead of struct kevent64.\n+// we loose the kevent.ext[] members and the time out is based on relavite msec based time\n+// vs. absolute nsec based time. For now we make the adjustments right here until the solution\n+// to either extend libkqueue with a proper kevent64 API or removing kevent all together \n+// and move to a lower API (e.g. epoll or kernel_module. Also leeway is ignored.\n+\n+static void \n+kevent_set_delay(_dispatch_kevent_qos_s *ke, uint64_t delay,uint64_t leeway, uint64_t nows[]) ","path":"src/source.c","position":13,"original_position":13,"commit_id":"d76ef08fe157f2b0874bb99096127ce31f17e338","original_commit_id":"d76ef08fe157f2b0874bb99096127ce31f17e338","user":{"login":"MadCoder","id":44708,"avatar_url":"https://avatars.githubusercontent.com/u/44708?v=3","gravatar_id":"","url":"https://api.github.com/users/MadCoder","html_url":"https://github.com/MadCoder","followers_url":"https://api.github.com/users/MadCoder/followers","following_url":"https://api.github.com/users/MadCoder/following{/other_user}","gists_url":"https://api.github.com/users/MadCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MadCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadCoder/subscriptions","organizations_url":"https://api.github.com/users/MadCoder/orgs","repos_url":"https://api.github.com/users/MadCoder/repos","events_url":"https://api.github.com/users/MadCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MadCoder/received_events","type":"User","site_admin":false},"body":"This is about timer so should have timer in the name.\r\nalso to match the naming style of the file this function should be\r\n\r\n`_dispatch_kevent_timer_set_delay`.\r\nplease have a space after the commas, and wrap the prototype if it doesn't fit on 80 colums","created_at":"2015-12-10T23:02:12Z","updated_at":"2015-12-10T23:02:12Z","html_url":"https://github.com/apple/swift-corelibs-libdispatch/pull/8#discussion_r47300186","pull_request_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/comments/47300186"},"html":{"href":"https://github.com/apple/swift-corelibs-libdispatch/pull/8#discussion_r47300186"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/8","id":53188879,"html_url":"https://github.com/apple/swift-corelibs-libdispatch/pull/8","diff_url":"https://github.com/apple/swift-corelibs-libdispatch/pull/8.diff","patch_url":"https://github.com/apple/swift-corelibs-libdispatch/pull/8.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/8","number":8,"state":"open","locked":false,"title":"Linux port hdd timers2","user":{"login":"frankeh","id":15785601,"avatar_url":"https://avatars.githubusercontent.com/u/15785601?v=3","gravatar_id":"","url":"https://api.github.com/users/frankeh","html_url":"https://github.com/frankeh","followers_url":"https://api.github.com/users/frankeh/followers","following_url":"https://api.github.com/users/frankeh/following{/other_user}","gists_url":"https://api.github.com/users/frankeh/gists{/gist_id}","starred_url":"https://api.github.com/users/frankeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankeh/subscriptions","organizations_url":"https://api.github.com/users/frankeh/orgs","repos_url":"https://api.github.com/users/frankeh/repos","events_url":"https://api.github.com/users/frankeh/events{/privacy}","received_events_url":"https://api.github.com/users/frankeh/received_events","type":"User","site_admin":false},"body":"Additional changes to handle Timers using kevent properly.\r\n","created_at":"2015-12-09T22:37:21Z","updated_at":"2015-12-10T23:02:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"260adbeb97d05339ff120d45b303133f8f334764","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/8/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/8/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/8/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/statuses/d76ef08fe157f2b0874bb99096127ce31f17e338","head":{"label":"dgrove-oss:linux-port-hdd-timers2","ref":"linux-port-hdd-timers2","sha":"d76ef08fe157f2b0874bb99096127ce31f17e338","user":{"login":"dgrove-oss","id":5099100,"avatar_url":"https://avatars.githubusercontent.com/u/5099100?v=3","gravatar_id":"","url":"https://api.github.com/users/dgrove-oss","html_url":"https://github.com/dgrove-oss","followers_url":"https://api.github.com/users/dgrove-oss/followers","following_url":"https://api.github.com/users/dgrove-oss/following{/other_user}","gists_url":"https://api.github.com/users/dgrove-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrove-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrove-oss/subscriptions","organizations_url":"https://api.github.com/users/dgrove-oss/orgs","repos_url":"https://api.github.com/users/dgrove-oss/repos","events_url":"https://api.github.com/users/dgrove-oss/events{/privacy}","received_events_url":"https://api.github.com/users/dgrove-oss/received_events","type":"User","site_admin":false},"repo":{"id":47428328,"name":"swift-corelibs-libdispatch","full_name":"dgrove-oss/swift-corelibs-libdispatch","owner":{"login":"dgrove-oss","id":5099100,"avatar_url":"https://avatars.githubusercontent.com/u/5099100?v=3","gravatar_id":"","url":"https://api.github.com/users/dgrove-oss","html_url":"https://github.com/dgrove-oss","followers_url":"https://api.github.com/users/dgrove-oss/followers","following_url":"https://api.github.com/users/dgrove-oss/following{/other_user}","gists_url":"https://api.github.com/users/dgrove-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrove-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrove-oss/subscriptions","organizations_url":"https://api.github.com/users/dgrove-oss/orgs","repos_url":"https://api.github.com/users/dgrove-oss/repos","events_url":"https://api.github.com/users/dgrove-oss/events{/privacy}","received_events_url":"https://api.github.com/users/dgrove-oss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgrove-oss/swift-corelibs-libdispatch","description":"The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware","fork":true,"url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch","forks_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/forks","keys_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/teams","hooks_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/hooks","issue_events_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/issues/events{/number}","events_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/events","assignees_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/assignees{/user}","branches_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/branches{/branch}","tags_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/tags","blobs_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/statuses/{sha}","languages_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/languages","stargazers_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/stargazers","contributors_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/contributors","subscribers_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/subscribers","subscription_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/subscription","commits_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/contents/{+path}","compare_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/merges","archive_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/downloads","issues_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/issues{/number}","pulls_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/pulls{/number}","milestones_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/milestones{/number}","notifications_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/labels{/name}","releases_url":"https://api.github.com/repos/dgrove-oss/swift-corelibs-libdispatch/releases{/id}","created_at":"2015-12-04T20:54:44Z","updated_at":"2015-12-05T08:52:18Z","pushed_at":"2015-12-10T22:59:38Z","git_url":"git://github.com/dgrove-oss/swift-corelibs-libdispatch.git","ssh_url":"git@github.com:dgrove-oss/swift-corelibs-libdispatch.git","clone_url":"https://github.com/dgrove-oss/swift-corelibs-libdispatch.git","svn_url":"https://github.com/dgrove-oss/swift-corelibs-libdispatch","homepage":"swift.org","size":626,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"linux-port-hdd"}},"base":{"label":"apple:master","ref":"master","sha":"14f0250f75aa1e4d80bc58f8c55eec95bfadb696","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863965,"name":"swift-corelibs-libdispatch","full_name":"apple/swift-corelibs-libdispatch","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-corelibs-libdispatch","description":"The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch","forks_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/releases{/id}","created_at":"2015-11-09T20:13:55Z","updated_at":"2015-12-10T21:54:55Z","pushed_at":"2015-12-10T22:56:21Z","git_url":"git://github.com/apple/swift-corelibs-libdispatch.git","ssh_url":"git@github.com:apple/swift-corelibs-libdispatch.git","clone_url":"https://github.com/apple/swift-corelibs-libdispatch.git","svn_url":"https://github.com/apple/swift-corelibs-libdispatch","homepage":"swift.org","size":660,"stargazers_count":511,"watchers_count":511,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":1,"forks":59,"open_issues":1,"watchers":511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/8"},"html":{"href":"https://github.com/apple/swift-corelibs-libdispatch/pull/8"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/8"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/statuses/d76ef08fe157f2b0874bb99096127ce31f17e338"}}}}