{"action":"created","issue":{"url":"https://api.github.com/repos/rackerlabs/otter/issues/1023","labels_url":"https://api.github.com/repos/rackerlabs/otter/issues/1023/labels{/name}","comments_url":"https://api.github.com/repos/rackerlabs/otter/issues/1023/comments","events_url":"https://api.github.com/repos/rackerlabs/otter/issues/1023/events","html_url":"https://github.com/rackerlabs/otter/pull/1023","id":56104887,"number":1023,"title":"Excise add_content_only","user":{"login":"lvh","id":97816,"avatar_url":"https://avatars.githubusercontent.com/u/97816?v=3","gravatar_id":"","url":"https://api.github.com/users/lvh","html_url":"https://github.com/lvh","followers_url":"https://api.github.com/users/lvh/followers","following_url":"https://api.github.com/users/lvh/following{/other_user}","gists_url":"https://api.github.com/users/lvh/gists{/gist_id}","starred_url":"https://api.github.com/users/lvh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvh/subscriptions","organizations_url":"https://api.github.com/users/lvh/orgs","repos_url":"https://api.github.com/users/lvh/repos","events_url":"https://api.github.com/users/lvh/events{/privacy}","received_events_url":"https://api.github.com/users/lvh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-01-31T00:56:56Z","updated_at":"2015-01-31T17:58:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rackerlabs/otter/pulls/1023","html_url":"https://github.com/rackerlabs/otter/pull/1023","diff_url":"https://github.com/rackerlabs/otter/pull/1023.diff","patch_url":"https://github.com/rackerlabs/otter/pull/1023.patch"},"body":"Note that this does not yet *remove* `add_content_only`. If people feel that's appropriate, I'd be happy to do so in a different PR. All it does is remove it from the default `service_request` decorator stack.\r\n\r\nWhile this changes the type of any `ServiceRequest` effect, it turns out we don't really use the results on those effects yet, so it doesn't matter. The only functions that do use the result (`_rcv3_check_bulk_delete`, `_clb_check_bulk_delete`) already assumed that it would be of the shape that this PR makes it."},"comment":{"url":"https://api.github.com/repos/rackerlabs/otter/issues/comments/72328333","html_url":"https://github.com/rackerlabs/otter/pull/1023#issuecomment-72328333","issue_url":"https://api.github.com/repos/rackerlabs/otter/issues/1023","id":72328333,"user":{"login":"lvh","id":97816,"avatar_url":"https://avatars.githubusercontent.com/u/97816?v=3","gravatar_id":"","url":"https://api.github.com/users/lvh","html_url":"https://github.com/lvh","followers_url":"https://api.github.com/users/lvh/followers","following_url":"https://api.github.com/users/lvh/following{/other_user}","gists_url":"https://api.github.com/users/lvh/gists{/gist_id}","starred_url":"https://api.github.com/users/lvh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvh/subscriptions","organizations_url":"https://api.github.com/users/lvh/orgs","repos_url":"https://api.github.com/users/lvh/repos","events_url":"https://api.github.com/users/lvh/events{/privacy}","received_events_url":"https://api.github.com/users/lvh/received_events","type":"User","site_admin":false},"created_at":"2015-01-31T17:58:59Z","updated_at":"2015-01-31T17:58:59Z","body":"Yeah, that's what I didn't hit merge just yet ;-) Also note that this has nothing to do with `success_pred` by the way; it's about the type of the Effect.\r\n"}}