{"action":"opened","number":1279,"pull_request":{"url":"https://api.github.com/repos/OpenMeridian/Meridian59/pulls/1279","id":50027545,"html_url":"https://github.com/OpenMeridian/Meridian59/pull/1279","diff_url":"https://github.com/OpenMeridian/Meridian59/pull/1279.diff","patch_url":"https://github.com/OpenMeridian/Meridian59/pull/1279.patch","issue_url":"https://api.github.com/repos/OpenMeridian/Meridian59/issues/1279","number":1279,"state":"open","locked":false,"title":"Fixes for handling Spellitems in Set/Loadout, add abstract parent classes for Robe and Shirt.","user":{"login":"skittles1","id":4743083,"avatar_url":"https://avatars.githubusercontent.com/u/4743083?v=3","gravatar_id":"","url":"https://api.github.com/users/skittles1","html_url":"https://github.com/skittles1","followers_url":"https://api.github.com/users/skittles1/followers","following_url":"https://api.github.com/users/skittles1/following{/other_user}","gists_url":"https://api.github.com/users/skittles1/gists{/gist_id}","starred_url":"https://api.github.com/users/skittles1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skittles1/subscriptions","organizations_url":"https://api.github.com/users/skittles1/orgs","repos_url":"https://api.github.com/users/skittles1/repos","events_url":"https://api.github.com/users/skittles1/events{/privacy}","received_events_url":"https://api.github.com/users/skittles1/received_events","type":"User","site_admin":false},"body":"* Loadout will now handle SpellItems correctly - the number of charges on each SpellItem in the player's inventory is recorded when Set is cast, and Loadout will try to match these when stocking from the chest. SpellItems are replenished from largest stack to smallest (according to the loadout list) but if players have a larger stack already, they will end up with extra potions after the loadout. SpellItems are not combined when pulled into player's inventory beyond that necessary to match the loadout list.\r\n* Streamlined the \"sorted scoreboard\" code in util.kod and renamed messages to AddToSortedList and RemoveFromSortedList to reflect what the messages are for.\r\n* Added abstract classes for Robe (RobeBase) and Shirt (ShirtBase) to match the implementation of other items. Would have preferred to keep the existing parent names and use new child ones, but this would cause severe issues on live servers.\r\n* Fixed up handling of SpellItem weight/piHits when splitting spellitems. Added GetNumberCanHold to SpellItem as there are instances where these should be handled in the same manner as number items.\r\n* Code cleanup in SpellItem/SpellItemSplit.","created_at":"2015-11-07T03:52:37Z","updated_at":"2015-11-07T03:52:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenMeridian/Meridian59/pulls/1279/commits","review_comments_url":"https://api.github.com/repos/OpenMeridian/Meridian59/pulls/1279/comments","review_comment_url":"https://api.github.com/repos/OpenMeridian/Meridian59/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMeridian/Meridian59/issues/1279/comments","statuses_url":"https://api.github.com/repos/OpenMeridian/Meridian59/statuses/d2e6b441863e6cb03d93d3a4553ad0e36a0ee32a","head":{"label":"skittles1:loadoutspellitem","ref":"loadoutspellitem","sha":"d2e6b441863e6cb03d93d3a4553ad0e36a0ee32a","user":{"login":"skittles1","id":4743083,"avatar_url":"https://avatars.githubusercontent.com/u/4743083?v=3","gravatar_id":"","url":"https://api.github.com/users/skittles1","html_url":"https://github.com/skittles1","followers_url":"https://api.github.com/users/skittles1/followers","following_url":"https://api.github.com/users/skittles1/following{/other_user}","gists_url":"https://api.github.com/users/skittles1/gists{/gist_id}","starred_url":"https://api.github.com/users/skittles1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skittles1/subscriptions","organizations_url":"https://api.github.com/users/skittles1/orgs","repos_url":"https://api.github.com/users/skittles1/repos","events_url":"https://api.github.com/users/skittles1/events{/privacy}","received_events_url":"https://api.github.com/users/skittles1/received_events","type":"User","site_admin":false},"repo":{"id":16250474,"name":"Meridian59_103","full_name":"skittles1/Meridian59_103","owner":{"login":"skittles1","id":4743083,"avatar_url":"https://avatars.githubusercontent.com/u/4743083?v=3","gravatar_id":"","url":"https://api.github.com/users/skittles1","html_url":"https://github.com/skittles1","followers_url":"https://api.github.com/users/skittles1/followers","following_url":"https://api.github.com/users/skittles1/following{/other_user}","gists_url":"https://api.github.com/users/skittles1/gists{/gist_id}","starred_url":"https://api.github.com/users/skittles1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skittles1/subscriptions","organizations_url":"https://api.github.com/users/skittles1/orgs","repos_url":"https://api.github.com/users/skittles1/repos","events_url":"https://api.github.com/users/skittles1/events{/privacy}","received_events_url":"https://api.github.com/users/skittles1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skittles1/Meridian59_103","description":"The MMORPG Meridian 59 - Server 103","fork":true,"url":"https://api.github.com/repos/skittles1/Meridian59_103","forks_url":"https://api.github.com/repos/skittles1/Meridian59_103/forks","keys_url":"https://api.github.com/repos/skittles1/Meridian59_103/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skittles1/Meridian59_103/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skittles1/Meridian59_103/teams","hooks_url":"https://api.github.com/repos/skittles1/Meridian59_103/hooks","issue_events_url":"https://api.github.com/repos/skittles1/Meridian59_103/issues/events{/number}","events_url":"https://api.github.com/repos/skittles1/Meridian59_103/events","assignees_url":"https://api.github.com/repos/skittles1/Meridian59_103/assignees{/user}","branches_url":"https://api.github.com/repos/skittles1/Meridian59_103/branches{/branch}","tags_url":"https://api.github.com/repos/skittles1/Meridian59_103/tags","blobs_url":"https://api.github.com/repos/skittles1/Meridian59_103/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skittles1/Meridian59_103/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skittles1/Meridian59_103/git/refs{/sha}","trees_url":"https://api.github.com/repos/skittles1/Meridian59_103/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skittles1/Meridian59_103/statuses/{sha}","languages_url":"https://api.github.com/repos/skittles1/Meridian59_103/languages","stargazers_url":"https://api.github.com/repos/skittles1/Meridian59_103/stargazers","contributors_url":"https://api.github.com/repos/skittles1/Meridian59_103/contributors","subscribers_url":"https://api.github.com/repos/skittles1/Meridian59_103/subscribers","subscription_url":"https://api.github.com/repos/skittles1/Meridian59_103/subscription","commits_url":"https://api.github.com/repos/skittles1/Meridian59_103/commits{/sha}","git_commits_url":"https://api.github.com/repos/skittles1/Meridian59_103/git/commits{/sha}","comments_url":"https://api.github.com/repos/skittles1/Meridian59_103/comments{/number}","issue_comment_url":"https://api.github.com/repos/skittles1/Meridian59_103/issues/comments{/number}","contents_url":"https://api.github.com/repos/skittles1/Meridian59_103/contents/{+path}","compare_url":"https://api.github.com/repos/skittles1/Meridian59_103/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skittles1/Meridian59_103/merges","archive_url":"https://api.github.com/repos/skittles1/Meridian59_103/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skittles1/Meridian59_103/downloads","issues_url":"https://api.github.com/repos/skittles1/Meridian59_103/issues{/number}","pulls_url":"https://api.github.com/repos/skittles1/Meridian59_103/pulls{/number}","milestones_url":"https://api.github.com/repos/skittles1/Meridian59_103/milestones{/number}","notifications_url":"https://api.github.com/repos/skittles1/Meridian59_103/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skittles1/Meridian59_103/labels{/name}","releases_url":"https://api.github.com/repos/skittles1/Meridian59_103/releases{/id}","created_at":"2014-01-26T09:26:09Z","updated_at":"2015-10-16T18:17:41Z","pushed_at":"2015-11-07T03:43:50Z","git_url":"git://github.com/skittles1/Meridian59_103.git","ssh_url":"git@github.com:skittles1/Meridian59_103.git","clone_url":"https://github.com/skittles1/Meridian59_103.git","svn_url":"https://github.com/skittles1/Meridian59_103","homepage":"openmeridian.org","size":170109,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"OpenMeridian:develop","ref":"develop","sha":"3f4ea901a69fb5583fae835bb742831749f61704","user":{"login":"OpenMeridian","id":8811562,"avatar_url":"https://avatars.githubusercontent.com/u/8811562?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMeridian","html_url":"https://github.com/OpenMeridian","followers_url":"https://api.github.com/users/OpenMeridian/followers","following_url":"https://api.github.com/users/OpenMeridian/following{/other_user}","gists_url":"https://api.github.com/users/OpenMeridian/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMeridian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMeridian/subscriptions","organizations_url":"https://api.github.com/users/OpenMeridian/orgs","repos_url":"https://api.github.com/users/OpenMeridian/repos","events_url":"https://api.github.com/users/OpenMeridian/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMeridian/received_events","type":"Organization","site_admin":false},"repo":{"id":14400546,"name":"Meridian59","full_name":"OpenMeridian/Meridian59","owner":{"login":"OpenMeridian","id":8811562,"avatar_url":"https://avatars.githubusercontent.com/u/8811562?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMeridian","html_url":"https://github.com/OpenMeridian","followers_url":"https://api.github.com/users/OpenMeridian/followers","following_url":"https://api.github.com/users/OpenMeridian/following{/other_user}","gists_url":"https://api.github.com/users/OpenMeridian/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMeridian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMeridian/subscriptions","organizations_url":"https://api.github.com/users/OpenMeridian/orgs","repos_url":"https://api.github.com/users/OpenMeridian/repos","events_url":"https://api.github.com/users/OpenMeridian/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMeridian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMeridian/Meridian59","description":"The MMORPG Meridian 59 - Server 103","fork":true,"url":"https://api.github.com/repos/OpenMeridian/Meridian59","forks_url":"https://api.github.com/repos/OpenMeridian/Meridian59/forks","keys_url":"https://api.github.com/repos/OpenMeridian/Meridian59/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMeridian/Meridian59/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMeridian/Meridian59/teams","hooks_url":"https://api.github.com/repos/OpenMeridian/Meridian59/hooks","issue_events_url":"https://api.github.com/repos/OpenMeridian/Meridian59/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMeridian/Meridian59/events","assignees_url":"https://api.github.com/repos/OpenMeridian/Meridian59/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMeridian/Meridian59/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMeridian/Meridian59/tags","blobs_url":"https://api.github.com/repos/OpenMeridian/Meridian59/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMeridian/Meridian59/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMeridian/Meridian59/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMeridian/Meridian59/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMeridian/Meridian59/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMeridian/Meridian59/languages","stargazers_url":"https://api.github.com/repos/OpenMeridian/Meridian59/stargazers","contributors_url":"https://api.github.com/repos/OpenMeridian/Meridian59/contributors","subscribers_url":"https://api.github.com/repos/OpenMeridian/Meridian59/subscribers","subscription_url":"https://api.github.com/repos/OpenMeridian/Meridian59/subscription","commits_url":"https://api.github.com/repos/OpenMeridian/Meridian59/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMeridian/Meridian59/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMeridian/Meridian59/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMeridian/Meridian59/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMeridian/Meridian59/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMeridian/Meridian59/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMeridian/Meridian59/merges","archive_url":"https://api.github.com/repos/OpenMeridian/Meridian59/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMeridian/Meridian59/downloads","issues_url":"https://api.github.com/repos/OpenMeridian/Meridian59/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMeridian/Meridian59/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMeridian/Meridian59/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMeridian/Meridian59/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMeridian/Meridian59/labels{/name}","releases_url":"https://api.github.com/repos/OpenMeridian/Meridian59/releases{/id}","created_at":"2013-11-14T16:29:15Z","updated_at":"2015-11-04T18:35:25Z","pushed_at":"2015-11-06T15:26:29Z","git_url":"git://github.com/OpenMeridian/Meridian59.git","ssh_url":"git@github.com:OpenMeridian/Meridian59.git","clone_url":"https://github.com/OpenMeridian/Meridian59.git","svn_url":"https://github.com/OpenMeridian/Meridian59","homepage":"openmeridian.org","size":303508,"stargazers_count":31,"watchers_count":31,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":52,"mirror_url":null,"open_issues_count":103,"forks":52,"open_issues":103,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMeridian/Meridian59/pulls/1279"},"html":{"href":"https://github.com/OpenMeridian/Meridian59/pull/1279"},"issue":{"href":"https://api.github.com/repos/OpenMeridian/Meridian59/issues/1279"},"comments":{"href":"https://api.github.com/repos/OpenMeridian/Meridian59/issues/1279/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMeridian/Meridian59/pulls/1279/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMeridian/Meridian59/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMeridian/Meridian59/pulls/1279/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMeridian/Meridian59/statuses/d2e6b441863e6cb03d93d3a4553ad0e36a0ee32a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":605,"deletions":297,"changed_files":34}}