{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/1022","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/1022/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/1022/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/1022/events","html_url":"https://github.com/dotnet/corefx/issues/1022","id":58954260,"number":1022,"title":"MSBuild consistency in casing boolean properties","user":{"login":"krwq","id":660048,"avatar_url":"https://avatars.githubusercontent.com/u/660048?v=3","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-02-25T19:15:25Z","updated_at":"2015-02-26T17:43:15Z","closed_at":null,"body":"MSBuild properties are case sensitive.\r\nThe \"false\"/\"true\" vs \"False\"/\"True\"\r\n\r\nWhat do we prefer?\r\n\r\nIt looks like we don't have any standards with this and I saw various places in the targets which mix two different casings even for the same properties.\r\n\r\nI believe we should unify this\r\n\r\nExamples:\r\nsrc\\System.Collections.Immutable\\src\\System.Collections.Immutable.csproj (lowercase):\r\n```\r\n  <PropertyGroup Condition=\" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' \">\r\n    <DebugSymbols>true</DebugSymbols>\r\n    <DebugType>full</DebugType>\r\n    <Optimize>false</Optimize>\r\n    <DefineConstants>DEBUG;TRACE</DefineConstants>\r\n    <ErrorReport>prompt</ErrorReport>\r\n    <WarningLevel>4</WarningLevel>\r\n    <Prefer32Bit>false</Prefer32Bit>\r\n    <CodeAnalysisRuleSet>System.Collections.Immutable.ruleset</CodeAnalysisRuleSet>\r\n  </PropertyGroup>\r\n```\r\nand the same project in the bottom:\r\n```\r\n    <Compile Include=\"Strings.Designer.cs\">\r\n      <AutoGen>True</AutoGen>\r\n      <DesignTime>True</DesignTime>\r\n      <DependentUpon>Strings.resx</DependentUpon>\r\n    </Compile>\r\n```\r\n\r\nsrc\\dirs.targets: (Look at the IsTestProject property and CLSCompliant condition):\r\nhttps://github.com/dotnet/corefx/blob/master/src/dir.targets#L94\r\n```\r\n <PropertyGroup>\r\n<IsTestProject Condition=\"'$(IsTestProject)'=='' And $(MSBuildProjectName.EndsWith('.Tests'))\">True</IsTestProject>\r\n<RunTestsForProject Condition=\"'$(RunTestsForProject)'=='' and '$(IsTestProject)'=='True'\">True</RunTestsForProject>\r\n<RunTestsForProject Condition=\"'$(SkipTests)'=='True'\">False</RunTestsForProject>\r\n<CLSCompliant Condition=\"'$(IsTestProject)'=='true'\">false</CLSCompliant>\r\n</PropertyGroup>\r\n```"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/76226383","html_url":"https://github.com/dotnet/corefx/issues/1022#issuecomment-76226383","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/1022","id":76226383,"user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"created_at":"2015-02-26T17:43:15Z","updated_at":"2015-02-26T17:43:15Z","body":"I also like lowercase but I've not seen and bugs causes by this (have you?) because I believe msbuild does case insensitive compares, it is just inconsistencies. I'm working on pulling a lot of these common targets into the build tools and as part of that I will try and clean up any of those casing issues as I do that work."}}