{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman/issues/2980","labels_url":"https://api.github.com/repos/theforeman/foreman/issues/2980/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2980/comments","events_url":"https://api.github.com/repos/theforeman/foreman/issues/2980/events","html_url":"https://github.com/theforeman/foreman/pull/2980","id":122492551,"number":2980,"title":"fixes #12805 - nested LV in puppetclass form are now validated","user":{"login":"unorthodoxgeek","id":706359,"avatar_url":"https://avatars.githubusercontent.com/u/706359?v=3","gravatar_id":"","url":"https://api.github.com/users/unorthodoxgeek","html_url":"https://github.com/unorthodoxgeek","followers_url":"https://api.github.com/users/unorthodoxgeek/followers","following_url":"https://api.github.com/users/unorthodoxgeek/following{/other_user}","gists_url":"https://api.github.com/users/unorthodoxgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/unorthodoxgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unorthodoxgeek/subscriptions","organizations_url":"https://api.github.com/users/unorthodoxgeek/orgs","repos_url":"https://api.github.com/users/unorthodoxgeek/repos","events_url":"https://api.github.com/users/unorthodoxgeek/events{/privacy}","received_events_url":"https://api.github.com/users/unorthodoxgeek/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/theforeman/foreman/labels/Waiting%20on%20contributor","name":"Waiting on contributor","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-16T12:18:38Z","updated_at":"2015-12-19T10:22:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2980","html_url":"https://github.com/theforeman/foreman/pull/2980","diff_url":"https://github.com/theforeman/foreman/pull/2980.diff","patch_url":"https://github.com/theforeman/foreman/pull/2980.patch"},"body":"Callbacks return false ONLY if they NEED to stop EVERYTHING else from\r\nrunning!\r\nDO NOT return false if you want to say \"this isn't valid\"\r\n\r\nI just spent three hours looking for a \"false\" value.\r\nThanks, whoever put it there :sob: "},"comment":{"url":"https://api.github.com/repos/theforeman/foreman/issues/comments/165972067","html_url":"https://github.com/theforeman/foreman/pull/2980#issuecomment-165972067","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2980","id":165972067,"user":{"login":"tbrisker","id":1540531,"avatar_url":"https://avatars.githubusercontent.com/u/1540531?v=3","gravatar_id":"","url":"https://api.github.com/users/tbrisker","html_url":"https://github.com/tbrisker","followers_url":"https://api.github.com/users/tbrisker/followers","following_url":"https://api.github.com/users/tbrisker/following{/other_user}","gists_url":"https://api.github.com/users/tbrisker/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrisker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrisker/subscriptions","organizations_url":"https://api.github.com/users/tbrisker/orgs","repos_url":"https://api.github.com/users/tbrisker/repos","events_url":"https://api.github.com/users/tbrisker/events{/privacy}","received_events_url":"https://api.github.com/users/tbrisker/received_events","type":"User","site_admin":false},"created_at":"2015-12-19T10:22:57Z","updated_at":"2015-12-19T10:22:57Z","body":"As a side note, looks like dhh finally realized this is silly behaviour - check out the last of the \"A few other highlights\" in Rails 5:\r\nhttp://weblog.rubyonrails.org/2015/12/18/Rails-5-0-beta1/\r\nMaybe if we start work on the Rails 5 migration now, we will finish it before Rails 6 comes out :wink: "}}