{"action":"created","comment":{"url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/comments/45455880","id":45455880,"diff_hunk":"@@ -11,8 +11,10 @@ ENV PATH=${PATH}:/opt/nodejs/bin\n WORKDIR /app\n \n ONBUILD RUN yum update -y && yum clean\n-ONBUILD COPY . /app/\n-ONBUILD RUN rm -rf node_modules && npm install\n+ONBUILD COPY package.json /app\n+ONBUILD RUN npm install\n+ONBUILD COPY . /app","path":"Dockerfile","position":8,"original_position":8,"commit_id":"8788d6182875d1e4fdd5dcd5ffc0048d05d30192","original_commit_id":"8788d6182875d1e4fdd5dcd5ffc0048d05d30192","user":{"login":"vaijab","id":1308018,"avatar_url":"https://avatars.githubusercontent.com/u/1308018?v=3","gravatar_id":"","url":"https://api.github.com/users/vaijab","html_url":"https://github.com/vaijab","followers_url":"https://api.github.com/users/vaijab/followers","following_url":"https://api.github.com/users/vaijab/following{/other_user}","gists_url":"https://api.github.com/users/vaijab/gists{/gist_id}","starred_url":"https://api.github.com/users/vaijab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaijab/subscriptions","organizations_url":"https://api.github.com/users/vaijab/orgs","repos_url":"https://api.github.com/users/vaijab/repos","events_url":"https://api.github.com/users/vaijab/events{/privacy}","received_events_url":"https://api.github.com/users/vaijab/received_events","type":"User","site_admin":false},"body":"This is still copying everything. #11 issue remains.","created_at":"2015-11-20T10:40:59Z","updated_at":"2015-11-20T10:40:59Z","html_url":"https://github.com/UKHomeOffice/docker-nodejs/pull/12#discussion_r45455880","pull_request_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/comments/45455880"},"html":{"href":"https://github.com/UKHomeOffice/docker-nodejs/pull/12#discussion_r45455880"},"pull_request":{"href":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/12","id":51341009,"html_url":"https://github.com/UKHomeOffice/docker-nodejs/pull/12","diff_url":"https://github.com/UKHomeOffice/docker-nodejs/pull/12.diff","patch_url":"https://github.com/UKHomeOffice/docker-nodejs/pull/12.patch","issue_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/issues/12","number":12,"state":"open","locked":false,"title":"Bring container in line with official image behaviour","user":{"login":"PurpleBooth","id":133327,"avatar_url":"https://avatars.githubusercontent.com/u/133327?v=3","gravatar_id":"","url":"https://api.github.com/users/PurpleBooth","html_url":"https://github.com/PurpleBooth","followers_url":"https://api.github.com/users/PurpleBooth/followers","following_url":"https://api.github.com/users/PurpleBooth/following{/other_user}","gists_url":"https://api.github.com/users/PurpleBooth/gists{/gist_id}","starred_url":"https://api.github.com/users/PurpleBooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PurpleBooth/subscriptions","organizations_url":"https://api.github.com/users/PurpleBooth/orgs","repos_url":"https://api.github.com/users/PurpleBooth/repos","events_url":"https://api.github.com/users/PurpleBooth/events{/privacy}","received_events_url":"https://api.github.com/users/PurpleBooth/received_events","type":"User","site_admin":false},"body":"The offical container builds like this\n\n```dockerfile\nFROM node:0.12.6\n\nRUN mkdir -p /usr/src/app\nWORKDIR /usr/src/app\n\nONBUILD COPY package.json /usr/src/app/\nONBUILD RUN npm install\nONBUILD COPY . /usr/src/app\n\nCMD [ \"npm\", \"start\" ]\n```\n\nThis pull request will bring this container inline with that.\n\nFixes #11","created_at":"2015-11-20T10:38:30Z","updated_at":"2015-11-20T10:40:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"260e1bfdfb579153ee6da79d28ec7f0fd7593105","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/12/commits","review_comments_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/12/comments","review_comment_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/issues/12/comments","statuses_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/statuses/8788d6182875d1e4fdd5dcd5ffc0048d05d30192","head":{"label":"UKHomeOffice:bring-container-inline-with-official-image","ref":"bring-container-inline-with-official-image","sha":"8788d6182875d1e4fdd5dcd5ffc0048d05d30192","user":{"login":"UKHomeOffice","id":3778081,"avatar_url":"https://avatars.githubusercontent.com/u/3778081?v=3","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":41105269,"name":"docker-nodejs","full_name":"UKHomeOffice/docker-nodejs","owner":{"login":"UKHomeOffice","id":3778081,"avatar_url":"https://avatars.githubusercontent.com/u/3778081?v=3","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UKHomeOffice/docker-nodejs","description":"","fork":false,"url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs","forks_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/releases{/id}","created_at":"2015-08-20T16:00:37Z","updated_at":"2015-09-14T15:35:35Z","pushed_at":"2015-11-20T10:40:25Z","git_url":"git://github.com/UKHomeOffice/docker-nodejs.git","ssh_url":"git@github.com:UKHomeOffice/docker-nodejs.git","clone_url":"https://github.com/UKHomeOffice/docker-nodejs.git","svn_url":"https://github.com/UKHomeOffice/docker-nodejs","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"UKHomeOffice:master","ref":"master","sha":"ecbad6dd554b4c18f828ad909658e0f2c99f886c","user":{"login":"UKHomeOffice","id":3778081,"avatar_url":"https://avatars.githubusercontent.com/u/3778081?v=3","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":41105269,"name":"docker-nodejs","full_name":"UKHomeOffice/docker-nodejs","owner":{"login":"UKHomeOffice","id":3778081,"avatar_url":"https://avatars.githubusercontent.com/u/3778081?v=3","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UKHomeOffice/docker-nodejs","description":"","fork":false,"url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs","forks_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/releases{/id}","created_at":"2015-08-20T16:00:37Z","updated_at":"2015-09-14T15:35:35Z","pushed_at":"2015-11-20T10:40:25Z","git_url":"git://github.com/UKHomeOffice/docker-nodejs.git","ssh_url":"git@github.com:UKHomeOffice/docker-nodejs.git","clone_url":"https://github.com/UKHomeOffice/docker-nodejs.git","svn_url":"https://github.com/UKHomeOffice/docker-nodejs","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/12"},"html":{"href":"https://github.com/UKHomeOffice/docker-nodejs/pull/12"},"issue":{"href":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/issues/12"},"comments":{"href":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/UKHomeOffice/docker-nodejs/statuses/8788d6182875d1e4fdd5dcd5ffc0048d05d30192"}}}}