{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/atomicapp/pulls/comments/40292119","id":40292119,"diff_hunk":"@@ -37,6 +37,7 @@\n ANSWERS_FILE_SAMPLE_FORMAT = 'ini'\n WORKDIR = \".workdir\"\n LOCK_FILE = \"/run/lock/atomicapp.lock\"\n+LOG_FILE = \"/var/log/atomicapp.log\"","path":"atomicapp/constants.py","position":4,"original_position":4,"commit_id":"4dd1e4ea087dbd3ddd1f771f68531e7a7833187c","original_commit_id":"4dd1e4ea087dbd3ddd1f771f68531e7a7833187c","user":{"login":"goern","id":260331,"avatar_url":"https://avatars.githubusercontent.com/u/260331?v=3","gravatar_id":"","url":"https://api.github.com/users/goern","html_url":"https://github.com/goern","followers_url":"https://api.github.com/users/goern/followers","following_url":"https://api.github.com/users/goern/following{/other_user}","gists_url":"https://api.github.com/users/goern/gists{/gist_id}","starred_url":"https://api.github.com/users/goern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goern/subscriptions","organizations_url":"https://api.github.com/users/goern/orgs","repos_url":"https://api.github.com/users/goern/repos","events_url":"https://api.github.com/users/goern/events{/privacy}","received_events_url":"https://api.github.com/users/goern/received_events","type":"User","site_admin":false},"body":"That /var/log inside the container? outside? Or.. `atomic` somehow manages it? `needs_doc`","created_at":"2015-09-24T07:35:54Z","updated_at":"2015-09-24T07:35:54Z","html_url":"https://github.com/projectatomic/atomicapp/pull/288#discussion_r40292119","pull_request_url":"https://api.github.com/repos/projectatomic/atomicapp/pulls/288","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/atomicapp/pulls/comments/40292119"},"html":{"href":"https://github.com/projectatomic/atomicapp/pull/288#discussion_r40292119"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/atomicapp/pulls/288"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/atomicapp/pulls/288","id":45836007,"html_url":"https://github.com/projectatomic/atomicapp/pull/288","diff_url":"https://github.com/projectatomic/atomicapp/pull/288.diff","patch_url":"https://github.com/projectatomic/atomicapp/pull/288.patch","issue_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/288","number":288,"state":"open","locked":false,"title":"[Do not merge, need input] Beautify logging","user":{"login":"charliedrage","id":6422176,"avatar_url":"https://avatars.githubusercontent.com/u/6422176?v=3","gravatar_id":"","url":"https://api.github.com/users/charliedrage","html_url":"https://github.com/charliedrage","followers_url":"https://api.github.com/users/charliedrage/followers","following_url":"https://api.github.com/users/charliedrage/following{/other_user}","gists_url":"https://api.github.com/users/charliedrage/gists{/gist_id}","starred_url":"https://api.github.com/users/charliedrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliedrage/subscriptions","organizations_url":"https://api.github.com/users/charliedrage/orgs","repos_url":"https://api.github.com/users/charliedrage/repos","events_url":"https://api.github.com/users/charliedrage/events{/privacy}","received_events_url":"https://api.github.com/users/charliedrage/received_events","type":"User","site_admin":false},"body":"Beautifies the logging by using a class to display the output to console. Outputs to stderr and stdout consoles\r\n\r\n(ignore my terminal motd's)\r\n\r\nTurns this:\r\n![old](http://i.imgur.com/y9vSb7i.gif)\r\n\r\nInto this:\r\n![new](http://i.imgur.com/w1tR9lS.gif)\r\n\r\n\r\nNeed some input on:\r\n * Colour(s)\r\n * Do we touch / create an atomicapp.log on creation or remove logging module completely (since we output to err and info on console anyways)? SEE TOP OF `display.py` \r\n * Is there ANY WAY to remove the console __Cockpit__ requirements? (pass a --output=cockpit param?)\r\n\r\nNeed some testing on:\r\n * Cockpit (atomicapp.status.info.message) to see if there is any regressions. If anyone has a current dev environment with Cockpit + atomicapp\r\n\r\n\r\nFixes: #134 \r\n","created_at":"2015-09-23T21:47:32Z","updated_at":"2015-09-24T07:35:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a11059ab9a1b3e3eb3be41412279d2628b40a4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/atomicapp/pulls/288/commits","review_comments_url":"https://api.github.com/repos/projectatomic/atomicapp/pulls/288/comments","review_comment_url":"https://api.github.com/repos/projectatomic/atomicapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/288/comments","statuses_url":"https://api.github.com/repos/projectatomic/atomicapp/statuses/4dd1e4ea087dbd3ddd1f771f68531e7a7833187c","head":{"label":"charliedrage:beautify_logging","ref":"beautify_logging","sha":"4dd1e4ea087dbd3ddd1f771f68531e7a7833187c","user":{"login":"charliedrage","id":6422176,"avatar_url":"https://avatars.githubusercontent.com/u/6422176?v=3","gravatar_id":"","url":"https://api.github.com/users/charliedrage","html_url":"https://github.com/charliedrage","followers_url":"https://api.github.com/users/charliedrage/followers","following_url":"https://api.github.com/users/charliedrage/following{/other_user}","gists_url":"https://api.github.com/users/charliedrage/gists{/gist_id}","starred_url":"https://api.github.com/users/charliedrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliedrage/subscriptions","organizations_url":"https://api.github.com/users/charliedrage/orgs","repos_url":"https://api.github.com/users/charliedrage/repos","events_url":"https://api.github.com/users/charliedrage/events{/privacy}","received_events_url":"https://api.github.com/users/charliedrage/received_events","type":"User","site_admin":false},"repo":{"id":41424648,"name":"atomicapp","full_name":"charliedrage/atomicapp","owner":{"login":"charliedrage","id":6422176,"avatar_url":"https://avatars.githubusercontent.com/u/6422176?v=3","gravatar_id":"","url":"https://api.github.com/users/charliedrage","html_url":"https://github.com/charliedrage","followers_url":"https://api.github.com/users/charliedrage/followers","following_url":"https://api.github.com/users/charliedrage/following{/other_user}","gists_url":"https://api.github.com/users/charliedrage/gists{/gist_id}","starred_url":"https://api.github.com/users/charliedrage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliedrage/subscriptions","organizations_url":"https://api.github.com/users/charliedrage/orgs","repos_url":"https://api.github.com/users/charliedrage/repos","events_url":"https://api.github.com/users/charliedrage/events{/privacy}","received_events_url":"https://api.github.com/users/charliedrage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charliedrage/atomicapp","description":"This is the reference implementation of the Nulecule container application Specification: Atomic App","fork":true,"url":"https://api.github.com/repos/charliedrage/atomicapp","forks_url":"https://api.github.com/repos/charliedrage/atomicapp/forks","keys_url":"https://api.github.com/repos/charliedrage/atomicapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charliedrage/atomicapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charliedrage/atomicapp/teams","hooks_url":"https://api.github.com/repos/charliedrage/atomicapp/hooks","issue_events_url":"https://api.github.com/repos/charliedrage/atomicapp/issues/events{/number}","events_url":"https://api.github.com/repos/charliedrage/atomicapp/events","assignees_url":"https://api.github.com/repos/charliedrage/atomicapp/assignees{/user}","branches_url":"https://api.github.com/repos/charliedrage/atomicapp/branches{/branch}","tags_url":"https://api.github.com/repos/charliedrage/atomicapp/tags","blobs_url":"https://api.github.com/repos/charliedrage/atomicapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charliedrage/atomicapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charliedrage/atomicapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/charliedrage/atomicapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charliedrage/atomicapp/statuses/{sha}","languages_url":"https://api.github.com/repos/charliedrage/atomicapp/languages","stargazers_url":"https://api.github.com/repos/charliedrage/atomicapp/stargazers","contributors_url":"https://api.github.com/repos/charliedrage/atomicapp/contributors","subscribers_url":"https://api.github.com/repos/charliedrage/atomicapp/subscribers","subscription_url":"https://api.github.com/repos/charliedrage/atomicapp/subscription","commits_url":"https://api.github.com/repos/charliedrage/atomicapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/charliedrage/atomicapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/charliedrage/atomicapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/charliedrage/atomicapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/charliedrage/atomicapp/contents/{+path}","compare_url":"https://api.github.com/repos/charliedrage/atomicapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charliedrage/atomicapp/merges","archive_url":"https://api.github.com/repos/charliedrage/atomicapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charliedrage/atomicapp/downloads","issues_url":"https://api.github.com/repos/charliedrage/atomicapp/issues{/number}","pulls_url":"https://api.github.com/repos/charliedrage/atomicapp/pulls{/number}","milestones_url":"https://api.github.com/repos/charliedrage/atomicapp/milestones{/number}","notifications_url":"https://api.github.com/repos/charliedrage/atomicapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charliedrage/atomicapp/labels{/name}","releases_url":"https://api.github.com/repos/charliedrage/atomicapp/releases{/id}","created_at":"2015-08-26T12:37:30Z","updated_at":"2015-08-26T12:37:30Z","pushed_at":"2015-09-23T23:03:27Z","git_url":"git://github.com/charliedrage/atomicapp.git","ssh_url":"git@github.com:charliedrage/atomicapp.git","clone_url":"https://github.com/charliedrage/atomicapp.git","svn_url":"https://github.com/charliedrage/atomicapp","homepage":"","size":588,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"15f5d45e62f06f62c95bf400a5f684800b79199c","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":32819266,"name":"atomicapp","full_name":"projectatomic/atomicapp","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/atomicapp","description":"This is the reference implementation of the Nulecule container application Specification: Atomic App","fork":false,"url":"https://api.github.com/repos/projectatomic/atomicapp","forks_url":"https://api.github.com/repos/projectatomic/atomicapp/forks","keys_url":"https://api.github.com/repos/projectatomic/atomicapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/atomicapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/atomicapp/teams","hooks_url":"https://api.github.com/repos/projectatomic/atomicapp/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/atomicapp/events","assignees_url":"https://api.github.com/repos/projectatomic/atomicapp/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/atomicapp/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/atomicapp/tags","blobs_url":"https://api.github.com/repos/projectatomic/atomicapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/atomicapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/atomicapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/atomicapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/atomicapp/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/atomicapp/languages","stargazers_url":"https://api.github.com/repos/projectatomic/atomicapp/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/atomicapp/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/atomicapp/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/atomicapp/subscription","commits_url":"https://api.github.com/repos/projectatomic/atomicapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/atomicapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/atomicapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/atomicapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/atomicapp/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/atomicapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/atomicapp/merges","archive_url":"https://api.github.com/repos/projectatomic/atomicapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/atomicapp/downloads","issues_url":"https://api.github.com/repos/projectatomic/atomicapp/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/atomicapp/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/atomicapp/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/atomicapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/atomicapp/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/atomicapp/releases{/id}","created_at":"2015-03-24T19:09:39Z","updated_at":"2015-09-16T20:06:21Z","pushed_at":"2015-09-23T23:03:27Z","git_url":"git://github.com/projectatomic/atomicapp.git","ssh_url":"git@github.com:projectatomic/atomicapp.git","clone_url":"https://github.com/projectatomic/atomicapp.git","svn_url":"https://github.com/projectatomic/atomicapp","homepage":"","size":2025,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":47,"forks":31,"open_issues":47,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/atomicapp/pulls/288"},"html":{"href":"https://github.com/projectatomic/atomicapp/pull/288"},"issue":{"href":"https://api.github.com/repos/projectatomic/atomicapp/issues/288"},"comments":{"href":"https://api.github.com/repos/projectatomic/atomicapp/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/atomicapp/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/atomicapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/atomicapp/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/atomicapp/statuses/4dd1e4ea087dbd3ddd1f771f68531e7a7833187c"}}}}