{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/30114403","id":30114403,"diff_hunk":"@@ -0,0 +1,173 @@\n+#include \"util/math.h\"\n+#include <QDebug>\n+\n+#include \"effects/native/phasereffect.h\"\n+\n+const unsigned int updateCoef = 32;\n+\n+// static\n+QString PhaserEffect::getId() {\n+    return \"org.mixxx.effects.phaser\";\n+}\n+\n+// static\n+EffectManifest PhaserEffect::getManifest() {\n+    EffectManifest manifest;\n+    manifest.setId(getId());\n+    manifest.setName(QObject::tr(\"Phaser\"));\n+    manifest.setAuthor(\"The Mixxx Team\");\n+    manifest.setVersion(\"1.0\");\n+    manifest.setDescription(QObject::tr(\n+                \"A more complex sound effect obtained by mixing the input signal\" \n+                \"with a copy passed through a series of all-pass filters.\"));\n+    \n+    EffectManifestParameter* stages = manifest.addParameter();\n+    stages->setId(\"stages\");\n+    stages->setName(QObject::tr(\"Stages\"));\n+    stages->setDescription(\"Sets number of stages.\");\n+    stages->setControlHint(EffectManifestParameter::CONTROL_KNOB_LINEAR);\n+    stages->setSemanticHint(EffectManifestParameter::SEMANTIC_UNKNOWN);\n+    stages->setUnitsHint(EffectManifestParameter::UNITS_UNKNOWN);\n+    stages->setDefault(1.0);","path":"src/effects/native/phasereffect.cpp","position":31,"original_position":31,"commit_id":"b5f198bf6a31200c0dfd044d2a6432c276027f92","original_commit_id":"b5f198bf6a31200c0dfd044d2a6432c276027f92","user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"The old version was correct. I think it is common to set the stages in double steps.\r\n2 stages = 1 notch  \r\nYou find 2/6/12 stages phaser in the wild.","created_at":"2015-05-12T08:37:50Z","updated_at":"2015-05-12T08:37:50Z","html_url":"https://github.com/mixxxdj/mixxx/pull/560#discussion_r30114403","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/560","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/30114403"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/560#discussion_r30114403"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/560"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/560","id":33893256,"html_url":"https://github.com/mixxxdj/mixxx/pull/560","diff_url":"https://github.com/mixxxdj/mixxx/pull/560.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/560.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/560","number":560,"state":"open","locked":false,"title":"[Bug #1299029] phaser effect","user":{"login":"jercaianu","id":6543739,"avatar_url":"https://avatars.githubusercontent.com/u/6543739?v=3","gravatar_id":"","url":"https://api.github.com/users/jercaianu","html_url":"https://github.com/jercaianu","followers_url":"https://api.github.com/users/jercaianu/followers","following_url":"https://api.github.com/users/jercaianu/following{/other_user}","gists_url":"https://api.github.com/users/jercaianu/gists{/gist_id}","starred_url":"https://api.github.com/users/jercaianu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jercaianu/subscriptions","organizations_url":"https://api.github.com/users/jercaianu/orgs","repos_url":"https://api.github.com/users/jercaianu/repos","events_url":"https://api.github.com/users/jercaianu/events{/privacy}","received_events_url":"https://api.github.com/users/jercaianu/received_events","type":"User","site_admin":false},"body":"I tried to implement a phaser inspired by the one already done in Audacity. However the output does not sound well. I'm not sure whether this can be improved, or if i should start looking somewhere else. Thanks !","created_at":"2015-04-22T19:38:38Z","updated_at":"2015-05-12T08:37:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cc4099ceeb4ecd4a0b38c4067bfe8e8dbbbd9c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/560/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/560/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/560/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/b5f198bf6a31200c0dfd044d2a6432c276027f92","head":{"label":"jercaianu:phaser","ref":"phaser","sha":"b5f198bf6a31200c0dfd044d2a6432c276027f92","user":{"login":"jercaianu","id":6543739,"avatar_url":"https://avatars.githubusercontent.com/u/6543739?v=3","gravatar_id":"","url":"https://api.github.com/users/jercaianu","html_url":"https://github.com/jercaianu","followers_url":"https://api.github.com/users/jercaianu/followers","following_url":"https://api.github.com/users/jercaianu/following{/other_user}","gists_url":"https://api.github.com/users/jercaianu/gists{/gist_id}","starred_url":"https://api.github.com/users/jercaianu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jercaianu/subscriptions","organizations_url":"https://api.github.com/users/jercaianu/orgs","repos_url":"https://api.github.com/users/jercaianu/repos","events_url":"https://api.github.com/users/jercaianu/events{/privacy}","received_events_url":"https://api.github.com/users/jercaianu/received_events","type":"User","site_admin":false},"repo":{"id":32629019,"name":"mixxx","full_name":"jercaianu/mixxx","owner":{"login":"jercaianu","id":6543739,"avatar_url":"https://avatars.githubusercontent.com/u/6543739?v=3","gravatar_id":"","url":"https://api.github.com/users/jercaianu","html_url":"https://github.com/jercaianu","followers_url":"https://api.github.com/users/jercaianu/followers","following_url":"https://api.github.com/users/jercaianu/following{/other_user}","gists_url":"https://api.github.com/users/jercaianu/gists{/gist_id}","starred_url":"https://api.github.com/users/jercaianu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jercaianu/subscriptions","organizations_url":"https://api.github.com/users/jercaianu/orgs","repos_url":"https://api.github.com/users/jercaianu/repos","events_url":"https://api.github.com/users/jercaianu/events{/privacy}","received_events_url":"https://api.github.com/users/jercaianu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jercaianu/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/jercaianu/mixxx","forks_url":"https://api.github.com/repos/jercaianu/mixxx/forks","keys_url":"https://api.github.com/repos/jercaianu/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jercaianu/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jercaianu/mixxx/teams","hooks_url":"https://api.github.com/repos/jercaianu/mixxx/hooks","issue_events_url":"https://api.github.com/repos/jercaianu/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/jercaianu/mixxx/events","assignees_url":"https://api.github.com/repos/jercaianu/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/jercaianu/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/jercaianu/mixxx/tags","blobs_url":"https://api.github.com/repos/jercaianu/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jercaianu/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jercaianu/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jercaianu/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jercaianu/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/jercaianu/mixxx/languages","stargazers_url":"https://api.github.com/repos/jercaianu/mixxx/stargazers","contributors_url":"https://api.github.com/repos/jercaianu/mixxx/contributors","subscribers_url":"https://api.github.com/repos/jercaianu/mixxx/subscribers","subscription_url":"https://api.github.com/repos/jercaianu/mixxx/subscription","commits_url":"https://api.github.com/repos/jercaianu/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jercaianu/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jercaianu/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jercaianu/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/jercaianu/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/jercaianu/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jercaianu/mixxx/merges","archive_url":"https://api.github.com/repos/jercaianu/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jercaianu/mixxx/downloads","issues_url":"https://api.github.com/repos/jercaianu/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/jercaianu/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/jercaianu/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/jercaianu/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jercaianu/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/jercaianu/mixxx/releases{/id}","created_at":"2015-03-21T10:57:31Z","updated_at":"2015-04-09T15:05:30Z","pushed_at":"2015-04-29T21:57:14Z","git_url":"git://github.com/jercaianu/mixxx.git","ssh_url":"git@github.com:jercaianu/mixxx.git","clone_url":"https://github.com/jercaianu/mixxx.git","svn_url":"https://github.com/jercaianu/mixxx","homepage":"http://mixxx.org","size":239127,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"2df5727055b8372a31ff8faaafcae614312ec085","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","created_at":"2013-05-17T15:14:38Z","updated_at":"2015-05-11T12:56:16Z","pushed_at":"2015-05-11T21:32:59Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":323596,"stargazers_count":280,"watchers_count":280,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":206,"mirror_url":null,"open_issues_count":38,"forks":206,"open_issues":38,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/560"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/560"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/560"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/560/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/560/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/560/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/b5f198bf6a31200c0dfd044d2a6432c276027f92"}}}}