{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/227","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/227/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/227/events","html_url":"https://github.com/ocaml/ocaml/pull/227","id":99160545,"number":227,"title":"Fix 0006945: strings containing 0 are truncated","user":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars.githubusercontent.com/u/1274291?v=3","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-08-05T09:21:21Z","updated_at":"2015-11-13T13:58:45Z","closed_at":"2015-11-11T16:30:09Z","pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/227","html_url":"https://github.com/ocaml/ocaml/pull/227","diff_url":"https://github.com/ocaml/ocaml/pull/227.diff","patch_url":"https://github.com/ocaml/ocaml/pull/227.patch"},"body":"I added checks in many primitive operations to fix http://caml.inria.fr/mantis/view.php?id=6945\r\nI don't know the performance overhead, but it does fix the test case. Maybe the check can be made faster.\r\n\r\nOn the other hand, it looks to me like many calls to `strdup` are unecessary, since the strings are given to system calls as `const char*` and free()'d just after."},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/156436862","html_url":"https://github.com/ocaml/ocaml/pull/227#issuecomment-156436862","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/227","id":156436862,"user":{"login":"xavierleroy","id":3845810,"avatar_url":"https://avatars.githubusercontent.com/u/3845810?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierleroy","html_url":"https://github.com/xavierleroy","followers_url":"https://api.github.com/users/xavierleroy/followers","following_url":"https://api.github.com/users/xavierleroy/following{/other_user}","gists_url":"https://api.github.com/users/xavierleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierleroy/subscriptions","organizations_url":"https://api.github.com/users/xavierleroy/orgs","repos_url":"https://api.github.com/users/xavierleroy/repos","events_url":"https://api.github.com/users/xavierleroy/events{/privacy}","received_events_url":"https://api.github.com/users/xavierleroy/received_events","type":"User","site_admin":false},"created_at":"2015-11-13T13:58:45Z","updated_at":"2015-11-13T13:58:45Z","body":"More checks added in commits dc2a98c and 29a50b4\r\n"}}