{"push_id":918440394,"size":54,"distinct_size":1,"ref":"refs/heads/isblock","head":"529c9a39d6ba4bc3e06c2c5049212cb0f7598d73","before":"dae8d81f71645ab7151d0cdacac38de948f3ab4d","commits":[{"sha":"eac8c0cd3fffb2ff29dc2edd647df544c47dd3ff","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"removed obsolete documentation about requiring classes","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/eac8c0cd3fffb2ff29dc2edd647df544c47dd3ff"},{"sha":"53aa70a3f43cc0094cf5a72b22f3d63a87713eb5","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"minor #1884 removed obsolete documentation about requiring classes (fabpot)\n\nThis PR was merged into the 1.x branch.\n\nDiscussion\n----------\n\nremoved obsolete documentation about requiring classes\n\nCommits\n-------\n\neac8c0c removed obsolete documentation about requiring classes","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/53aa70a3f43cc0094cf5a72b22f3d63a87713eb5"},{"sha":"a57b1cc3be61c9751cae05c418e9cf814e043919","author":{"email":"723156650c5778d0e4df4b2fbfeefa65359302e5@tamarelle.net","name":"Jérôme Tamarelle"},"message":"Fix adding mock extension to Twig environment\n\nWhen the extension class is not defined in a file but in eval'd code\nwe cannot assume ReflectionObject::getFileName will return\na valid file path.\n\nhttps://bugs.php.net/bug.php?id=63901","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/a57b1cc3be61c9751cae05c418e9cf814e043919"},{"sha":"a4597a4c0061c41432f3e83effa3d3ebde81c946","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bumped version to 1.23","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/a4597a4c0061c41432f3e83effa3d3ebde81c946"},{"sha":"f47af35457d5029b3c8eaa3a49c253f7791df12a","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"bug #1874 Fix adding mock extension to Twig environment (GromNaN)\n\nThis PR was merged into the 1.x branch.\n\nDiscussion\n----------\n\nFix adding mock extension to Twig environment\n\nWhen the extension class is not defined in a file but in eval'd code we cannot assume `ReflectionObject::getFileName()` will return a valid file path.\nhttps://bugs.php.net/bug.php?id=63901\n\nThis PR adds a test case that produce the following error without the fix:\n\n```\n1) Twig_Tests_EnvironmentTest::testAddMockExtension\nfilemtime(): stat failed for phar:///usr/local/php5-5.5.14-20140628-105310/bin/phpunit/phpunit-mock-objects/Framework/MockObject/Generator.php(335) : eval()'d code\n\n/xxx/Twig/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php:40\n/xxx/Twig/lib/Twig/Environment.php:769\n/xxx/Twig/test/Twig/Tests/EnvironmentTest.php:304\n```\n\nI encountered this issue with mocked twig extensions in SonataAdminBundle test suite:\nhttps://github.com/sonata-project/SonataAdminBundle/blob/master/Tests/Controller/HelperControllerTest.php#L254\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #1870\n| License       | MIT\n| Doc PR        | n/a\n\nCommits\n-------\n\na57b1cc Fix adding mock extension to Twig environment","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/f47af35457d5029b3c8eaa3a49c253f7791df12a"},{"sha":"f839ad328e442066a756b27fdefe4e1a769ca7b9","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"made the tests semantically more correct","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/f839ad328e442066a756b27fdefe4e1a769ca7b9"},{"sha":"6ddd911aa5dff3e5075186142fb3ddf7a19d6aef","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"minor #1891 made the tests semantically more correct (fabpot)\n\nThis PR was merged into the 1.x branch.\n\nDiscussion\n----------\n\nmade the tests semantically more correct\n\nCalling `initRuntime()` is just a side-effect of loading a template.\n\nCommits\n-------\n\nf839ad3 made the tests semantically more correct","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/6ddd911aa5dff3e5075186142fb3ddf7a19d6aef"},{"sha":"d0a5ef8cc08f9283bdb144af402eb6b4f09727b5","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"deprecated Twig_Environment::computeAlternatives()","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/d0a5ef8cc08f9283bdb144af402eb6b4f09727b5"},{"sha":"0468a7ede469dd8e3beda44c676fbb66cac91706","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"feature #1890 deprecated Twig_Environment::computeAlternatives() (fabpot)\n\nThis PR was merged into the 1.x branch.\n\nDiscussion\n----------\n\ndeprecated Twig_Environment::computeAlternatives()\n\nCommits\n-------\n\nd0a5ef8 deprecated Twig_Environment::computeAlternatives()","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/0468a7ede469dd8e3beda44c676fbb66cac91706"},{"sha":"9774f4f1a43ae7c1dfd952430b1826217ce72f0b","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"deprecated Twig_ExtensionInterface::initRuntime()","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/9774f4f1a43ae7c1dfd952430b1826217ce72f0b"},{"sha":"9caf7722ccbf5926a88e0f8c35dd7b0502ace65a","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"renamed a method","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/9caf7722ccbf5926a88e0f8c35dd7b0502ace65a"},{"sha":"6450c870ae5caf0e7252e6ff6b283a72a0a67031","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"removed useless phpdocs","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/6450c870ae5caf0e7252e6ff6b283a72a0a67031"},{"sha":"12ea20245c2b233ff98906b743de4fc7f9dade8c","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"fixed message inconsistency","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/12ea20245c2b233ff98906b743de4fc7f9dade8c"},{"sha":"dbd78848575be839f48afe12a72f997306c3430c","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"minor #1893 fixed message inconsistency (fabpot)\n\nThis PR was merged into the 1.x branch.\n\nDiscussion\n----------\n\nfixed message inconsistency\n\nCommits\n-------\n\n12ea202 fixed message inconsistency","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/dbd78848575be839f48afe12a72f997306c3430c"},{"sha":"d4f699a089a954eb55c78636ba153c79a25b51e2","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"minor #1894 removed useless phpdocs (fabpot)\n\nThis PR was merged into the 1.x branch.\n\nDiscussion\n----------\n\nremoved useless phpdocs\n\nCommits\n-------\n\n6450c87 removed useless phpdocs","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/d4f699a089a954eb55c78636ba153c79a25b51e2"},{"sha":"847d48e790224ff118921e056d4db86d047a1d5a","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"feature #1886 deprecated Twig_ExtensionInterface::initRuntime() (fabpot)\n\nThis PR was merged into the 1.x branch.\n\nDiscussion\n----------\n\ndeprecated Twig_ExtensionInterface::initRuntime()\n\nI'm working on splitting Twig extensions into 2 different phases: compilation and runtime. The goal is to avoid having to load the runtime environment of an extension when compiling templates. That also opens the way to be able to lazy-load Twig extensions.\n\nWhile working on the split, I realized that the `initRuntime()` method on `Twig_ExtensionInterface` is not needed anymore. It was added at a time `needs_environment` did not exist and was a way to keep the environment around for custom filters/tests/functions. But nowadays, that's not needed anymore. I did a quick search on Github, and most of the implementation I found just store the environment in a local property, which is not needed anymore. So, I propose to deprecate it in 1.x and remove it in 2.0.\n\nCommits\n-------\n\n9774f4f deprecated Twig_ExtensionInterface::initRuntime()","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/847d48e790224ff118921e056d4db86d047a1d5a"},{"sha":"72485c2ea04d1c151c884953d452a35108a67193","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"deprecated the possibility to override an extension by registering another one with the same name","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/72485c2ea04d1c151c884953d452a35108a67193"},{"sha":"babf8f80e74a0c31c522ef855ceb243fe22a026e","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"feature #1896 deprecated the possibility to override an extension by registering an other one with the same name (fabpot)\n\nThis PR was merged into the 1.x branch.\n\nDiscussion\n----------\n\ndeprecated the possibility to override an extension by registering an other one with the same name\n\nCommits\n-------\n\n72485c2 deprecated the possibility to override an extension by registering another one with the same name","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/babf8f80e74a0c31c522ef855ceb243fe22a026e"},{"sha":"7220fd2d887a427cd78604ad21e8b72005e91d09","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"fixed typo","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/7220fd2d887a427cd78604ad21e8b72005e91d09"},{"sha":"e3a325f249a5ff4cdbbabbec7271c13dee2d7ac5","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"deprecated Twig_ExtensionInterface::getGlobals()","distinct":false,"url":"https://api.github.com/repos/hason/Twig/commits/e3a325f249a5ff4cdbbabbec7271c13dee2d7ac5"}]}