{"action":"closed","number":2098,"pull_request":{"url":"https://api.github.com/repos/sbt/sbt/pulls/2098","id":39669158,"html_url":"https://github.com/sbt/sbt/pull/2098","diff_url":"https://github.com/sbt/sbt/pull/2098.diff","patch_url":"https://github.com/sbt/sbt/pull/2098.patch","issue_url":"https://api.github.com/repos/sbt/sbt/issues/2098","number":2098,"state":"closed","locked":false,"title":"Fix most SBT's build warnings","user":{"login":"pdalpra","id":1514127,"avatar_url":"https://avatars.githubusercontent.com/u/1514127?v=3","gravatar_id":"","url":"https://api.github.com/users/pdalpra","html_url":"https://github.com/pdalpra","followers_url":"https://api.github.com/users/pdalpra/followers","following_url":"https://api.github.com/users/pdalpra/following{/other_user}","gists_url":"https://api.github.com/users/pdalpra/gists{/gist_id}","starred_url":"https://api.github.com/users/pdalpra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdalpra/subscriptions","organizations_url":"https://api.github.com/users/pdalpra/orgs","repos_url":"https://api.github.com/users/pdalpra/repos","events_url":"https://api.github.com/users/pdalpra/events{/privacy}","received_events_url":"https://api.github.com/users/pdalpra/received_events","type":"User","site_admin":false},"body":"This PR fixes most (2 remain) warnings in SBT's own build.\r\n\r\nHere are those which remain : \r\n\r\n```\r\n/Users/pierredalpra/Work/Forks/sbt/build.sbt:12: warning: postfix operator intransitive should be enabled\r\nby making the implicit value scala.language.postfixOps visible.\r\nThis can be achieved by adding the import clause 'import scala.language.postfixOps'\r\nor by setting the compiler option -language:postfixOps.\r\nSee the Scala docs for value scala.language.postfixOps for a discussion\r\nwhy the feature should be explicitly enabled.\r\ndef buildLevelSettings: Seq[Setting[_]] = Seq(\r\n                                         ^\r\n```\r\n\r\n```\r\n/Users/pierredalpra/Work/Forks/sbt/build.sbt:555: warning: method normalize in object StringUtilities is deprecated: Different use cases require different normalization.  Use Project.normalizeModuleID or normalizeProjectID instead.\r\ndef precompiled(scalav: String): Project = Project(id = normalize(\"Precompiled \" + scalav.replace('.', '_')), base = compilePath / \"interface\").\r\n```\r\n\r\nI'm having quite a hard time to understand where the first one comes from with my basic knowledge of SBT's internals...","created_at":"2015-07-10T09:57:44Z","updated_at":"2015-07-10T18:21:54Z","closed_at":"2015-07-10T18:21:53Z","merged_at":"2015-07-10T18:21:53Z","merge_commit_sha":"de7b59621f396b5c795dc12571887c9fcd3e47d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sbt/sbt/pulls/2098/commits","review_comments_url":"https://api.github.com/repos/sbt/sbt/pulls/2098/comments","review_comment_url":"https://api.github.com/repos/sbt/sbt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sbt/sbt/issues/2098/comments","statuses_url":"https://api.github.com/repos/sbt/sbt/statuses/3ffa333c14bee2e0e46b473be54a5a6ce33e504a","head":{"label":"pdalpra:fix-build-warnings","ref":"fix-build-warnings","sha":"3ffa333c14bee2e0e46b473be54a5a6ce33e504a","user":{"login":"pdalpra","id":1514127,"avatar_url":"https://avatars.githubusercontent.com/u/1514127?v=3","gravatar_id":"","url":"https://api.github.com/users/pdalpra","html_url":"https://github.com/pdalpra","followers_url":"https://api.github.com/users/pdalpra/followers","following_url":"https://api.github.com/users/pdalpra/following{/other_user}","gists_url":"https://api.github.com/users/pdalpra/gists{/gist_id}","starred_url":"https://api.github.com/users/pdalpra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdalpra/subscriptions","organizations_url":"https://api.github.com/users/pdalpra/orgs","repos_url":"https://api.github.com/users/pdalpra/repos","events_url":"https://api.github.com/users/pdalpra/events{/privacy}","received_events_url":"https://api.github.com/users/pdalpra/received_events","type":"User","site_admin":false},"repo":{"id":34446757,"name":"sbt","full_name":"pdalpra/sbt","owner":{"login":"pdalpra","id":1514127,"avatar_url":"https://avatars.githubusercontent.com/u/1514127?v=3","gravatar_id":"","url":"https://api.github.com/users/pdalpra","html_url":"https://github.com/pdalpra","followers_url":"https://api.github.com/users/pdalpra/followers","following_url":"https://api.github.com/users/pdalpra/following{/other_user}","gists_url":"https://api.github.com/users/pdalpra/gists{/gist_id}","starred_url":"https://api.github.com/users/pdalpra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdalpra/subscriptions","organizations_url":"https://api.github.com/users/pdalpra/orgs","repos_url":"https://api.github.com/users/pdalpra/repos","events_url":"https://api.github.com/users/pdalpra/events{/privacy}","received_events_url":"https://api.github.com/users/pdalpra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pdalpra/sbt","description":"sbt, a build tool for Scala","fork":true,"url":"https://api.github.com/repos/pdalpra/sbt","forks_url":"https://api.github.com/repos/pdalpra/sbt/forks","keys_url":"https://api.github.com/repos/pdalpra/sbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdalpra/sbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdalpra/sbt/teams","hooks_url":"https://api.github.com/repos/pdalpra/sbt/hooks","issue_events_url":"https://api.github.com/repos/pdalpra/sbt/issues/events{/number}","events_url":"https://api.github.com/repos/pdalpra/sbt/events","assignees_url":"https://api.github.com/repos/pdalpra/sbt/assignees{/user}","branches_url":"https://api.github.com/repos/pdalpra/sbt/branches{/branch}","tags_url":"https://api.github.com/repos/pdalpra/sbt/tags","blobs_url":"https://api.github.com/repos/pdalpra/sbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdalpra/sbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdalpra/sbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdalpra/sbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdalpra/sbt/statuses/{sha}","languages_url":"https://api.github.com/repos/pdalpra/sbt/languages","stargazers_url":"https://api.github.com/repos/pdalpra/sbt/stargazers","contributors_url":"https://api.github.com/repos/pdalpra/sbt/contributors","subscribers_url":"https://api.github.com/repos/pdalpra/sbt/subscribers","subscription_url":"https://api.github.com/repos/pdalpra/sbt/subscription","commits_url":"https://api.github.com/repos/pdalpra/sbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdalpra/sbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdalpra/sbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdalpra/sbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdalpra/sbt/contents/{+path}","compare_url":"https://api.github.com/repos/pdalpra/sbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdalpra/sbt/merges","archive_url":"https://api.github.com/repos/pdalpra/sbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdalpra/sbt/downloads","issues_url":"https://api.github.com/repos/pdalpra/sbt/issues{/number}","pulls_url":"https://api.github.com/repos/pdalpra/sbt/pulls{/number}","milestones_url":"https://api.github.com/repos/pdalpra/sbt/milestones{/number}","notifications_url":"https://api.github.com/repos/pdalpra/sbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdalpra/sbt/labels{/name}","releases_url":"https://api.github.com/repos/pdalpra/sbt/releases{/id}","created_at":"2015-04-23T09:26:44Z","updated_at":"2015-04-23T09:26:48Z","pushed_at":"2015-07-10T09:53:56Z","git_url":"git://github.com/pdalpra/sbt.git","ssh_url":"git@github.com:pdalpra/sbt.git","clone_url":"https://github.com/pdalpra/sbt.git","svn_url":"https://github.com/pdalpra/sbt","homepage":"scala-sbt.org","size":30365,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.13"}},"base":{"label":"sbt:0.13","ref":"0.13","sha":"d2fdfb81a09a0b46e8072ebf30802f3058083599","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":279553,"name":"sbt","full_name":"sbt/sbt","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/sbt","description":"sbt, a build tool for Scala","fork":false,"url":"https://api.github.com/repos/sbt/sbt","forks_url":"https://api.github.com/repos/sbt/sbt/forks","keys_url":"https://api.github.com/repos/sbt/sbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/sbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/sbt/teams","hooks_url":"https://api.github.com/repos/sbt/sbt/hooks","issue_events_url":"https://api.github.com/repos/sbt/sbt/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/sbt/events","assignees_url":"https://api.github.com/repos/sbt/sbt/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/sbt/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/sbt/tags","blobs_url":"https://api.github.com/repos/sbt/sbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/sbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/sbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/sbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/sbt/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/sbt/languages","stargazers_url":"https://api.github.com/repos/sbt/sbt/stargazers","contributors_url":"https://api.github.com/repos/sbt/sbt/contributors","subscribers_url":"https://api.github.com/repos/sbt/sbt/subscribers","subscription_url":"https://api.github.com/repos/sbt/sbt/subscription","commits_url":"https://api.github.com/repos/sbt/sbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/sbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/sbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/sbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbt/sbt/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/sbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/sbt/merges","archive_url":"https://api.github.com/repos/sbt/sbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/sbt/downloads","issues_url":"https://api.github.com/repos/sbt/sbt/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/sbt/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/sbt/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/sbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/sbt/labels{/name}","releases_url":"https://api.github.com/repos/sbt/sbt/releases{/id}","created_at":"2009-08-17T00:31:14Z","updated_at":"2015-07-10T16:54:48Z","pushed_at":"2015-07-10T18:21:54Z","git_url":"git://github.com/sbt/sbt.git","ssh_url":"git@github.com:sbt/sbt.git","clone_url":"https://github.com/sbt/sbt.git","svn_url":"https://github.com/sbt/sbt","homepage":"scala-sbt.org","size":49120,"stargazers_count":2264,"watchers_count":2264,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":424,"mirror_url":null,"open_issues_count":355,"forks":424,"open_issues":355,"watchers":2264,"default_branch":"0.13"}},"_links":{"self":{"href":"https://api.github.com/repos/sbt/sbt/pulls/2098"},"html":{"href":"https://github.com/sbt/sbt/pull/2098"},"issue":{"href":"https://api.github.com/repos/sbt/sbt/issues/2098"},"comments":{"href":"https://api.github.com/repos/sbt/sbt/issues/2098/comments"},"review_comments":{"href":"https://api.github.com/repos/sbt/sbt/pulls/2098/comments"},"review_comment":{"href":"https://api.github.com/repos/sbt/sbt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sbt/sbt/pulls/2098/commits"},"statuses":{"href":"https://api.github.com/repos/sbt/sbt/statuses/3ffa333c14bee2e0e46b473be54a5a6ce33e504a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jsuereth","id":29006,"avatar_url":"https://avatars.githubusercontent.com/u/29006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuereth","html_url":"https://github.com/jsuereth","followers_url":"https://api.github.com/users/jsuereth/followers","following_url":"https://api.github.com/users/jsuereth/following{/other_user}","gists_url":"https://api.github.com/users/jsuereth/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuereth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuereth/subscriptions","organizations_url":"https://api.github.com/users/jsuereth/orgs","repos_url":"https://api.github.com/users/jsuereth/repos","events_url":"https://api.github.com/users/jsuereth/events{/privacy}","received_events_url":"https://api.github.com/users/jsuereth/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"commits":1,"additions":23,"deletions":22,"changed_files":7}}