{"action":"created","issue":{"url":"https://api.github.com/repos/shazow/urllib3/issues/762","labels_url":"https://api.github.com/repos/shazow/urllib3/issues/762/labels{/name}","comments_url":"https://api.github.com/repos/shazow/urllib3/issues/762/comments","events_url":"https://api.github.com/repos/shazow/urllib3/issues/762/events","html_url":"https://github.com/shazow/urllib3/pull/762","id":122327735,"number":762,"title":"Add SOCKS support via contrib module (AKA SOCKS support, take 4)","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-12-15T17:48:24Z","updated_at":"2015-12-16T17:41:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shazow/urllib3/pulls/762","html_url":"https://github.com/shazow/urllib3/pull/762","diff_url":"https://github.com/shazow/urllib3/pull/762.diff","patch_url":"https://github.com/shazow/urllib3/pull/762.patch"},"body":"@Anorov did fantastic work in #692 but did not have time to go back through and respond to code review, so I've adopted the work done there and refactored it. Credit should be joint between me and @Anorov should this satisfy the bounty: however, @Anorov has previously claimed they don't want the bounty. For that reason, if @Anorov doesn't change their mind and this submission does qualify for it, I'll donate the bounty, in full, to PyLadies. (I don't need it because I'm paid full-time to work on libraries like this.)\r\n\r\nThis change essentially pulls most of the work done in #692 out into a contrib module. This allows us to avoid having to change too many things in the mainline of urllib3, and also ensures that it is not affected by the requirements to have tests and coverage. This helps us get the work initially off the ground and out into the world.\r\n\r\nIf we decide to take this change as-is, I'll also volunteer to be \"on the hook\" for supporting it going forward until such time as I can add sufficient test coverage for it.\r\n\r\nFeedback is encouraged!"},"comment":{"url":"https://api.github.com/repos/shazow/urllib3/issues/comments/165188693","html_url":"https://github.com/shazow/urllib3/pull/762#issuecomment-165188693","issue_url":"https://api.github.com/repos/shazow/urllib3/issues/762","id":165188693,"user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"created_at":"2015-12-16T17:41:35Z","updated_at":"2015-12-16T17:41:35Z","body":"I believe this is ready for preliminary review: I don't think I'll get to the HTTPS test until tomorrow."}}