{"action":"closed","number":391,"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/391","id":34384718,"html_url":"https://github.com/Microsoft/visualfsharp/pull/391","diff_url":"https://github.com/Microsoft/visualfsharp/pull/391.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/391.patch","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/391","number":391,"state":"closed","locked":false,"title":"fix invalid already rendered folder error","user":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?v=3","gravatar_id":"","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"body":"fix #246\r\n\r\nfix invalid already rendered folder error when a project contains\r\nfolders with same name\r\n\r\nTake 3: fix the current algorithm, one-liner ftw :smile:\r\n\r\nthe problem was:\r\n\r\nthe alreadyRenderedFolders hashset is used to store the folders as list ( \"a\\b\" -> [\"a\"; \"b\"] ) but the list added was the local variable curPathParts, **mutated** inside the while, so the alreadyRenderedFolders item was also modified (same instance) -> :boom: \r\n","created_at":"2015-04-29T17:10:50Z","updated_at":"2015-05-19T01:54:26Z","closed_at":"2015-05-19T01:54:26Z","merged_at":null,"merge_commit_sha":"1289244366fdded87612b1aade20effe3803539a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/391/commits","review_comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/391/comments","review_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/391/comments","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/2c37b20d129a231a16d2e64cbf2f007aa73e40c4","head":{"label":"enricosada:already_rendered_take_3","ref":"already_rendered_take_3","sha":"2c37b20d129a231a16d2e64cbf2f007aa73e40c4","user":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?v=3","gravatar_id":"","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"repo":{"id":29712087,"name":"visualfsharp","full_name":"enricosada/visualfsharp","owner":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?v=3","gravatar_id":"","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enricosada/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/enricosada/visualfsharp","forks_url":"https://api.github.com/repos/enricosada/visualfsharp/forks","keys_url":"https://api.github.com/repos/enricosada/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enricosada/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enricosada/visualfsharp/teams","hooks_url":"https://api.github.com/repos/enricosada/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/enricosada/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/enricosada/visualfsharp/events","assignees_url":"https://api.github.com/repos/enricosada/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/enricosada/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/enricosada/visualfsharp/tags","blobs_url":"https://api.github.com/repos/enricosada/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enricosada/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enricosada/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/enricosada/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enricosada/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/enricosada/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/enricosada/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/enricosada/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/enricosada/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/enricosada/visualfsharp/subscription","commits_url":"https://api.github.com/repos/enricosada/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/enricosada/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/enricosada/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/enricosada/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/enricosada/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/enricosada/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enricosada/visualfsharp/merges","archive_url":"https://api.github.com/repos/enricosada/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enricosada/visualfsharp/downloads","issues_url":"https://api.github.com/repos/enricosada/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/enricosada/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/enricosada/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/enricosada/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enricosada/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/enricosada/visualfsharp/releases{/id}","created_at":"2015-01-23T02:16:46Z","updated_at":"2015-03-02T10:13:24Z","pushed_at":"2015-05-18T13:21:59Z","git_url":"git://github.com/enricosada/visualfsharp.git","ssh_url":"git@github.com:enricosada/visualfsharp.git","clone_url":"https://github.com/enricosada/visualfsharp.git","svn_url":"https://github.com/enricosada/visualfsharp","homepage":null,"size":50763,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"fsharp4"}},"base":{"label":"Microsoft:master","ref":"master","sha":"1f195e4289f1996a009c61383873390fa1212084","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"name":"visualfsharp","full_name":"Microsoft/visualfsharp","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/visualfsharp","description":"The Visual F# compiler and tools","fork":false,"url":"https://api.github.com/repos/Microsoft/visualfsharp","forks_url":"https://api.github.com/repos/Microsoft/visualfsharp/forks","keys_url":"https://api.github.com/repos/Microsoft/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/visualfsharp/teams","hooks_url":"https://api.github.com/repos/Microsoft/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/events","assignees_url":"https://api.github.com/repos/Microsoft/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/tags","blobs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscription","commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/visualfsharp/merges","archive_url":"https://api.github.com/repos/Microsoft/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/visualfsharp/downloads","issues_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/visualfsharp/releases{/id}","created_at":"2015-01-10T05:58:43Z","updated_at":"2015-05-19T00:09:24Z","pushed_at":"2015-05-19T01:54:25Z","git_url":"git://github.com/Microsoft/visualfsharp.git","ssh_url":"git@github.com:Microsoft/visualfsharp.git","clone_url":"https://github.com/Microsoft/visualfsharp.git","svn_url":"https://github.com/Microsoft/visualfsharp","homepage":null,"size":56465,"stargazers_count":448,"watchers_count":448,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":153,"forks":86,"open_issues":153,"watchers":448,"default_branch":"fsharp4"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/391"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/391"},"issue":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/391"},"comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/391/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/391/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/391/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/2c37b20d129a231a16d2e64cbf2f007aa73e40c4"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":2,"additions":12,"deletions":1,"changed_files":2}}