{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/41127361","id":41127361,"diff_hunk":"@@ -498,12 +498,23 @@ os::build::ldflags() {\n     os::build::get_version_vars\n \n     declare -a ldflags=()\n-    ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.majorFromGit\" \"${OS_GIT_MAJOR}\")\n-    ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.minorFromGit\" \"${OS_GIT_MINOR}\")\n-    ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.versionFromGit\" \"${OS_GIT_VERSION}\")\n-    ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.commitFromGit\" \"${OS_GIT_COMMIT}\")\n-    ldflags+=(-X \"k8s.io/kubernetes/pkg/version.gitCommit\" \"${KUBE_GIT_COMMIT}\")\n-    ldflags+=(-X \"k8s.io/kubernetes/pkg/version.gitVersion\" \"${KUBE_GIT_VERSION}\")\n+\n+    go_version=($(go version))\n+    if [[ \"${go_version[2]}\" < \"go1.5\" ]]; then\n+      ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.majorFromGit\" \"${OS_GIT_MAJOR}\")\n+      ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.minorFromGit\" \"${OS_GIT_MINOR}\")\n+      ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.versionFromGit\" \"${OS_GIT_VERSION}\")\n+      ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.commitFromGit\" \"${OS_GIT_COMMIT}\")\n+      ldflags+=(-X \"k8s.io/kubernetes/pkg/version.gitCommit\" \"${KUBE_GIT_COMMIT}\")\n+      ldflags+=(-X \"k8s.io/kubernetes/pkg/version.gitVersion\" \"${KUBE_GIT_VERSION}\")\n+    else\n+      ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.majorFromGit=${OS_GIT_MAJOR}\")\n+      ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.minorFromGit=${OS_GIT_MINOR}\")\n+      ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.versionFromGit=${OS_GIT_VERSION}\")\n+      ldflags+=(-X \"${OS_GO_PACKAGE}/pkg/version.commitFromGit=${OS_GIT_COMMIT}\")\n+      ldflags+=(-X \"k8s.io/kubernetes/pkg/version.gitCommit=${KUBE_GIT_COMMIT}\")\n+      ldflags+=(-X \"k8s.io/kubernetes/pkg/version.gitVersion=${KUBE_GIT_VERSION}\")","path":"hack/common.sh","position":25,"original_position":25,"commit_id":"01b35760f650888a79100db4b712bc20b9aad0f8","original_commit_id":"01b35760f650888a79100db4b712bc20b9aad0f8","user":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2015-10-05T09:58:49Z","updated_at":"2015-10-05T09:58:49Z","html_url":"https://github.com/openshift/origin/pull/4906#discussion_r41127361","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/4906","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/41127361"},"html":{"href":"https://github.com/openshift/origin/pull/4906#discussion_r41127361"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/4906"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4906","id":46616705,"html_url":"https://github.com/openshift/origin/pull/4906","diff_url":"https://github.com/openshift/origin/pull/4906.diff","patch_url":"https://github.com/openshift/origin/pull/4906.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/4906","number":4906,"state":"open","locked":false,"title":"Fix compilation on go 1.5","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"Extracted from https://github.com/openshift/origin/pull/4324","created_at":"2015-10-02T09:24:16Z","updated_at":"2015-10-05T09:58:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0a0280f4d46313e4ac6cf6ddf737c309289243a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/4906/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/4906/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4906/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/01b35760f650888a79100db4b712bc20b9aad0f8","head":{"label":"mfojtik:go15","ref":"go15","sha":"01b35760f650888a79100db4b712bc20b9aad0f8","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"repo":{"id":22954249,"name":"origin","full_name":"mfojtik/origin","owner":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfojtik/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/mfojtik/origin","forks_url":"https://api.github.com/repos/mfojtik/origin/forks","keys_url":"https://api.github.com/repos/mfojtik/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfojtik/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfojtik/origin/teams","hooks_url":"https://api.github.com/repos/mfojtik/origin/hooks","issue_events_url":"https://api.github.com/repos/mfojtik/origin/issues/events{/number}","events_url":"https://api.github.com/repos/mfojtik/origin/events","assignees_url":"https://api.github.com/repos/mfojtik/origin/assignees{/user}","branches_url":"https://api.github.com/repos/mfojtik/origin/branches{/branch}","tags_url":"https://api.github.com/repos/mfojtik/origin/tags","blobs_url":"https://api.github.com/repos/mfojtik/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfojtik/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfojtik/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfojtik/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfojtik/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/mfojtik/origin/languages","stargazers_url":"https://api.github.com/repos/mfojtik/origin/stargazers","contributors_url":"https://api.github.com/repos/mfojtik/origin/contributors","subscribers_url":"https://api.github.com/repos/mfojtik/origin/subscribers","subscription_url":"https://api.github.com/repos/mfojtik/origin/subscription","commits_url":"https://api.github.com/repos/mfojtik/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfojtik/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfojtik/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfojtik/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfojtik/origin/contents/{+path}","compare_url":"https://api.github.com/repos/mfojtik/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfojtik/origin/merges","archive_url":"https://api.github.com/repos/mfojtik/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfojtik/origin/downloads","issues_url":"https://api.github.com/repos/mfojtik/origin/issues{/number}","pulls_url":"https://api.github.com/repos/mfojtik/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/mfojtik/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/mfojtik/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfojtik/origin/labels{/name}","releases_url":"https://api.github.com/repos/mfojtik/origin/releases{/id}","created_at":"2014-08-14T13:11:47Z","updated_at":"2015-05-07T09:05:06Z","pushed_at":"2015-10-05T09:21:24Z","git_url":"git://github.com/mfojtik/origin.git","ssh_url":"git@github.com:mfojtik/origin.git","clone_url":"https://github.com/mfojtik/origin.git","svn_url":"https://github.com/mfojtik/origin","homepage":"https://openshift.github.io","size":145355,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"43899e777f6030c855607788ecaf2f140bbe5932","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-10-05T04:37:07Z","pushed_at":"2015-10-05T09:21:25Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":233881,"stargazers_count":717,"watchers_count":717,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":433,"mirror_url":null,"open_issues_count":562,"forks":433,"open_issues":562,"watchers":717,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/4906"},"html":{"href":"https://github.com/openshift/origin/pull/4906"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/4906"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/4906/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/4906/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/4906/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/01b35760f650888a79100db4b712bc20b9aad0f8"}}}}