{"action":"closed","number":93,"pull_request":{"url":"https://api.github.com/repos/Wildhoney/EmberDroplet/pulls/93","id":43814231,"html_url":"https://github.com/Wildhoney/EmberDroplet/pull/93","diff_url":"https://github.com/Wildhoney/EmberDroplet/pull/93.diff","patch_url":"https://github.com/Wildhoney/EmberDroplet/pull/93.patch","issue_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/issues/93","number":93,"state":"closed","locked":false,"title":"[Fix #91] Cannot specify options","user":{"login":"lardawge","id":35866,"avatar_url":"https://avatars.githubusercontent.com/u/35866?v=3","gravatar_id":"","url":"https://api.github.com/users/lardawge","html_url":"https://github.com/lardawge","followers_url":"https://api.github.com/users/lardawge/followers","following_url":"https://api.github.com/users/lardawge/following{/other_user}","gists_url":"https://api.github.com/users/lardawge/gists{/gist_id}","starred_url":"https://api.github.com/users/lardawge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lardawge/subscriptions","organizations_url":"https://api.github.com/users/lardawge/orgs","repos_url":"https://api.github.com/users/lardawge/repos","events_url":"https://api.github.com/users/lardawge/events{/privacy}","received_events_url":"https://api.github.com/users/lardawge/received_events","type":"User","site_admin":false},"body":"@Wildhoney \r\n\r\nTake a looksie at this. I was able to replicate the issue in the test and come up with a reasonable solution which included not sharing global setting. It makes it easier to determine if they have been overwritten. I also think it makes the second test obsolete and maybe better to test defaults...\r\n\r\nThoughts?","created_at":"2015-08-31T21:45:57Z","updated_at":"2015-10-15T08:12:01Z","closed_at":"2015-10-15T08:12:01Z","merged_at":null,"merge_commit_sha":"bf8cbf8df65b682f9bd08161589daa7476a581a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/pulls/93/commits","review_comments_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/pulls/93/comments","review_comment_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/issues/93/comments","statuses_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/statuses/b8b3f0bf853b3c429cf31055e798a011a2d43d9c","head":{"label":"lardawge:fix_settings_and_hook_bug","ref":"fix_settings_and_hook_bug","sha":"b8b3f0bf853b3c429cf31055e798a011a2d43d9c","user":{"login":"lardawge","id":35866,"avatar_url":"https://avatars.githubusercontent.com/u/35866?v=3","gravatar_id":"","url":"https://api.github.com/users/lardawge","html_url":"https://github.com/lardawge","followers_url":"https://api.github.com/users/lardawge/followers","following_url":"https://api.github.com/users/lardawge/following{/other_user}","gists_url":"https://api.github.com/users/lardawge/gists{/gist_id}","starred_url":"https://api.github.com/users/lardawge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lardawge/subscriptions","organizations_url":"https://api.github.com/users/lardawge/orgs","repos_url":"https://api.github.com/users/lardawge/repos","events_url":"https://api.github.com/users/lardawge/events{/privacy}","received_events_url":"https://api.github.com/users/lardawge/received_events","type":"User","site_admin":false},"repo":{"id":41572717,"name":"EmberDroplet","full_name":"lardawge/EmberDroplet","owner":{"login":"lardawge","id":35866,"avatar_url":"https://avatars.githubusercontent.com/u/35866?v=3","gravatar_id":"","url":"https://api.github.com/users/lardawge","html_url":"https://github.com/lardawge","followers_url":"https://api.github.com/users/lardawge/followers","following_url":"https://api.github.com/users/lardawge/following{/other_user}","gists_url":"https://api.github.com/users/lardawge/gists{/gist_id}","starred_url":"https://api.github.com/users/lardawge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lardawge/subscriptions","organizations_url":"https://api.github.com/users/lardawge/orgs","repos_url":"https://api.github.com/users/lardawge/repos","events_url":"https://api.github.com/users/lardawge/events{/privacy}","received_events_url":"https://api.github.com/users/lardawge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lardawge/EmberDroplet","description":"Ember.js HTML5 file uploading with drag & drop and image/file preview.","fork":true,"url":"https://api.github.com/repos/lardawge/EmberDroplet","forks_url":"https://api.github.com/repos/lardawge/EmberDroplet/forks","keys_url":"https://api.github.com/repos/lardawge/EmberDroplet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lardawge/EmberDroplet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lardawge/EmberDroplet/teams","hooks_url":"https://api.github.com/repos/lardawge/EmberDroplet/hooks","issue_events_url":"https://api.github.com/repos/lardawge/EmberDroplet/issues/events{/number}","events_url":"https://api.github.com/repos/lardawge/EmberDroplet/events","assignees_url":"https://api.github.com/repos/lardawge/EmberDroplet/assignees{/user}","branches_url":"https://api.github.com/repos/lardawge/EmberDroplet/branches{/branch}","tags_url":"https://api.github.com/repos/lardawge/EmberDroplet/tags","blobs_url":"https://api.github.com/repos/lardawge/EmberDroplet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lardawge/EmberDroplet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lardawge/EmberDroplet/git/refs{/sha}","trees_url":"https://api.github.com/repos/lardawge/EmberDroplet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lardawge/EmberDroplet/statuses/{sha}","languages_url":"https://api.github.com/repos/lardawge/EmberDroplet/languages","stargazers_url":"https://api.github.com/repos/lardawge/EmberDroplet/stargazers","contributors_url":"https://api.github.com/repos/lardawge/EmberDroplet/contributors","subscribers_url":"https://api.github.com/repos/lardawge/EmberDroplet/subscribers","subscription_url":"https://api.github.com/repos/lardawge/EmberDroplet/subscription","commits_url":"https://api.github.com/repos/lardawge/EmberDroplet/commits{/sha}","git_commits_url":"https://api.github.com/repos/lardawge/EmberDroplet/git/commits{/sha}","comments_url":"https://api.github.com/repos/lardawge/EmberDroplet/comments{/number}","issue_comment_url":"https://api.github.com/repos/lardawge/EmberDroplet/issues/comments{/number}","contents_url":"https://api.github.com/repos/lardawge/EmberDroplet/contents/{+path}","compare_url":"https://api.github.com/repos/lardawge/EmberDroplet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lardawge/EmberDroplet/merges","archive_url":"https://api.github.com/repos/lardawge/EmberDroplet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lardawge/EmberDroplet/downloads","issues_url":"https://api.github.com/repos/lardawge/EmberDroplet/issues{/number}","pulls_url":"https://api.github.com/repos/lardawge/EmberDroplet/pulls{/number}","milestones_url":"https://api.github.com/repos/lardawge/EmberDroplet/milestones{/number}","notifications_url":"https://api.github.com/repos/lardawge/EmberDroplet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lardawge/EmberDroplet/labels{/name}","releases_url":"https://api.github.com/repos/lardawge/EmberDroplet/releases{/id}","created_at":"2015-08-28T22:59:22Z","updated_at":"2015-08-28T22:59:22Z","pushed_at":"2015-09-01T00:21:09Z","git_url":"git://github.com/lardawge/EmberDroplet.git","ssh_url":"git@github.com:lardawge/EmberDroplet.git","clone_url":"https://github.com/lardawge/EmberDroplet.git","svn_url":"https://github.com/lardawge/EmberDroplet","homepage":"http://ember-droplet.herokuapp.com/","size":20973,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Wildhoney:master","ref":"master","sha":"02665cc21ad60a1c3344f9d99f1b61d9e6be925f","user":{"login":"Wildhoney","id":1528477,"avatar_url":"https://avatars.githubusercontent.com/u/1528477?v=3","gravatar_id":"","url":"https://api.github.com/users/Wildhoney","html_url":"https://github.com/Wildhoney","followers_url":"https://api.github.com/users/Wildhoney/followers","following_url":"https://api.github.com/users/Wildhoney/following{/other_user}","gists_url":"https://api.github.com/users/Wildhoney/gists{/gist_id}","starred_url":"https://api.github.com/users/Wildhoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wildhoney/subscriptions","organizations_url":"https://api.github.com/users/Wildhoney/orgs","repos_url":"https://api.github.com/users/Wildhoney/repos","events_url":"https://api.github.com/users/Wildhoney/events{/privacy}","received_events_url":"https://api.github.com/users/Wildhoney/received_events","type":"User","site_admin":false},"repo":{"id":10623444,"name":"EmberDroplet","full_name":"Wildhoney/EmberDroplet","owner":{"login":"Wildhoney","id":1528477,"avatar_url":"https://avatars.githubusercontent.com/u/1528477?v=3","gravatar_id":"","url":"https://api.github.com/users/Wildhoney","html_url":"https://github.com/Wildhoney","followers_url":"https://api.github.com/users/Wildhoney/followers","following_url":"https://api.github.com/users/Wildhoney/following{/other_user}","gists_url":"https://api.github.com/users/Wildhoney/gists{/gist_id}","starred_url":"https://api.github.com/users/Wildhoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wildhoney/subscriptions","organizations_url":"https://api.github.com/users/Wildhoney/orgs","repos_url":"https://api.github.com/users/Wildhoney/repos","events_url":"https://api.github.com/users/Wildhoney/events{/privacy}","received_events_url":"https://api.github.com/users/Wildhoney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Wildhoney/EmberDroplet","description":"Ember.js HTML5 file uploading with drag & drop and image/file preview.","fork":false,"url":"https://api.github.com/repos/Wildhoney/EmberDroplet","forks_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/forks","keys_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/teams","hooks_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/hooks","issue_events_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/issues/events{/number}","events_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/events","assignees_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/assignees{/user}","branches_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/branches{/branch}","tags_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/tags","blobs_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/statuses/{sha}","languages_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/languages","stargazers_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/stargazers","contributors_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/contributors","subscribers_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/subscribers","subscription_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/subscription","commits_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/contents/{+path}","compare_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/merges","archive_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/downloads","issues_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/issues{/number}","pulls_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/pulls{/number}","milestones_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/milestones{/number}","notifications_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/labels{/name}","releases_url":"https://api.github.com/repos/Wildhoney/EmberDroplet/releases{/id}","created_at":"2013-06-11T14:40:41Z","updated_at":"2015-09-26T06:00:45Z","pushed_at":"2015-10-15T08:11:25Z","git_url":"git://github.com/Wildhoney/EmberDroplet.git","ssh_url":"git@github.com:Wildhoney/EmberDroplet.git","clone_url":"https://github.com/Wildhoney/EmberDroplet.git","svn_url":"https://github.com/Wildhoney/EmberDroplet","homepage":"http://ember-droplet.herokuapp.com/","size":21733,"stargazers_count":186,"watchers_count":186,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":10,"forks":29,"open_issues":10,"watchers":186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wildhoney/EmberDroplet/pulls/93"},"html":{"href":"https://github.com/Wildhoney/EmberDroplet/pull/93"},"issue":{"href":"https://api.github.com/repos/Wildhoney/EmberDroplet/issues/93"},"comments":{"href":"https://api.github.com/repos/Wildhoney/EmberDroplet/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/Wildhoney/EmberDroplet/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/Wildhoney/EmberDroplet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wildhoney/EmberDroplet/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/Wildhoney/EmberDroplet/statuses/b8b3f0bf853b3c429cf31055e798a011a2d43d9c"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":46,"deletions":42,"changed_files":2}}