{"action":"created","comment":{"url":"https://api.github.com/repos/NetLogo/Tortoise/pulls/comments/32779560","id":32779560,"diff_hunk":"@@ -187,62 +161,25 @@ object BrowserCompiler {\n       compileResult.fold(compilationFailureJson, compilationSuccessJson)\n   }\n \n-  implicit object widgetCompilation2Json extends JsonWriter[WidgetCompilation] {\n-    import BrowserCompiler.compiledWidgets2Json\n-\n-    def apply(widgetCompilation: WidgetCompilation): TortoiseJson =\n-      widgetCompilation match {\n-        case NotCompiled              => JsObject(fields())\n-        case s: SourceCompilation     => Jsonify.writer[SourceCompilation, TortoiseJson](s)\n-        case u: UpdateableCompilation => Jsonify.writer[UpdateableCompilation, TortoiseJson](u)\n-        case p: PlotWidgetCompilation => Jsonify.writer[PlotWidgetCompilation, TortoiseJson](p)\n-        case s: SliderCompilation     => Jsonify.writer[SliderCompilation, TortoiseJson](s)\n-      }\n-  }\n-\n   implicit def exception2Json(ex: Throwable): JsonWritable =\n     JsonWriter.convert(ex)\n \n   implicit def failure2Json(f: Failure): JsonWritable =\n     JsonWriter.convert(f)\n \n-  implicit def compileWidget2Json(compiledWidget: CompiledWidget): JsonWritable =\n-    new JsonWritable {\n-      def toJsonObj = JsObject(\n-        widgetCompilation2Json(compiledWidget.widgetCompilation).asInstanceOf[JsObject].props ++\n-        compiledWidget.widgetData.toJsonObj.asInstanceOf[JsObject].props)\n-    }\n-\n   implicit def compilationResult2Json(modelCompilation: ValidationNel[Failure, ModelCompilation]): JsonWritable =\n     JsonWriter.convert(modelCompilation)\n \n-  case class CompiledWidget(widgetData: Widget, widgetCompilation: WidgetCompilation)\n-\n-  sealed trait WidgetCompilation\n-  case object NotCompiled extends WidgetCompilation\n-  case class SourceCompilation(\n-    compiledSource: CompiledStringV) extends WidgetCompilation\n-  case class UpdateableCompilation(\n-    compiledSetupCode: CompiledStringV,\n-    compiledUpdateCode: CompiledStringV) extends WidgetCompilation\n-  case class PlotWidgetCompilation(\n-    compiledSetupCode: CompiledStringV,\n-    compiledUpdateCode: CompiledStringV,\n-    compiledPens: Seq[CompiledWidget]) extends WidgetCompilation\n-  case class SliderCompilation(compiledMin: CompiledStringV,\n-    compiledMax: CompiledStringV,\n-    compiledStep: CompiledStringV) extends WidgetCompilation\n-\n   case class ModelCompilation(\n     result: String,\n     code: String,\n     info: String,\n-    widgets: Seq[CompiledWidget],\n+    widgets: List[JsObject],","path":"js/src/main/scala/BrowserCompiler.scala","position":116,"original_position":116,"commit_id":"de1fb3d517452d21bfc442f56765fe69c0e4526e","original_commit_id":"de1fb3d517452d21bfc442f56765fe69c0e4526e","user":{"login":"mrerrormessage","id":143198,"avatar_url":"https://avatars.githubusercontent.com/u/143198?v=3","gravatar_id":"","url":"https://api.github.com/users/mrerrormessage","html_url":"https://github.com/mrerrormessage","followers_url":"https://api.github.com/users/mrerrormessage/followers","following_url":"https://api.github.com/users/mrerrormessage/following{/other_user}","gists_url":"https://api.github.com/users/mrerrormessage/gists{/gist_id}","starred_url":"https://api.github.com/users/mrerrormessage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrerrormessage/subscriptions","organizations_url":"https://api.github.com/users/mrerrormessage/orgs","repos_url":"https://api.github.com/users/mrerrormessage/repos","events_url":"https://api.github.com/users/mrerrormessage/events{/privacy}","received_events_url":"https://api.github.com/users/mrerrormessage/received_events","type":"User","site_admin":false},"body":"I'll change it to a `Seq`. I think the reason for this was just that `widgets` in [NetLogo Headless `core.model`](https://github.com/NetLogo/NetLogo-Headless/blob/master/parser-core/src/main/core/Model.scala#L5) are contained in a `List`, and I happened to be flipping through that code a lot. I'll change it to a `Seq`. @SethTisue can change `Seq`s to be immutable, everyone wins.","created_at":"2015-06-18T21:17:35Z","updated_at":"2015-06-18T21:17:35Z","html_url":"https://github.com/NetLogo/Tortoise/pull/12#discussion_r32779560","pull_request_url":"https://api.github.com/repos/NetLogo/Tortoise/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/NetLogo/Tortoise/pulls/comments/32779560"},"html":{"href":"https://github.com/NetLogo/Tortoise/pull/12#discussion_r32779560"},"pull_request":{"href":"https://api.github.com/repos/NetLogo/Tortoise/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/NetLogo/Tortoise/pulls/12","id":35770159,"html_url":"https://github.com/NetLogo/Tortoise/pull/12","diff_url":"https://github.com/NetLogo/Tortoise/pull/12.diff","patch_url":"https://github.com/NetLogo/Tortoise/pull/12.patch","issue_url":"https://api.github.com/repos/NetLogo/Tortoise/issues/12","number":12,"state":"open","locked":false,"title":"docking tests: code in plots and monitors should run and be checked","user":{"login":"mrerrormessage","id":143198,"avatar_url":"https://avatars.githubusercontent.com/u/143198?v=3","gravatar_id":"","url":"https://api.github.com/users/mrerrormessage","html_url":"https://github.com/mrerrormessage","followers_url":"https://api.github.com/users/mrerrormessage/followers","following_url":"https://api.github.com/users/mrerrormessage/following{/other_user}","gists_url":"https://api.github.com/users/mrerrormessage/gists{/gist_id}","starred_url":"https://api.github.com/users/mrerrormessage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrerrormessage/subscriptions","organizations_url":"https://api.github.com/users/mrerrormessage/orgs","repos_url":"https://api.github.com/users/mrerrormessage/repos","events_url":"https://api.github.com/users/mrerrormessage/events{/privacy}","received_events_url":"https://api.github.com/users/mrerrormessage/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-19T20:17:44Z","updated_at":"2015-06-18T21:17:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f8f8b9d18715ff9b1df602daa63093642bdc47c","assignee":{"login":"mrerrormessage","id":143198,"avatar_url":"https://avatars.githubusercontent.com/u/143198?v=3","gravatar_id":"","url":"https://api.github.com/users/mrerrormessage","html_url":"https://github.com/mrerrormessage","followers_url":"https://api.github.com/users/mrerrormessage/followers","following_url":"https://api.github.com/users/mrerrormessage/following{/other_user}","gists_url":"https://api.github.com/users/mrerrormessage/gists{/gist_id}","starred_url":"https://api.github.com/users/mrerrormessage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrerrormessage/subscriptions","organizations_url":"https://api.github.com/users/mrerrormessage/orgs","repos_url":"https://api.github.com/users/mrerrormessage/repos","events_url":"https://api.github.com/users/mrerrormessage/events{/privacy}","received_events_url":"https://api.github.com/users/mrerrormessage/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/NetLogo/Tortoise/milestones/1","html_url":"https://github.com/NetLogo/Tortoise/milestones/1.0","labels_url":"https://api.github.com/repos/NetLogo/Tortoise/milestones/1/labels","id":969158,"number":1,"title":"1.0","description":"The first official release of Tortoise.  It doesn't have to be beautiful, but it needs to be not-awful for users.","creator":{"login":"TheBizzle","id":912890,"avatar_url":"https://avatars.githubusercontent.com/u/912890?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBizzle","html_url":"https://github.com/TheBizzle","followers_url":"https://api.github.com/users/TheBizzle/followers","following_url":"https://api.github.com/users/TheBizzle/following{/other_user}","gists_url":"https://api.github.com/users/TheBizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBizzle/subscriptions","organizations_url":"https://api.github.com/users/TheBizzle/orgs","repos_url":"https://api.github.com/users/TheBizzle/repos","events_url":"https://api.github.com/users/TheBizzle/events{/privacy}","received_events_url":"https://api.github.com/users/TheBizzle/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":10,"state":"open","created_at":"2015-02-06T18:11:34Z","updated_at":"2015-06-18T19:57:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/NetLogo/Tortoise/pulls/12/commits","review_comments_url":"https://api.github.com/repos/NetLogo/Tortoise/pulls/12/comments","review_comment_url":"https://api.github.com/repos/NetLogo/Tortoise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetLogo/Tortoise/issues/12/comments","statuses_url":"https://api.github.com/repos/NetLogo/Tortoise/statuses/de1fb3d517452d21bfc442f56765fe69c0e4526e","head":{"label":"NetLogo:wip-test-monitors-docked","ref":"wip-test-monitors-docked","sha":"de1fb3d517452d21bfc442f56765fe69c0e4526e","user":{"login":"NetLogo","id":767367,"avatar_url":"https://avatars.githubusercontent.com/u/767367?v=3","gravatar_id":"","url":"https://api.github.com/users/NetLogo","html_url":"https://github.com/NetLogo","followers_url":"https://api.github.com/users/NetLogo/followers","following_url":"https://api.github.com/users/NetLogo/following{/other_user}","gists_url":"https://api.github.com/users/NetLogo/gists{/gist_id}","starred_url":"https://api.github.com/users/NetLogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetLogo/subscriptions","organizations_url":"https://api.github.com/users/NetLogo/orgs","repos_url":"https://api.github.com/users/NetLogo/repos","events_url":"https://api.github.com/users/NetLogo/events{/privacy}","received_events_url":"https://api.github.com/users/NetLogo/received_events","type":"Organization","site_admin":false},"repo":{"id":13257961,"name":"Tortoise","full_name":"NetLogo/Tortoise","owner":{"login":"NetLogo","id":767367,"avatar_url":"https://avatars.githubusercontent.com/u/767367?v=3","gravatar_id":"","url":"https://api.github.com/users/NetLogo","html_url":"https://github.com/NetLogo","followers_url":"https://api.github.com/users/NetLogo/followers","following_url":"https://api.github.com/users/NetLogo/following{/other_user}","gists_url":"https://api.github.com/users/NetLogo/gists{/gist_id}","starred_url":"https://api.github.com/users/NetLogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetLogo/subscriptions","organizations_url":"https://api.github.com/users/NetLogo/orgs","repos_url":"https://api.github.com/users/NetLogo/repos","events_url":"https://api.github.com/users/NetLogo/events{/privacy}","received_events_url":"https://api.github.com/users/NetLogo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetLogo/Tortoise","description":"JavaScript-based runtime for NetLogo","fork":false,"url":"https://api.github.com/repos/NetLogo/Tortoise","forks_url":"https://api.github.com/repos/NetLogo/Tortoise/forks","keys_url":"https://api.github.com/repos/NetLogo/Tortoise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetLogo/Tortoise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetLogo/Tortoise/teams","hooks_url":"https://api.github.com/repos/NetLogo/Tortoise/hooks","issue_events_url":"https://api.github.com/repos/NetLogo/Tortoise/issues/events{/number}","events_url":"https://api.github.com/repos/NetLogo/Tortoise/events","assignees_url":"https://api.github.com/repos/NetLogo/Tortoise/assignees{/user}","branches_url":"https://api.github.com/repos/NetLogo/Tortoise/branches{/branch}","tags_url":"https://api.github.com/repos/NetLogo/Tortoise/tags","blobs_url":"https://api.github.com/repos/NetLogo/Tortoise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetLogo/Tortoise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetLogo/Tortoise/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetLogo/Tortoise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetLogo/Tortoise/statuses/{sha}","languages_url":"https://api.github.com/repos/NetLogo/Tortoise/languages","stargazers_url":"https://api.github.com/repos/NetLogo/Tortoise/stargazers","contributors_url":"https://api.github.com/repos/NetLogo/Tortoise/contributors","subscribers_url":"https://api.github.com/repos/NetLogo/Tortoise/subscribers","subscription_url":"https://api.github.com/repos/NetLogo/Tortoise/subscription","commits_url":"https://api.github.com/repos/NetLogo/Tortoise/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetLogo/Tortoise/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetLogo/Tortoise/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetLogo/Tortoise/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetLogo/Tortoise/contents/{+path}","compare_url":"https://api.github.com/repos/NetLogo/Tortoise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetLogo/Tortoise/merges","archive_url":"https://api.github.com/repos/NetLogo/Tortoise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetLogo/Tortoise/downloads","issues_url":"https://api.github.com/repos/NetLogo/Tortoise/issues{/number}","pulls_url":"https://api.github.com/repos/NetLogo/Tortoise/pulls{/number}","milestones_url":"https://api.github.com/repos/NetLogo/Tortoise/milestones{/number}","notifications_url":"https://api.github.com/repos/NetLogo/Tortoise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetLogo/Tortoise/labels{/name}","releases_url":"https://api.github.com/repos/NetLogo/Tortoise/releases{/id}","created_at":"2013-10-01T22:59:33Z","updated_at":"2015-06-10T15:08:11Z","pushed_at":"2015-06-18T19:57:07Z","git_url":"git://github.com/NetLogo/Tortoise.git","ssh_url":"git@github.com:NetLogo/Tortoise.git","clone_url":"https://github.com/NetLogo/Tortoise.git","svn_url":"https://github.com/NetLogo/Tortoise","homepage":null,"size":34419,"stargazers_count":9,"watchers_count":9,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":9,"default_branch":"master"}},"base":{"label":"NetLogo:master","ref":"master","sha":"6f41b08037b17227d8a4dd60a23a3893a5e1f945","user":{"login":"NetLogo","id":767367,"avatar_url":"https://avatars.githubusercontent.com/u/767367?v=3","gravatar_id":"","url":"https://api.github.com/users/NetLogo","html_url":"https://github.com/NetLogo","followers_url":"https://api.github.com/users/NetLogo/followers","following_url":"https://api.github.com/users/NetLogo/following{/other_user}","gists_url":"https://api.github.com/users/NetLogo/gists{/gist_id}","starred_url":"https://api.github.com/users/NetLogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetLogo/subscriptions","organizations_url":"https://api.github.com/users/NetLogo/orgs","repos_url":"https://api.github.com/users/NetLogo/repos","events_url":"https://api.github.com/users/NetLogo/events{/privacy}","received_events_url":"https://api.github.com/users/NetLogo/received_events","type":"Organization","site_admin":false},"repo":{"id":13257961,"name":"Tortoise","full_name":"NetLogo/Tortoise","owner":{"login":"NetLogo","id":767367,"avatar_url":"https://avatars.githubusercontent.com/u/767367?v=3","gravatar_id":"","url":"https://api.github.com/users/NetLogo","html_url":"https://github.com/NetLogo","followers_url":"https://api.github.com/users/NetLogo/followers","following_url":"https://api.github.com/users/NetLogo/following{/other_user}","gists_url":"https://api.github.com/users/NetLogo/gists{/gist_id}","starred_url":"https://api.github.com/users/NetLogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetLogo/subscriptions","organizations_url":"https://api.github.com/users/NetLogo/orgs","repos_url":"https://api.github.com/users/NetLogo/repos","events_url":"https://api.github.com/users/NetLogo/events{/privacy}","received_events_url":"https://api.github.com/users/NetLogo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetLogo/Tortoise","description":"JavaScript-based runtime for NetLogo","fork":false,"url":"https://api.github.com/repos/NetLogo/Tortoise","forks_url":"https://api.github.com/repos/NetLogo/Tortoise/forks","keys_url":"https://api.github.com/repos/NetLogo/Tortoise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetLogo/Tortoise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetLogo/Tortoise/teams","hooks_url":"https://api.github.com/repos/NetLogo/Tortoise/hooks","issue_events_url":"https://api.github.com/repos/NetLogo/Tortoise/issues/events{/number}","events_url":"https://api.github.com/repos/NetLogo/Tortoise/events","assignees_url":"https://api.github.com/repos/NetLogo/Tortoise/assignees{/user}","branches_url":"https://api.github.com/repos/NetLogo/Tortoise/branches{/branch}","tags_url":"https://api.github.com/repos/NetLogo/Tortoise/tags","blobs_url":"https://api.github.com/repos/NetLogo/Tortoise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetLogo/Tortoise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetLogo/Tortoise/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetLogo/Tortoise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetLogo/Tortoise/statuses/{sha}","languages_url":"https://api.github.com/repos/NetLogo/Tortoise/languages","stargazers_url":"https://api.github.com/repos/NetLogo/Tortoise/stargazers","contributors_url":"https://api.github.com/repos/NetLogo/Tortoise/contributors","subscribers_url":"https://api.github.com/repos/NetLogo/Tortoise/subscribers","subscription_url":"https://api.github.com/repos/NetLogo/Tortoise/subscription","commits_url":"https://api.github.com/repos/NetLogo/Tortoise/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetLogo/Tortoise/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetLogo/Tortoise/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetLogo/Tortoise/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetLogo/Tortoise/contents/{+path}","compare_url":"https://api.github.com/repos/NetLogo/Tortoise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetLogo/Tortoise/merges","archive_url":"https://api.github.com/repos/NetLogo/Tortoise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetLogo/Tortoise/downloads","issues_url":"https://api.github.com/repos/NetLogo/Tortoise/issues{/number}","pulls_url":"https://api.github.com/repos/NetLogo/Tortoise/pulls{/number}","milestones_url":"https://api.github.com/repos/NetLogo/Tortoise/milestones{/number}","notifications_url":"https://api.github.com/repos/NetLogo/Tortoise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetLogo/Tortoise/labels{/name}","releases_url":"https://api.github.com/repos/NetLogo/Tortoise/releases{/id}","created_at":"2013-10-01T22:59:33Z","updated_at":"2015-06-10T15:08:11Z","pushed_at":"2015-06-18T19:57:07Z","git_url":"git://github.com/NetLogo/Tortoise.git","ssh_url":"git@github.com:NetLogo/Tortoise.git","clone_url":"https://github.com/NetLogo/Tortoise.git","svn_url":"https://github.com/NetLogo/Tortoise","homepage":null,"size":34419,"stargazers_count":9,"watchers_count":9,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NetLogo/Tortoise/pulls/12"},"html":{"href":"https://github.com/NetLogo/Tortoise/pull/12"},"issue":{"href":"https://api.github.com/repos/NetLogo/Tortoise/issues/12"},"comments":{"href":"https://api.github.com/repos/NetLogo/Tortoise/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/NetLogo/Tortoise/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/NetLogo/Tortoise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetLogo/Tortoise/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/NetLogo/Tortoise/statuses/de1fb3d517452d21bfc442f56765fe69c0e4526e"}}}}