{"action":"created","comment":{"url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/comments/46538321","id":46538321,"diff_hunk":"@@ -89,7 +89,7 @@ public void registerNode(Node node) throws NodeAlreadyRegisteredException\n \tpublic void clearRegisteredNode(Node node) {\n \t\tString normalizedPath = node.dir().getAbsolutePath();\n \t\tList<Node> nodesForPath = nodeCache.get(normalizedPath);\n-\t\tnodesForPath.remove(node.getTypeName());\n+\t\tnodesForPath.remove(node);","path":"brjs-core/src/main/java/org/bladerunnerjs/model/engine/AbstractRootNode.java","position":5,"original_position":5,"commit_id":"14f75cbdd937e2b6f187ff7dd051dcd0861d63df","original_commit_id":"14f75cbdd937e2b6f187ff7dd051dcd0861d63df","user":{"login":"andyberry88","id":726896,"avatar_url":"https://avatars.githubusercontent.com/u/726896?v=3","gravatar_id":"","url":"https://api.github.com/users/andyberry88","html_url":"https://github.com/andyberry88","followers_url":"https://api.github.com/users/andyberry88/followers","following_url":"https://api.github.com/users/andyberry88/following{/other_user}","gists_url":"https://api.github.com/users/andyberry88/gists{/gist_id}","starred_url":"https://api.github.com/users/andyberry88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyberry88/subscriptions","organizations_url":"https://api.github.com/users/andyberry88/orgs","repos_url":"https://api.github.com/users/andyberry88/repos","events_url":"https://api.github.com/users/andyberry88/events{/privacy}","received_events_url":"https://api.github.com/users/andyberry88/received_events","type":"User","site_admin":false},"body":"Is there a test that proves this should be `node` not `node.getTypeName()`?","created_at":"2015-12-03T11:03:39Z","updated_at":"2015-12-03T11:03:39Z","html_url":"https://github.com/BladeRunnerJS/brjs/pull/1614#discussion_r46538321","pull_request_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1614","_links":{"self":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/comments/46538321"},"html":{"href":"https://github.com/BladeRunnerJS/brjs/pull/1614#discussion_r46538321"},"pull_request":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1614"}}},"pull_request":{"url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1614","id":52415013,"html_url":"https://github.com/BladeRunnerJS/brjs/pull/1614","diff_url":"https://github.com/BladeRunnerJS/brjs/pull/1614.diff","patch_url":"https://github.com/BladeRunnerJS/brjs/pull/1614.patch","issue_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1614","number":1614,"state":"open","locked":false,"title":"Bugfix clearnode now removes the node","user":{"login":"thecapdan","id":6085260,"avatar_url":"https://avatars.githubusercontent.com/u/6085260?v=3","gravatar_id":"","url":"https://api.github.com/users/thecapdan","html_url":"https://github.com/thecapdan","followers_url":"https://api.github.com/users/thecapdan/followers","following_url":"https://api.github.com/users/thecapdan/following{/other_user}","gists_url":"https://api.github.com/users/thecapdan/gists{/gist_id}","starred_url":"https://api.github.com/users/thecapdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecapdan/subscriptions","organizations_url":"https://api.github.com/users/thecapdan/orgs","repos_url":"https://api.github.com/users/thecapdan/repos","events_url":"https://api.github.com/users/thecapdan/events{/privacy}","received_events_url":"https://api.github.com/users/thecapdan/received_events","type":"User","site_admin":false},"body":"previously the remove method was being passed a string which would not clear the node\r\n\r\n<!---\r\n@huboard:{\"order\":1618.5,\"milestone_order\":1614,\"custom_state\":\"\"}\n-->\r\n","created_at":"2015-12-02T16:02:56Z","updated_at":"2015-12-03T11:03:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21acc3cbb93f8afb553c75b207326320f7583494","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1614/commits","review_comments_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1614/comments","review_comment_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1614/comments","statuses_url":"https://api.github.com/repos/BladeRunnerJS/brjs/statuses/14f75cbdd937e2b6f187ff7dd051dcd0861d63df","head":{"label":"BladeRunnerJS:bugfix-clearnode-now-removes-the-node","ref":"bugfix-clearnode-now-removes-the-node","sha":"14f75cbdd937e2b6f187ff7dd051dcd0861d63df","user":{"login":"BladeRunnerJS","id":5066144,"avatar_url":"https://avatars.githubusercontent.com/u/5066144?v=3","gravatar_id":"","url":"https://api.github.com/users/BladeRunnerJS","html_url":"https://github.com/BladeRunnerJS","followers_url":"https://api.github.com/users/BladeRunnerJS/followers","following_url":"https://api.github.com/users/BladeRunnerJS/following{/other_user}","gists_url":"https://api.github.com/users/BladeRunnerJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BladeRunnerJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BladeRunnerJS/subscriptions","organizations_url":"https://api.github.com/users/BladeRunnerJS/orgs","repos_url":"https://api.github.com/users/BladeRunnerJS/repos","events_url":"https://api.github.com/users/BladeRunnerJS/events{/privacy}","received_events_url":"https://api.github.com/users/BladeRunnerJS/received_events","type":"Organization","site_admin":false},"repo":{"id":11682819,"name":"brjs","full_name":"BladeRunnerJS/brjs","owner":{"login":"BladeRunnerJS","id":5066144,"avatar_url":"https://avatars.githubusercontent.com/u/5066144?v=3","gravatar_id":"","url":"https://api.github.com/users/BladeRunnerJS","html_url":"https://github.com/BladeRunnerJS","followers_url":"https://api.github.com/users/BladeRunnerJS/followers","following_url":"https://api.github.com/users/BladeRunnerJS/following{/other_user}","gists_url":"https://api.github.com/users/BladeRunnerJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BladeRunnerJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BladeRunnerJS/subscriptions","organizations_url":"https://api.github.com/users/BladeRunnerJS/orgs","repos_url":"https://api.github.com/users/BladeRunnerJS/repos","events_url":"https://api.github.com/users/BladeRunnerJS/events{/privacy}","received_events_url":"https://api.github.com/users/BladeRunnerJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BladeRunnerJS/brjs","description":"BladeRunnerJS (BRJS) is an open source development toolkit and framework for modular construction of large single-page HTML5 apps. It consists of a set of conventions, supporting tools and micro-libraries that make it easy to develop, test, deploy and maintain complex JavaScript apps.","fork":false,"url":"https://api.github.com/repos/BladeRunnerJS/brjs","forks_url":"https://api.github.com/repos/BladeRunnerJS/brjs/forks","keys_url":"https://api.github.com/repos/BladeRunnerJS/brjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BladeRunnerJS/brjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BladeRunnerJS/brjs/teams","hooks_url":"https://api.github.com/repos/BladeRunnerJS/brjs/hooks","issue_events_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/events{/number}","events_url":"https://api.github.com/repos/BladeRunnerJS/brjs/events","assignees_url":"https://api.github.com/repos/BladeRunnerJS/brjs/assignees{/user}","branches_url":"https://api.github.com/repos/BladeRunnerJS/brjs/branches{/branch}","tags_url":"https://api.github.com/repos/BladeRunnerJS/brjs/tags","blobs_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BladeRunnerJS/brjs/statuses/{sha}","languages_url":"https://api.github.com/repos/BladeRunnerJS/brjs/languages","stargazers_url":"https://api.github.com/repos/BladeRunnerJS/brjs/stargazers","contributors_url":"https://api.github.com/repos/BladeRunnerJS/brjs/contributors","subscribers_url":"https://api.github.com/repos/BladeRunnerJS/brjs/subscribers","subscription_url":"https://api.github.com/repos/BladeRunnerJS/brjs/subscription","commits_url":"https://api.github.com/repos/BladeRunnerJS/brjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/BladeRunnerJS/brjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/BladeRunnerJS/brjs/contents/{+path}","compare_url":"https://api.github.com/repos/BladeRunnerJS/brjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BladeRunnerJS/brjs/merges","archive_url":"https://api.github.com/repos/BladeRunnerJS/brjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BladeRunnerJS/brjs/downloads","issues_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues{/number}","pulls_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls{/number}","milestones_url":"https://api.github.com/repos/BladeRunnerJS/brjs/milestones{/number}","notifications_url":"https://api.github.com/repos/BladeRunnerJS/brjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BladeRunnerJS/brjs/labels{/name}","releases_url":"https://api.github.com/repos/BladeRunnerJS/brjs/releases{/id}","created_at":"2013-07-26T09:49:40Z","updated_at":"2015-12-03T08:04:36Z","pushed_at":"2015-12-03T10:51:49Z","git_url":"git://github.com/BladeRunnerJS/brjs.git","ssh_url":"git@github.com:BladeRunnerJS/brjs.git","clone_url":"https://github.com/BladeRunnerJS/brjs.git","svn_url":"https://github.com/BladeRunnerJS/brjs","homepage":"http://bladerunnerjs.org/","size":96309,"stargazers_count":218,"watchers_count":218,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":198,"forks":36,"open_issues":198,"watchers":218,"default_branch":"master"}},"base":{"label":"BladeRunnerJS:master","ref":"master","sha":"da69718fb39f36e2289fe0919b99607896195b4a","user":{"login":"BladeRunnerJS","id":5066144,"avatar_url":"https://avatars.githubusercontent.com/u/5066144?v=3","gravatar_id":"","url":"https://api.github.com/users/BladeRunnerJS","html_url":"https://github.com/BladeRunnerJS","followers_url":"https://api.github.com/users/BladeRunnerJS/followers","following_url":"https://api.github.com/users/BladeRunnerJS/following{/other_user}","gists_url":"https://api.github.com/users/BladeRunnerJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BladeRunnerJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BladeRunnerJS/subscriptions","organizations_url":"https://api.github.com/users/BladeRunnerJS/orgs","repos_url":"https://api.github.com/users/BladeRunnerJS/repos","events_url":"https://api.github.com/users/BladeRunnerJS/events{/privacy}","received_events_url":"https://api.github.com/users/BladeRunnerJS/received_events","type":"Organization","site_admin":false},"repo":{"id":11682819,"name":"brjs","full_name":"BladeRunnerJS/brjs","owner":{"login":"BladeRunnerJS","id":5066144,"avatar_url":"https://avatars.githubusercontent.com/u/5066144?v=3","gravatar_id":"","url":"https://api.github.com/users/BladeRunnerJS","html_url":"https://github.com/BladeRunnerJS","followers_url":"https://api.github.com/users/BladeRunnerJS/followers","following_url":"https://api.github.com/users/BladeRunnerJS/following{/other_user}","gists_url":"https://api.github.com/users/BladeRunnerJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BladeRunnerJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BladeRunnerJS/subscriptions","organizations_url":"https://api.github.com/users/BladeRunnerJS/orgs","repos_url":"https://api.github.com/users/BladeRunnerJS/repos","events_url":"https://api.github.com/users/BladeRunnerJS/events{/privacy}","received_events_url":"https://api.github.com/users/BladeRunnerJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BladeRunnerJS/brjs","description":"BladeRunnerJS (BRJS) is an open source development toolkit and framework for modular construction of large single-page HTML5 apps. It consists of a set of conventions, supporting tools and micro-libraries that make it easy to develop, test, deploy and maintain complex JavaScript apps.","fork":false,"url":"https://api.github.com/repos/BladeRunnerJS/brjs","forks_url":"https://api.github.com/repos/BladeRunnerJS/brjs/forks","keys_url":"https://api.github.com/repos/BladeRunnerJS/brjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BladeRunnerJS/brjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BladeRunnerJS/brjs/teams","hooks_url":"https://api.github.com/repos/BladeRunnerJS/brjs/hooks","issue_events_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/events{/number}","events_url":"https://api.github.com/repos/BladeRunnerJS/brjs/events","assignees_url":"https://api.github.com/repos/BladeRunnerJS/brjs/assignees{/user}","branches_url":"https://api.github.com/repos/BladeRunnerJS/brjs/branches{/branch}","tags_url":"https://api.github.com/repos/BladeRunnerJS/brjs/tags","blobs_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BladeRunnerJS/brjs/statuses/{sha}","languages_url":"https://api.github.com/repos/BladeRunnerJS/brjs/languages","stargazers_url":"https://api.github.com/repos/BladeRunnerJS/brjs/stargazers","contributors_url":"https://api.github.com/repos/BladeRunnerJS/brjs/contributors","subscribers_url":"https://api.github.com/repos/BladeRunnerJS/brjs/subscribers","subscription_url":"https://api.github.com/repos/BladeRunnerJS/brjs/subscription","commits_url":"https://api.github.com/repos/BladeRunnerJS/brjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/BladeRunnerJS/brjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/BladeRunnerJS/brjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/BladeRunnerJS/brjs/contents/{+path}","compare_url":"https://api.github.com/repos/BladeRunnerJS/brjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BladeRunnerJS/brjs/merges","archive_url":"https://api.github.com/repos/BladeRunnerJS/brjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BladeRunnerJS/brjs/downloads","issues_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues{/number}","pulls_url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls{/number}","milestones_url":"https://api.github.com/repos/BladeRunnerJS/brjs/milestones{/number}","notifications_url":"https://api.github.com/repos/BladeRunnerJS/brjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BladeRunnerJS/brjs/labels{/name}","releases_url":"https://api.github.com/repos/BladeRunnerJS/brjs/releases{/id}","created_at":"2013-07-26T09:49:40Z","updated_at":"2015-12-03T08:04:36Z","pushed_at":"2015-12-03T10:51:49Z","git_url":"git://github.com/BladeRunnerJS/brjs.git","ssh_url":"git@github.com:BladeRunnerJS/brjs.git","clone_url":"https://github.com/BladeRunnerJS/brjs.git","svn_url":"https://github.com/BladeRunnerJS/brjs","homepage":"http://bladerunnerjs.org/","size":96309,"stargazers_count":218,"watchers_count":218,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":198,"forks":36,"open_issues":198,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1614"},"html":{"href":"https://github.com/BladeRunnerJS/brjs/pull/1614"},"issue":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1614"},"comments":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1614/comments"},"review_comments":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1614/comments"},"review_comment":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1614/commits"},"statuses":{"href":"https://api.github.com/repos/BladeRunnerJS/brjs/statuses/14f75cbdd937e2b6f187ff7dd051dcd0861d63df"}}}}