{"action":"created","comment":{"url":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/comments/43764666","id":43764666,"diff_hunk":"@@ -34,7 +34,7 @@\n  *\r\n  * @author bjornl\r\n  */\r\n-public class ComponentPresentationImpl implements ComponentPresentation {\r\n+public class ComponentPresentationImpl extends AbstractModel implements ComponentPresentation {\r","path":"dd4t-core/src/main/java/org/dd4t/contentmodel/impl/ComponentPresentationImpl.java","position":5,"original_position":5,"commit_id":"eabfc74b19a16aa503c4c17b6a0a4366982d1197","original_commit_id":"eabfc74b19a16aa503c4c17b6a0a4366982d1197","user":{"login":"RaimondKempees","id":4125105,"avatar_url":"https://avatars.githubusercontent.com/u/4125105?v=3","gravatar_id":"","url":"https://api.github.com/users/RaimondKempees","html_url":"https://github.com/RaimondKempees","followers_url":"https://api.github.com/users/RaimondKempees/followers","following_url":"https://api.github.com/users/RaimondKempees/following{/other_user}","gists_url":"https://api.github.com/users/RaimondKempees/gists{/gist_id}","starred_url":"https://api.github.com/users/RaimondKempees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaimondKempees/subscriptions","organizations_url":"https://api.github.com/users/RaimondKempees/orgs","repos_url":"https://api.github.com/users/RaimondKempees/repos","events_url":"https://api.github.com/users/RaimondKempees/events{/privacy}","received_events_url":"https://api.github.com/users/RaimondKempees/received_events","type":"User","site_admin":false},"body":"This will break backward compatibility in case the eclId is not present in the Json","created_at":"2015-11-03T15:52:08Z","updated_at":"2015-11-03T15:52:08Z","html_url":"https://github.com/dd4t/dd4t-2-java/pull/26#discussion_r43764666","pull_request_url":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/comments/43764666"},"html":{"href":"https://github.com/dd4t/dd4t-2-java/pull/26#discussion_r43764666"},"pull_request":{"href":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/26","id":47800874,"html_url":"https://github.com/dd4t/dd4t-2-java/pull/26","diff_url":"https://github.com/dd4t/dd4t-2-java/pull/26.diff","patch_url":"https://github.com/dd4t/dd4t-2-java/pull/26.patch","issue_url":"https://api.github.com/repos/dd4t/dd4t-2-java/issues/26","number":26,"state":"open","locked":false,"title":"Ecl data","user":{"login":"rpannekoek","id":4688784,"avatar_url":"https://avatars.githubusercontent.com/u/4688784?v=3","gravatar_id":"","url":"https://api.github.com/users/rpannekoek","html_url":"https://github.com/rpannekoek","followers_url":"https://api.github.com/users/rpannekoek/followers","following_url":"https://api.github.com/users/rpannekoek/following{/other_user}","gists_url":"https://api.github.com/users/rpannekoek/gists{/gist_id}","starred_url":"https://api.github.com/users/rpannekoek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpannekoek/subscriptions","organizations_url":"https://api.github.com/users/rpannekoek/orgs","repos_url":"https://api.github.com/users/rpannekoek/repos","events_url":"https://api.github.com/users/rpannekoek/events{/privacy}","received_events_url":"https://api.github.com/users/rpannekoek/received_events","type":"User","site_admin":false},"body":"Added support for additional ECL data using a general extension mechanism, as discussed earlier:\r\n Model.ExtensionData\r\n Component.EclId","created_at":"2015-10-15T15:19:43Z","updated_at":"2015-11-03T15:52:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34ae76667eb274316c44784afa44967cc8a5d969","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/26/commits","review_comments_url":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/26/comments","review_comment_url":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dd4t/dd4t-2-java/issues/26/comments","statuses_url":"https://api.github.com/repos/dd4t/dd4t-2-java/statuses/eabfc74b19a16aa503c4c17b6a0a4366982d1197","head":{"label":"sdl:ecl-data","ref":"ecl-data","sha":"eabfc74b19a16aa503c4c17b6a0a4366982d1197","user":{"login":"sdl","id":7047555,"avatar_url":"https://avatars.githubusercontent.com/u/7047555?v=3","gravatar_id":"","url":"https://api.github.com/users/sdl","html_url":"https://github.com/sdl","followers_url":"https://api.github.com/users/sdl/followers","following_url":"https://api.github.com/users/sdl/following{/other_user}","gists_url":"https://api.github.com/users/sdl/gists{/gist_id}","starred_url":"https://api.github.com/users/sdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdl/subscriptions","organizations_url":"https://api.github.com/users/sdl/orgs","repos_url":"https://api.github.com/users/sdl/repos","events_url":"https://api.github.com/users/sdl/events{/privacy}","received_events_url":"https://api.github.com/users/sdl/received_events","type":"Organization","site_admin":false},"repo":{"id":43434514,"name":"dd4t-2-java","full_name":"sdl/dd4t-2-java","owner":{"login":"sdl","id":7047555,"avatar_url":"https://avatars.githubusercontent.com/u/7047555?v=3","gravatar_id":"","url":"https://api.github.com/users/sdl","html_url":"https://github.com/sdl","followers_url":"https://api.github.com/users/sdl/followers","following_url":"https://api.github.com/users/sdl/following{/other_user}","gists_url":"https://api.github.com/users/sdl/gists{/gist_id}","starred_url":"https://api.github.com/users/sdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdl/subscriptions","organizations_url":"https://api.github.com/users/sdl/orgs","repos_url":"https://api.github.com/users/sdl/repos","events_url":"https://api.github.com/users/sdl/events{/privacy}","received_events_url":"https://api.github.com/users/sdl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sdl/dd4t-2-java","description":"","fork":true,"url":"https://api.github.com/repos/sdl/dd4t-2-java","forks_url":"https://api.github.com/repos/sdl/dd4t-2-java/forks","keys_url":"https://api.github.com/repos/sdl/dd4t-2-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdl/dd4t-2-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdl/dd4t-2-java/teams","hooks_url":"https://api.github.com/repos/sdl/dd4t-2-java/hooks","issue_events_url":"https://api.github.com/repos/sdl/dd4t-2-java/issues/events{/number}","events_url":"https://api.github.com/repos/sdl/dd4t-2-java/events","assignees_url":"https://api.github.com/repos/sdl/dd4t-2-java/assignees{/user}","branches_url":"https://api.github.com/repos/sdl/dd4t-2-java/branches{/branch}","tags_url":"https://api.github.com/repos/sdl/dd4t-2-java/tags","blobs_url":"https://api.github.com/repos/sdl/dd4t-2-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdl/dd4t-2-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdl/dd4t-2-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdl/dd4t-2-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdl/dd4t-2-java/statuses/{sha}","languages_url":"https://api.github.com/repos/sdl/dd4t-2-java/languages","stargazers_url":"https://api.github.com/repos/sdl/dd4t-2-java/stargazers","contributors_url":"https://api.github.com/repos/sdl/dd4t-2-java/contributors","subscribers_url":"https://api.github.com/repos/sdl/dd4t-2-java/subscribers","subscription_url":"https://api.github.com/repos/sdl/dd4t-2-java/subscription","commits_url":"https://api.github.com/repos/sdl/dd4t-2-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdl/dd4t-2-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdl/dd4t-2-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdl/dd4t-2-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdl/dd4t-2-java/contents/{+path}","compare_url":"https://api.github.com/repos/sdl/dd4t-2-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdl/dd4t-2-java/merges","archive_url":"https://api.github.com/repos/sdl/dd4t-2-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdl/dd4t-2-java/downloads","issues_url":"https://api.github.com/repos/sdl/dd4t-2-java/issues{/number}","pulls_url":"https://api.github.com/repos/sdl/dd4t-2-java/pulls{/number}","milestones_url":"https://api.github.com/repos/sdl/dd4t-2-java/milestones{/number}","notifications_url":"https://api.github.com/repos/sdl/dd4t-2-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdl/dd4t-2-java/labels{/name}","releases_url":"https://api.github.com/repos/sdl/dd4t-2-java/releases{/id}","created_at":"2015-09-30T13:28:30Z","updated_at":"2015-09-30T13:28:32Z","pushed_at":"2015-11-03T15:20:59Z","git_url":"git://github.com/sdl/dd4t-2-java.git","ssh_url":"git@github.com:sdl/dd4t-2-java.git","clone_url":"https://github.com/sdl/dd4t-2-java.git","svn_url":"https://github.com/sdl/dd4t-2-java","homepage":null,"size":14028,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"dd4t:develop","ref":"develop","sha":"81c59083131502a89d0a4e3c492a431c997dca93","user":{"login":"dd4t","id":8267590,"avatar_url":"https://avatars.githubusercontent.com/u/8267590?v=3","gravatar_id":"","url":"https://api.github.com/users/dd4t","html_url":"https://github.com/dd4t","followers_url":"https://api.github.com/users/dd4t/followers","following_url":"https://api.github.com/users/dd4t/following{/other_user}","gists_url":"https://api.github.com/users/dd4t/gists{/gist_id}","starred_url":"https://api.github.com/users/dd4t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dd4t/subscriptions","organizations_url":"https://api.github.com/users/dd4t/orgs","repos_url":"https://api.github.com/users/dd4t/repos","events_url":"https://api.github.com/users/dd4t/events{/privacy}","received_events_url":"https://api.github.com/users/dd4t/received_events","type":"Organization","site_admin":false},"repo":{"id":28407415,"name":"dd4t-2-java","full_name":"dd4t/dd4t-2-java","owner":{"login":"dd4t","id":8267590,"avatar_url":"https://avatars.githubusercontent.com/u/8267590?v=3","gravatar_id":"","url":"https://api.github.com/users/dd4t","html_url":"https://github.com/dd4t","followers_url":"https://api.github.com/users/dd4t/followers","following_url":"https://api.github.com/users/dd4t/following{/other_user}","gists_url":"https://api.github.com/users/dd4t/gists{/gist_id}","starred_url":"https://api.github.com/users/dd4t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dd4t/subscriptions","organizations_url":"https://api.github.com/users/dd4t/orgs","repos_url":"https://api.github.com/users/dd4t/repos","events_url":"https://api.github.com/users/dd4t/events{/privacy}","received_events_url":"https://api.github.com/users/dd4t/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dd4t/dd4t-2-java","description":"","fork":false,"url":"https://api.github.com/repos/dd4t/dd4t-2-java","forks_url":"https://api.github.com/repos/dd4t/dd4t-2-java/forks","keys_url":"https://api.github.com/repos/dd4t/dd4t-2-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dd4t/dd4t-2-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dd4t/dd4t-2-java/teams","hooks_url":"https://api.github.com/repos/dd4t/dd4t-2-java/hooks","issue_events_url":"https://api.github.com/repos/dd4t/dd4t-2-java/issues/events{/number}","events_url":"https://api.github.com/repos/dd4t/dd4t-2-java/events","assignees_url":"https://api.github.com/repos/dd4t/dd4t-2-java/assignees{/user}","branches_url":"https://api.github.com/repos/dd4t/dd4t-2-java/branches{/branch}","tags_url":"https://api.github.com/repos/dd4t/dd4t-2-java/tags","blobs_url":"https://api.github.com/repos/dd4t/dd4t-2-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dd4t/dd4t-2-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dd4t/dd4t-2-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/dd4t/dd4t-2-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dd4t/dd4t-2-java/statuses/{sha}","languages_url":"https://api.github.com/repos/dd4t/dd4t-2-java/languages","stargazers_url":"https://api.github.com/repos/dd4t/dd4t-2-java/stargazers","contributors_url":"https://api.github.com/repos/dd4t/dd4t-2-java/contributors","subscribers_url":"https://api.github.com/repos/dd4t/dd4t-2-java/subscribers","subscription_url":"https://api.github.com/repos/dd4t/dd4t-2-java/subscription","commits_url":"https://api.github.com/repos/dd4t/dd4t-2-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/dd4t/dd4t-2-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/dd4t/dd4t-2-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/dd4t/dd4t-2-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/dd4t/dd4t-2-java/contents/{+path}","compare_url":"https://api.github.com/repos/dd4t/dd4t-2-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dd4t/dd4t-2-java/merges","archive_url":"https://api.github.com/repos/dd4t/dd4t-2-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dd4t/dd4t-2-java/downloads","issues_url":"https://api.github.com/repos/dd4t/dd4t-2-java/issues{/number}","pulls_url":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls{/number}","milestones_url":"https://api.github.com/repos/dd4t/dd4t-2-java/milestones{/number}","notifications_url":"https://api.github.com/repos/dd4t/dd4t-2-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dd4t/dd4t-2-java/labels{/name}","releases_url":"https://api.github.com/repos/dd4t/dd4t-2-java/releases{/id}","created_at":"2014-12-23T16:16:27Z","updated_at":"2015-06-15T11:44:11Z","pushed_at":"2015-11-03T15:20:59Z","git_url":"git://github.com/dd4t/dd4t-2-java.git","ssh_url":"git@github.com:dd4t/dd4t-2-java.git","clone_url":"https://github.com/dd4t/dd4t-2-java.git","svn_url":"https://github.com/dd4t/dd4t-2-java","homepage":null,"size":15228,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":20,"forks":4,"open_issues":20,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/26"},"html":{"href":"https://github.com/dd4t/dd4t-2-java/pull/26"},"issue":{"href":"https://api.github.com/repos/dd4t/dd4t-2-java/issues/26"},"comments":{"href":"https://api.github.com/repos/dd4t/dd4t-2-java/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dd4t/dd4t-2-java/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/dd4t/dd4t-2-java/statuses/eabfc74b19a16aa503c4c17b6a0a4366982d1197"}}}}