{"action":"created","comment":{"url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/comments/41112347","id":41112347,"diff_hunk":"@@ -81,11 +81,11 @@ public virtual Span SendClientSpan(string requestName, string traceId, string pa\n             return newSpan;\n         }\n \n-        public virtual void ReceiveClientSpan(Span span, string clientServiceName)\n+        public virtual void ReceiveClientSpan(Span span)\n         {\n             var annotation = new Annotation()\n             {\n-                Host = zipkinEndpoint.GetEndpoint(clientServiceName),\n+                Host = span.Annotations[0].Host,","path":"src/Medidata.ZipkinTracer.Core/SpanTracer.cs","position":34,"original_position":34,"commit_id":"a49bcff8d177b3a3e46f2085c6266bfe0e275ce8","original_commit_id":"a49bcff8d177b3a3e46f2085c6266bfe0e275ce8","user":{"login":"lschreck-mdsol","id":14884761,"avatar_url":"https://avatars.githubusercontent.com/u/14884761?v=3","gravatar_id":"","url":"https://api.github.com/users/lschreck-mdsol","html_url":"https://github.com/lschreck-mdsol","followers_url":"https://api.github.com/users/lschreck-mdsol/followers","following_url":"https://api.github.com/users/lschreck-mdsol/following{/other_user}","gists_url":"https://api.github.com/users/lschreck-mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/lschreck-mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lschreck-mdsol/subscriptions","organizations_url":"https://api.github.com/users/lschreck-mdsol/orgs","repos_url":"https://api.github.com/users/lschreck-mdsol/repos","events_url":"https://api.github.com/users/lschreck-mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/lschreck-mdsol/received_events","type":"User","site_admin":false},"body":"Is it 100% sure that the span won't be null and it will also have a non-null Annotations collection with at least 1 element at any given time when this method is called? I would recommend to handle null span, null Annotations and empty Annotations collection cases (including but not necessarily error handling) before this statement (of course if you can ensure that there is no possibility for any of the cases above then there is no need for checks).","created_at":"2015-10-05T05:51:49Z","updated_at":"2015-10-05T05:51:49Z","html_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule/pull/63#discussion_r41112347","pull_request_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/comments/41112347"},"html":{"href":"https://github.com/mdsol/Medidata.ZipkinTracerModule/pull/63#discussion_r41112347"},"pull_request":{"href":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/63","id":46741653,"html_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule/pull/63","diff_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule/pull/63.diff","patch_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule/pull/63.patch","issue_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/63","number":63,"state":"open","locked":false,"title":"[MCC-186539] Refactor","user":{"login":"bvillanueva-mdsol","id":10608964,"avatar_url":"https://avatars.githubusercontent.com/u/10608964?v=3","gravatar_id":"","url":"https://api.github.com/users/bvillanueva-mdsol","html_url":"https://github.com/bvillanueva-mdsol","followers_url":"https://api.github.com/users/bvillanueva-mdsol/followers","following_url":"https://api.github.com/users/bvillanueva-mdsol/following{/other_user}","gists_url":"https://api.github.com/users/bvillanueva-mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/bvillanueva-mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvillanueva-mdsol/subscriptions","organizations_url":"https://api.github.com/users/bvillanueva-mdsol/orgs","repos_url":"https://api.github.com/users/bvillanueva-mdsol/repos","events_url":"https://api.github.com/users/bvillanueva-mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/bvillanueva-mdsol/received_events","type":"User","site_admin":false},"body":"@kenyamat @jcarres-mdsol @BPONTES @lschreck-mdsol \r\n\r\nThis PR corrects the span name information resulting to some interface change on zipkin client.\r\n\r\n- Span name has now has a format of --> \"{Context Method Name} {Context Absolute path}\"\r\n- Start Trace returns a span which should be used on later when doing stop trace passing the same span instance.\r\n\r\nPlease review if change is ok and merge.\r\n\r\nThanks,\r\nBrent","created_at":"2015-10-05T03:18:29Z","updated_at":"2015-10-05T05:51:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93e0f57c7418b3ac2698fa9d1ee3bdcd8fa061b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/63/commits","review_comments_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/63/comments","review_comment_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/63/comments","statuses_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/statuses/a49bcff8d177b3a3e46f2085c6266bfe0e275ce8","head":{"label":"mdsol:feature/refactor","ref":"feature/refactor","sha":"a49bcff8d177b3a3e46f2085c6266bfe0e275ce8","user":{"login":"mdsol","id":171103,"avatar_url":"https://avatars.githubusercontent.com/u/171103?v=3","gravatar_id":"","url":"https://api.github.com/users/mdsol","html_url":"https://github.com/mdsol","followers_url":"https://api.github.com/users/mdsol/followers","following_url":"https://api.github.com/users/mdsol/following{/other_user}","gists_url":"https://api.github.com/users/mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdsol/subscriptions","organizations_url":"https://api.github.com/users/mdsol/orgs","repos_url":"https://api.github.com/users/mdsol/repos","events_url":"https://api.github.com/users/mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/mdsol/received_events","type":"Organization","site_admin":false},"repo":{"id":21194896,"name":"Medidata.ZipkinTracerModule","full_name":"mdsol/Medidata.ZipkinTracerModule","owner":{"login":"mdsol","id":171103,"avatar_url":"https://avatars.githubusercontent.com/u/171103?v=3","gravatar_id":"","url":"https://api.github.com/users/mdsol","html_url":"https://github.com/mdsol","followers_url":"https://api.github.com/users/mdsol/followers","following_url":"https://api.github.com/users/mdsol/following{/other_user}","gists_url":"https://api.github.com/users/mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdsol/subscriptions","organizations_url":"https://api.github.com/users/mdsol/orgs","repos_url":"https://api.github.com/users/mdsol/repos","events_url":"https://api.github.com/users/mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/mdsol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule","description":"Zipkin Request Tracing for .Net Apps","fork":false,"url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule","forks_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/forks","keys_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/teams","hooks_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/hooks","issue_events_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/events{/number}","events_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/events","assignees_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/assignees{/user}","branches_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/branches{/branch}","tags_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/tags","blobs_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/statuses/{sha}","languages_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/languages","stargazers_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/stargazers","contributors_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/contributors","subscribers_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/subscribers","subscription_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/subscription","commits_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/contents/{+path}","compare_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/merges","archive_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/downloads","issues_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues{/number}","pulls_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls{/number}","milestones_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/milestones{/number}","notifications_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/labels{/name}","releases_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/releases{/id}","created_at":"2014-06-25T07:55:02Z","updated_at":"2015-09-28T06:35:05Z","pushed_at":"2015-10-05T03:18:29Z","git_url":"git://github.com/mdsol/Medidata.ZipkinTracerModule.git","ssh_url":"git@github.com:mdsol/Medidata.ZipkinTracerModule.git","clone_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule.git","svn_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule","homepage":null,"size":1880,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"mdsol:develop","ref":"develop","sha":"b45bedd73eeb80ba38dfc18e9cc82ca497ebc153","user":{"login":"mdsol","id":171103,"avatar_url":"https://avatars.githubusercontent.com/u/171103?v=3","gravatar_id":"","url":"https://api.github.com/users/mdsol","html_url":"https://github.com/mdsol","followers_url":"https://api.github.com/users/mdsol/followers","following_url":"https://api.github.com/users/mdsol/following{/other_user}","gists_url":"https://api.github.com/users/mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdsol/subscriptions","organizations_url":"https://api.github.com/users/mdsol/orgs","repos_url":"https://api.github.com/users/mdsol/repos","events_url":"https://api.github.com/users/mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/mdsol/received_events","type":"Organization","site_admin":false},"repo":{"id":21194896,"name":"Medidata.ZipkinTracerModule","full_name":"mdsol/Medidata.ZipkinTracerModule","owner":{"login":"mdsol","id":171103,"avatar_url":"https://avatars.githubusercontent.com/u/171103?v=3","gravatar_id":"","url":"https://api.github.com/users/mdsol","html_url":"https://github.com/mdsol","followers_url":"https://api.github.com/users/mdsol/followers","following_url":"https://api.github.com/users/mdsol/following{/other_user}","gists_url":"https://api.github.com/users/mdsol/gists{/gist_id}","starred_url":"https://api.github.com/users/mdsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdsol/subscriptions","organizations_url":"https://api.github.com/users/mdsol/orgs","repos_url":"https://api.github.com/users/mdsol/repos","events_url":"https://api.github.com/users/mdsol/events{/privacy}","received_events_url":"https://api.github.com/users/mdsol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule","description":"Zipkin Request Tracing for .Net Apps","fork":false,"url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule","forks_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/forks","keys_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/teams","hooks_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/hooks","issue_events_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/events{/number}","events_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/events","assignees_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/assignees{/user}","branches_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/branches{/branch}","tags_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/tags","blobs_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/statuses/{sha}","languages_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/languages","stargazers_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/stargazers","contributors_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/contributors","subscribers_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/subscribers","subscription_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/subscription","commits_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/contents/{+path}","compare_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/merges","archive_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/downloads","issues_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues{/number}","pulls_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls{/number}","milestones_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/milestones{/number}","notifications_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/labels{/name}","releases_url":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/releases{/id}","created_at":"2014-06-25T07:55:02Z","updated_at":"2015-09-28T06:35:05Z","pushed_at":"2015-10-05T03:18:29Z","git_url":"git://github.com/mdsol/Medidata.ZipkinTracerModule.git","ssh_url":"git@github.com:mdsol/Medidata.ZipkinTracerModule.git","clone_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule.git","svn_url":"https://github.com/mdsol/Medidata.ZipkinTracerModule","homepage":null,"size":1880,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/63"},"html":{"href":"https://github.com/mdsol/Medidata.ZipkinTracerModule/pull/63"},"issue":{"href":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/63"},"comments":{"href":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/mdsol/Medidata.ZipkinTracerModule/statuses/a49bcff8d177b3a3e46f2085c6266bfe0e275ce8"}}}}