{"action":"created","comment":{"url":"https://api.github.com/repos/CocoaPods/Core/pulls/comments/36727235","id":36727235,"diff_hunk":"@@ -387,8 +388,15 @@ def perform_github_uri_checks(git, git_uri)\n       # Performs validations related to SSH sources\n       #\n       def check_git_ssh_source(s)\n+        require 'uri'\n+\n         if git = s[:git]\n-          if git =~ /\\w+\\@(\\w|\\.)+\\:(\\/\\w+)*/\n+          if git =~ /^#{URI.regexp}$/","path":"lib/cocoapods-core/specification/linter.rb","position":17,"original_position":16,"commit_id":"214fc883c16e1266efb0a60fe280426296f791db","original_commit_id":"165d06c5d7c5ee0c00ce068aace431b7de113cd9","user":{"login":"kylef","id":44164,"avatar_url":"https://avatars.githubusercontent.com/u/44164?v=3","gravatar_id":"","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"body":"Can you add a test case to show what this change is for, the test you've added seems unrelated to this change since it wouldn't match this rule.","created_at":"2015-08-11T09:36:10Z","updated_at":"2015-08-11T09:36:10Z","html_url":"https://github.com/CocoaPods/Core/pull/223#discussion_r36727235","pull_request_url":"https://api.github.com/repos/CocoaPods/Core/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/Core/pulls/comments/36727235"},"html":{"href":"https://github.com/CocoaPods/Core/pull/223#discussion_r36727235"},"pull_request":{"href":"https://api.github.com/repos/CocoaPods/Core/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/CocoaPods/Core/pulls/223","id":30703256,"html_url":"https://github.com/CocoaPods/Core/pull/223","diff_url":"https://github.com/CocoaPods/Core/pull/223.diff","patch_url":"https://github.com/CocoaPods/Core/pull/223.patch","issue_url":"https://api.github.com/repos/CocoaPods/Core/issues/223","number":223,"state":"open","locked":false,"title":"supports git ssh url without preceding `user@` as podspec source url","user":{"login":"banjun","id":11156,"avatar_url":"https://avatars.githubusercontent.com/u/11156?v=3","gravatar_id":"","url":"https://api.github.com/users/banjun","html_url":"https://github.com/banjun","followers_url":"https://api.github.com/users/banjun/followers","following_url":"https://api.github.com/users/banjun/following{/other_user}","gists_url":"https://api.github.com/users/banjun/gists{/gist_id}","starred_url":"https://api.github.com/users/banjun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banjun/subscriptions","organizations_url":"https://api.github.com/users/banjun/orgs","repos_url":"https://api.github.com/users/banjun/repos","events_url":"https://api.github.com/users/banjun/events{/privacy}","received_events_url":"https://api.github.com/users/banjun/received_events","type":"User","site_admin":false},"body":"`pod _0.36.0.rc.1_ lib lint` fails with an error when podspec source url have some form of `hostname:/path/to.git`, without preceding `user@` (such as `git@hostname:/path/to.git`).\r\nsome github clone (such as GitBucket) do not use `git@` as username. they use account names for ssh login. so we should avoid using specific username from podspec source urls.\r\n\r\n### Error\r\n\r\n```\r\nNoMethodError - undefined method `end_with?' for nil:NilClass\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-core-0.36.0.rc.1/lib/cocoapods-core/specification/linter.rb:368:in `perform_github_source_checks'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-core-0.36.0.rc.1/lib/cocoapods-core/specification/linter.rb:347:in `_validate_source'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-core-0.36.0.rc.1/lib/cocoapods-core/specification/linter.rb:159:in `block in run_validation_hooks'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-core-0.36.0.rc.1/lib/cocoapods-core/specification/linter.rb:154:in `each'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-core-0.36.0.rc.1/lib/cocoapods-core/specification/linter.rb:154:in `run_validation_hooks'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-core-0.36.0.rc.1/lib/cocoapods-core/specification/linter.rb:110:in `run_root_validation_hooks'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-core-0.36.0.rc.1/lib/cocoapods-core/specification/linter.rb:50:in `lint'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.36.0.rc.1/lib/cocoapods/validator.rb:198:in `perform_linting'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.36.0.rc.1/lib/cocoapods/validator.rb:72:in `validate'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.36.0.rc.1/lib/cocoapods/command/lib.rb:149:in `block in run'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.36.0.rc.1/lib/cocoapods/command/lib.rb:140:in `each'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.36.0.rc.1/lib/cocoapods/command/lib.rb:140:in `run'\r\n/Library/Ruby/Gems/2.0.0/gems/claide-0.8.1/lib/claide/command.rb:312:in `run'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.36.0.rc.1/lib/cocoapods/command.rb:46:in `run'\r\n/Library/Ruby/Gems/2.0.0/gems/cocoapods-0.36.0.rc.1/bin/pod:44:in `<top (required)>'\r\n/usr/bin/pod:23:in `load'\r\n/usr/bin/pod:23:in `<main>'\r\n```\r\n","created_at":"2015-03-07T14:14:47Z","updated_at":"2015-08-11T09:36:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4911beb3e0254b37fd616b9be81d4d1ce4dfbad5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CocoaPods/Core/pulls/223/commits","review_comments_url":"https://api.github.com/repos/CocoaPods/Core/pulls/223/comments","review_comment_url":"https://api.github.com/repos/CocoaPods/Core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CocoaPods/Core/issues/223/comments","statuses_url":"https://api.github.com/repos/CocoaPods/Core/statuses/214fc883c16e1266efb0a60fe280426296f791db","head":{"label":"banjun:ssh-source-url-without-user-at","ref":"ssh-source-url-without-user-at","sha":"214fc883c16e1266efb0a60fe280426296f791db","user":{"login":"banjun","id":11156,"avatar_url":"https://avatars.githubusercontent.com/u/11156?v=3","gravatar_id":"","url":"https://api.github.com/users/banjun","html_url":"https://github.com/banjun","followers_url":"https://api.github.com/users/banjun/followers","following_url":"https://api.github.com/users/banjun/following{/other_user}","gists_url":"https://api.github.com/users/banjun/gists{/gist_id}","starred_url":"https://api.github.com/users/banjun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banjun/subscriptions","organizations_url":"https://api.github.com/users/banjun/orgs","repos_url":"https://api.github.com/users/banjun/repos","events_url":"https://api.github.com/users/banjun/events{/privacy}","received_events_url":"https://api.github.com/users/banjun/received_events","type":"User","site_admin":false},"repo":{"id":31811827,"name":"Core","full_name":"banjun/Core","owner":{"login":"banjun","id":11156,"avatar_url":"https://avatars.githubusercontent.com/u/11156?v=3","gravatar_id":"","url":"https://api.github.com/users/banjun","html_url":"https://github.com/banjun","followers_url":"https://api.github.com/users/banjun/followers","following_url":"https://api.github.com/users/banjun/following{/other_user}","gists_url":"https://api.github.com/users/banjun/gists{/gist_id}","starred_url":"https://api.github.com/users/banjun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banjun/subscriptions","organizations_url":"https://api.github.com/users/banjun/orgs","repos_url":"https://api.github.com/users/banjun/repos","events_url":"https://api.github.com/users/banjun/events{/privacy}","received_events_url":"https://api.github.com/users/banjun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/banjun/Core","description":"The models used within the CocoaPods gem","fork":true,"url":"https://api.github.com/repos/banjun/Core","forks_url":"https://api.github.com/repos/banjun/Core/forks","keys_url":"https://api.github.com/repos/banjun/Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/banjun/Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/banjun/Core/teams","hooks_url":"https://api.github.com/repos/banjun/Core/hooks","issue_events_url":"https://api.github.com/repos/banjun/Core/issues/events{/number}","events_url":"https://api.github.com/repos/banjun/Core/events","assignees_url":"https://api.github.com/repos/banjun/Core/assignees{/user}","branches_url":"https://api.github.com/repos/banjun/Core/branches{/branch}","tags_url":"https://api.github.com/repos/banjun/Core/tags","blobs_url":"https://api.github.com/repos/banjun/Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/banjun/Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/banjun/Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/banjun/Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/banjun/Core/statuses/{sha}","languages_url":"https://api.github.com/repos/banjun/Core/languages","stargazers_url":"https://api.github.com/repos/banjun/Core/stargazers","contributors_url":"https://api.github.com/repos/banjun/Core/contributors","subscribers_url":"https://api.github.com/repos/banjun/Core/subscribers","subscription_url":"https://api.github.com/repos/banjun/Core/subscription","commits_url":"https://api.github.com/repos/banjun/Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/banjun/Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/banjun/Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/banjun/Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/banjun/Core/contents/{+path}","compare_url":"https://api.github.com/repos/banjun/Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/banjun/Core/merges","archive_url":"https://api.github.com/repos/banjun/Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/banjun/Core/downloads","issues_url":"https://api.github.com/repos/banjun/Core/issues{/number}","pulls_url":"https://api.github.com/repos/banjun/Core/pulls{/number}","milestones_url":"https://api.github.com/repos/banjun/Core/milestones{/number}","notifications_url":"https://api.github.com/repos/banjun/Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/banjun/Core/labels{/name}","releases_url":"https://api.github.com/repos/banjun/Core/releases{/id}","created_at":"2015-03-07T12:48:24Z","updated_at":"2015-03-07T12:48:25Z","pushed_at":"2015-03-08T02:32:33Z","git_url":"git://github.com/banjun/Core.git","ssh_url":"git@github.com:banjun/Core.git","clone_url":"https://github.com/banjun/Core.git","svn_url":"https://github.com/banjun/Core","homepage":"","size":11389,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CocoaPods:master","ref":"master","sha":"1e73cdf6ae1a715723774af151915a2c4a09ed42","user":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars.githubusercontent.com/u/1189714?v=3","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"repo":{"id":6612466,"name":"Core","full_name":"CocoaPods/Core","owner":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars.githubusercontent.com/u/1189714?v=3","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CocoaPods/Core","description":"The models used within the CocoaPods gem","fork":false,"url":"https://api.github.com/repos/CocoaPods/Core","forks_url":"https://api.github.com/repos/CocoaPods/Core/forks","keys_url":"https://api.github.com/repos/CocoaPods/Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CocoaPods/Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CocoaPods/Core/teams","hooks_url":"https://api.github.com/repos/CocoaPods/Core/hooks","issue_events_url":"https://api.github.com/repos/CocoaPods/Core/issues/events{/number}","events_url":"https://api.github.com/repos/CocoaPods/Core/events","assignees_url":"https://api.github.com/repos/CocoaPods/Core/assignees{/user}","branches_url":"https://api.github.com/repos/CocoaPods/Core/branches{/branch}","tags_url":"https://api.github.com/repos/CocoaPods/Core/tags","blobs_url":"https://api.github.com/repos/CocoaPods/Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CocoaPods/Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CocoaPods/Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/CocoaPods/Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CocoaPods/Core/statuses/{sha}","languages_url":"https://api.github.com/repos/CocoaPods/Core/languages","stargazers_url":"https://api.github.com/repos/CocoaPods/Core/stargazers","contributors_url":"https://api.github.com/repos/CocoaPods/Core/contributors","subscribers_url":"https://api.github.com/repos/CocoaPods/Core/subscribers","subscription_url":"https://api.github.com/repos/CocoaPods/Core/subscription","commits_url":"https://api.github.com/repos/CocoaPods/Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/CocoaPods/Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/CocoaPods/Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/CocoaPods/Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/CocoaPods/Core/contents/{+path}","compare_url":"https://api.github.com/repos/CocoaPods/Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CocoaPods/Core/merges","archive_url":"https://api.github.com/repos/CocoaPods/Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CocoaPods/Core/downloads","issues_url":"https://api.github.com/repos/CocoaPods/Core/issues{/number}","pulls_url":"https://api.github.com/repos/CocoaPods/Core/pulls{/number}","milestones_url":"https://api.github.com/repos/CocoaPods/Core/milestones{/number}","notifications_url":"https://api.github.com/repos/CocoaPods/Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CocoaPods/Core/labels{/name}","releases_url":"https://api.github.com/repos/CocoaPods/Core/releases{/id}","created_at":"2012-11-09T11:24:08Z","updated_at":"2015-05-07T17:47:38Z","pushed_at":"2015-08-09T17:55:34Z","git_url":"git://github.com/CocoaPods/Core.git","ssh_url":"git@github.com:CocoaPods/Core.git","clone_url":"https://github.com/CocoaPods/Core.git","svn_url":"https://github.com/CocoaPods/Core","homepage":"","size":14574,"stargazers_count":26,"watchers_count":26,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":9,"forks":65,"open_issues":9,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/Core/pulls/223"},"html":{"href":"https://github.com/CocoaPods/Core/pull/223"},"issue":{"href":"https://api.github.com/repos/CocoaPods/Core/issues/223"},"comments":{"href":"https://api.github.com/repos/CocoaPods/Core/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/CocoaPods/Core/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/CocoaPods/Core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CocoaPods/Core/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/CocoaPods/Core/statuses/214fc883c16e1266efb0a60fe280426296f791db"}}}}