{"action":"created","issue":{"url":"https://api.github.com/repos/kalamuna/kalastatic/issues/120","labels_url":"https://api.github.com/repos/kalamuna/kalastatic/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/kalamuna/kalastatic/issues/120/comments","events_url":"https://api.github.com/repos/kalamuna/kalastatic/issues/120/events","html_url":"https://github.com/kalamuna/kalastatic/pull/120","id":87784676,"number":120,"title":"metalsmit-sass --> grunt-sass","user":{"login":"madeofpeople","id":79221,"avatar_url":"https://avatars.githubusercontent.com/u/79221?v=3","gravatar_id":"","url":"https://api.github.com/users/madeofpeople","html_url":"https://github.com/madeofpeople","followers_url":"https://api.github.com/users/madeofpeople/followers","following_url":"https://api.github.com/users/madeofpeople/following{/other_user}","gists_url":"https://api.github.com/users/madeofpeople/gists{/gist_id}","starred_url":"https://api.github.com/users/madeofpeople/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madeofpeople/subscriptions","organizations_url":"https://api.github.com/users/madeofpeople/orgs","repos_url":"https://api.github.com/users/madeofpeople/repos","events_url":"https://api.github.com/users/madeofpeople/events{/privacy}","received_events_url":"https://api.github.com/users/madeofpeople/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"RobLoach","id":25086,"avatar_url":"https://avatars.githubusercontent.com/u/25086?v=3","gravatar_id":"","url":"https://api.github.com/users/RobLoach","html_url":"https://github.com/RobLoach","followers_url":"https://api.github.com/users/RobLoach/followers","following_url":"https://api.github.com/users/RobLoach/following{/other_user}","gists_url":"https://api.github.com/users/RobLoach/gists{/gist_id}","starred_url":"https://api.github.com/users/RobLoach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobLoach/subscriptions","organizations_url":"https://api.github.com/users/RobLoach/orgs","repos_url":"https://api.github.com/users/RobLoach/repos","events_url":"https://api.github.com/users/RobLoach/events{/privacy}","received_events_url":"https://api.github.com/users/RobLoach/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-06-12T16:44:18Z","updated_at":"2015-06-12T20:55:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kalamuna/kalastatic/pulls/120","html_url":"https://github.com/kalamuna/kalastatic/pull/120","diff_url":"https://github.com/kalamuna/kalastatic/pull/120.diff","patch_url":"https://github.com/kalamuna/kalastatic/pull/120.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/kalamuna/kalastatic/issues/comments/111614506","html_url":"https://github.com/kalamuna/kalastatic/pull/120#issuecomment-111614506","issue_url":"https://api.github.com/repos/kalamuna/kalastatic/issues/120","id":111614506,"user":{"login":"RobLoach","id":25086,"avatar_url":"https://avatars.githubusercontent.com/u/25086?v=3","gravatar_id":"","url":"https://api.github.com/users/RobLoach","html_url":"https://github.com/RobLoach","followers_url":"https://api.github.com/users/RobLoach/followers","following_url":"https://api.github.com/users/RobLoach/following{/other_user}","gists_url":"https://api.github.com/users/RobLoach/gists{/gist_id}","starred_url":"https://api.github.com/users/RobLoach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobLoach/subscriptions","organizations_url":"https://api.github.com/users/RobLoach/orgs","repos_url":"https://api.github.com/users/RobLoach/repos","events_url":"https://api.github.com/users/RobLoach/events{/privacy}","received_events_url":"https://api.github.com/users/RobLoach/received_events","type":"User","site_admin":false},"created_at":"2015-06-12T20:55:27Z","updated_at":"2015-06-12T20:55:27Z","body":"> As I mentioned before, metalsmith-sass doesnt pass all the arguments you pass to it to node-sass, but rather hard-codes the 2-3 the author thought was important.\r\n\r\nI think that was fixed in one of the more recent versions of metalsmith-sass. I remember we had that problem, but it went away since updating.\r\n\r\n> Also the SCSS files absolutely don't belong in the metalsmith src directory, but we were doing it so we could use metalsmith-sass.\r\n\r\n`src` is just stuff we want Metalsmith to process. We don't want it to process vendor code, but for our own stuff, that's fine.\r\n\r\n> Ideally we would just use node-sass directly, but the CLI interface doesnt support multiple includePaths directories yet.\r\n\r\nUsing multiple includePaths in https://github.com/kalamuna/kalastatic/pull/129/files ... I remember it was broken on older versions, but it's working now.\r\n\r\n> This specific implementation has no real downside.\r\n\r\nYou're correct, using grunt-sass will do what we need it to do. But the problem with having Metalsmith process some stuff, and then Grunt process some stuff is that there ends up being two different build processes. Metalsmith has its own files database array, which can be modified through its build-queue. Going against that adds a layer of complexity that we might be able to avoid.\r\n\r\nIn essence... Metalsmith is exclusively used to build the site, while Grunt is just used to aid development (watch, serve, etc)."}}