{"action":"created","issue":{"url":"https://api.github.com/repos/frankmorgner/OpenSC.tokend/issues/4","labels_url":"https://api.github.com/repos/frankmorgner/OpenSC.tokend/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/frankmorgner/OpenSC.tokend/issues/4/comments","events_url":"https://api.github.com/repos/frankmorgner/OpenSC.tokend/issues/4/events","html_url":"https://github.com/frankmorgner/OpenSC.tokend/pull/4","id":120040386,"number":4,"title":"Fix compilation problems, and removed an undefined hash ","user":{"login":"mouse07410","id":5923577,"avatar_url":"https://avatars.githubusercontent.com/u/5923577?v=3","gravatar_id":"","url":"https://api.github.com/users/mouse07410","html_url":"https://github.com/mouse07410","followers_url":"https://api.github.com/users/mouse07410/followers","following_url":"https://api.github.com/users/mouse07410/following{/other_user}","gists_url":"https://api.github.com/users/mouse07410/gists{/gist_id}","starred_url":"https://api.github.com/users/mouse07410/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mouse07410/subscriptions","organizations_url":"https://api.github.com/users/mouse07410/orgs","repos_url":"https://api.github.com/users/mouse07410/repos","events_url":"https://api.github.com/users/mouse07410/events{/privacy}","received_events_url":"https://api.github.com/users/mouse07410/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-02T21:32:19Z","updated_at":"2015-12-02T22:53:13Z","closed_at":"2015-12-02T22:26:33Z","pull_request":{"url":"https://api.github.com/repos/frankmorgner/OpenSC.tokend/pulls/4","html_url":"https://github.com/frankmorgner/OpenSC.tokend/pull/4","diff_url":"https://github.com/frankmorgner/OpenSC.tokend/pull/4.diff","patch_url":"https://github.com/frankmorgner/OpenSC.tokend/pull/4.patch"},"body":"@frankmorgner I suggest that this fix is better for several reasons:\r\n\r\n1. It sets the correct signature length (I'm not sure that `sc_pkcs15_compute_signature()` returns the length of the output data).\r\n\r\n2. It removes SC_ALGORITHM_ECDSA_HASH_MD5 which has not been defined (I think MD5 has been prohibited by the time ECDSA came about)."},"comment":{"url":"https://api.github.com/repos/frankmorgner/OpenSC.tokend/issues/comments/161459567","html_url":"https://github.com/frankmorgner/OpenSC.tokend/pull/4#issuecomment-161459567","issue_url":"https://api.github.com/repos/frankmorgner/OpenSC.tokend/issues/4","id":161459567,"user":{"login":"frankmorgner","id":1266577,"avatar_url":"https://avatars.githubusercontent.com/u/1266577?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmorgner","html_url":"https://github.com/frankmorgner","followers_url":"https://api.github.com/users/frankmorgner/followers","following_url":"https://api.github.com/users/frankmorgner/following{/other_user}","gists_url":"https://api.github.com/users/frankmorgner/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmorgner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmorgner/subscriptions","organizations_url":"https://api.github.com/users/frankmorgner/orgs","repos_url":"https://api.github.com/users/frankmorgner/repos","events_url":"https://api.github.com/users/frankmorgner/events{/privacy}","received_events_url":"https://api.github.com/users/frankmorgner/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T22:53:13Z","updated_at":"2015-12-02T22:53:13Z","body":"Well, you asked me to remove one of my commits which would have required rewriting my git history anyway (destroying any incoming PR).\r\n\r\nTo keep pace, simply create new branches (no need to resolve conflicts for the old ones). Fetch my remote, checkout my branch sha2 to a new local branch, apply your changes, make a PR. Branches are cheap in git(hub)! You may still keep \"your\" version lying around in some other branch."}}