{"action":"created","comment":{"url":"https://api.github.com/repos/PecanProject/pecan/pulls/comments/24726040","id":24726040,"diff_hunk":"@@ -27,13 +27,9 @@\n ##' @param end_date the end date of the data to be downloaded (will only use the year part of the date)\n ##' @param overwrite should existing files be overwritten\n ##' @param verbose should the function be very verbose\n-met2model.ED2 <- function(in.path,in.prefix,outfolder,start_date, end_date, lst=0,overwrite=FALSE,verbose=FALSE){\n+met2model.ED2 <- function(in.path,in.prefix,outfolder,start_date, end_date, lst=\"lst=0\",..., overwrite=FALSE,verbose=FALSE){","path":"models/ed/R/met2model.ED2.R","position":5,"original_position":5,"commit_id":"6d106c8e02c3aa0de2b7285c0393f372caa78072","original_commit_id":"6d106c8e02c3aa0de2b7285c0393f372caa78072","user":{"login":"mdietze","id":3081466,"avatar_url":"https://avatars.githubusercontent.com/u/3081466?v=3","gravatar_id":"","url":"https://api.github.com/users/mdietze","html_url":"https://github.com/mdietze","followers_url":"https://api.github.com/users/mdietze/followers","following_url":"https://api.github.com/users/mdietze/following{/other_user}","gists_url":"https://api.github.com/users/mdietze/gists{/gist_id}","starred_url":"https://api.github.com/users/mdietze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdietze/subscriptions","organizations_url":"https://api.github.com/users/mdietze/orgs","repos_url":"https://api.github.com/users/mdietze/repos","events_url":"https://api.github.com/users/mdietze/events{/privacy}","received_events_url":"https://api.github.com/users/mdietze/received_events","type":"User","site_admin":false},"body":"Ok, so we need to fix the problem, not the symptom. The cmdFcn should say\r\n\r\nPEcAn.ED2::met2model.ED2('/fs/data4/NARR_CF_site_0-772/','NARR','/fs/data4/NARR_ED2_site_0-772/','1979-01-01 00:00:00','2013-12-31 00:00:00',lst = -7,overwrite = TRUE)\r\n\r\nor\r\n\r\nPEcAn.ED2::met2model.ED2('/fs/data4/NARR_CF_site_0-772/','NARR','/fs/data4/NARR_ED2_site_0-772/','1979-01-01 00:00:00','2013-12-31 00:00:00',lst = -7,overwrite = FALSE)\r\n\r\nso the bit of code that builds cmdFcn needs improvement\r\n","created_at":"2015-02-15T21:04:27Z","updated_at":"2015-02-15T21:04:27Z","html_url":"https://github.com/PecanProject/pecan/pull/363#discussion_r24726040","pull_request_url":"https://api.github.com/repos/PecanProject/pecan/pulls/363","_links":{"self":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/comments/24726040"},"html":{"href":"https://github.com/PecanProject/pecan/pull/363#discussion_r24726040"},"pull_request":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/363"}}},"pull_request":{"url":"https://api.github.com/repos/PecanProject/pecan/pulls/363","id":29337240,"html_url":"https://github.com/PecanProject/pecan/pull/363","diff_url":"https://github.com/PecanProject/pecan/pull/363.diff","patch_url":"https://github.com/PecanProject/pecan/pull/363.patch","issue_url":"https://api.github.com/repos/PecanProject/pecan/issues/363","number":363,"state":"open","locked":false,"title":"Conversion for NARR and Ameriflux for four met2model fucntions","user":{"login":"bcow","id":5503595,"avatar_url":"https://avatars.githubusercontent.com/u/5503595?v=3","gravatar_id":"","url":"https://api.github.com/users/bcow","html_url":"https://github.com/bcow","followers_url":"https://api.github.com/users/bcow/followers","following_url":"https://api.github.com/users/bcow/following{/other_user}","gists_url":"https://api.github.com/users/bcow/gists{/gist_id}","starred_url":"https://api.github.com/users/bcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcow/subscriptions","organizations_url":"https://api.github.com/users/bcow/orgs","repos_url":"https://api.github.com/users/bcow/repos","events_url":"https://api.github.com/users/bcow/events{/privacy}","received_events_url":"https://api.github.com/users/bcow/received_events","type":"User","site_admin":false},"body":"SIPNET, DALEC, LINKAGES and ED2 for NARR and Ameriflux on the localhost, without changes to pecan.xml ","created_at":"2015-02-15T16:50:51Z","updated_at":"2015-02-15T21:04:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41d10a93ed9052b430f03387b5d665f4d124d4ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PecanProject/pecan/pulls/363/commits","review_comments_url":"https://api.github.com/repos/PecanProject/pecan/pulls/363/comments","review_comment_url":"https://api.github.com/repos/PecanProject/pecan/pulls/comments/{number}","comments_url":"https://api.github.com/repos/PecanProject/pecan/issues/363/comments","statuses_url":"https://api.github.com/repos/PecanProject/pecan/statuses/6d106c8e02c3aa0de2b7285c0393f372caa78072","head":{"label":"bcow:master","ref":"master","sha":"6d106c8e02c3aa0de2b7285c0393f372caa78072","user":{"login":"bcow","id":5503595,"avatar_url":"https://avatars.githubusercontent.com/u/5503595?v=3","gravatar_id":"","url":"https://api.github.com/users/bcow","html_url":"https://github.com/bcow","followers_url":"https://api.github.com/users/bcow/followers","following_url":"https://api.github.com/users/bcow/following{/other_user}","gists_url":"https://api.github.com/users/bcow/gists{/gist_id}","starred_url":"https://api.github.com/users/bcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcow/subscriptions","organizations_url":"https://api.github.com/users/bcow/orgs","repos_url":"https://api.github.com/users/bcow/repos","events_url":"https://api.github.com/users/bcow/events{/privacy}","received_events_url":"https://api.github.com/users/bcow/received_events","type":"User","site_admin":false},"repo":{"id":19579017,"name":"pecan","full_name":"bcow/pecan","owner":{"login":"bcow","id":5503595,"avatar_url":"https://avatars.githubusercontent.com/u/5503595?v=3","gravatar_id":"","url":"https://api.github.com/users/bcow","html_url":"https://github.com/bcow","followers_url":"https://api.github.com/users/bcow/followers","following_url":"https://api.github.com/users/bcow/following{/other_user}","gists_url":"https://api.github.com/users/bcow/gists{/gist_id}","starred_url":"https://api.github.com/users/bcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcow/subscriptions","organizations_url":"https://api.github.com/users/bcow/orgs","repos_url":"https://api.github.com/users/bcow/repos","events_url":"https://api.github.com/users/bcow/events{/privacy}","received_events_url":"https://api.github.com/users/bcow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcow/pecan","description":"The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.","fork":true,"url":"https://api.github.com/repos/bcow/pecan","forks_url":"https://api.github.com/repos/bcow/pecan/forks","keys_url":"https://api.github.com/repos/bcow/pecan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcow/pecan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcow/pecan/teams","hooks_url":"https://api.github.com/repos/bcow/pecan/hooks","issue_events_url":"https://api.github.com/repos/bcow/pecan/issues/events{/number}","events_url":"https://api.github.com/repos/bcow/pecan/events","assignees_url":"https://api.github.com/repos/bcow/pecan/assignees{/user}","branches_url":"https://api.github.com/repos/bcow/pecan/branches{/branch}","tags_url":"https://api.github.com/repos/bcow/pecan/tags","blobs_url":"https://api.github.com/repos/bcow/pecan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcow/pecan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcow/pecan/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcow/pecan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcow/pecan/statuses/{sha}","languages_url":"https://api.github.com/repos/bcow/pecan/languages","stargazers_url":"https://api.github.com/repos/bcow/pecan/stargazers","contributors_url":"https://api.github.com/repos/bcow/pecan/contributors","subscribers_url":"https://api.github.com/repos/bcow/pecan/subscribers","subscription_url":"https://api.github.com/repos/bcow/pecan/subscription","commits_url":"https://api.github.com/repos/bcow/pecan/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcow/pecan/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcow/pecan/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcow/pecan/issues/comments/{number}","contents_url":"https://api.github.com/repos/bcow/pecan/contents/{+path}","compare_url":"https://api.github.com/repos/bcow/pecan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcow/pecan/merges","archive_url":"https://api.github.com/repos/bcow/pecan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcow/pecan/downloads","issues_url":"https://api.github.com/repos/bcow/pecan/issues{/number}","pulls_url":"https://api.github.com/repos/bcow/pecan/pulls{/number}","milestones_url":"https://api.github.com/repos/bcow/pecan/milestones{/number}","notifications_url":"https://api.github.com/repos/bcow/pecan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcow/pecan/labels{/name}","releases_url":"https://api.github.com/repos/bcow/pecan/releases{/id}","created_at":"2014-05-08T15:40:52Z","updated_at":"2015-02-15T16:39:38Z","pushed_at":"2015-02-15T16:39:38Z","git_url":"git://github.com/bcow/pecan.git","ssh_url":"git@github.com:bcow/pecan.git","clone_url":"https://github.com/bcow/pecan.git","svn_url":"https://github.com/bcow/pecan","homepage":"www.pecanproject.org","size":94404,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PecanProject:master","ref":"master","sha":"818dd77fd743420eef0b07bf9eb31bae3cca2e82","user":{"login":"PecanProject","id":2879854,"avatar_url":"https://avatars.githubusercontent.com/u/2879854?v=3","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"repo":{"id":6857384,"name":"pecan","full_name":"PecanProject/pecan","owner":{"login":"PecanProject","id":2879854,"avatar_url":"https://avatars.githubusercontent.com/u/2879854?v=3","gravatar_id":"","url":"https://api.github.com/users/PecanProject","html_url":"https://github.com/PecanProject","followers_url":"https://api.github.com/users/PecanProject/followers","following_url":"https://api.github.com/users/PecanProject/following{/other_user}","gists_url":"https://api.github.com/users/PecanProject/gists{/gist_id}","starred_url":"https://api.github.com/users/PecanProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PecanProject/subscriptions","organizations_url":"https://api.github.com/users/PecanProject/orgs","repos_url":"https://api.github.com/users/PecanProject/repos","events_url":"https://api.github.com/users/PecanProject/events{/privacy}","received_events_url":"https://api.github.com/users/PecanProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PecanProject/pecan","description":"The Predictive Ecosystem Analyzer (PEcAn) is an integrated ecological bioinformatics toolbox.","fork":false,"url":"https://api.github.com/repos/PecanProject/pecan","forks_url":"https://api.github.com/repos/PecanProject/pecan/forks","keys_url":"https://api.github.com/repos/PecanProject/pecan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PecanProject/pecan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PecanProject/pecan/teams","hooks_url":"https://api.github.com/repos/PecanProject/pecan/hooks","issue_events_url":"https://api.github.com/repos/PecanProject/pecan/issues/events{/number}","events_url":"https://api.github.com/repos/PecanProject/pecan/events","assignees_url":"https://api.github.com/repos/PecanProject/pecan/assignees{/user}","branches_url":"https://api.github.com/repos/PecanProject/pecan/branches{/branch}","tags_url":"https://api.github.com/repos/PecanProject/pecan/tags","blobs_url":"https://api.github.com/repos/PecanProject/pecan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PecanProject/pecan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PecanProject/pecan/git/refs{/sha}","trees_url":"https://api.github.com/repos/PecanProject/pecan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PecanProject/pecan/statuses/{sha}","languages_url":"https://api.github.com/repos/PecanProject/pecan/languages","stargazers_url":"https://api.github.com/repos/PecanProject/pecan/stargazers","contributors_url":"https://api.github.com/repos/PecanProject/pecan/contributors","subscribers_url":"https://api.github.com/repos/PecanProject/pecan/subscribers","subscription_url":"https://api.github.com/repos/PecanProject/pecan/subscription","commits_url":"https://api.github.com/repos/PecanProject/pecan/commits{/sha}","git_commits_url":"https://api.github.com/repos/PecanProject/pecan/git/commits{/sha}","comments_url":"https://api.github.com/repos/PecanProject/pecan/comments{/number}","issue_comment_url":"https://api.github.com/repos/PecanProject/pecan/issues/comments/{number}","contents_url":"https://api.github.com/repos/PecanProject/pecan/contents/{+path}","compare_url":"https://api.github.com/repos/PecanProject/pecan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PecanProject/pecan/merges","archive_url":"https://api.github.com/repos/PecanProject/pecan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PecanProject/pecan/downloads","issues_url":"https://api.github.com/repos/PecanProject/pecan/issues{/number}","pulls_url":"https://api.github.com/repos/PecanProject/pecan/pulls{/number}","milestones_url":"https://api.github.com/repos/PecanProject/pecan/milestones{/number}","notifications_url":"https://api.github.com/repos/PecanProject/pecan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PecanProject/pecan/labels{/name}","releases_url":"https://api.github.com/repos/PecanProject/pecan/releases{/id}","created_at":"2012-11-25T23:48:26Z","updated_at":"2015-02-06T13:26:05Z","pushed_at":"2015-02-06T13:26:05Z","git_url":"git://github.com/PecanProject/pecan.git","ssh_url":"git@github.com:PecanProject/pecan.git","clone_url":"https://github.com/PecanProject/pecan.git","svn_url":"https://github.com/PecanProject/pecan","homepage":"www.pecanproject.org","size":316848,"stargazers_count":21,"watchers_count":21,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":84,"forks":52,"open_issues":84,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/363"},"html":{"href":"https://github.com/PecanProject/pecan/pull/363"},"issue":{"href":"https://api.github.com/repos/PecanProject/pecan/issues/363"},"comments":{"href":"https://api.github.com/repos/PecanProject/pecan/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/PecanProject/pecan/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/PecanProject/pecan/statuses/6d106c8e02c3aa0de2b7285c0393f372caa78072"}}}}