{"action":"created","issue":{"url":"https://api.github.com/repos/tobi/airbrake-go/issues/14","labels_url":"https://api.github.com/repos/tobi/airbrake-go/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/tobi/airbrake-go/issues/14/comments","events_url":"https://api.github.com/repos/tobi/airbrake-go/issues/14/events","html_url":"https://github.com/tobi/airbrake-go/pull/14","id":53672179,"number":14,"title":"Populate the Environement and Parameters tab in errbit reports","user":{"login":"mkobetic","id":871693,"avatar_url":"https://avatars.githubusercontent.com/u/871693?v=3","gravatar_id":"","url":"https://api.github.com/users/mkobetic","html_url":"https://github.com/mkobetic","followers_url":"https://api.github.com/users/mkobetic/followers","following_url":"https://api.github.com/users/mkobetic/following{/other_user}","gists_url":"https://api.github.com/users/mkobetic/gists{/gist_id}","starred_url":"https://api.github.com/users/mkobetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkobetic/subscriptions","organizations_url":"https://api.github.com/users/mkobetic/orgs","repos_url":"https://api.github.com/users/mkobetic/repos","events_url":"https://api.github.com/users/mkobetic/events{/privacy}","received_events_url":"https://api.github.com/users/mkobetic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-07T19:36:26Z","updated_at":"2015-01-07T19:59:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tobi/airbrake-go/pulls/14","html_url":"https://github.com/tobi/airbrake-go/pull/14","diff_url":"https://github.com/tobi/airbrake-go/pull/14.diff","patch_url":"https://github.com/tobi/airbrake-go/pull/14.patch"},"body":"Apologies for a somewhat larger change, I got progressively more greedy as I was eyeing the fancy Ruby errbits. The code change isn't actually that large, I mostly just extracted the common parameter compilation bit from `Error()` and `Notify()` into its own function `params()`, so that I can write a test for it. Bulk of the change is in the template, which unfortunately doesn't provide much room for making it more readable without adversely affecting its output. I'd be happy to convert it to ego style template if desired.\r\n\r\nI added `PrettyParams` config variable, to allow including query/form parameters on the Environment tab which is more readable. I also tweaked the URL value a bit, because when using nested http muxes (as we do in reportifydb) they muck with the URL value.\r\n\r\nOne thing that bothers me still is the unused WHERE field that is so prominent (included even in the email notifications), but I didn't come up with something universally useful to put in there (Rails puts the Component#action there). Any suggestions welcome.\r\n\r\nI tested this with a local custom reportifydb build. [sample errbit](https://exceptions.shopify.com/apps/54abfdafb74f33389b0002d7/errs/54ad7dd4b74f3338c3001bb2).\r\n\r\n@tobi, would you have a minute to look this over?\r\n\r\n@snormore, @burke: If you guys have any suggestions comments, please let me know.\r\n\r\nPS: I'd like to follow this up with a PR with some backtrace fixes, hopefully also adding the line hyperlinking to github the same way the Ruby airbrake does. "},"comment":{"url":"https://api.github.com/repos/tobi/airbrake-go/issues/comments/69081975","html_url":"https://github.com/tobi/airbrake-go/pull/14#issuecomment-69081975","issue_url":"https://api.github.com/repos/tobi/airbrake-go/issues/14","id":69081975,"user":{"login":"benbjohnson","id":118015,"avatar_url":"https://avatars.githubusercontent.com/u/118015?v=3","gravatar_id":"","url":"https://api.github.com/users/benbjohnson","html_url":"https://github.com/benbjohnson","followers_url":"https://api.github.com/users/benbjohnson/followers","following_url":"https://api.github.com/users/benbjohnson/following{/other_user}","gists_url":"https://api.github.com/users/benbjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/benbjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbjohnson/subscriptions","organizations_url":"https://api.github.com/users/benbjohnson/orgs","repos_url":"https://api.github.com/users/benbjohnson/repos","events_url":"https://api.github.com/users/benbjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/benbjohnson/received_events","type":"User","site_admin":false},"created_at":"2015-01-07T19:59:30Z","updated_at":"2015-01-07T19:59:30Z","body":"lgtm. can you scrub the data before passing into the stdlib `template` package? Adding an ego dependency seems heavy since there's already an existing template and it's fairly small."}}