{"action":"closed","number":17283,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/17283","id":48520312,"html_url":"https://github.com/docker/docker/pull/17283","diff_url":"https://github.com/docker/docker/pull/17283.diff","patch_url":"https://github.com/docker/docker/pull/17283.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/17283","number":17283,"state":"closed","locked":false,"title":"[WIP] Add support for building docker-engine RPMs for the Amazon Linux AMI","user":{"login":"ianweller","id":52814,"avatar_url":"https://avatars.githubusercontent.com/u/52814?v=3","gravatar_id":"","url":"https://api.github.com/users/ianweller","html_url":"https://github.com/ianweller","followers_url":"https://api.github.com/users/ianweller/followers","following_url":"https://api.github.com/users/ianweller/following{/other_user}","gists_url":"https://api.github.com/users/ianweller/gists{/gist_id}","starred_url":"https://api.github.com/users/ianweller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianweller/subscriptions","organizations_url":"https://api.github.com/users/ianweller/orgs","repos_url":"https://api.github.com/users/ianweller/repos","events_url":"https://api.github.com/users/ianweller/events{/privacy}","received_events_url":"https://api.github.com/users/ianweller/received_events","type":"User","site_admin":false},"body":"This modifies `hack/make/build-rpm` to build RPMs for the Amazon Linux AMI. I'd greatly appreciate it if this could be considered for 1.9.\r\n\r\nBecause there is not a container image of the Amazon Linux AMI currently, the RPMs are built in a CentOS 7 container, which provides the most-similar version of RPM.\r\n\r\nA side-effect of using the CentOS 7 container is the presence of systemd-libs-devel (or an equivalent), which causes Docker to link against libsystemd-journal. There's a hack added to `hack/make.sh` to disable the journald build tag — if you have a better suggestion than the change I've made, let me know.\r\n\r\nI've done basic testing of a 1.9.0-dev RPM on the 2015.09 AMI, and verified that the CentOS 7 RPM still links to libsystemd-journal. I'd be happy to do thorough testing of officially built pre-release RPMs.","created_at":"2015-10-22T22:14:05Z","updated_at":"2015-12-14T17:32:50Z","closed_at":"2015-12-14T17:32:50Z","merged_at":null,"merge_commit_sha":"6eb343bc4405d81a1dace6fdafb1d9a68f5ec70c","assignee":{"login":"jfrazelle","id":1445228,"avatar_url":"https://avatars.githubusercontent.com/u/1445228?v=3","gravatar_id":"","url":"https://api.github.com/users/jfrazelle","html_url":"https://github.com/jfrazelle","followers_url":"https://api.github.com/users/jfrazelle/followers","following_url":"https://api.github.com/users/jfrazelle/following{/other_user}","gists_url":"https://api.github.com/users/jfrazelle/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrazelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrazelle/subscriptions","organizations_url":"https://api.github.com/users/jfrazelle/orgs","repos_url":"https://api.github.com/users/jfrazelle/repos","events_url":"https://api.github.com/users/jfrazelle/events{/privacy}","received_events_url":"https://api.github.com/users/jfrazelle/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/17283/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/17283/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/17283/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/05d7a56c6635483cdea5344901c8c9a8cb10edf9","head":{"label":"ianweller:amazon-rpms","ref":"amazon-rpms","sha":"05d7a56c6635483cdea5344901c8c9a8cb10edf9","user":{"login":"ianweller","id":52814,"avatar_url":"https://avatars.githubusercontent.com/u/52814?v=3","gravatar_id":"","url":"https://api.github.com/users/ianweller","html_url":"https://github.com/ianweller","followers_url":"https://api.github.com/users/ianweller/followers","following_url":"https://api.github.com/users/ianweller/following{/other_user}","gists_url":"https://api.github.com/users/ianweller/gists{/gist_id}","starred_url":"https://api.github.com/users/ianweller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianweller/subscriptions","organizations_url":"https://api.github.com/users/ianweller/orgs","repos_url":"https://api.github.com/users/ianweller/repos","events_url":"https://api.github.com/users/ianweller/events{/privacy}","received_events_url":"https://api.github.com/users/ianweller/received_events","type":"User","site_admin":false},"repo":{"id":44644503,"name":"docker","full_name":"ianweller/docker","owner":{"login":"ianweller","id":52814,"avatar_url":"https://avatars.githubusercontent.com/u/52814?v=3","gravatar_id":"","url":"https://api.github.com/users/ianweller","html_url":"https://github.com/ianweller","followers_url":"https://api.github.com/users/ianweller/followers","following_url":"https://api.github.com/users/ianweller/following{/other_user}","gists_url":"https://api.github.com/users/ianweller/gists{/gist_id}","starred_url":"https://api.github.com/users/ianweller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianweller/subscriptions","organizations_url":"https://api.github.com/users/ianweller/orgs","repos_url":"https://api.github.com/users/ianweller/repos","events_url":"https://api.github.com/users/ianweller/events{/privacy}","received_events_url":"https://api.github.com/users/ianweller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianweller/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/ianweller/docker","forks_url":"https://api.github.com/repos/ianweller/docker/forks","keys_url":"https://api.github.com/repos/ianweller/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianweller/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianweller/docker/teams","hooks_url":"https://api.github.com/repos/ianweller/docker/hooks","issue_events_url":"https://api.github.com/repos/ianweller/docker/issues/events{/number}","events_url":"https://api.github.com/repos/ianweller/docker/events","assignees_url":"https://api.github.com/repos/ianweller/docker/assignees{/user}","branches_url":"https://api.github.com/repos/ianweller/docker/branches{/branch}","tags_url":"https://api.github.com/repos/ianweller/docker/tags","blobs_url":"https://api.github.com/repos/ianweller/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianweller/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianweller/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianweller/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianweller/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/ianweller/docker/languages","stargazers_url":"https://api.github.com/repos/ianweller/docker/stargazers","contributors_url":"https://api.github.com/repos/ianweller/docker/contributors","subscribers_url":"https://api.github.com/repos/ianweller/docker/subscribers","subscription_url":"https://api.github.com/repos/ianweller/docker/subscription","commits_url":"https://api.github.com/repos/ianweller/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianweller/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianweller/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianweller/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianweller/docker/contents/{+path}","compare_url":"https://api.github.com/repos/ianweller/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianweller/docker/merges","archive_url":"https://api.github.com/repos/ianweller/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianweller/docker/downloads","issues_url":"https://api.github.com/repos/ianweller/docker/issues{/number}","pulls_url":"https://api.github.com/repos/ianweller/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/ianweller/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/ianweller/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianweller/docker/labels{/name}","releases_url":"https://api.github.com/repos/ianweller/docker/releases{/id}","created_at":"2015-10-21T01:13:22Z","updated_at":"2015-10-21T01:13:34Z","pushed_at":"2015-10-22T06:33:59Z","git_url":"git://github.com/ianweller/docker.git","ssh_url":"git@github.com:ianweller/docker.git","clone_url":"https://github.com/ianweller/docker.git","svn_url":"https://github.com/ianweller/docker","homepage":"http://www.docker.com","size":71643,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"4c253ddf204f0c8ebc58c1aa5796c689d623e16b","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-12-14T16:43:56Z","pushed_at":"2015-12-14T17:23:57Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":118292,"stargazers_count":27015,"watchers_count":27015,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7358,"mirror_url":null,"open_issues_count":1232,"forks":7358,"open_issues":1232,"watchers":27015,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/17283"},"html":{"href":"https://github.com/docker/docker/pull/17283"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/17283"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/17283/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/17283/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/17283/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/05d7a56c6635483cdea5344901c8c9a8cb10edf9"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":12,"review_comments":7,"commits":1,"additions":50,"deletions":10,"changed_files":5}}