{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/vert.x/pulls/comments/29757720","id":29757720,"diff_hunk":"@@ -1150,7 +1150,17 @@ public synchronized boolean isRegistered() {\n \n     @Override\n     public synchronized MessageConsumer<T> endHandler(Handler<Void> endHandler) {\n-      this.endHandler = endHandler;\n+      if (endHandler != null) {\n+        // We should use the HandlerHolder context to properly do this (needs small refactoring)","path":"src/main/java/io/vertx/core/eventbus/impl/EventBusImpl.java","position":6,"original_position":6,"commit_id":"fe656c9d7f0c45ad6e62c8acecb9f3db77932b37","original_commit_id":"fe656c9d7f0c45ad6e62c8acecb9f3db77932b37","user":{"login":"purplefox","id":701906,"avatar_url":"https://avatars.githubusercontent.com/u/701906?v=3","gravatar_id":"","url":"https://api.github.com/users/purplefox","html_url":"https://github.com/purplefox","followers_url":"https://api.github.com/users/purplefox/followers","following_url":"https://api.github.com/users/purplefox/following{/other_user}","gists_url":"https://api.github.com/users/purplefox/gists{/gist_id}","starred_url":"https://api.github.com/users/purplefox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purplefox/subscriptions","organizations_url":"https://api.github.com/users/purplefox/orgs","repos_url":"https://api.github.com/users/purplefox/repos","events_url":"https://api.github.com/users/purplefox/events{/privacy}","received_events_url":"https://api.github.com/users/purplefox/received_events","type":"User","site_admin":false},"body":"I agree. So why not do that? ;)","created_at":"2015-05-06T13:31:20Z","updated_at":"2015-05-06T13:31:20Z","html_url":"https://github.com/eclipse/vert.x/pull/1032#discussion_r29757720","pull_request_url":"https://api.github.com/repos/eclipse/vert.x/pulls/1032","_links":{"self":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/comments/29757720"},"html":{"href":"https://github.com/eclipse/vert.x/pull/1032#discussion_r29757720"},"pull_request":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/1032"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/vert.x/pulls/1032","id":34816366,"html_url":"https://github.com/eclipse/vert.x/pull/1032","diff_url":"https://github.com/eclipse/vert.x/pull/1032.diff","patch_url":"https://github.com/eclipse/vert.x/pull/1032.patch","issue_url":"https://api.github.com/repos/eclipse/vert.x/issues/1032","number":1032,"state":"open","locked":false,"title":"MessageConsumer#endHandler should be invoked with the registration context","user":{"login":"vietj","id":225674,"avatar_url":"https://avatars.githubusercontent.com/u/225674?v=3","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"body":"@purplefox please review this fix","created_at":"2015-05-06T13:29:21Z","updated_at":"2015-05-06T13:31:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e9ef8210f2daf7defc460ec48ebf966f8b445f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/vert.x/pulls/1032/commits","review_comments_url":"https://api.github.com/repos/eclipse/vert.x/pulls/1032/comments","review_comment_url":"https://api.github.com/repos/eclipse/vert.x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/vert.x/issues/1032/comments","statuses_url":"https://api.github.com/repos/eclipse/vert.x/statuses/fe656c9d7f0c45ad6e62c8acecb9f3db77932b37","head":{"label":"eclipse:messageconsumer-endhandler-called-with-right-context","ref":"messageconsumer-endhandler-called-with-right-context","sha":"fe656c9d7f0c45ad6e62c8acecb9f3db77932b37","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":1911523,"name":"vert.x","full_name":"eclipse/vert.x","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/vert.x","description":"vert.x - The scalable polyglot application platform for the JVM","fork":false,"url":"https://api.github.com/repos/eclipse/vert.x","forks_url":"https://api.github.com/repos/eclipse/vert.x/forks","keys_url":"https://api.github.com/repos/eclipse/vert.x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/vert.x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/vert.x/teams","hooks_url":"https://api.github.com/repos/eclipse/vert.x/hooks","issue_events_url":"https://api.github.com/repos/eclipse/vert.x/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/vert.x/events","assignees_url":"https://api.github.com/repos/eclipse/vert.x/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/vert.x/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/vert.x/tags","blobs_url":"https://api.github.com/repos/eclipse/vert.x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/vert.x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/vert.x/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/vert.x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/vert.x/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/vert.x/languages","stargazers_url":"https://api.github.com/repos/eclipse/vert.x/stargazers","contributors_url":"https://api.github.com/repos/eclipse/vert.x/contributors","subscribers_url":"https://api.github.com/repos/eclipse/vert.x/subscribers","subscription_url":"https://api.github.com/repos/eclipse/vert.x/subscription","commits_url":"https://api.github.com/repos/eclipse/vert.x/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/vert.x/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/vert.x/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/vert.x/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/vert.x/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/vert.x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/vert.x/merges","archive_url":"https://api.github.com/repos/eclipse/vert.x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/vert.x/downloads","issues_url":"https://api.github.com/repos/eclipse/vert.x/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/vert.x/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/vert.x/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/vert.x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/vert.x/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/vert.x/releases{/id}","created_at":"2011-06-17T14:54:55Z","updated_at":"2015-05-06T12:56:46Z","pushed_at":"2015-05-06T13:29:21Z","git_url":"git://github.com/eclipse/vert.x.git","ssh_url":"git@github.com:eclipse/vert.x.git","clone_url":"https://github.com/eclipse/vert.x.git","svn_url":"https://github.com/eclipse/vert.x","homepage":"","size":377027,"stargazers_count":3526,"watchers_count":3526,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":711,"mirror_url":null,"open_issues_count":19,"forks":711,"open_issues":19,"watchers":3526,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"042f39158a24e784b2fb289dbba8182b47198511","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":1911523,"name":"vert.x","full_name":"eclipse/vert.x","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/vert.x","description":"vert.x - The scalable polyglot application platform for the JVM","fork":false,"url":"https://api.github.com/repos/eclipse/vert.x","forks_url":"https://api.github.com/repos/eclipse/vert.x/forks","keys_url":"https://api.github.com/repos/eclipse/vert.x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/vert.x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/vert.x/teams","hooks_url":"https://api.github.com/repos/eclipse/vert.x/hooks","issue_events_url":"https://api.github.com/repos/eclipse/vert.x/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/vert.x/events","assignees_url":"https://api.github.com/repos/eclipse/vert.x/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/vert.x/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/vert.x/tags","blobs_url":"https://api.github.com/repos/eclipse/vert.x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/vert.x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/vert.x/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/vert.x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/vert.x/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/vert.x/languages","stargazers_url":"https://api.github.com/repos/eclipse/vert.x/stargazers","contributors_url":"https://api.github.com/repos/eclipse/vert.x/contributors","subscribers_url":"https://api.github.com/repos/eclipse/vert.x/subscribers","subscription_url":"https://api.github.com/repos/eclipse/vert.x/subscription","commits_url":"https://api.github.com/repos/eclipse/vert.x/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/vert.x/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/vert.x/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/vert.x/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/vert.x/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/vert.x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/vert.x/merges","archive_url":"https://api.github.com/repos/eclipse/vert.x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/vert.x/downloads","issues_url":"https://api.github.com/repos/eclipse/vert.x/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/vert.x/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/vert.x/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/vert.x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/vert.x/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/vert.x/releases{/id}","created_at":"2011-06-17T14:54:55Z","updated_at":"2015-05-06T12:56:46Z","pushed_at":"2015-05-06T13:29:21Z","git_url":"git://github.com/eclipse/vert.x.git","ssh_url":"git@github.com:eclipse/vert.x.git","clone_url":"https://github.com/eclipse/vert.x.git","svn_url":"https://github.com/eclipse/vert.x","homepage":"","size":377027,"stargazers_count":3526,"watchers_count":3526,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":711,"mirror_url":null,"open_issues_count":19,"forks":711,"open_issues":19,"watchers":3526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/1032"},"html":{"href":"https://github.com/eclipse/vert.x/pull/1032"},"issue":{"href":"https://api.github.com/repos/eclipse/vert.x/issues/1032"},"comments":{"href":"https://api.github.com/repos/eclipse/vert.x/issues/1032/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/1032/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/vert.x/pulls/1032/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/vert.x/statuses/fe656c9d7f0c45ad6e62c8acecb9f3db77932b37"}}}}