{"action":"created","issue":{"url":"https://api.github.com/repos/buchen/portfolio/issues/226","labels_url":"https://api.github.com/repos/buchen/portfolio/issues/226/labels{/name}","comments_url":"https://api.github.com/repos/buchen/portfolio/issues/226/comments","events_url":"https://api.github.com/repos/buchen/portfolio/issues/226/events","html_url":"https://github.com/buchen/portfolio/pull/226","id":54793913,"number":226,"title":"calculation methods for risk measures maximum drawdown and volatility","user":{"login":"simpsus","id":1447101,"avatar_url":"https://avatars.githubusercontent.com/u/1447101?v=3","gravatar_id":"","url":"https://api.github.com/users/simpsus","html_url":"https://github.com/simpsus","followers_url":"https://api.github.com/users/simpsus/followers","following_url":"https://api.github.com/users/simpsus/following{/other_user}","gists_url":"https://api.github.com/users/simpsus/gists{/gist_id}","starred_url":"https://api.github.com/users/simpsus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simpsus/subscriptions","organizations_url":"https://api.github.com/users/simpsus/orgs","repos_url":"https://api.github.com/users/simpsus/repos","events_url":"https://api.github.com/users/simpsus/events{/privacy}","received_events_url":"https://api.github.com/users/simpsus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-19T17:55:41Z","updated_at":"2015-01-19T18:53:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buchen/portfolio/pulls/226","html_url":"https://github.com/buchen/portfolio/pull/226","diff_url":"https://github.com/buchen/portfolio/pull/226.diff","patch_url":"https://github.com/buchen/portfolio/pull/226.patch"},"body":"#223 \r\ndie Methoden erwarten eine Liste aus doubles.\r\nBeide Methoden errechnen auf dem Weg auch eine weitere Liste der Interval-Werte. Evtl. will man sich sowas ja anzeigen lassen. Beim drawdown könnte ich mir das vorstellen, bei der vola .. keine ahnung.\r\n\r\nIch habe das mangels richtiger Daten nicht auf Herz und Nieren getestet."},"comment":{"url":"https://api.github.com/repos/buchen/portfolio/issues/comments/70542348","html_url":"https://github.com/buchen/portfolio/pull/226#issuecomment-70542348","issue_url":"https://api.github.com/repos/buchen/portfolio/issues/226","id":70542348,"user":{"login":"buchen","id":587976,"avatar_url":"https://avatars.githubusercontent.com/u/587976?v=3","gravatar_id":"","url":"https://api.github.com/users/buchen","html_url":"https://github.com/buchen","followers_url":"https://api.github.com/users/buchen/followers","following_url":"https://api.github.com/users/buchen/following{/other_user}","gists_url":"https://api.github.com/users/buchen/gists{/gist_id}","starred_url":"https://api.github.com/users/buchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchen/subscriptions","organizations_url":"https://api.github.com/users/buchen/orgs","repos_url":"https://api.github.com/users/buchen/repos","events_url":"https://api.github.com/users/buchen/events{/privacy}","received_events_url":"https://api.github.com/users/buchen/received_events","type":"User","site_admin":false},"created_at":"2015-01-19T18:53:56Z","updated_at":"2015-01-19T18:53:56Z","body":"Danke. Die Methoden sind doch schon mal hilfreich. Ich wüsste auch wo ich sie einbauen würde.\r\n\r\nKönntest Du\r\n* das auf ein double array umbauen, dann könnte man die Methode direkt mit den Input-Daten verwenden: https://github.com/buchen/portfolio/blob/master/name.abuchen.portfolio/src/name/abuchen/portfolio/snapshot/PerformanceIndex.java#L128\r\n* einen Test hinzufügen (das Paket ist genau das richtige)\r\n* und die System.out entfernen und richtig formatieren.\r\n\r\n\r\nWenn Du die Zahl auch anzeigen möchtest, dann wohl hier:\r\nhttps://github.com/buchen/portfolio/blob/master/name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/PerformanceView.java#L96\r\n\r\nAber Achtung, wegen der Währungsumstellung greife ich doch manchmal recht tief rein. Damit ich das später gut mergen kann, etwas vorsichtig mit grösseren umbauten :-)"}}