{"comment":{"url":"https://api.github.com/repos/zhekov/geany/comments/10437227","html_url":"https://github.com/zhekov/geany/commit/6e92c5f64aa4bcf4434a8d2b191f7e85724d231e#commitcomment-10437227","id":10437227,"user":{"login":"zhekov","id":1112714,"avatar_url":"https://avatars.githubusercontent.com/u/1112714?v=3","gravatar_id":"","url":"https://api.github.com/users/zhekov","html_url":"https://github.com/zhekov","followers_url":"https://api.github.com/users/zhekov/followers","following_url":"https://api.github.com/users/zhekov/following{/other_user}","gists_url":"https://api.github.com/users/zhekov/gists{/gist_id}","starred_url":"https://api.github.com/users/zhekov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhekov/subscriptions","organizations_url":"https://api.github.com/users/zhekov/orgs","repos_url":"https://api.github.com/users/zhekov/repos","events_url":"https://api.github.com/users/zhekov/events{/privacy}","received_events_url":"https://api.github.com/users/zhekov/received_events","type":"User","site_admin":false},"position":295,"line":238,"path":"src/tools.c","commit_id":"6e92c5f64aa4bcf4434a8d2b191f7e85724d231e","created_at":"2015-03-27T18:08:06Z","updated_at":"2015-03-27T18:08:06Z","body":"It can't be NULL, of course. I was unsure whether we should replace the selection if the tool returns no output (which is a legitimate result BTW), and ended placing a wrong check. Should test how the original works under *nix (the original Win32 always receives at least one G_IO_IN | G_IO_PRI, even with 0 bytes).\r\n\r\nIf a check is required, that should be if (*output->str), since we don't handle '\\0' bytes in the text."}}