{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/46618078","id":46618078,"diff_hunk":"@@ -0,0 +1,29 @@\n+apiVersion: v1","path":"cluster/gce/trusty/kube-manifest/fluentd-es.yaml","position":1,"original_position":1,"commit_id":"7c9e71646107a52ec7a8762c77edf66d2b9232ba","original_commit_id":"7c9e71646107a52ec7a8762c77edf66d2b9232ba","user":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"body":"An alternative: for the manifest files without salt configuration, such as these three files, we can simply copy them from cluster/saltbase/salt when creating the kube-manifest.tar.gz. So, the dir cluster/gce/trusty/kube-manifest only contains the manifests containing salt configurations, such as  etcd, api-server. This should be used by both CoreOS and trusty, so I am fine to move it to be cluster/gce/kube-manifest. Does it solve your concern?","created_at":"2015-12-03T21:52:19Z","updated_at":"2015-12-03T21:52:19Z","html_url":"https://github.com/kubernetes/kubernetes/pull/18115#discussion_r46618078","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18115","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/46618078"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18115#discussion_r46618078"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18115"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18115","id":52474324,"html_url":"https://github.com/kubernetes/kubernetes/pull/18115","diff_url":"https://github.com/kubernetes/kubernetes/pull/18115.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/18115.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18115","number":18115,"state":"open","locked":false,"title":"Prepare kube-system pods manifest for trusty nodes.","user":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"body":"The current trusty node support does not rely on salt, but it still downloads the salt tarball to extract needed kube-system pods manifest files for simplicity. However, this method will not work for master on trusty, because there are several manifest files with salt configuration. This change get rids of using salt tarball in trusty nodes. Instead, we put the manifest files under the directory cluster/gce/trusty/kube-manifest. For ongoing work of master on trusty, we will follow the same logic to get kube-system pods manifest.","created_at":"2015-12-03T00:10:29Z","updated_at":"2015-12-03T21:52:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"689025b447d76bea316cd0ac02a83c7110e26086","assignee":{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars.githubusercontent.com/u/7751204?v=3","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18115/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18115/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18115/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/7c9e71646107a52ec7a8762c77edf66d2b9232ba","head":{"label":"andyzheng0831:trusty","ref":"trusty","sha":"7c9e71646107a52ec7a8762c77edf66d2b9232ba","user":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"repo":{"id":44209465,"name":"kubernetes","full_name":"andyzheng0831/kubernetes","owner":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andyzheng0831/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/andyzheng0831/kubernetes","forks_url":"https://api.github.com/repos/andyzheng0831/kubernetes/forks","keys_url":"https://api.github.com/repos/andyzheng0831/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andyzheng0831/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andyzheng0831/kubernetes/teams","hooks_url":"https://api.github.com/repos/andyzheng0831/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/andyzheng0831/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/andyzheng0831/kubernetes/events","assignees_url":"https://api.github.com/repos/andyzheng0831/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/andyzheng0831/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/andyzheng0831/kubernetes/tags","blobs_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andyzheng0831/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/andyzheng0831/kubernetes/languages","stargazers_url":"https://api.github.com/repos/andyzheng0831/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/andyzheng0831/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/andyzheng0831/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/andyzheng0831/kubernetes/subscription","commits_url":"https://api.github.com/repos/andyzheng0831/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/andyzheng0831/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/andyzheng0831/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/andyzheng0831/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/andyzheng0831/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andyzheng0831/kubernetes/merges","archive_url":"https://api.github.com/repos/andyzheng0831/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andyzheng0831/kubernetes/downloads","issues_url":"https://api.github.com/repos/andyzheng0831/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/andyzheng0831/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/andyzheng0831/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/andyzheng0831/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andyzheng0831/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/andyzheng0831/kubernetes/releases{/id}","created_at":"2015-10-13T22:35:08Z","updated_at":"2015-10-13T22:35:25Z","pushed_at":"2015-12-03T19:12:37Z","git_url":"git://github.com/andyzheng0831/kubernetes.git","ssh_url":"git@github.com:andyzheng0831/kubernetes.git","clone_url":"https://github.com/andyzheng0831/kubernetes.git","svn_url":"https://github.com/andyzheng0831/kubernetes","homepage":"http://kubernetes.io","size":142496,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"537405fedab1060432ec4ef2ab4279f97c3a3e94","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-12-03T21:49:28Z","pushed_at":"2015-12-03T21:49:08Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":294824,"stargazers_count":11604,"watchers_count":11604,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3127,"mirror_url":null,"open_issues_count":2467,"forks":3127,"open_issues":2467,"watchers":11604,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18115"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18115"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18115"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18115/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18115/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18115/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/7c9e71646107a52ec7a8762c77edf66d2b9232ba"}}}}