{"action":"closed","number":233,"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/233","id":50560702,"html_url":"https://github.com/percona/percona-server/pull/233","diff_url":"https://github.com/percona/percona-server/pull/233.diff","patch_url":"https://github.com/percona/percona-server/pull/233.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/233","number":233,"state":"closed","locked":false,"title":"lp1512464 : mysqld got signal 11 while setting tokudb_backup_last_err…","user":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars.githubusercontent.com/u/5247783?v=3","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"body":"…or_string variable\r\n\r\ntokudb_backup_last_error and tokudb_backup_last_error_string should never have\r\nbeen variables, but status values. Since it is already done and some\r\napps/infrastructures may depend on these as they are, it is proper then to just\r\nfix the variable issues.\r\n\r\nThat being said, fixed up memory management of tokudb_backup_last_error_string\r\nso all allocation/free happens within the plugin and not spread across the\r\nserver and plugin.\r\n\r\nAlso added mtr/tokudb.backup test case that crashed as described in the bug\r\nreport and works correctly after the fix.\r\n\r\nhttps://bugs.launchpad.net/percona-server/+bug/1512464\r\n\r\nNo jenkins since the tokudb.backup suite is currently disabled, but here are local results:\r\n\r\nLogging: ./mtr  --mysqld=--loose-tokudb-cache-size=2G --force --retry=0 --retry-failure=0 --max-test-fail=0 --no-warnings --testcase-timeout=120 --suite=tokudb.backup\r\n2015-11-12 13:06:35 0 [Note] /ssd/toku/ST-57094/percona-server-install/bin/mysqld (mysqld 5.6.27-75.0-debug) starting as process 27334 ...\r\n2015-11-12 13:06:35 27334 [Note] Plugin 'FEDERATED' is disabled.\r\n2015-11-12 13:06:35 27334 [Note] Binlog end\r\n2015-11-12 13:06:35 27334 [Note] Shutting down plugin 'CSV'\r\n2015-11-12 13:06:35 27334 [Note] Shutting down plugin 'MyISAM'\r\nMySQL Version 5.6.27\r\nChecking supported features...\r\n - SSL connections supported\r\n - binaries are debug compiled\r\nUsing suites: tokudb.backup\r\nCollecting tests...\r\nChecking leftover processes...\r\nRemoving old var directory...\r\nCreating var directory '/ssd/toku/ST-57094/percona-server-install/mysql-test/var'...\r\nInstalling system database...\r\n\r\n==============================================================================\r\n\r\nTEST                                      RESULT   TIME (ms) or COMMENT\r\n--------------------------------------------------------------------------\r\n\r\nworker[1] Using MTR_BUILD_THREAD 300, with reserved ports 13000..13009\r\ntokudb.backup.tokudb_backup_exclude      [ pass ]    161\r\ntokudb.backup.tokudb_backup_set_last_error [ pass ]     10\r\n--------------------------------------------------------------------------\r\nThe servers were restarted 0 times\r\nSpent 0.171 of 7 seconds executing testcases\r\n\r\nCompleted: All 2 tests were successful.\r\n","created_at":"2015-11-12T20:07:47Z","updated_at":"2015-11-17T17:47:19Z","closed_at":"2015-11-17T17:47:19Z","merged_at":"2015-11-17T17:47:19Z","merge_commit_sha":"0274b165ebe78a1bf54d126da0cccc9e0776fcd6","assignee":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars.githubusercontent.com/u/5247783?v=3","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/233/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/233/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/233/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/316a4a9c81817fd3682b43ab9afefdb979c5919f","head":{"label":"georgelorchpercona:lp1512464","ref":"lp1512464","sha":"316a4a9c81817fd3682b43ab9afefdb979c5919f","user":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars.githubusercontent.com/u/5247783?v=3","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"repo":{"id":32110095,"name":"percona-server","full_name":"georgelorchpercona/percona-server","owner":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars.githubusercontent.com/u/5247783?v=3","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/georgelorchpercona/percona-server","description":"","fork":true,"url":"https://api.github.com/repos/georgelorchpercona/percona-server","forks_url":"https://api.github.com/repos/georgelorchpercona/percona-server/forks","keys_url":"https://api.github.com/repos/georgelorchpercona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georgelorchpercona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georgelorchpercona/percona-server/teams","hooks_url":"https://api.github.com/repos/georgelorchpercona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/georgelorchpercona/percona-server/events","assignees_url":"https://api.github.com/repos/georgelorchpercona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/georgelorchpercona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/georgelorchpercona/percona-server/tags","blobs_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georgelorchpercona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/georgelorchpercona/percona-server/languages","stargazers_url":"https://api.github.com/repos/georgelorchpercona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/georgelorchpercona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/georgelorchpercona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/georgelorchpercona/percona-server/subscription","commits_url":"https://api.github.com/repos/georgelorchpercona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/georgelorchpercona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/georgelorchpercona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/georgelorchpercona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/georgelorchpercona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georgelorchpercona/percona-server/merges","archive_url":"https://api.github.com/repos/georgelorchpercona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georgelorchpercona/percona-server/downloads","issues_url":"https://api.github.com/repos/georgelorchpercona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/georgelorchpercona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/georgelorchpercona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/georgelorchpercona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georgelorchpercona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/georgelorchpercona/percona-server/releases{/id}","created_at":"2015-03-12T23:58:07Z","updated_at":"2015-03-12T23:59:42Z","pushed_at":"2015-11-15T18:27:00Z","git_url":"git://github.com/georgelorchpercona/percona-server.git","ssh_url":"git@github.com:georgelorchpercona/percona-server.git","clone_url":"https://github.com/georgelorchpercona/percona-server.git","svn_url":"https://github.com/georgelorchpercona/percona-server","homepage":null,"size":384045,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.6"}},"base":{"label":"percona:5.6","ref":"5.6","sha":"f00af1ad41baeb10999225cc1085d0484464263c","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"name":"percona-server","full_name":"percona/percona-server","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-server","description":"","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","created_at":"2015-02-13T11:32:01Z","updated_at":"2015-11-16T03:22:35Z","pushed_at":"2015-11-17T17:47:19Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"git@github.com:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":null,"size":421574,"stargazers_count":63,"watchers_count":63,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":6,"forks":35,"open_issues":6,"watchers":63,"default_branch":"5.6"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/233"},"html":{"href":"https://github.com/percona/percona-server/pull/233"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/233"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/316a4a9c81817fd3682b43ab9afefdb979c5919f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"georgelorchpercona","id":5247783,"avatar_url":"https://avatars.githubusercontent.com/u/5247783?v=3","gravatar_id":"","url":"https://api.github.com/users/georgelorchpercona","html_url":"https://github.com/georgelorchpercona","followers_url":"https://api.github.com/users/georgelorchpercona/followers","following_url":"https://api.github.com/users/georgelorchpercona/following{/other_user}","gists_url":"https://api.github.com/users/georgelorchpercona/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelorchpercona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelorchpercona/subscriptions","organizations_url":"https://api.github.com/users/georgelorchpercona/orgs","repos_url":"https://api.github.com/users/georgelorchpercona/repos","events_url":"https://api.github.com/users/georgelorchpercona/events{/privacy}","received_events_url":"https://api.github.com/users/georgelorchpercona/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":112,"deletions":19,"changed_files":3}}