{"action":"created","issue":{"url":"https://api.github.com/repos/oasp/oasp4j/issues/255","labels_url":"https://api.github.com/repos/oasp/oasp4j/issues/255/labels{/name}","comments_url":"https://api.github.com/repos/oasp/oasp4j/issues/255/comments","events_url":"https://api.github.com/repos/oasp/oasp4j/issues/255/events","html_url":"https://github.com/oasp/oasp4j/pull/255","id":88980015,"number":255,"title":"#230 avoid redundant version numbers in POMs","user":{"login":"amarinso","id":9352103,"avatar_url":"https://avatars.githubusercontent.com/u/9352103?v=3","gravatar_id":"","url":"https://api.github.com/users/amarinso","html_url":"https://github.com/amarinso","followers_url":"https://api.github.com/users/amarinso/followers","following_url":"https://api.github.com/users/amarinso/following{/other_user}","gists_url":"https://api.github.com/users/amarinso/gists{/gist_id}","starred_url":"https://api.github.com/users/amarinso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarinso/subscriptions","organizations_url":"https://api.github.com/users/amarinso/orgs","repos_url":"https://api.github.com/users/amarinso/repos","events_url":"https://api.github.com/users/amarinso/events{/privacy}","received_events_url":"https://api.github.com/users/amarinso/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-06-17T10:33:40Z","updated_at":"2015-06-18T06:32:07Z","closed_at":"2015-06-17T19:49:15Z","pull_request":{"url":"https://api.github.com/repos/oasp/oasp4j/pulls/255","html_url":"https://github.com/oasp/oasp4j/pull/255","diff_url":"https://github.com/oasp/oasp4j/pull/255.diff","patch_url":"https://github.com/oasp/oasp4j/pull/255.patch"},"body":"I've moved \r\n`oasp4j/oasp4j-templates/oasp4j-template-server/src/main/templates/archetype-resources/pom.xml`\r\nto:\r\n`oasp4j/oasp4j-templates/oasp4j-template-server/src/main/resources/pom.xml`\r\n\r\nand then added filtering for resources on the `oasp4j/oasp4j-templates/oasp4j-template-server/pom.xml`\r\n\r\nI've added the properties :\r\n\r\n- `spring.boot.version`\r\n- `java.version`\r\n\r\nHave you identified more variables to change?"},"comment":{"url":"https://api.github.com/repos/oasp/oasp4j/issues/comments/113052045","html_url":"https://github.com/oasp/oasp4j/pull/255#issuecomment-113052045","issue_url":"https://api.github.com/repos/oasp/oasp4j/issues/255","id":113052045,"user":{"login":"hohwille","id":1923119,"avatar_url":"https://avatars.githubusercontent.com/u/1923119?v=3","gravatar_id":"","url":"https://api.github.com/users/hohwille","html_url":"https://github.com/hohwille","followers_url":"https://api.github.com/users/hohwille/followers","following_url":"https://api.github.com/users/hohwille/following{/other_user}","gists_url":"https://api.github.com/users/hohwille/gists{/gist_id}","starred_url":"https://api.github.com/users/hohwille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hohwille/subscriptions","organizations_url":"https://api.github.com/users/hohwille/orgs","repos_url":"https://api.github.com/users/hohwille/repos","events_url":"https://api.github.com/users/hohwille/events{/privacy}","received_events_url":"https://api.github.com/users/hohwille/received_events","type":"User","site_admin":false},"created_at":"2015-06-18T06:32:07Z","updated_at":"2015-06-18T06:32:07Z","body":"Both spring BOM and OASP and most other maven projects I know just use a variable called ```java.version``` in the POM. However, this is also a predefined system property of the JVM:\r\nhttps://docs.oracle.com/javase/tutorial/essential/environment/sysprop.html\r\n\r\nThat seems to cause the problem when resolving ```${java.version}``` here as in our case the JVM system property value was resolved from some reason that is the exact JVM java version including minor and update level. This however is not accepted by javac.\r\n\r\nAnyhow it seems pointless to separate ```maven.compiler.source``` and ```maven.compiler.target``` as it will never work properly if they are different. This was invented in javac with the idea in mind that you could compile new syntax to older byte-code but that never ever worked out.\r\n\r\nI would still like to see a solution using ```java.version``` as this is the convenience way to do it also used in ```spring-boot-starter-parent``` that we will go to extend sooner or later. \r\n\r\nI still do not 100% understand why maven is resolving ```${java.version}``` here. I thought with our current approach only ```^property^```` would be resolved but not ```${property}```. Maybe there is an excuse if the property is a JVM system property what would fully explain the problem and might clash with other system properties as well."}}