{"action":"created","issue":{"url":"https://api.github.com/repos/simbody/simbody/issues/356","labels_url":"https://api.github.com/repos/simbody/simbody/issues/356/labels{/name}","comments_url":"https://api.github.com/repos/simbody/simbody/issues/356/comments","events_url":"https://api.github.com/repos/simbody/simbody/issues/356/events","html_url":"https://github.com/simbody/simbody/pull/356","id":66094264,"number":356,"title":"Export Simbody targets in SimbodyConfig.cmake files","user":{"login":"elen4","id":3841320,"avatar_url":"https://avatars.githubusercontent.com/u/3841320?v=3","gravatar_id":"","url":"https://api.github.com/users/elen4","html_url":"https://github.com/elen4","followers_url":"https://api.github.com/users/elen4/followers","following_url":"https://api.github.com/users/elen4/following{/other_user}","gists_url":"https://api.github.com/users/elen4/gists{/gist_id}","starred_url":"https://api.github.com/users/elen4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elen4/subscriptions","organizations_url":"https://api.github.com/users/elen4/orgs","repos_url":"https://api.github.com/users/elen4/repos","events_url":"https://api.github.com/users/elen4/events{/privacy}","received_events_url":"https://api.github.com/users/elen4/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-04-03T07:06:27Z","updated_at":"2015-04-05T18:37:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/simbody/simbody/pulls/356","html_url":"https://github.com/simbody/simbody/pull/356","diff_url":"https://github.com/simbody/simbody/pull/356.diff","patch_url":"https://github.com/simbody/simbody/pull/356.patch"},"body":"Currently, SimbodyConfig.cmake is an adaptation of FindSimbody.cmake, and libraries are found using the `find_library` command.\r\nWith this PR, libraries are *exported* so that downstream packages can import them (along with their properties) through SimbodyConfig.cmake.\r\n\r\nTested with OpenSim (master) compilation on Windows (VS2013, 64bit) and Ubuntu 14.04, but it's hard to tell if this can break other downstream packages' build :confused: \r\n\r\n**Note1**: There are also some pure-cleanup commits, hope they don't create too much confusion\r\n\r\n**Note2**: I was trying also to get rid of the need for the deprecated `link_directories` command, but I cannot find a way to trick CMake into treating as targets the blas/lapack/pthread libraries that are provided as binaries on Windows :confounded: "},"comment":{"url":"https://api.github.com/repos/simbody/simbody/issues/comments/89830550","html_url":"https://github.com/simbody/simbody/pull/356#issuecomment-89830550","issue_url":"https://api.github.com/repos/simbody/simbody/issues/356","id":89830550,"user":{"login":"sherm1","id":4088016,"avatar_url":"https://avatars.githubusercontent.com/u/4088016?v=3","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},"created_at":"2015-04-05T18:37:48Z","updated_at":"2015-04-05T18:37:48Z","body":"> if I changed the installation directory after the first CMake pass, the symbolic link would still point to the first (default) installation directory\r\n\r\nGood find! That sounds like a bug that should be fixed. Doing it in its own PR would make it easier to test since we would know the limited circumstances in which the change has an effect."}}