{"action":"created","comment":{"url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/comments/45708763","id":45708763,"diff_hunk":"@@ -42,19 +42,18 @@\n _logger = logging.getLogger('glancesync')\n \n \n-def get_master_region_dict(image_list):\n-    \"\"\"Convert the image list to a dictionary indexed by name and also\n-    replace at parameters kernel_id and ramdisk_id the UUID with the name of\n+def clean_ami_ids(image_dict):\n+    \"\"\"replace at parameters kernel_id and ramdisk_id the UUID with the name of\n     the image.\n \n-    :param image_list: the list of images on the master region\n-    :return: a dictionary indexed by name\n+    :param image_dict: a dictionary of master images\n+    :return: nothing","path":"glancesync/glancesync_ami.py","position":14,"original_position":14,"commit_id":"2702116d43d45a20057a0c3d2fc0fd5f7f37c2f0","original_commit_id":"2702116d43d45a20057a0c3d2fc0fd5f7f37c2f0","user":{"login":"chemaper","id":8962900,"avatar_url":"https://avatars.githubusercontent.com/u/8962900?v=3","gravatar_id":"","url":"https://api.github.com/users/chemaper","html_url":"https://github.com/chemaper","followers_url":"https://api.github.com/users/chemaper/followers","following_url":"https://api.github.com/users/chemaper/following{/other_user}","gists_url":"https://api.github.com/users/chemaper/gists{/gist_id}","starred_url":"https://api.github.com/users/chemaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemaper/subscriptions","organizations_url":"https://api.github.com/users/chemaper/orgs","repos_url":"https://api.github.com/users/chemaper/repos","events_url":"https://api.github.com/users/chemaper/events{/privacy}","received_events_url":"https://api.github.com/users/chemaper/received_events","type":"User","site_admin":false},"body":"It does what the docstring says. It does not need to return/print nothing, because if receives a dictionary and iterates over the dictionary changing the elements of the dictionary.","created_at":"2015-11-24T08:51:32Z","updated_at":"2015-11-24T08:51:32Z","html_url":"https://github.com/telefonicaid/fiware-glancesync/pull/40#discussion_r45708763","pull_request_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/comments/45708763"},"html":{"href":"https://github.com/telefonicaid/fiware-glancesync/pull/40#discussion_r45708763"},"pull_request":{"href":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/40","id":51547948,"html_url":"https://github.com/telefonicaid/fiware-glancesync/pull/40","diff_url":"https://github.com/telefonicaid/fiware-glancesync/pull/40.diff","patch_url":"https://github.com/telefonicaid/fiware-glancesync/pull/40.patch","issue_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/issues/40","number":40,"state":"open","locked":false,"title":"Bug/claudia 5416","user":{"login":"chemaper","id":8962900,"avatar_url":"https://avatars.githubusercontent.com/u/8962900?v=3","gravatar_id":"","url":"https://api.github.com/users/chemaper","html_url":"https://github.com/chemaper","followers_url":"https://api.github.com/users/chemaper/followers","following_url":"https://api.github.com/users/chemaper/following{/other_user}","gists_url":"https://api.github.com/users/chemaper/gists{/gist_id}","starred_url":"https://api.github.com/users/chemaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemaper/subscriptions","organizations_url":"https://api.github.com/users/chemaper/orgs","repos_url":"https://api.github.com/users/chemaper/repos","events_url":"https://api.github.com/users/chemaper/events{/privacy}","received_events_url":"https://api.github.com/users/chemaper/received_events","type":"User","site_admin":false},"body":"#### Reviewers\r\n@flopezag @jframos \r\n \r\n#### Description\r\nBug CLAUDIA-5416, about warning when there are two images with the same name in master\r\n\r\nThe code prints a warning and also omit the image (i.e. if there are two images with the same name, both images are ignored). This is done for consistency.\r\n\r\nA related change is that images of other tenants are filter silently. This affects indirectly to this bug, because if images of other tenants are accepted, this implies that other user may cause a duplicate adding an image with the same name.\r\n\r\nFinally, a missing info message with obsoleted images has been added.\r\n \r\n#### Testing\r\nLocally","created_at":"2015-11-23T16:44:20Z","updated_at":"2015-11-24T08:51:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40c1d3fd4415b561e006c7c3daf3663ab7a0a82d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/40/commits","review_comments_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/40/comments","review_comment_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/issues/40/comments","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/statuses/2702116d43d45a20057a0c3d2fc0fd5f7f37c2f0","head":{"label":"telefonicaid:bug/claudia-5416","ref":"bug/claudia-5416","sha":"2702116d43d45a20057a0c3d2fc0fd5f7f37c2f0","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":39255854,"name":"fiware-glancesync","full_name":"telefonicaid/fiware-glancesync","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-glancesync","description":"","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-glancesync","forks_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/issues/comments{/number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/releases{/id}","created_at":"2015-07-17T13:38:48Z","updated_at":"2015-07-17T14:15:55Z","pushed_at":"2015-11-23T16:49:36Z","git_url":"git://github.com/telefonicaid/fiware-glancesync.git","ssh_url":"git@github.com:telefonicaid/fiware-glancesync.git","clone_url":"https://github.com/telefonicaid/fiware-glancesync.git","svn_url":"https://github.com/telefonicaid/fiware-glancesync","homepage":null,"size":10345,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"telefonicaid:develop","ref":"develop","sha":"0b29097f5c1b2c362a5927f15f62e9e46f460dbd","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":39255854,"name":"fiware-glancesync","full_name":"telefonicaid/fiware-glancesync","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars.githubusercontent.com/u/968363?v=3","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-glancesync","description":"","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-glancesync","forks_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/issues/comments{/number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-glancesync/releases{/id}","created_at":"2015-07-17T13:38:48Z","updated_at":"2015-07-17T14:15:55Z","pushed_at":"2015-11-23T16:49:36Z","git_url":"git://github.com/telefonicaid/fiware-glancesync.git","ssh_url":"git@github.com:telefonicaid/fiware-glancesync.git","clone_url":"https://github.com/telefonicaid/fiware-glancesync.git","svn_url":"https://github.com/telefonicaid/fiware-glancesync","homepage":null,"size":10345,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/40"},"html":{"href":"https://github.com/telefonicaid/fiware-glancesync/pull/40"},"issue":{"href":"https://api.github.com/repos/telefonicaid/fiware-glancesync/issues/40"},"comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-glancesync/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telefonicaid/fiware-glancesync/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/telefonicaid/fiware-glancesync/statuses/2702116d43d45a20057a0c3d2fc0fd5f7f37c2f0"}}}}