{"action":"created","issue":{"url":"https://api.github.com/repos/hw-cookbooks/graphite/issues/197","labels_url":"https://api.github.com/repos/hw-cookbooks/graphite/issues/197/labels{/name}","comments_url":"https://api.github.com/repos/hw-cookbooks/graphite/issues/197/comments","events_url":"https://api.github.com/repos/hw-cookbooks/graphite/issues/197/events","html_url":"https://github.com/hw-cookbooks/graphite/issues/197","id":44759044,"number":197,"title":"Please come talk to me or dan at the summit","user":{"login":"lamont-granquist","id":454857,"avatar_url":"https://avatars.githubusercontent.com/u/454857?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":28,"created_at":"2014-10-03T01:46:39Z","updated_at":"2015-06-12T05:04:19Z","closed_at":null,"body":"The accumulator pattern in this cookbook where it looks like you're modifying the resource collection at converge time creating dynamic attributes in providers is gonna fail in ways that we can't rescue you from.  You should really use definitions for this purpose (e.g. the \"Many Recipes, One Definition\" section of https://docs.getchef.com/essentials_cookbook_definitions.html documentation).  I'm not sure how you wound up with the design decision to do that kind of mutating of the resource collection inside providers so I don't quite know what to tell you.  If you think you shouldn't be using definitions then that is incorrect, and you have stumbled across the use case for which providers are terrible at and definitions are wonderful for.  You can simply disable the foodcritic rule that nag you about them and move on.  If there's a problem with using definitions then it'd be nice to know what that problem is, since its probably a chef bug and/or a design element that we need to understand for making them better.  "},"comment":{"url":"https://api.github.com/repos/hw-cookbooks/graphite/issues/comments/111359548","html_url":"https://github.com/hw-cookbooks/graphite/issues/197#issuecomment-111359548","issue_url":"https://api.github.com/repos/hw-cookbooks/graphite/issues/197","id":111359548,"user":{"login":"cwjohnston","id":148017,"avatar_url":"https://avatars.githubusercontent.com/u/148017?v=3","gravatar_id":"","url":"https://api.github.com/users/cwjohnston","html_url":"https://github.com/cwjohnston","followers_url":"https://api.github.com/users/cwjohnston/followers","following_url":"https://api.github.com/users/cwjohnston/following{/other_user}","gists_url":"https://api.github.com/users/cwjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/cwjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwjohnston/subscriptions","organizations_url":"https://api.github.com/users/cwjohnston/orgs","repos_url":"https://api.github.com/users/cwjohnston/repos","events_url":"https://api.github.com/users/cwjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/cwjohnston/received_events","type":"User","site_admin":false},"created_at":"2015-06-12T05:04:19Z","updated_at":"2015-06-12T05:04:19Z","body":"Hi Jeff, thanks for inquiring. I've burned a bunch of hours on a refactor and ran into a few  obstacles which have led me to shelf that effort for the time being.\n\nI am beginning to work on other issues outstanding on this project, with the intent of returning to this issue at a later time. In the meantime, if you or anyone else would like to attempt the refactor, I would be happy to assist with that work."}}