{"push_id":550656187,"size":17,"distinct_size":17,"ref":"refs/heads/master","head":"2e50ba744339522be2f29fe11210ebb91e3915bf","before":"f92a2e40aa36d58833b703830a07bfade499a073","commits":[{"sha":"080e4d17bc2e2a65cf2e5f5411ec625638a1dde1","author":{"email":"a82ad16292c9f3b890b7b13c336ff95f6bd02623@webkit.org","name":"commit-queue@webkit.org"},"message":"Canonicalization of :lang() should preserve the :lang()'s arguments representations\nhttps://bugs.webkit.org/show_bug.cgi?id=139928\n\nPatch by Dhi Aurrahman <diorahman@rockybars.com> on 2015-01-19\nReviewed by Benjamin Poulain.\n\nSource/WebCore:\n\nPreserve the representation of IDENT and STRING when serializing the\n:lang(). For example, :lang(foo,\"bar\", baz) should be serialize as\n:lang(foo, \"bar\", baz) instead of :lang(foo, bar, baz).\n\nRename CSSParserSelector::setArgumentList, CSSSelector::setArgumentList\nand CSSSelector::argumentList to CSSParserSelector::setLangArgumentList,\nCSSSelector::setLangArgumentList and CSSSelector::langArgumentList\nrespectively, since those methods are being exclusively used in respect\nwith :lang().\n\nUpdate the test of serializing :lang() with IDENT and STRING arguments.\n\n* css/CSSGrammar.y.in:\n* css/CSSParserValues.cpp:\n(WebCore::CSSParserSelector::setLangArgumentList):\n(WebCore::CSSParserSelector::setArgumentList): Deleted.\n* css/CSSParserValues.h:\n(WebCore::CSSParserString::tokenType):\n(WebCore::CSSParserString::setTokenType):\n* css/CSSSelector.cpp:\n(WebCore::appendLangArgumentList):\n(WebCore::CSSSelector::selectorText):\n(WebCore::CSSSelector::setLangArgumentList):\n(WebCore::appendArgumentList): Deleted.\n(WebCore::CSSSelector::setArgumentList): Deleted.\n* css/CSSSelector.h:\n(WebCore::CSSSelector::langArgumentList):\n(WebCore::CSSSelector::argumentList): Deleted.\n* css/SelectorChecker.cpp:\n(WebCore::SelectorChecker::checkOne):\n* css/SelectorCheckerTestFunctions.h:\n(WebCore::matchesLangPseudoClass):\n\nLayoutTests:\n\n* fast/css/css-lang-selector-with-string-arguments-text-expected.txt:\n* fast/css/css-lang-selector-with-string-arguments-text.html:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178675 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/080e4d17bc2e2a65cf2e5f5411ec625638a1dde1"},{"sha":"de49c6a709a26ccc9f4c239a908b6185a8996fca","author":{"email":"fdaf4f444665d7fe9551ea4df3463be25e3fb623@apple.com","name":"bdakin@apple.com"},"message":"REGRESSION (r178290): Yellow highlight from context menu Lookup in Dictionary is \noffset by flipped-ness\nhttps://bugs.webkit.org/show_bug.cgi?id=140643\n-and corresponding-\nrdar://problem/19489593\n\nReviewed by Tim Horton.\n\nWe universally flipped because we assumed that the root view was flipped and the \nWebView was not. However, in Dictionary, the WebView is flipped! So this patch \nfixes that assumption by checking the WebView’s flipped-ness.\n* WebView/WebView.mm:\n(-[WebView _convertRectFromRootView:]):\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178676 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/de49c6a709a26ccc9f4c239a908b6185a8996fca"},{"sha":"4e498dbc214a6f6dccc6581511ad8199a58c1ff4","author":{"email":"75627661c6524c42f6b15cccebd09e42ccf63aa6@apple.com","name":"roger_fong@apple.com"},"message":"[Mac] Test fix after r178674.\n* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:\n* platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178677 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/4e498dbc214a6f6dccc6581511ad8199a58c1ff4"},{"sha":"dd11e0e63822df9d20d3b0d56fef32431debe485","author":{"email":"40fc0cb507030a081616f25547d9cd1b104aae47@apple.com","name":"bfulgham@apple.com"},"message":"[Win] Unreviewed Windows gardening.\n\nRebaseline a few tests based on current bot output.\n\n* platform/win/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:\n* platform/win/fast/regions/region-dynamic-after-before-expected.txt:\n* platform/win/fast/regions/region-generated-content-before-after-expected.txt:\n* platform/win/fast/regions/text-region-split-small-pagination-expected.txt:\n* platform/win/fast/text/international/thai-baht-space-expected.txt:\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178678 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/dd11e0e63822df9d20d3b0d56fef32431debe485"},{"sha":"cf09738bbbc39be8455652be54b02eab8c134c5b","author":{"email":"f6a40302e70d3875826ddafd7e450bcee2d7be56@apple.com","name":"timothy_horton@apple.com"},"message":"Adjust naming of action menu SPI\nhttps://bugs.webkit.org/show_bug.cgi?id=140644\n<rdar://problem/19448129>\n\nReviewed by Brian Weinstein.\n\n* platform/spi/mac/NSViewSPI.h:\nAdd an underscore.\n\n* WebView/WebActionMenuController.mm:\n(-[WebActionMenuController prepareForMenu:withEvent:]):\n(-[WebActionMenuController willOpenMenu:withEvent:]):\n(-[WebActionMenuController didCloseMenu:withEvent:]):\n* WebView/WebView.mm:\n(-[WebView _commonInitializationWithFrameName:groupName:]):\n(-[WebView prepareForMenu:withEvent:]):\n(-[WebView willOpenMenu:withEvent:]):\n(-[WebView didCloseMenu:withEvent:]):\n\n* UIProcess/API/mac/WKView.mm:\n(-[WKView initWithFrame:processPool:configuration:webView:]):\n* UIProcess/mac/WKActionMenuController.mm:\n(-[WKActionMenuController prepareForMenu:withEvent:]):\n(-[WKActionMenuController willOpenMenu:withEvent:]):\n(-[WKActionMenuController didCloseMenu:withEvent:]):\n(-[WKActionMenuController menuNeedsUpdate:]):\n(-[WKActionMenuController _updateActionMenuItems]):\n\n* TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:\n(-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):\n(TestWebKitAPI::TEST):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178679 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/cf09738bbbc39be8455652be54b02eab8c134c5b"},{"sha":"c61de691ed162d709e13ac14166ecce2babf95d2","author":{"email":"fdaf4f444665d7fe9551ea4df3463be25e3fb623@apple.com","name":"bdakin@apple.com"},"message":"Speculative build fix.\n\n* WebView/WebView.mm:\n(-[WebView _convertRectFromRootView:]):\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178680 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/c61de691ed162d709e13ac14166ecce2babf95d2"},{"sha":"8cb90a32a91d03d9edfa436ba51f5881b1287b19","author":{"email":"fdaf4f444665d7fe9551ea4df3463be25e3fb623@apple.com","name":"bdakin@apple.com"},"message":"Source/WebCore:\nSpeculative build fix.\n\n* platform/spi/mac/NSViewSPI.h:\n\nSource/WebKit/mac:\nSpeculative build fix.\n\n* WebView/WebView.mm:\n(-[WebView _commonInitializationWithFrameName:groupName:]):\n\nSource/WebKit2:\n Speculative build fix.\n\n* UIProcess/API/mac/WKView.mm:\n(-[WKView initWithFrame:processPool:configuration:webView:]):\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178681 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/8cb90a32a91d03d9edfa436ba51f5881b1287b19"},{"sha":"2bbb37681a87f4aa06dbc0e34e982f0589588215","author":{"email":"02f199576e3fa8dd317089ce53371c928ff2f6f2@samsung.com","name":"gyuyoung.kim@samsung.com"},"message":"[CMAKE] Fix cmake warning\nhttps://bugs.webkit.org/show_bug.cgi?id=140497\n\nReviewed by Gustavo Noronha Silva.\n\nr173155 already tried to fix cmake warning though, the warning is still exist.\nCMAKE_LINK_INTERFACE_LIBRARIES seems to cause this warning. Individual target is\nalready set for their libraries though, INTERFACE_LINK_LIBRARIES contains the list\nof transitive link dependencies, and CMAKE_LINK_INTERFACE_LIBRARIES can override\nthe INTERFACE_LINK_LIBRARIES property when CMP0022 is not set. CMake warns this override.\nTo avoid it, EFL port doesn't set CMAKE_LINK_INTERFACE_LIBRARIES.\n\n* CMakeLists.txt:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178682 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/2bbb37681a87f4aa06dbc0e34e982f0589588215"},{"sha":"47cb3f7fc46e922561ff2eb9927e3b4a8b5e7900","author":{"email":"8f3a129bc83673565f000899a2a2ef93d9111231@apple.com","name":"akling@apple.com"},"message":"LayoutState and subtree layout code should use RenderElement.\n<https://webkit.org/b/126878>\n\nSubtree layout will never begin at a RenderText, so tighten up\nthe code to operate on RenderElements instead of RenderObjects.\n\nReviewed by Antti Koivisto.\n\n* inspector/InspectorTimelineAgent.cpp:\n(WebCore::InspectorTimelineAgent::willLayout):\n* page/FrameView.cpp:\n(WebCore::FrameView::layoutRoot):\n(WebCore::FrameView::layout):\n* page/FrameView.h:\n\n    Make FrameView::layoutRoot() return RenderElement*.\n\n* rendering/RenderElement.cpp:\n(WebCore::RenderElement::willBeDestroyed):\n* rendering/RenderObject.cpp:\n(WebCore::RenderObject::willBeDestroyed):\n* rendering/RenderObject.h:\n\n    Move subtree layout root clearing logic in willBeDestroyed()\n    from RenderObject to RenderElement.\n\n* rendering/LayoutState.cpp:\n(WebCore::LayoutState::LayoutState):\n* rendering/LayoutState.h:\n* rendering/RenderView.h:\n* rendering/RenderView.cpp:\n(WebCore::RenderView::pushLayoutState):\n(WebCore::RenderView::pushLayoutStateForCurrentFlowThread):\n\n    Make all of these functions take RenderElement instead of\n    RenderObject since layout never starts from a RenderText.\n\n(WebCore::RenderView::shouldDisableLayoutStateForSubtree):\n\n    Tweak loop since it's never null on first iteration.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178683 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/47cb3f7fc46e922561ff2eb9927e3b4a8b5e7900"},{"sha":"e1318502d0ad2d2782795777250c36a2cc0000fd","author":{"email":"083d44ce61b1f946a3aa6fbd704954e0195d0658@apple.com","name":"cdumez@apple.com"},"message":"Stop using FeatureCounter to log navigation types\nhttps://bugs.webkit.org/show_bug.cgi?id=140642\n\nReviewed by Andreas Kling.\n\nStop using FeatureCounter to log navigation types now that\nDiagnosticLoggingClient is working on iOS.\n\n* loader/FrameLoader.cpp:\n(WebCore::logNavigation):\n* platform/FeatureCounterKeys.h:\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178684 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/e1318502d0ad2d2782795777250c36a2cc0000fd"},{"sha":"d03d8f10cd769204a1b445f5a360a41d09b53aa6","author":{"email":"1213f304cb4206c2f96b41c3de6fca27b6572fb1@apple.com","name":"weinig@apple.com"},"message":"Merge API::ProcessPoolConfiguration and _WKProcessPoolConfiguration\nhttps://bugs.webkit.org/show_bug.cgi?id=140601\n\nReviewed by Anders Carlsson.\n\n- Converts _WKProcessPoolConfiguration to be backed via API::ProcessPoolConfiguration.\n- Expands API::ProcessPoolConfiguration to add all the parameters necessary to fully\n  initialize a WebProcessPool. This allows -[WKProcessPool _initWithConfiguration:] to\n  be a simple pass through initializer, which in turn allows us to consider WebProcessPools\n  created on the C++ and Objective-C sides as equivalent.\n- Makes WebProcessPool own the reference to the API::ProcessPoolConfiguration (rather than\n  the WKProcessPool wrapper).\n\n* Shared/Cocoa/APIObject.mm:\n(API::Object::newObject):\nCreate the API::ProcessPoolConfigurations using [_WKProcessPoolConfiguration alloc] as its \nstorage..\n\n* UIProcess/API/APIProcessPoolConfiguration.cpp:\n(API::ProcessPoolConfiguration::create):\n(API::ProcessPoolConfiguration::createWithLegacyOptions):\n(API::ProcessPoolConfiguration::ProcessPoolConfiguration):\n(API::ProcessPoolConfiguration::~ProcessPoolConfiguration):\n(API::ProcessPoolConfiguration::copy):\n(API::ProcessPoolConfiguration::webProcessPoolConfiguration): Deleted.\n* UIProcess/API/APIProcessPoolConfiguration.h:\nAdd the remaining initialization parameters and add a convenience create function\nfor configuring legacy WebProcessPools (for use by the C-SPI).\n\n* UIProcess/API/APIWebsiteDataStore.cpp:\n(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):\n* UIProcess/API/APIWebsiteDataStore.h:\n* UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:\n(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):\n(API::WebsiteDataStore::defaultDataStoreConfiguration):\nExpose helper for getting the website data directories for use in the ProcessPoolConfiguration.\n\n* UIProcess/API/C/WKContext.cpp:\n(WKContextCreate):\n(WKContextCreateWithInjectedBundlePath):\n(WKContextCreateWithConfiguration):\nUse ProcessPoolConfiguration::createWithLegacyOptions() to keep backwards compatibility.\n\n* UIProcess/API/C/WKContextConfigurationRef.cpp:\n(WKContextConfigurationCreate):\nUpdate for ProcessPoolConfiguration::create() returning a Ref. Note, this function\nwas not changed to call ProcessPoolConfiguration::createWithLegacyOptions() since\nit has not been around long enough to warrant it.\n\n* UIProcess/API/Cocoa/WKProcessGroup.mm:\n(-[WKProcessGroup initWithInjectedBundleURL:]):\nUse ProcessPoolConfiguration::createWithLegacyOptions() to keep backwards compatibility.\n\n* UIProcess/API/Cocoa/WKProcessPool.mm:\n(-[WKProcessPool description]):\nChange to pull the configuration from the underlying API::Object.\n\n(-[WKProcessPool _configuration]):\nChange to pull the configuration from the underlying API::Object and call the new\ncopy() helper on it.\n        \n(-[WKProcessPool _initWithConfiguration:]):\nConvert to be a simple pass through to API::Object::constructInWrapper.\n\n(websiteDataDirectoryURL): Deleted.\nMoved to APIWebsiteDataStore.h\n\n* UIProcess/API/Cocoa/WKProcessPoolInternal.h:\nRemoves the _WKProcessPoolConfiguration member, now that it is stored on the WebProcessPool.\n        \n* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:\n(-[_WKProcessPoolConfiguration init]):\n(-[_WKProcessPoolConfiguration dealloc]):\nAdded to support API::Object bridging.\n\n(-[_WKProcessPoolConfiguration injectedBundleURL]):\n(-[_WKProcessPoolConfiguration setInjectedBundleURL:]):\nConvert to getting the URL from the underlying object. Moved the exception\nthat used to be on creation of the WKProcessPool.\n\n(-[_WKProcessPoolConfiguration maximumProcessCount]):\n(-[_WKProcessPoolConfiguration setMaximumProcessCount:]):\nConvert to getting the count from the underlying object.\n\n(-[_WKProcessPoolConfiguration cachePartitionedURLSchemes]):\nConvert to constructing the NSArray on demand from the underlying Vector.\n\n(-[_WKProcessPoolConfiguration setCachePartitionedURLSchemes:]):\nConverts the NSArray to a Vector rather than storing the array.\n\n* UIProcess/API/Cocoa/_WKProcessPoolConfigurationInternal.h: Added.\n(API::wrapper):\nAdd boilerplate for API::Object bridging.\n\n* UIProcess/API/gtk/WebKitWebContext.cpp:\n(webkitWebContextConstructed):\nUpdate to use API::ProcessPoolConfiguration::createWithLegacyOptions() to keep backwards compatibility.\n\n\n* UIProcess/WebInspectorProxy.cpp:\n(WebKit::WebInspectorProxy::inspectorProcessPool):\nUpdate to call API::ProcessPoolConfiguration::createWithLegacyOptions().\n\n* UIProcess/WebProcessPool.cpp:\n(WebKit::WebProcessPool::create):\n(WebKit::websiteDataStoreConfiguration):\n(WebKit::WebProcessPool::WebProcessPool):\n(WebKit::WebProcessPool::applyPlatformSpecificConfigurationDefaults): Deleted.\nThis functionality was moved to the constructor of the API::ProcessPoolConfiguration.\n* UIProcess/WebProcessPool.h:\nChanged to take (and store) a API::ProcessPoolConfiguration rather than the WebProcessPoolConfiguration.\n\n* UIProcess/Cocoa/WebProcessPoolCocoa.mm:\n(WebKit::WebProcessPool::legacyPlatformDefaultWebSQLDatabaseDirectory):\n(WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory):\n(WebKit::WebProcessPool::legacyPlatformDefaultLocalStorageDirectory):\n(WebKit::WebProcessPool::legacyPlatformDefaultMediaKeysStorageDirectory):\n(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory): Deleted.\n(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory): Deleted.\n(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory): Deleted.\n(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory): Deleted.\n* UIProcess/efl/WebContextEfl.cpp:\n(WebKit::WebProcessPool::legacyPlatformDefaultWebSQLDatabaseDirectory):\n(WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory):\n(WebKit::WebProcessPool::legacyPlatformDefaultLocalStorageDirectory):\n(WebKit::WebProcessPool::legacyPlatformDefaultMediaKeysStorageDirectory):\n(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory): Deleted.\n(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory): Deleted.\n(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory): Deleted.\n(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory): Deleted.\n* UIProcess/gtk/WebProcessPoolGtk.cpp:\n(WebKit::WebProcessPool::legacyPlatformDefaultWebSQLDatabaseDirectory):\n(WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory):\n(WebKit::WebProcessPool::legacyPlatformDefaultLocalStorageDirectory):\n(WebKit::WebProcessPool::legacyPlatformDefaultMediaKeysStorageDirectory):\n(WebKit::WebProcessPool::platformDefaultWebSQLDatabaseDirectory): Deleted.\n(WebKit::WebProcessPool::platformDefaultIndexedDBDatabaseDirectory): Deleted.\n(WebKit::WebProcessPool::platformDefaultLocalStorageDirectory): Deleted.\n(WebKit::WebProcessPool::platformDefaultMediaKeysStorageDirectory): Deleted.\nRenamed to make it clear these were the legacy locations for these directories.\n\n* WebKit2.xcodeproj/project.pbxproj:\nAdded new files.\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178685 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/d03d8f10cd769204a1b445f5a360a41d09b53aa6"},{"sha":"04476b2f3bbeefe8d06306e6157f6048a1e88571","author":{"email":"fe09bc2ef2737a3258f978e26226dcbac1b3f948@webkit.org","name":"benjamin@webkit.org"},"message":"Remove the support for custom suffixes on ChangeLog\nhttps://bugs.webkit.org/show_bug.cgi?id=140648\n\nPatch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-19\nReviewed by David Kilzer.\n\nCustom suffixes were used for the iOS branch of WebKit.\nNow that everything is opensource, there is no need for it.\n\n* Scripts/VCSUtils.pm:\n(changeLogSuffix): Deleted.\n(changeLogFileName): Deleted.\n* Scripts/commit-log-editor:\n* Scripts/prepare-ChangeLog:\n(getLatestChangeLogs):\n(generateNewChangeLogs):\n(generateFileList):\n* Scripts/resolve-ChangeLogs:\n(findChangeLog):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178686 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/04476b2f3bbeefe8d06306e6157f6048a1e88571"},{"sha":"e872d7b4e8253492fa9166b379f66e872b6ac213","author":{"email":"40fc0cb507030a081616f25547d9cd1b104aae47@apple.com","name":"bfulgham@apple.com"},"message":"[Win] Unreviewed gardening.\n\nAvoid compiling files twice when they are included in an 'AllInOne.cpp' file.\n\n* WebCore.vcxproj/WebCore.vcxproj: Mark several files as 'not to be built', since\nthey are also build as part of an 'AllInOne.cpp' file.\n\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178687 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/e872d7b4e8253492fa9166b379f66e872b6ac213"},{"sha":"2131fabd40932f77e705420d5177d2ec50a09d37","author":{"email":"1213f304cb4206c2f96b41c3de6fca27b6572fb1@apple.com","name":"weinig@apple.com"},"message":"Sprinkle some CTTE on API::PolicyClient and API::FormClient\nhttps://bugs.webkit.org/show_bug.cgi?id=140656\n\nReviewed by Tim Horton.\n\n- Use references rather than pointers where possible.\n- Store and pass the listeners as Refs.\n- Make API::FormClient more like API::PolicyClient by making it the\n  responsibility of the client implementation to call the default policy.\n\n* UIProcess/API/APIFormClient.h:\n(API::FormClient::willSubmitForm):\n* UIProcess/API/APIPolicyClient.h:\n(API::PolicyClient::decidePolicyForNavigationAction):\n(API::PolicyClient::decidePolicyForNewWindowAction):\n(API::PolicyClient::decidePolicyForResponse):\n(API::PolicyClient::unableToImplementPolicy):\n* UIProcess/API/C/WKPage.cpp:\n(WKPageSetPagePolicyClient):\n* UIProcess/API/Cocoa/WKWebView.mm:\n(-[WKWebView _setFormDelegate:]):\n* UIProcess/API/gtk/WebKitPolicyClient.cpp:\n* UIProcess/Cocoa/NavigationState.h:\n* UIProcess/Cocoa/NavigationState.mm:\n(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):\n(WebKit::NavigationState::PolicyClient::decidePolicyForNewWindowAction):\n(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):\n* UIProcess/WebFormClient.cpp:\n(WebKit::WebFormClient::willSubmitForm):\n* UIProcess/WebFormClient.h:\n* UIProcess/WebFrameProxy.cpp:\n(WebKit::WebFrameProxy::setUpPolicyListenerProxy):\n(WebKit::WebFrameProxy::setUpFormSubmissionListenerProxy):\n* UIProcess/WebFrameProxy.h:\n* UIProcess/WebPageProxy.cpp:\n(WebKit::WebPageProxy::decidePolicyForNavigationAction):\n(WebKit::WebPageProxy::decidePolicyForNewWindowAction):\n(WebKit::WebPageProxy::decidePolicyForResponse):\n(WebKit::WebPageProxy::unableToImplementPolicy):\n(WebKit::WebPageProxy::willSubmitForm):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178688 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/2131fabd40932f77e705420d5177d2ec50a09d37"},{"sha":"42646f843aa31db9c6496418ff4a747d90d8c733","author":{"email":"a82ad16292c9f3b890b7b13c336ff95f6bd02623@webkit.org","name":"commit-queue@webkit.org"},"message":"Unreviewed, rolling out r178683.\nhttps://bugs.webkit.org/show_bug.cgi?id=140657\n\nLots of asserts in tests. (Requested by JoePeck on #webkit).\n\nReverted changeset:\n\n\"LayoutState and subtree layout code should use\nRenderElement.\"\nhttps://bugs.webkit.org/show_bug.cgi?id=126878\nhttp://trac.webkit.org/changeset/178683\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178689 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/42646f843aa31db9c6496418ff4a747d90d8c733"},{"sha":"3537f82613a40f56418d43a33850417b0189b577","author":{"email":"93c0a45b0c9f0b7ee979ac652e25f9f758cc1311@apple.com","name":"mrowe@apple.com"},"message":"<https://webkit.org/b/140504> REGRESSION (r178452): Visited link coloring only appears to work in the first web process\n\nRoll out r178452 since it broke visited link coloring.\n\nReviewed by Anders Carlsson.\n\n* UIProcess/VisitedLinkProvider.cpp:\n(WebKit::VisitedLinkProvider::~VisitedLinkProvider):\n(WebKit::VisitedLinkProvider::addProcess):\n(WebKit::VisitedLinkProvider::removeProcess):\n(WebKit::VisitedLinkProvider::removeAll):\n(WebKit::VisitedLinkProvider::webProcessWillOpenConnection):\n(WebKit::VisitedLinkProvider::webProcessDidCloseConnection):\n(WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):\n(WebKit::VisitedLinkProvider::resizeTable):\n* UIProcess/VisitedLinkProvider.h:\n* UIProcess/WebPageProxy.cpp:\n(WebKit::WebPageProxy::WebPageProxy):\n(WebKit::WebPageProxy::processDidFinishLaunching):\n* UIProcess/WebProcessProxy.cpp:\n(WebKit::WebProcessProxy::disconnect):\n(WebKit::WebProcessProxy::addVisitedLinkProvider):\n(WebKit::WebProcessProxy::didDestroyVisitedLinkProvider):\n* UIProcess/WebProcessProxy.h:\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178690 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/3537f82613a40f56418d43a33850417b0189b577"},{"sha":"2e50ba744339522be2f29fe11210ebb91e3915bf","author":{"email":"a0310c785c20c1f6bc83cd138f89eae3dbdb5804@apple.com","name":"mmaxfield@apple.com"},"message":"[SVG -> OTF Converter] Flip the switch on\nhttps://bugs.webkit.org/show_bug.cgi?id=140592\n\nSource/JavaScriptCore:\n\nReviewed by Antti Koivisto.\n\n* Configurations/FeatureDefines.xcconfig:\n\nSource/WebCore:\n\nReviewed by Antti Koivisto.\n\n* Configurations/FeatureDefines.xcconfig:\n\nSource/WebKit/mac:\n\nReviewed by Antti Koivisto.\n\n* Configurations/FeatureDefines.xcconfig:\n\nSource/WebKit2:\n\nReviewed by Antti Koivisto.\n\n* Configurations/FeatureDefines.xcconfig:\n\nLayoutTests:\n\nUpdating test expected results.\n\nsvg/W3C-SVG-1.1/fonts-glyph-04-t.svg tests something which isn't spec'ed\nand is impossible to perform with the converter, so I have deleted that\ntest.\n\nsvg/custom/skip-underline-missing-glyph-expected.html was testing\nincorrect behavior, so I have updated the test.\n\nThe getStartPositionOfChar() calls in svg/text/kerning.svg and\nsvg/text/multichar-glyph.svg are currently impossible to be implemented\ncorrectly with the converter, so I have updated the expected results to\ntest for the updated results of those calls.\n\nReviewed by Antti Koivisto.\n\n* platform/mac/TestExpectations:\n* platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png: Removed.\n* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Removed.\n* platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:\n* platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:\n* platform/mac/svg/custom/glyph-setting-d-attribute-expected.txt:\n* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:\n* platform/mac/svg/custom/svg-fonts-fallback-expected.txt:\n* platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:\n* platform/mac/svg/text/kerning-expected.txt:\n* platform/mac/svg/text/multichar-glyph-expected.txt:\n* platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:\n* platform/mac-mountainlion/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:\n* platform/mac-mountainlion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:\n* platform/mac-mountainlion/svg/custom/svg-fonts-fallback-expected.txt:\n* platform/mac-mountainlion/svg/text/kerning-expected.txt:\n* platform/mac-mountainlion/svg/text/multichar-glyph-expected.txt:\n* platform/mac-mountainlion/svg/transforms/text-with-mask-with-svg-transform-expected.txt:\n* svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Removed.\n* svg/W3C-SVG-1.1/fonts-glyph-04-t-w3c.png: Removed.\n* svg/W3C-SVG-1.1/fonts-glyph-04-t.svg: Removed.\n* svg/custom/skip-underline-missing-glyph-expected.html: Removed.\n* svg/custom/skip-underline-missing-glyph-expected.txt: Added.\n* svg/custom/skip-underline-missing-glyph.html:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@178691 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/frankolivier/webkit/commits/2e50ba744339522be2f29fe11210ebb91e3915bf"}]}