{"action":"closed","issue":{"url":"https://api.github.com/repos/Stanvk/Magister/issues/9","labels_url":"https://api.github.com/repos/Stanvk/Magister/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/Stanvk/Magister/issues/9/comments","events_url":"https://api.github.com/repos/Stanvk/Magister/issues/9/events","html_url":"https://github.com/Stanvk/Magister/issues/9","id":103843958,"number":9,"title":"[Insight] Logical operators should be avoided - in src/Magister/…/Encryption/Encrypter.php, line 122","user":{"login":"Stanvk","id":3638029,"avatar_url":"https://avatars.githubusercontent.com/u/3638029?v=3","gravatar_id":"","url":"https://api.github.com/users/Stanvk","html_url":"https://github.com/Stanvk","followers_url":"https://api.github.com/users/Stanvk/followers","following_url":"https://api.github.com/users/Stanvk/following{/other_user}","gists_url":"https://api.github.com/users/Stanvk/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanvk/subscriptions","organizations_url":"https://api.github.com/users/Stanvk/orgs","repos_url":"https://api.github.com/users/Stanvk/repos","events_url":"https://api.github.com/users/Stanvk/events{/privacy}","received_events_url":"https://api.github.com/users/Stanvk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-08-29T10:42:54Z","updated_at":"2015-09-10T08:34:11Z","closed_at":"2015-09-10T08:34:11Z","body":"**[in src/Magister/Services/Encryption/Encrypter.php, line 122](https://github.com/Stanvk/Magister/blob/45934d894f594f9674da1a1ad2c9806bf5d3ed26/src/Magister/Services/Encryption/Encrypter.php#L122)**\r\n\r\n> The `or` operator does not have the same precedence as `||`.\r\n            This could lead to unexpected behavior, use `||` instead.\r\n\r\n```php\r\n     */\r\n    protected function getJsonPayload($payload)\r\n    {\r\n        $payload = json_decode(base64_decode($payload), true);\r\n\r\n        if ( ! $payload or $this->invalidPayload($payload))\r\n        {\r\n            throw new DecryptException(\"Invalid data.\");\r\n        }\r\n\r\n        if ( ! $this->validMac($payload))\r\n```\r\n\r\n---------------------\r\n\r\n_Posted from [SensioLabsInsight](https://insight.sensiolabs.com/projects/73016b8b-9ec6-4ccd-96a2-2b7cfbd3902e/analyses/1)_"}}