{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/core-focusable/pulls/comments/26266169","id":26266169,"diff_hunk":"@@ -0,0 +1,101 @@\n+<!--\n+Copyright (c) 2015 The Polymer Project Authors. All rights reserved.\n+This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt\n+The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt\n+The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt\n+Code distributed by Google as part of the polymer project is also\n+subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt\n+-->\n+<link rel=\"import\" href=\"../polymer/polymer.html\">\n+<dom-module id=\"core-active-state\"></dom-module>\n+<script>\n+  Polymer({\n+    is: 'core-active-state',\n+\n+    properties: {\n+      active: {\n+        type: Boolean,\n+        notify: true,\n+        readOnly: true,\n+        observer: 'activeChanged',\n+        value: false\n+      },","path":"core-active-state.html","position":31,"original_position":22,"commit_id":"d553dcc3d4c7981887dd17c4bff4c90f7aa7c9c4","original_commit_id":"0270199f4b68508f6e8bb3ee03b05db8448dcdcd","user":{"login":"morethanreal","id":1202776,"avatar_url":"https://avatars.githubusercontent.com/u/1202776?v=3","gravatar_id":"","url":"https://api.github.com/users/morethanreal","html_url":"https://github.com/morethanreal","followers_url":"https://api.github.com/users/morethanreal/followers","following_url":"https://api.github.com/users/morethanreal/following{/other_user}","gists_url":"https://api.github.com/users/morethanreal/gists{/gist_id}","starred_url":"https://api.github.com/users/morethanreal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morethanreal/subscriptions","organizations_url":"https://api.github.com/users/morethanreal/orgs","repos_url":"https://api.github.com/users/morethanreal/repos","events_url":"https://api.github.com/users/morethanreal/events{/privacy}","received_events_url":"https://api.github.com/users/morethanreal/received_events","type":"User","site_admin":false},"body":"That sounds good, but the default values we choose across our elements should work well together.","created_at":"2015-03-11T23:23:25Z","updated_at":"2015-03-11T23:23:25Z","html_url":"https://github.com/Polymer/core-focusable/pull/12#discussion_r26266169","pull_request_url":"https://api.github.com/repos/Polymer/core-focusable/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/Polymer/core-focusable/pulls/comments/26266169"},"html":{"href":"https://github.com/Polymer/core-focusable/pull/12#discussion_r26266169"},"pull_request":{"href":"https://api.github.com/repos/Polymer/core-focusable/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/core-focusable/pulls/12","id":30896798,"html_url":"https://github.com/Polymer/core-focusable/pull/12","diff_url":"https://github.com/Polymer/core-focusable/pull/12.diff","patch_url":"https://github.com/Polymer/core-focusable/pull/12.patch","issue_url":"https://api.github.com/repos/Polymer/core-focusable/issues/12","number":12,"state":"open","locked":false,"title":"Port to 0.8, refactor into composable elements.","user":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"body":" - core-focusable has been refactored into three new elements\r\n - core-focused-state manages the tabindex and focused attributes\r\n - core-disabled-state manages the disabled attribute\r\n - core-active-state manages the active attribute and toggle logic\r\n - There are tests now\r\n\r\nUltimately, an element leveraging all three of these state elements might be implemented like so:\r\n\r\n```html\r\n<dom-module id=\"stateful-button\">\r\n  <template>\r\n    <core-disabled-state disabled=\"{{disabled}}\"></core-disabled-state>\r\n    <core-focused-state focused=\"{{focused}}\" disabled=\"[[disabled]]\"></core-focused-state>\r\n    <core-active-state active=\"{{active}}\" disabled=\"[[disabled]]\"></core-active-state>\r\n  </template>\r\n</dom-module>\r\n<script>\r\n  Polymer({\r\n    is: 'stateful-button'\r\n  });\r\n</script>\r\n```\r\n\r\n## Work still in progress\r\n - [ ] Respond to appropriate keyboard interactions\r\n - [ ] Automatically manage appropriate ARIA states\r\n - [ ] Emulate the `isTabStop` attribute\r\n - [ ] More tests related to above\r\n - [x] Demo","created_at":"2015-03-10T21:57:17Z","updated_at":"2015-03-11T23:23:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f9b5f87f41c55c6fbfe091763d4fab886e9b919","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/core-focusable/pulls/12/commits","review_comments_url":"https://api.github.com/repos/Polymer/core-focusable/pulls/12/comments","review_comment_url":"https://api.github.com/repos/Polymer/core-focusable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/core-focusable/issues/12/comments","statuses_url":"https://api.github.com/repos/Polymer/core-focusable/statuses/d553dcc3d4c7981887dd17c4bff4c90f7aa7c9c4","head":{"label":"Polymer:0.8-initial-port","ref":"0.8-initial-port","sha":"d553dcc3d4c7981887dd17c4bff4c90f7aa7c9c4","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":24966113,"name":"core-focusable","full_name":"Polymer/core-focusable","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/core-focusable","description":"A mixin for focusable interactive elements","fork":false,"url":"https://api.github.com/repos/Polymer/core-focusable","forks_url":"https://api.github.com/repos/Polymer/core-focusable/forks","keys_url":"https://api.github.com/repos/Polymer/core-focusable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/core-focusable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/core-focusable/teams","hooks_url":"https://api.github.com/repos/Polymer/core-focusable/hooks","issue_events_url":"https://api.github.com/repos/Polymer/core-focusable/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/core-focusable/events","assignees_url":"https://api.github.com/repos/Polymer/core-focusable/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/core-focusable/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/core-focusable/tags","blobs_url":"https://api.github.com/repos/Polymer/core-focusable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/core-focusable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/core-focusable/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/core-focusable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/core-focusable/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/core-focusable/languages","stargazers_url":"https://api.github.com/repos/Polymer/core-focusable/stargazers","contributors_url":"https://api.github.com/repos/Polymer/core-focusable/contributors","subscribers_url":"https://api.github.com/repos/Polymer/core-focusable/subscribers","subscription_url":"https://api.github.com/repos/Polymer/core-focusable/subscription","commits_url":"https://api.github.com/repos/Polymer/core-focusable/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/core-focusable/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/core-focusable/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/core-focusable/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/core-focusable/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/core-focusable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/core-focusable/merges","archive_url":"https://api.github.com/repos/Polymer/core-focusable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/core-focusable/downloads","issues_url":"https://api.github.com/repos/Polymer/core-focusable/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/core-focusable/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/core-focusable/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/core-focusable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/core-focusable/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/core-focusable/releases{/id}","created_at":"2014-10-08T23:59:24Z","updated_at":"2014-12-12T08:16:32Z","pushed_at":"2015-03-11T21:43:10Z","git_url":"git://github.com/Polymer/core-focusable.git","ssh_url":"git@github.com:Polymer/core-focusable.git","clone_url":"https://github.com/Polymer/core-focusable.git","svn_url":"https://github.com/Polymer/core-focusable","homepage":null,"size":233,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":10,"forks":4,"open_issues":10,"watchers":1,"default_branch":"master"}},"base":{"label":"Polymer:0.8-preview","ref":"0.8-preview","sha":"6a9573e3558d4dff8bff8908e55fdabc30f0af60","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":24966113,"name":"core-focusable","full_name":"Polymer/core-focusable","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/core-focusable","description":"A mixin for focusable interactive elements","fork":false,"url":"https://api.github.com/repos/Polymer/core-focusable","forks_url":"https://api.github.com/repos/Polymer/core-focusable/forks","keys_url":"https://api.github.com/repos/Polymer/core-focusable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/core-focusable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/core-focusable/teams","hooks_url":"https://api.github.com/repos/Polymer/core-focusable/hooks","issue_events_url":"https://api.github.com/repos/Polymer/core-focusable/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/core-focusable/events","assignees_url":"https://api.github.com/repos/Polymer/core-focusable/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/core-focusable/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/core-focusable/tags","blobs_url":"https://api.github.com/repos/Polymer/core-focusable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/core-focusable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/core-focusable/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/core-focusable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/core-focusable/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/core-focusable/languages","stargazers_url":"https://api.github.com/repos/Polymer/core-focusable/stargazers","contributors_url":"https://api.github.com/repos/Polymer/core-focusable/contributors","subscribers_url":"https://api.github.com/repos/Polymer/core-focusable/subscribers","subscription_url":"https://api.github.com/repos/Polymer/core-focusable/subscription","commits_url":"https://api.github.com/repos/Polymer/core-focusable/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/core-focusable/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/core-focusable/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/core-focusable/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/core-focusable/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/core-focusable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/core-focusable/merges","archive_url":"https://api.github.com/repos/Polymer/core-focusable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/core-focusable/downloads","issues_url":"https://api.github.com/repos/Polymer/core-focusable/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/core-focusable/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/core-focusable/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/core-focusable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/core-focusable/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/core-focusable/releases{/id}","created_at":"2014-10-08T23:59:24Z","updated_at":"2014-12-12T08:16:32Z","pushed_at":"2015-03-11T21:43:10Z","git_url":"git://github.com/Polymer/core-focusable.git","ssh_url":"git@github.com:Polymer/core-focusable.git","clone_url":"https://github.com/Polymer/core-focusable.git","svn_url":"https://github.com/Polymer/core-focusable","homepage":null,"size":233,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":10,"forks":4,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/core-focusable/pulls/12"},"html":{"href":"https://github.com/Polymer/core-focusable/pull/12"},"issue":{"href":"https://api.github.com/repos/Polymer/core-focusable/issues/12"},"comments":{"href":"https://api.github.com/repos/Polymer/core-focusable/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/core-focusable/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/core-focusable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/core-focusable/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/core-focusable/statuses/d553dcc3d4c7981887dd17c4bff4c90f7aa7c9c4"}}}}