{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/36594631","id":36594631,"diff_hunk":"@@ -77,7 +242,7 @@ block_operator(const std::array<std::array<LinearOperator<typename Range::BlockT\n     v.reinit(m);\n \n     // And reinitialize every individual block with reinit_range_vectors:\n-    for (unsigned int i = 0; i < m; ++i)\n+    for (size_t i = 0; i < m; ++i)","path":"include/deal.II/lac/block_linear_operator.h","position":224,"original_position":224,"commit_id":"99bbe5f4b54508b06e39a863e07e4265f05e2751","original_commit_id":"99bbe5f4b54508b06e39a863e07e4265f05e2751","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"Any reason to use not use `unsigned int`? (Isn't `size_t` also signed?)","created_at":"2015-08-09T22:35:40Z","updated_at":"2015-08-09T22:35:40Z","html_url":"https://github.com/dealii/dealii/pull/1310#discussion_r36594631","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/1310","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/36594631"},"html":{"href":"https://github.com/dealii/dealii/pull/1310#discussion_r36594631"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1310"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/1310","id":41958313,"html_url":"https://github.com/dealii/dealii/pull/1310","diff_url":"https://github.com/dealii/dealii/pull/1310.diff","patch_url":"https://github.com/dealii/dealii/pull/1310.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/1310","number":1310,"state":"open","locked":false,"title":"[WIP] BlockLinearOperator overhaul","user":{"login":"tamiko","id":3432917,"avatar_url":"https://avatars.githubusercontent.com/u/3432917?v=3","gravatar_id":"","url":"https://api.github.com/users/tamiko","html_url":"https://github.com/tamiko","followers_url":"https://api.github.com/users/tamiko/followers","following_url":"https://api.github.com/users/tamiko/following{/other_user}","gists_url":"https://api.github.com/users/tamiko/gists{/gist_id}","starred_url":"https://api.github.com/users/tamiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamiko/subscriptions","organizations_url":"https://api.github.com/users/tamiko/orgs","repos_url":"https://api.github.com/users/tamiko/repos","events_url":"https://api.github.com/users/tamiko/events{/privacy}","received_events_url":"https://api.github.com/users/tamiko/received_events","type":"User","site_admin":false},"body":"This is the first part of the (long promised) BlockLinearOperator overhaul.\r\n\r\nI opened a pull request quite early to discuss two outstanding design decisions that have to be made. (The current pull request lacks some necessary documentation and some test cases.)\r\n\r\n - The ```BlockLinearOperator``` class consists of an additional nested ```std::array``` of ```LinearOperator``` that give access to the underlying block structure. Right now, special diagonal structure is created via ```block_diagonal_operator``` that provides specialized ```std::function``` objects for the ```LinearOperator``` object (That, e.g., has an O(m) instead of O(mn) complexity for ```vmult```). We could save quite a bunch of code by just providing the general encapsulation in ```block_operator``` - but I don't know how efficient the ```null_operator``` shortcut is (Maybe it is worthwile to keep the more efficient implementation).\r\n\r\n - The ```block_forward_substitution``` and ```block_back_substitution``` functions currently do not populate ```ops``` this will be fixed.\r\n\r\n - ```BlockLinearOperator``` currently only retains the block structure as long as it is not used in an arithmetic expression, otherwise it is sliced down to a ```LinearOperator```. Shall we also implement all arithmetic expressions for ```BlockLinearOperator```? If yes something like the following would be possible:\r\n  ```\r\n  auto result = block_op_A * block_op_B;\r\n  result.ops[0][0]; // is a LinearOperator that encodes sum_j A[0][j] * B[j][0]\r\n  ```\r\n  The downside is obviously a lot more boilerplate code to write (Reimplement every ```operator``` for ```BlockLinearOperator``` as well as provide mixed operations for ```PackagedOperation```).\r\n\r\n*ping* @luca-heltai @ESeNonFossiIo Opinions?\r\n\r\n@ESeNonFossiIo - As you can see, the last variant ```block_triangular_inverse``` is now obsolete (one can now easily wrap a block matrix into a ```BlockLinearOperator``` and still access the block structure) - I have removed the function.","created_at":"2015-08-08T18:30:32Z","updated_at":"2015-08-09T22:35:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be2c8778548233cb1f190d3421a24a2b5f8123db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/1310/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/1310/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/1310/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/99bbe5f4b54508b06e39a863e07e4265f05e2751","head":{"label":"tamiko:block_linear_operator_overhaul","ref":"block_linear_operator_overhaul","sha":"99bbe5f4b54508b06e39a863e07e4265f05e2751","user":{"login":"tamiko","id":3432917,"avatar_url":"https://avatars.githubusercontent.com/u/3432917?v=3","gravatar_id":"","url":"https://api.github.com/users/tamiko","html_url":"https://github.com/tamiko","followers_url":"https://api.github.com/users/tamiko/followers","following_url":"https://api.github.com/users/tamiko/following{/other_user}","gists_url":"https://api.github.com/users/tamiko/gists{/gist_id}","starred_url":"https://api.github.com/users/tamiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamiko/subscriptions","organizations_url":"https://api.github.com/users/tamiko/orgs","repos_url":"https://api.github.com/users/tamiko/repos","events_url":"https://api.github.com/users/tamiko/events{/privacy}","received_events_url":"https://api.github.com/users/tamiko/received_events","type":"User","site_admin":false},"repo":{"id":22046756,"name":"dealii","full_name":"tamiko/dealii","owner":{"login":"tamiko","id":3432917,"avatar_url":"https://avatars.githubusercontent.com/u/3432917?v=3","gravatar_id":"","url":"https://api.github.com/users/tamiko","html_url":"https://github.com/tamiko","followers_url":"https://api.github.com/users/tamiko/followers","following_url":"https://api.github.com/users/tamiko/following{/other_user}","gists_url":"https://api.github.com/users/tamiko/gists{/gist_id}","starred_url":"https://api.github.com/users/tamiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamiko/subscriptions","organizations_url":"https://api.github.com/users/tamiko/orgs","repos_url":"https://api.github.com/users/tamiko/repos","events_url":"https://api.github.com/users/tamiko/events{/privacy}","received_events_url":"https://api.github.com/users/tamiko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamiko/dealii","description":"","fork":true,"url":"https://api.github.com/repos/tamiko/dealii","forks_url":"https://api.github.com/repos/tamiko/dealii/forks","keys_url":"https://api.github.com/repos/tamiko/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamiko/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamiko/dealii/teams","hooks_url":"https://api.github.com/repos/tamiko/dealii/hooks","issue_events_url":"https://api.github.com/repos/tamiko/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/tamiko/dealii/events","assignees_url":"https://api.github.com/repos/tamiko/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/tamiko/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/tamiko/dealii/tags","blobs_url":"https://api.github.com/repos/tamiko/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamiko/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamiko/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamiko/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamiko/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/tamiko/dealii/languages","stargazers_url":"https://api.github.com/repos/tamiko/dealii/stargazers","contributors_url":"https://api.github.com/repos/tamiko/dealii/contributors","subscribers_url":"https://api.github.com/repos/tamiko/dealii/subscribers","subscription_url":"https://api.github.com/repos/tamiko/dealii/subscription","commits_url":"https://api.github.com/repos/tamiko/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamiko/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamiko/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamiko/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamiko/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/tamiko/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamiko/dealii/merges","archive_url":"https://api.github.com/repos/tamiko/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamiko/dealii/downloads","issues_url":"https://api.github.com/repos/tamiko/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/tamiko/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/tamiko/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/tamiko/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamiko/dealii/labels{/name}","releases_url":"https://api.github.com/repos/tamiko/dealii/releases{/id}","created_at":"2014-07-21T00:21:17Z","updated_at":"2015-05-07T08:20:43Z","pushed_at":"2015-08-08T18:30:58Z","git_url":"git://github.com/tamiko/dealii.git","ssh_url":"git@github.com:tamiko/dealii.git","clone_url":"https://github.com/tamiko/dealii.git","svn_url":"https://github.com/tamiko/dealii","homepage":null,"size":122223,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"00622690b4e910293608d7cc34b1a94bae476832","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","created_at":"2014-07-17T14:00:26Z","updated_at":"2015-08-07T15:27:59Z","pushed_at":"2015-08-09T21:29:53Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":154816,"stargazers_count":77,"watchers_count":77,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":111,"forks":112,"open_issues":111,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1310"},"html":{"href":"https://github.com/dealii/dealii/pull/1310"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/1310"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/1310/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1310/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1310/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/99bbe5f4b54508b06e39a863e07e4265f05e2751"}}}}