{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments/23707709","id":23707709,"diff_hunk":"@@ -150,4 +168,35 @@ public String getHaZookeeperQuorum() {\n     return getConf().get(\"mesos.hdfs.zkfc.ha.zookeeper.quorum\", \"localhost:2181\");\n   }\n \n+  public String getStateZkServers() {\n+    return getConf().get(\"mesos.hdfs.state.zk\", \"localhost:2181\");\n+  }\n+\n+  public int getStateZkTimeout() {\n+    return getConf().getInt(\"mesos.hdfs.state.zk.timeout.ms\", 20000);\n+  }\n+\n+  public String getNativeLibrary() {\n+    return getConf().get(\"mesos.native.library\", \"/usr/local/lib/libmesos.so\");\n+  }\n+\n+  public String getFrameworkHostAddress() {\n+    String hostAddress = getConf().get(\"mesos.hdfs.framework.hostaddress\");\n+    if (hostAddress == null) {\n+      try {\n+        hostAddress = InetAddress.getLocalHost().getHostAddress();\n+      } catch (UnknownHostException e) {\n+        throw new RuntimeException(e);\n+      }\n+    }\n+    return hostAddress;\n+  }\n+\n+  public int getConfigServerPort() {\n+    String configServerPortString = System.getProperty(\"mesos.hdfs.config.server.port\");","path":"src/main/java/org/apache/mesos/hdfs/config/SchedulerConf.java","position":61,"original_position":61,"commit_id":"117c2a28b898b8f847b8a51e47fe59b3a787c3df","original_commit_id":"117c2a28b898b8f847b8a51e47fe59b3a787c3df","user":{"login":"elingg","id":8423887,"avatar_url":"https://avatars.githubusercontent.com/u/8423887?v=3","gravatar_id":"","url":"https://api.github.com/users/elingg","html_url":"https://github.com/elingg","followers_url":"https://api.github.com/users/elingg/followers","following_url":"https://api.github.com/users/elingg/following{/other_user}","gists_url":"https://api.github.com/users/elingg/gists{/gist_id}","starred_url":"https://api.github.com/users/elingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elingg/subscriptions","organizations_url":"https://api.github.com/users/elingg/orgs","repos_url":"https://api.github.com/users/elingg/repos","events_url":"https://api.github.com/users/elingg/events{/privacy}","received_events_url":"https://api.github.com/users/elingg/received_events","type":"User","site_admin":false},"body":"No need to read from System.getProperty() here. This should be part hdfs-site.xml just like all the other properties.","created_at":"2015-01-28T18:06:00Z","updated_at":"2015-01-28T18:06:00Z","html_url":"https://github.com/mesosphere/hdfs/pull/53#discussion_r23707709","pull_request_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments/23707709"},"html":{"href":"https://github.com/mesosphere/hdfs/pull/53#discussion_r23707709"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/hdfs/pulls/53","id":28147003,"html_url":"https://github.com/mesosphere/hdfs/pull/53","diff_url":"https://github.com/mesosphere/hdfs/pull/53.diff","patch_url":"https://github.com/mesosphere/hdfs/pull/53.patch","issue_url":"https://api.github.com/repos/mesosphere/hdfs/issues/53","number":53,"state":"open","locked":false,"title":"Cleanup and added some scheduler tests","user":{"login":"rubbish","id":1580,"avatar_url":"https://avatars.githubusercontent.com/u/1580?v=3","gravatar_id":"","url":"https://api.github.com/users/rubbish","html_url":"https://github.com/rubbish","followers_url":"https://api.github.com/users/rubbish/followers","following_url":"https://api.github.com/users/rubbish/following{/other_user}","gists_url":"https://api.github.com/users/rubbish/gists{/gist_id}","starred_url":"https://api.github.com/users/rubbish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubbish/subscriptions","organizations_url":"https://api.github.com/users/rubbish/orgs","repos_url":"https://api.github.com/users/rubbish/repos","events_url":"https://api.github.com/users/rubbish/events{/privacy}","received_events_url":"https://api.github.com/users/rubbish/received_events","type":"User","site_admin":false},"body":"We started work on adding tests to the scheduler for resources offers and found out we needed to cleanup the mish-mash of state and configuration. So we did that and figured it would be a good PR.","created_at":"2015-01-27T21:42:14Z","updated_at":"2015-01-28T18:06:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dbf0af39559411e3b27f7e6fa1b98717c44d546","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/53/commits","review_comments_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/53/comments","review_comment_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mesosphere/hdfs/issues/53/comments","statuses_url":"https://api.github.com/repos/mesosphere/hdfs/statuses/117c2a28b898b8f847b8a51e47fe59b3a787c3df","head":{"label":"Banno:tests-and-clean","ref":"tests-and-clean","sha":"117c2a28b898b8f847b8a51e47fe59b3a787c3df","user":{"login":"Banno","id":371161,"avatar_url":"https://avatars.githubusercontent.com/u/371161?v=3","gravatar_id":"","url":"https://api.github.com/users/Banno","html_url":"https://github.com/Banno","followers_url":"https://api.github.com/users/Banno/followers","following_url":"https://api.github.com/users/Banno/following{/other_user}","gists_url":"https://api.github.com/users/Banno/gists{/gist_id}","starred_url":"https://api.github.com/users/Banno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Banno/subscriptions","organizations_url":"https://api.github.com/users/Banno/orgs","repos_url":"https://api.github.com/users/Banno/repos","events_url":"https://api.github.com/users/Banno/events{/privacy}","received_events_url":"https://api.github.com/users/Banno/received_events","type":"Organization","site_admin":false},"repo":{"id":29147330,"name":"hdfs","full_name":"Banno/hdfs","owner":{"login":"Banno","id":371161,"avatar_url":"https://avatars.githubusercontent.com/u/371161?v=3","gravatar_id":"","url":"https://api.github.com/users/Banno","html_url":"https://github.com/Banno","followers_url":"https://api.github.com/users/Banno/followers","following_url":"https://api.github.com/users/Banno/following{/other_user}","gists_url":"https://api.github.com/users/Banno/gists{/gist_id}","starred_url":"https://api.github.com/users/Banno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Banno/subscriptions","organizations_url":"https://api.github.com/users/Banno/orgs","repos_url":"https://api.github.com/users/Banno/repos","events_url":"https://api.github.com/users/Banno/events{/privacy}","received_events_url":"https://api.github.com/users/Banno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Banno/hdfs","description":"HA HDFS on Apache Mesos  ~~~  aka 'Super Available' HDFS","fork":true,"url":"https://api.github.com/repos/Banno/hdfs","forks_url":"https://api.github.com/repos/Banno/hdfs/forks","keys_url":"https://api.github.com/repos/Banno/hdfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Banno/hdfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Banno/hdfs/teams","hooks_url":"https://api.github.com/repos/Banno/hdfs/hooks","issue_events_url":"https://api.github.com/repos/Banno/hdfs/issues/events{/number}","events_url":"https://api.github.com/repos/Banno/hdfs/events","assignees_url":"https://api.github.com/repos/Banno/hdfs/assignees{/user}","branches_url":"https://api.github.com/repos/Banno/hdfs/branches{/branch}","tags_url":"https://api.github.com/repos/Banno/hdfs/tags","blobs_url":"https://api.github.com/repos/Banno/hdfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Banno/hdfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Banno/hdfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Banno/hdfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Banno/hdfs/statuses/{sha}","languages_url":"https://api.github.com/repos/Banno/hdfs/languages","stargazers_url":"https://api.github.com/repos/Banno/hdfs/stargazers","contributors_url":"https://api.github.com/repos/Banno/hdfs/contributors","subscribers_url":"https://api.github.com/repos/Banno/hdfs/subscribers","subscription_url":"https://api.github.com/repos/Banno/hdfs/subscription","commits_url":"https://api.github.com/repos/Banno/hdfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Banno/hdfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Banno/hdfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Banno/hdfs/issues/comments/{number}","contents_url":"https://api.github.com/repos/Banno/hdfs/contents/{+path}","compare_url":"https://api.github.com/repos/Banno/hdfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Banno/hdfs/merges","archive_url":"https://api.github.com/repos/Banno/hdfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Banno/hdfs/downloads","issues_url":"https://api.github.com/repos/Banno/hdfs/issues{/number}","pulls_url":"https://api.github.com/repos/Banno/hdfs/pulls{/number}","milestones_url":"https://api.github.com/repos/Banno/hdfs/milestones{/number}","notifications_url":"https://api.github.com/repos/Banno/hdfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Banno/hdfs/labels{/name}","releases_url":"https://api.github.com/repos/Banno/hdfs/releases{/id}","created_at":"2015-01-12T17:26:37Z","updated_at":"2015-01-28T15:24:52Z","pushed_at":"2015-01-28T15:24:51Z","git_url":"git://github.com/Banno/hdfs.git","ssh_url":"git@github.com:Banno/hdfs.git","clone_url":"https://github.com/Banno/hdfs.git","svn_url":"https://github.com/Banno/hdfs","homepage":"","size":298,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"9a18b9fd52a06774c9e47a93e8a91844a3e98d44","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":25594400,"name":"hdfs","full_name":"mesosphere/hdfs","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/hdfs","description":"HA HDFS on Apache Mesos  ~~~  aka 'Super Available' HDFS","fork":true,"url":"https://api.github.com/repos/mesosphere/hdfs","forks_url":"https://api.github.com/repos/mesosphere/hdfs/forks","keys_url":"https://api.github.com/repos/mesosphere/hdfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/hdfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/hdfs/teams","hooks_url":"https://api.github.com/repos/mesosphere/hdfs/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/hdfs/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/hdfs/events","assignees_url":"https://api.github.com/repos/mesosphere/hdfs/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/hdfs/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/hdfs/tags","blobs_url":"https://api.github.com/repos/mesosphere/hdfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/hdfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/hdfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/hdfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/hdfs/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/hdfs/languages","stargazers_url":"https://api.github.com/repos/mesosphere/hdfs/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/hdfs/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/hdfs/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/hdfs/subscription","commits_url":"https://api.github.com/repos/mesosphere/hdfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/hdfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/hdfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/hdfs/issues/comments/{number}","contents_url":"https://api.github.com/repos/mesosphere/hdfs/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/hdfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/hdfs/merges","archive_url":"https://api.github.com/repos/mesosphere/hdfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/hdfs/downloads","issues_url":"https://api.github.com/repos/mesosphere/hdfs/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/hdfs/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/hdfs/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/hdfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/hdfs/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/hdfs/releases{/id}","created_at":"2014-10-22T17:21:52Z","updated_at":"2015-01-28T01:34:33Z","pushed_at":"2015-01-28T01:34:33Z","git_url":"git://github.com/mesosphere/hdfs.git","ssh_url":"git@github.com:mesosphere/hdfs.git","clone_url":"https://github.com/mesosphere/hdfs.git","svn_url":"https://github.com/mesosphere/hdfs","homepage":"","size":678,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":25,"forks":3,"open_issues":25,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/53"},"html":{"href":"https://github.com/mesosphere/hdfs/pull/53"},"issue":{"href":"https://api.github.com/repos/mesosphere/hdfs/issues/53"},"comments":{"href":"https://api.github.com/repos/mesosphere/hdfs/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/hdfs/statuses/117c2a28b898b8f847b8a51e47fe59b3a787c3df"}}}}