{"action":"created","comment":{"url":"https://api.github.com/repos/allegro/hermes/pulls/comments/38395793","id":38395793,"diff_hunk":"@@ -35,7 +38,12 @@ public void check(byte[] message, Topic topic) {\n         List<String> errors = validate(schemaRepository.getSchema(topic), message);\n \n         if (!errors.isEmpty()) {\n-            throw new InvalidMessageException(\"Message incompatible with JSON schema\", errors);\n+            if (topic.isValidationDryRunEnabled()) {\n+                logger.info(\"Message incompatible with JSON schema for topic {}, errors: {}, message body: {}\",\n+                        topic.getQualifiedName(), Joiner.on(\";\").join(errors), new String(message, UTF_8));","path":"hermes-frontend/src/main/java/pl/allegro/tech/hermes/frontend/validator/JsonTopicMessageValidator.java","position":31,"original_position":31,"commit_id":"f24cf4df425e882b42ea16e854f9c263112b8f4e","original_commit_id":"f24cf4df425e882b42ea16e854f9c263112b8f4e","user":{"login":"wojtkiewicz","id":11539876,"avatar_url":"https://avatars.githubusercontent.com/u/11539876?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtkiewicz","html_url":"https://github.com/wojtkiewicz","followers_url":"https://api.github.com/users/wojtkiewicz/followers","following_url":"https://api.github.com/users/wojtkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/wojtkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtkiewicz/subscriptions","organizations_url":"https://api.github.com/users/wojtkiewicz/orgs","repos_url":"https://api.github.com/users/wojtkiewicz/repos","events_url":"https://api.github.com/users/wojtkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/wojtkiewicz/received_events","type":"User","site_admin":false},"body":"To jest dobry pomysł żeby wrzucać do kibany całe message body?","created_at":"2015-09-01T08:26:35Z","updated_at":"2015-09-01T08:26:35Z","html_url":"https://github.com/allegro/hermes/pull/201#discussion_r38395793","pull_request_url":"https://api.github.com/repos/allegro/hermes/pulls/201","_links":{"self":{"href":"https://api.github.com/repos/allegro/hermes/pulls/comments/38395793"},"html":{"href":"https://github.com/allegro/hermes/pull/201#discussion_r38395793"},"pull_request":{"href":"https://api.github.com/repos/allegro/hermes/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/allegro/hermes/pulls/201","id":43740495,"html_url":"https://github.com/allegro/hermes/pull/201","diff_url":"https://github.com/allegro/hermes/pull/201.diff","patch_url":"https://github.com/allegro/hermes/pull/201.patch","issue_url":"https://api.github.com/repos/allegro/hermes/issues/201","number":201,"state":"open","locked":false,"title":"Validation dry-run mode for JSON topics.","user":{"login":"dankraw","id":2399036,"avatar_url":"https://avatars.githubusercontent.com/u/2399036?v=3","gravatar_id":"","url":"https://api.github.com/users/dankraw","html_url":"https://github.com/dankraw","followers_url":"https://api.github.com/users/dankraw/followers","following_url":"https://api.github.com/users/dankraw/following{/other_user}","gists_url":"https://api.github.com/users/dankraw/gists{/gist_id}","starred_url":"https://api.github.com/users/dankraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankraw/subscriptions","organizations_url":"https://api.github.com/users/dankraw/orgs","repos_url":"https://api.github.com/users/dankraw/repos","events_url":"https://api.github.com/users/dankraw/events{/privacy}","received_events_url":"https://api.github.com/users/dankraw/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-31T08:00:45Z","updated_at":"2015-09-01T08:26:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3ca147f251fd71b523548921c6f74ebd62fd54e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/allegro/hermes/pulls/201/commits","review_comments_url":"https://api.github.com/repos/allegro/hermes/pulls/201/comments","review_comment_url":"https://api.github.com/repos/allegro/hermes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allegro/hermes/issues/201/comments","statuses_url":"https://api.github.com/repos/allegro/hermes/statuses/f24cf4df425e882b42ea16e854f9c263112b8f4e","head":{"label":"allegro:message_validation_dry_run","ref":"message_validation_dry_run","sha":"f24cf4df425e882b42ea16e854f9c263112b8f4e","user":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"repo":{"id":35662043,"name":"hermes","full_name":"allegro/hermes","owner":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allegro/hermes","description":"Fast and reliable message broker built on top of Kafka.","fork":false,"url":"https://api.github.com/repos/allegro/hermes","forks_url":"https://api.github.com/repos/allegro/hermes/forks","keys_url":"https://api.github.com/repos/allegro/hermes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allegro/hermes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allegro/hermes/teams","hooks_url":"https://api.github.com/repos/allegro/hermes/hooks","issue_events_url":"https://api.github.com/repos/allegro/hermes/issues/events{/number}","events_url":"https://api.github.com/repos/allegro/hermes/events","assignees_url":"https://api.github.com/repos/allegro/hermes/assignees{/user}","branches_url":"https://api.github.com/repos/allegro/hermes/branches{/branch}","tags_url":"https://api.github.com/repos/allegro/hermes/tags","blobs_url":"https://api.github.com/repos/allegro/hermes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allegro/hermes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allegro/hermes/git/refs{/sha}","trees_url":"https://api.github.com/repos/allegro/hermes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allegro/hermes/statuses/{sha}","languages_url":"https://api.github.com/repos/allegro/hermes/languages","stargazers_url":"https://api.github.com/repos/allegro/hermes/stargazers","contributors_url":"https://api.github.com/repos/allegro/hermes/contributors","subscribers_url":"https://api.github.com/repos/allegro/hermes/subscribers","subscription_url":"https://api.github.com/repos/allegro/hermes/subscription","commits_url":"https://api.github.com/repos/allegro/hermes/commits{/sha}","git_commits_url":"https://api.github.com/repos/allegro/hermes/git/commits{/sha}","comments_url":"https://api.github.com/repos/allegro/hermes/comments{/number}","issue_comment_url":"https://api.github.com/repos/allegro/hermes/issues/comments{/number}","contents_url":"https://api.github.com/repos/allegro/hermes/contents/{+path}","compare_url":"https://api.github.com/repos/allegro/hermes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allegro/hermes/merges","archive_url":"https://api.github.com/repos/allegro/hermes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allegro/hermes/downloads","issues_url":"https://api.github.com/repos/allegro/hermes/issues{/number}","pulls_url":"https://api.github.com/repos/allegro/hermes/pulls{/number}","milestones_url":"https://api.github.com/repos/allegro/hermes/milestones{/number}","notifications_url":"https://api.github.com/repos/allegro/hermes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allegro/hermes/labels{/name}","releases_url":"https://api.github.com/repos/allegro/hermes/releases{/id}","created_at":"2015-05-15T08:11:16Z","updated_at":"2015-08-19T16:02:29Z","pushed_at":"2015-08-31T11:04:40Z","git_url":"git://github.com/allegro/hermes.git","ssh_url":"git@github.com:allegro/hermes.git","clone_url":"https://github.com/allegro/hermes.git","svn_url":"https://github.com/allegro/hermes","homepage":"http://hermes.allegro.tech","size":3331,"stargazers_count":120,"watchers_count":120,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":22,"forks":15,"open_issues":22,"watchers":120,"default_branch":"master"}},"base":{"label":"allegro:rc","ref":"rc","sha":"1ece834839a3ea3e4bd4452aa48e5f7d5fc50355","user":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"repo":{"id":35662043,"name":"hermes","full_name":"allegro/hermes","owner":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allegro/hermes","description":"Fast and reliable message broker built on top of Kafka.","fork":false,"url":"https://api.github.com/repos/allegro/hermes","forks_url":"https://api.github.com/repos/allegro/hermes/forks","keys_url":"https://api.github.com/repos/allegro/hermes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allegro/hermes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allegro/hermes/teams","hooks_url":"https://api.github.com/repos/allegro/hermes/hooks","issue_events_url":"https://api.github.com/repos/allegro/hermes/issues/events{/number}","events_url":"https://api.github.com/repos/allegro/hermes/events","assignees_url":"https://api.github.com/repos/allegro/hermes/assignees{/user}","branches_url":"https://api.github.com/repos/allegro/hermes/branches{/branch}","tags_url":"https://api.github.com/repos/allegro/hermes/tags","blobs_url":"https://api.github.com/repos/allegro/hermes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allegro/hermes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allegro/hermes/git/refs{/sha}","trees_url":"https://api.github.com/repos/allegro/hermes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allegro/hermes/statuses/{sha}","languages_url":"https://api.github.com/repos/allegro/hermes/languages","stargazers_url":"https://api.github.com/repos/allegro/hermes/stargazers","contributors_url":"https://api.github.com/repos/allegro/hermes/contributors","subscribers_url":"https://api.github.com/repos/allegro/hermes/subscribers","subscription_url":"https://api.github.com/repos/allegro/hermes/subscription","commits_url":"https://api.github.com/repos/allegro/hermes/commits{/sha}","git_commits_url":"https://api.github.com/repos/allegro/hermes/git/commits{/sha}","comments_url":"https://api.github.com/repos/allegro/hermes/comments{/number}","issue_comment_url":"https://api.github.com/repos/allegro/hermes/issues/comments{/number}","contents_url":"https://api.github.com/repos/allegro/hermes/contents/{+path}","compare_url":"https://api.github.com/repos/allegro/hermes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allegro/hermes/merges","archive_url":"https://api.github.com/repos/allegro/hermes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allegro/hermes/downloads","issues_url":"https://api.github.com/repos/allegro/hermes/issues{/number}","pulls_url":"https://api.github.com/repos/allegro/hermes/pulls{/number}","milestones_url":"https://api.github.com/repos/allegro/hermes/milestones{/number}","notifications_url":"https://api.github.com/repos/allegro/hermes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allegro/hermes/labels{/name}","releases_url":"https://api.github.com/repos/allegro/hermes/releases{/id}","created_at":"2015-05-15T08:11:16Z","updated_at":"2015-08-19T16:02:29Z","pushed_at":"2015-08-31T11:04:40Z","git_url":"git://github.com/allegro/hermes.git","ssh_url":"git@github.com:allegro/hermes.git","clone_url":"https://github.com/allegro/hermes.git","svn_url":"https://github.com/allegro/hermes","homepage":"http://hermes.allegro.tech","size":3331,"stargazers_count":120,"watchers_count":120,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":22,"forks":15,"open_issues":22,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allegro/hermes/pulls/201"},"html":{"href":"https://github.com/allegro/hermes/pull/201"},"issue":{"href":"https://api.github.com/repos/allegro/hermes/issues/201"},"comments":{"href":"https://api.github.com/repos/allegro/hermes/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/allegro/hermes/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/allegro/hermes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allegro/hermes/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/allegro/hermes/statuses/f24cf4df425e882b42ea16e854f9c263112b8f4e"}}}}