{"action":"created","issue":{"url":"https://api.github.com/repos/gollum/gollum/issues/917","labels_url":"https://api.github.com/repos/gollum/gollum/issues/917/labels{/name}","comments_url":"https://api.github.com/repos/gollum/gollum/issues/917/comments","events_url":"https://api.github.com/repos/gollum/gollum/issues/917/events","html_url":"https://github.com/gollum/gollum/issues/917","id":51219284,"number":917,"title":"Upcoming CSS changes","user":{"login":"SkyCrawl","id":6152937,"avatar_url":"https://avatars.githubusercontent.com/u/6152937?v=3","gravatar_id":"","url":"https://api.github.com/users/SkyCrawl","html_url":"https://github.com/SkyCrawl","followers_url":"https://api.github.com/users/SkyCrawl/followers","following_url":"https://api.github.com/users/SkyCrawl/following{/other_user}","gists_url":"https://api.github.com/users/SkyCrawl/gists{/gist_id}","starred_url":"https://api.github.com/users/SkyCrawl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkyCrawl/subscriptions","organizations_url":"https://api.github.com/users/SkyCrawl/orgs","repos_url":"https://api.github.com/users/SkyCrawl/repos","events_url":"https://api.github.com/users/SkyCrawl/events{/privacy}","received_events_url":"https://api.github.com/users/SkyCrawl/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gollum/gollum/labels/CSS%20styling","name":"CSS styling","color":"eb6420"},{"url":"https://api.github.com/repos/gollum/gollum/labels/improvement","name":"improvement","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/gollum/gollum/milestones/8","html_url":"https://github.com/gollum/gollum/milestones/3.2","labels_url":"https://api.github.com/repos/gollum/gollum/milestones/8/labels","id":866538,"number":8,"title":"3.2","description":"","creator":{"login":"bartkamphorst","id":571173,"avatar_url":"https://avatars.githubusercontent.com/u/571173?v=3","gravatar_id":"","url":"https://api.github.com/users/bartkamphorst","html_url":"https://github.com/bartkamphorst","followers_url":"https://api.github.com/users/bartkamphorst/followers","following_url":"https://api.github.com/users/bartkamphorst/following{/other_user}","gists_url":"https://api.github.com/users/bartkamphorst/gists{/gist_id}","starred_url":"https://api.github.com/users/bartkamphorst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartkamphorst/subscriptions","organizations_url":"https://api.github.com/users/bartkamphorst/orgs","repos_url":"https://api.github.com/users/bartkamphorst/repos","events_url":"https://api.github.com/users/bartkamphorst/events{/privacy}","received_events_url":"https://api.github.com/users/bartkamphorst/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":4,"state":"open","created_at":"2014-11-14T12:54:48Z","updated_at":"2015-01-31T13:30:06Z","due_on":null,"closed_at":null},"comments":32,"created_at":"2014-12-07T14:25:59Z","updated_at":"2015-03-15T20:53:22Z","closed_at":null,"body":"Issue in accordance with:  #906 , #908, #909, #910 \r\n\r\n@sunny @dometto @bartkamphorst \r\n\r\nI've had a look at Gollum's styles and it's a **much** larger and more complex system than I thought it would be. From my humble point of view, it's way too large and complex (for the more or less simple infrastructure and looks of Gollum's pages) and stands on the edge of being impossible to maintain. Newcomers like me can only stare from afar :p.\r\nThis could **definitely** use a **lot of** help from SASS :). It would probably take a major amount of work to rewrite all the styles into SASS and get it all working again but every second would count greatly towards dev-experience and future maintenance. On top of that, any potential templating would become light-years easier. Inspiration may be taken from:\r\n* [Vaadin's article on SASS](https://vaadin.com/book/vaadin7/-/page/themes.sass.html)\r\n* [Theming with SASS](http://morevaadin.com/content/easy-theming-with-valo/)\r\n* [Example of two 10-minute themes using a nice SASS theming engine](http://jaxenter.com/why-youll-want-to-check-out-vaadin-7-3s-new-valo-theme-engine-108048.html)\r\n* [Ruby SASS - compile all SAS files into a single CSS to be included in pages](https://www.npmjs.org/package/gulp-ruby-sass)\r\n\r\nWhile I can incorporate the changes in `template.css` and `print.css` in this particular case, I have no idea whether that's actually OK with the rest of the styles and honestly, don't really want to be finding out... That's as far as my contributions in this regard will go, unless we (or me, possibly) \"sit down\" to rewrite all this first :).\r\nSome changes had, in my opinion, best be accompanied by mustache template changes:\r\n* Page title should only duplicate `<h1>`'s styles and another tag be used for it. This is so that `<h1>` may be used in pages themselves and header numbering will not take any interference from the page title. Unless, of course, the associated \"trigger\" style name would be pushed further in the DOM (not `<body>`) so as not to encompass the page title.\r\n* While applying `position: absolute;` to menu actions should not be problematic, I think that with regard to the look we want to achieve, page title tag should follow (not precede) the action menu.\r\n* If header numbering is used and table of contents displayed on a page, they should be in sync (currently, table of contents is not being numbered). CSS-wise, there shouldn't be much of a problem but can it be easily handled from your end?"},"comment":{"url":"https://api.github.com/repos/gollum/gollum/issues/comments/81235389","html_url":"https://github.com/gollum/gollum/issues/917#issuecomment-81235389","issue_url":"https://api.github.com/repos/gollum/gollum/issues/917","id":81235389,"user":{"login":"SkyCrawl","id":6152937,"avatar_url":"https://avatars.githubusercontent.com/u/6152937?v=3","gravatar_id":"","url":"https://api.github.com/users/SkyCrawl","html_url":"https://github.com/SkyCrawl","followers_url":"https://api.github.com/users/SkyCrawl/followers","following_url":"https://api.github.com/users/SkyCrawl/following{/other_user}","gists_url":"https://api.github.com/users/SkyCrawl/gists{/gist_id}","starred_url":"https://api.github.com/users/SkyCrawl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkyCrawl/subscriptions","organizations_url":"https://api.github.com/users/SkyCrawl/orgs","repos_url":"https://api.github.com/users/SkyCrawl/repos","events_url":"https://api.github.com/users/SkyCrawl/events{/privacy}","received_events_url":"https://api.github.com/users/SkyCrawl/received_events","type":"User","site_admin":false},"created_at":"2015-03-15T20:53:22Z","updated_at":"2015-03-15T20:53:22Z","body":"@dometto @bartkamphorst @sunny \r\nHow is it with thread-safety in Gollum? Does the current chain of `WEBRick<->Rack<->Sinatra` use threads to serve incoming requests? Is the `Gollum::Wiki` object thread-safe?"}}