{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/33283549","id":33283549,"diff_hunk":"@@ -259,7 +259,7 @@ Op Example\n \n         def make_node(self, x):\n             # check that the theano version has support for __props__\n-            assert hasattr(self, '_props')\n+            assert hasattr(self, '__props__')","path":"doc/tutorial/extending_theano.txt","position":5,"original_position":5,"commit_id":"3c19fc3e215f1803b5d3a628c3f05cfed8558ed2","original_commit_id":"6eb6f6e8eb6122056cc73bba22f714669e926ab9","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"@carriepl what do you think? I think we should keep the old one. The goal is to know if the Theano version is recent enough. Using self.__props__ won't do that, as the Op will have it implemented.","created_at":"2015-06-25T17:48:58Z","updated_at":"2015-06-25T17:48:58Z","html_url":"https://github.com/Theano/Theano/pull/3061#discussion_r33283549","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/3061","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/33283549"},"html":{"href":"https://github.com/Theano/Theano/pull/3061#discussion_r33283549"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/3061"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/3061","id":38367785,"html_url":"https://github.com/Theano/Theano/pull/3061","diff_url":"https://github.com/Theano/Theano/pull/3061.diff","patch_url":"https://github.com/Theano/Theano/pull/3061.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/3061","number":3061,"state":"open","locked":false,"title":"adding documentation for __props__","user":{"login":"gyom","id":192976,"avatar_url":"https://avatars.githubusercontent.com/u/192976?v=3","gravatar_id":"","url":"https://api.github.com/users/gyom","html_url":"https://github.com/gyom","followers_url":"https://api.github.com/users/gyom/followers","following_url":"https://api.github.com/users/gyom/following{/other_user}","gists_url":"https://api.github.com/users/gyom/gists{/gist_id}","starred_url":"https://api.github.com/users/gyom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyom/subscriptions","organizations_url":"https://api.github.com/users/gyom/orgs","repos_url":"https://api.github.com/users/gyom/repos","events_url":"https://api.github.com/users/gyom/events{/privacy}","received_events_url":"https://api.github.com/users/gyom/received_events","type":"User","site_admin":false},"body":"Fixed an error in the existing doc.\r\n\r\nAdded an example for __props__ where an Op is created and it has two properties to be compared.","created_at":"2015-06-23T18:30:24Z","updated_at":"2015-06-25T17:48:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7813fc935ea14882b9e2eb0801a7b2ac0a694285","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/3061/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/3061/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/3061/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/3c19fc3e215f1803b5d3a628c3f05cfed8558ed2","head":{"label":"gyom:master","ref":"master","sha":"3c19fc3e215f1803b5d3a628c3f05cfed8558ed2","user":{"login":"gyom","id":192976,"avatar_url":"https://avatars.githubusercontent.com/u/192976?v=3","gravatar_id":"","url":"https://api.github.com/users/gyom","html_url":"https://github.com/gyom","followers_url":"https://api.github.com/users/gyom/followers","following_url":"https://api.github.com/users/gyom/following{/other_user}","gists_url":"https://api.github.com/users/gyom/gists{/gist_id}","starred_url":"https://api.github.com/users/gyom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyom/subscriptions","organizations_url":"https://api.github.com/users/gyom/orgs","repos_url":"https://api.github.com/users/gyom/repos","events_url":"https://api.github.com/users/gyom/events{/privacy}","received_events_url":"https://api.github.com/users/gyom/received_events","type":"User","site_admin":false},"repo":{"id":37936481,"name":"Theano","full_name":"gyom/Theano","owner":{"login":"gyom","id":192976,"avatar_url":"https://avatars.githubusercontent.com/u/192976?v=3","gravatar_id":"","url":"https://api.github.com/users/gyom","html_url":"https://github.com/gyom","followers_url":"https://api.github.com/users/gyom/followers","following_url":"https://api.github.com/users/gyom/following{/other_user}","gists_url":"https://api.github.com/users/gyom/gists{/gist_id}","starred_url":"https://api.github.com/users/gyom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyom/subscriptions","organizations_url":"https://api.github.com/users/gyom/orgs","repos_url":"https://api.github.com/users/gyom/repos","events_url":"https://api.github.com/users/gyom/events{/privacy}","received_events_url":"https://api.github.com/users/gyom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gyom/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/gyom/Theano","forks_url":"https://api.github.com/repos/gyom/Theano/forks","keys_url":"https://api.github.com/repos/gyom/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gyom/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gyom/Theano/teams","hooks_url":"https://api.github.com/repos/gyom/Theano/hooks","issue_events_url":"https://api.github.com/repos/gyom/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/gyom/Theano/events","assignees_url":"https://api.github.com/repos/gyom/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/gyom/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/gyom/Theano/tags","blobs_url":"https://api.github.com/repos/gyom/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gyom/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gyom/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/gyom/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gyom/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/gyom/Theano/languages","stargazers_url":"https://api.github.com/repos/gyom/Theano/stargazers","contributors_url":"https://api.github.com/repos/gyom/Theano/contributors","subscribers_url":"https://api.github.com/repos/gyom/Theano/subscribers","subscription_url":"https://api.github.com/repos/gyom/Theano/subscription","commits_url":"https://api.github.com/repos/gyom/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/gyom/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/gyom/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/gyom/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/gyom/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/gyom/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gyom/Theano/merges","archive_url":"https://api.github.com/repos/gyom/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gyom/Theano/downloads","issues_url":"https://api.github.com/repos/gyom/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/gyom/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/gyom/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/gyom/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gyom/Theano/labels{/name}","releases_url":"https://api.github.com/repos/gyom/Theano/releases{/id}","created_at":"2015-06-23T18:17:17Z","updated_at":"2015-06-23T18:17:19Z","pushed_at":"2015-06-25T17:42:22Z","git_url":"git://github.com/gyom/Theano.git","ssh_url":"git@github.com:gyom/Theano.git","clone_url":"https://github.com/gyom/Theano.git","svn_url":"https://github.com/gyom/Theano","homepage":"http://www.deeplearning.net/software/theano","size":35254,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"131ea96a8146330518a350e050a062b922b30470","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","created_at":"2011-08-10T03:48:06Z","updated_at":"2015-06-25T09:10:50Z","pushed_at":"2015-06-25T17:42:23Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":53805,"stargazers_count":1657,"watchers_count":1657,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":601,"mirror_url":null,"open_issues_count":403,"forks":601,"open_issues":403,"watchers":1657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/3061"},"html":{"href":"https://github.com/Theano/Theano/pull/3061"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/3061"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/3061/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/3061/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/3061/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/3c19fc3e215f1803b5d3a628c3f05cfed8558ed2"}}}}