{"action":"created","issue":{"url":"https://api.github.com/repos/kbandla/dpkt/issues/214","labels_url":"https://api.github.com/repos/kbandla/dpkt/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/kbandla/dpkt/issues/214/comments","events_url":"https://api.github.com/repos/kbandla/dpkt/issues/214/events","html_url":"https://github.com/kbandla/dpkt/pull/214","id":101328561,"number":214,"title":"Add dns.unpack_name improvements and related tests.","user":{"login":"sunhao2014","id":5916357,"avatar_url":"https://avatars.githubusercontent.com/u/5916357?v=3","gravatar_id":"","url":"https://api.github.com/users/sunhao2014","html_url":"https://github.com/sunhao2014","followers_url":"https://api.github.com/users/sunhao2014/followers","following_url":"https://api.github.com/users/sunhao2014/following{/other_user}","gists_url":"https://api.github.com/users/sunhao2014/gists{/gist_id}","starred_url":"https://api.github.com/users/sunhao2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunhao2014/subscriptions","organizations_url":"https://api.github.com/users/sunhao2014/orgs","repos_url":"https://api.github.com/users/sunhao2014/repos","events_url":"https://api.github.com/users/sunhao2014/events{/privacy}","received_events_url":"https://api.github.com/users/sunhao2014/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kbandla/dpkt/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-17T02:58:18Z","updated_at":"2015-11-30T09:54:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kbandla/dpkt/pulls/214","html_url":"https://github.com/kbandla/dpkt/pull/214","diff_url":"https://github.com/kbandla/dpkt/pull/214.diff","patch_url":"https://github.com/kbandla/dpkt/pull/214.patch"},"body":"This update is totally based on the patch of #146. There are three improvements for `dns.py`.\r\n\r\n1. Changes the `unpack_name` from recursive to iterative when there are `ptr`s in the `name` field.\r\n1. Detects pointer loops as soon as possible and raises `UnpackError`.\r\n1. Uses `'.'.join()` to build the return value instead of repeatedly appending to a string to improve the performance.\r\n\r\nI checked the logic and run the updated code, it seems good. Also it could pass all tests in `dns.py` module."},"comment":{"url":"https://api.github.com/repos/kbandla/dpkt/issues/comments/160580463","html_url":"https://github.com/kbandla/dpkt/pull/214#issuecomment-160580463","issue_url":"https://api.github.com/repos/kbandla/dpkt/issues/214","id":160580463,"user":{"login":"sunhao2014","id":5916357,"avatar_url":"https://avatars.githubusercontent.com/u/5916357?v=3","gravatar_id":"","url":"https://api.github.com/users/sunhao2014","html_url":"https://github.com/sunhao2014","followers_url":"https://api.github.com/users/sunhao2014/followers","following_url":"https://api.github.com/users/sunhao2014/following{/other_user}","gists_url":"https://api.github.com/users/sunhao2014/gists{/gist_id}","starred_url":"https://api.github.com/users/sunhao2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunhao2014/subscriptions","organizations_url":"https://api.github.com/users/sunhao2014/orgs","repos_url":"https://api.github.com/users/sunhao2014/repos","events_url":"https://api.github.com/users/sunhao2014/events{/privacy}","received_events_url":"https://api.github.com/users/sunhao2014/received_events","type":"User","site_admin":false},"created_at":"2015-11-30T09:54:34Z","updated_at":"2015-11-30T09:54:34Z","body":"@brifordwylie, the `continuous-integration/travis-ci/push` build failed, however I'm not sure why. Related log is as follows.\r\n`You have to provide either repo_token in .coveralls.yml, or launch via Travis or CircleCI\r\nERROR: InvocationError: '/home/travis/build/kbandla/dpkt/.tox/coveralls/bin/coveralls'`\r\nCould you please take a look at this issue?"}}