{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/25027989","id":25027989,"diff_hunk":"@@ -36,94 +36,42 @@ def self.configure(_namespace, options = {})\n   end\n \n   def self.gen_token(namespace, token_options = {})\n-    token_cleanup\n-    token = SecureRandom.hex(16)\n-\n     ts = global_token_store(namespace)\n-    ts[token] = {:expires_on => Time.now.tv_sec + @config[:token_ttl]}\n-    ts[token].merge!(prune_token_options(namespace, token, token_options))\n+    token = SecureRandom.hex(16)\n+    token_data = {:expires_on => Time.now.tv_sec + @config[:token_ttl]}","path":"vmdb/lib/token_manager.rb","position":54,"original_position":54,"commit_id":"8981b09369d7affb7831633e2e56355935a69e53","original_commit_id":"8981b09369d7affb7831633e2e56355935a69e53","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"You can probably just store time objects so as not to make this confusing (though I know you had tv_sec before).","created_at":"2015-02-19T21:35:54Z","updated_at":"2015-02-19T21:35:54Z","html_url":"https://github.com/ManageIQ/manageiq/pull/1801#discussion_r25027989","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1801","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/25027989"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1801#discussion_r25027989"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1801"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1801","id":29648121,"html_url":"https://github.com/ManageIQ/manageiq/pull/1801","diff_url":"https://github.com/ManageIQ/manageiq/pull/1801.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1801.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1801","number":1801,"state":"open","locked":false,"title":"[api] Enhancements to the Token Manager","user":{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false},"body":"- Leveraging Memcached to make sure tokens work across workers\r\n- Using Dalli::Client's interface and token cleanup support.\r\n- Removing Token Manager token cleanup code\r\n- Removing api token_cleanup_interval configuration\r\n- Rubocop changes\r\n\r\nhttps://trello.com/c/Drza2h1q","created_at":"2015-02-19T20:56:50Z","updated_at":"2015-02-19T21:35:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce20a2e5a478f642782cb9b835d1744b29260604","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1801/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1801/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1801/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/8981b09369d7affb7831633e2e56355935a69e53","head":{"label":"abellotti:rest_api_token_manager","ref":"rest_api_token_manager","sha":"8981b09369d7affb7831633e2e56355935a69e53","user":{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false},"repo":{"id":20813598,"name":"manageiq","full_name":"abellotti/manageiq","owner":{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abellotti/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/abellotti/manageiq","forks_url":"https://api.github.com/repos/abellotti/manageiq/forks","keys_url":"https://api.github.com/repos/abellotti/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abellotti/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abellotti/manageiq/teams","hooks_url":"https://api.github.com/repos/abellotti/manageiq/hooks","issue_events_url":"https://api.github.com/repos/abellotti/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/abellotti/manageiq/events","assignees_url":"https://api.github.com/repos/abellotti/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/abellotti/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/abellotti/manageiq/tags","blobs_url":"https://api.github.com/repos/abellotti/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abellotti/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abellotti/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/abellotti/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abellotti/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/abellotti/manageiq/languages","stargazers_url":"https://api.github.com/repos/abellotti/manageiq/stargazers","contributors_url":"https://api.github.com/repos/abellotti/manageiq/contributors","subscribers_url":"https://api.github.com/repos/abellotti/manageiq/subscribers","subscription_url":"https://api.github.com/repos/abellotti/manageiq/subscription","commits_url":"https://api.github.com/repos/abellotti/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/abellotti/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/abellotti/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/abellotti/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/abellotti/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/abellotti/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abellotti/manageiq/merges","archive_url":"https://api.github.com/repos/abellotti/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abellotti/manageiq/downloads","issues_url":"https://api.github.com/repos/abellotti/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/abellotti/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/abellotti/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/abellotti/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abellotti/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/abellotti/manageiq/releases{/id}","created_at":"2014-06-13T18:22:42Z","updated_at":"2014-06-17T20:58:44Z","pushed_at":"2015-02-19T21:10:14Z","git_url":"git://github.com/abellotti/manageiq.git","ssh_url":"git@github.com:abellotti/manageiq.git","clone_url":"https://github.com/abellotti/manageiq.git","svn_url":"https://github.com/abellotti/manageiq","homepage":null,"size":63868,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"2df61a8670199ce9851a810c3c034ea38304a7c2","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-02-19T18:53:27Z","pushed_at":"2015-02-19T18:53:26Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":97740,"stargazers_count":88,"watchers_count":88,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":263,"forks":87,"open_issues":263,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1801"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1801"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1801"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1801/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1801/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1801/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/8981b09369d7affb7831633e2e56355935a69e53"}}}}