{"action":"created","comment":{"url":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments/35531446","id":35531446,"diff_hunk":"@@ -66,6 +70,21 @@\n     <module>knowledge-api-legacy5-adapter</module>\n   </modules>\n \n+  <build>\n+    <pluginManagement>\n+      <plugins>\n+        <plugin>\n+          <groupId>org.apache.maven.plugins</groupId>\n+          <artifactId>maven-surefire-plugin</artifactId>\n+          <configuration>\n+            <forkCount>${surefire.forkCount}</forkCount>\n+            <reuseForks>true</reuseForks>","path":"pom.xml","position":23,"original_position":23,"commit_id":"ca6461dbe0d4e69f1cb57aba1def1191c3fddd3f","original_commit_id":"ca6461dbe0d4e69f1cb57aba1def1191c3fddd3f","user":{"login":"psiroky","id":670547,"avatar_url":"https://avatars.githubusercontent.com/u/670547?v=3","gravatar_id":"","url":"https://api.github.com/users/psiroky","html_url":"https://github.com/psiroky","followers_url":"https://api.github.com/users/psiroky/followers","following_url":"https://api.github.com/users/psiroky/following{/other_user}","gists_url":"https://api.github.com/users/psiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/psiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiroky/subscriptions","organizations_url":"https://api.github.com/users/psiroky/orgs","repos_url":"https://api.github.com/users/psiroky/repos","events_url":"https://api.github.com/users/psiroky/events{/privacy}","received_events_url":"https://api.github.com/users/psiroky/received_events","type":"User","site_admin":false},"body":"Based on a quick local build, with `<reuseForks>false</reuseForks>` the build takes around 40% more time, which is significant I think.\r\n\r\nI believe the tests should be written in a way that they should work independently of other tests, so reusing the forks should not be an issue. If we find such tests we need to fix them.","created_at":"2015-07-27T12:49:01Z","updated_at":"2015-07-27T12:49:01Z","html_url":"https://github.com/droolsjbpm/drools/pull/471#discussion_r35531446","pull_request_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/471","_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments/35531446"},"html":{"href":"https://github.com/droolsjbpm/drools/pull/471#discussion_r35531446"},"pull_request":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/471"}}},"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/drools/pulls/471","id":40858510,"html_url":"https://github.com/droolsjbpm/drools/pull/471","diff_url":"https://github.com/droolsjbpm/drools/pull/471.diff","patch_url":"https://github.com/droolsjbpm/drools/pull/471.patch","issue_url":"https://api.github.com/repos/droolsjbpm/drools/issues/471","number":471,"state":"open","locked":false,"title":"Run tests in parallel for specified modules","user":{"login":"psiroky","id":670547,"avatar_url":"https://avatars.githubusercontent.com/u/670547?v=3","gravatar_id":"","url":"https://api.github.com/users/psiroky","html_url":"https://github.com/psiroky","followers_url":"https://api.github.com/users/psiroky/followers","following_url":"https://api.github.com/users/psiroky/following{/other_user}","gists_url":"https://api.github.com/users/psiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/psiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiroky/subscriptions","organizations_url":"https://api.github.com/users/psiroky/orgs","repos_url":"https://api.github.com/users/psiroky/repos","events_url":"https://api.github.com/users/psiroky/events{/privacy}","received_events_url":"https://api.github.com/users/psiroky/received_events","type":"User","site_admin":false},"body":" * running tests in multiple forks results\r\n   in significant speed-up\r\n\r\n * only some modules are able to run tests in\r\n   parallel, others like -jpa would need to be\r\n   fixed first to not depend on each other.\r\n\r\n * it also makes most sense for modules which build\r\n   time is high (most of the time is spent in tests).","created_at":"2015-07-26T19:42:57Z","updated_at":"2015-07-27T12:49:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad2ee3793913648545c17b798cc16e198adf3564","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/471/commits","review_comments_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/471/comments","review_comment_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/droolsjbpm/drools/issues/471/comments","statuses_url":"https://api.github.com/repos/droolsjbpm/drools/statuses/ca6461dbe0d4e69f1cb57aba1def1191c3fddd3f","head":{"label":"psiroky:surefire-forks","ref":"surefire-forks","sha":"ca6461dbe0d4e69f1cb57aba1def1191c3fddd3f","user":{"login":"psiroky","id":670547,"avatar_url":"https://avatars.githubusercontent.com/u/670547?v=3","gravatar_id":"","url":"https://api.github.com/users/psiroky","html_url":"https://github.com/psiroky","followers_url":"https://api.github.com/users/psiroky/followers","following_url":"https://api.github.com/users/psiroky/following{/other_user}","gists_url":"https://api.github.com/users/psiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/psiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiroky/subscriptions","organizations_url":"https://api.github.com/users/psiroky/orgs","repos_url":"https://api.github.com/users/psiroky/repos","events_url":"https://api.github.com/users/psiroky/events{/privacy}","received_events_url":"https://api.github.com/users/psiroky/received_events","type":"User","site_admin":false},"repo":{"id":6177562,"name":"drools","full_name":"psiroky/drools","owner":{"login":"psiroky","id":670547,"avatar_url":"https://avatars.githubusercontent.com/u/670547?v=3","gravatar_id":"","url":"https://api.github.com/users/psiroky","html_url":"https://github.com/psiroky","followers_url":"https://api.github.com/users/psiroky/followers","following_url":"https://api.github.com/users/psiroky/following{/other_user}","gists_url":"https://api.github.com/users/psiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/psiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiroky/subscriptions","organizations_url":"https://api.github.com/users/psiroky/orgs","repos_url":"https://api.github.com/users/psiroky/repos","events_url":"https://api.github.com/users/psiroky/events{/privacy}","received_events_url":"https://api.github.com/users/psiroky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psiroky/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":true,"url":"https://api.github.com/repos/psiroky/drools","forks_url":"https://api.github.com/repos/psiroky/drools/forks","keys_url":"https://api.github.com/repos/psiroky/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psiroky/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psiroky/drools/teams","hooks_url":"https://api.github.com/repos/psiroky/drools/hooks","issue_events_url":"https://api.github.com/repos/psiroky/drools/issues/events{/number}","events_url":"https://api.github.com/repos/psiroky/drools/events","assignees_url":"https://api.github.com/repos/psiroky/drools/assignees{/user}","branches_url":"https://api.github.com/repos/psiroky/drools/branches{/branch}","tags_url":"https://api.github.com/repos/psiroky/drools/tags","blobs_url":"https://api.github.com/repos/psiroky/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psiroky/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psiroky/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/psiroky/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psiroky/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/psiroky/drools/languages","stargazers_url":"https://api.github.com/repos/psiroky/drools/stargazers","contributors_url":"https://api.github.com/repos/psiroky/drools/contributors","subscribers_url":"https://api.github.com/repos/psiroky/drools/subscribers","subscription_url":"https://api.github.com/repos/psiroky/drools/subscription","commits_url":"https://api.github.com/repos/psiroky/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/psiroky/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/psiroky/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/psiroky/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/psiroky/drools/contents/{+path}","compare_url":"https://api.github.com/repos/psiroky/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psiroky/drools/merges","archive_url":"https://api.github.com/repos/psiroky/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psiroky/drools/downloads","issues_url":"https://api.github.com/repos/psiroky/drools/issues{/number}","pulls_url":"https://api.github.com/repos/psiroky/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/psiroky/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/psiroky/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psiroky/drools/labels{/name}","releases_url":"https://api.github.com/repos/psiroky/drools/releases{/id}","created_at":"2012-10-11T17:13:33Z","updated_at":"2014-03-18T16:55:32Z","pushed_at":"2015-07-26T19:42:23Z","git_url":"git://github.com/psiroky/drools.git","ssh_url":"git@github.com:psiroky/drools.git","clone_url":"https://github.com/psiroky/drools.git","svn_url":"https://github.com/psiroky/drools","homepage":"http://www.jboss.org/drools","size":131436,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"droolsjbpm:master","ref":"master","sha":"1a63fb2220d3c10f6703b825abcc933e9d2a7e40","user":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"repo":{"id":1381673,"name":"drools","full_name":"droolsjbpm/drools","owner":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/droolsjbpm/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":false,"url":"https://api.github.com/repos/droolsjbpm/drools","forks_url":"https://api.github.com/repos/droolsjbpm/drools/forks","keys_url":"https://api.github.com/repos/droolsjbpm/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droolsjbpm/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droolsjbpm/drools/teams","hooks_url":"https://api.github.com/repos/droolsjbpm/drools/hooks","issue_events_url":"https://api.github.com/repos/droolsjbpm/drools/issues/events{/number}","events_url":"https://api.github.com/repos/droolsjbpm/drools/events","assignees_url":"https://api.github.com/repos/droolsjbpm/drools/assignees{/user}","branches_url":"https://api.github.com/repos/droolsjbpm/drools/branches{/branch}","tags_url":"https://api.github.com/repos/droolsjbpm/drools/tags","blobs_url":"https://api.github.com/repos/droolsjbpm/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droolsjbpm/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droolsjbpm/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/droolsjbpm/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droolsjbpm/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/droolsjbpm/drools/languages","stargazers_url":"https://api.github.com/repos/droolsjbpm/drools/stargazers","contributors_url":"https://api.github.com/repos/droolsjbpm/drools/contributors","subscribers_url":"https://api.github.com/repos/droolsjbpm/drools/subscribers","subscription_url":"https://api.github.com/repos/droolsjbpm/drools/subscription","commits_url":"https://api.github.com/repos/droolsjbpm/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/droolsjbpm/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/droolsjbpm/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/droolsjbpm/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/droolsjbpm/drools/contents/{+path}","compare_url":"https://api.github.com/repos/droolsjbpm/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droolsjbpm/drools/merges","archive_url":"https://api.github.com/repos/droolsjbpm/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droolsjbpm/drools/downloads","issues_url":"https://api.github.com/repos/droolsjbpm/drools/issues{/number}","pulls_url":"https://api.github.com/repos/droolsjbpm/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/droolsjbpm/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/droolsjbpm/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droolsjbpm/drools/labels{/name}","releases_url":"https://api.github.com/repos/droolsjbpm/drools/releases{/id}","created_at":"2011-02-18T08:37:05Z","updated_at":"2015-07-22T12:17:48Z","pushed_at":"2015-07-27T08:19:38Z","git_url":"git://github.com/droolsjbpm/drools.git","ssh_url":"git@github.com:droolsjbpm/drools.git","clone_url":"https://github.com/droolsjbpm/drools.git","svn_url":"https://github.com/droolsjbpm/drools","homepage":"http://www.drools.org","size":297014,"stargazers_count":429,"watchers_count":429,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":660,"mirror_url":null,"open_issues_count":6,"forks":660,"open_issues":6,"watchers":429,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/471"},"html":{"href":"https://github.com/droolsjbpm/drools/pull/471"},"issue":{"href":"https://api.github.com/repos/droolsjbpm/drools/issues/471"},"comments":{"href":"https://api.github.com/repos/droolsjbpm/drools/issues/471/comments"},"review_comments":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/471/comments"},"review_comment":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/471/commits"},"statuses":{"href":"https://api.github.com/repos/droolsjbpm/drools/statuses/ca6461dbe0d4e69f1cb57aba1def1191c3fddd3f"}}}}