{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/32993681","id":32993681,"diff_hunk":"@@ -382,6 +382,18 @@ class SQLQuerySuite extends QueryTest with BeforeAndAfterAll with SQLTestUtils {\n     )\n   }\n \n+  test(\"left semi greater than predicate and equal operator\") {\n+    checkAnswer(\n+      sql(\"SELECT * FROM testData2 x LEFT SEMI JOIN testData2 y ON x.b = y.b and x.a >= y.a + 2\"),\n+      Seq(Row(3, 1), Row(3, 2))\n+    )\n+\n+    checkAnswer(\n+      sql(\"SELECT * FROM testData2 x LEFT SEMI JOIN testData2 y ON x.b = y.a and x.a >= y.b + 1\"),\n+      Seq(Row(2, 1), Row(2, 2), Row(3, 1), Row(3, 2))\n+    )\n+  }","path":"sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala","position":14,"original_position":14,"commit_id":"ad0ad5909c80bb3871a0c082c8e03e4e87d6131a","original_commit_id":"ad0ad5909c80bb3871a0c082c8e03e4e87d6131a","user":{"login":"marmbrus","id":527,"avatar_url":"https://avatars.githubusercontent.com/u/527?v=3","gravatar_id":"","url":"https://api.github.com/users/marmbrus","html_url":"https://github.com/marmbrus","followers_url":"https://api.github.com/users/marmbrus/followers","following_url":"https://api.github.com/users/marmbrus/following{/other_user}","gists_url":"https://api.github.com/users/marmbrus/gists{/gist_id}","starred_url":"https://api.github.com/users/marmbrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmbrus/subscriptions","organizations_url":"https://api.github.com/users/marmbrus/orgs","repos_url":"https://api.github.com/users/marmbrus/repos","events_url":"https://api.github.com/users/marmbrus/events{/privacy}","received_events_url":"https://api.github.com/users/marmbrus/received_events","type":"User","site_admin":false},"body":"It would be great to also add some tests using the new `SparkPlanTest` infrastructure.  In particular it seems like @Sephiroth-Lin found a bug that indicates test coverage is insufficient.","created_at":"2015-06-22T22:56:50Z","updated_at":"2015-06-22T22:56:50Z","html_url":"https://github.com/apache/spark/pull/5643#discussion_r32993681","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/5643","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/32993681"},"html":{"href":"https://github.com/apache/spark/pull/5643#discussion_r32993681"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/5643"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/5643","id":33919921,"html_url":"https://github.com/apache/spark/pull/5643","diff_url":"https://github.com/apache/spark/pull/5643.diff","patch_url":"https://github.com/apache/spark/pull/5643.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/5643","number":5643,"state":"open","locked":false,"title":"[SPARK-7026] [SQL] fix left semi join with equi key and non-equi condition","user":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"body":"When the `condition` extracted by `ExtractEquiJoinKeys` contain join Predicate for left semi join, we can not plan it as semiJoin. Such as\r\n\r\n    SELECT * FROM testData2 x\r\n    LEFT SEMI JOIN testData2 y \r\n    ON x.b = y.b\r\n    AND x.a >= y.a + 2\r\nCondition `x.a >= y.a + 2` can not evaluate on table `x`, so it throw errors","created_at":"2015-04-23T02:47:06Z","updated_at":"2015-06-22T22:56:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60e68539e6e0b09bc6464514108a189750263a50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/5643/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/5643/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/5643/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/ad0ad5909c80bb3871a0c082c8e03e4e87d6131a","head":{"label":"adrian-wang:spark7026","ref":"spark7026","sha":"ad0ad5909c80bb3871a0c082c8e03e4e87d6131a","user":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"repo":{"id":18545588,"name":"spark","full_name":"adrian-wang/spark","owner":{"login":"adrian-wang","id":3078910,"avatar_url":"https://avatars.githubusercontent.com/u/3078910?v=3","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrian-wang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/adrian-wang/spark","forks_url":"https://api.github.com/repos/adrian-wang/spark/forks","keys_url":"https://api.github.com/repos/adrian-wang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrian-wang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrian-wang/spark/teams","hooks_url":"https://api.github.com/repos/adrian-wang/spark/hooks","issue_events_url":"https://api.github.com/repos/adrian-wang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/adrian-wang/spark/events","assignees_url":"https://api.github.com/repos/adrian-wang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/adrian-wang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/adrian-wang/spark/tags","blobs_url":"https://api.github.com/repos/adrian-wang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrian-wang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrian-wang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrian-wang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrian-wang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/adrian-wang/spark/languages","stargazers_url":"https://api.github.com/repos/adrian-wang/spark/stargazers","contributors_url":"https://api.github.com/repos/adrian-wang/spark/contributors","subscribers_url":"https://api.github.com/repos/adrian-wang/spark/subscribers","subscription_url":"https://api.github.com/repos/adrian-wang/spark/subscription","commits_url":"https://api.github.com/repos/adrian-wang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrian-wang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrian-wang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrian-wang/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrian-wang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/adrian-wang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrian-wang/spark/merges","archive_url":"https://api.github.com/repos/adrian-wang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrian-wang/spark/downloads","issues_url":"https://api.github.com/repos/adrian-wang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/adrian-wang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/adrian-wang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/adrian-wang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrian-wang/spark/labels{/name}","releases_url":"https://api.github.com/repos/adrian-wang/spark/releases{/id}","created_at":"2014-04-08T04:42:25Z","updated_at":"2014-07-17T08:04:57Z","pushed_at":"2015-06-19T06:53:52Z","git_url":"git://github.com/adrian-wang/spark.git","ssh_url":"git@github.com:adrian-wang/spark.git","clone_url":"https://github.com/adrian-wang/spark.git","svn_url":"https://github.com/adrian-wang/spark","homepage":null,"size":106597,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d1069cba4a2eb4f00fc3306993a49284efad00c7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-06-22T22:01:30Z","pushed_at":"2015-06-22T22:48:13Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1498855,"stargazers_count":4483,"watchers_count":4483,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3952,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":350,"forks":3952,"open_issues":350,"watchers":4483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/5643"},"html":{"href":"https://github.com/apache/spark/pull/5643"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/5643"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/5643/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/5643/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/5643/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/ad0ad5909c80bb3871a0c082c8e03e4e87d6131a"}}}}