{"action":"created","comment":{"url":"https://api.github.com/repos/jspm/npm/pulls/comments/40607325","id":40607325,"diff_hunk":"@@ -29,5 +30,14 @@\n     \"which\": \"^1.1.1\"\n   },\n   \"homepage\": \"https://github.com/jspm/npm\",\n-  \"devDependencies\": {}\n+  \"devDependencies\": {\n+    \"istanbul\": \"0.3.21\",\n+    \"lodash\": \"3.10.1\",\n+    \"magicpen-media\": \"1.5.1\",\n+    \"messy\": \"6.6.2\",\n+    \"mocha\": \"2.3.3\",\n+    \"unexpected\": \"9.16.0\",\n+    \"unexpected-messy\": \"4.8.1\",","path":"package.json","position":20,"original_position":20,"commit_id":"6900f207fab061b80b327e8226f57cf62bf246d9","original_commit_id":"6900f207fab061b80b327e8226f57cf62bf246d9","user":{"login":"guybedford","id":598730,"avatar_url":"https://avatars.githubusercontent.com/u/598730?v=3","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"body":"Again, is this used?","created_at":"2015-09-28T21:22:26Z","updated_at":"2015-09-28T21:22:26Z","html_url":"https://github.com/jspm/npm/pull/97#discussion_r40607325","pull_request_url":"https://api.github.com/repos/jspm/npm/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/jspm/npm/pulls/comments/40607325"},"html":{"href":"https://github.com/jspm/npm/pull/97#discussion_r40607325"},"pull_request":{"href":"https://api.github.com/repos/jspm/npm/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/jspm/npm/pulls/97","id":46150789,"html_url":"https://github.com/jspm/npm/pull/97","diff_url":"https://github.com/jspm/npm/pull/97.diff","patch_url":"https://github.com/jspm/npm/pull/97.patch","issue_url":"https://api.github.com/repos/jspm/npm/issues/97","number":97,"state":"open","locked":false,"title":"adding tests for lib/auth","user":{"login":"gustavnikolaj","id":1371503,"avatar_url":"https://avatars.githubusercontent.com/u/1371503?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavnikolaj","html_url":"https://github.com/gustavnikolaj","followers_url":"https://api.github.com/users/gustavnikolaj/followers","following_url":"https://api.github.com/users/gustavnikolaj/following{/other_user}","gists_url":"https://api.github.com/users/gustavnikolaj/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavnikolaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavnikolaj/subscriptions","organizations_url":"https://api.github.com/users/gustavnikolaj/orgs","repos_url":"https://api.github.com/users/gustavnikolaj/repos","events_url":"https://api.github.com/users/gustavnikolaj/events{/privacy}","received_events_url":"https://api.github.com/users/gustavnikolaj/received_events","type":"User","site_admin":false},"body":"As promised, here is my take on testing this project.\r\n\r\nWhen checking out this branch, first run `npm install` to get the new development dependencies. Then running `mocha` or `./node_modules/.bin/mocha` will run the new tests for lib/auth.js. Alternatively, you can run the tests through instanbul by running `npm run coverage` and then, the generated coverage report can be found at ./coverage/lcov-report/index.html.\r\n\r\nIf you have any questions please don't hesitate to reach out here, or on gitter, if you prefer.\r\n\r\nI'm using the [unexpected](http://unexpected.js.org/) assertion framework. It goes hand-in-hand with mocha quite nicely, and gives a really nice API for async assertions, based on promises.","created_at":"2015-09-28T12:30:26Z","updated_at":"2015-09-28T21:22:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d8b815654cfeeb83c9e0f2aaee3072406ee38c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jspm/npm/pulls/97/commits","review_comments_url":"https://api.github.com/repos/jspm/npm/pulls/97/comments","review_comment_url":"https://api.github.com/repos/jspm/npm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jspm/npm/issues/97/comments","statuses_url":"https://api.github.com/repos/jspm/npm/statuses/6900f207fab061b80b327e8226f57cf62bf246d9","head":{"label":"gustavnikolaj:feature/test","ref":"feature/test","sha":"6900f207fab061b80b327e8226f57cf62bf246d9","user":{"login":"gustavnikolaj","id":1371503,"avatar_url":"https://avatars.githubusercontent.com/u/1371503?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavnikolaj","html_url":"https://github.com/gustavnikolaj","followers_url":"https://api.github.com/users/gustavnikolaj/followers","following_url":"https://api.github.com/users/gustavnikolaj/following{/other_user}","gists_url":"https://api.github.com/users/gustavnikolaj/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavnikolaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavnikolaj/subscriptions","organizations_url":"https://api.github.com/users/gustavnikolaj/orgs","repos_url":"https://api.github.com/users/gustavnikolaj/repos","events_url":"https://api.github.com/users/gustavnikolaj/events{/privacy}","received_events_url":"https://api.github.com/users/gustavnikolaj/received_events","type":"User","site_admin":false},"repo":{"id":33862591,"name":"npm","full_name":"gustavnikolaj/npm","owner":{"login":"gustavnikolaj","id":1371503,"avatar_url":"https://avatars.githubusercontent.com/u/1371503?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavnikolaj","html_url":"https://github.com/gustavnikolaj","followers_url":"https://api.github.com/users/gustavnikolaj/followers","following_url":"https://api.github.com/users/gustavnikolaj/following{/other_user}","gists_url":"https://api.github.com/users/gustavnikolaj/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavnikolaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavnikolaj/subscriptions","organizations_url":"https://api.github.com/users/gustavnikolaj/orgs","repos_url":"https://api.github.com/users/gustavnikolaj/repos","events_url":"https://api.github.com/users/gustavnikolaj/events{/privacy}","received_events_url":"https://api.github.com/users/gustavnikolaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gustavnikolaj/npm","description":"NPM Location Service","fork":true,"url":"https://api.github.com/repos/gustavnikolaj/npm","forks_url":"https://api.github.com/repos/gustavnikolaj/npm/forks","keys_url":"https://api.github.com/repos/gustavnikolaj/npm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gustavnikolaj/npm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gustavnikolaj/npm/teams","hooks_url":"https://api.github.com/repos/gustavnikolaj/npm/hooks","issue_events_url":"https://api.github.com/repos/gustavnikolaj/npm/issues/events{/number}","events_url":"https://api.github.com/repos/gustavnikolaj/npm/events","assignees_url":"https://api.github.com/repos/gustavnikolaj/npm/assignees{/user}","branches_url":"https://api.github.com/repos/gustavnikolaj/npm/branches{/branch}","tags_url":"https://api.github.com/repos/gustavnikolaj/npm/tags","blobs_url":"https://api.github.com/repos/gustavnikolaj/npm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gustavnikolaj/npm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gustavnikolaj/npm/git/refs{/sha}","trees_url":"https://api.github.com/repos/gustavnikolaj/npm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gustavnikolaj/npm/statuses/{sha}","languages_url":"https://api.github.com/repos/gustavnikolaj/npm/languages","stargazers_url":"https://api.github.com/repos/gustavnikolaj/npm/stargazers","contributors_url":"https://api.github.com/repos/gustavnikolaj/npm/contributors","subscribers_url":"https://api.github.com/repos/gustavnikolaj/npm/subscribers","subscription_url":"https://api.github.com/repos/gustavnikolaj/npm/subscription","commits_url":"https://api.github.com/repos/gustavnikolaj/npm/commits{/sha}","git_commits_url":"https://api.github.com/repos/gustavnikolaj/npm/git/commits{/sha}","comments_url":"https://api.github.com/repos/gustavnikolaj/npm/comments{/number}","issue_comment_url":"https://api.github.com/repos/gustavnikolaj/npm/issues/comments{/number}","contents_url":"https://api.github.com/repos/gustavnikolaj/npm/contents/{+path}","compare_url":"https://api.github.com/repos/gustavnikolaj/npm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gustavnikolaj/npm/merges","archive_url":"https://api.github.com/repos/gustavnikolaj/npm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gustavnikolaj/npm/downloads","issues_url":"https://api.github.com/repos/gustavnikolaj/npm/issues{/number}","pulls_url":"https://api.github.com/repos/gustavnikolaj/npm/pulls{/number}","milestones_url":"https://api.github.com/repos/gustavnikolaj/npm/milestones{/number}","notifications_url":"https://api.github.com/repos/gustavnikolaj/npm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gustavnikolaj/npm/labels{/name}","releases_url":"https://api.github.com/repos/gustavnikolaj/npm/releases{/id}","created_at":"2015-04-13T10:37:23Z","updated_at":"2015-04-13T10:37:23Z","pushed_at":"2015-09-28T12:24:00Z","git_url":"git://github.com/gustavnikolaj/npm.git","ssh_url":"git@github.com:gustavnikolaj/npm.git","clone_url":"https://github.com/gustavnikolaj/npm.git","svn_url":"https://github.com/gustavnikolaj/npm","homepage":"","size":234,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jspm:master","ref":"master","sha":"3be85ca1fd412b80bf0efb14fee3f22e1b0b77f5","user":{"login":"jspm","id":3802108,"avatar_url":"https://avatars.githubusercontent.com/u/3802108?v=3","gravatar_id":"","url":"https://api.github.com/users/jspm","html_url":"https://github.com/jspm","followers_url":"https://api.github.com/users/jspm/followers","following_url":"https://api.github.com/users/jspm/following{/other_user}","gists_url":"https://api.github.com/users/jspm/gists{/gist_id}","starred_url":"https://api.github.com/users/jspm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspm/subscriptions","organizations_url":"https://api.github.com/users/jspm/orgs","repos_url":"https://api.github.com/users/jspm/repos","events_url":"https://api.github.com/users/jspm/events{/privacy}","received_events_url":"https://api.github.com/users/jspm/received_events","type":"Organization","site_admin":false},"repo":{"id":12779410,"name":"npm","full_name":"jspm/npm","owner":{"login":"jspm","id":3802108,"avatar_url":"https://avatars.githubusercontent.com/u/3802108?v=3","gravatar_id":"","url":"https://api.github.com/users/jspm","html_url":"https://github.com/jspm","followers_url":"https://api.github.com/users/jspm/followers","following_url":"https://api.github.com/users/jspm/following{/other_user}","gists_url":"https://api.github.com/users/jspm/gists{/gist_id}","starred_url":"https://api.github.com/users/jspm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspm/subscriptions","organizations_url":"https://api.github.com/users/jspm/orgs","repos_url":"https://api.github.com/users/jspm/repos","events_url":"https://api.github.com/users/jspm/events{/privacy}","received_events_url":"https://api.github.com/users/jspm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jspm/npm","description":"NPM Location Service","fork":false,"url":"https://api.github.com/repos/jspm/npm","forks_url":"https://api.github.com/repos/jspm/npm/forks","keys_url":"https://api.github.com/repos/jspm/npm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jspm/npm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jspm/npm/teams","hooks_url":"https://api.github.com/repos/jspm/npm/hooks","issue_events_url":"https://api.github.com/repos/jspm/npm/issues/events{/number}","events_url":"https://api.github.com/repos/jspm/npm/events","assignees_url":"https://api.github.com/repos/jspm/npm/assignees{/user}","branches_url":"https://api.github.com/repos/jspm/npm/branches{/branch}","tags_url":"https://api.github.com/repos/jspm/npm/tags","blobs_url":"https://api.github.com/repos/jspm/npm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jspm/npm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jspm/npm/git/refs{/sha}","trees_url":"https://api.github.com/repos/jspm/npm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jspm/npm/statuses/{sha}","languages_url":"https://api.github.com/repos/jspm/npm/languages","stargazers_url":"https://api.github.com/repos/jspm/npm/stargazers","contributors_url":"https://api.github.com/repos/jspm/npm/contributors","subscribers_url":"https://api.github.com/repos/jspm/npm/subscribers","subscription_url":"https://api.github.com/repos/jspm/npm/subscription","commits_url":"https://api.github.com/repos/jspm/npm/commits{/sha}","git_commits_url":"https://api.github.com/repos/jspm/npm/git/commits{/sha}","comments_url":"https://api.github.com/repos/jspm/npm/comments{/number}","issue_comment_url":"https://api.github.com/repos/jspm/npm/issues/comments{/number}","contents_url":"https://api.github.com/repos/jspm/npm/contents/{+path}","compare_url":"https://api.github.com/repos/jspm/npm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jspm/npm/merges","archive_url":"https://api.github.com/repos/jspm/npm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jspm/npm/downloads","issues_url":"https://api.github.com/repos/jspm/npm/issues{/number}","pulls_url":"https://api.github.com/repos/jspm/npm/pulls{/number}","milestones_url":"https://api.github.com/repos/jspm/npm/milestones{/number}","notifications_url":"https://api.github.com/repos/jspm/npm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jspm/npm/labels{/name}","releases_url":"https://api.github.com/repos/jspm/npm/releases{/id}","created_at":"2013-09-12T09:04:53Z","updated_at":"2015-06-20T20:10:21Z","pushed_at":"2015-09-28T12:30:26Z","git_url":"git://github.com/jspm/npm.git","ssh_url":"git@github.com:jspm/npm.git","clone_url":"https://github.com/jspm/npm.git","svn_url":"https://github.com/jspm/npm","homepage":"","size":993,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":16,"forks":7,"open_issues":16,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jspm/npm/pulls/97"},"html":{"href":"https://github.com/jspm/npm/pull/97"},"issue":{"href":"https://api.github.com/repos/jspm/npm/issues/97"},"comments":{"href":"https://api.github.com/repos/jspm/npm/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/jspm/npm/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/jspm/npm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jspm/npm/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/jspm/npm/statuses/6900f207fab061b80b327e8226f57cf62bf246d9"}}}}