{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/40750990","id":40750990,"diff_hunk":"@@ -544,6 +545,7 @@ private[spark] class Client(\n       logInfo(s\"Credentials file set to: $credentialsFile\")\n       val renewalInterval = getTokenRenewalInterval(stagingDirPath)\n       sparkConf.set(\"spark.yarn.token.renewal.interval\", renewalInterval.toString)\n+      SparkHadoopUtil.get.startExecutorDelegationTokenRenewer(sparkConf)","path":"yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala","position":12,"original_position":12,"commit_id":"00fd0bc4cd2d6b31ba197629fbe1e9e07a2497bc","original_commit_id":"00fd0bc4cd2d6b31ba197629fbe1e9e07a2497bc","user":{"login":"SaintBacchus","id":7404824,"avatar_url":"https://avatars.githubusercontent.com/u/7404824?v=3","gravatar_id":"","url":"https://api.github.com/users/SaintBacchus","html_url":"https://github.com/SaintBacchus","followers_url":"https://api.github.com/users/SaintBacchus/followers","following_url":"https://api.github.com/users/SaintBacchus/following{/other_user}","gists_url":"https://api.github.com/users/SaintBacchus/gists{/gist_id}","starred_url":"https://api.github.com/users/SaintBacchus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaintBacchus/subscriptions","organizations_url":"https://api.github.com/users/SaintBacchus/orgs","repos_url":"https://api.github.com/users/SaintBacchus/repos","events_url":"https://api.github.com/users/SaintBacchus/events{/privacy}","received_events_url":"https://api.github.com/users/SaintBacchus/received_events","type":"User","site_admin":false},"body":"This code had change the configuration `spark.yarn.credentials.file`, and this configuration would be used in `DelegationTokenUpdate`, so it had to put the `start` after this.","created_at":"2015-09-30T01:34:04Z","updated_at":"2015-09-30T01:34:04Z","html_url":"https://github.com/apache/spark/pull/8867#discussion_r40750990","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/8867","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/40750990"},"html":{"href":"https://github.com/apache/spark/pull/8867#discussion_r40750990"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/8867"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/8867","id":45650439,"html_url":"https://github.com/apache/spark/pull/8867","diff_url":"https://github.com/apache/spark/pull/8867.diff","patch_url":"https://github.com/apache/spark/pull/8867.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/8867","number":8867,"state":"open","locked":false,"title":"[SPARK-10755][YARN]Set driver also update the token for long-running application","user":{"login":"SaintBacchus","id":7404824,"avatar_url":"https://avatars.githubusercontent.com/u/7404824?v=3","gravatar_id":"","url":"https://api.github.com/users/SaintBacchus","html_url":"https://github.com/SaintBacchus","followers_url":"https://api.github.com/users/SaintBacchus/followers","following_url":"https://api.github.com/users/SaintBacchus/following{/other_user}","gists_url":"https://api.github.com/users/SaintBacchus/gists{/gist_id}","starred_url":"https://api.github.com/users/SaintBacchus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaintBacchus/subscriptions","organizations_url":"https://api.github.com/users/SaintBacchus/orgs","repos_url":"https://api.github.com/users/SaintBacchus/repos","events_url":"https://api.github.com/users/SaintBacchus/events{/privacy}","received_events_url":"https://api.github.com/users/SaintBacchus/received_events","type":"User","site_admin":false},"body":"In the yarn-client mode, driver will write the event logs into hdfs and get the partition information from hdfs, so it's nessary to update the token from the `AMDelegationTokenRenewer`.\r\nIn the yarn-cluster mode, driver is company with AM and token will update by AM. But it's still better to update the token for client process since the client wants to delete the staging dir with a expired token.","created_at":"2015-09-22T11:04:53Z","updated_at":"2015-09-30T01:34:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39289c4b677b5dc060b67403a8cf5a91803f46d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/8867/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/8867/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/8867/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/00fd0bc4cd2d6b31ba197629fbe1e9e07a2497bc","head":{"label":"SaintBacchus:SPARK-10755","ref":"SPARK-10755","sha":"00fd0bc4cd2d6b31ba197629fbe1e9e07a2497bc","user":{"login":"SaintBacchus","id":7404824,"avatar_url":"https://avatars.githubusercontent.com/u/7404824?v=3","gravatar_id":"","url":"https://api.github.com/users/SaintBacchus","html_url":"https://github.com/SaintBacchus","followers_url":"https://api.github.com/users/SaintBacchus/followers","following_url":"https://api.github.com/users/SaintBacchus/following{/other_user}","gists_url":"https://api.github.com/users/SaintBacchus/gists{/gist_id}","starred_url":"https://api.github.com/users/SaintBacchus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaintBacchus/subscriptions","organizations_url":"https://api.github.com/users/SaintBacchus/orgs","repos_url":"https://api.github.com/users/SaintBacchus/repos","events_url":"https://api.github.com/users/SaintBacchus/events{/privacy}","received_events_url":"https://api.github.com/users/SaintBacchus/received_events","type":"User","site_admin":false},"repo":{"id":23314424,"name":"spark","full_name":"SaintBacchus/spark","owner":{"login":"SaintBacchus","id":7404824,"avatar_url":"https://avatars.githubusercontent.com/u/7404824?v=3","gravatar_id":"","url":"https://api.github.com/users/SaintBacchus","html_url":"https://github.com/SaintBacchus","followers_url":"https://api.github.com/users/SaintBacchus/followers","following_url":"https://api.github.com/users/SaintBacchus/following{/other_user}","gists_url":"https://api.github.com/users/SaintBacchus/gists{/gist_id}","starred_url":"https://api.github.com/users/SaintBacchus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaintBacchus/subscriptions","organizations_url":"https://api.github.com/users/SaintBacchus/orgs","repos_url":"https://api.github.com/users/SaintBacchus/repos","events_url":"https://api.github.com/users/SaintBacchus/events{/privacy}","received_events_url":"https://api.github.com/users/SaintBacchus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SaintBacchus/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/SaintBacchus/spark","forks_url":"https://api.github.com/repos/SaintBacchus/spark/forks","keys_url":"https://api.github.com/repos/SaintBacchus/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SaintBacchus/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SaintBacchus/spark/teams","hooks_url":"https://api.github.com/repos/SaintBacchus/spark/hooks","issue_events_url":"https://api.github.com/repos/SaintBacchus/spark/issues/events{/number}","events_url":"https://api.github.com/repos/SaintBacchus/spark/events","assignees_url":"https://api.github.com/repos/SaintBacchus/spark/assignees{/user}","branches_url":"https://api.github.com/repos/SaintBacchus/spark/branches{/branch}","tags_url":"https://api.github.com/repos/SaintBacchus/spark/tags","blobs_url":"https://api.github.com/repos/SaintBacchus/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SaintBacchus/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SaintBacchus/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/SaintBacchus/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SaintBacchus/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/SaintBacchus/spark/languages","stargazers_url":"https://api.github.com/repos/SaintBacchus/spark/stargazers","contributors_url":"https://api.github.com/repos/SaintBacchus/spark/contributors","subscribers_url":"https://api.github.com/repos/SaintBacchus/spark/subscribers","subscription_url":"https://api.github.com/repos/SaintBacchus/spark/subscription","commits_url":"https://api.github.com/repos/SaintBacchus/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/SaintBacchus/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/SaintBacchus/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/SaintBacchus/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/SaintBacchus/spark/contents/{+path}","compare_url":"https://api.github.com/repos/SaintBacchus/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SaintBacchus/spark/merges","archive_url":"https://api.github.com/repos/SaintBacchus/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SaintBacchus/spark/downloads","issues_url":"https://api.github.com/repos/SaintBacchus/spark/issues{/number}","pulls_url":"https://api.github.com/repos/SaintBacchus/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/SaintBacchus/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/SaintBacchus/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SaintBacchus/spark/labels{/name}","releases_url":"https://api.github.com/repos/SaintBacchus/spark/releases{/id}","created_at":"2014-08-25T13:22:42Z","updated_at":"2015-05-05T08:45:42Z","pushed_at":"2015-09-29T03:15:43Z","git_url":"git://github.com/SaintBacchus/spark.git","ssh_url":"git@github.com:SaintBacchus/spark.git","clone_url":"https://github.com/SaintBacchus/spark.git","svn_url":"https://github.com/SaintBacchus/spark","homepage":null,"size":118104,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"870b8a2edd44c9274c43ca0db4ef5b0998e16fd8","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-09-30T01:03:51Z","pushed_at":"2015-09-30T01:26:50Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1632283,"stargazers_count":5599,"watchers_count":5599,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5174,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":339,"forks":5174,"open_issues":339,"watchers":5599,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/8867"},"html":{"href":"https://github.com/apache/spark/pull/8867"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/8867"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/8867/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/8867/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/8867/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/00fd0bc4cd2d6b31ba197629fbe1e9e07a2497bc"}}}}