{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/23003304","id":23003304,"diff_hunk":"@@ -502,7 +502,7 @@ protected function initializeBundles()\n      */\n     protected function getContainerClass()\n     {\n-        return $this->name.ucfirst($this->environment).($this->debug ? 'Debug' : '').'ProjectContainer';\n+        return preg_replace('/(^[0-9]*|[^a-zA-Z0-9_]+)/', '', $this->name.ucfirst($this->environment)).($this->debug ? 'Debug' : '').'ProjectContainer';","path":"src/Symfony/Component/HttpKernel/Kernel.php","position":14,"original_position":14,"commit_id":"d86c40429467cc80ebc2678354f2c90e55c4669f","original_commit_id":"d86c40429467cc80ebc2678354f2c90e55c4669f","user":{"login":"lyrixx","id":408368,"avatar_url":"https://avatars.githubusercontent.com/u/408368?v=3","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"body":"ok. no problem. I close the PR","created_at":"2015-01-15T11:14:37Z","updated_at":"2015-01-15T11:14:37Z","html_url":"https://github.com/symfony/symfony/pull/13412#discussion_r23003304","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/13412","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/23003304"},"html":{"href":"https://github.com/symfony/symfony/pull/13412#discussion_r23003304"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13412"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/13412","id":27374510,"html_url":"https://github.com/symfony/symfony/pull/13412","diff_url":"https://github.com/symfony/symfony/pull/13412.diff","patch_url":"https://github.com/symfony/symfony/pull/13412.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/13412","number":13412,"state":"open","locked":false,"title":"[HttpKernel] Fixed Kernel::getContainerClass, to prevent invalid PHP class name","user":{"login":"lyrixx","id":408368,"avatar_url":"https://avatars.githubusercontent.com/u/408368?v=3","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nIf the folder which contains the kernel begin with a number, symfony will crash because symfony will create a container class starting with a number.\r\n\r\n~~I'm not sure if I should fix the `getName` method, or only the `getContainerClass()`.\r\nMore over, if the `environment` contains some invalid characters, it should be fixed too.~~\r\n\r\nActually, I sanitaze only the ``getContainerClass`` method. I did not squashed my commit if I need to revert ;)","created_at":"2015-01-14T19:08:38Z","updated_at":"2015-01-15T11:14:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a7583965476411a1c432623a5f2f74d525d6793","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/13412/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/13412/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/13412/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/d86c40429467cc80ebc2678354f2c90e55c4669f","head":{"label":"lyrixx:fix-kernel-get-name","ref":"fix-kernel-get-name","sha":"d86c40429467cc80ebc2678354f2c90e55c4669f","user":{"login":"lyrixx","id":408368,"avatar_url":"https://avatars.githubusercontent.com/u/408368?v=3","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"repo":{"id":3148495,"name":"symfony","full_name":"lyrixx/symfony","owner":{"login":"lyrixx","id":408368,"avatar_url":"https://avatars.githubusercontent.com/u/408368?v=3","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lyrixx/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/lyrixx/symfony","forks_url":"https://api.github.com/repos/lyrixx/symfony/forks","keys_url":"https://api.github.com/repos/lyrixx/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyrixx/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyrixx/symfony/teams","hooks_url":"https://api.github.com/repos/lyrixx/symfony/hooks","issue_events_url":"https://api.github.com/repos/lyrixx/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/lyrixx/symfony/events","assignees_url":"https://api.github.com/repos/lyrixx/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/lyrixx/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/lyrixx/symfony/tags","blobs_url":"https://api.github.com/repos/lyrixx/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyrixx/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyrixx/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyrixx/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyrixx/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/lyrixx/symfony/languages","stargazers_url":"https://api.github.com/repos/lyrixx/symfony/stargazers","contributors_url":"https://api.github.com/repos/lyrixx/symfony/contributors","subscribers_url":"https://api.github.com/repos/lyrixx/symfony/subscribers","subscription_url":"https://api.github.com/repos/lyrixx/symfony/subscription","commits_url":"https://api.github.com/repos/lyrixx/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyrixx/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyrixx/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyrixx/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/lyrixx/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/lyrixx/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyrixx/symfony/merges","archive_url":"https://api.github.com/repos/lyrixx/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyrixx/symfony/downloads","issues_url":"https://api.github.com/repos/lyrixx/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/lyrixx/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/lyrixx/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/lyrixx/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyrixx/symfony/labels{/name}","releases_url":"https://api.github.com/repos/lyrixx/symfony/releases{/id}","created_at":"2012-01-10T20:46:58Z","updated_at":"2014-10-16T10:07:53Z","pushed_at":"2015-01-14T23:28:32Z","git_url":"git://github.com/lyrixx/symfony.git","ssh_url":"git@github.com:lyrixx/symfony.git","clone_url":"https://github.com/lyrixx/symfony.git","svn_url":"https://github.com/lyrixx/symfony","homepage":"symfony.com","size":46380,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"760ad3306fefdcbd6508fd13edf97a2aa57edd39","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-01-15T08:53:34Z","pushed_at":"2015-01-14T10:57:25Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":187861,"stargazers_count":9504,"watchers_count":9504,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3713,"mirror_url":null,"open_issues_count":804,"forks":3713,"open_issues":804,"watchers":9504,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13412"},"html":{"href":"https://github.com/symfony/symfony/pull/13412"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/13412"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/13412/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13412/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13412/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/d86c40429467cc80ebc2678354f2c90e55c4669f"}}}}