{"action":"created","comment":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/30252065","id":30252065,"diff_hunk":"@@ -558,5 +558,36 @@ bool cl_sandbox_supports_8dot3(void)\n \n \treturn supported;\n }\n+\n+bool cl_sandbox_supports_reparse_points(void)\n+{\n+\tunsigned int flags = 0;\n+\tchar path[8];\n+\tchar drive = 'A' + _getdrive() - 1;\n+\n+\tsprintf(path, \"%c:\\\\\", drive);\n+\n+\tGetVolumeInformation(path, NULL, 0, NULL, NULL, &flags, NULL, 0);","path":"tests/clar_libgit2.c","position":13,"original_position":13,"commit_id":"3e9fa5b8bc750da5ec1979bb0391b455c0b804fa","original_commit_id":"3e9fa5b8bc750da5ec1979bb0391b455c0b804fa","user":{"login":"ethomson","id":1130014,"avatar_url":"https://avatars.githubusercontent.com/u/1130014?v=3","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"body":"This isn't, I suppose, super critical, but you can mount filesystems within the space of another filesystem.  So strictly speaking, I think that we should query the mount point for the clar sandbox path (`GetVolumePathName`?) and then pass *that* to `GetVolumeInformation`.  Otherwise you could mount a VHD at (say) `C:\\Temp\\Foo`, and use that as your clar path and we would incorrectly query the volume information for `C:\\`.\r\n\r\nI would suggest that this is not particularly useful *except* that this PR is about making our ability to run tests in wacky places (ramdisks, in your specific example) more useful.","created_at":"2015-05-13T17:05:06Z","updated_at":"2015-05-13T17:05:06Z","html_url":"https://github.com/libgit2/libgit2/pull/3122#discussion_r30252065","pull_request_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3122","_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/30252065"},"html":{"href":"https://github.com/libgit2/libgit2/pull/3122#discussion_r30252065"},"pull_request":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3122"}}},"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/3122","id":35346452,"html_url":"https://github.com/libgit2/libgit2/pull/3122","diff_url":"https://github.com/libgit2/libgit2/pull/3122.diff","patch_url":"https://github.com/libgit2/libgit2/pull/3122.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/3122","number":3122,"state":"open","locked":false,"title":"Better test support for non-system volumes on Windows","user":{"login":"whoisj","id":11578325,"avatar_url":"https://avatars.githubusercontent.com/u/11578325?v=3","gravatar_id":"","url":"https://api.github.com/users/whoisj","html_url":"https://github.com/whoisj","followers_url":"https://api.github.com/users/whoisj/followers","following_url":"https://api.github.com/users/whoisj/following{/other_user}","gists_url":"https://api.github.com/users/whoisj/gists{/gist_id}","starred_url":"https://api.github.com/users/whoisj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whoisj/subscriptions","organizations_url":"https://api.github.com/users/whoisj/orgs","repos_url":"https://api.github.com/users/whoisj/repos","events_url":"https://api.github.com/users/whoisj/events{/privacy}","received_events_url":"https://api.github.com/users/whoisj/received_events","type":"User","site_admin":false},"body":"Many non-system volumes do not support 8.3 short names, disabling testing on volumes that do not support the feature.\r\n\r\nMany non-systems volumes do not support links (aka reparse points and/or junctions), disabling testing on volumes that do not support the feature.","created_at":"2015-05-13T16:41:31Z","updated_at":"2015-05-13T17:05:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb0100e480dbf3d2c94fc7f89618a7893f5aeb44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3122/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3122/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/3122/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/3e9fa5b8bc750da5ec1979bb0391b455c0b804fa","head":{"label":"whoisj:support-nonsystem-volumes","ref":"support-nonsystem-volumes","sha":"3e9fa5b8bc750da5ec1979bb0391b455c0b804fa","user":{"login":"whoisj","id":11578325,"avatar_url":"https://avatars.githubusercontent.com/u/11578325?v=3","gravatar_id":"","url":"https://api.github.com/users/whoisj","html_url":"https://github.com/whoisj","followers_url":"https://api.github.com/users/whoisj/followers","following_url":"https://api.github.com/users/whoisj/following{/other_user}","gists_url":"https://api.github.com/users/whoisj/gists{/gist_id}","starred_url":"https://api.github.com/users/whoisj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whoisj/subscriptions","organizations_url":"https://api.github.com/users/whoisj/orgs","repos_url":"https://api.github.com/users/whoisj/repos","events_url":"https://api.github.com/users/whoisj/events{/privacy}","received_events_url":"https://api.github.com/users/whoisj/received_events","type":"User","site_admin":false},"repo":{"id":34127680,"name":"libgit2","full_name":"whoisj/libgit2","owner":{"login":"whoisj","id":11578325,"avatar_url":"https://avatars.githubusercontent.com/u/11578325?v=3","gravatar_id":"","url":"https://api.github.com/users/whoisj","html_url":"https://github.com/whoisj","followers_url":"https://api.github.com/users/whoisj/followers","following_url":"https://api.github.com/users/whoisj/following{/other_user}","gists_url":"https://api.github.com/users/whoisj/gists{/gist_id}","starred_url":"https://api.github.com/users/whoisj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whoisj/subscriptions","organizations_url":"https://api.github.com/users/whoisj/orgs","repos_url":"https://api.github.com/users/whoisj/repos","events_url":"https://api.github.com/users/whoisj/events{/privacy}","received_events_url":"https://api.github.com/users/whoisj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whoisj/libgit2","description":"The Library","fork":true,"url":"https://api.github.com/repos/whoisj/libgit2","forks_url":"https://api.github.com/repos/whoisj/libgit2/forks","keys_url":"https://api.github.com/repos/whoisj/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whoisj/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whoisj/libgit2/teams","hooks_url":"https://api.github.com/repos/whoisj/libgit2/hooks","issue_events_url":"https://api.github.com/repos/whoisj/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/whoisj/libgit2/events","assignees_url":"https://api.github.com/repos/whoisj/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/whoisj/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/whoisj/libgit2/tags","blobs_url":"https://api.github.com/repos/whoisj/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whoisj/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whoisj/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/whoisj/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whoisj/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/whoisj/libgit2/languages","stargazers_url":"https://api.github.com/repos/whoisj/libgit2/stargazers","contributors_url":"https://api.github.com/repos/whoisj/libgit2/contributors","subscribers_url":"https://api.github.com/repos/whoisj/libgit2/subscribers","subscription_url":"https://api.github.com/repos/whoisj/libgit2/subscription","commits_url":"https://api.github.com/repos/whoisj/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/whoisj/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/whoisj/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/whoisj/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/whoisj/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/whoisj/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whoisj/libgit2/merges","archive_url":"https://api.github.com/repos/whoisj/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whoisj/libgit2/downloads","issues_url":"https://api.github.com/repos/whoisj/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/whoisj/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/whoisj/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/whoisj/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whoisj/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/whoisj/libgit2/releases{/id}","created_at":"2015-04-17T16:36:41Z","updated_at":"2015-05-07T16:37:30Z","pushed_at":"2015-05-13T16:41:13Z","git_url":"git://github.com/whoisj/libgit2.git","ssh_url":"git@github.com:whoisj/libgit2.git","clone_url":"https://github.com/whoisj/libgit2.git","svn_url":"https://github.com/whoisj/libgit2","homepage":"http://libgit2.github.com","size":17477,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"libgit2:master","ref":"master","sha":"a6f2ceaf48ae7bb5ca125129adc9017c67979abf","user":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"name":"libgit2","full_name":"libgit2/libgit2","owner":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/libgit2","description":"The Library","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","created_at":"2010-09-10T16:17:48Z","updated_at":"2015-05-13T15:33:55Z","pushed_at":"2015-05-13T16:41:31Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"http://libgit2.github.com","size":110653,"stargazers_count":4881,"watchers_count":4881,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1138,"mirror_url":null,"open_issues_count":116,"forks":1138,"open_issues":116,"watchers":4881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3122"},"html":{"href":"https://github.com/libgit2/libgit2/pull/3122"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3122"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3122/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3122/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3122/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2/statuses/3e9fa5b8bc750da5ec1979bb0391b455c0b804fa"}}}}