{"action":"created","comment":{"url":"https://api.github.com/repos/rhinstaller/blivet/pulls/comments/36800327","id":36800327,"diff_hunk":"@@ -110,27 +111,69 @@ def addSan(self, nic, dcb=False, auto_vlan=True):\n         log.info(\"Activating FCoE SAN attached to %s, dcb: %s autovlan: %s\",\n                  nic, dcb, auto_vlan)\n \n-        util.run_program([\"ip\", \"link\", \"set\", nic, \"up\"])\n-\n         rc = 0\n+        out = \"\"\n+        timeout = 60\n         error_msg = \"\"\n         if dcb:\n+\n             self._startLldpad()\n-            util.run_program([\"dcbtool\", \"sc\", nic, \"dcb\", \"on\"])\n-            util.run_program([\"dcbtool\", \"sc\", nic, \"app:fcoe\",\n-                                                \"e:1\", \"a:1\", \"w:1\"])\n-            rc, out = util.run_program_and_capture_output([\"fipvlan\", \"-c\", \"-s\", \"-f\",\n-                                               \"-fcoe\", nic])\n+            while timeout > 0:\n+                rc, out = util.run_program_and_capture_output(\n+                    [\"lldptool\", \"-p\"])\n+                if not rc:\n+                    break\n+                log.info(\"Waiting for lldpad to be ready\")","path":"blivet/fcoe.py","position":40,"original_position":40,"commit_id":"f4ddb913a34a377f528ff85169f040120d2c3d0c","original_commit_id":"f4ddb913a34a377f528ff85169f040120d2c3d0c","user":{"login":"bcl","id":212092,"avatar_url":"https://avatars.githubusercontent.com/u/212092?v=3","gravatar_id":"","url":"https://api.github.com/users/bcl","html_url":"https://github.com/bcl","followers_url":"https://api.github.com/users/bcl/followers","following_url":"https://api.github.com/users/bcl/following{/other_user}","gists_url":"https://api.github.com/users/bcl/gists{/gist_id}","starred_url":"https://api.github.com/users/bcl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcl/subscriptions","organizations_url":"https://api.github.com/users/bcl/orgs","repos_url":"https://api.github.com/users/bcl/repos","events_url":"https://api.github.com/users/bcl/events{/privacy}","received_events_url":"https://api.github.com/users/bcl/received_events","type":"User","site_admin":false},"body":"these are going to clutter up the logs, maybe only log if the timeout is exceeded. while / else could be used for that.","created_at":"2015-08-11T21:18:23Z","updated_at":"2015-08-11T21:18:23Z","html_url":"https://github.com/rhinstaller/blivet/pull/200#discussion_r36800327","pull_request_url":"https://api.github.com/repos/rhinstaller/blivet/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/comments/36800327"},"html":{"href":"https://github.com/rhinstaller/blivet/pull/200#discussion_r36800327"},"pull_request":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/rhinstaller/blivet/pulls/200","id":42116813,"html_url":"https://github.com/rhinstaller/blivet/pull/200","diff_url":"https://github.com/rhinstaller/blivet/pull/200.diff","patch_url":"https://github.com/rhinstaller/blivet/pull/200.patch","issue_url":"https://api.github.com/repos/rhinstaller/blivet/issues/200","number":200,"state":"open","locked":false,"title":"fcoe: replace fipvlan with fcoemon (#1085325)","user":{"login":"rvykydal","id":1220237,"avatar_url":"https://avatars.githubusercontent.com/u/1220237?v=3","gravatar_id":"","url":"https://api.github.com/users/rvykydal","html_url":"https://github.com/rvykydal","followers_url":"https://api.github.com/users/rvykydal/followers","following_url":"https://api.github.com/users/rvykydal/following{/other_user}","gists_url":"https://api.github.com/users/rvykydal/gists{/gist_id}","starred_url":"https://api.github.com/users/rvykydal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvykydal/subscriptions","organizations_url":"https://api.github.com/users/rvykydal/orgs","repos_url":"https://api.github.com/users/rvykydal/repos","events_url":"https://api.github.com/users/rvykydal/events{/privacy}","received_events_url":"https://api.github.com/users/rvykydal/received_events","type":"User","site_admin":false},"body":"Same as dracut (#1129888), we are moving to use fcoemon which provides more\r\nrobust approach than fipvlan.\r\n\r\nResolves: rhbz#1085325","created_at":"2015-08-11T11:05:10Z","updated_at":"2015-08-11T21:18:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a26abee58bc3aff25b01ee3203b225984a954f63","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rhinstaller/blivet/pulls/200/commits","review_comments_url":"https://api.github.com/repos/rhinstaller/blivet/pulls/200/comments","review_comment_url":"https://api.github.com/repos/rhinstaller/blivet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhinstaller/blivet/issues/200/comments","statuses_url":"https://api.github.com/repos/rhinstaller/blivet/statuses/f4ddb913a34a377f528ff85169f040120d2c3d0c","head":{"label":"rvykydal:rhel7-branch-fcoe-with-fcoeadm","ref":"rhel7-branch-fcoe-with-fcoeadm","sha":"f4ddb913a34a377f528ff85169f040120d2c3d0c","user":{"login":"rvykydal","id":1220237,"avatar_url":"https://avatars.githubusercontent.com/u/1220237?v=3","gravatar_id":"","url":"https://api.github.com/users/rvykydal","html_url":"https://github.com/rvykydal","followers_url":"https://api.github.com/users/rvykydal/followers","following_url":"https://api.github.com/users/rvykydal/following{/other_user}","gists_url":"https://api.github.com/users/rvykydal/gists{/gist_id}","starred_url":"https://api.github.com/users/rvykydal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvykydal/subscriptions","organizations_url":"https://api.github.com/users/rvykydal/orgs","repos_url":"https://api.github.com/users/rvykydal/repos","events_url":"https://api.github.com/users/rvykydal/events{/privacy}","received_events_url":"https://api.github.com/users/rvykydal/received_events","type":"User","site_admin":false},"repo":{"id":39943464,"name":"blivet","full_name":"rvykydal/blivet","owner":{"login":"rvykydal","id":1220237,"avatar_url":"https://avatars.githubusercontent.com/u/1220237?v=3","gravatar_id":"","url":"https://api.github.com/users/rvykydal","html_url":"https://github.com/rvykydal","followers_url":"https://api.github.com/users/rvykydal/followers","following_url":"https://api.github.com/users/rvykydal/following{/other_user}","gists_url":"https://api.github.com/users/rvykydal/gists{/gist_id}","starred_url":"https://api.github.com/users/rvykydal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvykydal/subscriptions","organizations_url":"https://api.github.com/users/rvykydal/orgs","repos_url":"https://api.github.com/users/rvykydal/repos","events_url":"https://api.github.com/users/rvykydal/events{/privacy}","received_events_url":"https://api.github.com/users/rvykydal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rvykydal/blivet","description":"A python module for configuration of block devices","fork":true,"url":"https://api.github.com/repos/rvykydal/blivet","forks_url":"https://api.github.com/repos/rvykydal/blivet/forks","keys_url":"https://api.github.com/repos/rvykydal/blivet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rvykydal/blivet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rvykydal/blivet/teams","hooks_url":"https://api.github.com/repos/rvykydal/blivet/hooks","issue_events_url":"https://api.github.com/repos/rvykydal/blivet/issues/events{/number}","events_url":"https://api.github.com/repos/rvykydal/blivet/events","assignees_url":"https://api.github.com/repos/rvykydal/blivet/assignees{/user}","branches_url":"https://api.github.com/repos/rvykydal/blivet/branches{/branch}","tags_url":"https://api.github.com/repos/rvykydal/blivet/tags","blobs_url":"https://api.github.com/repos/rvykydal/blivet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rvykydal/blivet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rvykydal/blivet/git/refs{/sha}","trees_url":"https://api.github.com/repos/rvykydal/blivet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rvykydal/blivet/statuses/{sha}","languages_url":"https://api.github.com/repos/rvykydal/blivet/languages","stargazers_url":"https://api.github.com/repos/rvykydal/blivet/stargazers","contributors_url":"https://api.github.com/repos/rvykydal/blivet/contributors","subscribers_url":"https://api.github.com/repos/rvykydal/blivet/subscribers","subscription_url":"https://api.github.com/repos/rvykydal/blivet/subscription","commits_url":"https://api.github.com/repos/rvykydal/blivet/commits{/sha}","git_commits_url":"https://api.github.com/repos/rvykydal/blivet/git/commits{/sha}","comments_url":"https://api.github.com/repos/rvykydal/blivet/comments{/number}","issue_comment_url":"https://api.github.com/repos/rvykydal/blivet/issues/comments{/number}","contents_url":"https://api.github.com/repos/rvykydal/blivet/contents/{+path}","compare_url":"https://api.github.com/repos/rvykydal/blivet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rvykydal/blivet/merges","archive_url":"https://api.github.com/repos/rvykydal/blivet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rvykydal/blivet/downloads","issues_url":"https://api.github.com/repos/rvykydal/blivet/issues{/number}","pulls_url":"https://api.github.com/repos/rvykydal/blivet/pulls{/number}","milestones_url":"https://api.github.com/repos/rvykydal/blivet/milestones{/number}","notifications_url":"https://api.github.com/repos/rvykydal/blivet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rvykydal/blivet/labels{/name}","releases_url":"https://api.github.com/repos/rvykydal/blivet/releases{/id}","created_at":"2015-07-30T09:51:36Z","updated_at":"2015-07-30T09:51:37Z","pushed_at":"2015-08-11T11:01:35Z","git_url":"git://github.com/rvykydal/blivet.git","ssh_url":"git@github.com:rvykydal/blivet.git","clone_url":"https://github.com/rvykydal/blivet.git","svn_url":"https://github.com/rvykydal/blivet","homepage":null,"size":7419,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhinstaller:rhel7-branch","ref":"rhel7-branch","sha":"64f76379710314adbad6edcb556719008a3f4f4f","user":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"repo":{"id":16584540,"name":"blivet","full_name":"rhinstaller/blivet","owner":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhinstaller/blivet","description":"A python module for configuration of block devices","fork":false,"url":"https://api.github.com/repos/rhinstaller/blivet","forks_url":"https://api.github.com/repos/rhinstaller/blivet/forks","keys_url":"https://api.github.com/repos/rhinstaller/blivet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinstaller/blivet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinstaller/blivet/teams","hooks_url":"https://api.github.com/repos/rhinstaller/blivet/hooks","issue_events_url":"https://api.github.com/repos/rhinstaller/blivet/issues/events{/number}","events_url":"https://api.github.com/repos/rhinstaller/blivet/events","assignees_url":"https://api.github.com/repos/rhinstaller/blivet/assignees{/user}","branches_url":"https://api.github.com/repos/rhinstaller/blivet/branches{/branch}","tags_url":"https://api.github.com/repos/rhinstaller/blivet/tags","blobs_url":"https://api.github.com/repos/rhinstaller/blivet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinstaller/blivet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinstaller/blivet/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinstaller/blivet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinstaller/blivet/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinstaller/blivet/languages","stargazers_url":"https://api.github.com/repos/rhinstaller/blivet/stargazers","contributors_url":"https://api.github.com/repos/rhinstaller/blivet/contributors","subscribers_url":"https://api.github.com/repos/rhinstaller/blivet/subscribers","subscription_url":"https://api.github.com/repos/rhinstaller/blivet/subscription","commits_url":"https://api.github.com/repos/rhinstaller/blivet/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinstaller/blivet/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinstaller/blivet/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinstaller/blivet/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinstaller/blivet/contents/{+path}","compare_url":"https://api.github.com/repos/rhinstaller/blivet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinstaller/blivet/merges","archive_url":"https://api.github.com/repos/rhinstaller/blivet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinstaller/blivet/downloads","issues_url":"https://api.github.com/repos/rhinstaller/blivet/issues{/number}","pulls_url":"https://api.github.com/repos/rhinstaller/blivet/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinstaller/blivet/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinstaller/blivet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinstaller/blivet/labels{/name}","releases_url":"https://api.github.com/repos/rhinstaller/blivet/releases{/id}","created_at":"2014-02-06T16:02:44Z","updated_at":"2015-08-09T20:10:44Z","pushed_at":"2015-08-11T11:05:11Z","git_url":"git://github.com/rhinstaller/blivet.git","ssh_url":"git@github.com:rhinstaller/blivet.git","clone_url":"https://github.com/rhinstaller/blivet.git","svn_url":"https://github.com/rhinstaller/blivet","homepage":null,"size":11357,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":25,"mirror_url":null,"open_issues_count":27,"forks":25,"open_issues":27,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/200"},"html":{"href":"https://github.com/rhinstaller/blivet/pull/200"},"issue":{"href":"https://api.github.com/repos/rhinstaller/blivet/issues/200"},"comments":{"href":"https://api.github.com/repos/rhinstaller/blivet/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/rhinstaller/blivet/statuses/f4ddb913a34a377f528ff85169f040120d2c3d0c"}}}}