{"action":"created","comment":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/comments/25462954","id":25462954,"diff_hunk":"@@ -41,14 +41,14 @@\n     $jsvc_version = 'latest',\n     $owner = 'root',\n     $group = 'root',\n-    $service_name,\n+    $service_name = undef,\n     $jsvc_exec = '$(which jsvc)',\n     $java_home = undef,\n-    $service_out_logfile,\n-    $service_err_logfile,\n+    $service_out_logfile = undef,\n+    $service_err_logfile = undef,\n     $lib_dir = undef,\n-    $jar_path,\n-    $mainClass,\n+    $jar_path = undef,\n+    $mainClass = undef,","path":"manifests/application/migrator/daemon.pp","position":16,"original_position":16,"commit_id":"8d7595fcc49316734d5d8ae0f51a5347ac367621","original_commit_id":"8d7595fcc49316734d5d8ae0f51a5347ac367621","user":{"login":"dcrissman","id":1878960,"avatar_url":"https://avatars.githubusercontent.com/u/1878960?v=3","gravatar_id":"","url":"https://api.github.com/users/dcrissman","html_url":"https://github.com/dcrissman","followers_url":"https://api.github.com/users/dcrissman/followers","following_url":"https://api.github.com/users/dcrissman/following{/other_user}","gists_url":"https://api.github.com/users/dcrissman/gists{/gist_id}","starred_url":"https://api.github.com/users/dcrissman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcrissman/subscriptions","organizations_url":"https://api.github.com/users/dcrissman/orgs","repos_url":"https://api.github.com/users/dcrissman/repos","events_url":"https://api.github.com/users/dcrissman/events{/privacy}","received_events_url":"https://api.github.com/users/dcrissman/received_events","type":"User","site_admin":false},"body":"Please do not make these undef. Doing so makes them optional, and they should be required.","created_at":"2015-02-26T20:50:54Z","updated_at":"2015-02-26T20:50:54Z","html_url":"https://github.com/lightblue-platform/lightblue-puppet/pull/100#discussion_r25462954","pull_request_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/comments/25462954"},"html":{"href":"https://github.com/lightblue-platform/lightblue-puppet/pull/100#discussion_r25462954"},"pull_request":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/100","id":29842978,"html_url":"https://github.com/lightblue-platform/lightblue-puppet/pull/100","diff_url":"https://github.com/lightblue-platform/lightblue-puppet/pull/100.diff","patch_url":"https://github.com/lightblue-platform/lightblue-puppet/pull/100.patch","issue_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/issues/100","number":100,"state":"open","locked":false,"title":"Fixing eap module path creation and some syntax quirks","user":{"login":"paterczm","id":4681035,"avatar_url":"https://avatars.githubusercontent.com/u/4681035?v=3","gravatar_id":"","url":"https://api.github.com/users/paterczm","html_url":"https://github.com/paterczm","followers_url":"https://api.github.com/users/paterczm/followers","following_url":"https://api.github.com/users/paterczm/following{/other_user}","gists_url":"https://api.github.com/users/paterczm/gists{/gist_id}","starred_url":"https://api.github.com/users/paterczm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paterczm/subscriptions","organizations_url":"https://api.github.com/users/paterczm/orgs","repos_url":"https://api.github.com/users/paterczm/repos","events_url":"https://api.github.com/users/paterczm/events{/privacy}","received_events_url":"https://api.github.com/users/paterczm/received_events","type":"User","site_admin":false},"body":"The first 2 fixes (commits 'Making puppet lint happy' and 'Fix check if var defined') are probably related to the puppet version we're using (2.7). Perhaps this works on 3.x.\r\n\r\nThe last fix ('Fix creating module paths') is required to be able to create more than client configuration on a single host.","created_at":"2015-02-23T20:36:48Z","updated_at":"2015-02-26T20:50:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a8d82bbe28a5204dd901c8a893205d6b15b4bca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/100/commits","review_comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/100/comments","review_comment_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/issues/100/comments","statuses_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/statuses/8d7595fcc49316734d5d8ae0f51a5347ac367621","head":{"label":"paterczm:master","ref":"master","sha":"8d7595fcc49316734d5d8ae0f51a5347ac367621","user":{"login":"paterczm","id":4681035,"avatar_url":"https://avatars.githubusercontent.com/u/4681035?v=3","gravatar_id":"","url":"https://api.github.com/users/paterczm","html_url":"https://github.com/paterczm","followers_url":"https://api.github.com/users/paterczm/followers","following_url":"https://api.github.com/users/paterczm/following{/other_user}","gists_url":"https://api.github.com/users/paterczm/gists{/gist_id}","starred_url":"https://api.github.com/users/paterczm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paterczm/subscriptions","organizations_url":"https://api.github.com/users/paterczm/orgs","repos_url":"https://api.github.com/users/paterczm/repos","events_url":"https://api.github.com/users/paterczm/events{/privacy}","received_events_url":"https://api.github.com/users/paterczm/received_events","type":"User","site_admin":false},"repo":{"id":31228042,"name":"lightblue-puppet","full_name":"paterczm/lightblue-puppet","owner":{"login":"paterczm","id":4681035,"avatar_url":"https://avatars.githubusercontent.com/u/4681035?v=3","gravatar_id":"","url":"https://api.github.com/users/paterczm","html_url":"https://github.com/paterczm","followers_url":"https://api.github.com/users/paterczm/followers","following_url":"https://api.github.com/users/paterczm/following{/other_user}","gists_url":"https://api.github.com/users/paterczm/gists{/gist_id}","starred_url":"https://api.github.com/users/paterczm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paterczm/subscriptions","organizations_url":"https://api.github.com/users/paterczm/orgs","repos_url":"https://api.github.com/users/paterczm/repos","events_url":"https://api.github.com/users/paterczm/events{/privacy}","received_events_url":"https://api.github.com/users/paterczm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paterczm/lightblue-puppet","description":"Puppet module for lightblue!","fork":true,"url":"https://api.github.com/repos/paterczm/lightblue-puppet","forks_url":"https://api.github.com/repos/paterczm/lightblue-puppet/forks","keys_url":"https://api.github.com/repos/paterczm/lightblue-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paterczm/lightblue-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paterczm/lightblue-puppet/teams","hooks_url":"https://api.github.com/repos/paterczm/lightblue-puppet/hooks","issue_events_url":"https://api.github.com/repos/paterczm/lightblue-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/paterczm/lightblue-puppet/events","assignees_url":"https://api.github.com/repos/paterczm/lightblue-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/paterczm/lightblue-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/paterczm/lightblue-puppet/tags","blobs_url":"https://api.github.com/repos/paterczm/lightblue-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paterczm/lightblue-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paterczm/lightblue-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/paterczm/lightblue-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paterczm/lightblue-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/paterczm/lightblue-puppet/languages","stargazers_url":"https://api.github.com/repos/paterczm/lightblue-puppet/stargazers","contributors_url":"https://api.github.com/repos/paterczm/lightblue-puppet/contributors","subscribers_url":"https://api.github.com/repos/paterczm/lightblue-puppet/subscribers","subscription_url":"https://api.github.com/repos/paterczm/lightblue-puppet/subscription","commits_url":"https://api.github.com/repos/paterczm/lightblue-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/paterczm/lightblue-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/paterczm/lightblue-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/paterczm/lightblue-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/paterczm/lightblue-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/paterczm/lightblue-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paterczm/lightblue-puppet/merges","archive_url":"https://api.github.com/repos/paterczm/lightblue-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paterczm/lightblue-puppet/downloads","issues_url":"https://api.github.com/repos/paterczm/lightblue-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/paterczm/lightblue-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/paterczm/lightblue-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/paterczm/lightblue-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paterczm/lightblue-puppet/labels{/name}","releases_url":"https://api.github.com/repos/paterczm/lightblue-puppet/releases{/id}","created_at":"2015-02-23T20:28:54Z","updated_at":"2015-02-23T20:32:32Z","pushed_at":"2015-02-23T20:32:30Z","git_url":"git://github.com/paterczm/lightblue-puppet.git","ssh_url":"git@github.com:paterczm/lightblue-puppet.git","clone_url":"https://github.com/paterczm/lightblue-puppet.git","svn_url":"https://github.com/paterczm/lightblue-puppet","homepage":null,"size":434,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightblue-platform:master","ref":"master","sha":"30e2d4e2377942453fa2bfb889aa320d26b74d63","user":{"login":"lightblue-platform","id":7061725,"avatar_url":"https://avatars.githubusercontent.com/u/7061725?v=3","gravatar_id":"","url":"https://api.github.com/users/lightblue-platform","html_url":"https://github.com/lightblue-platform","followers_url":"https://api.github.com/users/lightblue-platform/followers","following_url":"https://api.github.com/users/lightblue-platform/following{/other_user}","gists_url":"https://api.github.com/users/lightblue-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lightblue-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightblue-platform/subscriptions","organizations_url":"https://api.github.com/users/lightblue-platform/orgs","repos_url":"https://api.github.com/users/lightblue-platform/repos","events_url":"https://api.github.com/users/lightblue-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lightblue-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":21955650,"name":"lightblue-puppet","full_name":"lightblue-platform/lightblue-puppet","owner":{"login":"lightblue-platform","id":7061725,"avatar_url":"https://avatars.githubusercontent.com/u/7061725?v=3","gravatar_id":"","url":"https://api.github.com/users/lightblue-platform","html_url":"https://github.com/lightblue-platform","followers_url":"https://api.github.com/users/lightblue-platform/followers","following_url":"https://api.github.com/users/lightblue-platform/following{/other_user}","gists_url":"https://api.github.com/users/lightblue-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lightblue-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightblue-platform/subscriptions","organizations_url":"https://api.github.com/users/lightblue-platform/orgs","repos_url":"https://api.github.com/users/lightblue-platform/repos","events_url":"https://api.github.com/users/lightblue-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lightblue-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightblue-platform/lightblue-puppet","description":"Puppet module for lightblue!","fork":false,"url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet","forks_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/forks","keys_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/teams","hooks_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/hooks","issue_events_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/events","assignees_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/tags","blobs_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/languages","stargazers_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/stargazers","contributors_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/contributors","subscribers_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/subscribers","subscription_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/subscription","commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/merges","archive_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/downloads","issues_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/labels{/name}","releases_url":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/releases{/id}","created_at":"2014-07-17T19:59:41Z","updated_at":"2015-02-25T20:34:28Z","pushed_at":"2015-02-25T20:34:28Z","git_url":"git://github.com/lightblue-platform/lightblue-puppet.git","ssh_url":"git@github.com:lightblue-platform/lightblue-puppet.git","clone_url":"https://github.com/lightblue-platform/lightblue-puppet.git","svn_url":"https://github.com/lightblue-platform/lightblue-puppet","homepage":null,"size":1415,"stargazers_count":2,"watchers_count":2,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":32,"forks":6,"open_issues":32,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/100"},"html":{"href":"https://github.com/lightblue-platform/lightblue-puppet/pull/100"},"issue":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/issues/100"},"comments":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-puppet/statuses/8d7595fcc49316734d5d8ae0f51a5347ac367621"}}}}