{"action":"closed","number":483,"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/483","id":28423544,"html_url":"https://github.com/facebook/rocksdb/pull/483","diff_url":"https://github.com/facebook/rocksdb/pull/483.diff","patch_url":"https://github.com/facebook/rocksdb/pull/483.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/483","number":483,"state":"closed","locked":false,"title":"Restructure java build","user":{"login":"adamretter","id":1264057,"avatar_url":"https://avatars.githubusercontent.com/u/1264057?v=3","gravatar_id":"","url":"https://api.github.com/users/adamretter","html_url":"https://github.com/adamretter","followers_url":"https://api.github.com/users/adamretter/followers","following_url":"https://api.github.com/users/adamretter/following{/other_user}","gists_url":"https://api.github.com/users/adamretter/gists{/gist_id}","starred_url":"https://api.github.com/users/adamretter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamretter/subscriptions","organizations_url":"https://api.github.com/users/adamretter/orgs","repos_url":"https://api.github.com/users/adamretter/repos","events_url":"https://api.github.com/users/adamretter/events{/privacy}","received_events_url":"https://api.github.com/users/adamretter/received_events","type":"User","site_admin":false},"body":"I have restructured the layout of the Java class files so that they are in a standard directory layout as popularised by Maven but recognised by many tools, e.g. `src/main/java` and `src/test/java`.\r\n\r\nThe main advantage here is that it is now possible and simple to build and debug the Java code from IDEs such as IntelliJ. In addition the fact that test classes and source classes are now in the same correct packages, means that tests can access *package-private* and *protected* methods of classes under test.\r\n\r\nThese changes are backwards compatible, as the packages and classes of the Java API itself have not been changed.\r\n\r\nReview is available here: https://reviews.facebook.net/D32643","created_at":"2015-02-01T00:07:00Z","updated_at":"2015-02-09T06:53:11Z","closed_at":"2015-02-09T06:53:11Z","merged_at":"2015-02-09T06:53:11Z","merge_commit_sha":"65cdd6704f2fcf55f42d2c822d5cba3a38c0cd18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/483/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/483/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/483/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/f33f3955eee379b29fda02dac1d30ba628669d67","head":{"label":"adamretter:restructure-java-build","ref":"restructure-java-build","sha":"f33f3955eee379b29fda02dac1d30ba628669d67","user":{"login":"adamretter","id":1264057,"avatar_url":"https://avatars.githubusercontent.com/u/1264057?v=3","gravatar_id":"","url":"https://api.github.com/users/adamretter","html_url":"https://github.com/adamretter","followers_url":"https://api.github.com/users/adamretter/followers","following_url":"https://api.github.com/users/adamretter/following{/other_user}","gists_url":"https://api.github.com/users/adamretter/gists{/gist_id}","starred_url":"https://api.github.com/users/adamretter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamretter/subscriptions","organizations_url":"https://api.github.com/users/adamretter/orgs","repos_url":"https://api.github.com/users/adamretter/repos","events_url":"https://api.github.com/users/adamretter/events{/privacy}","received_events_url":"https://api.github.com/users/adamretter/received_events","type":"User","site_admin":false},"repo":{"id":22577794,"name":"rocksdb","full_name":"adamretter/rocksdb","owner":{"login":"adamretter","id":1264057,"avatar_url":"https://avatars.githubusercontent.com/u/1264057?v=3","gravatar_id":"","url":"https://api.github.com/users/adamretter","html_url":"https://github.com/adamretter","followers_url":"https://api.github.com/users/adamretter/followers","following_url":"https://api.github.com/users/adamretter/following{/other_user}","gists_url":"https://api.github.com/users/adamretter/gists{/gist_id}","starred_url":"https://api.github.com/users/adamretter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamretter/subscriptions","organizations_url":"https://api.github.com/users/adamretter/orgs","repos_url":"https://api.github.com/users/adamretter/repos","events_url":"https://api.github.com/users/adamretter/events{/privacy}","received_events_url":"https://api.github.com/users/adamretter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamretter/rocksdb","description":"Embedded key-value store for fast storage","fork":true,"url":"https://api.github.com/repos/adamretter/rocksdb","forks_url":"https://api.github.com/repos/adamretter/rocksdb/forks","keys_url":"https://api.github.com/repos/adamretter/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamretter/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamretter/rocksdb/teams","hooks_url":"https://api.github.com/repos/adamretter/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/adamretter/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/adamretter/rocksdb/events","assignees_url":"https://api.github.com/repos/adamretter/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/adamretter/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/adamretter/rocksdb/tags","blobs_url":"https://api.github.com/repos/adamretter/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamretter/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamretter/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamretter/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamretter/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/adamretter/rocksdb/languages","stargazers_url":"https://api.github.com/repos/adamretter/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/adamretter/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/adamretter/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/adamretter/rocksdb/subscription","commits_url":"https://api.github.com/repos/adamretter/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamretter/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamretter/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamretter/rocksdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/adamretter/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/adamretter/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamretter/rocksdb/merges","archive_url":"https://api.github.com/repos/adamretter/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamretter/rocksdb/downloads","issues_url":"https://api.github.com/repos/adamretter/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/adamretter/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/adamretter/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/adamretter/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamretter/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/adamretter/rocksdb/releases{/id}","created_at":"2014-08-03T15:38:02Z","updated_at":"2015-01-31T15:15:26Z","pushed_at":"2015-02-01T20:06:23Z","git_url":"git://github.com/adamretter/rocksdb.git","ssh_url":"git@github.com:adamretter/rocksdb.git","clone_url":"https://github.com/adamretter/rocksdb.git","svn_url":"https://github.com/adamretter/rocksdb","homepage":"http://rocksdb.org","size":43077,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"4a4e4279f0b17f960c9e504f018ec758cd5b9d0b","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments/{number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","created_at":"2012-11-30T06:16:18Z","updated_at":"2015-02-08T12:33:43Z","pushed_at":"2015-02-09T06:53:11Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":57248,"stargazers_count":3072,"watchers_count":3072,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":567,"mirror_url":null,"open_issues_count":32,"forks":567,"open_issues":32,"watchers":3072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/483"},"html":{"href":"https://github.com/facebook/rocksdb/pull/483"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/483"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/f33f3955eee379b29fda02dac1d30ba628669d67"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"yhchiang","id":6447975,"avatar_url":"https://avatars.githubusercontent.com/u/6447975?v=3","gravatar_id":"","url":"https://api.github.com/users/yhchiang","html_url":"https://github.com/yhchiang","followers_url":"https://api.github.com/users/yhchiang/followers","following_url":"https://api.github.com/users/yhchiang/following{/other_user}","gists_url":"https://api.github.com/users/yhchiang/gists{/gist_id}","starred_url":"https://api.github.com/users/yhchiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhchiang/subscriptions","organizations_url":"https://api.github.com/users/yhchiang/orgs","repos_url":"https://api.github.com/users/yhchiang/repos","events_url":"https://api.github.com/users/yhchiang/events{/privacy}","received_events_url":"https://api.github.com/users/yhchiang/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":7,"additions":415,"deletions":428,"changed_files":124}}