{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/23963904","id":23963904,"diff_hunk":"@@ -613,19 +613,76 @@\n     };\n \n     var deviceInfoQuery = {\n-      'deviceinfo.update_channel': 'unknown',\n-      'deviceinfo.platform_version': 'unknown',\n+      'developer.menu.enabled': false, // If true, data is probably an outlier\n+      'deviceinfo.hardware': 'unknown',\n+      'deviceinfo.os': 'unknown',\n       'deviceinfo.platform_build_id': 'unknown',\n-      'developer.menu.enabled': false // If true, data is probably an outlier\n+      'deviceinfo.platform_version': 'unknown',\n+      'deviceinfo.product_model': 'unknown',\n+      'deviceinfo.software': 'unknown',\n+      'deviceinfo.update_channel': 'unknown'\n     };\n \n     // Query the settings db to get some more device-specific information\n-    AUM.getSettings(deviceInfoQuery, function(deviceinfo) {\n-      data.deviceinfo = deviceinfo;\n+    AUM.getSettings(deviceInfoQuery, function(deviceInfo) {\n+      data.deviceinfo = deviceInfo;\n+      data.simInfo = getSIMInfo();","path":"apps/system/js/app_usage_metrics.js","position":58,"original_position":58,"commit_id":"d31bf06a89b031f48d46ac3bbbe906ec51df2891","original_commit_id":"d31bf06a89b031f48d46ac3bbbe906ec51df2891","user":{"login":"davidflanagan","id":516914,"avatar_url":"https://avatars.githubusercontent.com/u/516914?v=3","gravatar_id":"","url":"https://api.github.com/users/davidflanagan","html_url":"https://github.com/davidflanagan","followers_url":"https://api.github.com/users/davidflanagan/followers","following_url":"https://api.github.com/users/davidflanagan/following{/other_user}","gists_url":"https://api.github.com/users/davidflanagan/gists{/gist_id}","starred_url":"https://api.github.com/users/davidflanagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidflanagan/subscriptions","organizations_url":"https://api.github.com/users/davidflanagan/orgs","repos_url":"https://api.github.com/users/davidflanagan/repos","events_url":"https://api.github.com/users/davidflanagan/events{/privacy}","received_events_url":"https://api.github.com/users/davidflanagan/received_events","type":"User","site_admin":false},"body":"Your data object here has one property with lowercase info and one with capitalized Info.  Did you mean to type data.deviceInfo here?","created_at":"2015-02-02T22:13:01Z","updated_at":"2015-02-02T22:13:01Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/27286#discussion_r23963904","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27286","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/23963904"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27286#discussion_r23963904"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27286"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27286","id":27138288,"html_url":"https://github.com/mozilla-b2g/gaia/pull/27286","diff_url":"https://github.com/mozilla-b2g/gaia/pull/27286.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/27286.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27286","number":27286,"state":"open","locked":false,"title":"Bug 1109422: [AppUsageMetrics] Updates to support monthly active users","user":{"login":"marshall","id":29191,"avatar_url":"https://avatars.githubusercontent.com/u/29191?v=3","gravatar_id":"","url":"https://api.github.com/users/marshall","html_url":"https://github.com/marshall","followers_url":"https://api.github.com/users/marshall/followers","following_url":"https://api.github.com/users/marshall/following{/other_user}","gists_url":"https://api.github.com/users/marshall/gists{/gist_id}","starred_url":"https://api.github.com/users/marshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshall/subscriptions","organizations_url":"https://api.github.com/users/marshall/orgs","repos_url":"https://api.github.com/users/marshall/repos","events_url":"https://api.github.com/users/marshall/events{/privacy}","received_events_url":"https://api.github.com/users/marshall/received_events","type":"User","site_admin":false},"body":"Updates made to support monthly active users calculation for the Metrics team:\r\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1109422","created_at":"2015-01-09T23:45:05Z","updated_at":"2015-02-02T22:13:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30def996aedafc384fc04579f9e75cf34f388ab3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27286/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27286/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27286/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/d31bf06a89b031f48d46ac3bbbe906ec51df2891","head":{"label":"marshall:bug1109422_mauChanges","ref":"bug1109422_mauChanges","sha":"d31bf06a89b031f48d46ac3bbbe906ec51df2891","user":{"login":"marshall","id":29191,"avatar_url":"https://avatars.githubusercontent.com/u/29191?v=3","gravatar_id":"","url":"https://api.github.com/users/marshall","html_url":"https://github.com/marshall","followers_url":"https://api.github.com/users/marshall/followers","following_url":"https://api.github.com/users/marshall/following{/other_user}","gists_url":"https://api.github.com/users/marshall/gists{/gist_id}","starred_url":"https://api.github.com/users/marshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshall/subscriptions","organizations_url":"https://api.github.com/users/marshall/orgs","repos_url":"https://api.github.com/users/marshall/repos","events_url":"https://api.github.com/users/marshall/events{/privacy}","received_events_url":"https://api.github.com/users/marshall/received_events","type":"User","site_admin":false},"repo":{"id":4587247,"name":"gaia","full_name":"marshall/gaia","owner":{"login":"marshall","id":29191,"avatar_url":"https://avatars.githubusercontent.com/u/29191?v=3","gravatar_id":"","url":"https://api.github.com/users/marshall","html_url":"https://github.com/marshall","followers_url":"https://api.github.com/users/marshall/followers","following_url":"https://api.github.com/users/marshall/following{/other_user}","gists_url":"https://api.github.com/users/marshall/gists{/gist_id}","starred_url":"https://api.github.com/users/marshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshall/subscriptions","organizations_url":"https://api.github.com/users/marshall/orgs","repos_url":"https://api.github.com/users/marshall/repos","events_url":"https://api.github.com/users/marshall/events{/privacy}","received_events_url":"https://api.github.com/users/marshall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marshall/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/marshall/gaia","forks_url":"https://api.github.com/repos/marshall/gaia/forks","keys_url":"https://api.github.com/repos/marshall/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marshall/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marshall/gaia/teams","hooks_url":"https://api.github.com/repos/marshall/gaia/hooks","issue_events_url":"https://api.github.com/repos/marshall/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/marshall/gaia/events","assignees_url":"https://api.github.com/repos/marshall/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/marshall/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/marshall/gaia/tags","blobs_url":"https://api.github.com/repos/marshall/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marshall/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marshall/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/marshall/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marshall/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/marshall/gaia/languages","stargazers_url":"https://api.github.com/repos/marshall/gaia/stargazers","contributors_url":"https://api.github.com/repos/marshall/gaia/contributors","subscribers_url":"https://api.github.com/repos/marshall/gaia/subscribers","subscription_url":"https://api.github.com/repos/marshall/gaia/subscription","commits_url":"https://api.github.com/repos/marshall/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/marshall/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/marshall/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/marshall/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/marshall/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/marshall/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marshall/gaia/merges","archive_url":"https://api.github.com/repos/marshall/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marshall/gaia/downloads","issues_url":"https://api.github.com/repos/marshall/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/marshall/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/marshall/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/marshall/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marshall/gaia/labels{/name}","releases_url":"https://api.github.com/repos/marshall/gaia/releases{/id}","created_at":"2012-06-07T15:59:58Z","updated_at":"2015-01-27T17:36:01Z","pushed_at":"2015-01-28T18:39:10Z","git_url":"git://github.com/marshall/gaia.git","ssh_url":"git@github.com:marshall/gaia.git","clone_url":"https://github.com/marshall/gaia.git","svn_url":"https://github.com/marshall/gaia","homepage":"https://wiki.mozilla.org/B2G","size":866954,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"1d53fb07984298253aad64bfa4236b7167ee3d4d","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-02-02T19:50:21Z","pushed_at":"2015-02-02T19:50:21Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1395206,"stargazers_count":1865,"watchers_count":1865,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2189,"mirror_url":null,"open_issues_count":849,"forks":2189,"open_issues":849,"watchers":1865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27286"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27286"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27286"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27286/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27286/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27286/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/d31bf06a89b031f48d46ac3bbbe906ec51df2891"}}}}