{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/27947968","id":27947968,"diff_hunk":"@@ -10,7 +10,10 @@ angular.module('ui.bootstrap.progressbar', [])\n         animate = angular.isDefined($attrs.animate) ? $scope.$parent.$eval($attrs.animate) : progressConfig.animate;\n \n     this.bars = [];\n-    $scope.max = angular.isDefined($scope.max) ? $scope.max : progressConfig.max;\n+\n+    if (!angular.isDefined($attrs.max)) {","path":"src/progressbar/progressbar.js","position":6,"original_position":6,"commit_id":"74d7542710b6a53a5bec74e2a9be014686a67e8a","original_commit_id":"74d7542710b6a53a5bec74e2a9be014686a67e8a","user":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"body":"Should be able to just do `if ($attrs.max) {` since the only way it can be falsey (but defined) is if it's set via `max=\"\"` and that's invalid.","created_at":"2015-04-08T07:24:50Z","updated_at":"2015-04-08T07:24:50Z","html_url":"https://github.com/angular-ui/bootstrap/pull/2543#discussion_r27947968","pull_request_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2543","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/27947968"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/2543#discussion_r27947968"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2543"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2543","id":19313070,"html_url":"https://github.com/angular-ui/bootstrap/pull/2543","diff_url":"https://github.com/angular-ui/bootstrap/pull/2543.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/2543.patch","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/2543","number":2543,"state":"open","locked":false,"title":"feat(progressbar): respond to changes in max dynamically","user":{"login":"coojam","id":8351997,"avatar_url":"https://avatars.githubusercontent.com/u/8351997?v=3","gravatar_id":"","url":"https://api.github.com/users/coojam","html_url":"https://github.com/coojam","followers_url":"https://api.github.com/users/coojam/followers","following_url":"https://api.github.com/users/coojam/following{/other_user}","gists_url":"https://api.github.com/users/coojam/gists{/gist_id}","starred_url":"https://api.github.com/users/coojam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coojam/subscriptions","organizations_url":"https://api.github.com/users/coojam/orgs","repos_url":"https://api.github.com/users/coojam/repos","events_url":"https://api.github.com/users/coojam/events{/privacy}","received_events_url":"https://api.github.com/users/coojam/received_events","type":"User","site_admin":false},"body":"We have a use case where the max of the progress bar should change dynamically so this pull request enables that behaviour.","created_at":"2014-08-04T22:53:58Z","updated_at":"2015-04-08T07:24:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3eca1c7d60bf90973a8d0f1563d4c0ca45dc5999","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/20","html_url":"https://github.com/angular-ui/bootstrap/milestones/0.13.1","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/20/labels","id":1040683,"number":20,"title":"0.13.1","description":"Performance tweaks and fixes for 0.13 .","creator":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":1,"state":"open","created_at":"2015-03-26T20:06:14Z","updated_at":"2015-04-08T02:50:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2543/commits","review_comments_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2543/comments","review_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/2543/comments","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/74d7542710b6a53a5bec74e2a9be014686a67e8a","head":{"label":"coojam:master","ref":"master","sha":"74d7542710b6a53a5bec74e2a9be014686a67e8a","user":{"login":"coojam","id":8351997,"avatar_url":"https://avatars.githubusercontent.com/u/8351997?v=3","gravatar_id":"","url":"https://api.github.com/users/coojam","html_url":"https://github.com/coojam","followers_url":"https://api.github.com/users/coojam/followers","following_url":"https://api.github.com/users/coojam/following{/other_user}","gists_url":"https://api.github.com/users/coojam/gists{/gist_id}","starred_url":"https://api.github.com/users/coojam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coojam/subscriptions","organizations_url":"https://api.github.com/users/coojam/orgs","repos_url":"https://api.github.com/users/coojam/repos","events_url":"https://api.github.com/users/coojam/events{/privacy}","received_events_url":"https://api.github.com/users/coojam/received_events","type":"User","site_admin":false},"repo":{"id":22605650,"name":"bootstrap","full_name":"coojam/bootstrap","owner":{"login":"coojam","id":8351997,"avatar_url":"https://avatars.githubusercontent.com/u/8351997?v=3","gravatar_id":"","url":"https://api.github.com/users/coojam","html_url":"https://github.com/coojam","followers_url":"https://api.github.com/users/coojam/followers","following_url":"https://api.github.com/users/coojam/following{/other_user}","gists_url":"https://api.github.com/users/coojam/gists{/gist_id}","starred_url":"https://api.github.com/users/coojam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coojam/subscriptions","organizations_url":"https://api.github.com/users/coojam/orgs","repos_url":"https://api.github.com/users/coojam/repos","events_url":"https://api.github.com/users/coojam/events{/privacy}","received_events_url":"https://api.github.com/users/coojam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coojam/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped!), no 3rd party JS dependencies (jQuery, bootstrap JS) required!","fork":true,"url":"https://api.github.com/repos/coojam/bootstrap","forks_url":"https://api.github.com/repos/coojam/bootstrap/forks","keys_url":"https://api.github.com/repos/coojam/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coojam/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coojam/bootstrap/teams","hooks_url":"https://api.github.com/repos/coojam/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/coojam/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/coojam/bootstrap/events","assignees_url":"https://api.github.com/repos/coojam/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/coojam/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/coojam/bootstrap/tags","blobs_url":"https://api.github.com/repos/coojam/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coojam/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coojam/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/coojam/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coojam/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/coojam/bootstrap/languages","stargazers_url":"https://api.github.com/repos/coojam/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/coojam/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/coojam/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/coojam/bootstrap/subscription","commits_url":"https://api.github.com/repos/coojam/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/coojam/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/coojam/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/coojam/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/coojam/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/coojam/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coojam/bootstrap/merges","archive_url":"https://api.github.com/repos/coojam/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coojam/bootstrap/downloads","issues_url":"https://api.github.com/repos/coojam/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/coojam/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/coojam/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/coojam/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coojam/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/coojam/bootstrap/releases{/id}","created_at":"2014-08-04T13:45:23Z","updated_at":"2015-04-08T02:48:17Z","pushed_at":"2015-04-08T02:48:14Z","git_url":"git://github.com/coojam/bootstrap.git","ssh_url":"git@github.com:coojam/bootstrap.git","clone_url":"https://github.com/coojam/bootstrap.git","svn_url":"https://github.com/coojam/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":3918,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"e31fcf0fcb06580064d1e6375dbedb69f1c95f25","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6094683,"name":"bootstrap","full_name":"angular-ui/bootstrap","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":false,"url":"https://api.github.com/repos/angular-ui/bootstrap","forks_url":"https://api.github.com/repos/angular-ui/bootstrap/forks","keys_url":"https://api.github.com/repos/angular-ui/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/bootstrap/teams","hooks_url":"https://api.github.com/repos/angular-ui/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/bootstrap/events","assignees_url":"https://api.github.com/repos/angular-ui/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/bootstrap/tags","blobs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/bootstrap/languages","stargazers_url":"https://api.github.com/repos/angular-ui/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/bootstrap/subscription","commits_url":"https://api.github.com/repos/angular-ui/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/bootstrap/merges","archive_url":"https://api.github.com/repos/angular-ui/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/bootstrap/downloads","issues_url":"https://api.github.com/repos/angular-ui/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/bootstrap/releases{/id}","created_at":"2012-10-05T18:27:01Z","updated_at":"2015-04-08T07:11:26Z","pushed_at":"2015-04-08T07:15:55Z","git_url":"git://github.com/angular-ui/bootstrap.git","ssh_url":"git@github.com:angular-ui/bootstrap.git","clone_url":"https://github.com/angular-ui/bootstrap.git","svn_url":"https://github.com/angular-ui/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":20101,"stargazers_count":8396,"watchers_count":8396,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4450,"mirror_url":null,"open_issues_count":601,"forks":4450,"open_issues":601,"watchers":8396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2543"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/2543"},"issue":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/2543"},"comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/2543/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2543/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/2543/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/bootstrap/statuses/74d7542710b6a53a5bec74e2a9be014686a67e8a"}}}}