{"action":"closed","number":566,"pull_request":{"url":"https://api.github.com/repos/ScottLogic/d3fc/pulls/566","id":46034521,"html_url":"https://github.com/ScottLogic/d3fc/pull/566","diff_url":"https://github.com/ScottLogic/d3fc/pull/566.diff","patch_url":"https://github.com/ScottLogic/d3fc/pull/566.patch","issue_url":"https://api.github.com/repos/ScottLogic/d3fc/issues/566","number":566,"state":"closed","locked":false,"title":"Cartesian chart transitions","user":{"login":"ColinEberhardt","id":1098110,"avatar_url":"https://avatars.githubusercontent.com/u/1098110?v=3","gravatar_id":"","url":"https://api.github.com/users/ColinEberhardt","html_url":"https://github.com/ColinEberhardt","followers_url":"https://api.github.com/users/ColinEberhardt/followers","following_url":"https://api.github.com/users/ColinEberhardt/following{/other_user}","gists_url":"https://api.github.com/users/ColinEberhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinEberhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinEberhardt/subscriptions","organizations_url":"https://api.github.com/users/ColinEberhardt/orgs","repos_url":"https://api.github.com/users/ColinEberhardt/repos","events_url":"https://api.github.com/users/ColinEberhardt/events{/privacy}","received_events_url":"https://api.github.com/users/ColinEberhardt/received_events","type":"User","site_admin":false},"body":"Fixes #563 \r\n\r\nAfter a bit of digging I found the underlying problem, our `layout` component is exposed on selections but not transitions. This means that if you call a component that uses `layout` from a transition, it fails.\r\n\r\nThis change adds `layout` to transitions. Also, transitions do not provide a 'getter' for the `attr` method, which is why this `layout` now drops down to the underlying DOM API.\r\n\r\n","created_at":"2015-09-25T17:01:57Z","updated_at":"2015-09-26T09:01:19Z","closed_at":"2015-09-26T09:01:19Z","merged_at":"2015-09-26T09:01:19Z","merge_commit_sha":"c182670e0f81ab172376dd94b652f553dd598f8d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ScottLogic/d3fc/pulls/566/commits","review_comments_url":"https://api.github.com/repos/ScottLogic/d3fc/pulls/566/comments","review_comment_url":"https://api.github.com/repos/ScottLogic/d3fc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ScottLogic/d3fc/issues/566/comments","statuses_url":"https://api.github.com/repos/ScottLogic/d3fc/statuses/ebf1dd7c4c4ca0717d7064f8b2d5e3fe68044914","head":{"label":"ColinEberhardt:cartesian-chart-transitions","ref":"cartesian-chart-transitions","sha":"ebf1dd7c4c4ca0717d7064f8b2d5e3fe68044914","user":{"login":"ColinEberhardt","id":1098110,"avatar_url":"https://avatars.githubusercontent.com/u/1098110?v=3","gravatar_id":"","url":"https://api.github.com/users/ColinEberhardt","html_url":"https://github.com/ColinEberhardt","followers_url":"https://api.github.com/users/ColinEberhardt/followers","following_url":"https://api.github.com/users/ColinEberhardt/following{/other_user}","gists_url":"https://api.github.com/users/ColinEberhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinEberhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinEberhardt/subscriptions","organizations_url":"https://api.github.com/users/ColinEberhardt/orgs","repos_url":"https://api.github.com/users/ColinEberhardt/repos","events_url":"https://api.github.com/users/ColinEberhardt/events{/privacy}","received_events_url":"https://api.github.com/users/ColinEberhardt/received_events","type":"User","site_admin":false},"repo":{"id":26486000,"name":"d3-financial-components","full_name":"ColinEberhardt/d3-financial-components","owner":{"login":"ColinEberhardt","id":1098110,"avatar_url":"https://avatars.githubusercontent.com/u/1098110?v=3","gravatar_id":"","url":"https://api.github.com/users/ColinEberhardt","html_url":"https://github.com/ColinEberhardt","followers_url":"https://api.github.com/users/ColinEberhardt/followers","following_url":"https://api.github.com/users/ColinEberhardt/following{/other_user}","gists_url":"https://api.github.com/users/ColinEberhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinEberhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinEberhardt/subscriptions","organizations_url":"https://api.github.com/users/ColinEberhardt/orgs","repos_url":"https://api.github.com/users/ColinEberhardt/repos","events_url":"https://api.github.com/users/ColinEberhardt/events{/privacy}","received_events_url":"https://api.github.com/users/ColinEberhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ColinEberhardt/d3-financial-components","description":"A set of re-useable components for building financial charts with D3","fork":true,"url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components","forks_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/forks","keys_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/teams","hooks_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/hooks","issue_events_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/issues/events{/number}","events_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/events","assignees_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/assignees{/user}","branches_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/branches{/branch}","tags_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/tags","blobs_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/statuses/{sha}","languages_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/languages","stargazers_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/stargazers","contributors_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/contributors","subscribers_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/subscribers","subscription_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/subscription","commits_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/contents/{+path}","compare_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/merges","archive_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/downloads","issues_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/issues{/number}","pulls_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/pulls{/number}","milestones_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/milestones{/number}","notifications_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/labels{/name}","releases_url":"https://api.github.com/repos/ColinEberhardt/d3-financial-components/releases{/id}","created_at":"2014-11-11T13:25:33Z","updated_at":"2015-05-07T07:47:58Z","pushed_at":"2015-09-25T16:57:52Z","git_url":"git://github.com/ColinEberhardt/d3-financial-components.git","ssh_url":"git@github.com:ColinEberhardt/d3-financial-components.git","clone_url":"https://github.com/ColinEberhardt/d3-financial-components.git","svn_url":"https://github.com/ColinEberhardt/d3-financial-components","homepage":"","size":4387,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"ScottLogic:master","ref":"master","sha":"7563eb15c238c00e3defac810238885b6c56438d","user":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":24850617,"name":"d3fc","full_name":"ScottLogic/d3fc","owner":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScottLogic/d3fc","description":"A collection of components that make it easy to build interactive charts with D3","fork":false,"url":"https://api.github.com/repos/ScottLogic/d3fc","forks_url":"https://api.github.com/repos/ScottLogic/d3fc/forks","keys_url":"https://api.github.com/repos/ScottLogic/d3fc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottLogic/d3fc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottLogic/d3fc/teams","hooks_url":"https://api.github.com/repos/ScottLogic/d3fc/hooks","issue_events_url":"https://api.github.com/repos/ScottLogic/d3fc/issues/events{/number}","events_url":"https://api.github.com/repos/ScottLogic/d3fc/events","assignees_url":"https://api.github.com/repos/ScottLogic/d3fc/assignees{/user}","branches_url":"https://api.github.com/repos/ScottLogic/d3fc/branches{/branch}","tags_url":"https://api.github.com/repos/ScottLogic/d3fc/tags","blobs_url":"https://api.github.com/repos/ScottLogic/d3fc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottLogic/d3fc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottLogic/d3fc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottLogic/d3fc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottLogic/d3fc/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottLogic/d3fc/languages","stargazers_url":"https://api.github.com/repos/ScottLogic/d3fc/stargazers","contributors_url":"https://api.github.com/repos/ScottLogic/d3fc/contributors","subscribers_url":"https://api.github.com/repos/ScottLogic/d3fc/subscribers","subscription_url":"https://api.github.com/repos/ScottLogic/d3fc/subscription","commits_url":"https://api.github.com/repos/ScottLogic/d3fc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottLogic/d3fc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottLogic/d3fc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottLogic/d3fc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScottLogic/d3fc/contents/{+path}","compare_url":"https://api.github.com/repos/ScottLogic/d3fc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottLogic/d3fc/merges","archive_url":"https://api.github.com/repos/ScottLogic/d3fc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottLogic/d3fc/downloads","issues_url":"https://api.github.com/repos/ScottLogic/d3fc/issues{/number}","pulls_url":"https://api.github.com/repos/ScottLogic/d3fc/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottLogic/d3fc/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottLogic/d3fc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottLogic/d3fc/labels{/name}","releases_url":"https://api.github.com/repos/ScottLogic/d3fc/releases{/id}","created_at":"2014-10-06T15:03:11Z","updated_at":"2015-09-24T10:07:24Z","pushed_at":"2015-09-26T09:01:19Z","git_url":"git://github.com/ScottLogic/d3fc.git","ssh_url":"git@github.com:ScottLogic/d3fc.git","clone_url":"https://github.com/ScottLogic/d3fc.git","svn_url":"https://github.com/ScottLogic/d3fc","homepage":"http://d3fc.io/","size":6909,"stargazers_count":167,"watchers_count":167,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":46,"forks":23,"open_issues":46,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/d3fc/pulls/566"},"html":{"href":"https://github.com/ScottLogic/d3fc/pull/566"},"issue":{"href":"https://api.github.com/repos/ScottLogic/d3fc/issues/566"},"comments":{"href":"https://api.github.com/repos/ScottLogic/d3fc/issues/566/comments"},"review_comments":{"href":"https://api.github.com/repos/ScottLogic/d3fc/pulls/566/comments"},"review_comment":{"href":"https://api.github.com/repos/ScottLogic/d3fc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ScottLogic/d3fc/pulls/566/commits"},"statuses":{"href":"https://api.github.com/repos/ScottLogic/d3fc/statuses/ebf1dd7c4c4ca0717d7064f8b2d5e3fe68044914"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chrisprice","id":433457,"avatar_url":"https://avatars.githubusercontent.com/u/433457?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisprice","html_url":"https://github.com/chrisprice","followers_url":"https://api.github.com/users/chrisprice/followers","following_url":"https://api.github.com/users/chrisprice/following{/other_user}","gists_url":"https://api.github.com/users/chrisprice/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisprice/subscriptions","organizations_url":"https://api.github.com/users/chrisprice/orgs","repos_url":"https://api.github.com/users/chrisprice/repos","events_url":"https://api.github.com/users/chrisprice/events{/privacy}","received_events_url":"https://api.github.com/users/chrisprice/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":3,"additions":57,"deletions":82,"changed_files":3}}