{"action":"created","comment":{"url":"https://api.github.com/repos/terrestris/shogun2/pulls/comments/48154905","id":48154905,"diff_hunk":"@@ -46,9 +46,9 @@\n \n \t@ManyToMany\n \t@JoinTable(\n-\t\t\tname = \"TILEWMSLAYERDATASRC_LAYERNAME\",\n-\t\t\tjoinColumns = { @JoinColumn(name = \"TILEWMSLAYERDATASOURCE_ID\") },\n-\t\t\tinverseJoinColumns = { @JoinColumn(name = \"LAYERNAME_ID\") }\n+\t\tname = \"TILEWMSLAYERDATASRC_LAYERNAME\",","path":"src/shogun2-core/shogun2-model/src/main/java/de/terrestris/shogun2/model/layer/source/TileWmsLayerDataSource.java","position":7,"original_position":7,"commit_id":"57d6d99a0247706fe7a6babdd49a5ca58d93d89a","original_commit_id":"57d6d99a0247706fe7a6babdd49a5ca58d93d89a","user":{"login":"marcjansen","id":227934,"avatar_url":"https://avatars.githubusercontent.com/u/227934?v=3","gravatar_id":"","url":"https://api.github.com/users/marcjansen","html_url":"https://github.com/marcjansen","followers_url":"https://api.github.com/users/marcjansen/followers","following_url":"https://api.github.com/users/marcjansen/following{/other_user}","gists_url":"https://api.github.com/users/marcjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/marcjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcjansen/subscriptions","organizations_url":"https://api.github.com/users/marcjansen/orgs","repos_url":"https://api.github.com/users/marcjansen/repos","events_url":"https://api.github.com/users/marcjansen/events{/privacy}","received_events_url":"https://api.github.com/users/marcjansen/received_events","type":"User","site_admin":false},"body":"Why do you explicitly give a name here, but not everywhere else?","created_at":"2015-12-21T15:19:33Z","updated_at":"2015-12-21T15:19:33Z","html_url":"https://github.com/terrestris/shogun2/pull/100#discussion_r48154905","pull_request_url":"https://api.github.com/repos/terrestris/shogun2/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/terrestris/shogun2/pulls/comments/48154905"},"html":{"href":"https://github.com/terrestris/shogun2/pull/100#discussion_r48154905"},"pull_request":{"href":"https://api.github.com/repos/terrestris/shogun2/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/terrestris/shogun2/pulls/100","id":54263407,"html_url":"https://github.com/terrestris/shogun2/pull/100","diff_url":"https://github.com/terrestris/shogun2/pull/100.diff","patch_url":"https://github.com/terrestris/shogun2/pull/100.patch","issue_url":"https://api.github.com/repos/terrestris/shogun2/issues/100","number":100,"state":"open","locked":false,"title":"Introduce Hibernate naming strategies","user":{"login":"buehner","id":3939332,"avatar_url":"https://avatars.githubusercontent.com/u/3939332?v=3","gravatar_id":"","url":"https://api.github.com/users/buehner","html_url":"https://github.com/buehner","followers_url":"https://api.github.com/users/buehner/followers","following_url":"https://api.github.com/users/buehner/following{/other_user}","gists_url":"https://api.github.com/users/buehner/gists{/gist_id}","starred_url":"https://api.github.com/users/buehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buehner/subscriptions","organizations_url":"https://api.github.com/users/buehner/orgs","repos_url":"https://api.github.com/users/buehner/repos","events_url":"https://api.github.com/users/buehner/events{/privacy}","received_events_url":"https://api.github.com/users/buehner/received_events","type":"User","site_admin":false},"body":"Regarding #93 , this PR introduces a DDL naming strategy for SHOGun2:\r\n\r\nSince Hibernate 5, the naming strategy is split up in two parts:\r\n\r\n* *ImplicitNamingStrategy* - If an explicit naming configuration is given via `@Table` (or `@JoinTable`), this strategy will **NOT** be executed. Otherwise: Based on the class name, an implicit name for the entity will be created. In our case, this strategy will produce *plural forms* of the singular class name forms, e.g. `Application -> Applications`. \r\n* *PhysicalNamingStrategy* - This strategy will **always** be executed: Based on the result of the implicit naming strategy or an explicit naming configuration, this strategy will create a physical name for tables/schemas etc.  In our case, the implementation will\r\n  1. transform all entity names to **lower case**\r\n  2. **limit the length of an identifier** according to the given JDBC context (currently H2, Oracle and PostgreSQL are supported)\r\n\r\nAs a result of this implementation, a lot of `@Table` and `@JoinTable` annotations have been cleaned up. Even though, in case of most `@JoinTable`s the naming should still be done manually to avoid that the physical naming strategy cuts off the (implicitly) generated join table names (including `_`) in case of a limitation.\r\n\r\nTests are included!","created_at":"2015-12-21T14:45:08Z","updated_at":"2015-12-21T15:19:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b866387436fc09ae6d8c5faed094c6d17fad02f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/terrestris/shogun2/pulls/100/commits","review_comments_url":"https://api.github.com/repos/terrestris/shogun2/pulls/100/comments","review_comment_url":"https://api.github.com/repos/terrestris/shogun2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terrestris/shogun2/issues/100/comments","statuses_url":"https://api.github.com/repos/terrestris/shogun2/statuses/57d6d99a0247706fe7a6babdd49a5ca58d93d89a","head":{"label":"buehner:naming-strategy","ref":"naming-strategy","sha":"57d6d99a0247706fe7a6babdd49a5ca58d93d89a","user":{"login":"buehner","id":3939332,"avatar_url":"https://avatars.githubusercontent.com/u/3939332?v=3","gravatar_id":"","url":"https://api.github.com/users/buehner","html_url":"https://github.com/buehner","followers_url":"https://api.github.com/users/buehner/followers","following_url":"https://api.github.com/users/buehner/following{/other_user}","gists_url":"https://api.github.com/users/buehner/gists{/gist_id}","starred_url":"https://api.github.com/users/buehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buehner/subscriptions","organizations_url":"https://api.github.com/users/buehner/orgs","repos_url":"https://api.github.com/users/buehner/repos","events_url":"https://api.github.com/users/buehner/events{/privacy}","received_events_url":"https://api.github.com/users/buehner/received_events","type":"User","site_admin":false},"repo":{"id":19099580,"name":"shogun2","full_name":"buehner/shogun2","owner":{"login":"buehner","id":3939332,"avatar_url":"https://avatars.githubusercontent.com/u/3939332?v=3","gravatar_id":"","url":"https://api.github.com/users/buehner","html_url":"https://github.com/buehner","followers_url":"https://api.github.com/users/buehner/followers","following_url":"https://api.github.com/users/buehner/following{/other_user}","gists_url":"https://api.github.com/users/buehner/gists{/gist_id}","starred_url":"https://api.github.com/users/buehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buehner/subscriptions","organizations_url":"https://api.github.com/users/buehner/orgs","repos_url":"https://api.github.com/users/buehner/repos","events_url":"https://api.github.com/users/buehner/events{/privacy}","received_events_url":"https://api.github.com/users/buehner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/buehner/shogun2","description":"SHOGun2 is a Java based WebGIS framework.","fork":true,"url":"https://api.github.com/repos/buehner/shogun2","forks_url":"https://api.github.com/repos/buehner/shogun2/forks","keys_url":"https://api.github.com/repos/buehner/shogun2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buehner/shogun2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buehner/shogun2/teams","hooks_url":"https://api.github.com/repos/buehner/shogun2/hooks","issue_events_url":"https://api.github.com/repos/buehner/shogun2/issues/events{/number}","events_url":"https://api.github.com/repos/buehner/shogun2/events","assignees_url":"https://api.github.com/repos/buehner/shogun2/assignees{/user}","branches_url":"https://api.github.com/repos/buehner/shogun2/branches{/branch}","tags_url":"https://api.github.com/repos/buehner/shogun2/tags","blobs_url":"https://api.github.com/repos/buehner/shogun2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buehner/shogun2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buehner/shogun2/git/refs{/sha}","trees_url":"https://api.github.com/repos/buehner/shogun2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buehner/shogun2/statuses/{sha}","languages_url":"https://api.github.com/repos/buehner/shogun2/languages","stargazers_url":"https://api.github.com/repos/buehner/shogun2/stargazers","contributors_url":"https://api.github.com/repos/buehner/shogun2/contributors","subscribers_url":"https://api.github.com/repos/buehner/shogun2/subscribers","subscription_url":"https://api.github.com/repos/buehner/shogun2/subscription","commits_url":"https://api.github.com/repos/buehner/shogun2/commits{/sha}","git_commits_url":"https://api.github.com/repos/buehner/shogun2/git/commits{/sha}","comments_url":"https://api.github.com/repos/buehner/shogun2/comments{/number}","issue_comment_url":"https://api.github.com/repos/buehner/shogun2/issues/comments{/number}","contents_url":"https://api.github.com/repos/buehner/shogun2/contents/{+path}","compare_url":"https://api.github.com/repos/buehner/shogun2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buehner/shogun2/merges","archive_url":"https://api.github.com/repos/buehner/shogun2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buehner/shogun2/downloads","issues_url":"https://api.github.com/repos/buehner/shogun2/issues{/number}","pulls_url":"https://api.github.com/repos/buehner/shogun2/pulls{/number}","milestones_url":"https://api.github.com/repos/buehner/shogun2/milestones{/number}","notifications_url":"https://api.github.com/repos/buehner/shogun2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buehner/shogun2/labels{/name}","releases_url":"https://api.github.com/repos/buehner/shogun2/releases{/id}","created_at":"2014-04-24T07:24:56Z","updated_at":"2015-01-11T12:25:19Z","pushed_at":"2015-12-21T14:54:23Z","git_url":"git://github.com/buehner/shogun2.git","ssh_url":"git@github.com:buehner/shogun2.git","clone_url":"https://github.com/buehner/shogun2.git","svn_url":"https://github.com/buehner/shogun2","homepage":null,"size":665,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terrestris:master","ref":"master","sha":"01e8dcd3dac3f8d889eeb428c79f6700885c1823","user":{"login":"terrestris","id":1510416,"avatar_url":"https://avatars.githubusercontent.com/u/1510416?v=3","gravatar_id":"","url":"https://api.github.com/users/terrestris","html_url":"https://github.com/terrestris","followers_url":"https://api.github.com/users/terrestris/followers","following_url":"https://api.github.com/users/terrestris/following{/other_user}","gists_url":"https://api.github.com/users/terrestris/gists{/gist_id}","starred_url":"https://api.github.com/users/terrestris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrestris/subscriptions","organizations_url":"https://api.github.com/users/terrestris/orgs","repos_url":"https://api.github.com/users/terrestris/repos","events_url":"https://api.github.com/users/terrestris/events{/privacy}","received_events_url":"https://api.github.com/users/terrestris/received_events","type":"Organization","site_admin":false},"repo":{"id":15997656,"name":"shogun2","full_name":"terrestris/shogun2","owner":{"login":"terrestris","id":1510416,"avatar_url":"https://avatars.githubusercontent.com/u/1510416?v=3","gravatar_id":"","url":"https://api.github.com/users/terrestris","html_url":"https://github.com/terrestris","followers_url":"https://api.github.com/users/terrestris/followers","following_url":"https://api.github.com/users/terrestris/following{/other_user}","gists_url":"https://api.github.com/users/terrestris/gists{/gist_id}","starred_url":"https://api.github.com/users/terrestris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrestris/subscriptions","organizations_url":"https://api.github.com/users/terrestris/orgs","repos_url":"https://api.github.com/users/terrestris/repos","events_url":"https://api.github.com/users/terrestris/events{/privacy}","received_events_url":"https://api.github.com/users/terrestris/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terrestris/shogun2","description":"SHOGun2 is a Java based WebGIS framework.","fork":false,"url":"https://api.github.com/repos/terrestris/shogun2","forks_url":"https://api.github.com/repos/terrestris/shogun2/forks","keys_url":"https://api.github.com/repos/terrestris/shogun2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terrestris/shogun2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terrestris/shogun2/teams","hooks_url":"https://api.github.com/repos/terrestris/shogun2/hooks","issue_events_url":"https://api.github.com/repos/terrestris/shogun2/issues/events{/number}","events_url":"https://api.github.com/repos/terrestris/shogun2/events","assignees_url":"https://api.github.com/repos/terrestris/shogun2/assignees{/user}","branches_url":"https://api.github.com/repos/terrestris/shogun2/branches{/branch}","tags_url":"https://api.github.com/repos/terrestris/shogun2/tags","blobs_url":"https://api.github.com/repos/terrestris/shogun2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terrestris/shogun2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terrestris/shogun2/git/refs{/sha}","trees_url":"https://api.github.com/repos/terrestris/shogun2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terrestris/shogun2/statuses/{sha}","languages_url":"https://api.github.com/repos/terrestris/shogun2/languages","stargazers_url":"https://api.github.com/repos/terrestris/shogun2/stargazers","contributors_url":"https://api.github.com/repos/terrestris/shogun2/contributors","subscribers_url":"https://api.github.com/repos/terrestris/shogun2/subscribers","subscription_url":"https://api.github.com/repos/terrestris/shogun2/subscription","commits_url":"https://api.github.com/repos/terrestris/shogun2/commits{/sha}","git_commits_url":"https://api.github.com/repos/terrestris/shogun2/git/commits{/sha}","comments_url":"https://api.github.com/repos/terrestris/shogun2/comments{/number}","issue_comment_url":"https://api.github.com/repos/terrestris/shogun2/issues/comments{/number}","contents_url":"https://api.github.com/repos/terrestris/shogun2/contents/{+path}","compare_url":"https://api.github.com/repos/terrestris/shogun2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terrestris/shogun2/merges","archive_url":"https://api.github.com/repos/terrestris/shogun2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terrestris/shogun2/downloads","issues_url":"https://api.github.com/repos/terrestris/shogun2/issues{/number}","pulls_url":"https://api.github.com/repos/terrestris/shogun2/pulls{/number}","milestones_url":"https://api.github.com/repos/terrestris/shogun2/milestones{/number}","notifications_url":"https://api.github.com/repos/terrestris/shogun2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terrestris/shogun2/labels{/name}","releases_url":"https://api.github.com/repos/terrestris/shogun2/releases{/id}","created_at":"2014-01-17T11:10:10Z","updated_at":"2015-12-01T10:24:10Z","pushed_at":"2015-12-21T14:54:24Z","git_url":"git://github.com/terrestris/shogun2.git","ssh_url":"git@github.com:terrestris/shogun2.git","clone_url":"https://github.com/terrestris/shogun2.git","svn_url":"https://github.com/terrestris/shogun2","homepage":null,"size":711,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terrestris/shogun2/pulls/100"},"html":{"href":"https://github.com/terrestris/shogun2/pull/100"},"issue":{"href":"https://api.github.com/repos/terrestris/shogun2/issues/100"},"comments":{"href":"https://api.github.com/repos/terrestris/shogun2/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/terrestris/shogun2/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/terrestris/shogun2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terrestris/shogun2/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/terrestris/shogun2/statuses/57d6d99a0247706fe7a6babdd49a5ca58d93d89a"}}}}