{"action":"closed","number":2541,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/2541","id":40950244,"html_url":"https://github.com/dotnet/corefx/pull/2541","diff_url":"https://github.com/dotnet/corefx/pull/2541.diff","patch_url":"https://github.com/dotnet/corefx/pull/2541.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/2541","number":2541,"state":"closed","locked":false,"title":"Serialization time zone fixes","user":{"login":"mj1856","id":1396388,"avatar_url":"https://avatars.githubusercontent.com/u/1396388?v=3","gravatar_id":"","url":"https://api.github.com/users/mj1856","html_url":"https://github.com/mj1856","followers_url":"https://api.github.com/users/mj1856/followers","following_url":"https://api.github.com/users/mj1856/following{/other_user}","gists_url":"https://api.github.com/users/mj1856/gists{/gist_id}","starred_url":"https://api.github.com/users/mj1856/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mj1856/subscriptions","organizations_url":"https://api.github.com/users/mj1856/orgs","repos_url":"https://api.github.com/users/mj1856/repos","events_url":"https://api.github.com/users/mj1856/events{/privacy}","received_events_url":"https://api.github.com/users/mj1856/received_events","type":"User","site_admin":false},"body":"Similar to #2496, several other tests will fail when running in southern-hemisphere time zones that use daylight saving time.   The tests pick a date in January, but always use the standard offset.  Since southern hemisphere time zones are in DST during this period, the standard offset is not the correct one to use.\r\n\r\nCalling `TimeZoneInfo.BaseUtcOffset` should always be avoided.  Use `TimeZoneInfo.GetUtcOffset` instead.\r\n\r\nAdditionally, unit tests that compare `DateTimeOffset` values should always test the value and the offset separately, due to the way that the equality comparison normalizes to UTC.   This was masking errors in the System.Runtime.Serialization.Xml tests.","created_at":"2015-07-27T21:14:42Z","updated_at":"2015-07-30T14:52:44Z","closed_at":"2015-07-30T14:52:42Z","merged_at":"2015-07-30T14:52:42Z","merge_commit_sha":"0191387cb9dfd1fb607a8648fd9842ab0abe30f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/2541/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/2541/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/2541/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/a5d438442a1778f0c927b1d05cea4843c88161b1","head":{"label":"mj1856:serialization-timezone-fixes","ref":"serialization-timezone-fixes","sha":"a5d438442a1778f0c927b1d05cea4843c88161b1","user":{"login":"mj1856","id":1396388,"avatar_url":"https://avatars.githubusercontent.com/u/1396388?v=3","gravatar_id":"","url":"https://api.github.com/users/mj1856","html_url":"https://github.com/mj1856","followers_url":"https://api.github.com/users/mj1856/followers","following_url":"https://api.github.com/users/mj1856/following{/other_user}","gists_url":"https://api.github.com/users/mj1856/gists{/gist_id}","starred_url":"https://api.github.com/users/mj1856/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mj1856/subscriptions","organizations_url":"https://api.github.com/users/mj1856/orgs","repos_url":"https://api.github.com/users/mj1856/repos","events_url":"https://api.github.com/users/mj1856/events{/privacy}","received_events_url":"https://api.github.com/users/mj1856/received_events","type":"User","site_admin":false},"repo":{"id":26547287,"name":"corefx","full_name":"mj1856/corefx","owner":{"login":"mj1856","id":1396388,"avatar_url":"https://avatars.githubusercontent.com/u/1396388?v=3","gravatar_id":"","url":"https://api.github.com/users/mj1856","html_url":"https://github.com/mj1856","followers_url":"https://api.github.com/users/mj1856/followers","following_url":"https://api.github.com/users/mj1856/following{/other_user}","gists_url":"https://api.github.com/users/mj1856/gists{/gist_id}","starred_url":"https://api.github.com/users/mj1856/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mj1856/subscriptions","organizations_url":"https://api.github.com/users/mj1856/orgs","repos_url":"https://api.github.com/users/mj1856/repos","events_url":"https://api.github.com/users/mj1856/events{/privacy}","received_events_url":"https://api.github.com/users/mj1856/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mj1856/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/mj1856/corefx","forks_url":"https://api.github.com/repos/mj1856/corefx/forks","keys_url":"https://api.github.com/repos/mj1856/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mj1856/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mj1856/corefx/teams","hooks_url":"https://api.github.com/repos/mj1856/corefx/hooks","issue_events_url":"https://api.github.com/repos/mj1856/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/mj1856/corefx/events","assignees_url":"https://api.github.com/repos/mj1856/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/mj1856/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/mj1856/corefx/tags","blobs_url":"https://api.github.com/repos/mj1856/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mj1856/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mj1856/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mj1856/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mj1856/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/mj1856/corefx/languages","stargazers_url":"https://api.github.com/repos/mj1856/corefx/stargazers","contributors_url":"https://api.github.com/repos/mj1856/corefx/contributors","subscribers_url":"https://api.github.com/repos/mj1856/corefx/subscribers","subscription_url":"https://api.github.com/repos/mj1856/corefx/subscription","commits_url":"https://api.github.com/repos/mj1856/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mj1856/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mj1856/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mj1856/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mj1856/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/mj1856/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mj1856/corefx/merges","archive_url":"https://api.github.com/repos/mj1856/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mj1856/corefx/downloads","issues_url":"https://api.github.com/repos/mj1856/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/mj1856/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/mj1856/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/mj1856/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mj1856/corefx/labels{/name}","releases_url":"https://api.github.com/repos/mj1856/corefx/releases{/id}","created_at":"2014-11-12T17:23:42Z","updated_at":"2015-03-18T04:14:35Z","pushed_at":"2015-07-27T21:14:22Z","git_url":"git://github.com/mj1856/corefx.git","ssh_url":"git@github.com:mj1856/corefx.git","clone_url":"https://github.com/mj1856/corefx.git","svn_url":"https://github.com/mj1856/corefx","homepage":"","size":25185,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"196c8368b08b813bd768785a91e030ecc0be3f4f","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-07-30T13:48:19Z","pushed_at":"2015-07-30T14:52:43Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":56033,"stargazers_count":8144,"watchers_count":8144,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1702,"mirror_url":null,"open_issues_count":513,"forks":1702,"open_issues":513,"watchers":8144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2541"},"html":{"href":"https://github.com/dotnet/corefx/pull/2541"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2541"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2541/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2541/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2541/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/a5d438442a1778f0c927b1d05cea4843c88161b1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":13,"deletions":7,"changed_files":3}}