{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/47578096","id":47578096,"diff_hunk":"@@ -96,6 +96,7 @@ This section lists each version from latest to oldest.  Each listing includes a\n [Docker Remote API v1.22](docker_remote_api_v1.22.md) documentation\n \n * `GET /containers/json` supports filter `isolation` on Windows.\n+* `GET /containers/json` returns list of containers for containers","path":"docs/reference/api/docker_remote_api.md","position":4,"original_position":4,"commit_id":"1cdc095ba27e6e318cab51b00361ba103d155e0c","original_commit_id":"1cdc095ba27e6e318cab51b00361ba103d155e0c","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"hm, you've got \"containers\" twice now, haha. Perhaps;\r\n```\r\n`GET /containers/json` now returns `NetworkSettings` for each container, providing\r\ninformation about the networks that the container is connected to.\r\n```\r\n","created_at":"2015-12-14T23:51:10Z","updated_at":"2015-12-14T23:51:10Z","html_url":"https://github.com/docker/docker/pull/18559#discussion_r47578096","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/18559","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/47578096"},"html":{"href":"https://github.com/docker/docker/pull/18559#discussion_r47578096"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/18559"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/18559","id":53217790,"html_url":"https://github.com/docker/docker/pull/18559","diff_url":"https://github.com/docker/docker/pull/18559.diff","patch_url":"https://github.com/docker/docker/pull/18559.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/18559","number":18559,"state":"open","locked":false,"title":"Proposal: Add container networks list to /containers/json","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"body":"After addition of multi-host networking in Docker 1.9, Docker Remote\r\nAPI is still returning the network name specified during creation\r\nof the container in the “List Containers” (`/containers/json`) endpoint and\r\nnot a list of networks:\r\n\r\n    ...\r\n    \"HostConfig\": {\r\n      \"NetworkMode\": \"default\"\r\n    },\r\n\r\nThe list of networks containers are attached to is only available at\r\neach container's Get Container (`/containers/<id>/json`) endpoint.\r\nThis does not allow development of applications utilizing multi-host\r\nnetworking info to be built on top of the Docker Remote API.\r\n\r\nTherefore I added a simple `\"NetworkSettings\"` section to the\r\n`/containers/json` endpoint. This is not identical to the NetworkSettings\r\nreturned in Get Container (`/containers/<id>/json`) endpoint. It only\r\ncontains a single field `\"Networks\"`, which is essentially the same\r\nvalue shown in inspect output of a container.\r\n\r\nThis change adds the following section to the `/containers/json`:\r\n\r\n    \"NetworkSettings\": {\r\n      \"Networks\": {\r\n        \"bridge\": {\r\n          \"EndpointID\": \"2cdc4edb1ded3631c81f57966563e...\",\r\n          \"Gateway\": \"172.17.0.1\",\r\n          \"IPAddress\": \"172.17.0.2\",\r\n          \"IPPrefixLen\": 16,\r\n          \"IPv6Gateway\": \"\",\r\n          \"GlobalIPv6Address\": \"\",\r\n          \"GlobalIPv6PrefixLen\": 0,\r\n          \"MacAddress\": \"02:42:ac:11:00:02\"\r\n        }\r\n      }\r\n    }\r\n\r\nThis is of type `api/types#SummaryNetworkSettings`, a minimal version of\r\n`api/types#NetworkSettings`.\r\n\r\nActually all I need is the network name and the IPAddress fields. If folks\r\nfind this addition too big, I can create a `SummaryEndpointSettings` field\r\nas well, containing just the IPAddress field.\r\n\r\nSigned-off-by: Ahmet Alp Balkan","created_at":"2015-12-10T05:40:45Z","updated_at":"2015-12-14T23:51:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36e9d4c6f5f15ff0ee1232d863d670178e4b348c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/18559/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/18559/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/18559/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/1cdc095ba27e6e318cab51b00361ba103d155e0c","head":{"label":"ahmetalpbalkan:return-container-networks","ref":"return-container-networks","sha":"1cdc095ba27e6e318cab51b00361ba103d155e0c","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"repo":{"id":30384043,"name":"docker","full_name":"ahmetalpbalkan/docker","owner":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmetalpbalkan/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/ahmetalpbalkan/docker","forks_url":"https://api.github.com/repos/ahmetalpbalkan/docker/forks","keys_url":"https://api.github.com/repos/ahmetalpbalkan/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmetalpbalkan/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmetalpbalkan/docker/teams","hooks_url":"https://api.github.com/repos/ahmetalpbalkan/docker/hooks","issue_events_url":"https://api.github.com/repos/ahmetalpbalkan/docker/issues/events{/number}","events_url":"https://api.github.com/repos/ahmetalpbalkan/docker/events","assignees_url":"https://api.github.com/repos/ahmetalpbalkan/docker/assignees{/user}","branches_url":"https://api.github.com/repos/ahmetalpbalkan/docker/branches{/branch}","tags_url":"https://api.github.com/repos/ahmetalpbalkan/docker/tags","blobs_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmetalpbalkan/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmetalpbalkan/docker/languages","stargazers_url":"https://api.github.com/repos/ahmetalpbalkan/docker/stargazers","contributors_url":"https://api.github.com/repos/ahmetalpbalkan/docker/contributors","subscribers_url":"https://api.github.com/repos/ahmetalpbalkan/docker/subscribers","subscription_url":"https://api.github.com/repos/ahmetalpbalkan/docker/subscription","commits_url":"https://api.github.com/repos/ahmetalpbalkan/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmetalpbalkan/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmetalpbalkan/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahmetalpbalkan/docker/contents/{+path}","compare_url":"https://api.github.com/repos/ahmetalpbalkan/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmetalpbalkan/docker/merges","archive_url":"https://api.github.com/repos/ahmetalpbalkan/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmetalpbalkan/docker/downloads","issues_url":"https://api.github.com/repos/ahmetalpbalkan/docker/issues{/number}","pulls_url":"https://api.github.com/repos/ahmetalpbalkan/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmetalpbalkan/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmetalpbalkan/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmetalpbalkan/docker/labels{/name}","releases_url":"https://api.github.com/repos/ahmetalpbalkan/docker/releases{/id}","created_at":"2015-02-05T23:23:10Z","updated_at":"2015-04-14T07:16:29Z","pushed_at":"2015-12-14T23:41:54Z","git_url":"git://github.com/ahmetalpbalkan/docker.git","ssh_url":"git@github.com:ahmetalpbalkan/docker.git","clone_url":"https://github.com/ahmetalpbalkan/docker.git","svn_url":"https://github.com/ahmetalpbalkan/docker","homepage":"http://www.docker.com","size":75076,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"8970337f609d38dab69785f963d4a64a539ebf1b","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-12-14T23:24:38Z","pushed_at":"2015-12-14T23:41:55Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":118213,"stargazers_count":27014,"watchers_count":27014,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7359,"mirror_url":null,"open_issues_count":1225,"forks":7359,"open_issues":1225,"watchers":27014,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/18559"},"html":{"href":"https://github.com/docker/docker/pull/18559"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/18559"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/18559/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/18559/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/18559/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/1cdc095ba27e6e318cab51b00361ba103d155e0c"}}}}