{"action":"created","issue":{"url":"https://api.github.com/repos/fogonwater/pydnz/issues/1","labels_url":"https://api.github.com/repos/fogonwater/pydnz/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/fogonwater/pydnz/issues/1/comments","events_url":"https://api.github.com/repos/fogonwater/pydnz/issues/1/events","html_url":"https://github.com/fogonwater/pydnz/pull/1","id":95608137,"number":1,"title":"Use Make for build, add tests, setup scripts and requirements.txt for pip. Fix some pep8 and pep257 warnings.","user":{"login":"kinow","id":304786,"avatar_url":"https://avatars.githubusercontent.com/u/304786?v=3","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-17T07:56:28Z","updated_at":"2015-07-18T00:09:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fogonwater/pydnz/pulls/1","html_url":"https://github.com/fogonwater/pydnz/pull/1","diff_url":"https://github.com/fogonwater/pydnz/pull/1.diff","patch_url":"https://github.com/fogonwater/pydnz/pull/1.patch"},"body":"Hello,\r\n\r\nThanks for sharing this. This pull request adds a Makefile for building the project. It doesn't work with Windows as it displays a usage menu using sed (never tried with Cygwin though).\r\n\r\nThere are some basic tests now, you can try with ./setup.py nosetests or make test.\r\n\r\nThe setup script uses setuptools and provides package information and nosetests.\r\n\r\nThere is also a requirements.txt shamelessly copied from the DPyLA project.\r\n\r\nYou can run pep8 and pep257 analysis as well. While writing this pull request I've fixed a few minor warnings. \r\n\r\nThe only change in the Python code of the API, was to handle when the DNZ API returns errors. I got an error due to an invalid API (which happens when you select the text form your user profile screen and CTRL + V into the editor) but it wasn't clear what the error was about. "},"comment":{"url":"https://api.github.com/repos/fogonwater/pydnz/issues/comments/122458899","html_url":"https://github.com/fogonwater/pydnz/pull/1#issuecomment-122458899","issue_url":"https://api.github.com/repos/fogonwater/pydnz/issues/1","id":122458899,"user":{"login":"kinow","id":304786,"avatar_url":"https://avatars.githubusercontent.com/u/304786?v=3","gravatar_id":"","url":"https://api.github.com/users/kinow","html_url":"https://github.com/kinow","followers_url":"https://api.github.com/users/kinow/followers","following_url":"https://api.github.com/users/kinow/following{/other_user}","gists_url":"https://api.github.com/users/kinow/gists{/gist_id}","starred_url":"https://api.github.com/users/kinow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinow/subscriptions","organizations_url":"https://api.github.com/users/kinow/orgs","repos_url":"https://api.github.com/users/kinow/repos","events_url":"https://api.github.com/users/kinow/events{/privacy}","received_events_url":"https://api.github.com/users/kinow/received_events","type":"User","site_admin":false},"created_at":"2015-07-18T00:09:53Z","updated_at":"2015-07-18T00:09:53Z","body":"Awesome Chris. I was undecided on whether to send many smaller pull requests or a single on, so feel free to comment on specific parts if necessary (I can probably update the PR) or simply ignore the PR and manually merge anything you may find useful :) \r\n\r\n"}}