{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/comments/27651102","id":27651102,"diff_hunk":"@@ -56,10 +58,78 @@ class SDSSClass(BaseQuery):\n     TIMEOUT = conf.timeout\n \n     QUERY_URL = 'http://skyserver.sdss3.org/public/en/tools/search/x_sql.aspx'\n+    XID_URL = 'http://skyserver.sdss.org/dr12/en/tools/crossid/x_crossid.aspx'\n+\n+    def query_crossid_async(self, coordinates, obj_names=None,\n+                            photoobj_fields=None, specobj_fields=None,\n+                            get_query_payload=False, timeout=TIMEOUT,\n+                            radius=u.degree / 1800, output_format='csv'):","path":"astroquery/sdss/core.py","position":18,"original_position":18,"commit_id":"da5bcb9c21218e24fc113b7ab76fad4517992717","original_commit_id":"da5bcb9c21218e24fc113b7ab76fad4517992717","user":{"login":"keflavich","id":143715,"avatar_url":"https://avatars.githubusercontent.com/u/143715?v=3","gravatar_id":"","url":"https://api.github.com/users/keflavich","html_url":"https://github.com/keflavich","followers_url":"https://api.github.com/users/keflavich/followers","following_url":"https://api.github.com/users/keflavich/following{/other_user}","gists_url":"https://api.github.com/users/keflavich/gists{/gist_id}","starred_url":"https://api.github.com/users/keflavich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keflavich/subscriptions","organizations_url":"https://api.github.com/users/keflavich/orgs","repos_url":"https://api.github.com/users/keflavich/repos","events_url":"https://api.github.com/users/keflavich/events{/privacy}","received_events_url":"https://api.github.com/users/keflavich/received_events","type":"User","site_admin":false},"body":"Yeah, I was going to say it should be changed there too...\r\n\r\nJust ping me when this is ready for final review & merging.","created_at":"2015-04-02T12:10:29Z","updated_at":"2015-04-02T12:10:29Z","html_url":"https://github.com/astropy/astroquery/pull/507#discussion_r27651102","pull_request_url":"https://api.github.com/repos/astropy/astroquery/pulls/507","_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments/27651102"},"html":{"href":"https://github.com/astropy/astroquery/pull/507#discussion_r27651102"},"pull_request":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/507"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/507","id":32471083,"html_url":"https://github.com/astropy/astroquery/pull/507","diff_url":"https://github.com/astropy/astroquery/pull/507.diff","patch_url":"https://github.com/astropy/astroquery/pull/507.patch","issue_url":"https://api.github.com/repos/astropy/astroquery/issues/507","number":507,"state":"open","locked":false,"title":"Adding SDSS query_crossid() to use  the crossid api","user":{"login":"bsipocz","id":6788290,"avatar_url":"https://avatars.githubusercontent.com/u/6788290?v=3","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"body":"This PR adds support for queries using the crossid API which are beyond to the limitations of the sql api (it cuts the query, thus doesn't work when a large number of coordinates are passed at the) same time. crossid api has the more generous limitations listed  [here](http://skyserver.sdss.org/dr12/en/help/docs/limits.aspx).\r\n\r\nThis works as is for thousands of coordinates and the default photobj fields, however more throughout testing and documentation is needed (e.g. haven't tested for specobj fields, most probably is not yet working).\r\n\r\nCloses #492","created_at":"2015-04-01T23:30:01Z","updated_at":"2015-04-02T12:10:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c564ca40b5b1007195edea6e1f9a8c464384aab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astroquery/pulls/507/commits","review_comments_url":"https://api.github.com/repos/astropy/astroquery/pulls/507/comments","review_comment_url":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astroquery/issues/507/comments","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/da5bcb9c21218e24fc113b7ab76fad4517992717","head":{"label":"bsipocz:sdss_add_crossid_match","ref":"sdss_add_crossid_match","sha":"da5bcb9c21218e24fc113b7ab76fad4517992717","user":{"login":"bsipocz","id":6788290,"avatar_url":"https://avatars.githubusercontent.com/u/6788290?v=3","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"repo":{"id":18994800,"name":"astroquery","full_name":"bsipocz/astroquery","owner":{"login":"bsipocz","id":6788290,"avatar_url":"https://avatars.githubusercontent.com/u/6788290?v=3","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsipocz/astroquery","description":"Functions and classes to access online data resources. Maintainer: @keflavich","fork":true,"url":"https://api.github.com/repos/bsipocz/astroquery","forks_url":"https://api.github.com/repos/bsipocz/astroquery/forks","keys_url":"https://api.github.com/repos/bsipocz/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsipocz/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsipocz/astroquery/teams","hooks_url":"https://api.github.com/repos/bsipocz/astroquery/hooks","issue_events_url":"https://api.github.com/repos/bsipocz/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/bsipocz/astroquery/events","assignees_url":"https://api.github.com/repos/bsipocz/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/bsipocz/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/bsipocz/astroquery/tags","blobs_url":"https://api.github.com/repos/bsipocz/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsipocz/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsipocz/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsipocz/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsipocz/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/bsipocz/astroquery/languages","stargazers_url":"https://api.github.com/repos/bsipocz/astroquery/stargazers","contributors_url":"https://api.github.com/repos/bsipocz/astroquery/contributors","subscribers_url":"https://api.github.com/repos/bsipocz/astroquery/subscribers","subscription_url":"https://api.github.com/repos/bsipocz/astroquery/subscription","commits_url":"https://api.github.com/repos/bsipocz/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsipocz/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsipocz/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsipocz/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsipocz/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/bsipocz/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsipocz/astroquery/merges","archive_url":"https://api.github.com/repos/bsipocz/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsipocz/astroquery/downloads","issues_url":"https://api.github.com/repos/bsipocz/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/bsipocz/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/bsipocz/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/bsipocz/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsipocz/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/bsipocz/astroquery/releases{/id}","created_at":"2014-04-21T14:27:08Z","updated_at":"2014-04-28T12:54:14Z","pushed_at":"2015-04-02T02:31:24Z","git_url":"git://github.com/bsipocz/astroquery.git","ssh_url":"git@github.com:bsipocz/astroquery.git","clone_url":"https://github.com/bsipocz/astroquery.git","svn_url":"https://github.com/bsipocz/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":6612,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"75590ea47ca20bb53c2d752c856ba1615597b7d1","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":4787269,"name":"astroquery","full_name":"astropy/astroquery","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astroquery","description":"Functions and classes to access online data resources. Maintainer: @keflavich","fork":false,"url":"https://api.github.com/repos/astropy/astroquery","forks_url":"https://api.github.com/repos/astropy/astroquery/forks","keys_url":"https://api.github.com/repos/astropy/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astroquery/teams","hooks_url":"https://api.github.com/repos/astropy/astroquery/hooks","issue_events_url":"https://api.github.com/repos/astropy/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astroquery/events","assignees_url":"https://api.github.com/repos/astropy/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astroquery/tags","blobs_url":"https://api.github.com/repos/astropy/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astroquery/languages","stargazers_url":"https://api.github.com/repos/astropy/astroquery/stargazers","contributors_url":"https://api.github.com/repos/astropy/astroquery/contributors","subscribers_url":"https://api.github.com/repos/astropy/astroquery/subscribers","subscription_url":"https://api.github.com/repos/astropy/astroquery/subscription","commits_url":"https://api.github.com/repos/astropy/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astroquery/merges","archive_url":"https://api.github.com/repos/astropy/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astroquery/downloads","issues_url":"https://api.github.com/repos/astropy/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astroquery/releases{/id}","created_at":"2012-06-25T20:52:07Z","updated_at":"2015-03-31T16:54:49Z","pushed_at":"2015-04-02T02:31:26Z","git_url":"git://github.com/astropy/astroquery.git","ssh_url":"git@github.com:astropy/astroquery.git","clone_url":"https://github.com/astropy/astroquery.git","svn_url":"https://github.com/astropy/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":9790,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":61,"forks":46,"open_issues":61,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/507"},"html":{"href":"https://github.com/astropy/astroquery/pull/507"},"issue":{"href":"https://api.github.com/repos/astropy/astroquery/issues/507"},"comments":{"href":"https://api.github.com/repos/astropy/astroquery/issues/507/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/507/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/507/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astroquery/statuses/da5bcb9c21218e24fc113b7ab76fad4517992717"}}}}