{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/48681151","id":48681151,"diff_hunk":"@@ -80,7 +80,8 @@ def self.plugin_rails_init(options)\n       Minitest.backtrace_filter = ::Rails.backtrace_cleaner if ::Rails.respond_to?(:backtrace_cleaner)\n     end\n \n-    self.reporter.reporters.clear # Replace progress reporter for colors.\n+    # Replace progress reporter for colors.\n+    self.reporter.reporters.delete_if { |reporter| reporter.is_a?(SummaryReporter) || reporter.is_a?(ProgressReporter) }","path":"railties/lib/rails/test_unit/minitest_plugin.rb","position":6,"original_position":6,"commit_id":"13a72368e214b799f86f4d4c41e9f4564adeb162","original_commit_id":"13a72368e214b799f86f4d4c41e9f4564adeb162","user":{"login":"y-yagi","id":987638,"avatar_url":"https://avatars.githubusercontent.com/u/987638?v=3","gravatar_id":"","url":"https://api.github.com/users/y-yagi","html_url":"https://github.com/y-yagi","followers_url":"https://api.github.com/users/y-yagi/followers","following_url":"https://api.github.com/users/y-yagi/following{/other_user}","gists_url":"https://api.github.com/users/y-yagi/gists{/gist_id}","starred_url":"https://api.github.com/users/y-yagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-yagi/subscriptions","organizations_url":"https://api.github.com/users/y-yagi/orgs","repos_url":"https://api.github.com/users/y-yagi/repos","events_url":"https://api.github.com/users/y-yagi/events{/privacy}","received_events_url":"https://api.github.com/users/y-yagi/received_events","type":"User","site_admin":false},"body":"Since all of the custom reporters will not mean that conflict of reporter of the rails, I think it should not be delete all.\r\nIn my project, I am using reporters that extends `Minitest::StatisticsReporter`, they do not conflict with the reporter of the rails.\r\n","created_at":"2016-01-01T23:36:48Z","updated_at":"2016-01-01T23:36:48Z","html_url":"https://github.com/rails/rails/pull/22808#discussion_r48681151","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/22808","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/48681151"},"html":{"href":"https://github.com/rails/rails/pull/22808#discussion_r48681151"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/22808"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/22808","id":54630677,"html_url":"https://github.com/rails/rails/pull/22808","diff_url":"https://github.com/rails/rails/pull/22808.diff","patch_url":"https://github.com/rails/rails/pull/22808.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/22808","number":22808,"state":"open","locked":false,"title":"delete only unnecessary reporter","user":{"login":"y-yagi","id":987638,"avatar_url":"https://avatars.githubusercontent.com/u/987638?v=3","gravatar_id":"","url":"https://api.github.com/users/y-yagi","html_url":"https://github.com/y-yagi","followers_url":"https://api.github.com/users/y-yagi/followers","following_url":"https://api.github.com/users/y-yagi/following{/other_user}","gists_url":"https://api.github.com/users/y-yagi/gists{/gist_id}","starred_url":"https://api.github.com/users/y-yagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-yagi/subscriptions","organizations_url":"https://api.github.com/users/y-yagi/orgs","repos_url":"https://api.github.com/users/y-yagi/repos","events_url":"https://api.github.com/users/y-yagi/events{/privacy}","received_events_url":"https://api.github.com/users/y-yagi/received_events","type":"User","site_admin":false},"body":"Reporter that defines its own users at the time of this process are also loaded,\r\nto avoid them from being deleted, to delete only the specified to unnecessary reporter.","created_at":"2015-12-28T03:46:49Z","updated_at":"2016-01-01T23:36:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25d71131ebe159f701e847e4cf00be4f5877fd72","assignee":{"login":"arthurnn","id":833383,"avatar_url":"https://avatars.githubusercontent.com/u/833383?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurnn","html_url":"https://github.com/arthurnn","followers_url":"https://api.github.com/users/arthurnn/followers","following_url":"https://api.github.com/users/arthurnn/following{/other_user}","gists_url":"https://api.github.com/users/arthurnn/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurnn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurnn/subscriptions","organizations_url":"https://api.github.com/users/arthurnn/orgs","repos_url":"https://api.github.com/users/arthurnn/repos","events_url":"https://api.github.com/users/arthurnn/events{/privacy}","received_events_url":"https://api.github.com/users/arthurnn/received_events","type":"User","site_admin":true},"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/22808/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/22808/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/22808/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/13a72368e214b799f86f4d4c41e9f4564adeb162","head":{"label":"y-yagi:do_not_clear_all_reporters","ref":"do_not_clear_all_reporters","sha":"13a72368e214b799f86f4d4c41e9f4564adeb162","user":{"login":"y-yagi","id":987638,"avatar_url":"https://avatars.githubusercontent.com/u/987638?v=3","gravatar_id":"","url":"https://api.github.com/users/y-yagi","html_url":"https://github.com/y-yagi","followers_url":"https://api.github.com/users/y-yagi/followers","following_url":"https://api.github.com/users/y-yagi/following{/other_user}","gists_url":"https://api.github.com/users/y-yagi/gists{/gist_id}","starred_url":"https://api.github.com/users/y-yagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-yagi/subscriptions","organizations_url":"https://api.github.com/users/y-yagi/orgs","repos_url":"https://api.github.com/users/y-yagi/repos","events_url":"https://api.github.com/users/y-yagi/events{/privacy}","received_events_url":"https://api.github.com/users/y-yagi/received_events","type":"User","site_admin":false},"repo":{"id":39712809,"name":"rails","full_name":"y-yagi/rails","owner":{"login":"y-yagi","id":987638,"avatar_url":"https://avatars.githubusercontent.com/u/987638?v=3","gravatar_id":"","url":"https://api.github.com/users/y-yagi","html_url":"https://github.com/y-yagi","followers_url":"https://api.github.com/users/y-yagi/followers","following_url":"https://api.github.com/users/y-yagi/following{/other_user}","gists_url":"https://api.github.com/users/y-yagi/gists{/gist_id}","starred_url":"https://api.github.com/users/y-yagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-yagi/subscriptions","organizations_url":"https://api.github.com/users/y-yagi/orgs","repos_url":"https://api.github.com/users/y-yagi/repos","events_url":"https://api.github.com/users/y-yagi/events{/privacy}","received_events_url":"https://api.github.com/users/y-yagi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/y-yagi/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/y-yagi/rails","forks_url":"https://api.github.com/repos/y-yagi/rails/forks","keys_url":"https://api.github.com/repos/y-yagi/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/y-yagi/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/y-yagi/rails/teams","hooks_url":"https://api.github.com/repos/y-yagi/rails/hooks","issue_events_url":"https://api.github.com/repos/y-yagi/rails/issues/events{/number}","events_url":"https://api.github.com/repos/y-yagi/rails/events","assignees_url":"https://api.github.com/repos/y-yagi/rails/assignees{/user}","branches_url":"https://api.github.com/repos/y-yagi/rails/branches{/branch}","tags_url":"https://api.github.com/repos/y-yagi/rails/tags","blobs_url":"https://api.github.com/repos/y-yagi/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/y-yagi/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/y-yagi/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/y-yagi/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/y-yagi/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/y-yagi/rails/languages","stargazers_url":"https://api.github.com/repos/y-yagi/rails/stargazers","contributors_url":"https://api.github.com/repos/y-yagi/rails/contributors","subscribers_url":"https://api.github.com/repos/y-yagi/rails/subscribers","subscription_url":"https://api.github.com/repos/y-yagi/rails/subscription","commits_url":"https://api.github.com/repos/y-yagi/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/y-yagi/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/y-yagi/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/y-yagi/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/y-yagi/rails/contents/{+path}","compare_url":"https://api.github.com/repos/y-yagi/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/y-yagi/rails/merges","archive_url":"https://api.github.com/repos/y-yagi/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/y-yagi/rails/downloads","issues_url":"https://api.github.com/repos/y-yagi/rails/issues{/number}","pulls_url":"https://api.github.com/repos/y-yagi/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/y-yagi/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/y-yagi/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/y-yagi/rails/labels{/name}","releases_url":"https://api.github.com/repos/y-yagi/rails/releases{/id}","created_at":"2015-07-26T03:56:33Z","updated_at":"2015-07-26T03:57:00Z","pushed_at":"2015-12-28T03:45:14Z","git_url":"git://github.com/y-yagi/rails.git","ssh_url":"git@github.com:y-yagi/rails.git","clone_url":"https://github.com/y-yagi/rails.git","svn_url":"https://github.com/y-yagi/rails","homepage":"http://rubyonrails.org","size":121989,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"46bbdf58b50a34986d671091a0a7188b66492cd5","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-01-01T22:21:34Z","pushed_at":"2016-01-01T21:58:43Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":320626,"stargazers_count":28970,"watchers_count":28970,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11727,"mirror_url":null,"open_issues_count":850,"forks":11727,"open_issues":850,"watchers":28970,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/22808"},"html":{"href":"https://github.com/rails/rails/pull/22808"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/22808"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/22808/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/22808/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/22808/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/13a72368e214b799f86f4d4c41e9f4564adeb162"}}}}