{"action":"closed","number":1597,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1597","id":47332303,"html_url":"https://github.com/spring-projects/spring-integration/pull/1597","diff_url":"https://github.com/spring-projects/spring-integration/pull/1597.diff","patch_url":"https://github.com/spring-projects/spring-integration/pull/1597.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/1597","number":1597,"state":"closed","locked":false,"title":"INT-2787: Map `correlationId` to JMS Property","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.spring.io/browse/INT-2787\r\n\r\nThe `correlationId` is `UUID` object by default Framework behavior.\r\nThis type isn't allowed for JMS Message properties mapping.\r\n\r\nAdd the mapping for the `IntegrationMessageHeaderAccessor.CORRELATION_ID` header as a `String`,\r\nsince on the other side it simply can be converted to the `UUID` object back.\r\nFor example `AbstractCorrelatingMessageHandler` does that automatically on the correlation function using `UUIDConverter`.\r\n\r\nThe provided `SplitterAggregatorTests` demonstrates the scenario when we weren't be able to aggregate by the unsupported `UUID` type.\r\n\r\nI don't consider this as back-port fix, because the same can be simply achieved with the custom `JmsHeaderMapper`.\r\nFrom other side this fix maybe like some side-effect breaking change.\r\n\r\nI don't consider any `UUID` message header as a candidate to be converted to String and mapped, because to do that unconditionally\r\nmay cause some undesired issues. From other side it can be done with the custom `JmsHeaderMapper` in the end-application.","created_at":"2015-10-10T00:19:18Z","updated_at":"2015-11-24T18:33:30Z","closed_at":"2015-11-24T18:33:30Z","merged_at":null,"merge_commit_sha":"5b7fcde4773a106c2b25b894a65422eededb28ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1597/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1597/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/1597/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/a022c814e787d6e379a76996807a8baeb68c2225","head":{"label":"artembilan:INT-2787","ref":"INT-2787","sha":"a022c814e787d6e379a76996807a8baeb68c2225","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"repo":{"id":2686240,"name":"spring-integration","full_name":"artembilan/spring-integration","owner":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/artembilan/spring-integration","description":"","fork":true,"url":"https://api.github.com/repos/artembilan/spring-integration","forks_url":"https://api.github.com/repos/artembilan/spring-integration/forks","keys_url":"https://api.github.com/repos/artembilan/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artembilan/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artembilan/spring-integration/teams","hooks_url":"https://api.github.com/repos/artembilan/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/artembilan/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/artembilan/spring-integration/events","assignees_url":"https://api.github.com/repos/artembilan/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/artembilan/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/artembilan/spring-integration/tags","blobs_url":"https://api.github.com/repos/artembilan/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artembilan/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artembilan/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/artembilan/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artembilan/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/artembilan/spring-integration/languages","stargazers_url":"https://api.github.com/repos/artembilan/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/artembilan/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/artembilan/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/artembilan/spring-integration/subscription","commits_url":"https://api.github.com/repos/artembilan/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/artembilan/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/artembilan/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/artembilan/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/artembilan/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/artembilan/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artembilan/spring-integration/merges","archive_url":"https://api.github.com/repos/artembilan/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artembilan/spring-integration/downloads","issues_url":"https://api.github.com/repos/artembilan/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/artembilan/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/artembilan/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/artembilan/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artembilan/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/artembilan/spring-integration/releases{/id}","created_at":"2011-11-01T08:04:04Z","updated_at":"2015-05-08T08:40:43Z","pushed_at":"2015-11-22T00:22:08Z","git_url":"git://github.com/artembilan/spring-integration.git","ssh_url":"git@github.com:artembilan/spring-integration.git","clone_url":"https://github.com/artembilan/spring-integration.git","svn_url":"https://github.com/artembilan/spring-integration","homepage":"","size":32949,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"d21b42dbcf825772a4071520529d906bdb5a732d","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":2090979,"name":"spring-integration","full_name":"spring-projects/spring-integration","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-integration","description":"Spring Integration provides an extension of the Spring programming model to support the well-known Enterprise Integration Patterns (EIP)","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-integration","forks_url":"https://api.github.com/repos/spring-projects/spring-integration/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-integration/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-integration/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-integration/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-integration/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-integration/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-integration/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-integration/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-integration/releases{/id}","created_at":"2011-07-22T21:47:27Z","updated_at":"2015-11-19T23:40:22Z","pushed_at":"2015-11-24T18:32:48Z","git_url":"git://github.com/spring-projects/spring-integration.git","ssh_url":"git@github.com:spring-projects/spring-integration.git","clone_url":"https://github.com/spring-projects/spring-integration.git","svn_url":"https://github.com/spring-projects/spring-integration","homepage":"http://projects.spring.io/spring-integration/","size":40646,"stargazers_count":397,"watchers_count":397,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":379,"mirror_url":null,"open_issues_count":5,"forks":379,"open_issues":5,"watchers":397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1597"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/1597"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/1597"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/1597/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1597/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/1597/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-integration/statuses/a022c814e787d6e379a76996807a8baeb68c2225"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":1,"commits":1,"additions":146,"deletions":13,"changed_files":2}}