{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/h/issues/2131","labels_url":"https://api.github.com/repos/hypothesis/h/issues/2131/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/2131/comments","events_url":"https://api.github.com/repos/hypothesis/h/issues/2131/events","html_url":"https://github.com/hypothesis/h/pull/2131","id":66218812,"number":2131,"title":"Let users change their email addresses","user":{"login":"seanh","id":22498,"avatar_url":"https://avatars.githubusercontent.com/u/22498?v=3","gravatar_id":"","url":"https://api.github.com/users/seanh","html_url":"https://github.com/seanh","followers_url":"https://api.github.com/users/seanh/followers","following_url":"https://api.github.com/users/seanh/following{/other_user}","gists_url":"https://api.github.com/users/seanh/gists{/gist_id}","starred_url":"https://api.github.com/users/seanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanh/subscriptions","organizations_url":"https://api.github.com/users/seanh/orgs","repos_url":"https://api.github.com/users/seanh/repos","events_url":"https://api.github.com/users/seanh/events{/privacy}","received_events_url":"https://api.github.com/users/seanh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"seanh","id":22498,"avatar_url":"https://avatars.githubusercontent.com/u/22498?v=3","gravatar_id":"","url":"https://api.github.com/users/seanh","html_url":"https://github.com/seanh","followers_url":"https://api.github.com/users/seanh/followers","following_url":"https://api.github.com/users/seanh/following{/other_user}","gists_url":"https://api.github.com/users/seanh/gists{/gist_id}","starred_url":"https://api.github.com/users/seanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanh/subscriptions","organizations_url":"https://api.github.com/users/seanh/orgs","repos_url":"https://api.github.com/users/seanh/repos","events_url":"https://api.github.com/users/seanh/events{/privacy}","received_events_url":"https://api.github.com/users/seanh/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-04-03T20:00:28Z","updated_at":"2015-04-09T15:27:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/2131","html_url":"https://github.com/hypothesis/h/pull/2131","diff_url":"https://github.com/hypothesis/h/pull/2131.diff","patch_url":"https://github.com/hypothesis/h/pull/2131.patch"},"body":"Fixes https://github.com/hypothesis/vision/issues/174\r\n\r\naccount.html:\r\n\r\n- Add a new \"Change Your Email Address\" form\r\n\r\naccounts/views.py:\r\n\r\n- Add email to the user dict returned at /app?__formid__=profile (or\r\n  session.profile() in Angular)\r\n\r\n- When resetting the form after a successful submission, put the new (or\r\n  unchanged) email address into the user dict returned in the response.\r\n  AccountController needs this (see below).\r\n\r\naccount-controller.coffee:\r\n\r\n- Add $scope.email (the user's current email address), to use for placeholder\r\n  text in the email form field.\r\n\r\n- After a successful form submission set $scope.email to the one from the\r\n  response. This sets the placeholder text in the email field to the new value,\r\n  instead of continuing to show the old email address as placeholder.\r\n\r\n- Add changeEmail() method to receive email form submissions."},"comment":{"url":"https://api.github.com/repos/hypothesis/h/issues/comments/91264510","html_url":"https://github.com/hypothesis/h/pull/2131#issuecomment-91264510","issue_url":"https://api.github.com/repos/hypothesis/h/issues/2131","id":91264510,"user":{"login":"nickstenning","id":3602,"avatar_url":"https://avatars.githubusercontent.com/u/3602?v=3","gravatar_id":"","url":"https://api.github.com/users/nickstenning","html_url":"https://github.com/nickstenning","followers_url":"https://api.github.com/users/nickstenning/followers","following_url":"https://api.github.com/users/nickstenning/following{/other_user}","gists_url":"https://api.github.com/users/nickstenning/gists{/gist_id}","starred_url":"https://api.github.com/users/nickstenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickstenning/subscriptions","organizations_url":"https://api.github.com/users/nickstenning/orgs","repos_url":"https://api.github.com/users/nickstenning/repos","events_url":"https://api.github.com/users/nickstenning/events{/privacy}","received_events_url":"https://api.github.com/users/nickstenning/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T15:27:15Z","updated_at":"2015-04-09T15:27:15Z","body":"I think adding this without email verification is fine. What's worse:\r\n\r\n- users can't change their own email addresses at all\r\n- users can change their own email addresses to an unverified address, but only after they've already signed up with a verified email address\r\n\r\nLet's add a story to add verification to email address changes later. For now I think this materially improves things."}}