{"action":"created","issue":{"url":"https://api.github.com/repos/chgagne/beagle/issues/6","labels_url":"https://api.github.com/repos/chgagne/beagle/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/chgagne/beagle/issues/6/comments","events_url":"https://api.github.com/repos/chgagne/beagle/issues/6/events","html_url":"https://github.com/chgagne/beagle/issues/6","id":89322211,"number":6,"title":"CMakeLists: Unsetting CMAKE_REQUIRED_FLAGS incorrect?","user":{"login":"GhostGambler","id":969344,"avatar_url":"https://avatars.githubusercontent.com/u/969344?v=3","gravatar_id":"","url":"https://api.github.com/users/GhostGambler","html_url":"https://github.com/GhostGambler","followers_url":"https://api.github.com/users/GhostGambler/followers","following_url":"https://api.github.com/users/GhostGambler/following{/other_user}","gists_url":"https://api.github.com/users/GhostGambler/gists{/gist_id}","starred_url":"https://api.github.com/users/GhostGambler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GhostGambler/subscriptions","organizations_url":"https://api.github.com/users/GhostGambler/orgs","repos_url":"https://api.github.com/users/GhostGambler/repos","events_url":"https://api.github.com/users/GhostGambler/events{/privacy}","received_events_url":"https://api.github.com/users/GhostGambler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-18T15:26:22Z","updated_at":"2015-06-20T20:50:58Z","closed_at":null,"body":"The following line is likely intended to undo the changes introduced to check for PACC: `set(CMAKE_REQUIRED_FLAGS)\t\t# Unset modified CMake variables`\r\nhttps://github.com/chgagne/beagle/blob/2eadc45b316bad2e41052e7129a45b7bb51f2a7a/CMakeLists.txt#L443\r\n\r\nI expect this to set CMAKE_REQUIRED_FLAGS to an empty string? Then this might break further tests, because CMAKE_REQUIRED_FLAGS might contain other values as well: `set(CMAKE_REQUIRED_FLAGS \"-std=c++0x\")`\r\nhttps://github.com/chgagne/beagle/blob/2eadc45b316bad2e41052e7129a45b7bb51f2a7a/CMakeLists.txt#L209\r\n\r\nThe old value should for example be saved in a temp variable and written back in line 443"},"comment":{"url":"https://api.github.com/repos/chgagne/beagle/issues/comments/113818857","html_url":"https://github.com/chgagne/beagle/issues/6#issuecomment-113818857","issue_url":"https://api.github.com/repos/chgagne/beagle/issues/6","id":113818857,"user":{"login":"mgard","id":3259003,"avatar_url":"https://avatars.githubusercontent.com/u/3259003?v=3","gravatar_id":"","url":"https://api.github.com/users/mgard","html_url":"https://github.com/mgard","followers_url":"https://api.github.com/users/mgard/followers","following_url":"https://api.github.com/users/mgard/following{/other_user}","gists_url":"https://api.github.com/users/mgard/gists{/gist_id}","starred_url":"https://api.github.com/users/mgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgard/subscriptions","organizations_url":"https://api.github.com/users/mgard/orgs","repos_url":"https://api.github.com/users/mgard/repos","events_url":"https://api.github.com/users/mgard/events{/privacy}","received_events_url":"https://api.github.com/users/mgard/received_events","type":"User","site_admin":false},"created_at":"2015-06-20T20:50:58Z","updated_at":"2015-06-20T20:50:58Z","body":"You are right. Actually, there are many wrong practices like that in the CMakeList. It was mainly made about 6 years ago by an undergraduate intern, with an old version of CMake.\r\n\r\nWe will review the whole CMakeList (there are many cleanups we can do, including removing old options that are not useful anymore, like the check for GCC 2.95...), and, in the process, take your suggestions into account. I leave this issue open as a reminder.\r\n\r\nThanks for your report."}}