{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/25998303","id":25998303,"diff_hunk":"@@ -2273,6 +2273,19 @@ static void Main()\n             CompileAndVerify(\n                 text,\n                 new[] { ExpressionAssemblyRef }, expectedOutput: TrimExpectedOutput(expectedOutput));\n+\n+            // Also verify with the assemblies on which the tests are running, as there's a higher\n+            // liklihood that they have Array.Empty, and we want to verify that Array.Empty is not used","path":"src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenExprLambdaTests.cs","position":6,"original_position":6,"commit_id":"72a1cfe07c6da668d906d00f347831be0c678505","original_commit_id":"72a1cfe07c6da668d906d00f347831be0c678505","user":{"login":"VladimirReshetnikov","id":1231606,"avatar_url":"https://avatars.githubusercontent.com/u/1231606?v=3","gravatar_id":"","url":"https://api.github.com/users/VladimirReshetnikov","html_url":"https://github.com/VladimirReshetnikov","followers_url":"https://api.github.com/users/VladimirReshetnikov/followers","following_url":"https://api.github.com/users/VladimirReshetnikov/following{/other_user}","gists_url":"https://api.github.com/users/VladimirReshetnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/VladimirReshetnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladimirReshetnikov/subscriptions","organizations_url":"https://api.github.com/users/VladimirReshetnikov/orgs","repos_url":"https://api.github.com/users/VladimirReshetnikov/repos","events_url":"https://api.github.com/users/VladimirReshetnikov/events{/privacy}","received_events_url":"https://api.github.com/users/VladimirReshetnikov/received_events","type":"User","site_admin":false},"body":"Spelling: liklihood -> likelihood","created_at":"2015-03-07T18:41:57Z","updated_at":"2015-03-07T18:41:57Z","html_url":"https://github.com/dotnet/roslyn/pull/1117#discussion_r25998303","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/1117","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/25998303"},"html":{"href":"https://github.com/dotnet/roslyn/pull/1117#discussion_r25998303"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1117"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/1117","id":30697886,"html_url":"https://github.com/dotnet/roslyn/pull/1117","diff_url":"https://github.com/dotnet/roslyn/pull/1117.diff","patch_url":"https://github.com/dotnet/roslyn/pull/1117.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/1117","number":1117,"state":"open","locked":false,"title":"Disable Array.Empty params array optimization in expression lambdas","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Fixes #1103.  Or more specifically, #1103 represents two issues: that we do the Array.Empty optimization for params arrays in the expression lambda, and that this optimization does not kick in when compiling expression lambdas... this fix addresses the former but not the latter.\r\n\r\nThe actual fix is a one-line trivial change.  In terms of tests, there's actually already a test for this case, but as it compiles against an earlier mscorlib that lacks Array.Empty, it passes even before the fix.  I augmented the test to also try to run it on a newer mscorlib, but since the Roslyn test suite doesn't yet contain the metadata for mscorlib 4.6, I use the mscorlib on which the test is running as a substitute (thanks to @jaredpar for the suggestion); worst case is the test isn't running on 4.6 and it passes but doesn't verify what we wanted it to.  I did verify that on 4.6 the test fails before the product fix and passes after it.","created_at":"2015-03-07T05:33:55Z","updated_at":"2015-03-07T18:41:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c07430619e0068f0951cedefb223d4c9bc23733","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/1117/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/1117/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/1117/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/72a1cfe07c6da668d906d00f347831be0c678505","head":{"label":"stephentoub:arrayempty_exprlambda","ref":"arrayempty_exprlambda","sha":"72a1cfe07c6da668d906d00f347831be0c678505","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"repo":{"id":29276086,"name":"roslyn","full_name":"stephentoub/roslyn","owner":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephentoub/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/stephentoub/roslyn","forks_url":"https://api.github.com/repos/stephentoub/roslyn/forks","keys_url":"https://api.github.com/repos/stephentoub/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephentoub/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephentoub/roslyn/teams","hooks_url":"https://api.github.com/repos/stephentoub/roslyn/hooks","issue_events_url":"https://api.github.com/repos/stephentoub/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/stephentoub/roslyn/events","assignees_url":"https://api.github.com/repos/stephentoub/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/stephentoub/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/stephentoub/roslyn/tags","blobs_url":"https://api.github.com/repos/stephentoub/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephentoub/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephentoub/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephentoub/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephentoub/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/stephentoub/roslyn/languages","stargazers_url":"https://api.github.com/repos/stephentoub/roslyn/stargazers","contributors_url":"https://api.github.com/repos/stephentoub/roslyn/contributors","subscribers_url":"https://api.github.com/repos/stephentoub/roslyn/subscribers","subscription_url":"https://api.github.com/repos/stephentoub/roslyn/subscription","commits_url":"https://api.github.com/repos/stephentoub/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephentoub/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephentoub/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephentoub/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephentoub/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/stephentoub/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephentoub/roslyn/merges","archive_url":"https://api.github.com/repos/stephentoub/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephentoub/roslyn/downloads","issues_url":"https://api.github.com/repos/stephentoub/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/stephentoub/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/stephentoub/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/stephentoub/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephentoub/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/stephentoub/roslyn/releases{/id}","created_at":"2015-01-15T02:08:48Z","updated_at":"2015-03-07T12:55:07Z","pushed_at":"2015-03-07T12:55:07Z","git_url":"git://github.com/stephentoub/roslyn.git","ssh_url":"git@github.com:stephentoub/roslyn.git","clone_url":"https://github.com/stephentoub/roslyn.git","svn_url":"https://github.com/stephentoub/roslyn","homepage":"","size":53333,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"6a3b722e2fbd74ad59c4c004a4b4dd2c6a83fd66","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-03-07T18:19:15Z","pushed_at":"2015-03-07T05:17:45Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":80390,"stargazers_count":1410,"watchers_count":1410,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":287,"mirror_url":null,"open_issues_count":490,"forks":287,"open_issues":490,"watchers":1410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1117"},"html":{"href":"https://github.com/dotnet/roslyn/pull/1117"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/1117"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/1117/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1117/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1117/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/72a1cfe07c6da668d906d00f347831be0c678505"}}}}