{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/27915975","id":27915975,"diff_hunk":"@@ -149,54 +147,48 @@ public function getVotes($isSubmit = false) {\n \t\t$votes = array();\n \t\t$total = 0;\n \n-\t\t$memcKey = wfMemcKey(self::MEMC_PREFIX_GETVOTES, $this->mId);\n-\t\tif (!$isSubmit) {\n-\t\t\t$votes = $wgMemc->get($memcKey);\n+\t\t$memcKey = $this->getVotesMemKey();\n+\t\tif ( !$isSubmit ) {\n+\t\t\t$votes = $wgMemc->get( $memcKey );\n \t\t}\n-\t\tif (!empty($votes)) {\n-\t\t\tforeach($votes as $ansData){\n+\t\tif ( !empty( $votes ) ) {\n+\t\t\tforeach( $votes as $ansData ){\n \t\t\t\t$total += $ansData[\"value\"];\n \t\t\t}\n \t\t} else {\n-\t\t\t$votes = array();\n \t\t\t$dbr = wfGetDB( $isSubmit ? DB_MASTER : DB_SLAVE );\n-\t\t\t$oRes = $dbr->select(\n-\t\t\t\tarray( \"poll_vote\" ),\n-\t\t\t\tarray( \"poll_answer\" ),\n-\t\t\t\tarray( \"poll_id\" => $this->mId ),\n-\t\t\t\t__METHOD__\n-\t\t\t);\n \n-\t\t\twhile( $oRow = $dbr->fetchObject( $oRes ) ) {\n-\t\t\t\tif( isset( $votes[ $oRow->poll_answer ] ) ) {\n-\t\t\t\t\t$votes[ $oRow->poll_answer ][ \"value\" ]++;\n-\t\t\t\t} else {\n-\t\t\t\t\t$votes[ $oRow->poll_answer ][ \"value\" ] = 1;\n-\t\t\t\t}\n-\t\t\t\t$total++;\n-\t\t\t}\n-\t\t\t$dbr->freeResult( $oRes );\n+\t\t\t$votes = ( new WikiaSQL() )\n+\t\t\t\t->SELECT( 'poll_answer' )\n+\t\t\t\t\t->COUNT( '*' )->AS_( 'count' )\n+\t\t\t\t->FROM( 'poll_vote' )\n+\t\t\t\t->WHERE( 'poll_id' )->EQUAL_TO( $this->mId )\n+\t\t\t\t->GROUP_BY( 'poll_answer' )\n+\t\t\t\t->runLoop( $dbr, function( &$votes, $row ) use ( &$total ) {\n+\t\t\t\t\t$votes[$row->poll_answer]['value'] = $row->count;\n+\t\t\t\t\t$total += $row->count;\n+\t\t\t\t}, [] );","path":"extensions/wikia/AjaxPoll/AjaxPoll_body.php","position":100,"original_position":100,"commit_id":"9a662b3b777afdbf5f5391f0f236c3a19ecfc1a2","original_commit_id":"9a662b3b777afdbf5f5391f0f236c3a19ecfc1a2","user":{"login":"jsutterfield","id":1657792,"avatar_url":"https://avatars.githubusercontent.com/u/1657792?v=3","gravatar_id":"","url":"https://api.github.com/users/jsutterfield","html_url":"https://github.com/jsutterfield","followers_url":"https://api.github.com/users/jsutterfield/followers","following_url":"https://api.github.com/users/jsutterfield/following{/other_user}","gists_url":"https://api.github.com/users/jsutterfield/gists{/gist_id}","starred_url":"https://api.github.com/users/jsutterfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsutterfield/subscriptions","organizations_url":"https://api.github.com/users/jsutterfield/orgs","repos_url":"https://api.github.com/users/jsutterfield/repos","events_url":"https://api.github.com/users/jsutterfield/events{/privacy}","received_events_url":"https://api.github.com/users/jsutterfield/received_events","type":"User","site_admin":false},"body":"I don't believe you need to pass this empty array as the third parameter. That's the default value in the function signature.","created_at":"2015-04-07T20:21:19Z","updated_at":"2015-04-07T20:21:19Z","html_url":"https://github.com/Wikia/app/pull/6885#discussion_r27915975","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/6885","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/27915975"},"html":{"href":"https://github.com/Wikia/app/pull/6885#discussion_r27915975"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/6885"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/6885","id":32701373,"html_url":"https://github.com/Wikia/app/pull/6885","diff_url":"https://github.com/Wikia/app/pull/6885.diff","patch_url":"https://github.com/Wikia/app/pull/6885.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/6885","number":6885,"state":"open","locked":false,"title":"SOC-586 Error reporter clean up","user":{"login":"garthwebb","id":72574,"avatar_url":"https://avatars.githubusercontent.com/u/72574?v=3","gravatar_id":"","url":"https://api.github.com/users/garthwebb","html_url":"https://github.com/garthwebb","followers_url":"https://api.github.com/users/garthwebb/followers","following_url":"https://api.github.com/users/garthwebb/following{/other_user}","gists_url":"https://api.github.com/users/garthwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/garthwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garthwebb/subscriptions","organizations_url":"https://api.github.com/users/garthwebb/orgs","repos_url":"https://api.github.com/users/garthwebb/repos","events_url":"https://api.github.com/users/garthwebb/events{/privacy}","received_events_url":"https://api.github.com/users/garthwebb/received_events","type":"User","site_admin":false},"body":"\r\nhttps://wikia-inc.atlassian.net/browse/SOC-586","created_at":"2015-04-06T19:02:36Z","updated_at":"2015-04-07T20:21:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf87d42b10ecd962f37297756fceb10a4a0d77df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/6885/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/6885/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/6885/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/9a662b3b777afdbf5f5391f0f236c3a19ecfc1a2","head":{"label":"Wikia:SOC-586","ref":"SOC-586","sha":"9a662b3b777afdbf5f5391f0f236c3a19ecfc1a2","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-04-07T18:22:22Z","pushed_at":"2015-04-07T18:22:24Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1387393,"stargazers_count":76,"watchers_count":76,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":58,"forks":56,"open_issues":58,"watchers":76,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"1319c0fe36c11fb87bc9c5c29debd1a386acb75d","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-04-07T18:22:22Z","pushed_at":"2015-04-07T18:22:24Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1387393,"stargazers_count":76,"watchers_count":76,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":58,"forks":56,"open_issues":58,"watchers":76,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/6885"},"html":{"href":"https://github.com/Wikia/app/pull/6885"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/6885"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/6885/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/6885/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/6885/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/9a662b3b777afdbf5f5391f0f236c3a19ecfc1a2"}}}}