{"action":"created","comment":{"url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/comments/34355455","id":34355455,"diff_hunk":"@@ -68,15 +69,17 @@ public function preSubmit(FormEvent $event)\n             foreach ($contentType->getFields() as $contentTypeField) {\n                 $contentTypeFieldId = $contentTypeField->getFieldId();\n                 $data[$contentTypeFieldId] = isset($data[$contentTypeFieldId]) ? $data[$contentTypeFieldId] : null;\n-                if ($attribute = $content->getAttributeByName($contentTypeFieldId)) {\n-                    $attribute->setValue($this->transformData($data[$contentTypeFieldId], $form->get($contentTypeFieldId)));\n-                } elseif (is_null($attribute)) {\n+                $attribute = $content->getAttributeByName($contentTypeFieldId);\n+                if (is_null($attribute)) {\n                     $contentAttributeClass = $this->contentAttributeClass;\n                     $attribute = new $contentAttributeClass;\n                     $attribute->setName($contentTypeFieldId);\n-                    $attribute->setValue($this->transformData($data[$contentTypeFieldId], $form->get($contentTypeFieldId)));\n-                    $content->addAttribute($attribute);\n                 }\n+                $value = $this->transformData($data[$contentTypeFieldId], $form->get($contentTypeFieldId));\n+                $attribute->setValue($value);\n+                $valueTransformer = new ValueToStringTransformer();\n+                $attribute->setStringValue($valueTransformer->transform($value));\n+                $content->addAttribute($attribute);","path":"BackofficeBundle/EventSubscriber/ContentTypeSubscriber.php","position":27,"original_position":27,"commit_id":"bf10e3d42e34e84e8f52020e5011b80e2845fd96","original_commit_id":"bf10e3d42e34e84e8f52020e5011b80e2845fd96","user":{"login":"nicolasThal","id":2675545,"avatar_url":"https://avatars.githubusercontent.com/u/2675545?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasThal","html_url":"https://github.com/nicolasThal","followers_url":"https://api.github.com/users/nicolasThal/followers","following_url":"https://api.github.com/users/nicolasThal/following{/other_user}","gists_url":"https://api.github.com/users/nicolasThal/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasThal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasThal/subscriptions","organizations_url":"https://api.github.com/users/nicolasThal/orgs","repos_url":"https://api.github.com/users/nicolasThal/repos","events_url":"https://api.github.com/users/nicolasThal/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasThal/received_events","type":"User","site_admin":false},"body":"The add attribute should only be done for hte new contentAttribute\r\n","created_at":"2015-07-10T13:44:37Z","updated_at":"2015-07-10T13:44:37Z","html_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/937#discussion_r34355455","pull_request_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/937","_links":{"self":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/comments/34355455"},"html":{"href":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/937#discussion_r34355455"},"pull_request":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/937"}}},"pull_request":{"url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/937","id":39684784,"html_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/937","diff_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/937.diff","patch_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/937.patch","issue_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/937","number":937,"state":"open","locked":false,"title":"use string value for Contentattribute","user":{"login":"itkg-rboessel","id":11752276,"avatar_url":"https://avatars.githubusercontent.com/u/11752276?v=3","gravatar_id":"","url":"https://api.github.com/users/itkg-rboessel","html_url":"https://github.com/itkg-rboessel","followers_url":"https://api.github.com/users/itkg-rboessel/followers","following_url":"https://api.github.com/users/itkg-rboessel/following{/other_user}","gists_url":"https://api.github.com/users/itkg-rboessel/gists{/gist_id}","starred_url":"https://api.github.com/users/itkg-rboessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itkg-rboessel/subscriptions","organizations_url":"https://api.github.com/users/itkg-rboessel/orgs","repos_url":"https://api.github.com/users/itkg-rboessel/repos","events_url":"https://api.github.com/users/itkg-rboessel/events{/privacy}","received_events_url":"https://api.github.com/users/itkg-rboessel/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-10T13:36:38Z","updated_at":"2015-07-10T13:44:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d972af712e1f583ca61266c9d6f72007dd225d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/937/commits","review_comments_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/937/comments","review_comment_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/937/comments","statuses_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/statuses/bf10e3d42e34e84e8f52020e5011b80e2845fd96","head":{"label":"open-orchestra:save_content_attribute","ref":"save_content_attribute","sha":"bf10e3d42e34e84e8f52020e5011b80e2845fd96","user":{"login":"open-orchestra","id":11756116,"avatar_url":"https://avatars.githubusercontent.com/u/11756116?v=3","gravatar_id":"","url":"https://api.github.com/users/open-orchestra","html_url":"https://github.com/open-orchestra","followers_url":"https://api.github.com/users/open-orchestra/followers","following_url":"https://api.github.com/users/open-orchestra/following{/other_user}","gists_url":"https://api.github.com/users/open-orchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/open-orchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-orchestra/subscriptions","organizations_url":"https://api.github.com/users/open-orchestra/orgs","repos_url":"https://api.github.com/users/open-orchestra/repos","events_url":"https://api.github.com/users/open-orchestra/events{/privacy}","received_events_url":"https://api.github.com/users/open-orchestra/received_events","type":"Organization","site_admin":false},"repo":{"id":21900253,"name":"open-orchestra-cms-bundle","full_name":"open-orchestra/open-orchestra-cms-bundle","owner":{"login":"open-orchestra","id":11756116,"avatar_url":"https://avatars.githubusercontent.com/u/11756116?v=3","gravatar_id":"","url":"https://api.github.com/users/open-orchestra","html_url":"https://github.com/open-orchestra","followers_url":"https://api.github.com/users/open-orchestra/followers","following_url":"https://api.github.com/users/open-orchestra/following{/other_user}","gists_url":"https://api.github.com/users/open-orchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/open-orchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-orchestra/subscriptions","organizations_url":"https://api.github.com/users/open-orchestra/orgs","repos_url":"https://api.github.com/users/open-orchestra/repos","events_url":"https://api.github.com/users/open-orchestra/events{/privacy}","received_events_url":"https://api.github.com/users/open-orchestra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle","description":"The php orchestra cms bundle","fork":false,"url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle","forks_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/forks","keys_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/teams","hooks_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/hooks","issue_events_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/events","assignees_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/tags","blobs_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/languages","stargazers_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/stargazers","contributors_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/contributors","subscribers_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/subscribers","subscription_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/subscription","commits_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/merges","archive_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/downloads","issues_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/labels{/name}","releases_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/releases{/id}","created_at":"2014-07-16T12:49:27Z","updated_at":"2015-05-07T08:02:31Z","pushed_at":"2015-07-10T13:44:04Z","git_url":"git://github.com/open-orchestra/open-orchestra-cms-bundle.git","ssh_url":"git@github.com:open-orchestra/open-orchestra-cms-bundle.git","clone_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle.git","svn_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle","homepage":null,"size":24598,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"open-orchestra:master","ref":"master","sha":"282481a36fb23e10f39624139e9b9650841fae2b","user":{"login":"open-orchestra","id":11756116,"avatar_url":"https://avatars.githubusercontent.com/u/11756116?v=3","gravatar_id":"","url":"https://api.github.com/users/open-orchestra","html_url":"https://github.com/open-orchestra","followers_url":"https://api.github.com/users/open-orchestra/followers","following_url":"https://api.github.com/users/open-orchestra/following{/other_user}","gists_url":"https://api.github.com/users/open-orchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/open-orchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-orchestra/subscriptions","organizations_url":"https://api.github.com/users/open-orchestra/orgs","repos_url":"https://api.github.com/users/open-orchestra/repos","events_url":"https://api.github.com/users/open-orchestra/events{/privacy}","received_events_url":"https://api.github.com/users/open-orchestra/received_events","type":"Organization","site_admin":false},"repo":{"id":21900253,"name":"open-orchestra-cms-bundle","full_name":"open-orchestra/open-orchestra-cms-bundle","owner":{"login":"open-orchestra","id":11756116,"avatar_url":"https://avatars.githubusercontent.com/u/11756116?v=3","gravatar_id":"","url":"https://api.github.com/users/open-orchestra","html_url":"https://github.com/open-orchestra","followers_url":"https://api.github.com/users/open-orchestra/followers","following_url":"https://api.github.com/users/open-orchestra/following{/other_user}","gists_url":"https://api.github.com/users/open-orchestra/gists{/gist_id}","starred_url":"https://api.github.com/users/open-orchestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-orchestra/subscriptions","organizations_url":"https://api.github.com/users/open-orchestra/orgs","repos_url":"https://api.github.com/users/open-orchestra/repos","events_url":"https://api.github.com/users/open-orchestra/events{/privacy}","received_events_url":"https://api.github.com/users/open-orchestra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle","description":"The php orchestra cms bundle","fork":false,"url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle","forks_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/forks","keys_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/teams","hooks_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/hooks","issue_events_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/events","assignees_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/tags","blobs_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/languages","stargazers_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/stargazers","contributors_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/contributors","subscribers_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/subscribers","subscription_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/subscription","commits_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/merges","archive_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/downloads","issues_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/labels{/name}","releases_url":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/releases{/id}","created_at":"2014-07-16T12:49:27Z","updated_at":"2015-05-07T08:02:31Z","pushed_at":"2015-07-10T13:44:04Z","git_url":"git://github.com/open-orchestra/open-orchestra-cms-bundle.git","ssh_url":"git@github.com:open-orchestra/open-orchestra-cms-bundle.git","clone_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle.git","svn_url":"https://github.com/open-orchestra/open-orchestra-cms-bundle","homepage":null,"size":24598,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/937"},"html":{"href":"https://github.com/open-orchestra/open-orchestra-cms-bundle/pull/937"},"issue":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/937"},"comments":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/issues/937/comments"},"review_comments":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/937/comments"},"review_comment":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/pulls/937/commits"},"statuses":{"href":"https://api.github.com/repos/open-orchestra/open-orchestra-cms-bundle/statuses/bf10e3d42e34e84e8f52020e5011b80e2845fd96"}}}}