{"action":"created","comment":{"url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/comments/26806253","id":26806253,"diff_hunk":"@@ -127,15 +127,16 @@\n \t\t * @private\n \t\t */\n \t\tfunction _removeHook( type, hook, callback, context ) {\n-\t\t\tif ( !STORAGE[ type ][ hook ] ) {\n+\t\t\tif ( ! (hook in STORAGE[ type ]) ) {","path":"src/event-manager.js","position":5,"original_position":5,"commit_id":"cace10cf62ee0b5cb737cd2f6c8a7adb2f12e2ef","original_commit_id":"cace10cf62ee0b5cb737cd2f6c8a7adb2f12e2ef","user":{"login":"carldanley","id":1470571,"avatar_url":"https://avatars.githubusercontent.com/u/1470571?v=3","gravatar_id":"","url":"https://api.github.com/users/carldanley","html_url":"https://github.com/carldanley","followers_url":"https://api.github.com/users/carldanley/followers","following_url":"https://api.github.com/users/carldanley/following{/other_user}","gists_url":"https://api.github.com/users/carldanley/gists{/gist_id}","starred_url":"https://api.github.com/users/carldanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carldanley/subscriptions","organizations_url":"https://api.github.com/users/carldanley/orgs","repos_url":"https://api.github.com/users/carldanley/repos","events_url":"https://api.github.com/users/carldanley/events{/privacy}","received_events_url":"https://api.github.com/users/carldanley/received_events","type":"User","site_admin":false},"body":"No real benefit to writing it this way.","created_at":"2015-03-19T22:57:11Z","updated_at":"2015-03-19T22:57:11Z","html_url":"https://github.com/carldanley/WP-JS-Hooks/pull/12#discussion_r26806253","pull_request_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/comments/26806253"},"html":{"href":"https://github.com/carldanley/WP-JS-Hooks/pull/12#discussion_r26806253"},"pull_request":{"href":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/12","id":13561461,"html_url":"https://github.com/carldanley/WP-JS-Hooks/pull/12","diff_url":"https://github.com/carldanley/WP-JS-Hooks/pull/12.diff","patch_url":"https://github.com/carldanley/WP-JS-Hooks/pull/12.patch","issue_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/issues/12","number":12,"state":"open","locked":false,"title":"Some type checks on arguments for _removeHook()","user":{"login":"mgiulio","id":99207,"avatar_url":"https://avatars.githubusercontent.com/u/99207?v=3","gravatar_id":"","url":"https://api.github.com/users/mgiulio","html_url":"https://github.com/mgiulio","followers_url":"https://api.github.com/users/mgiulio/followers","following_url":"https://api.github.com/users/mgiulio/following{/other_user}","gists_url":"https://api.github.com/users/mgiulio/gists{/gist_id}","starred_url":"https://api.github.com/users/mgiulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgiulio/subscriptions","organizations_url":"https://api.github.com/users/mgiulio/orgs","repos_url":"https://api.github.com/users/mgiulio/repos","events_url":"https://api.github.com/users/mgiulio/events{/privacy}","received_events_url":"https://api.github.com/users/mgiulio/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-03-14T08:36:49Z","updated_at":"2015-03-19T22:57:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b7906a276b5965de3d8a73bff647a1429ec95ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/12/commits","review_comments_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/12/comments","review_comment_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/issues/12/comments","statuses_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/statuses/cace10cf62ee0b5cb737cd2f6c8a7adb2f12e2ef","head":{"label":"mgiulio:more_strict_arg_checks","ref":"more_strict_arg_checks","sha":"cace10cf62ee0b5cb737cd2f6c8a7adb2f12e2ef","user":{"login":"mgiulio","id":99207,"avatar_url":"https://avatars.githubusercontent.com/u/99207?v=3","gravatar_id":"","url":"https://api.github.com/users/mgiulio","html_url":"https://github.com/mgiulio","followers_url":"https://api.github.com/users/mgiulio/followers","following_url":"https://api.github.com/users/mgiulio/following{/other_user}","gists_url":"https://api.github.com/users/mgiulio/gists{/gist_id}","starred_url":"https://api.github.com/users/mgiulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgiulio/subscriptions","organizations_url":"https://api.github.com/users/mgiulio/orgs","repos_url":"https://api.github.com/users/mgiulio/repos","events_url":"https://api.github.com/users/mgiulio/events{/privacy}","received_events_url":"https://api.github.com/users/mgiulio/received_events","type":"User","site_admin":false},"repo":{"id":16582481,"name":"WP-JS-Hooks","full_name":"mgiulio/WP-JS-Hooks","owner":{"login":"mgiulio","id":99207,"avatar_url":"https://avatars.githubusercontent.com/u/99207?v=3","gravatar_id":"","url":"https://api.github.com/users/mgiulio","html_url":"https://github.com/mgiulio","followers_url":"https://api.github.com/users/mgiulio/followers","following_url":"https://api.github.com/users/mgiulio/following{/other_user}","gists_url":"https://api.github.com/users/mgiulio/gists{/gist_id}","starred_url":"https://api.github.com/users/mgiulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgiulio/subscriptions","organizations_url":"https://api.github.com/users/mgiulio/orgs","repos_url":"https://api.github.com/users/mgiulio/repos","events_url":"https://api.github.com/users/mgiulio/events{/privacy}","received_events_url":"https://api.github.com/users/mgiulio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgiulio/WP-JS-Hooks","description":"A lightweight & efficient EventManager for JS in WP.","fork":true,"url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks","forks_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/forks","keys_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/teams","hooks_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/hooks","issue_events_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/issues/events{/number}","events_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/events","assignees_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/assignees{/user}","branches_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/branches{/branch}","tags_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/tags","blobs_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/statuses/{sha}","languages_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/languages","stargazers_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/stargazers","contributors_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/contributors","subscribers_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/subscribers","subscription_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/subscription","commits_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/contents/{+path}","compare_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/merges","archive_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/downloads","issues_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/issues{/number}","pulls_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/pulls{/number}","milestones_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/milestones{/number}","notifications_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/labels{/name}","releases_url":"https://api.github.com/repos/mgiulio/WP-JS-Hooks/releases{/id}","created_at":"2014-02-06T14:58:36Z","updated_at":"2014-03-14T09:05:45Z","pushed_at":"2014-03-14T09:05:22Z","git_url":"git://github.com/mgiulio/WP-JS-Hooks.git","ssh_url":"git@github.com:mgiulio/WP-JS-Hooks.git","clone_url":"https://github.com/mgiulio/WP-JS-Hooks.git","svn_url":"https://github.com/mgiulio/WP-JS-Hooks","homepage":null,"size":364,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"carldanley:master","ref":"master","sha":"8a864856bd55d2bd123d880b30304db27277bb3c","user":{"login":"carldanley","id":1470571,"avatar_url":"https://avatars.githubusercontent.com/u/1470571?v=3","gravatar_id":"","url":"https://api.github.com/users/carldanley","html_url":"https://github.com/carldanley","followers_url":"https://api.github.com/users/carldanley/followers","following_url":"https://api.github.com/users/carldanley/following{/other_user}","gists_url":"https://api.github.com/users/carldanley/gists{/gist_id}","starred_url":"https://api.github.com/users/carldanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carldanley/subscriptions","organizations_url":"https://api.github.com/users/carldanley/orgs","repos_url":"https://api.github.com/users/carldanley/repos","events_url":"https://api.github.com/users/carldanley/events{/privacy}","received_events_url":"https://api.github.com/users/carldanley/received_events","type":"User","site_admin":false},"repo":{"id":8526785,"name":"WP-JS-Hooks","full_name":"carldanley/WP-JS-Hooks","owner":{"login":"carldanley","id":1470571,"avatar_url":"https://avatars.githubusercontent.com/u/1470571?v=3","gravatar_id":"","url":"https://api.github.com/users/carldanley","html_url":"https://github.com/carldanley","followers_url":"https://api.github.com/users/carldanley/followers","following_url":"https://api.github.com/users/carldanley/following{/other_user}","gists_url":"https://api.github.com/users/carldanley/gists{/gist_id}","starred_url":"https://api.github.com/users/carldanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carldanley/subscriptions","organizations_url":"https://api.github.com/users/carldanley/orgs","repos_url":"https://api.github.com/users/carldanley/repos","events_url":"https://api.github.com/users/carldanley/events{/privacy}","received_events_url":"https://api.github.com/users/carldanley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carldanley/WP-JS-Hooks","description":"A lightweight & efficient EventManager for JS in WP.","fork":false,"url":"https://api.github.com/repos/carldanley/WP-JS-Hooks","forks_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/forks","keys_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/teams","hooks_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/hooks","issue_events_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/issues/events{/number}","events_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/events","assignees_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/assignees{/user}","branches_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/branches{/branch}","tags_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/tags","blobs_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/git/refs{/sha}","trees_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/statuses/{sha}","languages_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/languages","stargazers_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/stargazers","contributors_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/contributors","subscribers_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/subscribers","subscription_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/subscription","commits_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/commits{/sha}","git_commits_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/git/commits{/sha}","comments_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/comments{/number}","issue_comment_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/issues/comments{/number}","contents_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/contents/{+path}","compare_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/merges","archive_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/downloads","issues_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/issues{/number}","pulls_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls{/number}","milestones_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/milestones{/number}","notifications_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/labels{/name}","releases_url":"https://api.github.com/repos/carldanley/WP-JS-Hooks/releases{/id}","created_at":"2013-03-02T20:47:11Z","updated_at":"2015-03-19T22:55:56Z","pushed_at":"2015-03-19T22:55:55Z","git_url":"git://github.com/carldanley/WP-JS-Hooks.git","ssh_url":"git@github.com:carldanley/WP-JS-Hooks.git","clone_url":"https://github.com/carldanley/WP-JS-Hooks.git","svn_url":"https://github.com/carldanley/WP-JS-Hooks","homepage":null,"size":295,"stargazers_count":110,"watchers_count":110,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":9,"forks":12,"open_issues":9,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/12"},"html":{"href":"https://github.com/carldanley/WP-JS-Hooks/pull/12"},"issue":{"href":"https://api.github.com/repos/carldanley/WP-JS-Hooks/issues/12"},"comments":{"href":"https://api.github.com/repos/carldanley/WP-JS-Hooks/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/carldanley/WP-JS-Hooks/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/carldanley/WP-JS-Hooks/statuses/cace10cf62ee0b5cb737cd2f6c8a7adb2f12e2ef"}}}}