{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/121","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/121/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/121/events","html_url":"https://github.com/LMMS/lmms/issues/121","id":26209134,"number":121,"title":"Rename \"Song Editor\" to \"Sequencer\"","user":{"login":"unfa","id":491704,"avatar_url":"https://avatars.githubusercontent.com/u/491704?v=3","gravatar_id":"","url":"https://api.github.com/users/unfa","html_url":"https://github.com/unfa","followers_url":"https://api.github.com/users/unfa/followers","following_url":"https://api.github.com/users/unfa/following{/other_user}","gists_url":"https://api.github.com/users/unfa/gists{/gist_id}","starred_url":"https://api.github.com/users/unfa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unfa/subscriptions","organizations_url":"https://api.github.com/users/unfa/orgs","repos_url":"https://api.github.com/users/unfa/repos","events_url":"https://api.github.com/users/unfa/events{/privacy}","received_events_url":"https://api.github.com/users/unfa/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/LMMS/lmms/labels/enhancement","name":"enhancement","color":"0052cc"},{"url":"https://api.github.com/repos/LMMS/lmms/labels/ux","name":"ux","color":"2c974f"}],"state":"open","locked":false,"assignee":{"login":"pgiblock","id":290880,"avatar_url":"https://avatars.githubusercontent.com/u/290880?v=3","gravatar_id":"","url":"https://api.github.com/users/pgiblock","html_url":"https://github.com/pgiblock","followers_url":"https://api.github.com/users/pgiblock/followers","following_url":"https://api.github.com/users/pgiblock/following{/other_user}","gists_url":"https://api.github.com/users/pgiblock/gists{/gist_id}","starred_url":"https://api.github.com/users/pgiblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgiblock/subscriptions","organizations_url":"https://api.github.com/users/pgiblock/orgs","repos_url":"https://api.github.com/users/pgiblock/repos","events_url":"https://api.github.com/users/pgiblock/events{/privacy}","received_events_url":"https://api.github.com/users/pgiblock/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/LMMS/lmms/milestones/4","html_url":"https://github.com/LMMS/lmms/milestones/1.3.0","labels_url":"https://api.github.com/repos/LMMS/lmms/milestones/4/labels","id":614544,"number":4,"title":"1.3.0","description":"To be released during 1.10.2014 - 31.12.2014","creator":{"login":"diizy","id":6368868,"avatar_url":"https://avatars.githubusercontent.com/u/6368868?v=3","gravatar_id":"","url":"https://api.github.com/users/diizy","html_url":"https://github.com/diizy","followers_url":"https://api.github.com/users/diizy/followers","following_url":"https://api.github.com/users/diizy/following{/other_user}","gists_url":"https://api.github.com/users/diizy/gists{/gist_id}","starred_url":"https://api.github.com/users/diizy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diizy/subscriptions","organizations_url":"https://api.github.com/users/diizy/orgs","repos_url":"https://api.github.com/users/diizy/repos","events_url":"https://api.github.com/users/diizy/events{/privacy}","received_events_url":"https://api.github.com/users/diizy/received_events","type":"User","site_admin":false},"open_issues":82,"closed_issues":19,"state":"open","created_at":"2014-03-30T19:00:44Z","updated_at":"2015-08-24T16:15:13Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2014-01-23T23:51:42Z","updated_at":"2015-08-27T06:36:43Z","closed_at":null,"body":"The titles says it all.\r\nLet's have shorter and more universal names,"},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/135310829","html_url":"https://github.com/LMMS/lmms/issues/121#issuecomment-135310829","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/121","id":135310829,"user":{"login":"Wallacoloo","id":1210751,"avatar_url":"https://avatars.githubusercontent.com/u/1210751?v=3","gravatar_id":"","url":"https://api.github.com/users/Wallacoloo","html_url":"https://github.com/Wallacoloo","followers_url":"https://api.github.com/users/Wallacoloo/followers","following_url":"https://api.github.com/users/Wallacoloo/following{/other_user}","gists_url":"https://api.github.com/users/Wallacoloo/gists{/gist_id}","starred_url":"https://api.github.com/users/Wallacoloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wallacoloo/subscriptions","organizations_url":"https://api.github.com/users/Wallacoloo/orgs","repos_url":"https://api.github.com/users/Wallacoloo/repos","events_url":"https://api.github.com/users/Wallacoloo/events{/privacy}","received_events_url":"https://api.github.com/users/Wallacoloo/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T06:36:43Z","updated_at":"2015-08-27T06:36:43Z","body":"@tresf hmm. I haven't dug into the code too far yet, but if we were to reduce this to one string constant per editor, I would suspect it allows for more code reuse.\r\n\r\nFor example, we could add a virtual method, `editorName()` to the `Editor` class & implement that in all the subclasses. Then the Editor class can be responsible for setting the Window title instead of implementing that functionality in *every* subclass, we can create the `show/hide xxx` options in the view menu programatically - `tr (\"Show/Hide {1}\").arg(editor->name())`... I'm sure there are more areas that would benefit which I cannot yet think of."}}