{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/Localization/issues/92","labels_url":"https://api.github.com/repos/aspnet/Localization/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/Localization/issues/92/comments","events_url":"https://api.github.com/repos/aspnet/Localization/issues/92/events","html_url":"https://github.com/aspnet/Localization/issues/92","id":108411882,"number":92,"title":"Make 'ResourceManagerStringLocalizer' overload internal","user":{"login":"hishamco","id":3237266,"avatar_url":"https://avatars.githubusercontent.com/u/3237266?v=3","gravatar_id":"","url":"https://api.github.com/users/hishamco","html_url":"https://github.com/hishamco","followers_url":"https://api.github.com/users/hishamco/followers","following_url":"https://api.github.com/users/hishamco/following{/other_user}","gists_url":"https://api.github.com/users/hishamco/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamco/subscriptions","organizations_url":"https://api.github.com/users/hishamco/orgs","repos_url":"https://api.github.com/users/hishamco/repos","events_url":"https://api.github.com/users/hishamco/events{/privacy}","received_events_url":"https://api.github.com/users/hishamco/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-09-25T21:35:26Z","updated_at":"2015-09-28T06:46:39Z","closed_at":"2015-09-26T17:20:51Z","body":"After the PR #91 and while we have InternalsVisibleTo in this line of https://github.com/aspnet/Localization/blob/dev/src/Microsoft.Framework.Localization/Properties/AssemblyInfo.cs#L8, it will be nice to modify the access modifier for ResourceManagerStringLocalizer in https://github.com/aspnet/Localization/blob/dev/src/Microsoft.Framework.Localization/ResourceManagerStringLocalizer.cs#L49 to internal rather than public because the intend for this overload to be used for testing purpose only\r\n/cc @kirthik "},"comment":{"url":"https://api.github.com/repos/aspnet/Localization/issues/comments/143653687","html_url":"https://github.com/aspnet/Localization/issues/92#issuecomment-143653687","issue_url":"https://api.github.com/repos/aspnet/Localization/issues/92","id":143653687,"user":{"login":"hishamco","id":3237266,"avatar_url":"https://avatars.githubusercontent.com/u/3237266?v=3","gravatar_id":"","url":"https://api.github.com/users/hishamco","html_url":"https://github.com/hishamco","followers_url":"https://api.github.com/users/hishamco/followers","following_url":"https://api.github.com/users/hishamco/following{/other_user}","gists_url":"https://api.github.com/users/hishamco/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamco/subscriptions","organizations_url":"https://api.github.com/users/hishamco/orgs","repos_url":"https://api.github.com/users/hishamco/repos","events_url":"https://api.github.com/users/hishamco/events{/privacy}","received_events_url":"https://api.github.com/users/hishamco/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T06:46:39Z","updated_at":"2015-09-28T06:46:39Z","body":"Thanks for this clarification @Eilon "}}