{"action":"closed","number":64,"pull_request":{"url":"https://api.github.com/repos/smicallef/spiderfoot/pulls/64","id":32722821,"html_url":"https://github.com/smicallef/spiderfoot/pull/64","diff_url":"https://github.com/smicallef/spiderfoot/pull/64.diff","patch_url":"https://github.com/smicallef/spiderfoot/pull/64.patch","issue_url":"https://api.github.com/repos/smicallef/spiderfoot/issues/64","number":64,"state":"closed","locked":false,"title":"PEP and Performance","user":{"login":"Gormogon","id":8905868,"avatar_url":"https://avatars.githubusercontent.com/u/8905868?v=3","gravatar_id":"","url":"https://api.github.com/users/Gormogon","html_url":"https://github.com/Gormogon","followers_url":"https://api.github.com/users/Gormogon/followers","following_url":"https://api.github.com/users/Gormogon/following{/other_user}","gists_url":"https://api.github.com/users/Gormogon/gists{/gist_id}","starred_url":"https://api.github.com/users/Gormogon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gormogon/subscriptions","organizations_url":"https://api.github.com/users/Gormogon/orgs","repos_url":"https://api.github.com/users/Gormogon/repos","events_url":"https://api.github.com/users/Gormogon/events{/privacy}","received_events_url":"https://api.github.com/users/Gormogon/received_events","type":"User","site_admin":false},"body":"Simplifies a few things, fixes more PEP violations, and improves performance a little, and the addition of __future__ imports.\r\n\r\nSimplifying assignment:\r\n* Augmented Assignment: 4d0c43e250e1118a895edefe95ccadd462f295fe\r\n\r\nPEP Violation Fixes:\r\n* PEP 8 – Comparison to 'None': 7bc2ddc7266e159c912636ffaa0a28edab60ab39\r\n* PEP 263 – File Encoding: f18a50d1642fcc7c85f71350316a9af770ea7841\r\n* More PEP Violation Fixes: 297ece1bab4d55d7fdc920ab04bbc886799c2849\r\n\r\nReplaced empty Dictionary 'dict()'and List 'list()' creation with '{}' and '[]', as this is far more efficient:\r\n* Dictionary '{}' Instead of 'dict()': fd33bc2d7aac76b256fc364025cf16cd3d4f9a12\r\n```\r\npython2 -m timeit -n 1000000 -r 5 -v 'dict()' \r\nraw times: 0.137 0.0916 0.0806 0.0807 0.0806\r\n1000000 loops, best of 5: 0.0806 usec per loop\r\n\r\npython2 -m timeit -n 1000000 -r 5 -v '{}' \r\nraw times: 0.0517 0.0419 0.0362 0.0323 0.0295\r\n1000000 loops, best of 5: 0.0295 usec per loop\r\n```\r\n* List '[]' Instead of 'list()': 353d27f1c593ceb7ba49c63039529a9ac113c659\r\n```\r\npython2 -m timeit -n 1000000 -r 5 -v 'list()'\r\nraw times: 0.141 0.0933 0.0897 0.0897 0.0899\r\n1000000 loops, best of 5: 0.0897 usec per loop\r\n\r\npython2 -m timeit -n 1000000 -r 5 -v '[]'    \r\nraw times: 0.0504 0.0407 0.0353 0.0316 0.0288\r\n1000000 loops, best of 5: 0.0288 usec per loop\r\n```\r\n\r\nFor some unfathomable reason Git is acting like I modified the entire file, my assumption is that the line ending was converted from the Windows '\\r\\n' to the Unix '\\n'.  Ultimately this doesn't matter, but I wanted to assure you that I indeed only added a few __future__ imports and converted the 'print' statements to Python 3 syntax to ease the transition to Python 3 in the future.  Unfortunately, I would have to blow away all of my changes to resolve what Git did.:\r\n* __future__ for Python 3 Transition: 46fdf01a1e69aff045e55e60e3579cb40003a9fa\r\n* https://docs.python.org/2/library/__future__.html\r\n* __NOTE!: This change was rolled back with 46fdf01a1e69aff045e55e60e3579cb40003a9fa as 'modernize' modified the line-endings, rendering changes indistinguishable from unchanged code in the diff.__\r\n\r\nMisc Changes:\r\n* Rewrite as Dictionary Literal: b55160cd9e34a4e3a3c62291d74185189b3091a6\r\n* Fix Classic Style Class Usage: b0a2cfd1f4da8f9fb63a08817d2341d32f7dd17f","created_at":"2015-04-07T00:00:02Z","updated_at":"2015-06-21T22:36:12Z","closed_at":"2015-06-21T22:36:12Z","merged_at":null,"merge_commit_sha":"f8173ce313f606426029bf483d68270457991f13","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/smicallef/spiderfoot/pulls/64/commits","review_comments_url":"https://api.github.com/repos/smicallef/spiderfoot/pulls/64/comments","review_comment_url":"https://api.github.com/repos/smicallef/spiderfoot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smicallef/spiderfoot/issues/64/comments","statuses_url":"https://api.github.com/repos/smicallef/spiderfoot/statuses/98d212d5a545276e27a99cceee2325157b584c04","head":{"label":"Gormogon:master","ref":"master","sha":"98d212d5a545276e27a99cceee2325157b584c04","user":{"login":"Gormogon","id":8905868,"avatar_url":"https://avatars.githubusercontent.com/u/8905868?v=3","gravatar_id":"","url":"https://api.github.com/users/Gormogon","html_url":"https://github.com/Gormogon","followers_url":"https://api.github.com/users/Gormogon/followers","following_url":"https://api.github.com/users/Gormogon/following{/other_user}","gists_url":"https://api.github.com/users/Gormogon/gists{/gist_id}","starred_url":"https://api.github.com/users/Gormogon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gormogon/subscriptions","organizations_url":"https://api.github.com/users/Gormogon/orgs","repos_url":"https://api.github.com/users/Gormogon/repos","events_url":"https://api.github.com/users/Gormogon/events{/privacy}","received_events_url":"https://api.github.com/users/Gormogon/received_events","type":"User","site_admin":false},"repo":{"id":32245490,"name":"spiderfoot","full_name":"Gormogon/spiderfoot","owner":{"login":"Gormogon","id":8905868,"avatar_url":"https://avatars.githubusercontent.com/u/8905868?v=3","gravatar_id":"","url":"https://api.github.com/users/Gormogon","html_url":"https://github.com/Gormogon","followers_url":"https://api.github.com/users/Gormogon/followers","following_url":"https://api.github.com/users/Gormogon/following{/other_user}","gists_url":"https://api.github.com/users/Gormogon/gists{/gist_id}","starred_url":"https://api.github.com/users/Gormogon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gormogon/subscriptions","organizations_url":"https://api.github.com/users/Gormogon/orgs","repos_url":"https://api.github.com/users/Gormogon/repos","events_url":"https://api.github.com/users/Gormogon/events{/privacy}","received_events_url":"https://api.github.com/users/Gormogon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gormogon/spiderfoot","description":"SpiderFoot, the open source footprinting and intelligence-gathering  tool.","fork":true,"url":"https://api.github.com/repos/Gormogon/spiderfoot","forks_url":"https://api.github.com/repos/Gormogon/spiderfoot/forks","keys_url":"https://api.github.com/repos/Gormogon/spiderfoot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gormogon/spiderfoot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gormogon/spiderfoot/teams","hooks_url":"https://api.github.com/repos/Gormogon/spiderfoot/hooks","issue_events_url":"https://api.github.com/repos/Gormogon/spiderfoot/issues/events{/number}","events_url":"https://api.github.com/repos/Gormogon/spiderfoot/events","assignees_url":"https://api.github.com/repos/Gormogon/spiderfoot/assignees{/user}","branches_url":"https://api.github.com/repos/Gormogon/spiderfoot/branches{/branch}","tags_url":"https://api.github.com/repos/Gormogon/spiderfoot/tags","blobs_url":"https://api.github.com/repos/Gormogon/spiderfoot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gormogon/spiderfoot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gormogon/spiderfoot/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gormogon/spiderfoot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gormogon/spiderfoot/statuses/{sha}","languages_url":"https://api.github.com/repos/Gormogon/spiderfoot/languages","stargazers_url":"https://api.github.com/repos/Gormogon/spiderfoot/stargazers","contributors_url":"https://api.github.com/repos/Gormogon/spiderfoot/contributors","subscribers_url":"https://api.github.com/repos/Gormogon/spiderfoot/subscribers","subscription_url":"https://api.github.com/repos/Gormogon/spiderfoot/subscription","commits_url":"https://api.github.com/repos/Gormogon/spiderfoot/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gormogon/spiderfoot/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gormogon/spiderfoot/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gormogon/spiderfoot/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gormogon/spiderfoot/contents/{+path}","compare_url":"https://api.github.com/repos/Gormogon/spiderfoot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gormogon/spiderfoot/merges","archive_url":"https://api.github.com/repos/Gormogon/spiderfoot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gormogon/spiderfoot/downloads","issues_url":"https://api.github.com/repos/Gormogon/spiderfoot/issues{/number}","pulls_url":"https://api.github.com/repos/Gormogon/spiderfoot/pulls{/number}","milestones_url":"https://api.github.com/repos/Gormogon/spiderfoot/milestones{/number}","notifications_url":"https://api.github.com/repos/Gormogon/spiderfoot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gormogon/spiderfoot/labels{/name}","releases_url":"https://api.github.com/repos/Gormogon/spiderfoot/releases{/id}","created_at":"2015-03-15T04:48:31Z","updated_at":"2015-04-08T23:11:50Z","pushed_at":"2015-04-08T23:11:50Z","git_url":"git://github.com/Gormogon/spiderfoot.git","ssh_url":"git@github.com:Gormogon/spiderfoot.git","clone_url":"https://github.com/Gormogon/spiderfoot.git","svn_url":"https://github.com/Gormogon/spiderfoot","homepage":"http://www.spiderfoot.net","size":2694,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smicallef:master","ref":"master","sha":"70fdab4ee6ec54e218ee4ca885935a8235247dbb","user":{"login":"smicallef","id":1687345,"avatar_url":"https://avatars.githubusercontent.com/u/1687345?v=3","gravatar_id":"","url":"https://api.github.com/users/smicallef","html_url":"https://github.com/smicallef","followers_url":"https://api.github.com/users/smicallef/followers","following_url":"https://api.github.com/users/smicallef/following{/other_user}","gists_url":"https://api.github.com/users/smicallef/gists{/gist_id}","starred_url":"https://api.github.com/users/smicallef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smicallef/subscriptions","organizations_url":"https://api.github.com/users/smicallef/orgs","repos_url":"https://api.github.com/users/smicallef/repos","events_url":"https://api.github.com/users/smicallef/events{/privacy}","received_events_url":"https://api.github.com/users/smicallef/received_events","type":"User","site_admin":false},"repo":{"id":4165675,"name":"spiderfoot","full_name":"smicallef/spiderfoot","owner":{"login":"smicallef","id":1687345,"avatar_url":"https://avatars.githubusercontent.com/u/1687345?v=3","gravatar_id":"","url":"https://api.github.com/users/smicallef","html_url":"https://github.com/smicallef","followers_url":"https://api.github.com/users/smicallef/followers","following_url":"https://api.github.com/users/smicallef/following{/other_user}","gists_url":"https://api.github.com/users/smicallef/gists{/gist_id}","starred_url":"https://api.github.com/users/smicallef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smicallef/subscriptions","organizations_url":"https://api.github.com/users/smicallef/orgs","repos_url":"https://api.github.com/users/smicallef/repos","events_url":"https://api.github.com/users/smicallef/events{/privacy}","received_events_url":"https://api.github.com/users/smicallef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smicallef/spiderfoot","description":"SpiderFoot, the open source footprinting and intelligence-gathering  tool.","fork":false,"url":"https://api.github.com/repos/smicallef/spiderfoot","forks_url":"https://api.github.com/repos/smicallef/spiderfoot/forks","keys_url":"https://api.github.com/repos/smicallef/spiderfoot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smicallef/spiderfoot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smicallef/spiderfoot/teams","hooks_url":"https://api.github.com/repos/smicallef/spiderfoot/hooks","issue_events_url":"https://api.github.com/repos/smicallef/spiderfoot/issues/events{/number}","events_url":"https://api.github.com/repos/smicallef/spiderfoot/events","assignees_url":"https://api.github.com/repos/smicallef/spiderfoot/assignees{/user}","branches_url":"https://api.github.com/repos/smicallef/spiderfoot/branches{/branch}","tags_url":"https://api.github.com/repos/smicallef/spiderfoot/tags","blobs_url":"https://api.github.com/repos/smicallef/spiderfoot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smicallef/spiderfoot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smicallef/spiderfoot/git/refs{/sha}","trees_url":"https://api.github.com/repos/smicallef/spiderfoot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smicallef/spiderfoot/statuses/{sha}","languages_url":"https://api.github.com/repos/smicallef/spiderfoot/languages","stargazers_url":"https://api.github.com/repos/smicallef/spiderfoot/stargazers","contributors_url":"https://api.github.com/repos/smicallef/spiderfoot/contributors","subscribers_url":"https://api.github.com/repos/smicallef/spiderfoot/subscribers","subscription_url":"https://api.github.com/repos/smicallef/spiderfoot/subscription","commits_url":"https://api.github.com/repos/smicallef/spiderfoot/commits{/sha}","git_commits_url":"https://api.github.com/repos/smicallef/spiderfoot/git/commits{/sha}","comments_url":"https://api.github.com/repos/smicallef/spiderfoot/comments{/number}","issue_comment_url":"https://api.github.com/repos/smicallef/spiderfoot/issues/comments{/number}","contents_url":"https://api.github.com/repos/smicallef/spiderfoot/contents/{+path}","compare_url":"https://api.github.com/repos/smicallef/spiderfoot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smicallef/spiderfoot/merges","archive_url":"https://api.github.com/repos/smicallef/spiderfoot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smicallef/spiderfoot/downloads","issues_url":"https://api.github.com/repos/smicallef/spiderfoot/issues{/number}","pulls_url":"https://api.github.com/repos/smicallef/spiderfoot/pulls{/number}","milestones_url":"https://api.github.com/repos/smicallef/spiderfoot/milestones{/number}","notifications_url":"https://api.github.com/repos/smicallef/spiderfoot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smicallef/spiderfoot/labels{/name}","releases_url":"https://api.github.com/repos/smicallef/spiderfoot/releases{/id}","created_at":"2012-04-28T07:10:13Z","updated_at":"2015-06-17T06:54:34Z","pushed_at":"2015-05-31T11:01:24Z","git_url":"git://github.com/smicallef/spiderfoot.git","ssh_url":"git@github.com:smicallef/spiderfoot.git","clone_url":"https://github.com/smicallef/spiderfoot.git","svn_url":"https://github.com/smicallef/spiderfoot","homepage":"http://www.spiderfoot.net","size":4108,"stargazers_count":362,"watchers_count":362,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":9,"forks":82,"open_issues":9,"watchers":362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smicallef/spiderfoot/pulls/64"},"html":{"href":"https://github.com/smicallef/spiderfoot/pull/64"},"issue":{"href":"https://api.github.com/repos/smicallef/spiderfoot/issues/64"},"comments":{"href":"https://api.github.com/repos/smicallef/spiderfoot/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/smicallef/spiderfoot/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/smicallef/spiderfoot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smicallef/spiderfoot/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/smicallef/spiderfoot/statuses/98d212d5a545276e27a99cceee2325157b584c04"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":11,"additions":216,"deletions":226,"changed_files":44}}