{"action":"created","comment":{"url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/comments/38186595","id":38186595,"diff_hunk":"@@ -0,0 +1,11 @@\n+(function(d3, fc) {\n+    'use strict';\n+    sc.menu.option = function(displayString, valueString, option) {\n+        return {\n+            displayString: displayString,\n+            valueString: valueString,\n+            option: option\n+        };\n+    };","path":"src/assets/js/menu/option.js","position":9,"original_position":9,"commit_id":"e970bbd62eb564f0becc97c9e888658ecc6bf2cf","original_commit_id":"e970bbd62eb564f0becc97c9e888658ecc6bf2cf","user":{"login":"djmiley","id":13115186,"avatar_url":"https://avatars.githubusercontent.com/u/13115186?v=3","gravatar_id":"","url":"https://api.github.com/users/djmiley","html_url":"https://github.com/djmiley","followers_url":"https://api.github.com/users/djmiley/followers","following_url":"https://api.github.com/users/djmiley/following{/other_user}","gists_url":"https://api.github.com/users/djmiley/gists{/gist_id}","starred_url":"https://api.github.com/users/djmiley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmiley/subscriptions","organizations_url":"https://api.github.com/users/djmiley/orgs","repos_url":"https://api.github.com/users/djmiley/repos","events_url":"https://api.github.com/users/djmiley/events{/privacy}","received_events_url":"https://api.github.com/users/djmiley/received_events","type":"User","site_admin":false},"body":"Was just thinking about this last night! :+1: ","created_at":"2015-08-28T10:07:53Z","updated_at":"2015-08-28T10:07:53Z","html_url":"https://github.com/ScottLogic/d3fc-showcase/pull/194#discussion_r38186595","pull_request_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/194","_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/comments/38186595"},"html":{"href":"https://github.com/ScottLogic/d3fc-showcase/pull/194#discussion_r38186595"},"pull_request":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/194","id":43611634,"html_url":"https://github.com/ScottLogic/d3fc-showcase/pull/194","diff_url":"https://github.com/ScottLogic/d3fc-showcase/pull/194.diff","patch_url":"https://github.com/ScottLogic/d3fc-showcase/pull/194.patch","issue_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/194","number":194,"state":"open","locked":false,"title":"Modularise menu","user":{"login":"jleft","id":2017615,"avatar_url":"https://avatars.githubusercontent.com/u/2017615?v=3","gravatar_id":"","url":"https://api.github.com/users/jleft","html_url":"https://github.com/jleft","followers_url":"https://api.github.com/users/jleft/followers","following_url":"https://api.github.com/users/jleft/following{/other_user}","gists_url":"https://api.github.com/users/jleft/gists{/gist_id}","starred_url":"https://api.github.com/users/jleft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleft/subscriptions","organizations_url":"https://api.github.com/users/jleft/orgs","repos_url":"https://api.github.com/users/jleft/repos","events_url":"https://api.github.com/users/jleft/events{/privacy}","received_events_url":"https://api.github.com/users/jleft/received_events","type":"User","site_admin":false},"body":"A continuation of #157. Also adds:\r\n\r\n- A top-level menu component, to handle the main menu\r\n- Use of option generators moved out of main and into separate modules for each menu section\r\n- A more generic 'option' class for use with the option generator\r\n\r\nStill TODO: all of the logic for changing the data source is still in main - I think this should be pulled out into its own module - if we're in agreement, another issue can be created for this.","created_at":"2015-08-28T09:57:04Z","updated_at":"2015-08-28T10:07:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14ae9b9edf50e28cde2e1e820b07da66ef1134d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/194/commits","review_comments_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/194/comments","review_comment_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/194/comments","statuses_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/statuses/e970bbd62eb564f0becc97c9e888658ecc6bf2cf","head":{"label":"jleft:feature/modularise-menu","ref":"feature/modularise-menu","sha":"e970bbd62eb564f0becc97c9e888658ecc6bf2cf","user":{"login":"jleft","id":2017615,"avatar_url":"https://avatars.githubusercontent.com/u/2017615?v=3","gravatar_id":"","url":"https://api.github.com/users/jleft","html_url":"https://github.com/jleft","followers_url":"https://api.github.com/users/jleft/followers","following_url":"https://api.github.com/users/jleft/following{/other_user}","gists_url":"https://api.github.com/users/jleft/gists{/gist_id}","starred_url":"https://api.github.com/users/jleft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleft/subscriptions","organizations_url":"https://api.github.com/users/jleft/orgs","repos_url":"https://api.github.com/users/jleft/repos","events_url":"https://api.github.com/users/jleft/events{/privacy}","received_events_url":"https://api.github.com/users/jleft/received_events","type":"User","site_admin":false},"repo":{"id":39064295,"name":"d3fc-showcase","full_name":"jleft/d3fc-showcase","owner":{"login":"jleft","id":2017615,"avatar_url":"https://avatars.githubusercontent.com/u/2017615?v=3","gravatar_id":"","url":"https://api.github.com/users/jleft","html_url":"https://github.com/jleft","followers_url":"https://api.github.com/users/jleft/followers","following_url":"https://api.github.com/users/jleft/following{/other_user}","gists_url":"https://api.github.com/users/jleft/gists{/gist_id}","starred_url":"https://api.github.com/users/jleft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleft/subscriptions","organizations_url":"https://api.github.com/users/jleft/orgs","repos_url":"https://api.github.com/users/jleft/repos","events_url":"https://api.github.com/users/jleft/events{/privacy}","received_events_url":"https://api.github.com/users/jleft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jleft/d3fc-showcase","description":"A cross-platform financial charting application to showcase the functionality of d3fc components.","fork":true,"url":"https://api.github.com/repos/jleft/d3fc-showcase","forks_url":"https://api.github.com/repos/jleft/d3fc-showcase/forks","keys_url":"https://api.github.com/repos/jleft/d3fc-showcase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jleft/d3fc-showcase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jleft/d3fc-showcase/teams","hooks_url":"https://api.github.com/repos/jleft/d3fc-showcase/hooks","issue_events_url":"https://api.github.com/repos/jleft/d3fc-showcase/issues/events{/number}","events_url":"https://api.github.com/repos/jleft/d3fc-showcase/events","assignees_url":"https://api.github.com/repos/jleft/d3fc-showcase/assignees{/user}","branches_url":"https://api.github.com/repos/jleft/d3fc-showcase/branches{/branch}","tags_url":"https://api.github.com/repos/jleft/d3fc-showcase/tags","blobs_url":"https://api.github.com/repos/jleft/d3fc-showcase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jleft/d3fc-showcase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jleft/d3fc-showcase/git/refs{/sha}","trees_url":"https://api.github.com/repos/jleft/d3fc-showcase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jleft/d3fc-showcase/statuses/{sha}","languages_url":"https://api.github.com/repos/jleft/d3fc-showcase/languages","stargazers_url":"https://api.github.com/repos/jleft/d3fc-showcase/stargazers","contributors_url":"https://api.github.com/repos/jleft/d3fc-showcase/contributors","subscribers_url":"https://api.github.com/repos/jleft/d3fc-showcase/subscribers","subscription_url":"https://api.github.com/repos/jleft/d3fc-showcase/subscription","commits_url":"https://api.github.com/repos/jleft/d3fc-showcase/commits{/sha}","git_commits_url":"https://api.github.com/repos/jleft/d3fc-showcase/git/commits{/sha}","comments_url":"https://api.github.com/repos/jleft/d3fc-showcase/comments{/number}","issue_comment_url":"https://api.github.com/repos/jleft/d3fc-showcase/issues/comments{/number}","contents_url":"https://api.github.com/repos/jleft/d3fc-showcase/contents/{+path}","compare_url":"https://api.github.com/repos/jleft/d3fc-showcase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jleft/d3fc-showcase/merges","archive_url":"https://api.github.com/repos/jleft/d3fc-showcase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jleft/d3fc-showcase/downloads","issues_url":"https://api.github.com/repos/jleft/d3fc-showcase/issues{/number}","pulls_url":"https://api.github.com/repos/jleft/d3fc-showcase/pulls{/number}","milestones_url":"https://api.github.com/repos/jleft/d3fc-showcase/milestones{/number}","notifications_url":"https://api.github.com/repos/jleft/d3fc-showcase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jleft/d3fc-showcase/labels{/name}","releases_url":"https://api.github.com/repos/jleft/d3fc-showcase/releases{/id}","created_at":"2015-07-14T08:52:13Z","updated_at":"2015-07-22T10:02:40Z","pushed_at":"2015-08-28T10:01:13Z","git_url":"git://github.com/jleft/d3fc-showcase.git","ssh_url":"git@github.com:jleft/d3fc-showcase.git","clone_url":"https://github.com/jleft/d3fc-showcase.git","svn_url":"https://github.com/jleft/d3fc-showcase","homepage":"","size":712,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ScottLogic:develop","ref":"develop","sha":"66d020ba39cdd0654330b7c77d24be77e1c1e850","user":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":39064095,"name":"d3fc-showcase","full_name":"ScottLogic/d3fc-showcase","owner":{"login":"ScottLogic","id":2046037,"avatar_url":"https://avatars.githubusercontent.com/u/2046037?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottLogic","html_url":"https://github.com/ScottLogic","followers_url":"https://api.github.com/users/ScottLogic/followers","following_url":"https://api.github.com/users/ScottLogic/following{/other_user}","gists_url":"https://api.github.com/users/ScottLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottLogic/subscriptions","organizations_url":"https://api.github.com/users/ScottLogic/orgs","repos_url":"https://api.github.com/users/ScottLogic/repos","events_url":"https://api.github.com/users/ScottLogic/events{/privacy}","received_events_url":"https://api.github.com/users/ScottLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScottLogic/d3fc-showcase","description":"A cross-platform financial charting application to showcase the functionality of d3fc components.","fork":false,"url":"https://api.github.com/repos/ScottLogic/d3fc-showcase","forks_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/forks","keys_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/teams","hooks_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/hooks","issue_events_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/events{/number}","events_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/events","assignees_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/assignees{/user}","branches_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/branches{/branch}","tags_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/tags","blobs_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/languages","stargazers_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/stargazers","contributors_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/contributors","subscribers_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/subscribers","subscription_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/subscription","commits_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/contents/{+path}","compare_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/merges","archive_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/downloads","issues_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues{/number}","pulls_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/labels{/name}","releases_url":"https://api.github.com/repos/ScottLogic/d3fc-showcase/releases{/id}","created_at":"2015-07-14T08:47:46Z","updated_at":"2015-08-27T07:19:46Z","pushed_at":"2015-08-28T10:02:09Z","git_url":"git://github.com/ScottLogic/d3fc-showcase.git","ssh_url":"git@github.com:ScottLogic/d3fc-showcase.git","clone_url":"https://github.com/ScottLogic/d3fc-showcase.git","svn_url":"https://github.com/ScottLogic/d3fc-showcase","homepage":"http://scottlogic.github.io/d3fc-showcase/","size":1945,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":58,"forks":4,"open_issues":58,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/194"},"html":{"href":"https://github.com/ScottLogic/d3fc-showcase/pull/194"},"issue":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/194"},"comments":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/ScottLogic/d3fc-showcase/statuses/e970bbd62eb564f0becc97c9e888658ecc6bf2cf"}}}}