{"action":"created","issue":{"url":"https://api.github.com/repos/martinisgroup/servers/issues/101","labels_url":"https://api.github.com/repos/martinisgroup/servers/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/martinisgroup/servers/issues/101/comments","events_url":"https://api.github.com/repos/martinisgroup/servers/issues/101/events","html_url":"https://github.com/martinisgroup/servers/pull/101","id":69048257,"number":101,"title":"GHzFPGA.run: Enable ADC Average Mode","user":{"login":"jwenner","id":8183919,"avatar_url":"https://avatars.githubusercontent.com/u/8183919?v=3","gravatar_id":"","url":"https://api.github.com/users/jwenner","html_url":"https://github.com/jwenner","followers_url":"https://api.github.com/users/jwenner/followers","following_url":"https://api.github.com/users/jwenner/following{/other_user}","gists_url":"https://api.github.com/users/jwenner/gists{/gist_id}","starred_url":"https://api.github.com/users/jwenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwenner/subscriptions","organizations_url":"https://api.github.com/users/jwenner/orgs","repos_url":"https://api.github.com/users/jwenner/repos","events_url":"https://api.github.com/users/jwenner/events{/privacy}","received_events_url":"https://api.github.com/users/jwenner/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/martinisgroup/servers/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/martinisgroup/servers/labels/critical","name":"critical","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-17T02:23:10Z","updated_at":"2015-04-20T22:48:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/martinisgroup/servers/pulls/101","html_url":"https://github.com/martinisgroup/servers/pull/101","diff_url":"https://github.com/martinisgroup/servers/pull/101.diff","patch_url":"https://github.com/martinisgroup/servers/pull/101.patch"},"body":"Fixes #100.\r\n\r\nIn FPGA server/run (and hence run_sequence), if ADC in average mode so that no demod channel specified, raised 'channel format not understood' exception. Now add elif case in getTimingData so if ADC is present in channel name but not :: (for demodulation), can still return data. Move calls to channel to if statement for if channel defined. Amend return format type for run_sequence to also allow '*3i' for average mode data.\r\n\r\nNote that in going between demod and average modes (although in different scans & calls to run_sequence), it seems to work fine (although it's possible I might not be seeing/knowing what @JulianSKelly was referring to)."},"comment":{"url":"https://api.github.com/repos/martinisgroup/servers/issues/comments/94586379","html_url":"https://github.com/martinisgroup/servers/pull/101#issuecomment-94586379","issue_url":"https://api.github.com/repos/martinisgroup/servers/issues/101","id":94586379,"user":{"login":"jwenner","id":8183919,"avatar_url":"https://avatars.githubusercontent.com/u/8183919?v=3","gravatar_id":"","url":"https://api.github.com/users/jwenner","html_url":"https://github.com/jwenner","followers_url":"https://api.github.com/users/jwenner/followers","following_url":"https://api.github.com/users/jwenner/following{/other_user}","gists_url":"https://api.github.com/users/jwenner/gists{/gist_id}","starred_url":"https://api.github.com/users/jwenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwenner/subscriptions","organizations_url":"https://api.github.com/users/jwenner/orgs","repos_url":"https://api.github.com/users/jwenner/repos","events_url":"https://api.github.com/users/jwenner/events{/privacy}","received_events_url":"https://api.github.com/users/jwenner/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T22:48:32Z","updated_at":"2015-04-20T22:48:32Z","body":"@DanielSank, the dimensions from run_sequence appear to be as follows:\r\n   * demod: [demodChannel, trialNumber, data?, data?]\r\n   * average: [demodChannel, IOrQ, data]\r\n\r\nI would propose that we instead make the average mode data 4-dimensional of the same form as demod (i.e., [demodChannel, trialNumber, IOrQ, data]), with the length=1 in the demodChannel and trialNumber dimensions. The reason would be so that we could (maybe?) take average mode & demod mode data at the same time on different ADCs (e.g., measure qubit state &, say, resonator reflection at the same time).\r\n\r\nWould changing any of this (in any direction) require changes in the qubit sequencer server?\r\n\r\nThanks."}}