{"push_id":724860988,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"8c39f1487461fb366e6156955f5045ee9f71c1a9","before":"28d218d7ed00be0e15de29ee3083f184c6c3d1c6","commits":[{"sha":"8c39f1487461fb366e6156955f5045ee9f71c1a9","author":{"email":"caba3e8952f4d2ea63e2f01a984f1577eb19f143@redhat.com","name":"Kaushal M"},"message":"rpc-transport: socket_poller fixes for proper working of mgmt encryption\n\nsocket_poller, the polling function used by ssl own_thread, had two\nissues which lead to GlusterD crashes when using management encryption\n\nIssue 1\n-------\nsocket_poller calls functions which require THIS to be set. But, THIS\nwas being set conditionally. Because of this, functions could sometimes\nbe called without THIS being set. For example, rpc_transport_notify\ncould be called for an accepted client socket without THIS being set, as\nTHIS was only set it the transport wasn't yet connected. This would\ncause the process to crash when THIS was accessed by the called\nfunctions.\n\nTo fix this, THIS is being set at the start of socket_poller\nunconditionally.\n\nIssue 2\n-------\nDISCONNECT notify was being sent on the listener transport instead of\nthe client transport. The DISCONNECT event was converted to a\nLISTENER_DEAD event in rpcsvc_handle_disconnect, as it could not find\nthe listener socket of the listener socket. GlusterD was notified of a\nLISTENER_DEAD event instead of a DISCONNECT and failed to remove the\nclient transport from its xprt_list. The transport would subsequently\nbe freed, leaving the xprt_list with a corrupted/invalid entry. Later,\nwhen GlusterD would iterate over the xprt_list to send notifications, it\nwould crash when the invalid entry was accessed.\n\nTo fix this, DISCONNECT notification in socket_poller is sent on the\nclient socket, as it is done in the epoll handler.\n\nChange-Id: I0370b7c6d7eb13de10ebf08d91a4a39dc7d64c7a\nBUG: 1242570\nSigned-off-by: Kaushal M <kaushal@redhat.com>\nReviewed-on: http://review.gluster.org/11650\nTested-by: NetBSD Build System <jenkins@build.gluster.org>\nReviewed-by: Krishnan Parthasarathi <kparthas@redhat.com>\nReviewed-by: Raghavendra G <rgowdapp@redhat.com>","distinct":true,"url":"https://api.github.com/repos/gluster/glusterfs/commits/8c39f1487461fb366e6156955f5045ee9f71c1a9"}]}