{"action":"created","issue":{"url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/57","labels_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/57/comments","events_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/57/events","html_url":"https://github.com/DigitalPebble/storm-crawler/pull/57","id":54395699,"number":57,"title":"Pass in the Storm config when configuring ParseFilters","user":{"login":"GuiForget","id":2585258,"avatar_url":"https://avatars.githubusercontent.com/u/2585258?v=3","gravatar_id":"","url":"https://api.github.com/users/GuiForget","html_url":"https://github.com/GuiForget","followers_url":"https://api.github.com/users/GuiForget/followers","following_url":"https://api.github.com/users/GuiForget/following{/other_user}","gists_url":"https://api.github.com/users/GuiForget/gists{/gist_id}","starred_url":"https://api.github.com/users/GuiForget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuiForget/subscriptions","organizations_url":"https://api.github.com/users/GuiForget/orgs","repos_url":"https://api.github.com/users/GuiForget/repos","events_url":"https://api.github.com/users/GuiForget/events{/privacy}","received_events_url":"https://api.github.com/users/GuiForget/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-15T00:07:22Z","updated_at":"2015-01-15T00:08:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/57","html_url":"https://github.com/DigitalPebble/storm-crawler/pull/57","diff_url":"https://github.com/DigitalPebble/storm-crawler/pull/57.diff","patch_url":"https://github.com/DigitalPebble/storm-crawler/pull/57.patch"},"body":"A ParseFilter may want to access the Storm config during its config phase. To\r\nthat end the interface is changed to receive both the Storm config as well as\r\nthe Filter's parameters.\r\n\r\nAlso I changed ParseFilters to always call configure on the ParseFilter even\r\nif there are no params defined. I think the original difference was too subtle\r\nand therefore error prone. To make it easy on the ParseFiler, the paramsNode\r\nis set to a NullNode.\r\n\r\nFixes #56"},"comment":{"url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/comments/70018103","html_url":"https://github.com/DigitalPebble/storm-crawler/pull/57#issuecomment-70018103","issue_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/57","id":70018103,"user":{"login":"GuiForget","id":2585258,"avatar_url":"https://avatars.githubusercontent.com/u/2585258?v=3","gravatar_id":"","url":"https://api.github.com/users/GuiForget","html_url":"https://github.com/GuiForget","followers_url":"https://api.github.com/users/GuiForget/followers","following_url":"https://api.github.com/users/GuiForget/following{/other_user}","gists_url":"https://api.github.com/users/GuiForget/gists{/gist_id}","starred_url":"https://api.github.com/users/GuiForget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GuiForget/subscriptions","organizations_url":"https://api.github.com/users/GuiForget/orgs","repos_url":"https://api.github.com/users/GuiForget/repos","events_url":"https://api.github.com/users/GuiForget/events{/privacy}","received_events_url":"https://api.github.com/users/GuiForget/received_events","type":"User","site_admin":false},"created_at":"2015-01-15T00:08:00Z","updated_at":"2015-01-15T00:08:00Z","body":"After propagating all the changes to my own project, I gained confidence that this change is rock solid :)"}}