{"action":"closed","number":4977,"pull_request":{"url":"https://api.github.com/repos/rg3/youtube-dl/pulls/4977","id":29500664,"html_url":"https://github.com/rg3/youtube-dl/pull/4977","diff_url":"https://github.com/rg3/youtube-dl/pull/4977.diff","patch_url":"https://github.com/rg3/youtube-dl/pull/4977.patch","issue_url":"https://api.github.com/repos/rg3/youtube-dl/issues/4977","number":4977,"state":"closed","locked":false,"title":"Fix _remove_comments regex because of function that has “/*” in it:","user":{"login":"HyShai","id":1154806,"avatar_url":"https://avatars.githubusercontent.com/u/1154806?v=3","gravatar_id":"","url":"https://api.github.com/users/HyShai","html_url":"https://github.com/HyShai","followers_url":"https://api.github.com/users/HyShai/followers","following_url":"https://api.github.com/users/HyShai/following{/other_user}","gists_url":"https://api.github.com/users/HyShai/gists{/gist_id}","starred_url":"https://api.github.com/users/HyShai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyShai/subscriptions","organizations_url":"https://api.github.com/users/HyShai/orgs","repos_url":"https://api.github.com/users/HyShai/repos","events_url":"https://api.github.com/users/HyShai/events{/privacy}","received_events_url":"https://api.github.com/users/HyShai/received_events","type":"User","site_admin":false},"body":"This function has a couple of \"/*\" in it that is throwing off the regex to remove comments. This only happens occasionally - one video threw an exception but that same video worked fine on a different IP address. So I don't think this should be a permanent fix, but until we narrow down the issue this can be a workaround.\r\n\r\nThis fixes #4976 \r\n\r\n```javascript\r\nfunction LB(a) {\r\n        if (\"undefined\" != typeof a.selectNodes) {\r\n            var b = Ad(a);\r\n            \"undefined\" != typeof b.setProperty && b.setProperty(\"SelectionLanguage\", \"XPath\");\r\n            return a.selectNodes('vmap:Extensions/vmap:Extension[@type = \"YTBreakTime\"]/*[name() = \"yt:BreakTime\"]')\r\n        }\r\n        if (document.implementation.hasFeature(\"XPath\", \"3.0\")) {\r\n            var b = Ad(a),\r\n                c = b.createNSResolver(b.documentElement);\r\n            a = b.evaluate('vmap:Extensions/vmap:Extension[@type = \"YTBreakTime\"]/*[name() = \"yt:BreakTime\"]', a, c, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);\r\n            for (var b = [], c = a.snapshotLength, d = 0; d < c; d++) b.push(a.snapshotItem(d));\r\n            return b\r\n        }\r\n        return []\r\n    }\r\n```","created_at":"2015-02-18T04:31:50Z","updated_at":"2015-02-18T09:55:10Z","closed_at":"2015-02-18T09:55:10Z","merged_at":null,"merge_commit_sha":"bc0d3e96ff2f1e78456a35f7137957c785487c32","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/4977/commits","review_comments_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/4977/comments","review_comment_url":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rg3/youtube-dl/issues/4977/comments","statuses_url":"https://api.github.com/repos/rg3/youtube-dl/statuses/f3e5d9dcd3d6c0fba7a68d8897510956df7627c4","head":{"label":"HyShai:master","ref":"master","sha":"f3e5d9dcd3d6c0fba7a68d8897510956df7627c4","user":{"login":"HyShai","id":1154806,"avatar_url":"https://avatars.githubusercontent.com/u/1154806?v=3","gravatar_id":"","url":"https://api.github.com/users/HyShai","html_url":"https://github.com/HyShai","followers_url":"https://api.github.com/users/HyShai/followers","following_url":"https://api.github.com/users/HyShai/following{/other_user}","gists_url":"https://api.github.com/users/HyShai/gists{/gist_id}","starred_url":"https://api.github.com/users/HyShai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyShai/subscriptions","organizations_url":"https://api.github.com/users/HyShai/orgs","repos_url":"https://api.github.com/users/HyShai/repos","events_url":"https://api.github.com/users/HyShai/events{/privacy}","received_events_url":"https://api.github.com/users/HyShai/received_events","type":"User","site_admin":false},"repo":{"id":29873426,"name":"youtube-dl","full_name":"HyShai/youtube-dl","owner":{"login":"HyShai","id":1154806,"avatar_url":"https://avatars.githubusercontent.com/u/1154806?v=3","gravatar_id":"","url":"https://api.github.com/users/HyShai","html_url":"https://github.com/HyShai","followers_url":"https://api.github.com/users/HyShai/followers","following_url":"https://api.github.com/users/HyShai/following{/other_user}","gists_url":"https://api.github.com/users/HyShai/gists{/gist_id}","starred_url":"https://api.github.com/users/HyShai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyShai/subscriptions","organizations_url":"https://api.github.com/users/HyShai/orgs","repos_url":"https://api.github.com/users/HyShai/repos","events_url":"https://api.github.com/users/HyShai/events{/privacy}","received_events_url":"https://api.github.com/users/HyShai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HyShai/youtube-dl","description":"Small command-line program to download videos from YouTube.com and other video sites","fork":true,"url":"https://api.github.com/repos/HyShai/youtube-dl","forks_url":"https://api.github.com/repos/HyShai/youtube-dl/forks","keys_url":"https://api.github.com/repos/HyShai/youtube-dl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HyShai/youtube-dl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HyShai/youtube-dl/teams","hooks_url":"https://api.github.com/repos/HyShai/youtube-dl/hooks","issue_events_url":"https://api.github.com/repos/HyShai/youtube-dl/issues/events{/number}","events_url":"https://api.github.com/repos/HyShai/youtube-dl/events","assignees_url":"https://api.github.com/repos/HyShai/youtube-dl/assignees{/user}","branches_url":"https://api.github.com/repos/HyShai/youtube-dl/branches{/branch}","tags_url":"https://api.github.com/repos/HyShai/youtube-dl/tags","blobs_url":"https://api.github.com/repos/HyShai/youtube-dl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HyShai/youtube-dl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HyShai/youtube-dl/git/refs{/sha}","trees_url":"https://api.github.com/repos/HyShai/youtube-dl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HyShai/youtube-dl/statuses/{sha}","languages_url":"https://api.github.com/repos/HyShai/youtube-dl/languages","stargazers_url":"https://api.github.com/repos/HyShai/youtube-dl/stargazers","contributors_url":"https://api.github.com/repos/HyShai/youtube-dl/contributors","subscribers_url":"https://api.github.com/repos/HyShai/youtube-dl/subscribers","subscription_url":"https://api.github.com/repos/HyShai/youtube-dl/subscription","commits_url":"https://api.github.com/repos/HyShai/youtube-dl/commits{/sha}","git_commits_url":"https://api.github.com/repos/HyShai/youtube-dl/git/commits{/sha}","comments_url":"https://api.github.com/repos/HyShai/youtube-dl/comments{/number}","issue_comment_url":"https://api.github.com/repos/HyShai/youtube-dl/issues/comments/{number}","contents_url":"https://api.github.com/repos/HyShai/youtube-dl/contents/{+path}","compare_url":"https://api.github.com/repos/HyShai/youtube-dl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HyShai/youtube-dl/merges","archive_url":"https://api.github.com/repos/HyShai/youtube-dl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HyShai/youtube-dl/downloads","issues_url":"https://api.github.com/repos/HyShai/youtube-dl/issues{/number}","pulls_url":"https://api.github.com/repos/HyShai/youtube-dl/pulls{/number}","milestones_url":"https://api.github.com/repos/HyShai/youtube-dl/milestones{/number}","notifications_url":"https://api.github.com/repos/HyShai/youtube-dl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HyShai/youtube-dl/labels{/name}","releases_url":"https://api.github.com/repos/HyShai/youtube-dl/releases{/id}","created_at":"2015-01-26T17:45:34Z","updated_at":"2015-02-10T21:40:12Z","pushed_at":"2015-02-18T04:18:04Z","git_url":"git://github.com/HyShai/youtube-dl.git","ssh_url":"git@github.com:HyShai/youtube-dl.git","clone_url":"https://github.com/HyShai/youtube-dl.git","svn_url":"https://github.com/HyShai/youtube-dl","homepage":"http://rg3.github.io/youtube-dl/","size":29539,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"ytdl-pythonista"}},"base":{"label":"rg3:master","ref":"master","sha":"9cad27008b88b5ba3dfb1d747d7476b05582f385","user":{"login":"rg3","id":53487,"avatar_url":"https://avatars.githubusercontent.com/u/53487?v=3","gravatar_id":"","url":"https://api.github.com/users/rg3","html_url":"https://github.com/rg3","followers_url":"https://api.github.com/users/rg3/followers","following_url":"https://api.github.com/users/rg3/following{/other_user}","gists_url":"https://api.github.com/users/rg3/gists{/gist_id}","starred_url":"https://api.github.com/users/rg3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rg3/subscriptions","organizations_url":"https://api.github.com/users/rg3/orgs","repos_url":"https://api.github.com/users/rg3/repos","events_url":"https://api.github.com/users/rg3/events{/privacy}","received_events_url":"https://api.github.com/users/rg3/received_events","type":"User","site_admin":false},"repo":{"id":1039520,"name":"youtube-dl","full_name":"rg3/youtube-dl","owner":{"login":"rg3","id":53487,"avatar_url":"https://avatars.githubusercontent.com/u/53487?v=3","gravatar_id":"","url":"https://api.github.com/users/rg3","html_url":"https://github.com/rg3","followers_url":"https://api.github.com/users/rg3/followers","following_url":"https://api.github.com/users/rg3/following{/other_user}","gists_url":"https://api.github.com/users/rg3/gists{/gist_id}","starred_url":"https://api.github.com/users/rg3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rg3/subscriptions","organizations_url":"https://api.github.com/users/rg3/orgs","repos_url":"https://api.github.com/users/rg3/repos","events_url":"https://api.github.com/users/rg3/events{/privacy}","received_events_url":"https://api.github.com/users/rg3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rg3/youtube-dl","description":"Small command-line program to download videos from YouTube.com and other video sites","fork":false,"url":"https://api.github.com/repos/rg3/youtube-dl","forks_url":"https://api.github.com/repos/rg3/youtube-dl/forks","keys_url":"https://api.github.com/repos/rg3/youtube-dl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rg3/youtube-dl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rg3/youtube-dl/teams","hooks_url":"https://api.github.com/repos/rg3/youtube-dl/hooks","issue_events_url":"https://api.github.com/repos/rg3/youtube-dl/issues/events{/number}","events_url":"https://api.github.com/repos/rg3/youtube-dl/events","assignees_url":"https://api.github.com/repos/rg3/youtube-dl/assignees{/user}","branches_url":"https://api.github.com/repos/rg3/youtube-dl/branches{/branch}","tags_url":"https://api.github.com/repos/rg3/youtube-dl/tags","blobs_url":"https://api.github.com/repos/rg3/youtube-dl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rg3/youtube-dl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rg3/youtube-dl/git/refs{/sha}","trees_url":"https://api.github.com/repos/rg3/youtube-dl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rg3/youtube-dl/statuses/{sha}","languages_url":"https://api.github.com/repos/rg3/youtube-dl/languages","stargazers_url":"https://api.github.com/repos/rg3/youtube-dl/stargazers","contributors_url":"https://api.github.com/repos/rg3/youtube-dl/contributors","subscribers_url":"https://api.github.com/repos/rg3/youtube-dl/subscribers","subscription_url":"https://api.github.com/repos/rg3/youtube-dl/subscription","commits_url":"https://api.github.com/repos/rg3/youtube-dl/commits{/sha}","git_commits_url":"https://api.github.com/repos/rg3/youtube-dl/git/commits{/sha}","comments_url":"https://api.github.com/repos/rg3/youtube-dl/comments{/number}","issue_comment_url":"https://api.github.com/repos/rg3/youtube-dl/issues/comments/{number}","contents_url":"https://api.github.com/repos/rg3/youtube-dl/contents/{+path}","compare_url":"https://api.github.com/repos/rg3/youtube-dl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rg3/youtube-dl/merges","archive_url":"https://api.github.com/repos/rg3/youtube-dl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rg3/youtube-dl/downloads","issues_url":"https://api.github.com/repos/rg3/youtube-dl/issues{/number}","pulls_url":"https://api.github.com/repos/rg3/youtube-dl/pulls{/number}","milestones_url":"https://api.github.com/repos/rg3/youtube-dl/milestones{/number}","notifications_url":"https://api.github.com/repos/rg3/youtube-dl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rg3/youtube-dl/labels{/name}","releases_url":"https://api.github.com/repos/rg3/youtube-dl/releases{/id}","created_at":"2010-10-31T14:35:07Z","updated_at":"2015-02-18T09:55:09Z","pushed_at":"2015-02-18T09:55:09Z","git_url":"git://github.com/rg3/youtube-dl.git","ssh_url":"git@github.com:rg3/youtube-dl.git","clone_url":"https://github.com/rg3/youtube-dl.git","svn_url":"https://github.com/rg3/youtube-dl","homepage":"http://rg3.github.io/youtube-dl/","size":67074,"stargazers_count":8374,"watchers_count":8374,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1645,"mirror_url":null,"open_issues_count":997,"forks":1645,"open_issues":997,"watchers":8374,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/4977"},"html":{"href":"https://github.com/rg3/youtube-dl/pull/4977"},"issue":{"href":"https://api.github.com/repos/rg3/youtube-dl/issues/4977"},"comments":{"href":"https://api.github.com/repos/rg3/youtube-dl/issues/4977/comments"},"review_comments":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/4977/comments"},"review_comment":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rg3/youtube-dl/pulls/4977/commits"},"statuses":{"href":"https://api.github.com/repos/rg3/youtube-dl/statuses/f3e5d9dcd3d6c0fba7a68d8897510956df7627c4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}