{"action":"created","issue":{"url":"https://api.github.com/repos/thoughtbot/json-matchers/issues/16","labels_url":"https://api.github.com/repos/thoughtbot/json-matchers/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/thoughtbot/json-matchers/issues/16/comments","events_url":"https://api.github.com/repos/thoughtbot/json-matchers/issues/16/events","html_url":"https://github.com/thoughtbot/json-matchers/pull/16","id":109541019,"number":16,"title":"Transition from `JSON::Matchers` to `JsonMatchers`","user":{"login":"seanpdoyle","id":2575027,"avatar_url":"https://avatars.githubusercontent.com/u/2575027?v=3","gravatar_id":"","url":"https://api.github.com/users/seanpdoyle","html_url":"https://github.com/seanpdoyle","followers_url":"https://api.github.com/users/seanpdoyle/followers","following_url":"https://api.github.com/users/seanpdoyle/following{/other_user}","gists_url":"https://api.github.com/users/seanpdoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/seanpdoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanpdoyle/subscriptions","organizations_url":"https://api.github.com/users/seanpdoyle/orgs","repos_url":"https://api.github.com/users/seanpdoyle/repos","events_url":"https://api.github.com/users/seanpdoyle/events{/privacy}","received_events_url":"https://api.github.com/users/seanpdoyle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-02T18:01:10Z","updated_at":"2015-10-02T18:06:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thoughtbot/json-matchers/pulls/16","html_url":"https://github.com/thoughtbot/json-matchers/pull/16","diff_url":"https://github.com/thoughtbot/json-matchers/pull/16.diff","patch_url":"https://github.com/thoughtbot/json-matchers/pull/16.patch"},"body":"**BREAKING CHANGE**\r\n\r\nRename module to `JsonMatchers`. This resolves clashing with gems like\r\n`oj` / `oj_mimic_json` that take control of the standard library's\r\n`json` module. As a result, the file to require is now `json_matchers`,\r\ninstead of `json/matchers`.\r\n\r\nThis should leave clients largely unaffected, since their usage of the\r\ngem is based around `require \"json/matchers\"` and using a globally\r\naccessible `match_response_schema`.\r\n\r\nThe only real difference is that the gem name (`json-matchers`) is no\r\nlonger aligned with Ruby conventions around module nesting. As a\r\nconsumer, I would expect the gem name to be `json_matchers`.\r\n\r\nFor backwards compatibility, this PR introduces the `json/matchers` file\r\nas an alias for `json_matchers`, so that consumers can still call\r\n`require \"json/matchers\"`.\r\n\r\nFor compatibility with the gem name, consumers can also call `require\r\n\"json-matchers\"`, which is aliased to `require \"json_matchers\"`."},"comment":{"url":"https://api.github.com/repos/thoughtbot/json-matchers/issues/comments/145108148","html_url":"https://github.com/thoughtbot/json-matchers/pull/16#issuecomment-145108148","issue_url":"https://api.github.com/repos/thoughtbot/json-matchers/issues/16","id":145108148,"user":{"login":"seanpdoyle","id":2575027,"avatar_url":"https://avatars.githubusercontent.com/u/2575027?v=3","gravatar_id":"","url":"https://api.github.com/users/seanpdoyle","html_url":"https://github.com/seanpdoyle","followers_url":"https://api.github.com/users/seanpdoyle/followers","following_url":"https://api.github.com/users/seanpdoyle/following{/other_user}","gists_url":"https://api.github.com/users/seanpdoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/seanpdoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanpdoyle/subscriptions","organizations_url":"https://api.github.com/users/seanpdoyle/orgs","repos_url":"https://api.github.com/users/seanpdoyle/repos","events_url":"https://api.github.com/users/seanpdoyle/events{/privacy}","received_events_url":"https://api.github.com/users/seanpdoyle/received_events","type":"User","site_admin":false},"created_at":"2015-10-02T18:06:19Z","updated_at":"2015-10-02T18:06:19Z","body":"@mike-burns thanks. Do you have strong opinions about the gem's name vs its module structure?\r\n\r\nThat is to say `json-matchers` -> `JSON::Matchers` vs `json_matchers` -> `JsonMatchers`?"}}