{"action":"created","issue":{"url":"https://api.github.com/repos/rackerlabs/otter/issues/1512","labels_url":"https://api.github.com/repos/rackerlabs/otter/issues/1512/labels{/name}","comments_url":"https://api.github.com/repos/rackerlabs/otter/issues/1512/comments","events_url":"https://api.github.com/repos/rackerlabs/otter/issues/1512/events","html_url":"https://github.com/rackerlabs/otter/pull/1512","id":89382592,"number":1512,"title":"Fail when adding nodes to a CLB results in a node limit error (please review after #1524)","user":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-18T19:54:48Z","updated_at":"2015-06-23T20:48:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rackerlabs/otter/pulls/1512","html_url":"https://github.com/rackerlabs/otter/pull/1512","diff_url":"https://github.com/rackerlabs/otter/pull/1512.diff","patch_url":"https://github.com/rackerlabs/otter/pull/1512.patch"},"body":"If the are more 25 nodes on a CLB and convergence tries to add more, then the step should fail and convergence should put the group into ERROR.\r\n\r\nSince we're touching the add nodes code anyway, I moved it to cloud_client as per #1189.\r\n\r\nThis makes it so that all 4XX errors, unless we know we can retry, fail.  Other errors are retried.\r\n\r\nFixes #1214.  I think this also fixes #1244 and #1260. "},"comment":{"url":"https://api.github.com/repos/rackerlabs/otter/issues/comments/114637836","html_url":"https://github.com/rackerlabs/otter/pull/1512#issuecomment-114637836","issue_url":"https://api.github.com/repos/rackerlabs/otter/issues/1512","id":114637836,"user":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T20:48:48Z","updated_at":"2015-06-23T20:48:48Z","body":"Ok, this is probably ready for review again.  #1513 still passes with master merged in and changes."}}