{"action":"created","issue":{"url":"https://api.github.com/repos/RealFaviconGenerator/rails_real_favicon/issues/3","labels_url":"https://api.github.com/repos/RealFaviconGenerator/rails_real_favicon/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/RealFaviconGenerator/rails_real_favicon/issues/3/comments","events_url":"https://api.github.com/repos/RealFaviconGenerator/rails_real_favicon/issues/3/events","html_url":"https://github.com/RealFaviconGenerator/rails_real_favicon/pull/3","id":120277079,"number":3,"title":"Rails 3 support","user":{"login":"keithlayne","id":2667202,"avatar_url":"https://avatars.githubusercontent.com/u/2667202?v=3","gravatar_id":"","url":"https://api.github.com/users/keithlayne","html_url":"https://github.com/keithlayne","followers_url":"https://api.github.com/users/keithlayne/followers","following_url":"https://api.github.com/users/keithlayne/following{/other_user}","gists_url":"https://api.github.com/users/keithlayne/gists{/gist_id}","starred_url":"https://api.github.com/users/keithlayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithlayne/subscriptions","organizations_url":"https://api.github.com/users/keithlayne/orgs","repos_url":"https://api.github.com/users/keithlayne/repos","events_url":"https://api.github.com/users/keithlayne/events{/privacy}","received_events_url":"https://api.github.com/users/keithlayne/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-03T21:45:26Z","updated_at":"2015-12-04T09:25:27Z","closed_at":"2015-12-04T09:20:36Z","pull_request":{"url":"https://api.github.com/repos/RealFaviconGenerator/rails_real_favicon/pulls/3","html_url":"https://github.com/RealFaviconGenerator/rails_real_favicon/pull/3","diff_url":"https://github.com/RealFaviconGenerator/rails_real_favicon/pull/3.diff","patch_url":"https://github.com/RealFaviconGenerator/rails_real_favicon/pull/3.patch"},"body":"This PR would allow this great gem to work with Rails 3.\r\n\r\nChanges:\r\n* Loosen the restriction on the Rails version in the gemspec.\r\n* Remove `Gemfile.lock` from the repo.  \r\n* Don't `require 'rails/all` in the dummy app.  When you clone this gem and bundle, the tests fail because it wants to load ActiveRecord and there's no database configured.  This takes care of that.\r\n* Remove all references to the other Rails libs in the Dummy app, like ActionController, ActionMailer, etc.  so that they don't cause the tests to fail.\r\n\r\nI ran the tests against rails 3.2.22 and 4.2.5, and they all still passed.  I can confirm that the gem is working correctly (so far) with a Rails 3.2 app.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/RealFaviconGenerator/rails_real_favicon/issues/comments/161917996","html_url":"https://github.com/RealFaviconGenerator/rails_real_favicon/pull/3#issuecomment-161917996","issue_url":"https://api.github.com/repos/RealFaviconGenerator/rails_real_favicon/issues/3","id":161917996,"user":{"login":"phbernard","id":423852,"avatar_url":"https://avatars.githubusercontent.com/u/423852?v=3","gravatar_id":"","url":"https://api.github.com/users/phbernard","html_url":"https://github.com/phbernard","followers_url":"https://api.github.com/users/phbernard/followers","following_url":"https://api.github.com/users/phbernard/following{/other_user}","gists_url":"https://api.github.com/users/phbernard/gists{/gist_id}","starred_url":"https://api.github.com/users/phbernard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phbernard/subscriptions","organizations_url":"https://api.github.com/users/phbernard/orgs","repos_url":"https://api.github.com/users/phbernard/repos","events_url":"https://api.github.com/users/phbernard/events{/privacy}","received_events_url":"https://api.github.com/users/phbernard/received_events","type":"User","site_admin":false},"created_at":"2015-12-04T09:25:27Z","updated_at":"2015-12-04T09:25:27Z","body":"Great! Thank you very much for the PR!\r\n\r\nI tested the Gem against two versions of RoR:\r\n\r\n- 3.0 : it doesn't work because `asset_path` is missing. Plus the partial can't be used as is (it needs to be referenced with `application/favicon` and not `favicon`). Not a big deal but this makes the usage more complex. I didn't investigated any further.\r\n- 3.1 : it works as is.\r\n\r\nSo I changed the dependency to `>= 3.1` in the gemspec."}}