{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/cache/pulls/comments/40397557","id":40397557,"diff_hunk":"@@ -126,9 +114,9 @@ protected function getFilename($id)\n     {\n         return $this->directory\n             . DIRECTORY_SEPARATOR\n-            . implode(str_split(hash('sha256', $id), 2), DIRECTORY_SEPARATOR)\n+            . substr(hash('sha256', $id), 0, 2)\n             . DIRECTORY_SEPARATOR\n-            . preg_replace($this->disallowedCharacterPatterns, $this->replacementCharacters, $id)\n+            . str_replace('.', '%2E', rawurlencode($id))","path":"lib/Doctrine/Common/Cache/FileCache.php","position":45,"original_position":45,"commit_id":"7e92c6349727874c97f445af57886e34387de97a","original_commit_id":"7e92c6349727874c97f445af57886e34387de97a","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"body":"As per discussion, needs encoding of uppercase ascii. Actually, to simplify, can't we have encoding of all chars?","created_at":"2015-09-25T03:45:36Z","updated_at":"2015-09-25T03:45:36Z","html_url":"https://github.com/doctrine/cache/pull/94#discussion_r40397557","pull_request_url":"https://api.github.com/repos/doctrine/cache/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/doctrine/cache/pulls/comments/40397557"},"html":{"href":"https://github.com/doctrine/cache/pull/94#discussion_r40397557"},"pull_request":{"href":"https://api.github.com/repos/doctrine/cache/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/cache/pulls/94","id":45962541,"html_url":"https://github.com/doctrine/cache/pull/94","diff_url":"https://github.com/doctrine/cache/pull/94.diff","patch_url":"https://github.com/doctrine/cache/pull/94.patch","issue_url":"https://api.github.com/repos/doctrine/cache/issues/94","number":94,"state":"open","locked":false,"title":"fix file naming based on cache key","user":{"login":"Tobion","id":610090,"avatar_url":"https://avatars.githubusercontent.com/u/610090?v=3","gravatar_id":"","url":"https://api.github.com/users/Tobion","html_url":"https://github.com/Tobion","followers_url":"https://api.github.com/users/Tobion/followers","following_url":"https://api.github.com/users/Tobion/following{/other_user}","gists_url":"https://api.github.com/users/Tobion/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobion/subscriptions","organizations_url":"https://api.github.com/users/Tobion/orgs","repos_url":"https://api.github.com/users/Tobion/repos","events_url":"https://api.github.com/users/Tobion/events{/privacy}","received_events_url":"https://api.github.com/users/Tobion/received_events","type":"User","site_admin":false},"body":"Replaces #68 and #63\r\n\r\nSee comments on PR lines.","created_at":"2015-09-24T23:30:58Z","updated_at":"2015-09-25T03:45:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"441ccc829331aea2818b726c59eaf2d87fb0388b","assignee":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/doctrine/cache/milestones/4","html_url":"https://github.com/doctrine/cache/milestones/1.5.0","labels_url":"https://api.github.com/repos/doctrine/cache/milestones/4/labels","id":937418,"number":4,"title":"1.5.0","description":"","creator":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2015-01-15T21:00:06Z","updated_at":"2015-09-24T23:33:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/doctrine/cache/pulls/94/commits","review_comments_url":"https://api.github.com/repos/doctrine/cache/pulls/94/comments","review_comment_url":"https://api.github.com/repos/doctrine/cache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/cache/issues/94/comments","statuses_url":"https://api.github.com/repos/doctrine/cache/statuses/7e92c6349727874c97f445af57886e34387de97a","head":{"label":"Tobion:fix-file-cache","ref":"fix-file-cache","sha":"7e92c6349727874c97f445af57886e34387de97a","user":{"login":"Tobion","id":610090,"avatar_url":"https://avatars.githubusercontent.com/u/610090?v=3","gravatar_id":"","url":"https://api.github.com/users/Tobion","html_url":"https://github.com/Tobion","followers_url":"https://api.github.com/users/Tobion/followers","following_url":"https://api.github.com/users/Tobion/following{/other_user}","gists_url":"https://api.github.com/users/Tobion/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobion/subscriptions","organizations_url":"https://api.github.com/users/Tobion/orgs","repos_url":"https://api.github.com/users/Tobion/repos","events_url":"https://api.github.com/users/Tobion/events{/privacy}","received_events_url":"https://api.github.com/users/Tobion/received_events","type":"User","site_admin":false},"repo":{"id":42344011,"name":"cache","full_name":"Tobion/cache","owner":{"login":"Tobion","id":610090,"avatar_url":"https://avatars.githubusercontent.com/u/610090?v=3","gravatar_id":"","url":"https://api.github.com/users/Tobion","html_url":"https://github.com/Tobion","followers_url":"https://api.github.com/users/Tobion/followers","following_url":"https://api.github.com/users/Tobion/following{/other_user}","gists_url":"https://api.github.com/users/Tobion/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobion/subscriptions","organizations_url":"https://api.github.com/users/Tobion/orgs","repos_url":"https://api.github.com/users/Tobion/repos","events_url":"https://api.github.com/users/Tobion/events{/privacy}","received_events_url":"https://api.github.com/users/Tobion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tobion/cache","description":"Doctrine Cache component","fork":true,"url":"https://api.github.com/repos/Tobion/cache","forks_url":"https://api.github.com/repos/Tobion/cache/forks","keys_url":"https://api.github.com/repos/Tobion/cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tobion/cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tobion/cache/teams","hooks_url":"https://api.github.com/repos/Tobion/cache/hooks","issue_events_url":"https://api.github.com/repos/Tobion/cache/issues/events{/number}","events_url":"https://api.github.com/repos/Tobion/cache/events","assignees_url":"https://api.github.com/repos/Tobion/cache/assignees{/user}","branches_url":"https://api.github.com/repos/Tobion/cache/branches{/branch}","tags_url":"https://api.github.com/repos/Tobion/cache/tags","blobs_url":"https://api.github.com/repos/Tobion/cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tobion/cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tobion/cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tobion/cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tobion/cache/statuses/{sha}","languages_url":"https://api.github.com/repos/Tobion/cache/languages","stargazers_url":"https://api.github.com/repos/Tobion/cache/stargazers","contributors_url":"https://api.github.com/repos/Tobion/cache/contributors","subscribers_url":"https://api.github.com/repos/Tobion/cache/subscribers","subscription_url":"https://api.github.com/repos/Tobion/cache/subscription","commits_url":"https://api.github.com/repos/Tobion/cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tobion/cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tobion/cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tobion/cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tobion/cache/contents/{+path}","compare_url":"https://api.github.com/repos/Tobion/cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tobion/cache/merges","archive_url":"https://api.github.com/repos/Tobion/cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tobion/cache/downloads","issues_url":"https://api.github.com/repos/Tobion/cache/issues{/number}","pulls_url":"https://api.github.com/repos/Tobion/cache/pulls{/number}","milestones_url":"https://api.github.com/repos/Tobion/cache/milestones{/number}","notifications_url":"https://api.github.com/repos/Tobion/cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tobion/cache/labels{/name}","releases_url":"https://api.github.com/repos/Tobion/cache/releases{/id}","created_at":"2015-09-12T04:03:27Z","updated_at":"2015-09-12T04:03:30Z","pushed_at":"2015-09-25T01:28:22Z","git_url":"git://github.com/Tobion/cache.git","ssh_url":"git@github.com:Tobion/cache.git","clone_url":"https://github.com/Tobion/cache.git","svn_url":"https://github.com/Tobion/cache","homepage":null,"size":364,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"dd47003641aa5425820c0ec8a6f4a85e7412ffcd","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":7550057,"name":"cache","full_name":"doctrine/cache","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/cache","description":"Doctrine Cache component","fork":false,"url":"https://api.github.com/repos/doctrine/cache","forks_url":"https://api.github.com/repos/doctrine/cache/forks","keys_url":"https://api.github.com/repos/doctrine/cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/cache/teams","hooks_url":"https://api.github.com/repos/doctrine/cache/hooks","issue_events_url":"https://api.github.com/repos/doctrine/cache/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/cache/events","assignees_url":"https://api.github.com/repos/doctrine/cache/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/cache/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/cache/tags","blobs_url":"https://api.github.com/repos/doctrine/cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/cache/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/cache/languages","stargazers_url":"https://api.github.com/repos/doctrine/cache/stargazers","contributors_url":"https://api.github.com/repos/doctrine/cache/contributors","subscribers_url":"https://api.github.com/repos/doctrine/cache/subscribers","subscription_url":"https://api.github.com/repos/doctrine/cache/subscription","commits_url":"https://api.github.com/repos/doctrine/cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/cache/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/cache/merges","archive_url":"https://api.github.com/repos/doctrine/cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/cache/downloads","issues_url":"https://api.github.com/repos/doctrine/cache/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/cache/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/cache/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/cache/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/cache/releases{/id}","created_at":"2013-01-10T22:37:43Z","updated_at":"2015-09-24T14:13:39Z","pushed_at":"2015-09-25T01:28:23Z","git_url":"git://github.com/doctrine/cache.git","ssh_url":"git@github.com:doctrine/cache.git","clone_url":"https://github.com/doctrine/cache.git","svn_url":"https://github.com/doctrine/cache","homepage":null,"size":1351,"stargazers_count":171,"watchers_count":171,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":6,"forks":88,"open_issues":6,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/cache/pulls/94"},"html":{"href":"https://github.com/doctrine/cache/pull/94"},"issue":{"href":"https://api.github.com/repos/doctrine/cache/issues/94"},"comments":{"href":"https://api.github.com/repos/doctrine/cache/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/cache/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/cache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/cache/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/cache/statuses/7e92c6349727874c97f445af57886e34387de97a"}}}}