{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/33096985","id":33096985,"diff_hunk":"@@ -60,9 +60,23 @@ public function createForProperty($class, $property, $data = null, array $option\n      */\n     public function createBuilder($type = 'form', $data = null, array $options = array())\n     {\n-        $name = $type instanceof FormTypeInterface || $type instanceof ResolvedFormTypeInterface\n-            ? $type->getName()\n-            : $type;\n+        if (!$type instanceof FormTypeInterface && !$type instanceof ResolvedFormTypeInterface) {\n+            $type = $this->registry->getType($type);\n+        }\n+\n+        $typeName = $type->getName();\n+\n+        if (false === ($pos = strrpos($typeName, '\\\\'))) {\n+            // No FQCN - leave unchanged for BC\n+            $name = $typeName;","path":"src/Symfony/Component/Form/FormFactory.php","position":15,"original_position":15,"commit_id":"e33fcd20b871330e24ef6719c871918ff039d931","original_commit_id":"e33fcd20b871330e24ef6719c871918ff039d931","user":{"login":"Tobion","id":610090,"avatar_url":"https://avatars.githubusercontent.com/u/610090?v=3","gravatar_id":"","url":"https://api.github.com/users/Tobion","html_url":"https://github.com/Tobion","followers_url":"https://api.github.com/users/Tobion/followers","following_url":"https://api.github.com/users/Tobion/following{/other_user}","gists_url":"https://api.github.com/users/Tobion/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobion/subscriptions","organizations_url":"https://api.github.com/users/Tobion/orgs","repos_url":"https://api.github.com/users/Tobion/repos","events_url":"https://api.github.com/users/Tobion/events{/privacy}","received_events_url":"https://api.github.com/users/Tobion/received_events","type":"User","site_admin":false},"body":"are we going to remove that in 3.0? Then we could also remove the `FormType::getName` completely, or?","created_at":"2015-06-23T21:50:47Z","updated_at":"2015-06-23T21:50:47Z","html_url":"https://github.com/symfony/symfony/pull/15079#discussion_r33096985","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/15079","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/33096985"},"html":{"href":"https://github.com/symfony/symfony/pull/15079#discussion_r33096985"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15079"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/15079","id":38357749,"html_url":"https://github.com/symfony/symfony/pull/15079","diff_url":"https://github.com/symfony/symfony/pull/15079.diff","patch_url":"https://github.com/symfony/symfony/pull/15079.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/15079","number":15079,"state":"open","locked":false,"title":"[Form] Added default implementation of AbstractType::getName()","user":{"login":"webmozart","id":176399,"avatar_url":"https://avatars.githubusercontent.com/u/176399?v=3","gravatar_id":"","url":"https://api.github.com/users/webmozart","html_url":"https://github.com/webmozart","followers_url":"https://api.github.com/users/webmozart/followers","following_url":"https://api.github.com/users/webmozart/following{/other_user}","gists_url":"https://api.github.com/users/webmozart/gists{/gist_id}","starred_url":"https://api.github.com/users/webmozart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmozart/subscriptions","organizations_url":"https://api.github.com/users/webmozart/orgs","repos_url":"https://api.github.com/users/webmozart/repos","events_url":"https://api.github.com/users/webmozart/events{/privacy}","received_events_url":"https://api.github.com/users/webmozart/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | **yes**\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #15008\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nThis PR makes the definition of the `getName()` method of form types as well as setting the `alias` in the DIC configuration obsolete. See #15008 for a more detailed description.\r\n\r\nThis PR breaks BC! Before, the alias of the \"form.type\" tag defaulted to the ID of the tagged service. This does not really make sense and I have no idea if anyone relies on that. After the PR, the alias defaults to the class of the tagged service and thus corresponds to the default return value of `getName()`.\r\n\r\nIf @symfony/deciders agree that this BC break is justified, I'll adapt the UPGRADE and CHANGELOG files.","created_at":"2015-06-23T16:45:39Z","updated_at":"2015-06-23T21:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18d41639f7cdef05a54fe3252032b72228898f8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/15079/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/15079/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/15079/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/e33fcd20b871330e24ef6719c871918ff039d931","head":{"label":"webmozart:issue15008","ref":"issue15008","sha":"e33fcd20b871330e24ef6719c871918ff039d931","user":{"login":"webmozart","id":176399,"avatar_url":"https://avatars.githubusercontent.com/u/176399?v=3","gravatar_id":"","url":"https://api.github.com/users/webmozart","html_url":"https://github.com/webmozart","followers_url":"https://api.github.com/users/webmozart/followers","following_url":"https://api.github.com/users/webmozart/following{/other_user}","gists_url":"https://api.github.com/users/webmozart/gists{/gist_id}","starred_url":"https://api.github.com/users/webmozart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmozart/subscriptions","organizations_url":"https://api.github.com/users/webmozart/orgs","repos_url":"https://api.github.com/users/webmozart/repos","events_url":"https://api.github.com/users/webmozart/events{/privacy}","received_events_url":"https://api.github.com/users/webmozart/received_events","type":"User","site_admin":false},"repo":{"id":1402087,"name":"symfony","full_name":"webmozart/symfony","owner":{"login":"webmozart","id":176399,"avatar_url":"https://avatars.githubusercontent.com/u/176399?v=3","gravatar_id":"","url":"https://api.github.com/users/webmozart","html_url":"https://github.com/webmozart","followers_url":"https://api.github.com/users/webmozart/followers","following_url":"https://api.github.com/users/webmozart/following{/other_user}","gists_url":"https://api.github.com/users/webmozart/gists{/gist_id}","starred_url":"https://api.github.com/users/webmozart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmozart/subscriptions","organizations_url":"https://api.github.com/users/webmozart/orgs","repos_url":"https://api.github.com/users/webmozart/repos","events_url":"https://api.github.com/users/webmozart/events{/privacy}","received_events_url":"https://api.github.com/users/webmozart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/webmozart/symfony","description":"The Symfony2 PHP framework (PHP 5.3 only -- not yet stable) -- documentation for master is at http://docs.symfony-reloaded.org/master/","fork":true,"url":"https://api.github.com/repos/webmozart/symfony","forks_url":"https://api.github.com/repos/webmozart/symfony/forks","keys_url":"https://api.github.com/repos/webmozart/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webmozart/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webmozart/symfony/teams","hooks_url":"https://api.github.com/repos/webmozart/symfony/hooks","issue_events_url":"https://api.github.com/repos/webmozart/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/webmozart/symfony/events","assignees_url":"https://api.github.com/repos/webmozart/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/webmozart/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/webmozart/symfony/tags","blobs_url":"https://api.github.com/repos/webmozart/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webmozart/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webmozart/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/webmozart/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webmozart/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/webmozart/symfony/languages","stargazers_url":"https://api.github.com/repos/webmozart/symfony/stargazers","contributors_url":"https://api.github.com/repos/webmozart/symfony/contributors","subscribers_url":"https://api.github.com/repos/webmozart/symfony/subscribers","subscription_url":"https://api.github.com/repos/webmozart/symfony/subscription","commits_url":"https://api.github.com/repos/webmozart/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/webmozart/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/webmozart/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/webmozart/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/webmozart/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/webmozart/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webmozart/symfony/merges","archive_url":"https://api.github.com/repos/webmozart/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webmozart/symfony/downloads","issues_url":"https://api.github.com/repos/webmozart/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/webmozart/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/webmozart/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/webmozart/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webmozart/symfony/labels{/name}","releases_url":"https://api.github.com/repos/webmozart/symfony/releases{/id}","created_at":"2011-02-23T12:20:24Z","updated_at":"2015-05-04T06:31:31Z","pushed_at":"2015-06-23T16:55:25Z","git_url":"git://github.com/webmozart/symfony.git","ssh_url":"git@github.com:webmozart/symfony.git","clone_url":"https://github.com/webmozart/symfony.git","svn_url":"https://github.com/webmozart/symfony","homepage":"http://www.symfony-reloaded.org/","size":61268,"stargazers_count":14,"watchers_count":14,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":14,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"dd7583d4851fa10f711b3f7e0727f80236b22f77","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-06-23T13:41:23Z","pushed_at":"2015-06-23T18:38:06Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":1193109,"stargazers_count":10381,"watchers_count":10381,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4119,"mirror_url":null,"open_issues_count":842,"forks":4119,"open_issues":842,"watchers":10381,"default_branch":"2.8"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15079"},"html":{"href":"https://github.com/symfony/symfony/pull/15079"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/15079"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/15079/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15079/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15079/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/e33fcd20b871330e24ef6719c871918ff039d931"}}}}