{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/muckrake/pulls/comments/38677012","id":38677012,"diff_hunk":"@@ -0,0 +1,69 @@\n+# Copyright 2015 Confluent Inc.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+\n+class MysqlClient():\n+","path":"muckrake/services/mysql_client.py","position":17,"original_position":17,"commit_id":"69325b909aedfe287e74ca3f982d02cc4a38097a","original_commit_id":"69325b909aedfe287e74ca3f982d02cc4a38097a","user":{"login":"granders","id":1295932,"avatar_url":"https://avatars.githubusercontent.com/u/1295932?v=3","gravatar_id":"","url":"https://api.github.com/users/granders","html_url":"https://github.com/granders","followers_url":"https://api.github.com/users/granders/followers","following_url":"https://api.github.com/users/granders/following{/other_user}","gists_url":"https://api.github.com/users/granders/gists{/gist_id}","starred_url":"https://api.github.com/users/granders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granders/subscriptions","organizations_url":"https://api.github.com/users/granders/orgs","repos_url":"https://api.github.com/users/granders/repos","events_url":"https://api.github.com/users/granders/events{/privacy}","received_events_url":"https://api.github.com/users/granders/received_events","type":"User","site_admin":false},"body":"This is nice.\r\nIt would be good to add at least a class docstring.\r\nYou could call out here that the node in the constructor is the node taken from a MysqlService instance","created_at":"2015-09-03T18:06:58Z","updated_at":"2015-09-03T18:06:58Z","html_url":"https://github.com/confluentinc/muckrake/pull/42#discussion_r38677012","pull_request_url":"https://api.github.com/repos/confluentinc/muckrake/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/muckrake/pulls/comments/38677012"},"html":{"href":"https://github.com/confluentinc/muckrake/pull/42#discussion_r38677012"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/muckrake/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/muckrake/pulls/42","id":44050666,"html_url":"https://github.com/confluentinc/muckrake/pull/42","diff_url":"https://github.com/confluentinc/muckrake/pull/42.diff","patch_url":"https://github.com/confluentinc/muckrake/pull/42.patch","issue_url":"https://api.github.com/repos/confluentinc/muckrake/issues/42","number":42,"state":"open","locked":false,"title":"Add Mysql Service to enable copycat JDBC connector system tests ","user":{"login":"Ishiihara","id":1189848,"avatar_url":"https://avatars.githubusercontent.com/u/1189848?v=3","gravatar_id":"","url":"https://api.github.com/users/Ishiihara","html_url":"https://github.com/Ishiihara","followers_url":"https://api.github.com/users/Ishiihara/followers","following_url":"https://api.github.com/users/Ishiihara/following{/other_user}","gists_url":"https://api.github.com/users/Ishiihara/gists{/gist_id}","starred_url":"https://api.github.com/users/Ishiihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ishiihara/subscriptions","organizations_url":"https://api.github.com/users/Ishiihara/orgs","repos_url":"https://api.github.com/users/Ishiihara/repos","events_url":"https://api.github.com/users/Ishiihara/events{/privacy}","received_events_url":"https://api.github.com/users/Ishiihara/received_events","type":"User","site_admin":false},"body":"Changes\r\n1. Added mysql service to muckrake. \r\n2. Added mysql client to access the mysql service\r\n3. Added a simple verification method to verify the query result matches the data inserted into the table.\r\n\r\n@granders @ewencp Would be good if you guys can review. It's been awhile since a add a service last time so I may not follow the best practices.  ","created_at":"2015-09-02T22:30:37Z","updated_at":"2015-09-03T18:06:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68952922251c9e727d179a4a21b10237433e54d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/muckrake/pulls/42/commits","review_comments_url":"https://api.github.com/repos/confluentinc/muckrake/pulls/42/comments","review_comment_url":"https://api.github.com/repos/confluentinc/muckrake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/muckrake/issues/42/comments","statuses_url":"https://api.github.com/repos/confluentinc/muckrake/statuses/69325b909aedfe287e74ca3f982d02cc4a38097a","head":{"label":"confluentinc:mysql","ref":"mysql","sha":"69325b909aedfe287e74ca3f982d02cc4a38097a","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":32954806,"name":"muckrake","full_name":"confluentinc/muckrake","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/muckrake","description":"Confluent Platform system tests","fork":false,"url":"https://api.github.com/repos/confluentinc/muckrake","forks_url":"https://api.github.com/repos/confluentinc/muckrake/forks","keys_url":"https://api.github.com/repos/confluentinc/muckrake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/muckrake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/muckrake/teams","hooks_url":"https://api.github.com/repos/confluentinc/muckrake/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/muckrake/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/muckrake/events","assignees_url":"https://api.github.com/repos/confluentinc/muckrake/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/muckrake/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/muckrake/tags","blobs_url":"https://api.github.com/repos/confluentinc/muckrake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/muckrake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/muckrake/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/muckrake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/muckrake/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/muckrake/languages","stargazers_url":"https://api.github.com/repos/confluentinc/muckrake/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/muckrake/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/muckrake/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/muckrake/subscription","commits_url":"https://api.github.com/repos/confluentinc/muckrake/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/muckrake/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/muckrake/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/muckrake/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/muckrake/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/muckrake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/muckrake/merges","archive_url":"https://api.github.com/repos/confluentinc/muckrake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/muckrake/downloads","issues_url":"https://api.github.com/repos/confluentinc/muckrake/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/muckrake/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/muckrake/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/muckrake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/muckrake/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/muckrake/releases{/id}","created_at":"2015-03-26T22:16:59Z","updated_at":"2015-07-21T07:35:49Z","pushed_at":"2015-09-02T22:30:37Z","git_url":"git://github.com/confluentinc/muckrake.git","ssh_url":"git@github.com:confluentinc/muckrake.git","clone_url":"https://github.com/confluentinc/muckrake.git","svn_url":"https://github.com/confluentinc/muckrake","homepage":null,"size":628,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":19,"forks":3,"open_issues":19,"watchers":6,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"46ee79200e10a7c9ad2c0d7de0c43b6b3a5d2d32","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":32954806,"name":"muckrake","full_name":"confluentinc/muckrake","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/muckrake","description":"Confluent Platform system tests","fork":false,"url":"https://api.github.com/repos/confluentinc/muckrake","forks_url":"https://api.github.com/repos/confluentinc/muckrake/forks","keys_url":"https://api.github.com/repos/confluentinc/muckrake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/muckrake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/muckrake/teams","hooks_url":"https://api.github.com/repos/confluentinc/muckrake/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/muckrake/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/muckrake/events","assignees_url":"https://api.github.com/repos/confluentinc/muckrake/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/muckrake/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/muckrake/tags","blobs_url":"https://api.github.com/repos/confluentinc/muckrake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/muckrake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/muckrake/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/muckrake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/muckrake/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/muckrake/languages","stargazers_url":"https://api.github.com/repos/confluentinc/muckrake/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/muckrake/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/muckrake/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/muckrake/subscription","commits_url":"https://api.github.com/repos/confluentinc/muckrake/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/muckrake/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/muckrake/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/muckrake/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/muckrake/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/muckrake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/muckrake/merges","archive_url":"https://api.github.com/repos/confluentinc/muckrake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/muckrake/downloads","issues_url":"https://api.github.com/repos/confluentinc/muckrake/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/muckrake/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/muckrake/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/muckrake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/muckrake/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/muckrake/releases{/id}","created_at":"2015-03-26T22:16:59Z","updated_at":"2015-07-21T07:35:49Z","pushed_at":"2015-09-02T22:30:37Z","git_url":"git://github.com/confluentinc/muckrake.git","ssh_url":"git@github.com:confluentinc/muckrake.git","clone_url":"https://github.com/confluentinc/muckrake.git","svn_url":"https://github.com/confluentinc/muckrake","homepage":null,"size":628,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":19,"forks":3,"open_issues":19,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/muckrake/pulls/42"},"html":{"href":"https://github.com/confluentinc/muckrake/pull/42"},"issue":{"href":"https://api.github.com/repos/confluentinc/muckrake/issues/42"},"comments":{"href":"https://api.github.com/repos/confluentinc/muckrake/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/muckrake/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/muckrake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/muckrake/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/muckrake/statuses/69325b909aedfe287e74ca3f982d02cc4a38097a"}}}}