{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/28325701","id":28325701,"diff_hunk":"@@ -71,9 +76,11 @@ class TaskBuilder(app: AppDefinition,\n       .addResources(ScalarResource(Resource.CPUS, app.cpus, cpuRole))\n       .addResources(ScalarResource(Resource.MEM, app.mem, memRole))\n \n-    if (portsResource.ranges.nonEmpty) {\n+    if (labels.nonEmpty)","path":"src/main/scala/mesosphere/mesos/TaskBuilder.scala","position":17,"original_position":17,"commit_id":"d3b6fb227076bf4436c2d7f0c75c7aaee49d3b03","original_commit_id":"d3b6fb227076bf4436c2d7f0c75c7aaee49d3b03","user":{"login":"drexin","id":433020,"avatar_url":"https://avatars.githubusercontent.com/u/433020?v=3","gravatar_id":"","url":"https://api.github.com/users/drexin","html_url":"https://github.com/drexin","followers_url":"https://api.github.com/users/drexin/followers","following_url":"https://api.github.com/users/drexin/following{/other_user}","gists_url":"https://api.github.com/users/drexin/gists{/gist_id}","starred_url":"https://api.github.com/users/drexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drexin/subscriptions","organizations_url":"https://api.github.com/users/drexin/orgs","repos_url":"https://api.github.com/users/drexin/repos","events_url":"https://api.github.com/users/drexin/events{/privacy}","received_events_url":"https://api.github.com/users/drexin/received_events","type":"User","site_admin":false},"body":"If its not present, we shouldn't set it. First because it will simply send more bytes over the wire, second because default values will be ignored in that case.","created_at":"2015-04-14T13:27:40Z","updated_at":"2015-04-14T13:27:40Z","html_url":"https://github.com/mesosphere/marathon/pull/1384#discussion_r28325701","pull_request_url":"https://api.github.com/repos/mesosphere/marathon/pulls/1384","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/28325701"},"html":{"href":"https://github.com/mesosphere/marathon/pull/1384#discussion_r28325701"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/1384"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/1384","id":33163033,"html_url":"https://github.com/mesosphere/marathon/pull/1384","diff_url":"https://github.com/mesosphere/marathon/pull/1384.diff","patch_url":"https://github.com/mesosphere/marathon/pull/1384.patch","issue_url":"https://api.github.com/repos/mesosphere/marathon/issues/1384","number":1384,"state":"open","locked":false,"title":"fixes #1121 - Set labels configured in Marathon in Mesos TaskInfo","user":{"login":"drexin","id":433020,"avatar_url":"https://avatars.githubusercontent.com/u/433020?v=3","gravatar_id":"","url":"https://api.github.com/users/drexin","html_url":"https://github.com/drexin","followers_url":"https://api.github.com/users/drexin/followers","following_url":"https://api.github.com/users/drexin/following{/other_user}","gists_url":"https://api.github.com/users/drexin/gists{/gist_id}","starred_url":"https://api.github.com/users/drexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drexin/subscriptions","organizations_url":"https://api.github.com/users/drexin/orgs","repos_url":"https://api.github.com/users/drexin/repos","events_url":"https://api.github.com/users/drexin/events{/privacy}","received_events_url":"https://api.github.com/users/drexin/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-13T13:26:15Z","updated_at":"2015-04-14T13:27:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21ac960435dd26d7fbe0172750a1f4c5a40f02a8","assignee":{"login":"kolloch","id":339354,"avatar_url":"https://avatars.githubusercontent.com/u/339354?v=3","gravatar_id":"","url":"https://api.github.com/users/kolloch","html_url":"https://github.com/kolloch","followers_url":"https://api.github.com/users/kolloch/followers","following_url":"https://api.github.com/users/kolloch/following{/other_user}","gists_url":"https://api.github.com/users/kolloch/gists{/gist_id}","starred_url":"https://api.github.com/users/kolloch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolloch/subscriptions","organizations_url":"https://api.github.com/users/kolloch/orgs","repos_url":"https://api.github.com/users/kolloch/repos","events_url":"https://api.github.com/users/kolloch/events{/privacy}","received_events_url":"https://api.github.com/users/kolloch/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/marathon/pulls/1384/commits","review_comments_url":"https://api.github.com/repos/mesosphere/marathon/pulls/1384/comments","review_comment_url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/marathon/issues/1384/comments","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/d3b6fb227076bf4436c2d7f0c75c7aaee49d3b03","head":{"label":"mesosphere:wip-1121-drexin","ref":"wip-1121-drexin","sha":"d3b6fb227076bf4436c2d7f0c75c7aaee49d3b03","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"name":"marathon","full_name":"mesosphere/marathon","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","created_at":"2013-06-25T14:56:34Z","updated_at":"2015-04-14T10:11:22Z","pushed_at":"2015-04-14T12:59:22Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":24212,"stargazers_count":1320,"watchers_count":1320,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":282,"mirror_url":null,"open_issues_count":219,"forks":282,"open_issues":219,"watchers":1320,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"c2e86b13df8528320528fe938a9d7a0b397cc000","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"name":"marathon","full_name":"mesosphere/marathon","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","created_at":"2013-06-25T14:56:34Z","updated_at":"2015-04-14T10:11:22Z","pushed_at":"2015-04-14T12:59:22Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":24212,"stargazers_count":1320,"watchers_count":1320,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":282,"mirror_url":null,"open_issues_count":219,"forks":282,"open_issues":219,"watchers":1320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/1384"},"html":{"href":"https://github.com/mesosphere/marathon/pull/1384"},"issue":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/1384"},"comments":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/1384/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/1384/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/1384/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/marathon/statuses/d3b6fb227076bf4436c2d7f0c75c7aaee49d3b03"}}}}