{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/openregister/organisations/pulls/1","id":42036157,"html_url":"https://github.com/openregister/organisations/pull/1","diff_url":"https://github.com/openregister/organisations/pull/1.diff","patch_url":"https://github.com/openregister/organisations/pull/1.patch","issue_url":"https://api.github.com/repos/openregister/organisations/issues/1","number":1,"state":"closed","locked":false,"title":"fix broken things about company data","user":{"login":"philandstuff","id":581269,"avatar_url":"https://avatars.githubusercontent.com/u/581269?v=3","gravatar_id":"","url":"https://api.github.com/users/philandstuff","html_url":"https://github.com/philandstuff","followers_url":"https://api.github.com/users/philandstuff/followers","following_url":"https://api.github.com/users/philandstuff/following{/other_user}","gists_url":"https://api.github.com/users/philandstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/philandstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philandstuff/subscriptions","organizations_url":"https://api.github.com/users/philandstuff/orgs","repos_url":"https://api.github.com/users/philandstuff/repos","events_url":"https://api.github.com/users/philandstuff/events{/privacy}","received_events_url":"https://api.github.com/users/philandstuff/received_events","type":"User","site_admin":false},"body":" 1. there's been a new release of basic company data, so (of course) the\r\n    old URLs now 404 :(\r\n 2. the requirements.txt format didn't work at all for me, but manually\r\n    fiddling with it produced something that seemed to work\r\n 3. the register register data and country register data has moved, so\r\n    the URLs needed updating\r\n\r\nunfortunately I still get errors even after this commit:\r\n\r\n    $ make\r\n    flake8 bin\r\n    mkdir -p cache && curl -s \"http://download.companieshouse.gov.uk/BasicCompanyData-2015-08-01-part1_5.zip\" > cache/part1.zip\r\n    funzip cache/part1.zip | bin/companies.py part1\r\n    Traceback (most recent call last):\r\n      File \"bin/companies.py\", line 67, in <module>\r\n        addresses.write(address)\r\n      File \"/Users/philandstuff/openregister/data/organisations/companies/src/thingstance/thingstance/representations/csv.py\", line 60, in write\r\n        self.writer.writerow(thing.primitive)\r\n      File \"/opt/boxen/homebrew/Cellar/python3/3.4.3_2/Frameworks/Python.framework/Versions/3.4/lib/python3.4/csv.py\", line 153, in writerow\r\n        return self.writer.writerow(self._dict_to_list(rowdict))\r\n      File \"/opt/boxen/homebrew/Cellar/python3/3.4.3_2/Frameworks/Python.framework/Versions/3.4/lib/python3.4/csv.py\", line 149, in _dict_to_list\r\n        + \", \".join([repr(x) for x in wrong_fields]))\r\n    ValueError: dict contains fields not in fieldnames: 'addressCountry', 'addressRegion', 'addressLocality', 'postalCode', 'postOfficeBoxNumber', 'streetAddress'\r\n    make: *** [data/Company/part1.tsv] Error 1\r\n\r\nI don't know what this is trying to tell me.","created_at":"2015-08-10T16:01:36Z","updated_at":"2015-09-29T11:45:41Z","closed_at":"2015-09-29T11:45:41Z","merged_at":"2015-09-29T11:45:41Z","merge_commit_sha":"bde48eef250e427d82df5295185884be7b930dd4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openregister/organisations/pulls/1/commits","review_comments_url":"https://api.github.com/repos/openregister/organisations/pulls/1/comments","review_comment_url":"https://api.github.com/repos/openregister/organisations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openregister/organisations/issues/1/comments","statuses_url":"https://api.github.com/repos/openregister/organisations/statuses/0bd68038ce74fe2779a62085695c8aa6009339df","head":{"label":"openregister:fix-broken-things","ref":"fix-broken-things","sha":"0bd68038ce74fe2779a62085695c8aa6009339df","user":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":39835492,"name":"organisations","full_name":"openregister/organisations","owner":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openregister/organisations","description":"Register data for organisations","fork":false,"url":"https://api.github.com/repos/openregister/organisations","forks_url":"https://api.github.com/repos/openregister/organisations/forks","keys_url":"https://api.github.com/repos/openregister/organisations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/organisations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/organisations/teams","hooks_url":"https://api.github.com/repos/openregister/organisations/hooks","issue_events_url":"https://api.github.com/repos/openregister/organisations/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/organisations/events","assignees_url":"https://api.github.com/repos/openregister/organisations/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/organisations/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/organisations/tags","blobs_url":"https://api.github.com/repos/openregister/organisations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/organisations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/organisations/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/organisations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/organisations/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/organisations/languages","stargazers_url":"https://api.github.com/repos/openregister/organisations/stargazers","contributors_url":"https://api.github.com/repos/openregister/organisations/contributors","subscribers_url":"https://api.github.com/repos/openregister/organisations/subscribers","subscription_url":"https://api.github.com/repos/openregister/organisations/subscription","commits_url":"https://api.github.com/repos/openregister/organisations/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/organisations/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/organisations/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/organisations/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/organisations/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/organisations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/organisations/merges","archive_url":"https://api.github.com/repos/openregister/organisations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/organisations/downloads","issues_url":"https://api.github.com/repos/openregister/organisations/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/organisations/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/organisations/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/organisations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/organisations/labels{/name}","releases_url":"https://api.github.com/repos/openregister/organisations/releases{/id}","created_at":"2015-07-28T13:29:00Z","updated_at":"2015-07-28T15:39:51Z","pushed_at":"2015-09-29T11:45:41Z","git_url":"git://github.com/openregister/organisations.git","ssh_url":"git@github.com:openregister/organisations.git","clone_url":"https://github.com/openregister/organisations.git","svn_url":"https://github.com/openregister/organisations","homepage":"","size":6672,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openregister:master","ref":"master","sha":"5ea1fe5ecd225e7d4d42c36698a5c9b798499164","user":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":39835492,"name":"organisations","full_name":"openregister/organisations","owner":{"login":"openregister","id":10206003,"avatar_url":"https://avatars.githubusercontent.com/u/10206003?v=3","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openregister/organisations","description":"Register data for organisations","fork":false,"url":"https://api.github.com/repos/openregister/organisations","forks_url":"https://api.github.com/repos/openregister/organisations/forks","keys_url":"https://api.github.com/repos/openregister/organisations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/organisations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/organisations/teams","hooks_url":"https://api.github.com/repos/openregister/organisations/hooks","issue_events_url":"https://api.github.com/repos/openregister/organisations/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/organisations/events","assignees_url":"https://api.github.com/repos/openregister/organisations/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/organisations/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/organisations/tags","blobs_url":"https://api.github.com/repos/openregister/organisations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/organisations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/organisations/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/organisations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/organisations/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/organisations/languages","stargazers_url":"https://api.github.com/repos/openregister/organisations/stargazers","contributors_url":"https://api.github.com/repos/openregister/organisations/contributors","subscribers_url":"https://api.github.com/repos/openregister/organisations/subscribers","subscription_url":"https://api.github.com/repos/openregister/organisations/subscription","commits_url":"https://api.github.com/repos/openregister/organisations/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/organisations/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/organisations/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/organisations/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/organisations/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/organisations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/organisations/merges","archive_url":"https://api.github.com/repos/openregister/organisations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/organisations/downloads","issues_url":"https://api.github.com/repos/openregister/organisations/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/organisations/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/organisations/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/organisations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/organisations/labels{/name}","releases_url":"https://api.github.com/repos/openregister/organisations/releases{/id}","created_at":"2015-07-28T13:29:00Z","updated_at":"2015-07-28T15:39:51Z","pushed_at":"2015-09-29T11:45:41Z","git_url":"git://github.com/openregister/organisations.git","ssh_url":"git@github.com:openregister/organisations.git","clone_url":"https://github.com/openregister/organisations.git","svn_url":"https://github.com/openregister/organisations","homepage":"","size":6672,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openregister/organisations/pulls/1"},"html":{"href":"https://github.com/openregister/organisations/pull/1"},"issue":{"href":"https://api.github.com/repos/openregister/organisations/issues/1"},"comments":{"href":"https://api.github.com/repos/openregister/organisations/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/openregister/organisations/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/openregister/organisations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openregister/organisations/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/openregister/organisations/statuses/0bd68038ce74fe2779a62085695c8aa6009339df"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ashimali","id":666250,"avatar_url":"https://avatars.githubusercontent.com/u/666250?v=3","gravatar_id":"","url":"https://api.github.com/users/ashimali","html_url":"https://github.com/ashimali","followers_url":"https://api.github.com/users/ashimali/followers","following_url":"https://api.github.com/users/ashimali/following{/other_user}","gists_url":"https://api.github.com/users/ashimali/gists{/gist_id}","starred_url":"https://api.github.com/users/ashimali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashimali/subscriptions","organizations_url":"https://api.github.com/users/ashimali/orgs","repos_url":"https://api.github.com/users/ashimali/repos","events_url":"https://api.github.com/users/ashimali/events{/privacy}","received_events_url":"https://api.github.com/users/ashimali/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":10,"changed_files":2}}