{"action":"opened","number":587,"pull_request":{"url":"https://api.github.com/repos/PrismJS/prism/pulls/587","id":36647698,"html_url":"https://github.com/PrismJS/prism/pull/587","diff_url":"https://github.com/PrismJS/prism/pull/587.diff","patch_url":"https://github.com/PrismJS/prism/pull/587.patch","issue_url":"https://api.github.com/repos/PrismJS/prism/issues/587","number":587,"state":"open","locked":false,"title":"Handlebars: support block names with dashes","user":{"login":"apfelbox","id":1032411,"avatar_url":"https://avatars.githubusercontent.com/u/1032411?v=3","gravatar_id":"","url":"https://api.github.com/users/apfelbox","html_url":"https://github.com/apfelbox","followers_url":"https://api.github.com/users/apfelbox/followers","following_url":"https://api.github.com/users/apfelbox/following{/other_user}","gists_url":"https://api.github.com/users/apfelbox/gists{/gist_id}","starred_url":"https://api.github.com/users/apfelbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apfelbox/subscriptions","organizations_url":"https://api.github.com/users/apfelbox/orgs","repos_url":"https://api.github.com/users/apfelbox/repos","events_url":"https://api.github.com/users/apfelbox/events{/privacy}","received_events_url":"https://api.github.com/users/apfelbox/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nas mentioned in #586 blocks with dashes should be supported.\r\nAs I was searching for a list of allowed characters in block names I couldn't find anything in the short time I was looking (`{{#this-is_ällowed✓-yep}} .. {{/this-is_ällowed✓-yep}}`).\r\n\r\n[This hints](https://github.com/wycats/handlebars.js/blob/4bed826d0e210c336fb9e500835b1c1926562da5/lib/handlebars/base.js#L39) in the direction that any valid object key is allowed, but whitespace is obviously not allowed (as Handlebars couldn't determine whether this is still the block name or already an argument). So I went for `\\S`, as basically only whitespace would error out (which was confirmed by my quick tests).\r\n\r\nFixes #586","created_at":"2015-06-01T16:49:43Z","updated_at":"2015-06-01T16:49:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PrismJS/prism/pulls/587/commits","review_comments_url":"https://api.github.com/repos/PrismJS/prism/pulls/587/comments","review_comment_url":"https://api.github.com/repos/PrismJS/prism/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrismJS/prism/issues/587/comments","statuses_url":"https://api.github.com/repos/PrismJS/prism/statuses/67b89eaf0ff666573261b7856b262c4cf26f8bc9","head":{"label":"apfelbox:handlebars-blocks-dashes","ref":"handlebars-blocks-dashes","sha":"67b89eaf0ff666573261b7856b262c4cf26f8bc9","user":{"login":"apfelbox","id":1032411,"avatar_url":"https://avatars.githubusercontent.com/u/1032411?v=3","gravatar_id":"","url":"https://api.github.com/users/apfelbox","html_url":"https://github.com/apfelbox","followers_url":"https://api.github.com/users/apfelbox/followers","following_url":"https://api.github.com/users/apfelbox/following{/other_user}","gists_url":"https://api.github.com/users/apfelbox/gists{/gist_id}","starred_url":"https://api.github.com/users/apfelbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apfelbox/subscriptions","organizations_url":"https://api.github.com/users/apfelbox/orgs","repos_url":"https://api.github.com/users/apfelbox/repos","events_url":"https://api.github.com/users/apfelbox/events{/privacy}","received_events_url":"https://api.github.com/users/apfelbox/received_events","type":"User","site_admin":false},"repo":{"id":16993247,"name":"prism","full_name":"apfelbox/prism","owner":{"login":"apfelbox","id":1032411,"avatar_url":"https://avatars.githubusercontent.com/u/1032411?v=3","gravatar_id":"","url":"https://api.github.com/users/apfelbox","html_url":"https://github.com/apfelbox","followers_url":"https://api.github.com/users/apfelbox/followers","following_url":"https://api.github.com/users/apfelbox/following{/other_user}","gists_url":"https://api.github.com/users/apfelbox/gists{/gist_id}","starred_url":"https://api.github.com/users/apfelbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apfelbox/subscriptions","organizations_url":"https://api.github.com/users/apfelbox/orgs","repos_url":"https://api.github.com/users/apfelbox/repos","events_url":"https://api.github.com/users/apfelbox/events{/privacy}","received_events_url":"https://api.github.com/users/apfelbox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apfelbox/prism","description":"Lightweight, robust, elegant syntax highlighting. A spin-off project from Dabblet. ","fork":true,"url":"https://api.github.com/repos/apfelbox/prism","forks_url":"https://api.github.com/repos/apfelbox/prism/forks","keys_url":"https://api.github.com/repos/apfelbox/prism/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apfelbox/prism/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apfelbox/prism/teams","hooks_url":"https://api.github.com/repos/apfelbox/prism/hooks","issue_events_url":"https://api.github.com/repos/apfelbox/prism/issues/events{/number}","events_url":"https://api.github.com/repos/apfelbox/prism/events","assignees_url":"https://api.github.com/repos/apfelbox/prism/assignees{/user}","branches_url":"https://api.github.com/repos/apfelbox/prism/branches{/branch}","tags_url":"https://api.github.com/repos/apfelbox/prism/tags","blobs_url":"https://api.github.com/repos/apfelbox/prism/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apfelbox/prism/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apfelbox/prism/git/refs{/sha}","trees_url":"https://api.github.com/repos/apfelbox/prism/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apfelbox/prism/statuses/{sha}","languages_url":"https://api.github.com/repos/apfelbox/prism/languages","stargazers_url":"https://api.github.com/repos/apfelbox/prism/stargazers","contributors_url":"https://api.github.com/repos/apfelbox/prism/contributors","subscribers_url":"https://api.github.com/repos/apfelbox/prism/subscribers","subscription_url":"https://api.github.com/repos/apfelbox/prism/subscription","commits_url":"https://api.github.com/repos/apfelbox/prism/commits{/sha}","git_commits_url":"https://api.github.com/repos/apfelbox/prism/git/commits{/sha}","comments_url":"https://api.github.com/repos/apfelbox/prism/comments{/number}","issue_comment_url":"https://api.github.com/repos/apfelbox/prism/issues/comments{/number}","contents_url":"https://api.github.com/repos/apfelbox/prism/contents/{+path}","compare_url":"https://api.github.com/repos/apfelbox/prism/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apfelbox/prism/merges","archive_url":"https://api.github.com/repos/apfelbox/prism/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apfelbox/prism/downloads","issues_url":"https://api.github.com/repos/apfelbox/prism/issues{/number}","pulls_url":"https://api.github.com/repos/apfelbox/prism/pulls{/number}","milestones_url":"https://api.github.com/repos/apfelbox/prism/milestones{/number}","notifications_url":"https://api.github.com/repos/apfelbox/prism/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apfelbox/prism/labels{/name}","releases_url":"https://api.github.com/repos/apfelbox/prism/releases{/id}","created_at":"2014-02-19T17:55:59Z","updated_at":"2015-02-21T23:20:12Z","pushed_at":"2015-06-01T16:45:45Z","git_url":"git://github.com/apfelbox/prism.git","ssh_url":"git@github.com:apfelbox/prism.git","clone_url":"https://github.com/apfelbox/prism.git","svn_url":"https://github.com/apfelbox/prism","homepage":"http://prismjs.com","size":1815,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"PrismJS:gh-pages","ref":"gh-pages","sha":"534f34cd35526481e4a32ac4d1eaf447a5a64bf2","user":{"login":"PrismJS","id":11140484,"avatar_url":"https://avatars.githubusercontent.com/u/11140484?v=3","gravatar_id":"","url":"https://api.github.com/users/PrismJS","html_url":"https://github.com/PrismJS","followers_url":"https://api.github.com/users/PrismJS/followers","following_url":"https://api.github.com/users/PrismJS/following{/other_user}","gists_url":"https://api.github.com/users/PrismJS/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismJS/subscriptions","organizations_url":"https://api.github.com/users/PrismJS/orgs","repos_url":"https://api.github.com/users/PrismJS/repos","events_url":"https://api.github.com/users/PrismJS/events{/privacy}","received_events_url":"https://api.github.com/users/PrismJS/received_events","type":"Organization","site_admin":false},"repo":{"id":4979467,"name":"prism","full_name":"PrismJS/prism","owner":{"login":"PrismJS","id":11140484,"avatar_url":"https://avatars.githubusercontent.com/u/11140484?v=3","gravatar_id":"","url":"https://api.github.com/users/PrismJS","html_url":"https://github.com/PrismJS","followers_url":"https://api.github.com/users/PrismJS/followers","following_url":"https://api.github.com/users/PrismJS/following{/other_user}","gists_url":"https://api.github.com/users/PrismJS/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismJS/subscriptions","organizations_url":"https://api.github.com/users/PrismJS/orgs","repos_url":"https://api.github.com/users/PrismJS/repos","events_url":"https://api.github.com/users/PrismJS/events{/privacy}","received_events_url":"https://api.github.com/users/PrismJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrismJS/prism","description":"Lightweight, robust, elegant syntax highlighting.","fork":false,"url":"https://api.github.com/repos/PrismJS/prism","forks_url":"https://api.github.com/repos/PrismJS/prism/forks","keys_url":"https://api.github.com/repos/PrismJS/prism/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrismJS/prism/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrismJS/prism/teams","hooks_url":"https://api.github.com/repos/PrismJS/prism/hooks","issue_events_url":"https://api.github.com/repos/PrismJS/prism/issues/events{/number}","events_url":"https://api.github.com/repos/PrismJS/prism/events","assignees_url":"https://api.github.com/repos/PrismJS/prism/assignees{/user}","branches_url":"https://api.github.com/repos/PrismJS/prism/branches{/branch}","tags_url":"https://api.github.com/repos/PrismJS/prism/tags","blobs_url":"https://api.github.com/repos/PrismJS/prism/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrismJS/prism/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrismJS/prism/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrismJS/prism/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrismJS/prism/statuses/{sha}","languages_url":"https://api.github.com/repos/PrismJS/prism/languages","stargazers_url":"https://api.github.com/repos/PrismJS/prism/stargazers","contributors_url":"https://api.github.com/repos/PrismJS/prism/contributors","subscribers_url":"https://api.github.com/repos/PrismJS/prism/subscribers","subscription_url":"https://api.github.com/repos/PrismJS/prism/subscription","commits_url":"https://api.github.com/repos/PrismJS/prism/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrismJS/prism/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrismJS/prism/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrismJS/prism/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrismJS/prism/contents/{+path}","compare_url":"https://api.github.com/repos/PrismJS/prism/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrismJS/prism/merges","archive_url":"https://api.github.com/repos/PrismJS/prism/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrismJS/prism/downloads","issues_url":"https://api.github.com/repos/PrismJS/prism/issues{/number}","pulls_url":"https://api.github.com/repos/PrismJS/prism/pulls{/number}","milestones_url":"https://api.github.com/repos/PrismJS/prism/milestones{/number}","notifications_url":"https://api.github.com/repos/PrismJS/prism/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrismJS/prism/labels{/name}","releases_url":"https://api.github.com/repos/PrismJS/prism/releases{/id}","created_at":"2012-07-10T19:47:14Z","updated_at":"2015-05-31T05:16:08Z","pushed_at":"2015-05-30T03:31:24Z","git_url":"git://github.com/PrismJS/prism.git","ssh_url":"git@github.com:PrismJS/prism.git","clone_url":"https://github.com/PrismJS/prism.git","svn_url":"https://github.com/PrismJS/prism","homepage":"http://prismjs.com","size":6358,"stargazers_count":2199,"watchers_count":2199,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":313,"mirror_url":null,"open_issues_count":129,"forks":313,"open_issues":129,"watchers":2199,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/PrismJS/prism/pulls/587"},"html":{"href":"https://github.com/PrismJS/prism/pull/587"},"issue":{"href":"https://api.github.com/repos/PrismJS/prism/issues/587"},"comments":{"href":"https://api.github.com/repos/PrismJS/prism/issues/587/comments"},"review_comments":{"href":"https://api.github.com/repos/PrismJS/prism/pulls/587/comments"},"review_comment":{"href":"https://api.github.com/repos/PrismJS/prism/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrismJS/prism/pulls/587/commits"},"statuses":{"href":"https://api.github.com/repos/PrismJS/prism/statuses/67b89eaf0ff666573261b7856b262c4cf26f8bc9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":6,"changed_files":3}}