{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments/29791991","id":29791991,"diff_hunk":"@@ -1201,6 +1202,11 @@ TCN_IMPLEMENT_CALL(jlong /* SSL * */, SSL, newSSL)(TCN_STDARGS,\n         tcn_ThrowException(e, \"cannot create new ssl\");\n         return 0;\n     }\n+\n+    // Store the handshakeCount in the SSL instance.\n+    *handshakeCount = 0;","path":"src/main/c/ssl.c","position":41,"original_position":41,"commit_id":"5c513d56d54e1eb7f72da2448180e5f785e0b908","original_commit_id":"5c513d56d54e1eb7f72da2448180e5f785e0b908","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"@Scottmitch Hmm just leave it as it is for now. Maybe we should create another issue and go over the whole code and check for these. Then when once is detected throw an exception or so. WDYT ?","created_at":"2015-05-06T19:17:53Z","updated_at":"2015-05-06T19:17:53Z","html_url":"https://github.com/netty/netty-tcnative/pull/39#discussion_r29791991","pull_request_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments/29791991"},"html":{"href":"https://github.com/netty/netty-tcnative/pull/39#discussion_r29791991"},"pull_request":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty-tcnative/pulls/39","id":34846260,"html_url":"https://github.com/netty/netty-tcnative/pull/39","diff_url":"https://github.com/netty/netty-tcnative/pull/39.diff","patch_url":"https://github.com/netty/netty-tcnative/pull/39.patch","issue_url":"https://api.github.com/repos/netty/netty-tcnative/issues/39","number":39,"state":"open","locked":false,"title":"Allow to correctly retrieve the number of handshakes for a ssl instance","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nIn commit 1cd48327e711a230e325f74d3d09873d70043edd SSL.getHandshakeCount(...) was introduced. Unfortunally the implementation was not correct and so the returned number did not match the reality.\r\n\r\nModifications:\r\n\r\n- Store the handshakeCount per SSL instance and so fix the implemented\r\n\r\nResult:\r\n\r\nSSL.getHandshakeCount(...) returns the correct number now.","created_at":"2015-05-06T18:36:16Z","updated_at":"2015-05-06T19:17:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddb45d6f266ec26b2c05187c304514c351bd95af","assignee":null,"milestone":{"url":"https://api.github.com/repos/netty/netty-tcnative/milestones/5","html_url":"https://github.com/netty/netty-tcnative/milestones/1.1.33-Fork2","labels_url":"https://api.github.com/repos/netty/netty-tcnative/milestones/5/labels","id":1060264,"number":5,"title":"1.1.33-Fork2","description":"","creator":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":4,"state":"open","created_at":"2015-04-09T13:17:41Z","updated_at":"2015-05-06T18:50:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/39/commits","review_comments_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/39/comments","review_comment_url":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty-tcnative/issues/39/comments","statuses_url":"https://api.github.com/repos/netty/netty-tcnative/statuses/5c513d56d54e1eb7f72da2448180e5f785e0b908","head":{"label":"netty:fix_handshake_count","ref":"fix_handshake_count","sha":"5c513d56d54e1eb7f72da2448180e5f785e0b908","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":19016985,"name":"netty-tcnative","full_name":"netty/netty-tcnative","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty-tcnative","description":"A fork of Apache Tomcat Native, based on finagle-native","fork":false,"url":"https://api.github.com/repos/netty/netty-tcnative","forks_url":"https://api.github.com/repos/netty/netty-tcnative/forks","keys_url":"https://api.github.com/repos/netty/netty-tcnative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty-tcnative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty-tcnative/teams","hooks_url":"https://api.github.com/repos/netty/netty-tcnative/hooks","issue_events_url":"https://api.github.com/repos/netty/netty-tcnative/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty-tcnative/events","assignees_url":"https://api.github.com/repos/netty/netty-tcnative/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty-tcnative/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty-tcnative/tags","blobs_url":"https://api.github.com/repos/netty/netty-tcnative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty-tcnative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty-tcnative/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty-tcnative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty-tcnative/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty-tcnative/languages","stargazers_url":"https://api.github.com/repos/netty/netty-tcnative/stargazers","contributors_url":"https://api.github.com/repos/netty/netty-tcnative/contributors","subscribers_url":"https://api.github.com/repos/netty/netty-tcnative/subscribers","subscription_url":"https://api.github.com/repos/netty/netty-tcnative/subscription","commits_url":"https://api.github.com/repos/netty/netty-tcnative/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty-tcnative/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty-tcnative/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty-tcnative/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty-tcnative/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty-tcnative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty-tcnative/merges","archive_url":"https://api.github.com/repos/netty/netty-tcnative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty-tcnative/downloads","issues_url":"https://api.github.com/repos/netty/netty-tcnative/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty-tcnative/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty-tcnative/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty-tcnative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty-tcnative/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty-tcnative/releases{/id}","created_at":"2014-04-22T04:24:17Z","updated_at":"2015-05-06T06:16:12Z","pushed_at":"2015-05-06T18:56:31Z","git_url":"git://github.com/netty/netty-tcnative.git","ssh_url":"git@github.com:netty/netty-tcnative.git","clone_url":"https://github.com/netty/netty-tcnative.git","svn_url":"https://github.com/netty/netty-tcnative","homepage":null,"size":1688,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":5,"forks":12,"open_issues":5,"watchers":19,"default_branch":"1.1.33"}},"base":{"label":"netty:1.1.33","ref":"1.1.33","sha":"1cd48327e711a230e325f74d3d09873d70043edd","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":19016985,"name":"netty-tcnative","full_name":"netty/netty-tcnative","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty-tcnative","description":"A fork of Apache Tomcat Native, based on finagle-native","fork":false,"url":"https://api.github.com/repos/netty/netty-tcnative","forks_url":"https://api.github.com/repos/netty/netty-tcnative/forks","keys_url":"https://api.github.com/repos/netty/netty-tcnative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty-tcnative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty-tcnative/teams","hooks_url":"https://api.github.com/repos/netty/netty-tcnative/hooks","issue_events_url":"https://api.github.com/repos/netty/netty-tcnative/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty-tcnative/events","assignees_url":"https://api.github.com/repos/netty/netty-tcnative/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty-tcnative/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty-tcnative/tags","blobs_url":"https://api.github.com/repos/netty/netty-tcnative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty-tcnative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty-tcnative/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty-tcnative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty-tcnative/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty-tcnative/languages","stargazers_url":"https://api.github.com/repos/netty/netty-tcnative/stargazers","contributors_url":"https://api.github.com/repos/netty/netty-tcnative/contributors","subscribers_url":"https://api.github.com/repos/netty/netty-tcnative/subscribers","subscription_url":"https://api.github.com/repos/netty/netty-tcnative/subscription","commits_url":"https://api.github.com/repos/netty/netty-tcnative/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty-tcnative/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty-tcnative/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty-tcnative/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty-tcnative/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty-tcnative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty-tcnative/merges","archive_url":"https://api.github.com/repos/netty/netty-tcnative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty-tcnative/downloads","issues_url":"https://api.github.com/repos/netty/netty-tcnative/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty-tcnative/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty-tcnative/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty-tcnative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty-tcnative/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty-tcnative/releases{/id}","created_at":"2014-04-22T04:24:17Z","updated_at":"2015-05-06T06:16:12Z","pushed_at":"2015-05-06T18:56:31Z","git_url":"git://github.com/netty/netty-tcnative.git","ssh_url":"git@github.com:netty/netty-tcnative.git","clone_url":"https://github.com/netty/netty-tcnative.git","svn_url":"https://github.com/netty/netty-tcnative","homepage":null,"size":1688,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":5,"forks":12,"open_issues":5,"watchers":19,"default_branch":"1.1.33"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/39"},"html":{"href":"https://github.com/netty/netty-tcnative/pull/39"},"issue":{"href":"https://api.github.com/repos/netty/netty-tcnative/issues/39"},"comments":{"href":"https://api.github.com/repos/netty/netty-tcnative/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty-tcnative/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty-tcnative/statuses/5c513d56d54e1eb7f72da2448180e5f785e0b908"}}}}