{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/24577670","id":24577670,"diff_hunk":"@@ -25,25 +49,34 @@ def install\n     bin.install_symlink libexec/\"slimerjs\"\n   end\n \n-  def caveats; <<-EOS.undent\n-    You can set the environment variable SLIMERJSLAUNCHER to a installation of\n-    Mozilla Firefox (or Mozilla XULRunner) to use this version with SlimerJS\n-    instead of the one installed by Homebrew (this is required if built without\n-    xulrunner).\n-    For a standard Mozilla Firefox installation this would be:\n+  def caveats\n+    s = \"\"\n \n-      export SLIMERJSLAUNCHER=/Applications/Firefox.app/Contents/MacOS/firefox\n+    ffpath = firefox_installation\n+    if ffpath.nil?\n+      s += <<-EOS.undent\n+        You MUST provide an installation of Mozilla Firefox and set\n+        the environment variable SLIMERJSLAUNCHER pointing to it, e.g.:\n \n-    Note: If you use SlimerJS with an unstable version of Mozilla\n-    Firefox/XULRunner (>29.*) you may have to change the [Gecko]MaxVersion in:\n-      #{libexec}/application.ini\n+        export SLIMERJSLAUNCHER=#{firefox_installation}/Contents/MacOS/firefox","path":"Library/Formula/slimerjs.rb","position":70,"original_position":70,"commit_id":"467cddde111f293ce39a136900771424a669ad1a","original_commit_id":"467cddde111f293ce39a136900771424a669ad1a","user":{"login":"skycaptain","id":1119641,"avatar_url":"https://avatars.githubusercontent.com/u/1119641?v=3","gravatar_id":"","url":"https://api.github.com/users/skycaptain","html_url":"https://github.com/skycaptain","followers_url":"https://api.github.com/users/skycaptain/followers","following_url":"https://api.github.com/users/skycaptain/following{/other_user}","gists_url":"https://api.github.com/users/skycaptain/gists{/gist_id}","starred_url":"https://api.github.com/users/skycaptain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skycaptain/subscriptions","organizations_url":"https://api.github.com/users/skycaptain/orgs","repos_url":"https://api.github.com/users/skycaptain/repos","events_url":"https://api.github.com/users/skycaptain/events{/privacy}","received_events_url":"https://api.github.com/users/skycaptain/received_events","type":"User","site_admin":false},"body":"`ffpath` instead of `firefox_installation` prevents a recalculation","created_at":"2015-02-12T12:45:16Z","updated_at":"2015-02-12T12:45:16Z","html_url":"https://github.com/Homebrew/homebrew/pull/36635#discussion_r24577670","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/36635","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/24577670"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/36635#discussion_r24577670"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/36635"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/36635","id":28870321,"html_url":"https://github.com/Homebrew/homebrew/pull/36635","diff_url":"https://github.com/Homebrew/homebrew/pull/36635.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/36635.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/36635","number":36635,"state":"open","locked":false,"title":"slimerjs: add firefox requirement","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"body":"Closes #36399","created_at":"2015-02-07T21:17:38Z","updated_at":"2015-02-12T12:45:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f97df69ad42e11dded604a5476fe37f16c65a50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/36635/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/36635/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/36635/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/467cddde111f293ce39a136900771424a669ad1a","head":{"label":"DomT4:slimerjs","ref":"slimerjs","sha":"467cddde111f293ce39a136900771424a669ad1a","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"repo":{"id":23289808,"name":"homebrew","full_name":"DomT4/homebrew","owner":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DomT4/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/DomT4/homebrew","forks_url":"https://api.github.com/repos/DomT4/homebrew/forks","keys_url":"https://api.github.com/repos/DomT4/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DomT4/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DomT4/homebrew/teams","hooks_url":"https://api.github.com/repos/DomT4/homebrew/hooks","issue_events_url":"https://api.github.com/repos/DomT4/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/DomT4/homebrew/events","assignees_url":"https://api.github.com/repos/DomT4/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/DomT4/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/DomT4/homebrew/tags","blobs_url":"https://api.github.com/repos/DomT4/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DomT4/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DomT4/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/DomT4/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DomT4/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/DomT4/homebrew/languages","stargazers_url":"https://api.github.com/repos/DomT4/homebrew/stargazers","contributors_url":"https://api.github.com/repos/DomT4/homebrew/contributors","subscribers_url":"https://api.github.com/repos/DomT4/homebrew/subscribers","subscription_url":"https://api.github.com/repos/DomT4/homebrew/subscription","commits_url":"https://api.github.com/repos/DomT4/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/DomT4/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/DomT4/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/DomT4/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/DomT4/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/DomT4/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DomT4/homebrew/merges","archive_url":"https://api.github.com/repos/DomT4/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DomT4/homebrew/downloads","issues_url":"https://api.github.com/repos/DomT4/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/DomT4/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/DomT4/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/DomT4/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DomT4/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/DomT4/homebrew/releases{/id}","created_at":"2014-08-24T19:01:40Z","updated_at":"2015-02-10T19:54:23Z","pushed_at":"2015-02-12T10:11:54Z","git_url":"git://github.com/DomT4/homebrew.git","ssh_url":"git@github.com:DomT4/homebrew.git","clone_url":"https://github.com/DomT4/homebrew.git","svn_url":"https://github.com/DomT4/homebrew","homepage":"http://brew.sh","size":59084,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"1e3503f41b5d16ab1b008c612f9995ed438c0c10","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":"The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2015-02-12T11:42:37Z","pushed_at":"2015-02-12T11:42:35Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1175933,"stargazers_count":21433,"watchers_count":21433,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":10727,"mirror_url":null,"open_issues_count":299,"forks":10727,"open_issues":299,"watchers":21433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/36635"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/36635"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/36635"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/36635/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/36635/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/36635/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/467cddde111f293ce39a136900771424a669ad1a"}}}}