{"action":"created","issue":{"url":"https://api.github.com/repos/google/guava/issues/2083","labels_url":"https://api.github.com/repos/google/guava/issues/2083/labels{/name}","comments_url":"https://api.github.com/repos/google/guava/issues/2083/comments","events_url":"https://api.github.com/repos/google/guava/issues/2083/events","html_url":"https://github.com/google/guava/issues/2083","id":89140721,"number":2083,"title":"Empty immutable collections should be explicitly documented as singletons","user":{"login":"eamonnmcmanus","id":5246810,"avatar_url":"https://avatars.githubusercontent.com/u/5246810?v=3","gravatar_id":"","url":"https://api.github.com/users/eamonnmcmanus","html_url":"https://github.com/eamonnmcmanus","followers_url":"https://api.github.com/users/eamonnmcmanus/followers","following_url":"https://api.github.com/users/eamonnmcmanus/following{/other_user}","gists_url":"https://api.github.com/users/eamonnmcmanus/gists{/gist_id}","starred_url":"https://api.github.com/users/eamonnmcmanus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eamonnmcmanus/subscriptions","organizations_url":"https://api.github.com/users/eamonnmcmanus/orgs","repos_url":"https://api.github.com/users/eamonnmcmanus/repos","events_url":"https://api.github.com/users/eamonnmcmanus/events{/privacy}","received_events_url":"https://api.github.com/users/eamonnmcmanus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/google/guava/labels/package:%20collect","name":"package: collect","color":"207de5"},{"url":"https://api.github.com/repos/google/guava/labels/status:%20accepted","name":"status: accepted","color":"bfe5bf"},{"url":"https://api.github.com/repos/google/guava/labels/type:%20api%20docs","name":"type: api docs","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-17T22:15:58Z","updated_at":"2015-12-07T16:53:43Z","closed_at":null,"body":"`ImmutableList.of()` says this:\r\n\r\n> Returns the empty immutable list. This set behaves and performs comparably to `Collections.emptyList()`, and is preferable mainly for consistency and maintainability of your code.\r\n\r\nThe use of the phrase \"the empty immutable list\" suggests that this method always returns the same object, as indeed it does. But this is implied only by the use of the definite article and the reference to `Collecitons.emptyList()`. It would be better to state it more explicitly. By comparison, `Collections.emptyList()` itself says this:\r\n\r\n> Implementation note: Implementations of this method need not create a separate `List` object for each call. Using this method is likely to have comparable cost to using the like-named field. (Unlike this method, the field does not provide type safety.)\r\n\r\nOf course the same applies to the other empty-collection methods."},"comment":{"url":"https://api.github.com/repos/google/guava/issues/comments/162590602","html_url":"https://github.com/google/guava/issues/2083#issuecomment-162590602","issue_url":"https://api.github.com/repos/google/guava/issues/2083","id":162590602,"user":{"login":"cjosw","id":6909735,"avatar_url":"https://avatars.githubusercontent.com/u/6909735?v=3","gravatar_id":"","url":"https://api.github.com/users/cjosw","html_url":"https://github.com/cjosw","followers_url":"https://api.github.com/users/cjosw/followers","following_url":"https://api.github.com/users/cjosw/following{/other_user}","gists_url":"https://api.github.com/users/cjosw/gists{/gist_id}","starred_url":"https://api.github.com/users/cjosw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjosw/subscriptions","organizations_url":"https://api.github.com/users/cjosw/orgs","repos_url":"https://api.github.com/users/cjosw/repos","events_url":"https://api.github.com/users/cjosw/events{/privacy}","received_events_url":"https://api.github.com/users/cjosw/received_events","type":"User","site_admin":false},"created_at":"2015-12-07T16:53:43Z","updated_at":"2015-12-07T16:53:43Z","body":"I have raised a pull request for this: https://github.com/google/guava/pull/2247\r\n"}}