{"action":"opened","number":40,"pull_request":{"url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/pulls/40","id":49720516,"html_url":"https://github.com/digitalLumberjack/recalbox-buildroot/pull/40","diff_url":"https://github.com/digitalLumberjack/recalbox-buildroot/pull/40.diff","patch_url":"https://github.com/digitalLumberjack/recalbox-buildroot/pull/40.patch","issue_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/issues/40","number":40,"state":"open","locked":false,"title":"Joysticks support improvement, including wiimote","user":{"login":"nadenislamarre","id":5346913,"avatar_url":"https://avatars.githubusercontent.com/u/5346913?v=3","gravatar_id":"","url":"https://api.github.com/users/nadenislamarre","html_url":"https://github.com/nadenislamarre","followers_url":"https://api.github.com/users/nadenislamarre/followers","following_url":"https://api.github.com/users/nadenislamarre/following{/other_user}","gists_url":"https://api.github.com/users/nadenislamarre/gists{/gist_id}","starred_url":"https://api.github.com/users/nadenislamarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadenislamarre/subscriptions","organizations_url":"https://api.github.com/users/nadenislamarre/orgs","repos_url":"https://api.github.com/users/nadenislamarre/repos","events_url":"https://api.github.com/users/nadenislamarre/events{/privacy}","received_events_url":"https://api.github.com/users/nadenislamarre/received_events","type":"User","site_admin":false},"body":"Summary of the 2 fixes :\r\n\r\n1) make SDL2 considers any udev button\r\nSDL2 ignores buttons which are not between BTN_MISC and KEY_MAX\r\nRA_UDEV ignores buttons which are not between BTN_MISC and KEY_MAX or between KEY_UP and KEY_DOWN\r\n2) make SDL2 assign buttons following the input.h file order as RA_UDEV does\r\nan example joystick has 2 buttons : BTN_MISC and BTN_JOYSTICK\r\n\r\nSDL2 will assign :\r\nbutton 0 = BTN_JOYSTICK\r\nbutton 1 = BTN_MISC\r\n\r\nRA_UDEV will assign :\r\nbutton 0 = BTN_MISC\r\nbutton 1 = BTN_JOYSTICK\r\n\r\nButtons current behaviors :\r\n\r\nSDL2:\r\nbetween 0 and BTN_MISC-1 : ignored\r\nbetween BTN_MISC and BTN_JOYSTICK-1 : second buttons group\r\nbetween BTN_JOYSTICK and KEY_MAX : first buttons group\r\n\r\nRA_UDEV:\r\nbetween 0 and KEY_UP-1 : ignored\r\nbetween KEY_UP and KEY_DOWN-1 : first buttons group\r\nbetween KEY_DOWN and BTN_MISC-1 : ignored\r\nbetween BTN_MISC and KEY_MAX : first buttons group\r\n\r\nSDL2 updated to :\r\nbetween 0 and KEY_MAX : first buttons group\r\nno keys are ignored, so, potentially, we could update ra too if some poeple have buttons working in es but not in ra.\r\nRisks :\r\n1) SDL1 compatibiliy\r\ntheses modifications break compabitility between sdl1 and sdl2.\r\nA joystick working with es but not working in ra could become not working on an other emulator based on sdl1.\r\n2) Buttons reordering\r\nA joystick configured in es could have to be reconfigured in case the buttons order has changed. However, if this occurs, it means that some buttons were already not working correctly in ra.\r\n\r\nSigned-off-by: Nicolas Adenis-Lamarre <nicolas.adenis-lamarre@gmail.com>","created_at":"2015-11-04T17:39:50Z","updated_at":"2015-11-04T17:39:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/pulls/40/commits","review_comments_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/pulls/40/comments","review_comment_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/issues/40/comments","statuses_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/statuses/91d0ff6ad573051e780ab8800208d8890dbb4b1f","head":{"label":"nadenislamarre:wiimote","ref":"wiimote","sha":"91d0ff6ad573051e780ab8800208d8890dbb4b1f","user":{"login":"nadenislamarre","id":5346913,"avatar_url":"https://avatars.githubusercontent.com/u/5346913?v=3","gravatar_id":"","url":"https://api.github.com/users/nadenislamarre","html_url":"https://github.com/nadenislamarre","followers_url":"https://api.github.com/users/nadenislamarre/followers","following_url":"https://api.github.com/users/nadenislamarre/following{/other_user}","gists_url":"https://api.github.com/users/nadenislamarre/gists{/gist_id}","starred_url":"https://api.github.com/users/nadenislamarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadenislamarre/subscriptions","organizations_url":"https://api.github.com/users/nadenislamarre/orgs","repos_url":"https://api.github.com/users/nadenislamarre/repos","events_url":"https://api.github.com/users/nadenislamarre/events{/privacy}","received_events_url":"https://api.github.com/users/nadenislamarre/received_events","type":"User","site_admin":false},"repo":{"id":45555931,"name":"recalbox-buildroot","full_name":"nadenislamarre/recalbox-buildroot","owner":{"login":"nadenislamarre","id":5346913,"avatar_url":"https://avatars.githubusercontent.com/u/5346913?v=3","gravatar_id":"","url":"https://api.github.com/users/nadenislamarre","html_url":"https://github.com/nadenislamarre","followers_url":"https://api.github.com/users/nadenislamarre/followers","following_url":"https://api.github.com/users/nadenislamarre/following{/other_user}","gists_url":"https://api.github.com/users/nadenislamarre/gists{/gist_id}","starred_url":"https://api.github.com/users/nadenislamarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadenislamarre/subscriptions","organizations_url":"https://api.github.com/users/nadenislamarre/orgs","repos_url":"https://api.github.com/users/nadenislamarre/repos","events_url":"https://api.github.com/users/nadenislamarre/events{/privacy}","received_events_url":"https://api.github.com/users/nadenislamarre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nadenislamarre/recalbox-buildroot","description":"recalbox system","fork":true,"url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot","forks_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/forks","keys_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/teams","hooks_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/hooks","issue_events_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/issues/events{/number}","events_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/events","assignees_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/assignees{/user}","branches_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/branches{/branch}","tags_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/tags","blobs_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/git/refs{/sha}","trees_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/statuses/{sha}","languages_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/languages","stargazers_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/stargazers","contributors_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/contributors","subscribers_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/subscribers","subscription_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/subscription","commits_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/commits{/sha}","git_commits_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/git/commits{/sha}","comments_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/comments{/number}","issue_comment_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/issues/comments{/number}","contents_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/contents/{+path}","compare_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/merges","archive_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/downloads","issues_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/issues{/number}","pulls_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/pulls{/number}","milestones_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/milestones{/number}","notifications_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/labels{/name}","releases_url":"https://api.github.com/repos/nadenislamarre/recalbox-buildroot/releases{/id}","created_at":"2015-11-04T17:37:10Z","updated_at":"2015-11-04T17:37:29Z","pushed_at":"2015-11-04T17:38:51Z","git_url":"git://github.com/nadenislamarre/recalbox-buildroot.git","ssh_url":"git@github.com:nadenislamarre/recalbox-buildroot.git","clone_url":"https://github.com/nadenislamarre/recalbox-buildroot.git","svn_url":"https://github.com/nadenislamarre/recalbox-buildroot","homepage":null,"size":187559,"stargazers_count":0,"watchers_count":0,"language":"GLSL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"unified"}},"base":{"label":"digitalLumberjack:unified","ref":"unified","sha":"85fa41b7fa07e9209d86b584b900fe2bae1cc3c2","user":{"login":"digitalLumberjack","id":1128425,"avatar_url":"https://avatars.githubusercontent.com/u/1128425?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalLumberjack","html_url":"https://github.com/digitalLumberjack","followers_url":"https://api.github.com/users/digitalLumberjack/followers","following_url":"https://api.github.com/users/digitalLumberjack/following{/other_user}","gists_url":"https://api.github.com/users/digitalLumberjack/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalLumberjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalLumberjack/subscriptions","organizations_url":"https://api.github.com/users/digitalLumberjack/orgs","repos_url":"https://api.github.com/users/digitalLumberjack/repos","events_url":"https://api.github.com/users/digitalLumberjack/events{/privacy}","received_events_url":"https://api.github.com/users/digitalLumberjack/received_events","type":"User","site_admin":false},"repo":{"id":29864190,"name":"recalbox-buildroot","full_name":"digitalLumberjack/recalbox-buildroot","owner":{"login":"digitalLumberjack","id":1128425,"avatar_url":"https://avatars.githubusercontent.com/u/1128425?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalLumberjack","html_url":"https://github.com/digitalLumberjack","followers_url":"https://api.github.com/users/digitalLumberjack/followers","following_url":"https://api.github.com/users/digitalLumberjack/following{/other_user}","gists_url":"https://api.github.com/users/digitalLumberjack/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalLumberjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalLumberjack/subscriptions","organizations_url":"https://api.github.com/users/digitalLumberjack/orgs","repos_url":"https://api.github.com/users/digitalLumberjack/repos","events_url":"https://api.github.com/users/digitalLumberjack/events{/privacy}","received_events_url":"https://api.github.com/users/digitalLumberjack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/digitalLumberjack/recalbox-buildroot","description":"recalbox system","fork":false,"url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot","forks_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/forks","keys_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/teams","hooks_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/hooks","issue_events_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/issues/events{/number}","events_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/events","assignees_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/assignees{/user}","branches_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/branches{/branch}","tags_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/tags","blobs_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/languages","stargazers_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/stargazers","contributors_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/contributors","subscribers_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/subscribers","subscription_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/subscription","commits_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/issues/comments{/number}","contents_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/contents/{+path}","compare_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/merges","archive_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/downloads","issues_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/issues{/number}","pulls_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/labels{/name}","releases_url":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/releases{/id}","created_at":"2015-01-26T14:21:26Z","updated_at":"2015-10-10T15:52:45Z","pushed_at":"2015-10-07T21:50:26Z","git_url":"git://github.com/digitalLumberjack/recalbox-buildroot.git","ssh_url":"git@github.com:digitalLumberjack/recalbox-buildroot.git","clone_url":"https://github.com/digitalLumberjack/recalbox-buildroot.git","svn_url":"https://github.com/digitalLumberjack/recalbox-buildroot","homepage":null,"size":187559,"stargazers_count":21,"watchers_count":21,"language":"GLSL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":7,"forks":27,"open_issues":7,"watchers":21,"default_branch":"unified"}},"_links":{"self":{"href":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/pulls/40"},"html":{"href":"https://github.com/digitalLumberjack/recalbox-buildroot/pull/40"},"issue":{"href":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/issues/40"},"comments":{"href":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/digitalLumberjack/recalbox-buildroot/statuses/91d0ff6ad573051e780ab8800208d8890dbb4b1f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":56,"deletions":0,"changed_files":2}}