{"action":"closed","issue":{"url":"https://api.github.com/repos/dreamstalker/rehlds/issues/46","labels_url":"https://api.github.com/repos/dreamstalker/rehlds/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/dreamstalker/rehlds/issues/46/comments","events_url":"https://api.github.com/repos/dreamstalker/rehlds/issues/46/events","html_url":"https://github.com/dreamstalker/rehlds/issues/46","id":93033925,"number":46,"title":"HLSDK NEWAPI function pfnShouldCollide doesn't work properly","user":{"login":"theAsmodai","id":3618509,"avatar_url":"https://avatars.githubusercontent.com/u/3618509?v=3","gravatar_id":"","url":"https://api.github.com/users/theAsmodai","html_url":"https://github.com/theAsmodai","followers_url":"https://api.github.com/users/theAsmodai/followers","following_url":"https://api.github.com/users/theAsmodai/following{/other_user}","gists_url":"https://api.github.com/users/theAsmodai/gists{/gist_id}","starred_url":"https://api.github.com/users/theAsmodai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theAsmodai/subscriptions","organizations_url":"https://api.github.com/users/theAsmodai/orgs","repos_url":"https://api.github.com/users/theAsmodai/repos","events_url":"https://api.github.com/users/theAsmodai/events{/privacy}","received_events_url":"https://api.github.com/users/theAsmodai/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dreamstalker/rehlds/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-07-04T17:49:18Z","updated_at":"2015-07-04T19:01:22Z","closed_at":"2015-07-04T19:01:22Z","body":"This bug was discovered by hzqst https://forums.alliedmods.net/member.php?u=39607\r\n\r\nWhen gamedll returns false in pfnShouldCollide (entities shouldn't collide), engine ignores collisions with all subsequent entities. This can lead to bugs in physics. The bug occurs because of a premature return from SV_ClipToLinks https://github.com/dreamstalker/rehlds/blob/master/rehlds/engine/world.cpp#L1196\r\n\r\n```c++\r\n\t\tif (gNewDLLFunctions.pfnShouldCollide && !gNewDLLFunctions.pfnShouldCollide(touch, clip->passedict))\r\n\t\t\treturn;\r\n```\r\nIt would be correct to continue the loop instead of return."}}