{"comment":{"url":"https://api.github.com/repos/NixOS/nix/comments/11229910","html_url":"https://github.com/NixOS/nix/commit/92f822d6a5c5e053185215e1792198c67f4c48e2#commitcomment-11229910","id":11229910,"user":{"login":"twhitehead","id":787843,"avatar_url":"https://avatars.githubusercontent.com/u/787843?v=3","gravatar_id":"","url":"https://api.github.com/users/twhitehead","html_url":"https://github.com/twhitehead","followers_url":"https://api.github.com/users/twhitehead/followers","following_url":"https://api.github.com/users/twhitehead/following{/other_user}","gists_url":"https://api.github.com/users/twhitehead/gists{/gist_id}","starred_url":"https://api.github.com/users/twhitehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twhitehead/subscriptions","organizations_url":"https://api.github.com/users/twhitehead/orgs","repos_url":"https://api.github.com/users/twhitehead/repos","events_url":"https://api.github.com/users/twhitehead/events{/privacy}","received_events_url":"https://api.github.com/users/twhitehead/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"92f822d6a5c5e053185215e1792198c67f4c48e2","created_at":"2015-05-17T13:08:23Z","updated_at":"2015-05-17T13:08:23Z","body":"I just meant the client-side programs (e.g., nix-env, nix-instantiate, etc.) will have to have access to the client certificate key.  Assuming no setgid/setuid/etc. stuff then this means the user will also have access and could use that to send their own custom crafted packets from that machine to the daemon.\r\n\r\nNothing too serious here as they could also do that under the current standard setup with the daemon running on the local machine and listening on the local socket.  Really just noting that the ssl/tls just brings security back up to the level of the unix socket case.  It doesn't make it better.\r\n\r\n(i.e., if there are clever ways to abuse the protocol or bugs in how the daemon handles messages, then local users will still be able to potentially exploit these to hack the daemon)"}}