{"action":"created","comment":{"url":"https://api.github.com/repos/kivy/kivy/pulls/comments/26325060","id":26325060,"diff_hunk":"@@ -291,7 +295,7 @@ def _toggle_dropdown(self, *largs):\n         children = ddn.container.children\n \n         if children:\n-            ddn.width = max([self.width, children[0].minimum_width])\n+            ddn.width = self.dropdown_width or max([self.width, children[0].minimum_width])","path":"kivy/uix/actionbar.py","position":16,"original_position":16,"commit_id":"8233c435b4d3893eb0bf898fad3d3d5c2359929f","original_commit_id":"8233c435b4d3893eb0bf898fad3d3d5c2359929f","user":{"login":"FeralBytes","id":7874274,"avatar_url":"https://avatars.githubusercontent.com/u/7874274?v=3","gravatar_id":"","url":"https://api.github.com/users/FeralBytes","html_url":"https://github.com/FeralBytes","followers_url":"https://api.github.com/users/FeralBytes/followers","following_url":"https://api.github.com/users/FeralBytes/following{/other_user}","gists_url":"https://api.github.com/users/FeralBytes/gists{/gist_id}","starred_url":"https://api.github.com/users/FeralBytes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FeralBytes/subscriptions","organizations_url":"https://api.github.com/users/FeralBytes/orgs","repos_url":"https://api.github.com/users/FeralBytes/repos","events_url":"https://api.github.com/users/FeralBytes/events{/privacy}","received_events_url":"https://api.github.com/users/FeralBytes/received_events","type":"User","site_admin":false},"body":"This always assigns what ever self.dropdown_width, which is the left side of the or statement. But if I don't set that, then my width will always be 0.","created_at":"2015-03-12T17:36:39Z","updated_at":"2015-03-12T17:36:39Z","html_url":"https://github.com/kivy/kivy/pull/3128#discussion_r26325060","pull_request_url":"https://api.github.com/repos/kivy/kivy/pulls/3128","_links":{"self":{"href":"https://api.github.com/repos/kivy/kivy/pulls/comments/26325060"},"html":{"href":"https://github.com/kivy/kivy/pull/3128#discussion_r26325060"},"pull_request":{"href":"https://api.github.com/repos/kivy/kivy/pulls/3128"}}},"pull_request":{"url":"https://api.github.com/repos/kivy/kivy/pulls/3128","id":31042768,"html_url":"https://github.com/kivy/kivy/pull/3128","diff_url":"https://github.com/kivy/kivy/pull/3128.diff","patch_url":"https://github.com/kivy/kivy/pull/3128.patch","issue_url":"https://api.github.com/repos/kivy/kivy/issues/3128","number":3128,"state":"open","locked":false,"title":"introduce ActionGroup.dropdown_width property","user":{"login":"denys-duchier","id":966422,"avatar_url":"https://avatars.githubusercontent.com/u/966422?v=3","gravatar_id":"","url":"https://api.github.com/users/denys-duchier","html_url":"https://github.com/denys-duchier","followers_url":"https://api.github.com/users/denys-duchier/followers","following_url":"https://api.github.com/users/denys-duchier/following{/other_user}","gists_url":"https://api.github.com/users/denys-duchier/gists{/gist_id}","starred_url":"https://api.github.com/users/denys-duchier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denys-duchier/subscriptions","organizations_url":"https://api.github.com/users/denys-duchier/orgs","repos_url":"https://api.github.com/users/denys-duchier/repos","events_url":"https://api.github.com/users/denys-duchier/events{/privacy}","received_events_url":"https://api.github.com/users/denys-duchier/received_events","type":"User","site_admin":false},"body":"This patch adds the dropdown_width property to ActionGroup and makes it easy to accommodate a dropdown list with wide items.  Full disclosure: it is already possible (but imho much less intuitive) to do something similar using the minimum_width property on the LAST item.","created_at":"2015-03-12T14:51:10Z","updated_at":"2015-03-12T17:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e77a5b2ec2a95df5ea821a4f6defbcf64f30edf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kivy/kivy/pulls/3128/commits","review_comments_url":"https://api.github.com/repos/kivy/kivy/pulls/3128/comments","review_comment_url":"https://api.github.com/repos/kivy/kivy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kivy/kivy/issues/3128/comments","statuses_url":"https://api.github.com/repos/kivy/kivy/statuses/8233c435b4d3893eb0bf898fad3d3d5c2359929f","head":{"label":"denys-duchier:actiongroup-ddn-width","ref":"actiongroup-ddn-width","sha":"8233c435b4d3893eb0bf898fad3d3d5c2359929f","user":{"login":"denys-duchier","id":966422,"avatar_url":"https://avatars.githubusercontent.com/u/966422?v=3","gravatar_id":"","url":"https://api.github.com/users/denys-duchier","html_url":"https://github.com/denys-duchier","followers_url":"https://api.github.com/users/denys-duchier/followers","following_url":"https://api.github.com/users/denys-duchier/following{/other_user}","gists_url":"https://api.github.com/users/denys-duchier/gists{/gist_id}","starred_url":"https://api.github.com/users/denys-duchier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denys-duchier/subscriptions","organizations_url":"https://api.github.com/users/denys-duchier/orgs","repos_url":"https://api.github.com/users/denys-duchier/repos","events_url":"https://api.github.com/users/denys-duchier/events{/privacy}","received_events_url":"https://api.github.com/users/denys-duchier/received_events","type":"User","site_admin":false},"repo":{"id":30039445,"name":"kivy","full_name":"denys-duchier/kivy","owner":{"login":"denys-duchier","id":966422,"avatar_url":"https://avatars.githubusercontent.com/u/966422?v=3","gravatar_id":"","url":"https://api.github.com/users/denys-duchier","html_url":"https://github.com/denys-duchier","followers_url":"https://api.github.com/users/denys-duchier/followers","following_url":"https://api.github.com/users/denys-duchier/following{/other_user}","gists_url":"https://api.github.com/users/denys-duchier/gists{/gist_id}","starred_url":"https://api.github.com/users/denys-duchier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denys-duchier/subscriptions","organizations_url":"https://api.github.com/users/denys-duchier/orgs","repos_url":"https://api.github.com/users/denys-duchier/repos","events_url":"https://api.github.com/users/denys-duchier/events{/privacy}","received_events_url":"https://api.github.com/users/denys-duchier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/denys-duchier/kivy","description":"Open source Python framework for creating NUI applications, running on Windows, Linux, OS X, Android and iOS","fork":true,"url":"https://api.github.com/repos/denys-duchier/kivy","forks_url":"https://api.github.com/repos/denys-duchier/kivy/forks","keys_url":"https://api.github.com/repos/denys-duchier/kivy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/denys-duchier/kivy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/denys-duchier/kivy/teams","hooks_url":"https://api.github.com/repos/denys-duchier/kivy/hooks","issue_events_url":"https://api.github.com/repos/denys-duchier/kivy/issues/events{/number}","events_url":"https://api.github.com/repos/denys-duchier/kivy/events","assignees_url":"https://api.github.com/repos/denys-duchier/kivy/assignees{/user}","branches_url":"https://api.github.com/repos/denys-duchier/kivy/branches{/branch}","tags_url":"https://api.github.com/repos/denys-duchier/kivy/tags","blobs_url":"https://api.github.com/repos/denys-duchier/kivy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/denys-duchier/kivy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/denys-duchier/kivy/git/refs{/sha}","trees_url":"https://api.github.com/repos/denys-duchier/kivy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/denys-duchier/kivy/statuses/{sha}","languages_url":"https://api.github.com/repos/denys-duchier/kivy/languages","stargazers_url":"https://api.github.com/repos/denys-duchier/kivy/stargazers","contributors_url":"https://api.github.com/repos/denys-duchier/kivy/contributors","subscribers_url":"https://api.github.com/repos/denys-duchier/kivy/subscribers","subscription_url":"https://api.github.com/repos/denys-duchier/kivy/subscription","commits_url":"https://api.github.com/repos/denys-duchier/kivy/commits{/sha}","git_commits_url":"https://api.github.com/repos/denys-duchier/kivy/git/commits{/sha}","comments_url":"https://api.github.com/repos/denys-duchier/kivy/comments{/number}","issue_comment_url":"https://api.github.com/repos/denys-duchier/kivy/issues/comments{/number}","contents_url":"https://api.github.com/repos/denys-duchier/kivy/contents/{+path}","compare_url":"https://api.github.com/repos/denys-duchier/kivy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/denys-duchier/kivy/merges","archive_url":"https://api.github.com/repos/denys-duchier/kivy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/denys-duchier/kivy/downloads","issues_url":"https://api.github.com/repos/denys-duchier/kivy/issues{/number}","pulls_url":"https://api.github.com/repos/denys-duchier/kivy/pulls{/number}","milestones_url":"https://api.github.com/repos/denys-duchier/kivy/milestones{/number}","notifications_url":"https://api.github.com/repos/denys-duchier/kivy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/denys-duchier/kivy/labels{/name}","releases_url":"https://api.github.com/repos/denys-duchier/kivy/releases{/id}","created_at":"2015-01-29T20:23:08Z","updated_at":"2015-03-06T17:36:01Z","pushed_at":"2015-03-12T14:42:59Z","git_url":"git://github.com/denys-duchier/kivy.git","ssh_url":"git@github.com:denys-duchier/kivy.git","clone_url":"https://github.com/denys-duchier/kivy.git","svn_url":"https://github.com/denys-duchier/kivy","homepage":"http://kivy.org","size":45455,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kivy:master","ref":"master","sha":"4bdd9fab6eec7a2ba22c6fe6d4f513a1be755ea2","user":{"login":"kivy","id":1266152,"avatar_url":"https://avatars.githubusercontent.com/u/1266152?v=3","gravatar_id":"","url":"https://api.github.com/users/kivy","html_url":"https://github.com/kivy","followers_url":"https://api.github.com/users/kivy/followers","following_url":"https://api.github.com/users/kivy/following{/other_user}","gists_url":"https://api.github.com/users/kivy/gists{/gist_id}","starred_url":"https://api.github.com/users/kivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivy/subscriptions","organizations_url":"https://api.github.com/users/kivy/orgs","repos_url":"https://api.github.com/users/kivy/repos","events_url":"https://api.github.com/users/kivy/events{/privacy}","received_events_url":"https://api.github.com/users/kivy/received_events","type":"Organization","site_admin":false},"repo":{"id":1049095,"name":"kivy","full_name":"kivy/kivy","owner":{"login":"kivy","id":1266152,"avatar_url":"https://avatars.githubusercontent.com/u/1266152?v=3","gravatar_id":"","url":"https://api.github.com/users/kivy","html_url":"https://github.com/kivy","followers_url":"https://api.github.com/users/kivy/followers","following_url":"https://api.github.com/users/kivy/following{/other_user}","gists_url":"https://api.github.com/users/kivy/gists{/gist_id}","starred_url":"https://api.github.com/users/kivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kivy/subscriptions","organizations_url":"https://api.github.com/users/kivy/orgs","repos_url":"https://api.github.com/users/kivy/repos","events_url":"https://api.github.com/users/kivy/events{/privacy}","received_events_url":"https://api.github.com/users/kivy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kivy/kivy","description":"Open source Python framework for creating NUI applications, running on Windows, Linux, OS X, Android and iOS","fork":false,"url":"https://api.github.com/repos/kivy/kivy","forks_url":"https://api.github.com/repos/kivy/kivy/forks","keys_url":"https://api.github.com/repos/kivy/kivy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kivy/kivy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kivy/kivy/teams","hooks_url":"https://api.github.com/repos/kivy/kivy/hooks","issue_events_url":"https://api.github.com/repos/kivy/kivy/issues/events{/number}","events_url":"https://api.github.com/repos/kivy/kivy/events","assignees_url":"https://api.github.com/repos/kivy/kivy/assignees{/user}","branches_url":"https://api.github.com/repos/kivy/kivy/branches{/branch}","tags_url":"https://api.github.com/repos/kivy/kivy/tags","blobs_url":"https://api.github.com/repos/kivy/kivy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kivy/kivy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kivy/kivy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kivy/kivy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kivy/kivy/statuses/{sha}","languages_url":"https://api.github.com/repos/kivy/kivy/languages","stargazers_url":"https://api.github.com/repos/kivy/kivy/stargazers","contributors_url":"https://api.github.com/repos/kivy/kivy/contributors","subscribers_url":"https://api.github.com/repos/kivy/kivy/subscribers","subscription_url":"https://api.github.com/repos/kivy/kivy/subscription","commits_url":"https://api.github.com/repos/kivy/kivy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kivy/kivy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kivy/kivy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kivy/kivy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kivy/kivy/contents/{+path}","compare_url":"https://api.github.com/repos/kivy/kivy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kivy/kivy/merges","archive_url":"https://api.github.com/repos/kivy/kivy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kivy/kivy/downloads","issues_url":"https://api.github.com/repos/kivy/kivy/issues{/number}","pulls_url":"https://api.github.com/repos/kivy/kivy/pulls{/number}","milestones_url":"https://api.github.com/repos/kivy/kivy/milestones{/number}","notifications_url":"https://api.github.com/repos/kivy/kivy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kivy/kivy/labels{/name}","releases_url":"https://api.github.com/repos/kivy/kivy/releases{/id}","created_at":"2010-11-03T20:27:32Z","updated_at":"2015-03-12T17:13:07Z","pushed_at":"2015-03-11T14:30:02Z","git_url":"git://github.com/kivy/kivy.git","ssh_url":"git@github.com:kivy/kivy.git","clone_url":"https://github.com/kivy/kivy.git","svn_url":"https://github.com/kivy/kivy","homepage":"http://kivy.org","size":155024,"stargazers_count":2836,"watchers_count":2836,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":716,"mirror_url":null,"open_issues_count":370,"forks":716,"open_issues":370,"watchers":2836,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kivy/kivy/pulls/3128"},"html":{"href":"https://github.com/kivy/kivy/pull/3128"},"issue":{"href":"https://api.github.com/repos/kivy/kivy/issues/3128"},"comments":{"href":"https://api.github.com/repos/kivy/kivy/issues/3128/comments"},"review_comments":{"href":"https://api.github.com/repos/kivy/kivy/pulls/3128/comments"},"review_comment":{"href":"https://api.github.com/repos/kivy/kivy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kivy/kivy/pulls/3128/commits"},"statuses":{"href":"https://api.github.com/repos/kivy/kivy/statuses/8233c435b4d3893eb0bf898fad3d3d5c2359929f"}}}}