{"action":"opened","number":7997,"pull_request":{"url":"https://api.github.com/repos/ipython/ipython/pulls/7997","id":30715361,"html_url":"https://github.com/ipython/ipython/pull/7997","diff_url":"https://github.com/ipython/ipython/pull/7997.diff","patch_url":"https://github.com/ipython/ipython/pull/7997.patch","issue_url":"https://api.github.com/repos/ipython/ipython/issues/7997","number":7997,"state":"open","locked":false,"title":"Add sticky header effect without Javascript","user":{"login":"rsmith31415","id":599274,"avatar_url":"https://avatars.githubusercontent.com/u/599274?v=3","gravatar_id":"","url":"https://api.github.com/users/rsmith31415","html_url":"https://github.com/rsmith31415","followers_url":"https://api.github.com/users/rsmith31415/followers","following_url":"https://api.github.com/users/rsmith31415/following{/other_user}","gists_url":"https://api.github.com/users/rsmith31415/gists{/gist_id}","starred_url":"https://api.github.com/users/rsmith31415/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsmith31415/subscriptions","organizations_url":"https://api.github.com/users/rsmith31415/orgs","repos_url":"https://api.github.com/users/rsmith31415/repos","events_url":"https://api.github.com/users/rsmith31415/events{/privacy}","received_events_url":"https://api.github.com/users/rsmith31415/received_events","type":"User","site_admin":false},"body":"This is supposed to be a step to fix issue #7968. It allows to obtain the same current behavior without using Javascript and then it will be possible to fix #7701. However, more input is needed.\r\n\r\nSticky header when scrolling down:\r\n\r\n![screenshot from 2015-03-07 21 23 29](https://cloud.githubusercontent.com/assets/599274/6544330/a2fda044-c510-11e4-9eda-bc4521d4cbc2.png)\r\n\r\nKeeping the same margin between `#header` and `#site` elements when resizing window:\r\n\r\n![screenshot from 2015-03-07 21 25 08](https://cloud.githubusercontent.com/assets/599274/6544331/be48e214-c510-11e4-8513-7796590183eb.png)\r\n\r\nSmall issue. If there are scrollbars, the width of the window is calculated differently. As a consequence, the media query is not activated as it should when the header's height is increased:\r\n\r\n![screenshot from 2015-03-07 21 25 51](https://cloud.githubusercontent.com/assets/599274/6544332/d9c914d2-c510-11e4-93b8-d30329bb5d4d.png)\r\n\r\nIf the browser is shrunk a bit more, then the media query takes effect. Unfortunately, I don't think there is a clean solution for this. Removing the media queries could be an option to give a more consistent behavior although this reduces the margin between `#header` and `#site` in small windows.\r\n\r\n`/tree` page is not affected by these changes because I added classes specific to `/tree` and `/notebook`.","created_at":"2015-03-08T06:01:48Z","updated_at":"2015-03-08T06:01:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ipython/ipython/pulls/7997/commits","review_comments_url":"https://api.github.com/repos/ipython/ipython/pulls/7997/comments","review_comment_url":"https://api.github.com/repos/ipython/ipython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipython/ipython/issues/7997/comments","statuses_url":"https://api.github.com/repos/ipython/ipython/statuses/dea977c0df9083bbea39917f8e31296a441d7e4a","head":{"label":"rsmith31415:add-sticky-header","ref":"add-sticky-header","sha":"dea977c0df9083bbea39917f8e31296a441d7e4a","user":{"login":"rsmith31415","id":599274,"avatar_url":"https://avatars.githubusercontent.com/u/599274?v=3","gravatar_id":"","url":"https://api.github.com/users/rsmith31415","html_url":"https://github.com/rsmith31415","followers_url":"https://api.github.com/users/rsmith31415/followers","following_url":"https://api.github.com/users/rsmith31415/following{/other_user}","gists_url":"https://api.github.com/users/rsmith31415/gists{/gist_id}","starred_url":"https://api.github.com/users/rsmith31415/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsmith31415/subscriptions","organizations_url":"https://api.github.com/users/rsmith31415/orgs","repos_url":"https://api.github.com/users/rsmith31415/repos","events_url":"https://api.github.com/users/rsmith31415/events{/privacy}","received_events_url":"https://api.github.com/users/rsmith31415/received_events","type":"User","site_admin":false},"repo":{"id":31839720,"name":"ipython","full_name":"rsmith31415/ipython","owner":{"login":"rsmith31415","id":599274,"avatar_url":"https://avatars.githubusercontent.com/u/599274?v=3","gravatar_id":"","url":"https://api.github.com/users/rsmith31415","html_url":"https://github.com/rsmith31415","followers_url":"https://api.github.com/users/rsmith31415/followers","following_url":"https://api.github.com/users/rsmith31415/following{/other_user}","gists_url":"https://api.github.com/users/rsmith31415/gists{/gist_id}","starred_url":"https://api.github.com/users/rsmith31415/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsmith31415/subscriptions","organizations_url":"https://api.github.com/users/rsmith31415/orgs","repos_url":"https://api.github.com/users/rsmith31415/repos","events_url":"https://api.github.com/users/rsmith31415/events{/privacy}","received_events_url":"https://api.github.com/users/rsmith31415/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsmith31415/ipython","description":"Official repository for IPython itself. Other repos in the IPython organization contain things like the website, documentation builds, etc.","fork":true,"url":"https://api.github.com/repos/rsmith31415/ipython","forks_url":"https://api.github.com/repos/rsmith31415/ipython/forks","keys_url":"https://api.github.com/repos/rsmith31415/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsmith31415/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsmith31415/ipython/teams","hooks_url":"https://api.github.com/repos/rsmith31415/ipython/hooks","issue_events_url":"https://api.github.com/repos/rsmith31415/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/rsmith31415/ipython/events","assignees_url":"https://api.github.com/repos/rsmith31415/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/rsmith31415/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/rsmith31415/ipython/tags","blobs_url":"https://api.github.com/repos/rsmith31415/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsmith31415/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsmith31415/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsmith31415/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsmith31415/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/rsmith31415/ipython/languages","stargazers_url":"https://api.github.com/repos/rsmith31415/ipython/stargazers","contributors_url":"https://api.github.com/repos/rsmith31415/ipython/contributors","subscribers_url":"https://api.github.com/repos/rsmith31415/ipython/subscribers","subscription_url":"https://api.github.com/repos/rsmith31415/ipython/subscription","commits_url":"https://api.github.com/repos/rsmith31415/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsmith31415/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsmith31415/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsmith31415/ipython/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsmith31415/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/rsmith31415/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsmith31415/ipython/merges","archive_url":"https://api.github.com/repos/rsmith31415/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsmith31415/ipython/downloads","issues_url":"https://api.github.com/repos/rsmith31415/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/rsmith31415/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/rsmith31415/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/rsmith31415/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsmith31415/ipython/labels{/name}","releases_url":"https://api.github.com/repos/rsmith31415/ipython/releases{/id}","created_at":"2015-03-08T05:37:15Z","updated_at":"2015-03-08T05:37:27Z","pushed_at":"2015-03-08T05:43:45Z","git_url":"git://github.com/rsmith31415/ipython.git","ssh_url":"git@github.com:rsmith31415/ipython.git","clone_url":"https://github.com/rsmith31415/ipython.git","svn_url":"https://github.com/rsmith31415/ipython","homepage":"http://ipython.org","size":111260,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ipython:master","ref":"master","sha":"932d2b017c038c1515f41a61a95bc3235fcfdc11","user":{"login":"ipython","id":230453,"avatar_url":"https://avatars.githubusercontent.com/u/230453?v=3","gravatar_id":"","url":"https://api.github.com/users/ipython","html_url":"https://github.com/ipython","followers_url":"https://api.github.com/users/ipython/followers","following_url":"https://api.github.com/users/ipython/following{/other_user}","gists_url":"https://api.github.com/users/ipython/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython/subscriptions","organizations_url":"https://api.github.com/users/ipython/orgs","repos_url":"https://api.github.com/users/ipython/repos","events_url":"https://api.github.com/users/ipython/events{/privacy}","received_events_url":"https://api.github.com/users/ipython/received_events","type":"Organization","site_admin":false},"repo":{"id":658518,"name":"ipython","full_name":"ipython/ipython","owner":{"login":"ipython","id":230453,"avatar_url":"https://avatars.githubusercontent.com/u/230453?v=3","gravatar_id":"","url":"https://api.github.com/users/ipython","html_url":"https://github.com/ipython","followers_url":"https://api.github.com/users/ipython/followers","following_url":"https://api.github.com/users/ipython/following{/other_user}","gists_url":"https://api.github.com/users/ipython/gists{/gist_id}","starred_url":"https://api.github.com/users/ipython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipython/subscriptions","organizations_url":"https://api.github.com/users/ipython/orgs","repos_url":"https://api.github.com/users/ipython/repos","events_url":"https://api.github.com/users/ipython/events{/privacy}","received_events_url":"https://api.github.com/users/ipython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipython/ipython","description":"Official repository for IPython itself. Other repos in the IPython organization contain things like the website, documentation builds, etc.","fork":false,"url":"https://api.github.com/repos/ipython/ipython","forks_url":"https://api.github.com/repos/ipython/ipython/forks","keys_url":"https://api.github.com/repos/ipython/ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipython/ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipython/ipython/teams","hooks_url":"https://api.github.com/repos/ipython/ipython/hooks","issue_events_url":"https://api.github.com/repos/ipython/ipython/issues/events{/number}","events_url":"https://api.github.com/repos/ipython/ipython/events","assignees_url":"https://api.github.com/repos/ipython/ipython/assignees{/user}","branches_url":"https://api.github.com/repos/ipython/ipython/branches{/branch}","tags_url":"https://api.github.com/repos/ipython/ipython/tags","blobs_url":"https://api.github.com/repos/ipython/ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipython/ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipython/ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipython/ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipython/ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/ipython/ipython/languages","stargazers_url":"https://api.github.com/repos/ipython/ipython/stargazers","contributors_url":"https://api.github.com/repos/ipython/ipython/contributors","subscribers_url":"https://api.github.com/repos/ipython/ipython/subscribers","subscription_url":"https://api.github.com/repos/ipython/ipython/subscription","commits_url":"https://api.github.com/repos/ipython/ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipython/ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipython/ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipython/ipython/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipython/ipython/contents/{+path}","compare_url":"https://api.github.com/repos/ipython/ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipython/ipython/merges","archive_url":"https://api.github.com/repos/ipython/ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipython/ipython/downloads","issues_url":"https://api.github.com/repos/ipython/ipython/issues{/number}","pulls_url":"https://api.github.com/repos/ipython/ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/ipython/ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/ipython/ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipython/ipython/labels{/name}","releases_url":"https://api.github.com/repos/ipython/ipython/releases{/id}","created_at":"2010-05-10T04:46:06Z","updated_at":"2015-03-08T05:37:58Z","pushed_at":"2015-03-07T20:43:59Z","git_url":"git://github.com/ipython/ipython.git","ssh_url":"git@github.com:ipython/ipython.git","clone_url":"https://github.com/ipython/ipython.git","svn_url":"https://github.com/ipython/ipython","homepage":"http://ipython.org","size":111260,"stargazers_count":5925,"watchers_count":5925,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1763,"mirror_url":null,"open_issues_count":845,"forks":1763,"open_issues":845,"watchers":5925,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipython/ipython/pulls/7997"},"html":{"href":"https://github.com/ipython/ipython/pull/7997"},"issue":{"href":"https://api.github.com/repos/ipython/ipython/issues/7997"},"comments":{"href":"https://api.github.com/repos/ipython/ipython/issues/7997/comments"},"review_comments":{"href":"https://api.github.com/repos/ipython/ipython/pulls/7997/comments"},"review_comment":{"href":"https://api.github.com/repos/ipython/ipython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipython/ipython/pulls/7997/commits"},"statuses":{"href":"https://api.github.com/repos/ipython/ipython/statuses/dea977c0df9083bbea39917f8e31296a441d7e4a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":80,"deletions":12,"changed_files":8}}