{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/3542","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/3542/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/3542/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/3542/events","html_url":"https://github.com/dotnet/corefx/issues/3542","id":108956235,"number":3542,"title":"Should sockets performance tests be inner loop?","user":{"login":"ellismg","id":9602953,"avatar_url":"https://avatars.githubusercontent.com/u/9602953?v=3","gravatar_id":"","url":"https://api.github.com/users/ellismg","html_url":"https://github.com/ellismg","followers_url":"https://api.github.com/users/ellismg/followers","following_url":"https://api.github.com/users/ellismg/following{/other_user}","gists_url":"https://api.github.com/users/ellismg/gists{/gist_id}","starred_url":"https://api.github.com/users/ellismg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellismg/subscriptions","organizations_url":"https://api.github.com/users/ellismg/orgs","repos_url":"https://api.github.com/users/ellismg/repos","events_url":"https://api.github.com/users/ellismg/events{/privacy}","received_events_url":"https://api.github.com/users/ellismg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/bug","name":"bug","color":"207de5"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/System.Net","name":"System.Net","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/3","html_url":"https://github.com/dotnet/corefx/milestones/1.0.0-rc1","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/3/labels","id":1248712,"number":3,"title":"1.0.0-rc1","description":"Nov 2015 (https://github.com/aspnet/Home/wiki/Roadmap)\r\n","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":147,"closed_issues":23,"state":"open","created_at":"2015-08-10T18:00:33Z","updated_at":"2015-10-03T20:55:16Z","due_on":"2015-11-18T08:00:00Z","closed_at":null},"comments":6,"created_at":"2015-09-29T20:45:25Z","updated_at":"2015-10-05T16:09:24Z","closed_at":"2015-10-02T17:20:19Z","body":"These tests have failed to meet the baseline a few times, but they pass on re-run.\r\n\r\nhttp://dotnet-ci.cloudapp.net/job/dotnet_corefx_windows_debug_prtest/4407/testReport/junit/System.Net.Sockets.Performance.Tests/SocketPerformanceAPMTests/SocketPerformance_SingleSocketClientAsync_LocalHostServerAPM/\r\n\r\nWhen the CI System runs jobs, it can run multiple jobs on the same machine at the same time, could that be causing problems or are there real problems here that we should be investigating?\r\n\r\nIt seems like the long term plan is that we move to @ianhays's [Performance] stuff.  Can we just adopt these changes for that instead of having yet another perf testing thing that also runs inner loop?\r\n\r\n/cc @CIPop @davidsh @pgavlin @bartonjs."},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/145584344","html_url":"https://github.com/dotnet/corefx/issues/3542#issuecomment-145584344","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/3542","id":145584344,"user":{"login":"bartonjs","id":10642668,"avatar_url":"https://avatars.githubusercontent.com/u/10642668?v=3","gravatar_id":"","url":"https://api.github.com/users/bartonjs","html_url":"https://github.com/bartonjs","followers_url":"https://api.github.com/users/bartonjs/followers","following_url":"https://api.github.com/users/bartonjs/following{/other_user}","gists_url":"https://api.github.com/users/bartonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bartonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartonjs/subscriptions","organizations_url":"https://api.github.com/users/bartonjs/orgs","repos_url":"https://api.github.com/users/bartonjs/repos","events_url":"https://api.github.com/users/bartonjs/events{/privacy}","received_events_url":"https://api.github.com/users/bartonjs/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T16:09:24Z","updated_at":"2015-10-05T16:09:24Z","body":"> eventually I do believe we'll want perf legs as part of CI jobs, so that we can verify that core performance isn't regressed\r\n\r\nRight now one potential problem with that is that we allow multiple PR jobs to run on the same machines, in parallel.  So wall-clock based performance metrics can be impacted by process switching."}}