{"action":"created","issue":{"url":"https://api.github.com/repos/mikaelpatel/Cosa/issues/363","labels_url":"https://api.github.com/repos/mikaelpatel/Cosa/issues/363/labels{/name}","comments_url":"https://api.github.com/repos/mikaelpatel/Cosa/issues/363/comments","events_url":"https://api.github.com/repos/mikaelpatel/Cosa/issues/363/events","html_url":"https://github.com/mikaelpatel/Cosa/pull/363","id":79614950,"number":363,"title":"W5100 driver refactor, simplifies code and reduces elf size slightly","user":{"login":"dansut","id":100365,"avatar_url":"https://avatars.githubusercontent.com/u/100365?v=3","gravatar_id":"","url":"https://api.github.com/users/dansut","html_url":"https://github.com/dansut","followers_url":"https://api.github.com/users/dansut/followers","following_url":"https://api.github.com/users/dansut/following{/other_user}","gists_url":"https://api.github.com/users/dansut/gists{/gist_id}","starred_url":"https://api.github.com/users/dansut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dansut/subscriptions","organizations_url":"https://api.github.com/users/dansut/orgs","repos_url":"https://api.github.com/users/dansut/repos","events_url":"https://api.github.com/users/dansut/events{/privacy}","received_events_url":"https://api.github.com/users/dansut/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-22T21:22:14Z","updated_at":"2015-05-26T08:55:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mikaelpatel/Cosa/pulls/363","html_url":"https://github.com/mikaelpatel/Cosa/pull/363","diff_url":"https://github.com/mikaelpatel/Cosa/pull/363.diff","patch_url":"https://github.com/mikaelpatel/Cosa/pull/363.patch"},"body":"W5100::write method gains bool progmem parameter following pattern I have seen used elsewhere in codebase.\r\n\r\nThis submission is a precursor W5200/W5500 drivers that I currently have working purely as modifications to this driver but am interested in thoughts on desired way to code these so they fit in with any plans there might be to support multiple NIC drivers through a common interface.\r\n\r\nAs an aside I have rolled back my avr-gcc from 4.9.2 to 4.8.4 as I seem to have hit in a compiler bug in 4.9 which corrupts memory in ICMP driver (seq partially overwrites id space) - can be fixed with a slight code alteration but got concerned for others area of code that were failing but not so visibly. I can explain further if you have any interest."},"comment":{"url":"https://api.github.com/repos/mikaelpatel/Cosa/issues/comments/105452942","html_url":"https://github.com/mikaelpatel/Cosa/pull/363#issuecomment-105452942","issue_url":"https://api.github.com/repos/mikaelpatel/Cosa/issues/363","id":105452942,"user":{"login":"mikaelpatel","id":2774083,"avatar_url":"https://avatars.githubusercontent.com/u/2774083?v=3","gravatar_id":"","url":"https://api.github.com/users/mikaelpatel","html_url":"https://github.com/mikaelpatel","followers_url":"https://api.github.com/users/mikaelpatel/followers","following_url":"https://api.github.com/users/mikaelpatel/following{/other_user}","gists_url":"https://api.github.com/users/mikaelpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelpatel/subscriptions","organizations_url":"https://api.github.com/users/mikaelpatel/orgs","repos_url":"https://api.github.com/users/mikaelpatel/repos","events_url":"https://api.github.com/users/mikaelpatel/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelpatel/received_events","type":"User","site_admin":false},"created_at":"2015-05-26T08:55:36Z","updated_at":"2015-05-26T08:55:36Z","body":"Do not see any big issue with this PR. My concern was mostly that there could be a lose of speed if the conditional memory read (progmem or sram) took longer than the SPI transfer.\r\n\r\nI had a brief look at the changes to support W5200. It would be nice to maintain the same code base for both devices or at least see W5200 as an extension of the W5100 driver. There seems to be changes to the registers that does not really allow this?? In this case I would recommend going for separate drivers for each W5X00. I will have another look.\r\n\r\nCheers!"}}