{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/24339160","id":24339160,"diff_hunk":"@@ -698,11 +698,13 @@ suite('Settings Test Suite >', function() {\n         dataLimitInput.value = '124.56';\n         dataLimitInput.dispatchEvent(evtInput);\n \n-        var limitUnitValue = dataLimitSwitchUnitButton\n-          .querySelector('span.tag');\n-        assert.equal(limitUnitValue.textContent, 'MB');\n+        assert.equal(dataLimitSwitchUnitButton.getAttribute('data-l10n-id'),\n+          'unit-MB');","path":"apps/costcontrol/test/unit/settings_test.js","position":8,"original_position":8,"commit_id":"a714dc5cf6a6d68a11db067918802f3181536df6","original_commit_id":"a714dc5cf6a6d68a11db067918802f3181536df6","user":{"login":"gitmai","id":4752466,"avatar_url":"https://avatars.githubusercontent.com/u/4752466?v=3","gravatar_id":"","url":"https://api.github.com/users/gitmai","html_url":"https://github.com/gitmai","followers_url":"https://api.github.com/users/gitmai/followers","following_url":"https://api.github.com/users/gitmai/following{/other_user}","gists_url":"https://api.github.com/users/gitmai/gists{/gist_id}","starred_url":"https://api.github.com/users/gitmai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitmai/subscriptions","organizations_url":"https://api.github.com/users/gitmai/orgs","repos_url":"https://api.github.com/users/gitmai/repos","events_url":"https://api.github.com/users/gitmai/events{/privacy}","received_events_url":"https://api.github.com/users/gitmai/received_events","type":"User","site_admin":false},"body":"nit: in Usage we usually align the function parameters like:\r\nassert.equal(dataLimitSwitchUnitButton.getAttribute('data-l10n-id'),\r\n                     'unit-MB');","created_at":"2015-02-09T16:08:44Z","updated_at":"2015-02-09T16:08:44Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/27978#discussion_r24339160","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27978","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/24339160"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27978#discussion_r24339160"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27978"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27978","id":28745282,"html_url":"https://github.com/mozilla-b2g/gaia/pull/27978","diff_url":"https://github.com/mozilla-b2g/gaia/pull/27978.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/27978.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27978","number":27978,"state":"open","locked":false,"title":"Bug 1069476 - improved accessibility for the data usage limit view.","user":{"login":"yzen","id":561275,"avatar_url":"https://avatars.githubusercontent.com/u/561275?v=3","gravatar_id":"","url":"https://api.github.com/users/yzen","html_url":"https://github.com/yzen","followers_url":"https://api.github.com/users/yzen/followers","following_url":"https://api.github.com/users/yzen/following{/other_user}","gists_url":"https://api.github.com/users/yzen/gists{/gist_id}","starred_url":"https://api.github.com/users/yzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yzen/subscriptions","organizations_url":"https://api.github.com/users/yzen/orgs","repos_url":"https://api.github.com/users/yzen/repos","events_url":"https://api.github.com/users/yzen/events{/privacy}","received_events_url":"https://api.github.com/users/yzen/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-05T17:46:29Z","updated_at":"2015-02-09T16:08:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"170e9d45e6cc27d283c911be5366e369a44ad45d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27978/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27978/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27978/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/a714dc5cf6a6d68a11db067918802f3181536df6","head":{"label":"yzen:bug-1069476","ref":"bug-1069476","sha":"a714dc5cf6a6d68a11db067918802f3181536df6","user":{"login":"yzen","id":561275,"avatar_url":"https://avatars.githubusercontent.com/u/561275?v=3","gravatar_id":"","url":"https://api.github.com/users/yzen","html_url":"https://github.com/yzen","followers_url":"https://api.github.com/users/yzen/followers","following_url":"https://api.github.com/users/yzen/following{/other_user}","gists_url":"https://api.github.com/users/yzen/gists{/gist_id}","starred_url":"https://api.github.com/users/yzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yzen/subscriptions","organizations_url":"https://api.github.com/users/yzen/orgs","repos_url":"https://api.github.com/users/yzen/repos","events_url":"https://api.github.com/users/yzen/events{/privacy}","received_events_url":"https://api.github.com/users/yzen/received_events","type":"User","site_admin":false},"repo":{"id":9679958,"name":"gaia","full_name":"yzen/gaia","owner":{"login":"yzen","id":561275,"avatar_url":"https://avatars.githubusercontent.com/u/561275?v=3","gravatar_id":"","url":"https://api.github.com/users/yzen","html_url":"https://github.com/yzen","followers_url":"https://api.github.com/users/yzen/followers","following_url":"https://api.github.com/users/yzen/following{/other_user}","gists_url":"https://api.github.com/users/yzen/gists{/gist_id}","starred_url":"https://api.github.com/users/yzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yzen/subscriptions","organizations_url":"https://api.github.com/users/yzen/orgs","repos_url":"https://api.github.com/users/yzen/repos","events_url":"https://api.github.com/users/yzen/events{/privacy}","received_events_url":"https://api.github.com/users/yzen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yzen/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/yzen/gaia","forks_url":"https://api.github.com/repos/yzen/gaia/forks","keys_url":"https://api.github.com/repos/yzen/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yzen/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yzen/gaia/teams","hooks_url":"https://api.github.com/repos/yzen/gaia/hooks","issue_events_url":"https://api.github.com/repos/yzen/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/yzen/gaia/events","assignees_url":"https://api.github.com/repos/yzen/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/yzen/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/yzen/gaia/tags","blobs_url":"https://api.github.com/repos/yzen/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yzen/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yzen/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/yzen/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yzen/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/yzen/gaia/languages","stargazers_url":"https://api.github.com/repos/yzen/gaia/stargazers","contributors_url":"https://api.github.com/repos/yzen/gaia/contributors","subscribers_url":"https://api.github.com/repos/yzen/gaia/subscribers","subscription_url":"https://api.github.com/repos/yzen/gaia/subscription","commits_url":"https://api.github.com/repos/yzen/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/yzen/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/yzen/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/yzen/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/yzen/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/yzen/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yzen/gaia/merges","archive_url":"https://api.github.com/repos/yzen/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yzen/gaia/downloads","issues_url":"https://api.github.com/repos/yzen/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/yzen/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/yzen/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/yzen/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yzen/gaia/labels{/name}","releases_url":"https://api.github.com/repos/yzen/gaia/releases{/id}","created_at":"2013-04-25T19:49:15Z","updated_at":"2015-02-09T15:21:05Z","pushed_at":"2015-02-09T15:21:04Z","git_url":"git://github.com/yzen/gaia.git","ssh_url":"git@github.com:yzen/gaia.git","clone_url":"https://github.com/yzen/gaia.git","svn_url":"https://github.com/yzen/gaia","homepage":"https://wiki.mozilla.org/B2G","size":863963,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"ded85e94a325d1546d5c46fbe68153ddd7671181","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-02-09T15:55:45Z","pushed_at":"2015-02-09T15:55:45Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1403127,"stargazers_count":1872,"watchers_count":1872,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2205,"mirror_url":null,"open_issues_count":893,"forks":2205,"open_issues":893,"watchers":1872,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27978"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27978"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27978"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27978/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27978/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27978/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/a714dc5cf6a6d68a11db067918802f3181536df6"}}}}