{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/26365836","id":26365836,"diff_hunk":"@@ -333,6 +343,17 @@ def translate_hash_to_trigger(puppet_trigger)\n       self.fail \"Unknown schedule type: #{puppet_trigger[\"schedule\"].inspect}\"\n     end\n \n+    if puppet_trigger['minutes_interval']\n+      integer_interval = Integer(puppet_trigger['minutes_interval'])\n+      self.fail 'minutes_interval must be an integer greater or equal to 0' unless integer_interval >= 0","path":"lib/puppet/provider/scheduled_task/win32_taskscheduler.rb","position":90,"original_position":90,"commit_id":"0eb7cb4d1274d7dcf6336b827bbc2725021f892a","original_commit_id":"0eb7cb4d1274d7dcf6336b827bbc2725021f892a","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"I prefer to avoid double-negatives, so just `if integer_interval < 0`","created_at":"2015-03-13T05:31:16Z","updated_at":"2015-03-13T05:31:16Z","html_url":"https://github.com/puppetlabs/puppet/pull/3637#discussion_r26365836","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3637","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/26365836"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3637#discussion_r26365836"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3637"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3637","id":29696519,"html_url":"https://github.com/puppetlabs/puppet/pull/3637","diff_url":"https://github.com/puppetlabs/puppet/pull/3637.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3637.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3637","number":3637,"state":"open","locked":false,"title":"(PUP-1291) Scheduled Tasks Support for Repeat Triggers","user":{"login":"mrdima","id":10998932,"avatar_url":"https://avatars.githubusercontent.com/u/10998932?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdima","html_url":"https://github.com/mrdima","followers_url":"https://api.github.com/users/mrdima/followers","following_url":"https://api.github.com/users/mrdima/following{/other_user}","gists_url":"https://api.github.com/users/mrdima/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdima/subscriptions","organizations_url":"https://api.github.com/users/mrdima/orgs","repos_url":"https://api.github.com/users/mrdima/repos","events_url":"https://api.github.com/users/mrdima/events{/privacy}","received_events_url":"https://api.github.com/users/mrdima/received_events","type":"User","site_admin":false},"body":"Add minutes_interval and minutes_duration for supporting repeat triggers.\r\nAlso added support for the comment field as a bonus.\r\n","created_at":"2015-02-20T13:46:56Z","updated_at":"2015-03-13T05:31:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04324c2683affdd56c5952f716a1202e433ac0aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3637/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3637/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3637/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/0eb7cb4d1274d7dcf6336b827bbc2725021f892a","head":{"label":"mrdima:fix/master/schedtasks1","ref":"fix/master/schedtasks1","sha":"0eb7cb4d1274d7dcf6336b827bbc2725021f892a","user":{"login":"mrdima","id":10998932,"avatar_url":"https://avatars.githubusercontent.com/u/10998932?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdima","html_url":"https://github.com/mrdima","followers_url":"https://api.github.com/users/mrdima/followers","following_url":"https://api.github.com/users/mrdima/following{/other_user}","gists_url":"https://api.github.com/users/mrdima/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdima/subscriptions","organizations_url":"https://api.github.com/users/mrdima/orgs","repos_url":"https://api.github.com/users/mrdima/repos","events_url":"https://api.github.com/users/mrdima/events{/privacy}","received_events_url":"https://api.github.com/users/mrdima/received_events","type":"User","site_admin":false},"repo":{"id":30777179,"name":"puppet","full_name":"mrdima/puppet","owner":{"login":"mrdima","id":10998932,"avatar_url":"https://avatars.githubusercontent.com/u/10998932?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdima","html_url":"https://github.com/mrdima","followers_url":"https://api.github.com/users/mrdima/followers","following_url":"https://api.github.com/users/mrdima/following{/other_user}","gists_url":"https://api.github.com/users/mrdima/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdima/subscriptions","organizations_url":"https://api.github.com/users/mrdima/orgs","repos_url":"https://api.github.com/users/mrdima/repos","events_url":"https://api.github.com/users/mrdima/events{/privacy}","received_events_url":"https://api.github.com/users/mrdima/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdima/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/mrdima/puppet","forks_url":"https://api.github.com/repos/mrdima/puppet/forks","keys_url":"https://api.github.com/repos/mrdima/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdima/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdima/puppet/teams","hooks_url":"https://api.github.com/repos/mrdima/puppet/hooks","issue_events_url":"https://api.github.com/repos/mrdima/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/mrdima/puppet/events","assignees_url":"https://api.github.com/repos/mrdima/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/mrdima/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/mrdima/puppet/tags","blobs_url":"https://api.github.com/repos/mrdima/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdima/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdima/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdima/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdima/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdima/puppet/languages","stargazers_url":"https://api.github.com/repos/mrdima/puppet/stargazers","contributors_url":"https://api.github.com/repos/mrdima/puppet/contributors","subscribers_url":"https://api.github.com/repos/mrdima/puppet/subscribers","subscription_url":"https://api.github.com/repos/mrdima/puppet/subscription","commits_url":"https://api.github.com/repos/mrdima/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdima/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdima/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdima/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdima/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/mrdima/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdima/puppet/merges","archive_url":"https://api.github.com/repos/mrdima/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdima/puppet/downloads","issues_url":"https://api.github.com/repos/mrdima/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/mrdima/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdima/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdima/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdima/puppet/labels{/name}","releases_url":"https://api.github.com/repos/mrdima/puppet/releases{/id}","created_at":"2015-02-13T21:34:20Z","updated_at":"2015-02-20T13:37:34Z","pushed_at":"2015-02-20T13:42:12Z","git_url":"git://github.com/mrdima/puppet.git","ssh_url":"git@github.com:mrdima/puppet.git","clone_url":"https://github.com/mrdima/puppet.git","svn_url":"https://github.com/mrdima/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":45391,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"3583fb8b47f048bbc947359a7e47f36f9c3c752e","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-03-13T05:02:12Z","pushed_at":"2015-03-12T17:57:25Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":109612,"stargazers_count":3044,"watchers_count":3044,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1299,"mirror_url":null,"open_issues_count":37,"forks":1299,"open_issues":37,"watchers":3044,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3637"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3637"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3637"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3637/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3637/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3637/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/0eb7cb4d1274d7dcf6336b827bbc2725021f892a"}}}}