{"action":"created","issue":{"url":"https://api.github.com/repos/tplaner/When/issues/38","labels_url":"https://api.github.com/repos/tplaner/When/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/tplaner/When/issues/38/comments","events_url":"https://api.github.com/repos/tplaner/When/issues/38/events","html_url":"https://github.com/tplaner/When/issues/38","id":95222536,"number":38,"title":"Why is there an InvalidStartDate error?","user":{"login":"vz28bh","id":1178917,"avatar_url":"https://avatars.githubusercontent.com/u/1178917?v=3","gravatar_id":"","url":"https://api.github.com/users/vz28bh","html_url":"https://github.com/vz28bh","followers_url":"https://api.github.com/users/vz28bh/followers","following_url":"https://api.github.com/users/vz28bh/following{/other_user}","gists_url":"https://api.github.com/users/vz28bh/gists{/gist_id}","starred_url":"https://api.github.com/users/vz28bh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vz28bh/subscriptions","organizations_url":"https://api.github.com/users/vz28bh/orgs","repos_url":"https://api.github.com/users/vz28bh/repos","events_url":"https://api.github.com/users/vz28bh/events{/privacy}","received_events_url":"https://api.github.com/users/vz28bh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-15T15:24:48Z","updated_at":"2015-12-24T19:40:39Z","closed_at":null,"body":"It seems there is an unneeded error being thrown if the start day does not match one of the recurring days. For example if I create an event on Monday and say it is weekly recurring on Sunday and Monday, an error is thrown. This is a perfectly normal situation so I commented out the \"throw new InvalidStartDate()\" and it works correctly, but I am concerned that there may be a reason for the that I am unaware of. Is there a specific reason for this error?\r\n\r\nThanks, this is a very nice little library."},"comment":{"url":"https://api.github.com/repos/tplaner/When/issues/comments/167153090","html_url":"https://github.com/tplaner/When/issues/38#issuecomment-167153090","issue_url":"https://api.github.com/repos/tplaner/When/issues/38","id":167153090,"user":{"login":"kcrawley","id":3759919,"avatar_url":"https://avatars.githubusercontent.com/u/3759919?v=3","gravatar_id":"","url":"https://api.github.com/users/kcrawley","html_url":"https://github.com/kcrawley","followers_url":"https://api.github.com/users/kcrawley/followers","following_url":"https://api.github.com/users/kcrawley/following{/other_user}","gists_url":"https://api.github.com/users/kcrawley/gists{/gist_id}","starred_url":"https://api.github.com/users/kcrawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcrawley/subscriptions","organizations_url":"https://api.github.com/users/kcrawley/orgs","repos_url":"https://api.github.com/users/kcrawley/repos","events_url":"https://api.github.com/users/kcrawley/events{/privacy}","received_events_url":"https://api.github.com/users/kcrawley/received_events","type":"User","site_admin":false},"created_at":"2015-12-24T19:40:39Z","updated_at":"2015-12-24T19:40:39Z","body":"@tplaner I've submitted a PR that would address some of the concerns here while remaining backwards compatible for those who have implemented the library as-is. I've taken the recommendations of @milokmet and introduced a small change alongside unit tests to cover the changes.\r\n\r\nThank you! Have a Merry Christmas! :)"}}