{"action":"created","comment":{"url":"https://api.github.com/repos/square/p2/pulls/comments/28276572","id":28276572,"diff_hunk":"@@ -89,7 +95,7 @@ func (f *fakeHooks) RunHookType(hookType hooks.HookType, pod hooks.Pod, manifest\n \t\tf.ranAfterLaunch = true\n \t\treturn f.afterLaunchErr\n \tcase hooks.AFTER_AUTH_FAIL:\n-\t\tf.ranAfterAuthFail = true\n+\t\tf.ranAfterAuthFail <- struct{}{}","path":"pkg/preparer/orchestrate_test.go","position":20,"original_position":20,"commit_id":"faa0bad3f7e87a00454e19deb7fe466db16ba157","original_commit_id":"f3e450dbab8b7a70fde22eda30b846b3df7e5402","user":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars.githubusercontent.com/u/1444855?v=3","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"body":"I'm worried that this will be a gotcha for people writing new tests. If their test case calls the after auth fail hook then they can deadlock their test","created_at":"2015-04-13T20:38:04Z","updated_at":"2015-04-13T20:38:04Z","html_url":"https://github.com/square/p2/pull/153#discussion_r28276572","pull_request_url":"https://api.github.com/repos/square/p2/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/comments/28276572"},"html":{"href":"https://github.com/square/p2/pull/153#discussion_r28276572"},"pull_request":{"href":"https://api.github.com/repos/square/p2/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/153","id":33200599,"html_url":"https://github.com/square/p2/pull/153","diff_url":"https://github.com/square/p2/pull/153.diff","patch_url":"https://github.com/square/p2/pull/153.patch","issue_url":"https://api.github.com/repos/square/p2/issues/153","number":153,"state":"open","locked":false,"title":"Mpuncel/run as","user":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars.githubusercontent.com/u/1444855?v=3","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"body":"@anthonybishopric @petertseng @tummychow ","created_at":"2015-04-13T20:34:24Z","updated_at":"2015-04-13T20:38:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03d85b6ed4cd289221fb5a36cc2ae7bf6a33f7a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/p2/pulls/153/commits","review_comments_url":"https://api.github.com/repos/square/p2/pulls/153/comments","review_comment_url":"https://api.github.com/repos/square/p2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/p2/issues/153/comments","statuses_url":"https://api.github.com/repos/square/p2/statuses/faa0bad3f7e87a00454e19deb7fe466db16ba157","head":{"label":"mpuncel:mpuncel/run-as","ref":"mpuncel/run-as","sha":"faa0bad3f7e87a00454e19deb7fe466db16ba157","user":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars.githubusercontent.com/u/1444855?v=3","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"repo":{"id":25327874,"name":"p2","full_name":"mpuncel/p2","owner":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars.githubusercontent.com/u/1444855?v=3","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpuncel/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":true,"url":"https://api.github.com/repos/mpuncel/p2","forks_url":"https://api.github.com/repos/mpuncel/p2/forks","keys_url":"https://api.github.com/repos/mpuncel/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpuncel/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpuncel/p2/teams","hooks_url":"https://api.github.com/repos/mpuncel/p2/hooks","issue_events_url":"https://api.github.com/repos/mpuncel/p2/issues/events{/number}","events_url":"https://api.github.com/repos/mpuncel/p2/events","assignees_url":"https://api.github.com/repos/mpuncel/p2/assignees{/user}","branches_url":"https://api.github.com/repos/mpuncel/p2/branches{/branch}","tags_url":"https://api.github.com/repos/mpuncel/p2/tags","blobs_url":"https://api.github.com/repos/mpuncel/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpuncel/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpuncel/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpuncel/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpuncel/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/mpuncel/p2/languages","stargazers_url":"https://api.github.com/repos/mpuncel/p2/stargazers","contributors_url":"https://api.github.com/repos/mpuncel/p2/contributors","subscribers_url":"https://api.github.com/repos/mpuncel/p2/subscribers","subscription_url":"https://api.github.com/repos/mpuncel/p2/subscription","commits_url":"https://api.github.com/repos/mpuncel/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpuncel/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpuncel/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpuncel/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpuncel/p2/contents/{+path}","compare_url":"https://api.github.com/repos/mpuncel/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpuncel/p2/merges","archive_url":"https://api.github.com/repos/mpuncel/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpuncel/p2/downloads","issues_url":"https://api.github.com/repos/mpuncel/p2/issues{/number}","pulls_url":"https://api.github.com/repos/mpuncel/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/mpuncel/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/mpuncel/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpuncel/p2/labels{/name}","releases_url":"https://api.github.com/repos/mpuncel/p2/releases{/id}","created_at":"2014-10-16T23:47:47Z","updated_at":"2015-04-10T20:58:36Z","pushed_at":"2015-04-13T20:37:38Z","git_url":"git://github.com/mpuncel/p2.git","ssh_url":"git@github.com:mpuncel/p2.git","clone_url":"https://github.com/mpuncel/p2.git","svn_url":"https://github.com/mpuncel/p2","homepage":"","size":15850,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"d89d9a83f92581931dff6d11e5e020196e734f98","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":25320424,"name":"p2","full_name":"square/p2","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":false,"url":"https://api.github.com/repos/square/p2","forks_url":"https://api.github.com/repos/square/p2/forks","keys_url":"https://api.github.com/repos/square/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/p2/teams","hooks_url":"https://api.github.com/repos/square/p2/hooks","issue_events_url":"https://api.github.com/repos/square/p2/issues/events{/number}","events_url":"https://api.github.com/repos/square/p2/events","assignees_url":"https://api.github.com/repos/square/p2/assignees{/user}","branches_url":"https://api.github.com/repos/square/p2/branches{/branch}","tags_url":"https://api.github.com/repos/square/p2/tags","blobs_url":"https://api.github.com/repos/square/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/square/p2/languages","stargazers_url":"https://api.github.com/repos/square/p2/stargazers","contributors_url":"https://api.github.com/repos/square/p2/contributors","subscribers_url":"https://api.github.com/repos/square/p2/subscribers","subscription_url":"https://api.github.com/repos/square/p2/subscription","commits_url":"https://api.github.com/repos/square/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/p2/contents/{+path}","compare_url":"https://api.github.com/repos/square/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/p2/merges","archive_url":"https://api.github.com/repos/square/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/p2/downloads","issues_url":"https://api.github.com/repos/square/p2/issues{/number}","pulls_url":"https://api.github.com/repos/square/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/square/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/square/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/p2/labels{/name}","releases_url":"https://api.github.com/repos/square/p2/releases{/id}","created_at":"2014-10-16T20:31:12Z","updated_at":"2015-04-11T23:01:00Z","pushed_at":"2015-04-13T20:37:38Z","git_url":"git://github.com/square/p2.git","ssh_url":"git@github.com:square/p2.git","clone_url":"https://github.com/square/p2.git","svn_url":"https://github.com/square/p2","homepage":"","size":17745,"stargazers_count":19,"watchers_count":19,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/153"},"html":{"href":"https://github.com/square/p2/pull/153"},"issue":{"href":"https://api.github.com/repos/square/p2/issues/153"},"comments":{"href":"https://api.github.com/repos/square/p2/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/square/p2/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/square/p2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/p2/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/square/p2/statuses/faa0bad3f7e87a00454e19deb7fe466db16ba157"}}}}