{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments/25874050","id":25874050,"diff_hunk":"@@ -5396,10 +5396,87 @@ <h3 id=\"sec.identity-verify-assertion\">Verifying Identity Assertions</h3>\n     </table>\n   </section>\n \n-  <section>\n+  <section class=\"informative\">\n     <h2>Security Considerations</h2>\n+    <p>This section is non-normative; it specifies no new behaviour,\n+    but instead summarizes information already present in other parts\n+    of the specification.</p>\n+\n+    <p>This document extends the Web platform with the ability to set\n+    up real time, direct communication between browsers and other\n+    devices, including other browsers.</p>\n+\n+    <p>This means that data and media can be shared between\n+    applications running in different browsers, or between an\n+    application running in the same browser and something that is not a\n+    browser, something that is an extension to the usual barriers in\n+    the Web model against sending data between entities with different\n+    origins.</p>\n+\n+    <p>The WebRTC specification provides no user prompts or chrome\n+    indicators for communication; it assumes that once the Web page\n+    has been allowed to access media, it is free to share that media\n+    with other entities as it chooses.</p>\n+\n+    <p>A mechanism, <code><a>peerIdentity</a></code>, is provided that gives\n+    Javascript the option of requesting media that the same javascript\n+    cannot access, but can only be sent to certain other entities.</p>\n+\n+    <p>Even without WebRTC, the Web server providing a Web application\n+    will know the public IP\n+    address to which the application is delivered. Setting up\n+    communications exposes additional information about the browser’s\n+    network context to the web application, including the set of\n+    (possibly private) IP addresses available to the browser for WebRTC\n+    use. Some of this information has to be passed to the\n+    corresponding party to enable the establishment of a communication\n+    session.</p>\n+\n+    <p>Revealing IP addresses can leak location and means of\n+    connection; this can be sensitive.</p>","path":"webrtc.html","position":42,"original_position":42,"commit_id":"a429ea4d7bbcf99943c1cd98494dd9242ae14c13","original_commit_id":"a429ea4d7bbcf99943c1cd98494dd9242ae14c13","user":{"login":"fluffy","id":217200,"avatar_url":"https://avatars.githubusercontent.com/u/217200?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffy","html_url":"https://github.com/fluffy","followers_url":"https://api.github.com/users/fluffy/followers","following_url":"https://api.github.com/users/fluffy/following{/other_user}","gists_url":"https://api.github.com/users/fluffy/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffy/subscriptions","organizations_url":"https://api.github.com/users/fluffy/orgs","repos_url":"https://api.github.com/users/fluffy/repos","events_url":"https://api.github.com/users/fluffy/events{/privacy}","received_events_url":"https://api.github.com/users/fluffy/received_events","type":"User","site_admin":false},"body":"Also worth noting that the connection to the webserver already leaked some of this","created_at":"2015-03-05T15:56:31Z","updated_at":"2015-03-05T15:56:31Z","html_url":"https://github.com/w3c/webrtc-pc/pull/194#discussion_r25874050","pull_request_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/194","_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments/25874050"},"html":{"href":"https://github.com/w3c/webrtc-pc/pull/194#discussion_r25874050"},"pull_request":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/194","id":30165729,"html_url":"https://github.com/w3c/webrtc-pc/pull/194","diff_url":"https://github.com/w3c/webrtc-pc/pull/194.diff","patch_url":"https://github.com/w3c/webrtc-pc/pull/194.patch","issue_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/194","number":194,"state":"open","locked":false,"title":"Security considerations section - second PR","user":{"login":"alvestrand","id":480893,"avatar_url":"https://avatars.githubusercontent.com/u/480893?v=3","gravatar_id":"","url":"https://api.github.com/users/alvestrand","html_url":"https://github.com/alvestrand","followers_url":"https://api.github.com/users/alvestrand/followers","following_url":"https://api.github.com/users/alvestrand/following{/other_user}","gists_url":"https://api.github.com/users/alvestrand/gists{/gist_id}","starred_url":"https://api.github.com/users/alvestrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvestrand/subscriptions","organizations_url":"https://api.github.com/users/alvestrand/orgs","repos_url":"https://api.github.com/users/alvestrand/repos","events_url":"https://api.github.com/users/alvestrand/events{/privacy}","received_events_url":"https://api.github.com/users/alvestrand/received_events","type":"User","site_admin":false},"body":"Adding security considerations. This replaces PR #15 .\r\n","created_at":"2015-02-27T13:27:44Z","updated_at":"2015-03-05T15:56:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5750e37ae3314da8abfa37c294e32f3a839e8642","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/194/commits","review_comments_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/194/comments","review_comment_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/194/comments","statuses_url":"https://api.github.com/repos/w3c/webrtc-pc/statuses/a429ea4d7bbcf99943c1cd98494dd9242ae14c13","head":{"label":"w3c:security-merge","ref":"security-merge","sha":"a429ea4d7bbcf99943c1cd98494dd9242ae14c13","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":23384500,"name":"webrtc-pc","full_name":"w3c/webrtc-pc","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/webrtc-pc","description":"WebRTC 1.0 API","fork":false,"url":"https://api.github.com/repos/w3c/webrtc-pc","forks_url":"https://api.github.com/repos/w3c/webrtc-pc/forks","keys_url":"https://api.github.com/repos/w3c/webrtc-pc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webrtc-pc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webrtc-pc/teams","hooks_url":"https://api.github.com/repos/w3c/webrtc-pc/hooks","issue_events_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webrtc-pc/events","assignees_url":"https://api.github.com/repos/w3c/webrtc-pc/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webrtc-pc/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webrtc-pc/tags","blobs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webrtc-pc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webrtc-pc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webrtc-pc/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webrtc-pc/languages","stargazers_url":"https://api.github.com/repos/w3c/webrtc-pc/stargazers","contributors_url":"https://api.github.com/repos/w3c/webrtc-pc/contributors","subscribers_url":"https://api.github.com/repos/w3c/webrtc-pc/subscribers","subscription_url":"https://api.github.com/repos/w3c/webrtc-pc/subscription","commits_url":"https://api.github.com/repos/w3c/webrtc-pc/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webrtc-pc/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webrtc-pc/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webrtc-pc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webrtc-pc/merges","archive_url":"https://api.github.com/repos/w3c/webrtc-pc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webrtc-pc/downloads","issues_url":"https://api.github.com/repos/w3c/webrtc-pc/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webrtc-pc/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webrtc-pc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webrtc-pc/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webrtc-pc/releases{/id}","created_at":"2014-08-27T09:39:00Z","updated_at":"2015-03-05T15:44:17Z","pushed_at":"2015-03-05T15:44:16Z","git_url":"git://github.com/w3c/webrtc-pc.git","ssh_url":"git@github.com:w3c/webrtc-pc.git","clone_url":"https://github.com/w3c/webrtc-pc.git","svn_url":"https://github.com/w3c/webrtc-pc","homepage":null,"size":15057,"stargazers_count":12,"watchers_count":12,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":75,"forks":15,"open_issues":75,"watchers":12,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"8385480bc23175051777b4af19091bc4a2dff531","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":23384500,"name":"webrtc-pc","full_name":"w3c/webrtc-pc","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/webrtc-pc","description":"WebRTC 1.0 API","fork":false,"url":"https://api.github.com/repos/w3c/webrtc-pc","forks_url":"https://api.github.com/repos/w3c/webrtc-pc/forks","keys_url":"https://api.github.com/repos/w3c/webrtc-pc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webrtc-pc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webrtc-pc/teams","hooks_url":"https://api.github.com/repos/w3c/webrtc-pc/hooks","issue_events_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webrtc-pc/events","assignees_url":"https://api.github.com/repos/w3c/webrtc-pc/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webrtc-pc/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webrtc-pc/tags","blobs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webrtc-pc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webrtc-pc/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webrtc-pc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webrtc-pc/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webrtc-pc/languages","stargazers_url":"https://api.github.com/repos/w3c/webrtc-pc/stargazers","contributors_url":"https://api.github.com/repos/w3c/webrtc-pc/contributors","subscribers_url":"https://api.github.com/repos/w3c/webrtc-pc/subscribers","subscription_url":"https://api.github.com/repos/w3c/webrtc-pc/subscription","commits_url":"https://api.github.com/repos/w3c/webrtc-pc/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webrtc-pc/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webrtc-pc/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webrtc-pc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webrtc-pc/merges","archive_url":"https://api.github.com/repos/w3c/webrtc-pc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webrtc-pc/downloads","issues_url":"https://api.github.com/repos/w3c/webrtc-pc/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webrtc-pc/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webrtc-pc/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webrtc-pc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webrtc-pc/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webrtc-pc/releases{/id}","created_at":"2014-08-27T09:39:00Z","updated_at":"2015-03-05T15:44:17Z","pushed_at":"2015-03-05T15:44:16Z","git_url":"git://github.com/w3c/webrtc-pc.git","ssh_url":"git@github.com:w3c/webrtc-pc.git","clone_url":"https://github.com/w3c/webrtc-pc.git","svn_url":"https://github.com/w3c/webrtc-pc","homepage":null,"size":15057,"stargazers_count":12,"watchers_count":12,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":75,"forks":15,"open_issues":75,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/194"},"html":{"href":"https://github.com/w3c/webrtc-pc/pull/194"},"issue":{"href":"https://api.github.com/repos/w3c/webrtc-pc/issues/194"},"comments":{"href":"https://api.github.com/repos/w3c/webrtc-pc/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/webrtc-pc/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/webrtc-pc/statuses/a429ea4d7bbcf99943c1cd98494dd9242ae14c13"}}}}