{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/39532027","id":39532027,"diff_hunk":"@@ -24,10 +24,16 @@ var (\n \tErrDriverNotFound          = errors.New(\"The requested docker init has not been found\")\n )\n \n-// StartCallback defines a callback function.\n+const (","path":"daemon/execdriver/driver.go","position":5,"original_position":5,"commit_id":"ab985e9690b9233285ad6782531e100e22b9b4be","original_commit_id":"ab985e9690b9233285ad6782531e100e22b9b4be","user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"body":"This stuff sorta hurts me. Couldn't this be just struct with such fields?","created_at":"2015-09-15T16:27:10Z","updated_at":"2015-09-15T16:27:10Z","html_url":"https://github.com/docker/docker/pull/16305#discussion_r39532027","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/16305","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/39532027"},"html":{"href":"https://github.com/docker/docker/pull/16305#discussion_r39532027"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/16305"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/16305","id":45054192,"html_url":"https://github.com/docker/docker/pull/16305","diff_url":"https://github.com/docker/docker/pull/16305.diff","patch_url":"https://github.com/docker/docker/pull/16305.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/16305","number":16305,"state":"open","locked":false,"title":"Use libcontainer hook for network namespace info passing to libnetwork's sandbox","user":{"login":"estesp","id":1397980,"avatar_url":"https://avatars.githubusercontent.com/u/1397980?v=3","gravatar_id":"","url":"https://api.github.com/users/estesp","html_url":"https://github.com/estesp","followers_url":"https://api.github.com/users/estesp/followers","following_url":"https://api.github.com/users/estesp/following{/other_user}","gists_url":"https://api.github.com/users/estesp/gists{/gist_id}","starred_url":"https://api.github.com/users/estesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estesp/subscriptions","organizations_url":"https://api.github.com/users/estesp/orgs","repos_url":"https://api.github.com/users/estesp/repos","events_url":"https://api.github.com/users/estesp/events{/privacy}","received_events_url":"https://api.github.com/users/estesp/received_events","type":"User","site_admin":false},"body":"Use the new hook functionality from runC/libcontainer to perform the setting of the network namespace path into libnetwork's sandbox entity.  This is the final required step to solve the conflict between user namespaces and the (original) libnetwork network namespace setup flow.  See #15187 for more details.\r\n\r\nThanks @mavenugo for the original design.","created_at":"2015-09-15T14:12:53Z","updated_at":"2015-09-15T16:27:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"813230d7d15328c05705222d854d5e724f6b33f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/16305/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/16305/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/16305/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/ab985e9690b9233285ad6782531e100e22b9b4be","head":{"label":"estesp:hooks-for-the-hooks-gods","ref":"hooks-for-the-hooks-gods","sha":"ab985e9690b9233285ad6782531e100e22b9b4be","user":{"login":"estesp","id":1397980,"avatar_url":"https://avatars.githubusercontent.com/u/1397980?v=3","gravatar_id":"","url":"https://api.github.com/users/estesp","html_url":"https://github.com/estesp","followers_url":"https://api.github.com/users/estesp/followers","following_url":"https://api.github.com/users/estesp/following{/other_user}","gists_url":"https://api.github.com/users/estesp/gists{/gist_id}","starred_url":"https://api.github.com/users/estesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estesp/subscriptions","organizations_url":"https://api.github.com/users/estesp/orgs","repos_url":"https://api.github.com/users/estesp/repos","events_url":"https://api.github.com/users/estesp/events{/privacy}","received_events_url":"https://api.github.com/users/estesp/received_events","type":"User","site_admin":false},"repo":{"id":23801241,"name":"docker","full_name":"estesp/docker","owner":{"login":"estesp","id":1397980,"avatar_url":"https://avatars.githubusercontent.com/u/1397980?v=3","gravatar_id":"","url":"https://api.github.com/users/estesp","html_url":"https://github.com/estesp","followers_url":"https://api.github.com/users/estesp/followers","following_url":"https://api.github.com/users/estesp/following{/other_user}","gists_url":"https://api.github.com/users/estesp/gists{/gist_id}","starred_url":"https://api.github.com/users/estesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estesp/subscriptions","organizations_url":"https://api.github.com/users/estesp/orgs","repos_url":"https://api.github.com/users/estesp/repos","events_url":"https://api.github.com/users/estesp/events{/privacy}","received_events_url":"https://api.github.com/users/estesp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/estesp/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/estesp/docker","forks_url":"https://api.github.com/repos/estesp/docker/forks","keys_url":"https://api.github.com/repos/estesp/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/estesp/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/estesp/docker/teams","hooks_url":"https://api.github.com/repos/estesp/docker/hooks","issue_events_url":"https://api.github.com/repos/estesp/docker/issues/events{/number}","events_url":"https://api.github.com/repos/estesp/docker/events","assignees_url":"https://api.github.com/repos/estesp/docker/assignees{/user}","branches_url":"https://api.github.com/repos/estesp/docker/branches{/branch}","tags_url":"https://api.github.com/repos/estesp/docker/tags","blobs_url":"https://api.github.com/repos/estesp/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/estesp/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/estesp/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/estesp/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/estesp/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/estesp/docker/languages","stargazers_url":"https://api.github.com/repos/estesp/docker/stargazers","contributors_url":"https://api.github.com/repos/estesp/docker/contributors","subscribers_url":"https://api.github.com/repos/estesp/docker/subscribers","subscription_url":"https://api.github.com/repos/estesp/docker/subscription","commits_url":"https://api.github.com/repos/estesp/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/estesp/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/estesp/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/estesp/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/estesp/docker/contents/{+path}","compare_url":"https://api.github.com/repos/estesp/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/estesp/docker/merges","archive_url":"https://api.github.com/repos/estesp/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/estesp/docker/downloads","issues_url":"https://api.github.com/repos/estesp/docker/issues{/number}","pulls_url":"https://api.github.com/repos/estesp/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/estesp/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/estesp/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/estesp/docker/labels{/name}","releases_url":"https://api.github.com/repos/estesp/docker/releases{/id}","created_at":"2014-09-08T17:42:10Z","updated_at":"2015-06-05T16:30:54Z","pushed_at":"2015-09-15T14:27:55Z","git_url":"git://github.com/estesp/docker.git","ssh_url":"git@github.com:estesp/docker.git","clone_url":"https://github.com/estesp/docker.git","svn_url":"https://github.com/estesp/docker","homepage":"http://www.docker.com","size":68704,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"e91f2c26ce38787e159162d2c4a43744396e3308","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-09-15T16:21:24Z","pushed_at":"2015-09-15T16:25:02Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":251784,"stargazers_count":24759,"watchers_count":24759,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6400,"mirror_url":null,"open_issues_count":1057,"forks":6400,"open_issues":1057,"watchers":24759,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/16305"},"html":{"href":"https://github.com/docker/docker/pull/16305"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/16305"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/16305/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/16305/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/16305/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/ab985e9690b9233285ad6782531e100e22b9b4be"}}}}