{"action":"created","issue":{"url":"https://api.github.com/repos/hammerlab/cycledash/issues/826","labels_url":"https://api.github.com/repos/hammerlab/cycledash/issues/826/labels{/name}","comments_url":"https://api.github.com/repos/hammerlab/cycledash/issues/826/comments","events_url":"https://api.github.com/repos/hammerlab/cycledash/issues/826/events","html_url":"https://github.com/hammerlab/cycledash/pull/826","id":104126000,"number":826,"title":"Sanity-check and debug pdifftests ","user":{"login":"armish","id":7809,"avatar_url":"https://avatars.githubusercontent.com/u/7809?v=3","gravatar_id":"","url":"https://api.github.com/users/armish","html_url":"https://github.com/armish","followers_url":"https://api.github.com/users/armish/followers","following_url":"https://api.github.com/users/armish/following{/other_user}","gists_url":"https://api.github.com/users/armish/gists{/gist_id}","starred_url":"https://api.github.com/users/armish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armish/subscriptions","organizations_url":"https://api.github.com/users/armish/orgs","repos_url":"https://api.github.com/users/armish/repos","events_url":"https://api.github.com/users/armish/events{/privacy}","received_events_url":"https://api.github.com/users/armish/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-31T20:15:20Z","updated_at":"2015-08-31T21:04:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hammerlab/cycledash/pulls/826","html_url":"https://github.com/hammerlab/cycledash/pull/826","diff_url":"https://github.com/hammerlab/cycledash/pull/826.diff","patch_url":"https://github.com/hammerlab/cycledash/pull/826.patch"},"body":"This reverts the changes introduced as part of #814 into the `update-screenshots.sh`. Note that there are no changes to the screenshots and this passes the pdfifftests without any problem.\r\n\r\nHowever, if you are to check this code out and run `scripts/update-screenshots.sh`, you do get different screenshots:\r\n\r\n```bash\r\n$ git branch |grep \"*\"\r\n* sanity-check-pdiffs\r\n\r\n$ git status\r\nOn branch sanity-check-pdiffs\r\nYour branch is up-to-date with 'origin/sanity-check-pdiffs'.\r\nnothing to commit, working directory clean\r\n\r\n$ bash scripts/update-screenshots.sh \r\nCreating test DB, logging to tests/pdifftests/logs/DB_LOGs.txt...done.\r\nStarting test server, logging to tests/pdifftests/logs/TEST_SERVER_LOGS.txt...done.\r\nOpening SauceConnect tunnel from localhost..........................done.\r\nUpdating images...\r\n for Examine\r\n  ✗ examine_bad-query: screenshots differ, updating\r\n  ✗ examine_base: screenshots differ, updating\r\n ...\r\n```\r\n\r\nwhich is unexpected as these new screenshots don't match with the ones generated via Travis.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/hammerlab/cycledash/826)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/hammerlab/cycledash/issues/comments/136499241","html_url":"https://github.com/hammerlab/cycledash/pull/826#issuecomment-136499241","issue_url":"https://api.github.com/repos/hammerlab/cycledash/issues/826","id":136499241,"user":{"login":"armish","id":7809,"avatar_url":"https://avatars.githubusercontent.com/u/7809?v=3","gravatar_id":"","url":"https://api.github.com/users/armish","html_url":"https://github.com/armish","followers_url":"https://api.github.com/users/armish/followers","following_url":"https://api.github.com/users/armish/following{/other_user}","gists_url":"https://api.github.com/users/armish/gists{/gist_id}","starred_url":"https://api.github.com/users/armish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armish/subscriptions","organizations_url":"https://api.github.com/users/armish/orgs","repos_url":"https://api.github.com/users/armish/repos","events_url":"https://api.github.com/users/armish/events{/privacy}","received_events_url":"https://api.github.com/users/armish/received_events","type":"User","site_admin":false},"created_at":"2015-08-31T21:04:27Z","updated_at":"2015-08-31T21:04:27Z","body":"@ihodes: never mind the earlier differing screenshots. I think they were temporary as 9 out of 10 trials, the update screenshots scripts run OK:\r\n\r\n```bash\r\n$ bash scripts/update-screenshots.sh \r\nCreating test DB, logging to tests/pdifftests/logs/DB_LOGs.txt...done.\r\nStarting test server, logging to tests/pdifftests/logs/TEST_SERVER_LOGS.txt...done.\r\nSauceConnect tunnel detected already running, will attempt to use that.\r\nUpdating images...\r\n for Examine\r\n  ✓ examine_bad-query: no change\r\n  ✓ examine_base: no change\r\n  ✓ examine_comments-edit: no change\r\n  ✓ examine_comments-view: no change\r\n  ✓ examine_filter: no change\r\n  ✓ examine_sorted: no change\r\n  ✓ examine_tooltip: no change\r\n  ✓ examine_validation: no change\r\n for Runs\r\n  ✓ runs_add-bam: no change\r\n  ✓ runs_add-run: no change\r\n  ✓ runs_bams: no change\r\n  ✓ runs_info: no change\r\n  ✓ runs_new-project: no change\r\n  ✓ runs_page: no change\r\n for Tasks\r\n  ✓ tasks_page: no change\r\n for Website\r\n  ✓ website_about-page: no change\r\n  ✓ website_comments: no change\r\n  ✓ website_login: no change\r\n  ✓ website_register: no change\r\n```\r\n\r\nSeems you were right: we didn't need that change in this script, but a version bump for Chrome was good enough to fix the problem. \r\n\r\n\r\n"}}