{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/25595561","id":25595561,"diff_hunk":"@@ -324,19 +326,34 @@ void ModifierDefinition::checkTypeRequirements()\n \tm_body->checkTypeRequirements();\n }\n \n-void ModifierInvocation::checkTypeRequirements()\n+void ModifierInvocation::checkTypeRequirements(std::vector<ASTPointer<InheritanceSpecifier>> const& _bases)","path":"libsolidity/AST.cpp","position":16,"original_position":16,"commit_id":"e0dc8a2368e7a17a072f6bf7978595841523ed4f","original_commit_id":"e0dc8a2368e7a17a072f6bf7978595841523ed4f","user":{"login":"LianaHus","id":9685356,"avatar_url":"https://avatars.githubusercontent.com/u/9685356?v=3","gravatar_id":"","url":"https://api.github.com/users/LianaHus","html_url":"https://github.com/LianaHus","followers_url":"https://api.github.com/users/LianaHus/followers","following_url":"https://api.github.com/users/LianaHus/following{/other_user}","gists_url":"https://api.github.com/users/LianaHus/gists{/gist_id}","starred_url":"https://api.github.com/users/LianaHus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LianaHus/subscriptions","organizations_url":"https://api.github.com/users/LianaHus/orgs","repos_url":"https://api.github.com/users/LianaHus/repos","events_url":"https://api.github.com/users/LianaHus/events{/privacy}","received_events_url":"https://api.github.com/users/LianaHus/received_events","type":"User","site_admin":false},"body":"sure. there are some more \"std::\"'s in this file, should I remove them all?(not from new code)","created_at":"2015-03-02T12:45:02Z","updated_at":"2015-03-02T12:45:02Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/1163#discussion_r25595561","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1163","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/25595561"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1163#discussion_r25595561"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1163"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1163","id":30181094,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/1163","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/1163.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/1163.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1163","number":1163,"state":"open","locked":false,"title":"sol Passing arguments to the base constructor.","user":{"login":"LianaHus","id":9685356,"avatar_url":"https://avatars.githubusercontent.com/u/9685356?v=3","gravatar_id":"","url":"https://api.github.com/users/LianaHus","html_url":"https://github.com/LianaHus","followers_url":"https://api.github.com/users/LianaHus/followers","following_url":"https://api.github.com/users/LianaHus/following{/other_user}","gists_url":"https://api.github.com/users/LianaHus/gists{/gist_id}","starred_url":"https://api.github.com/users/LianaHus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LianaHus/subscriptions","organizations_url":"https://api.github.com/users/LianaHus/orgs","repos_url":"https://api.github.com/users/LianaHus/repos","events_url":"https://api.github.com/users/LianaHus/events{/privacy}","received_events_url":"https://api.github.com/users/LianaHus/received_events","type":"User","site_admin":false},"body":"the story is here: https://www.pivotaltracker.com/n/projects/1189488/stories/88454388","created_at":"2015-02-27T16:48:04Z","updated_at":"2015-03-02T12:45:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e13034ade4d976b173d30b8b939a230babfd049a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1163/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1163/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1163/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/e0dc8a2368e7a17a072f6bf7978595841523ed4f","head":{"label":"LianaHus:sol_AccessToBaseArgs","ref":"sol_AccessToBaseArgs","sha":"e0dc8a2368e7a17a072f6bf7978595841523ed4f","user":{"login":"LianaHus","id":9685356,"avatar_url":"https://avatars.githubusercontent.com/u/9685356?v=3","gravatar_id":"","url":"https://api.github.com/users/LianaHus","html_url":"https://github.com/LianaHus","followers_url":"https://api.github.com/users/LianaHus/followers","following_url":"https://api.github.com/users/LianaHus/following{/other_user}","gists_url":"https://api.github.com/users/LianaHus/gists{/gist_id}","starred_url":"https://api.github.com/users/LianaHus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LianaHus/subscriptions","organizations_url":"https://api.github.com/users/LianaHus/orgs","repos_url":"https://api.github.com/users/LianaHus/repos","events_url":"https://api.github.com/users/LianaHus/events{/privacy}","received_events_url":"https://api.github.com/users/LianaHus/received_events","type":"User","site_admin":false},"repo":{"id":29241685,"name":"cpp-ethereum","full_name":"LianaHus/cpp-ethereum","owner":{"login":"LianaHus","id":9685356,"avatar_url":"https://avatars.githubusercontent.com/u/9685356?v=3","gravatar_id":"","url":"https://api.github.com/users/LianaHus","html_url":"https://github.com/LianaHus","followers_url":"https://api.github.com/users/LianaHus/followers","following_url":"https://api.github.com/users/LianaHus/following{/other_user}","gists_url":"https://api.github.com/users/LianaHus/gists{/gist_id}","starred_url":"https://api.github.com/users/LianaHus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LianaHus/subscriptions","organizations_url":"https://api.github.com/users/LianaHus/orgs","repos_url":"https://api.github.com/users/LianaHus/repos","events_url":"https://api.github.com/users/LianaHus/events{/privacy}","received_events_url":"https://api.github.com/users/LianaHus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LianaHus/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":true,"url":"https://api.github.com/repos/LianaHus/cpp-ethereum","forks_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/LianaHus/cpp-ethereum/releases{/id}","created_at":"2015-01-14T11:44:38Z","updated_at":"2015-03-02T11:41:55Z","pushed_at":"2015-03-02T11:43:31Z","git_url":"git://github.com/LianaHus/cpp-ethereum.git","ssh_url":"git@github.com:LianaHus/cpp-ethereum.git","clone_url":"https://github.com/LianaHus/cpp-ethereum.git","svn_url":"https://github.com/LianaHus/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":15045,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"03478e943d1177905e7787770836bfdac89833ad","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2015-03-02T12:28:57Z","pushed_at":"2015-03-02T12:28:56Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":82959,"stargazers_count":407,"watchers_count":407,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":130,"forks":144,"open_issues":130,"watchers":407,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1163"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1163"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1163"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1163/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1163/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1163/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/e0dc8a2368e7a17a072f6bf7978595841523ed4f"}}}}