{"action":"opened","number":2471,"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/2471","id":49213503,"html_url":"https://github.com/pantsbuild/pants/pull/2471","diff_url":"https://github.com/pantsbuild/pants/pull/2471.diff","patch_url":"https://github.com/pantsbuild/pants/pull/2471.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/2471","number":2471,"state":"open","locked":false,"title":"[CI] Better implementation of the reporting emitter thread.","user":{"login":"benjyw","id":512764,"avatar_url":"https://avatars.githubusercontent.com/u/512764?v=3","gravatar_id":"","url":"https://api.github.com/users/benjyw","html_url":"https://github.com/benjyw","followers_url":"https://api.github.com/users/benjyw/followers","following_url":"https://api.github.com/users/benjyw/following{/other_user}","gists_url":"https://api.github.com/users/benjyw/gists{/gist_id}","starred_url":"https://api.github.com/users/benjyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjyw/subscriptions","organizations_url":"https://api.github.com/users/benjyw/orgs","repos_url":"https://api.github.com/users/benjyw/repos","events_url":"https://api.github.com/users/benjyw/events{/privacy}","received_events_url":"https://api.github.com/users/benjyw/received_events","type":"User","site_admin":false},"body":"Previously it used twitter.commons.threading.PeriodicThread, which\r\nit turns out just calls time.sleep() in a loop. So we were wasting\r\nup to half a second on a no-op pants shutdown just for that thread\r\nto exit.\r\n\r\nNow we use proper event signaling, so the thread can be interrrupted\r\nimmediately.\r\n\r\nThis also gets rid of the t.c.threading dep entirely.","created_at":"2015-10-29T23:19:21Z","updated_at":"2015-10-29T23:19:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/2471/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/2471/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/2471/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/0ec9a92532b2425827a55fa66d8620bb474d5dca","head":{"label":"benjyw:reporting_thread_stopping","ref":"reporting_thread_stopping","sha":"0ec9a92532b2425827a55fa66d8620bb474d5dca","user":{"login":"benjyw","id":512764,"avatar_url":"https://avatars.githubusercontent.com/u/512764?v=3","gravatar_id":"","url":"https://api.github.com/users/benjyw","html_url":"https://github.com/benjyw","followers_url":"https://api.github.com/users/benjyw/followers","following_url":"https://api.github.com/users/benjyw/following{/other_user}","gists_url":"https://api.github.com/users/benjyw/gists{/gist_id}","starred_url":"https://api.github.com/users/benjyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjyw/subscriptions","organizations_url":"https://api.github.com/users/benjyw/orgs","repos_url":"https://api.github.com/users/benjyw/repos","events_url":"https://api.github.com/users/benjyw/events{/privacy}","received_events_url":"https://api.github.com/users/benjyw/received_events","type":"User","site_admin":false},"repo":{"id":24425665,"name":"pants","full_name":"benjyw/pants","owner":{"login":"benjyw","id":512764,"avatar_url":"https://avatars.githubusercontent.com/u/512764?v=3","gravatar_id":"","url":"https://api.github.com/users/benjyw","html_url":"https://github.com/benjyw","followers_url":"https://api.github.com/users/benjyw/followers","following_url":"https://api.github.com/users/benjyw/following{/other_user}","gists_url":"https://api.github.com/users/benjyw/gists{/gist_id}","starred_url":"https://api.github.com/users/benjyw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjyw/subscriptions","organizations_url":"https://api.github.com/users/benjyw/orgs","repos_url":"https://api.github.com/users/benjyw/repos","events_url":"https://api.github.com/users/benjyw/events{/privacy}","received_events_url":"https://api.github.com/users/benjyw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjyw/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/benjyw/pants","forks_url":"https://api.github.com/repos/benjyw/pants/forks","keys_url":"https://api.github.com/repos/benjyw/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjyw/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjyw/pants/teams","hooks_url":"https://api.github.com/repos/benjyw/pants/hooks","issue_events_url":"https://api.github.com/repos/benjyw/pants/issues/events{/number}","events_url":"https://api.github.com/repos/benjyw/pants/events","assignees_url":"https://api.github.com/repos/benjyw/pants/assignees{/user}","branches_url":"https://api.github.com/repos/benjyw/pants/branches{/branch}","tags_url":"https://api.github.com/repos/benjyw/pants/tags","blobs_url":"https://api.github.com/repos/benjyw/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjyw/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjyw/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjyw/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjyw/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/benjyw/pants/languages","stargazers_url":"https://api.github.com/repos/benjyw/pants/stargazers","contributors_url":"https://api.github.com/repos/benjyw/pants/contributors","subscribers_url":"https://api.github.com/repos/benjyw/pants/subscribers","subscription_url":"https://api.github.com/repos/benjyw/pants/subscription","commits_url":"https://api.github.com/repos/benjyw/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjyw/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjyw/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjyw/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjyw/pants/contents/{+path}","compare_url":"https://api.github.com/repos/benjyw/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjyw/pants/merges","archive_url":"https://api.github.com/repos/benjyw/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjyw/pants/downloads","issues_url":"https://api.github.com/repos/benjyw/pants/issues{/number}","pulls_url":"https://api.github.com/repos/benjyw/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/benjyw/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/benjyw/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjyw/pants/labels{/name}","releases_url":"https://api.github.com/repos/benjyw/pants/releases{/id}","created_at":"2014-09-24T17:42:00Z","updated_at":"2015-05-08T20:53:41Z","pushed_at":"2015-10-29T23:19:06Z","git_url":"git://github.com/benjyw/pants.git","ssh_url":"git@github.com:benjyw/pants.git","clone_url":"https://github.com/benjyw/pants.git","svn_url":"https://github.com/benjyw/pants","homepage":"http://pantsbuild.github.io/","size":57916,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"c1684754289af66fb8e9d12dbff181c9320961ec","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","created_at":"2012-12-17T17:39:04Z","updated_at":"2015-10-29T18:49:30Z","pushed_at":"2015-10-29T23:19:21Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.github.io/","size":83514,"stargazers_count":427,"watchers_count":427,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":341,"forks":126,"open_issues":341,"watchers":427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2471"},"html":{"href":"https://github.com/pantsbuild/pants/pull/2471"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/2471"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/2471/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2471/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2471/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/0ec9a92532b2425827a55fa66d8620bb474d5dca"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":10,"changed_files":4}}