{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/42649759","id":42649759,"diff_hunk":"@@ -94,6 +95,16 @@ public void testThreeArgConstructorRegistersTopicListener() {\n         verify(topic).addMessageListener(isNotNull(MessageListener.class));\n     }\n \n+    @Test\n+    public void testTimestampToString() {\n+        assertNotNull(new Timestamp().toString());","path":"hazelcast-hibernate/hazelcast-hibernate4/src/test/java/com/hazelcast/hibernate/local/LocalRegionCacheTest.java","position":14,"original_position":14,"commit_id":"c68c374dca4a204a10bfe908d5dea91b8f7def0c","original_commit_id":"c68c374dca4a204a10bfe908d5dea91b8f7def0c","user":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"body":"Just testing on not null doesn't make a lot of sense to me. It leads to a false sense of security in the sense that the code seems tested, but actually there is not a lot of validation logic. Looks nice for coverage; but not a lot of actual value.","created_at":"2015-10-21T16:47:05Z","updated_at":"2015-10-21T16:47:05Z","html_url":"https://github.com/hazelcast/hazelcast/pull/6535#discussion_r42649759","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6535","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/42649759"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6535#discussion_r42649759"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6535"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6535","id":48340876,"html_url":"https://github.com/hazelcast/hazelcast/pull/6535","diff_url":"https://github.com/hazelcast/hazelcast/pull/6535.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/6535.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6535","number":6535,"state":"open","locked":false,"title":"UpdateEntryProcessor test on real network","user":{"login":"mustafaiman","id":6582349,"avatar_url":"https://avatars.githubusercontent.com/u/6582349?v=3","gravatar_id":"","url":"https://api.github.com/users/mustafaiman","html_url":"https://github.com/mustafaiman","followers_url":"https://api.github.com/users/mustafaiman/followers","following_url":"https://api.github.com/users/mustafaiman/following{/other_user}","gists_url":"https://api.github.com/users/mustafaiman/gists{/gist_id}","starred_url":"https://api.github.com/users/mustafaiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mustafaiman/subscriptions","organizations_url":"https://api.github.com/users/mustafaiman/orgs","repos_url":"https://api.github.com/users/mustafaiman/repos","events_url":"https://api.github.com/users/mustafaiman/events{/privacy}","received_events_url":"https://api.github.com/users/mustafaiman/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-21T14:44:14Z","updated_at":"2015-10-21T16:47:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a66762211153419facd6ba722ff8db27d52a0e56","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6535/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6535/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6535/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/c68c374dca4a204a10bfe908d5dea91b8f7def0c","head":{"label":"mustafaiman:techdebt/hibernate","ref":"techdebt/hibernate","sha":"c68c374dca4a204a10bfe908d5dea91b8f7def0c","user":{"login":"mustafaiman","id":6582349,"avatar_url":"https://avatars.githubusercontent.com/u/6582349?v=3","gravatar_id":"","url":"https://api.github.com/users/mustafaiman","html_url":"https://github.com/mustafaiman","followers_url":"https://api.github.com/users/mustafaiman/followers","following_url":"https://api.github.com/users/mustafaiman/following{/other_user}","gists_url":"https://api.github.com/users/mustafaiman/gists{/gist_id}","starred_url":"https://api.github.com/users/mustafaiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mustafaiman/subscriptions","organizations_url":"https://api.github.com/users/mustafaiman/orgs","repos_url":"https://api.github.com/users/mustafaiman/repos","events_url":"https://api.github.com/users/mustafaiman/events{/privacy}","received_events_url":"https://api.github.com/users/mustafaiman/received_events","type":"User","site_admin":false},"repo":{"id":37841658,"name":"hazelcast","full_name":"mustafaiman/hazelcast","owner":{"login":"mustafaiman","id":6582349,"avatar_url":"https://avatars.githubusercontent.com/u/6582349?v=3","gravatar_id":"","url":"https://api.github.com/users/mustafaiman","html_url":"https://github.com/mustafaiman","followers_url":"https://api.github.com/users/mustafaiman/followers","following_url":"https://api.github.com/users/mustafaiman/following{/other_user}","gists_url":"https://api.github.com/users/mustafaiman/gists{/gist_id}","starred_url":"https://api.github.com/users/mustafaiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mustafaiman/subscriptions","organizations_url":"https://api.github.com/users/mustafaiman/orgs","repos_url":"https://api.github.com/users/mustafaiman/repos","events_url":"https://api.github.com/users/mustafaiman/events{/privacy}","received_events_url":"https://api.github.com/users/mustafaiman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mustafaiman/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/mustafaiman/hazelcast","forks_url":"https://api.github.com/repos/mustafaiman/hazelcast/forks","keys_url":"https://api.github.com/repos/mustafaiman/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mustafaiman/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mustafaiman/hazelcast/teams","hooks_url":"https://api.github.com/repos/mustafaiman/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/mustafaiman/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/mustafaiman/hazelcast/events","assignees_url":"https://api.github.com/repos/mustafaiman/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/mustafaiman/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/mustafaiman/hazelcast/tags","blobs_url":"https://api.github.com/repos/mustafaiman/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mustafaiman/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mustafaiman/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/mustafaiman/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mustafaiman/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/mustafaiman/hazelcast/languages","stargazers_url":"https://api.github.com/repos/mustafaiman/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/mustafaiman/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/mustafaiman/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/mustafaiman/hazelcast/subscription","commits_url":"https://api.github.com/repos/mustafaiman/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/mustafaiman/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/mustafaiman/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/mustafaiman/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/mustafaiman/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/mustafaiman/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mustafaiman/hazelcast/merges","archive_url":"https://api.github.com/repos/mustafaiman/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mustafaiman/hazelcast/downloads","issues_url":"https://api.github.com/repos/mustafaiman/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/mustafaiman/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/mustafaiman/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/mustafaiman/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mustafaiman/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/mustafaiman/hazelcast/releases{/id}","created_at":"2015-06-22T07:02:33Z","updated_at":"2015-06-22T07:02:44Z","pushed_at":"2015-10-21T14:43:10Z","git_url":"git://github.com/mustafaiman/hazelcast.git","ssh_url":"git@github.com:mustafaiman/hazelcast.git","clone_url":"https://github.com/mustafaiman/hazelcast.git","svn_url":"https://github.com/mustafaiman/hazelcast","homepage":"www.hazelcast.com","size":78844,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"b792ccf0427a6c6107ccecbf789db4a8c03ccb1c","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-10-21T07:21:42Z","pushed_at":"2015-10-21T16:43:31Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":158924,"stargazers_count":1277,"watchers_count":1277,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":620,"mirror_url":null,"open_issues_count":521,"forks":620,"open_issues":521,"watchers":1277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6535"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6535"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6535"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6535/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6535/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6535/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/c68c374dca4a204a10bfe908d5dea91b8f7def0c"}}}}