{"action":"closed","number":3690,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/3690","id":38497654,"html_url":"https://github.com/dotnet/roslyn/pull/3690","diff_url":"https://github.com/dotnet/roslyn/pull/3690.diff","patch_url":"https://github.com/dotnet/roslyn/pull/3690.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/3690","number":3690,"state":"closed","locked":false,"title":"Use command line args to describe options","user":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"body":"Changes the MSBuildWorkspace internal project file abstraction to communicate project options via compiler command line args instead of the existing data structure with fixed layout. Ideally, this will be more flexible in the future for other project types beyond msbuild, so that this service can be used with other kinds of workspaces.  Also, it forces us to use the command line parsers to resolve all files, etc, so we don't get diverging logic between workspaces and compilers.\r\n\r\n@Pilchie @jasonmalinowski please review.\r\n\r\n","created_at":"2015-06-24T23:12:03Z","updated_at":"2015-07-10T00:53:53Z","closed_at":"2015-07-10T00:53:53Z","merged_at":"2015-07-10T00:53:53Z","merge_commit_sha":"62e6230776a4c7a85cfd2b2b804fb95099246408","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/3690/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/3690/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/3690/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/af22e2d0bfb12a934d357aca391eb37192494c80","head":{"label":"mattwar:ProjectFile2","ref":"ProjectFile2","sha":"af22e2d0bfb12a934d357aca391eb37192494c80","user":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"repo":{"id":30200787,"name":"roslyn","full_name":"mattwar/roslyn","owner":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattwar/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/mattwar/roslyn","forks_url":"https://api.github.com/repos/mattwar/roslyn/forks","keys_url":"https://api.github.com/repos/mattwar/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattwar/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattwar/roslyn/teams","hooks_url":"https://api.github.com/repos/mattwar/roslyn/hooks","issue_events_url":"https://api.github.com/repos/mattwar/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/mattwar/roslyn/events","assignees_url":"https://api.github.com/repos/mattwar/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/mattwar/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/mattwar/roslyn/tags","blobs_url":"https://api.github.com/repos/mattwar/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattwar/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattwar/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattwar/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattwar/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/mattwar/roslyn/languages","stargazers_url":"https://api.github.com/repos/mattwar/roslyn/stargazers","contributors_url":"https://api.github.com/repos/mattwar/roslyn/contributors","subscribers_url":"https://api.github.com/repos/mattwar/roslyn/subscribers","subscription_url":"https://api.github.com/repos/mattwar/roslyn/subscription","commits_url":"https://api.github.com/repos/mattwar/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattwar/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattwar/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattwar/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattwar/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/mattwar/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattwar/roslyn/merges","archive_url":"https://api.github.com/repos/mattwar/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattwar/roslyn/downloads","issues_url":"https://api.github.com/repos/mattwar/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/mattwar/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/mattwar/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/mattwar/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattwar/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/mattwar/roslyn/releases{/id}","created_at":"2015-02-02T18:12:54Z","updated_at":"2015-05-01T19:32:18Z","pushed_at":"2015-07-09T23:01:06Z","git_url":"git://github.com/mattwar/roslyn.git","ssh_url":"git@github.com:mattwar/roslyn.git","clone_url":"https://github.com/mattwar/roslyn.git","svn_url":"https://github.com/mattwar/roslyn","homepage":"","size":87313,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a631eff27fe751ba8e9fed8bd1787ede63bbbf12","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-07-09T21:55:31Z","pushed_at":"2015-07-10T00:53:53Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":147139,"stargazers_count":2635,"watchers_count":2635,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":578,"mirror_url":null,"open_issues_count":1118,"forks":578,"open_issues":1118,"watchers":2635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/3690"},"html":{"href":"https://github.com/dotnet/roslyn/pull/3690"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/3690"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/3690/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/3690/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/3690/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/af22e2d0bfb12a934d357aca391eb37192494c80"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":2,"additions":877,"deletions":997,"changed_files":20}}