{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/33459505","id":33459505,"diff_hunk":"@@ -109,6 +109,22 @@ def __new__(cls, e, z, z0, dir=\"+\"):\n         obj._args = (e, z, z0, dir)\n         return obj\n \n+\n+    @property\n+    def free_symbols(self):\n+        e = self.args[0]\n+        # e and z are same then none is free_symbols\n+        if e is self.args[1]:\n+            isyms = set()\n+        else:\n+            isyms = e.free_symbols\n+            # take out z from isyms\n+            if self.args[1] in isyms:\n+                isyms.remove(self.args[1])","path":"sympy/series/limits.py","position":15,"original_position":15,"commit_id":"0e333a4045d0ef29f63095f08f2b2fb00a87ebf0","original_commit_id":"0e333a4045d0ef29f63095f08f2b2fb00a87ebf0","user":{"login":"jksuom","id":6929119,"avatar_url":"https://avatars.githubusercontent.com/u/6929119?v=3","gravatar_id":"","url":"https://api.github.com/users/jksuom","html_url":"https://github.com/jksuom","followers_url":"https://api.github.com/users/jksuom/followers","following_url":"https://api.github.com/users/jksuom/following{/other_user}","gists_url":"https://api.github.com/users/jksuom/gists{/gist_id}","starred_url":"https://api.github.com/users/jksuom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jksuom/subscriptions","organizations_url":"https://api.github.com/users/jksuom/orgs","repos_url":"https://api.github.com/users/jksuom/repos","events_url":"https://api.github.com/users/jksuom/events{/privacy}","received_events_url":"https://api.github.com/users/jksuom/received_events","type":"User","site_admin":false},"body":"Would it be possible to use ``discard`` without checking the presence of ``self.args[1]``?","created_at":"2015-06-29T12:47:23Z","updated_at":"2015-06-29T12:47:23Z","html_url":"https://github.com/sympy/sympy/pull/9581#discussion_r33459505","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/9581","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/33459505"},"html":{"href":"https://github.com/sympy/sympy/pull/9581#discussion_r33459505"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9581"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/9581","id":38725359,"html_url":"https://github.com/sympy/sympy/pull/9581","diff_url":"https://github.com/sympy/sympy/pull/9581.diff","patch_url":"https://github.com/sympy/sympy/pull/9581.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/9581","number":9581,"state":"open","locked":false,"title":"Limit(x, x, a).free_symbols now returns set([a])","user":{"login":"gxyd","id":7712241,"avatar_url":"https://avatars.githubusercontent.com/u/7712241?v=3","gravatar_id":"","url":"https://api.github.com/users/gxyd","html_url":"https://github.com/gxyd","followers_url":"https://api.github.com/users/gxyd/followers","following_url":"https://api.github.com/users/gxyd/following{/other_user}","gists_url":"https://api.github.com/users/gxyd/gists{/gist_id}","starred_url":"https://api.github.com/users/gxyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gxyd/subscriptions","organizations_url":"https://api.github.com/users/gxyd/orgs","repos_url":"https://api.github.com/users/gxyd/repos","events_url":"https://api.github.com/users/gxyd/events{/privacy}","received_events_url":"https://api.github.com/users/gxyd/received_events","type":"User","site_admin":false},"body":"fixes issue #9205\r\n```\r\n>>> Limit(x, x, a).free_symbols\r\nset([a])               # instead of set([a, x, '+'])\r\n```\r\nI looked into the code base for definition of `free_symbols` in `Integration.free_symbols` and found the definition different from the one stated in documentation. Though i think that is also an issue. After my comment on the issue #9205 i realised that.","created_at":"2015-06-28T13:21:01Z","updated_at":"2015-06-29T12:47:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97f45d314f53dd6e22a7f7db6aed1cd769f29936","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/9581/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/9581/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/9581/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/0e333a4045d0ef29f63095f08f2b2fb00a87ebf0","head":{"label":"gxyd:free_symbols","ref":"free_symbols","sha":"0e333a4045d0ef29f63095f08f2b2fb00a87ebf0","user":{"login":"gxyd","id":7712241,"avatar_url":"https://avatars.githubusercontent.com/u/7712241?v=3","gravatar_id":"","url":"https://api.github.com/users/gxyd","html_url":"https://github.com/gxyd","followers_url":"https://api.github.com/users/gxyd/followers","following_url":"https://api.github.com/users/gxyd/following{/other_user}","gists_url":"https://api.github.com/users/gxyd/gists{/gist_id}","starred_url":"https://api.github.com/users/gxyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gxyd/subscriptions","organizations_url":"https://api.github.com/users/gxyd/orgs","repos_url":"https://api.github.com/users/gxyd/repos","events_url":"https://api.github.com/users/gxyd/events{/privacy}","received_events_url":"https://api.github.com/users/gxyd/received_events","type":"User","site_admin":false},"repo":{"id":23004594,"name":"sympy","full_name":"gxyd/sympy","owner":{"login":"gxyd","id":7712241,"avatar_url":"https://avatars.githubusercontent.com/u/7712241?v=3","gravatar_id":"","url":"https://api.github.com/users/gxyd","html_url":"https://github.com/gxyd","followers_url":"https://api.github.com/users/gxyd/followers","following_url":"https://api.github.com/users/gxyd/following{/other_user}","gists_url":"https://api.github.com/users/gxyd/gists{/gist_id}","starred_url":"https://api.github.com/users/gxyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gxyd/subscriptions","organizations_url":"https://api.github.com/users/gxyd/orgs","repos_url":"https://api.github.com/users/gxyd/repos","events_url":"https://api.github.com/users/gxyd/events{/privacy}","received_events_url":"https://api.github.com/users/gxyd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gxyd/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/gxyd/sympy","forks_url":"https://api.github.com/repos/gxyd/sympy/forks","keys_url":"https://api.github.com/repos/gxyd/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gxyd/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gxyd/sympy/teams","hooks_url":"https://api.github.com/repos/gxyd/sympy/hooks","issue_events_url":"https://api.github.com/repos/gxyd/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/gxyd/sympy/events","assignees_url":"https://api.github.com/repos/gxyd/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/gxyd/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/gxyd/sympy/tags","blobs_url":"https://api.github.com/repos/gxyd/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gxyd/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gxyd/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gxyd/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gxyd/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/gxyd/sympy/languages","stargazers_url":"https://api.github.com/repos/gxyd/sympy/stargazers","contributors_url":"https://api.github.com/repos/gxyd/sympy/contributors","subscribers_url":"https://api.github.com/repos/gxyd/sympy/subscribers","subscription_url":"https://api.github.com/repos/gxyd/sympy/subscription","commits_url":"https://api.github.com/repos/gxyd/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gxyd/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gxyd/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gxyd/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gxyd/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/gxyd/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gxyd/sympy/merges","archive_url":"https://api.github.com/repos/gxyd/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gxyd/sympy/downloads","issues_url":"https://api.github.com/repos/gxyd/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/gxyd/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/gxyd/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/gxyd/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gxyd/sympy/labels{/name}","releases_url":"https://api.github.com/repos/gxyd/sympy/releases{/id}","created_at":"2014-08-15T22:08:09Z","updated_at":"2015-01-24T17:34:43Z","pushed_at":"2015-06-28T13:16:00Z","git_url":"git://github.com/gxyd/sympy.git","ssh_url":"git@github.com:gxyd/sympy.git","clone_url":"https://github.com/gxyd/sympy.git","svn_url":"https://github.com/gxyd/sympy","homepage":"http://sympy.org/","size":71147,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"17668727bb154a9fafab2da7838d17040a9db1ee","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2015-06-29T08:55:19Z","pushed_at":"2015-06-29T12:47:02Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":149528,"stargazers_count":2197,"watchers_count":2197,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1086,"mirror_url":null,"open_issues_count":1930,"forks":1086,"open_issues":1930,"watchers":2197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9581"},"html":{"href":"https://github.com/sympy/sympy/pull/9581"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/9581"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/9581/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9581/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9581/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/0e333a4045d0ef29f63095f08f2b2fb00a87ebf0"}}}}