{"action":"created","comment":{"url":"https://api.github.com/repos/LaurentGomila/SFML/pulls/comments/25154589","id":25154589,"diff_hunk":"@@ -94,6 +109,23 @@ struct ContextSettings\n /// all handled the same way (i.e. you can use any version\n /// < 3.0 if you don't want an OpenGL 3 context).\n ///\n+/// When requesting a context with a version greater or equal\n+/// to 3.2, you have the option of specifying whether the\n+/// context should follow the core or compatibility profile\n+/// of all newer (>= 3.2) OpenGL specifications. For versions\n+/// 3.0 and 3.1 there is only the core profile. By default\n+/// a compatibility context is created. You only need to specify\n+/// the core flag if you want a core profile context to use with\n+/// your own OpenGL rendering.\n+/// <b>Warning: The graphics module will not function if you\n+/// request a core profile context. Make sure the attributes are\n+/// set to Default if you want to use the graphics module.</b>\n+///\n+/// Setting the debug attribute flag will request a context with\n+/// additional debugging features enabled. Depending on the\n+/// system, this might be required for advanced OpenGL debugging.\n+/// OpenGL debugging is disabled by default.\n+///","path":"include/SFML/Window/ContextSettings.hpp","position":81,"original_position":81,"commit_id":"8091d6ebdcfdee0c4abe131aa029049b997841bb","original_commit_id":"8091d6ebdcfdee0c4abe131aa029049b997841bb","user":{"login":"mantognini","id":693483,"avatar_url":"https://avatars.githubusercontent.com/u/693483?v=3","gravatar_id":"","url":"https://api.github.com/users/mantognini","html_url":"https://github.com/mantognini","followers_url":"https://api.github.com/users/mantognini/followers","following_url":"https://api.github.com/users/mantognini/following{/other_user}","gists_url":"https://api.github.com/users/mantognini/gists{/gist_id}","starred_url":"https://api.github.com/users/mantognini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantognini/subscriptions","organizations_url":"https://api.github.com/users/mantognini/orgs","repos_url":"https://api.github.com/users/mantognini/repos","events_url":"https://api.github.com/users/mantognini/events{/privacy}","received_events_url":"https://api.github.com/users/mantognini/received_events","type":"User","site_admin":false},"body":"Regarding core/compatiliby flag with version >= 3.2 and debug flag, we should probably add a note about OS X. Something along those lines:\r\n\r\n<b>Special Note for OS X:</b> Apple only provide a legacy profile (OpenGL 2.1) and a core profile for some versions of the operating system (further information are available on the <a href=\"https://developer.apple.com/opengl/capabilities/index.html\">OpenGL Capabilities Tables</a> page). Moreover, no debug context are available on that system.\r\n\r\n```\r\n<b>Special Note for OS X:</b> Apple only provide a legacy profile (OpenGL 2.1) and a core profile for some versions of the operating system (further information are available on the <a href=\"https://developer.apple.com/opengl/capabilities/index.html\">OpenGL Capabilities Tables</a> page). Moreover, no debug context are available on that system.\r\n```","created_at":"2015-02-23T10:35:12Z","updated_at":"2015-02-23T10:35:12Z","html_url":"https://github.com/LaurentGomila/SFML/pull/779#discussion_r25154589","pull_request_url":"https://api.github.com/repos/LaurentGomila/SFML/pulls/779","_links":{"self":{"href":"https://api.github.com/repos/LaurentGomila/SFML/pulls/comments/25154589"},"html":{"href":"https://github.com/LaurentGomila/SFML/pull/779#discussion_r25154589"},"pull_request":{"href":"https://api.github.com/repos/LaurentGomila/SFML/pulls/779"}}},"pull_request":{"url":"https://api.github.com/repos/LaurentGomila/SFML/pulls/779","id":27240581,"html_url":"https://github.com/LaurentGomila/SFML/pull/779","diff_url":"https://github.com/LaurentGomila/SFML/pull/779.diff","patch_url":"https://github.com/LaurentGomila/SFML/pull/779.patch","issue_url":"https://api.github.com/repos/LaurentGomila/SFML/issues/779","number":779,"state":"open","locked":false,"title":"OpenGL improvements","user":{"login":"binary1248","id":949359,"avatar_url":"https://avatars.githubusercontent.com/u/949359?v=3","gravatar_id":"","url":"https://api.github.com/users/binary1248","html_url":"https://github.com/binary1248","followers_url":"https://api.github.com/users/binary1248/followers","following_url":"https://api.github.com/users/binary1248/following{/other_user}","gists_url":"https://api.github.com/users/binary1248/gists{/gist_id}","starred_url":"https://api.github.com/users/binary1248/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary1248/subscriptions","organizations_url":"https://api.github.com/users/binary1248/orgs","repos_url":"https://api.github.com/users/binary1248/repos","events_url":"https://api.github.com/users/binary1248/events{/privacy}","received_events_url":"https://api.github.com/users/binary1248/received_events","type":"User","site_admin":false},"body":"It's done :grin:.\r\n\r\nI was too lazy to copy all the commit messages here, so if you have any questions feel free to ask.\r\n\r\nNeeds testing on OS X.","created_at":"2015-01-13T01:02:48Z","updated_at":"2015-02-23T10:35:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e624dd7460bc3b887a1dd6832eb57b0e38dfa48b","assignee":{"login":"binary1248","id":949359,"avatar_url":"https://avatars.githubusercontent.com/u/949359?v=3","gravatar_id":"","url":"https://api.github.com/users/binary1248","html_url":"https://github.com/binary1248","followers_url":"https://api.github.com/users/binary1248/followers","following_url":"https://api.github.com/users/binary1248/following{/other_user}","gists_url":"https://api.github.com/users/binary1248/gists{/gist_id}","starred_url":"https://api.github.com/users/binary1248/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary1248/subscriptions","organizations_url":"https://api.github.com/users/binary1248/orgs","repos_url":"https://api.github.com/users/binary1248/repos","events_url":"https://api.github.com/users/binary1248/events{/privacy}","received_events_url":"https://api.github.com/users/binary1248/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/LaurentGomila/SFML/milestones/9","labels_url":"https://api.github.com/repos/LaurentGomila/SFML/milestones/9/labels","id":821119,"number":9,"title":"2.3","description":"","creator":{"login":"Bromeon","id":708488,"avatar_url":"https://avatars.githubusercontent.com/u/708488?v=3","gravatar_id":"","url":"https://api.github.com/users/Bromeon","html_url":"https://github.com/Bromeon","followers_url":"https://api.github.com/users/Bromeon/followers","following_url":"https://api.github.com/users/Bromeon/following{/other_user}","gists_url":"https://api.github.com/users/Bromeon/gists{/gist_id}","starred_url":"https://api.github.com/users/Bromeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bromeon/subscriptions","organizations_url":"https://api.github.com/users/Bromeon/orgs","repos_url":"https://api.github.com/users/Bromeon/repos","events_url":"https://api.github.com/users/Bromeon/events{/privacy}","received_events_url":"https://api.github.com/users/Bromeon/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":26,"state":"open","created_at":"2014-10-10T13:20:14Z","updated_at":"2015-02-23T09:54:59Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/LaurentGomila/SFML/pulls/779/commits","review_comments_url":"https://api.github.com/repos/LaurentGomila/SFML/pulls/779/comments","review_comment_url":"https://api.github.com/repos/LaurentGomila/SFML/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LaurentGomila/SFML/issues/779/comments","statuses_url":"https://api.github.com/repos/LaurentGomila/SFML/statuses/8091d6ebdcfdee0c4abe131aa029049b997841bb","head":{"label":"LaurentGomila:feature/gl_dev_new","ref":"feature/gl_dev_new","sha":"8091d6ebdcfdee0c4abe131aa029049b997841bb","user":{"login":"LaurentGomila","id":245489,"avatar_url":"https://avatars.githubusercontent.com/u/245489?v=3","gravatar_id":"","url":"https://api.github.com/users/LaurentGomila","html_url":"https://github.com/LaurentGomila","followers_url":"https://api.github.com/users/LaurentGomila/followers","following_url":"https://api.github.com/users/LaurentGomila/following{/other_user}","gists_url":"https://api.github.com/users/LaurentGomila/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurentGomila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurentGomila/subscriptions","organizations_url":"https://api.github.com/users/LaurentGomila/orgs","repos_url":"https://api.github.com/users/LaurentGomila/repos","events_url":"https://api.github.com/users/LaurentGomila/events{/privacy}","received_events_url":"https://api.github.com/users/LaurentGomila/received_events","type":"User","site_admin":false},"repo":{"id":1524684,"name":"SFML","full_name":"LaurentGomila/SFML","owner":{"login":"LaurentGomila","id":245489,"avatar_url":"https://avatars.githubusercontent.com/u/245489?v=3","gravatar_id":"","url":"https://api.github.com/users/LaurentGomila","html_url":"https://github.com/LaurentGomila","followers_url":"https://api.github.com/users/LaurentGomila/followers","following_url":"https://api.github.com/users/LaurentGomila/following{/other_user}","gists_url":"https://api.github.com/users/LaurentGomila/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurentGomila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurentGomila/subscriptions","organizations_url":"https://api.github.com/users/LaurentGomila/orgs","repos_url":"https://api.github.com/users/LaurentGomila/repos","events_url":"https://api.github.com/users/LaurentGomila/events{/privacy}","received_events_url":"https://api.github.com/users/LaurentGomila/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LaurentGomila/SFML","description":"Simple and Fast Multimedia Library","fork":false,"url":"https://api.github.com/repos/LaurentGomila/SFML","forks_url":"https://api.github.com/repos/LaurentGomila/SFML/forks","keys_url":"https://api.github.com/repos/LaurentGomila/SFML/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LaurentGomila/SFML/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LaurentGomila/SFML/teams","hooks_url":"https://api.github.com/repos/LaurentGomila/SFML/hooks","issue_events_url":"https://api.github.com/repos/LaurentGomila/SFML/issues/events{/number}","events_url":"https://api.github.com/repos/LaurentGomila/SFML/events","assignees_url":"https://api.github.com/repos/LaurentGomila/SFML/assignees{/user}","branches_url":"https://api.github.com/repos/LaurentGomila/SFML/branches{/branch}","tags_url":"https://api.github.com/repos/LaurentGomila/SFML/tags","blobs_url":"https://api.github.com/repos/LaurentGomila/SFML/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LaurentGomila/SFML/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LaurentGomila/SFML/git/refs{/sha}","trees_url":"https://api.github.com/repos/LaurentGomila/SFML/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LaurentGomila/SFML/statuses/{sha}","languages_url":"https://api.github.com/repos/LaurentGomila/SFML/languages","stargazers_url":"https://api.github.com/repos/LaurentGomila/SFML/stargazers","contributors_url":"https://api.github.com/repos/LaurentGomila/SFML/contributors","subscribers_url":"https://api.github.com/repos/LaurentGomila/SFML/subscribers","subscription_url":"https://api.github.com/repos/LaurentGomila/SFML/subscription","commits_url":"https://api.github.com/repos/LaurentGomila/SFML/commits{/sha}","git_commits_url":"https://api.github.com/repos/LaurentGomila/SFML/git/commits{/sha}","comments_url":"https://api.github.com/repos/LaurentGomila/SFML/comments{/number}","issue_comment_url":"https://api.github.com/repos/LaurentGomila/SFML/issues/comments{/number}","contents_url":"https://api.github.com/repos/LaurentGomila/SFML/contents/{+path}","compare_url":"https://api.github.com/repos/LaurentGomila/SFML/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LaurentGomila/SFML/merges","archive_url":"https://api.github.com/repos/LaurentGomila/SFML/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LaurentGomila/SFML/downloads","issues_url":"https://api.github.com/repos/LaurentGomila/SFML/issues{/number}","pulls_url":"https://api.github.com/repos/LaurentGomila/SFML/pulls{/number}","milestones_url":"https://api.github.com/repos/LaurentGomila/SFML/milestones{/number}","notifications_url":"https://api.github.com/repos/LaurentGomila/SFML/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LaurentGomila/SFML/labels{/name}","releases_url":"https://api.github.com/repos/LaurentGomila/SFML/releases{/id}","created_at":"2011-03-25T08:05:25Z","updated_at":"2015-02-23T06:00:05Z","pushed_at":"2015-02-23T09:51:00Z","git_url":"git://github.com/LaurentGomila/SFML.git","ssh_url":"git@github.com:LaurentGomila/SFML.git","clone_url":"https://github.com/LaurentGomila/SFML.git","svn_url":"https://github.com/LaurentGomila/SFML","homepage":"http://www.sfml-dev.org/","size":75740,"stargazers_count":1952,"watchers_count":1952,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":416,"mirror_url":null,"open_issues_count":78,"forks":416,"open_issues":78,"watchers":1952,"default_branch":"master"}},"base":{"label":"LaurentGomila:master","ref":"master","sha":"8dd31f2f52267f043fc7d6f78ba0a20c0f35afa0","user":{"login":"LaurentGomila","id":245489,"avatar_url":"https://avatars.githubusercontent.com/u/245489?v=3","gravatar_id":"","url":"https://api.github.com/users/LaurentGomila","html_url":"https://github.com/LaurentGomila","followers_url":"https://api.github.com/users/LaurentGomila/followers","following_url":"https://api.github.com/users/LaurentGomila/following{/other_user}","gists_url":"https://api.github.com/users/LaurentGomila/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurentGomila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurentGomila/subscriptions","organizations_url":"https://api.github.com/users/LaurentGomila/orgs","repos_url":"https://api.github.com/users/LaurentGomila/repos","events_url":"https://api.github.com/users/LaurentGomila/events{/privacy}","received_events_url":"https://api.github.com/users/LaurentGomila/received_events","type":"User","site_admin":false},"repo":{"id":1524684,"name":"SFML","full_name":"LaurentGomila/SFML","owner":{"login":"LaurentGomila","id":245489,"avatar_url":"https://avatars.githubusercontent.com/u/245489?v=3","gravatar_id":"","url":"https://api.github.com/users/LaurentGomila","html_url":"https://github.com/LaurentGomila","followers_url":"https://api.github.com/users/LaurentGomila/followers","following_url":"https://api.github.com/users/LaurentGomila/following{/other_user}","gists_url":"https://api.github.com/users/LaurentGomila/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurentGomila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurentGomila/subscriptions","organizations_url":"https://api.github.com/users/LaurentGomila/orgs","repos_url":"https://api.github.com/users/LaurentGomila/repos","events_url":"https://api.github.com/users/LaurentGomila/events{/privacy}","received_events_url":"https://api.github.com/users/LaurentGomila/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LaurentGomila/SFML","description":"Simple and Fast Multimedia Library","fork":false,"url":"https://api.github.com/repos/LaurentGomila/SFML","forks_url":"https://api.github.com/repos/LaurentGomila/SFML/forks","keys_url":"https://api.github.com/repos/LaurentGomila/SFML/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LaurentGomila/SFML/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LaurentGomila/SFML/teams","hooks_url":"https://api.github.com/repos/LaurentGomila/SFML/hooks","issue_events_url":"https://api.github.com/repos/LaurentGomila/SFML/issues/events{/number}","events_url":"https://api.github.com/repos/LaurentGomila/SFML/events","assignees_url":"https://api.github.com/repos/LaurentGomila/SFML/assignees{/user}","branches_url":"https://api.github.com/repos/LaurentGomila/SFML/branches{/branch}","tags_url":"https://api.github.com/repos/LaurentGomila/SFML/tags","blobs_url":"https://api.github.com/repos/LaurentGomila/SFML/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LaurentGomila/SFML/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LaurentGomila/SFML/git/refs{/sha}","trees_url":"https://api.github.com/repos/LaurentGomila/SFML/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LaurentGomila/SFML/statuses/{sha}","languages_url":"https://api.github.com/repos/LaurentGomila/SFML/languages","stargazers_url":"https://api.github.com/repos/LaurentGomila/SFML/stargazers","contributors_url":"https://api.github.com/repos/LaurentGomila/SFML/contributors","subscribers_url":"https://api.github.com/repos/LaurentGomila/SFML/subscribers","subscription_url":"https://api.github.com/repos/LaurentGomila/SFML/subscription","commits_url":"https://api.github.com/repos/LaurentGomila/SFML/commits{/sha}","git_commits_url":"https://api.github.com/repos/LaurentGomila/SFML/git/commits{/sha}","comments_url":"https://api.github.com/repos/LaurentGomila/SFML/comments{/number}","issue_comment_url":"https://api.github.com/repos/LaurentGomila/SFML/issues/comments{/number}","contents_url":"https://api.github.com/repos/LaurentGomila/SFML/contents/{+path}","compare_url":"https://api.github.com/repos/LaurentGomila/SFML/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LaurentGomila/SFML/merges","archive_url":"https://api.github.com/repos/LaurentGomila/SFML/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LaurentGomila/SFML/downloads","issues_url":"https://api.github.com/repos/LaurentGomila/SFML/issues{/number}","pulls_url":"https://api.github.com/repos/LaurentGomila/SFML/pulls{/number}","milestones_url":"https://api.github.com/repos/LaurentGomila/SFML/milestones{/number}","notifications_url":"https://api.github.com/repos/LaurentGomila/SFML/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LaurentGomila/SFML/labels{/name}","releases_url":"https://api.github.com/repos/LaurentGomila/SFML/releases{/id}","created_at":"2011-03-25T08:05:25Z","updated_at":"2015-02-23T06:00:05Z","pushed_at":"2015-02-23T09:51:00Z","git_url":"git://github.com/LaurentGomila/SFML.git","ssh_url":"git@github.com:LaurentGomila/SFML.git","clone_url":"https://github.com/LaurentGomila/SFML.git","svn_url":"https://github.com/LaurentGomila/SFML","homepage":"http://www.sfml-dev.org/","size":75740,"stargazers_count":1952,"watchers_count":1952,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":416,"mirror_url":null,"open_issues_count":78,"forks":416,"open_issues":78,"watchers":1952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LaurentGomila/SFML/pulls/779"},"html":{"href":"https://github.com/LaurentGomila/SFML/pull/779"},"issue":{"href":"https://api.github.com/repos/LaurentGomila/SFML/issues/779"},"comments":{"href":"https://api.github.com/repos/LaurentGomila/SFML/issues/779/comments"},"review_comments":{"href":"https://api.github.com/repos/LaurentGomila/SFML/pulls/779/comments"},"review_comment":{"href":"https://api.github.com/repos/LaurentGomila/SFML/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LaurentGomila/SFML/pulls/779/commits"},"statuses":{"href":"https://api.github.com/repos/LaurentGomila/SFML/statuses/8091d6ebdcfdee0c4abe131aa029049b997841bb"}}}}