{"action":"created","comment":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments/48310162","id":48310162,"diff_hunk":"@@ -336,10 +336,7 @@ func (s *Signer) Sign(req signer.SignRequest) (cert []byte, err error) {\n \t\tvar certRecord = &certdb.CertificateRecord{\n \t\t\tSerial:    certTBS.SerialNumber.String(),\n \t\t\tCALabel:   req.Label,\n-\t\t\tStatus:    \"\",","path":"signer/local/local.go","position":4,"original_position":4,"commit_id":"02f0820c9f4125968f04b9e5cf923dd81e100e06","original_commit_id":"02f0820c9f4125968f04b9e5cf923dd81e100e06","user":{"login":"lziest","id":1222706,"avatar_url":"https://avatars.githubusercontent.com/u/1222706?v=3","gravatar_id":"","url":"https://api.github.com/users/lziest","html_url":"https://github.com/lziest","followers_url":"https://api.github.com/users/lziest/followers","following_url":"https://api.github.com/users/lziest/following{/other_user}","gists_url":"https://api.github.com/users/lziest/gists{/gist_id}","starred_url":"https://api.github.com/users/lziest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lziest/subscriptions","organizations_url":"https://api.github.com/users/lziest/orgs","repos_url":"https://api.github.com/users/lziest/repos","events_url":"https://api.github.com/users/lziest/events{/privacy}","received_events_url":"https://api.github.com/users/lziest/received_events","type":"User","site_admin":false},"body":"2nd thought, I think making it \"good\" by default is the desired behavior.","created_at":"2015-12-22T23:28:30Z","updated_at":"2015-12-22T23:28:30Z","html_url":"https://github.com/cloudflare/cfssl/pull/477#discussion_r48310162","pull_request_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/477","_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments/48310162"},"html":{"href":"https://github.com/cloudflare/cfssl/pull/477#discussion_r48310162"},"pull_request":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/477"}}},"pull_request":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/477","id":54426610,"html_url":"https://github.com/cloudflare/cfssl/pull/477","diff_url":"https://github.com/cloudflare/cfssl/pull/477.diff","patch_url":"https://github.com/cloudflare/cfssl/pull/477.patch","issue_url":"https://api.github.com/repos/cloudflare/cfssl/issues/477","number":477,"state":"open","locked":false,"title":"Remove unnecessary initialization of CertificateRecord fields when signing a cert","user":{"login":"andrewbuss","id":5904167,"avatar_url":"https://avatars.githubusercontent.com/u/5904167?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewbuss","html_url":"https://github.com/andrewbuss","followers_url":"https://api.github.com/users/andrewbuss/followers","following_url":"https://api.github.com/users/andrewbuss/following{/other_user}","gists_url":"https://api.github.com/users/andrewbuss/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewbuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewbuss/subscriptions","organizations_url":"https://api.github.com/users/andrewbuss/orgs","repos_url":"https://api.github.com/users/andrewbuss/repos","events_url":"https://api.github.com/users/andrewbuss/events{/privacy}","received_events_url":"https://api.github.com/users/andrewbuss/received_events","type":"User","site_admin":false},"body":"Reason, Status, and RevokedAt should be initialized to \"\", 0, and Jan 1 1 (https://golang.org/pkg/time/#Time.IsZero) respectively.","created_at":"2015-12-22T23:23:41Z","updated_at":"2015-12-22T23:28:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68c8e212d3c58b75c33f02f376a66e56937f1c57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/477/commits","review_comments_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/477/comments","review_comment_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/issues/477/comments","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/02f0820c9f4125968f04b9e5cf923dd81e100e06","head":{"label":"andrewbuss:patch-1","ref":"patch-1","sha":"02f0820c9f4125968f04b9e5cf923dd81e100e06","user":{"login":"andrewbuss","id":5904167,"avatar_url":"https://avatars.githubusercontent.com/u/5904167?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewbuss","html_url":"https://github.com/andrewbuss","followers_url":"https://api.github.com/users/andrewbuss/followers","following_url":"https://api.github.com/users/andrewbuss/following{/other_user}","gists_url":"https://api.github.com/users/andrewbuss/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewbuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewbuss/subscriptions","organizations_url":"https://api.github.com/users/andrewbuss/orgs","repos_url":"https://api.github.com/users/andrewbuss/repos","events_url":"https://api.github.com/users/andrewbuss/events{/privacy}","received_events_url":"https://api.github.com/users/andrewbuss/received_events","type":"User","site_admin":false},"repo":{"id":43838375,"name":"cfssl","full_name":"andrewbuss/cfssl","owner":{"login":"andrewbuss","id":5904167,"avatar_url":"https://avatars.githubusercontent.com/u/5904167?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewbuss","html_url":"https://github.com/andrewbuss","followers_url":"https://api.github.com/users/andrewbuss/followers","following_url":"https://api.github.com/users/andrewbuss/following{/other_user}","gists_url":"https://api.github.com/users/andrewbuss/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewbuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewbuss/subscriptions","organizations_url":"https://api.github.com/users/andrewbuss/orgs","repos_url":"https://api.github.com/users/andrewbuss/repos","events_url":"https://api.github.com/users/andrewbuss/events{/privacy}","received_events_url":"https://api.github.com/users/andrewbuss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewbuss/cfssl","description":"CFSSL: CloudFlare's PKI toolkit","fork":true,"url":"https://api.github.com/repos/andrewbuss/cfssl","forks_url":"https://api.github.com/repos/andrewbuss/cfssl/forks","keys_url":"https://api.github.com/repos/andrewbuss/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewbuss/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewbuss/cfssl/teams","hooks_url":"https://api.github.com/repos/andrewbuss/cfssl/hooks","issue_events_url":"https://api.github.com/repos/andrewbuss/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/andrewbuss/cfssl/events","assignees_url":"https://api.github.com/repos/andrewbuss/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/andrewbuss/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/andrewbuss/cfssl/tags","blobs_url":"https://api.github.com/repos/andrewbuss/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewbuss/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewbuss/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewbuss/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewbuss/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewbuss/cfssl/languages","stargazers_url":"https://api.github.com/repos/andrewbuss/cfssl/stargazers","contributors_url":"https://api.github.com/repos/andrewbuss/cfssl/contributors","subscribers_url":"https://api.github.com/repos/andrewbuss/cfssl/subscribers","subscription_url":"https://api.github.com/repos/andrewbuss/cfssl/subscription","commits_url":"https://api.github.com/repos/andrewbuss/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewbuss/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewbuss/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewbuss/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewbuss/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/andrewbuss/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewbuss/cfssl/merges","archive_url":"https://api.github.com/repos/andrewbuss/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewbuss/cfssl/downloads","issues_url":"https://api.github.com/repos/andrewbuss/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/andrewbuss/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewbuss/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewbuss/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewbuss/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/andrewbuss/cfssl/releases{/id}","created_at":"2015-10-07T19:02:02Z","updated_at":"2015-10-07T19:02:03Z","pushed_at":"2015-12-22T23:27:08Z","git_url":"git://github.com/andrewbuss/cfssl.git","ssh_url":"git@github.com:andrewbuss/cfssl.git","clone_url":"https://github.com/andrewbuss/cfssl.git","svn_url":"https://github.com/andrewbuss/cfssl","homepage":"https://cfssl.org/","size":2716,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"387a1698b5ff1f0db4f560628b5680d27827ecb1","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":21591001,"name":"cfssl","full_name":"cloudflare/cfssl","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/cfssl","description":"CFSSL: CloudFlare's PKI and TLS toolkit","fork":false,"url":"https://api.github.com/repos/cloudflare/cfssl","forks_url":"https://api.github.com/repos/cloudflare/cfssl/forks","keys_url":"https://api.github.com/repos/cloudflare/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/cfssl/teams","hooks_url":"https://api.github.com/repos/cloudflare/cfssl/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/cfssl/events","assignees_url":"https://api.github.com/repos/cloudflare/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/cfssl/tags","blobs_url":"https://api.github.com/repos/cloudflare/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/cfssl/languages","stargazers_url":"https://api.github.com/repos/cloudflare/cfssl/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/cfssl/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/cfssl/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/cfssl/subscription","commits_url":"https://api.github.com/repos/cloudflare/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/cfssl/merges","archive_url":"https://api.github.com/repos/cloudflare/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/cfssl/downloads","issues_url":"https://api.github.com/repos/cloudflare/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/cfssl/releases{/id}","created_at":"2014-07-07T23:49:12Z","updated_at":"2015-12-22T18:47:58Z","pushed_at":"2015-12-22T23:27:08Z","git_url":"git://github.com/cloudflare/cfssl.git","ssh_url":"git@github.com:cloudflare/cfssl.git","clone_url":"https://github.com/cloudflare/cfssl.git","svn_url":"https://github.com/cloudflare/cfssl","homepage":"https://cfssl.org/","size":4857,"stargazers_count":958,"watchers_count":958,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":57,"forks":115,"open_issues":57,"watchers":958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/477"},"html":{"href":"https://github.com/cloudflare/cfssl/pull/477"},"issue":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/477"},"comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/477/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/477/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/477/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/cfssl/statuses/02f0820c9f4125968f04b9e5cf923dd81e100e06"}}}}