{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/comments/30747645","id":30747645,"diff_hunk":"@@ -79,9 +83,12 @@ d-i user-setup/allow-password-weak boolean false\n d-i user-setup/encrypt-home boolean false\n \n # Individual additional packages to install\n+#set os_version = $getVar('os_version','')","path":"roles/cobbler/templates/kickstarts/cephlab_ubuntu.preseed","position":28,"original_position":28,"commit_id":"c7d359a5bdf1c3d21327a0e8bb32f76544348197","original_commit_id":"c7d359a5bdf1c3d21327a0e8bb32f76544348197","user":{"login":"zmc","id":58307,"avatar_url":"https://avatars.githubusercontent.com/u/58307?v=3","gravatar_id":"","url":"https://api.github.com/users/zmc","html_url":"https://github.com/zmc","followers_url":"https://api.github.com/users/zmc/followers","following_url":"https://api.github.com/users/zmc/following{/other_user}","gists_url":"https://api.github.com/users/zmc/gists{/gist_id}","starred_url":"https://api.github.com/users/zmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmc/subscriptions","organizations_url":"https://api.github.com/users/zmc/orgs","repos_url":"https://api.github.com/users/zmc/repos","events_url":"https://api.github.com/users/zmc/events{/privacy}","received_events_url":"https://api.github.com/users/zmc/received_events","type":"User","site_admin":false},"body":"Here it looks like you're setting ``os_version`` after you use it in line 20","created_at":"2015-05-20T20:49:37Z","updated_at":"2015-05-20T20:49:37Z","html_url":"https://github.com/ceph/ceph-cm-ansible/pull/35#discussion_r30747645","pull_request_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/comments/30747645"},"html":{"href":"https://github.com/ceph/ceph-cm-ansible/pull/35#discussion_r30747645"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/35","id":35871268,"html_url":"https://github.com/ceph/ceph-cm-ansible/pull/35","diff_url":"https://github.com/ceph/ceph-cm-ansible/pull/35.diff","patch_url":"https://github.com/ceph/ceph-cm-ansible/pull/35.patch","issue_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/35","number":35,"state":"open","locked":false,"title":"cobbler: one ubuntu preseed for trusty, precise and vivid","user":{"login":"andrewschoen","id":20618,"avatar_url":"https://avatars.githubusercontent.com/u/20618?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewschoen","html_url":"https://github.com/andrewschoen","followers_url":"https://api.github.com/users/andrewschoen/followers","following_url":"https://api.github.com/users/andrewschoen/following{/other_user}","gists_url":"https://api.github.com/users/andrewschoen/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewschoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewschoen/subscriptions","organizations_url":"https://api.github.com/users/andrewschoen/orgs","repos_url":"https://api.github.com/users/andrewschoen/repos","events_url":"https://api.github.com/users/andrewschoen/events{/privacy}","received_events_url":"https://api.github.com/users/andrewschoen/received_events","type":"User","site_admin":false},"body":"This adds the new preseed as well as making the necessary changes to cobbler_profile to manage new profiles for precise, trusty and vivid.\r\n\r\nSomething isn't quite right with the precise and vivid profiles as the don't come up with a network connection.  I suspect it's the kernel options but I'm unsure.  Regardless, I thought it'd be best to put up a PR for this work now and I can follow up with those fixes in a separate PR if I don't figure it out before this is reviewed and merged.","created_at":"2015-05-20T20:15:17Z","updated_at":"2015-05-20T20:49:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e006f050682cd9b4b567e029e73759769d214d64","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/35/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/35/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/35/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/statuses/c7d359a5bdf1c3d21327a0e8bb32f76544348197","head":{"label":"ceph:cobbler-ubuntu-vivid","ref":"cobbler-ubuntu-vivid","sha":"c7d359a5bdf1c3d21327a0e8bb32f76544348197","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":34542634,"name":"ceph-cm-ansible","full_name":"ceph/ceph-cm-ansible","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-cm-ansible","description":"Ansible configurations for Ceph.com infrastructure","fork":false,"url":"https://api.github.com/repos/ceph/ceph-cm-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/releases{/id}","created_at":"2015-04-24T21:24:55Z","updated_at":"2015-05-08T20:12:38Z","pushed_at":"2015-05-20T20:15:17Z","git_url":"git://github.com/ceph/ceph-cm-ansible.git","ssh_url":"git@github.com:ceph/ceph-cm-ansible.git","clone_url":"https://github.com/ceph/ceph-cm-ansible.git","svn_url":"https://github.com/ceph/ceph-cm-ansible","homepage":"","size":2251,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"547ff8e76297f9b4debfb28f3b8a3703f9590002","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":34542634,"name":"ceph-cm-ansible","full_name":"ceph/ceph-cm-ansible","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-cm-ansible","description":"Ansible configurations for Ceph.com infrastructure","fork":false,"url":"https://api.github.com/repos/ceph/ceph-cm-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/releases{/id}","created_at":"2015-04-24T21:24:55Z","updated_at":"2015-05-08T20:12:38Z","pushed_at":"2015-05-20T20:15:17Z","git_url":"git://github.com/ceph/ceph-cm-ansible.git","ssh_url":"git@github.com:ceph/ceph-cm-ansible.git","clone_url":"https://github.com/ceph/ceph-cm-ansible.git","svn_url":"https://github.com/ceph/ceph-cm-ansible","homepage":"","size":2251,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/35"},"html":{"href":"https://github.com/ceph/ceph-cm-ansible/pull/35"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/35"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/statuses/c7d359a5bdf1c3d21327a0e8bb32f76544348197"}}}}