{"action":"opened","number":21,"pull_request":{"url":"https://api.github.com/repos/gogotanaka/Rubype/pulls/21","id":33209809,"html_url":"https://github.com/gogotanaka/Rubype/pull/21","diff_url":"https://github.com/gogotanaka/Rubype/pull/21.diff","patch_url":"https://github.com/gogotanaka/Rubype/pull/21.patch","issue_url":"https://api.github.com/repos/gogotanaka/Rubype/issues/21","number":21,"state":"open","locked":false,"title":"Refactoring","user":{"login":"bublik42","id":884211,"avatar_url":"https://avatars.githubusercontent.com/u/884211?v=3","gravatar_id":"","url":"https://api.github.com/users/bublik42","html_url":"https://github.com/bublik42","followers_url":"https://api.github.com/users/bublik42/followers","following_url":"https://api.github.com/users/bublik42/following{/other_user}","gists_url":"https://api.github.com/users/bublik42/gists{/gist_id}","starred_url":"https://api.github.com/users/bublik42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bublik42/subscriptions","organizations_url":"https://api.github.com/users/bublik42/orgs","repos_url":"https://api.github.com/users/bublik42/repos","events_url":"https://api.github.com/users/bublik42/events{/privacy}","received_events_url":"https://api.github.com/users/bublik42/received_events","type":"User","site_admin":false},"body":"Sorry if I broke some of the principles that you was following. I assumed that you value conciseness above other aspects. \r\n\r\n* Using guard statements instead of full sized conditional statements should shorten methods a little bit.\r\n\r\n* Using then instead of ; after when is recommended by  [community styleguide](https://github.com/bbatsov/ruby-style-guide#no-when-semicolons), as well as [identation after assignment](https://github.com/bbatsov/ruby-style-guide#indent-conditional-assignment)\r\n\r\n* Using assignment in conditional statement may be misleading\r\n\r\nThank you for such an elegant implementation of contracts, 79 lines is impressive.\r\n\r\n\r\n\r\n","created_at":"2015-04-13T22:24:06Z","updated_at":"2015-04-13T22:24:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gogotanaka/Rubype/pulls/21/commits","review_comments_url":"https://api.github.com/repos/gogotanaka/Rubype/pulls/21/comments","review_comment_url":"https://api.github.com/repos/gogotanaka/Rubype/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gogotanaka/Rubype/issues/21/comments","statuses_url":"https://api.github.com/repos/gogotanaka/Rubype/statuses/c27285c4bac5aadeda9f8fb987230495bf187807","head":{"label":"bublik42:refactoring","ref":"refactoring","sha":"c27285c4bac5aadeda9f8fb987230495bf187807","user":{"login":"bublik42","id":884211,"avatar_url":"https://avatars.githubusercontent.com/u/884211?v=3","gravatar_id":"","url":"https://api.github.com/users/bublik42","html_url":"https://github.com/bublik42","followers_url":"https://api.github.com/users/bublik42/followers","following_url":"https://api.github.com/users/bublik42/following{/other_user}","gists_url":"https://api.github.com/users/bublik42/gists{/gist_id}","starred_url":"https://api.github.com/users/bublik42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bublik42/subscriptions","organizations_url":"https://api.github.com/users/bublik42/orgs","repos_url":"https://api.github.com/users/bublik42/repos","events_url":"https://api.github.com/users/bublik42/events{/privacy}","received_events_url":"https://api.github.com/users/bublik42/received_events","type":"User","site_admin":false},"repo":{"id":33891613,"name":"Rubype","full_name":"bublik42/Rubype","owner":{"login":"bublik42","id":884211,"avatar_url":"https://avatars.githubusercontent.com/u/884211?v=3","gravatar_id":"","url":"https://api.github.com/users/bublik42","html_url":"https://github.com/bublik42","followers_url":"https://api.github.com/users/bublik42/followers","following_url":"https://api.github.com/users/bublik42/following{/other_user}","gists_url":"https://api.github.com/users/bublik42/gists{/gist_id}","starred_url":"https://api.github.com/users/bublik42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bublik42/subscriptions","organizations_url":"https://api.github.com/users/bublik42/orgs","repos_url":"https://api.github.com/users/bublik42/repos","events_url":"https://api.github.com/users/bublik42/events{/privacy}","received_events_url":"https://api.github.com/users/bublik42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bublik42/Rubype","description":"Super clean, pure. Contracts for Ruby","fork":true,"url":"https://api.github.com/repos/bublik42/Rubype","forks_url":"https://api.github.com/repos/bublik42/Rubype/forks","keys_url":"https://api.github.com/repos/bublik42/Rubype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bublik42/Rubype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bublik42/Rubype/teams","hooks_url":"https://api.github.com/repos/bublik42/Rubype/hooks","issue_events_url":"https://api.github.com/repos/bublik42/Rubype/issues/events{/number}","events_url":"https://api.github.com/repos/bublik42/Rubype/events","assignees_url":"https://api.github.com/repos/bublik42/Rubype/assignees{/user}","branches_url":"https://api.github.com/repos/bublik42/Rubype/branches{/branch}","tags_url":"https://api.github.com/repos/bublik42/Rubype/tags","blobs_url":"https://api.github.com/repos/bublik42/Rubype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bublik42/Rubype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bublik42/Rubype/git/refs{/sha}","trees_url":"https://api.github.com/repos/bublik42/Rubype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bublik42/Rubype/statuses/{sha}","languages_url":"https://api.github.com/repos/bublik42/Rubype/languages","stargazers_url":"https://api.github.com/repos/bublik42/Rubype/stargazers","contributors_url":"https://api.github.com/repos/bublik42/Rubype/contributors","subscribers_url":"https://api.github.com/repos/bublik42/Rubype/subscribers","subscription_url":"https://api.github.com/repos/bublik42/Rubype/subscription","commits_url":"https://api.github.com/repos/bublik42/Rubype/commits{/sha}","git_commits_url":"https://api.github.com/repos/bublik42/Rubype/git/commits{/sha}","comments_url":"https://api.github.com/repos/bublik42/Rubype/comments{/number}","issue_comment_url":"https://api.github.com/repos/bublik42/Rubype/issues/comments{/number}","contents_url":"https://api.github.com/repos/bublik42/Rubype/contents/{+path}","compare_url":"https://api.github.com/repos/bublik42/Rubype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bublik42/Rubype/merges","archive_url":"https://api.github.com/repos/bublik42/Rubype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bublik42/Rubype/downloads","issues_url":"https://api.github.com/repos/bublik42/Rubype/issues{/number}","pulls_url":"https://api.github.com/repos/bublik42/Rubype/pulls{/number}","milestones_url":"https://api.github.com/repos/bublik42/Rubype/milestones{/number}","notifications_url":"https://api.github.com/repos/bublik42/Rubype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bublik42/Rubype/labels{/name}","releases_url":"https://api.github.com/repos/bublik42/Rubype/releases{/id}","created_at":"2015-04-13T20:17:25Z","updated_at":"2015-04-13T20:17:26Z","pushed_at":"2015-04-13T22:06:56Z","git_url":"git://github.com/bublik42/Rubype.git","ssh_url":"git@github.com:bublik42/Rubype.git","clone_url":"https://github.com/bublik42/Rubype.git","svn_url":"https://github.com/bublik42/Rubype","homepage":"http://gogotanaka.github.io/rubype.github.io/","size":474,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gogotanaka:develop","ref":"develop","sha":"3ee8b08608463243b705e2691bc6d858c608c3ab","user":{"login":"gogotanaka","id":5266933,"avatar_url":"https://avatars.githubusercontent.com/u/5266933?v=3","gravatar_id":"","url":"https://api.github.com/users/gogotanaka","html_url":"https://github.com/gogotanaka","followers_url":"https://api.github.com/users/gogotanaka/followers","following_url":"https://api.github.com/users/gogotanaka/following{/other_user}","gists_url":"https://api.github.com/users/gogotanaka/gists{/gist_id}","starred_url":"https://api.github.com/users/gogotanaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogotanaka/subscriptions","organizations_url":"https://api.github.com/users/gogotanaka/orgs","repos_url":"https://api.github.com/users/gogotanaka/repos","events_url":"https://api.github.com/users/gogotanaka/events{/privacy}","received_events_url":"https://api.github.com/users/gogotanaka/received_events","type":"User","site_admin":false},"repo":{"id":16841471,"name":"Rubype","full_name":"gogotanaka/Rubype","owner":{"login":"gogotanaka","id":5266933,"avatar_url":"https://avatars.githubusercontent.com/u/5266933?v=3","gravatar_id":"","url":"https://api.github.com/users/gogotanaka","html_url":"https://github.com/gogotanaka","followers_url":"https://api.github.com/users/gogotanaka/followers","following_url":"https://api.github.com/users/gogotanaka/following{/other_user}","gists_url":"https://api.github.com/users/gogotanaka/gists{/gist_id}","starred_url":"https://api.github.com/users/gogotanaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogotanaka/subscriptions","organizations_url":"https://api.github.com/users/gogotanaka/orgs","repos_url":"https://api.github.com/users/gogotanaka/repos","events_url":"https://api.github.com/users/gogotanaka/events{/privacy}","received_events_url":"https://api.github.com/users/gogotanaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gogotanaka/Rubype","description":"Super clean, pure. Contracts for Ruby","fork":false,"url":"https://api.github.com/repos/gogotanaka/Rubype","forks_url":"https://api.github.com/repos/gogotanaka/Rubype/forks","keys_url":"https://api.github.com/repos/gogotanaka/Rubype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gogotanaka/Rubype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gogotanaka/Rubype/teams","hooks_url":"https://api.github.com/repos/gogotanaka/Rubype/hooks","issue_events_url":"https://api.github.com/repos/gogotanaka/Rubype/issues/events{/number}","events_url":"https://api.github.com/repos/gogotanaka/Rubype/events","assignees_url":"https://api.github.com/repos/gogotanaka/Rubype/assignees{/user}","branches_url":"https://api.github.com/repos/gogotanaka/Rubype/branches{/branch}","tags_url":"https://api.github.com/repos/gogotanaka/Rubype/tags","blobs_url":"https://api.github.com/repos/gogotanaka/Rubype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gogotanaka/Rubype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gogotanaka/Rubype/git/refs{/sha}","trees_url":"https://api.github.com/repos/gogotanaka/Rubype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gogotanaka/Rubype/statuses/{sha}","languages_url":"https://api.github.com/repos/gogotanaka/Rubype/languages","stargazers_url":"https://api.github.com/repos/gogotanaka/Rubype/stargazers","contributors_url":"https://api.github.com/repos/gogotanaka/Rubype/contributors","subscribers_url":"https://api.github.com/repos/gogotanaka/Rubype/subscribers","subscription_url":"https://api.github.com/repos/gogotanaka/Rubype/subscription","commits_url":"https://api.github.com/repos/gogotanaka/Rubype/commits{/sha}","git_commits_url":"https://api.github.com/repos/gogotanaka/Rubype/git/commits{/sha}","comments_url":"https://api.github.com/repos/gogotanaka/Rubype/comments{/number}","issue_comment_url":"https://api.github.com/repos/gogotanaka/Rubype/issues/comments{/number}","contents_url":"https://api.github.com/repos/gogotanaka/Rubype/contents/{+path}","compare_url":"https://api.github.com/repos/gogotanaka/Rubype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gogotanaka/Rubype/merges","archive_url":"https://api.github.com/repos/gogotanaka/Rubype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gogotanaka/Rubype/downloads","issues_url":"https://api.github.com/repos/gogotanaka/Rubype/issues{/number}","pulls_url":"https://api.github.com/repos/gogotanaka/Rubype/pulls{/number}","milestones_url":"https://api.github.com/repos/gogotanaka/Rubype/milestones{/number}","notifications_url":"https://api.github.com/repos/gogotanaka/Rubype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gogotanaka/Rubype/labels{/name}","releases_url":"https://api.github.com/repos/gogotanaka/Rubype/releases{/id}","created_at":"2014-02-14T15:43:17Z","updated_at":"2015-04-13T21:03:19Z","pushed_at":"2015-04-13T20:48:23Z","git_url":"git://github.com/gogotanaka/Rubype.git","ssh_url":"git@github.com:gogotanaka/Rubype.git","clone_url":"https://github.com/gogotanaka/Rubype.git","svn_url":"https://github.com/gogotanaka/Rubype","homepage":"http://gogotanaka.github.io/rubype.github.io/","size":474,"stargazers_count":308,"watchers_count":308,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":11,"forks":13,"open_issues":11,"watchers":308,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gogotanaka/Rubype/pulls/21"},"html":{"href":"https://github.com/gogotanaka/Rubype/pull/21"},"issue":{"href":"https://api.github.com/repos/gogotanaka/Rubype/issues/21"},"comments":{"href":"https://api.github.com/repos/gogotanaka/Rubype/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/gogotanaka/Rubype/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/gogotanaka/Rubype/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gogotanaka/Rubype/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/gogotanaka/Rubype/statuses/c27285c4bac5aadeda9f8fb987230495bf187807"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":11,"deletions":15,"changed_files":1}}