{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/cpp-client/pulls/comments/32416173","id":32416173,"diff_hunk":"@@ -57,7 +57,7 @@ if (CMAKE_COMPILER_IS_GNUCXX)\n     set (WERROR \"-Werror\")\n   endif (ENABLE_WARNING_ERROR)\n \n-  set (COMPILER_FLAGS \"-fvisibility=hidden -fvisibility-inlines-hidden\")\n+  set (COMPILER_FLAGS \"-fvisibility=hidden -fvisibility-inlines-hidden -std=c++11\")","path":"CMakeLists.txt","position":5,"original_position":5,"commit_id":"cf5acf3d2103442b0528c0768054e912c61c3e37","original_commit_id":"cf5acf3d2103442b0528c0768054e912c61c3e37","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"body":"ooh I see. I need to figure something else than using `<atomic>` stuff. ","created_at":"2015-06-15T12:56:55Z","updated_at":"2015-06-15T12:56:55Z","html_url":"https://github.com/infinispan/cpp-client/pull/166#discussion_r32416173","pull_request_url":"https://api.github.com/repos/infinispan/cpp-client/pulls/166","_links":{"self":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/comments/32416173"},"html":{"href":"https://github.com/infinispan/cpp-client/pull/166#discussion_r32416173"},"pull_request":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/166"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/cpp-client/pulls/166","id":37672478,"html_url":"https://github.com/infinispan/cpp-client/pull/166","diff_url":"https://github.com/infinispan/cpp-client/pull/166.diff","patch_url":"https://github.com/infinispan/cpp-client/pull/166.patch","issue_url":"https://api.github.com/repos/infinispan/cpp-client/issues/166","number":166,"state":"open","locked":false,"title":"HRCPP-195 BZ1228026 Message id should be threadsafe","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"body":"JIRA: https://issues.jboss.org/browse/HRCPP-195\r\nBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1228026\r\n\r\nSome concerns:\r\n* Can we use C++ 2011 standard and `<atomic>`? It looks like both GCC and .NET support it [1].\r\n* We should use GCC >= 4.7 with lock free atomic implementation [2]\r\n\r\n[1] https://msdn.microsoft.com/en-us/library/hh874894.aspx\r\n[2] http://stackoverflow.com/a/13138154/562699","created_at":"2015-06-15T09:23:53Z","updated_at":"2015-06-15T12:56:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dde478666946bab2c72731fc009737d488711ac5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/cpp-client/pulls/166/commits","review_comments_url":"https://api.github.com/repos/infinispan/cpp-client/pulls/166/comments","review_comment_url":"https://api.github.com/repos/infinispan/cpp-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/cpp-client/issues/166/comments","statuses_url":"https://api.github.com/repos/infinispan/cpp-client/statuses/cf5acf3d2103442b0528c0768054e912c61c3e37","head":{"label":"slaskawi:HRCPP-195/BZ1228026/threadsafe_counter_for_messages","ref":"HRCPP-195/BZ1228026/threadsafe_counter_for_messages","sha":"cf5acf3d2103442b0528c0768054e912c61c3e37","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"repo":{"id":22872907,"name":"cpp-client","full_name":"slaskawi/cpp-client","owner":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slaskawi/cpp-client","description":"C++ client for Infinispan, over the Hot Rod wire protocol","fork":true,"url":"https://api.github.com/repos/slaskawi/cpp-client","forks_url":"https://api.github.com/repos/slaskawi/cpp-client/forks","keys_url":"https://api.github.com/repos/slaskawi/cpp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slaskawi/cpp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slaskawi/cpp-client/teams","hooks_url":"https://api.github.com/repos/slaskawi/cpp-client/hooks","issue_events_url":"https://api.github.com/repos/slaskawi/cpp-client/issues/events{/number}","events_url":"https://api.github.com/repos/slaskawi/cpp-client/events","assignees_url":"https://api.github.com/repos/slaskawi/cpp-client/assignees{/user}","branches_url":"https://api.github.com/repos/slaskawi/cpp-client/branches{/branch}","tags_url":"https://api.github.com/repos/slaskawi/cpp-client/tags","blobs_url":"https://api.github.com/repos/slaskawi/cpp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slaskawi/cpp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slaskawi/cpp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/slaskawi/cpp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slaskawi/cpp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/slaskawi/cpp-client/languages","stargazers_url":"https://api.github.com/repos/slaskawi/cpp-client/stargazers","contributors_url":"https://api.github.com/repos/slaskawi/cpp-client/contributors","subscribers_url":"https://api.github.com/repos/slaskawi/cpp-client/subscribers","subscription_url":"https://api.github.com/repos/slaskawi/cpp-client/subscription","commits_url":"https://api.github.com/repos/slaskawi/cpp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/slaskawi/cpp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/slaskawi/cpp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/slaskawi/cpp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/slaskawi/cpp-client/contents/{+path}","compare_url":"https://api.github.com/repos/slaskawi/cpp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slaskawi/cpp-client/merges","archive_url":"https://api.github.com/repos/slaskawi/cpp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slaskawi/cpp-client/downloads","issues_url":"https://api.github.com/repos/slaskawi/cpp-client/issues{/number}","pulls_url":"https://api.github.com/repos/slaskawi/cpp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/slaskawi/cpp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/slaskawi/cpp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slaskawi/cpp-client/labels{/name}","releases_url":"https://api.github.com/repos/slaskawi/cpp-client/releases{/id}","created_at":"2014-08-12T10:02:40Z","updated_at":"2014-06-23T09:24:06Z","pushed_at":"2015-06-15T09:18:11Z","git_url":"git://github.com/slaskawi/cpp-client.git","ssh_url":"git@github.com:slaskawi/cpp-client.git","clone_url":"https://github.com/slaskawi/cpp-client.git","svn_url":"https://github.com/slaskawi/cpp-client","homepage":null,"size":899,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"b58fccfca98ee145df9c8cbc8b94ea7006219f7b","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":9675051,"name":"cpp-client","full_name":"infinispan/cpp-client","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/cpp-client","description":"C++ client for Infinispan, over the Hot Rod wire protocol","fork":false,"url":"https://api.github.com/repos/infinispan/cpp-client","forks_url":"https://api.github.com/repos/infinispan/cpp-client/forks","keys_url":"https://api.github.com/repos/infinispan/cpp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/cpp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/cpp-client/teams","hooks_url":"https://api.github.com/repos/infinispan/cpp-client/hooks","issue_events_url":"https://api.github.com/repos/infinispan/cpp-client/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/cpp-client/events","assignees_url":"https://api.github.com/repos/infinispan/cpp-client/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/cpp-client/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/cpp-client/tags","blobs_url":"https://api.github.com/repos/infinispan/cpp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/cpp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/cpp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/cpp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/cpp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/cpp-client/languages","stargazers_url":"https://api.github.com/repos/infinispan/cpp-client/stargazers","contributors_url":"https://api.github.com/repos/infinispan/cpp-client/contributors","subscribers_url":"https://api.github.com/repos/infinispan/cpp-client/subscribers","subscription_url":"https://api.github.com/repos/infinispan/cpp-client/subscription","commits_url":"https://api.github.com/repos/infinispan/cpp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/cpp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/cpp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/cpp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/cpp-client/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/cpp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/cpp-client/merges","archive_url":"https://api.github.com/repos/infinispan/cpp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/cpp-client/downloads","issues_url":"https://api.github.com/repos/infinispan/cpp-client/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/cpp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/cpp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/cpp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/cpp-client/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/cpp-client/releases{/id}","created_at":"2013-04-25T15:33:11Z","updated_at":"2015-04-24T14:08:29Z","pushed_at":"2015-06-15T09:23:54Z","git_url":"git://github.com/infinispan/cpp-client.git","ssh_url":"git@github.com:infinispan/cpp-client.git","clone_url":"https://github.com/infinispan/cpp-client.git","svn_url":"https://github.com/infinispan/cpp-client","homepage":null,"size":2207,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/166"},"html":{"href":"https://github.com/infinispan/cpp-client/pull/166"},"issue":{"href":"https://api.github.com/repos/infinispan/cpp-client/issues/166"},"comments":{"href":"https://api.github.com/repos/infinispan/cpp-client/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/cpp-client/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/cpp-client/statuses/cf5acf3d2103442b0528c0768054e912c61c3e37"}}}}