{"action":"closed","number":683,"pull_request":{"url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/683","id":43556105,"html_url":"https://github.com/virtual-world-framework/mars-game/pull/683","diff_url":"https://github.com/virtual-world-framework/mars-game/pull/683.diff","patch_url":"https://github.com/virtual-world-framework/mars-game/pull/683.patch","issue_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/683","number":683,"state":"closed","locked":false,"title":"New assets and other changes","user":{"login":"jyucra","id":10178431,"avatar_url":"https://avatars.githubusercontent.com/u/10178431?v=3","gravatar_id":"","url":"https://api.github.com/users/jyucra","html_url":"https://github.com/jyucra","followers_url":"https://api.github.com/users/jyucra/followers","following_url":"https://api.github.com/users/jyucra/following{/other_user}","gists_url":"https://api.github.com/users/jyucra/gists{/gist_id}","starred_url":"https://api.github.com/users/jyucra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyucra/subscriptions","organizations_url":"https://api.github.com/users/jyucra/orgs","repos_url":"https://api.github.com/users/jyucra/repos","events_url":"https://api.github.com/users/jyucra/events{/privacy}","received_events_url":"https://api.github.com/users/jyucra/received_events","type":"User","site_admin":false},"body":"@kadst43 @BrettASwift \r\n\r\n* Adds new success videos for missions 2 and 3\r\n* Adds new assets for the greenhouse, tent, and water well\r\n* Gets rid of negative numbers and changes mission RAM/blocks to account for this\r\n* Adds blinking tiles and triangles to Mission 4\r\n* Adds scenario specific failures to mission 4 that check whether the nano spray block is present\r\n* Changes the rover's display names to Perry/Peregrine/Rosie instead of rover/rover2/rover3 during low ram/out of ram messages.\r\n\r\nThere seems to be a problem with the drawTriangle action, as it only draws all 4/2 triangles if I switch directly into the scenario, but will only draw one if I play through the game in the correct sequence. There's also times where I'll call cancelCallOut during startState but the blinking tile will still be present.\r\n\r\n@BrettASwift Can you confirm that I'm drawing multiple triangles the right/wrong way? I'm doing\r\n\r\n  - clearTriangle:\r\n  - drawTriangle:\r\n    - [ -7, -13 ]\r\n    - [ -7, -17 ]\r\n    - [ -3, -17 ]\r\n  - drawTriangle:\r\n    - [ -9, -17 ]\r\n    - [ -9, -13 ]\r\n    - [ -13, -17 ]\r\n  - drawTriangle:\r\n    - [ -7, -19 ]\r\n    - [ -7, -23 ]\r\n    - [ -3, -19 ]\r\n  - drawTriangle: \r\n    - [ -9, -19 ]\r\n    - [ -9, -23 ]\r\n    - [ -13, -19 ]","created_at":"2015-08-27T19:22:54Z","updated_at":"2015-08-27T19:38:11Z","closed_at":"2015-08-27T19:38:11Z","merged_at":"2015-08-27T19:38:11Z","merge_commit_sha":"f0c304b8a2121c1383a186c34f6c65ad8af6960f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/683/commits","review_comments_url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/683/comments","review_comment_url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/comments{/number}","comments_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/683/comments","statuses_url":"https://api.github.com/repos/virtual-world-framework/mars-game/statuses/a92e70128fcabea47c6185d0bcca2020718dd65b","head":{"label":"virtual-world-framework:new-assets-and-videos","ref":"new-assets-and-videos","sha":"a92e70128fcabea47c6185d0bcca2020718dd65b","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=3","gravatar_id":"","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":17410926,"name":"mars-game","full_name":"virtual-world-framework/mars-game","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=3","gravatar_id":"","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/mars-game","description":"A game designed to teach STEM concepts to high school students under the ADL True Game-based Learning project.","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/mars-game","forks_url":"https://api.github.com/repos/virtual-world-framework/mars-game/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/mars-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/mars-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/mars-game/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/mars-game/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/mars-game/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/mars-game/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/mars-game/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/mars-game/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/mars-game/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/mars-game/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/mars-game/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/mars-game/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/mars-game/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/mars-game/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/mars-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/mars-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/comments{/number}","contents_url":"https://api.github.com/repos/virtual-world-framework/mars-game/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/mars-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/mars-game/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/mars-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/mars-game/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/mars-game/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/mars-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/mars-game/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/mars-game/releases{/id}","created_at":"2014-03-04T17:43:02Z","updated_at":"2015-04-08T15:25:34Z","pushed_at":"2015-08-27T19:38:11Z","git_url":"git://github.com/virtual-world-framework/mars-game.git","ssh_url":"git@github.com:virtual-world-framework/mars-game.git","clone_url":"https://github.com/virtual-world-framework/mars-game.git","svn_url":"https://github.com/virtual-world-framework/mars-game","homepage":"","size":3106328,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"mars-game-development"}},"base":{"label":"virtual-world-framework:mars-game-development","ref":"mars-game-development","sha":"af1864cc69523480b3e29de00d79c33ee547d558","user":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=3","gravatar_id":"","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":17410926,"name":"mars-game","full_name":"virtual-world-framework/mars-game","owner":{"login":"virtual-world-framework","id":1552130,"avatar_url":"https://avatars.githubusercontent.com/u/1552130?v=3","gravatar_id":"","url":"https://api.github.com/users/virtual-world-framework","html_url":"https://github.com/virtual-world-framework","followers_url":"https://api.github.com/users/virtual-world-framework/followers","following_url":"https://api.github.com/users/virtual-world-framework/following{/other_user}","gists_url":"https://api.github.com/users/virtual-world-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/virtual-world-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtual-world-framework/subscriptions","organizations_url":"https://api.github.com/users/virtual-world-framework/orgs","repos_url":"https://api.github.com/users/virtual-world-framework/repos","events_url":"https://api.github.com/users/virtual-world-framework/events{/privacy}","received_events_url":"https://api.github.com/users/virtual-world-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/virtual-world-framework/mars-game","description":"A game designed to teach STEM concepts to high school students under the ADL True Game-based Learning project.","fork":false,"url":"https://api.github.com/repos/virtual-world-framework/mars-game","forks_url":"https://api.github.com/repos/virtual-world-framework/mars-game/forks","keys_url":"https://api.github.com/repos/virtual-world-framework/mars-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtual-world-framework/mars-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtual-world-framework/mars-game/teams","hooks_url":"https://api.github.com/repos/virtual-world-framework/mars-game/hooks","issue_events_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/events{/number}","events_url":"https://api.github.com/repos/virtual-world-framework/mars-game/events","assignees_url":"https://api.github.com/repos/virtual-world-framework/mars-game/assignees{/user}","branches_url":"https://api.github.com/repos/virtual-world-framework/mars-game/branches{/branch}","tags_url":"https://api.github.com/repos/virtual-world-framework/mars-game/tags","blobs_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtual-world-framework/mars-game/statuses/{sha}","languages_url":"https://api.github.com/repos/virtual-world-framework/mars-game/languages","stargazers_url":"https://api.github.com/repos/virtual-world-framework/mars-game/stargazers","contributors_url":"https://api.github.com/repos/virtual-world-framework/mars-game/contributors","subscribers_url":"https://api.github.com/repos/virtual-world-framework/mars-game/subscribers","subscription_url":"https://api.github.com/repos/virtual-world-framework/mars-game/subscription","commits_url":"https://api.github.com/repos/virtual-world-framework/mars-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtual-world-framework/mars-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtual-world-framework/mars-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/comments{/number}","contents_url":"https://api.github.com/repos/virtual-world-framework/mars-game/contents/{+path}","compare_url":"https://api.github.com/repos/virtual-world-framework/mars-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtual-world-framework/mars-game/merges","archive_url":"https://api.github.com/repos/virtual-world-framework/mars-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtual-world-framework/mars-game/downloads","issues_url":"https://api.github.com/repos/virtual-world-framework/mars-game/issues{/number}","pulls_url":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls{/number}","milestones_url":"https://api.github.com/repos/virtual-world-framework/mars-game/milestones{/number}","notifications_url":"https://api.github.com/repos/virtual-world-framework/mars-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtual-world-framework/mars-game/labels{/name}","releases_url":"https://api.github.com/repos/virtual-world-framework/mars-game/releases{/id}","created_at":"2014-03-04T17:43:02Z","updated_at":"2015-04-08T15:25:34Z","pushed_at":"2015-08-27T19:38:11Z","git_url":"git://github.com/virtual-world-framework/mars-game.git","ssh_url":"git@github.com:virtual-world-framework/mars-game.git","clone_url":"https://github.com/virtual-world-framework/mars-game.git","svn_url":"https://github.com/virtual-world-framework/mars-game","homepage":"","size":3106328,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"mars-game-development"}},"_links":{"self":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/683"},"html":{"href":"https://github.com/virtual-world-framework/mars-game/pull/683"},"issue":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/683"},"comments":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/issues/683/comments"},"review_comments":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/683/comments"},"review_comment":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/pulls/683/commits"},"statuses":{"href":"https://api.github.com/repos/virtual-world-framework/mars-game/statuses/a92e70128fcabea47c6185d0bcca2020718dd65b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jyucra","id":10178431,"avatar_url":"https://avatars.githubusercontent.com/u/10178431?v=3","gravatar_id":"","url":"https://api.github.com/users/jyucra","html_url":"https://github.com/jyucra","followers_url":"https://api.github.com/users/jyucra/followers","following_url":"https://api.github.com/users/jyucra/following{/other_user}","gists_url":"https://api.github.com/users/jyucra/gists{/gist_id}","starred_url":"https://api.github.com/users/jyucra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyucra/subscriptions","organizations_url":"https://api.github.com/users/jyucra/orgs","repos_url":"https://api.github.com/users/jyucra/repos","events_url":"https://api.github.com/users/jyucra/events{/privacy}","received_events_url":"https://api.github.com/users/jyucra/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":6,"additions":385,"deletions":1377,"changed_files":41}}