{"action":"opened","number":120,"pull_request":{"url":"https://api.github.com/repos/jackaudio/jack2/pulls/120","id":34530970,"html_url":"https://github.com/jackaudio/jack2/pull/120","diff_url":"https://github.com/jackaudio/jack2/pull/120.diff","patch_url":"https://github.com/jackaudio/jack2/pull/120.patch","issue_url":"https://api.github.com/repos/jackaudio/jack2/issues/120","number":120,"state":"open","locked":false,"title":"Fix svnversion.h generation","user":{"login":"lilrc","id":4058283,"avatar_url":"https://avatars.githubusercontent.com/u/4058283?v=3","gravatar_id":"","url":"https://api.github.com/users/lilrc","html_url":"https://github.com/lilrc","followers_url":"https://api.github.com/users/lilrc/followers","following_url":"https://api.github.com/users/lilrc/following{/other_user}","gists_url":"https://api.github.com/users/lilrc/gists{/gist_id}","starred_url":"https://api.github.com/users/lilrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilrc/subscriptions","organizations_url":"https://api.github.com/users/lilrc/orgs","repos_url":"https://api.github.com/users/lilrc/repos","events_url":"https://api.github.com/users/lilrc/events{/privacy}","received_events_url":"https://api.github.com/users/lilrc/received_events","type":"User","site_admin":false},"body":"The svnversion.h was broken since the dist_hook was never called. This resulted in SVN_REVISION being defined as \"unknown\" (since svnversion.h did not exist and not the .git directory either) in distributed tarballs. This pull request fixes that issue.\r\n\r\nAlso the svnersion_regenerate.sh script assumed ../ was the source directory. It has been fixed.\r\n\r\nAnother issue was the hardcoded path to the svnersion_regenerate.sh script which caused builds with a nonstandard out directory (--out was specified and was not build) to fail. This is also fixed.\r\n\r\nThere are a few very minor fixes too such as future-proofing so that cxx sources can use svnversion.h to.","created_at":"2015-05-01T10:30:38Z","updated_at":"2015-05-01T10:30:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jackaudio/jack2/pulls/120/commits","review_comments_url":"https://api.github.com/repos/jackaudio/jack2/pulls/120/comments","review_comment_url":"https://api.github.com/repos/jackaudio/jack2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jackaudio/jack2/issues/120/comments","statuses_url":"https://api.github.com/repos/jackaudio/jack2/statuses/5db744029a21d53b2fe21c5c13acd6b8c73e9c97","head":{"label":"lilrc:master","ref":"master","sha":"5db744029a21d53b2fe21c5c13acd6b8c73e9c97","user":{"login":"lilrc","id":4058283,"avatar_url":"https://avatars.githubusercontent.com/u/4058283?v=3","gravatar_id":"","url":"https://api.github.com/users/lilrc","html_url":"https://github.com/lilrc","followers_url":"https://api.github.com/users/lilrc/followers","following_url":"https://api.github.com/users/lilrc/following{/other_user}","gists_url":"https://api.github.com/users/lilrc/gists{/gist_id}","starred_url":"https://api.github.com/users/lilrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilrc/subscriptions","organizations_url":"https://api.github.com/users/lilrc/orgs","repos_url":"https://api.github.com/users/lilrc/repos","events_url":"https://api.github.com/users/lilrc/events{/privacy}","received_events_url":"https://api.github.com/users/lilrc/received_events","type":"User","site_admin":false},"repo":{"id":33466723,"name":"jack2","full_name":"lilrc/jack2","owner":{"login":"lilrc","id":4058283,"avatar_url":"https://avatars.githubusercontent.com/u/4058283?v=3","gravatar_id":"","url":"https://api.github.com/users/lilrc","html_url":"https://github.com/lilrc","followers_url":"https://api.github.com/users/lilrc/followers","following_url":"https://api.github.com/users/lilrc/following{/other_user}","gists_url":"https://api.github.com/users/lilrc/gists{/gist_id}","starred_url":"https://api.github.com/users/lilrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilrc/subscriptions","organizations_url":"https://api.github.com/users/lilrc/orgs","repos_url":"https://api.github.com/users/lilrc/repos","events_url":"https://api.github.com/users/lilrc/events{/privacy}","received_events_url":"https://api.github.com/users/lilrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lilrc/jack2","description":"jack2 codebase","fork":true,"url":"https://api.github.com/repos/lilrc/jack2","forks_url":"https://api.github.com/repos/lilrc/jack2/forks","keys_url":"https://api.github.com/repos/lilrc/jack2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lilrc/jack2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lilrc/jack2/teams","hooks_url":"https://api.github.com/repos/lilrc/jack2/hooks","issue_events_url":"https://api.github.com/repos/lilrc/jack2/issues/events{/number}","events_url":"https://api.github.com/repos/lilrc/jack2/events","assignees_url":"https://api.github.com/repos/lilrc/jack2/assignees{/user}","branches_url":"https://api.github.com/repos/lilrc/jack2/branches{/branch}","tags_url":"https://api.github.com/repos/lilrc/jack2/tags","blobs_url":"https://api.github.com/repos/lilrc/jack2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lilrc/jack2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lilrc/jack2/git/refs{/sha}","trees_url":"https://api.github.com/repos/lilrc/jack2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lilrc/jack2/statuses/{sha}","languages_url":"https://api.github.com/repos/lilrc/jack2/languages","stargazers_url":"https://api.github.com/repos/lilrc/jack2/stargazers","contributors_url":"https://api.github.com/repos/lilrc/jack2/contributors","subscribers_url":"https://api.github.com/repos/lilrc/jack2/subscribers","subscription_url":"https://api.github.com/repos/lilrc/jack2/subscription","commits_url":"https://api.github.com/repos/lilrc/jack2/commits{/sha}","git_commits_url":"https://api.github.com/repos/lilrc/jack2/git/commits{/sha}","comments_url":"https://api.github.com/repos/lilrc/jack2/comments{/number}","issue_comment_url":"https://api.github.com/repos/lilrc/jack2/issues/comments{/number}","contents_url":"https://api.github.com/repos/lilrc/jack2/contents/{+path}","compare_url":"https://api.github.com/repos/lilrc/jack2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lilrc/jack2/merges","archive_url":"https://api.github.com/repos/lilrc/jack2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lilrc/jack2/downloads","issues_url":"https://api.github.com/repos/lilrc/jack2/issues{/number}","pulls_url":"https://api.github.com/repos/lilrc/jack2/pulls{/number}","milestones_url":"https://api.github.com/repos/lilrc/jack2/milestones{/number}","notifications_url":"https://api.github.com/repos/lilrc/jack2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lilrc/jack2/labels{/name}","releases_url":"https://api.github.com/repos/lilrc/jack2/releases{/id}","created_at":"2015-04-06T04:33:53Z","updated_at":"2015-05-01T10:22:24Z","pushed_at":"2015-05-01T10:22:24Z","git_url":"git://github.com/lilrc/jack2.git","ssh_url":"git@github.com:lilrc/jack2.git","clone_url":"https://github.com/lilrc/jack2.git","svn_url":"https://github.com/lilrc/jack2","homepage":"","size":13250,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jackaudio:master","ref":"master","sha":"40341d16fb0625514caa0f853d63c502c263c267","user":{"login":"jackaudio","id":1402469,"avatar_url":"https://avatars.githubusercontent.com/u/1402469?v=3","gravatar_id":"","url":"https://api.github.com/users/jackaudio","html_url":"https://github.com/jackaudio","followers_url":"https://api.github.com/users/jackaudio/followers","following_url":"https://api.github.com/users/jackaudio/following{/other_user}","gists_url":"https://api.github.com/users/jackaudio/gists{/gist_id}","starred_url":"https://api.github.com/users/jackaudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackaudio/subscriptions","organizations_url":"https://api.github.com/users/jackaudio/orgs","repos_url":"https://api.github.com/users/jackaudio/repos","events_url":"https://api.github.com/users/jackaudio/events{/privacy}","received_events_url":"https://api.github.com/users/jackaudio/received_events","type":"Organization","site_admin":false},"repo":{"id":3337027,"name":"jack2","full_name":"jackaudio/jack2","owner":{"login":"jackaudio","id":1402469,"avatar_url":"https://avatars.githubusercontent.com/u/1402469?v=3","gravatar_id":"","url":"https://api.github.com/users/jackaudio","html_url":"https://github.com/jackaudio","followers_url":"https://api.github.com/users/jackaudio/followers","following_url":"https://api.github.com/users/jackaudio/following{/other_user}","gists_url":"https://api.github.com/users/jackaudio/gists{/gist_id}","starred_url":"https://api.github.com/users/jackaudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackaudio/subscriptions","organizations_url":"https://api.github.com/users/jackaudio/orgs","repos_url":"https://api.github.com/users/jackaudio/repos","events_url":"https://api.github.com/users/jackaudio/events{/privacy}","received_events_url":"https://api.github.com/users/jackaudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jackaudio/jack2","description":"jack2 codebase","fork":false,"url":"https://api.github.com/repos/jackaudio/jack2","forks_url":"https://api.github.com/repos/jackaudio/jack2/forks","keys_url":"https://api.github.com/repos/jackaudio/jack2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackaudio/jack2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackaudio/jack2/teams","hooks_url":"https://api.github.com/repos/jackaudio/jack2/hooks","issue_events_url":"https://api.github.com/repos/jackaudio/jack2/issues/events{/number}","events_url":"https://api.github.com/repos/jackaudio/jack2/events","assignees_url":"https://api.github.com/repos/jackaudio/jack2/assignees{/user}","branches_url":"https://api.github.com/repos/jackaudio/jack2/branches{/branch}","tags_url":"https://api.github.com/repos/jackaudio/jack2/tags","blobs_url":"https://api.github.com/repos/jackaudio/jack2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackaudio/jack2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackaudio/jack2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackaudio/jack2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackaudio/jack2/statuses/{sha}","languages_url":"https://api.github.com/repos/jackaudio/jack2/languages","stargazers_url":"https://api.github.com/repos/jackaudio/jack2/stargazers","contributors_url":"https://api.github.com/repos/jackaudio/jack2/contributors","subscribers_url":"https://api.github.com/repos/jackaudio/jack2/subscribers","subscription_url":"https://api.github.com/repos/jackaudio/jack2/subscription","commits_url":"https://api.github.com/repos/jackaudio/jack2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackaudio/jack2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackaudio/jack2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackaudio/jack2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackaudio/jack2/contents/{+path}","compare_url":"https://api.github.com/repos/jackaudio/jack2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackaudio/jack2/merges","archive_url":"https://api.github.com/repos/jackaudio/jack2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackaudio/jack2/downloads","issues_url":"https://api.github.com/repos/jackaudio/jack2/issues{/number}","pulls_url":"https://api.github.com/repos/jackaudio/jack2/pulls{/number}","milestones_url":"https://api.github.com/repos/jackaudio/jack2/milestones{/number}","notifications_url":"https://api.github.com/repos/jackaudio/jack2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackaudio/jack2/labels{/name}","releases_url":"https://api.github.com/repos/jackaudio/jack2/releases{/id}","created_at":"2012-02-02T17:37:08Z","updated_at":"2015-04-29T12:47:00Z","pushed_at":"2015-04-29T12:46:59Z","git_url":"git://github.com/jackaudio/jack2.git","ssh_url":"git@github.com:jackaudio/jack2.git","clone_url":"https://github.com/jackaudio/jack2.git","svn_url":"https://github.com/jackaudio/jack2","homepage":"","size":25166,"stargazers_count":193,"watchers_count":193,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":33,"forks":66,"open_issues":33,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jackaudio/jack2/pulls/120"},"html":{"href":"https://github.com/jackaudio/jack2/pull/120"},"issue":{"href":"https://api.github.com/repos/jackaudio/jack2/issues/120"},"comments":{"href":"https://api.github.com/repos/jackaudio/jack2/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/jackaudio/jack2/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/jackaudio/jack2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jackaudio/jack2/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/jackaudio/jack2/statuses/5db744029a21d53b2fe21c5c13acd6b8c73e9c97"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":9,"additions":33,"deletions":31,"changed_files":2}}