{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/27664408","id":27664408,"diff_hunk":"@@ -0,0 +1,60 @@\n+---\n+- name: Launch instance(s)\n+  hosts: localhost\n+  connection: local\n+  gather_facts: no\n+  vars_files:\n+      - vars.yml\n+  tasks:\n+    - set_fact: k8s_type=\"master\"\n+\n+    - name: Generate master instance names(s)\n+      set_fact: scratch={{ cluster_id }}-{{ k8s_type }}-{{ '%05x' |format( 1048576 |random) }}\n+      register: master_names_output\n+      with_sequence: start=1 end={{ num_masters }}\n+\n+    # These set_fact's cannot be combined\n+    - set_fact:\n+        master_names_string: \"{% for item in master_names_output.results %}{{ item.ansible_facts.scratch }} {% endfor %}\"\n+\n+    - set_fact:\n+        master_names: \"{{ master_names_string.strip().split(' ') }}\"\n+\n+    - include: launch_instances.yml\n+      vars:\n+        instances: \"{{ master_names }}\"\n+        cluster: \"{{ cluster_id }}\"\n+        type: \"{{ k8s_type }}\"\n+\n+    - set_fact: k8s_type=\"node\"\n+\n+    - name: Generate node instance names(s)\n+      set_fact: scratch={{ cluster_id }}-{{ k8s_type }}-{{ '%05x' |format( 1048576 |random) }}\n+      register: node_names_output\n+      with_sequence: start=1 end={{ num_nodes }}\n+\n+    # These set_fact's cannot be combined\n+    - set_fact:\n+        node_names_string: \"{% for item in node_names_output.results %}{{ item.ansible_facts.scratch }} {% endfor %}\"\n+\n+    - set_fact:\n+        node_names: \"{{ node_names_string.strip().split(' ') }}\"\n+\n+    - include: launch_instances.yml\n+      vars:\n+        instances: \"{{ node_names }}\"\n+        cluster: \"{{ cluster_id }}\"\n+        type: \"{{ k8s_type }}\"\n+\n+- hosts: \"tag_env_{{ cluster_id }}\"\n+  roles:\n+  - openshift_repos\n+  - os_update_latest\n+\n+- include: ../openshift-master/config.yml\n+  vars:\n+    oo_host_group_exp: \"groups[\\\"tag_env-host-type_{{ cluster_id }}-openshift-master\\\"]\"\n+\n+- include: ../openshift-node/config.yml\n+  vars:\n+    oo_host_group_exp: \"groups[\\\"tag_env-host-type_{{ cluster_id }}-openshift-node\\\"]\"","path":"playbooks/aws/openshift-cluster/launch.yml","position":60,"original_position":60,"commit_id":"7c9d11318bcb697ea6be7742aff4b721f5c92c6a","original_commit_id":"7c9d11318bcb697ea6be7742aff4b721f5c92c6a","user":{"login":"jwhonce","id":796529,"avatar_url":"https://avatars.githubusercontent.com/u/796529?v=3","gravatar_id":"","url":"https://api.github.com/users/jwhonce","html_url":"https://github.com/jwhonce","followers_url":"https://api.github.com/users/jwhonce/followers","following_url":"https://api.github.com/users/jwhonce/following{/other_user}","gists_url":"https://api.github.com/users/jwhonce/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhonce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhonce/subscriptions","organizations_url":"https://api.github.com/users/jwhonce/orgs","repos_url":"https://api.github.com/users/jwhonce/repos","events_url":"https://api.github.com/users/jwhonce/events{/privacy}","received_events_url":"https://api.github.com/users/jwhonce/received_events","type":"User","site_admin":false},"body":"Please add to the end of the file:\r\n\r\n- include: list.yml\r\n","created_at":"2015-04-02T14:57:05Z","updated_at":"2015-04-02T14:57:05Z","html_url":"https://github.com/openshift/openshift-ansible/pull/121#discussion_r27664408","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/27664408"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/121#discussion_r27664408"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/121","id":31796886,"html_url":"https://github.com/openshift/openshift-ansible/pull/121","diff_url":"https://github.com/openshift/openshift-ansible/pull/121.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/121.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/121","number":121,"state":"open","locked":false,"title":"[WIP] Node registration changes master","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"@twiest @jwhonce node registration changes for latest build\r\n\r\nBackground: Node now requires a set of certificates and kubeconfig that need to be generated on the master and can no longer connect using the --master flag.\r\n\r\nFixes in this changeset:\r\n- Node registration works again with new build\r\n- Node certificates are generated on the master and distributed to the client\r\n- Node no longer gets the admin kubeconfig cert\r\n- os_env_extras_node role added to perform the steps we needed from the docker role (adding root to the dockerroot group). This prevents the docker role from starting/enabling the docker service and letting openshift-node manage the docker service.\r\n- Added the openshift_facts role and module to better allow for setting and overriding default values.\r\n- Fixes some edge cases in os_firewall\r\n\r\nAdditional items included\r\n- Adding the Enterprise docs and byo playbooks/inventory\r\n- Removes cluster.sh\r\n- Adds launch/terminate support for AWS to bin/cluster","created_at":"2015-03-24T04:38:40Z","updated_at":"2015-04-02T14:57:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a6fa7f8f8a86604c96e9164275238f639f0e9e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/121/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/121/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/121/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/7c9d11318bcb697ea6be7742aff4b721f5c92c6a","head":{"label":"detiber:nodeRegistrationChangesMaster","ref":"nodeRegistrationChangesMaster","sha":"7c9d11318bcb697ea6be7742aff4b721f5c92c6a","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"repo":{"id":29140945,"name":"openshift-ansible","full_name":"detiber/openshift-ansible","owner":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/detiber/openshift-ansible","description":"OpenShift Online's Ansible Code","fork":true,"url":"https://api.github.com/repos/detiber/openshift-ansible","forks_url":"https://api.github.com/repos/detiber/openshift-ansible/forks","keys_url":"https://api.github.com/repos/detiber/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/detiber/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/detiber/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/detiber/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/detiber/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/detiber/openshift-ansible/events","assignees_url":"https://api.github.com/repos/detiber/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/detiber/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/detiber/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/detiber/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/detiber/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/detiber/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/detiber/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/detiber/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/detiber/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/detiber/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/detiber/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/detiber/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/detiber/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/detiber/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/detiber/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/detiber/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/detiber/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/detiber/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/detiber/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/detiber/openshift-ansible/merges","archive_url":"https://api.github.com/repos/detiber/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/detiber/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/detiber/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/detiber/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/detiber/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/detiber/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/detiber/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/detiber/openshift-ansible/releases{/id}","created_at":"2015-01-12T15:09:30Z","updated_at":"2015-03-30T19:52:51Z","pushed_at":"2015-04-02T04:25:59Z","git_url":"git://github.com/detiber/openshift-ansible.git","ssh_url":"git@github.com:detiber/openshift-ansible.git","clone_url":"https://github.com/detiber/openshift-ansible.git","svn_url":"https://github.com/detiber/openshift-ansible","homepage":"","size":1309,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"59e69dd21c19bf745392b5e83bd652630ee870cc","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","created_at":"2014-09-16T17:07:51Z","updated_at":"2015-04-01T20:45:03Z","pushed_at":"2015-04-02T14:20:43Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"","size":1967,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":12,"forks":32,"open_issues":12,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/121"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/121"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/121"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/7c9d11318bcb697ea6be7742aff4b721f5c92c6a"}}}}