{"action":"created","issue":{"url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2142","labels_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2142/labels{/name}","comments_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2142/comments","events_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2142/events","html_url":"https://github.com/quicksilver/Quicksilver/pull/2142","id":113719374,"number":2142,"title":"Modern aliases","user":{"login":"tiennou","id":81099,"avatar_url":"https://avatars.githubusercontent.com/u/81099?v=3","gravatar_id":"","url":"https://api.github.com/users/tiennou","html_url":"https://github.com/tiennou","followers_url":"https://api.github.com/users/tiennou/followers","following_url":"https://api.github.com/users/tiennou/following{/other_user}","gists_url":"https://api.github.com/users/tiennou/gists{/gist_id}","starred_url":"https://api.github.com/users/tiennou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiennou/subscriptions","organizations_url":"https://api.github.com/users/tiennou/orgs","repos_url":"https://api.github.com/users/tiennou/repos","events_url":"https://api.github.com/users/tiennou/events{/privacy}","received_events_url":"https://api.github.com/users/tiennou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-28T00:46:58Z","updated_at":"2015-10-29T04:14:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/2142","html_url":"https://github.com/quicksilver/Quicksilver/pull/2142","diff_url":"https://github.com/quicksilver/Quicksilver/pull/2142.diff","patch_url":"https://github.com/quicksilver/Quicksilver/pull/2142.patch"},"body":"Sorry for the name, *you* know that's a hard problem ;-).\r\n\r\nThis resurrects the switch to NSURL bookmarks I tried to do (#2075), since I wanted to fix the class of network-alias-stalls bugs we have and the main QS method we had actually doesn't handle all the bells and whistles of bookmark resolution. Maybe I should have added a comment on `-[NSFileManager resolveAliasAtPath:]` and friends but, well, I didn't. Consider yourselves warned :smirk:.\r\n\r\nThis one fixes the issue Rob had with the hundreds of warning messages had because *symlinks*. Since I wasn't keen on basing the new resolver because of [shaky grounds](http://digitalleaves.com/blog/2013/09/nsurl-files-equality-comparison-and-equivalency/), I preferred to keep the symlink-checking separate.\r\n\r\nThere's also a fix for `-infoRec` returning the symlink target info instead of the symlink itself, which makes symlink actually \"invisible\" (and non-working, it would seem — at least here, current `master` doesn't allow me to right-arrow into a symlink because the code passes a symlink path to some directory-parsing code). I wonder how you guys feel about that, especially in light of #1897, #1485, and the broken test ;-).\r\n\r\nThe icing on the cake is that \"resolvables\" show their target path instead of theirs.\r\n\r\nBased on the deprecation cleanup branch ~~for motivation~~ so the diff is cleaner."},"comment":{"url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/comments/152071856","html_url":"https://github.com/quicksilver/Quicksilver/pull/2142#issuecomment-152071856","issue_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2142","id":152071856,"user":{"login":"skurfer","id":154676,"avatar_url":"https://avatars.githubusercontent.com/u/154676?v=3","gravatar_id":"","url":"https://api.github.com/users/skurfer","html_url":"https://github.com/skurfer","followers_url":"https://api.github.com/users/skurfer/followers","following_url":"https://api.github.com/users/skurfer/following{/other_user}","gists_url":"https://api.github.com/users/skurfer/gists{/gist_id}","starred_url":"https://api.github.com/users/skurfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skurfer/subscriptions","organizations_url":"https://api.github.com/users/skurfer/orgs","repos_url":"https://api.github.com/users/skurfer/repos","events_url":"https://api.github.com/users/skurfer/events{/privacy}","received_events_url":"https://api.github.com/users/skurfer/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T04:14:19Z","updated_at":"2015-10-29T04:14:19Z","body":"Nice to see you, as always. So, let’s see. Some quick testing I did shows that this fixes\r\n\r\n  * #2063\r\n  * #2030\r\n  * #1977 (I could never reproduce it, but I'm taking your word)\r\n  * #1952\r\n  * #1884\r\n  * #1498 (if it was ever really broken)\r\n\r\nIn other words, every known issue with symbolic links. I had them all assigned to me, but hadn’t gotten to them yet. Nice work!\r\n\r\nRegarding my comment above about the UTI comparison, I found an [old comment][1] that suggests this test might not even work, but I’m seeing the target path in the details, so maybe it was fixed at the OS level?\r\n\r\nPersonally, I’d like the target path in the details string prefixed with things like “Link to” and “Alias of”. Not saying you need to bother with that right now, though. I can add it later.\r\n\r\n[1]: https://github.com/quicksilver/Quicksilver/issues/1884#issue-36291366\r\n"}}