{"action":"created","comment":{"url":"https://api.github.com/repos/meanjs/mean/pulls/comments/35465570","id":35465570,"diff_hunk":"@@ -38,12 +31,13 @@\n \t<!-- Fav Icon -->\n \t<link href=\"/modules/core/img/brand/favicon.ico\" rel=\"shortcut icon\" type=\"image/x-icon\">\n \n-\t<!--Application CSS Files-->\n+\t<!-- Application CSS Files -->\n \t{% for cssFile in cssFiles %}<link rel=\"stylesheet\" href=\"{{cssFile}}\">{% endfor %}\n \n-\t<!-- HTML5 Shim -->\n+\t<!-- HTML5 shim and Respond.js for IE8 support of HTML5 elements and media queries -->\n \t<!--[if lt IE 9]>\n-\t\t<script src=\"http://html5shim.googlecode.com/svn/trunk/html5.js\"></script>\n+\t\t<script src=\"//oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js\"></script>\n+\t\t<script src=\"//oss.maxcdn.com/respond/1.4.2/respond.min.js\"></script>","path":"modules/core/server/views/layout.server.view.html","position":44,"original_position":44,"commit_id":"d764faebcd9d0aace4f3445c328df46494b4f205","original_commit_id":"d764faebcd9d0aace4f3445c328df46494b4f205","user":{"login":"lirantal","id":316371,"avatar_url":"https://avatars.githubusercontent.com/u/316371?v=3","gravatar_id":"","url":"https://api.github.com/users/lirantal","html_url":"https://github.com/lirantal","followers_url":"https://api.github.com/users/lirantal/followers","following_url":"https://api.github.com/users/lirantal/following{/other_user}","gists_url":"https://api.github.com/users/lirantal/gists{/gist_id}","starred_url":"https://api.github.com/users/lirantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lirantal/subscriptions","organizations_url":"https://api.github.com/users/lirantal/orgs","repos_url":"https://api.github.com/users/lirantal/repos","events_url":"https://api.github.com/users/lirantal/events{/privacy}","received_events_url":"https://api.github.com/users/lirantal/received_events","type":"User","site_admin":false},"body":"I don't mind leaving this there, we can clean it up in a later version when we'll also probably upgrade AngularJS versions, etc. IIRC IE9 is deprecating on January 2016 or something like that.","created_at":"2015-07-24T21:03:33Z","updated_at":"2015-07-24T21:03:33Z","html_url":"https://github.com/meanjs/mean/pull/698#discussion_r35465570","pull_request_url":"https://api.github.com/repos/meanjs/mean/pulls/698","_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments/35465570"},"html":{"href":"https://github.com/meanjs/mean/pull/698#discussion_r35465570"},"pull_request":{"href":"https://api.github.com/repos/meanjs/mean/pulls/698"}}},"pull_request":{"url":"https://api.github.com/repos/meanjs/mean/pulls/698","id":40803311,"html_url":"https://github.com/meanjs/mean/pull/698","diff_url":"https://github.com/meanjs/mean/pull/698.diff","patch_url":"https://github.com/meanjs/mean/pull/698.patch","issue_url":"https://api.github.com/repos/meanjs/mean/issues/698","number":698,"state":"open","locked":false,"title":"Putting the head in order","user":{"login":"simison","id":87168,"avatar_url":"https://avatars.githubusercontent.com/u/87168?v=3","gravatar_id":"","url":"https://api.github.com/users/simison","html_url":"https://github.com/simison","followers_url":"https://api.github.com/users/simison/followers","following_url":"https://api.github.com/users/simison/following{/other_user}","gists_url":"https://api.github.com/users/simison/gists{/gist_id}","starred_url":"https://api.github.com/users/simison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simison/subscriptions","organizations_url":"https://api.github.com/users/simison/orgs","repos_url":"https://api.github.com/users/simison/repos","events_url":"https://api.github.com/users/simison/events{/privacy}","received_events_url":"https://api.github.com/users/simison/received_events","type":"User","site_admin":false},"body":"- Moving a few meta tags+base tag before the title. I've noticed Bootstrap [recommends this](http://getbootstrap.com/getting-started/#template) (wasn't sure why) so I did some quick googling and [IE seems to be the reason](http://blogs.msdn.com/b/ieinternals/archive/2011/07/18/optimal-html-head-ordering-to-avoid-parser-restarts-redownloads-and-improve-performance.aspx) but there were some other speculations, too. Feel free to search more.\r\n\r\n- ...in any case, [charset tag should come before the title](http://www.w3.org/wiki/The_HTML_head_element#Stop_right_there.21_Inline_CSS_and_JavaScript_is_not_too_clever.21).\r\n\r\n- Removing keyword tag since it [isn't really used anymore](https://chrisedwards.me/seo/keyword-meta-tag-google/).\r\n\r\n- Removing duplicate Content-type/Encoding tag\r\n\r\n- Adding respond.min.js so that media queries would work with old IEs.\r\n\r\n- Using a proper CDN for shim JS. That previous one was over http (problems when using https) and googlecode.com doesn't send proper cache headers; it's not smart to use it as a CDN.","created_at":"2015-07-24T18:38:52Z","updated_at":"2015-07-24T21:03:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c08f6be076205a8cc505cdbcb4edfd0bbbf78c0","assignee":{"login":"lirantal","id":316371,"avatar_url":"https://avatars.githubusercontent.com/u/316371?v=3","gravatar_id":"","url":"https://api.github.com/users/lirantal","html_url":"https://github.com/lirantal","followers_url":"https://api.github.com/users/lirantal/followers","following_url":"https://api.github.com/users/lirantal/following{/other_user}","gists_url":"https://api.github.com/users/lirantal/gists{/gist_id}","starred_url":"https://api.github.com/users/lirantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lirantal/subscriptions","organizations_url":"https://api.github.com/users/lirantal/orgs","repos_url":"https://api.github.com/users/lirantal/repos","events_url":"https://api.github.com/users/lirantal/events{/privacy}","received_events_url":"https://api.github.com/users/lirantal/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/meanjs/mean/milestones/2","html_url":"https://github.com/meanjs/mean/milestones/0.4.0","labels_url":"https://api.github.com/repos/meanjs/mean/milestones/2/labels","id":638272,"number":2,"title":"0.4.0","description":"","creator":{"login":"roieki","id":277629,"avatar_url":"https://avatars.githubusercontent.com/u/277629?v=3","gravatar_id":"","url":"https://api.github.com/users/roieki","html_url":"https://github.com/roieki","followers_url":"https://api.github.com/users/roieki/followers","following_url":"https://api.github.com/users/roieki/following{/other_user}","gists_url":"https://api.github.com/users/roieki/gists{/gist_id}","starred_url":"https://api.github.com/users/roieki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roieki/subscriptions","organizations_url":"https://api.github.com/users/roieki/orgs","repos_url":"https://api.github.com/users/roieki/repos","events_url":"https://api.github.com/users/roieki/events{/privacy}","received_events_url":"https://api.github.com/users/roieki/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":60,"state":"open","created_at":"2014-04-23T17:12:19Z","updated_at":"2015-07-24T21:02:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/meanjs/mean/pulls/698/commits","review_comments_url":"https://api.github.com/repos/meanjs/mean/pulls/698/comments","review_comment_url":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meanjs/mean/issues/698/comments","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/d764faebcd9d0aace4f3445c328df46494b4f205","head":{"label":"simison:patch-11","ref":"patch-11","sha":"d764faebcd9d0aace4f3445c328df46494b4f205","user":{"login":"simison","id":87168,"avatar_url":"https://avatars.githubusercontent.com/u/87168?v=3","gravatar_id":"","url":"https://api.github.com/users/simison","html_url":"https://github.com/simison","followers_url":"https://api.github.com/users/simison/followers","following_url":"https://api.github.com/users/simison/following{/other_user}","gists_url":"https://api.github.com/users/simison/gists{/gist_id}","starred_url":"https://api.github.com/users/simison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simison/subscriptions","organizations_url":"https://api.github.com/users/simison/orgs","repos_url":"https://api.github.com/users/simison/repos","events_url":"https://api.github.com/users/simison/events{/privacy}","received_events_url":"https://api.github.com/users/simison/received_events","type":"User","site_admin":false},"repo":{"id":33597226,"name":"mean","full_name":"simison/mean","owner":{"login":"simison","id":87168,"avatar_url":"https://avatars.githubusercontent.com/u/87168?v=3","gravatar_id":"","url":"https://api.github.com/users/simison","html_url":"https://github.com/simison","followers_url":"https://api.github.com/users/simison/followers","following_url":"https://api.github.com/users/simison/following{/other_user}","gists_url":"https://api.github.com/users/simison/gists{/gist_id}","starred_url":"https://api.github.com/users/simison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simison/subscriptions","organizations_url":"https://api.github.com/users/simison/orgs","repos_url":"https://api.github.com/users/simison/repos","events_url":"https://api.github.com/users/simison/events{/privacy}","received_events_url":"https://api.github.com/users/simison/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simison/mean","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js - ","fork":true,"url":"https://api.github.com/repos/simison/mean","forks_url":"https://api.github.com/repos/simison/mean/forks","keys_url":"https://api.github.com/repos/simison/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simison/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simison/mean/teams","hooks_url":"https://api.github.com/repos/simison/mean/hooks","issue_events_url":"https://api.github.com/repos/simison/mean/issues/events{/number}","events_url":"https://api.github.com/repos/simison/mean/events","assignees_url":"https://api.github.com/repos/simison/mean/assignees{/user}","branches_url":"https://api.github.com/repos/simison/mean/branches{/branch}","tags_url":"https://api.github.com/repos/simison/mean/tags","blobs_url":"https://api.github.com/repos/simison/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simison/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simison/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/simison/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simison/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/simison/mean/languages","stargazers_url":"https://api.github.com/repos/simison/mean/stargazers","contributors_url":"https://api.github.com/repos/simison/mean/contributors","subscribers_url":"https://api.github.com/repos/simison/mean/subscribers","subscription_url":"https://api.github.com/repos/simison/mean/subscription","commits_url":"https://api.github.com/repos/simison/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/simison/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/simison/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/simison/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/simison/mean/contents/{+path}","compare_url":"https://api.github.com/repos/simison/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simison/mean/merges","archive_url":"https://api.github.com/repos/simison/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simison/mean/downloads","issues_url":"https://api.github.com/repos/simison/mean/issues{/number}","pulls_url":"https://api.github.com/repos/simison/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/simison/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/simison/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simison/mean/labels{/name}","releases_url":"https://api.github.com/repos/simison/mean/releases{/id}","created_at":"2015-04-08T09:23:29Z","updated_at":"2015-04-08T09:23:29Z","pushed_at":"2015-07-24T18:38:40Z","git_url":"git://github.com/simison/mean.git","ssh_url":"git@github.com:simison/mean.git","clone_url":"https://github.com/simison/mean.git","svn_url":"https://github.com/simison/mean","homepage":"http://meanjs.org","size":2634,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meanjs:0.4.0","ref":"0.4.0","sha":"e3405d2f2b06dbbd282b285fbf221aeb2ba03f71","user":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"repo":{"id":15508537,"name":"mean","full_name":"meanjs/mean","owner":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meanjs/mean","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js - ","fork":false,"url":"https://api.github.com/repos/meanjs/mean","forks_url":"https://api.github.com/repos/meanjs/mean/forks","keys_url":"https://api.github.com/repos/meanjs/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meanjs/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meanjs/mean/teams","hooks_url":"https://api.github.com/repos/meanjs/mean/hooks","issue_events_url":"https://api.github.com/repos/meanjs/mean/issues/events{/number}","events_url":"https://api.github.com/repos/meanjs/mean/events","assignees_url":"https://api.github.com/repos/meanjs/mean/assignees{/user}","branches_url":"https://api.github.com/repos/meanjs/mean/branches{/branch}","tags_url":"https://api.github.com/repos/meanjs/mean/tags","blobs_url":"https://api.github.com/repos/meanjs/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meanjs/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meanjs/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/meanjs/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/meanjs/mean/languages","stargazers_url":"https://api.github.com/repos/meanjs/mean/stargazers","contributors_url":"https://api.github.com/repos/meanjs/mean/contributors","subscribers_url":"https://api.github.com/repos/meanjs/mean/subscribers","subscription_url":"https://api.github.com/repos/meanjs/mean/subscription","commits_url":"https://api.github.com/repos/meanjs/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/meanjs/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/meanjs/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/meanjs/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/meanjs/mean/contents/{+path}","compare_url":"https://api.github.com/repos/meanjs/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meanjs/mean/merges","archive_url":"https://api.github.com/repos/meanjs/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meanjs/mean/downloads","issues_url":"https://api.github.com/repos/meanjs/mean/issues{/number}","pulls_url":"https://api.github.com/repos/meanjs/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/meanjs/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/meanjs/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meanjs/mean/labels{/name}","releases_url":"https://api.github.com/repos/meanjs/mean/releases{/id}","created_at":"2013-12-29T13:01:15Z","updated_at":"2015-07-24T09:16:43Z","pushed_at":"2015-07-24T20:29:03Z","git_url":"git://github.com/meanjs/mean.git","ssh_url":"git@github.com:meanjs/mean.git","clone_url":"https://github.com/meanjs/mean.git","svn_url":"https://github.com/meanjs/mean","homepage":"http://meanjs.org","size":6702,"stargazers_count":2363,"watchers_count":2363,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":807,"mirror_url":null,"open_issues_count":114,"forks":807,"open_issues":114,"watchers":2363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/698"},"html":{"href":"https://github.com/meanjs/mean/pull/698"},"issue":{"href":"https://api.github.com/repos/meanjs/mean/issues/698"},"comments":{"href":"https://api.github.com/repos/meanjs/mean/issues/698/comments"},"review_comments":{"href":"https://api.github.com/repos/meanjs/mean/pulls/698/comments"},"review_comment":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meanjs/mean/pulls/698/commits"},"statuses":{"href":"https://api.github.com/repos/meanjs/mean/statuses/d764faebcd9d0aace4f3445c328df46494b4f205"}}}}