{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/42461130","id":42461130,"diff_hunk":"@@ -166,20 +176,37 @@ func PrioritizeNodes(pod *api.Pod, podLister algorithm.PodLister, priorityConfig\n \t\tpriorityFunc := priorityConfig.Function\n \t\tprioritizedList, err := priorityFunc(pod, podLister, minionLister)\n \t\tif err != nil {\n-\t\t\treturn algorithm.HostPriorityList{}, err\n+\t\t\treturn schedulerapi.HostPriorityList{}, err\n \t\t}\n \t\tfor _, hostEntry := range prioritizedList {\n \t\t\tcombinedScores[hostEntry.Host] += hostEntry.Score * weight\n \t\t}\n \t}\n+\tif len(extenders) != 0 && minionLister != nil {\n+\t\tnodes, err := minionLister.List()\n+\t\tif err != nil {\n+\t\t\treturn schedulerapi.HostPriorityList{}, err\n+\t\t}\n+\n+\t\tfor _, extender := range extenders {\n+\t\t\tprioritizedList, err := extender.Prioritize(pod, &nodes)","path":"plugin/pkg/scheduler/generic_scheduler.go","position":95,"original_position":95,"commit_id":"a3e9055227a8d07de6f54dc05dea3268aac6d828","original_commit_id":"a3e9055227a8d07de6f54dc05dea3268aac6d828","user":{"login":"ravigadde","id":3618819,"avatar_url":"https://avatars.githubusercontent.com/u/3618819?v=3","gravatar_id":"","url":"https://api.github.com/users/ravigadde","html_url":"https://github.com/ravigadde","followers_url":"https://api.github.com/users/ravigadde/followers","following_url":"https://api.github.com/users/ravigadde/following{/other_user}","gists_url":"https://api.github.com/users/ravigadde/gists{/gist_id}","starred_url":"https://api.github.com/users/ravigadde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravigadde/subscriptions","organizations_url":"https://api.github.com/users/ravigadde/orgs","repos_url":"https://api.github.com/users/ravigadde/repos","events_url":"https://api.github.com/users/ravigadde/events{/privacy}","received_events_url":"https://api.github.com/users/ravigadde/received_events","type":"User","site_admin":false},"body":"@davidopp Thanks for the review.\r\n\r\nThe concern here is that the pod list can be too large. The other assumption I made is that any inter pod synergies for scheduling purpose can be handled by the k8s scheduler (affinity, anti affinity etc).\r\n","created_at":"2015-10-20T06:50:23Z","updated_at":"2015-10-20T06:50:23Z","html_url":"https://github.com/kubernetes/kubernetes/pull/13580#discussion_r42461130","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13580","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/42461130"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13580#discussion_r42461130"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13580"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13580","id":44188812,"html_url":"https://github.com/kubernetes/kubernetes/pull/13580","diff_url":"https://github.com/kubernetes/kubernetes/pull/13580.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13580.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13580","number":13580,"state":"open","locked":false,"title":"Scheduler extension","user":{"login":"ravigadde","id":3618819,"avatar_url":"https://avatars.githubusercontent.com/u/3618819?v=3","gravatar_id":"","url":"https://api.github.com/users/ravigadde","html_url":"https://github.com/ravigadde","followers_url":"https://api.github.com/users/ravigadde/followers","following_url":"https://api.github.com/users/ravigadde/following{/other_user}","gists_url":"https://api.github.com/users/ravigadde/gists{/gist_id}","starred_url":"https://api.github.com/users/ravigadde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravigadde/subscriptions","organizations_url":"https://api.github.com/users/ravigadde/orgs","repos_url":"https://api.github.com/users/ravigadde/repos","events_url":"https://api.github.com/users/ravigadde/events{/privacy}","received_events_url":"https://api.github.com/users/ravigadde/received_events","type":"User","site_admin":false},"body":"Implementation of scheduler extension proposal as discussed in #11470","created_at":"2015-09-04T07:09:28Z","updated_at":"2015-10-20T06:50:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7fbed97e79808e6146d407a99fd3b2ec7680784","assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13580/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13580/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13580/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a3e9055227a8d07de6f54dc05dea3268aac6d828","head":{"label":"ravigadde:sched-ext","ref":"sched-ext","sha":"a3e9055227a8d07de6f54dc05dea3268aac6d828","user":{"login":"ravigadde","id":3618819,"avatar_url":"https://avatars.githubusercontent.com/u/3618819?v=3","gravatar_id":"","url":"https://api.github.com/users/ravigadde","html_url":"https://github.com/ravigadde","followers_url":"https://api.github.com/users/ravigadde/followers","following_url":"https://api.github.com/users/ravigadde/following{/other_user}","gists_url":"https://api.github.com/users/ravigadde/gists{/gist_id}","starred_url":"https://api.github.com/users/ravigadde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravigadde/subscriptions","organizations_url":"https://api.github.com/users/ravigadde/orgs","repos_url":"https://api.github.com/users/ravigadde/repos","events_url":"https://api.github.com/users/ravigadde/events{/privacy}","received_events_url":"https://api.github.com/users/ravigadde/received_events","type":"User","site_admin":false},"repo":{"id":27415409,"name":"kubernetes","full_name":"ravigadde/kubernetes","owner":{"login":"ravigadde","id":3618819,"avatar_url":"https://avatars.githubusercontent.com/u/3618819?v=3","gravatar_id":"","url":"https://api.github.com/users/ravigadde","html_url":"https://github.com/ravigadde","followers_url":"https://api.github.com/users/ravigadde/followers","following_url":"https://api.github.com/users/ravigadde/following{/other_user}","gists_url":"https://api.github.com/users/ravigadde/gists{/gist_id}","starred_url":"https://api.github.com/users/ravigadde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravigadde/subscriptions","organizations_url":"https://api.github.com/users/ravigadde/orgs","repos_url":"https://api.github.com/users/ravigadde/repos","events_url":"https://api.github.com/users/ravigadde/events{/privacy}","received_events_url":"https://api.github.com/users/ravigadde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ravigadde/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/ravigadde/kubernetes","forks_url":"https://api.github.com/repos/ravigadde/kubernetes/forks","keys_url":"https://api.github.com/repos/ravigadde/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravigadde/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravigadde/kubernetes/teams","hooks_url":"https://api.github.com/repos/ravigadde/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ravigadde/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ravigadde/kubernetes/events","assignees_url":"https://api.github.com/repos/ravigadde/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ravigadde/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ravigadde/kubernetes/tags","blobs_url":"https://api.github.com/repos/ravigadde/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravigadde/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravigadde/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravigadde/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravigadde/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ravigadde/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ravigadde/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ravigadde/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ravigadde/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ravigadde/kubernetes/subscription","commits_url":"https://api.github.com/repos/ravigadde/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravigadde/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravigadde/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravigadde/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravigadde/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ravigadde/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravigadde/kubernetes/merges","archive_url":"https://api.github.com/repos/ravigadde/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravigadde/kubernetes/downloads","issues_url":"https://api.github.com/repos/ravigadde/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ravigadde/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ravigadde/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ravigadde/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravigadde/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ravigadde/kubernetes/releases{/id}","created_at":"2014-12-02T04:43:36Z","updated_at":"2015-04-27T19:12:30Z","pushed_at":"2015-10-01T23:52:11Z","git_url":"git://github.com/ravigadde/kubernetes.git","ssh_url":"git@github.com:ravigadde/kubernetes.git","clone_url":"https://github.com/ravigadde/kubernetes.git","svn_url":"https://github.com/ravigadde/kubernetes","homepage":null,"size":109601,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b9293a093b51182486c133c44fce636536d28e21","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-10-20T06:47:41Z","pushed_at":"2015-10-20T06:49:18Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":476431,"stargazers_count":10778,"watchers_count":10778,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2733,"mirror_url":null,"open_issues_count":2074,"forks":2733,"open_issues":2074,"watchers":10778,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13580"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13580"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13580"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13580/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13580/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13580/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a3e9055227a8d07de6f54dc05dea3268aac6d828"}}}}