{"action":"created","issue":{"url":"https://api.github.com/repos/apache/tajo/issues/531","labels_url":"https://api.github.com/repos/apache/tajo/issues/531/labels{/name}","comments_url":"https://api.github.com/repos/apache/tajo/issues/531/comments","events_url":"https://api.github.com/repos/apache/tajo/issues/531/events","html_url":"https://github.com/apache/tajo/pull/531","id":67801547,"number":531,"title":"TAJO-1548 Refactoring condition code for CHAR into CatalogUtil","user":{"login":"charsyam","id":439301,"avatar_url":"https://avatars.githubusercontent.com/u/439301?v=3","gravatar_id":"","url":"https://api.github.com/users/charsyam","html_url":"https://github.com/charsyam","followers_url":"https://api.github.com/users/charsyam/followers","following_url":"https://api.github.com/users/charsyam/following{/other_user}","gists_url":"https://api.github.com/users/charsyam/gists{/gist_id}","starred_url":"https://api.github.com/users/charsyam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charsyam/subscriptions","organizations_url":"https://api.github.com/users/charsyam/orgs","repos_url":"https://api.github.com/users/charsyam/repos","events_url":"https://api.github.com/users/charsyam/events{/privacy}","received_events_url":"https://api.github.com/users/charsyam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-11T16:01:09Z","updated_at":"2015-04-20T01:32:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/tajo/pulls/531","html_url":"https://github.com/apache/tajo/pull/531","diff_url":"https://github.com/apache/tajo/pull/531.diff","patch_url":"https://github.com/apache/tajo/pull/531.patch"},"body":"Currently Schema's addColumn is this\r\n```java\r\npublic synchronized Schema addColumn(String name, Type type) {\r\nif (type == Type.CHAR)\r\n{ return addColumn(name, CatalogUtil.newDataTypeWithLen(type, 1)); }\r\nreturn addColumn(name, CatalogUtil.newSimpleDataType(type));\r\n}\r\n```\r\nI think it is better condition code into CatalogUtil.newSimpleDataType.\r\nbecause some testcode make columns just using CatalogUtil."},"comment":{"url":"https://api.github.com/repos/apache/tajo/issues/comments/94332999","html_url":"https://github.com/apache/tajo/pull/531#issuecomment-94332999","issue_url":"https://api.github.com/repos/apache/tajo/issues/531","id":94332999,"user":{"login":"blrunner","id":3724310,"avatar_url":"https://avatars.githubusercontent.com/u/3724310?v=3","gravatar_id":"","url":"https://api.github.com/users/blrunner","html_url":"https://github.com/blrunner","followers_url":"https://api.github.com/users/blrunner/followers","following_url":"https://api.github.com/users/blrunner/following{/other_user}","gists_url":"https://api.github.com/users/blrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/blrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blrunner/subscriptions","organizations_url":"https://api.github.com/users/blrunner/orgs","repos_url":"https://api.github.com/users/blrunner/repos","events_url":"https://api.github.com/users/blrunner/events{/privacy}","received_events_url":"https://api.github.com/users/blrunner/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T01:32:01Z","updated_at":"2015-04-20T01:32:01Z","body":"Hi @jihoonson \r\n\r\nThanks for your review.\r\n\r\nHi @charsyam \r\n\r\n+1\r\nThanks for your kind comment.\r\nI also agree with your suggestion.\r\n\r\nI'll commit this soon. :)\r\n"}}