{"action":"created","comment":{"url":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/comments/42013094","id":42013094,"diff_hunk":"@@ -40,10 +39,12 @@\n     \"lib/transport-utils.js\"\n   ],\n   \"devDependencies\": {\n-    \"seneca\": \"plugin\",\n+    \"async\": \"1.4.2\",\n+    \"bench\": \"^0.3.5\",\n     \"docco\": \"0.7.0\",\n     \"jshint\": \"2.8.0\",\n     \"mocha\": \"2.1.0\",\n+    \"seneca\": \"plugin\",\n     \"seneca-transport-test\": \"0.1.3\"","path":"package.json","position":45,"original_position":45,"commit_id":"be8e0d29b8e6bbd0835d4b5fdae62408ffd6f136","original_commit_id":"be8e0d29b8e6bbd0835d4b5fdae62408ffd6f136","user":{"login":"geek","id":441346,"avatar_url":"https://avatars.githubusercontent.com/u/441346?v=3","gravatar_id":"","url":"https://api.github.com/users/geek","html_url":"https://github.com/geek","followers_url":"https://api.github.com/users/geek/followers","following_url":"https://api.github.com/users/geek/following{/other_user}","gists_url":"https://api.github.com/users/geek/gists{/gist_id}","starred_url":"https://api.github.com/users/geek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geek/subscriptions","organizations_url":"https://api.github.com/users/geek/orgs","repos_url":"https://api.github.com/users/geek/repos","events_url":"https://api.github.com/users/geek/events{/privacy}","received_events_url":"https://api.github.com/users/geek/received_events","type":"User","site_admin":false},"body":"good idea.  We can wait to publish any update to seneca-transport until we have confirmed against the latest seneca-transport-test","created_at":"2015-10-14T15:58:12Z","updated_at":"2015-10-14T15:58:12Z","html_url":"https://github.com/rjrodger/seneca-transport/pull/34#discussion_r42013094","pull_request_url":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/comments/42013094"},"html":{"href":"https://github.com/rjrodger/seneca-transport/pull/34#discussion_r42013094"},"pull_request":{"href":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/34","id":45622262,"html_url":"https://github.com/rjrodger/seneca-transport/pull/34","diff_url":"https://github.com/rjrodger/seneca-transport/pull/34.diff","patch_url":"https://github.com/rjrodger/seneca-transport/pull/34.patch","issue_url":"https://api.github.com/repos/rjrodger/seneca-transport/issues/34","number":34,"state":"open","locked":false,"title":"Refactor transport","user":{"login":"geek","id":441346,"avatar_url":"https://avatars.githubusercontent.com/u/441346?v=3","gravatar_id":"","url":"https://api.github.com/users/geek","html_url":"https://github.com/geek","followers_url":"https://api.github.com/users/geek/followers","following_url":"https://api.github.com/users/geek/following{/other_user}","gists_url":"https://api.github.com/users/geek/gists{/gist_id}","starred_url":"https://api.github.com/users/geek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geek/subscriptions","organizations_url":"https://api.github.com/users/geek/orgs","repos_url":"https://api.github.com/users/geek/repos","events_url":"https://api.github.com/users/geek/events{/privacy}","received_events_url":"https://api.github.com/users/geek/received_events","type":"User","site_admin":false},"body":"- Added node v4 to travis\r\n- Changed reconnect-net dep to reconnect-core.  reconnect-net was 2 years old and never published beyond 0.0.0\r\n- No changes to tests or util functions.  The interface has stayed the same, just reorganized the transport code to make it easier to redo next.\r\n- Transport follows standard style + defensive measures from hapi: explicit internal/module functions, capitalized external module names\r\n- Pulled functions out of single function module.exports to make them easier to move around\r\n- Switched to camelCase for variables from snake_case\r\n- Brought in Hoek for default options support\r\n- Moved http and tcp into separate modules, making them possible to be pulled out as plugins\r\n\r\n18% faster than published implementation","created_at":"2015-09-22T02:39:40Z","updated_at":"2015-10-14T15:58:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e391a5c110435671f0a86e9da207a1a6ef0fdb6b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/34/commits","review_comments_url":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/34/comments","review_comment_url":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rjrodger/seneca-transport/issues/34/comments","statuses_url":"https://api.github.com/repos/rjrodger/seneca-transport/statuses/be8e0d29b8e6bbd0835d4b5fdae62408ffd6f136","head":{"label":"geek:rewrite","ref":"rewrite","sha":"be8e0d29b8e6bbd0835d4b5fdae62408ffd6f136","user":{"login":"geek","id":441346,"avatar_url":"https://avatars.githubusercontent.com/u/441346?v=3","gravatar_id":"","url":"https://api.github.com/users/geek","html_url":"https://github.com/geek","followers_url":"https://api.github.com/users/geek/followers","following_url":"https://api.github.com/users/geek/following{/other_user}","gists_url":"https://api.github.com/users/geek/gists{/gist_id}","starred_url":"https://api.github.com/users/geek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geek/subscriptions","organizations_url":"https://api.github.com/users/geek/orgs","repos_url":"https://api.github.com/users/geek/repos","events_url":"https://api.github.com/users/geek/events{/privacy}","received_events_url":"https://api.github.com/users/geek/received_events","type":"User","site_admin":false},"repo":{"id":42474958,"name":"seneca-transport","full_name":"geek/seneca-transport","owner":{"login":"geek","id":441346,"avatar_url":"https://avatars.githubusercontent.com/u/441346?v=3","gravatar_id":"","url":"https://api.github.com/users/geek","html_url":"https://github.com/geek","followers_url":"https://api.github.com/users/geek/followers","following_url":"https://api.github.com/users/geek/following{/other_user}","gists_url":"https://api.github.com/users/geek/gists{/gist_id}","starred_url":"https://api.github.com/users/geek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geek/subscriptions","organizations_url":"https://api.github.com/users/geek/orgs","repos_url":"https://api.github.com/users/geek/repos","events_url":"https://api.github.com/users/geek/events{/privacy}","received_events_url":"https://api.github.com/users/geek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geek/seneca-transport","description":"Seneca micro-services message transport over TCP and HTTP.","fork":true,"url":"https://api.github.com/repos/geek/seneca-transport","forks_url":"https://api.github.com/repos/geek/seneca-transport/forks","keys_url":"https://api.github.com/repos/geek/seneca-transport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geek/seneca-transport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geek/seneca-transport/teams","hooks_url":"https://api.github.com/repos/geek/seneca-transport/hooks","issue_events_url":"https://api.github.com/repos/geek/seneca-transport/issues/events{/number}","events_url":"https://api.github.com/repos/geek/seneca-transport/events","assignees_url":"https://api.github.com/repos/geek/seneca-transport/assignees{/user}","branches_url":"https://api.github.com/repos/geek/seneca-transport/branches{/branch}","tags_url":"https://api.github.com/repos/geek/seneca-transport/tags","blobs_url":"https://api.github.com/repos/geek/seneca-transport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geek/seneca-transport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geek/seneca-transport/git/refs{/sha}","trees_url":"https://api.github.com/repos/geek/seneca-transport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geek/seneca-transport/statuses/{sha}","languages_url":"https://api.github.com/repos/geek/seneca-transport/languages","stargazers_url":"https://api.github.com/repos/geek/seneca-transport/stargazers","contributors_url":"https://api.github.com/repos/geek/seneca-transport/contributors","subscribers_url":"https://api.github.com/repos/geek/seneca-transport/subscribers","subscription_url":"https://api.github.com/repos/geek/seneca-transport/subscription","commits_url":"https://api.github.com/repos/geek/seneca-transport/commits{/sha}","git_commits_url":"https://api.github.com/repos/geek/seneca-transport/git/commits{/sha}","comments_url":"https://api.github.com/repos/geek/seneca-transport/comments{/number}","issue_comment_url":"https://api.github.com/repos/geek/seneca-transport/issues/comments{/number}","contents_url":"https://api.github.com/repos/geek/seneca-transport/contents/{+path}","compare_url":"https://api.github.com/repos/geek/seneca-transport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geek/seneca-transport/merges","archive_url":"https://api.github.com/repos/geek/seneca-transport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geek/seneca-transport/downloads","issues_url":"https://api.github.com/repos/geek/seneca-transport/issues{/number}","pulls_url":"https://api.github.com/repos/geek/seneca-transport/pulls{/number}","milestones_url":"https://api.github.com/repos/geek/seneca-transport/milestones{/number}","notifications_url":"https://api.github.com/repos/geek/seneca-transport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geek/seneca-transport/labels{/name}","releases_url":"https://api.github.com/repos/geek/seneca-transport/releases{/id}","created_at":"2015-09-14T20:23:06Z","updated_at":"2015-09-14T20:23:06Z","pushed_at":"2015-10-12T19:35:50Z","git_url":"git://github.com/geek/seneca-transport.git","ssh_url":"git@github.com:geek/seneca-transport.git","clone_url":"https://github.com/geek/seneca-transport.git","svn_url":"https://github.com/geek/seneca-transport","homepage":"","size":680,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rjrodger:master","ref":"master","sha":"2ae98438352830ceb962324ae7dc62df061cc6fb","user":{"login":"rjrodger","id":138608,"avatar_url":"https://avatars.githubusercontent.com/u/138608?v=3","gravatar_id":"","url":"https://api.github.com/users/rjrodger","html_url":"https://github.com/rjrodger","followers_url":"https://api.github.com/users/rjrodger/followers","following_url":"https://api.github.com/users/rjrodger/following{/other_user}","gists_url":"https://api.github.com/users/rjrodger/gists{/gist_id}","starred_url":"https://api.github.com/users/rjrodger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjrodger/subscriptions","organizations_url":"https://api.github.com/users/rjrodger/orgs","repos_url":"https://api.github.com/users/rjrodger/repos","events_url":"https://api.github.com/users/rjrodger/events{/privacy}","received_events_url":"https://api.github.com/users/rjrodger/received_events","type":"User","site_admin":false},"repo":{"id":13784349,"name":"seneca-transport","full_name":"rjrodger/seneca-transport","owner":{"login":"rjrodger","id":138608,"avatar_url":"https://avatars.githubusercontent.com/u/138608?v=3","gravatar_id":"","url":"https://api.github.com/users/rjrodger","html_url":"https://github.com/rjrodger","followers_url":"https://api.github.com/users/rjrodger/followers","following_url":"https://api.github.com/users/rjrodger/following{/other_user}","gists_url":"https://api.github.com/users/rjrodger/gists{/gist_id}","starred_url":"https://api.github.com/users/rjrodger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjrodger/subscriptions","organizations_url":"https://api.github.com/users/rjrodger/orgs","repos_url":"https://api.github.com/users/rjrodger/repos","events_url":"https://api.github.com/users/rjrodger/events{/privacy}","received_events_url":"https://api.github.com/users/rjrodger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjrodger/seneca-transport","description":"Seneca micro-services message transport over TCP and HTTP.","fork":false,"url":"https://api.github.com/repos/rjrodger/seneca-transport","forks_url":"https://api.github.com/repos/rjrodger/seneca-transport/forks","keys_url":"https://api.github.com/repos/rjrodger/seneca-transport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjrodger/seneca-transport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjrodger/seneca-transport/teams","hooks_url":"https://api.github.com/repos/rjrodger/seneca-transport/hooks","issue_events_url":"https://api.github.com/repos/rjrodger/seneca-transport/issues/events{/number}","events_url":"https://api.github.com/repos/rjrodger/seneca-transport/events","assignees_url":"https://api.github.com/repos/rjrodger/seneca-transport/assignees{/user}","branches_url":"https://api.github.com/repos/rjrodger/seneca-transport/branches{/branch}","tags_url":"https://api.github.com/repos/rjrodger/seneca-transport/tags","blobs_url":"https://api.github.com/repos/rjrodger/seneca-transport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjrodger/seneca-transport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjrodger/seneca-transport/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjrodger/seneca-transport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjrodger/seneca-transport/statuses/{sha}","languages_url":"https://api.github.com/repos/rjrodger/seneca-transport/languages","stargazers_url":"https://api.github.com/repos/rjrodger/seneca-transport/stargazers","contributors_url":"https://api.github.com/repos/rjrodger/seneca-transport/contributors","subscribers_url":"https://api.github.com/repos/rjrodger/seneca-transport/subscribers","subscription_url":"https://api.github.com/repos/rjrodger/seneca-transport/subscription","commits_url":"https://api.github.com/repos/rjrodger/seneca-transport/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjrodger/seneca-transport/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjrodger/seneca-transport/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjrodger/seneca-transport/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjrodger/seneca-transport/contents/{+path}","compare_url":"https://api.github.com/repos/rjrodger/seneca-transport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjrodger/seneca-transport/merges","archive_url":"https://api.github.com/repos/rjrodger/seneca-transport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjrodger/seneca-transport/downloads","issues_url":"https://api.github.com/repos/rjrodger/seneca-transport/issues{/number}","pulls_url":"https://api.github.com/repos/rjrodger/seneca-transport/pulls{/number}","milestones_url":"https://api.github.com/repos/rjrodger/seneca-transport/milestones{/number}","notifications_url":"https://api.github.com/repos/rjrodger/seneca-transport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjrodger/seneca-transport/labels{/name}","releases_url":"https://api.github.com/repos/rjrodger/seneca-transport/releases{/id}","created_at":"2013-10-22T20:01:19Z","updated_at":"2015-10-09T20:50:33Z","pushed_at":"2015-10-12T19:35:50Z","git_url":"git://github.com/rjrodger/seneca-transport.git","ssh_url":"git@github.com:rjrodger/seneca-transport.git","clone_url":"https://github.com/rjrodger/seneca-transport.git","svn_url":"https://github.com/rjrodger/seneca-transport","homepage":"","size":1257,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":10,"forks":16,"open_issues":10,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/34"},"html":{"href":"https://github.com/rjrodger/seneca-transport/pull/34"},"issue":{"href":"https://api.github.com/repos/rjrodger/seneca-transport/issues/34"},"comments":{"href":"https://api.github.com/repos/rjrodger/seneca-transport/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rjrodger/seneca-transport/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/rjrodger/seneca-transport/statuses/be8e0d29b8e6bbd0835d4b5fdae62408ffd6f136"}}}}