{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3980","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3980/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3980/comments","events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3980/events","html_url":"https://github.com/angular-ui/bootstrap/pull/3980","id":96192076,"number":3980,"title":"Tooltip positioning & placement improvements","user":{"login":"cvn","id":774864,"avatar_url":"https://avatars.githubusercontent.com/u/774864?v=3","gravatar_id":"","url":"https://api.github.com/users/cvn","html_url":"https://github.com/cvn","followers_url":"https://api.github.com/users/cvn/followers","following_url":"https://api.github.com/users/cvn/following{/other_user}","gists_url":"https://api.github.com/users/cvn/gists{/gist_id}","starred_url":"https://api.github.com/users/cvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvn/subscriptions","organizations_url":"https://api.github.com/users/cvn/orgs","repos_url":"https://api.github.com/users/cvn/repos","events_url":"https://api.github.com/users/cvn/events{/privacy}","received_events_url":"https://api.github.com/users/cvn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular-ui/bootstrap/labels/component:%20tooltip","name":"component: tooltip","color":"ffffff"},{"url":"https://api.github.com/repos/angular-ui/bootstrap/labels/needs:%20review","name":"needs: review","color":"5319e7"},{"url":"https://api.github.com/repos/angular-ui/bootstrap/labels/type:%20performance","name":"type: performance","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/14","html_url":"https://github.com/angular-ui/bootstrap/milestones/Backlog","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/14/labels","id":806073,"number":14,"title":"Backlog","description":"Holds the backlog of issues and pull requests that have been triaged.","creator":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"open_issues":188,"closed_issues":71,"state":"open","created_at":"2014-09-29T01:22:44Z","updated_at":"2015-07-21T19:24:42Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-07-20T23:53:53Z","updated_at":"2015-07-21T19:33:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3980","html_url":"https://github.com/angular-ui/bootstrap/pull/3980","diff_url":"https://github.com/angular-ui/bootstrap/pull/3980.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/3980.patch"},"body":"This PR contains two changes:\r\n\r\n1. Only update tooltip position when content changes, instead of every $digest. This fixes a bug where the tooltip would shift a pixel #3964, and should be a little more performant.\r\n2. Adds the ability for changes to `tooltip-placement`/`popover-placement` to be reflected by the tooltip immediately #3978. The test for this is arguably incomplete, it only checks that the tooltip scope is updated, and doesn't check that the tooltip appearance has changed. I don't really know how to test the latter.\r\n\r\n@chrisirhc It looks like you've done the most work on the tooltips recently, I would love to get your opinion on these changes."},"comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments/123455605","html_url":"https://github.com/angular-ui/bootstrap/pull/3980#issuecomment-123455605","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3980","id":123455605,"user":{"login":"cvn","id":774864,"avatar_url":"https://avatars.githubusercontent.com/u/774864?v=3","gravatar_id":"","url":"https://api.github.com/users/cvn","html_url":"https://github.com/cvn","followers_url":"https://api.github.com/users/cvn/followers","following_url":"https://api.github.com/users/cvn/following{/other_user}","gists_url":"https://api.github.com/users/cvn/gists{/gist_id}","starred_url":"https://api.github.com/users/cvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvn/subscriptions","organizations_url":"https://api.github.com/users/cvn/orgs","repos_url":"https://api.github.com/users/cvn/repos","events_url":"https://api.github.com/users/cvn/events{/privacy}","received_events_url":"https://api.github.com/users/cvn/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T19:33:27Z","updated_at":"2015-07-21T19:33:27Z","body":"Yeah, the $timeouts were necessary in my testing. It *might* be possible to set priorities on the directives to remove the need for the $timeouts (so that the position calculation always happened after the text was rendered), but I'm just speculating, I didn't attempt this."}}