{"action":"created","comment":{"url":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/comments/39338788","id":39338788,"diff_hunk":"@@ -0,0 +1,116 @@\n+module Hydra::Works::GenericFile\n+  module Characterization\n+    extend ActiveSupport::Concern\n+\n+    autoload :FitsDatastream, 'hydra/works/models/generic_file/characterization/fits_datastream.rb'","path":"lib/hydra/works/models/concerns/generic_file/characterization.rb","position":5,"original_position":5,"commit_id":"706d29ab87911a466d43fa52fde33bd827df011d","original_commit_id":"706d29ab87911a466d43fa52fde33bd827df011d","user":{"login":"grosscol","id":1520508,"avatar_url":"https://avatars.githubusercontent.com/u/1520508?v=3","gravatar_id":"","url":"https://api.github.com/users/grosscol","html_url":"https://github.com/grosscol","followers_url":"https://api.github.com/users/grosscol/followers","following_url":"https://api.github.com/users/grosscol/following{/other_user}","gists_url":"https://api.github.com/users/grosscol/gists{/gist_id}","starred_url":"https://api.github.com/users/grosscol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosscol/subscriptions","organizations_url":"https://api.github.com/users/grosscol/orgs","repos_url":"https://api.github.com/users/grosscol/repos","events_url":"https://api.github.com/users/grosscol/events{/privacy}","received_events_url":"https://api.github.com/users/grosscol/received_events","type":"User","site_admin":false},"body":"I was unable to specify that the rails autoload logic should be looking in the models directory.","created_at":"2015-09-12T16:13:44Z","updated_at":"2015-09-12T16:13:44Z","html_url":"https://github.com/projecthydra-labs/hydra-works/pull/209#discussion_r39338788","pull_request_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/comments/39338788"},"html":{"href":"https://github.com/projecthydra-labs/hydra-works/pull/209#discussion_r39338788"},"pull_request":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/209","id":44495211,"html_url":"https://github.com/projecthydra-labs/hydra-works/pull/209","diff_url":"https://github.com/projecthydra-labs/hydra-works/pull/209.diff","patch_url":"https://github.com/projecthydra-labs/hydra-works/pull/209.patch","issue_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/issues/209","number":209,"state":"open","locked":false,"title":"Characterization using OM","user":{"login":"grosscol","id":1520508,"avatar_url":"https://avatars.githubusercontent.com/u/1520508?v=3","gravatar_id":"","url":"https://api.github.com/users/grosscol","html_url":"https://github.com/grosscol","followers_url":"https://api.github.com/users/grosscol/followers","following_url":"https://api.github.com/users/grosscol/following{/other_user}","gists_url":"https://api.github.com/users/grosscol/gists{/gist_id}","starred_url":"https://api.github.com/users/grosscol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosscol/subscriptions","organizations_url":"https://api.github.com/users/grosscol/orgs","repos_url":"https://api.github.com/users/grosscol/repos","events_url":"https://api.github.com/users/grosscol/events{/privacy}","received_events_url":"https://api.github.com/users/grosscol/received_events","type":"User","site_admin":false},"body":"A parallel line of development with #199.  Also addresses #89.  \r\n\r\nThis is a more direct pull down of the OM approach.  @jcoyne, this still requires the downstream application to define the properties they want available for their GenericFile::Base derived class.  However, all the default fits datastream configuration is there by default, so only properties will have to be defined for the GF subclass.\r\n\r\nThis does not save the fits xml datastream object.  It's a transient artifact of the characterization.\r\n\r\nThe specs are still a work in progress.  I should be able to address them tomorrow.","created_at":"2015-09-08T23:26:33Z","updated_at":"2015-09-12T16:13:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7502723ef9cec61aed417c434514c0441c5c014b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/209/commits","review_comments_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/209/comments","review_comment_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/issues/209/comments","statuses_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/statuses/706d29ab87911a466d43fa52fde33bd827df011d","head":{"label":"grosscol:characterization","ref":"characterization","sha":"706d29ab87911a466d43fa52fde33bd827df011d","user":{"login":"grosscol","id":1520508,"avatar_url":"https://avatars.githubusercontent.com/u/1520508?v=3","gravatar_id":"","url":"https://api.github.com/users/grosscol","html_url":"https://github.com/grosscol","followers_url":"https://api.github.com/users/grosscol/followers","following_url":"https://api.github.com/users/grosscol/following{/other_user}","gists_url":"https://api.github.com/users/grosscol/gists{/gist_id}","starred_url":"https://api.github.com/users/grosscol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosscol/subscriptions","organizations_url":"https://api.github.com/users/grosscol/orgs","repos_url":"https://api.github.com/users/grosscol/repos","events_url":"https://api.github.com/users/grosscol/events{/privacy}","received_events_url":"https://api.github.com/users/grosscol/received_events","type":"User","site_admin":false},"repo":{"id":36466481,"name":"hydra-works","full_name":"grosscol/hydra-works","owner":{"login":"grosscol","id":1520508,"avatar_url":"https://avatars.githubusercontent.com/u/1520508?v=3","gravatar_id":"","url":"https://api.github.com/users/grosscol","html_url":"https://github.com/grosscol","followers_url":"https://api.github.com/users/grosscol/followers","following_url":"https://api.github.com/users/grosscol/following{/other_user}","gists_url":"https://api.github.com/users/grosscol/gists{/gist_id}","starred_url":"https://api.github.com/users/grosscol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosscol/subscriptions","organizations_url":"https://api.github.com/users/grosscol/orgs","repos_url":"https://api.github.com/users/grosscol/repos","events_url":"https://api.github.com/users/grosscol/events{/privacy}","received_events_url":"https://api.github.com/users/grosscol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grosscol/hydra-works","description":"A base work/file/collection model for hydra.","fork":true,"url":"https://api.github.com/repos/grosscol/hydra-works","forks_url":"https://api.github.com/repos/grosscol/hydra-works/forks","keys_url":"https://api.github.com/repos/grosscol/hydra-works/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grosscol/hydra-works/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grosscol/hydra-works/teams","hooks_url":"https://api.github.com/repos/grosscol/hydra-works/hooks","issue_events_url":"https://api.github.com/repos/grosscol/hydra-works/issues/events{/number}","events_url":"https://api.github.com/repos/grosscol/hydra-works/events","assignees_url":"https://api.github.com/repos/grosscol/hydra-works/assignees{/user}","branches_url":"https://api.github.com/repos/grosscol/hydra-works/branches{/branch}","tags_url":"https://api.github.com/repos/grosscol/hydra-works/tags","blobs_url":"https://api.github.com/repos/grosscol/hydra-works/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grosscol/hydra-works/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grosscol/hydra-works/git/refs{/sha}","trees_url":"https://api.github.com/repos/grosscol/hydra-works/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grosscol/hydra-works/statuses/{sha}","languages_url":"https://api.github.com/repos/grosscol/hydra-works/languages","stargazers_url":"https://api.github.com/repos/grosscol/hydra-works/stargazers","contributors_url":"https://api.github.com/repos/grosscol/hydra-works/contributors","subscribers_url":"https://api.github.com/repos/grosscol/hydra-works/subscribers","subscription_url":"https://api.github.com/repos/grosscol/hydra-works/subscription","commits_url":"https://api.github.com/repos/grosscol/hydra-works/commits{/sha}","git_commits_url":"https://api.github.com/repos/grosscol/hydra-works/git/commits{/sha}","comments_url":"https://api.github.com/repos/grosscol/hydra-works/comments{/number}","issue_comment_url":"https://api.github.com/repos/grosscol/hydra-works/issues/comments{/number}","contents_url":"https://api.github.com/repos/grosscol/hydra-works/contents/{+path}","compare_url":"https://api.github.com/repos/grosscol/hydra-works/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grosscol/hydra-works/merges","archive_url":"https://api.github.com/repos/grosscol/hydra-works/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grosscol/hydra-works/downloads","issues_url":"https://api.github.com/repos/grosscol/hydra-works/issues{/number}","pulls_url":"https://api.github.com/repos/grosscol/hydra-works/pulls{/number}","milestones_url":"https://api.github.com/repos/grosscol/hydra-works/milestones{/number}","notifications_url":"https://api.github.com/repos/grosscol/hydra-works/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grosscol/hydra-works/labels{/name}","releases_url":"https://api.github.com/repos/grosscol/hydra-works/releases{/id}","created_at":"2015-05-28T21:13:26Z","updated_at":"2015-05-28T21:13:26Z","pushed_at":"2015-09-11T18:52:12Z","git_url":"git://github.com/grosscol/hydra-works.git","ssh_url":"git@github.com:grosscol/hydra-works.git","clone_url":"https://github.com/grosscol/hydra-works.git","svn_url":"https://github.com/grosscol/hydra-works","homepage":null,"size":1436,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projecthydra-labs:master","ref":"master","sha":"bf57c698399c342534484d8e836846fdfa80bfe4","user":{"login":"projecthydra-labs","id":7377013,"avatar_url":"https://avatars.githubusercontent.com/u/7377013?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra-labs","html_url":"https://github.com/projecthydra-labs","followers_url":"https://api.github.com/users/projecthydra-labs/followers","following_url":"https://api.github.com/users/projecthydra-labs/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra-labs/subscriptions","organizations_url":"https://api.github.com/users/projecthydra-labs/orgs","repos_url":"https://api.github.com/users/projecthydra-labs/repos","events_url":"https://api.github.com/users/projecthydra-labs/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":24871990,"name":"hydra-works","full_name":"projecthydra-labs/hydra-works","owner":{"login":"projecthydra-labs","id":7377013,"avatar_url":"https://avatars.githubusercontent.com/u/7377013?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra-labs","html_url":"https://github.com/projecthydra-labs","followers_url":"https://api.github.com/users/projecthydra-labs/followers","following_url":"https://api.github.com/users/projecthydra-labs/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra-labs/subscriptions","organizations_url":"https://api.github.com/users/projecthydra-labs/orgs","repos_url":"https://api.github.com/users/projecthydra-labs/repos","events_url":"https://api.github.com/users/projecthydra-labs/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra-labs/hydra-works","description":"A base work/file/collection model for hydra.","fork":false,"url":"https://api.github.com/repos/projecthydra-labs/hydra-works","forks_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/forks","keys_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/teams","hooks_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/hooks","issue_events_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/events","assignees_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/tags","blobs_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/languages","stargazers_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/stargazers","contributors_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/contributors","subscribers_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/subscribers","subscription_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/subscription","commits_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/merges","archive_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/downloads","issues_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra-labs/hydra-works/releases{/id}","created_at":"2014-10-07T01:09:07Z","updated_at":"2015-08-06T07:35:22Z","pushed_at":"2015-09-11T18:52:13Z","git_url":"git://github.com/projecthydra-labs/hydra-works.git","ssh_url":"git@github.com:projecthydra-labs/hydra-works.git","clone_url":"https://github.com/projecthydra-labs/hydra-works.git","svn_url":"https://github.com/projecthydra-labs/hydra-works","homepage":null,"size":93093,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":28,"forks":10,"open_issues":28,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/209"},"html":{"href":"https://github.com/projecthydra-labs/hydra-works/pull/209"},"issue":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-works/issues/209"},"comments":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-works/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-works/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/projecthydra-labs/hydra-works/statuses/706d29ab87911a466d43fa52fde33bd827df011d"}}}}