{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2047","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2047/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2047/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2047/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/2047","id":57668318,"number":2047,"title":"Replace DISC_TYPE_WII with DISC_TYPE_WII_CONTAINER","user":{"login":"Stevoisiak","id":1330770,"avatar_url":"https://avatars.githubusercontent.com/u/1330770?v=3","gravatar_id":"","url":"https://api.github.com/users/Stevoisiak","html_url":"https://github.com/Stevoisiak","followers_url":"https://api.github.com/users/Stevoisiak/followers","following_url":"https://api.github.com/users/Stevoisiak/following{/other_user}","gists_url":"https://api.github.com/users/Stevoisiak/gists{/gist_id}","starred_url":"https://api.github.com/users/Stevoisiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stevoisiak/subscriptions","organizations_url":"https://api.github.com/users/Stevoisiak/orgs","repos_url":"https://api.github.com/users/Stevoisiak/repos","events_url":"https://api.github.com/users/Stevoisiak/events{/privacy}","received_events_url":"https://api.github.com/users/Stevoisiak/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-02-13T23:32:18Z","updated_at":"2015-05-08T08:25:50Z","closed_at":"2015-05-08T01:56:46Z","pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2047","html_url":"https://github.com/dolphin-emu/dolphin/pull/2047","diff_url":"https://github.com/dolphin-emu/dolphin/pull/2047.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/2047.patch"},"body":"As best as I can tell, this code goes completely unused, as all of my Wii games come up as \"DISC_TYPE_WII_CONTAINER\".\r\n\r\nIf anyone knows what these variables are used for, please let me know. I'm trying to figure out what the purpose of this code is.\r\n\r\nGit blame said this section was authored by Soren Jorvang on Jun 1, 2010.\r\n\r\nEdit: It seems that Wii Container Magic is the debugger hook. So DISC_TYPE_WII is only used if the debugger hook is not equal to 0. http://hitmen.c02.at/files/yagcd/yagcd/chap4.html#sec4.2.1.3"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/100151003","html_url":"https://github.com/dolphin-emu/dolphin/pull/2047#issuecomment-100151003","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2047","id":100151003,"user":{"login":"shuffle2","id":113063,"avatar_url":"https://avatars.githubusercontent.com/u/113063?v=3","gravatar_id":"","url":"https://api.github.com/users/shuffle2","html_url":"https://github.com/shuffle2","followers_url":"https://api.github.com/users/shuffle2/followers","following_url":"https://api.github.com/users/shuffle2/following{/other_user}","gists_url":"https://api.github.com/users/shuffle2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuffle2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuffle2/subscriptions","organizations_url":"https://api.github.com/users/shuffle2/orgs","repos_url":"https://api.github.com/users/shuffle2/repos","events_url":"https://api.github.com/users/shuffle2/events{/privacy}","received_events_url":"https://api.github.com/users/shuffle2/received_events","type":"User","site_admin":false},"created_at":"2015-05-08T08:25:50Z","updated_at":"2015-05-08T08:25:50Z","body":"This is for reading unencrypted discs...probably some (early?) sdk output or demo disc. Look at offset 0x61. This is why i mentioned that it's reading 4bytes (instead of 1)."}}