{"action":"created","issue":{"url":"https://api.github.com/repos/TomAugspurger/engarde/issues/5","labels_url":"https://api.github.com/repos/TomAugspurger/engarde/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/TomAugspurger/engarde/issues/5/comments","events_url":"https://api.github.com/repos/TomAugspurger/engarde/issues/5/events","html_url":"https://github.com/TomAugspurger/engarde/pull/5","id":90643323,"number":5,"title":"ENH: Start of adding slicing","user":{"login":"jnmclarty","id":6062071,"avatar_url":"https://avatars.githubusercontent.com/u/6062071?v=3","gravatar_id":"","url":"https://api.github.com/users/jnmclarty","html_url":"https://github.com/jnmclarty","followers_url":"https://api.github.com/users/jnmclarty/followers","following_url":"https://api.github.com/users/jnmclarty/following{/other_user}","gists_url":"https://api.github.com/users/jnmclarty/gists{/gist_id}","starred_url":"https://api.github.com/users/jnmclarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnmclarty/subscriptions","organizations_url":"https://api.github.com/users/jnmclarty/orgs","repos_url":"https://api.github.com/users/jnmclarty/repos","events_url":"https://api.github.com/users/jnmclarty/events{/privacy}","received_events_url":"https://api.github.com/users/jnmclarty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-24T11:00:36Z","updated_at":"2015-06-25T02:33:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TomAugspurger/engarde/pulls/5","html_url":"https://github.com/TomAugspurger/engarde/pull/5","diff_url":"https://github.com/TomAugspurger/engarde/pull/5.diff","patch_url":"https://github.com/TomAugspurger/engarde/pull/5.patch"},"body":"Hi Tom!\r\n\r\nNice project you started here.  What are you plans with it?  This fits in nicely with a project I'm working on.\r\n\r\nI'm curious if you would be inclined to add a slicing layer to the framework?  This PR, is just to illustrate what it might look like.  I haven't even tried to run this code.  Want to bounce it off you, ask if you're even interested in contributors, etc, before I spent too much time on it.\r\n\r\nIt would enable checking \"recent\" data, against the values in the \"pre-recent\", and it would also be a massive speed boost, for those kinds of checks (as opposed to checking the entire thing.) I've prepared a second PR, before I had this idea, with a few one off examples where it might be appropriate."},"comment":{"url":"https://api.github.com/repos/TomAugspurger/engarde/issues/comments/115075491","html_url":"https://github.com/TomAugspurger/engarde/pull/5#issuecomment-115075491","issue_url":"https://api.github.com/repos/TomAugspurger/engarde/issues/5","id":115075491,"user":{"login":"jnmclarty","id":6062071,"avatar_url":"https://avatars.githubusercontent.com/u/6062071?v=3","gravatar_id":"","url":"https://api.github.com/users/jnmclarty","html_url":"https://github.com/jnmclarty","followers_url":"https://api.github.com/users/jnmclarty/followers","following_url":"https://api.github.com/users/jnmclarty/following{/other_user}","gists_url":"https://api.github.com/users/jnmclarty/gists{/gist_id}","starred_url":"https://api.github.com/users/jnmclarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnmclarty/subscriptions","organizations_url":"https://api.github.com/users/jnmclarty/orgs","repos_url":"https://api.github.com/users/jnmclarty/repos","events_url":"https://api.github.com/users/jnmclarty/events{/privacy}","received_events_url":"https://api.github.com/users/jnmclarty/received_events","type":"User","site_admin":false},"created_at":"2015-06-25T02:33:54Z","updated_at":"2015-06-25T02:33:54Z","body":"I started trying to use a few of the functions, using my first implementation method, and it started to feel akward, using parameters for passing the slice object.\r\n\r\n`within_range(df, slice(-1), items)` or something akin to `within_range(df, items, sl=slice(-1))`\r\n\r\n...so, I created an OO approach.  Both 1bc608b and 30ef13d pass `test_within_range`, and both have strengths/weaknesses.  \r\n\r\nI'm going to sleep on it...let me know if you have any better ideas, for the API.\r\n\r\n"}}