{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/presto/pulls/comments/33392519","id":33392519,"diff_hunk":"@@ -67,110 +67,101 @@\n                     </plugin>\n                     <!-- Build presto-server rpm using the untarred artifacts -->\n                     <plugin>\n-                        <groupId>org.codehaus.mojo</groupId>\n-                        <artifactId>rpm-maven-plugin</artifactId>\n-                        <version>2.1.2</version>\n-                        <executions>\n-                            <execution>\n-                                <id>generate-rpm</id>\n-                                <goals>\n-                                    <goal>rpm</goal>\n-                                </goals>\n-                            </execution>\n-                        </executions>\n-                        <configuration>\n-                            <name>presto</name>\n-                            <version>${project.version}</version>\n-                            <release>1.0</release>\n-                            <group>Applications</group>\n-                            <description>Presto Server RPM Package.</description>\n-                            <needarch>x86_64</needarch>\n-                            <requires>\n-                                <require>python &gt;= 2.4</require>\n-                            </requires>\n-                            <mappings>\n-                                <mapping>\n-                                    <!-- This should go to /usr/bin eventually. But that needs modifying launcher.py in\n-                                    airlift, to have a configurable option for install_path -->\n-                                    <directory>/usr/lib/presto/bin</directory>\n-                                    <!-- make sure laucher scripts are executable -->\n-                                    <filemode>755</filemode>\n-                                    <sources>\n-                                        <source>\n-                                            <location>${project.build.directory}/${server.tar.package}/bin\n-                                            </location>\n-                                        </source>\n-                                    </sources>\n-                                </mapping>\n-                                <mapping>\n-                                    <directory>/etc/rc.d/init.d</directory>\n-                                    <!-- make sure init.d scripts are executable -->\n-                                    <filemode>755</filemode>\n-                                    <sources>\n-                                        <source>\n-                                            <location>src/main/resources/dist/etc/rc.d/init.d</location>\n-                                        </source>\n-                                    </sources>\n-                                </mapping>\n-                                <mapping>\n-                                    <!-- This should go to just /usr/lib/presto eventually. But that needs modifying\n-                                    launcher.py in airlift, to have a configurable option for install_path -->\n-                                    <directory>/usr/lib/presto/lib</directory>\n-                                    <sources>\n-                                        <source>\n-                                            <location>${project.build.directory}/${server.tar.package}/lib\n-                                            </location>\n-                                        </source>\n-                                    </sources>\n-                                </mapping>\n-                                <mapping>\n-                                    <directory>/usr/lib/presto/lib/plugin</directory>\n-                                    <sources>\n-                                        <source>\n-                                            <location>\n-                                                ${project.build.directory}/${server.tar.package}/plugin\n-                                            </location>\n-                                        </source>\n-                                    </sources>\n-                                </mapping>\n-                                <mapping>\n-                                    <directory>/etc/presto</directory>\n-                                    <sources>\n-                                        <source>\n-                                            <location>src/main/resources/dist/config</location>\n-                                        </source>\n-                                    </sources>\n-                                </mapping>\n-                                <mapping>\n-                                    <directory>/usr/shared/doc/presto</directory>\n-                                    <sources>\n-                                        <source>\n-                                            <location>${project.build.directory}/${server.tar.package}\n-                                            </location>\n-                                            <!-- Just include Presto's README for now.-->\n+                        <groupId>uk.co.codezen</groupId>\n+                        <artifactId>redlinerpm-maven-plugin</artifactId>\n+                        <version>1.0</version>\n+                        <extensions>true</extensions>\n+\n+\t\t\t            <configuration>\n+                            <performCheckingForExtraFiles>false</performCheckingForExtraFiles>\n+\n+                            <packages>\n+                                <package>\n+                                    <name>presto</name>\n+                                    <version>${project.version}</version>\n+                                    <release>1.1</release>","path":"presto-server-rpm/pom.xml","position":124,"original_position":124,"commit_id":"f1bd4ecfa73911ac49237b56d81bfef0bf031e1d","original_commit_id":"f1bd4ecfa73911ac49237b56d81bfef0bf031e1d","user":{"login":"martint","id":14387,"avatar_url":"https://avatars.githubusercontent.com/u/14387?v=3","gravatar_id":"","url":"https://api.github.com/users/martint","html_url":"https://github.com/martint","followers_url":"https://api.github.com/users/martint/followers","following_url":"https://api.github.com/users/martint/following{/other_user}","gists_url":"https://api.github.com/users/martint/gists{/gist_id}","starred_url":"https://api.github.com/users/martint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martint/subscriptions","organizations_url":"https://api.github.com/users/martint/orgs","repos_url":"https://api.github.com/users/martint/repos","events_url":"https://api.github.com/users/martint/events{/privacy}","received_events_url":"https://api.github.com/users/martint/received_events","type":"User","site_admin":false},"body":"What does the `release` option do?","created_at":"2015-06-26T20:26:28Z","updated_at":"2015-06-26T20:26:28Z","html_url":"https://github.com/facebook/presto/pull/3162#discussion_r33392519","pull_request_url":"https://api.github.com/repos/facebook/presto/pulls/3162","_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments/33392519"},"html":{"href":"https://github.com/facebook/presto/pull/3162#discussion_r33392519"},"pull_request":{"href":"https://api.github.com/repos/facebook/presto/pulls/3162"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/presto/pulls/3162","id":38453979,"html_url":"https://github.com/facebook/presto/pull/3162","diff_url":"https://github.com/facebook/presto/pull/3162.diff","patch_url":"https://github.com/facebook/presto/pull/3162.patch","issue_url":"https://api.github.com/repos/facebook/presto/issues/3162","number":3162,"state":"open","locked":false,"title":"Build Presto server RPM in an OS-agnostic way","user":{"login":"cawallin","id":3652644,"avatar_url":"https://avatars.githubusercontent.com/u/3652644?v=3","gravatar_id":"","url":"https://api.github.com/users/cawallin","html_url":"https://github.com/cawallin","followers_url":"https://api.github.com/users/cawallin/followers","following_url":"https://api.github.com/users/cawallin/following{/other_user}","gists_url":"https://api.github.com/users/cawallin/gists{/gist_id}","starred_url":"https://api.github.com/users/cawallin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cawallin/subscriptions","organizations_url":"https://api.github.com/users/cawallin/orgs","repos_url":"https://api.github.com/users/cawallin/repos","events_url":"https://api.github.com/users/cawallin/events{/privacy}","received_events_url":"https://api.github.com/users/cawallin/received_events","type":"User","site_admin":false},"body":"Use redlinerpm-maven-plugin --\r\nhttps://github.com/spaulg/redlinerpm-maven-plugin/ -- to build the\r\nPresto server RPM, so that it can be built by both Linux and OSX with\r\nno additional libraries. This plugin uses the redline library\r\n(https://github.com/craigwblake/redline), a pure Java RPM building\r\nlibrary.\r\n\r\nChange the Maven profile so that the RPM builds every time.\r\n\r\nTest Plan: mvn clean install, on both Linux and Mac OSX","created_at":"2015-06-24T15:23:25Z","updated_at":"2015-06-26T20:26:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3936308074be28021ca70cb83b821b858dd8b9e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/presto/pulls/3162/commits","review_comments_url":"https://api.github.com/repos/facebook/presto/pulls/3162/comments","review_comment_url":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/presto/issues/3162/comments","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/f1bd4ecfa73911ac49237b56d81bfef0bf031e1d","head":{"label":"TeradataCenterForHadoop:os-agnostic-rpm","ref":"os-agnostic-rpm","sha":"f1bd4ecfa73911ac49237b56d81bfef0bf031e1d","user":{"login":"TeradataCenterForHadoop","id":12552963,"avatar_url":"https://avatars.githubusercontent.com/u/12552963?v=3","gravatar_id":"","url":"https://api.github.com/users/TeradataCenterForHadoop","html_url":"https://github.com/TeradataCenterForHadoop","followers_url":"https://api.github.com/users/TeradataCenterForHadoop/followers","following_url":"https://api.github.com/users/TeradataCenterForHadoop/following{/other_user}","gists_url":"https://api.github.com/users/TeradataCenterForHadoop/gists{/gist_id}","starred_url":"https://api.github.com/users/TeradataCenterForHadoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeradataCenterForHadoop/subscriptions","organizations_url":"https://api.github.com/users/TeradataCenterForHadoop/orgs","repos_url":"https://api.github.com/users/TeradataCenterForHadoop/repos","events_url":"https://api.github.com/users/TeradataCenterForHadoop/events{/privacy}","received_events_url":"https://api.github.com/users/TeradataCenterForHadoop/received_events","type":"Organization","site_admin":false},"repo":{"id":36903368,"name":"presto","full_name":"TeradataCenterForHadoop/presto","owner":{"login":"TeradataCenterForHadoop","id":12552963,"avatar_url":"https://avatars.githubusercontent.com/u/12552963?v=3","gravatar_id":"","url":"https://api.github.com/users/TeradataCenterForHadoop","html_url":"https://github.com/TeradataCenterForHadoop","followers_url":"https://api.github.com/users/TeradataCenterForHadoop/followers","following_url":"https://api.github.com/users/TeradataCenterForHadoop/following{/other_user}","gists_url":"https://api.github.com/users/TeradataCenterForHadoop/gists{/gist_id}","starred_url":"https://api.github.com/users/TeradataCenterForHadoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeradataCenterForHadoop/subscriptions","organizations_url":"https://api.github.com/users/TeradataCenterForHadoop/orgs","repos_url":"https://api.github.com/users/TeradataCenterForHadoop/repos","events_url":"https://api.github.com/users/TeradataCenterForHadoop/events{/privacy}","received_events_url":"https://api.github.com/users/TeradataCenterForHadoop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TeradataCenterForHadoop/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":true,"url":"https://api.github.com/repos/TeradataCenterForHadoop/presto","forks_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/forks","keys_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/teams","hooks_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/hooks","issue_events_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/issues/events{/number}","events_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/events","assignees_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/assignees{/user}","branches_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/branches{/branch}","tags_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/tags","blobs_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/languages","stargazers_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/stargazers","contributors_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/contributors","subscribers_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/subscribers","subscription_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/subscription","commits_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/contents/{+path}","compare_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/merges","archive_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/downloads","issues_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/issues{/number}","pulls_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/labels{/name}","releases_url":"https://api.github.com/repos/TeradataCenterForHadoop/presto/releases{/id}","created_at":"2015-06-05T00:38:37Z","updated_at":"2015-06-05T00:38:45Z","pushed_at":"2015-06-26T18:45:18Z","git_url":"git://github.com/TeradataCenterForHadoop/presto.git","ssh_url":"git@github.com:TeradataCenterForHadoop/presto.git","clone_url":"https://github.com/TeradataCenterForHadoop/presto.git","svn_url":"https://github.com/TeradataCenterForHadoop/presto","homepage":"https://prestodb.io","size":44386,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"31dec7eb085494f3e20a4d9ec5c208aae14cb756","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"facebook/presto","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":false,"url":"https://api.github.com/repos/facebook/presto","forks_url":"https://api.github.com/repos/facebook/presto/forks","keys_url":"https://api.github.com/repos/facebook/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/presto/teams","hooks_url":"https://api.github.com/repos/facebook/presto/hooks","issue_events_url":"https://api.github.com/repos/facebook/presto/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/presto/events","assignees_url":"https://api.github.com/repos/facebook/presto/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/presto/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/presto/tags","blobs_url":"https://api.github.com/repos/facebook/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/presto/languages","stargazers_url":"https://api.github.com/repos/facebook/presto/stargazers","contributors_url":"https://api.github.com/repos/facebook/presto/contributors","subscribers_url":"https://api.github.com/repos/facebook/presto/subscribers","subscription_url":"https://api.github.com/repos/facebook/presto/subscription","commits_url":"https://api.github.com/repos/facebook/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/presto/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/presto/merges","archive_url":"https://api.github.com/repos/facebook/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/presto/downloads","issues_url":"https://api.github.com/repos/facebook/presto/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/presto/labels{/name}","releases_url":"https://api.github.com/repos/facebook/presto/releases{/id}","created_at":"2012-08-09T01:03:37Z","updated_at":"2015-06-26T18:40:30Z","pushed_at":"2015-06-26T20:15:44Z","git_url":"git://github.com/facebook/presto.git","ssh_url":"git@github.com:facebook/presto.git","clone_url":"https://github.com/facebook/presto.git","svn_url":"https://github.com/facebook/presto","homepage":"https://prestodb.io","size":91143,"stargazers_count":3587,"watchers_count":3587,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":874,"mirror_url":null,"open_issues_count":275,"forks":874,"open_issues":275,"watchers":3587,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/3162"},"html":{"href":"https://github.com/facebook/presto/pull/3162"},"issue":{"href":"https://api.github.com/repos/facebook/presto/issues/3162"},"comments":{"href":"https://api.github.com/repos/facebook/presto/issues/3162/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/presto/pulls/3162/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/presto/pulls/3162/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/presto/statuses/f1bd4ecfa73911ac49237b56d81bfef0bf031e1d"}}}}