{"action":"opened","number":88,"pull_request":{"url":"https://api.github.com/repos/GEWIS/gewisweb/pulls/88","id":29438737,"html_url":"https://github.com/GEWIS/gewisweb/pull/88","diff_url":"https://github.com/GEWIS/gewisweb/pull/88.diff","patch_url":"https://github.com/GEWIS/gewisweb/pull/88.patch","issue_url":"https://api.github.com/repos/GEWIS/gewisweb/issues/88","number":88,"state":"open","locked":false,"title":"ACL update/revision Activities/small issue fix in company review","user":{"login":"choutha","id":6672220,"avatar_url":"https://avatars.githubusercontent.com/u/6672220?v=3","gravatar_id":"","url":"https://api.github.com/users/choutha","html_url":"https://github.com/choutha","followers_url":"https://api.github.com/users/choutha/followers","following_url":"https://api.github.com/users/choutha/following{/other_user}","gists_url":"https://api.github.com/users/choutha/gists{/gist_id}","starred_url":"https://api.github.com/users/choutha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choutha/subscriptions","organizations_url":"https://api.github.com/users/choutha/orgs","repos_url":"https://api.github.com/users/choutha/repos","events_url":"https://api.github.com/users/choutha/events{/privacy}","received_events_url":"https://api.github.com/users/choutha/received_events","type":"User","site_admin":false},"body":"added version of Activity --> not that important to rest of project. This is a simple version with key functionallity\r\n\r\nchanged isAllowed function in AbstractAclService --> important since it is about general authorization. Changed the method such that it checks the actual roles instead of the user object against several role strings\r\n\r\nchanged the approver variable in CompanyReview --> this was giving errors when doctrine was creating the database. Now changed the relation to a OneToMany relation as it should be (discussed with Geert)","created_at":"2015-02-17T12:37:55Z","updated_at":"2015-02-17T12:37:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GEWIS/gewisweb/pulls/88/commits","review_comments_url":"https://api.github.com/repos/GEWIS/gewisweb/pulls/88/comments","review_comment_url":"https://api.github.com/repos/GEWIS/gewisweb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GEWIS/gewisweb/issues/88/comments","statuses_url":"https://api.github.com/repos/GEWIS/gewisweb/statuses/0ac00fda934b4f4004396cd5c44fddb7b2d95f5f","head":{"label":"choutha:master","ref":"master","sha":"0ac00fda934b4f4004396cd5c44fddb7b2d95f5f","user":{"login":"choutha","id":6672220,"avatar_url":"https://avatars.githubusercontent.com/u/6672220?v=3","gravatar_id":"","url":"https://api.github.com/users/choutha","html_url":"https://github.com/choutha","followers_url":"https://api.github.com/users/choutha/followers","following_url":"https://api.github.com/users/choutha/following{/other_user}","gists_url":"https://api.github.com/users/choutha/gists{/gist_id}","starred_url":"https://api.github.com/users/choutha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choutha/subscriptions","organizations_url":"https://api.github.com/users/choutha/orgs","repos_url":"https://api.github.com/users/choutha/repos","events_url":"https://api.github.com/users/choutha/events{/privacy}","received_events_url":"https://api.github.com/users/choutha/received_events","type":"User","site_admin":false},"repo":{"id":16803233,"name":"gewisweb","full_name":"choutha/gewisweb","owner":{"login":"choutha","id":6672220,"avatar_url":"https://avatars.githubusercontent.com/u/6672220?v=3","gravatar_id":"","url":"https://api.github.com/users/choutha","html_url":"https://github.com/choutha","followers_url":"https://api.github.com/users/choutha/followers","following_url":"https://api.github.com/users/choutha/following{/other_user}","gists_url":"https://api.github.com/users/choutha/gists{/gist_id}","starred_url":"https://api.github.com/users/choutha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choutha/subscriptions","organizations_url":"https://api.github.com/users/choutha/orgs","repos_url":"https://api.github.com/users/choutha/repos","events_url":"https://api.github.com/users/choutha/events{/privacy}","received_events_url":"https://api.github.com/users/choutha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/choutha/gewisweb","description":"GEWIS Website","fork":true,"url":"https://api.github.com/repos/choutha/gewisweb","forks_url":"https://api.github.com/repos/choutha/gewisweb/forks","keys_url":"https://api.github.com/repos/choutha/gewisweb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/choutha/gewisweb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/choutha/gewisweb/teams","hooks_url":"https://api.github.com/repos/choutha/gewisweb/hooks","issue_events_url":"https://api.github.com/repos/choutha/gewisweb/issues/events{/number}","events_url":"https://api.github.com/repos/choutha/gewisweb/events","assignees_url":"https://api.github.com/repos/choutha/gewisweb/assignees{/user}","branches_url":"https://api.github.com/repos/choutha/gewisweb/branches{/branch}","tags_url":"https://api.github.com/repos/choutha/gewisweb/tags","blobs_url":"https://api.github.com/repos/choutha/gewisweb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/choutha/gewisweb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/choutha/gewisweb/git/refs{/sha}","trees_url":"https://api.github.com/repos/choutha/gewisweb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/choutha/gewisweb/statuses/{sha}","languages_url":"https://api.github.com/repos/choutha/gewisweb/languages","stargazers_url":"https://api.github.com/repos/choutha/gewisweb/stargazers","contributors_url":"https://api.github.com/repos/choutha/gewisweb/contributors","subscribers_url":"https://api.github.com/repos/choutha/gewisweb/subscribers","subscription_url":"https://api.github.com/repos/choutha/gewisweb/subscription","commits_url":"https://api.github.com/repos/choutha/gewisweb/commits{/sha}","git_commits_url":"https://api.github.com/repos/choutha/gewisweb/git/commits{/sha}","comments_url":"https://api.github.com/repos/choutha/gewisweb/comments{/number}","issue_comment_url":"https://api.github.com/repos/choutha/gewisweb/issues/comments/{number}","contents_url":"https://api.github.com/repos/choutha/gewisweb/contents/{+path}","compare_url":"https://api.github.com/repos/choutha/gewisweb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/choutha/gewisweb/merges","archive_url":"https://api.github.com/repos/choutha/gewisweb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/choutha/gewisweb/downloads","issues_url":"https://api.github.com/repos/choutha/gewisweb/issues{/number}","pulls_url":"https://api.github.com/repos/choutha/gewisweb/pulls{/number}","milestones_url":"https://api.github.com/repos/choutha/gewisweb/milestones{/number}","notifications_url":"https://api.github.com/repos/choutha/gewisweb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/choutha/gewisweb/labels{/name}","releases_url":"https://api.github.com/repos/choutha/gewisweb/releases{/id}","created_at":"2014-02-13T13:12:35Z","updated_at":"2015-02-17T12:33:50Z","pushed_at":"2015-02-17T12:33:50Z","git_url":"git://github.com/choutha/gewisweb.git","ssh_url":"git@github.com:choutha/gewisweb.git","clone_url":"https://github.com/choutha/gewisweb.git","svn_url":"https://github.com/choutha/gewisweb","homepage":null,"size":1342,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GEWIS:master","ref":"master","sha":"c384b9624c52bc457cf5d2cfa65f38fb74962d3b","user":{"login":"GEWIS","id":1815510,"avatar_url":"https://avatars.githubusercontent.com/u/1815510?v=3","gravatar_id":"","url":"https://api.github.com/users/GEWIS","html_url":"https://github.com/GEWIS","followers_url":"https://api.github.com/users/GEWIS/followers","following_url":"https://api.github.com/users/GEWIS/following{/other_user}","gists_url":"https://api.github.com/users/GEWIS/gists{/gist_id}","starred_url":"https://api.github.com/users/GEWIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GEWIS/subscriptions","organizations_url":"https://api.github.com/users/GEWIS/orgs","repos_url":"https://api.github.com/users/GEWIS/repos","events_url":"https://api.github.com/users/GEWIS/events{/privacy}","received_events_url":"https://api.github.com/users/GEWIS/received_events","type":"Organization","site_admin":false},"repo":{"id":16512277,"name":"gewisweb","full_name":"GEWIS/gewisweb","owner":{"login":"GEWIS","id":1815510,"avatar_url":"https://avatars.githubusercontent.com/u/1815510?v=3","gravatar_id":"","url":"https://api.github.com/users/GEWIS","html_url":"https://github.com/GEWIS","followers_url":"https://api.github.com/users/GEWIS/followers","following_url":"https://api.github.com/users/GEWIS/following{/other_user}","gists_url":"https://api.github.com/users/GEWIS/gists{/gist_id}","starred_url":"https://api.github.com/users/GEWIS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GEWIS/subscriptions","organizations_url":"https://api.github.com/users/GEWIS/orgs","repos_url":"https://api.github.com/users/GEWIS/repos","events_url":"https://api.github.com/users/GEWIS/events{/privacy}","received_events_url":"https://api.github.com/users/GEWIS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GEWIS/gewisweb","description":"GEWIS Website","fork":false,"url":"https://api.github.com/repos/GEWIS/gewisweb","forks_url":"https://api.github.com/repos/GEWIS/gewisweb/forks","keys_url":"https://api.github.com/repos/GEWIS/gewisweb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GEWIS/gewisweb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GEWIS/gewisweb/teams","hooks_url":"https://api.github.com/repos/GEWIS/gewisweb/hooks","issue_events_url":"https://api.github.com/repos/GEWIS/gewisweb/issues/events{/number}","events_url":"https://api.github.com/repos/GEWIS/gewisweb/events","assignees_url":"https://api.github.com/repos/GEWIS/gewisweb/assignees{/user}","branches_url":"https://api.github.com/repos/GEWIS/gewisweb/branches{/branch}","tags_url":"https://api.github.com/repos/GEWIS/gewisweb/tags","blobs_url":"https://api.github.com/repos/GEWIS/gewisweb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GEWIS/gewisweb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GEWIS/gewisweb/git/refs{/sha}","trees_url":"https://api.github.com/repos/GEWIS/gewisweb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GEWIS/gewisweb/statuses/{sha}","languages_url":"https://api.github.com/repos/GEWIS/gewisweb/languages","stargazers_url":"https://api.github.com/repos/GEWIS/gewisweb/stargazers","contributors_url":"https://api.github.com/repos/GEWIS/gewisweb/contributors","subscribers_url":"https://api.github.com/repos/GEWIS/gewisweb/subscribers","subscription_url":"https://api.github.com/repos/GEWIS/gewisweb/subscription","commits_url":"https://api.github.com/repos/GEWIS/gewisweb/commits{/sha}","git_commits_url":"https://api.github.com/repos/GEWIS/gewisweb/git/commits{/sha}","comments_url":"https://api.github.com/repos/GEWIS/gewisweb/comments{/number}","issue_comment_url":"https://api.github.com/repos/GEWIS/gewisweb/issues/comments/{number}","contents_url":"https://api.github.com/repos/GEWIS/gewisweb/contents/{+path}","compare_url":"https://api.github.com/repos/GEWIS/gewisweb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GEWIS/gewisweb/merges","archive_url":"https://api.github.com/repos/GEWIS/gewisweb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GEWIS/gewisweb/downloads","issues_url":"https://api.github.com/repos/GEWIS/gewisweb/issues{/number}","pulls_url":"https://api.github.com/repos/GEWIS/gewisweb/pulls{/number}","milestones_url":"https://api.github.com/repos/GEWIS/gewisweb/milestones{/number}","notifications_url":"https://api.github.com/repos/GEWIS/gewisweb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GEWIS/gewisweb/labels{/name}","releases_url":"https://api.github.com/repos/GEWIS/gewisweb/releases{/id}","created_at":"2014-02-04T13:22:05Z","updated_at":"2015-01-23T13:15:41Z","pushed_at":"2015-01-23T13:15:41Z","git_url":"git://github.com/GEWIS/gewisweb.git","ssh_url":"git@github.com:GEWIS/gewisweb.git","clone_url":"https://github.com/GEWIS/gewisweb.git","svn_url":"https://github.com/GEWIS/gewisweb","homepage":null,"size":1929,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":43,"forks":10,"open_issues":43,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GEWIS/gewisweb/pulls/88"},"html":{"href":"https://github.com/GEWIS/gewisweb/pull/88"},"issue":{"href":"https://api.github.com/repos/GEWIS/gewisweb/issues/88"},"comments":{"href":"https://api.github.com/repos/GEWIS/gewisweb/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/GEWIS/gewisweb/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/GEWIS/gewisweb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GEWIS/gewisweb/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/GEWIS/gewisweb/statuses/0ac00fda934b4f4004396cd5c44fddb7b2d95f5f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":24,"additions":1138,"deletions":97,"changed_files":22}}