{"action":"opened","number":262,"pull_request":{"url":"https://api.github.com/repos/vulcand/vulcand/pulls/262","id":51406913,"html_url":"https://github.com/vulcand/vulcand/pull/262","diff_url":"https://github.com/vulcand/vulcand/pull/262.diff","patch_url":"https://github.com/vulcand/vulcand/pull/262.patch","issue_url":"https://api.github.com/repos/vulcand/vulcand/issues/262","number":262,"state":"open","locked":false,"title":"Use correct waitIndex for Etcd engine Watch","user":{"login":"wrotki","id":4007980,"avatar_url":"https://avatars.githubusercontent.com/u/4007980?v=3","gravatar_id":"","url":"https://api.github.com/users/wrotki","html_url":"https://github.com/wrotki","followers_url":"https://api.github.com/users/wrotki/followers","following_url":"https://api.github.com/users/wrotki/following{/other_user}","gists_url":"https://api.github.com/users/wrotki/gists{/gist_id}","starred_url":"https://api.github.com/users/wrotki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrotki/subscriptions","organizations_url":"https://api.github.com/users/wrotki/orgs","repos_url":"https://api.github.com/users/wrotki/repos","events_url":"https://api.github.com/users/wrotki/events{/privacy}","received_events_url":"https://api.github.com/users/wrotki/received_events","type":"User","site_admin":false},"body":"    Until this change it was watching after just root node's\r\n    ModifiedIndex, while the Watch was recursive, i.e. the real change's\r\n    index might've been later. It was leading to errors manifesting in logs as follows:\r\n\r\n    Nov 18 22:10:46.148 router ERROR PID:1\r\n    [log.go:131:...Godeps/_workspace/src/github.com/mailgun/log.Errorf] unexpected error:\r\n    401: The event in requested index is outdated and cleared\r\n    (the requested history has been cleared [1116/1039]) [2115], stop watching\r\n\r\n    ...and it was causing the router restart, leaking socket fd's in the process.\r\n\r\nSigned-off-by: Mariusz Borsa mborsa@polyverse.io","created_at":"2015-11-20T20:53:21Z","updated_at":"2015-11-20T20:53:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vulcand/vulcand/pulls/262/commits","review_comments_url":"https://api.github.com/repos/vulcand/vulcand/pulls/262/comments","review_comment_url":"https://api.github.com/repos/vulcand/vulcand/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vulcand/vulcand/issues/262/comments","statuses_url":"https://api.github.com/repos/vulcand/vulcand/statuses/cf1b997069013d44d599bfba2ff656c8ab3a1720","head":{"label":"wrotki:waitindex_fix","ref":"waitindex_fix","sha":"cf1b997069013d44d599bfba2ff656c8ab3a1720","user":{"login":"wrotki","id":4007980,"avatar_url":"https://avatars.githubusercontent.com/u/4007980?v=3","gravatar_id":"","url":"https://api.github.com/users/wrotki","html_url":"https://github.com/wrotki","followers_url":"https://api.github.com/users/wrotki/followers","following_url":"https://api.github.com/users/wrotki/following{/other_user}","gists_url":"https://api.github.com/users/wrotki/gists{/gist_id}","starred_url":"https://api.github.com/users/wrotki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrotki/subscriptions","organizations_url":"https://api.github.com/users/wrotki/orgs","repos_url":"https://api.github.com/users/wrotki/repos","events_url":"https://api.github.com/users/wrotki/events{/privacy}","received_events_url":"https://api.github.com/users/wrotki/received_events","type":"User","site_admin":false},"repo":{"id":46531517,"name":"vulcand","full_name":"wrotki/vulcand","owner":{"login":"wrotki","id":4007980,"avatar_url":"https://avatars.githubusercontent.com/u/4007980?v=3","gravatar_id":"","url":"https://api.github.com/users/wrotki","html_url":"https://github.com/wrotki","followers_url":"https://api.github.com/users/wrotki/followers","following_url":"https://api.github.com/users/wrotki/following{/other_user}","gists_url":"https://api.github.com/users/wrotki/gists{/gist_id}","starred_url":"https://api.github.com/users/wrotki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrotki/subscriptions","organizations_url":"https://api.github.com/users/wrotki/orgs","repos_url":"https://api.github.com/users/wrotki/repos","events_url":"https://api.github.com/users/wrotki/events{/privacy}","received_events_url":"https://api.github.com/users/wrotki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wrotki/vulcand","description":" Programmatic load balancer backed by Etcd","fork":true,"url":"https://api.github.com/repos/wrotki/vulcand","forks_url":"https://api.github.com/repos/wrotki/vulcand/forks","keys_url":"https://api.github.com/repos/wrotki/vulcand/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wrotki/vulcand/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wrotki/vulcand/teams","hooks_url":"https://api.github.com/repos/wrotki/vulcand/hooks","issue_events_url":"https://api.github.com/repos/wrotki/vulcand/issues/events{/number}","events_url":"https://api.github.com/repos/wrotki/vulcand/events","assignees_url":"https://api.github.com/repos/wrotki/vulcand/assignees{/user}","branches_url":"https://api.github.com/repos/wrotki/vulcand/branches{/branch}","tags_url":"https://api.github.com/repos/wrotki/vulcand/tags","blobs_url":"https://api.github.com/repos/wrotki/vulcand/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wrotki/vulcand/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wrotki/vulcand/git/refs{/sha}","trees_url":"https://api.github.com/repos/wrotki/vulcand/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wrotki/vulcand/statuses/{sha}","languages_url":"https://api.github.com/repos/wrotki/vulcand/languages","stargazers_url":"https://api.github.com/repos/wrotki/vulcand/stargazers","contributors_url":"https://api.github.com/repos/wrotki/vulcand/contributors","subscribers_url":"https://api.github.com/repos/wrotki/vulcand/subscribers","subscription_url":"https://api.github.com/repos/wrotki/vulcand/subscription","commits_url":"https://api.github.com/repos/wrotki/vulcand/commits{/sha}","git_commits_url":"https://api.github.com/repos/wrotki/vulcand/git/commits{/sha}","comments_url":"https://api.github.com/repos/wrotki/vulcand/comments{/number}","issue_comment_url":"https://api.github.com/repos/wrotki/vulcand/issues/comments{/number}","contents_url":"https://api.github.com/repos/wrotki/vulcand/contents/{+path}","compare_url":"https://api.github.com/repos/wrotki/vulcand/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wrotki/vulcand/merges","archive_url":"https://api.github.com/repos/wrotki/vulcand/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wrotki/vulcand/downloads","issues_url":"https://api.github.com/repos/wrotki/vulcand/issues{/number}","pulls_url":"https://api.github.com/repos/wrotki/vulcand/pulls{/number}","milestones_url":"https://api.github.com/repos/wrotki/vulcand/milestones{/number}","notifications_url":"https://api.github.com/repos/wrotki/vulcand/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wrotki/vulcand/labels{/name}","releases_url":"https://api.github.com/repos/wrotki/vulcand/releases{/id}","created_at":"2015-11-20T01:34:54Z","updated_at":"2015-11-20T01:34:55Z","pushed_at":"2015-11-20T20:52:37Z","git_url":"git://github.com/wrotki/vulcand.git","ssh_url":"git@github.com:wrotki/vulcand.git","clone_url":"https://github.com/wrotki/vulcand.git","svn_url":"https://github.com/wrotki/vulcand","homepage":"https://vulcand.io","size":1602,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vulcand:master","ref":"master","sha":"40bd3c38bf5a52f708f18acc39782475aa6e9bb2","user":{"login":"vulcand","id":15367115,"avatar_url":"https://avatars.githubusercontent.com/u/15367115?v=3","gravatar_id":"","url":"https://api.github.com/users/vulcand","html_url":"https://github.com/vulcand","followers_url":"https://api.github.com/users/vulcand/followers","following_url":"https://api.github.com/users/vulcand/following{/other_user}","gists_url":"https://api.github.com/users/vulcand/gists{/gist_id}","starred_url":"https://api.github.com/users/vulcand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vulcand/subscriptions","organizations_url":"https://api.github.com/users/vulcand/orgs","repos_url":"https://api.github.com/users/vulcand/repos","events_url":"https://api.github.com/users/vulcand/events{/privacy}","received_events_url":"https://api.github.com/users/vulcand/received_events","type":"Organization","site_admin":false},"repo":{"id":18165661,"name":"vulcand","full_name":"vulcand/vulcand","owner":{"login":"vulcand","id":15367115,"avatar_url":"https://avatars.githubusercontent.com/u/15367115?v=3","gravatar_id":"","url":"https://api.github.com/users/vulcand","html_url":"https://github.com/vulcand","followers_url":"https://api.github.com/users/vulcand/followers","following_url":"https://api.github.com/users/vulcand/following{/other_user}","gists_url":"https://api.github.com/users/vulcand/gists{/gist_id}","starred_url":"https://api.github.com/users/vulcand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vulcand/subscriptions","organizations_url":"https://api.github.com/users/vulcand/orgs","repos_url":"https://api.github.com/users/vulcand/repos","events_url":"https://api.github.com/users/vulcand/events{/privacy}","received_events_url":"https://api.github.com/users/vulcand/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vulcand/vulcand","description":" Programmatic load balancer backed by Etcd","fork":false,"url":"https://api.github.com/repos/vulcand/vulcand","forks_url":"https://api.github.com/repos/vulcand/vulcand/forks","keys_url":"https://api.github.com/repos/vulcand/vulcand/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vulcand/vulcand/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vulcand/vulcand/teams","hooks_url":"https://api.github.com/repos/vulcand/vulcand/hooks","issue_events_url":"https://api.github.com/repos/vulcand/vulcand/issues/events{/number}","events_url":"https://api.github.com/repos/vulcand/vulcand/events","assignees_url":"https://api.github.com/repos/vulcand/vulcand/assignees{/user}","branches_url":"https://api.github.com/repos/vulcand/vulcand/branches{/branch}","tags_url":"https://api.github.com/repos/vulcand/vulcand/tags","blobs_url":"https://api.github.com/repos/vulcand/vulcand/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vulcand/vulcand/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vulcand/vulcand/git/refs{/sha}","trees_url":"https://api.github.com/repos/vulcand/vulcand/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vulcand/vulcand/statuses/{sha}","languages_url":"https://api.github.com/repos/vulcand/vulcand/languages","stargazers_url":"https://api.github.com/repos/vulcand/vulcand/stargazers","contributors_url":"https://api.github.com/repos/vulcand/vulcand/contributors","subscribers_url":"https://api.github.com/repos/vulcand/vulcand/subscribers","subscription_url":"https://api.github.com/repos/vulcand/vulcand/subscription","commits_url":"https://api.github.com/repos/vulcand/vulcand/commits{/sha}","git_commits_url":"https://api.github.com/repos/vulcand/vulcand/git/commits{/sha}","comments_url":"https://api.github.com/repos/vulcand/vulcand/comments{/number}","issue_comment_url":"https://api.github.com/repos/vulcand/vulcand/issues/comments{/number}","contents_url":"https://api.github.com/repos/vulcand/vulcand/contents/{+path}","compare_url":"https://api.github.com/repos/vulcand/vulcand/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vulcand/vulcand/merges","archive_url":"https://api.github.com/repos/vulcand/vulcand/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vulcand/vulcand/downloads","issues_url":"https://api.github.com/repos/vulcand/vulcand/issues{/number}","pulls_url":"https://api.github.com/repos/vulcand/vulcand/pulls{/number}","milestones_url":"https://api.github.com/repos/vulcand/vulcand/milestones{/number}","notifications_url":"https://api.github.com/repos/vulcand/vulcand/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vulcand/vulcand/labels{/name}","releases_url":"https://api.github.com/repos/vulcand/vulcand/releases{/id}","created_at":"2014-03-27T05:42:43Z","updated_at":"2015-11-19T22:00:45Z","pushed_at":"2015-10-31T18:09:23Z","git_url":"git://github.com/vulcand/vulcand.git","ssh_url":"git@github.com:vulcand/vulcand.git","clone_url":"https://github.com/vulcand/vulcand.git","svn_url":"https://github.com/vulcand/vulcand","homepage":"https://vulcand.io","size":3583,"stargazers_count":1648,"watchers_count":1648,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":80,"forks":108,"open_issues":80,"watchers":1648,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vulcand/vulcand/pulls/262"},"html":{"href":"https://github.com/vulcand/vulcand/pull/262"},"issue":{"href":"https://api.github.com/repos/vulcand/vulcand/issues/262"},"comments":{"href":"https://api.github.com/repos/vulcand/vulcand/issues/262/comments"},"review_comments":{"href":"https://api.github.com/repos/vulcand/vulcand/pulls/262/comments"},"review_comment":{"href":"https://api.github.com/repos/vulcand/vulcand/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vulcand/vulcand/pulls/262/commits"},"statuses":{"href":"https://api.github.com/repos/vulcand/vulcand/statuses/cf1b997069013d44d599bfba2ff656c8ab3a1720"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}