{"action":"created","issue":{"url":"https://api.github.com/repos/davidchappelle/AutobahnCpp/issues/8","labels_url":"https://api.github.com/repos/davidchappelle/AutobahnCpp/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/davidchappelle/AutobahnCpp/issues/8/comments","events_url":"https://api.github.com/repos/davidchappelle/AutobahnCpp/issues/8/events","html_url":"https://github.com/davidchappelle/AutobahnCpp/pull/8","id":93630472,"number":8,"title":"Expose details invocation arguments and create tcp client wrapper","user":{"login":"stopthatcow","id":12653733,"avatar_url":"https://avatars.githubusercontent.com/u/12653733?v=3","gravatar_id":"","url":"https://api.github.com/users/stopthatcow","html_url":"https://github.com/stopthatcow","followers_url":"https://api.github.com/users/stopthatcow/followers","following_url":"https://api.github.com/users/stopthatcow/following{/other_user}","gists_url":"https://api.github.com/users/stopthatcow/gists{/gist_id}","starred_url":"https://api.github.com/users/stopthatcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stopthatcow/subscriptions","organizations_url":"https://api.github.com/users/stopthatcow/orgs","repos_url":"https://api.github.com/users/stopthatcow/repos","events_url":"https://api.github.com/users/stopthatcow/events{/privacy}","received_events_url":"https://api.github.com/users/stopthatcow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-07-07T21:13:10Z","updated_at":"2015-07-23T03:11:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/davidchappelle/AutobahnCpp/pulls/8","html_url":"https://github.com/davidchappelle/AutobahnCpp/pull/8","diff_url":"https://github.com/davidchappelle/AutobahnCpp/pull/8.diff","patch_url":"https://github.com/davidchappelle/AutobahnCpp/pull/8.patch"},"body":"This PR adds deserialization of the WAMP details field (field 3) in the INVOCATION message and exposes it as a key value map in the invocation object. This is useful for prefixed matched registrations that need to know the actual procedure called in order to process the call. The PR also adds a tcp client wrapper (wraps socket and sesssion) that seeks to reduce the number of lines of boiler plate code to spin up a tcp WAMP client."},"comment":{"url":"https://api.github.com/repos/davidchappelle/AutobahnCpp/issues/comments/123947618","html_url":"https://github.com/davidchappelle/AutobahnCpp/pull/8#issuecomment-123947618","issue_url":"https://api.github.com/repos/davidchappelle/AutobahnCpp/issues/8","id":123947618,"user":{"login":"jpetso","id":88121,"avatar_url":"https://avatars.githubusercontent.com/u/88121?v=3","gravatar_id":"","url":"https://api.github.com/users/jpetso","html_url":"https://github.com/jpetso","followers_url":"https://api.github.com/users/jpetso/followers","following_url":"https://api.github.com/users/jpetso/following{/other_user}","gists_url":"https://api.github.com/users/jpetso/gists{/gist_id}","starred_url":"https://api.github.com/users/jpetso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpetso/subscriptions","organizations_url":"https://api.github.com/users/jpetso/orgs","repos_url":"https://api.github.com/users/jpetso/repos","events_url":"https://api.github.com/users/jpetso/events{/privacy}","received_events_url":"https://api.github.com/users/jpetso/received_events","type":"User","site_admin":false},"created_at":"2015-07-23T03:11:21Z","updated_at":"2015-07-23T03:11:21Z","body":"In addition to the per-line comments, would it be possible to squash the commits into one or two so the commit history isn't littered with reverts of reverts of reverts? In fact, exposure of the invocation details property and the TCP client wrapper are two completely different sets of functionality, and should probably be submitted as separate pull requests (with a cleaned-up commit each)."}}