{"action":"created","comment":{"url":"https://api.github.com/repos/watir/watir-webdriver/pulls/comments/34089800","id":34089800,"diff_hunk":"@@ -10,6 +10,7 @@ class Browser\n     include Waitable\n \n     attr_reader :driver\n+    attr_reader :checkers","path":"lib/watir-webdriver/browser.rb","position":4,"original_position":4,"commit_id":"029a66b9b6abbf5dead0ad998c804a12b56aa07e","original_commit_id":"029a66b9b6abbf5dead0ad998c804a12b56aa07e","user":{"login":"jarmo","id":174160,"avatar_url":"https://avatars.githubusercontent.com/u/174160?v=3","gravatar_id":"","url":"https://api.github.com/users/jarmo","html_url":"https://github.com/jarmo","followers_url":"https://api.github.com/users/jarmo/followers","following_url":"https://api.github.com/users/jarmo/following{/other_user}","gists_url":"https://api.github.com/users/jarmo/gists{/gist_id}","starred_url":"https://api.github.com/users/jarmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarmo/subscriptions","organizations_url":"https://api.github.com/users/jarmo/orgs","repos_url":"https://api.github.com/users/jarmo/repos","events_url":"https://api.github.com/users/jarmo/events{/privacy}","received_events_url":"https://api.github.com/users/jarmo/received_events","type":"User","site_admin":false},"body":"Since we're already changing the API itself then maybe we could use some better naming here as well instead of ambigious `checker`? What about something in the lines of `after_hooks` or something similar, because that's what they essentially are. Or?","created_at":"2015-07-07T20:58:43Z","updated_at":"2015-07-07T20:58:43Z","html_url":"https://github.com/watir/watir-webdriver/pull/352#discussion_r34089800","pull_request_url":"https://api.github.com/repos/watir/watir-webdriver/pulls/352","_links":{"self":{"href":"https://api.github.com/repos/watir/watir-webdriver/pulls/comments/34089800"},"html":{"href":"https://github.com/watir/watir-webdriver/pull/352#discussion_r34089800"},"pull_request":{"href":"https://api.github.com/repos/watir/watir-webdriver/pulls/352"}}},"pull_request":{"url":"https://api.github.com/repos/watir/watir-webdriver/pulls/352","id":39093078,"html_url":"https://github.com/watir/watir-webdriver/pull/352","diff_url":"https://github.com/watir/watir-webdriver/pull/352.diff","patch_url":"https://github.com/watir/watir-webdriver/pull/352.patch","issue_url":"https://api.github.com/repos/watir/watir-webdriver/issues/352","number":352,"state":"open","locked":false,"title":"Extract Checkers into separate API and run them after alert ok/close","user":{"login":"p0deje","id":665846,"avatar_url":"https://avatars.githubusercontent.com/u/665846?v=3","gravatar_id":"","url":"https://api.github.com/users/p0deje","html_url":"https://github.com/p0deje","followers_url":"https://api.github.com/users/p0deje/followers","following_url":"https://api.github.com/users/p0deje/following{/other_user}","gists_url":"https://api.github.com/users/p0deje/gists{/gist_id}","starred_url":"https://api.github.com/users/p0deje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0deje/subscriptions","organizations_url":"https://api.github.com/users/p0deje/orgs","repos_url":"https://api.github.com/users/p0deje/repos","events_url":"https://api.github.com/users/p0deje/events{/privacy}","received_events_url":"https://api.github.com/users/p0deje/received_events","type":"User","site_admin":false},"body":"Related to #351 \r\n\r\nThis is a quick and working solution to the problem of sharing checkers between. We can actually implement it way easier by passing `Watir::Browser` instance to `Watir::Alert` constructor and just calling `browser#run_checkers` later.\r\n\r\nI kinda like this solution more because it remove checkers responsibility from `Watir::Browser` and make API more OO. Though, this means we have to deprecate current API and update it watir-classic too.\r\n\r\n@titusfortner @jarmo @jkotests Please take a look. If you don't like this solution, I can easily revert and forget about it.\r\n\r\nSpecs are in https://github.com/watir/watirspec/pull/67","created_at":"2015-07-02T15:12:00Z","updated_at":"2015-07-07T20:58:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb1d099091b318a24e9f359a7c79d3514c2621cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/watir/watir-webdriver/pulls/352/commits","review_comments_url":"https://api.github.com/repos/watir/watir-webdriver/pulls/352/comments","review_comment_url":"https://api.github.com/repos/watir/watir-webdriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/watir/watir-webdriver/issues/352/comments","statuses_url":"https://api.github.com/repos/watir/watir-webdriver/statuses/029a66b9b6abbf5dead0ad998c804a12b56aa07e","head":{"label":"watir:alert_checkers","ref":"alert_checkers","sha":"029a66b9b6abbf5dead0ad998c804a12b56aa07e","user":{"login":"watir","id":1331009,"avatar_url":"https://avatars.githubusercontent.com/u/1331009?v=3","gravatar_id":"","url":"https://api.github.com/users/watir","html_url":"https://github.com/watir","followers_url":"https://api.github.com/users/watir/followers","following_url":"https://api.github.com/users/watir/following{/other_user}","gists_url":"https://api.github.com/users/watir/gists{/gist_id}","starred_url":"https://api.github.com/users/watir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watir/subscriptions","organizations_url":"https://api.github.com/users/watir/orgs","repos_url":"https://api.github.com/users/watir/repos","events_url":"https://api.github.com/users/watir/events{/privacy}","received_events_url":"https://api.github.com/users/watir/received_events","type":"Organization","site_admin":false},"repo":{"id":366200,"name":"watir-webdriver","full_name":"watir/watir-webdriver","owner":{"login":"watir","id":1331009,"avatar_url":"https://avatars.githubusercontent.com/u/1331009?v=3","gravatar_id":"","url":"https://api.github.com/users/watir","html_url":"https://github.com/watir","followers_url":"https://api.github.com/users/watir/followers","following_url":"https://api.github.com/users/watir/following{/other_user}","gists_url":"https://api.github.com/users/watir/gists{/gist_id}","starred_url":"https://api.github.com/users/watir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watir/subscriptions","organizations_url":"https://api.github.com/users/watir/orgs","repos_url":"https://api.github.com/users/watir/repos","events_url":"https://api.github.com/users/watir/events{/privacy}","received_events_url":"https://api.github.com/users/watir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/watir/watir-webdriver","description":"Watir implementation on WebDriver","fork":false,"url":"https://api.github.com/repos/watir/watir-webdriver","forks_url":"https://api.github.com/repos/watir/watir-webdriver/forks","keys_url":"https://api.github.com/repos/watir/watir-webdriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watir/watir-webdriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watir/watir-webdriver/teams","hooks_url":"https://api.github.com/repos/watir/watir-webdriver/hooks","issue_events_url":"https://api.github.com/repos/watir/watir-webdriver/issues/events{/number}","events_url":"https://api.github.com/repos/watir/watir-webdriver/events","assignees_url":"https://api.github.com/repos/watir/watir-webdriver/assignees{/user}","branches_url":"https://api.github.com/repos/watir/watir-webdriver/branches{/branch}","tags_url":"https://api.github.com/repos/watir/watir-webdriver/tags","blobs_url":"https://api.github.com/repos/watir/watir-webdriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watir/watir-webdriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watir/watir-webdriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/watir/watir-webdriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watir/watir-webdriver/statuses/{sha}","languages_url":"https://api.github.com/repos/watir/watir-webdriver/languages","stargazers_url":"https://api.github.com/repos/watir/watir-webdriver/stargazers","contributors_url":"https://api.github.com/repos/watir/watir-webdriver/contributors","subscribers_url":"https://api.github.com/repos/watir/watir-webdriver/subscribers","subscription_url":"https://api.github.com/repos/watir/watir-webdriver/subscription","commits_url":"https://api.github.com/repos/watir/watir-webdriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/watir/watir-webdriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/watir/watir-webdriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/watir/watir-webdriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/watir/watir-webdriver/contents/{+path}","compare_url":"https://api.github.com/repos/watir/watir-webdriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watir/watir-webdriver/merges","archive_url":"https://api.github.com/repos/watir/watir-webdriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watir/watir-webdriver/downloads","issues_url":"https://api.github.com/repos/watir/watir-webdriver/issues{/number}","pulls_url":"https://api.github.com/repos/watir/watir-webdriver/pulls{/number}","milestones_url":"https://api.github.com/repos/watir/watir-webdriver/milestones{/number}","notifications_url":"https://api.github.com/repos/watir/watir-webdriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watir/watir-webdriver/labels{/name}","releases_url":"https://api.github.com/repos/watir/watir-webdriver/releases{/id}","created_at":"2009-11-09T11:40:46Z","updated_at":"2015-07-07T07:18:56Z","pushed_at":"2015-07-02T16:45:49Z","git_url":"git://github.com/watir/watir-webdriver.git","ssh_url":"git@github.com:watir/watir-webdriver.git","clone_url":"https://github.com/watir/watir-webdriver.git","svn_url":"https://github.com/watir/watir-webdriver","homepage":"http://watirwebdriver.com","size":7220,"stargazers_count":516,"watchers_count":516,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":113,"mirror_url":null,"open_issues_count":13,"forks":113,"open_issues":13,"watchers":516,"default_branch":"master"}},"base":{"label":"watir:master","ref":"master","sha":"0abffec91f467a511ddbdda6065318124b9c90b3","user":{"login":"watir","id":1331009,"avatar_url":"https://avatars.githubusercontent.com/u/1331009?v=3","gravatar_id":"","url":"https://api.github.com/users/watir","html_url":"https://github.com/watir","followers_url":"https://api.github.com/users/watir/followers","following_url":"https://api.github.com/users/watir/following{/other_user}","gists_url":"https://api.github.com/users/watir/gists{/gist_id}","starred_url":"https://api.github.com/users/watir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watir/subscriptions","organizations_url":"https://api.github.com/users/watir/orgs","repos_url":"https://api.github.com/users/watir/repos","events_url":"https://api.github.com/users/watir/events{/privacy}","received_events_url":"https://api.github.com/users/watir/received_events","type":"Organization","site_admin":false},"repo":{"id":366200,"name":"watir-webdriver","full_name":"watir/watir-webdriver","owner":{"login":"watir","id":1331009,"avatar_url":"https://avatars.githubusercontent.com/u/1331009?v=3","gravatar_id":"","url":"https://api.github.com/users/watir","html_url":"https://github.com/watir","followers_url":"https://api.github.com/users/watir/followers","following_url":"https://api.github.com/users/watir/following{/other_user}","gists_url":"https://api.github.com/users/watir/gists{/gist_id}","starred_url":"https://api.github.com/users/watir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watir/subscriptions","organizations_url":"https://api.github.com/users/watir/orgs","repos_url":"https://api.github.com/users/watir/repos","events_url":"https://api.github.com/users/watir/events{/privacy}","received_events_url":"https://api.github.com/users/watir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/watir/watir-webdriver","description":"Watir implementation on WebDriver","fork":false,"url":"https://api.github.com/repos/watir/watir-webdriver","forks_url":"https://api.github.com/repos/watir/watir-webdriver/forks","keys_url":"https://api.github.com/repos/watir/watir-webdriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watir/watir-webdriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watir/watir-webdriver/teams","hooks_url":"https://api.github.com/repos/watir/watir-webdriver/hooks","issue_events_url":"https://api.github.com/repos/watir/watir-webdriver/issues/events{/number}","events_url":"https://api.github.com/repos/watir/watir-webdriver/events","assignees_url":"https://api.github.com/repos/watir/watir-webdriver/assignees{/user}","branches_url":"https://api.github.com/repos/watir/watir-webdriver/branches{/branch}","tags_url":"https://api.github.com/repos/watir/watir-webdriver/tags","blobs_url":"https://api.github.com/repos/watir/watir-webdriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watir/watir-webdriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watir/watir-webdriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/watir/watir-webdriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watir/watir-webdriver/statuses/{sha}","languages_url":"https://api.github.com/repos/watir/watir-webdriver/languages","stargazers_url":"https://api.github.com/repos/watir/watir-webdriver/stargazers","contributors_url":"https://api.github.com/repos/watir/watir-webdriver/contributors","subscribers_url":"https://api.github.com/repos/watir/watir-webdriver/subscribers","subscription_url":"https://api.github.com/repos/watir/watir-webdriver/subscription","commits_url":"https://api.github.com/repos/watir/watir-webdriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/watir/watir-webdriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/watir/watir-webdriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/watir/watir-webdriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/watir/watir-webdriver/contents/{+path}","compare_url":"https://api.github.com/repos/watir/watir-webdriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watir/watir-webdriver/merges","archive_url":"https://api.github.com/repos/watir/watir-webdriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watir/watir-webdriver/downloads","issues_url":"https://api.github.com/repos/watir/watir-webdriver/issues{/number}","pulls_url":"https://api.github.com/repos/watir/watir-webdriver/pulls{/number}","milestones_url":"https://api.github.com/repos/watir/watir-webdriver/milestones{/number}","notifications_url":"https://api.github.com/repos/watir/watir-webdriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watir/watir-webdriver/labels{/name}","releases_url":"https://api.github.com/repos/watir/watir-webdriver/releases{/id}","created_at":"2009-11-09T11:40:46Z","updated_at":"2015-07-07T07:18:56Z","pushed_at":"2015-07-02T16:45:49Z","git_url":"git://github.com/watir/watir-webdriver.git","ssh_url":"git@github.com:watir/watir-webdriver.git","clone_url":"https://github.com/watir/watir-webdriver.git","svn_url":"https://github.com/watir/watir-webdriver","homepage":"http://watirwebdriver.com","size":7220,"stargazers_count":516,"watchers_count":516,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":113,"mirror_url":null,"open_issues_count":13,"forks":113,"open_issues":13,"watchers":516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/watir/watir-webdriver/pulls/352"},"html":{"href":"https://github.com/watir/watir-webdriver/pull/352"},"issue":{"href":"https://api.github.com/repos/watir/watir-webdriver/issues/352"},"comments":{"href":"https://api.github.com/repos/watir/watir-webdriver/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/watir/watir-webdriver/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/watir/watir-webdriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/watir/watir-webdriver/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/watir/watir-webdriver/statuses/029a66b9b6abbf5dead0ad998c804a12b56aa07e"}}}}