{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/27802987","id":27802987,"diff_hunk":"@@ -1400,6 +1399,14 @@ def connect_ssh(options={})\n       rl_user, rl_password = self.auth_user_pwd(:root)\n       su_user, su_password = nil, nil\n     end\n+    return rl_user, rl_password, su_user, su_password, {}\n+  end\n+\n+  def connect_ssh(options={})\n+    require 'MiqSshUtil'\n+\n+    rl_user, rl_password, su_user, su_password, additional_options = ssh_users_and_passwords","path":"vmdb/app/models/host.rb","position":20,"original_position":20,"commit_id":"29357b81a4de44f62c832d59fb7cf39f564b77c4","original_commit_id":"5bf8c91d58fae1ec9e2f73e2d42ba1dec0891f47","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"body":"Nice @Ladas... hopefully this refactoring will allow others as it seems like that method is still doing too much but at least it's a single method.  But we do need tests for this `ssh_users_and_passwords` on `Host` vs. `HostOpenstackInfra`","created_at":"2015-04-06T15:14:00Z","updated_at":"2015-04-06T15:14:00Z","html_url":"https://github.com/ManageIQ/manageiq/pull/2374#discussion_r27802987","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2374","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/27802987"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/2374#discussion_r27802987"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2374"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2374","id":32034739,"html_url":"https://github.com/ManageIQ/manageiq/pull/2374","diff_url":"https://github.com/ManageIQ/manageiq/pull/2374.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/2374.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2374","number":2374,"state":"open","locked":false,"title":"Making connect ssh for host openstack infra work","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"body":"Adding keypair on Provider level. And using this keypair for all the hosts in the provider for ssh.","created_at":"2015-03-26T16:27:18Z","updated_at":"2015-04-06T15:14:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe83b53869a1faa2cd3df64299f9e1084bfecbfa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2374/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2374/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2374/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/29357b81a4de44f62c832d59fb7cf39f564b77c4","head":{"label":"Ladas:making_connect_ssh_for_host_openstack_infra_work","ref":"making_connect_ssh_for_host_openstack_infra_work","sha":"29357b81a4de44f62c832d59fb7cf39f564b77c4","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"repo":{"id":27175121,"name":"manageiq","full_name":"Ladas/manageiq","owner":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ladas/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/Ladas/manageiq","forks_url":"https://api.github.com/repos/Ladas/manageiq/forks","keys_url":"https://api.github.com/repos/Ladas/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ladas/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ladas/manageiq/teams","hooks_url":"https://api.github.com/repos/Ladas/manageiq/hooks","issue_events_url":"https://api.github.com/repos/Ladas/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/Ladas/manageiq/events","assignees_url":"https://api.github.com/repos/Ladas/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/Ladas/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/Ladas/manageiq/tags","blobs_url":"https://api.github.com/repos/Ladas/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ladas/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ladas/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ladas/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ladas/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/Ladas/manageiq/languages","stargazers_url":"https://api.github.com/repos/Ladas/manageiq/stargazers","contributors_url":"https://api.github.com/repos/Ladas/manageiq/contributors","subscribers_url":"https://api.github.com/repos/Ladas/manageiq/subscribers","subscription_url":"https://api.github.com/repos/Ladas/manageiq/subscription","commits_url":"https://api.github.com/repos/Ladas/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ladas/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ladas/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ladas/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ladas/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/Ladas/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ladas/manageiq/merges","archive_url":"https://api.github.com/repos/Ladas/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ladas/manageiq/downloads","issues_url":"https://api.github.com/repos/Ladas/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/Ladas/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/Ladas/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/Ladas/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ladas/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/Ladas/manageiq/releases{/id}","created_at":"2014-11-26T12:09:24Z","updated_at":"2015-04-02T07:57:23Z","pushed_at":"2015-04-03T12:14:18Z","git_url":"git://github.com/Ladas/manageiq.git","ssh_url":"git@github.com:Ladas/manageiq.git","clone_url":"https://github.com/Ladas/manageiq.git","svn_url":"https://github.com/Ladas/manageiq","homepage":"manageiq.org","size":68586,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"b9487a9c14ee073f49faf9b09f074f963dfa121c","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-04-03T14:41:24Z","pushed_at":"2015-04-06T14:37:52Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":114614,"stargazers_count":102,"watchers_count":102,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":360,"forks":100,"open_issues":360,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2374"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/2374"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/2374"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/2374/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2374/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2374/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/29357b81a4de44f62c832d59fb7cf39f564b77c4"}}}}