{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4284","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4284/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4284/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4284/events","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4284","id":88405018,"number":4284,"title":"Upgrading Chosen JS plugin","user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-06-15T12:05:21Z","updated_at":"2015-07-01T05:26:42Z","closed_at":"2015-06-15T23:13:03Z","pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4284","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4284","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/4284.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/4284.patch"},"body":"The version of Chosen we currently use in admin is very old and has\r\nperformance issues with large data-sets."},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/117439006","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4284#issuecomment-117439006","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4284","id":117439006,"user":{"login":"adrexia","id":984753,"avatar_url":"https://avatars.githubusercontent.com/u/984753?v=3","gravatar_id":"","url":"https://api.github.com/users/adrexia","html_url":"https://github.com/adrexia","followers_url":"https://api.github.com/users/adrexia/followers","following_url":"https://api.github.com/users/adrexia/following{/other_user}","gists_url":"https://api.github.com/users/adrexia/gists{/gist_id}","starred_url":"https://api.github.com/users/adrexia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrexia/subscriptions","organizations_url":"https://api.github.com/users/adrexia/orgs","repos_url":"https://api.github.com/users/adrexia/repos","events_url":"https://api.github.com/users/adrexia/events{/privacy}","received_events_url":"https://api.github.com/users/adrexia/received_events","type":"User","site_admin":false},"created_at":"2015-07-01T05:26:42Z","updated_at":"2015-07-01T05:26:42Z","body":"I realised when it came to looking at this that 0.14.0 is still an old chosen version (pre-api changes). Which is what we need in 3.1, but it's the later changes that I was hopeful would fix our bugs. \r\n\r\nI can confirm that it's working with a couple of exceptions: \r\n1. the preview selectors\r\n2. iframe based composite style fields (c.f. uploadfield). \r\n\r\niframes, unfortunately, do not produce scrollbars when chosen goes outside their parameters. The drop up functionality as a style choice is needed for preview without doing something drastic like moving controls to the top of the preview. I do think we can fix this more elegantly using the post 1.0 versions of chosen, but this version has all of our old customisation limitations. \r\n\r\nAt this point it might be best to backport our fixes onto 0.14.0* and upgrade properly in 3.2. Do you want me to give it a go? \r\n\r\n--\r\n*  I know it just compounds the history state issue. It already looks deceptively more complex than it is**, but aside from creating a new file and reapplying our patches, I'm unsure what more we can do?\r\n\r\n** It looks a bit like: upgrade chosen -> apply patches -> upgrade chosen -> patch our patches -> upgrade chosen. But our actual unique change set is pretty minimal. "}}