{"action":"closed","number":2180,"pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2180","id":42547397,"html_url":"https://github.com/angular-ui/ui-router/pull/2180","diff_url":"https://github.com/angular-ui/ui-router/pull/2180.diff","patch_url":"https://github.com/angular-ui/ui-router/pull/2180.patch","issue_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2180","number":2180,"state":"closed","locked":false,"title":"Replace `declare ng.ui` with `declare angular.ui`.  Fixes #2035","user":{"login":"rcollette","id":136476,"avatar_url":"https://avatars.githubusercontent.com/u/136476?v=3","gravatar_id":"","url":"https://api.github.com/users/rcollette","html_url":"https://github.com/rcollette","followers_url":"https://api.github.com/users/rcollette/followers","following_url":"https://api.github.com/users/rcollette/following{/other_user}","gists_url":"https://api.github.com/users/rcollette/gists{/gist_id}","starred_url":"https://api.github.com/users/rcollette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcollette/subscriptions","organizations_url":"https://api.github.com/users/rcollette/orgs","repos_url":"https://api.github.com/users/rcollette/repos","events_url":"https://api.github.com/users/rcollette/events{/privacy}","received_events_url":"https://api.github.com/users/rcollette/received_events","type":"User","site_admin":false},"body":"Because the TS 1.5 language service does not yet support the exclude option, IDEs such as WebStorm will find and use angular-ui-router.d.ts.\r\n\r\nAs discussed in issue 2035, the declaration ng.ui conflicts with the declaration of ng in angular.d.ts.\r\n\r\nThis merge is to correct the declaration from ng.ui to angular.ui\r\n\r\nPull 1990 is attempting to address the issue by removing the definition entirely from the project, which is fine as well.\r\n\r\nEither way, the issue is a blocker for those compiling with an IDE (i.e. perhaps not using  a gulpfile).\r\n\r\nHopefully one of the two pulls will be merged ASAP.\r\n\r\nFixes #2035 ","created_at":"2015-08-17T01:02:50Z","updated_at":"2015-09-23T04:56:59Z","closed_at":"2015-09-23T04:56:58Z","merged_at":null,"merge_commit_sha":"9177ab72d4cde2a2396dadec9b163d389b9cff32","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2180/commits","review_comments_url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2180/comments","review_comment_url":"https://api.github.com/repos/angular-ui/ui-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2180/comments","statuses_url":"https://api.github.com/repos/angular-ui/ui-router/statuses/ec41e8318e90663b9727db868ceb1aa77c553054","head":{"label":"rcollette:master","ref":"master","sha":"ec41e8318e90663b9727db868ceb1aa77c553054","user":{"login":"rcollette","id":136476,"avatar_url":"https://avatars.githubusercontent.com/u/136476?v=3","gravatar_id":"","url":"https://api.github.com/users/rcollette","html_url":"https://github.com/rcollette","followers_url":"https://api.github.com/users/rcollette/followers","following_url":"https://api.github.com/users/rcollette/following{/other_user}","gists_url":"https://api.github.com/users/rcollette/gists{/gist_id}","starred_url":"https://api.github.com/users/rcollette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcollette/subscriptions","organizations_url":"https://api.github.com/users/rcollette/orgs","repos_url":"https://api.github.com/users/rcollette/repos","events_url":"https://api.github.com/users/rcollette/events{/privacy}","received_events_url":"https://api.github.com/users/rcollette/received_events","type":"User","site_admin":false},"repo":{"id":40850436,"name":"ui-router","full_name":"rcollette/ui-router","owner":{"login":"rcollette","id":136476,"avatar_url":"https://avatars.githubusercontent.com/u/136476?v=3","gravatar_id":"","url":"https://api.github.com/users/rcollette","html_url":"https://github.com/rcollette","followers_url":"https://api.github.com/users/rcollette/followers","following_url":"https://api.github.com/users/rcollette/following{/other_user}","gists_url":"https://api.github.com/users/rcollette/gists{/gist_id}","starred_url":"https://api.github.com/users/rcollette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcollette/subscriptions","organizations_url":"https://api.github.com/users/rcollette/orgs","repos_url":"https://api.github.com/users/rcollette/repos","events_url":"https://api.github.com/users/rcollette/events{/privacy}","received_events_url":"https://api.github.com/users/rcollette/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rcollette/ui-router","description":"The de-facto solution to flexible routing with nested views in AngularJS","fork":true,"url":"https://api.github.com/repos/rcollette/ui-router","forks_url":"https://api.github.com/repos/rcollette/ui-router/forks","keys_url":"https://api.github.com/repos/rcollette/ui-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcollette/ui-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcollette/ui-router/teams","hooks_url":"https://api.github.com/repos/rcollette/ui-router/hooks","issue_events_url":"https://api.github.com/repos/rcollette/ui-router/issues/events{/number}","events_url":"https://api.github.com/repos/rcollette/ui-router/events","assignees_url":"https://api.github.com/repos/rcollette/ui-router/assignees{/user}","branches_url":"https://api.github.com/repos/rcollette/ui-router/branches{/branch}","tags_url":"https://api.github.com/repos/rcollette/ui-router/tags","blobs_url":"https://api.github.com/repos/rcollette/ui-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcollette/ui-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcollette/ui-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcollette/ui-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcollette/ui-router/statuses/{sha}","languages_url":"https://api.github.com/repos/rcollette/ui-router/languages","stargazers_url":"https://api.github.com/repos/rcollette/ui-router/stargazers","contributors_url":"https://api.github.com/repos/rcollette/ui-router/contributors","subscribers_url":"https://api.github.com/repos/rcollette/ui-router/subscribers","subscription_url":"https://api.github.com/repos/rcollette/ui-router/subscription","commits_url":"https://api.github.com/repos/rcollette/ui-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcollette/ui-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcollette/ui-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcollette/ui-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcollette/ui-router/contents/{+path}","compare_url":"https://api.github.com/repos/rcollette/ui-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcollette/ui-router/merges","archive_url":"https://api.github.com/repos/rcollette/ui-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcollette/ui-router/downloads","issues_url":"https://api.github.com/repos/rcollette/ui-router/issues{/number}","pulls_url":"https://api.github.com/repos/rcollette/ui-router/pulls{/number}","milestones_url":"https://api.github.com/repos/rcollette/ui-router/milestones{/number}","notifications_url":"https://api.github.com/repos/rcollette/ui-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcollette/ui-router/labels{/name}","releases_url":"https://api.github.com/repos/rcollette/ui-router/releases{/id}","created_at":"2015-08-17T00:29:29Z","updated_at":"2015-08-17T00:29:30Z","pushed_at":"2015-08-17T00:39:04Z","git_url":"git://github.com/rcollette/ui-router.git","ssh_url":"git@github.com:rcollette/ui-router.git","clone_url":"https://github.com/rcollette/ui-router.git","svn_url":"https://github.com/rcollette/ui-router","homepage":"http://angular-ui.github.io/ui-router/site","size":5018,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"997deb79451ec303bf10ee6694c085d24fafbc2f","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":7693799,"name":"ui-router","full_name":"angular-ui/ui-router","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/ui-router","description":"The de-facto solution to flexible routing with nested views in AngularJS","fork":false,"url":"https://api.github.com/repos/angular-ui/ui-router","forks_url":"https://api.github.com/repos/angular-ui/ui-router/forks","keys_url":"https://api.github.com/repos/angular-ui/ui-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/ui-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/ui-router/teams","hooks_url":"https://api.github.com/repos/angular-ui/ui-router/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/ui-router/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/ui-router/events","assignees_url":"https://api.github.com/repos/angular-ui/ui-router/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/ui-router/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/ui-router/tags","blobs_url":"https://api.github.com/repos/angular-ui/ui-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/ui-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/ui-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/ui-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/ui-router/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/ui-router/languages","stargazers_url":"https://api.github.com/repos/angular-ui/ui-router/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/ui-router/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/ui-router/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/ui-router/subscription","commits_url":"https://api.github.com/repos/angular-ui/ui-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/ui-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/ui-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/ui-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/ui-router/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/ui-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/ui-router/merges","archive_url":"https://api.github.com/repos/angular-ui/ui-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/ui-router/downloads","issues_url":"https://api.github.com/repos/angular-ui/ui-router/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/ui-router/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/ui-router/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/ui-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/ui-router/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/ui-router/releases{/id}","created_at":"2013-01-18T20:26:29Z","updated_at":"2015-09-23T04:10:46Z","pushed_at":"2015-09-23T04:45:06Z","git_url":"git://github.com/angular-ui/ui-router.git","ssh_url":"git@github.com:angular-ui/ui-router.git","clone_url":"https://github.com/angular-ui/ui-router.git","svn_url":"https://github.com/angular-ui/ui-router","homepage":"http://angular-ui.github.io/ui-router/site","size":14190,"stargazers_count":8399,"watchers_count":8399,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2012,"mirror_url":null,"open_issues_count":214,"forks":2012,"open_issues":214,"watchers":8399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/2180"},"html":{"href":"https://github.com/angular-ui/ui-router/pull/2180"},"issue":{"href":"https://api.github.com/repos/angular-ui/ui-router/issues/2180"},"comments":{"href":"https://api.github.com/repos/angular-ui/ui-router/issues/2180/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/2180/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/2180/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/ui-router/statuses/ec41e8318e90663b9727db868ceb1aa77c553054"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}