{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/40279401","id":40279401,"diff_hunk":"@@ -2624,7 +2612,7 @@ static char_u *expand_tag_fname(char_u *fname, char_u *tag_fname, int expand)\n  */\n static int test_for_current(char_u *fname, char_u *fname_end, char_u *tag_fname, char_u *buf_ffname)\n {\n-  int c;\n+  char_u c;","path":"src/nvim/tag.c","position":267,"original_position":267,"commit_id":"37b925205dd531445d16ec6a6585a410855b1a90","original_commit_id":"37b925205dd531445d16ec6a6585a410855b1a90","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"why not `char`?","created_at":"2015-09-24T02:00:27Z","updated_at":"2015-09-24T02:00:27Z","html_url":"https://github.com/neovim/neovim/pull/2803#discussion_r40279401","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/2803","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/40279401"},"html":{"href":"https://github.com/neovim/neovim/pull/2803#discussion_r40279401"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2803"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/2803","id":37111356,"html_url":"https://github.com/neovim/neovim/pull/2803","diff_url":"https://github.com/neovim/neovim/pull/2803.diff","patch_url":"https://github.com/neovim/neovim/pull/2803.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/2803","number":2803,"state":"open","locked":false,"title":"[RFC] Enable -Wconversion: tag.c","user":{"login":"vheon","id":90633,"avatar_url":"https://avatars.githubusercontent.com/u/90633?v=3","gravatar_id":"","url":"https://api.github.com/users/vheon","html_url":"https://github.com/vheon","followers_url":"https://api.github.com/users/vheon/followers","following_url":"https://api.github.com/users/vheon/following{/other_user}","gists_url":"https://api.github.com/users/vheon/gists{/gist_id}","starred_url":"https://api.github.com/users/vheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vheon/subscriptions","organizations_url":"https://api.github.com/users/vheon/orgs","repos_url":"https://api.github.com/users/vheon/repos","events_url":"https://api.github.com/users/vheon/events{/privacy}","received_events_url":"https://api.github.com/users/vheon/received_events","type":"User","site_admin":false},"body":"I tried to tackle this one. The only doubt that I have is for lines that interact with `num_matches` (https://github.com/neovim/neovim/pull/2803/files#diff-bb67c9d81d07a0359baaea74957f649dR1968) and `mincount` (https://github.com/neovim/neovim/pull/2803/files#diff-bb67c9d81d07a0359baaea74957f649dR1905): I wanted to make them `size_t` as well but they got passed around to other functions from the outside and following their uses wasn't easy, so I would like to hear some other opinion about those.","created_at":"2015-06-07T18:57:27Z","updated_at":"2015-09-24T02:00:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54cecc47c789acf2f2ac5a92304b6e3ffe15008b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/2803/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/2803/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/2803/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/37b925205dd531445d16ec6a6585a410855b1a90","head":{"label":"vheon:wconversion-tag","ref":"wconversion-tag","sha":"37b925205dd531445d16ec6a6585a410855b1a90","user":{"login":"vheon","id":90633,"avatar_url":"https://avatars.githubusercontent.com/u/90633?v=3","gravatar_id":"","url":"https://api.github.com/users/vheon","html_url":"https://github.com/vheon","followers_url":"https://api.github.com/users/vheon/followers","following_url":"https://api.github.com/users/vheon/following{/other_user}","gists_url":"https://api.github.com/users/vheon/gists{/gist_id}","starred_url":"https://api.github.com/users/vheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vheon/subscriptions","organizations_url":"https://api.github.com/users/vheon/orgs","repos_url":"https://api.github.com/users/vheon/repos","events_url":"https://api.github.com/users/vheon/events{/privacy}","received_events_url":"https://api.github.com/users/vheon/received_events","type":"User","site_admin":false},"repo":{"id":37028011,"name":"neovim","full_name":"vheon/neovim","owner":{"login":"vheon","id":90633,"avatar_url":"https://avatars.githubusercontent.com/u/90633?v=3","gravatar_id":"","url":"https://api.github.com/users/vheon","html_url":"https://github.com/vheon","followers_url":"https://api.github.com/users/vheon/followers","following_url":"https://api.github.com/users/vheon/following{/other_user}","gists_url":"https://api.github.com/users/vheon/gists{/gist_id}","starred_url":"https://api.github.com/users/vheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vheon/subscriptions","organizations_url":"https://api.github.com/users/vheon/orgs","repos_url":"https://api.github.com/users/vheon/repos","events_url":"https://api.github.com/users/vheon/events{/privacy}","received_events_url":"https://api.github.com/users/vheon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vheon/neovim","description":"ambitious Vim-fork focused on extensibility and agility. Please consider helping sustain Neovim development! https://salt.bountysource.com/teams/neovim","fork":true,"url":"https://api.github.com/repos/vheon/neovim","forks_url":"https://api.github.com/repos/vheon/neovim/forks","keys_url":"https://api.github.com/repos/vheon/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vheon/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vheon/neovim/teams","hooks_url":"https://api.github.com/repos/vheon/neovim/hooks","issue_events_url":"https://api.github.com/repos/vheon/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/vheon/neovim/events","assignees_url":"https://api.github.com/repos/vheon/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/vheon/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/vheon/neovim/tags","blobs_url":"https://api.github.com/repos/vheon/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vheon/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vheon/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/vheon/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vheon/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/vheon/neovim/languages","stargazers_url":"https://api.github.com/repos/vheon/neovim/stargazers","contributors_url":"https://api.github.com/repos/vheon/neovim/contributors","subscribers_url":"https://api.github.com/repos/vheon/neovim/subscribers","subscription_url":"https://api.github.com/repos/vheon/neovim/subscription","commits_url":"https://api.github.com/repos/vheon/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/vheon/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/vheon/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/vheon/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/vheon/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/vheon/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vheon/neovim/merges","archive_url":"https://api.github.com/repos/vheon/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vheon/neovim/downloads","issues_url":"https://api.github.com/repos/vheon/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/vheon/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/vheon/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/vheon/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vheon/neovim/labels{/name}","releases_url":"https://api.github.com/repos/vheon/neovim/releases{/id}","created_at":"2015-06-07T18:51:12Z","updated_at":"2015-06-07T18:51:18Z","pushed_at":"2015-06-29T16:55:18Z","git_url":"git://github.com/vheon/neovim.git","ssh_url":"git@github.com:vheon/neovim.git","clone_url":"https://github.com/vheon/neovim.git","svn_url":"https://github.com/vheon/neovim","homepage":"http://neovim.io","size":31484,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"6270d431aaeed71e7a8782411f36409ab8e0ee35","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and agility. Consider helping sustain Neovim development! ","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2015-09-24T00:23:19Z","pushed_at":"2015-09-24T01:46:26Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":80482,"stargazers_count":15097,"watchers_count":15097,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1035,"mirror_url":null,"open_issues_count":524,"forks":1035,"open_issues":524,"watchers":15097,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2803"},"html":{"href":"https://github.com/neovim/neovim/pull/2803"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/2803"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/2803/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2803/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2803/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/37b925205dd531445d16ec6a6585a410855b1a90"}}}}