{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/comments/36528968","id":36528968,"diff_hunk":"@@ -302,4 +358,30 @@ private void apply(Path.Segment segment, HawkularPipeline<?, ?> pipeline) {\n         pipeline.hasType(Constants.Type.of(segment.getElementType()));\n         pipeline.hasEid(segment.getElementId());\n     }\n+\n+    /**\n+     * A very simplistic conversion of string to positive integer in only decimal radix.\n+     *\n+     * <p>This is used to figure out whether a segment id represents an index or a key.\n+     *\n+     * @param str the string potentially representing a number\n+     * @return the parsed number or null if the string is not a supported number\n+     */\n+    private static Integer toInteger(String str) {","path":"hawkular-inventory-impl-tinkerpop-parent/hawkular-inventory-impl-tinkerpop/src/main/java/org/hawkular/inventory/impl/tinkerpop/FilterVisitor.java","position":90,"original_position":90,"commit_id":"26368312eaf7ce4c73490b7d9b31f22320a97033","original_commit_id":"03b82de01a7dd1197342bf2529424044ef5b87fc","user":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?v=3","gravatar_id":"","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"body":"why not Integer.parseInt?","created_at":"2015-08-07T15:16:58Z","updated_at":"2015-08-07T15:16:58Z","html_url":"https://github.com/hawkular/hawkular-inventory/pull/138#discussion_r36528968","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/138","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/comments/36528968"},"html":{"href":"https://github.com/hawkular/hawkular-inventory/pull/138#discussion_r36528968"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/138"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/138","id":41780408,"html_url":"https://github.com/hawkular/hawkular-inventory/pull/138","diff_url":"https://github.com/hawkular/hawkular-inventory/pull/138.diff","patch_url":"https://github.com/hawkular/hawkular-inventory/pull/138.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/138","number":138,"state":"open","locked":false,"title":"[HWKINVENT-62] Structured data data model, access and serialization.","user":{"login":"metlos","id":19999,"avatar_url":"https://avatars.githubusercontent.com/u/19999?v=3","gravatar_id":"","url":"https://api.github.com/users/metlos","html_url":"https://github.com/metlos","followers_url":"https://api.github.com/users/metlos/followers","following_url":"https://api.github.com/users/metlos/following{/other_user}","gists_url":"https://api.github.com/users/metlos/gists{/gist_id}","starred_url":"https://api.github.com/users/metlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metlos/subscriptions","organizations_url":"https://api.github.com/users/metlos/orgs","repos_url":"https://api.github.com/users/metlos/repos","events_url":"https://api.github.com/users/metlos/events{/privacy}","received_events_url":"https://api.github.com/users/metlos/received_events","type":"User","site_admin":false},"body":"This has some rough edges still, but is complete enough to publicize so that peer review can start.\r\n\r\n* [x] - more unit tests\r\n* [x] - `hasData` should not be user-creatable\r\n* [x] - `DataEntity` json serialization\r\n* [x] - Reword and add javadoc\r\n* [x] - Clean up (some unimplemented methods that don't need implementing anymore, etc.)","created_at":"2015-08-06T12:06:17Z","updated_at":"2015-08-07T15:16:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec5c959804a629f4a705217d15a67faf015aeb82","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/138/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/138/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/138/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-inventory/statuses/26368312eaf7ce4c73490b7d9b31f22320a97033","head":{"label":"metlos:bug/HWKINVENT-62","ref":"bug/HWKINVENT-62","sha":"26368312eaf7ce4c73490b7d9b31f22320a97033","user":{"login":"metlos","id":19999,"avatar_url":"https://avatars.githubusercontent.com/u/19999?v=3","gravatar_id":"","url":"https://api.github.com/users/metlos","html_url":"https://github.com/metlos","followers_url":"https://api.github.com/users/metlos/followers","following_url":"https://api.github.com/users/metlos/following{/other_user}","gists_url":"https://api.github.com/users/metlos/gists{/gist_id}","starred_url":"https://api.github.com/users/metlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metlos/subscriptions","organizations_url":"https://api.github.com/users/metlos/orgs","repos_url":"https://api.github.com/users/metlos/repos","events_url":"https://api.github.com/users/metlos/events{/privacy}","received_events_url":"https://api.github.com/users/metlos/received_events","type":"User","site_admin":false},"repo":{"id":30182355,"name":"hawkular-inventory","full_name":"metlos/hawkular-inventory","owner":{"login":"metlos","id":19999,"avatar_url":"https://avatars.githubusercontent.com/u/19999?v=3","gravatar_id":"","url":"https://api.github.com/users/metlos","html_url":"https://github.com/metlos","followers_url":"https://api.github.com/users/metlos/followers","following_url":"https://api.github.com/users/metlos/following{/other_user}","gists_url":"https://api.github.com/users/metlos/gists{/gist_id}","starred_url":"https://api.github.com/users/metlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metlos/subscriptions","organizations_url":"https://api.github.com/users/metlos/orgs","repos_url":"https://api.github.com/users/metlos/repos","events_url":"https://api.github.com/users/metlos/events{/privacy}","received_events_url":"https://api.github.com/users/metlos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/metlos/hawkular-inventory","description":"Inventory part of Hawkular - basically a registry for all the things","fork":true,"url":"https://api.github.com/repos/metlos/hawkular-inventory","forks_url":"https://api.github.com/repos/metlos/hawkular-inventory/forks","keys_url":"https://api.github.com/repos/metlos/hawkular-inventory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metlos/hawkular-inventory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metlos/hawkular-inventory/teams","hooks_url":"https://api.github.com/repos/metlos/hawkular-inventory/hooks","issue_events_url":"https://api.github.com/repos/metlos/hawkular-inventory/issues/events{/number}","events_url":"https://api.github.com/repos/metlos/hawkular-inventory/events","assignees_url":"https://api.github.com/repos/metlos/hawkular-inventory/assignees{/user}","branches_url":"https://api.github.com/repos/metlos/hawkular-inventory/branches{/branch}","tags_url":"https://api.github.com/repos/metlos/hawkular-inventory/tags","blobs_url":"https://api.github.com/repos/metlos/hawkular-inventory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metlos/hawkular-inventory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metlos/hawkular-inventory/git/refs{/sha}","trees_url":"https://api.github.com/repos/metlos/hawkular-inventory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metlos/hawkular-inventory/statuses/{sha}","languages_url":"https://api.github.com/repos/metlos/hawkular-inventory/languages","stargazers_url":"https://api.github.com/repos/metlos/hawkular-inventory/stargazers","contributors_url":"https://api.github.com/repos/metlos/hawkular-inventory/contributors","subscribers_url":"https://api.github.com/repos/metlos/hawkular-inventory/subscribers","subscription_url":"https://api.github.com/repos/metlos/hawkular-inventory/subscription","commits_url":"https://api.github.com/repos/metlos/hawkular-inventory/commits{/sha}","git_commits_url":"https://api.github.com/repos/metlos/hawkular-inventory/git/commits{/sha}","comments_url":"https://api.github.com/repos/metlos/hawkular-inventory/comments{/number}","issue_comment_url":"https://api.github.com/repos/metlos/hawkular-inventory/issues/comments{/number}","contents_url":"https://api.github.com/repos/metlos/hawkular-inventory/contents/{+path}","compare_url":"https://api.github.com/repos/metlos/hawkular-inventory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metlos/hawkular-inventory/merges","archive_url":"https://api.github.com/repos/metlos/hawkular-inventory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metlos/hawkular-inventory/downloads","issues_url":"https://api.github.com/repos/metlos/hawkular-inventory/issues{/number}","pulls_url":"https://api.github.com/repos/metlos/hawkular-inventory/pulls{/number}","milestones_url":"https://api.github.com/repos/metlos/hawkular-inventory/milestones{/number}","notifications_url":"https://api.github.com/repos/metlos/hawkular-inventory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metlos/hawkular-inventory/labels{/name}","releases_url":"https://api.github.com/repos/metlos/hawkular-inventory/releases{/id}","created_at":"2015-02-02T10:36:47Z","updated_at":"2015-04-29T09:14:46Z","pushed_at":"2015-08-07T13:35:07Z","git_url":"git://github.com/metlos/hawkular-inventory.git","ssh_url":"git@github.com:metlos/hawkular-inventory.git","clone_url":"https://github.com/metlos/hawkular-inventory.git","svn_url":"https://github.com/metlos/hawkular-inventory","homepage":null,"size":2152,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"bc41b3ab5b7346b1fc502441b7ee0637104e98a4","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":29915222,"name":"hawkular-inventory","full_name":"hawkular/hawkular-inventory","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-inventory","description":"Inventory part of Hawkular - basically a registry for all the things","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-inventory","forks_url":"https://api.github.com/repos/hawkular/hawkular-inventory/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-inventory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-inventory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-inventory/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-inventory/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-inventory/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-inventory/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-inventory/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-inventory/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-inventory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-inventory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-inventory/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-inventory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-inventory/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-inventory/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-inventory/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-inventory/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-inventory/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-inventory/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-inventory/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-inventory/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-inventory/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-inventory/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-inventory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-inventory/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-inventory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-inventory/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-inventory/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-inventory/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-inventory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-inventory/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-inventory/releases{/id}","created_at":"2015-01-27T13:27:01Z","updated_at":"2015-07-22T11:22:10Z","pushed_at":"2015-08-07T13:35:09Z","git_url":"git://github.com/hawkular/hawkular-inventory.git","ssh_url":"git@github.com:hawkular/hawkular-inventory.git","clone_url":"https://github.com/hawkular/hawkular-inventory.git","svn_url":"https://github.com/hawkular/hawkular-inventory","homepage":null,"size":2787,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/138"},"html":{"href":"https://github.com/hawkular/hawkular-inventory/pull/138"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/138"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-inventory/statuses/26368312eaf7ce4c73490b7d9b31f22320a97033"}}}}