{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/31476465","id":31476465,"diff_hunk":"@@ -443,9 +466,27 @@ private[spark] class ExecutorAllocationManager(\n   private def onExecutorIdle(executorId: String): Unit = synchronized {\n     if (executorIds.contains(executorId)) {\n       if (!removeTimes.contains(executorId) && !executorsPendingToRemove.contains(executorId)) {\n+\n+        val hasCachedBlocks =\n+          executorsWithCachedBlocks.contains(executorId) ||\n+            executorEndpoints.get(executorId).exists(_.askWithRetry[Boolean](HasCachedBlocks))\n+\n+        if (hasCachedBlocks) executorsWithCachedBlocks += executorId","path":"core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala","position":69,"original_position":69,"commit_id":"ae932ffa53d49b99ae6392843a36e5cbc0c8e9f5","original_commit_id":"ae932ffa53d49b99ae6392843a36e5cbc0c8e9f5","user":{"login":"harishreedharan","id":1481194,"avatar_url":"https://avatars.githubusercontent.com/u/1481194?v=3","gravatar_id":"","url":"https://api.github.com/users/harishreedharan","html_url":"https://github.com/harishreedharan","followers_url":"https://api.github.com/users/harishreedharan/followers","following_url":"https://api.github.com/users/harishreedharan/following{/other_user}","gists_url":"https://api.github.com/users/harishreedharan/gists{/gist_id}","starred_url":"https://api.github.com/users/harishreedharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishreedharan/subscriptions","organizations_url":"https://api.github.com/users/harishreedharan/orgs","repos_url":"https://api.github.com/users/harishreedharan/repos","events_url":"https://api.github.com/users/harishreedharan/events{/privacy}","received_events_url":"https://api.github.com/users/harishreedharan/received_events","type":"User","site_admin":false},"body":"@vanzin pinged me offline about having an RPC happening in the listener thread for each executor being reported idle that can be a huge bottle neck. I am planning to make all code in this thread asynchronous, and make the maps and sets used in this thread synchronized, to avoid blocking the listener thread. \r\n\r\nThoughts - @andrewor14, @vanzin ?","created_at":"2015-06-01T22:15:43Z","updated_at":"2015-06-01T22:15:43Z","html_url":"https://github.com/apache/spark/pull/6508#discussion_r31476465","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/6508","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/31476465"},"html":{"href":"https://github.com/apache/spark/pull/6508#discussion_r31476465"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/6508"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/6508","id":36544347,"html_url":"https://github.com/apache/spark/pull/6508","diff_url":"https://github.com/apache/spark/pull/6508.diff","patch_url":"https://github.com/apache/spark/pull/6508.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/6508","number":6508,"state":"open","locked":false,"title":"[SPARK-7955][Core] Ensure executors with cached RDD blocks are not re…","user":{"login":"harishreedharan","id":1481194,"avatar_url":"https://avatars.githubusercontent.com/u/1481194?v=3","gravatar_id":"","url":"https://api.github.com/users/harishreedharan","html_url":"https://github.com/harishreedharan","followers_url":"https://api.github.com/users/harishreedharan/followers","following_url":"https://api.github.com/users/harishreedharan/following{/other_user}","gists_url":"https://api.github.com/users/harishreedharan/gists{/gist_id}","starred_url":"https://api.github.com/users/harishreedharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishreedharan/subscriptions","organizations_url":"https://api.github.com/users/harishreedharan/orgs","repos_url":"https://api.github.com/users/harishreedharan/repos","events_url":"https://api.github.com/users/harishreedharan/events{/privacy}","received_events_url":"https://api.github.com/users/harishreedharan/received_events","type":"User","site_admin":false},"body":"…moved if dynamic allocation is enabled.\r\n\r\nThis is a work in progress. This patch ensures that an executor that has cached RDD blocks are not removed,\r\nbut makes no attempt to find another executor to remove. This is meant to get some feedback on the current\r\napproach, and if it makes sense then I will look at choosing another executor to remove. No testing has been done either.","created_at":"2015-05-29T20:57:42Z","updated_at":"2015-06-01T22:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"467e7c8e9116d356f4c764367c52c6c03be7dc1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/6508/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/6508/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/6508/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/ae932ffa53d49b99ae6392843a36e5cbc0c8e9f5","head":{"label":"harishreedharan:dymanic-caching","ref":"dymanic-caching","sha":"ae932ffa53d49b99ae6392843a36e5cbc0c8e9f5","user":{"login":"harishreedharan","id":1481194,"avatar_url":"https://avatars.githubusercontent.com/u/1481194?v=3","gravatar_id":"","url":"https://api.github.com/users/harishreedharan","html_url":"https://github.com/harishreedharan","followers_url":"https://api.github.com/users/harishreedharan/followers","following_url":"https://api.github.com/users/harishreedharan/following{/other_user}","gists_url":"https://api.github.com/users/harishreedharan/gists{/gist_id}","starred_url":"https://api.github.com/users/harishreedharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishreedharan/subscriptions","organizations_url":"https://api.github.com/users/harishreedharan/orgs","repos_url":"https://api.github.com/users/harishreedharan/repos","events_url":"https://api.github.com/users/harishreedharan/events{/privacy}","received_events_url":"https://api.github.com/users/harishreedharan/received_events","type":"User","site_admin":false},"repo":{"id":18419952,"name":"spark","full_name":"harishreedharan/spark","owner":{"login":"harishreedharan","id":1481194,"avatar_url":"https://avatars.githubusercontent.com/u/1481194?v=3","gravatar_id":"","url":"https://api.github.com/users/harishreedharan","html_url":"https://github.com/harishreedharan","followers_url":"https://api.github.com/users/harishreedharan/followers","following_url":"https://api.github.com/users/harishreedharan/following{/other_user}","gists_url":"https://api.github.com/users/harishreedharan/gists{/gist_id}","starred_url":"https://api.github.com/users/harishreedharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishreedharan/subscriptions","organizations_url":"https://api.github.com/users/harishreedharan/orgs","repos_url":"https://api.github.com/users/harishreedharan/repos","events_url":"https://api.github.com/users/harishreedharan/events{/privacy}","received_events_url":"https://api.github.com/users/harishreedharan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harishreedharan/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/harishreedharan/spark","forks_url":"https://api.github.com/repos/harishreedharan/spark/forks","keys_url":"https://api.github.com/repos/harishreedharan/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harishreedharan/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harishreedharan/spark/teams","hooks_url":"https://api.github.com/repos/harishreedharan/spark/hooks","issue_events_url":"https://api.github.com/repos/harishreedharan/spark/issues/events{/number}","events_url":"https://api.github.com/repos/harishreedharan/spark/events","assignees_url":"https://api.github.com/repos/harishreedharan/spark/assignees{/user}","branches_url":"https://api.github.com/repos/harishreedharan/spark/branches{/branch}","tags_url":"https://api.github.com/repos/harishreedharan/spark/tags","blobs_url":"https://api.github.com/repos/harishreedharan/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harishreedharan/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harishreedharan/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/harishreedharan/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harishreedharan/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/harishreedharan/spark/languages","stargazers_url":"https://api.github.com/repos/harishreedharan/spark/stargazers","contributors_url":"https://api.github.com/repos/harishreedharan/spark/contributors","subscribers_url":"https://api.github.com/repos/harishreedharan/spark/subscribers","subscription_url":"https://api.github.com/repos/harishreedharan/spark/subscription","commits_url":"https://api.github.com/repos/harishreedharan/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/harishreedharan/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/harishreedharan/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/harishreedharan/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/harishreedharan/spark/contents/{+path}","compare_url":"https://api.github.com/repos/harishreedharan/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harishreedharan/spark/merges","archive_url":"https://api.github.com/repos/harishreedharan/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harishreedharan/spark/downloads","issues_url":"https://api.github.com/repos/harishreedharan/spark/issues{/number}","pulls_url":"https://api.github.com/repos/harishreedharan/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/harishreedharan/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/harishreedharan/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harishreedharan/spark/labels{/name}","releases_url":"https://api.github.com/repos/harishreedharan/spark/releases{/id}","created_at":"2014-04-03T22:17:22Z","updated_at":"2014-07-10T22:11:34Z","pushed_at":"2015-05-30T19:41:55Z","git_url":"git://github.com/harishreedharan/spark.git","ssh_url":"git@github.com:harishreedharan/spark.git","clone_url":"https://github.com/harishreedharan/spark.git","svn_url":"https://github.com/harishreedharan/spark","homepage":null,"size":102943,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"94f62a4979e4bc5f7bf4f5852d76977e097209e6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-06-01T20:11:39Z","pushed_at":"2015-06-01T22:13:23Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1803111,"stargazers_count":4171,"watchers_count":4171,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3662,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":330,"forks":3662,"open_issues":330,"watchers":4171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/6508"},"html":{"href":"https://github.com/apache/spark/pull/6508"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/6508"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/6508/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/6508/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/6508/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/ae932ffa53d49b99ae6392843a36e5cbc0c8e9f5"}}}}