{"action":"created","issue":{"url":"https://api.github.com/repos/thephpleague/fractal/issues/205","labels_url":"https://api.github.com/repos/thephpleague/fractal/issues/205/labels{/name}","comments_url":"https://api.github.com/repos/thephpleague/fractal/issues/205/comments","events_url":"https://api.github.com/repos/thephpleague/fractal/issues/205/events","html_url":"https://github.com/thephpleague/fractal/pull/205","id":101042327,"number":205,"title":"Update `JsonApiSerializer` to be compatible with JSON API v1.0","user":{"login":"felixkiss","id":256075,"avatar_url":"https://avatars.githubusercontent.com/u/256075?v=3","gravatar_id":"","url":"https://api.github.com/users/felixkiss","html_url":"https://github.com/felixkiss","followers_url":"https://api.github.com/users/felixkiss/followers","following_url":"https://api.github.com/users/felixkiss/following{/other_user}","gists_url":"https://api.github.com/users/felixkiss/gists{/gist_id}","starred_url":"https://api.github.com/users/felixkiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixkiss/subscriptions","organizations_url":"https://api.github.com/users/felixkiss/orgs","repos_url":"https://api.github.com/users/felixkiss/repos","events_url":"https://api.github.com/users/felixkiss/events{/privacy}","received_events_url":"https://api.github.com/users/felixkiss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-08-14T15:59:22Z","updated_at":"2015-08-20T22:59:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thephpleague/fractal/pulls/205","html_url":"https://github.com/thephpleague/fractal/pull/205","diff_url":"https://github.com/thephpleague/fractal/pull/205.diff","patch_url":"https://github.com/thephpleague/fractal/pull/205.patch"},"body":"I am using fractal for my API responses, which is consumed by an Ember app and want to have a Serializer that converts to JSON API v1.0 (which will be the default in Ember's future).\r\n\r\nI took a stab at the TODOs listed in #187:\r\n\r\n> What we need to do:\r\n>\r\n> - [x] Add links\r\n> - [x] Add relationships\r\n>     - [x] to-one\r\n>     - [x] to-many\r\n>     - [x] nested relationships\r\n>     - [x] empty relationships\r\n> - [x] Always set data as resource key\r\n> - [x] Rename includes to included\r\n> - [x] Included resources should be moved outside the data object\r\n> - [x] All resources should return id, type and attributes\r\n\r\nAdditional things to do:\r\n - [x] Write documentation for the new serializer\r\n\r\nI will try to add the remaining TODOs over this weekend.\r\n\r\nPlease provide feedback and mention any other things we need to get done before we can implement JSON APIs with fractal.\r\n\r\nCheers"},"comment":{"url":"https://api.github.com/repos/thephpleague/fractal/issues/comments/133206654","html_url":"https://github.com/thephpleague/fractal/pull/205#issuecomment-133206654","issue_url":"https://api.github.com/repos/thephpleague/fractal/issues/205","id":133206654,"user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"created_at":"2015-08-20T22:59:03Z","updated_at":"2015-08-20T22:59:03Z","body":"> @GrahamCampbell Exactly the same as in the commit you linked me too.\r\n\r\nNo it's not. Look at the context. Those statements are onlt used to break out of a logical block."}}