{"action":"created","comment":{"url":"https://api.github.com/repos/project-hatohol/hatohol/pulls/comments/32422988","id":32422988,"diff_hunk":"@@ -880,30 +1003,39 @@ string HatoholArmPluginGateHAPI2::procedureHandlerPutHostGroupMembership(\n {\n \tUnifiedDataStore *dataStore = UnifiedDataStore::getInstance();\n \tHostgroupMemberVect hostgroupMembershipVect;\n+\tJSONRPCErrorObject errObj;\n+\tCHECK_MANDATORY_PARAMS_EXISTENCE(\"params\", errObj);\n \tparser.startObject(\"params\");\n \n \tconst MonitoringServerInfo &serverInfo = m_impl->m_serverInfo;\n-\tbool succeeded = parseHostGroupMembershipParams(parser, hostgroupMembershipVect,\n-\t\t\t\t\t\t\tserverInfo);\n+\tbool succeeded = parseHostGroupMembershipParams(parser,\n+\t\t\t\t\t\t\thostgroupMembershipVect,\n+\t\t\t\t\t\t\tserverInfo, errObj);\n \tstring result = succeeded ? \"SUCCESS\" : \"FAILURE\";\n \n \tstring updateType;\n \tbool checkInvalidHostGroupMembership =\n-\t  parseUpdateType(parser, updateType);\n-\t// TODO: reflect error in response\n-\tif (checkInvalidHostGroupMembership) {\n-\t\tdataStore->syncHostgroupMembers(hostgroupMembershipVect, serverInfo.id);\n-\t} else {\n-\t\tdataStore->upsertHostgroupMembers(hostgroupMembershipVect);\n-\t}\n+\t\tparseUpdateType(parser, updateType, errObj);\n \tstring lastInfo;\n-\tif (!parser.read(\"lastInfo\", lastInfo) ) {\n+\tif (parser.read(\"lastInfo\", lastInfo) ) {\n \t\tupsertLastInfo(lastInfo, LAST_INFO_HOST_GROUP_MEMBERSHIP);","path":"server/src/HatoholArmPluginGateHAPI2.cc","position":507,"original_position":507,"commit_id":"8429817b9bfc35cb8bdb5f5917c75208f8fbe534","original_commit_id":"8429817b9bfc35cb8bdb5f5917c75208f8fbe534","user":{"login":"ashie","id":135104,"avatar_url":"https://avatars.githubusercontent.com/u/135104?v=3","gravatar_id":"","url":"https://api.github.com/users/ashie","html_url":"https://github.com/ashie","followers_url":"https://api.github.com/users/ashie/followers","following_url":"https://api.github.com/users/ashie/following{/other_user}","gists_url":"https://api.github.com/users/ashie/gists{/gist_id}","starred_url":"https://api.github.com/users/ashie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashie/subscriptions","organizations_url":"https://api.github.com/users/ashie/orgs","repos_url":"https://api.github.com/users/ashie/repos","events_url":"https://api.github.com/users/ashie/events{/privacy}","received_events_url":"https://api.github.com/users/ashie/received_events","type":"User","site_admin":false},"body":"ここも同様","created_at":"2015-06-15T14:07:01Z","updated_at":"2015-06-15T14:07:01Z","html_url":"https://github.com/project-hatohol/hatohol/pull/1242#discussion_r32422988","pull_request_url":"https://api.github.com/repos/project-hatohol/hatohol/pulls/1242","_links":{"self":{"href":"https://api.github.com/repos/project-hatohol/hatohol/pulls/comments/32422988"},"html":{"href":"https://github.com/project-hatohol/hatohol/pull/1242#discussion_r32422988"},"pull_request":{"href":"https://api.github.com/repos/project-hatohol/hatohol/pulls/1242"}}},"pull_request":{"url":"https://api.github.com/repos/project-hatohol/hatohol/pulls/1242","id":37667863,"html_url":"https://github.com/project-hatohol/hatohol/pull/1242","diff_url":"https://github.com/project-hatohol/hatohol/pull/1242.diff","patch_url":"https://github.com/project-hatohol/hatohol/pull/1242.patch","issue_url":"https://api.github.com/repos/project-hatohol/hatohol/issues/1242","number":1242,"state":"open","locked":false,"title":"[server][HAPI 2.0] Validate for mandatory JSON parameters","user":{"login":"cosmo0920","id":700876,"avatar_url":"https://avatars.githubusercontent.com/u/700876?v=3","gravatar_id":"","url":"https://api.github.com/users/cosmo0920","html_url":"https://github.com/cosmo0920","followers_url":"https://api.github.com/users/cosmo0920/followers","following_url":"https://api.github.com/users/cosmo0920/following{/other_user}","gists_url":"https://api.github.com/users/cosmo0920/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmo0920/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmo0920/subscriptions","organizations_url":"https://api.github.com/users/cosmo0920/orgs","repos_url":"https://api.github.com/users/cosmo0920/repos","events_url":"https://api.github.com/users/cosmo0920/events{/privacy}","received_events_url":"https://api.github.com/users/cosmo0920/received_events","type":"User","site_admin":false},"body":"* Add validation for mandatory JSON parameters","created_at":"2015-06-15T08:22:09Z","updated_at":"2015-06-15T14:07:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d95037de936c992f8a4e8b2c7138304bc5f8827","assignee":{"login":"ashie","id":135104,"avatar_url":"https://avatars.githubusercontent.com/u/135104?v=3","gravatar_id":"","url":"https://api.github.com/users/ashie","html_url":"https://github.com/ashie","followers_url":"https://api.github.com/users/ashie/followers","following_url":"https://api.github.com/users/ashie/following{/other_user}","gists_url":"https://api.github.com/users/ashie/gists{/gist_id}","starred_url":"https://api.github.com/users/ashie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashie/subscriptions","organizations_url":"https://api.github.com/users/ashie/orgs","repos_url":"https://api.github.com/users/ashie/repos","events_url":"https://api.github.com/users/ashie/events{/privacy}","received_events_url":"https://api.github.com/users/ashie/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/project-hatohol/hatohol/pulls/1242/commits","review_comments_url":"https://api.github.com/repos/project-hatohol/hatohol/pulls/1242/comments","review_comment_url":"https://api.github.com/repos/project-hatohol/hatohol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/project-hatohol/hatohol/issues/1242/comments","statuses_url":"https://api.github.com/repos/project-hatohol/hatohol/statuses/8429817b9bfc35cb8bdb5f5917c75208f8fbe534","head":{"label":"project-hatohol:HAPI-2.0-server-param-validation-2","ref":"HAPI-2.0-server-param-validation-2","sha":"8429817b9bfc35cb8bdb5f5917c75208f8fbe534","user":{"login":"project-hatohol","id":4715745,"avatar_url":"https://avatars.githubusercontent.com/u/4715745?v=3","gravatar_id":"","url":"https://api.github.com/users/project-hatohol","html_url":"https://github.com/project-hatohol","followers_url":"https://api.github.com/users/project-hatohol/followers","following_url":"https://api.github.com/users/project-hatohol/following{/other_user}","gists_url":"https://api.github.com/users/project-hatohol/gists{/gist_id}","starred_url":"https://api.github.com/users/project-hatohol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project-hatohol/subscriptions","organizations_url":"https://api.github.com/users/project-hatohol/orgs","repos_url":"https://api.github.com/users/project-hatohol/repos","events_url":"https://api.github.com/users/project-hatohol/events{/privacy}","received_events_url":"https://api.github.com/users/project-hatohol/received_events","type":"Organization","site_admin":false},"repo":{"id":10903163,"name":"hatohol","full_name":"project-hatohol/hatohol","owner":{"login":"project-hatohol","id":4715745,"avatar_url":"https://avatars.githubusercontent.com/u/4715745?v=3","gravatar_id":"","url":"https://api.github.com/users/project-hatohol","html_url":"https://github.com/project-hatohol","followers_url":"https://api.github.com/users/project-hatohol/followers","following_url":"https://api.github.com/users/project-hatohol/following{/other_user}","gists_url":"https://api.github.com/users/project-hatohol/gists{/gist_id}","starred_url":"https://api.github.com/users/project-hatohol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project-hatohol/subscriptions","organizations_url":"https://api.github.com/users/project-hatohol/orgs","repos_url":"https://api.github.com/users/project-hatohol/repos","events_url":"https://api.github.com/users/project-hatohol/events{/privacy}","received_events_url":"https://api.github.com/users/project-hatohol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/project-hatohol/hatohol","description":"A unified manager of monitoring software","fork":false,"url":"https://api.github.com/repos/project-hatohol/hatohol","forks_url":"https://api.github.com/repos/project-hatohol/hatohol/forks","keys_url":"https://api.github.com/repos/project-hatohol/hatohol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/project-hatohol/hatohol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/project-hatohol/hatohol/teams","hooks_url":"https://api.github.com/repos/project-hatohol/hatohol/hooks","issue_events_url":"https://api.github.com/repos/project-hatohol/hatohol/issues/events{/number}","events_url":"https://api.github.com/repos/project-hatohol/hatohol/events","assignees_url":"https://api.github.com/repos/project-hatohol/hatohol/assignees{/user}","branches_url":"https://api.github.com/repos/project-hatohol/hatohol/branches{/branch}","tags_url":"https://api.github.com/repos/project-hatohol/hatohol/tags","blobs_url":"https://api.github.com/repos/project-hatohol/hatohol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/project-hatohol/hatohol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/project-hatohol/hatohol/git/refs{/sha}","trees_url":"https://api.github.com/repos/project-hatohol/hatohol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/project-hatohol/hatohol/statuses/{sha}","languages_url":"https://api.github.com/repos/project-hatohol/hatohol/languages","stargazers_url":"https://api.github.com/repos/project-hatohol/hatohol/stargazers","contributors_url":"https://api.github.com/repos/project-hatohol/hatohol/contributors","subscribers_url":"https://api.github.com/repos/project-hatohol/hatohol/subscribers","subscription_url":"https://api.github.com/repos/project-hatohol/hatohol/subscription","commits_url":"https://api.github.com/repos/project-hatohol/hatohol/commits{/sha}","git_commits_url":"https://api.github.com/repos/project-hatohol/hatohol/git/commits{/sha}","comments_url":"https://api.github.com/repos/project-hatohol/hatohol/comments{/number}","issue_comment_url":"https://api.github.com/repos/project-hatohol/hatohol/issues/comments{/number}","contents_url":"https://api.github.com/repos/project-hatohol/hatohol/contents/{+path}","compare_url":"https://api.github.com/repos/project-hatohol/hatohol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/project-hatohol/hatohol/merges","archive_url":"https://api.github.com/repos/project-hatohol/hatohol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/project-hatohol/hatohol/downloads","issues_url":"https://api.github.com/repos/project-hatohol/hatohol/issues{/number}","pulls_url":"https://api.github.com/repos/project-hatohol/hatohol/pulls{/number}","milestones_url":"https://api.github.com/repos/project-hatohol/hatohol/milestones{/number}","notifications_url":"https://api.github.com/repos/project-hatohol/hatohol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/project-hatohol/hatohol/labels{/name}","releases_url":"https://api.github.com/repos/project-hatohol/hatohol/releases{/id}","created_at":"2013-06-24T08:45:56Z","updated_at":"2015-06-10T04:23:31Z","pushed_at":"2015-06-15T13:02:36Z","git_url":"git://github.com/project-hatohol/hatohol.git","ssh_url":"git@github.com:project-hatohol/hatohol.git","clone_url":"https://github.com/project-hatohol/hatohol.git","svn_url":"https://github.com/project-hatohol/hatohol","homepage":"http://www.hatohol.org/","size":55447,"stargazers_count":67,"watchers_count":67,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":87,"forks":18,"open_issues":87,"watchers":67,"default_branch":"master"}},"base":{"label":"project-hatohol:master","ref":"master","sha":"aaf7a0011b84a896f07d63f47da2b79721df2460","user":{"login":"project-hatohol","id":4715745,"avatar_url":"https://avatars.githubusercontent.com/u/4715745?v=3","gravatar_id":"","url":"https://api.github.com/users/project-hatohol","html_url":"https://github.com/project-hatohol","followers_url":"https://api.github.com/users/project-hatohol/followers","following_url":"https://api.github.com/users/project-hatohol/following{/other_user}","gists_url":"https://api.github.com/users/project-hatohol/gists{/gist_id}","starred_url":"https://api.github.com/users/project-hatohol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project-hatohol/subscriptions","organizations_url":"https://api.github.com/users/project-hatohol/orgs","repos_url":"https://api.github.com/users/project-hatohol/repos","events_url":"https://api.github.com/users/project-hatohol/events{/privacy}","received_events_url":"https://api.github.com/users/project-hatohol/received_events","type":"Organization","site_admin":false},"repo":{"id":10903163,"name":"hatohol","full_name":"project-hatohol/hatohol","owner":{"login":"project-hatohol","id":4715745,"avatar_url":"https://avatars.githubusercontent.com/u/4715745?v=3","gravatar_id":"","url":"https://api.github.com/users/project-hatohol","html_url":"https://github.com/project-hatohol","followers_url":"https://api.github.com/users/project-hatohol/followers","following_url":"https://api.github.com/users/project-hatohol/following{/other_user}","gists_url":"https://api.github.com/users/project-hatohol/gists{/gist_id}","starred_url":"https://api.github.com/users/project-hatohol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/project-hatohol/subscriptions","organizations_url":"https://api.github.com/users/project-hatohol/orgs","repos_url":"https://api.github.com/users/project-hatohol/repos","events_url":"https://api.github.com/users/project-hatohol/events{/privacy}","received_events_url":"https://api.github.com/users/project-hatohol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/project-hatohol/hatohol","description":"A unified manager of monitoring software","fork":false,"url":"https://api.github.com/repos/project-hatohol/hatohol","forks_url":"https://api.github.com/repos/project-hatohol/hatohol/forks","keys_url":"https://api.github.com/repos/project-hatohol/hatohol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/project-hatohol/hatohol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/project-hatohol/hatohol/teams","hooks_url":"https://api.github.com/repos/project-hatohol/hatohol/hooks","issue_events_url":"https://api.github.com/repos/project-hatohol/hatohol/issues/events{/number}","events_url":"https://api.github.com/repos/project-hatohol/hatohol/events","assignees_url":"https://api.github.com/repos/project-hatohol/hatohol/assignees{/user}","branches_url":"https://api.github.com/repos/project-hatohol/hatohol/branches{/branch}","tags_url":"https://api.github.com/repos/project-hatohol/hatohol/tags","blobs_url":"https://api.github.com/repos/project-hatohol/hatohol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/project-hatohol/hatohol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/project-hatohol/hatohol/git/refs{/sha}","trees_url":"https://api.github.com/repos/project-hatohol/hatohol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/project-hatohol/hatohol/statuses/{sha}","languages_url":"https://api.github.com/repos/project-hatohol/hatohol/languages","stargazers_url":"https://api.github.com/repos/project-hatohol/hatohol/stargazers","contributors_url":"https://api.github.com/repos/project-hatohol/hatohol/contributors","subscribers_url":"https://api.github.com/repos/project-hatohol/hatohol/subscribers","subscription_url":"https://api.github.com/repos/project-hatohol/hatohol/subscription","commits_url":"https://api.github.com/repos/project-hatohol/hatohol/commits{/sha}","git_commits_url":"https://api.github.com/repos/project-hatohol/hatohol/git/commits{/sha}","comments_url":"https://api.github.com/repos/project-hatohol/hatohol/comments{/number}","issue_comment_url":"https://api.github.com/repos/project-hatohol/hatohol/issues/comments{/number}","contents_url":"https://api.github.com/repos/project-hatohol/hatohol/contents/{+path}","compare_url":"https://api.github.com/repos/project-hatohol/hatohol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/project-hatohol/hatohol/merges","archive_url":"https://api.github.com/repos/project-hatohol/hatohol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/project-hatohol/hatohol/downloads","issues_url":"https://api.github.com/repos/project-hatohol/hatohol/issues{/number}","pulls_url":"https://api.github.com/repos/project-hatohol/hatohol/pulls{/number}","milestones_url":"https://api.github.com/repos/project-hatohol/hatohol/milestones{/number}","notifications_url":"https://api.github.com/repos/project-hatohol/hatohol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/project-hatohol/hatohol/labels{/name}","releases_url":"https://api.github.com/repos/project-hatohol/hatohol/releases{/id}","created_at":"2013-06-24T08:45:56Z","updated_at":"2015-06-10T04:23:31Z","pushed_at":"2015-06-15T13:02:36Z","git_url":"git://github.com/project-hatohol/hatohol.git","ssh_url":"git@github.com:project-hatohol/hatohol.git","clone_url":"https://github.com/project-hatohol/hatohol.git","svn_url":"https://github.com/project-hatohol/hatohol","homepage":"http://www.hatohol.org/","size":55447,"stargazers_count":67,"watchers_count":67,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":87,"forks":18,"open_issues":87,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/project-hatohol/hatohol/pulls/1242"},"html":{"href":"https://github.com/project-hatohol/hatohol/pull/1242"},"issue":{"href":"https://api.github.com/repos/project-hatohol/hatohol/issues/1242"},"comments":{"href":"https://api.github.com/repos/project-hatohol/hatohol/issues/1242/comments"},"review_comments":{"href":"https://api.github.com/repos/project-hatohol/hatohol/pulls/1242/comments"},"review_comment":{"href":"https://api.github.com/repos/project-hatohol/hatohol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/project-hatohol/hatohol/pulls/1242/commits"},"statuses":{"href":"https://api.github.com/repos/project-hatohol/hatohol/statuses/8429817b9bfc35cb8bdb5f5917c75208f8fbe534"}}}}