{"action":"created","comment":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/45813980","id":45813980,"diff_hunk":"@@ -7,8 +7,8 @@ ActiveAdmin.flash =\n     reference: ->\n       @reference\n     constructor: (@message, @type = \"notice\", close_after) ->\n-      @reference = jQuery(\"<div>\").addClass(\"flash flash_#{@type}\").text(@message)\n-      jQuery \".flashes\"\n+      @reference = jQuery(\"<div>\").addClass(\"flash flash-#{@type}\").text(@message)","path":"app/assets/javascripts/active_admin/lib/flash.js.coffee","position":6,"original_position":6,"commit_id":"4abad0aac0badbaa62d19b5ac8cb4a99b9632322","original_commit_id":"4abad0aac0badbaa62d19b5ac8cb4a99b9632322","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line exceeds maximum allowed length","created_at":"2015-11-25T00:08:12Z","updated_at":"2015-11-25T00:08:12Z","html_url":"https://github.com/activeadmin/activeadmin/pull/3862#discussion_r45813980","pull_request_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862","_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/45813980"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3862#discussion_r45813980"},"pull_request":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862"}}},"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862","id":31797608,"html_url":"https://github.com/activeadmin/activeadmin/pull/3862","diff_url":"https://github.com/activeadmin/activeadmin/pull/3862.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/3862.patch","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862","number":3862,"state":"open","locked":false,"title":"WIP: Overhaul CSS for maintainability and customization","user":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"body":"I've seen mention about CSS overhauls but nothing seems active, if anything years old. I'm streamlining the CSS to make it easier to maintain, improve and customize. This should make it much easier to move to a framework like Bootstrap or Foundation.\r\n\r\n- [x] Replace reset with normalize.css (resets make debugging horrendously difficult)\r\n- [x] Remove excessive styles e.g. gradients, shadows (keep default theme basic, only what’s necessary and we can build from there)\r\n- [x] Remove unnecessary styles (many have no effect or are repetitive, apply smarter defaults)\r\n  - [x] Clean up typography\r\n  - [x] Replace strip table even/odd classes with nth-child selectors \r\n  - [x] Fix calc in forms due to box-sizing:border-box global change\r\n  - [x] Clean up modal dialog styles\r\n- [x] Reduce selector specificity (3 ids and 1 class in one selector 😩)\r\n- [x] Replace id based selectors with class based ones but keeping ids in HTML in place\r\n- [x] Rename CSS class index_grid to index_as_grid and index_table to index_as_table\r\n- [ ] Simplify table_tools CSS to use button group approach (index_list.rb, scopes.rb)\r\n- [x] Remove excessive status_tag classes and focus only on a few\r\n- [x] Further status_tag component changes #3677\r\n- [x] Streamline Formtastic CSS (I've done the best I can here in just CSS, would to need to tweak HTML)\r\n- [x] Add indeterminate support to the checkbox toggler script (a la Gmail or GitHub for Mac)\r\n- [x] Configure component styles using variables (e.g. Foundation)\r\n- [x] Stop Hound'n me!\r\n- [x] Summary of removed assets and removed SASS variables for the changelog\r\n- [x] Remove inline styles, one [example](https://github.com/activeadmin/activeadmin/blob/d59db0321080f8f369a8fffd53dc5847b6015fc1/lib/active_admin/filters/resource_extension.rb#L166-L170) (by @timoschilling) [already completed](https://github.com/javierjulio/activeadmin/blob/update-css-with-overhaul/lib/active_admin/filters/resource_extension.rb#L165-L171)\r\n- [x] https://github.com/activeadmin/activeadmin/pull/3893#issuecomment-92332840 (by @timoschilling)\r\n- [x] check the Print CSS (by @timoschilling)\r\n\r\n## How can you help?\r\n\r\n* use my branch to test out how the changes are affecting your admin \r\n* translate new \"commented on\" locale text\r\n\r\n## Changelog\r\n\r\n\r\n* Streamlined CSS: removing outdated techniques, styles that have no effect, etc.\r\n* Modern theme with simpler selectors and defaults (less CSS) allowing easier customization.\r\n* Any un-styled buttons need classes now: `button button-default` or `button button-primary`.\r\n* Action Items no longer set default button styles, you can customize as necessary.\r\n  * Apply class of `button button-default` for a default button, or `button button-primary` for the primary button style.\r\n* Replaced reset with normalize.css (800% less noise in the debugger! 🎉).\r\n* `box-sizing: border-box` now applied globally to all elements.\r\n* Broke up deeply nested selectors as much as possible.\r\n* Removed orderable.png, nested_menu_arrow.gif and nested_menu_arrow_dark.gif images and replaced with CSS based arrows. #3612 \r\n* Removed datepicker-input-icon.png and replaced with \"Starts with\" and \"Ends with\" placeholders.\r\n* Removed dropdown_menu JS positioning (CSS can do this just fine).\r\n* Some internal Sass mixins have been removed: border-colors, sans-family, etc.\r\n* Added \"commented on\" to EN locale (we need translations).\r\n* Added indeterminate support to toggle all checkbox-toggler (e.g. toggle all in index tables).\r\n* Wrapped \"(Toggle Selection)\" checkbox for index_as_blog/block/grid in a label tag.\r\n* `status_tag` no longer accepts a type arg, so its now: `status_tag(status, options)`\r\n* TBD","created_at":"2015-03-24T05:04:13Z","updated_at":"2015-11-25T00:08:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7398f06aa0b3d2118b94f076761baac15e996e5b","assignee":null,"milestone":{"url":"https://api.github.com/repos/activeadmin/activeadmin/milestones/18","html_url":"https://github.com/activeadmin/activeadmin/milestones/1.0.0","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones/18/labels","id":302820,"number":18,"title":"1.0.0","description":"+ migrates from meta_search to its successor, ransack\r\n+ removes support for Rails < 3.2\r\n+ adds support for Rails 4","creator":{"login":"gregbell","id":719,"avatar_url":"https://avatars.githubusercontent.com/u/719?v=3","gravatar_id":"","url":"https://api.github.com/users/gregbell","html_url":"https://github.com/gregbell","followers_url":"https://api.github.com/users/gregbell/followers","following_url":"https://api.github.com/users/gregbell/following{/other_user}","gists_url":"https://api.github.com/users/gregbell/gists{/gist_id}","starred_url":"https://api.github.com/users/gregbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregbell/subscriptions","organizations_url":"https://api.github.com/users/gregbell/orgs","repos_url":"https://api.github.com/users/gregbell/repos","events_url":"https://api.github.com/users/gregbell/events{/privacy}","received_events_url":"https://api.github.com/users/gregbell/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":35,"state":"open","created_at":"2013-04-04T14:04:03Z","updated_at":"2015-11-23T04:26:20Z","due_on":"2014-03-29T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/commits","review_comments_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/comments","review_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862/comments","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/4abad0aac0badbaa62d19b5ac8cb4a99b9632322","head":{"label":"javierjulio:update-css-with-overhaul","ref":"update-css-with-overhaul","sha":"4abad0aac0badbaa62d19b5ac8cb4a99b9632322","user":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"repo":{"id":32771575,"name":"activeadmin","full_name":"javierjulio/activeadmin","owner":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javierjulio/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":true,"url":"https://api.github.com/repos/javierjulio/activeadmin","forks_url":"https://api.github.com/repos/javierjulio/activeadmin/forks","keys_url":"https://api.github.com/repos/javierjulio/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javierjulio/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javierjulio/activeadmin/teams","hooks_url":"https://api.github.com/repos/javierjulio/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/javierjulio/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/javierjulio/activeadmin/events","assignees_url":"https://api.github.com/repos/javierjulio/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/javierjulio/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/javierjulio/activeadmin/tags","blobs_url":"https://api.github.com/repos/javierjulio/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javierjulio/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javierjulio/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/javierjulio/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javierjulio/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/javierjulio/activeadmin/languages","stargazers_url":"https://api.github.com/repos/javierjulio/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/javierjulio/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/javierjulio/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/javierjulio/activeadmin/subscription","commits_url":"https://api.github.com/repos/javierjulio/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/javierjulio/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/javierjulio/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/javierjulio/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/javierjulio/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/javierjulio/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javierjulio/activeadmin/merges","archive_url":"https://api.github.com/repos/javierjulio/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javierjulio/activeadmin/downloads","issues_url":"https://api.github.com/repos/javierjulio/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/javierjulio/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/javierjulio/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/javierjulio/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javierjulio/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/javierjulio/activeadmin/releases{/id}","created_at":"2015-03-24T02:32:35Z","updated_at":"2015-04-22T19:41:12Z","pushed_at":"2015-11-25T00:07:57Z","git_url":"git://github.com/javierjulio/activeadmin.git","ssh_url":"git@github.com:javierjulio/activeadmin.git","clone_url":"https://github.com/javierjulio/activeadmin.git","svn_url":"https://github.com/javierjulio/activeadmin","homepage":"activeadmin.info","size":7646,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activeadmin:master","ref":"master","sha":"d787029e5523be2eb2ed99816eb0cecca2b72862","user":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":611921,"name":"activeadmin","full_name":"activeadmin/activeadmin","owner":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeadmin/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":false,"url":"https://api.github.com/repos/activeadmin/activeadmin","forks_url":"https://api.github.com/repos/activeadmin/activeadmin/forks","keys_url":"https://api.github.com/repos/activeadmin/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeadmin/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeadmin/activeadmin/teams","hooks_url":"https://api.github.com/repos/activeadmin/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/activeadmin/activeadmin/events","assignees_url":"https://api.github.com/repos/activeadmin/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/activeadmin/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/activeadmin/activeadmin/tags","blobs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeadmin/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeadmin/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/activeadmin/activeadmin/languages","stargazers_url":"https://api.github.com/repos/activeadmin/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/activeadmin/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/activeadmin/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/activeadmin/activeadmin/subscription","commits_url":"https://api.github.com/repos/activeadmin/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeadmin/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeadmin/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/activeadmin/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeadmin/activeadmin/merges","archive_url":"https://api.github.com/repos/activeadmin/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeadmin/activeadmin/downloads","issues_url":"https://api.github.com/repos/activeadmin/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/activeadmin/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/activeadmin/activeadmin/releases{/id}","created_at":"2010-04-15T14:26:03Z","updated_at":"2015-11-24T16:49:35Z","pushed_at":"2015-11-25T00:07:58Z","git_url":"git://github.com/activeadmin/activeadmin.git","ssh_url":"git@github.com:activeadmin/activeadmin.git","clone_url":"https://github.com/activeadmin/activeadmin.git","svn_url":"https://github.com/activeadmin/activeadmin","homepage":"activeadmin.info","size":10549,"stargazers_count":6353,"watchers_count":6353,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2273,"mirror_url":null,"open_issues_count":198,"forks":2273,"open_issues":198,"watchers":6353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3862"},"issue":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862"},"comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862/comments"},"review_comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/comments"},"review_comment":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/commits"},"statuses":{"href":"https://api.github.com/repos/activeadmin/activeadmin/statuses/4abad0aac0badbaa62d19b5ac8cb4a99b9632322"}}}}