{"action":"created","issue":{"url":"https://api.github.com/repos/softlayer/sl-ember-components/issues/1071","labels_url":"https://api.github.com/repos/softlayer/sl-ember-components/issues/1071/labels{/name}","comments_url":"https://api.github.com/repos/softlayer/sl-ember-components/issues/1071/comments","events_url":"https://api.github.com/repos/softlayer/sl-ember-components/issues/1071/events","html_url":"https://github.com/softlayer/sl-ember-components/pull/1071","id":114637800,"number":1071,"title":"Closes softlayer/sl-ember-components#783","user":{"login":"SpikedKira","id":9935157,"avatar_url":"https://avatars.githubusercontent.com/u/9935157?v=3","gravatar_id":"","url":"https://api.github.com/users/SpikedKira","html_url":"https://github.com/SpikedKira","followers_url":"https://api.github.com/users/SpikedKira/followers","following_url":"https://api.github.com/users/SpikedKira/following{/other_user}","gists_url":"https://api.github.com/users/SpikedKira/gists{/gist_id}","starred_url":"https://api.github.com/users/SpikedKira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpikedKira/subscriptions","organizations_url":"https://api.github.com/users/SpikedKira/orgs","repos_url":"https://api.github.com/users/SpikedKira/repos","events_url":"https://api.github.com/users/SpikedKira/events{/privacy}","received_events_url":"https://api.github.com/users/SpikedKira/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/softlayer/sl-ember-components/labels/in%20review","name":"in review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-02T17:00:51Z","updated_at":"2015-11-02T20:24:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/softlayer/sl-ember-components/pulls/1071","html_url":"https://github.com/softlayer/sl-ember-components/pull/1071","diff_url":"https://github.com/softlayer/sl-ember-components/pull/1071.diff","patch_url":"https://github.com/softlayer/sl-ember-components/pull/1071.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/softlayer/sl-ember-components/1071)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/softlayer/sl-ember-components/issues/comments/153146467","html_url":"https://github.com/softlayer/sl-ember-components/pull/1071#issuecomment-153146467","issue_url":"https://api.github.com/repos/softlayer/sl-ember-components/issues/1071","id":153146467,"user":{"login":"SpikedKira","id":9935157,"avatar_url":"https://avatars.githubusercontent.com/u/9935157?v=3","gravatar_id":"","url":"https://api.github.com/users/SpikedKira","html_url":"https://github.com/SpikedKira","followers_url":"https://api.github.com/users/SpikedKira/followers","following_url":"https://api.github.com/users/SpikedKira/following{/other_user}","gists_url":"https://api.github.com/users/SpikedKira/gists{/gist_id}","starred_url":"https://api.github.com/users/SpikedKira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpikedKira/subscriptions","organizations_url":"https://api.github.com/users/SpikedKira/orgs","repos_url":"https://api.github.com/users/SpikedKira/repos","events_url":"https://api.github.com/users/SpikedKira/events{/privacy}","received_events_url":"https://api.github.com/users/SpikedKira/received_events","type":"User","site_admin":false},"created_at":"2015-11-02T20:24:56Z","updated_at":"2015-11-02T20:24:56Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n<sup>**[tests/integration/components/sl-calendar-test.js, line 51 \\[r1\\]](https://reviewable.io:443/reviews/softlayer/sl-ember-components/1071#-K28dqa4targrH-6kyNA)** ([raw file](https://github.com/softlayer/sl-ember-components/blob/1017bc2dd61ec84a08f7dd98c80636cd41c97a22/tests/integration/components/sl-calendar-test.js#L51)):</sup>\n1) those are passed through, not applied to generated.\n2) roger that\n3) i think this is the same as your 2nd bullet point?\n<!-- Reviewable comment -K28lqSHVzaMz5GmpmR0:1934222812 -->\n\n---\n\n<sup>**[tests/integration/components/sl-calendar-test.js, line 67 \\[r1\\]](https://reviewable.io:443/reviews/softlayer/sl-ember-components/1071#-K28eiILmxoameueOQ5-)** ([raw file](https://github.com/softlayer/sl-ember-components/blob/1017bc2dd61ec84a08f7dd98c80636cd41c97a22/tests/integration/components/sl-calendar-test.js#L67)):</sup>\nyes, I suppose so.  I was trying to prevent grabbing an element inside of a td that happened to have the same class.  I suppose we control that in the test environment though, so it's moot.\n<!-- Reviewable comment -K28kR5szZF6QJNpDGnR:-740407775 -->\n\n---\n\n<sup>**[tests/integration/components/sl-calendar-test.js, line 70 \\[r1\\]](https://reviewable.io:443/reviews/softlayer/sl-ember-components/1071#-K28eoTJ5AMQJQGb5QRv)** ([raw file](https://github.com/softlayer/sl-ember-components/blob/1017bc2dd61ec84a08f7dd98c80636cd41c97a22/tests/integration/components/sl-calendar-test.js#L70)):</sup>\nThose two are reused by the 2nd piece of logic, both pieces of logic have a comment that starts them.  These two lets are outside of both b/c they are used in both.  Still feel like they should be moved?\n<!-- Reviewable comment -K28lO0HTMpBHEAR8a3E:-1726708834 -->\n\n---\n\n<sup>**[tests/integration/components/sl-calendar-test.js, line 75 \\[r1\\]](https://reviewable.io:443/reviews/softlayer/sl-ember-components/1071#-K28evALDQTY7NT3B0qy)** ([raw file](https://github.com/softlayer/sl-ember-components/blob/1017bc2dd61ec84a08f7dd98c80636cd41c97a22/tests/integration/components/sl-calendar-test.js#L75)):</sup>\nwhoops; expected lint to catch this\n<!-- Reviewable comment -K28ladfNBZZdJ76fs5Y:503900533 -->\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/softlayer/sl-ember-components/1071)\n<!-- Sent from Reviewable.io -->\n"}}