{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/1392","labels_url":"https://api.github.com/repos/ripple/rippled/issues/1392/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1392/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/1392/events","html_url":"https://github.com/ripple/rippled/pull/1392","id":116028191,"number":1392,"title":"Force STAccount to 160-bit size (RIPD-994)","user":{"login":"scottschurr","id":7840379,"avatar_url":"https://avatars.githubusercontent.com/u/7840379?v=3","gravatar_id":"","url":"https://api.github.com/users/scottschurr","html_url":"https://github.com/scottschurr","followers_url":"https://api.github.com/users/scottschurr/followers","following_url":"https://api.github.com/users/scottschurr/following{/other_user}","gists_url":"https://api.github.com/users/scottschurr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottschurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottschurr/subscriptions","organizations_url":"https://api.github.com/users/scottschurr/orgs","repos_url":"https://api.github.com/users/scottschurr/repos","events_url":"https://api.github.com/users/scottschurr/events{/privacy}","received_events_url":"https://api.github.com/users/scottschurr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ripple/rippled/labels/David","name":"David","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Nik","name":"Nik","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-10T05:07:54Z","updated_at":"2015-11-12T23:26:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1392","html_url":"https://github.com/ripple/rippled/pull/1392","diff_url":"https://github.com/ripple/rippled/pull/1392.diff","patch_url":"https://github.com/ripple/rippled/pull/1392.patch"},"body":"Things to consider in this pull request:\r\n\r\n 1. Do you agree with my assessment that it is okay to throw in the STAccount constructor? If not, what is the alternative?\r\n\r\n 2. Do you agree that these changes correctly enforce that a non-default STAccount is always 160 bits?\r\n\r\n 3. Do the added unit tests provide adequate coverage?\r\n\r\n 4. Did I correctly leave the serialization format of STAccount unchanged?\r\n\r\nI have enough uncertainty about the serialization consequences that I'd like really knowledgeable reviewers: @nbougalis, @JoelKatz. There are not a lot of changes. Hopefully the review will be quick. Thanks.\r\n"},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/156269447","html_url":"https://github.com/ripple/rippled/pull/1392#issuecomment-156269447","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1392","id":156269447,"user":{"login":"JoelKatz","id":877549,"avatar_url":"https://avatars.githubusercontent.com/u/877549?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelKatz","html_url":"https://github.com/JoelKatz","followers_url":"https://api.github.com/users/JoelKatz/followers","following_url":"https://api.github.com/users/JoelKatz/following{/other_user}","gists_url":"https://api.github.com/users/JoelKatz/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelKatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelKatz/subscriptions","organizations_url":"https://api.github.com/users/JoelKatz/orgs","repos_url":"https://api.github.com/users/JoelKatz/repos","events_url":"https://api.github.com/users/JoelKatz/events{/privacy}","received_events_url":"https://api.github.com/users/JoelKatz/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T23:26:03Z","updated_at":"2015-11-12T23:26:03Z","body":"These changes all look fine to me. :+1: "}}