{"action":"opened","number":100,"pull_request":{"url":"https://api.github.com/repos/concord-consortium/lab/pulls/100","id":44448743,"html_url":"https://github.com/concord-consortium/lab/pull/100","diff_url":"https://github.com/concord-consortium/lab/pull/100.diff","patch_url":"https://github.com/concord-consortium/lab/pull/100.patch","issue_url":"https://api.github.com/repos/concord-consortium/lab/issues/100","number":100,"state":"open","locked":false,"title":"Energy2D: fix calculation of simulation cells taken by shapes","user":{"login":"pjanik","id":767857,"avatar_url":"https://avatars.githubusercontent.com/u/767857?v=3","gravatar_id":"","url":"https://api.github.com/users/pjanik","html_url":"https://github.com/pjanik","followers_url":"https://api.github.com/users/pjanik/followers","following_url":"https://api.github.com/users/pjanik/following{/other_user}","gists_url":"https://api.github.com/users/pjanik/gists{/gist_id}","starred_url":"https://api.github.com/users/pjanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjanik/subscriptions","organizations_url":"https://api.github.com/users/pjanik/orgs","repos_url":"https://api.github.com/users/pjanik/repos","events_url":"https://api.github.com/users/pjanik/events{/privacy}","received_events_url":"https://api.github.com/users/pjanik/received_events","type":"User","site_admin":false},"body":"The PR is necessary to fix this model:\r\nhttp://lab.concord.org/interactives.html#interactives/energy2d/htb/S5A1.json \r\ntogether with a small change to the model itself:\r\nhttps://github.com/concord-consortium/lab-interactives-site/commit/73a5a1a294ded2566af391c94d169f65c70f9784\r\n\r\nFixed model:\r\nhttp://lab.concord.org/branch/energy2d-fix/interactives.html#interactives/energy2d/htb/S5A1.json\r\n\r\nShort description:\r\nEach part / shape in Energy2D occupies some simulation grid cells. Those cells were calculated incorrectly, so average temperate at the edge of shape was different in Java and JS versions. That was causing incorrect radiation energy, which is based exactly on that.\r\n\r\nThere was also another issues related to floating point precision which is fixed in the S5A1.JSON itself.\r\n\r\nThis change seems small, but it can affect other models. Especially when parts are touching each other and energy is transferred between them. I've quickly tested all the models under \"Energy2D: Heat Transfer\" category and they seem fine.","created_at":"2015-09-08T15:47:20Z","updated_at":"2015-09-08T15:47:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91d5ffedfd05dc9d43580df7df5e3f1fb3853b4d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/concord-consortium/lab/pulls/100/commits","review_comments_url":"https://api.github.com/repos/concord-consortium/lab/pulls/100/comments","review_comment_url":"https://api.github.com/repos/concord-consortium/lab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concord-consortium/lab/issues/100/comments","statuses_url":"https://api.github.com/repos/concord-consortium/lab/statuses/6b4e2105dbddd88c9d7427ad827300d6305a915c","head":{"label":"concord-consortium:energy2d-fix","ref":"energy2d-fix","sha":"6b4e2105dbddd88c9d7427ad827300d6305a915c","user":{"login":"concord-consortium","id":319219,"avatar_url":"https://avatars.githubusercontent.com/u/319219?v=3","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":2774959,"name":"lab","full_name":"concord-consortium/lab","owner":{"login":"concord-consortium","id":319219,"avatar_url":"https://avatars.githubusercontent.com/u/319219?v=3","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concord-consortium/lab","description":"HTML5-based scientific models, visualizations, graphing, and probeware","fork":false,"url":"https://api.github.com/repos/concord-consortium/lab","forks_url":"https://api.github.com/repos/concord-consortium/lab/forks","keys_url":"https://api.github.com/repos/concord-consortium/lab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/lab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/lab/teams","hooks_url":"https://api.github.com/repos/concord-consortium/lab/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/lab/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/lab/events","assignees_url":"https://api.github.com/repos/concord-consortium/lab/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/lab/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/lab/tags","blobs_url":"https://api.github.com/repos/concord-consortium/lab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/lab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/lab/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/lab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/lab/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/lab/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/lab/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/lab/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/lab/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/lab/subscription","commits_url":"https://api.github.com/repos/concord-consortium/lab/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/lab/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/lab/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/lab/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/lab/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/lab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/lab/merges","archive_url":"https://api.github.com/repos/concord-consortium/lab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/lab/downloads","issues_url":"https://api.github.com/repos/concord-consortium/lab/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/lab/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/lab/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/lab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/lab/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/lab/releases{/id}","created_at":"2011-11-14T20:20:50Z","updated_at":"2015-05-24T04:44:22Z","pushed_at":"2015-09-08T15:47:20Z","git_url":"git://github.com/concord-consortium/lab.git","ssh_url":"git@github.com:concord-consortium/lab.git","clone_url":"https://github.com/concord-consortium/lab.git","svn_url":"https://github.com/concord-consortium/lab","homepage":"http://lab-framework.concord.org/","size":143502,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":18,"forks":26,"open_issues":18,"watchers":39,"default_branch":"master"}},"base":{"label":"concord-consortium:master","ref":"master","sha":"0530d0b6796ee3797e7d472965f2224f55dec9d7","user":{"login":"concord-consortium","id":319219,"avatar_url":"https://avatars.githubusercontent.com/u/319219?v=3","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":2774959,"name":"lab","full_name":"concord-consortium/lab","owner":{"login":"concord-consortium","id":319219,"avatar_url":"https://avatars.githubusercontent.com/u/319219?v=3","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concord-consortium/lab","description":"HTML5-based scientific models, visualizations, graphing, and probeware","fork":false,"url":"https://api.github.com/repos/concord-consortium/lab","forks_url":"https://api.github.com/repos/concord-consortium/lab/forks","keys_url":"https://api.github.com/repos/concord-consortium/lab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/lab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/lab/teams","hooks_url":"https://api.github.com/repos/concord-consortium/lab/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/lab/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/lab/events","assignees_url":"https://api.github.com/repos/concord-consortium/lab/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/lab/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/lab/tags","blobs_url":"https://api.github.com/repos/concord-consortium/lab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/lab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/lab/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/lab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/lab/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/lab/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/lab/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/lab/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/lab/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/lab/subscription","commits_url":"https://api.github.com/repos/concord-consortium/lab/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/lab/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/lab/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/lab/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/lab/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/lab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/lab/merges","archive_url":"https://api.github.com/repos/concord-consortium/lab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/lab/downloads","issues_url":"https://api.github.com/repos/concord-consortium/lab/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/lab/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/lab/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/lab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/lab/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/lab/releases{/id}","created_at":"2011-11-14T20:20:50Z","updated_at":"2015-05-24T04:44:22Z","pushed_at":"2015-09-08T15:47:20Z","git_url":"git://github.com/concord-consortium/lab.git","ssh_url":"git@github.com:concord-consortium/lab.git","clone_url":"https://github.com/concord-consortium/lab.git","svn_url":"https://github.com/concord-consortium/lab","homepage":"http://lab-framework.concord.org/","size":143502,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":18,"forks":26,"open_issues":18,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/lab/pulls/100"},"html":{"href":"https://github.com/concord-consortium/lab/pull/100"},"issue":{"href":"https://api.github.com/repos/concord-consortium/lab/issues/100"},"comments":{"href":"https://api.github.com/repos/concord-consortium/lab/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/concord-consortium/lab/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/concord-consortium/lab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concord-consortium/lab/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/concord-consortium/lab/statuses/6b4e2105dbddd88c9d7427ad827300d6305a915c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":2}}