{"action":"created","issue":{"url":"https://api.github.com/repos/LeanKit-Labs/hyped/issues/18","labels_url":"https://api.github.com/repos/LeanKit-Labs/hyped/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/LeanKit-Labs/hyped/issues/18/comments","events_url":"https://api.github.com/repos/LeanKit-Labs/hyped/issues/18/events","html_url":"https://github.com/LeanKit-Labs/hyped/pull/18","id":111778348,"number":18,"title":"They asked for asynchronous authorization, click here to see what happened next!","user":{"login":"arobson","id":115508,"avatar_url":"https://avatars.githubusercontent.com/u/115508?v=3","gravatar_id":"","url":"https://api.github.com/users/arobson","html_url":"https://github.com/arobson","followers_url":"https://api.github.com/users/arobson/followers","following_url":"https://api.github.com/users/arobson/following{/other_user}","gists_url":"https://api.github.com/users/arobson/gists{/gist_id}","starred_url":"https://api.github.com/users/arobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arobson/subscriptions","organizations_url":"https://api.github.com/users/arobson/orgs","repos_url":"https://api.github.com/users/arobson/repos","events_url":"https://api.github.com/users/arobson/events{/privacy}","received_events_url":"https://api.github.com/users/arobson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-16T07:44:08Z","updated_at":"2015-10-16T13:46:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LeanKit-Labs/hyped/pulls/18","html_url":"https://github.com/LeanKit-Labs/hyped/pull/18","diff_url":"https://github.com/LeanKit-Labs/hyped/pull/18.diff","patch_url":"https://github.com/LeanKit-Labs/hyped/pull/18.patch"},"body":"Keep in mind that a good bit of the change set is due to hyperResource getting separated into multiple files (which was mirrored in the specs). After that, the majority of changes are from taking a stack that was synchronous and changing it to support async calls. The features I added outside of that resulted in very little of the resulting change set.\r\n\r\nI also refactored and renamed several functions in an attempt to make this code base easier to follow in general. On the upside, the code improved, async authorize is supported, url parameters get filled from incoming requests, and you have tighter control over hypermedia included in responses.\r\n\r\nOn the downside, it's still more to look over than is ideal.\r\n\r\n* Allow authorize to return a promise\r\n* Add `hidden` feature to exclude actions from OPTIONS hyperlinks\r\n* Add `actions` property to control which actions are included in hyperlinks\r\n* Fill out URL parameters in action links from incoming request data\r\n* Refactor hyperResource into multiple modules\r\n* Rework tests to reflect new module separation"},"comment":{"url":"https://api.github.com/repos/LeanKit-Labs/hyped/issues/comments/148720836","html_url":"https://github.com/LeanKit-Labs/hyped/pull/18#issuecomment-148720836","issue_url":"https://api.github.com/repos/LeanKit-Labs/hyped/issues/18","id":148720836,"user":{"login":"arobson","id":115508,"avatar_url":"https://avatars.githubusercontent.com/u/115508?v=3","gravatar_id":"","url":"https://api.github.com/users/arobson","html_url":"https://github.com/arobson","followers_url":"https://api.github.com/users/arobson/followers","following_url":"https://api.github.com/users/arobson/following{/other_user}","gists_url":"https://api.github.com/users/arobson/gists{/gist_id}","starred_url":"https://api.github.com/users/arobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arobson/subscriptions","organizations_url":"https://api.github.com/users/arobson/orgs","repos_url":"https://api.github.com/users/arobson/repos","events_url":"https://api.github.com/users/arobson/events{/privacy}","received_events_url":"https://api.github.com/users/arobson/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T13:46:47Z","updated_at":"2015-10-16T13:46:47Z","body":"@calvinb - bother, I thought I'd nuked all of the timing stuff. I think having them is good in general but they being in a different suite and now that it's all promised based my original approach isn't correct for all cases. I'll get this removed shortly. "}}