{"action":"created","issue":{"url":"https://api.github.com/repos/pgherveou/gulp-awspublish/issues/38","labels_url":"https://api.github.com/repos/pgherveou/gulp-awspublish/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/pgherveou/gulp-awspublish/issues/38/comments","events_url":"https://api.github.com/repos/pgherveou/gulp-awspublish/issues/38/events","html_url":"https://github.com/pgherveou/gulp-awspublish/pull/38","id":55667992,"number":38,"title":"refactored to use aws-sdk instead of knox","user":{"login":"mshick","id":277401,"avatar_url":"https://avatars.githubusercontent.com/u/277401?v=3","gravatar_id":"","url":"https://api.github.com/users/mshick","html_url":"https://github.com/mshick","followers_url":"https://api.github.com/users/mshick/followers","following_url":"https://api.github.com/users/mshick/following{/other_user}","gists_url":"https://api.github.com/users/mshick/gists{/gist_id}","starred_url":"https://api.github.com/users/mshick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshick/subscriptions","organizations_url":"https://api.github.com/users/mshick/orgs","repos_url":"https://api.github.com/users/mshick/repos","events_url":"https://api.github.com/users/mshick/events{/privacy}","received_events_url":"https://api.github.com/users/mshick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-01-27T20:09:11Z","updated_at":"2015-01-28T22:05:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pgherveou/gulp-awspublish/pulls/38","html_url":"https://github.com/pgherveou/gulp-awspublish/pull/38","diff_url":"https://github.com/pgherveou/gulp-awspublish/pull/38.diff","patch_url":"https://github.com/pgherveou/gulp-awspublish/pull/38.patch"},"body":"Per #32 I've refactored the module to use the aws-sdk instead of Knox.\r\n\r\nI haven't added or removed any functionality -- just replaced Knox and dependent modules with aws-sdk and one other dependency.\r\n\r\nI think this is worthwhile because it seems aws-sdk will have better long term support. I'd also like to add functionality that handles the `putBucketWebsite` for a more complete package, and I found that nearly impossible to do with Knox."},"comment":{"url":"https://api.github.com/repos/pgherveou/gulp-awspublish/issues/comments/71926462","html_url":"https://github.com/pgherveou/gulp-awspublish/pull/38#issuecomment-71926462","issue_url":"https://api.github.com/repos/pgherveou/gulp-awspublish/issues/38","id":71926462,"user":{"login":"pgherveou","id":521091,"avatar_url":"https://avatars.githubusercontent.com/u/521091?v=3","gravatar_id":"","url":"https://api.github.com/users/pgherveou","html_url":"https://github.com/pgherveou","followers_url":"https://api.github.com/users/pgherveou/followers","following_url":"https://api.github.com/users/pgherveou/following{/other_user}","gists_url":"https://api.github.com/users/pgherveou/gists{/gist_id}","starred_url":"https://api.github.com/users/pgherveou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgherveou/subscriptions","organizations_url":"https://api.github.com/users/pgherveou/orgs","repos_url":"https://api.github.com/users/pgherveou/repos","events_url":"https://api.github.com/users/pgherveou/events{/privacy}","received_events_url":"https://api.github.com/users/pgherveou/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T22:05:26Z","updated_at":"2015-01-28T22:05:26Z","body":"I reviewed your code and encountered some errors with the xml-stream package under node 0.10\r\n\r\nI found a simpler solution for the sync method that make everything works under 0.10 and make things a bit more readable.\r\n\r\nhttps://gist.github.com/pgherveou/ddb020679f3add7179c0\r\n\r\ncan you copy paste that to your index.js so I can merge?"}}