{"action":"closed","number":48,"pull_request":{"url":"https://api.github.com/repos/wikimedia/service-template-node/pulls/48","id":47900348,"html_url":"https://github.com/wikimedia/service-template-node/pull/48","diff_url":"https://github.com/wikimedia/service-template-node/pull/48.diff","patch_url":"https://github.com/wikimedia/service-template-node/pull/48.patch","issue_url":"https://api.github.com/repos/wikimedia/service-template-node/issues/48","number":48,"state":"closed","locked":false,"title":"Logging: header whitelisting","user":{"login":"d00rman","id":10210173,"avatar_url":"https://avatars.githubusercontent.com/u/10210173?v=3","gravatar_id":"","url":"https://api.github.com/users/d00rman","html_url":"https://github.com/d00rman","followers_url":"https://api.github.com/users/d00rman/followers","following_url":"https://api.github.com/users/d00rman/following{/other_user}","gists_url":"https://api.github.com/users/d00rman/gists{/gist_id}","starred_url":"https://api.github.com/users/d00rman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d00rman/subscriptions","organizations_url":"https://api.github.com/users/d00rman/orgs","repos_url":"https://api.github.com/users/d00rman/repos","events_url":"https://api.github.com/users/d00rman/events{/privacy}","received_events_url":"https://api.github.com/users/d00rman/received_events","type":"User","site_admin":false},"body":"Headers can and often do contain sensitive user information (IP, cookies, etc.) which should not be kept around and stored. Here we set up configuration-based header whitelisting. By default, the following headers are whitelisted:\r\n- `cache-control`\r\n- `content-type`\r\n- `content-length`\r\n- `if-match`\r\n- `user-agent`\r\n- `x-request-id`\r\n\r\nBug: [T112072](https://phabricator.wikimedia.org/T112072)","created_at":"2015-10-16T11:44:10Z","updated_at":"2015-10-19T08:34:52Z","closed_at":"2015-10-19T08:34:52Z","merged_at":"2015-10-19T08:34:52Z","merge_commit_sha":"335f0c954f4462690863f4e48ebfceab30f4a932","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/service-template-node/pulls/48/commits","review_comments_url":"https://api.github.com/repos/wikimedia/service-template-node/pulls/48/comments","review_comment_url":"https://api.github.com/repos/wikimedia/service-template-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/service-template-node/issues/48/comments","statuses_url":"https://api.github.com/repos/wikimedia/service-template-node/statuses/d1993dbc22dc9fafd22b49052279cd6915f1b1e6","head":{"label":"d00rman:logging/header-whitelist","ref":"logging/header-whitelist","sha":"d1993dbc22dc9fafd22b49052279cd6915f1b1e6","user":{"login":"d00rman","id":10210173,"avatar_url":"https://avatars.githubusercontent.com/u/10210173?v=3","gravatar_id":"","url":"https://api.github.com/users/d00rman","html_url":"https://github.com/d00rman","followers_url":"https://api.github.com/users/d00rman/followers","following_url":"https://api.github.com/users/d00rman/following{/other_user}","gists_url":"https://api.github.com/users/d00rman/gists{/gist_id}","starred_url":"https://api.github.com/users/d00rman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d00rman/subscriptions","organizations_url":"https://api.github.com/users/d00rman/orgs","repos_url":"https://api.github.com/users/d00rman/repos","events_url":"https://api.github.com/users/d00rman/events{/privacy}","received_events_url":"https://api.github.com/users/d00rman/received_events","type":"User","site_admin":false},"repo":{"id":30872600,"name":"service-template-node","full_name":"d00rman/service-template-node","owner":{"login":"d00rman","id":10210173,"avatar_url":"https://avatars.githubusercontent.com/u/10210173?v=3","gravatar_id":"","url":"https://api.github.com/users/d00rman","html_url":"https://github.com/d00rman","followers_url":"https://api.github.com/users/d00rman/followers","following_url":"https://api.github.com/users/d00rman/following{/other_user}","gists_url":"https://api.github.com/users/d00rman/gists{/gist_id}","starred_url":"https://api.github.com/users/d00rman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d00rman/subscriptions","organizations_url":"https://api.github.com/users/d00rman/orgs","repos_url":"https://api.github.com/users/d00rman/repos","events_url":"https://api.github.com/users/d00rman/events{/privacy}","received_events_url":"https://api.github.com/users/d00rman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d00rman/service-template-node","description":"Template for creating MediaWiki Services in Node.js","fork":true,"url":"https://api.github.com/repos/d00rman/service-template-node","forks_url":"https://api.github.com/repos/d00rman/service-template-node/forks","keys_url":"https://api.github.com/repos/d00rman/service-template-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d00rman/service-template-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d00rman/service-template-node/teams","hooks_url":"https://api.github.com/repos/d00rman/service-template-node/hooks","issue_events_url":"https://api.github.com/repos/d00rman/service-template-node/issues/events{/number}","events_url":"https://api.github.com/repos/d00rman/service-template-node/events","assignees_url":"https://api.github.com/repos/d00rman/service-template-node/assignees{/user}","branches_url":"https://api.github.com/repos/d00rman/service-template-node/branches{/branch}","tags_url":"https://api.github.com/repos/d00rman/service-template-node/tags","blobs_url":"https://api.github.com/repos/d00rman/service-template-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d00rman/service-template-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d00rman/service-template-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/d00rman/service-template-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d00rman/service-template-node/statuses/{sha}","languages_url":"https://api.github.com/repos/d00rman/service-template-node/languages","stargazers_url":"https://api.github.com/repos/d00rman/service-template-node/stargazers","contributors_url":"https://api.github.com/repos/d00rman/service-template-node/contributors","subscribers_url":"https://api.github.com/repos/d00rman/service-template-node/subscribers","subscription_url":"https://api.github.com/repos/d00rman/service-template-node/subscription","commits_url":"https://api.github.com/repos/d00rman/service-template-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/d00rman/service-template-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/d00rman/service-template-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/d00rman/service-template-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/d00rman/service-template-node/contents/{+path}","compare_url":"https://api.github.com/repos/d00rman/service-template-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d00rman/service-template-node/merges","archive_url":"https://api.github.com/repos/d00rman/service-template-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d00rman/service-template-node/downloads","issues_url":"https://api.github.com/repos/d00rman/service-template-node/issues{/number}","pulls_url":"https://api.github.com/repos/d00rman/service-template-node/pulls{/number}","milestones_url":"https://api.github.com/repos/d00rman/service-template-node/milestones{/number}","notifications_url":"https://api.github.com/repos/d00rman/service-template-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d00rman/service-template-node/labels{/name}","releases_url":"https://api.github.com/repos/d00rman/service-template-node/releases{/id}","created_at":"2015-02-16T14:49:15Z","updated_at":"2015-04-29T15:38:54Z","pushed_at":"2015-10-19T08:33:13Z","git_url":"git://github.com/d00rman/service-template-node.git","ssh_url":"git@github.com:d00rman/service-template-node.git","clone_url":"https://github.com/d00rman/service-template-node.git","svn_url":"https://github.com/d00rman/service-template-node","homepage":null,"size":458,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"dc84855104c430f3a6df0b75d380b6e08e2298f8","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":30872453,"name":"service-template-node","full_name":"wikimedia/service-template-node","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/service-template-node","description":"Template for creating MediaWiki Services in Node.js","fork":false,"url":"https://api.github.com/repos/wikimedia/service-template-node","forks_url":"https://api.github.com/repos/wikimedia/service-template-node/forks","keys_url":"https://api.github.com/repos/wikimedia/service-template-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/service-template-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/service-template-node/teams","hooks_url":"https://api.github.com/repos/wikimedia/service-template-node/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/service-template-node/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/service-template-node/events","assignees_url":"https://api.github.com/repos/wikimedia/service-template-node/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/service-template-node/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/service-template-node/tags","blobs_url":"https://api.github.com/repos/wikimedia/service-template-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/service-template-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/service-template-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/service-template-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/service-template-node/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/service-template-node/languages","stargazers_url":"https://api.github.com/repos/wikimedia/service-template-node/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/service-template-node/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/service-template-node/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/service-template-node/subscription","commits_url":"https://api.github.com/repos/wikimedia/service-template-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/service-template-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/service-template-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/service-template-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/service-template-node/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/service-template-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/service-template-node/merges","archive_url":"https://api.github.com/repos/wikimedia/service-template-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/service-template-node/downloads","issues_url":"https://api.github.com/repos/wikimedia/service-template-node/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/service-template-node/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/service-template-node/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/service-template-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/service-template-node/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/service-template-node/releases{/id}","created_at":"2015-02-16T14:46:01Z","updated_at":"2015-05-20T13:40:50Z","pushed_at":"2015-10-19T08:34:52Z","git_url":"git://github.com/wikimedia/service-template-node.git","ssh_url":"git@github.com:wikimedia/service-template-node.git","clone_url":"https://github.com/wikimedia/service-template-node.git","svn_url":"https://github.com/wikimedia/service-template-node","homepage":null,"size":518,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/service-template-node/pulls/48"},"html":{"href":"https://github.com/wikimedia/service-template-node/pull/48"},"issue":{"href":"https://api.github.com/repos/wikimedia/service-template-node/issues/48"},"comments":{"href":"https://api.github.com/repos/wikimedia/service-template-node/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/service-template-node/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/service-template-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/service-template-node/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/service-template-node/statuses/d1993dbc22dc9fafd22b49052279cd6915f1b1e6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"d00rman","id":10210173,"avatar_url":"https://avatars.githubusercontent.com/u/10210173?v=3","gravatar_id":"","url":"https://api.github.com/users/d00rman","html_url":"https://github.com/d00rman","followers_url":"https://api.github.com/users/d00rman/followers","following_url":"https://api.github.com/users/d00rman/following{/other_user}","gists_url":"https://api.github.com/users/d00rman/gists{/gist_id}","starred_url":"https://api.github.com/users/d00rman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d00rman/subscriptions","organizations_url":"https://api.github.com/users/d00rman/orgs","repos_url":"https://api.github.com/users/d00rman/repos","events_url":"https://api.github.com/users/d00rman/events{/privacy}","received_events_url":"https://api.github.com/users/d00rman/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":2,"additions":49,"deletions":17,"changed_files":4}}