{"action":"created","comment":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/comments/30000173","id":30000173,"diff_hunk":"@@ -458,6 +458,7 @@ int pyi_launch_execute(ARCHIVE_STATUS *status, int argc, char *argv[])\n      * If it's None(NULL), get the filesystem encoding by using direct\n      * C calls and override it with correct value.\n      */\n+#ifndef WIN32\n     if (!*PI_Py_FileSystemDefaultEncoding) {","path":"bootloader/common/pyi_launch.c","position":53,"original_position":53,"commit_id":"6dc25714365fd4b91649a35297d85e573ccfbcab","original_commit_id":"6dc25714365fd4b91649a35297d85e573ccfbcab","user":{"login":"htgoebel","id":784161,"avatar_url":"https://avatars.githubusercontent.com/u/784161?v=3","gravatar_id":"","url":"https://api.github.com/users/htgoebel","html_url":"https://github.com/htgoebel","followers_url":"https://api.github.com/users/htgoebel/followers","following_url":"https://api.github.com/users/htgoebel/following{/other_user}","gists_url":"https://api.github.com/users/htgoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/htgoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htgoebel/subscriptions","organizations_url":"https://api.github.com/users/htgoebel/orgs","repos_url":"https://api.github.com/users/htgoebel/repos","events_url":"https://api.github.com/users/htgoebel/events{/privacy}","received_events_url":"https://api.github.com/users/htgoebel/received_events","type":"User","site_admin":false},"body":"Why should FileSystemDefaultEncoding nor be handled in win32? Please add a comment about the reason directly to the code. Thanks.","created_at":"2015-05-10T09:03:47Z","updated_at":"2015-05-10T09:03:47Z","html_url":"https://github.com/pyinstaller/pyinstaller/pull/1265#discussion_r30000173","pull_request_url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/1265","_links":{"self":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/comments/30000173"},"html":{"href":"https://github.com/pyinstaller/pyinstaller/pull/1265#discussion_r30000173"},"pull_request":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/1265"}}},"pull_request":{"url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/1265","id":35076643,"html_url":"https://github.com/pyinstaller/pyinstaller/pull/1265","diff_url":"https://github.com/pyinstaller/pyinstaller/pull/1265.diff","patch_url":"https://github.com/pyinstaller/pyinstaller/pull/1265.patch","issue_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1265","number":1265,"state":"open","locked":false,"title":"Fix bootloader to compile on win32 again.","user":{"login":"codewarrior0","id":307683,"avatar_url":"https://avatars.githubusercontent.com/u/307683?v=3","gravatar_id":"","url":"https://api.github.com/users/codewarrior0","html_url":"https://github.com/codewarrior0","followers_url":"https://api.github.com/users/codewarrior0/followers","following_url":"https://api.github.com/users/codewarrior0/following{/other_user}","gists_url":"https://api.github.com/users/codewarrior0/gists{/gist_id}","starred_url":"https://api.github.com/users/codewarrior0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codewarrior0/subscriptions","organizations_url":"https://api.github.com/users/codewarrior0/orgs","repos_url":"https://api.github.com/users/codewarrior0/repos","events_url":"https://api.github.com/users/codewarrior0/events{/privacy}","received_events_url":"https://api.github.com/users/codewarrior0/received_events","type":"User","site_admin":false},"body":"The bootloader would not compile because `langinfo.h` and `nl_langinfo()` are not available on win32. This patch moves the related code into `#ifndef WIN32` blocks.\r\n\r\nStackOverflow suggests the equivalent Win32 API function is `GetLangInfoEx()`","created_at":"2015-05-10T03:11:44Z","updated_at":"2015-05-10T09:03:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"004a5b597ea0f96f346678941685350765731572","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/1265/commits","review_comments_url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/1265/comments","review_comment_url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1265/comments","statuses_url":"https://api.github.com/repos/pyinstaller/pyinstaller/statuses/6dc25714365fd4b91649a35297d85e573ccfbcab","head":{"label":"codewarrior0:win-bootloader-fix","ref":"win-bootloader-fix","sha":"6dc25714365fd4b91649a35297d85e573ccfbcab","user":{"login":"codewarrior0","id":307683,"avatar_url":"https://avatars.githubusercontent.com/u/307683?v=3","gravatar_id":"","url":"https://api.github.com/users/codewarrior0","html_url":"https://github.com/codewarrior0","followers_url":"https://api.github.com/users/codewarrior0/followers","following_url":"https://api.github.com/users/codewarrior0/following{/other_user}","gists_url":"https://api.github.com/users/codewarrior0/gists{/gist_id}","starred_url":"https://api.github.com/users/codewarrior0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codewarrior0/subscriptions","organizations_url":"https://api.github.com/users/codewarrior0/orgs","repos_url":"https://api.github.com/users/codewarrior0/repos","events_url":"https://api.github.com/users/codewarrior0/events{/privacy}","received_events_url":"https://api.github.com/users/codewarrior0/received_events","type":"User","site_admin":false},"repo":{"id":28391032,"name":"pyinstaller","full_name":"codewarrior0/pyinstaller","owner":{"login":"codewarrior0","id":307683,"avatar_url":"https://avatars.githubusercontent.com/u/307683?v=3","gravatar_id":"","url":"https://api.github.com/users/codewarrior0","html_url":"https://github.com/codewarrior0","followers_url":"https://api.github.com/users/codewarrior0/followers","following_url":"https://api.github.com/users/codewarrior0/following{/other_user}","gists_url":"https://api.github.com/users/codewarrior0/gists{/gist_id}","starred_url":"https://api.github.com/users/codewarrior0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codewarrior0/subscriptions","organizations_url":"https://api.github.com/users/codewarrior0/orgs","repos_url":"https://api.github.com/users/codewarrior0/repos","events_url":"https://api.github.com/users/codewarrior0/events{/privacy}","received_events_url":"https://api.github.com/users/codewarrior0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codewarrior0/pyinstaller","description":"PyInstaller official GIT repository ","fork":true,"url":"https://api.github.com/repos/codewarrior0/pyinstaller","forks_url":"https://api.github.com/repos/codewarrior0/pyinstaller/forks","keys_url":"https://api.github.com/repos/codewarrior0/pyinstaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codewarrior0/pyinstaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codewarrior0/pyinstaller/teams","hooks_url":"https://api.github.com/repos/codewarrior0/pyinstaller/hooks","issue_events_url":"https://api.github.com/repos/codewarrior0/pyinstaller/issues/events{/number}","events_url":"https://api.github.com/repos/codewarrior0/pyinstaller/events","assignees_url":"https://api.github.com/repos/codewarrior0/pyinstaller/assignees{/user}","branches_url":"https://api.github.com/repos/codewarrior0/pyinstaller/branches{/branch}","tags_url":"https://api.github.com/repos/codewarrior0/pyinstaller/tags","blobs_url":"https://api.github.com/repos/codewarrior0/pyinstaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codewarrior0/pyinstaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codewarrior0/pyinstaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/codewarrior0/pyinstaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codewarrior0/pyinstaller/statuses/{sha}","languages_url":"https://api.github.com/repos/codewarrior0/pyinstaller/languages","stargazers_url":"https://api.github.com/repos/codewarrior0/pyinstaller/stargazers","contributors_url":"https://api.github.com/repos/codewarrior0/pyinstaller/contributors","subscribers_url":"https://api.github.com/repos/codewarrior0/pyinstaller/subscribers","subscription_url":"https://api.github.com/repos/codewarrior0/pyinstaller/subscription","commits_url":"https://api.github.com/repos/codewarrior0/pyinstaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/codewarrior0/pyinstaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/codewarrior0/pyinstaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/codewarrior0/pyinstaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/codewarrior0/pyinstaller/contents/{+path}","compare_url":"https://api.github.com/repos/codewarrior0/pyinstaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codewarrior0/pyinstaller/merges","archive_url":"https://api.github.com/repos/codewarrior0/pyinstaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codewarrior0/pyinstaller/downloads","issues_url":"https://api.github.com/repos/codewarrior0/pyinstaller/issues{/number}","pulls_url":"https://api.github.com/repos/codewarrior0/pyinstaller/pulls{/number}","milestones_url":"https://api.github.com/repos/codewarrior0/pyinstaller/milestones{/number}","notifications_url":"https://api.github.com/repos/codewarrior0/pyinstaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codewarrior0/pyinstaller/labels{/name}","releases_url":"https://api.github.com/repos/codewarrior0/pyinstaller/releases{/id}","created_at":"2014-12-23T10:02:19Z","updated_at":"2014-12-23T10:02:21Z","pushed_at":"2015-05-10T03:10:40Z","git_url":"git://github.com/codewarrior0/pyinstaller.git","ssh_url":"git@github.com:codewarrior0/pyinstaller.git","clone_url":"https://github.com/codewarrior0/pyinstaller.git","svn_url":"https://github.com/codewarrior0/pyinstaller","homepage":"http://www.pyinstaller.org","size":25827,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"pyinstaller:develop","ref":"develop","sha":"d1242e867896c2a20062ea8d3f7d6626783322c2","user":{"login":"pyinstaller","id":1215332,"avatar_url":"https://avatars.githubusercontent.com/u/1215332?v=3","gravatar_id":"","url":"https://api.github.com/users/pyinstaller","html_url":"https://github.com/pyinstaller","followers_url":"https://api.github.com/users/pyinstaller/followers","following_url":"https://api.github.com/users/pyinstaller/following{/other_user}","gists_url":"https://api.github.com/users/pyinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/pyinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyinstaller/subscriptions","organizations_url":"https://api.github.com/users/pyinstaller/orgs","repos_url":"https://api.github.com/users/pyinstaller/repos","events_url":"https://api.github.com/users/pyinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/pyinstaller/received_events","type":"Organization","site_admin":false},"repo":{"id":2835111,"name":"pyinstaller","full_name":"pyinstaller/pyinstaller","owner":{"login":"pyinstaller","id":1215332,"avatar_url":"https://avatars.githubusercontent.com/u/1215332?v=3","gravatar_id":"","url":"https://api.github.com/users/pyinstaller","html_url":"https://github.com/pyinstaller","followers_url":"https://api.github.com/users/pyinstaller/followers","following_url":"https://api.github.com/users/pyinstaller/following{/other_user}","gists_url":"https://api.github.com/users/pyinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/pyinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyinstaller/subscriptions","organizations_url":"https://api.github.com/users/pyinstaller/orgs","repos_url":"https://api.github.com/users/pyinstaller/repos","events_url":"https://api.github.com/users/pyinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/pyinstaller/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyinstaller/pyinstaller","description":"PyInstaller official GIT repository ","fork":false,"url":"https://api.github.com/repos/pyinstaller/pyinstaller","forks_url":"https://api.github.com/repos/pyinstaller/pyinstaller/forks","keys_url":"https://api.github.com/repos/pyinstaller/pyinstaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyinstaller/pyinstaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyinstaller/pyinstaller/teams","hooks_url":"https://api.github.com/repos/pyinstaller/pyinstaller/hooks","issue_events_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/events{/number}","events_url":"https://api.github.com/repos/pyinstaller/pyinstaller/events","assignees_url":"https://api.github.com/repos/pyinstaller/pyinstaller/assignees{/user}","branches_url":"https://api.github.com/repos/pyinstaller/pyinstaller/branches{/branch}","tags_url":"https://api.github.com/repos/pyinstaller/pyinstaller/tags","blobs_url":"https://api.github.com/repos/pyinstaller/pyinstaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyinstaller/pyinstaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyinstaller/pyinstaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyinstaller/pyinstaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyinstaller/pyinstaller/statuses/{sha}","languages_url":"https://api.github.com/repos/pyinstaller/pyinstaller/languages","stargazers_url":"https://api.github.com/repos/pyinstaller/pyinstaller/stargazers","contributors_url":"https://api.github.com/repos/pyinstaller/pyinstaller/contributors","subscribers_url":"https://api.github.com/repos/pyinstaller/pyinstaller/subscribers","subscription_url":"https://api.github.com/repos/pyinstaller/pyinstaller/subscription","commits_url":"https://api.github.com/repos/pyinstaller/pyinstaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyinstaller/pyinstaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyinstaller/pyinstaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyinstaller/pyinstaller/contents/{+path}","compare_url":"https://api.github.com/repos/pyinstaller/pyinstaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyinstaller/pyinstaller/merges","archive_url":"https://api.github.com/repos/pyinstaller/pyinstaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyinstaller/pyinstaller/downloads","issues_url":"https://api.github.com/repos/pyinstaller/pyinstaller/issues{/number}","pulls_url":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls{/number}","milestones_url":"https://api.github.com/repos/pyinstaller/pyinstaller/milestones{/number}","notifications_url":"https://api.github.com/repos/pyinstaller/pyinstaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyinstaller/pyinstaller/labels{/name}","releases_url":"https://api.github.com/repos/pyinstaller/pyinstaller/releases{/id}","created_at":"2011-11-23T11:05:56Z","updated_at":"2015-05-10T08:01:27Z","pushed_at":"2015-05-10T09:00:21Z","git_url":"git://github.com/pyinstaller/pyinstaller.git","ssh_url":"git@github.com:pyinstaller/pyinstaller.git","clone_url":"https://github.com/pyinstaller/pyinstaller.git","svn_url":"https://github.com/pyinstaller/pyinstaller","homepage":"http://www.pyinstaller.org","size":31697,"stargazers_count":813,"watchers_count":813,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":248,"mirror_url":null,"open_issues_count":259,"forks":248,"open_issues":259,"watchers":813,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/1265"},"html":{"href":"https://github.com/pyinstaller/pyinstaller/pull/1265"},"issue":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1265"},"comments":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/issues/1265/comments"},"review_comments":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/1265/comments"},"review_comment":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/pulls/1265/commits"},"statuses":{"href":"https://api.github.com/repos/pyinstaller/pyinstaller/statuses/6dc25714365fd4b91649a35297d85e573ccfbcab"}}}}