{"action":"created","issue":{"url":"https://api.github.com/repos/msmbuilder/msmbuilder/issues/469","labels_url":"https://api.github.com/repos/msmbuilder/msmbuilder/issues/469/labels{/name}","comments_url":"https://api.github.com/repos/msmbuilder/msmbuilder/issues/469/comments","events_url":"https://api.github.com/repos/msmbuilder/msmbuilder/issues/469/events","html_url":"https://github.com/msmbuilder/msmbuilder/pull/469","id":57508414,"number":469,"title":"remove value error for trajectories that are too short in tICA._fit","user":{"login":"schwancr","id":2244902,"avatar_url":"https://avatars.githubusercontent.com/u/2244902?v=3","gravatar_id":"","url":"https://api.github.com/users/schwancr","html_url":"https://github.com/schwancr","followers_url":"https://api.github.com/users/schwancr/followers","following_url":"https://api.github.com/users/schwancr/following{/other_user}","gists_url":"https://api.github.com/users/schwancr/gists{/gist_id}","starred_url":"https://api.github.com/users/schwancr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwancr/subscriptions","organizations_url":"https://api.github.com/users/schwancr/orgs","repos_url":"https://api.github.com/users/schwancr/repos","events_url":"https://api.github.com/users/schwancr/events{/privacy}","received_events_url":"https://api.github.com/users/schwancr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-02-12T19:37:03Z","updated_at":"2015-02-12T19:52:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/msmbuilder/msmbuilder/pulls/469","html_url":"https://github.com/msmbuilder/msmbuilder/pull/469","diff_url":"https://github.com/msmbuilder/msmbuilder/pull/469.diff","patch_url":"https://github.com/msmbuilder/msmbuilder/pull/469.patch"},"body":"@sryckbos was using tICA with osprey on some FAH data. Some trajectories are too short depending on the correlation lag time, but the code throws an error instead of failing silently.\r\n\r\nSo, tICA._fit just silently ignores the data. Alternatively, we could print a warning, but throwing an exception is the wrong behavior.\r\n"},"comment":{"url":"https://api.github.com/repos/msmbuilder/msmbuilder/issues/comments/74140135","html_url":"https://github.com/msmbuilder/msmbuilder/pull/469#issuecomment-74140135","issue_url":"https://api.github.com/repos/msmbuilder/msmbuilder/issues/469","id":74140135,"user":{"login":"rmcgibbo","id":641278,"avatar_url":"https://avatars.githubusercontent.com/u/641278?v=3","gravatar_id":"","url":"https://api.github.com/users/rmcgibbo","html_url":"https://github.com/rmcgibbo","followers_url":"https://api.github.com/users/rmcgibbo/followers","following_url":"https://api.github.com/users/rmcgibbo/following{/other_user}","gists_url":"https://api.github.com/users/rmcgibbo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmcgibbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmcgibbo/subscriptions","organizations_url":"https://api.github.com/users/rmcgibbo/orgs","repos_url":"https://api.github.com/users/rmcgibbo/repos","events_url":"https://api.github.com/users/rmcgibbo/events{/privacy}","received_events_url":"https://api.github.com/users/rmcgibbo/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T19:52:39Z","updated_at":"2015-02-12T19:52:39Z","body":"> What if someone calls partial_fit twice?\r\n\r\n:) I think we can figure out how to handle this correctly."}}