{"action":"created","issue":{"url":"https://api.github.com/repos/DanielRapp/doppler/issues/9","labels_url":"https://api.github.com/repos/DanielRapp/doppler/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/DanielRapp/doppler/issues/9/comments","events_url":"https://api.github.com/repos/DanielRapp/doppler/issues/9/events","html_url":"https://github.com/DanielRapp/doppler/pull/9","id":61340041,"number":9,"title":"Added auto-calibration","user":{"login":"dracolytch","id":2850275,"avatar_url":"https://avatars.githubusercontent.com/u/2850275?v=3","gravatar_id":"","url":"https://api.github.com/users/dracolytch","html_url":"https://github.com/dracolytch","followers_url":"https://api.github.com/users/dracolytch/followers","following_url":"https://api.github.com/users/dracolytch/following{/other_user}","gists_url":"https://api.github.com/users/dracolytch/gists{/gist_id}","starred_url":"https://api.github.com/users/dracolytch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dracolytch/subscriptions","organizations_url":"https://api.github.com/users/dracolytch/orgs","repos_url":"https://api.github.com/users/dracolytch/repos","events_url":"https://api.github.com/users/dracolytch/events{/privacy}","received_events_url":"https://api.github.com/users/dracolytch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-14T01:32:26Z","updated_at":"2015-03-18T00:34:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DanielRapp/doppler/pulls/9","html_url":"https://github.com/DanielRapp/doppler/pull/9","diff_url":"https://github.com/DanielRapp/doppler/pull/9.diff","patch_url":"https://github.com/DanielRapp/doppler/pull/9.patch"},"body":"Tested on three devices, auto-calibration seems to work fairly well."},"comment":{"url":"https://api.github.com/repos/DanielRapp/doppler/issues/comments/82653029","html_url":"https://github.com/DanielRapp/doppler/pull/9#issuecomment-82653029","issue_url":"https://api.github.com/repos/DanielRapp/doppler/issues/9","id":82653029,"user":{"login":"dracolytch","id":2850275,"avatar_url":"https://avatars.githubusercontent.com/u/2850275?v=3","gravatar_id":"","url":"https://api.github.com/users/dracolytch","html_url":"https://github.com/dracolytch","followers_url":"https://api.github.com/users/dracolytch/followers","following_url":"https://api.github.com/users/dracolytch/following{/other_user}","gists_url":"https://api.github.com/users/dracolytch/gists{/gist_id}","starred_url":"https://api.github.com/users/dracolytch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dracolytch/subscriptions","organizations_url":"https://api.github.com/users/dracolytch/orgs","repos_url":"https://api.github.com/users/dracolytch/repos","events_url":"https://api.github.com/users/dracolytch/events{/privacy}","received_events_url":"https://api.github.com/users/dracolytch/received_events","type":"User","site_admin":false},"created_at":"2015-03-18T00:34:05Z","updated_at":"2015-03-18T00:34:05Z","body":"Yes, to a point. If we can't hear anything, it's either because a) there's nothing to hear, or b) the setting is too high and we're not listening. So we reduce the ratio... But after a while we'll reduce into the point where background white noise will trigger direction changes, causing it to stop going down. If things are really quiet, or there's no motion, the worst-case is for the ratio to get just a bit lower than we'd ideally like, but where it still is responsive to the user. If the mic or speakers are off, it could get turned WAY down, so I believe I put in a min value check, so we never hit 0. \n\n\n     On Tuesday, March 17, 2015 7:02 PM, Jasper Lu <notifications@github.com> wrote:\n   \n\n @dracolytch \nYou have this line here : if (cd.directionChanges <= cd.downThreshold) cd.maxVolumeRatio *= cd.downAmount;\nWouldn't this sort of continuously lower the maxVolumeRatio if there's no activity?—\nReply to this email directly or view it on GitHub.   \n\n  "}}