{"action":"created","issue":{"url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1524","labels_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1524/labels{/name}","comments_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1524/comments","events_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1524/events","html_url":"https://github.com/BladeRunnerJS/brjs/pull/1524","id":106494244,"number":1524,"title":"Add new Closure minification setting","user":{"login":"dchambers","id":283294,"avatar_url":"https://avatars.githubusercontent.com/u/283294?v=3","gravatar_id":"","url":"https://api.github.com/users/dchambers","html_url":"https://github.com/dchambers","followers_url":"https://api.github.com/users/dchambers/followers","following_url":"https://api.github.com/users/dchambers/following{/other_user}","gists_url":"https://api.github.com/users/dchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/dchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchambers/subscriptions","organizations_url":"https://api.github.com/users/dchambers/orgs","repos_url":"https://api.github.com/users/dchambers/repos","events_url":"https://api.github.com/users/dchambers/events{/privacy}","received_events_url":"https://api.github.com/users/dchambers/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/BladeRunnerJS/brjs/labels/4%20-%20ReadyForTest","name":"4 - ReadyForTest","color":"CCCCCC"}],"state":"open","locked":false,"assignee":{"login":"dchambers","id":283294,"avatar_url":"https://avatars.githubusercontent.com/u/283294?v=3","gravatar_id":"","url":"https://api.github.com/users/dchambers","html_url":"https://github.com/dchambers","followers_url":"https://api.github.com/users/dchambers/followers","following_url":"https://api.github.com/users/dchambers/following{/other_user}","gists_url":"https://api.github.com/users/dchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/dchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchambers/subscriptions","organizations_url":"https://api.github.com/users/dchambers/orgs","repos_url":"https://api.github.com/users/dchambers/repos","events_url":"https://api.github.com/users/dchambers/events{/privacy}","received_events_url":"https://api.github.com/users/dchambers/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-09-15T07:00:23Z","updated_at":"2015-10-28T10:12:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BladeRunnerJS/brjs/pulls/1524","html_url":"https://github.com/BladeRunnerJS/brjs/pull/1524","diff_url":"https://github.com/BladeRunnerJS/brjs/pull/1524.diff","patch_url":"https://github.com/BladeRunnerJS/brjs/pull/1524.patch"},"body":"Added a new `closure-medium` minification level between `closure-simple` and `closure-advanced` that causes private members (i.e. members starting with `_` or `m_`) to be obfuscated. This change is dependent on the following up-stream improvement for Closure Compiler:\r\n\r\n  * https://github.com/google/closure-compiler/pull/1129\r\n\r\nI've so far been able to confirm that the 'it-app' app works with this new obfuscation level, but to progress this further somebody (@andyberry?) will need to confirm that the other more complex apps continue to work, and to find a way for us to start making use of the Closure Compiler changes pending a new release of Closure Compiler that contains those changes.\r\n\r\nFor the time being, you can test things by compiling [brjs-closure-compiler](https://github.com/BladeRunnerJS/closure-compiler/commits/rename-public-properties-compiler-option) on your own machine, and then updating the `closure-compiler` line in `dependencies.gradle` to something like this:\r\n\r\n```\r\n'closure-compiler': files('/home/dominicc/git-dev/brjs-closure-compiler/build/compiler.jar'),\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/comments/151790530","html_url":"https://github.com/BladeRunnerJS/brjs/pull/1524#issuecomment-151790530","issue_url":"https://api.github.com/repos/BladeRunnerJS/brjs/issues/1524","id":151790530,"user":{"login":"dchambers","id":283294,"avatar_url":"https://avatars.githubusercontent.com/u/283294?v=3","gravatar_id":"","url":"https://api.github.com/users/dchambers","html_url":"https://github.com/dchambers","followers_url":"https://api.github.com/users/dchambers/followers","following_url":"https://api.github.com/users/dchambers/following{/other_user}","gists_url":"https://api.github.com/users/dchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/dchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchambers/subscriptions","organizations_url":"https://api.github.com/users/dchambers/orgs","repos_url":"https://api.github.com/users/dchambers/repos","events_url":"https://api.github.com/users/dchambers/events{/privacy}","received_events_url":"https://api.github.com/users/dchambers/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T10:12:15Z","updated_at":"2015-10-28T10:12:15Z","body":"@Aivarass just mentioned the lack of release notes for this at present. @andyberry88, do you think we should keep this as a dark feature for the moment given the limited amount of automated testing we're able to perform? I'm wondering if we should wait until we get positive feedback from CT before announcing it? "}}