{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/30809571","id":30809571,"diff_hunk":"@@ -239,6 +240,33 @@ boolean offer(BBContainer cont, boolean compress) throws IOException {\n         return true;\n     }\n \n+    int offer(DeferredSerialization ds) throws IOException {\n+        if (m_closed) throw new IOException(\"closed\");\n+        final ByteBuffer mbuf = m_buf.b();\n+        if (mbuf.remaining() < ds.getSerializedSize() + m_objectHeaderBytes) return -1;\n+\n+        m_syncedSinceLastEdit = false;\n+        int written = writeDeferredSerialization(mbuf, ds);\n+        incrementNumEntries(written);\n+        return written;\n+    }\n+\n+    static int writeDeferredSerialization(ByteBuffer mbuf, DeferredSerialization ds) throws IOException {\n+        int written = 0;\n+        try {\n+            final int objSizePosition = mbuf.position();\n+            mbuf.position(mbuf.position() + m_objectHeaderBytes);\n+            final int objStartPosition = mbuf.position();\n+            ds.serialize(mbuf);\n+            written = mbuf.position() - objStartPosition;\n+            mbuf.putInt(objSizePosition, written);\n+            mbuf.putInt(objSizePosition + 4, 0);","path":"src/frontend/org/voltdb/utils/PBDSegment.java","position":32,"original_position":32,"commit_id":"e22001ab85c9ebc49f64d4d105e12b8c2336b9e2","original_commit_id":"e22001ab85c9ebc49f64d4d105e12b8c2336b9e2","user":{"login":"nshi","id":10992,"avatar_url":"https://avatars.githubusercontent.com/u/10992?v=3","gravatar_id":"","url":"https://api.github.com/users/nshi","html_url":"https://github.com/nshi","followers_url":"https://api.github.com/users/nshi/followers","following_url":"https://api.github.com/users/nshi/following{/other_user}","gists_url":"https://api.github.com/users/nshi/gists{/gist_id}","starred_url":"https://api.github.com/users/nshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nshi/subscriptions","organizations_url":"https://api.github.com/users/nshi/orgs","repos_url":"https://api.github.com/users/nshi/repos","events_url":"https://api.github.com/users/nshi/events{/privacy}","received_events_url":"https://api.github.com/users/nshi/received_events","type":"User","site_admin":false},"body":"What's this 0?","created_at":"2015-05-21T14:50:03Z","updated_at":"2015-05-21T14:50:03Z","html_url":"https://github.com/VoltDB/voltdb/pull/2339#discussion_r30809571","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2339","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/30809571"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2339#discussion_r30809571"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2339"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2339","id":35477263,"html_url":"https://github.com/VoltDB/voltdb/pull/2339","diff_url":"https://github.com/VoltDB/voltdb/pull/2339.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/2339.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2339","number":2339,"state":"open","locked":false,"title":"(REVIEW) ENG-7183: Initial DR compression work (rebased)","user":{"login":"afrogers","id":4966215,"avatar_url":"https://avatars.githubusercontent.com/u/4966215?v=3","gravatar_id":"","url":"https://api.github.com/users/afrogers","html_url":"https://github.com/afrogers","followers_url":"https://api.github.com/users/afrogers/followers","following_url":"https://api.github.com/users/afrogers/following{/other_user}","gists_url":"https://api.github.com/users/afrogers/gists{/gist_id}","starred_url":"https://api.github.com/users/afrogers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afrogers/subscriptions","organizations_url":"https://api.github.com/users/afrogers/orgs","repos_url":"https://api.github.com/users/afrogers/repos","events_url":"https://api.github.com/users/afrogers/events{/privacy}","received_events_url":"https://api.github.com/users/afrogers/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-15T01:08:59Z","updated_at":"2015-05-21T14:50:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a18fbb7b56e77ecc00a2c58d07f4d3d09b3b7ba5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2339/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2339/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2339/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/e22001ab85c9ebc49f64d4d105e12b8c2336b9e2","head":{"label":"VoltDB:ENG-7029","ref":"ENG-7029","sha":"e22001ab85c9ebc49f64d4d105e12b8c2336b9e2","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-05-21T14:48:54Z","pushed_at":"2015-05-21T11:52:25Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":672163,"stargazers_count":559,"watchers_count":559,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":27,"forks":162,"open_issues":27,"watchers":559,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"6696c6a22060c80022dcbd1256831d20a83dced3","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-05-21T14:48:54Z","pushed_at":"2015-05-21T11:52:25Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":672163,"stargazers_count":559,"watchers_count":559,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":27,"forks":162,"open_issues":27,"watchers":559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2339"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2339"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2339"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2339/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2339/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2339/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/e22001ab85c9ebc49f64d4d105e12b8c2336b9e2"}}}}