{"action":"opened","number":1075,"pull_request":{"url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/1075","id":43692912,"html_url":"https://github.com/bitcoinj/bitcoinj/pull/1075","diff_url":"https://github.com/bitcoinj/bitcoinj/pull/1075.diff","patch_url":"https://github.com/bitcoinj/bitcoinj/pull/1075.patch","issue_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1075","number":1075,"state":"open","locked":false,"title":"Close increasePaymentFuture when receiving an ERROR from the server.","user":{"login":"ollekullberg","id":201249,"avatar_url":"https://avatars.githubusercontent.com/u/201249?v=3","gravatar_id":"","url":"https://api.github.com/users/ollekullberg","html_url":"https://github.com/ollekullberg","followers_url":"https://api.github.com/users/ollekullberg/followers","following_url":"https://api.github.com/users/ollekullberg/following{/other_user}","gists_url":"https://api.github.com/users/ollekullberg/gists{/gist_id}","starred_url":"https://api.github.com/users/ollekullberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollekullberg/subscriptions","organizations_url":"https://api.github.com/users/ollekullberg/orgs","repos_url":"https://api.github.com/users/ollekullberg/repos","events_url":"https://api.github.com/users/ollekullberg/events{/privacy}","received_events_url":"https://api.github.com/users/ollekullberg/received_events","type":"User","site_admin":false},"body":"In PaymentChannelClient we have a future:\r\n\r\n   @GuardedBy(\"lock\") SettableFuture<PaymentIncrementAck> increasePaymentFuture;\r\n\r\n... and this future is used by incrementPayment(). When PAYMENT_ACK is returned from the serve the increasePaymentFuture is updated correctly. This PR makes sure the increasePaymentFuture is set even if the server returns an error.","created_at":"2015-08-29T10:57:37Z","updated_at":"2015-08-29T10:57:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/1075/commits","review_comments_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/1075/comments","review_comment_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1075/comments","statuses_url":"https://api.github.com/repos/bitcoinj/bitcoinj/statuses/f2753e953bb2fe44ce8d00f4302941f2cf126fbc","head":{"label":"strawpay:pcclient_error","ref":"pcclient_error","sha":"f2753e953bb2fe44ce8d00f4302941f2cf126fbc","user":{"login":"strawpay","id":7603604,"avatar_url":"https://avatars.githubusercontent.com/u/7603604?v=3","gravatar_id":"","url":"https://api.github.com/users/strawpay","html_url":"https://github.com/strawpay","followers_url":"https://api.github.com/users/strawpay/followers","following_url":"https://api.github.com/users/strawpay/following{/other_user}","gists_url":"https://api.github.com/users/strawpay/gists{/gist_id}","starred_url":"https://api.github.com/users/strawpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strawpay/subscriptions","organizations_url":"https://api.github.com/users/strawpay/orgs","repos_url":"https://api.github.com/users/strawpay/repos","events_url":"https://api.github.com/users/strawpay/events{/privacy}","received_events_url":"https://api.github.com/users/strawpay/received_events","type":"Organization","site_admin":false},"repo":{"id":20327840,"name":"bitcoinj","full_name":"strawpay/bitcoinj","owner":{"login":"strawpay","id":7603604,"avatar_url":"https://avatars.githubusercontent.com/u/7603604?v=3","gravatar_id":"","url":"https://api.github.com/users/strawpay","html_url":"https://github.com/strawpay","followers_url":"https://api.github.com/users/strawpay/followers","following_url":"https://api.github.com/users/strawpay/following{/other_user}","gists_url":"https://api.github.com/users/strawpay/gists{/gist_id}","starred_url":"https://api.github.com/users/strawpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strawpay/subscriptions","organizations_url":"https://api.github.com/users/strawpay/orgs","repos_url":"https://api.github.com/users/strawpay/repos","events_url":"https://api.github.com/users/strawpay/events{/privacy}","received_events_url":"https://api.github.com/users/strawpay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strawpay/bitcoinj","description":"A library for working with Bitcoin","fork":true,"url":"https://api.github.com/repos/strawpay/bitcoinj","forks_url":"https://api.github.com/repos/strawpay/bitcoinj/forks","keys_url":"https://api.github.com/repos/strawpay/bitcoinj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strawpay/bitcoinj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strawpay/bitcoinj/teams","hooks_url":"https://api.github.com/repos/strawpay/bitcoinj/hooks","issue_events_url":"https://api.github.com/repos/strawpay/bitcoinj/issues/events{/number}","events_url":"https://api.github.com/repos/strawpay/bitcoinj/events","assignees_url":"https://api.github.com/repos/strawpay/bitcoinj/assignees{/user}","branches_url":"https://api.github.com/repos/strawpay/bitcoinj/branches{/branch}","tags_url":"https://api.github.com/repos/strawpay/bitcoinj/tags","blobs_url":"https://api.github.com/repos/strawpay/bitcoinj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strawpay/bitcoinj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strawpay/bitcoinj/git/refs{/sha}","trees_url":"https://api.github.com/repos/strawpay/bitcoinj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strawpay/bitcoinj/statuses/{sha}","languages_url":"https://api.github.com/repos/strawpay/bitcoinj/languages","stargazers_url":"https://api.github.com/repos/strawpay/bitcoinj/stargazers","contributors_url":"https://api.github.com/repos/strawpay/bitcoinj/contributors","subscribers_url":"https://api.github.com/repos/strawpay/bitcoinj/subscribers","subscription_url":"https://api.github.com/repos/strawpay/bitcoinj/subscription","commits_url":"https://api.github.com/repos/strawpay/bitcoinj/commits{/sha}","git_commits_url":"https://api.github.com/repos/strawpay/bitcoinj/git/commits{/sha}","comments_url":"https://api.github.com/repos/strawpay/bitcoinj/comments{/number}","issue_comment_url":"https://api.github.com/repos/strawpay/bitcoinj/issues/comments{/number}","contents_url":"https://api.github.com/repos/strawpay/bitcoinj/contents/{+path}","compare_url":"https://api.github.com/repos/strawpay/bitcoinj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strawpay/bitcoinj/merges","archive_url":"https://api.github.com/repos/strawpay/bitcoinj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strawpay/bitcoinj/downloads","issues_url":"https://api.github.com/repos/strawpay/bitcoinj/issues{/number}","pulls_url":"https://api.github.com/repos/strawpay/bitcoinj/pulls{/number}","milestones_url":"https://api.github.com/repos/strawpay/bitcoinj/milestones{/number}","notifications_url":"https://api.github.com/repos/strawpay/bitcoinj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strawpay/bitcoinj/labels{/name}","releases_url":"https://api.github.com/repos/strawpay/bitcoinj/releases{/id}","created_at":"2014-05-30T11:58:13Z","updated_at":"2014-12-01T10:53:39Z","pushed_at":"2015-08-29T10:35:36Z","git_url":"git://github.com/strawpay/bitcoinj.git","ssh_url":"git@github.com:strawpay/bitcoinj.git","clone_url":"https://github.com/strawpay/bitcoinj.git","svn_url":"https://github.com/strawpay/bitcoinj","homepage":"http://www.bitcoinj.org","size":17706,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"bitcoinj:master","ref":"master","sha":"6b4123cd9fa37de7de7d3ad0c8e90da8b4ebb245","user":{"login":"bitcoinj","id":5951625,"avatar_url":"https://avatars.githubusercontent.com/u/5951625?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinj","html_url":"https://github.com/bitcoinj","followers_url":"https://api.github.com/users/bitcoinj/followers","following_url":"https://api.github.com/users/bitcoinj/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinj/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinj/subscriptions","organizations_url":"https://api.github.com/users/bitcoinj/orgs","repos_url":"https://api.github.com/users/bitcoinj/repos","events_url":"https://api.github.com/users/bitcoinj/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinj/received_events","type":"Organization","site_admin":false},"repo":{"id":14514251,"name":"bitcoinj","full_name":"bitcoinj/bitcoinj","owner":{"login":"bitcoinj","id":5951625,"avatar_url":"https://avatars.githubusercontent.com/u/5951625?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinj","html_url":"https://github.com/bitcoinj","followers_url":"https://api.github.com/users/bitcoinj/followers","following_url":"https://api.github.com/users/bitcoinj/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinj/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinj/subscriptions","organizations_url":"https://api.github.com/users/bitcoinj/orgs","repos_url":"https://api.github.com/users/bitcoinj/repos","events_url":"https://api.github.com/users/bitcoinj/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinj/bitcoinj","description":"A library for working with Bitcoin","fork":false,"url":"https://api.github.com/repos/bitcoinj/bitcoinj","forks_url":"https://api.github.com/repos/bitcoinj/bitcoinj/forks","keys_url":"https://api.github.com/repos/bitcoinj/bitcoinj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinj/bitcoinj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinj/bitcoinj/teams","hooks_url":"https://api.github.com/repos/bitcoinj/bitcoinj/hooks","issue_events_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinj/bitcoinj/events","assignees_url":"https://api.github.com/repos/bitcoinj/bitcoinj/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinj/bitcoinj/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinj/bitcoinj/tags","blobs_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinj/bitcoinj/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinj/bitcoinj/languages","stargazers_url":"https://api.github.com/repos/bitcoinj/bitcoinj/stargazers","contributors_url":"https://api.github.com/repos/bitcoinj/bitcoinj/contributors","subscribers_url":"https://api.github.com/repos/bitcoinj/bitcoinj/subscribers","subscription_url":"https://api.github.com/repos/bitcoinj/bitcoinj/subscription","commits_url":"https://api.github.com/repos/bitcoinj/bitcoinj/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinj/bitcoinj/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinj/bitcoinj/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinj/bitcoinj/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinj/bitcoinj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinj/bitcoinj/merges","archive_url":"https://api.github.com/repos/bitcoinj/bitcoinj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinj/bitcoinj/downloads","issues_url":"https://api.github.com/repos/bitcoinj/bitcoinj/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinj/bitcoinj/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinj/bitcoinj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinj/bitcoinj/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinj/bitcoinj/releases{/id}","created_at":"2013-11-19T04:33:23Z","updated_at":"2015-08-28T21:32:19Z","pushed_at":"2015-08-29T10:57:37Z","git_url":"git://github.com/bitcoinj/bitcoinj.git","ssh_url":"git@github.com:bitcoinj/bitcoinj.git","clone_url":"https://github.com/bitcoinj/bitcoinj.git","svn_url":"https://github.com/bitcoinj/bitcoinj","homepage":"http://www.bitcoinj.org","size":32503,"stargazers_count":505,"watchers_count":505,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":471,"mirror_url":null,"open_issues_count":150,"forks":471,"open_issues":150,"watchers":505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/1075"},"html":{"href":"https://github.com/bitcoinj/bitcoinj/pull/1075"},"issue":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1075"},"comments":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/issues/1075/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/1075/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/pulls/1075/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinj/bitcoinj/statuses/f2753e953bb2fe44ce8d00f4302941f2cf126fbc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":82,"deletions":7,"changed_files":2}}