{"action":"closed","number":224,"pull_request":{"url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/pulls/224","id":45153737,"html_url":"https://github.com/sphereio/sphere-sunrise-dmexco/pull/224","diff_url":"https://github.com/sphereio/sphere-sunrise-dmexco/pull/224.diff","patch_url":"https://github.com/sphereio/sphere-sunrise-dmexco/pull/224.patch","issue_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/issues/224","number":224,"state":"closed","locked":false,"title":"Cart discounts","user":{"login":"peter-gerhard","id":4236201,"avatar_url":"https://avatars.githubusercontent.com/u/4236201?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-gerhard","html_url":"https://github.com/peter-gerhard","followers_url":"https://api.github.com/users/peter-gerhard/followers","following_url":"https://api.github.com/users/peter-gerhard/following{/other_user}","gists_url":"https://api.github.com/users/peter-gerhard/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-gerhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-gerhard/subscriptions","organizations_url":"https://api.github.com/users/peter-gerhard/orgs","repos_url":"https://api.github.com/users/peter-gerhard/repos","events_url":"https://api.github.com/users/peter-gerhard/events{/privacy}","received_events_url":"https://api.github.com/users/peter-gerhard/received_events","type":"User","site_admin":false},"body":"@schleichardt @lauraluiz \r\nI removed that cart discounts are applied per line item in order to calculate and show them in ui\r\nfor me it doesnt make sense to have the cart discount already applied to the subtotal, whats your opinion on that?\r\n","created_at":"2015-09-16T10:17:25Z","updated_at":"2015-09-16T11:19:23Z","closed_at":"2015-09-16T11:19:23Z","merged_at":"2015-09-16T11:19:23Z","merge_commit_sha":"9120fc2d24622646698766ed7795345e418fdf30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/pulls/224/commits","review_comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/pulls/224/comments","review_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/issues/224/comments","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/statuses/cb2bdebd5d44c8d408a92c7a69e084336b5e0c3c","head":{"label":"sphereio:cartDiscounts","ref":"cartDiscounts","sha":"cb2bdebd5d44c8d408a92c7a69e084336b5e0c3c","user":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"repo":{"id":41804394,"name":"sphere-sunrise-dmexco","full_name":"sphereio/sphere-sunrise-dmexco","owner":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphereio/sphere-sunrise-dmexco","description":"","fork":false,"url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco","forks_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/forks","keys_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/teams","hooks_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/hooks","issue_events_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/issues/events{/number}","events_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/events","assignees_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/assignees{/user}","branches_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/branches{/branch}","tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/tags","blobs_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/statuses/{sha}","languages_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/languages","stargazers_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/stargazers","contributors_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/contributors","subscribers_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/subscribers","subscription_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/subscription","commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/contents/{+path}","compare_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/merges","archive_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/downloads","issues_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/issues{/number}","pulls_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/pulls{/number}","milestones_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/milestones{/number}","notifications_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/labels{/name}","releases_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/releases{/id}","created_at":"2015-09-02T14:02:09Z","updated_at":"2015-09-02T14:11:01Z","pushed_at":"2015-09-16T11:19:23Z","git_url":"git://github.com/sphereio/sphere-sunrise-dmexco.git","ssh_url":"git@github.com:sphereio/sphere-sunrise-dmexco.git","clone_url":"https://github.com/sphereio/sphere-sunrise-dmexco.git","svn_url":"https://github.com/sphereio/sphere-sunrise-dmexco","homepage":null,"size":7728,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":10,"forks":1,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"sphereio:master","ref":"master","sha":"a9b4b8ea90602cf3ff7e62b28f156772e5bc9ff7","user":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"repo":{"id":41804394,"name":"sphere-sunrise-dmexco","full_name":"sphereio/sphere-sunrise-dmexco","owner":{"login":"sphereio","id":4119130,"avatar_url":"https://avatars.githubusercontent.com/u/4119130?v=3","gravatar_id":"","url":"https://api.github.com/users/sphereio","html_url":"https://github.com/sphereio","followers_url":"https://api.github.com/users/sphereio/followers","following_url":"https://api.github.com/users/sphereio/following{/other_user}","gists_url":"https://api.github.com/users/sphereio/gists{/gist_id}","starred_url":"https://api.github.com/users/sphereio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphereio/subscriptions","organizations_url":"https://api.github.com/users/sphereio/orgs","repos_url":"https://api.github.com/users/sphereio/repos","events_url":"https://api.github.com/users/sphereio/events{/privacy}","received_events_url":"https://api.github.com/users/sphereio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphereio/sphere-sunrise-dmexco","description":"","fork":false,"url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco","forks_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/forks","keys_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/teams","hooks_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/hooks","issue_events_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/issues/events{/number}","events_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/events","assignees_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/assignees{/user}","branches_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/branches{/branch}","tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/tags","blobs_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/statuses/{sha}","languages_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/languages","stargazers_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/stargazers","contributors_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/contributors","subscribers_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/subscribers","subscription_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/subscription","commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/contents/{+path}","compare_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/merges","archive_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/downloads","issues_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/issues{/number}","pulls_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/pulls{/number}","milestones_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/milestones{/number}","notifications_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/labels{/name}","releases_url":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/releases{/id}","created_at":"2015-09-02T14:02:09Z","updated_at":"2015-09-02T14:11:01Z","pushed_at":"2015-09-16T11:19:23Z","git_url":"git://github.com/sphereio/sphere-sunrise-dmexco.git","ssh_url":"git@github.com:sphereio/sphere-sunrise-dmexco.git","clone_url":"https://github.com/sphereio/sphere-sunrise-dmexco.git","svn_url":"https://github.com/sphereio/sphere-sunrise-dmexco","homepage":null,"size":7728,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":10,"forks":1,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/pulls/224"},"html":{"href":"https://github.com/sphereio/sphere-sunrise-dmexco/pull/224"},"issue":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/issues/224"},"comments":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/sphereio/sphere-sunrise-dmexco/statuses/cb2bdebd5d44c8d408a92c7a69e084336b5e0c3c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lauraluiz","id":1917621,"avatar_url":"https://avatars.githubusercontent.com/u/1917621?v=3","gravatar_id":"","url":"https://api.github.com/users/lauraluiz","html_url":"https://github.com/lauraluiz","followers_url":"https://api.github.com/users/lauraluiz/followers","following_url":"https://api.github.com/users/lauraluiz/following{/other_user}","gists_url":"https://api.github.com/users/lauraluiz/gists{/gist_id}","starred_url":"https://api.github.com/users/lauraluiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauraluiz/subscriptions","organizations_url":"https://api.github.com/users/lauraluiz/orgs","repos_url":"https://api.github.com/users/lauraluiz/repos","events_url":"https://api.github.com/users/lauraluiz/events{/privacy}","received_events_url":"https://api.github.com/users/lauraluiz/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":8,"additions":43,"deletions":30,"changed_files":3}}