{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/48064242","id":48064242,"diff_hunk":"@@ -16,17 +16,20 @@ Gem::Specification.new do |s|\n   s.required_ruby_version = '>= 2.0.0'\n   s.requirements << 'libgrpc ~> 0.11.0 needs to be installed'\n \n-  s.files = %w( Rakefile )\n-  s.files += Dir.glob('bin/**/*')\n-  s.files += Dir.glob('ext/**/*')\n-  s.files += Dir.glob('lib/**/*')\n-  s.files += Dir.glob('pb/**/*')\n-  s.test_files = Dir.glob('spec/**/*')\n+  s.files = %w( Rakefile Makefile )\n+  s.files += Dir.glob('src/ruby/bin/**/*')\n+  s.files += Dir.glob('src/ruby/ext/**/*')\n+  s.files += Dir.glob('src/ruby/lib/**/*')\n+  s.files += Dir.glob('src/ruby/pb/**/*')\n+  s.files += Dir.glob('include/grpc/**/*')\n+  s.files += Dir.glob('src/core/**/*')","path":"grpc.gemspec","position":24,"original_position":24,"commit_id":"d7e1a10628b87d9437f15ffb44d74499345ba757","original_commit_id":"d7e1a10628b87d9437f15ffb44d74499345ba757","user":{"login":"ctiller","id":10120821,"avatar_url":"https://avatars.githubusercontent.com/u/10120821?v=3","gravatar_id":"","url":"https://api.github.com/users/ctiller","html_url":"https://github.com/ctiller","followers_url":"https://api.github.com/users/ctiller/followers","following_url":"https://api.github.com/users/ctiller/following{/other_user}","gists_url":"https://api.github.com/users/ctiller/gists{/gist_id}","starred_url":"https://api.github.com/users/ctiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctiller/subscriptions","organizations_url":"https://api.github.com/users/ctiller/orgs","repos_url":"https://api.github.com/users/ctiller/repos","events_url":"https://api.github.com/users/ctiller/events{/privacy}","received_events_url":"https://api.github.com/users/ctiller/received_events","type":"User","site_admin":false},"body":"Can we template this?\r\n\r\nThere have been cases (and likely will be cases again) where we have code in src/core that we don't necessarily want to bundle up for distribution, but nor do we want to delete it.","created_at":"2015-12-18T20:04:57Z","updated_at":"2015-12-18T20:04:57Z","html_url":"https://github.com/grpc/grpc/pull/4538#discussion_r48064242","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/4538","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/48064242"},"html":{"href":"https://github.com/grpc/grpc/pull/4538#discussion_r48064242"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/4538"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/4538","id":54139382,"html_url":"https://github.com/grpc/grpc/pull/4538","diff_url":"https://github.com/grpc/grpc/pull/4538.diff","patch_url":"https://github.com/grpc/grpc/pull/4538.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/4538","number":4538,"state":"open","locked":false,"title":"Bundled C core with Ruby library","user":{"login":"murgatroid99","id":961599,"avatar_url":"https://avatars.githubusercontent.com/u/961599?v=3","gravatar_id":"","url":"https://api.github.com/users/murgatroid99","html_url":"https://github.com/murgatroid99","followers_url":"https://api.github.com/users/murgatroid99/followers","following_url":"https://api.github.com/users/murgatroid99/following{/other_user}","gists_url":"https://api.github.com/users/murgatroid99/gists{/gist_id}","starred_url":"https://api.github.com/users/murgatroid99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murgatroid99/subscriptions","organizations_url":"https://api.github.com/users/murgatroid99/orgs","repos_url":"https://api.github.com/users/murgatroid99/repos","events_url":"https://api.github.com/users/murgatroid99/events{/privacy}","received_events_url":"https://api.github.com/users/murgatroid99/received_events","type":"User","site_admin":false},"body":"Note: this currently uses the system OpenSSL installation. When we start distributing BoringSSL, we should switch to using that.\r\n\r\nFixes #4398 and #4515.","created_at":"2015-12-18T19:21:30Z","updated_at":"2015-12-18T20:04:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf1884ccecbc04527ab7e43492f19ad4d6a79b10","assignee":{"login":"jtattermusch","id":9939684,"avatar_url":"https://avatars.githubusercontent.com/u/9939684?v=3","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/4538/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/4538/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/4538/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/d7e1a10628b87d9437f15ffb44d74499345ba757","head":{"label":"murgatroid99:ruby_bundle_core_release","ref":"ruby_bundle_core_release","sha":"d7e1a10628b87d9437f15ffb44d74499345ba757","user":{"login":"murgatroid99","id":961599,"avatar_url":"https://avatars.githubusercontent.com/u/961599?v=3","gravatar_id":"","url":"https://api.github.com/users/murgatroid99","html_url":"https://github.com/murgatroid99","followers_url":"https://api.github.com/users/murgatroid99/followers","following_url":"https://api.github.com/users/murgatroid99/following{/other_user}","gists_url":"https://api.github.com/users/murgatroid99/gists{/gist_id}","starred_url":"https://api.github.com/users/murgatroid99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murgatroid99/subscriptions","organizations_url":"https://api.github.com/users/murgatroid99/orgs","repos_url":"https://api.github.com/users/murgatroid99/repos","events_url":"https://api.github.com/users/murgatroid99/events{/privacy}","received_events_url":"https://api.github.com/users/murgatroid99/received_events","type":"User","site_admin":false},"repo":{"id":31379612,"name":"grpc","full_name":"murgatroid99/grpc","owner":{"login":"murgatroid99","id":961599,"avatar_url":"https://avatars.githubusercontent.com/u/961599?v=3","gravatar_id":"","url":"https://api.github.com/users/murgatroid99","html_url":"https://github.com/murgatroid99","followers_url":"https://api.github.com/users/murgatroid99/followers","following_url":"https://api.github.com/users/murgatroid99/following{/other_user}","gists_url":"https://api.github.com/users/murgatroid99/gists{/gist_id}","starred_url":"https://api.github.com/users/murgatroid99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murgatroid99/subscriptions","organizations_url":"https://api.github.com/users/murgatroid99/orgs","repos_url":"https://api.github.com/users/murgatroid99/repos","events_url":"https://api.github.com/users/murgatroid99/events{/privacy}","received_events_url":"https://api.github.com/users/murgatroid99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/murgatroid99/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/murgatroid99/grpc","forks_url":"https://api.github.com/repos/murgatroid99/grpc/forks","keys_url":"https://api.github.com/repos/murgatroid99/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/murgatroid99/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/murgatroid99/grpc/teams","hooks_url":"https://api.github.com/repos/murgatroid99/grpc/hooks","issue_events_url":"https://api.github.com/repos/murgatroid99/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/murgatroid99/grpc/events","assignees_url":"https://api.github.com/repos/murgatroid99/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/murgatroid99/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/murgatroid99/grpc/tags","blobs_url":"https://api.github.com/repos/murgatroid99/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/murgatroid99/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/murgatroid99/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/murgatroid99/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/murgatroid99/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/murgatroid99/grpc/languages","stargazers_url":"https://api.github.com/repos/murgatroid99/grpc/stargazers","contributors_url":"https://api.github.com/repos/murgatroid99/grpc/contributors","subscribers_url":"https://api.github.com/repos/murgatroid99/grpc/subscribers","subscription_url":"https://api.github.com/repos/murgatroid99/grpc/subscription","commits_url":"https://api.github.com/repos/murgatroid99/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/murgatroid99/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/murgatroid99/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/murgatroid99/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/murgatroid99/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/murgatroid99/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/murgatroid99/grpc/merges","archive_url":"https://api.github.com/repos/murgatroid99/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/murgatroid99/grpc/downloads","issues_url":"https://api.github.com/repos/murgatroid99/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/murgatroid99/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/murgatroid99/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/murgatroid99/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/murgatroid99/grpc/labels{/name}","releases_url":"https://api.github.com/repos/murgatroid99/grpc/releases{/id}","created_at":"2015-02-26T17:35:55Z","updated_at":"2015-05-08T16:33:06Z","pushed_at":"2015-12-18T19:18:41Z","git_url":"git://github.com/murgatroid99/grpc.git","ssh_url":"git@github.com:murgatroid99/grpc.git","clone_url":"https://github.com/murgatroid99/grpc.git","svn_url":"https://github.com/murgatroid99/grpc","homepage":"","size":65759,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"grpc:release-0_12","ref":"release-0_12","sha":"08ae945aac08bc36f77304ea06f826a4cf52b091","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","created_at":"2014-12-08T18:58:53Z","updated_at":"2015-12-18T15:00:28Z","pushed_at":"2015-12-18T19:40:50Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":163652,"stargazers_count":3826,"watchers_count":3826,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":600,"mirror_url":null,"open_issues_count":540,"forks":600,"open_issues":540,"watchers":3826,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/4538"},"html":{"href":"https://github.com/grpc/grpc/pull/4538"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/4538"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/4538/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/4538/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/4538/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/d7e1a10628b87d9437f15ffb44d74499345ba757"}}}}