{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/16366","labels_url":"https://api.github.com/repos/docker/docker/issues/16366/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/16366/comments","events_url":"https://api.github.com/repos/docker/docker/issues/16366/events","html_url":"https://github.com/docker/docker/pull/16366","id":106917781,"number":16366,"title":"refactor logs to not use internal data structures","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-09-17T06:02:18Z","updated_at":"2015-10-08T21:10:15Z","closed_at":"2015-10-08T21:05:02Z","pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/16366","html_url":"https://github.com/docker/docker/pull/16366","diff_url":"https://github.com/docker/docker/pull/16366.diff","patch_url":"https://github.com/docker/docker/pull/16366.patch"},"body":"In preparation for future work to pull the APIs into a separate deliverable, we need to not make references back into the daemon or other core engine code. The logs command referenced the daemon-struct for a container. This work attempts to move the code that does that into the daemon itself.\r\n\r\nIs there any worry about not bailing as early on failure? \r\n\r\nGiven the use of daemon.Get() for checking if a container exists, is the interest in a new function to do that and return some basic information? Looking at some of this stuff it feels like something missing, but I'm not sure it would have much use outside of the couple locations that already exist. \r\n\r\nsee also #16361 \r\n\r\n\r\ncc @icecrime @calavera \r\n& @cpuguy83 because he seemed interested in the last one."},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/146685939","html_url":"https://github.com/docker/docker/pull/16366#issuecomment-146685939","issue_url":"https://api.github.com/repos/docker/docker/issues/16366","id":146685939,"user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"created_at":"2015-10-08T21:10:15Z","updated_at":"2015-10-08T21:10:15Z","body":"ah, had a small nit on the test, but no biggies :cat:, I can't compete with jess :stuck_out_tongue_closed_eyes: "}}