{"action":"created","issue":{"url":"https://api.github.com/repos/cefsharp/CefSharp/issues/1358","labels_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/1358/labels{/name}","comments_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/1358/comments","events_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/1358/events","html_url":"https://github.com/cefsharp/CefSharp/pull/1358","id":112783210,"number":1358,"title":"Fix offscreen browser browser settings nullptr","user":{"login":"illfang","id":2493562,"avatar_url":"https://avatars.githubusercontent.com/u/2493562?v=3","gravatar_id":"","url":"https://api.github.com/users/illfang","html_url":"https://github.com/illfang","followers_url":"https://api.github.com/users/illfang/followers","following_url":"https://api.github.com/users/illfang/following{/other_user}","gists_url":"https://api.github.com/users/illfang/gists{/gist_id}","starred_url":"https://api.github.com/users/illfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illfang/subscriptions","organizations_url":"https://api.github.com/users/illfang/orgs","repos_url":"https://api.github.com/users/illfang/repos","events_url":"https://api.github.com/users/illfang/events{/privacy}","received_events_url":"https://api.github.com/users/illfang/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cefsharp/CefSharp/milestones/19","html_url":"https://github.com/cefsharp/CefSharp/milestones/43.0.1","labels_url":"https://api.github.com/repos/cefsharp/CefSharp/milestones/19/labels","id":1315132,"number":19,"title":"43.0.1","description":"Maintenance/Bug Fix Release. ","creator":{"login":"amaitland","id":307872,"avatar_url":"https://avatars.githubusercontent.com/u/307872?v=3","gravatar_id":"","url":"https://api.github.com/users/amaitland","html_url":"https://github.com/amaitland","followers_url":"https://api.github.com/users/amaitland/followers","following_url":"https://api.github.com/users/amaitland/following{/other_user}","gists_url":"https://api.github.com/users/amaitland/gists{/gist_id}","starred_url":"https://api.github.com/users/amaitland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaitland/subscriptions","organizations_url":"https://api.github.com/users/amaitland/orgs","repos_url":"https://api.github.com/users/amaitland/repos","events_url":"https://api.github.com/users/amaitland/events{/privacy}","received_events_url":"https://api.github.com/users/amaitland/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":10,"state":"open","created_at":"2015-09-20T12:59:51Z","updated_at":"2015-10-22T21:44:58Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-10-22T11:30:26Z","updated_at":"2015-10-22T21:45:28Z","closed_at":"2015-10-22T21:43:49Z","pull_request":{"url":"https://api.github.com/repos/cefsharp/CefSharp/pulls/1358","html_url":"https://github.com/cefsharp/CefSharp/pull/1358","diff_url":"https://github.com/cefsharp/CefSharp/pull/1358.diff","patch_url":"https://github.com/cefsharp/CefSharp/pull/1358.patch"},"body":"There is a bug with the optional browser settings in the offscreen browser project which will lead to a null poiinter exception if no settings are available.\r\n\r\nExample:\r\nhttps://github.com/illfang/CefSharp/tree/offscreen-browser-browser-settings-nullptr-test\r\n```\r\nSystem.NullReferenceException: Object reference not set to an instance of an object.\r\n   at CefSharp.BrowserSettings.get_OffScreenTransparentBackground()\r\n   at CefSharp.ManagedCefBrowserAdapter.CreateOffscreenBrowser(IntPtr windowHandle, BrowserSettings browserSettings, RequestContext requestContext, String address)\r\n   at CefSharp.OffScreen.ChromiumWebBrowser.CreateBrowser(IntPtr windowHandle, String address, BrowserSettings browserSettings, RequestContext requestcontext)\r\n   at CefSharp.OffScreen.ChromiumWebBrowser..ctor(String address, BrowserSettings browserSettings, RequestContext requestcontext, Boolean automaticallyCreateBrowser)\r\n```\r\n\r\nProbably related to dca52f931fcb7e0d435b2e1f46cd1d49fed5a2d3\r\n\r\nI suggest two version to fix this. This is the first version which will always create the offscreen browser using the instance settings, request context and address. The instance browser settings are checked for null in the constructor.\r\n\r\nThe second solution is described in cefsharp/CefSharp/pull/1359\r\n\r\nI'm looking forward to your feedback. Feel free to close one of the PRs if you decide to merge one."},"comment":{"url":"https://api.github.com/repos/cefsharp/CefSharp/issues/comments/150365301","html_url":"https://github.com/cefsharp/CefSharp/pull/1358#issuecomment-150365301","issue_url":"https://api.github.com/repos/cefsharp/CefSharp/issues/1358","id":150365301,"user":{"login":"amaitland","id":307872,"avatar_url":"https://avatars.githubusercontent.com/u/307872?v=3","gravatar_id":"","url":"https://api.github.com/users/amaitland","html_url":"https://github.com/amaitland","followers_url":"https://api.github.com/users/amaitland/followers","following_url":"https://api.github.com/users/amaitland/following{/other_user}","gists_url":"https://api.github.com/users/amaitland/gists{/gist_id}","starred_url":"https://api.github.com/users/amaitland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaitland/subscriptions","organizations_url":"https://api.github.com/users/amaitland/orgs","repos_url":"https://api.github.com/users/amaitland/repos","events_url":"https://api.github.com/users/amaitland/events{/privacy}","received_events_url":"https://api.github.com/users/amaitland/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T21:45:28Z","updated_at":"2015-10-22T21:45:28Z","body":"Setting milestone to `43.0.1` as that's the first release this change will appear in (even though it's merged initially into `master`)."}}