{"action":"closed","number":344,"pull_request":{"url":"https://api.github.com/repos/rebar/rebar3/pulls/344","id":33566393,"html_url":"https://github.com/rebar/rebar3/pull/344","diff_url":"https://github.com/rebar/rebar3/pull/344.diff","patch_url":"https://github.com/rebar/rebar3/pull/344.patch","issue_url":"https://api.github.com/repos/rebar/rebar3/issues/344","number":344,"state":"closed","locked":false,"title":"Default deps always to the default profile","user":{"login":"ferd","id":111141,"avatar_url":"https://avatars.githubusercontent.com/u/111141?v=3","gravatar_id":"","url":"https://api.github.com/users/ferd","html_url":"https://github.com/ferd","followers_url":"https://api.github.com/users/ferd/followers","following_url":"https://api.github.com/users/ferd/following{/other_user}","gists_url":"https://api.github.com/users/ferd/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd/subscriptions","organizations_url":"https://api.github.com/users/ferd/orgs","repos_url":"https://api.github.com/users/ferd/repos","events_url":"https://api.github.com/users/ferd/events{/privacy}","received_events_url":"https://api.github.com/users/ferd/received_events","type":"User","site_admin":false},"body":"When fetching dependencies for the first time using a profile (`rebar3\r\nas prod release` or `rebar3 ct`), the dependencies get fetched into the\r\nnon-default profile. This has two consequences:\r\n\r\n- the files get re-downloaded on follow-up runs\r\n- the lock file includes incomplete or too many deps in its list\r\n\r\nThis patch forces dependencies in the default profile to be stored in\r\n_build/default/lib even when running under other profiles, then symlinks\r\nthem to the correct one.\r\n\r\nThis makes it so common dependencies in 'default' be downloaded there\r\nand avoids re-downloading them. Should also fix the lock issues.\r\n\r\nShould address https://github.com/rebar/rebar3/issues/307 and https://github.com/rebar/rebar3/issues/339","created_at":"2015-04-17T17:46:51Z","updated_at":"2015-04-18T16:15:22Z","closed_at":"2015-04-18T16:15:22Z","merged_at":"2015-04-18T16:15:22Z","merge_commit_sha":"92f62bb7f39e013b0d555efcfa9c59b6d511fd75","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rebar/rebar3/pulls/344/commits","review_comments_url":"https://api.github.com/repos/rebar/rebar3/pulls/344/comments","review_comment_url":"https://api.github.com/repos/rebar/rebar3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rebar/rebar3/issues/344/comments","statuses_url":"https://api.github.com/repos/rebar/rebar3/statuses/2ff4ac6d5049746be80263e48df5d864606e22d6","head":{"label":"ferd:proper-default-fetch","ref":"proper-default-fetch","sha":"2ff4ac6d5049746be80263e48df5d864606e22d6","user":{"login":"ferd","id":111141,"avatar_url":"https://avatars.githubusercontent.com/u/111141?v=3","gravatar_id":"","url":"https://api.github.com/users/ferd","html_url":"https://github.com/ferd","followers_url":"https://api.github.com/users/ferd/followers","following_url":"https://api.github.com/users/ferd/following{/other_user}","gists_url":"https://api.github.com/users/ferd/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd/subscriptions","organizations_url":"https://api.github.com/users/ferd/orgs","repos_url":"https://api.github.com/users/ferd/repos","events_url":"https://api.github.com/users/ferd/events{/privacy}","received_events_url":"https://api.github.com/users/ferd/received_events","type":"User","site_admin":false},"repo":{"id":29505952,"name":"rebar3","full_name":"ferd/rebar3","owner":{"login":"ferd","id":111141,"avatar_url":"https://avatars.githubusercontent.com/u/111141?v=3","gravatar_id":"","url":"https://api.github.com/users/ferd","html_url":"https://github.com/ferd","followers_url":"https://api.github.com/users/ferd/followers","following_url":"https://api.github.com/users/ferd/following{/other_user}","gists_url":"https://api.github.com/users/ferd/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd/subscriptions","organizations_url":"https://api.github.com/users/ferd/orgs","repos_url":"https://api.github.com/users/ferd/repos","events_url":"https://api.github.com/users/ferd/events{/privacy}","received_events_url":"https://api.github.com/users/ferd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferd/rebar3","description":"Erlang build tool that makes it easy to compile and test Erlang applications, port drivers and releases.","fork":true,"url":"https://api.github.com/repos/ferd/rebar3","forks_url":"https://api.github.com/repos/ferd/rebar3/forks","keys_url":"https://api.github.com/repos/ferd/rebar3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferd/rebar3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferd/rebar3/teams","hooks_url":"https://api.github.com/repos/ferd/rebar3/hooks","issue_events_url":"https://api.github.com/repos/ferd/rebar3/issues/events{/number}","events_url":"https://api.github.com/repos/ferd/rebar3/events","assignees_url":"https://api.github.com/repos/ferd/rebar3/assignees{/user}","branches_url":"https://api.github.com/repos/ferd/rebar3/branches{/branch}","tags_url":"https://api.github.com/repos/ferd/rebar3/tags","blobs_url":"https://api.github.com/repos/ferd/rebar3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferd/rebar3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferd/rebar3/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferd/rebar3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferd/rebar3/statuses/{sha}","languages_url":"https://api.github.com/repos/ferd/rebar3/languages","stargazers_url":"https://api.github.com/repos/ferd/rebar3/stargazers","contributors_url":"https://api.github.com/repos/ferd/rebar3/contributors","subscribers_url":"https://api.github.com/repos/ferd/rebar3/subscribers","subscription_url":"https://api.github.com/repos/ferd/rebar3/subscription","commits_url":"https://api.github.com/repos/ferd/rebar3/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferd/rebar3/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferd/rebar3/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferd/rebar3/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferd/rebar3/contents/{+path}","compare_url":"https://api.github.com/repos/ferd/rebar3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferd/rebar3/merges","archive_url":"https://api.github.com/repos/ferd/rebar3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferd/rebar3/downloads","issues_url":"https://api.github.com/repos/ferd/rebar3/issues{/number}","pulls_url":"https://api.github.com/repos/ferd/rebar3/pulls{/number}","milestones_url":"https://api.github.com/repos/ferd/rebar3/milestones{/number}","notifications_url":"https://api.github.com/repos/ferd/rebar3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferd/rebar3/labels{/name}","releases_url":"https://api.github.com/repos/ferd/rebar3/releases{/id}","created_at":"2015-01-20T01:38:09Z","updated_at":"2015-02-13T19:44:40Z","pushed_at":"2015-04-18T13:58:28Z","git_url":"git://github.com/ferd/rebar3.git","ssh_url":"git@github.com:ferd/rebar3.git","clone_url":"https://github.com/ferd/rebar3.git","svn_url":"https://github.com/ferd/rebar3","homepage":"  http://www.rebar3.org","size":2977,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rebar:master","ref":"master","sha":"123b0ea61afd5d1524d0c08b5e8ebcc3b01f0866","user":{"login":"rebar","id":2651508,"avatar_url":"https://avatars.githubusercontent.com/u/2651508?v=3","gravatar_id":"","url":"https://api.github.com/users/rebar","html_url":"https://github.com/rebar","followers_url":"https://api.github.com/users/rebar/followers","following_url":"https://api.github.com/users/rebar/following{/other_user}","gists_url":"https://api.github.com/users/rebar/gists{/gist_id}","starred_url":"https://api.github.com/users/rebar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebar/subscriptions","organizations_url":"https://api.github.com/users/rebar/orgs","repos_url":"https://api.github.com/users/rebar/repos","events_url":"https://api.github.com/users/rebar/events{/privacy}","received_events_url":"https://api.github.com/users/rebar/received_events","type":"Organization","site_admin":false},"repo":{"id":26610130,"name":"rebar3","full_name":"rebar/rebar3","owner":{"login":"rebar","id":2651508,"avatar_url":"https://avatars.githubusercontent.com/u/2651508?v=3","gravatar_id":"","url":"https://api.github.com/users/rebar","html_url":"https://github.com/rebar","followers_url":"https://api.github.com/users/rebar/followers","following_url":"https://api.github.com/users/rebar/following{/other_user}","gists_url":"https://api.github.com/users/rebar/gists{/gist_id}","starred_url":"https://api.github.com/users/rebar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebar/subscriptions","organizations_url":"https://api.github.com/users/rebar/orgs","repos_url":"https://api.github.com/users/rebar/repos","events_url":"https://api.github.com/users/rebar/events{/privacy}","received_events_url":"https://api.github.com/users/rebar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rebar/rebar3","description":"Erlang build tool that makes it easy to compile and test Erlang applications, port drivers and releases.","fork":false,"url":"https://api.github.com/repos/rebar/rebar3","forks_url":"https://api.github.com/repos/rebar/rebar3/forks","keys_url":"https://api.github.com/repos/rebar/rebar3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rebar/rebar3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rebar/rebar3/teams","hooks_url":"https://api.github.com/repos/rebar/rebar3/hooks","issue_events_url":"https://api.github.com/repos/rebar/rebar3/issues/events{/number}","events_url":"https://api.github.com/repos/rebar/rebar3/events","assignees_url":"https://api.github.com/repos/rebar/rebar3/assignees{/user}","branches_url":"https://api.github.com/repos/rebar/rebar3/branches{/branch}","tags_url":"https://api.github.com/repos/rebar/rebar3/tags","blobs_url":"https://api.github.com/repos/rebar/rebar3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rebar/rebar3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rebar/rebar3/git/refs{/sha}","trees_url":"https://api.github.com/repos/rebar/rebar3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rebar/rebar3/statuses/{sha}","languages_url":"https://api.github.com/repos/rebar/rebar3/languages","stargazers_url":"https://api.github.com/repos/rebar/rebar3/stargazers","contributors_url":"https://api.github.com/repos/rebar/rebar3/contributors","subscribers_url":"https://api.github.com/repos/rebar/rebar3/subscribers","subscription_url":"https://api.github.com/repos/rebar/rebar3/subscription","commits_url":"https://api.github.com/repos/rebar/rebar3/commits{/sha}","git_commits_url":"https://api.github.com/repos/rebar/rebar3/git/commits{/sha}","comments_url":"https://api.github.com/repos/rebar/rebar3/comments{/number}","issue_comment_url":"https://api.github.com/repos/rebar/rebar3/issues/comments{/number}","contents_url":"https://api.github.com/repos/rebar/rebar3/contents/{+path}","compare_url":"https://api.github.com/repos/rebar/rebar3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rebar/rebar3/merges","archive_url":"https://api.github.com/repos/rebar/rebar3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rebar/rebar3/downloads","issues_url":"https://api.github.com/repos/rebar/rebar3/issues{/number}","pulls_url":"https://api.github.com/repos/rebar/rebar3/pulls{/number}","milestones_url":"https://api.github.com/repos/rebar/rebar3/milestones{/number}","notifications_url":"https://api.github.com/repos/rebar/rebar3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rebar/rebar3/labels{/name}","releases_url":"https://api.github.com/repos/rebar/rebar3/releases{/id}","created_at":"2014-11-13T22:02:03Z","updated_at":"2015-04-18T03:01:34Z","pushed_at":"2015-04-18T16:15:23Z","git_url":"git://github.com/rebar/rebar3.git","ssh_url":"git@github.com:rebar/rebar3.git","clone_url":"https://github.com/rebar/rebar3.git","svn_url":"https://github.com/rebar/rebar3","homepage":"  http://www.rebar3.org","size":6242,"stargazers_count":122,"watchers_count":122,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":17,"forks":28,"open_issues":17,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rebar/rebar3/pulls/344"},"html":{"href":"https://github.com/rebar/rebar3/pull/344"},"issue":{"href":"https://api.github.com/repos/rebar/rebar3/issues/344"},"comments":{"href":"https://api.github.com/repos/rebar/rebar3/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/rebar/rebar3/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/rebar/rebar3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rebar/rebar3/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/rebar/rebar3/statuses/2ff4ac6d5049746be80263e48df5d864606e22d6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tsloughter","id":36227,"avatar_url":"https://avatars.githubusercontent.com/u/36227?v=3","gravatar_id":"","url":"https://api.github.com/users/tsloughter","html_url":"https://github.com/tsloughter","followers_url":"https://api.github.com/users/tsloughter/followers","following_url":"https://api.github.com/users/tsloughter/following{/other_user}","gists_url":"https://api.github.com/users/tsloughter/gists{/gist_id}","starred_url":"https://api.github.com/users/tsloughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsloughter/subscriptions","organizations_url":"https://api.github.com/users/tsloughter/orgs","repos_url":"https://api.github.com/users/tsloughter/repos","events_url":"https://api.github.com/users/tsloughter/events{/privacy}","received_events_url":"https://api.github.com/users/tsloughter/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":1,"additions":146,"deletions":38,"changed_files":4}}