{"action":"created","comment":{"url":"https://api.github.com/repos/cocaine/cocaine-core/pulls/comments/25721549","id":25721549,"diff_hunk":"@@ -60,6 +60,11 @@ struct streamed {\n         return *this;\n     }\n \n+    template<class UpstreamType>\n+    void attach(UpstreamType&& upstream) const {","path":"include/cocaine/rpc/slot/streamed.hpp","position":5,"original_position":5,"commit_id":"f5647c2876c8c6280904bbdfbe38b08e5affd949","original_commit_id":"f5647c2876c8c6280904bbdfbe38b08e5affd949","user":{"login":"Kobolog","id":318866,"avatar_url":"https://avatars.githubusercontent.com/u/318866?v=3","gravatar_id":"","url":"https://api.github.com/users/Kobolog","html_url":"https://github.com/Kobolog","followers_url":"https://api.github.com/users/Kobolog/followers","following_url":"https://api.github.com/users/Kobolog/following{/other_user}","gists_url":"https://api.github.com/users/Kobolog/gists{/gist_id}","starred_url":"https://api.github.com/users/Kobolog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kobolog/subscriptions","organizations_url":"https://api.github.com/users/Kobolog/orgs","repos_url":"https://api.github.com/users/Kobolog/repos","events_url":"https://api.github.com/users/Kobolog/events{/privacy}","received_events_url":"https://api.github.com/users/Kobolog/received_events","type":"User","site_admin":false},"body":"Here too.","created_at":"2015-03-03T20:07:33Z","updated_at":"2015-03-03T20:07:33Z","html_url":"https://github.com/cocaine/cocaine-core/pull/160#discussion_r25721549","pull_request_url":"https://api.github.com/repos/cocaine/cocaine-core/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/cocaine/cocaine-core/pulls/comments/25721549"},"html":{"href":"https://github.com/cocaine/cocaine-core/pull/160#discussion_r25721549"},"pull_request":{"href":"https://api.github.com/repos/cocaine/cocaine-core/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/cocaine/cocaine-core/pulls/160","id":30366860,"html_url":"https://github.com/cocaine/cocaine-core/pull/160","diff_url":"https://github.com/cocaine/cocaine-core/pull/160.diff","patch_url":"https://github.com/cocaine/cocaine-core/pull/160.patch","issue_url":"https://api.github.com/repos/cocaine/cocaine-core/issues/160","number":160,"state":"open","locked":false,"title":"Deffered for custom slot","user":{"login":"antmat","id":691770,"avatar_url":"https://avatars.githubusercontent.com/u/691770?v=3","gravatar_id":"","url":"https://api.github.com/users/antmat","html_url":"https://github.com/antmat","followers_url":"https://api.github.com/users/antmat/followers","following_url":"https://api.github.com/users/antmat/following{/other_user}","gists_url":"https://api.github.com/users/antmat/gists{/gist_id}","starred_url":"https://api.github.com/users/antmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antmat/subscriptions","organizations_url":"https://api.github.com/users/antmat/orgs","repos_url":"https://api.github.com/users/antmat/repos","events_url":"https://api.github.com/users/antmat/events{/privacy}","received_events_url":"https://api.github.com/users/antmat/received_events","type":"User","site_admin":false},"body":"Deffered is quite usefull even for custom protocol transitions. This patch allows defferred and streamed to be used in custom slots.\r\nAlso some const callables such as std::mem_fn can call only underlying const methods. So in general we might want to pass reference instead of const reference to tuple::invoke. This patch only allows passing rvalue references additionally to lvalue const references to be compatible with old behaviour.","created_at":"2015-03-03T11:49:11Z","updated_at":"2015-03-03T20:07:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49c36c06c770f5b4c96730714eada532fe67fe37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cocaine/cocaine-core/pulls/160/commits","review_comments_url":"https://api.github.com/repos/cocaine/cocaine-core/pulls/160/comments","review_comment_url":"https://api.github.com/repos/cocaine/cocaine-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocaine/cocaine-core/issues/160/comments","statuses_url":"https://api.github.com/repos/cocaine/cocaine-core/statuses/f5647c2876c8c6280904bbdfbe38b08e5affd949","head":{"label":"antmat:deffered_for_custom_slot","ref":"deffered_for_custom_slot","sha":"f5647c2876c8c6280904bbdfbe38b08e5affd949","user":{"login":"antmat","id":691770,"avatar_url":"https://avatars.githubusercontent.com/u/691770?v=3","gravatar_id":"","url":"https://api.github.com/users/antmat","html_url":"https://github.com/antmat","followers_url":"https://api.github.com/users/antmat/followers","following_url":"https://api.github.com/users/antmat/following{/other_user}","gists_url":"https://api.github.com/users/antmat/gists{/gist_id}","starred_url":"https://api.github.com/users/antmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antmat/subscriptions","organizations_url":"https://api.github.com/users/antmat/orgs","repos_url":"https://api.github.com/users/antmat/repos","events_url":"https://api.github.com/users/antmat/events{/privacy}","received_events_url":"https://api.github.com/users/antmat/received_events","type":"User","site_admin":false},"repo":{"id":30540805,"name":"cocaine-core","full_name":"antmat/cocaine-core","owner":{"login":"antmat","id":691770,"avatar_url":"https://avatars.githubusercontent.com/u/691770?v=3","gravatar_id":"","url":"https://api.github.com/users/antmat","html_url":"https://github.com/antmat","followers_url":"https://api.github.com/users/antmat/followers","following_url":"https://api.github.com/users/antmat/following{/other_user}","gists_url":"https://api.github.com/users/antmat/gists{/gist_id}","starred_url":"https://api.github.com/users/antmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antmat/subscriptions","organizations_url":"https://api.github.com/users/antmat/orgs","repos_url":"https://api.github.com/users/antmat/repos","events_url":"https://api.github.com/users/antmat/events{/privacy}","received_events_url":"https://api.github.com/users/antmat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antmat/cocaine-core","description":"An open platform to build your own PaaS clouds.","fork":true,"url":"https://api.github.com/repos/antmat/cocaine-core","forks_url":"https://api.github.com/repos/antmat/cocaine-core/forks","keys_url":"https://api.github.com/repos/antmat/cocaine-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antmat/cocaine-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antmat/cocaine-core/teams","hooks_url":"https://api.github.com/repos/antmat/cocaine-core/hooks","issue_events_url":"https://api.github.com/repos/antmat/cocaine-core/issues/events{/number}","events_url":"https://api.github.com/repos/antmat/cocaine-core/events","assignees_url":"https://api.github.com/repos/antmat/cocaine-core/assignees{/user}","branches_url":"https://api.github.com/repos/antmat/cocaine-core/branches{/branch}","tags_url":"https://api.github.com/repos/antmat/cocaine-core/tags","blobs_url":"https://api.github.com/repos/antmat/cocaine-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antmat/cocaine-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antmat/cocaine-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/antmat/cocaine-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antmat/cocaine-core/statuses/{sha}","languages_url":"https://api.github.com/repos/antmat/cocaine-core/languages","stargazers_url":"https://api.github.com/repos/antmat/cocaine-core/stargazers","contributors_url":"https://api.github.com/repos/antmat/cocaine-core/contributors","subscribers_url":"https://api.github.com/repos/antmat/cocaine-core/subscribers","subscription_url":"https://api.github.com/repos/antmat/cocaine-core/subscription","commits_url":"https://api.github.com/repos/antmat/cocaine-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/antmat/cocaine-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/antmat/cocaine-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/antmat/cocaine-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/antmat/cocaine-core/contents/{+path}","compare_url":"https://api.github.com/repos/antmat/cocaine-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antmat/cocaine-core/merges","archive_url":"https://api.github.com/repos/antmat/cocaine-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antmat/cocaine-core/downloads","issues_url":"https://api.github.com/repos/antmat/cocaine-core/issues{/number}","pulls_url":"https://api.github.com/repos/antmat/cocaine-core/pulls{/number}","milestones_url":"https://api.github.com/repos/antmat/cocaine-core/milestones{/number}","notifications_url":"https://api.github.com/repos/antmat/cocaine-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antmat/cocaine-core/labels{/name}","releases_url":"https://api.github.com/repos/antmat/cocaine-core/releases{/id}","created_at":"2015-02-09T14:53:42Z","updated_at":"2015-03-03T11:44:48Z","pushed_at":"2015-03-03T19:44:04Z","git_url":"git://github.com/antmat/cocaine-core.git","ssh_url":"git@github.com:antmat/cocaine-core.git","clone_url":"https://github.com/antmat/cocaine-core.git","svn_url":"https://github.com/antmat/cocaine-core","homepage":"","size":14039,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cocaine:master","ref":"master","sha":"d17133414440f0989e2b41e4fbcb995db94f9245","user":{"login":"cocaine","id":1553730,"avatar_url":"https://avatars.githubusercontent.com/u/1553730?v=3","gravatar_id":"","url":"https://api.github.com/users/cocaine","html_url":"https://github.com/cocaine","followers_url":"https://api.github.com/users/cocaine/followers","following_url":"https://api.github.com/users/cocaine/following{/other_user}","gists_url":"https://api.github.com/users/cocaine/gists{/gist_id}","starred_url":"https://api.github.com/users/cocaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocaine/subscriptions","organizations_url":"https://api.github.com/users/cocaine/orgs","repos_url":"https://api.github.com/users/cocaine/repos","events_url":"https://api.github.com/users/cocaine/events{/privacy}","received_events_url":"https://api.github.com/users/cocaine/received_events","type":"Organization","site_admin":false},"repo":{"id":1516094,"name":"cocaine-core","full_name":"cocaine/cocaine-core","owner":{"login":"cocaine","id":1553730,"avatar_url":"https://avatars.githubusercontent.com/u/1553730?v=3","gravatar_id":"","url":"https://api.github.com/users/cocaine","html_url":"https://github.com/cocaine","followers_url":"https://api.github.com/users/cocaine/followers","following_url":"https://api.github.com/users/cocaine/following{/other_user}","gists_url":"https://api.github.com/users/cocaine/gists{/gist_id}","starred_url":"https://api.github.com/users/cocaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocaine/subscriptions","organizations_url":"https://api.github.com/users/cocaine/orgs","repos_url":"https://api.github.com/users/cocaine/repos","events_url":"https://api.github.com/users/cocaine/events{/privacy}","received_events_url":"https://api.github.com/users/cocaine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocaine/cocaine-core","description":"An open platform to build your own PaaS clouds.","fork":false,"url":"https://api.github.com/repos/cocaine/cocaine-core","forks_url":"https://api.github.com/repos/cocaine/cocaine-core/forks","keys_url":"https://api.github.com/repos/cocaine/cocaine-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocaine/cocaine-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocaine/cocaine-core/teams","hooks_url":"https://api.github.com/repos/cocaine/cocaine-core/hooks","issue_events_url":"https://api.github.com/repos/cocaine/cocaine-core/issues/events{/number}","events_url":"https://api.github.com/repos/cocaine/cocaine-core/events","assignees_url":"https://api.github.com/repos/cocaine/cocaine-core/assignees{/user}","branches_url":"https://api.github.com/repos/cocaine/cocaine-core/branches{/branch}","tags_url":"https://api.github.com/repos/cocaine/cocaine-core/tags","blobs_url":"https://api.github.com/repos/cocaine/cocaine-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocaine/cocaine-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocaine/cocaine-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocaine/cocaine-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocaine/cocaine-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cocaine/cocaine-core/languages","stargazers_url":"https://api.github.com/repos/cocaine/cocaine-core/stargazers","contributors_url":"https://api.github.com/repos/cocaine/cocaine-core/contributors","subscribers_url":"https://api.github.com/repos/cocaine/cocaine-core/subscribers","subscription_url":"https://api.github.com/repos/cocaine/cocaine-core/subscription","commits_url":"https://api.github.com/repos/cocaine/cocaine-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocaine/cocaine-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocaine/cocaine-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocaine/cocaine-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocaine/cocaine-core/contents/{+path}","compare_url":"https://api.github.com/repos/cocaine/cocaine-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocaine/cocaine-core/merges","archive_url":"https://api.github.com/repos/cocaine/cocaine-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocaine/cocaine-core/downloads","issues_url":"https://api.github.com/repos/cocaine/cocaine-core/issues{/number}","pulls_url":"https://api.github.com/repos/cocaine/cocaine-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cocaine/cocaine-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cocaine/cocaine-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocaine/cocaine-core/labels{/name}","releases_url":"https://api.github.com/repos/cocaine/cocaine-core/releases{/id}","created_at":"2011-03-23T12:31:26Z","updated_at":"2015-03-02T15:00:20Z","pushed_at":"2015-02-20T15:09:51Z","git_url":"git://github.com/cocaine/cocaine-core.git","ssh_url":"git@github.com:cocaine/cocaine-core.git","clone_url":"https://github.com/cocaine/cocaine-core.git","svn_url":"https://github.com/cocaine/cocaine-core","homepage":"","size":19467,"stargazers_count":797,"watchers_count":797,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":6,"forks":73,"open_issues":6,"watchers":797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cocaine/cocaine-core/pulls/160"},"html":{"href":"https://github.com/cocaine/cocaine-core/pull/160"},"issue":{"href":"https://api.github.com/repos/cocaine/cocaine-core/issues/160"},"comments":{"href":"https://api.github.com/repos/cocaine/cocaine-core/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/cocaine/cocaine-core/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/cocaine/cocaine-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocaine/cocaine-core/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/cocaine/cocaine-core/statuses/f5647c2876c8c6280904bbdfbe38b08e5affd949"}}}}