{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/47397890","id":47397890,"diff_hunk":"@@ -74,8 +74,7 @@ def self.prefetch(resources)\n   def self.reposdir(conf='/etc/yum.conf', dirs=['/etc/yum.repos.d', '/etc/yum/repos.d'])\n     reposdir = find_conf_value('reposdir', conf)\n     # Use directories in reposdir if they are set instead of default\n-    dirs = reposdir.split(\",\").map(&:strip) if reposdir\n-    \n+    dirs = reposdir.split(/[,|\\s]/).map(&:strip) if reposdir","path":"lib/puppet/provider/yumrepo/inifile.rb","position":6,"original_position":6,"commit_id":"835ca434f930dc98c33af548d6d1b861fd3a875b","original_commit_id":"835ca434f930dc98c33af548d6d1b861fd3a875b","user":{"login":"petems","id":1064715,"avatar_url":"https://avatars.githubusercontent.com/u/1064715?v=3","gravatar_id":"","url":"https://api.github.com/users/petems","html_url":"https://github.com/petems","followers_url":"https://api.github.com/users/petems/followers","following_url":"https://api.github.com/users/petems/following{/other_user}","gists_url":"https://api.github.com/users/petems/gists{/gist_id}","starred_url":"https://api.github.com/users/petems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petems/subscriptions","organizations_url":"https://api.github.com/users/petems/orgs","repos_url":"https://api.github.com/users/petems/repos","events_url":"https://api.github.com/users/petems/events{/privacy}","received_events_url":"https://api.github.com/users/petems/received_events","type":"User","site_admin":false},"body":"Hmm does `\\s` match newlines? Should probably catch that too...","created_at":"2015-12-11T19:56:49Z","updated_at":"2015-12-11T19:56:49Z","html_url":"https://github.com/puppetlabs/puppet/pull/4495#discussion_r47397890","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4495","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/47397890"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/4495#discussion_r47397890"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4495"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4495","id":53388073,"html_url":"https://github.com/puppetlabs/puppet/pull/4495","diff_url":"https://github.com/puppetlabs/puppet/pull/4495.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/4495.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4495","number":4495,"state":"open","locked":false,"title":"(PUP-4744) Fixes `reposdir` split by whitespace","user":{"login":"petems","id":1064715,"avatar_url":"https://avatars.githubusercontent.com/u/1064715?v=3","gravatar_id":"","url":"https://api.github.com/users/petems","html_url":"https://github.com/petems","followers_url":"https://api.github.com/users/petems/followers","following_url":"https://api.github.com/users/petems/following{/other_user}","gists_url":"https://api.github.com/users/petems/gists{/gist_id}","starred_url":"https://api.github.com/users/petems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petems/subscriptions","organizations_url":"https://api.github.com/users/petems/orgs","repos_url":"https://api.github.com/users/petems/repos","events_url":"https://api.github.com/users/petems/events{/privacy}","received_events_url":"https://api.github.com/users/petems/received_events","type":"User","site_admin":false},"body":"* `reposdir` can be split by whitespace - http://yum.baseurl.org/gitweb?p=yum.git;a=blob;f=yum/config.py;h=97e5e3d3b063294a96227a67cce43a9655cd3aa6;hb=30c993c19b8b85f44e7cec436484862ab55a6961#l171\n- Puppet previously only split by commas\n- Now changed to a regex of [,|\\s] which will catch whitespace and commas\n- Added new spec for this new regex","created_at":"2015-12-11T12:40:54Z","updated_at":"2015-12-11T19:56:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d7866636893f0a522303e2937b18ddcdf74715b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4495/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4495/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4495/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/835ca434f930dc98c33af548d6d1b861fd3a875b","head":{"label":"petems:PUP-4744-fix_regex_for_yumrepo_inifile","ref":"PUP-4744-fix_regex_for_yumrepo_inifile","sha":"835ca434f930dc98c33af548d6d1b861fd3a875b","user":{"login":"petems","id":1064715,"avatar_url":"https://avatars.githubusercontent.com/u/1064715?v=3","gravatar_id":"","url":"https://api.github.com/users/petems","html_url":"https://github.com/petems","followers_url":"https://api.github.com/users/petems/followers","following_url":"https://api.github.com/users/petems/following{/other_user}","gists_url":"https://api.github.com/users/petems/gists{/gist_id}","starred_url":"https://api.github.com/users/petems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petems/subscriptions","organizations_url":"https://api.github.com/users/petems/orgs","repos_url":"https://api.github.com/users/petems/repos","events_url":"https://api.github.com/users/petems/events{/privacy}","received_events_url":"https://api.github.com/users/petems/received_events","type":"User","site_admin":false},"repo":{"id":16104292,"name":"puppet","full_name":"petems/puppet","owner":{"login":"petems","id":1064715,"avatar_url":"https://avatars.githubusercontent.com/u/1064715?v=3","gravatar_id":"","url":"https://api.github.com/users/petems","html_url":"https://github.com/petems","followers_url":"https://api.github.com/users/petems/followers","following_url":"https://api.github.com/users/petems/following{/other_user}","gists_url":"https://api.github.com/users/petems/gists{/gist_id}","starred_url":"https://api.github.com/users/petems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petems/subscriptions","organizations_url":"https://api.github.com/users/petems/orgs","repos_url":"https://api.github.com/users/petems/repos","events_url":"https://api.github.com/users/petems/events{/privacy}","received_events_url":"https://api.github.com/users/petems/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petems/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/petems/puppet","forks_url":"https://api.github.com/repos/petems/puppet/forks","keys_url":"https://api.github.com/repos/petems/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petems/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petems/puppet/teams","hooks_url":"https://api.github.com/repos/petems/puppet/hooks","issue_events_url":"https://api.github.com/repos/petems/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/petems/puppet/events","assignees_url":"https://api.github.com/repos/petems/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/petems/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/petems/puppet/tags","blobs_url":"https://api.github.com/repos/petems/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petems/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petems/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/petems/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petems/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/petems/puppet/languages","stargazers_url":"https://api.github.com/repos/petems/puppet/stargazers","contributors_url":"https://api.github.com/repos/petems/puppet/contributors","subscribers_url":"https://api.github.com/repos/petems/puppet/subscribers","subscription_url":"https://api.github.com/repos/petems/puppet/subscription","commits_url":"https://api.github.com/repos/petems/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/petems/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/petems/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/petems/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/petems/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/petems/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petems/puppet/merges","archive_url":"https://api.github.com/repos/petems/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petems/puppet/downloads","issues_url":"https://api.github.com/repos/petems/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/petems/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/petems/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/petems/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petems/puppet/labels{/name}","releases_url":"https://api.github.com/repos/petems/puppet/releases{/id}","created_at":"2014-01-21T14:10:44Z","updated_at":"2014-06-02T15:40:07Z","pushed_at":"2015-12-11T12:40:48Z","git_url":"git://github.com/petems/puppet.git","ssh_url":"git@github.com:petems/puppet.git","clone_url":"https://github.com/petems/puppet.git","svn_url":"https://github.com/petems/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":49244,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"d6b75bbd6016b36651c5013b2e7b692851f9b5bf","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-12-11T13:00:41Z","pushed_at":"2015-12-11T13:29:06Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppetlabs.com/puppet/what-is-puppet","size":77102,"stargazers_count":3689,"watchers_count":3689,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1538,"mirror_url":null,"open_issues_count":37,"forks":1538,"open_issues":37,"watchers":3689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4495"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/4495"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/4495"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/4495/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4495/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4495/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/835ca434f930dc98c33af548d6d1b861fd3a875b"}}}}