{"push_id":694515869,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"3de3a72dd8c7cba6cff715ad7a40d8acb7b40007","before":"893c7a26c196ecbe619233b8816ca87044e5779e","commits":[{"sha":"3de3a72dd8c7cba6cff715ad7a40d8acb7b40007","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Add a \"Subscribers\" object policy\n\nSummary:\nRef T5681. Getting this to work correctly is a bit tricky, mostly because of the policy checks we do prior to applying an edit.\n\nI think I came up with a mostly-reasonable approach, although it's a little bit gross. It uses `spl_object_hash()` so it shouldn't be able to do anything bad/dangerous (the hints are strictly bound to the hinted object, which is a clone that we destroy moments later).\n\nTest Plan:\n  - Added + ran a unit test.\n  - Created a task with a \"Subscribers\" policy with me as a subscriber (without the hint stuff, this isn't possible: since you aren't a subscriber *yet*, you get a \"you won't be able to see it\" error).\n  - Unsubscribed from a task with a \"Subscribers\" policy, was immediately unable to see it.\n  - Created a task with a \"subscribers\" policy and a project subscriber with/without me as a member (error / success, respectively).\n\nReviewers: btrahan\n\nReviewed By: btrahan\n\nSubscribers: epriestley\n\nManiphest Tasks: T5681\n\nDifferential Revision: https://secure.phabricator.com/D13259","distinct":true,"url":"https://api.github.com/repos/phacility/phabricator/commits/3de3a72dd8c7cba6cff715ad7a40d8acb7b40007"}]}