{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/8353","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/8353/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/8353/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/8353/events","html_url":"https://github.com/xbmc/xbmc/pull/8353","id":115327832,"number":8353,"title":"[settings] use positive values for setting control ids","user":{"login":"mkortstiege","id":475281,"avatar_url":"https://avatars.githubusercontent.com/u/475281?v=3","gravatar_id":"","url":"https://api.github.com/users/mkortstiege","html_url":"https://github.com/mkortstiege","followers_url":"https://api.github.com/users/mkortstiege/followers","following_url":"https://api.github.com/users/mkortstiege/following{/other_user}","gists_url":"https://api.github.com/users/mkortstiege/gists{/gist_id}","starred_url":"https://api.github.com/users/mkortstiege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkortstiege/subscriptions","organizations_url":"https://api.github.com/users/mkortstiege/orgs","repos_url":"https://api.github.com/users/mkortstiege/repos","events_url":"https://api.github.com/users/mkortstiege/events{/privacy}","received_events_url":"https://api.github.com/users/mkortstiege/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Cleanup","name":"Cleanup","color":"0b02e1"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Guilib","name":"Guilib","color":"009800"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-05T16:58:18Z","updated_at":"2015-11-05T19:00:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/8353","html_url":"https://github.com/xbmc/xbmc/pull/8353","diff_url":"https://github.com/xbmc/xbmc/pull/8353.diff","patch_url":"https://github.com/xbmc/xbmc/pull/8353.patch"},"body":"This changes the internal control ids to positive values and so enables skins to retrieve the auto-filled labels -- via Control.GetLabel(ID) -- from the category and settings fields.\r\n\r\nRequested by @HitcherUK. @Montellese, @ronie, @phil65 for review please."},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/154153677","html_url":"https://github.com/xbmc/xbmc/pull/8353#issuecomment-154153677","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/8353","id":154153677,"user":{"login":"HitcherUK","id":133808,"avatar_url":"https://avatars.githubusercontent.com/u/133808?v=3","gravatar_id":"","url":"https://api.github.com/users/HitcherUK","html_url":"https://github.com/HitcherUK","followers_url":"https://api.github.com/users/HitcherUK/followers","following_url":"https://api.github.com/users/HitcherUK/following{/other_user}","gists_url":"https://api.github.com/users/HitcherUK/gists{/gist_id}","starred_url":"https://api.github.com/users/HitcherUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HitcherUK/subscriptions","organizations_url":"https://api.github.com/users/HitcherUK/orgs","repos_url":"https://api.github.com/users/HitcherUK/repos","events_url":"https://api.github.com/users/HitcherUK/events{/privacy}","received_events_url":"https://api.github.com/users/HitcherUK/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T19:00:18Z","updated_at":"2015-11-05T19:00:18Z","body":"I recently made Copacetic's context menu appear as though it was using a different fonts for focused and unfocused buttons through the use of a second grouplist filled with labels + visible conditions based on `Control.GetLabel(1001)`, `Control.GetLabel(1002)`, etc.\r\n\r\nhttps://raw.githubusercontent.com/HitcherUK/skin.copacetic/master/16x9/DialogContextMenu.xml\r\n\r\n![screenshot007](https://cloud.githubusercontent.com/assets/133808/10978316/28bc8f6e-83ee-11e5-83d8-acd0caccea6a.png)\r\n\r\nI then remembered this thread on the forum where someone wanted to do something similar with SettingsCategory - http://forum.kodi.tv/showthread.php?tid=244456&pid=2138071#pid2138071\r\n\r\nOnly when I tried it wouldn't work because `Control.GetLabel(-100)` doesn't work because the values are negative. This PR addresses the issue."}}