{"action":"created","issue":{"url":"https://api.github.com/repos/modeset/teaspoon/issues/277","labels_url":"https://api.github.com/repos/modeset/teaspoon/issues/277/labels{/name}","comments_url":"https://api.github.com/repos/modeset/teaspoon/issues/277/comments","events_url":"https://api.github.com/repos/modeset/teaspoon/issues/277/events","html_url":"https://github.com/modeset/teaspoon/pull/277","id":47546926,"number":277,"title":"Switching instrument_file? to be in Instrumentation class","user":{"login":"golmansax","id":5068929,"avatar_url":"https://avatars.githubusercontent.com/u/5068929?v=3","gravatar_id":"","url":"https://api.github.com/users/golmansax","html_url":"https://github.com/golmansax","followers_url":"https://api.github.com/users/golmansax/followers","following_url":"https://api.github.com/users/golmansax/following{/other_user}","gists_url":"https://api.github.com/users/golmansax/gists{/gist_id}","starred_url":"https://api.github.com/users/golmansax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golmansax/subscriptions","organizations_url":"https://api.github.com/users/golmansax/orgs","repos_url":"https://api.github.com/users/golmansax/repos","events_url":"https://api.github.com/users/golmansax/events{/privacy}","received_events_url":"https://api.github.com/users/golmansax/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2014-11-02T20:02:07Z","updated_at":"2015-02-23T16:54:47Z","closed_at":"2015-02-22T20:46:38Z","pull_request":{"url":"https://api.github.com/repos/modeset/teaspoon/pulls/277","html_url":"https://github.com/modeset/teaspoon/pull/277","diff_url":"https://github.com/modeset/teaspoon/pull/277.diff","patch_url":"https://github.com/modeset/teaspoon/pull/277.patch"},"body":"This was done to solve the RequireJS issue (https://github.com/modeset/teaspoon/pull/240), would like to hear your thoughts about this.  Some things:\r\n\r\n* The reason why this change works with RequireJS is because the decision to instrument is now made in the Sprockets hook, and all RequireJS requests go through Sprockets.\r\n* I wasn't sure how to grab the current config so I grabbed the default config with `Teaspoon.configuration.suite_configs['default'][:instance]`.  I can help write specs once this part is figured out.\r\n* I was thinking about completely forgoing the addition of `instrument=1`, but wasn't sure which way to go.  Either way works with RequireJS, as you can add a `instrument=1` to the end of every RequireJS request through the `urlArgs` config."},"comment":{"url":"https://api.github.com/repos/modeset/teaspoon/issues/comments/75582134","html_url":"https://github.com/modeset/teaspoon/pull/277#issuecomment-75582134","issue_url":"https://api.github.com/repos/modeset/teaspoon/issues/277","id":75582134,"user":{"login":"davestevens","id":287677,"avatar_url":"https://avatars.githubusercontent.com/u/287677?v=3","gravatar_id":"","url":"https://api.github.com/users/davestevens","html_url":"https://github.com/davestevens","followers_url":"https://api.github.com/users/davestevens/followers","following_url":"https://api.github.com/users/davestevens/following{/other_user}","gists_url":"https://api.github.com/users/davestevens/gists{/gist_id}","starred_url":"https://api.github.com/users/davestevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davestevens/subscriptions","organizations_url":"https://api.github.com/users/davestevens/orgs","repos_url":"https://api.github.com/users/davestevens/repos","events_url":"https://api.github.com/users/davestevens/events{/privacy}","received_events_url":"https://api.github.com/users/davestevens/received_events","type":"User","site_admin":false},"created_at":"2015-02-23T16:54:47Z","updated_at":"2015-02-23T16:54:47Z","body":"I've just opened #315 that simply adds an option to RequireJS from within the boot view which adds `instrument=1` to all requests made through require."}}