{"action":"created","comment":{"url":"https://api.github.com/repos/basecamp/local_time/pulls/comments/23929461","id":23929461,"diff_hunk":"@@ -17,6 +17,11 @@ class LocalTimeHelperTest < TestCase\n   include ActionView::Helpers::DateHelper, ActionView::Helpers::TagHelper\n   include LocalTimeHelper\n \n+  def normalize(html)\n+    n = Nokogiri::HTML(html).xpath('//time').first","path":"test/helpers/local_time_helper_test.rb","position":5,"original_position":5,"commit_id":"d604f5f2e131376f0d8271a64c3522537af6652c","original_commit_id":"d604f5f2e131376f0d8271a64c3522537af6652c","user":{"login":"bloot","id":1937294,"avatar_url":"https://avatars.githubusercontent.com/u/1937294?v=3","gravatar_id":"","url":"https://api.github.com/users/bloot","html_url":"https://github.com/bloot","followers_url":"https://api.github.com/users/bloot/followers","following_url":"https://api.github.com/users/bloot/following{/other_user}","gists_url":"https://api.github.com/users/bloot/gists{/gist_id}","starred_url":"https://api.github.com/users/bloot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloot/subscriptions","organizations_url":"https://api.github.com/users/bloot/orgs","repos_url":"https://api.github.com/users/bloot/repos","events_url":"https://api.github.com/users/bloot/events{/privacy}","received_events_url":"https://api.github.com/users/bloot/received_events","type":"User","site_admin":false},"body":"I'm not a big fan of using `n` or `x` etc. in variable naming. It makes stuff kind of unclear, especially in manipulation like you are doing later on ( where you are using `n` again ). I would recommend using something like `document` here and then getting a little bit more descriptive in `#map`'s vars.","created_at":"2015-02-02T15:00:39Z","updated_at":"2015-02-02T15:00:39Z","html_url":"https://github.com/basecamp/local_time/pull/36#discussion_r23929461","pull_request_url":"https://api.github.com/repos/basecamp/local_time/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/basecamp/local_time/pulls/comments/23929461"},"html":{"href":"https://github.com/basecamp/local_time/pull/36#discussion_r23929461"},"pull_request":{"href":"https://api.github.com/repos/basecamp/local_time/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/basecamp/local_time/pulls/36","id":28080383,"html_url":"https://github.com/basecamp/local_time/pull/36","diff_url":"https://github.com/basecamp/local_time/pull/36.diff","patch_url":"https://github.com/basecamp/local_time/pull/36.patch","issue_url":"https://api.github.com/repos/basecamp/local_time/issues/36","number":36,"state":"open","locked":false,"title":"Show far future as date+year when using timeago","user":{"login":"e2","id":150197,"avatar_url":"https://avatars.githubusercontent.com/u/150197?v=3","gravatar_id":"","url":"https://api.github.com/users/e2","html_url":"https://github.com/e2","followers_url":"https://api.github.com/users/e2/followers","following_url":"https://api.github.com/users/e2/following{/other_user}","gists_url":"https://api.github.com/users/e2/gists{/gist_id}","starred_url":"https://api.github.com/users/e2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e2/subscriptions","organizations_url":"https://api.github.com/users/e2/orgs","repos_url":"https://api.github.com/users/e2/repos","events_url":"https://api.github.com/users/e2/events{/privacy}","received_events_url":"https://api.github.com/users/e2/received_events","type":"User","site_admin":false},"body":"- also fix tag tests by sorting attributes\n- fix Rack setup for `rake test` task","created_at":"2015-01-27T03:04:12Z","updated_at":"2015-02-02T15:00:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a5e1398eff55439728a948d4171bce30aa1de28","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/basecamp/local_time/pulls/36/commits","review_comments_url":"https://api.github.com/repos/basecamp/local_time/pulls/36/comments","review_comment_url":"https://api.github.com/repos/basecamp/local_time/pulls/comments/{number}","comments_url":"https://api.github.com/repos/basecamp/local_time/issues/36/comments","statuses_url":"https://api.github.com/repos/basecamp/local_time/statuses/d604f5f2e131376f0d8271a64c3522537af6652c","head":{"label":"e2:show_date_when_far_future","ref":"show_date_when_far_future","sha":"d604f5f2e131376f0d8271a64c3522537af6652c","user":{"login":"e2","id":150197,"avatar_url":"https://avatars.githubusercontent.com/u/150197?v=3","gravatar_id":"","url":"https://api.github.com/users/e2","html_url":"https://github.com/e2","followers_url":"https://api.github.com/users/e2/followers","following_url":"https://api.github.com/users/e2/following{/other_user}","gists_url":"https://api.github.com/users/e2/gists{/gist_id}","starred_url":"https://api.github.com/users/e2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e2/subscriptions","organizations_url":"https://api.github.com/users/e2/orgs","repos_url":"https://api.github.com/users/e2/repos","events_url":"https://api.github.com/users/e2/events{/privacy}","received_events_url":"https://api.github.com/users/e2/received_events","type":"User","site_admin":false},"repo":{"id":29894547,"name":"local_time","full_name":"e2/local_time","owner":{"login":"e2","id":150197,"avatar_url":"https://avatars.githubusercontent.com/u/150197?v=3","gravatar_id":"","url":"https://api.github.com/users/e2","html_url":"https://github.com/e2","followers_url":"https://api.github.com/users/e2/followers","following_url":"https://api.github.com/users/e2/following{/other_user}","gists_url":"https://api.github.com/users/e2/gists{/gist_id}","starred_url":"https://api.github.com/users/e2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e2/subscriptions","organizations_url":"https://api.github.com/users/e2/orgs","repos_url":"https://api.github.com/users/e2/repos","events_url":"https://api.github.com/users/e2/events{/privacy}","received_events_url":"https://api.github.com/users/e2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/e2/local_time","description":"Rails engine for cache-friendly, client-side local time","fork":true,"url":"https://api.github.com/repos/e2/local_time","forks_url":"https://api.github.com/repos/e2/local_time/forks","keys_url":"https://api.github.com/repos/e2/local_time/keys{/key_id}","collaborators_url":"https://api.github.com/repos/e2/local_time/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/e2/local_time/teams","hooks_url":"https://api.github.com/repos/e2/local_time/hooks","issue_events_url":"https://api.github.com/repos/e2/local_time/issues/events{/number}","events_url":"https://api.github.com/repos/e2/local_time/events","assignees_url":"https://api.github.com/repos/e2/local_time/assignees{/user}","branches_url":"https://api.github.com/repos/e2/local_time/branches{/branch}","tags_url":"https://api.github.com/repos/e2/local_time/tags","blobs_url":"https://api.github.com/repos/e2/local_time/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/e2/local_time/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/e2/local_time/git/refs{/sha}","trees_url":"https://api.github.com/repos/e2/local_time/git/trees{/sha}","statuses_url":"https://api.github.com/repos/e2/local_time/statuses/{sha}","languages_url":"https://api.github.com/repos/e2/local_time/languages","stargazers_url":"https://api.github.com/repos/e2/local_time/stargazers","contributors_url":"https://api.github.com/repos/e2/local_time/contributors","subscribers_url":"https://api.github.com/repos/e2/local_time/subscribers","subscription_url":"https://api.github.com/repos/e2/local_time/subscription","commits_url":"https://api.github.com/repos/e2/local_time/commits{/sha}","git_commits_url":"https://api.github.com/repos/e2/local_time/git/commits{/sha}","comments_url":"https://api.github.com/repos/e2/local_time/comments{/number}","issue_comment_url":"https://api.github.com/repos/e2/local_time/issues/comments/{number}","contents_url":"https://api.github.com/repos/e2/local_time/contents/{+path}","compare_url":"https://api.github.com/repos/e2/local_time/compare/{base}...{head}","merges_url":"https://api.github.com/repos/e2/local_time/merges","archive_url":"https://api.github.com/repos/e2/local_time/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/e2/local_time/downloads","issues_url":"https://api.github.com/repos/e2/local_time/issues{/number}","pulls_url":"https://api.github.com/repos/e2/local_time/pulls{/number}","milestones_url":"https://api.github.com/repos/e2/local_time/milestones{/number}","notifications_url":"https://api.github.com/repos/e2/local_time/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/e2/local_time/labels{/name}","releases_url":"https://api.github.com/repos/e2/local_time/releases{/id}","created_at":"2015-01-27T03:01:00Z","updated_at":"2015-01-27T03:01:01Z","pushed_at":"2015-01-27T03:01:30Z","git_url":"git://github.com/e2/local_time.git","ssh_url":"git@github.com:e2/local_time.git","clone_url":"https://github.com/e2/local_time.git","svn_url":"https://github.com/e2/local_time","homepage":"","size":174,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"basecamp:master","ref":"master","sha":"834519e44dd2b6ff1d38ea0d5d9569653ddce375","user":{"login":"basecamp","id":13131,"avatar_url":"https://avatars.githubusercontent.com/u/13131?v=3","gravatar_id":"","url":"https://api.github.com/users/basecamp","html_url":"https://github.com/basecamp","followers_url":"https://api.github.com/users/basecamp/followers","following_url":"https://api.github.com/users/basecamp/following{/other_user}","gists_url":"https://api.github.com/users/basecamp/gists{/gist_id}","starred_url":"https://api.github.com/users/basecamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basecamp/subscriptions","organizations_url":"https://api.github.com/users/basecamp/orgs","repos_url":"https://api.github.com/users/basecamp/repos","events_url":"https://api.github.com/users/basecamp/events{/privacy}","received_events_url":"https://api.github.com/users/basecamp/received_events","type":"Organization","site_admin":false},"repo":{"id":14475276,"name":"local_time","full_name":"basecamp/local_time","owner":{"login":"basecamp","id":13131,"avatar_url":"https://avatars.githubusercontent.com/u/13131?v=3","gravatar_id":"","url":"https://api.github.com/users/basecamp","html_url":"https://github.com/basecamp","followers_url":"https://api.github.com/users/basecamp/followers","following_url":"https://api.github.com/users/basecamp/following{/other_user}","gists_url":"https://api.github.com/users/basecamp/gists{/gist_id}","starred_url":"https://api.github.com/users/basecamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basecamp/subscriptions","organizations_url":"https://api.github.com/users/basecamp/orgs","repos_url":"https://api.github.com/users/basecamp/repos","events_url":"https://api.github.com/users/basecamp/events{/privacy}","received_events_url":"https://api.github.com/users/basecamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basecamp/local_time","description":"Rails engine for cache-friendly, client-side local time","fork":false,"url":"https://api.github.com/repos/basecamp/local_time","forks_url":"https://api.github.com/repos/basecamp/local_time/forks","keys_url":"https://api.github.com/repos/basecamp/local_time/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basecamp/local_time/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basecamp/local_time/teams","hooks_url":"https://api.github.com/repos/basecamp/local_time/hooks","issue_events_url":"https://api.github.com/repos/basecamp/local_time/issues/events{/number}","events_url":"https://api.github.com/repos/basecamp/local_time/events","assignees_url":"https://api.github.com/repos/basecamp/local_time/assignees{/user}","branches_url":"https://api.github.com/repos/basecamp/local_time/branches{/branch}","tags_url":"https://api.github.com/repos/basecamp/local_time/tags","blobs_url":"https://api.github.com/repos/basecamp/local_time/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basecamp/local_time/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basecamp/local_time/git/refs{/sha}","trees_url":"https://api.github.com/repos/basecamp/local_time/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basecamp/local_time/statuses/{sha}","languages_url":"https://api.github.com/repos/basecamp/local_time/languages","stargazers_url":"https://api.github.com/repos/basecamp/local_time/stargazers","contributors_url":"https://api.github.com/repos/basecamp/local_time/contributors","subscribers_url":"https://api.github.com/repos/basecamp/local_time/subscribers","subscription_url":"https://api.github.com/repos/basecamp/local_time/subscription","commits_url":"https://api.github.com/repos/basecamp/local_time/commits{/sha}","git_commits_url":"https://api.github.com/repos/basecamp/local_time/git/commits{/sha}","comments_url":"https://api.github.com/repos/basecamp/local_time/comments{/number}","issue_comment_url":"https://api.github.com/repos/basecamp/local_time/issues/comments/{number}","contents_url":"https://api.github.com/repos/basecamp/local_time/contents/{+path}","compare_url":"https://api.github.com/repos/basecamp/local_time/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basecamp/local_time/merges","archive_url":"https://api.github.com/repos/basecamp/local_time/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basecamp/local_time/downloads","issues_url":"https://api.github.com/repos/basecamp/local_time/issues{/number}","pulls_url":"https://api.github.com/repos/basecamp/local_time/pulls{/number}","milestones_url":"https://api.github.com/repos/basecamp/local_time/milestones{/number}","notifications_url":"https://api.github.com/repos/basecamp/local_time/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basecamp/local_time/labels{/name}","releases_url":"https://api.github.com/repos/basecamp/local_time/releases{/id}","created_at":"2013-11-17T21:24:07Z","updated_at":"2015-01-30T05:32:29Z","pushed_at":"2015-01-02T23:18:41Z","git_url":"git://github.com/basecamp/local_time.git","ssh_url":"git@github.com:basecamp/local_time.git","clone_url":"https://github.com/basecamp/local_time.git","svn_url":"https://github.com/basecamp/local_time","homepage":"","size":434,"stargazers_count":816,"watchers_count":816,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":1,"forks":41,"open_issues":1,"watchers":816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/basecamp/local_time/pulls/36"},"html":{"href":"https://github.com/basecamp/local_time/pull/36"},"issue":{"href":"https://api.github.com/repos/basecamp/local_time/issues/36"},"comments":{"href":"https://api.github.com/repos/basecamp/local_time/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/basecamp/local_time/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/basecamp/local_time/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/basecamp/local_time/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/basecamp/local_time/statuses/d604f5f2e131376f0d8271a64c3522537af6652c"}}}}