{"action":"created","comment":{"url":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/comments/34056510","id":34056510,"diff_hunk":"@@ -96,6 +98,12 @@ typedef void(^DPLRouteCompletionBlock)(BOOL handled, NSError *error);\n  */\n - (BOOL)handleUserActivity:(NSUserActivity *)userActivity withCompletion:(DPLRouteCompletionBlock)completionHandler;\n \n+/**\n+ * Attempts to find a `UIViewController' for incoming URL. The URL must have been registered with a `DPLRouteHandler'.\n+ * @param url The incoming URL from `application:openURL:sourceApplication:annotation:'\n+ * @return A view controller if successful, already configured, otherwise Nil.\n+ */\n+- (UIViewController<DPLTargetViewController> *)viewControllerForUrl:(NSURL *)url ;","path":"DeepLinkKit/Router/DPLDeepLinkRouter.h","position":18,"original_position":18,"commit_id":"e6f8fab757cf251bee3ec9eea958fb1f93e3248f","original_commit_id":"e6f8fab757cf251bee3ec9eea958fb1f93e3248f","user":{"login":"alcarvalho","id":1180701,"avatar_url":"https://avatars.githubusercontent.com/u/1180701?v=3","gravatar_id":"","url":"https://api.github.com/users/alcarvalho","html_url":"https://github.com/alcarvalho","followers_url":"https://api.github.com/users/alcarvalho/followers","following_url":"https://api.github.com/users/alcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/alcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/alcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcarvalho/subscriptions","organizations_url":"https://api.github.com/users/alcarvalho/orgs","repos_url":"https://api.github.com/users/alcarvalho/repos","events_url":"https://api.github.com/users/alcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/alcarvalho/received_events","type":"User","site_admin":false},"body":"Ok! Will do that for every URL in the code.","created_at":"2015-07-07T15:57:24Z","updated_at":"2015-07-07T15:57:24Z","html_url":"https://github.com/usebutton/DeepLinkKit/pull/61#discussion_r34056510","pull_request_url":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/comments/34056510"},"html":{"href":"https://github.com/usebutton/DeepLinkKit/pull/61#discussion_r34056510"},"pull_request":{"href":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/61","id":39376711,"html_url":"https://github.com/usebutton/DeepLinkKit/pull/61","diff_url":"https://github.com/usebutton/DeepLinkKit/pull/61.diff","patch_url":"https://github.com/usebutton/DeepLinkKit/pull/61.patch","issue_url":"https://api.github.com/repos/usebutton/DeepLinkKit/issues/61","number":61,"state":"open","locked":false,"title":"WIP: internal router","user":{"login":"alcarvalho","id":1180701,"avatar_url":"https://avatars.githubusercontent.com/u/1180701?v=3","gravatar_id":"","url":"https://api.github.com/users/alcarvalho","html_url":"https://github.com/alcarvalho","followers_url":"https://api.github.com/users/alcarvalho/followers","following_url":"https://api.github.com/users/alcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/alcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/alcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcarvalho/subscriptions","organizations_url":"https://api.github.com/users/alcarvalho/orgs","repos_url":"https://api.github.com/users/alcarvalho/repos","events_url":"https://api.github.com/users/alcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/alcarvalho/received_events","type":"User","site_admin":false},"body":"This is the very first take into trying to extract an internal router as said in #60 \r\n\r\nI feel the code is a bit cluttered, I don't know. I specially don't like to pass pointers of pointers to anything other then `NSError`.\r\n\r\nAny suggestions on how to improve this?","created_at":"2015-07-07T14:35:05Z","updated_at":"2015-07-07T15:57:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49b43dbf8ac5ea0282373ec4746414714cfa8ba3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/61/commits","review_comments_url":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/61/comments","review_comment_url":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/usebutton/DeepLinkKit/issues/61/comments","statuses_url":"https://api.github.com/repos/usebutton/DeepLinkKit/statuses/e6f8fab757cf251bee3ec9eea958fb1f93e3248f","head":{"label":"alcarvalho:master","ref":"master","sha":"e6f8fab757cf251bee3ec9eea958fb1f93e3248f","user":{"login":"alcarvalho","id":1180701,"avatar_url":"https://avatars.githubusercontent.com/u/1180701?v=3","gravatar_id":"","url":"https://api.github.com/users/alcarvalho","html_url":"https://github.com/alcarvalho","followers_url":"https://api.github.com/users/alcarvalho/followers","following_url":"https://api.github.com/users/alcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/alcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/alcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcarvalho/subscriptions","organizations_url":"https://api.github.com/users/alcarvalho/orgs","repos_url":"https://api.github.com/users/alcarvalho/repos","events_url":"https://api.github.com/users/alcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/alcarvalho/received_events","type":"User","site_admin":false},"repo":{"id":38376211,"name":"DeepLinkKit","full_name":"alcarvalho/DeepLinkKit","owner":{"login":"alcarvalho","id":1180701,"avatar_url":"https://avatars.githubusercontent.com/u/1180701?v=3","gravatar_id":"","url":"https://api.github.com/users/alcarvalho","html_url":"https://github.com/alcarvalho","followers_url":"https://api.github.com/users/alcarvalho/followers","following_url":"https://api.github.com/users/alcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/alcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/alcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alcarvalho/subscriptions","organizations_url":"https://api.github.com/users/alcarvalho/orgs","repos_url":"https://api.github.com/users/alcarvalho/repos","events_url":"https://api.github.com/users/alcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/alcarvalho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alcarvalho/DeepLinkKit","description":"A splendid route-matching, block-based way to handle your deep links.","fork":true,"url":"https://api.github.com/repos/alcarvalho/DeepLinkKit","forks_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/forks","keys_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/teams","hooks_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/hooks","issue_events_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/issues/events{/number}","events_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/events","assignees_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/assignees{/user}","branches_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/branches{/branch}","tags_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/tags","blobs_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/statuses/{sha}","languages_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/languages","stargazers_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/stargazers","contributors_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/contributors","subscribers_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/subscribers","subscription_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/subscription","commits_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/contents/{+path}","compare_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/merges","archive_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/downloads","issues_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/issues{/number}","pulls_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/pulls{/number}","milestones_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/milestones{/number}","notifications_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/labels{/name}","releases_url":"https://api.github.com/repos/alcarvalho/DeepLinkKit/releases{/id}","created_at":"2015-07-01T14:38:31Z","updated_at":"2015-07-01T14:38:31Z","pushed_at":"2015-07-07T14:56:56Z","git_url":"git://github.com/alcarvalho/DeepLinkKit.git","ssh_url":"git@github.com:alcarvalho/DeepLinkKit.git","clone_url":"https://github.com/alcarvalho/DeepLinkKit.git","svn_url":"https://github.com/alcarvalho/DeepLinkKit","homepage":"http://www.usebutton.com/sdk/deep-links","size":357,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"usebutton:master","ref":"master","sha":"27353a24dad28dc3899cc10d805a9a50701593eb","user":{"login":"usebutton","id":7770987,"avatar_url":"https://avatars.githubusercontent.com/u/7770987?v=3","gravatar_id":"","url":"https://api.github.com/users/usebutton","html_url":"https://github.com/usebutton","followers_url":"https://api.github.com/users/usebutton/followers","following_url":"https://api.github.com/users/usebutton/following{/other_user}","gists_url":"https://api.github.com/users/usebutton/gists{/gist_id}","starred_url":"https://api.github.com/users/usebutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usebutton/subscriptions","organizations_url":"https://api.github.com/users/usebutton/orgs","repos_url":"https://api.github.com/users/usebutton/repos","events_url":"https://api.github.com/users/usebutton/events{/privacy}","received_events_url":"https://api.github.com/users/usebutton/received_events","type":"Organization","site_admin":false},"repo":{"id":27736734,"name":"DeepLinkKit","full_name":"usebutton/DeepLinkKit","owner":{"login":"usebutton","id":7770987,"avatar_url":"https://avatars.githubusercontent.com/u/7770987?v=3","gravatar_id":"","url":"https://api.github.com/users/usebutton","html_url":"https://github.com/usebutton","followers_url":"https://api.github.com/users/usebutton/followers","following_url":"https://api.github.com/users/usebutton/following{/other_user}","gists_url":"https://api.github.com/users/usebutton/gists{/gist_id}","starred_url":"https://api.github.com/users/usebutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usebutton/subscriptions","organizations_url":"https://api.github.com/users/usebutton/orgs","repos_url":"https://api.github.com/users/usebutton/repos","events_url":"https://api.github.com/users/usebutton/events{/privacy}","received_events_url":"https://api.github.com/users/usebutton/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/usebutton/DeepLinkKit","description":"A splendid route-matching, block-based way to handle your deep links.","fork":false,"url":"https://api.github.com/repos/usebutton/DeepLinkKit","forks_url":"https://api.github.com/repos/usebutton/DeepLinkKit/forks","keys_url":"https://api.github.com/repos/usebutton/DeepLinkKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usebutton/DeepLinkKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usebutton/DeepLinkKit/teams","hooks_url":"https://api.github.com/repos/usebutton/DeepLinkKit/hooks","issue_events_url":"https://api.github.com/repos/usebutton/DeepLinkKit/issues/events{/number}","events_url":"https://api.github.com/repos/usebutton/DeepLinkKit/events","assignees_url":"https://api.github.com/repos/usebutton/DeepLinkKit/assignees{/user}","branches_url":"https://api.github.com/repos/usebutton/DeepLinkKit/branches{/branch}","tags_url":"https://api.github.com/repos/usebutton/DeepLinkKit/tags","blobs_url":"https://api.github.com/repos/usebutton/DeepLinkKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usebutton/DeepLinkKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usebutton/DeepLinkKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/usebutton/DeepLinkKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usebutton/DeepLinkKit/statuses/{sha}","languages_url":"https://api.github.com/repos/usebutton/DeepLinkKit/languages","stargazers_url":"https://api.github.com/repos/usebutton/DeepLinkKit/stargazers","contributors_url":"https://api.github.com/repos/usebutton/DeepLinkKit/contributors","subscribers_url":"https://api.github.com/repos/usebutton/DeepLinkKit/subscribers","subscription_url":"https://api.github.com/repos/usebutton/DeepLinkKit/subscription","commits_url":"https://api.github.com/repos/usebutton/DeepLinkKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/usebutton/DeepLinkKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/usebutton/DeepLinkKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/usebutton/DeepLinkKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/usebutton/DeepLinkKit/contents/{+path}","compare_url":"https://api.github.com/repos/usebutton/DeepLinkKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usebutton/DeepLinkKit/merges","archive_url":"https://api.github.com/repos/usebutton/DeepLinkKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usebutton/DeepLinkKit/downloads","issues_url":"https://api.github.com/repos/usebutton/DeepLinkKit/issues{/number}","pulls_url":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls{/number}","milestones_url":"https://api.github.com/repos/usebutton/DeepLinkKit/milestones{/number}","notifications_url":"https://api.github.com/repos/usebutton/DeepLinkKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usebutton/DeepLinkKit/labels{/name}","releases_url":"https://api.github.com/repos/usebutton/DeepLinkKit/releases{/id}","created_at":"2014-12-08T21:44:58Z","updated_at":"2015-07-06T07:28:32Z","pushed_at":"2015-07-07T14:35:05Z","git_url":"git://github.com/usebutton/DeepLinkKit.git","ssh_url":"git@github.com:usebutton/DeepLinkKit.git","clone_url":"https://github.com/usebutton/DeepLinkKit.git","svn_url":"https://github.com/usebutton/DeepLinkKit","homepage":"http://www.usebutton.com/sdk/deep-links","size":959,"stargazers_count":1777,"watchers_count":1777,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":15,"forks":84,"open_issues":15,"watchers":1777,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/61"},"html":{"href":"https://github.com/usebutton/DeepLinkKit/pull/61"},"issue":{"href":"https://api.github.com/repos/usebutton/DeepLinkKit/issues/61"},"comments":{"href":"https://api.github.com/repos/usebutton/DeepLinkKit/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/usebutton/DeepLinkKit/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/usebutton/DeepLinkKit/statuses/e6f8fab757cf251bee3ec9eea958fb1f93e3248f"}}}}