{"action":"created","issue":{"url":"https://api.github.com/repos/php-http/adapter/issues/38","labels_url":"https://api.github.com/repos/php-http/adapter/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/php-http/adapter/issues/38/comments","events_url":"https://api.github.com/repos/php-http/adapter/issues/38/events","html_url":"https://github.com/php-http/adapter/issues/38","id":100191220,"number":38,"title":"Terminology","user":{"login":"sagikazarmark","id":1226384,"avatar_url":"https://avatars.githubusercontent.com/u/1226384?v=3","gravatar_id":"","url":"https://api.github.com/users/sagikazarmark","html_url":"https://github.com/sagikazarmark","followers_url":"https://api.github.com/users/sagikazarmark/followers","following_url":"https://api.github.com/users/sagikazarmark/following{/other_user}","gists_url":"https://api.github.com/users/sagikazarmark/gists{/gist_id}","starred_url":"https://api.github.com/users/sagikazarmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagikazarmark/subscriptions","organizations_url":"https://api.github.com/users/sagikazarmark/orgs","repos_url":"https://api.github.com/users/sagikazarmark/repos","events_url":"https://api.github.com/users/sagikazarmark/events{/privacy}","received_events_url":"https://api.github.com/users/sagikazarmark/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-08-10T23:33:11Z","updated_at":"2015-08-13T10:12:01Z","closed_at":null,"body":"I am thinking about the following:\r\n\r\nWe could make adapter/client a set of interfaces which are recommended for client implementations. This way if an HTTP Client PSR is created once, we already have something.\r\n\r\nThe adapter naming is useful in the context of creating adapters wrapping clients. But for the long term, clients themselves should have a common interface which makes the adapter naming a bit vague.\r\n\r\nI remember @jeromegamez mentioned something similar.\r\n\r\nWhat do you think?"},"comment":{"url":"https://api.github.com/repos/php-http/adapter/issues/comments/130602406","html_url":"https://github.com/php-http/adapter/issues/38#issuecomment-130602406","issue_url":"https://api.github.com/repos/php-http/adapter/issues/38","id":130602406,"user":{"login":"sagikazarmark","id":1226384,"avatar_url":"https://avatars.githubusercontent.com/u/1226384?v=3","gravatar_id":"","url":"https://api.github.com/users/sagikazarmark","html_url":"https://github.com/sagikazarmark","followers_url":"https://api.github.com/users/sagikazarmark/followers","following_url":"https://api.github.com/users/sagikazarmark/following{/other_user}","gists_url":"https://api.github.com/users/sagikazarmark/gists{/gist_id}","starred_url":"https://api.github.com/users/sagikazarmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagikazarmark/subscriptions","organizations_url":"https://api.github.com/users/sagikazarmark/orgs","repos_url":"https://api.github.com/users/sagikazarmark/repos","events_url":"https://api.github.com/users/sagikazarmark/events{/privacy}","received_events_url":"https://api.github.com/users/sagikazarmark/received_events","type":"User","site_admin":false},"created_at":"2015-08-13T10:12:01Z","updated_at":"2015-08-13T10:12:01Z","body":"Actually I would prefer if Client would extend HttpClient and\nPsrHttpClient. Seems more logical to me.\n\nMy plan is to merge the client and the adapter package. But we should\npreserve the adapter package's history. The client one is pretty new\nwithout relevant history.\n2015. aug. 13. 11:29 ezt írta (\"Hannes Van De Vreken\" <\nnotifications@github.com>):\n\n> Agreed.\n>\n> Like what? Likes this:\n>\n> namespace \\Http\\Client;\n>\n> interface PsrHttpClient\n> {\n> ...\n> }\n>\n> namespace \\Http\\Client;\n>\n> interface Client\n> {\n> ...\n> }\n>\n> namespace \\Http\\Client;interface HttpClient extends PsrHttpClient, HttpClient{}\n>\n> I would actually work on\n>\n>    1. Finalising interfaces and naming\n>    2. Tagging releases\n>    3. Adoption by other packages/sdks\n>    4. More adapters\n>\n> In that order. Because waiting on the FIG to for an approved version... It\n> could be useful to make something that is already greatly adopted so they\n> will consider using great portions (if not all) of this HTTP adapter\n> interface for their interface.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/php-http/adapter/issues/38#issuecomment-130590604>.\n>\n"}}