{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/comments/40250297","id":40250297,"diff_hunk":"@@ -46,9 +77,11 @@ type Allocator struct {\n // NewAllocator returns an instance of libnetwork ipam\n func NewAllocator(ds datastore.DataStore) (*Allocator, error) {\n \ta := &Allocator{}\n-\ta.subnets = make(map[subnetKey]*SubnetInfo)\n+\ta.subnets = make(map[subnetKey]*PoolData)\n \ta.addresses = make(map[subnetKey]*bitseq.Handle)\n-\ta.internalHostSize = defaultInternalHostSize\n+\ta.predefined = make(map[string][]*net.IPNet, 2)\n+\ta.predefined[localAddressSpace] = localPredefinedPools\n+\ta.predefined[globalAddressSpace] = globalPredefinedPools\n \ta.store = ds\n \ta.App = \"ipam\"\n \ta.ID = dsConfigKey","path":"ipam/allocator.go","position":89,"original_position":89,"commit_id":"beb6b6eb6de5456d0f7700eb10236bacc94d6f69","original_commit_id":"beb6b6eb6de5456d0f7700eb10236bacc94d6f69","user":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"body":"Do we really need this ?\r\nThe address space is already part of the individual configuration object's key when inserted in the DS.\r\nBecause of that the subnetKey are not colliding, this allows to keep the config for all address spaces in single level map `subnets map[subnetKey]*PoolData`.\r\n\r\nAlso, `ID` belongs to `Allocator`. I am not going to have an allocator per address space.\r\n","created_at":"2015-09-23T20:02:41Z","updated_at":"2015-09-23T20:02:41Z","html_url":"https://github.com/docker/libnetwork/pull/525#discussion_r40250297","pull_request_url":"https://api.github.com/repos/docker/libnetwork/pulls/525","_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments/40250297"},"html":{"href":"https://github.com/docker/libnetwork/pull/525#discussion_r40250297"},"pull_request":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/525"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/525","id":45010623,"html_url":"https://github.com/docker/libnetwork/pull/525","diff_url":"https://github.com/docker/libnetwork/pull/525.diff","patch_url":"https://github.com/docker/libnetwork/pull/525.patch","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/525","number":525,"state":"open","locked":false,"title":"IPAM driver","user":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"body":"This is work in progress for #489 \r\n\r\n- ipmapi contract\r\n- ipam remote driver and registration\r\n- changes to default ipam to comply with new contract.","created_at":"2015-09-15T05:36:31Z","updated_at":"2015-09-23T20:02:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf242c0acb105747e66ed06e42e54cc78e3e0950","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libnetwork/pulls/525/commits","review_comments_url":"https://api.github.com/repos/docker/libnetwork/pulls/525/comments","review_comment_url":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/525/comments","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/beb6b6eb6de5456d0f7700eb10236bacc94d6f69","head":{"label":"aboch:am","ref":"am","sha":"beb6b6eb6de5456d0f7700eb10236bacc94d6f69","user":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"repo":{"id":34007834,"name":"libnetwork_new","full_name":"aboch/libnetwork_new","owner":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aboch/libnetwork_new","description":"networking for containers","fork":true,"url":"https://api.github.com/repos/aboch/libnetwork_new","forks_url":"https://api.github.com/repos/aboch/libnetwork_new/forks","keys_url":"https://api.github.com/repos/aboch/libnetwork_new/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aboch/libnetwork_new/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aboch/libnetwork_new/teams","hooks_url":"https://api.github.com/repos/aboch/libnetwork_new/hooks","issue_events_url":"https://api.github.com/repos/aboch/libnetwork_new/issues/events{/number}","events_url":"https://api.github.com/repos/aboch/libnetwork_new/events","assignees_url":"https://api.github.com/repos/aboch/libnetwork_new/assignees{/user}","branches_url":"https://api.github.com/repos/aboch/libnetwork_new/branches{/branch}","tags_url":"https://api.github.com/repos/aboch/libnetwork_new/tags","blobs_url":"https://api.github.com/repos/aboch/libnetwork_new/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aboch/libnetwork_new/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aboch/libnetwork_new/git/refs{/sha}","trees_url":"https://api.github.com/repos/aboch/libnetwork_new/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aboch/libnetwork_new/statuses/{sha}","languages_url":"https://api.github.com/repos/aboch/libnetwork_new/languages","stargazers_url":"https://api.github.com/repos/aboch/libnetwork_new/stargazers","contributors_url":"https://api.github.com/repos/aboch/libnetwork_new/contributors","subscribers_url":"https://api.github.com/repos/aboch/libnetwork_new/subscribers","subscription_url":"https://api.github.com/repos/aboch/libnetwork_new/subscription","commits_url":"https://api.github.com/repos/aboch/libnetwork_new/commits{/sha}","git_commits_url":"https://api.github.com/repos/aboch/libnetwork_new/git/commits{/sha}","comments_url":"https://api.github.com/repos/aboch/libnetwork_new/comments{/number}","issue_comment_url":"https://api.github.com/repos/aboch/libnetwork_new/issues/comments{/number}","contents_url":"https://api.github.com/repos/aboch/libnetwork_new/contents/{+path}","compare_url":"https://api.github.com/repos/aboch/libnetwork_new/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aboch/libnetwork_new/merges","archive_url":"https://api.github.com/repos/aboch/libnetwork_new/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aboch/libnetwork_new/downloads","issues_url":"https://api.github.com/repos/aboch/libnetwork_new/issues{/number}","pulls_url":"https://api.github.com/repos/aboch/libnetwork_new/pulls{/number}","milestones_url":"https://api.github.com/repos/aboch/libnetwork_new/milestones{/number}","notifications_url":"https://api.github.com/repos/aboch/libnetwork_new/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aboch/libnetwork_new/labels{/name}","releases_url":"https://api.github.com/repos/aboch/libnetwork_new/releases{/id}","created_at":"2015-04-15T17:16:09Z","updated_at":"2015-05-03T07:22:06Z","pushed_at":"2015-09-23T02:31:47Z","git_url":"git://github.com/aboch/libnetwork_new.git","ssh_url":"git@github.com:aboch/libnetwork_new.git","clone_url":"https://github.com/aboch/libnetwork_new.git","svn_url":"https://github.com/aboch/libnetwork_new","homepage":"","size":6123,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"4b7359ccf21bf6ec229fb85e2ac1b2edd7a392b5","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":31046054,"name":"libnetwork","full_name":"docker/libnetwork","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libnetwork","description":"networking for containers","fork":false,"url":"https://api.github.com/repos/docker/libnetwork","forks_url":"https://api.github.com/repos/docker/libnetwork/forks","keys_url":"https://api.github.com/repos/docker/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libnetwork/teams","hooks_url":"https://api.github.com/repos/docker/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/docker/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libnetwork/events","assignees_url":"https://api.github.com/repos/docker/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libnetwork/tags","blobs_url":"https://api.github.com/repos/docker/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libnetwork/languages","stargazers_url":"https://api.github.com/repos/docker/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/docker/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/docker/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/docker/libnetwork/subscription","commits_url":"https://api.github.com/repos/docker/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libnetwork/merges","archive_url":"https://api.github.com/repos/docker/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libnetwork/downloads","issues_url":"https://api.github.com/repos/docker/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/docker/libnetwork/releases{/id}","created_at":"2015-02-20T01:20:15Z","updated_at":"2015-09-21T12:32:47Z","pushed_at":"2015-09-23T02:31:47Z","git_url":"git://github.com/docker/libnetwork.git","ssh_url":"git@github.com:docker/libnetwork.git","clone_url":"https://github.com/docker/libnetwork.git","svn_url":"https://github.com/docker/libnetwork","homepage":"","size":12427,"stargazers_count":445,"watchers_count":445,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":83,"forks":164,"open_issues":83,"watchers":445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/525"},"html":{"href":"https://github.com/docker/libnetwork/pull/525"},"issue":{"href":"https://api.github.com/repos/docker/libnetwork/issues/525"},"comments":{"href":"https://api.github.com/repos/docker/libnetwork/issues/525/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/525/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/525/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libnetwork/statuses/beb6b6eb6de5456d0f7700eb10236bacc94d6f69"}}}}