{"action":"created","comment":{"url":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/43545304","id":43545304,"diff_hunk":"@@ -238,6 +238,10 @@ public SingularityS3Log call() throws Exception {\n   }\n \n   private List<SingularityS3Log> getS3Logs(Optional<String> group, Collection<String> prefixes) throws InterruptedException, ExecutionException, TimeoutException {\n+    if (prefixes.size() == 0) {","path":"SingularityService/src/main/java/com/hubspot/singularity/resources/S3LogResource.java","position":4,"original_position":4,"commit_id":"dd8bc6a07f6ca5805c9625a38b1bfba0f9f27a64","original_commit_id":"dd8bc6a07f6ca5805c9625a38b1bfba0f9f27a64","user":{"login":"wsorenson","id":281687,"avatar_url":"https://avatars.githubusercontent.com/u/281687?v=3","gravatar_id":"","url":"https://api.github.com/users/wsorenson","html_url":"https://github.com/wsorenson","followers_url":"https://api.github.com/users/wsorenson/followers","following_url":"https://api.github.com/users/wsorenson/following{/other_user}","gists_url":"https://api.github.com/users/wsorenson/gists{/gist_id}","starred_url":"https://api.github.com/users/wsorenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsorenson/subscriptions","organizations_url":"https://api.github.com/users/wsorenson/orgs","repos_url":"https://api.github.com/users/wsorenson/repos","events_url":"https://api.github.com/users/wsorenson/events{/privacy}","received_events_url":"https://api.github.com/users/wsorenson/received_events","type":"User","site_admin":false},"body":"isEmpty() is preferable I believe.","created_at":"2015-10-30T19:53:28Z","updated_at":"2015-10-30T19:53:28Z","html_url":"https://github.com/HubSpot/Singularity/pull/743#discussion_r43545304","pull_request_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/743","_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/43545304"},"html":{"href":"https://github.com/HubSpot/Singularity/pull/743#discussion_r43545304"},"pull_request":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/743"}}},"pull_request":{"url":"https://api.github.com/repos/HubSpot/Singularity/pulls/743","id":49313277,"html_url":"https://github.com/HubSpot/Singularity/pull/743","diff_url":"https://github.com/HubSpot/Singularity/pull/743.diff","patch_url":"https://github.com/HubSpot/Singularity/pull/743.patch","issue_url":"https://api.github.com/repos/HubSpot/Singularity/issues/743","number":743,"state":"open","locked":false,"title":"thread pool of 1 if prefixes is 0, avoid IllegalArgument","user":{"login":"ssalinas","id":6034439,"avatar_url":"https://avatars.githubusercontent.com/u/6034439?v=3","gravatar_id":"","url":"https://api.github.com/users/ssalinas","html_url":"https://github.com/ssalinas","followers_url":"https://api.github.com/users/ssalinas/followers","following_url":"https://api.github.com/users/ssalinas/following{/other_user}","gists_url":"https://api.github.com/users/ssalinas/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalinas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalinas/subscriptions","organizations_url":"https://api.github.com/users/ssalinas/orgs","repos_url":"https://api.github.com/users/ssalinas/repos","events_url":"https://api.github.com/users/ssalinas/events{/privacy}","received_events_url":"https://api.github.com/users/ssalinas/received_events","type":"User","site_admin":false},"body":"@tpetr ","created_at":"2015-10-30T19:35:58Z","updated_at":"2015-10-30T19:53:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3d27209142eece3b7abc3be61fefd3246669e73","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/743/commits","review_comments_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/743/comments","review_comment_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/issues/743/comments","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/dd8bc6a07f6ca5805c9625a38b1bfba0f9f27a64","head":{"label":"HubSpot:prefixes","ref":"prefixes","sha":"dd8bc6a07f6ca5805c9625a38b1bfba0f9f27a64","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":13631804,"name":"Singularity","full_name":"HubSpot/Singularity","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Singularity","description":"Scheduler (HTTP API and webapp) for running mesos tasks—long running processes, one-off tasks, and scheduled jobs. #hubspot-open-source","fork":false,"url":"https://api.github.com/repos/HubSpot/Singularity","forks_url":"https://api.github.com/repos/HubSpot/Singularity/forks","keys_url":"https://api.github.com/repos/HubSpot/Singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Singularity/teams","hooks_url":"https://api.github.com/repos/HubSpot/Singularity/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Singularity/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Singularity/events","assignees_url":"https://api.github.com/repos/HubSpot/Singularity/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Singularity/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Singularity/tags","blobs_url":"https://api.github.com/repos/HubSpot/Singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Singularity/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Singularity/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Singularity/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Singularity/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Singularity/subscription","commits_url":"https://api.github.com/repos/HubSpot/Singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Singularity/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Singularity/merges","archive_url":"https://api.github.com/repos/HubSpot/Singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Singularity/downloads","issues_url":"https://api.github.com/repos/HubSpot/Singularity/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Singularity/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Singularity/releases{/id}","created_at":"2013-10-16T21:28:49Z","updated_at":"2015-10-29T05:21:57Z","pushed_at":"2015-10-30T19:51:53Z","git_url":"git://github.com/HubSpot/Singularity.git","ssh_url":"git@github.com:HubSpot/Singularity.git","clone_url":"https://github.com/HubSpot/Singularity.git","svn_url":"https://github.com/HubSpot/Singularity","homepage":"https://github.com/HubSpot/Singularity","size":30526,"stargazers_count":431,"watchers_count":431,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":61,"mirror_url":null,"open_issues_count":33,"forks":61,"open_issues":33,"watchers":431,"default_branch":"master"}},"base":{"label":"HubSpot:master","ref":"master","sha":"cce107be232f4463003376228ee54e09971d2cbd","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":13631804,"name":"Singularity","full_name":"HubSpot/Singularity","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Singularity","description":"Scheduler (HTTP API and webapp) for running mesos tasks—long running processes, one-off tasks, and scheduled jobs. #hubspot-open-source","fork":false,"url":"https://api.github.com/repos/HubSpot/Singularity","forks_url":"https://api.github.com/repos/HubSpot/Singularity/forks","keys_url":"https://api.github.com/repos/HubSpot/Singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Singularity/teams","hooks_url":"https://api.github.com/repos/HubSpot/Singularity/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Singularity/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Singularity/events","assignees_url":"https://api.github.com/repos/HubSpot/Singularity/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Singularity/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Singularity/tags","blobs_url":"https://api.github.com/repos/HubSpot/Singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Singularity/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Singularity/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Singularity/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Singularity/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Singularity/subscription","commits_url":"https://api.github.com/repos/HubSpot/Singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Singularity/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Singularity/merges","archive_url":"https://api.github.com/repos/HubSpot/Singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Singularity/downloads","issues_url":"https://api.github.com/repos/HubSpot/Singularity/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Singularity/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Singularity/releases{/id}","created_at":"2013-10-16T21:28:49Z","updated_at":"2015-10-29T05:21:57Z","pushed_at":"2015-10-30T19:51:53Z","git_url":"git://github.com/HubSpot/Singularity.git","ssh_url":"git@github.com:HubSpot/Singularity.git","clone_url":"https://github.com/HubSpot/Singularity.git","svn_url":"https://github.com/HubSpot/Singularity","homepage":"https://github.com/HubSpot/Singularity","size":30526,"stargazers_count":431,"watchers_count":431,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":61,"mirror_url":null,"open_issues_count":33,"forks":61,"open_issues":33,"watchers":431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/743"},"html":{"href":"https://github.com/HubSpot/Singularity/pull/743"},"issue":{"href":"https://api.github.com/repos/HubSpot/Singularity/issues/743"},"comments":{"href":"https://api.github.com/repos/HubSpot/Singularity/issues/743/comments"},"review_comments":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/743/comments"},"review_comment":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/743/commits"},"statuses":{"href":"https://api.github.com/repos/HubSpot/Singularity/statuses/dd8bc6a07f6ca5805c9625a38b1bfba0f9f27a64"}}}}