{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/rma/pulls/comments/36192071","id":36192071,"diff_hunk":"@@ -0,0 +1,108 @@\n+# -*- coding: utf-8 -*-\n+# ########################################################################\n+#                                                                        #\n+#                                                                        #\n+# ########################################################################\n+#                                                                        #\n+# Copyright 2015 Vauxoo\n+# Copyright (C) 2009-2011  Akretion, Emmanuel Samyn, Benoît Guillot      #\n+#                                                                        #\n+# This program is free software: you can redistribute it and/or modify   #\n+# it under the terms of the GNU General Public License as published by   #\n+# the Free Software Foundation, either version 3 of the License, or      #\n+# (at your option) any later version.                                    #\n+#                                                                        #\n+# This program is distributed in the hope that it will be useful,        #\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of         #\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the          #\n+# GNU General Public License for more details.                           #\n+#                                                                        #\n+# You should have received a copy of the GNU General Public License      #\n+# along with this program.  If not, see <http://www.gnu.org/licenses/>.  #\n+##########################################################################\n+\n+from openerp import api, fields, models\n+\n+\n+class ProductSupplierInfo(models.Model):\n+\n+    _inherit = \"product.supplierinfo\"\n+\n+    @api.model\n+    def get_warranty_return_partner(self):\n+        result = [('company', 'Company'),\n+                  ('supplier', 'Supplier'),\n+                  ('other', 'Other'),\n+                  ]\n+        return result\n+\n+    @api.model\n+    def _get_default_instructions(self):\n+        \"\"\" Get selected lines to add to exchange \"\"\"\n+        instruction_ids = self.env['return.instruction']\\\n+            .search([('is_default', '=', True)], limit=1)\n+        return instruction_ids\n+\n+    @api.one\n+    @api.depends('warranty_return_partner')\n+    def _get_warranty_return_address(self):","path":"product_warranty/models/product_supplierinfo.py","position":48,"original_position":48,"commit_id":"660f8157ce94f87f1f444ef2e8689252682081dc","original_commit_id":"660f8157ce94f87f1f444ef2e8689252682081dc","user":{"login":"yaniaular","id":7602170,"avatar_url":"https://avatars.githubusercontent.com/u/7602170?v=3","gravatar_id":"","url":"https://api.github.com/users/yaniaular","html_url":"https://github.com/yaniaular","followers_url":"https://api.github.com/users/yaniaular/followers","following_url":"https://api.github.com/users/yaniaular/following{/other_user}","gists_url":"https://api.github.com/users/yaniaular/gists{/gist_id}","starred_url":"https://api.github.com/users/yaniaular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaniaular/subscriptions","organizations_url":"https://api.github.com/users/yaniaular/orgs","repos_url":"https://api.github.com/users/yaniaular/repos","events_url":"https://api.github.com/users/yaniaular/events{/privacy}","received_events_url":"https://api.github.com/users/yaniaular/received_events","type":"User","site_admin":false},"body":"@LeartS I agree with you with regard to the method name. But, \r\nI do not understand your comment in brackets. With the new API, the compute method not return something, Modifies the value of the field referring to the way <a haref=\"https://github.com/odoo/odoo/blob/a9e3d74713b6882c64617345696ad326d75a4745/addons/event/event.py#L186\">self.field = value</a>","created_at":"2015-08-04T14:15:17Z","updated_at":"2015-08-04T14:15:17Z","html_url":"https://github.com/OCA/rma/pull/33#discussion_r36192071","pull_request_url":"https://api.github.com/repos/OCA/rma/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/OCA/rma/pulls/comments/36192071"},"html":{"href":"https://github.com/OCA/rma/pull/33#discussion_r36192071"},"pull_request":{"href":"https://api.github.com/repos/OCA/rma/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/rma/pulls/33","id":41506757,"html_url":"https://github.com/OCA/rma/pull/33","diff_url":"https://github.com/OCA/rma/pull/33.diff","patch_url":"https://github.com/OCA/rma/pull/33.patch","issue_url":"https://api.github.com/repos/OCA/rma/issues/33","number":33,"state":"open","locked":false,"title":"8.0 squash product warranty module between oca vauxoo","user":{"login":"yaniaular","id":7602170,"avatar_url":"https://avatars.githubusercontent.com/u/7602170?v=3","gravatar_id":"","url":"https://api.github.com/users/yaniaular","html_url":"https://github.com/yaniaular","followers_url":"https://api.github.com/users/yaniaular/followers","following_url":"https://api.github.com/users/yaniaular/following{/other_user}","gists_url":"https://api.github.com/users/yaniaular/gists{/gist_id}","starred_url":"https://api.github.com/users/yaniaular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaniaular/subscriptions","organizations_url":"https://api.github.com/users/yaniaular/orgs","repos_url":"https://api.github.com/users/yaniaular/repos","events_url":"https://api.github.com/users/yaniaular/events{/privacy}","received_events_url":"https://api.github.com/users/yaniaular/received_events","type":"User","site_admin":false},"body":"Product_warranty module is migrated to API 8.0 and odoo 8.0.","created_at":"2015-08-03T20:33:33Z","updated_at":"2015-08-04T14:15:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dc46f25e83a2b85f4967078d1f860b2bdf65b30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OCA/rma/pulls/33/commits","review_comments_url":"https://api.github.com/repos/OCA/rma/pulls/33/comments","review_comment_url":"https://api.github.com/repos/OCA/rma/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/rma/issues/33/comments","statuses_url":"https://api.github.com/repos/OCA/rma/statuses/660f8157ce94f87f1f444ef2e8689252682081dc","head":{"label":"vauxoo-dev:8.0-squash_product_warranty_module_between_oca_vauxoo","ref":"8.0-squash_product_warranty_module_between_oca_vauxoo","sha":"660f8157ce94f87f1f444ef2e8689252682081dc","user":{"login":"vauxoo-dev","id":7662790,"avatar_url":"https://avatars.githubusercontent.com/u/7662790?v=3","gravatar_id":"","url":"https://api.github.com/users/vauxoo-dev","html_url":"https://github.com/vauxoo-dev","followers_url":"https://api.github.com/users/vauxoo-dev/followers","following_url":"https://api.github.com/users/vauxoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/vauxoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/vauxoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vauxoo-dev/subscriptions","organizations_url":"https://api.github.com/users/vauxoo-dev/orgs","repos_url":"https://api.github.com/users/vauxoo-dev/repos","events_url":"https://api.github.com/users/vauxoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/vauxoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":26508381,"name":"rma","full_name":"vauxoo-dev/rma","owner":{"login":"vauxoo-dev","id":7662790,"avatar_url":"https://avatars.githubusercontent.com/u/7662790?v=3","gravatar_id":"","url":"https://api.github.com/users/vauxoo-dev","html_url":"https://github.com/vauxoo-dev","followers_url":"https://api.github.com/users/vauxoo-dev/followers","following_url":"https://api.github.com/users/vauxoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/vauxoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/vauxoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vauxoo-dev/subscriptions","organizations_url":"https://api.github.com/users/vauxoo-dev/orgs","repos_url":"https://api.github.com/users/vauxoo-dev/repos","events_url":"https://api.github.com/users/vauxoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/vauxoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vauxoo-dev/rma","description":"","fork":true,"url":"https://api.github.com/repos/vauxoo-dev/rma","forks_url":"https://api.github.com/repos/vauxoo-dev/rma/forks","keys_url":"https://api.github.com/repos/vauxoo-dev/rma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vauxoo-dev/rma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vauxoo-dev/rma/teams","hooks_url":"https://api.github.com/repos/vauxoo-dev/rma/hooks","issue_events_url":"https://api.github.com/repos/vauxoo-dev/rma/issues/events{/number}","events_url":"https://api.github.com/repos/vauxoo-dev/rma/events","assignees_url":"https://api.github.com/repos/vauxoo-dev/rma/assignees{/user}","branches_url":"https://api.github.com/repos/vauxoo-dev/rma/branches{/branch}","tags_url":"https://api.github.com/repos/vauxoo-dev/rma/tags","blobs_url":"https://api.github.com/repos/vauxoo-dev/rma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vauxoo-dev/rma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vauxoo-dev/rma/git/refs{/sha}","trees_url":"https://api.github.com/repos/vauxoo-dev/rma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vauxoo-dev/rma/statuses/{sha}","languages_url":"https://api.github.com/repos/vauxoo-dev/rma/languages","stargazers_url":"https://api.github.com/repos/vauxoo-dev/rma/stargazers","contributors_url":"https://api.github.com/repos/vauxoo-dev/rma/contributors","subscribers_url":"https://api.github.com/repos/vauxoo-dev/rma/subscribers","subscription_url":"https://api.github.com/repos/vauxoo-dev/rma/subscription","commits_url":"https://api.github.com/repos/vauxoo-dev/rma/commits{/sha}","git_commits_url":"https://api.github.com/repos/vauxoo-dev/rma/git/commits{/sha}","comments_url":"https://api.github.com/repos/vauxoo-dev/rma/comments{/number}","issue_comment_url":"https://api.github.com/repos/vauxoo-dev/rma/issues/comments{/number}","contents_url":"https://api.github.com/repos/vauxoo-dev/rma/contents/{+path}","compare_url":"https://api.github.com/repos/vauxoo-dev/rma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vauxoo-dev/rma/merges","archive_url":"https://api.github.com/repos/vauxoo-dev/rma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vauxoo-dev/rma/downloads","issues_url":"https://api.github.com/repos/vauxoo-dev/rma/issues{/number}","pulls_url":"https://api.github.com/repos/vauxoo-dev/rma/pulls{/number}","milestones_url":"https://api.github.com/repos/vauxoo-dev/rma/milestones{/number}","notifications_url":"https://api.github.com/repos/vauxoo-dev/rma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vauxoo-dev/rma/labels{/name}","releases_url":"https://api.github.com/repos/vauxoo-dev/rma/releases{/id}","created_at":"2014-11-11T22:43:23Z","updated_at":"2014-12-10T18:48:36Z","pushed_at":"2015-08-04T01:11:03Z","git_url":"git://github.com/vauxoo-dev/rma.git","ssh_url":"git@github.com:vauxoo-dev/rma.git","clone_url":"https://github.com/vauxoo-dev/rma.git","svn_url":"https://github.com/vauxoo-dev/rma","homepage":null,"size":2794,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"OCA:8.0","ref":"8.0","sha":"8c29715d52209955f85e19ca13a61d4058d26875","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20922026,"name":"rma","full_name":"OCA/rma","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/rma","description":"Odoo for Return Of Material (RMA)","fork":false,"url":"https://api.github.com/repos/OCA/rma","forks_url":"https://api.github.com/repos/OCA/rma/forks","keys_url":"https://api.github.com/repos/OCA/rma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/rma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/rma/teams","hooks_url":"https://api.github.com/repos/OCA/rma/hooks","issue_events_url":"https://api.github.com/repos/OCA/rma/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/rma/events","assignees_url":"https://api.github.com/repos/OCA/rma/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/rma/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/rma/tags","blobs_url":"https://api.github.com/repos/OCA/rma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/rma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/rma/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/rma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/rma/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/rma/languages","stargazers_url":"https://api.github.com/repos/OCA/rma/stargazers","contributors_url":"https://api.github.com/repos/OCA/rma/contributors","subscribers_url":"https://api.github.com/repos/OCA/rma/subscribers","subscription_url":"https://api.github.com/repos/OCA/rma/subscription","commits_url":"https://api.github.com/repos/OCA/rma/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/rma/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/rma/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/rma/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/rma/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/rma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/rma/merges","archive_url":"https://api.github.com/repos/OCA/rma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/rma/downloads","issues_url":"https://api.github.com/repos/OCA/rma/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/rma/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/rma/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/rma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/rma/labels{/name}","releases_url":"https://api.github.com/repos/OCA/rma/releases{/id}","created_at":"2014-06-17T12:15:02Z","updated_at":"2015-06-30T17:31:29Z","pushed_at":"2015-08-04T01:11:03Z","git_url":"git://github.com/OCA/rma.git","ssh_url":"git@github.com:OCA/rma.git","clone_url":"https://github.com/OCA/rma.git","svn_url":"https://github.com/OCA/rma","homepage":"","size":2357,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":10,"forks":33,"open_issues":10,"watchers":5,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/rma/pulls/33"},"html":{"href":"https://github.com/OCA/rma/pull/33"},"issue":{"href":"https://api.github.com/repos/OCA/rma/issues/33"},"comments":{"href":"https://api.github.com/repos/OCA/rma/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/rma/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/rma/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/rma/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/rma/statuses/660f8157ce94f87f1f444ef2e8689252682081dc"}}}}