{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/23250805","id":23250805,"diff_hunk":"@@ -253,9 +253,10 @@ pub fn file_to_filemap(sess: &ParseSess, path: &Path, spanopt: Option<Span>)\n     let bytes = match File::open(path).read_to_end() {\n         Ok(bytes) => bytes,\n         Err(e) => {\n-            err(&format!(\"couldn't read {:?}: {:?}\",\n+            let error_msg = e.desc;\n+            err(&format!(\"couldn't read {:?}: {}\",\n                         path.display(),\n-                        e)[]);\n+                        error_msg)[]);","path":"src/libsyntax/parse/mod.rs","position":9,"original_position":9,"commit_id":"b6b8880f0ec3f057dc56320f6886be173a8f0d8e","original_commit_id":"b6b8880f0ec3f057dc56320f6886be173a8f0d8e","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"I think this should actually continue to format `e` entirely, it should just use `{}` instead of `{:?}`","created_at":"2015-01-20T20:02:09Z","updated_at":"2015-01-20T20:02:09Z","html_url":"https://github.com/rust-lang/rust/pull/21336#discussion_r23250805","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/21336","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/23250805"},"html":{"href":"https://github.com/rust-lang/rust/pull/21336#discussion_r23250805"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/21336"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/21336","id":27564317,"html_url":"https://github.com/rust-lang/rust/pull/21336","diff_url":"https://github.com/rust-lang/rust/pull/21336.diff","patch_url":"https://github.com/rust-lang/rust/pull/21336.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/21336","number":21336,"state":"open","locked":false,"title":"Improve the error message when source file cannot be read","user":{"login":"rylev","id":1327285,"avatar_url":"https://avatars.githubusercontent.com/u/1327285?v=3","gravatar_id":"","url":"https://api.github.com/users/rylev","html_url":"https://github.com/rylev","followers_url":"https://api.github.com/users/rylev/followers","following_url":"https://api.github.com/users/rylev/following{/other_user}","gists_url":"https://api.github.com/users/rylev/gists{/gist_id}","starred_url":"https://api.github.com/users/rylev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rylev/subscriptions","organizations_url":"https://api.github.com/users/rylev/orgs","repos_url":"https://api.github.com/users/rylev/repos","events_url":"https://api.github.com/users/rylev/events{/privacy}","received_events_url":"https://api.github.com/users/rylev/received_events","type":"User","site_admin":false},"body":"Contribution from @look!\r\n\r\nAddresses https://github.com/rust-lang/rust/issues/21329","created_at":"2015-01-17T23:51:31Z","updated_at":"2015-01-20T20:02:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86f7cf9023b98cf0cb75a5989738aca8f154ec88","assignee":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/21336/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/21336/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/21336/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/b6b8880f0ec3f057dc56320f6886be173a8f0d8e","head":{"label":"rylev:better-nofile-error","ref":"better-nofile-error","sha":"b6b8880f0ec3f057dc56320f6886be173a8f0d8e","user":{"login":"rylev","id":1327285,"avatar_url":"https://avatars.githubusercontent.com/u/1327285?v=3","gravatar_id":"","url":"https://api.github.com/users/rylev","html_url":"https://github.com/rylev","followers_url":"https://api.github.com/users/rylev/followers","following_url":"https://api.github.com/users/rylev/following{/other_user}","gists_url":"https://api.github.com/users/rylev/gists{/gist_id}","starred_url":"https://api.github.com/users/rylev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rylev/subscriptions","organizations_url":"https://api.github.com/users/rylev/orgs","repos_url":"https://api.github.com/users/rylev/repos","events_url":"https://api.github.com/users/rylev/events{/privacy}","received_events_url":"https://api.github.com/users/rylev/received_events","type":"User","site_admin":false},"repo":{"id":29409658,"name":"rust","full_name":"rylev/rust","owner":{"login":"rylev","id":1327285,"avatar_url":"https://avatars.githubusercontent.com/u/1327285?v=3","gravatar_id":"","url":"https://api.github.com/users/rylev","html_url":"https://github.com/rylev","followers_url":"https://api.github.com/users/rylev/followers","following_url":"https://api.github.com/users/rylev/following{/other_user}","gists_url":"https://api.github.com/users/rylev/gists{/gist_id}","starred_url":"https://api.github.com/users/rylev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rylev/subscriptions","organizations_url":"https://api.github.com/users/rylev/orgs","repos_url":"https://api.github.com/users/rylev/repos","events_url":"https://api.github.com/users/rylev/events{/privacy}","received_events_url":"https://api.github.com/users/rylev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rylev/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/rylev/rust","forks_url":"https://api.github.com/repos/rylev/rust/forks","keys_url":"https://api.github.com/repos/rylev/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rylev/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rylev/rust/teams","hooks_url":"https://api.github.com/repos/rylev/rust/hooks","issue_events_url":"https://api.github.com/repos/rylev/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rylev/rust/events","assignees_url":"https://api.github.com/repos/rylev/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rylev/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rylev/rust/tags","blobs_url":"https://api.github.com/repos/rylev/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rylev/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rylev/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rylev/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rylev/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rylev/rust/languages","stargazers_url":"https://api.github.com/repos/rylev/rust/stargazers","contributors_url":"https://api.github.com/repos/rylev/rust/contributors","subscribers_url":"https://api.github.com/repos/rylev/rust/subscribers","subscription_url":"https://api.github.com/repos/rylev/rust/subscription","commits_url":"https://api.github.com/repos/rylev/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rylev/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rylev/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rylev/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rylev/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rylev/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rylev/rust/merges","archive_url":"https://api.github.com/repos/rylev/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rylev/rust/downloads","issues_url":"https://api.github.com/repos/rylev/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rylev/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rylev/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rylev/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rylev/rust/labels{/name}","releases_url":"https://api.github.com/repos/rylev/rust/releases{/id}","created_at":"2015-01-17T23:41:00Z","updated_at":"2015-01-17T23:41:12Z","pushed_at":"2015-01-17T23:50:30Z","git_url":"git://github.com/rylev/rust.git","ssh_url":"git@github.com:rylev/rust.git","clone_url":"https://github.com/rylev/rust.git","svn_url":"https://github.com/rylev/rust","homepage":"http://www.rust-lang.org","size":216442,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"f4f10dba2975b51c2d2c92157018db3ac13d4d4a","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-01-20T19:42:53Z","pushed_at":"2015-01-20T19:56:45Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":441895,"stargazers_count":8953,"watchers_count":8953,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1729,"mirror_url":null,"open_issues_count":2406,"forks":1729,"open_issues":2406,"watchers":8953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/21336"},"html":{"href":"https://github.com/rust-lang/rust/pull/21336"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/21336"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/21336/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/21336/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/21336/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/b6b8880f0ec3f057dc56320f6886be173a8f0d8e"}}}}