{"action":"created","comment":{"url":"https://api.github.com/repos/btcsuite/btcwallet/pulls/comments/29582136","id":29582136,"diff_hunk":"@@ -62,11 +65,11 @@ type ManagedPubKeyAddress interface {\n \tManagedAddress\n \n \t// PubKey returns the public key associated with the address.\n-\tPubKey() *btcec.PublicKey\n+\tPubKey() (*btcec.PublicKey, error)","path":"waddrmgr/address.go","position":15,"original_position":15,"commit_id":"b854a061b38a219d762296f63ac16d8e83d68bf8","original_commit_id":"8847744a7b55dec2300ab827656068d5211e2e2b","user":{"login":"tuxcanfly","id":132667,"avatar_url":"https://avatars.githubusercontent.com/u/132667?v=3","gravatar_id":"","url":"https://api.github.com/users/tuxcanfly","html_url":"https://github.com/tuxcanfly","followers_url":"https://api.github.com/users/tuxcanfly/followers","following_url":"https://api.github.com/users/tuxcanfly/following{/other_user}","gists_url":"https://api.github.com/users/tuxcanfly/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxcanfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxcanfly/subscriptions","organizations_url":"https://api.github.com/users/tuxcanfly/orgs","repos_url":"https://api.github.com/users/tuxcanfly/repos","events_url":"https://api.github.com/users/tuxcanfly/events{/privacy}","received_events_url":"https://api.github.com/users/tuxcanfly/received_events","type":"User","site_admin":false},"body":"OK, we already have a db field called `compressed` on `managedAddress` which we are using for determining whether the pubkey is compressed or not. If we change the signature we might want to remove that field to avoid ambiguity.\r\n\r\nAlso, the `PubKey` signature is consistent with `PrivKey` which returns `ErrWatchingOnly` when private key is not available.","created_at":"2015-05-04T13:01:48Z","updated_at":"2015-05-04T13:01:48Z","html_url":"https://github.com/btcsuite/btcwallet/pull/204#discussion_r29582136","pull_request_url":"https://api.github.com/repos/btcsuite/btcwallet/pulls/204","_links":{"self":{"href":"https://api.github.com/repos/btcsuite/btcwallet/pulls/comments/29582136"},"html":{"href":"https://github.com/btcsuite/btcwallet/pull/204#discussion_r29582136"},"pull_request":{"href":"https://api.github.com/repos/btcsuite/btcwallet/pulls/204"}}},"pull_request":{"url":"https://api.github.com/repos/btcsuite/btcwallet/pulls/204","id":30307026,"html_url":"https://github.com/btcsuite/btcwallet/pull/204","diff_url":"https://github.com/btcsuite/btcwallet/pull/204.diff","patch_url":"https://github.com/btcsuite/btcwallet/pull/204.patch","issue_url":"https://api.github.com/repos/btcsuite/btcwallet/issues/204","number":204,"state":"open","locked":false,"title":"Import external watch-only addresses","user":{"login":"tuxcanfly","id":132667,"avatar_url":"https://avatars.githubusercontent.com/u/132667?v=3","gravatar_id":"","url":"https://api.github.com/users/tuxcanfly","html_url":"https://github.com/tuxcanfly","followers_url":"https://api.github.com/users/tuxcanfly/followers","following_url":"https://api.github.com/users/tuxcanfly/following{/other_user}","gists_url":"https://api.github.com/users/tuxcanfly/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxcanfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxcanfly/subscriptions","organizations_url":"https://api.github.com/users/tuxcanfly/orgs","repos_url":"https://api.github.com/users/tuxcanfly/repos","events_url":"https://api.github.com/users/tuxcanfly/events{/privacy}","received_events_url":"https://api.github.com/users/tuxcanfly/received_events","type":"User","site_admin":false},"body":"Added RPC commands to import external watch-only addresses both with and without pubkeys. WIP on finishing test coverage and docs.\r\n\r\nRefs #192  ","created_at":"2015-03-02T18:23:56Z","updated_at":"2015-05-04T13:01:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd016401b5ea875af9a75d0582fd83b378fa55c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/btcsuite/btcwallet/pulls/204/commits","review_comments_url":"https://api.github.com/repos/btcsuite/btcwallet/pulls/204/comments","review_comment_url":"https://api.github.com/repos/btcsuite/btcwallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/btcsuite/btcwallet/issues/204/comments","statuses_url":"https://api.github.com/repos/btcsuite/btcwallet/statuses/b854a061b38a219d762296f63ac16d8e83d68bf8","head":{"label":"tuxcanfly:import-address","ref":"import-address","sha":"b854a061b38a219d762296f63ac16d8e83d68bf8","user":{"login":"tuxcanfly","id":132667,"avatar_url":"https://avatars.githubusercontent.com/u/132667?v=3","gravatar_id":"","url":"https://api.github.com/users/tuxcanfly","html_url":"https://github.com/tuxcanfly","followers_url":"https://api.github.com/users/tuxcanfly/followers","following_url":"https://api.github.com/users/tuxcanfly/following{/other_user}","gists_url":"https://api.github.com/users/tuxcanfly/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxcanfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxcanfly/subscriptions","organizations_url":"https://api.github.com/users/tuxcanfly/orgs","repos_url":"https://api.github.com/users/tuxcanfly/repos","events_url":"https://api.github.com/users/tuxcanfly/events{/privacy}","received_events_url":"https://api.github.com/users/tuxcanfly/received_events","type":"User","site_admin":false},"repo":{"id":21453162,"name":"btcwallet","full_name":"tuxcanfly/btcwallet","owner":{"login":"tuxcanfly","id":132667,"avatar_url":"https://avatars.githubusercontent.com/u/132667?v=3","gravatar_id":"","url":"https://api.github.com/users/tuxcanfly","html_url":"https://github.com/tuxcanfly","followers_url":"https://api.github.com/users/tuxcanfly/followers","following_url":"https://api.github.com/users/tuxcanfly/following{/other_user}","gists_url":"https://api.github.com/users/tuxcanfly/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxcanfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxcanfly/subscriptions","organizations_url":"https://api.github.com/users/tuxcanfly/orgs","repos_url":"https://api.github.com/users/tuxcanfly/repos","events_url":"https://api.github.com/users/tuxcanfly/events{/privacy}","received_events_url":"https://api.github.com/users/tuxcanfly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tuxcanfly/btcwallet","description":"","fork":true,"url":"https://api.github.com/repos/tuxcanfly/btcwallet","forks_url":"https://api.github.com/repos/tuxcanfly/btcwallet/forks","keys_url":"https://api.github.com/repos/tuxcanfly/btcwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuxcanfly/btcwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuxcanfly/btcwallet/teams","hooks_url":"https://api.github.com/repos/tuxcanfly/btcwallet/hooks","issue_events_url":"https://api.github.com/repos/tuxcanfly/btcwallet/issues/events{/number}","events_url":"https://api.github.com/repos/tuxcanfly/btcwallet/events","assignees_url":"https://api.github.com/repos/tuxcanfly/btcwallet/assignees{/user}","branches_url":"https://api.github.com/repos/tuxcanfly/btcwallet/branches{/branch}","tags_url":"https://api.github.com/repos/tuxcanfly/btcwallet/tags","blobs_url":"https://api.github.com/repos/tuxcanfly/btcwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuxcanfly/btcwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuxcanfly/btcwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuxcanfly/btcwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuxcanfly/btcwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/tuxcanfly/btcwallet/languages","stargazers_url":"https://api.github.com/repos/tuxcanfly/btcwallet/stargazers","contributors_url":"https://api.github.com/repos/tuxcanfly/btcwallet/contributors","subscribers_url":"https://api.github.com/repos/tuxcanfly/btcwallet/subscribers","subscription_url":"https://api.github.com/repos/tuxcanfly/btcwallet/subscription","commits_url":"https://api.github.com/repos/tuxcanfly/btcwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuxcanfly/btcwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuxcanfly/btcwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuxcanfly/btcwallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuxcanfly/btcwallet/contents/{+path}","compare_url":"https://api.github.com/repos/tuxcanfly/btcwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuxcanfly/btcwallet/merges","archive_url":"https://api.github.com/repos/tuxcanfly/btcwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuxcanfly/btcwallet/downloads","issues_url":"https://api.github.com/repos/tuxcanfly/btcwallet/issues{/number}","pulls_url":"https://api.github.com/repos/tuxcanfly/btcwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/tuxcanfly/btcwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/tuxcanfly/btcwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuxcanfly/btcwallet/labels{/name}","releases_url":"https://api.github.com/repos/tuxcanfly/btcwallet/releases{/id}","created_at":"2014-07-03T07:10:43Z","updated_at":"2014-07-09T11:38:45Z","pushed_at":"2015-05-02T03:19:53Z","git_url":"git://github.com/tuxcanfly/btcwallet.git","ssh_url":"git@github.com:tuxcanfly/btcwallet.git","clone_url":"https://github.com/tuxcanfly/btcwallet.git","svn_url":"https://github.com/tuxcanfly/btcwallet","homepage":null,"size":5083,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"btcsuite:master","ref":"master","sha":"c820c8a0151713571e23fe982a8847a4f121e940","user":{"login":"btcsuite","id":10235229,"avatar_url":"https://avatars.githubusercontent.com/u/10235229?v=3","gravatar_id":"","url":"https://api.github.com/users/btcsuite","html_url":"https://github.com/btcsuite","followers_url":"https://api.github.com/users/btcsuite/followers","following_url":"https://api.github.com/users/btcsuite/following{/other_user}","gists_url":"https://api.github.com/users/btcsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/btcsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcsuite/subscriptions","organizations_url":"https://api.github.com/users/btcsuite/orgs","repos_url":"https://api.github.com/users/btcsuite/repos","events_url":"https://api.github.com/users/btcsuite/events{/privacy}","received_events_url":"https://api.github.com/users/btcsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":12136863,"name":"btcwallet","full_name":"btcsuite/btcwallet","owner":{"login":"btcsuite","id":10235229,"avatar_url":"https://avatars.githubusercontent.com/u/10235229?v=3","gravatar_id":"","url":"https://api.github.com/users/btcsuite","html_url":"https://github.com/btcsuite","followers_url":"https://api.github.com/users/btcsuite/followers","following_url":"https://api.github.com/users/btcsuite/following{/other_user}","gists_url":"https://api.github.com/users/btcsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/btcsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btcsuite/subscriptions","organizations_url":"https://api.github.com/users/btcsuite/orgs","repos_url":"https://api.github.com/users/btcsuite/repos","events_url":"https://api.github.com/users/btcsuite/events{/privacy}","received_events_url":"https://api.github.com/users/btcsuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/btcsuite/btcwallet","description":"","fork":false,"url":"https://api.github.com/repos/btcsuite/btcwallet","forks_url":"https://api.github.com/repos/btcsuite/btcwallet/forks","keys_url":"https://api.github.com/repos/btcsuite/btcwallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btcsuite/btcwallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btcsuite/btcwallet/teams","hooks_url":"https://api.github.com/repos/btcsuite/btcwallet/hooks","issue_events_url":"https://api.github.com/repos/btcsuite/btcwallet/issues/events{/number}","events_url":"https://api.github.com/repos/btcsuite/btcwallet/events","assignees_url":"https://api.github.com/repos/btcsuite/btcwallet/assignees{/user}","branches_url":"https://api.github.com/repos/btcsuite/btcwallet/branches{/branch}","tags_url":"https://api.github.com/repos/btcsuite/btcwallet/tags","blobs_url":"https://api.github.com/repos/btcsuite/btcwallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btcsuite/btcwallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btcsuite/btcwallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/btcsuite/btcwallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btcsuite/btcwallet/statuses/{sha}","languages_url":"https://api.github.com/repos/btcsuite/btcwallet/languages","stargazers_url":"https://api.github.com/repos/btcsuite/btcwallet/stargazers","contributors_url":"https://api.github.com/repos/btcsuite/btcwallet/contributors","subscribers_url":"https://api.github.com/repos/btcsuite/btcwallet/subscribers","subscription_url":"https://api.github.com/repos/btcsuite/btcwallet/subscription","commits_url":"https://api.github.com/repos/btcsuite/btcwallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/btcsuite/btcwallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/btcsuite/btcwallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/btcsuite/btcwallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/btcsuite/btcwallet/contents/{+path}","compare_url":"https://api.github.com/repos/btcsuite/btcwallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btcsuite/btcwallet/merges","archive_url":"https://api.github.com/repos/btcsuite/btcwallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btcsuite/btcwallet/downloads","issues_url":"https://api.github.com/repos/btcsuite/btcwallet/issues{/number}","pulls_url":"https://api.github.com/repos/btcsuite/btcwallet/pulls{/number}","milestones_url":"https://api.github.com/repos/btcsuite/btcwallet/milestones{/number}","notifications_url":"https://api.github.com/repos/btcsuite/btcwallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btcsuite/btcwallet/labels{/name}","releases_url":"https://api.github.com/repos/btcsuite/btcwallet/releases{/id}","created_at":"2013-08-15T14:53:57Z","updated_at":"2015-05-01T17:38:24Z","pushed_at":"2015-05-02T03:19:53Z","git_url":"git://github.com/btcsuite/btcwallet.git","ssh_url":"git@github.com:btcsuite/btcwallet.git","clone_url":"https://github.com/btcsuite/btcwallet.git","svn_url":"https://github.com/btcsuite/btcwallet","homepage":null,"size":8683,"stargazers_count":66,"watchers_count":66,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":34,"forks":42,"open_issues":34,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/btcsuite/btcwallet/pulls/204"},"html":{"href":"https://github.com/btcsuite/btcwallet/pull/204"},"issue":{"href":"https://api.github.com/repos/btcsuite/btcwallet/issues/204"},"comments":{"href":"https://api.github.com/repos/btcsuite/btcwallet/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/btcsuite/btcwallet/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/btcsuite/btcwallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/btcsuite/btcwallet/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/btcsuite/btcwallet/statuses/b854a061b38a219d762296f63ac16d8e83d68bf8"}}}}