{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/43650051","id":43650051,"diff_hunk":"@@ -146,11 +146,13 @@ public void verifyHttpsFromConfig() throws Exception {\n     @Test\n     public void verifyHttpsCiphers() throws Exception {\n         brooklynProperties.put(BrooklynWebConfig.HTTPS_REQUIRED, true);\n-        brooklynProperties.put(BrooklynWebConfig.TRANSPORT_PROTOCOLS, \"XXX\");\n-        brooklynProperties.put(BrooklynWebConfig.TRANSPORT_CIPHERS, \"XXX\");","path":"usage/launcher/src/test/java/org/apache/brooklyn/launcher/BrooklynWebServerTest.java","position":5,"original_position":5,"commit_id":"53eaa823121c75089ff4d5b531c6a019d5899da0","original_commit_id":"b7129ebb54edc9077fc11d7062eca29595d04c06","user":{"login":"neykov","id":3612111,"avatar_url":"https://avatars.githubusercontent.com/u/3612111?v=3","gravatar_id":"","url":"https://api.github.com/users/neykov","html_url":"https://github.com/neykov","followers_url":"https://api.github.com/users/neykov/followers","following_url":"https://api.github.com/users/neykov/following{/other_user}","gists_url":"https://api.github.com/users/neykov/gists{/gist_id}","starred_url":"https://api.github.com/users/neykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neykov/subscriptions","organizations_url":"https://api.github.com/users/neykov/orgs","repos_url":"https://api.github.com/users/neykov/repos","events_url":"https://api.github.com/users/neykov/events{/privacy}","received_events_url":"https://api.github.com/users/neykov/received_events","type":"User","site_admin":false},"body":"But why remove the properties? The test is meant to confirm that the properties are actually used to configure the web server.\r\nHaving this pass now suggests that the test is not working as expected though.","created_at":"2015-11-02T16:48:24Z","updated_at":"2015-11-02T16:48:24Z","html_url":"https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43650051","pull_request_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/997","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/43650051"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43650051"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/997"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/997","id":49427007,"html_url":"https://github.com/apache/incubator-brooklyn/pull/997","diff_url":"https://github.com/apache/incubator-brooklyn/pull/997.diff","patch_url":"https://github.com/apache/incubator-brooklyn/pull/997.patch","issue_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/997","number":997,"state":"open","locked":false,"title":"[BROOKLYN-190] Move from Jetty8 to Jetty9","user":{"login":"CMoH","id":663132,"avatar_url":"https://avatars.githubusercontent.com/u/663132?v=3","gravatar_id":"","url":"https://api.github.com/users/CMoH","html_url":"https://github.com/CMoH","followers_url":"https://api.github.com/users/CMoH/followers","following_url":"https://api.github.com/users/CMoH/following{/other_user}","gists_url":"https://api.github.com/users/CMoH/gists{/gist_id}","starred_url":"https://api.github.com/users/CMoH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMoH/subscriptions","organizations_url":"https://api.github.com/users/CMoH/orgs","repos_url":"https://api.github.com/users/CMoH/repos","events_url":"https://api.github.com/users/CMoH/events{/privacy}","received_events_url":"https://api.github.com/users/CMoH/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-02T12:41:37Z","updated_at":"2015-11-02T16:48:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"305039ceeef41c2a7e75f8b53cb233b06df41ba6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/997/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/997/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/997/comments","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/53eaa823121c75089ff4d5b531c6a019d5899da0","head":{"label":"CMoH:jetty9","ref":"jetty9","sha":"53eaa823121c75089ff4d5b531c6a019d5899da0","user":{"login":"CMoH","id":663132,"avatar_url":"https://avatars.githubusercontent.com/u/663132?v=3","gravatar_id":"","url":"https://api.github.com/users/CMoH","html_url":"https://github.com/CMoH","followers_url":"https://api.github.com/users/CMoH/followers","following_url":"https://api.github.com/users/CMoH/following{/other_user}","gists_url":"https://api.github.com/users/CMoH/gists{/gist_id}","starred_url":"https://api.github.com/users/CMoH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMoH/subscriptions","organizations_url":"https://api.github.com/users/CMoH/orgs","repos_url":"https://api.github.com/users/CMoH/repos","events_url":"https://api.github.com/users/CMoH/events{/privacy}","received_events_url":"https://api.github.com/users/CMoH/received_events","type":"User","site_admin":false},"repo":{"id":26918522,"name":"incubator-brooklyn","full_name":"CMoH/incubator-brooklyn","owner":{"login":"CMoH","id":663132,"avatar_url":"https://avatars.githubusercontent.com/u/663132?v=3","gravatar_id":"","url":"https://api.github.com/users/CMoH","html_url":"https://github.com/CMoH","followers_url":"https://api.github.com/users/CMoH/followers","following_url":"https://api.github.com/users/CMoH/following{/other_user}","gists_url":"https://api.github.com/users/CMoH/gists{/gist_id}","starred_url":"https://api.github.com/users/CMoH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMoH/subscriptions","organizations_url":"https://api.github.com/users/CMoH/orgs","repos_url":"https://api.github.com/users/CMoH/repos","events_url":"https://api.github.com/users/CMoH/events{/privacy}","received_events_url":"https://api.github.com/users/CMoH/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CMoH/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":true,"url":"https://api.github.com/repos/CMoH/incubator-brooklyn","forks_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/CMoH/incubator-brooklyn/releases{/id}","created_at":"2014-11-20T15:27:51Z","updated_at":"2015-04-19T10:20:59Z","pushed_at":"2015-11-02T16:13:41Z","git_url":"git://github.com/CMoH/incubator-brooklyn.git","ssh_url":"git@github.com:CMoH/incubator-brooklyn.git","clone_url":"https://github.com/CMoH/incubator-brooklyn.git","svn_url":"https://github.com/CMoH/incubator-brooklyn","homepage":null,"size":253570,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6d0089086469513bd4c0f6729e6ca024e413cd72","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19368221,"name":"incubator-brooklyn","full_name":"apache/incubator-brooklyn","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":false,"url":"https://api.github.com/repos/apache/incubator-brooklyn","forks_url":"https://api.github.com/repos/apache/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/apache/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/apache/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/apache/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/apache/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-brooklyn/releases{/id}","created_at":"2014-05-02T07:00:07Z","updated_at":"2015-10-27T03:03:35Z","pushed_at":"2015-11-02T16:43:08Z","git_url":"git://github.com/apache/incubator-brooklyn.git","ssh_url":"git@github.com:apache/incubator-brooklyn.git","clone_url":"https://github.com/apache/incubator-brooklyn.git","svn_url":"https://github.com/apache/incubator-brooklyn","homepage":null,"size":265724,"stargazers_count":119,"watchers_count":119,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":"git://git.apache.org/incubator-brooklyn.git","open_issues_count":12,"forks":99,"open_issues":12,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/997"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/997"},"issue":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/997"},"comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/997/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/997/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/997/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/53eaa823121c75089ff4d5b531c6a019d5899da0"}}}}