{"action":"closed","issue":{"url":"https://api.github.com/repos/BIDData/BIDMat/issues/34","labels_url":"https://api.github.com/repos/BIDData/BIDMat/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/BIDData/BIDMat/issues/34/comments","events_url":"https://api.github.com/repos/BIDData/BIDMat/issues/34/events","html_url":"https://github.com/BIDData/BIDMat/issues/34","id":91034438,"number":34,"title":"Added out.clear for BIDMat DenseMat accum","user":{"login":"DanielTakeshi","id":5532096,"avatar_url":"https://avatars.githubusercontent.com/u/5532096?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielTakeshi","html_url":"https://github.com/DanielTakeshi","followers_url":"https://api.github.com/users/DanielTakeshi/followers","following_url":"https://api.github.com/users/DanielTakeshi/following{/other_user}","gists_url":"https://api.github.com/users/DanielTakeshi/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielTakeshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielTakeshi/subscriptions","organizations_url":"https://api.github.com/users/DanielTakeshi/orgs","repos_url":"https://api.github.com/users/DanielTakeshi/repos","events_url":"https://api.github.com/users/DanielTakeshi/events{/privacy}","received_events_url":"https://api.github.com/users/DanielTakeshi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-25T18:02:01Z","updated_at":"2015-06-25T20:11:21Z","closed_at":"2015-06-25T20:11:21Z","body":"John, I added in `out.clear` lines for the DenseMat accum, i.e., what gets called when we do `accum` for CPU matrices.\r\n\r\nhttps://github.com/BIDData/BIDMat/commit/99e99233c500440b22ae23adacc80067895f715d\r\n\r\nThe issue was that originally, my `accum` calls would store the results from the previous accum call in `out` which resulted in cumulative sums being added to the previous output, not a clear matrix of zeros. The GPU versions of accum have `out.clear` in them (check `GMat.scala`) so I'm assuming that the lack of `out.clear` in the CPU versions is just an oversight.  I didn't catch this in testing but it came up in the BayesNet.scala tests with matrix caching on.\r\n\r\nJohn, assuming this doesn't break anything, feel free to close this."}}