{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/35162222","id":35162222,"diff_hunk":"@@ -253,3 +254,13 @@ type ContainerConfig struct {\n \tCpuShares  int64\n \tCpuset     string\n }\n+\n+// MountPoint represents a mount point configuration inside the container.\n+type MountPoint struct {\n+\tName        string `json:\",omitempty\"`\n+\tSource      string\n+\tDestination string\n+\tDriver      string `json:\",omitempty\"`\n+\tMode        string","path":"api/types/types.go","position":39,"original_position":39,"commit_id":"7e11f01eabd52578aef2851e498a6da886ca738a","original_commit_id":"7e11f01eabd52578aef2851e498a6da886ca738a","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"Place a small doc comment for `Mode` that this might be known as `Relabel` internally.","created_at":"2015-07-21T22:26:57Z","updated_at":"2015-07-21T22:26:57Z","html_url":"https://github.com/docker/docker/pull/13711#discussion_r35162222","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/13711","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/35162222"},"html":{"href":"https://github.com/docker/docker/pull/13711#discussion_r35162222"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/13711"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/13711","id":36868241,"html_url":"https://github.com/docker/docker/pull/13711","diff_url":"https://github.com/docker/docker/pull/13711.diff","patch_url":"https://github.com/docker/docker/pull/13711.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/13711","number":13711,"state":"open","locked":false,"title":"Expose new mount points structs in inspect.","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"body":"Docker Inspect presents the volume information in two different hashes. There are a couple of issues with this approach:\r\n\r\n1. It's hard to parse, because if you want to have the full information for a volume you have to parse the output twice, one to look at the sources information and another time to look at the permissions information.\r\n2. It cannot display any more information besides what's in it now, because it's designed with a map of strings and a map of boolean. The amount of information for a mount point is growing with named volumes, external drivers and so on, and we need to show this information.\r\n\r\nThe new approach exposes the full mount point structure as a single element in the output. So you only need to parse a single field to get the information for a specific volume, and you get everything related to that volume.\r\n\r\n**Before this patch:**\r\n\r\n```json\r\n{\r\n  \"Volumes\": {\"/vol1\": \"/vol1\"},\r\n  \"VolumesRW\": {\"/vol1\": true}\r\n}\r\n```\r\n\r\n**After this patch:**\r\n\r\n```json\r\n{\r\n  \"Mounts\": [\r\n     {\r\n        \"Source\": \"/vol1\",\r\n        \"Destination\": \"/vol1\",\r\n        \"Mode\": \"rw,Z\",\r\n        \"RW\": true\r\n     }\r\n  ]\r\n}\r\n```\r\n\r\nTODO:\r\n\r\n- [x] Tests\r\n- [x] Docs\r\n\r\nSigned-off-by: David Calavera <david.calavera@gmail.com>","created_at":"2015-06-03T19:24:22Z","updated_at":"2015-07-21T22:26:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b91e6fa9b3bccc1bfd3981668bee3e248e0fcd27","assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/39","html_url":"https://github.com/docker/docker/milestones/1.8.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/39/labels","id":1151952,"number":39,"title":"1.8.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":30,"state":"open","created_at":"2015-06-05T19:27:06Z","updated_at":"2015-07-21T21:23:27Z","due_on":"2015-08-09T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/13711/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/13711/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/13711/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/7e11f01eabd52578aef2851e498a6da886ca738a","head":{"label":"calavera:version_volumes_inspect","ref":"version_volumes_inspect","sha":"7e11f01eabd52578aef2851e498a6da886ca738a","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"repo":{"id":11697698,"name":"docker","full_name":"calavera/docker","owner":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/calavera/docker","description":"Docker - the Linux container runtime","fork":true,"url":"https://api.github.com/repos/calavera/docker","forks_url":"https://api.github.com/repos/calavera/docker/forks","keys_url":"https://api.github.com/repos/calavera/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calavera/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calavera/docker/teams","hooks_url":"https://api.github.com/repos/calavera/docker/hooks","issue_events_url":"https://api.github.com/repos/calavera/docker/issues/events{/number}","events_url":"https://api.github.com/repos/calavera/docker/events","assignees_url":"https://api.github.com/repos/calavera/docker/assignees{/user}","branches_url":"https://api.github.com/repos/calavera/docker/branches{/branch}","tags_url":"https://api.github.com/repos/calavera/docker/tags","blobs_url":"https://api.github.com/repos/calavera/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calavera/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calavera/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/calavera/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calavera/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/calavera/docker/languages","stargazers_url":"https://api.github.com/repos/calavera/docker/stargazers","contributors_url":"https://api.github.com/repos/calavera/docker/contributors","subscribers_url":"https://api.github.com/repos/calavera/docker/subscribers","subscription_url":"https://api.github.com/repos/calavera/docker/subscription","commits_url":"https://api.github.com/repos/calavera/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/calavera/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/calavera/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/calavera/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/calavera/docker/contents/{+path}","compare_url":"https://api.github.com/repos/calavera/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calavera/docker/merges","archive_url":"https://api.github.com/repos/calavera/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calavera/docker/downloads","issues_url":"https://api.github.com/repos/calavera/docker/issues{/number}","pulls_url":"https://api.github.com/repos/calavera/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/calavera/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/calavera/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calavera/docker/labels{/name}","releases_url":"https://api.github.com/repos/calavera/docker/releases{/id}","created_at":"2013-07-27T00:49:52Z","updated_at":"2014-07-24T21:22:23Z","pushed_at":"2015-07-21T20:27:11Z","git_url":"git://github.com/calavera/docker.git","ssh_url":"git@github.com:calavera/docker.git","clone_url":"https://github.com/calavera/docker.git","svn_url":"https://github.com/calavera/docker","homepage":"http://docker.io","size":64120,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"3ee15acaadc3f25c90ea2c4de2e5ab1a12d8e042","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-07-21T22:05:42Z","pushed_at":"2015-07-21T22:24:27Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":228770,"stargazers_count":23428,"watchers_count":23428,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5838,"mirror_url":null,"open_issues_count":1084,"forks":5838,"open_issues":1084,"watchers":23428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/13711"},"html":{"href":"https://github.com/docker/docker/pull/13711"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/13711"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/13711/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/13711/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/13711/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/7e11f01eabd52578aef2851e498a6da886ca738a"}}}}