{"action":"created","comment":{"url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/comments/48477427","id":48477427,"diff_hunk":"@@ -0,0 +1,51 @@\n+#########\n+# Copyright (c) 2015 GigaSpaces Technologies Ltd. All rights reserved\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#       http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+#  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+#  * See the License for the specific language governing permissions and\n+#  * limitations under the License.\n+import os\n+import yaml\n+\n+from watchdog.observers import Observer\n+from watchdog.events import FileSystemEventHandler\n+\n+from flask_securest.userstores import simple","path":"flask_securest/userstores/file_userstore.py","position":21,"original_position":21,"commit_id":"e797fff6affbfb2ab92db4efb9f58868edd204c0","original_commit_id":"e797fff6affbfb2ab92db4efb9f58868edd204c0","user":{"login":"noakup","id":1745412,"avatar_url":"https://avatars.githubusercontent.com/u/1745412?v=3","gravatar_id":"","url":"https://api.github.com/users/noakup","html_url":"https://github.com/noakup","followers_url":"https://api.github.com/users/noakup/followers","following_url":"https://api.github.com/users/noakup/following{/other_user}","gists_url":"https://api.github.com/users/noakup/gists{/gist_id}","starred_url":"https://api.github.com/users/noakup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noakup/subscriptions","organizations_url":"https://api.github.com/users/noakup/orgs","repos_url":"https://api.github.com/users/noakup/repos","events_url":"https://api.github.com/users/noakup/events{/privacy}","received_events_url":"https://api.github.com/users/noakup/received_events","type":"User","site_admin":false},"body":"I think it's more elegant to do:\r\n`from flask_securest.userstores.simple import SimpleUserstore`\r\nand then in your class definition inherit from SimpleUserstore and not simple.SimpleUserstore","created_at":"2015-12-28T12:47:56Z","updated_at":"2015-12-28T12:47:56Z","html_url":"https://github.com/cloudify-cosmo/flask-securest/pull/28#discussion_r48477427","pull_request_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/comments/48477427"},"html":{"href":"https://github.com/cloudify-cosmo/flask-securest/pull/28#discussion_r48477427"},"pull_request":{"href":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/28","id":54624381,"html_url":"https://github.com/cloudify-cosmo/flask-securest/pull/28","diff_url":"https://github.com/cloudify-cosmo/flask-securest/pull/28.diff","patch_url":"https://github.com/cloudify-cosmo/flask-securest/pull/28.patch","issue_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/issues/28","number":28,"state":"open","locked":false,"title":"CFY-3717 add file based userstore","user":{"login":"adamlavie","id":929788,"avatar_url":"https://avatars.githubusercontent.com/u/929788?v=3","gravatar_id":"","url":"https://api.github.com/users/adamlavie","html_url":"https://github.com/adamlavie","followers_url":"https://api.github.com/users/adamlavie/followers","following_url":"https://api.github.com/users/adamlavie/following{/other_user}","gists_url":"https://api.github.com/users/adamlavie/gists{/gist_id}","starred_url":"https://api.github.com/users/adamlavie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamlavie/subscriptions","organizations_url":"https://api.github.com/users/adamlavie/orgs","repos_url":"https://api.github.com/users/adamlavie/repos","events_url":"https://api.github.com/users/adamlavie/events{/privacy}","received_events_url":"https://api.github.com/users/adamlavie/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-27T21:40:08Z","updated_at":"2015-12-28T12:47:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a9a83f844596b8b812b14ed4fbfd150c11d6c09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/28/commits","review_comments_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/28/comments","review_comment_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/issues/28/comments","statuses_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/statuses/e797fff6affbfb2ab92db4efb9f58868edd204c0","head":{"label":"cloudify-cosmo:CFY-3717-active-directory-support","ref":"CFY-3717-active-directory-support","sha":"e797fff6affbfb2ab92db4efb9f58868edd204c0","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":31850163,"name":"flask-securest","full_name":"cloudify-cosmo/flask-securest","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/flask-securest","description":"REST Security implementation for REST Gateway","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/flask-securest","forks_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/releases{/id}","created_at":"2015-03-08T13:13:52Z","updated_at":"2015-09-30T09:25:39Z","pushed_at":"2015-12-28T10:01:56Z","git_url":"git://github.com/cloudify-cosmo/flask-securest.git","ssh_url":"git@github.com:cloudify-cosmo/flask-securest.git","clone_url":"https://github.com/cloudify-cosmo/flask-securest.git","svn_url":"https://github.com/cloudify-cosmo/flask-securest","homepage":null,"size":135,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"cloudify-cosmo:master","ref":"master","sha":"4ed8a1e5fabec0c2255b70dea30ee2373513ed33","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":31850163,"name":"flask-securest","full_name":"cloudify-cosmo/flask-securest","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/flask-securest","description":"REST Security implementation for REST Gateway","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/flask-securest","forks_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/flask-securest/releases{/id}","created_at":"2015-03-08T13:13:52Z","updated_at":"2015-09-30T09:25:39Z","pushed_at":"2015-12-28T10:01:56Z","git_url":"git://github.com/cloudify-cosmo/flask-securest.git","ssh_url":"git@github.com:cloudify-cosmo/flask-securest.git","clone_url":"https://github.com/cloudify-cosmo/flask-securest.git","svn_url":"https://github.com/cloudify-cosmo/flask-securest","homepage":null,"size":135,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/28"},"html":{"href":"https://github.com/cloudify-cosmo/flask-securest/pull/28"},"issue":{"href":"https://api.github.com/repos/cloudify-cosmo/flask-securest/issues/28"},"comments":{"href":"https://api.github.com/repos/cloudify-cosmo/flask-securest/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudify-cosmo/flask-securest/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/cloudify-cosmo/flask-securest/statuses/e797fff6affbfb2ab92db4efb9f58868edd204c0"}}}}