{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/23676856","id":23676856,"diff_hunk":"@@ -109,9 +108,9 @@ protected DefaultDataContainer(int concurrencyLevel, int maxEntries,\n             throw new IllegalArgumentException(\"No such eviction strategy \" + strategy);\n       }\n \n-      entries = new BoundedConcurrentHashMap<K, InternalCacheEntry<K, V>>(maxEntries, concurrencyLevel, eviction, evictionListener,\n-                                                                          keyEquivalence, AnyEquivalence.getInstance());\n-      extendedMap = new BoundedConcurrentExtendedMap();\n+      entries = new BoundedEquivalentConcurrentHashMapV8<K, InternalCacheEntry<K, V>>(\n+            (long) maxEntries, Eviction.LRU, evictionListener, keyEquivalence, AnyEquivalence.getInstance());","path":"core/src/main/java/org/infinispan/container/DefaultDataContainer.java","position":68,"original_position":68,"commit_id":"e97997bc6ccb1a709806af4faaf45ca7696d08b0","original_commit_id":"e97997bc6ccb1a709806af4faaf45ca7696d08b0","user":{"login":"slaskawi","id":8417158,"avatar_url":"https://avatars.githubusercontent.com/u/8417158?v=3","gravatar_id":"","url":"https://api.github.com/users/slaskawi","html_url":"https://github.com/slaskawi","followers_url":"https://api.github.com/users/slaskawi/followers","following_url":"https://api.github.com/users/slaskawi/following{/other_user}","gists_url":"https://api.github.com/users/slaskawi/gists{/gist_id}","starred_url":"https://api.github.com/users/slaskawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaskawi/subscriptions","organizations_url":"https://api.github.com/users/slaskawi/orgs","repos_url":"https://api.github.com/users/slaskawi/repos","events_url":"https://api.github.com/users/slaskawi/events{/privacy}","received_events_url":"https://api.github.com/users/slaskawi/received_events","type":"User","site_admin":false},"body":"Do we need a cast to long?","created_at":"2015-01-28T10:12:33Z","updated_at":"2015-01-28T10:12:33Z","html_url":"https://github.com/infinispan/infinispan/pull/3228#discussion_r23676856","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3228","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/23676856"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3228#discussion_r23676856"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3228"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/3228","id":27869879,"html_url":"https://github.com/infinispan/infinispan/pull/3228","diff_url":"https://github.com/infinispan/infinispan/pull/3228.diff","patch_url":"https://github.com/infinispan/infinispan/pull/3228.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/3228","number":3228,"state":"open","locked":false,"title":"[REVIEW ONLY] Ispn 3023 2","user":{"login":"wburns","id":648175,"avatar_url":"https://avatars.githubusercontent.com/u/648175?v=3","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"body":"Continuation of #3224 \r\n\r\nThis now includes LIRS.  Also I have now assumed I can't unlink head and tail nodes so the first issue hoping to fix will not occur.  LIRS requires recreating some to enable non blocking.\r\n\r\nNew stuff for LIRS:\r\n1. We retain non resident HIR nodes so we can retain recency for evicted entries\r\n2. Size will now work across the entire cluster.\r\n\r\nTODO: need to add more into to this later","created_at":"2015-01-22T19:24:33Z","updated_at":"2015-01-28T10:12:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"865ff5df33de75870a2f1d04076e7c95ef47ea83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3228/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3228/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/{number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/3228/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/e97997bc6ccb1a709806af4faaf45ca7696d08b0","head":{"label":"wburns:ISPN-3023-2","ref":"ISPN-3023-2","sha":"e97997bc6ccb1a709806af4faaf45ca7696d08b0","user":{"login":"wburns","id":648175,"avatar_url":"https://avatars.githubusercontent.com/u/648175?v=3","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"repo":{"id":2681545,"name":"infinispan","full_name":"wburns/infinispan","owner":{"login":"wburns","id":648175,"avatar_url":"https://avatars.githubusercontent.com/u/648175?v=3","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wburns/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/wburns/infinispan","forks_url":"https://api.github.com/repos/wburns/infinispan/forks","keys_url":"https://api.github.com/repos/wburns/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wburns/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wburns/infinispan/teams","hooks_url":"https://api.github.com/repos/wburns/infinispan/hooks","issue_events_url":"https://api.github.com/repos/wburns/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/wburns/infinispan/events","assignees_url":"https://api.github.com/repos/wburns/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/wburns/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/wburns/infinispan/tags","blobs_url":"https://api.github.com/repos/wburns/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wburns/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wburns/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/wburns/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wburns/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/wburns/infinispan/languages","stargazers_url":"https://api.github.com/repos/wburns/infinispan/stargazers","contributors_url":"https://api.github.com/repos/wburns/infinispan/contributors","subscribers_url":"https://api.github.com/repos/wburns/infinispan/subscribers","subscription_url":"https://api.github.com/repos/wburns/infinispan/subscription","commits_url":"https://api.github.com/repos/wburns/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/wburns/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/wburns/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/wburns/infinispan/issues/comments/{number}","contents_url":"https://api.github.com/repos/wburns/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/wburns/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wburns/infinispan/merges","archive_url":"https://api.github.com/repos/wburns/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wburns/infinispan/downloads","issues_url":"https://api.github.com/repos/wburns/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/wburns/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/wburns/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/wburns/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wburns/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/wburns/infinispan/releases{/id}","created_at":"2011-10-31T15:31:04Z","updated_at":"2014-12-23T15:16:21Z","pushed_at":"2015-01-28T00:50:04Z","git_url":"git://github.com/wburns/infinispan.git","ssh_url":"git@github.com:wburns/infinispan.git","clone_url":"https://github.com/wburns/infinispan.git","svn_url":"https://github.com/wburns/infinispan","homepage":"http://www.infinispan.org","size":58784,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"d9783c2aec2008ddfced180c3207106582f5db53","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments/{number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","created_at":"2010-11-04T12:33:19Z","updated_at":"2015-01-27T18:45:17Z","pushed_at":"2015-01-27T18:45:16Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":130611,"stargazers_count":346,"watchers_count":346,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":271,"mirror_url":null,"open_issues_count":11,"forks":271,"open_issues":11,"watchers":346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3228"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3228"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3228"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3228/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3228/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3228/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/e97997bc6ccb1a709806af4faaf45ca7696d08b0"}}}}