{"action":"created","comment":{"url":"https://api.github.com/repos/iojs/io.js/pulls/comments/24251795","id":24251795,"diff_hunk":"@@ -149,6 +149,101 @@ assert.doesNotThrow(makeBlock(a.deepEqual, new String('a'), {0: 'a'}), a.Asserti\n assert.doesNotThrow(makeBlock(a.deepEqual, new Number(1), {}), a.AssertionError);\n assert.doesNotThrow(makeBlock(a.deepEqual, new Boolean(true), {}), a.AssertionError);\n \n+//deepStrictEqual\n+assert.doesNotThrow(makeBlock(a.deepStrictEqual, new Date(2000, 3, 14),\n+                    new Date(2000, 3, 14)), 'deepStrictEqual date');\n+\n+assert.throws(makeBlock(a.deepStrictEqual, new Date(), new Date(2000, 3, 14)),\n+              a.AssertionError,\n+              'deepStrictEqual date');\n+\n+// 7.3 - strict\n+assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/, /a/));\n+assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/g, /a/g));\n+assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/i, /a/i));\n+assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/m, /a/m));\n+assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/igm, /a/igm));\n+assert.throws(makeBlock(a.deepStrictEqual, /ab/, /a/));\n+assert.throws(makeBlock(a.deepStrictEqual, /a/g, /a/));\n+assert.throws(makeBlock(a.deepStrictEqual, /a/i, /a/));\n+assert.throws(makeBlock(a.deepStrictEqual, /a/m, /a/));\n+assert.throws(makeBlock(a.deepStrictEqual, /a/igm, /a/im));\n+\n+var re1 = /a/;\n+re1.lastIndex = 3;\n+assert.throws(makeBlock(a.deepStrictEqual, re1, /a/));\n+\n+\n+// 7.4 - strict\n+assert.throws(makeBlock(a.deepStrictEqual, 4, '4'),\n+              a.AssertionError,\n+              'deepStrictEqual === check');\n+\n+assert.throws(makeBlock(a.deepStrictEqual, true, 1),\n+              a.AssertionError,\n+              'deepStrictEqual === check');\n+\n+assert.throws(makeBlock(a.deepStrictEqual, 4, '5'),\n+              a.AssertionError,\n+              'deepStrictEqual === check');\n+\n+// 7.5 - strict\n+// having the same number of owned properties && the same set of keys\n+assert.doesNotThrow(makeBlock(a.deepStrictEqual, {a: 4}, {a: 4}));\n+assert.doesNotThrow(makeBlock(a.deepStrictEqual, {a: 4, b: '2'}, {a: 4, b: '2'}));\n+assert.throws(makeBlock(a.deepStrictEqual, [4], ['4']));\n+assert.throws(makeBlock(a.deepStrictEqual, {a: 4}, {a: 4, b: true}),\n+              a.AssertionError);\n+assert.throws(makeBlock(a.deepStrictEqual, ['a'], {0: 'a'}));\n+//(although not necessarily the same order),\n+assert.doesNotThrow(makeBlock(a.deepStrictEqual, {a: 4, b: '1'}, {b: '1', a: 4}));\n+var a1 = [1, 2, 3];\n+var a2 = [1, 2, 3];\n+a1.a = 'test';\n+a1.b = true;\n+a2.b = true;\n+a2.a = 'test';\n+assert.throws(makeBlock(a.deepStrictEqual, Object.keys(a1), Object.keys(a2)),\n+              a.AssertionError);","path":"test/parallel/test-assert.js","position":59,"original_position":59,"commit_id":"a45a10433a41cc71413c6f2baf72d84208e0099f","original_commit_id":"a45a10433a41cc71413c6f2baf72d84208e0099f","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"Why is this expected to fail?  Because the keys are in a different order?","created_at":"2015-02-06T16:27:54Z","updated_at":"2015-02-06T16:27:54Z","html_url":"https://github.com/iojs/io.js/pull/639#discussion_r24251795","pull_request_url":"https://api.github.com/repos/iojs/io.js/pulls/639","_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/24251795"},"html":{"href":"https://github.com/iojs/io.js/pull/639#discussion_r24251795"},"pull_request":{"href":"https://api.github.com/repos/iojs/io.js/pulls/639"}}},"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/639","id":28210833,"html_url":"https://github.com/iojs/io.js/pull/639","diff_url":"https://github.com/iojs/io.js/pull/639.diff","patch_url":"https://github.com/iojs/io.js/pull/639.patch","issue_url":"https://api.github.com/repos/iojs/io.js/issues/639","number":639,"state":"open","locked":false,"title":"assert: introduce `deepStrictEqual`","user":{"login":"vkurchatkin","id":2993861,"avatar_url":"https://avatars.githubusercontent.com/u/2993861?v=3","gravatar_id":"","url":"https://api.github.com/users/vkurchatkin","html_url":"https://github.com/vkurchatkin","followers_url":"https://api.github.com/users/vkurchatkin/followers","following_url":"https://api.github.com/users/vkurchatkin/following{/other_user}","gists_url":"https://api.github.com/users/vkurchatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vkurchatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkurchatkin/subscriptions","organizations_url":"https://api.github.com/users/vkurchatkin/orgs","repos_url":"https://api.github.com/users/vkurchatkin/repos","events_url":"https://api.github.com/users/vkurchatkin/events{/privacy}","received_events_url":"https://api.github.com/users/vkurchatkin/received_events","type":"User","site_admin":false},"body":"`deepStrictEqual` works the same way as `strictEqual`, but uses `===` to compare primitives and requires prototypes of equal objects to be the same object.\r\n\r\nFixes: https://github.com/joyent/node/issues/7161\r\n\r\nR=@iojs/collaborators ","created_at":"2015-01-28T17:09:17Z","updated_at":"2015-02-06T16:27:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1e8488335b627d38056851573c2a4434e7ec00e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iojs/io.js/pulls/639/commits","review_comments_url":"https://api.github.com/repos/iojs/io.js/pulls/639/comments","review_comment_url":"https://api.github.com/repos/iojs/io.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/639/comments","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/a45a10433a41cc71413c6f2baf72d84208e0099f","head":{"label":"vkurchatkin:assert-strict-deep","ref":"assert-strict-deep","sha":"a45a10433a41cc71413c6f2baf72d84208e0099f","user":{"login":"vkurchatkin","id":2993861,"avatar_url":"https://avatars.githubusercontent.com/u/2993861?v=3","gravatar_id":"","url":"https://api.github.com/users/vkurchatkin","html_url":"https://github.com/vkurchatkin","followers_url":"https://api.github.com/users/vkurchatkin/followers","following_url":"https://api.github.com/users/vkurchatkin/following{/other_user}","gists_url":"https://api.github.com/users/vkurchatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vkurchatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkurchatkin/subscriptions","organizations_url":"https://api.github.com/users/vkurchatkin/orgs","repos_url":"https://api.github.com/users/vkurchatkin/repos","events_url":"https://api.github.com/users/vkurchatkin/events{/privacy}","received_events_url":"https://api.github.com/users/vkurchatkin/received_events","type":"User","site_admin":false},"repo":{"id":28152690,"name":"io.js","full_name":"vkurchatkin/io.js","owner":{"login":"vkurchatkin","id":2993861,"avatar_url":"https://avatars.githubusercontent.com/u/2993861?v=3","gravatar_id":"","url":"https://api.github.com/users/vkurchatkin","html_url":"https://github.com/vkurchatkin","followers_url":"https://api.github.com/users/vkurchatkin/followers","following_url":"https://api.github.com/users/vkurchatkin/following{/other_user}","gists_url":"https://api.github.com/users/vkurchatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vkurchatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkurchatkin/subscriptions","organizations_url":"https://api.github.com/users/vkurchatkin/orgs","repos_url":"https://api.github.com/users/vkurchatkin/repos","events_url":"https://api.github.com/users/vkurchatkin/events{/privacy}","received_events_url":"https://api.github.com/users/vkurchatkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vkurchatkin/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/vkurchatkin/io.js","forks_url":"https://api.github.com/repos/vkurchatkin/io.js/forks","keys_url":"https://api.github.com/repos/vkurchatkin/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vkurchatkin/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vkurchatkin/io.js/teams","hooks_url":"https://api.github.com/repos/vkurchatkin/io.js/hooks","issue_events_url":"https://api.github.com/repos/vkurchatkin/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/vkurchatkin/io.js/events","assignees_url":"https://api.github.com/repos/vkurchatkin/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/vkurchatkin/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/vkurchatkin/io.js/tags","blobs_url":"https://api.github.com/repos/vkurchatkin/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vkurchatkin/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vkurchatkin/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/vkurchatkin/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vkurchatkin/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/vkurchatkin/io.js/languages","stargazers_url":"https://api.github.com/repos/vkurchatkin/io.js/stargazers","contributors_url":"https://api.github.com/repos/vkurchatkin/io.js/contributors","subscribers_url":"https://api.github.com/repos/vkurchatkin/io.js/subscribers","subscription_url":"https://api.github.com/repos/vkurchatkin/io.js/subscription","commits_url":"https://api.github.com/repos/vkurchatkin/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/vkurchatkin/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/vkurchatkin/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/vkurchatkin/io.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/vkurchatkin/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/vkurchatkin/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vkurchatkin/io.js/merges","archive_url":"https://api.github.com/repos/vkurchatkin/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vkurchatkin/io.js/downloads","issues_url":"https://api.github.com/repos/vkurchatkin/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/vkurchatkin/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/vkurchatkin/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/vkurchatkin/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vkurchatkin/io.js/labels{/name}","releases_url":"https://api.github.com/repos/vkurchatkin/io.js/releases{/id}","created_at":"2014-12-17T19:47:50Z","updated_at":"2014-12-23T18:30:27Z","pushed_at":"2015-02-06T15:56:45Z","git_url":"git://github.com/vkurchatkin/io.js.git","ssh_url":"git@github.com:vkurchatkin/io.js.git","clone_url":"https://github.com/vkurchatkin/io.js.git","svn_url":"https://github.com/vkurchatkin/io.js","homepage":null,"size":119276,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v0.12"}},"base":{"label":"iojs:v1.x","ref":"v1.x","sha":"e7573f9111f6b85c599ec225714d76e08ec8a4dc","user":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"iojs/io.js","owner":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iojs/io.js","description":"A friendly fork of Node.js with an open governance model","fork":false,"url":"https://api.github.com/repos/iojs/io.js","forks_url":"https://api.github.com/repos/iojs/io.js/forks","keys_url":"https://api.github.com/repos/iojs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iojs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iojs/io.js/teams","hooks_url":"https://api.github.com/repos/iojs/io.js/hooks","issue_events_url":"https://api.github.com/repos/iojs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/iojs/io.js/events","assignees_url":"https://api.github.com/repos/iojs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/iojs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/iojs/io.js/tags","blobs_url":"https://api.github.com/repos/iojs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iojs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iojs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/iojs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/iojs/io.js/languages","stargazers_url":"https://api.github.com/repos/iojs/io.js/stargazers","contributors_url":"https://api.github.com/repos/iojs/io.js/contributors","subscribers_url":"https://api.github.com/repos/iojs/io.js/subscribers","subscription_url":"https://api.github.com/repos/iojs/io.js/subscription","commits_url":"https://api.github.com/repos/iojs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/iojs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/iojs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/iojs/io.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/iojs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/iojs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iojs/io.js/merges","archive_url":"https://api.github.com/repos/iojs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iojs/io.js/downloads","issues_url":"https://api.github.com/repos/iojs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/iojs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/iojs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/iojs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iojs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/iojs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-02-06T16:25:42Z","pushed_at":"2015-02-06T15:50:24Z","git_url":"git://github.com/iojs/io.js.git","ssh_url":"git@github.com:iojs/io.js.git","clone_url":"https://github.com/iojs/io.js.git","svn_url":"https://github.com/iojs/io.js","homepage":"https://iojs.org","size":142926,"stargazers_count":9575,"watchers_count":9575,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":568,"mirror_url":null,"open_issues_count":132,"forks":568,"open_issues":132,"watchers":9575,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/639"},"html":{"href":"https://github.com/iojs/io.js/pull/639"},"issue":{"href":"https://api.github.com/repos/iojs/io.js/issues/639"},"comments":{"href":"https://api.github.com/repos/iojs/io.js/issues/639/comments"},"review_comments":{"href":"https://api.github.com/repos/iojs/io.js/pulls/639/comments"},"review_comment":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/iojs/io.js/pulls/639/commits"},"statuses":{"href":"https://api.github.com/repos/iojs/io.js/statuses/a45a10433a41cc71413c6f2baf72d84208e0099f"}}}}