{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/weave/issues/539","labels_url":"https://api.github.com/repos/weaveworks/weave/issues/539/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/539/comments","events_url":"https://api.github.com/repos/weaveworks/weave/issues/539/events","html_url":"https://github.com/weaveworks/weave/pull/539","id":67603511,"number":539,"title":"Make use of -iface flag compulsory","user":{"login":"abligh","id":1240226,"avatar_url":"https://avatars.githubusercontent.com/u/1240226?v=3","gravatar_id":"","url":"https://api.github.com/users/abligh","html_url":"https://github.com/abligh","followers_url":"https://api.github.com/users/abligh/followers","following_url":"https://api.github.com/users/abligh/following{/other_user}","gists_url":"https://api.github.com/users/abligh/gists{/gist_id}","starred_url":"https://api.github.com/users/abligh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abligh/subscriptions","organizations_url":"https://api.github.com/users/abligh/orgs","repos_url":"https://api.github.com/users/abligh/repos","events_url":"https://api.github.com/users/abligh/events{/privacy}","received_events_url":"https://api.github.com/users/abligh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-10T14:04:44Z","updated_at":"2015-04-10T14:09:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/539","html_url":"https://github.com/weaveworks/weave/pull/539","diff_url":"https://github.com/weaveworks/weave/pull/539.diff","patch_url":"https://github.com/weaveworks/weave/pull/539.patch"},"body":"This prevents a nil pointer dereference if (e.g.) weaver is\r\ninvoked with no arguments.\r\n\r\nSigned-off-by: Alex Bligh <alex@alex.org.uk>\r\n\r\nBefore this change:\r\n\r\n    $ weaver/weaver\r\n    weave 2015/04/10 14:54:39.431562 Command line options: map[]\r\n    weave 2015/04/10 14:54:39.431709 Command line peers: []\r\n    panic: runtime error: invalid memory address or nil pointer dereference\r\n    [signal 0xb code=0x1 addr=0x0 pc=0x4034df]\r\n\r\n    goroutine 1 [running]:\r\n    runtime.panic(0x82dc60, 0xfc1a68)\r\n    \t/usr/lib/go/src/pkg/runtime/panic.c:266 +0xb6\r\n    main.main()\r\n    \t/home/amb/weave/weave/weaver/main.go:95 +0x12df\r\n\r\n    goroutine 3 [syscall]:\r\n    os/signal.loop()\r\n    \t/usr/lib/go/src/pkg/os/signal/signal_unix.go:21 +0x1e\r\n    created by os/signal.init·1\r\n\r\nAfter this change:\r\n\r\n    $ weaver/weaver\r\n    weave 2015/04/10 14:59:11.852728 Command line options: map[]\r\n    weave 2015/04/10 14:59:11.853156 Command line peers: []\r\n    weave 2015/04/10 14:59:11.853164 An interface must be specified with -iface\r\n"},"comment":{"url":"https://api.github.com/repos/weaveworks/weave/issues/comments/91570564","html_url":"https://github.com/weaveworks/weave/pull/539#issuecomment-91570564","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/539","id":91570564,"user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"created_at":"2015-04-10T14:09:44Z","updated_at":"2015-04-10T14:09:44Z","body":"No, `-iface` shouldn't be compulsory. You can get around the error by specifying a `-name`."}}