{"action":"created","issue":{"url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1059","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1059/labels{/name}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1059/comments","events_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1059/events","html_url":"https://github.com/paparazzi/paparazzi/pull/1059","id":53215475,"number":1059,"title":"fixes to gcs / flight plan editor","user":{"login":"alonsoac","id":5254018,"avatar_url":"https://avatars.githubusercontent.com/u/5254018?v=3","gravatar_id":"","url":"https://api.github.com/users/alonsoac","html_url":"https://github.com/alonsoac","followers_url":"https://api.github.com/users/alonsoac/followers","following_url":"https://api.github.com/users/alonsoac/following{/other_user}","gists_url":"https://api.github.com/users/alonsoac/gists{/gist_id}","starred_url":"https://api.github.com/users/alonsoac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonsoac/subscriptions","organizations_url":"https://api.github.com/users/alonsoac/orgs","repos_url":"https://api.github.com/users/alonsoac/repos","events_url":"https://api.github.com/users/alonsoac/events{/privacy}","received_events_url":"https://api.github.com/users/alonsoac/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-01T08:13:34Z","updated_at":"2015-01-03T18:56:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1059","html_url":"https://github.com/paparazzi/paparazzi/pull/1059","diff_url":"https://github.com/paparazzi/paparazzi/pull/1059.diff","patch_url":"https://github.com/paparazzi/paparazzi/pull/1059.patch"},"body":"Fixes for issue #927 \r\n\r\n- deleting a wp from Waypoint Edit dialog or from XML editor does not remove the item from the georefs menus\r\n- changing the name of a wp in xml editor or in dialog does not update the menus\r\n- closing a flight plan does not clear the menus\r\n- opening a different plan after closing the first does not work because fit to window keeps trying to fix wp from closed fp\r\n\r\n\r\nOther changes\r\n- keep map center when zooming with the spin button\r\n- When the georef is set to a wp and the mouse is moved to a different UTM zone it would no longer update the distance. Now it shows an error message. TODO: fix so that it works across utm zones.\r\n\r\nNOT Fixed\r\n- creating a new wp by inserting a new xml item or by copying an existing item does not add the wp to the window or the menus\r\n- deleting a wp does not remove it from sectors\r\n- changing the name of a wp does not update the sectors"},"comment":{"url":"https://api.github.com/repos/paparazzi/paparazzi/issues/comments/68605284","html_url":"https://github.com/paparazzi/paparazzi/pull/1059#issuecomment-68605284","issue_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1059","id":68605284,"user":{"login":"flixr","id":104257,"avatar_url":"https://avatars.githubusercontent.com/u/104257?v=3","gravatar_id":"","url":"https://api.github.com/users/flixr","html_url":"https://github.com/flixr","followers_url":"https://api.github.com/users/flixr/followers","following_url":"https://api.github.com/users/flixr/following{/other_user}","gists_url":"https://api.github.com/users/flixr/gists{/gist_id}","starred_url":"https://api.github.com/users/flixr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flixr/subscriptions","organizations_url":"https://api.github.com/users/flixr/orgs","repos_url":"https://api.github.com/users/flixr/repos","events_url":"https://api.github.com/users/flixr/events{/privacy}","received_events_url":"https://api.github.com/users/flixr/received_events","type":"User","site_admin":false},"created_at":"2015-01-03T18:56:33Z","updated_at":"2015-01-03T18:56:33Z","body":"Thx! Really appreciated.\r\nSince @gautierhattenberger knows this stuff a lot better, I hope he can cross-check this and maybe fix some of the remaining ones.\r\n\r\nRegarding style:\r\nCommit style wise it is nicer to have each commit represent a \"logical change\" (where ideally each step compiles) with a good commit message.\r\nCoding style wise it looks ok to me. Only thing I would probably change is to put the added comment in a separate line before instead of at the end... but that is really minor."}}