{"action":"closed","number":2377,"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/2377","id":47860779,"html_url":"https://github.com/pantsbuild/pants/pull/2377","diff_url":"https://github.com/pantsbuild/pants/pull/2377.diff","patch_url":"https://github.com/pantsbuild/pants/pull/2377.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/2377","number":2377,"state":"closed","locked":false,"title":"Minimal Haskell plugin for `pants`","user":{"login":"Gabriel439","id":1313787,"avatar_url":"https://avatars.githubusercontent.com/u/1313787?v=3","gravatar_id":"","url":"https://api.github.com/users/Gabriel439","html_url":"https://github.com/Gabriel439","followers_url":"https://api.github.com/users/Gabriel439/followers","following_url":"https://api.github.com/users/Gabriel439/following{/other_user}","gists_url":"https://api.github.com/users/Gabriel439/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabriel439/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabriel439/subscriptions","organizations_url":"https://api.github.com/users/Gabriel439/orgs","repos_url":"https://api.github.com/users/Gabriel439/repos","events_url":"https://api.github.com/users/Gabriel439/events{/privacy}","received_events_url":"https://api.github.com/users/Gabriel439/received_events","type":"User","site_admin":false},"body":"This is a minimum viable subset of a larger plugin that I have been working on\r\nhere:\r\n\r\nhttps://github.com/pantsbuild/pants/compare/master...Gabriel439:ggonzalez/haskell-plugin\r\n\r\nThe easiest way to review this is to read the `contrib/haskell/README.md` that\r\nthis is included within this change.  You can also view the rendered `README.md`\r\nat:\r\n\r\nhttps://github.com/Gabriel439/pants/blob/ggonzalez/haskell-plugin/contrib/haskell/README.md\r\n\r\nNote that the `README.md` describes the full set of changes that I have already\r\nmade on my larger branch, not just the changes within this review board, but\r\nit's probably better that way since you'll have more context for reviewing this\r\nsmaller change.\r\n\r\nThis change provides:\r\n\r\n* New `pants` targets for Haskell projects\r\n* Support for `./pants build` on these targets\r\n* Example targets\r\n\r\nI wasn't sure whether or not to include the integration tests since @jsirois\r\nasked me to keep this small.  I can expand this review board further to add one\r\nof the integration tests I already wrote if people would like to see that, too.","created_at":"2015-10-16T01:02:05Z","updated_at":"2015-12-02T20:52:28Z","closed_at":"2015-12-02T20:52:28Z","merged_at":null,"merge_commit_sha":"6d85dca4cacce31242d4bb50de99eb95919e1444","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/2377/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/2377/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/2377/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/f9320216718407bb078e7ac1b0be38834e25fa23","head":{"label":"Gabriel439:ggonzalez/haskell-plugin-1","ref":"ggonzalez/haskell-plugin-1","sha":"f9320216718407bb078e7ac1b0be38834e25fa23","user":{"login":"Gabriel439","id":1313787,"avatar_url":"https://avatars.githubusercontent.com/u/1313787?v=3","gravatar_id":"","url":"https://api.github.com/users/Gabriel439","html_url":"https://github.com/Gabriel439","followers_url":"https://api.github.com/users/Gabriel439/followers","following_url":"https://api.github.com/users/Gabriel439/following{/other_user}","gists_url":"https://api.github.com/users/Gabriel439/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabriel439/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabriel439/subscriptions","organizations_url":"https://api.github.com/users/Gabriel439/orgs","repos_url":"https://api.github.com/users/Gabriel439/repos","events_url":"https://api.github.com/users/Gabriel439/events{/privacy}","received_events_url":"https://api.github.com/users/Gabriel439/received_events","type":"User","site_admin":false},"repo":{"id":41609141,"name":"pants","full_name":"Gabriel439/pants","owner":{"login":"Gabriel439","id":1313787,"avatar_url":"https://avatars.githubusercontent.com/u/1313787?v=3","gravatar_id":"","url":"https://api.github.com/users/Gabriel439","html_url":"https://github.com/Gabriel439","followers_url":"https://api.github.com/users/Gabriel439/followers","following_url":"https://api.github.com/users/Gabriel439/following{/other_user}","gists_url":"https://api.github.com/users/Gabriel439/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabriel439/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabriel439/subscriptions","organizations_url":"https://api.github.com/users/Gabriel439/orgs","repos_url":"https://api.github.com/users/Gabriel439/repos","events_url":"https://api.github.com/users/Gabriel439/events{/privacy}","received_events_url":"https://api.github.com/users/Gabriel439/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gabriel439/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/Gabriel439/pants","forks_url":"https://api.github.com/repos/Gabriel439/pants/forks","keys_url":"https://api.github.com/repos/Gabriel439/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gabriel439/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gabriel439/pants/teams","hooks_url":"https://api.github.com/repos/Gabriel439/pants/hooks","issue_events_url":"https://api.github.com/repos/Gabriel439/pants/issues/events{/number}","events_url":"https://api.github.com/repos/Gabriel439/pants/events","assignees_url":"https://api.github.com/repos/Gabriel439/pants/assignees{/user}","branches_url":"https://api.github.com/repos/Gabriel439/pants/branches{/branch}","tags_url":"https://api.github.com/repos/Gabriel439/pants/tags","blobs_url":"https://api.github.com/repos/Gabriel439/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gabriel439/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gabriel439/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gabriel439/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gabriel439/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/Gabriel439/pants/languages","stargazers_url":"https://api.github.com/repos/Gabriel439/pants/stargazers","contributors_url":"https://api.github.com/repos/Gabriel439/pants/contributors","subscribers_url":"https://api.github.com/repos/Gabriel439/pants/subscribers","subscription_url":"https://api.github.com/repos/Gabriel439/pants/subscription","commits_url":"https://api.github.com/repos/Gabriel439/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gabriel439/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gabriel439/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gabriel439/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gabriel439/pants/contents/{+path}","compare_url":"https://api.github.com/repos/Gabriel439/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gabriel439/pants/merges","archive_url":"https://api.github.com/repos/Gabriel439/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gabriel439/pants/downloads","issues_url":"https://api.github.com/repos/Gabriel439/pants/issues{/number}","pulls_url":"https://api.github.com/repos/Gabriel439/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/Gabriel439/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/Gabriel439/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gabriel439/pants/labels{/name}","releases_url":"https://api.github.com/repos/Gabriel439/pants/releases{/id}","created_at":"2015-08-29T22:22:48Z","updated_at":"2015-11-05T14:01:43Z","pushed_at":"2015-12-01T20:00:26Z","git_url":"git://github.com/Gabriel439/pants.git","ssh_url":"git@github.com:Gabriel439/pants.git","clone_url":"https://github.com/Gabriel439/pants.git","svn_url":"https://github.com/Gabriel439/pants","homepage":"http://pantsbuild.github.io/","size":57486,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"d7abc6e7e4ad3571d7ada8b007b11df83ca04eeb","user":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"name":"pants","full_name":"pantsbuild/pants","owner":{"login":"pantsbuild","id":3065172,"avatar_url":"https://avatars.githubusercontent.com/u/3065172?v=3","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantsbuild/pants","description":"Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","created_at":"2012-12-17T17:39:04Z","updated_at":"2015-12-02T09:37:09Z","pushed_at":"2015-12-02T20:22:16Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.github.io/","size":70330,"stargazers_count":449,"watchers_count":449,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":311,"forks":135,"open_issues":311,"watchers":449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2377"},"html":{"href":"https://github.com/pantsbuild/pants/pull/2377"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/2377"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/2377/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2377/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/2377/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/f9320216718407bb078e7ac1b0be38834e25fa23"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":52,"additions":1189,"deletions":9,"changed_files":17}}