{"action":"created","issue":{"url":"https://api.github.com/repos/shaleh/rust-readline/issues/5","labels_url":"https://api.github.com/repos/shaleh/rust-readline/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/shaleh/rust-readline/issues/5/comments","events_url":"https://api.github.com/repos/shaleh/rust-readline/issues/5/events","html_url":"https://github.com/shaleh/rust-readline/pull/5","id":99914445,"number":5,"title":"Allow String as well as &str as arguments","user":{"login":"pornel","id":72159,"avatar_url":"https://avatars.githubusercontent.com/u/72159?v=3","gravatar_id":"","url":"https://api.github.com/users/pornel","html_url":"https://github.com/pornel","followers_url":"https://api.github.com/users/pornel/followers","following_url":"https://api.github.com/users/pornel/following{/other_user}","gists_url":"https://api.github.com/users/pornel/gists{/gist_id}","starred_url":"https://api.github.com/users/pornel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pornel/subscriptions","organizations_url":"https://api.github.com/users/pornel/orgs","repos_url":"https://api.github.com/users/pornel/repos","events_url":"https://api.github.com/users/pornel/events{/privacy}","received_events_url":"https://api.github.com/users/pornel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-09T17:20:49Z","updated_at":"2015-08-10T03:42:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shaleh/rust-readline/pulls/5","html_url":"https://github.com/shaleh/rust-readline/pull/5","diff_url":"https://github.com/shaleh/rust-readline/pull/5.diff","patch_url":"https://github.com/shaleh/rust-readline/pull/5.patch"},"body":"For input use the same type as `CString::new()`, which allows more types (both &str and String)\r\n\r\nIt's a slightly breaking change, because `String.as_ref()` now requires type annotation. I'm not sure if there's a better type that could be used instead."},"comment":{"url":"https://api.github.com/repos/shaleh/rust-readline/issues/comments/129289088","html_url":"https://github.com/shaleh/rust-readline/pull/5#issuecomment-129289088","issue_url":"https://api.github.com/repos/shaleh/rust-readline/issues/5","id":129289088,"user":{"login":"shaleh","id":1377996,"avatar_url":"https://avatars.githubusercontent.com/u/1377996?v=3","gravatar_id":"","url":"https://api.github.com/users/shaleh","html_url":"https://github.com/shaleh","followers_url":"https://api.github.com/users/shaleh/followers","following_url":"https://api.github.com/users/shaleh/following{/other_user}","gists_url":"https://api.github.com/users/shaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/shaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaleh/subscriptions","organizations_url":"https://api.github.com/users/shaleh/orgs","repos_url":"https://api.github.com/users/shaleh/repos","events_url":"https://api.github.com/users/shaleh/events{/privacy}","received_events_url":"https://api.github.com/users/shaleh/received_events","type":"User","site_admin":false},"created_at":"2015-08-10T03:42:26Z","updated_at":"2015-08-10T03:42:26Z","body":"So this is just to allow adding other string types to history? \n\nOn August 9, 2015 10:20:49 AM PDT, Kornel <notifications@github.com> wrote:\n>For input use the same type as `CString::new()`, which allows more\n>types.\n>\n>It's a slightly breaking change, because `String.as_ref()` now requires\n>type annotation. I'm not sure if there's a better type that could be\n>used instead.\n>You can view, comment on, or merge this pull request online at:\n>\n>  https://github.com/shaleh/rust-readline/pull/5\n>\n>-- Commit Summary --\n>\n>  * Allow String as well as &str as arguments\n>\n>-- File Changes --\n>\n>    M src/lib.rs (8)\n>\n>-- Patch Links --\n>\n>https://github.com/shaleh/rust-readline/pull/5.patch\n>https://github.com/shaleh/rust-readline/pull/5.diff\n>\n>---\n>Reply to this email directly or view it on GitHub:\n>https://github.com/shaleh/rust-readline/pull/5\n\n-- \nSent from my Android device with K-9 Mail. Please excuse my brevity."}}