{"action":"created","issue":{"url":"https://api.github.com/repos/lenses/lens-data-table/issues/5","labels_url":"https://api.github.com/repos/lenses/lens-data-table/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/lenses/lens-data-table/issues/5/comments","events_url":"https://api.github.com/repos/lenses/lens-data-table/issues/5/events","html_url":"https://github.com/lenses/lens-data-table/pull/5","id":65775516,"number":5,"title":"Updates + tests, docs, deps, demo","user":{"login":"therewasaguy","id":504124,"avatar_url":"https://avatars.githubusercontent.com/u/504124?v=3","gravatar_id":"","url":"https://api.github.com/users/therewasaguy","html_url":"https://github.com/therewasaguy","followers_url":"https://api.github.com/users/therewasaguy/followers","following_url":"https://api.github.com/users/therewasaguy/following{/other_user}","gists_url":"https://api.github.com/users/therewasaguy/gists{/gist_id}","starred_url":"https://api.github.com/users/therewasaguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therewasaguy/subscriptions","organizations_url":"https://api.github.com/users/therewasaguy/orgs","repos_url":"https://api.github.com/users/therewasaguy/repos","events_url":"https://api.github.com/users/therewasaguy/events{/privacy}","received_events_url":"https://api.github.com/users/therewasaguy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-01T20:45:20Z","updated_at":"2015-04-13T19:30:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lenses/lens-data-table/pulls/5","html_url":"https://github.com/lenses/lens-data-table/pull/5","diff_url":"https://github.com/lenses/lens-data-table/pull/5.diff","patch_url":"https://github.com/lenses/lens-data-table/pull/5.patch"},"body":"Updates:\r\n- turn off resize (which was not working anyway) to avoid errors when handsontable.js tries to parse shadow dom\r\n- fix a bug where only 15 rows showed on init, rather than the specified amount, until a user interaction.\r\n- add _calculateOutput method so there is one place where output gets calculated\r\n- output currentSelection works, and includes proper headers. Outputs entire table if there is no selection.\r\n- can change outputType from 'json' to 'table'\r\n\r\nTO DO:\r\n- ensure that if headers are included with selection, they are not output twice"},"comment":{"url":"https://api.github.com/repos/lenses/lens-data-table/issues/comments/92471016","html_url":"https://github.com/lenses/lens-data-table/pull/5#issuecomment-92471016","issue_url":"https://api.github.com/repos/lenses/lens-data-table/issues/5","id":92471016,"user":{"login":"therewasaguy","id":504124,"avatar_url":"https://avatars.githubusercontent.com/u/504124?v=3","gravatar_id":"","url":"https://api.github.com/users/therewasaguy","html_url":"https://github.com/therewasaguy","followers_url":"https://api.github.com/users/therewasaguy/followers","following_url":"https://api.github.com/users/therewasaguy/following{/other_user}","gists_url":"https://api.github.com/users/therewasaguy/gists{/gist_id}","starred_url":"https://api.github.com/users/therewasaguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therewasaguy/subscriptions","organizations_url":"https://api.github.com/users/therewasaguy/orgs","repos_url":"https://api.github.com/users/therewasaguy/repos","events_url":"https://api.github.com/users/therewasaguy/events{/privacy}","received_events_url":"https://api.github.com/users/therewasaguy/received_events","type":"User","site_admin":false},"created_at":"2015-04-13T19:30:31Z","updated_at":"2015-04-13T19:30:31Z","body":"Oh no! Yes let's discuss, and I will add tests for this.\r\n\r\nThis probably has to do with changes I made to enable selecting output, like [this](https://github.com/therewasaguy/lens-data-table/commit/61d8fc7cd1d84d8d4efcbe0be8f66e8c8af9fefc#diff-8ab12a8502f4c9b6aa088a12d1e2b7ebL392\r\n), and adding headings based on the current selection. "}}