{"action":"created","issue":{"url":"https://api.github.com/repos/yahoo/fetchr/issues/132","labels_url":"https://api.github.com/repos/yahoo/fetchr/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/yahoo/fetchr/issues/132/comments","events_url":"https://api.github.com/repos/yahoo/fetchr/issues/132/events","html_url":"https://github.com/yahoo/fetchr/pull/132","id":119836349,"number":132,"title":"avoid sending undefined params in the uri","user":{"login":"AaronLasseigne","id":297205,"avatar_url":"https://avatars.githubusercontent.com/u/297205?v=3","gravatar_id":"","url":"https://api.github.com/users/AaronLasseigne","html_url":"https://github.com/AaronLasseigne","followers_url":"https://api.github.com/users/AaronLasseigne/followers","following_url":"https://api.github.com/users/AaronLasseigne/following{/other_user}","gists_url":"https://api.github.com/users/AaronLasseigne/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronLasseigne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronLasseigne/subscriptions","organizations_url":"https://api.github.com/users/AaronLasseigne/orgs","repos_url":"https://api.github.com/users/AaronLasseigne/repos","events_url":"https://api.github.com/users/AaronLasseigne/events{/privacy}","received_events_url":"https://api.github.com/users/AaronLasseigne/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/yahoo/fetchr/labels/ready","name":"ready","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-01T23:56:27Z","updated_at":"2015-12-02T00:42:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yahoo/fetchr/pulls/132","html_url":"https://github.com/yahoo/fetchr/pull/132","diff_url":"https://github.com/yahoo/fetchr/pull/132.diff","patch_url":"https://github.com/yahoo/fetchr/pull/132.patch"},"body":"fixes #55 \r\n\r\nParams that are `undefined` are being passed in the uri and then returned as the string `\"undefined\"`. It seems more appropriate to avoid sending any params that are `undefined`."},"comment":{"url":"https://api.github.com/repos/yahoo/fetchr/issues/comments/161142639","html_url":"https://github.com/yahoo/fetchr/pull/132#issuecomment-161142639","issue_url":"https://api.github.com/repos/yahoo/fetchr/issues/132","id":161142639,"user":{"login":"redonkulus","id":193272,"avatar_url":"https://avatars.githubusercontent.com/u/193272?v=3","gravatar_id":"","url":"https://api.github.com/users/redonkulus","html_url":"https://github.com/redonkulus","followers_url":"https://api.github.com/users/redonkulus/followers","following_url":"https://api.github.com/users/redonkulus/following{/other_user}","gists_url":"https://api.github.com/users/redonkulus/gists{/gist_id}","starred_url":"https://api.github.com/users/redonkulus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redonkulus/subscriptions","organizations_url":"https://api.github.com/users/redonkulus/orgs","repos_url":"https://api.github.com/users/redonkulus/repos","events_url":"https://api.github.com/users/redonkulus/events{/privacy}","received_events_url":"https://api.github.com/users/redonkulus/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T00:42:30Z","updated_at":"2015-12-02T00:42:30Z","body":"Seems like it should be fine, I don't know why apps would be relying on query params that are undefined."}}