{"action":"created","issue":{"url":"https://api.github.com/repos/google/flatbuffers/issues/349","labels_url":"https://api.github.com/repos/google/flatbuffers/issues/349/labels{/name}","comments_url":"https://api.github.com/repos/google/flatbuffers/issues/349/comments","events_url":"https://api.github.com/repos/google/flatbuffers/issues/349/events","html_url":"https://github.com/google/flatbuffers/pull/349","id":116899201,"number":349,"title":"Fixes issue #348: C# vector of enums doesn't compile","user":{"login":"belldon","id":1601276,"avatar_url":"https://avatars.githubusercontent.com/u/1601276?v=3","gravatar_id":"","url":"https://api.github.com/users/belldon","html_url":"https://github.com/belldon","followers_url":"https://api.github.com/users/belldon/followers","following_url":"https://api.github.com/users/belldon/following{/other_user}","gists_url":"https://api.github.com/users/belldon/gists{/gist_id}","starred_url":"https://api.github.com/users/belldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belldon/subscriptions","organizations_url":"https://api.github.com/users/belldon/orgs","repos_url":"https://api.github.com/users/belldon/repos","events_url":"https://api.github.com/users/belldon/events{/privacy}","received_events_url":"https://api.github.com/users/belldon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-14T05:28:26Z","updated_at":"2015-11-17T14:26:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/flatbuffers/pulls/349","html_url":"https://github.com/google/flatbuffers/pull/349","diff_url":"https://github.com/google/flatbuffers/pull/349.diff","patch_url":"https://github.com/google/flatbuffers/pull/349.patch"},"body":"The issue has to do with the logic to support C# enum types.  The existing logic to determine when to use an enum type actually winds up catching both the enum case and the vector of enums case, which may have been deliberate.  While it is the desired behavior in some cases, there are some cases where it isn't.\r\n\r\nThe fix tightens the checks where necessary and adds some comments where the original logic was left alone."},"comment":{"url":"https://api.github.com/repos/google/flatbuffers/issues/comments/157385314","html_url":"https://github.com/google/flatbuffers/pull/349#issuecomment-157385314","issue_url":"https://api.github.com/repos/google/flatbuffers/issues/349","id":157385314,"user":{"login":"belldon","id":1601276,"avatar_url":"https://avatars.githubusercontent.com/u/1601276?v=3","gravatar_id":"","url":"https://api.github.com/users/belldon","html_url":"https://github.com/belldon","followers_url":"https://api.github.com/users/belldon/followers","following_url":"https://api.github.com/users/belldon/following{/other_user}","gists_url":"https://api.github.com/users/belldon/gists{/gist_id}","starred_url":"https://api.github.com/users/belldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/belldon/subscriptions","organizations_url":"https://api.github.com/users/belldon/orgs","repos_url":"https://api.github.com/users/belldon/repos","events_url":"https://api.github.com/users/belldon/events{/privacy}","received_events_url":"https://api.github.com/users/belldon/received_events","type":"User","site_admin":false},"created_at":"2015-11-17T14:26:34Z","updated_at":"2015-11-17T14:26:34Z","body":"I missed that, thanks.\r\n\r\nI'm going to take the opportunity to re-work the fix a little bit.  I think I can consolidate a few of the \"get generated type\" functions and make the whole thing a little easier to understand.  "}}