{"action":"created","issue":{"url":"https://api.github.com/repos/forkcms/forkcms/issues/1076","labels_url":"https://api.github.com/repos/forkcms/forkcms/issues/1076/labels{/name}","comments_url":"https://api.github.com/repos/forkcms/forkcms/issues/1076/comments","events_url":"https://api.github.com/repos/forkcms/forkcms/issues/1076/events","html_url":"https://github.com/forkcms/forkcms/pull/1076","id":58286742,"number":1076,"title":"Feature twig","user":{"login":"Thijzer","id":3798321,"avatar_url":"https://avatars.githubusercontent.com/u/3798321?v=3","gravatar_id":"","url":"https://api.github.com/users/Thijzer","html_url":"https://github.com/Thijzer","followers_url":"https://api.github.com/users/Thijzer/followers","following_url":"https://api.github.com/users/Thijzer/following{/other_user}","gists_url":"https://api.github.com/users/Thijzer/gists{/gist_id}","starred_url":"https://api.github.com/users/Thijzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thijzer/subscriptions","organizations_url":"https://api.github.com/users/Thijzer/orgs","repos_url":"https://api.github.com/users/Thijzer/repos","events_url":"https://api.github.com/users/Thijzer/events{/privacy}","received_events_url":"https://api.github.com/users/Thijzer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/forkcms/forkcms/labels/RFC","name":"RFC","color":"fbca04"},{"url":"https://api.github.com/repos/forkcms/forkcms/labels/Symfony%20integration","name":"Symfony integration","color":"e102d8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-02-19T23:21:57Z","updated_at":"2015-02-22T09:52:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/1076","html_url":"https://github.com/forkcms/forkcms/pull/1076","diff_url":"https://github.com/forkcms/forkcms/pull/1076.diff","patch_url":"https://github.com/forkcms/forkcms/pull/1076.patch"},"body":"Okay still a work in progress but I think I'm getting really close to a working solution.\r\nAdded the bootstrap theme with a couple of core example twig files as example.\r\n\r\n* Theme object still has no notion of twig files so if the file tpl and twig is not in the theme folder it will not load.\r\n* no modifiers yet so the navigation is a forced one, I hear @dubgeiser has some work on the modifiers,\r\n* no filters yet it's not required actually but some filters could be handy\r\n* I haven't tested form errors yet\r\n\r\nSome plus sides\r\n\r\n* It's quicker\r\n* it's twig\r\n* less boilerplate\r\n\r\nThis is a large pull request so please mind that not everything is commented yet.\r\n"},"comment":{"url":"https://api.github.com/repos/forkcms/forkcms/issues/comments/75427836","html_url":"https://github.com/forkcms/forkcms/pull/1076#issuecomment-75427836","issue_url":"https://api.github.com/repos/forkcms/forkcms/issues/1076","id":75427836,"user":{"login":"Thijzer","id":3798321,"avatar_url":"https://avatars.githubusercontent.com/u/3798321?v=3","gravatar_id":"","url":"https://api.github.com/users/Thijzer","html_url":"https://github.com/Thijzer","followers_url":"https://api.github.com/users/Thijzer/followers","following_url":"https://api.github.com/users/Thijzer/following{/other_user}","gists_url":"https://api.github.com/users/Thijzer/gists{/gist_id}","starred_url":"https://api.github.com/users/Thijzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thijzer/subscriptions","organizations_url":"https://api.github.com/users/Thijzer/orgs","repos_url":"https://api.github.com/users/Thijzer/repos","events_url":"https://api.github.com/users/Thijzer/events{/privacy}","received_events_url":"https://api.github.com/users/Thijzer/received_events","type":"User","site_admin":false},"created_at":"2015-02-22T09:52:18Z","updated_at":"2015-02-22T09:52:18Z","body":"Navigation is working, \r\nSome of @dubgeiser's work is implemented\r\nThemePath should be working in all situations but needs more testing.\r\n\r\nToDo ::\r\n- not all filters are implemented\r\n- using globals instead of assigned vars\r\n- lots and lots of tpl files to convert\r\n- backend\r\n\r\nI think we are very close to finalising the implementation.\r\nIt's allready working 95% \r\nleaving discussing for further improvements out of this scope.\r\n\r\nside note : Core / Page / parsePositions() is not very useful while using twig."}}