{"action":"opened","number":2527,"pull_request":{"url":"https://api.github.com/repos/enyojs/moonstone/pulls/2527","id":44737036,"html_url":"https://github.com/enyojs/moonstone/pull/2527","diff_url":"https://github.com/enyojs/moonstone/pull/2527.diff","patch_url":"https://github.com/enyojs/moonstone/pull/2527.patch","issue_url":"https://api.github.com/repos/enyojs/moonstone/issues/2527","number":2527,"state":"open","locked":false,"title":"ENYO-2492: Prevent spotting of inactive panels.","user":{"login":"aarontam","id":463191,"avatar_url":"https://avatars.githubusercontent.com/u/463191?v=3","gravatar_id":"","url":"https://api.github.com/users/aarontam","html_url":"https://github.com/aarontam","followers_url":"https://api.github.com/users/aarontam/followers","following_url":"https://api.github.com/users/aarontam/following{/other_user}","gists_url":"https://api.github.com/users/aarontam/gists{/gist_id}","starred_url":"https://api.github.com/users/aarontam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarontam/subscriptions","organizations_url":"https://api.github.com/users/aarontam/orgs","repos_url":"https://api.github.com/users/aarontam/repos","events_url":"https://api.github.com/users/aarontam/events{/privacy}","received_events_url":"https://api.github.com/users/aarontam/received_events","type":"User","site_admin":false},"body":"### Issue\r\nIn the case where we are not caching panels and have declared them via a static components block, for example, inactive panels are still spottable and cause Spotlight focus to effectively be lost.\r\n\r\n### Fix\r\nWe explicitly set the `spotlightDisabled` value accordingly. Technically, Spotlight checks the `showing` property to cover this case, but we had specifically wanted to avoid setting this property and waterfalling the `showingChanged` event, each time. I am open to revisiting this and weighing the pros and cons between the two approaches.\r\n\r\nEnyo-DCO-1.1-Signed-off-by: Aaron Tam <aaron.tam@lge.com>","created_at":"2015-09-11T01:05:47Z","updated_at":"2015-09-11T01:05:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaccea04e49e03488426b8bffb93feb88a95279b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enyojs/moonstone/pulls/2527/commits","review_comments_url":"https://api.github.com/repos/enyojs/moonstone/pulls/2527/comments","review_comment_url":"https://api.github.com/repos/enyojs/moonstone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enyojs/moonstone/issues/2527/comments","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/8a146fe5d55c57855079ac58b0f04a7bea8eeb50","head":{"label":"enyojs:ENYO-2492-aarontam","ref":"ENYO-2492-aarontam","sha":"8a146fe5d55c57855079ac58b0f04a7bea8eeb50","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments{/number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2015-08-11T13:24:58Z","pushed_at":"2015-09-11T01:05:48Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":95542,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":63,"forks":12,"open_issues":63,"watchers":38,"default_branch":"master"}},"base":{"label":"enyojs:2.6.0-dev","ref":"2.6.0-dev","sha":"0db0a8721d95147f34c608ccb4ddd39a8611288c","user":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"repo":{"id":7251076,"name":"moonstone","full_name":"enyojs/moonstone","owner":{"login":"enyojs","id":1266337,"avatar_url":"https://avatars.githubusercontent.com/u/1266337?v=3","gravatar_id":"","url":"https://api.github.com/users/enyojs","html_url":"https://github.com/enyojs","followers_url":"https://api.github.com/users/enyojs/followers","following_url":"https://api.github.com/users/enyojs/following{/other_user}","gists_url":"https://api.github.com/users/enyojs/gists{/gist_id}","starred_url":"https://api.github.com/users/enyojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enyojs/subscriptions","organizations_url":"https://api.github.com/users/enyojs/orgs","repos_url":"https://api.github.com/users/enyojs/repos","events_url":"https://api.github.com/users/enyojs/events{/privacy}","received_events_url":"https://api.github.com/users/enyojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enyojs/moonstone","description":"Moonstone UI library for TV user interfaces.","fork":false,"url":"https://api.github.com/repos/enyojs/moonstone","forks_url":"https://api.github.com/repos/enyojs/moonstone/forks","keys_url":"https://api.github.com/repos/enyojs/moonstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enyojs/moonstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enyojs/moonstone/teams","hooks_url":"https://api.github.com/repos/enyojs/moonstone/hooks","issue_events_url":"https://api.github.com/repos/enyojs/moonstone/issues/events{/number}","events_url":"https://api.github.com/repos/enyojs/moonstone/events","assignees_url":"https://api.github.com/repos/enyojs/moonstone/assignees{/user}","branches_url":"https://api.github.com/repos/enyojs/moonstone/branches{/branch}","tags_url":"https://api.github.com/repos/enyojs/moonstone/tags","blobs_url":"https://api.github.com/repos/enyojs/moonstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enyojs/moonstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enyojs/moonstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/enyojs/moonstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enyojs/moonstone/statuses/{sha}","languages_url":"https://api.github.com/repos/enyojs/moonstone/languages","stargazers_url":"https://api.github.com/repos/enyojs/moonstone/stargazers","contributors_url":"https://api.github.com/repos/enyojs/moonstone/contributors","subscribers_url":"https://api.github.com/repos/enyojs/moonstone/subscribers","subscription_url":"https://api.github.com/repos/enyojs/moonstone/subscription","commits_url":"https://api.github.com/repos/enyojs/moonstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/enyojs/moonstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/enyojs/moonstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/enyojs/moonstone/issues/comments{/number}","contents_url":"https://api.github.com/repos/enyojs/moonstone/contents/{+path}","compare_url":"https://api.github.com/repos/enyojs/moonstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enyojs/moonstone/merges","archive_url":"https://api.github.com/repos/enyojs/moonstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enyojs/moonstone/downloads","issues_url":"https://api.github.com/repos/enyojs/moonstone/issues{/number}","pulls_url":"https://api.github.com/repos/enyojs/moonstone/pulls{/number}","milestones_url":"https://api.github.com/repos/enyojs/moonstone/milestones{/number}","notifications_url":"https://api.github.com/repos/enyojs/moonstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enyojs/moonstone/labels{/name}","releases_url":"https://api.github.com/repos/enyojs/moonstone/releases{/id}","created_at":"2012-12-20T02:41:05Z","updated_at":"2015-08-11T13:24:58Z","pushed_at":"2015-09-11T01:05:48Z","git_url":"git://github.com/enyojs/moonstone.git","ssh_url":"git@github.com:enyojs/moonstone.git","clone_url":"https://github.com/enyojs/moonstone.git","svn_url":"https://github.com/enyojs/moonstone","homepage":"","size":95542,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":63,"forks":12,"open_issues":63,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/2527"},"html":{"href":"https://github.com/enyojs/moonstone/pull/2527"},"issue":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/2527"},"comments":{"href":"https://api.github.com/repos/enyojs/moonstone/issues/2527/comments"},"review_comments":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/2527/comments"},"review_comment":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enyojs/moonstone/pulls/2527/commits"},"statuses":{"href":"https://api.github.com/repos/enyojs/moonstone/statuses/8a146fe5d55c57855079ac58b0f04a7bea8eeb50"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":28,"deletions":0,"changed_files":1}}