{"action":"created","comment":{"url":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/comments/23133341","id":23133341,"diff_hunk":"@@ -16,7 +16,9 @@ public void CanTakeVersionFromReleaseBranch()\n             fixture.Repository.CreateBranch(\"release-2.0.0\");\n             fixture.Repository.Checkout(\"release-2.0.0\");\n \n-            fixture.AssertFullSemver(\"2.0.0-beta.1+5\");\n+            fixture.AssertFullSemver(\"2.0.0-beta.1+0\");","path":"GitVersionCore.Tests/IntegrationTests/GitFlow/ReleaseBranchTests.cs","position":5,"original_position":5,"commit_id":"e0bf106209353f74ad556033b243824c1ef45a05","original_commit_id":"e0bf106209353f74ad556033b243824c1ef45a05","user":{"login":"JakeGinnivan","id":453152,"avatar_url":"https://avatars.githubusercontent.com/u/453152?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeGinnivan","html_url":"https://github.com/JakeGinnivan","followers_url":"https://api.github.com/users/JakeGinnivan/followers","following_url":"https://api.github.com/users/JakeGinnivan/following{/other_user}","gists_url":"https://api.github.com/users/JakeGinnivan/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeGinnivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeGinnivan/subscriptions","organizations_url":"https://api.github.com/users/JakeGinnivan/orgs","repos_url":"https://api.github.com/users/JakeGinnivan/repos","events_url":"https://api.github.com/users/JakeGinnivan/events{/privacy}","received_events_url":"https://api.github.com/users/JakeGinnivan/received_events","type":"User","site_admin":false},"body":"Same here, haven't commited to the release branch yet, so commit count is 0","created_at":"2015-01-18T13:40:48Z","updated_at":"2015-01-18T13:40:48Z","html_url":"https://github.com/ParticularLabs/GitVersion/pull/355#discussion_r23133341","pull_request_url":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/355","_links":{"self":{"href":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/comments/23133341"},"html":{"href":"https://github.com/ParticularLabs/GitVersion/pull/355#discussion_r23133341"},"pull_request":{"href":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/355"}}},"pull_request":{"url":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/355","id":27571360,"html_url":"https://github.com/ParticularLabs/GitVersion/pull/355","diff_url":"https://github.com/ParticularLabs/GitVersion/pull/355.diff","patch_url":"https://github.com/ParticularLabs/GitVersion/pull/355.patch","issue_url":"https://api.github.com/repos/ParticularLabs/GitVersion/issues/355","number":355,"state":"open","locked":false,"title":"Fixing tests","user":{"login":"JakeGinnivan","id":453152,"avatar_url":"https://avatars.githubusercontent.com/u/453152?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeGinnivan","html_url":"https://github.com/JakeGinnivan","followers_url":"https://api.github.com/users/JakeGinnivan/followers","following_url":"https://api.github.com/users/JakeGinnivan/following{/other_user}","gists_url":"https://api.github.com/users/JakeGinnivan/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeGinnivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeGinnivan/subscriptions","organizations_url":"https://api.github.com/users/JakeGinnivan/orgs","repos_url":"https://api.github.com/users/JakeGinnivan/repos","events_url":"https://api.github.com/users/JakeGinnivan/events{/privacy}","received_events_url":"https://api.github.com/users/JakeGinnivan/received_events","type":"User","site_admin":false},"body":"Taking a run at fixing a bunch of the failing tests. All of these tests are mainly failing because of commit counting strategies.\r\n\r\nI have simplified this a great deal (in my mind). GitVersion now uses this basic rule:\r\n\r\n`Count commits from the source of the base version`, if a base version doesn't have a source (say NextVersion from Config) it will use the source from the next base version.\r\n\r\nFor example, if the base version comes from a tag then it will be counted from that tag. If it is from a version in a branch name then it will be number of commits since that branch was created. If it comes a merge message it will count from when that merge was done.\r\n\r\nThe current commit counting confuses me. Would love a decent review of the commit counts in this @andreasohlund @SimonCropp @gep13 @nulltoken if possible :)","created_at":"2015-01-18T13:38:05Z","updated_at":"2015-01-18T13:40:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2b56924da5330e46983f3bd5ee4acaf5820a455","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/355/commits","review_comments_url":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/355/comments","review_comment_url":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ParticularLabs/GitVersion/issues/355/comments","statuses_url":"https://api.github.com/repos/ParticularLabs/GitVersion/statuses/e0bf106209353f74ad556033b243824c1ef45a05","head":{"label":"JakeGinnivan:FixingTests","ref":"FixingTests","sha":"e0bf106209353f74ad556033b243824c1ef45a05","user":{"login":"JakeGinnivan","id":453152,"avatar_url":"https://avatars.githubusercontent.com/u/453152?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeGinnivan","html_url":"https://github.com/JakeGinnivan","followers_url":"https://api.github.com/users/JakeGinnivan/followers","following_url":"https://api.github.com/users/JakeGinnivan/following{/other_user}","gists_url":"https://api.github.com/users/JakeGinnivan/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeGinnivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeGinnivan/subscriptions","organizations_url":"https://api.github.com/users/JakeGinnivan/orgs","repos_url":"https://api.github.com/users/JakeGinnivan/repos","events_url":"https://api.github.com/users/JakeGinnivan/events{/privacy}","received_events_url":"https://api.github.com/users/JakeGinnivan/received_events","type":"User","site_admin":false},"repo":{"id":13254884,"name":"GitVersion","full_name":"JakeGinnivan/GitVersion","owner":{"login":"JakeGinnivan","id":453152,"avatar_url":"https://avatars.githubusercontent.com/u/453152?v=3","gravatar_id":"","url":"https://api.github.com/users/JakeGinnivan","html_url":"https://github.com/JakeGinnivan","followers_url":"https://api.github.com/users/JakeGinnivan/followers","following_url":"https://api.github.com/users/JakeGinnivan/following{/other_user}","gists_url":"https://api.github.com/users/JakeGinnivan/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeGinnivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeGinnivan/subscriptions","organizations_url":"https://api.github.com/users/JakeGinnivan/orgs","repos_url":"https://api.github.com/users/JakeGinnivan/repos","events_url":"https://api.github.com/users/JakeGinnivan/events{/privacy}","received_events_url":"https://api.github.com/users/JakeGinnivan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JakeGinnivan/GitVersion","description":"Use convention to derive a product version from a GitFlow based repository","fork":true,"url":"https://api.github.com/repos/JakeGinnivan/GitVersion","forks_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/forks","keys_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/teams","hooks_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/hooks","issue_events_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/issues/events{/number}","events_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/events","assignees_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/assignees{/user}","branches_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/branches{/branch}","tags_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/tags","blobs_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/git/refs{/sha}","trees_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/statuses/{sha}","languages_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/languages","stargazers_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/stargazers","contributors_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/contributors","subscribers_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/subscribers","subscription_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/subscription","commits_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/commits{/sha}","git_commits_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/git/commits{/sha}","comments_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/comments{/number}","issue_comment_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/issues/comments/{number}","contents_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/contents/{+path}","compare_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/merges","archive_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/downloads","issues_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/issues{/number}","pulls_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/pulls{/number}","milestones_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/milestones{/number}","notifications_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/labels{/name}","releases_url":"https://api.github.com/repos/JakeGinnivan/GitVersion/releases{/id}","created_at":"2013-10-01T20:29:15Z","updated_at":"2015-01-18T11:09:26Z","pushed_at":"2015-01-18T13:33:48Z","git_url":"git://github.com/JakeGinnivan/GitVersion.git","ssh_url":"git@github.com:JakeGinnivan/GitVersion.git","clone_url":"https://github.com/JakeGinnivan/GitVersion.git","svn_url":"https://github.com/JakeGinnivan/GitVersion","homepage":"","size":6256,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ParticularLabs:BranchSpecificConfiguration","ref":"BranchSpecificConfiguration","sha":"85f76fc01a4004367e8c030176bc9b8a2e570865","user":{"login":"ParticularLabs","id":9639057,"avatar_url":"https://avatars.githubusercontent.com/u/9639057?v=3","gravatar_id":"","url":"https://api.github.com/users/ParticularLabs","html_url":"https://github.com/ParticularLabs","followers_url":"https://api.github.com/users/ParticularLabs/followers","following_url":"https://api.github.com/users/ParticularLabs/following{/other_user}","gists_url":"https://api.github.com/users/ParticularLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ParticularLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParticularLabs/subscriptions","organizations_url":"https://api.github.com/users/ParticularLabs/orgs","repos_url":"https://api.github.com/users/ParticularLabs/repos","events_url":"https://api.github.com/users/ParticularLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ParticularLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":12399790,"name":"GitVersion","full_name":"ParticularLabs/GitVersion","owner":{"login":"ParticularLabs","id":9639057,"avatar_url":"https://avatars.githubusercontent.com/u/9639057?v=3","gravatar_id":"","url":"https://api.github.com/users/ParticularLabs","html_url":"https://github.com/ParticularLabs","followers_url":"https://api.github.com/users/ParticularLabs/followers","following_url":"https://api.github.com/users/ParticularLabs/following{/other_user}","gists_url":"https://api.github.com/users/ParticularLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ParticularLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParticularLabs/subscriptions","organizations_url":"https://api.github.com/users/ParticularLabs/orgs","repos_url":"https://api.github.com/users/ParticularLabs/repos","events_url":"https://api.github.com/users/ParticularLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ParticularLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParticularLabs/GitVersion","description":"Use convention to derive a SemVer product version from a GitFlow based repository","fork":false,"url":"https://api.github.com/repos/ParticularLabs/GitVersion","forks_url":"https://api.github.com/repos/ParticularLabs/GitVersion/forks","keys_url":"https://api.github.com/repos/ParticularLabs/GitVersion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParticularLabs/GitVersion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParticularLabs/GitVersion/teams","hooks_url":"https://api.github.com/repos/ParticularLabs/GitVersion/hooks","issue_events_url":"https://api.github.com/repos/ParticularLabs/GitVersion/issues/events{/number}","events_url":"https://api.github.com/repos/ParticularLabs/GitVersion/events","assignees_url":"https://api.github.com/repos/ParticularLabs/GitVersion/assignees{/user}","branches_url":"https://api.github.com/repos/ParticularLabs/GitVersion/branches{/branch}","tags_url":"https://api.github.com/repos/ParticularLabs/GitVersion/tags","blobs_url":"https://api.github.com/repos/ParticularLabs/GitVersion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParticularLabs/GitVersion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParticularLabs/GitVersion/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParticularLabs/GitVersion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParticularLabs/GitVersion/statuses/{sha}","languages_url":"https://api.github.com/repos/ParticularLabs/GitVersion/languages","stargazers_url":"https://api.github.com/repos/ParticularLabs/GitVersion/stargazers","contributors_url":"https://api.github.com/repos/ParticularLabs/GitVersion/contributors","subscribers_url":"https://api.github.com/repos/ParticularLabs/GitVersion/subscribers","subscription_url":"https://api.github.com/repos/ParticularLabs/GitVersion/subscription","commits_url":"https://api.github.com/repos/ParticularLabs/GitVersion/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParticularLabs/GitVersion/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParticularLabs/GitVersion/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParticularLabs/GitVersion/issues/comments/{number}","contents_url":"https://api.github.com/repos/ParticularLabs/GitVersion/contents/{+path}","compare_url":"https://api.github.com/repos/ParticularLabs/GitVersion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParticularLabs/GitVersion/merges","archive_url":"https://api.github.com/repos/ParticularLabs/GitVersion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParticularLabs/GitVersion/downloads","issues_url":"https://api.github.com/repos/ParticularLabs/GitVersion/issues{/number}","pulls_url":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls{/number}","milestones_url":"https://api.github.com/repos/ParticularLabs/GitVersion/milestones{/number}","notifications_url":"https://api.github.com/repos/ParticularLabs/GitVersion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParticularLabs/GitVersion/labels{/name}","releases_url":"https://api.github.com/repos/ParticularLabs/GitVersion/releases{/id}","created_at":"2013-08-27T07:30:20Z","updated_at":"2015-01-17T21:57:03Z","pushed_at":"2015-01-18T11:39:14Z","git_url":"git://github.com/ParticularLabs/GitVersion.git","ssh_url":"git@github.com:ParticularLabs/GitVersion.git","clone_url":"https://github.com/ParticularLabs/GitVersion.git","svn_url":"https://github.com/ParticularLabs/GitVersion","homepage":"http://particularlabs.github.io/GitVersion/","size":7748,"stargazers_count":138,"watchers_count":138,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":52,"forks":46,"open_issues":52,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/355"},"html":{"href":"https://github.com/ParticularLabs/GitVersion/pull/355"},"issue":{"href":"https://api.github.com/repos/ParticularLabs/GitVersion/issues/355"},"comments":{"href":"https://api.github.com/repos/ParticularLabs/GitVersion/issues/355/comments"},"review_comments":{"href":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/355/comments"},"review_comment":{"href":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ParticularLabs/GitVersion/pulls/355/commits"},"statuses":{"href":"https://api.github.com/repos/ParticularLabs/GitVersion/statuses/e0bf106209353f74ad556033b243824c1ef45a05"}}}}