{"action":"created","comment":{"url":"https://api.github.com/repos/meanjs/mean/pulls/comments/35806138","id":35806138,"diff_hunk":"@@ -0,0 +1,7 @@\n+<div class=\"list-group\">\n+    <div data-ng-repeat=\"item in pagedItems\">","path":"modules/core/client/directives/pagination.client.directive.html","position":2,"original_position":2,"commit_id":"b5918e4a26ec9a06ea7791ad17428578a8d6e2b8","original_commit_id":"b5918e4a26ec9a06ea7791ad17428578a8d6e2b8","user":{"login":"mleanos","id":5613734,"avatar_url":"https://avatars.githubusercontent.com/u/5613734?v=3","gravatar_id":"","url":"https://api.github.com/users/mleanos","html_url":"https://github.com/mleanos","followers_url":"https://api.github.com/users/mleanos/followers","following_url":"https://api.github.com/users/mleanos/following{/other_user}","gists_url":"https://api.github.com/users/mleanos/gists{/gist_id}","starred_url":"https://api.github.com/users/mleanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mleanos/subscriptions","organizations_url":"https://api.github.com/users/mleanos/orgs","repos_url":"https://api.github.com/users/mleanos/repos","events_url":"https://api.github.com/users/mleanos/events{/privacy}","received_events_url":"https://api.github.com/users/mleanos/received_events","type":"User","site_admin":false},"body":"+1 on using `track by` \r\n\r\n@ilanbiala I think this is a good idea... using the `limitTo`, in conjunction with the filters and `track by` will enhance the performance. User lists tend to get unwieldy. \r\n\r\n@trainerbill You can use the pagination buttons to mimic a 'scroll' by updating the filter range & offsets based on how the user is interacting with the pagination. ","created_at":"2015-07-29T20:14:57Z","updated_at":"2015-07-29T20:14:57Z","html_url":"https://github.com/meanjs/mean/pull/725#discussion_r35806138","pull_request_url":"https://api.github.com/repos/meanjs/mean/pulls/725","_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments/35806138"},"html":{"href":"https://github.com/meanjs/mean/pull/725#discussion_r35806138"},"pull_request":{"href":"https://api.github.com/repos/meanjs/mean/pulls/725"}}},"pull_request":{"url":"https://api.github.com/repos/meanjs/mean/pulls/725","id":41069373,"html_url":"https://github.com/meanjs/mean/pull/725","diff_url":"https://github.com/meanjs/mean/pull/725.diff","patch_url":"https://github.com/meanjs/mean/pull/725.patch","issue_url":"https://api.github.com/repos/meanjs/mean/issues/725","number":725,"state":"open","locked":false,"title":"Pagination Directive POC","user":{"login":"trainerbill","id":3578259,"avatar_url":"https://avatars.githubusercontent.com/u/3578259?v=3","gravatar_id":"","url":"https://api.github.com/users/trainerbill","html_url":"https://github.com/trainerbill","followers_url":"https://api.github.com/users/trainerbill/followers","following_url":"https://api.github.com/users/trainerbill/following{/other_user}","gists_url":"https://api.github.com/users/trainerbill/gists{/gist_id}","starred_url":"https://api.github.com/users/trainerbill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trainerbill/subscriptions","organizations_url":"https://api.github.com/users/trainerbill/orgs","repos_url":"https://api.github.com/users/trainerbill/repos","events_url":"https://api.github.com/users/trainerbill/events{/privacy}","received_events_url":"https://api.github.com/users/trainerbill/received_events","type":"User","site_admin":false},"body":"Easily create pagination + search capabilities with an array, a view, and a directive.  Cuts out all the function calls in the admin users controller.  Can be used with articles module as well if we want pagination and search capability.","created_at":"2015-07-28T22:41:19Z","updated_at":"2015-07-29T20:14:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffd996d5aba5e064ce4aaa91c5a6414435a060d1","assignee":{"login":"ilanbiala","id":3695164,"avatar_url":"https://avatars.githubusercontent.com/u/3695164?v=3","gravatar_id":"","url":"https://api.github.com/users/ilanbiala","html_url":"https://github.com/ilanbiala","followers_url":"https://api.github.com/users/ilanbiala/followers","following_url":"https://api.github.com/users/ilanbiala/following{/other_user}","gists_url":"https://api.github.com/users/ilanbiala/gists{/gist_id}","starred_url":"https://api.github.com/users/ilanbiala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilanbiala/subscriptions","organizations_url":"https://api.github.com/users/ilanbiala/orgs","repos_url":"https://api.github.com/users/ilanbiala/repos","events_url":"https://api.github.com/users/ilanbiala/events{/privacy}","received_events_url":"https://api.github.com/users/ilanbiala/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/meanjs/mean/pulls/725/commits","review_comments_url":"https://api.github.com/repos/meanjs/mean/pulls/725/comments","review_comment_url":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meanjs/mean/issues/725/comments","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/b5918e4a26ec9a06ea7791ad17428578a8d6e2b8","head":{"label":"trainerbill:PaginationDirective","ref":"PaginationDirective","sha":"b5918e4a26ec9a06ea7791ad17428578a8d6e2b8","user":{"login":"trainerbill","id":3578259,"avatar_url":"https://avatars.githubusercontent.com/u/3578259?v=3","gravatar_id":"","url":"https://api.github.com/users/trainerbill","html_url":"https://github.com/trainerbill","followers_url":"https://api.github.com/users/trainerbill/followers","following_url":"https://api.github.com/users/trainerbill/following{/other_user}","gists_url":"https://api.github.com/users/trainerbill/gists{/gist_id}","starred_url":"https://api.github.com/users/trainerbill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trainerbill/subscriptions","organizations_url":"https://api.github.com/users/trainerbill/orgs","repos_url":"https://api.github.com/users/trainerbill/repos","events_url":"https://api.github.com/users/trainerbill/events{/privacy}","received_events_url":"https://api.github.com/users/trainerbill/received_events","type":"User","site_admin":false},"repo":{"id":35045185,"name":"mean","full_name":"trainerbill/mean","owner":{"login":"trainerbill","id":3578259,"avatar_url":"https://avatars.githubusercontent.com/u/3578259?v=3","gravatar_id":"","url":"https://api.github.com/users/trainerbill","html_url":"https://github.com/trainerbill","followers_url":"https://api.github.com/users/trainerbill/followers","following_url":"https://api.github.com/users/trainerbill/following{/other_user}","gists_url":"https://api.github.com/users/trainerbill/gists{/gist_id}","starred_url":"https://api.github.com/users/trainerbill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trainerbill/subscriptions","organizations_url":"https://api.github.com/users/trainerbill/orgs","repos_url":"https://api.github.com/users/trainerbill/repos","events_url":"https://api.github.com/users/trainerbill/events{/privacy}","received_events_url":"https://api.github.com/users/trainerbill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trainerbill/mean","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js - ","fork":true,"url":"https://api.github.com/repos/trainerbill/mean","forks_url":"https://api.github.com/repos/trainerbill/mean/forks","keys_url":"https://api.github.com/repos/trainerbill/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trainerbill/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trainerbill/mean/teams","hooks_url":"https://api.github.com/repos/trainerbill/mean/hooks","issue_events_url":"https://api.github.com/repos/trainerbill/mean/issues/events{/number}","events_url":"https://api.github.com/repos/trainerbill/mean/events","assignees_url":"https://api.github.com/repos/trainerbill/mean/assignees{/user}","branches_url":"https://api.github.com/repos/trainerbill/mean/branches{/branch}","tags_url":"https://api.github.com/repos/trainerbill/mean/tags","blobs_url":"https://api.github.com/repos/trainerbill/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trainerbill/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trainerbill/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/trainerbill/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trainerbill/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/trainerbill/mean/languages","stargazers_url":"https://api.github.com/repos/trainerbill/mean/stargazers","contributors_url":"https://api.github.com/repos/trainerbill/mean/contributors","subscribers_url":"https://api.github.com/repos/trainerbill/mean/subscribers","subscription_url":"https://api.github.com/repos/trainerbill/mean/subscription","commits_url":"https://api.github.com/repos/trainerbill/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/trainerbill/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/trainerbill/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/trainerbill/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/trainerbill/mean/contents/{+path}","compare_url":"https://api.github.com/repos/trainerbill/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trainerbill/mean/merges","archive_url":"https://api.github.com/repos/trainerbill/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trainerbill/mean/downloads","issues_url":"https://api.github.com/repos/trainerbill/mean/issues{/number}","pulls_url":"https://api.github.com/repos/trainerbill/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/trainerbill/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/trainerbill/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trainerbill/mean/labels{/name}","releases_url":"https://api.github.com/repos/trainerbill/mean/releases{/id}","created_at":"2015-05-04T16:12:38Z","updated_at":"2015-05-04T16:12:39Z","pushed_at":"2015-07-28T23:03:20Z","git_url":"git://github.com/trainerbill/mean.git","ssh_url":"git@github.com:trainerbill/mean.git","clone_url":"https://github.com/trainerbill/mean.git","svn_url":"https://github.com/trainerbill/mean","homepage":"http://meanjs.org","size":2731,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meanjs:0.4.0","ref":"0.4.0","sha":"460ef53aed174cc2277d584150f9c4f815812ee6","user":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"repo":{"id":15508537,"name":"mean","full_name":"meanjs/mean","owner":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meanjs/mean","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js - ","fork":false,"url":"https://api.github.com/repos/meanjs/mean","forks_url":"https://api.github.com/repos/meanjs/mean/forks","keys_url":"https://api.github.com/repos/meanjs/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meanjs/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meanjs/mean/teams","hooks_url":"https://api.github.com/repos/meanjs/mean/hooks","issue_events_url":"https://api.github.com/repos/meanjs/mean/issues/events{/number}","events_url":"https://api.github.com/repos/meanjs/mean/events","assignees_url":"https://api.github.com/repos/meanjs/mean/assignees{/user}","branches_url":"https://api.github.com/repos/meanjs/mean/branches{/branch}","tags_url":"https://api.github.com/repos/meanjs/mean/tags","blobs_url":"https://api.github.com/repos/meanjs/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meanjs/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meanjs/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/meanjs/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/meanjs/mean/languages","stargazers_url":"https://api.github.com/repos/meanjs/mean/stargazers","contributors_url":"https://api.github.com/repos/meanjs/mean/contributors","subscribers_url":"https://api.github.com/repos/meanjs/mean/subscribers","subscription_url":"https://api.github.com/repos/meanjs/mean/subscription","commits_url":"https://api.github.com/repos/meanjs/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/meanjs/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/meanjs/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/meanjs/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/meanjs/mean/contents/{+path}","compare_url":"https://api.github.com/repos/meanjs/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meanjs/mean/merges","archive_url":"https://api.github.com/repos/meanjs/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meanjs/mean/downloads","issues_url":"https://api.github.com/repos/meanjs/mean/issues{/number}","pulls_url":"https://api.github.com/repos/meanjs/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/meanjs/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/meanjs/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meanjs/mean/labels{/name}","releases_url":"https://api.github.com/repos/meanjs/mean/releases{/id}","created_at":"2013-12-29T13:01:15Z","updated_at":"2015-07-29T18:24:05Z","pushed_at":"2015-07-29T20:02:18Z","git_url":"git://github.com/meanjs/mean.git","ssh_url":"git@github.com:meanjs/mean.git","clone_url":"https://github.com/meanjs/mean.git","svn_url":"https://github.com/meanjs/mean","homepage":"http://meanjs.org","size":6526,"stargazers_count":2379,"watchers_count":2379,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":818,"mirror_url":null,"open_issues_count":93,"forks":818,"open_issues":93,"watchers":2379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/725"},"html":{"href":"https://github.com/meanjs/mean/pull/725"},"issue":{"href":"https://api.github.com/repos/meanjs/mean/issues/725"},"comments":{"href":"https://api.github.com/repos/meanjs/mean/issues/725/comments"},"review_comments":{"href":"https://api.github.com/repos/meanjs/mean/pulls/725/comments"},"review_comment":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meanjs/mean/pulls/725/commits"},"statuses":{"href":"https://api.github.com/repos/meanjs/mean/statuses/b5918e4a26ec9a06ea7791ad17428578a8d6e2b8"}}}}