{"action":"created","comment":{"url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments/34958173","id":34958173,"diff_hunk":"@@ -7,12 +7,6 @@\n \n     <parameters>\n         <parameter key=\"cmf_seo.sitemap.controller.class\">Symfony\\Cmf\\Bundle\\SeoBundle\\Controller\\SitemapController</parameter>\n-        <parameter key=\"cmf_seo.sitemap.provider.class\">Symfony\\Cmf\\Bundle\\SeoBundle\\Sitemap\\Provider</parameter>\n-\n-        <parameter key=\"cmf_seo.sitemap.loader_chain.class\">Symfony\\Cmf\\Bundle\\SeoBundle\\Sitemap\\Loader</parameter>\n-        <parameter key=\"cmf_seo.sitemap.guesser.class\">Symfony\\Cmf\\Bundle\\SeoBundle\\Sitemap\\Guesser</parameter>\n-        <parameter key=\"cmf_seo.sitemap.voter_chain.class\">Symfony\\Cmf\\Bundle\\SeoBundle\\Sitemap\\Voter</parameter>\n-        <parameter key=\"cmf_seo.sitemap.phpcr.public_workflow_voter.class\">Symfony\\Cmf\\Bundle\\SeoBundle\\Sitemap\\PublishWorkflowUrlInformationVoter</parameter>","path":"Resources/config/sitemap.xml","position":9,"original_position":9,"commit_id":"be78ea29a93f3e48dac4afee08c12254408222b8","original_commit_id":"be78ea29a93f3e48dac4afee08c12254408222b8","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"having configuration for class is deprecated. imho we should not add new ones anymore. (but keep existing until a major version bump to avoid BC breaks)","created_at":"2015-07-19T13:30:03Z","updated_at":"2015-07-19T13:30:03Z","html_url":"https://github.com/symfony-cmf/SeoBundle/pull/237#discussion_r34958173","pull_request_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/237","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments/34958173"},"html":{"href":"https://github.com/symfony-cmf/SeoBundle/pull/237#discussion_r34958173"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/237"}}},"pull_request":{"url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/237","id":40308176,"html_url":"https://github.com/symfony-cmf/SeoBundle/pull/237","diff_url":"https://github.com/symfony-cmf/SeoBundle/pull/237.diff","patch_url":"https://github.com/symfony-cmf/SeoBundle/pull/237.patch","issue_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/237","number":237,"state":"open","locked":false,"title":"refactoring the sitemap things some more","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"some tests are currently failing, but i ran out of time and would love feedback on the changes i propose before hunting down the last failures and increasing coverage further.","created_at":"2015-07-19T13:26:40Z","updated_at":"2015-07-19T13:30:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1becfd119f03c88d0f3731cd9860cc648cdc3501","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/237/commits","review_comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/237/comments","review_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/237/comments","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/be78ea29a93f3e48dac4afee08c12254408222b8","head":{"label":"symfony-cmf:cleanup-sitemap","ref":"cleanup-sitemap","sha":"be78ea29a93f3e48dac4afee08c12254408222b8","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":16372913,"name":"SeoBundle","full_name":"symfony-cmf/SeoBundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/SeoBundle","description":"A SEO Solution for duplicate contents, page titles, etc.","fork":false,"url":"https://api.github.com/repos/symfony-cmf/SeoBundle","forks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/releases{/id}","created_at":"2014-01-30T09:17:14Z","updated_at":"2015-05-09T12:05:01Z","pushed_at":"2015-07-19T13:26:41Z","git_url":"git://github.com/symfony-cmf/SeoBundle.git","ssh_url":"git@github.com:symfony-cmf/SeoBundle.git","clone_url":"https://github.com/symfony-cmf/SeoBundle.git","svn_url":"https://github.com/symfony-cmf/SeoBundle","homepage":"","size":2854,"stargazers_count":14,"watchers_count":14,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":23,"forks":16,"open_issues":23,"watchers":14,"default_branch":"master"}},"base":{"label":"symfony-cmf:voters-guessers-and-different-sitemaps","ref":"voters-guessers-and-different-sitemaps","sha":"673ad99afcfc0f823fc4100f6d09975e17714519","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":16372913,"name":"SeoBundle","full_name":"symfony-cmf/SeoBundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/SeoBundle","description":"A SEO Solution for duplicate contents, page titles, etc.","fork":false,"url":"https://api.github.com/repos/symfony-cmf/SeoBundle","forks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/SeoBundle/releases{/id}","created_at":"2014-01-30T09:17:14Z","updated_at":"2015-05-09T12:05:01Z","pushed_at":"2015-07-19T13:26:41Z","git_url":"git://github.com/symfony-cmf/SeoBundle.git","ssh_url":"git@github.com:symfony-cmf/SeoBundle.git","clone_url":"https://github.com/symfony-cmf/SeoBundle.git","svn_url":"https://github.com/symfony-cmf/SeoBundle","homepage":"","size":2854,"stargazers_count":14,"watchers_count":14,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":23,"forks":16,"open_issues":23,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/237"},"html":{"href":"https://github.com/symfony-cmf/SeoBundle/pull/237"},"issue":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/237"},"comments":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/issues/237/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/237/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/pulls/237/commits"},"statuses":{"href":"https://api.github.com/repos/symfony-cmf/SeoBundle/statuses/be78ea29a93f3e48dac4afee08c12254408222b8"}}}}