{"comment":{"url":"https://api.github.com/repos/aultuser/Openfire/comments/9749870","html_url":"https://github.com/aultuser/Openfire/commit/1d9686e91f1d11291e672d3f03e90c8ed6429bfe#commitcomment-9749870","id":9749870,"user":{"login":"sco0ter","id":7206462,"avatar_url":"https://avatars.githubusercontent.com/u/7206462?v=3","gravatar_id":"","url":"https://api.github.com/users/sco0ter","html_url":"https://github.com/sco0ter","followers_url":"https://api.github.com/users/sco0ter/followers","following_url":"https://api.github.com/users/sco0ter/following{/other_user}","gists_url":"https://api.github.com/users/sco0ter/gists{/gist_id}","starred_url":"https://api.github.com/users/sco0ter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sco0ter/subscriptions","organizations_url":"https://api.github.com/users/sco0ter/orgs","repos_url":"https://api.github.com/users/sco0ter/repos","events_url":"https://api.github.com/users/sco0ter/events{/privacy}","received_events_url":"https://api.github.com/users/sco0ter/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"1d9686e91f1d11291e672d3f03e90c8ed6429bfe","created_at":"2015-02-14T19:17:29Z","updated_at":"2015-02-14T19:17:29Z","body":"Looks good to me. I can't retrace the full code flow which led to the deadlock, but as a general rule, listeners should never be called from within synchronized blocks, because it's a well known cause for deadlocks."}}