{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/2285","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/2285/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/2285/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/2285/events","html_url":"https://github.com/LMMS/lmms/pull/2285","id":102528905,"number":2285,"title":"PianoRoll: Draw note names on all white keys, highlight white keys","user":{"login":"michaelgregorius","id":9293269,"avatar_url":"https://avatars.githubusercontent.com/u/9293269?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelgregorius","html_url":"https://github.com/michaelgregorius","followers_url":"https://api.github.com/users/michaelgregorius/followers","following_url":"https://api.github.com/users/michaelgregorius/following{/other_user}","gists_url":"https://api.github.com/users/michaelgregorius/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelgregorius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelgregorius/subscriptions","organizations_url":"https://api.github.com/users/michaelgregorius/orgs","repos_url":"https://api.github.com/users/michaelgregorius/repos","events_url":"https://api.github.com/users/michaelgregorius/events{/privacy}","received_events_url":"https://api.github.com/users/michaelgregorius/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-08-22T11:58:35Z","updated_at":"2015-08-23T17:08:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/2285","html_url":"https://github.com/LMMS/lmms/pull/2285","diff_url":"https://github.com/LMMS/lmms/pull/2285.diff","patch_url":"https://github.com/LMMS/lmms/pull/2285.patch"},"body":"Draws note labels on all (white) keys when selecting to do so in the\r\npreferences (\"Enable note labels in piano roll\"). The old rather messy\r\nimplementation that drew them all over the place has been removed.\r\n\r\nFurthermore, the lanes of the white keys are now slightly highlighted in\r\nthe piano roll.\r\n\r\n![pianorollchanges](https://cloud.githubusercontent.com/assets/9293269/9423839/d0ffa2fa-48d5-11e5-8c0e-24c161720627.png)\r\n"},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/133879512","html_url":"https://github.com/LMMS/lmms/pull/2285#issuecomment-133879512","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/2285","id":133879512,"user":{"login":"michaelgregorius","id":9293269,"avatar_url":"https://avatars.githubusercontent.com/u/9293269?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelgregorius","html_url":"https://github.com/michaelgregorius","followers_url":"https://api.github.com/users/michaelgregorius/followers","following_url":"https://api.github.com/users/michaelgregorius/following{/other_user}","gists_url":"https://api.github.com/users/michaelgregorius/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelgregorius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelgregorius/subscriptions","organizations_url":"https://api.github.com/users/michaelgregorius/orgs","repos_url":"https://api.github.com/users/michaelgregorius/repos","events_url":"https://api.github.com/users/michaelgregorius/events{/privacy}","received_events_url":"https://api.github.com/users/michaelgregorius/received_events","type":"User","site_admin":false},"created_at":"2015-08-23T17:08:33Z","updated_at":"2015-08-23T17:08:33Z","body":"@Umcaruje Done! I have created #2286 to document the changes and #2287 to implement them.\r\n\r\n@tresf This is all done using stuff that's already available from Qt! If you look at the code changes you will see that it was a rather low hanging fruit. There is some not so nice code concerning `m_toolBar` from the `Editor` class because I had to override some of the defaults being taken in the `Editor` implementation. I don't think it's a good idea that every `Editor` automatically has some transport controls but for now this does not seem to create any problems (except some headscratching when reading some of the code :wink:)."}}