{"action":"created","comment":{"url":"https://api.github.com/repos/datacratic/soa/pulls/comments/27881254","id":27881254,"diff_hunk":"@@ -157,6 +157,11 @@ parse(const char * value, size_t len, Type type)\n                 unsigned long long val = 0;\n                 for (unsigned i = start;  i != start + len;  ++i) {\n                     int c = p[i];\n+                    if (c >= 65 && c <= 70) {","path":"types/id.cc","position":4,"original_position":4,"commit_id":"d56550860b969b50d25a350927f3d6f02444bded","original_commit_id":"d56550860b969b50d25a350927f3d6f02444bded","user":{"login":"oktal","id":859699,"avatar_url":"https://avatars.githubusercontent.com/u/859699?v=3","gravatar_id":"","url":"https://api.github.com/users/oktal","html_url":"https://github.com/oktal","followers_url":"https://api.github.com/users/oktal/followers","following_url":"https://api.github.com/users/oktal/following{/other_user}","gists_url":"https://api.github.com/users/oktal/gists{/gist_id}","starred_url":"https://api.github.com/users/oktal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktal/subscriptions","organizations_url":"https://api.github.com/users/oktal/orgs","repos_url":"https://api.github.com/users/oktal/repos","events_url":"https://api.github.com/users/oktal/events{/privacy}","received_events_url":"https://api.github.com/users/oktal/received_events","type":"User","site_admin":false},"body":"For more clarity and readability, I would write:\r\n\r\n```cpp\r\nif (c >= 'A' && c <= 'F') {\r\n    ...\r\n}\r\n```\r\n\r\nFor maximum portability, I would check against every character since the standard does not guarantee that 'A' + 1 == 'B' but that's minor, I don't think our goal is to be non-ascii compatible anyway :)","created_at":"2015-04-07T14:15:42Z","updated_at":"2015-04-07T14:15:42Z","html_url":"https://github.com/datacratic/soa/pull/181#discussion_r27881254","pull_request_url":"https://api.github.com/repos/datacratic/soa/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/datacratic/soa/pulls/comments/27881254"},"html":{"href":"https://github.com/datacratic/soa/pull/181#discussion_r27881254"},"pull_request":{"href":"https://api.github.com/repos/datacratic/soa/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/datacratic/soa/pulls/181","id":32559407,"html_url":"https://github.com/datacratic/soa/pull/181","diff_url":"https://github.com/datacratic/soa/pull/181.diff","patch_url":"https://github.com/datacratic/soa/pull/181.patch","issue_url":"https://api.github.com/repos/datacratic/soa/issues/181","number":181,"state":"open","locked":false,"title":"Fix id -> uuid parser","user":{"login":"FinchPowers","id":607566,"avatar_url":"https://avatars.githubusercontent.com/u/607566?v=3","gravatar_id":"","url":"https://api.github.com/users/FinchPowers","html_url":"https://github.com/FinchPowers","followers_url":"https://api.github.com/users/FinchPowers/followers","following_url":"https://api.github.com/users/FinchPowers/following{/other_user}","gists_url":"https://api.github.com/users/FinchPowers/gists{/gist_id}","starred_url":"https://api.github.com/users/FinchPowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinchPowers/subscriptions","organizations_url":"https://api.github.com/users/FinchPowers/orgs","repos_url":"https://api.github.com/users/FinchPowers/repos","events_url":"https://api.github.com/users/FinchPowers/events{/privacy}","received_events_url":"https://api.github.com/users/FinchPowers/received_events","type":"User","site_admin":false},"body":"@jeremybarnes This is potentially dangerous. W/o this fix, it's an issue because parsing uuids containing upper cases dumped them with lower cases.\r\n\r\n@wsourdeau Review too please.","created_at":"2015-04-02T23:19:11Z","updated_at":"2015-04-07T14:15:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9713a2b8349bff8dad8c25518505dac094eec073","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/datacratic/soa/pulls/181/commits","review_comments_url":"https://api.github.com/repos/datacratic/soa/pulls/181/comments","review_comment_url":"https://api.github.com/repos/datacratic/soa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datacratic/soa/issues/181/comments","statuses_url":"https://api.github.com/repos/datacratic/soa/statuses/d56550860b969b50d25a350927f3d6f02444bded","head":{"label":"datacratic:id_uuid_parser_fix","ref":"id_uuid_parser_fix","sha":"d56550860b969b50d25a350927f3d6f02444bded","user":{"login":"datacratic","id":121150,"avatar_url":"https://avatars.githubusercontent.com/u/121150?v=3","gravatar_id":"","url":"https://api.github.com/users/datacratic","html_url":"https://github.com/datacratic","followers_url":"https://api.github.com/users/datacratic/followers","following_url":"https://api.github.com/users/datacratic/following{/other_user}","gists_url":"https://api.github.com/users/datacratic/gists{/gist_id}","starred_url":"https://api.github.com/users/datacratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacratic/subscriptions","organizations_url":"https://api.github.com/users/datacratic/orgs","repos_url":"https://api.github.com/users/datacratic/repos","events_url":"https://api.github.com/users/datacratic/events{/privacy}","received_events_url":"https://api.github.com/users/datacratic/received_events","type":"Organization","site_admin":false},"repo":{"id":8278385,"name":"soa","full_name":"datacratic/soa","owner":{"login":"datacratic","id":121150,"avatar_url":"https://avatars.githubusercontent.com/u/121150?v=3","gravatar_id":"","url":"https://api.github.com/users/datacratic","html_url":"https://github.com/datacratic","followers_url":"https://api.github.com/users/datacratic/followers","following_url":"https://api.github.com/users/datacratic/following{/other_user}","gists_url":"https://api.github.com/users/datacratic/gists{/gist_id}","starred_url":"https://api.github.com/users/datacratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacratic/subscriptions","organizations_url":"https://api.github.com/users/datacratic/orgs","repos_url":"https://api.github.com/users/datacratic/repos","events_url":"https://api.github.com/users/datacratic/events{/privacy}","received_events_url":"https://api.github.com/users/datacratic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datacratic/soa","description":"Repository for service oriented architecture code and components.","fork":false,"url":"https://api.github.com/repos/datacratic/soa","forks_url":"https://api.github.com/repos/datacratic/soa/forks","keys_url":"https://api.github.com/repos/datacratic/soa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datacratic/soa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datacratic/soa/teams","hooks_url":"https://api.github.com/repos/datacratic/soa/hooks","issue_events_url":"https://api.github.com/repos/datacratic/soa/issues/events{/number}","events_url":"https://api.github.com/repos/datacratic/soa/events","assignees_url":"https://api.github.com/repos/datacratic/soa/assignees{/user}","branches_url":"https://api.github.com/repos/datacratic/soa/branches{/branch}","tags_url":"https://api.github.com/repos/datacratic/soa/tags","blobs_url":"https://api.github.com/repos/datacratic/soa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datacratic/soa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datacratic/soa/git/refs{/sha}","trees_url":"https://api.github.com/repos/datacratic/soa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datacratic/soa/statuses/{sha}","languages_url":"https://api.github.com/repos/datacratic/soa/languages","stargazers_url":"https://api.github.com/repos/datacratic/soa/stargazers","contributors_url":"https://api.github.com/repos/datacratic/soa/contributors","subscribers_url":"https://api.github.com/repos/datacratic/soa/subscribers","subscription_url":"https://api.github.com/repos/datacratic/soa/subscription","commits_url":"https://api.github.com/repos/datacratic/soa/commits{/sha}","git_commits_url":"https://api.github.com/repos/datacratic/soa/git/commits{/sha}","comments_url":"https://api.github.com/repos/datacratic/soa/comments{/number}","issue_comment_url":"https://api.github.com/repos/datacratic/soa/issues/comments{/number}","contents_url":"https://api.github.com/repos/datacratic/soa/contents/{+path}","compare_url":"https://api.github.com/repos/datacratic/soa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datacratic/soa/merges","archive_url":"https://api.github.com/repos/datacratic/soa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datacratic/soa/downloads","issues_url":"https://api.github.com/repos/datacratic/soa/issues{/number}","pulls_url":"https://api.github.com/repos/datacratic/soa/pulls{/number}","milestones_url":"https://api.github.com/repos/datacratic/soa/milestones{/number}","notifications_url":"https://api.github.com/repos/datacratic/soa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datacratic/soa/labels{/name}","releases_url":"https://api.github.com/repos/datacratic/soa/releases{/id}","created_at":"2013-02-18T22:13:34Z","updated_at":"2015-03-26T20:20:54Z","pushed_at":"2015-04-06T13:47:07Z","git_url":"git://github.com/datacratic/soa.git","ssh_url":"git@github.com:datacratic/soa.git","clone_url":"https://github.com/datacratic/soa.git","svn_url":"https://github.com/datacratic/soa","homepage":"","size":8658,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":19,"forks":16,"open_issues":19,"watchers":8,"default_branch":"master"}},"base":{"label":"datacratic:master","ref":"master","sha":"45c12e3db43e83691e335e013ca902e9523d9dd7","user":{"login":"datacratic","id":121150,"avatar_url":"https://avatars.githubusercontent.com/u/121150?v=3","gravatar_id":"","url":"https://api.github.com/users/datacratic","html_url":"https://github.com/datacratic","followers_url":"https://api.github.com/users/datacratic/followers","following_url":"https://api.github.com/users/datacratic/following{/other_user}","gists_url":"https://api.github.com/users/datacratic/gists{/gist_id}","starred_url":"https://api.github.com/users/datacratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacratic/subscriptions","organizations_url":"https://api.github.com/users/datacratic/orgs","repos_url":"https://api.github.com/users/datacratic/repos","events_url":"https://api.github.com/users/datacratic/events{/privacy}","received_events_url":"https://api.github.com/users/datacratic/received_events","type":"Organization","site_admin":false},"repo":{"id":8278385,"name":"soa","full_name":"datacratic/soa","owner":{"login":"datacratic","id":121150,"avatar_url":"https://avatars.githubusercontent.com/u/121150?v=3","gravatar_id":"","url":"https://api.github.com/users/datacratic","html_url":"https://github.com/datacratic","followers_url":"https://api.github.com/users/datacratic/followers","following_url":"https://api.github.com/users/datacratic/following{/other_user}","gists_url":"https://api.github.com/users/datacratic/gists{/gist_id}","starred_url":"https://api.github.com/users/datacratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacratic/subscriptions","organizations_url":"https://api.github.com/users/datacratic/orgs","repos_url":"https://api.github.com/users/datacratic/repos","events_url":"https://api.github.com/users/datacratic/events{/privacy}","received_events_url":"https://api.github.com/users/datacratic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datacratic/soa","description":"Repository for service oriented architecture code and components.","fork":false,"url":"https://api.github.com/repos/datacratic/soa","forks_url":"https://api.github.com/repos/datacratic/soa/forks","keys_url":"https://api.github.com/repos/datacratic/soa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datacratic/soa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datacratic/soa/teams","hooks_url":"https://api.github.com/repos/datacratic/soa/hooks","issue_events_url":"https://api.github.com/repos/datacratic/soa/issues/events{/number}","events_url":"https://api.github.com/repos/datacratic/soa/events","assignees_url":"https://api.github.com/repos/datacratic/soa/assignees{/user}","branches_url":"https://api.github.com/repos/datacratic/soa/branches{/branch}","tags_url":"https://api.github.com/repos/datacratic/soa/tags","blobs_url":"https://api.github.com/repos/datacratic/soa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datacratic/soa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datacratic/soa/git/refs{/sha}","trees_url":"https://api.github.com/repos/datacratic/soa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datacratic/soa/statuses/{sha}","languages_url":"https://api.github.com/repos/datacratic/soa/languages","stargazers_url":"https://api.github.com/repos/datacratic/soa/stargazers","contributors_url":"https://api.github.com/repos/datacratic/soa/contributors","subscribers_url":"https://api.github.com/repos/datacratic/soa/subscribers","subscription_url":"https://api.github.com/repos/datacratic/soa/subscription","commits_url":"https://api.github.com/repos/datacratic/soa/commits{/sha}","git_commits_url":"https://api.github.com/repos/datacratic/soa/git/commits{/sha}","comments_url":"https://api.github.com/repos/datacratic/soa/comments{/number}","issue_comment_url":"https://api.github.com/repos/datacratic/soa/issues/comments{/number}","contents_url":"https://api.github.com/repos/datacratic/soa/contents/{+path}","compare_url":"https://api.github.com/repos/datacratic/soa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datacratic/soa/merges","archive_url":"https://api.github.com/repos/datacratic/soa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datacratic/soa/downloads","issues_url":"https://api.github.com/repos/datacratic/soa/issues{/number}","pulls_url":"https://api.github.com/repos/datacratic/soa/pulls{/number}","milestones_url":"https://api.github.com/repos/datacratic/soa/milestones{/number}","notifications_url":"https://api.github.com/repos/datacratic/soa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datacratic/soa/labels{/name}","releases_url":"https://api.github.com/repos/datacratic/soa/releases{/id}","created_at":"2013-02-18T22:13:34Z","updated_at":"2015-03-26T20:20:54Z","pushed_at":"2015-04-06T13:47:07Z","git_url":"git://github.com/datacratic/soa.git","ssh_url":"git@github.com:datacratic/soa.git","clone_url":"https://github.com/datacratic/soa.git","svn_url":"https://github.com/datacratic/soa","homepage":"","size":8658,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":19,"forks":16,"open_issues":19,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datacratic/soa/pulls/181"},"html":{"href":"https://github.com/datacratic/soa/pull/181"},"issue":{"href":"https://api.github.com/repos/datacratic/soa/issues/181"},"comments":{"href":"https://api.github.com/repos/datacratic/soa/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/datacratic/soa/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/datacratic/soa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datacratic/soa/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/datacratic/soa/statuses/d56550860b969b50d25a350927f3d6f02444bded"}}}}