{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/32315153","id":32315153,"diff_hunk":"@@ -475,10 +485,19 @@ PSM_INI\n \tint check_version;\n \tint err;\n \n-\tpsmx_env.name_server\t= psmx_get_int_env(\"OFI_PSM_NAME_SERVER\", 1);\n-\tpsmx_env.am_msg\t\t= psmx_get_int_env(\"OFI_PSM_AM_MSG\", 0);\n-\tpsmx_env.tagged_rma\t= psmx_get_int_env(\"OFI_PSM_TAGGED_RMA\", 1);\n-\tpsmx_env.uuid\t\t= getenv(\"OFI_PSM_UUID\");\n+\tpsmx_env.name_server =\n+\t\tpsmx_get_int_env(\"name_server\",\n+\t\t\t\t\"Whether there is a PSM name server or not\",\n+\t\t\t\t1);\n+\tpsmx_env.am_msg =\n+\t\tpsmx_get_int_env(\"am_msg\",\n+\t\t\t\t\"Whether PSM supports active messages or not\",\n+\t\t\t\t0);\n+\tpsmx_env.tagged_rma =\n+\t\tpsmx_get_int_env(\"tagged_rma\",\n+\t\t\t\t\"Whether PSM supports tagged RMA or not\",","path":"prov/psm/src/psmx_init.c","position":42,"original_position":42,"commit_id":"04598888c6d832eb0317c884531520cb2525a7e0","original_commit_id":"04598888c6d832eb0317c884531520cb2525a7e0","user":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars.githubusercontent.com/u/617316?v=3","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2015-06-12T13:27:05Z","updated_at":"2015-06-12T13:27:05Z","html_url":"https://github.com/ofiwg/libfabric/pull/1055#discussion_r32315153","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1055","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/32315153"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1055#discussion_r32315153"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1055"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1055","id":37204521,"html_url":"https://github.com/ofiwg/libfabric/pull/1055","diff_url":"https://github.com/ofiwg/libfabric/pull/1055.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/1055.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1055","number":1055,"state":"open","locked":false,"title":"RFC: add new var system","user":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars.githubusercontent.com/u/617316?v=3","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"body":"Stop the proliferation of unstandardized environment variables and use a standardized convention.\r\n\r\nThe first commit adds the var system: `fi_var_register()`, `fi_var_get()`, and `fi_var_fini()`.\r\n\r\nThe second commit converts the sockets provider to use the var interface:\r\n* SOCK_PE_WAITTIME -> FI_SOCKETS_PE_WAITTIME\r\n* SOCK_DGRAM_DROP_RATE -> FI_SOCKETS_DGRAM_DROP_RATE\r\n\r\n@jithinjosepkl @shantonu please review\r\n\r\nThe third commit converts the PSM provider to use the var interface (note: I cannot compile/test this commit, and I'm quite sure that my help strings are totally wrong):\r\n* OFI_PSM_NAME_SERVER -> FI_PSM_NAME_SERVER\r\n* OFI_PSM_AM_MSG -> FI_PSM_AM_MSG\r\n* OFI_PSM_TAGGED_RMA -> FI_PSM_TAGGED_RMA\r\n* OFI_PSM_UUID -> FI_PSM_UUID\r\n\r\n@j-xiong please review","created_at":"2015-06-08T22:55:02Z","updated_at":"2015-06-12T13:27:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfa257902e5e55c5b83f487a42497dce55578008","assignee":null,"milestone":{"url":"https://api.github.com/repos/ofiwg/libfabric/milestones/2","html_url":"https://github.com/ofiwg/libfabric/milestones/release%201.0.1","labels_url":"https://api.github.com/repos/ofiwg/libfabric/milestones/2/labels","id":924598,"number":2,"title":"release 1.0.1","description":null,"creator":{"login":"shefty","id":3967608,"avatar_url":"https://avatars.githubusercontent.com/u/3967608?v=3","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":1,"state":"open","created_at":"2015-01-06T22:31:59Z","updated_at":"2015-06-08T22:56:04Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1055/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1055/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1055/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/04598888c6d832eb0317c884531520cb2525a7e0","head":{"label":"jsquyres:pr/env-variable-roundup","ref":"pr/env-variable-roundup","sha":"04598888c6d832eb0317c884531520cb2525a7e0","user":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars.githubusercontent.com/u/617316?v=3","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"repo":{"id":23166404,"name":"libfabric","full_name":"jsquyres/libfabric","owner":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars.githubusercontent.com/u/617316?v=3","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsquyres/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/jsquyres/libfabric","forks_url":"https://api.github.com/repos/jsquyres/libfabric/forks","keys_url":"https://api.github.com/repos/jsquyres/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsquyres/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsquyres/libfabric/teams","hooks_url":"https://api.github.com/repos/jsquyres/libfabric/hooks","issue_events_url":"https://api.github.com/repos/jsquyres/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/jsquyres/libfabric/events","assignees_url":"https://api.github.com/repos/jsquyres/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/jsquyres/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/jsquyres/libfabric/tags","blobs_url":"https://api.github.com/repos/jsquyres/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsquyres/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsquyres/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsquyres/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsquyres/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/jsquyres/libfabric/languages","stargazers_url":"https://api.github.com/repos/jsquyres/libfabric/stargazers","contributors_url":"https://api.github.com/repos/jsquyres/libfabric/contributors","subscribers_url":"https://api.github.com/repos/jsquyres/libfabric/subscribers","subscription_url":"https://api.github.com/repos/jsquyres/libfabric/subscription","commits_url":"https://api.github.com/repos/jsquyres/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsquyres/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsquyres/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsquyres/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsquyres/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/jsquyres/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsquyres/libfabric/merges","archive_url":"https://api.github.com/repos/jsquyres/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsquyres/libfabric/downloads","issues_url":"https://api.github.com/repos/jsquyres/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/jsquyres/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/jsquyres/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/jsquyres/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsquyres/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/jsquyres/libfabric/releases{/id}","created_at":"2014-08-20T22:32:54Z","updated_at":"2014-08-20T22:33:17Z","pushed_at":"2015-06-09T17:56:36Z","git_url":"git://github.com/jsquyres/libfabric.git","ssh_url":"git@github.com:jsquyres/libfabric.git","clone_url":"https://github.com/jsquyres/libfabric.git","svn_url":"https://github.com/jsquyres/libfabric","homepage":null,"size":6561,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"b0fd3a0b97304d4f04311f74c397f921d9c58eb6","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","created_at":"2014-08-15T16:45:53Z","updated_at":"2015-05-29T15:45:17Z","pushed_at":"2015-06-11T23:07:38Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":11265,"stargazers_count":34,"watchers_count":34,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":49,"forks":38,"open_issues":49,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1055"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1055"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1055"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1055/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1055/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1055/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/04598888c6d832eb0317c884531520cb2525a7e0"}}}}