{"action":"created","comment":{"url":"https://api.github.com/repos/torch/image/pulls/comments/43728024","id":43728024,"diff_hunk":"@@ -14,35 +14,65 @@ local function outerProduct(x)\n end\n \n \n+local function assertTensorEq(actual, expected)\n+  if torch.type(expected) == 'torch.ByteTensor' then\n+    local areEqual = torch.eq(actual, expected):all()\n+    tester:assert(areEqual)\n+  else\n+     print(torch.type(expected))","path":"test/test_scale.lua","position":9,"original_position":9,"commit_id":"de335c56433f478ce5034ba8c7857ef6b84a593a","original_commit_id":"de335c56433f478ce5034ba8c7857ef6b84a593a","user":{"login":"deltheil","id":355031,"avatar_url":"https://avatars.githubusercontent.com/u/355031?v=3","gravatar_id":"","url":"https://api.github.com/users/deltheil","html_url":"https://github.com/deltheil","followers_url":"https://api.github.com/users/deltheil/followers","following_url":"https://api.github.com/users/deltheil/following{/other_user}","gists_url":"https://api.github.com/users/deltheil/gists{/gist_id}","starred_url":"https://api.github.com/users/deltheil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deltheil/subscriptions","organizations_url":"https://api.github.com/users/deltheil/orgs","repos_url":"https://api.github.com/users/deltheil/repos","events_url":"https://api.github.com/users/deltheil/events{/privacy}","received_events_url":"https://api.github.com/users/deltheil/received_events","type":"User","site_admin":false},"body":"This should be removed, right?","created_at":"2015-11-03T09:24:54Z","updated_at":"2015-11-03T09:24:54Z","html_url":"https://github.com/torch/image/pull/118#discussion_r43728024","pull_request_url":"https://api.github.com/repos/torch/image/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/torch/image/pulls/comments/43728024"},"html":{"href":"https://github.com/torch/image/pull/118#discussion_r43728024"},"pull_request":{"href":"https://api.github.com/repos/torch/image/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/torch/image/pulls/118","id":49466510,"html_url":"https://github.com/torch/image/pull/118","diff_url":"https://github.com/torch/image/pull/118.diff","patch_url":"https://github.com/torch/image/pull/118.patch","issue_url":"https://api.github.com/repos/torch/image/issues/118","number":118,"state":"open","locked":false,"title":"Fix bug with image.scale 'bicubic' and ByteTensors.","user":{"login":"jagapiou","id":1825314,"avatar_url":"https://avatars.githubusercontent.com/u/1825314?v=3","gravatar_id":"","url":"https://api.github.com/users/jagapiou","html_url":"https://github.com/jagapiou","followers_url":"https://api.github.com/users/jagapiou/followers","following_url":"https://api.github.com/users/jagapiou/following{/other_user}","gists_url":"https://api.github.com/users/jagapiou/gists{/gist_id}","starred_url":"https://api.github.com/users/jagapiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagapiou/subscriptions","organizations_url":"https://api.github.com/users/jagapiou/orgs","repos_url":"https://api.github.com/users/jagapiou/repos","events_url":"https://api.github.com/users/jagapiou/events{/privacy}","received_events_url":"https://api.github.com/users/jagapiou/received_events","type":"User","site_admin":false},"body":"Bicubic interpolation was not working for scaling torch.ByteTensors.\r\n\r\n* Temporary variables were also uint8, made them doubles.\r\n* Added unit tests for ByteTensors.","created_at":"2015-11-02T18:22:24Z","updated_at":"2015-11-03T09:24:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68eb9a72d55b16cabc91adeb828d10572a6d6348","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/torch/image/pulls/118/commits","review_comments_url":"https://api.github.com/repos/torch/image/pulls/118/comments","review_comment_url":"https://api.github.com/repos/torch/image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/torch/image/issues/118/comments","statuses_url":"https://api.github.com/repos/torch/image/statuses/de335c56433f478ce5034ba8c7857ef6b84a593a","head":{"label":"jagapiou:master","ref":"master","sha":"de335c56433f478ce5034ba8c7857ef6b84a593a","user":{"login":"jagapiou","id":1825314,"avatar_url":"https://avatars.githubusercontent.com/u/1825314?v=3","gravatar_id":"","url":"https://api.github.com/users/jagapiou","html_url":"https://github.com/jagapiou","followers_url":"https://api.github.com/users/jagapiou/followers","following_url":"https://api.github.com/users/jagapiou/following{/other_user}","gists_url":"https://api.github.com/users/jagapiou/gists{/gist_id}","starred_url":"https://api.github.com/users/jagapiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagapiou/subscriptions","organizations_url":"https://api.github.com/users/jagapiou/orgs","repos_url":"https://api.github.com/users/jagapiou/repos","events_url":"https://api.github.com/users/jagapiou/events{/privacy}","received_events_url":"https://api.github.com/users/jagapiou/received_events","type":"User","site_admin":false},"repo":{"id":39455227,"name":"image","full_name":"jagapiou/image","owner":{"login":"jagapiou","id":1825314,"avatar_url":"https://avatars.githubusercontent.com/u/1825314?v=3","gravatar_id":"","url":"https://api.github.com/users/jagapiou","html_url":"https://github.com/jagapiou","followers_url":"https://api.github.com/users/jagapiou/followers","following_url":"https://api.github.com/users/jagapiou/following{/other_user}","gists_url":"https://api.github.com/users/jagapiou/gists{/gist_id}","starred_url":"https://api.github.com/users/jagapiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagapiou/subscriptions","organizations_url":"https://api.github.com/users/jagapiou/orgs","repos_url":"https://api.github.com/users/jagapiou/repos","events_url":"https://api.github.com/users/jagapiou/events{/privacy}","received_events_url":"https://api.github.com/users/jagapiou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jagapiou/image","description":"An Image toolbox for Torch.","fork":true,"url":"https://api.github.com/repos/jagapiou/image","forks_url":"https://api.github.com/repos/jagapiou/image/forks","keys_url":"https://api.github.com/repos/jagapiou/image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jagapiou/image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jagapiou/image/teams","hooks_url":"https://api.github.com/repos/jagapiou/image/hooks","issue_events_url":"https://api.github.com/repos/jagapiou/image/issues/events{/number}","events_url":"https://api.github.com/repos/jagapiou/image/events","assignees_url":"https://api.github.com/repos/jagapiou/image/assignees{/user}","branches_url":"https://api.github.com/repos/jagapiou/image/branches{/branch}","tags_url":"https://api.github.com/repos/jagapiou/image/tags","blobs_url":"https://api.github.com/repos/jagapiou/image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jagapiou/image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jagapiou/image/git/refs{/sha}","trees_url":"https://api.github.com/repos/jagapiou/image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jagapiou/image/statuses/{sha}","languages_url":"https://api.github.com/repos/jagapiou/image/languages","stargazers_url":"https://api.github.com/repos/jagapiou/image/stargazers","contributors_url":"https://api.github.com/repos/jagapiou/image/contributors","subscribers_url":"https://api.github.com/repos/jagapiou/image/subscribers","subscription_url":"https://api.github.com/repos/jagapiou/image/subscription","commits_url":"https://api.github.com/repos/jagapiou/image/commits{/sha}","git_commits_url":"https://api.github.com/repos/jagapiou/image/git/commits{/sha}","comments_url":"https://api.github.com/repos/jagapiou/image/comments{/number}","issue_comment_url":"https://api.github.com/repos/jagapiou/image/issues/comments{/number}","contents_url":"https://api.github.com/repos/jagapiou/image/contents/{+path}","compare_url":"https://api.github.com/repos/jagapiou/image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jagapiou/image/merges","archive_url":"https://api.github.com/repos/jagapiou/image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jagapiou/image/downloads","issues_url":"https://api.github.com/repos/jagapiou/image/issues{/number}","pulls_url":"https://api.github.com/repos/jagapiou/image/pulls{/number}","milestones_url":"https://api.github.com/repos/jagapiou/image/milestones{/number}","notifications_url":"https://api.github.com/repos/jagapiou/image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jagapiou/image/labels{/name}","releases_url":"https://api.github.com/repos/jagapiou/image/releases{/id}","created_at":"2015-07-21T15:56:24Z","updated_at":"2015-07-21T15:56:25Z","pushed_at":"2015-11-02T18:20:27Z","git_url":"git://github.com/jagapiou/image.git","ssh_url":"git@github.com:jagapiou/image.git","clone_url":"https://github.com/jagapiou/image.git","svn_url":"https://github.com/jagapiou/image","homepage":null,"size":2140,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"torch:master","ref":"master","sha":"d97d20dbbd836a7801804c667fc1e5c56b2e90f2","user":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"repo":{"id":11313797,"name":"image","full_name":"torch/image","owner":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/torch/image","description":"An Image toolbox for Torch.","fork":false,"url":"https://api.github.com/repos/torch/image","forks_url":"https://api.github.com/repos/torch/image/forks","keys_url":"https://api.github.com/repos/torch/image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torch/image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torch/image/teams","hooks_url":"https://api.github.com/repos/torch/image/hooks","issue_events_url":"https://api.github.com/repos/torch/image/issues/events{/number}","events_url":"https://api.github.com/repos/torch/image/events","assignees_url":"https://api.github.com/repos/torch/image/assignees{/user}","branches_url":"https://api.github.com/repos/torch/image/branches{/branch}","tags_url":"https://api.github.com/repos/torch/image/tags","blobs_url":"https://api.github.com/repos/torch/image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torch/image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torch/image/git/refs{/sha}","trees_url":"https://api.github.com/repos/torch/image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torch/image/statuses/{sha}","languages_url":"https://api.github.com/repos/torch/image/languages","stargazers_url":"https://api.github.com/repos/torch/image/stargazers","contributors_url":"https://api.github.com/repos/torch/image/contributors","subscribers_url":"https://api.github.com/repos/torch/image/subscribers","subscription_url":"https://api.github.com/repos/torch/image/subscription","commits_url":"https://api.github.com/repos/torch/image/commits{/sha}","git_commits_url":"https://api.github.com/repos/torch/image/git/commits{/sha}","comments_url":"https://api.github.com/repos/torch/image/comments{/number}","issue_comment_url":"https://api.github.com/repos/torch/image/issues/comments{/number}","contents_url":"https://api.github.com/repos/torch/image/contents/{+path}","compare_url":"https://api.github.com/repos/torch/image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torch/image/merges","archive_url":"https://api.github.com/repos/torch/image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torch/image/downloads","issues_url":"https://api.github.com/repos/torch/image/issues{/number}","pulls_url":"https://api.github.com/repos/torch/image/pulls{/number}","milestones_url":"https://api.github.com/repos/torch/image/milestones{/number}","notifications_url":"https://api.github.com/repos/torch/image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torch/image/labels{/name}","releases_url":"https://api.github.com/repos/torch/image/releases{/id}","created_at":"2013-07-10T14:12:09Z","updated_at":"2015-11-01T06:39:17Z","pushed_at":"2015-11-02T18:22:24Z","git_url":"git://github.com/torch/image.git","ssh_url":"git@github.com:torch/image.git","clone_url":"https://github.com/torch/image.git","svn_url":"https://github.com/torch/image","homepage":null,"size":2957,"stargazers_count":42,"watchers_count":42,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":6,"forks":58,"open_issues":6,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/torch/image/pulls/118"},"html":{"href":"https://github.com/torch/image/pull/118"},"issue":{"href":"https://api.github.com/repos/torch/image/issues/118"},"comments":{"href":"https://api.github.com/repos/torch/image/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/torch/image/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/torch/image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/torch/image/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/torch/image/statuses/de335c56433f478ce5034ba8c7857ef6b84a593a"}}}}