{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/580","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/580/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/580/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/580/events","html_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/580","id":56077624,"number":580,"title":"Add python 3.4","user":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/labels/datastore","name":"datastore","color":"0052cc"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/labels/storage","name":"storage","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-01-30T19:58:52Z","updated_at":"2015-02-04T19:54:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/pulls/580","html_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/580","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/580.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/580.patch"},"body":"Default 'tox' all passes with this branch, including 'py34'.\r\n\r\nNotes:\r\n\r\n- Pre-applies changes from https://github.com/craigcitro/apitools/pull/15 into vendored tree.\r\n- Adds (but doesn't enable by default) a 'tox -e regression3' target.  Those tests are currently failing."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/comments/72926017","html_url":"https://github.com/GoogleCloudPlatform/gcloud-python/pull/580#issuecomment-72926017","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-python/issues/580","id":72926017,"user":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T19:54:08Z","updated_at":"2015-02-04T19:54:08Z","body":"> Can you git merge --squash into a fresh checkout from master?\r\n\r\nNow squashed.\r\n\r\n> The protobuf people have renamed 3.0.0-alpha1 -> 3.0.0-alpha-1 (try tox --recreate to see)\r\n\r\nI tried, and didn't see failures.  https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/49500349 passes without it (I'm pretty sure it doesn't reuse environments).  0e99cea updates it just in case.\r\n\r\n> Though pylint is annoying when we get cut on sharp corners, I am not a fan of abandoning our policy of disallowed pylint: disable statements. I spent a TON of time getting us to a point where we didn't need them. I made a few small changes to make this possible: dhermes@4cf536e\r\n\r\nThis isn't a \"sharp corner\" due to a difference of opinion, it is a known bug in pylint.  Please see [this\r\ngist](https://gist.github.com/tseaver/adac94c24aedde278b15), showing the changes I'm trying to make to accomodate your wishes, and the new linting errors they introduce.  We are objectively making the code harder to read / understand in order to appease brokenness in the tool:  this is a case where disabling the tool *is* the Right Thing(TM).\r\n\r\n> Why are we checking in `gcloud/datastore/_datastore_v1.proto`? I assume you have it because the new version of protobuf required regenerating `gcloud/datastore/_datastore_v1_pb2.py`.\r\n\r\nYes, and I envision regenerating it whenever we pick up new versions of `protobuf` (to ensure that we match the expectations of the library from the generated code).  It is also much better \"local\" documentation than the generated module.\r\n\r\n> I tracked down the reason for the oauth2client failures in the bug you filed and will take a stab.\r\n\r\nCool.\r\n\r\n>  I assume you left the protobuf pinned dependency out of setup.py since we can't endorse py34 yet? (We can't endorse until regression3 passes, which can't happen until google/oauth2client#125 is fixed.)\r\n\r\nI'd really like them to get 3.0.0 to a \"final\" release, or at least a feature-frozen / API stable beta:  I'm uncomfortable with us depending so strongly on an alpha."}}