{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/46672736","id":46672736,"diff_hunk":"@@ -1197,6 +1197,10 @@ public Network createGuestNetwork(CreateNetworkCmd cmd) throws InsufficientCapac\n             }\n \n             if (gateway != null && netmask != null) {\n+                if(!NetUtils.isNetworkorBroadcastIP(gateway,netmask)) {\n+                    s_logger.debug(\"The gateway IP provided is \"+ gateway + \" and netmask is \"+ netmask + \". The IP is either broadcast or network IP.\");","path":"server/src/com/cloud/network/NetworkServiceImpl.java","position":5,"original_position":5,"commit_id":"27b40e761a398565b1e2a1947c6ba8634c497e40","original_commit_id":"27b40e761a398565b1e2a1947c6ba8634c497e40","user":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars.githubusercontent.com/u/2486961?v=3","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"body":"maybe you can change the name of the static object to LOGGER while you are at it?","created_at":"2015-12-04T11:27:29Z","updated_at":"2015-12-04T11:27:29Z","html_url":"https://github.com/apache/cloudstack/pull/1125#discussion_r46672736","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/1125","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/46672736"},"html":{"href":"https://github.com/apache/cloudstack/pull/1125#discussion_r46672736"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1125"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/1125","id":51888491,"html_url":"https://github.com/apache/cloudstack/pull/1125","diff_url":"https://github.com/apache/cloudstack/pull/1125.diff","patch_url":"https://github.com/apache/cloudstack/pull/1125.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/1125","number":1125,"state":"open","locked":false,"title":"CLOUDSTACK-9086: ACS allows to create isolated networks with invalid …","user":{"login":"kansal","id":4276209,"avatar_url":"https://avatars.githubusercontent.com/u/4276209?v=3","gravatar_id":"","url":"https://api.github.com/users/kansal","html_url":"https://github.com/kansal","followers_url":"https://api.github.com/users/kansal/followers","following_url":"https://api.github.com/users/kansal/following{/other_user}","gists_url":"https://api.github.com/users/kansal/gists{/gist_id}","starred_url":"https://api.github.com/users/kansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kansal/subscriptions","organizations_url":"https://api.github.com/users/kansal/orgs","repos_url":"https://api.github.com/users/kansal/repos","events_url":"https://api.github.com/users/kansal/events{/privacy}","received_events_url":"https://api.github.com/users/kansal/received_events","type":"User","site_admin":false},"body":"…gateway IP address - Fixed\r\n\r\nProblem: There was no check for the network and broadcast IP addresses in the case where we provide the gateway and netmask while creating the isolated network. As a result the provided IP gets assigned to the eth0 interface of the VR.\r\n\r\nFix: Added the necessary checks.","created_at":"2015-11-26T09:23:04Z","updated_at":"2015-12-04T11:27:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"874349c27305a46968380bdc5b1e675c9673936f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/1125/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/1125/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/1125/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/27b40e761a398565b1e2a1947c6ba8634c497e40","head":{"label":"kansal:CLOUDSTACK-9086","ref":"CLOUDSTACK-9086","sha":"27b40e761a398565b1e2a1947c6ba8634c497e40","user":{"login":"kansal","id":4276209,"avatar_url":"https://avatars.githubusercontent.com/u/4276209?v=3","gravatar_id":"","url":"https://api.github.com/users/kansal","html_url":"https://github.com/kansal","followers_url":"https://api.github.com/users/kansal/followers","following_url":"https://api.github.com/users/kansal/following{/other_user}","gists_url":"https://api.github.com/users/kansal/gists{/gist_id}","starred_url":"https://api.github.com/users/kansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kansal/subscriptions","organizations_url":"https://api.github.com/users/kansal/orgs","repos_url":"https://api.github.com/users/kansal/repos","events_url":"https://api.github.com/users/kansal/events{/privacy}","received_events_url":"https://api.github.com/users/kansal/received_events","type":"User","site_admin":false},"repo":{"id":39490442,"name":"cloudstack","full_name":"kansal/cloudstack","owner":{"login":"kansal","id":4276209,"avatar_url":"https://avatars.githubusercontent.com/u/4276209?v=3","gravatar_id":"","url":"https://api.github.com/users/kansal","html_url":"https://github.com/kansal","followers_url":"https://api.github.com/users/kansal/followers","following_url":"https://api.github.com/users/kansal/following{/other_user}","gists_url":"https://api.github.com/users/kansal/gists{/gist_id}","starred_url":"https://api.github.com/users/kansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kansal/subscriptions","organizations_url":"https://api.github.com/users/kansal/orgs","repos_url":"https://api.github.com/users/kansal/repos","events_url":"https://api.github.com/users/kansal/events{/privacy}","received_events_url":"https://api.github.com/users/kansal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kansal/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/kansal/cloudstack","forks_url":"https://api.github.com/repos/kansal/cloudstack/forks","keys_url":"https://api.github.com/repos/kansal/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kansal/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kansal/cloudstack/teams","hooks_url":"https://api.github.com/repos/kansal/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/kansal/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/kansal/cloudstack/events","assignees_url":"https://api.github.com/repos/kansal/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/kansal/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/kansal/cloudstack/tags","blobs_url":"https://api.github.com/repos/kansal/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kansal/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kansal/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/kansal/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kansal/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/kansal/cloudstack/languages","stargazers_url":"https://api.github.com/repos/kansal/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/kansal/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/kansal/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/kansal/cloudstack/subscription","commits_url":"https://api.github.com/repos/kansal/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/kansal/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/kansal/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/kansal/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/kansal/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/kansal/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kansal/cloudstack/merges","archive_url":"https://api.github.com/repos/kansal/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kansal/cloudstack/downloads","issues_url":"https://api.github.com/repos/kansal/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/kansal/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/kansal/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/kansal/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kansal/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/kansal/cloudstack/releases{/id}","created_at":"2015-07-22T06:50:43Z","updated_at":"2015-07-22T06:51:05Z","pushed_at":"2015-12-02T12:40:16Z","git_url":"git://github.com/kansal/cloudstack.git","ssh_url":"git@github.com:kansal/cloudstack.git","clone_url":"https://github.com/kansal/cloudstack.git","svn_url":"https://github.com/kansal/cloudstack","homepage":null,"size":498216,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"45fa8ffb200ad5819b3a0be9274a5eea35cb6382","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-12-02T15:08:25Z","pushed_at":"2015-12-04T10:06:01Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":506813,"stargazers_count":321,"watchers_count":321,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":413,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":145,"forks":413,"open_issues":145,"watchers":321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1125"},"html":{"href":"https://github.com/apache/cloudstack/pull/1125"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/1125"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/1125/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1125/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1125/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/27b40e761a398565b1e2a1947c6ba8634c497e40"}}}}