{"action":"created","comment":{"url":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/comments/25077397","id":25077397,"diff_hunk":"@@ -67,6 +67,24 @@ extern NSString *const MDMIndpendentManagedObjectContextDidSaveNotification;\n - (id)initWithStoreURL:(NSURL *)storeURL modelURL:(NSURL *)modelURL;\n \n /**\n+ Returns an inMemory backed persistence controller initialized with the given arguments.\n+ \n+ @param model A managed object model.\n+ \n+ @return A new persistence controller object with an inMemoryStore type with model.\n+ */\n+- (id)initInMemoryTypeWithModel:(NSManagedObjectModel *)model;","path":"Classes/MDMPersistenceController/MDMPersistenceController.h","position":28,"original_position":28,"commit_id":"9d845172742b48562be866874a317c438877e5ef","original_commit_id":"9d845172742b48562be866874a317c438877e5ef","user":{"login":"mattglover","id":1572886,"avatar_url":"https://avatars.githubusercontent.com/u/1572886?v=3","gravatar_id":"","url":"https://api.github.com/users/mattglover","html_url":"https://github.com/mattglover","followers_url":"https://api.github.com/users/mattglover/followers","following_url":"https://api.github.com/users/mattglover/following{/other_user}","gists_url":"https://api.github.com/users/mattglover/gists{/gist_id}","starred_url":"https://api.github.com/users/mattglover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattglover/subscriptions","organizations_url":"https://api.github.com/users/mattglover/orgs","repos_url":"https://api.github.com/users/mattglover/repos","events_url":"https://api.github.com/users/mattglover/events{/privacy}","received_events_url":"https://api.github.com/users/mattglover/received_events","type":"User","site_admin":false},"body":"Yes, I think so .. now might be a good opportunity to update the init signature(s)","created_at":"2015-02-20T15:37:21Z","updated_at":"2015-02-20T15:37:21Z","html_url":"https://github.com/mmorey/MDMCoreData/pull/33#discussion_r25077397","pull_request_url":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/comments/25077397"},"html":{"href":"https://github.com/mmorey/MDMCoreData/pull/33#discussion_r25077397"},"pull_request":{"href":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/33","id":29271736,"html_url":"https://github.com/mmorey/MDMCoreData/pull/33","diff_url":"https://github.com/mmorey/MDMCoreData/pull/33.diff","patch_url":"https://github.com/mmorey/MDMCoreData/pull/33.patch","issue_url":"https://api.github.com/repos/mmorey/MDMCoreData/issues/33","number":33,"state":"open","locked":false,"title":"NSInMemoryStoreType option","user":{"login":"mattglover","id":1572886,"avatar_url":"https://avatars.githubusercontent.com/u/1572886?v=3","gravatar_id":"","url":"https://api.github.com/users/mattglover","html_url":"https://github.com/mattglover","followers_url":"https://api.github.com/users/mattglover/followers","following_url":"https://api.github.com/users/mattglover/following{/other_user}","gists_url":"https://api.github.com/users/mattglover/gists{/gist_id}","starred_url":"https://api.github.com/users/mattglover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattglover/subscriptions","organizations_url":"https://api.github.com/users/mattglover/orgs","repos_url":"https://api.github.com/users/mattglover/repos","events_url":"https://api.github.com/users/mattglover/events{/privacy}","received_events_url":"https://api.github.com/users/mattglover/received_events","type":"User","site_admin":false},"body":"@mmorey, @tLewisII and contributing team\r\n\r\nDuring my latest project, I found I would setup and teardown a persistenceController quite a number of times to thoroughly test a Core Data backed application. Using mocks would have been ok, but I really wanted to lean on the features that CD provides.\r\nWith this in mind .. and wanting to keep my test run-time as low as possible ... I thought using an InMemoryStoreType would be more efficient than hitting the disk for an SQLite file.\r\n\r\n#### MDMPersistenceController API\r\nNot wanting to make any breaking changes to the existing interface, I added a 2 new initializers to the MDMPersistenceController API to allow for creating an inMemoryStoreType.\r\nI've tried to mimic the functionality of the existing default (`SQLite`) initializers.\r\n\r\n```objc\r\n- (id)initInMemoryTypeWithModel:(NSManagedObjectModel *)model\r\n```\r\n```objc\r\n- (id)initInMemoryTypeWithModelURL:(NSURL *)modelURL\r\n```\r\n\r\n\r\n\r\n\r\n*Before I pursue this, I wanted to get your thoughts .. is this feature necessary or does it complicate things ?*\r\n","created_at":"2015-02-13T15:16:38Z","updated_at":"2015-02-20T15:37:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f7894ba40f4a7eed0d78faaf95956fc46b38928","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/33/commits","review_comments_url":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/33/comments","review_comment_url":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mmorey/MDMCoreData/issues/33/comments","statuses_url":"https://api.github.com/repos/mmorey/MDMCoreData/statuses/9d845172742b48562be866874a317c438877e5ef","head":{"label":"mattglover:master","ref":"master","sha":"9d845172742b48562be866874a317c438877e5ef","user":{"login":"mattglover","id":1572886,"avatar_url":"https://avatars.githubusercontent.com/u/1572886?v=3","gravatar_id":"","url":"https://api.github.com/users/mattglover","html_url":"https://github.com/mattglover","followers_url":"https://api.github.com/users/mattglover/followers","following_url":"https://api.github.com/users/mattglover/following{/other_user}","gists_url":"https://api.github.com/users/mattglover/gists{/gist_id}","starred_url":"https://api.github.com/users/mattglover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattglover/subscriptions","organizations_url":"https://api.github.com/users/mattglover/orgs","repos_url":"https://api.github.com/users/mattglover/repos","events_url":"https://api.github.com/users/mattglover/events{/privacy}","received_events_url":"https://api.github.com/users/mattglover/received_events","type":"User","site_admin":false},"repo":{"id":30748488,"name":"MDMCoreData","full_name":"mattglover/MDMCoreData","owner":{"login":"mattglover","id":1572886,"avatar_url":"https://avatars.githubusercontent.com/u/1572886?v=3","gravatar_id":"","url":"https://api.github.com/users/mattglover","html_url":"https://github.com/mattglover","followers_url":"https://api.github.com/users/mattglover/followers","following_url":"https://api.github.com/users/mattglover/following{/other_user}","gists_url":"https://api.github.com/users/mattglover/gists{/gist_id}","starred_url":"https://api.github.com/users/mattglover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattglover/subscriptions","organizations_url":"https://api.github.com/users/mattglover/orgs","repos_url":"https://api.github.com/users/mattglover/repos","events_url":"https://api.github.com/users/mattglover/events{/privacy}","received_events_url":"https://api.github.com/users/mattglover/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattglover/MDMCoreData","description":"A collection of lightweight Core Data classes for iOS and OS X.","fork":true,"url":"https://api.github.com/repos/mattglover/MDMCoreData","forks_url":"https://api.github.com/repos/mattglover/MDMCoreData/forks","keys_url":"https://api.github.com/repos/mattglover/MDMCoreData/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattglover/MDMCoreData/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattglover/MDMCoreData/teams","hooks_url":"https://api.github.com/repos/mattglover/MDMCoreData/hooks","issue_events_url":"https://api.github.com/repos/mattglover/MDMCoreData/issues/events{/number}","events_url":"https://api.github.com/repos/mattglover/MDMCoreData/events","assignees_url":"https://api.github.com/repos/mattglover/MDMCoreData/assignees{/user}","branches_url":"https://api.github.com/repos/mattglover/MDMCoreData/branches{/branch}","tags_url":"https://api.github.com/repos/mattglover/MDMCoreData/tags","blobs_url":"https://api.github.com/repos/mattglover/MDMCoreData/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattglover/MDMCoreData/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattglover/MDMCoreData/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattglover/MDMCoreData/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattglover/MDMCoreData/statuses/{sha}","languages_url":"https://api.github.com/repos/mattglover/MDMCoreData/languages","stargazers_url":"https://api.github.com/repos/mattglover/MDMCoreData/stargazers","contributors_url":"https://api.github.com/repos/mattglover/MDMCoreData/contributors","subscribers_url":"https://api.github.com/repos/mattglover/MDMCoreData/subscribers","subscription_url":"https://api.github.com/repos/mattglover/MDMCoreData/subscription","commits_url":"https://api.github.com/repos/mattglover/MDMCoreData/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattglover/MDMCoreData/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattglover/MDMCoreData/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattglover/MDMCoreData/issues/comments/{number}","contents_url":"https://api.github.com/repos/mattglover/MDMCoreData/contents/{+path}","compare_url":"https://api.github.com/repos/mattglover/MDMCoreData/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattglover/MDMCoreData/merges","archive_url":"https://api.github.com/repos/mattglover/MDMCoreData/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattglover/MDMCoreData/downloads","issues_url":"https://api.github.com/repos/mattglover/MDMCoreData/issues{/number}","pulls_url":"https://api.github.com/repos/mattglover/MDMCoreData/pulls{/number}","milestones_url":"https://api.github.com/repos/mattglover/MDMCoreData/milestones{/number}","notifications_url":"https://api.github.com/repos/mattglover/MDMCoreData/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattglover/MDMCoreData/labels{/name}","releases_url":"https://api.github.com/repos/mattglover/MDMCoreData/releases{/id}","created_at":"2015-02-13T09:01:33Z","updated_at":"2015-02-13T09:54:53Z","pushed_at":"2015-02-13T09:54:53Z","git_url":"git://github.com/mattglover/MDMCoreData.git","ssh_url":"git@github.com:mattglover/MDMCoreData.git","clone_url":"https://github.com/mattglover/MDMCoreData.git","svn_url":"https://github.com/mattglover/MDMCoreData","homepage":"","size":1183,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mmorey:master","ref":"master","sha":"7f39bd315a4ccf9e1fff604278d93a7e731e326d","user":{"login":"mmorey","id":251031,"avatar_url":"https://avatars.githubusercontent.com/u/251031?v=3","gravatar_id":"","url":"https://api.github.com/users/mmorey","html_url":"https://github.com/mmorey","followers_url":"https://api.github.com/users/mmorey/followers","following_url":"https://api.github.com/users/mmorey/following{/other_user}","gists_url":"https://api.github.com/users/mmorey/gists{/gist_id}","starred_url":"https://api.github.com/users/mmorey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmorey/subscriptions","organizations_url":"https://api.github.com/users/mmorey/orgs","repos_url":"https://api.github.com/users/mmorey/repos","events_url":"https://api.github.com/users/mmorey/events{/privacy}","received_events_url":"https://api.github.com/users/mmorey/received_events","type":"User","site_admin":false},"repo":{"id":16670204,"name":"MDMCoreData","full_name":"mmorey/MDMCoreData","owner":{"login":"mmorey","id":251031,"avatar_url":"https://avatars.githubusercontent.com/u/251031?v=3","gravatar_id":"","url":"https://api.github.com/users/mmorey","html_url":"https://github.com/mmorey","followers_url":"https://api.github.com/users/mmorey/followers","following_url":"https://api.github.com/users/mmorey/following{/other_user}","gists_url":"https://api.github.com/users/mmorey/gists{/gist_id}","starred_url":"https://api.github.com/users/mmorey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmorey/subscriptions","organizations_url":"https://api.github.com/users/mmorey/orgs","repos_url":"https://api.github.com/users/mmorey/repos","events_url":"https://api.github.com/users/mmorey/events{/privacy}","received_events_url":"https://api.github.com/users/mmorey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmorey/MDMCoreData","description":"A collection of lightweight Core Data classes for iOS and OS X.","fork":false,"url":"https://api.github.com/repos/mmorey/MDMCoreData","forks_url":"https://api.github.com/repos/mmorey/MDMCoreData/forks","keys_url":"https://api.github.com/repos/mmorey/MDMCoreData/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmorey/MDMCoreData/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmorey/MDMCoreData/teams","hooks_url":"https://api.github.com/repos/mmorey/MDMCoreData/hooks","issue_events_url":"https://api.github.com/repos/mmorey/MDMCoreData/issues/events{/number}","events_url":"https://api.github.com/repos/mmorey/MDMCoreData/events","assignees_url":"https://api.github.com/repos/mmorey/MDMCoreData/assignees{/user}","branches_url":"https://api.github.com/repos/mmorey/MDMCoreData/branches{/branch}","tags_url":"https://api.github.com/repos/mmorey/MDMCoreData/tags","blobs_url":"https://api.github.com/repos/mmorey/MDMCoreData/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmorey/MDMCoreData/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmorey/MDMCoreData/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmorey/MDMCoreData/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmorey/MDMCoreData/statuses/{sha}","languages_url":"https://api.github.com/repos/mmorey/MDMCoreData/languages","stargazers_url":"https://api.github.com/repos/mmorey/MDMCoreData/stargazers","contributors_url":"https://api.github.com/repos/mmorey/MDMCoreData/contributors","subscribers_url":"https://api.github.com/repos/mmorey/MDMCoreData/subscribers","subscription_url":"https://api.github.com/repos/mmorey/MDMCoreData/subscription","commits_url":"https://api.github.com/repos/mmorey/MDMCoreData/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmorey/MDMCoreData/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmorey/MDMCoreData/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmorey/MDMCoreData/issues/comments/{number}","contents_url":"https://api.github.com/repos/mmorey/MDMCoreData/contents/{+path}","compare_url":"https://api.github.com/repos/mmorey/MDMCoreData/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmorey/MDMCoreData/merges","archive_url":"https://api.github.com/repos/mmorey/MDMCoreData/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmorey/MDMCoreData/downloads","issues_url":"https://api.github.com/repos/mmorey/MDMCoreData/issues{/number}","pulls_url":"https://api.github.com/repos/mmorey/MDMCoreData/pulls{/number}","milestones_url":"https://api.github.com/repos/mmorey/MDMCoreData/milestones{/number}","notifications_url":"https://api.github.com/repos/mmorey/MDMCoreData/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmorey/MDMCoreData/labels{/name}","releases_url":"https://api.github.com/repos/mmorey/MDMCoreData/releases{/id}","created_at":"2014-02-09T16:36:20Z","updated_at":"2015-02-18T22:22:09Z","pushed_at":"2015-02-11T00:15:19Z","git_url":"git://github.com/mmorey/MDMCoreData.git","ssh_url":"git@github.com:mmorey/MDMCoreData.git","clone_url":"https://github.com/mmorey/MDMCoreData.git","svn_url":"https://github.com/mmorey/MDMCoreData","homepage":"","size":4161,"stargazers_count":223,"watchers_count":223,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":3,"forks":31,"open_issues":3,"watchers":223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/33"},"html":{"href":"https://github.com/mmorey/MDMCoreData/pull/33"},"issue":{"href":"https://api.github.com/repos/mmorey/MDMCoreData/issues/33"},"comments":{"href":"https://api.github.com/repos/mmorey/MDMCoreData/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mmorey/MDMCoreData/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/mmorey/MDMCoreData/statuses/9d845172742b48562be866874a317c438877e5ef"}}}}