{"action":"created","issue":{"url":"https://api.github.com/repos/zeromq/pyzmq/issues/656","labels_url":"https://api.github.com/repos/zeromq/pyzmq/issues/656/labels{/name}","comments_url":"https://api.github.com/repos/zeromq/pyzmq/issues/656/comments","events_url":"https://api.github.com/repos/zeromq/pyzmq/issues/656/events","html_url":"https://github.com/zeromq/pyzmq/pull/656","id":60190905,"number":656,"title":"Adds support for building libsodium on Windows.","user":{"login":"AndreLouisCaron","id":135974,"avatar_url":"https://avatars.githubusercontent.com/u/135974?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreLouisCaron","html_url":"https://github.com/AndreLouisCaron","followers_url":"https://api.github.com/users/AndreLouisCaron/followers","following_url":"https://api.github.com/users/AndreLouisCaron/following{/other_user}","gists_url":"https://api.github.com/users/AndreLouisCaron/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreLouisCaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreLouisCaron/subscriptions","organizations_url":"https://api.github.com/users/AndreLouisCaron/orgs","repos_url":"https://api.github.com/users/AndreLouisCaron/repos","events_url":"https://api.github.com/users/AndreLouisCaron/events{/privacy}","received_events_url":"https://api.github.com/users/AndreLouisCaron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-07T04:55:25Z","updated_at":"2015-03-08T19:27:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zeromq/pyzmq/pulls/656","html_url":"https://github.com/zeromq/pyzmq/pull/656","diff_url":"https://github.com/zeromq/pyzmq/pull/656.diff","patch_url":"https://github.com/zeromq/pyzmq/pull/656.patch"},"body":"Libsodium compiles fine on Windows, even with VS2008 (for Python 2.7).  However, it requires a few tricks:\r\n- VS2008 doesn't provide `<stdint.h>`, so we need to mock it (like libzmq already does);\r\n- VS2008 doesn't support C99 `static inline` functions, but removing the `inline` when compiling it for PyZMQ seems to work fine;\r\n- before version 1.0.1, libsodium uses the same `DLL_EXPORT` switch as libzmq, which prevented from compiling libsodium as a dependency of libzmq (since version 1.0.1, libsodium changed this macro to `SODIUM_DLL_EXPORT` and no longer conflicts with PyZMQ)."},"comment":{"url":"https://api.github.com/repos/zeromq/pyzmq/issues/comments/77769171","html_url":"https://github.com/zeromq/pyzmq/pull/656#issuecomment-77769171","issue_url":"https://api.github.com/repos/zeromq/pyzmq/issues/656","id":77769171,"user":{"login":"AndreLouisCaron","id":135974,"avatar_url":"https://avatars.githubusercontent.com/u/135974?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreLouisCaron","html_url":"https://github.com/AndreLouisCaron","followers_url":"https://api.github.com/users/AndreLouisCaron/followers","following_url":"https://api.github.com/users/AndreLouisCaron/following{/other_user}","gists_url":"https://api.github.com/users/AndreLouisCaron/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreLouisCaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreLouisCaron/subscriptions","organizations_url":"https://api.github.com/users/AndreLouisCaron/orgs","repos_url":"https://api.github.com/users/AndreLouisCaron/repos","events_url":"https://api.github.com/users/AndreLouisCaron/events{/privacy}","received_events_url":"https://api.github.com/users/AndreLouisCaron/received_events","type":"User","site_admin":false},"created_at":"2015-03-08T19:27:49Z","updated_at":"2015-03-08T19:27:49Z","body":"Updated the pull request.  Tested on Python 2.7.9 and 3.4.3.  I think I addressed all issues, let me know if there's anything else.\r\n\r\nI'm not sure how to test all build variants (debug/release/64-bit).  Do you have a procedure somewhere so that I can try them out or are you going to test it yourself?"}}