{"push_id":631422886,"size":206,"distinct_size":1,"ref":"refs/heads/rt-no-service-lookup","head":"a9a956f0b3b909406845f730b74832b61b61b4ba","before":"9808f10eba0353cb51ceaff0dd73105d3c3183ec","commits":[{"sha":"26424b883e3cbd4c1abc1738b417eb6823b0e3cd","author":{"email":"2c1c04960e5094d519e914b7f827193df42cff08@us.ibm.com","name":"Matt Riedemann"},"message":"Better power_state logging in _sync_instance_power_state\n\nCommit aa1792eb4c1d10e9a192142ce7e20d37871d916a added more verbose\nlogging of the various database and hypervisor states when\n_sync_instance_power_state is called (which can be called from\nhandle_lifecycle_event - triggered by the libvirt driver, or from the\n_sync_power_states periodic task).\n\nThis change adds logging of when the power_state in the database does\nnot match the power_state from the hypervisor, and then the power_state\nin the database is updated to match what's in the hypervisor.\n\nAlso, we save the original database power_state for logging when we have\ncases of stopping an active instance due to vm_state / power_state\nconflicts, or stopping a \"stopped\" instance but the hypervisor says is\nstill running.\n\nThis is all needed because debugging the various things that can hit\nthis code at different times and cause problems is, well, terrible.\n\nChange-Id: I297ca0037f43535c80afa8a4b5086ccb30558dc3","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/26424b883e3cbd4c1abc1738b417eb6823b0e3cd"},{"sha":"7560620da7704671e6e5a304c25e506e12f213bd","author":{"email":"2c1c04960e5094d519e914b7f827193df42cff08@us.ibm.com","name":"Matt Riedemann"},"message":"neutronv2: only create client once when adding/removing fixed IPs\n\nWe don't need to create a neutron client object (session) every time we\nneed to make an API call in add_fixed_ip_to_instance or\nremove_fixed_ip_from_instance, especially when looping over ports and\nsubnets.\n\nJust create the client once at the beginning of the method and reuse it.\n\nCloses-Bug: #1430481\n\nChange-Id: If9181c2ef5fb94652d0205d6d69521bcc5d85cff","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/7560620da7704671e6e5a304c25e506e12f213bd"},{"sha":"56a6c6485d197eb15c3bdf421c5580c6dc29f816","author":{"email":"84df40ec8e2270eb6994a3e4818f2872dd203c26@cloudbasesolutions.com","name":"Adelina Tuvenie"},"message":"Fix copy configdrive during live-migration on HyperV\n\nThis bug was introduced due to an oversight when fixing\nhttps://launchpad.net/bugs/1322096 . In that fix, we use the\n\"config_drive_cdrom\" value from the conf to determine if a\nthere is a iso configdrive attached to the instance. This\napproach is wrong due to the fact that that config value can be\nmodified by the user. If that happens, instances that still have\niso configdrives will be ommitted.\n\nThis path fixes this problem by checking the instance itself if\nit has any iso attached to it.\n\nCloses-Bug: #1427467\nChange-Id: Ia64389b4405109d7db6fbf9c000a0136e9862298","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/56a6c6485d197eb15c3bdf421c5580c6dc29f816"},{"sha":"48b499d3a7eddd6af88580ff1573f942dfda05b4","author":{"email":"aa71f94694e581551b4f662abcc23a9271bdb41d@vmware.com","name":"Gary Kotton"},"message":"libvirt: remove unnecessary flavor parameter\n\nThe instance now has the flavor as part of the object. There is\nno reason to pass this to:\n - _get_guest_config_meta\n - _get_guest_xml\n\nThe unit test test_get_guest_config was also updated. The flavor in\nthe test has 3 disks and these need to be validated correctly.\n\nChange-Id: I1170aefcd4912e091f4b85e91d351b4372522fa9","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/48b499d3a7eddd6af88580ff1573f942dfda05b4"},{"sha":"6ca7d598e3fd56784c02af6be7fc6d69c9b63b26","author":{"email":"b7a5da1e6209f9510c07a03f0423c37727add225@redhat.com","name":"Matthew Booth"},"message":"Fix PciDeviceDBApiTestCase with referential constraint checking\n\nPciDeviceDBApiTestCase relies on being able to create database rows\nwithout referential constraint checking, which is the default on\nsqlite but not other backends. This change adds the required compute\nnode row when creating pci device rows.\n\nChange-Id: I5c31f75d612946237a939acd86c143d895580fda","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/6ca7d598e3fd56784c02af6be7fc6d69c9b63b26"},{"sha":"b749bca5d13f07ffb8af210022ca153cfcd623a5","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@dague.net","name":"Sean Dague"},"message":"remove unneeded teardown related code\n\nThe DatabaseFixture ensures we have a blank database at the beginning\nof a test, previously there was a teardown method here, which was\ndeleted. However there remains a bunch of state tracking which was\nrelated to that teardown. Cleanup up all the extra variable references\nto avoid future confusion with this test.\n\nChange-Id: I5527413dfcc6b9e0691bfc229247e7707b75cb45","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/b749bca5d13f07ffb8af210022ca153cfcd623a5"},{"sha":"32c10850ae733c524e403592771b02491a96e67d","author":{"email":"5c7e7a1b9dd68895553ea361dd09b55647837ea3@gmail.com","name":"Eduardo Costa"},"message":"Workaround for race condition in libvirt\n\nMethod \"info\" is affected by a race condition in libvirt.\nMethods \"vcpus\" and \"memoryStats\" are also affected, but their\nerrors are handled gracefully by present code.\n\nThis patch detects the race and then performs a retry on error.\n\nNew code should avoid calling libvirt.virDomain.info directly.\nInstead, method Host.get_domain_info() should be called.\n\nA full fix for this bug would involve upgrading libvirt to\nversion >=1.2.11.\n\nChange-Id: I4e3baceabdbc843635d07652abf80d39d58d9e06\nPartial-Bug: #1372670","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/32c10850ae733c524e403592771b02491a96e67d"},{"sha":"39c0ce46b6d9bd93c2efabdb722dafac62b1f0f6","author":{"email":"80f3d9c8f10b600169ff46547616e6b5b34bf9fd@intel.com","name":"ShaoHe Feng"},"message":"add neutron api NotImplemented test cases for Network V2.1\n\nNow these test cases are tested twice, and just for V2.\nThis patch fixes it.\n\nAnd it blocks the bp v3-api-policy implementation.\n\nCloses-Bug: 1429729\n\nChange-Id: Ia2eb281a9ba2e02c0720f99d01971623c7664063","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/39c0ce46b6d9bd93c2efabdb722dafac62b1f0f6"},{"sha":"cadbcc440a2fcfb8532f38111999a06557fbafc2","author":{"email":"78c2c705d32f41ddd0dddd01cc56e39491384260@cn.ibm.com","name":"jichenjc"},"message":"Release bdm constraint source and dest type\n\nhttps://bugs.launchpad.net/nova/+bug/1377958 fixed a problem\nthat source_type: image, destination_type: local is not\nsupported for boot instance, exception should be raised to\nreject the param otherwise it will lead to instance become\nERROR state.\n\nHowever the fix introduced a problem on nova client\nhttps://bugs.launchpad.net/python-novaclient/+bug/1418484\nThe fix of the bug leads to following command become invalid\n\nnova boot test-vm --flavor m1.medium --image centos-vm-32\n--nic net-id=c3f40e33-d535-4217-916b-1450b8cd3987 --block-device\nid=26b7b917-2794-452a-95e5-2efb2ca6e32d,bus=sata,source=volume,bootindex=1\n\nSo we need to release the original constraint to allow\nthe above special case pass the validation check then\nwe can revert the nova client exception\n(https://review.openstack.org/#/c/165932/)\n\nThis patch checks the boot_index and whether image param is\ngiven after we found the bdm has source_type: image,\ndestination_type: local, if this is the special case, then\nno exception will be raised.\n\nCloses-Bug: #1433609\n\nChange-Id: If43faae95169bc3864449a8364975f5c887aac14","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/cadbcc440a2fcfb8532f38111999a06557fbafc2"},{"sha":"e7ae5bb7fbdd5b79bde8937958dd0a645554a5f0","author":{"email":"62291420548aa66b330ba07ee829b713e2baa07b@gmail.com","name":"Arnaud Legendre"},"message":"VMware: Consume the oslo.vmware objects\n\noslo.vmware now contains the datastore and datacenter objects.\n\nThis patch gets rid of the nova datastore object and leverages\noslo.vmware.\n\nCo-authored-by: Gary Kotton <gkotton@vmware.com>\n\nChange-Id: I3f1e65dec1500afb58dcb841991ac976887de09d","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/e7ae5bb7fbdd5b79bde8937958dd0a645554a5f0"},{"sha":"97d049b977d18ab277e7dfeae49062032a320ccd","author":{"email":"2c1c04960e5094d519e914b7f827193df42cff08@us.ibm.com","name":"Matt Riedemann"},"message":"mock out build_instances/rebuild_instance when not used\n\nTrying to close the gap on what could be causing issues\nwith races in the conductor tests that hit build/rebuild\ninstance.\n\nChange-Id: If36ffc21192493c940df9f60beef9476fbd31f84\nPartial-Bug: #1434161","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/97d049b977d18ab277e7dfeae49062032a320ccd"},{"sha":"d22673d38f384a21dca9b736df7115e1c1ee8954","author":{"email":"78c2c705d32f41ddd0dddd01cc56e39491384260@cn.ibm.com","name":"jichenjc"},"message":"Fix test cases still use v3 prefix\n\nAfter commit e03cfed720a2424ea9ce2819fa06c2d423e9100c\nthe prefix of v3 API was changed to os_compute_api\nso prefix in test cases should be changed as well.\nThis patch changed test_cells, test_extended_volumes,\ntest_simple_tenant_usage and test_used_limits.\n\nPartially implements bp v3-api-policy\n\nChange-Id: I793f6bbb35ab868d05224e4076befe981b19d537","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/d22673d38f384a21dca9b736df7115e1c1ee8954"},{"sha":"3bcaf68357d361100cb3ac35b3a5504627db8f0e","author":{"email":"78c2c705d32f41ddd0dddd01cc56e39491384260@cn.ibm.com","name":"jichenjc"},"message":"libvirt: remove volume_drivers config param\n\nCopied commit message from\ncommit I1f884f36e24fe478922671ca3eaf6b7c21fd8a5a\n\nThe 'volumes_drivers' parameter does the same job as the\n'vif_driver' parameter, but for volumes instead of vifs.\n\nThe API for the LibvirtBaseVolumeDriver class is not\nconsidered to be a public extension point. As such it\nis not required or expected to remain compatible across\nreleases.\n\nThe main reason for its existance is for people who are\ndeveloping new cinder drivers, to be able to write out\nof tree nova volume drivers. The recommended practice\nis to instead work in-tree to nova on a branch. This is\nan approach that would be required in order to submit\nthe work for review and eventual merge in any case.\n\ncommit I1f884f36e24fe478922671ca3eaf6b7c21fd8a5a\ndeprecated it and during the discussion the actually target\nis Kilo. But it's K-3 so more reasonable target is\nLiberty.\n\nDocImpact: libvirt.volume_drivers config param is removed.\n\nCloses-Bug: #1371175\n\nChange-Id: I832820499ec3304132379ad9b9d1ee92c5a75b61","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/3bcaf68357d361100cb3ac35b3a5504627db8f0e"},{"sha":"afb20c9d6c5c2c247415299b8f59a42e5818552c","author":{"email":"78c2c705d32f41ddd0dddd01cc56e39491384260@cn.ibm.com","name":"jichenjc"},"message":"Remove unused class variables in extended_volumes\n\nRemove unused class variables not used in\nnova/api/openstack/compute/contrib/extended_volumes.py\nnova/api/openstack/compute/plugins/v3/extended_volumes.py\n\nChange-Id: Id574c52a1acd60e3bd761199c18ce3b7922aa278","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/afb20c9d6c5c2c247415299b8f59a42e5818552c"},{"sha":"b09531826a9ed9743d2a83e6823e0b69412f95cd","author":{"email":"aa71f94694e581551b4f662abcc23a9271bdb41d@vmware.com","name":"Gary Kotton"},"message":"Neutron: simplify validate_networks\n\nCreates a utility method that returns the number of ports required\nby an instance. This does the following:\n1. it simplifies the method\n2. reduce the complexity of the code\n'./nova/network/neutronv2/api.py:913:1: C901 'API.validate_networks' is too complex (25)'\n\nNOTE: the code is already tested and this is just moving the internals.\n\nChange-Id: Ibed04a7f10eb85198c7d3ac2cedb58f50ec11f5e","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/b09531826a9ed9743d2a83e6823e0b69412f95cd"},{"sha":"e77be6c6da0720f8c28b983746579188245c58d0","author":{"email":"0fe0bd399dd39b6e2574442cf896a57f5611d8c7@intel.com","name":"He Jie Xu"},"message":"Avoid load real policy from policy.d when using fake policy fixture\n\nThe v2.1 API policy rules separated into a file in policy.d. But the\nfake policy fixture didn't override the default policy_dirs config,\nthat leads to fake policy fixture will load real policy config from\n\"/etc/nova/policy.d\" and unittest will failed.\n\nThis patch override default policy_dirs value to empty list.\n\nChange-Id: I7d8958dc2f0bb927b98b2bb86c99e855db6c5e2e\nCloses-Bug: #1435327","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/e77be6c6da0720f8c28b983746579188245c58d0"},{"sha":"3e42c7ae3f7a9353834c8c9c4dc79ee39dd0783b","author":{"email":"60c6b32104676d0f61025542ba8c54ced7cddc41@cloudbasesolutions.com","name":"Dorin Paslaru"},"message":"Hyper-V: Sets *DataRoot paths for instances\n\nSets the path for the instance's ConfigurationDataRoot,\nLogDataRoot, SnapshotDataRoot, SuspendDataRoot and\nSwapFileDataRoot for vmutilsv2 instances and\nExternalDataRoot and SnapshotDataRoot for vmutils\nto the instance's location.\n\nCloses-Bug: #1430239\n\nChange-Id: I3c9e2dece00df06cafdcd164ece6269337feda71","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/3e42c7ae3f7a9353834c8c9c4dc79ee39dd0783b"},{"sha":"70f3c8d3d33a12ee002753f7867c6c12d2b0fc84","author":{"email":"75d08737f5229309107d3b8db35f5764171a953f@intel.com","name":"Eli Qiao"},"message":"Fix incorrect http_conflict error message\n\ninstance power state may be integer zero, in that case the error message would\nbe no correct.\n\nBTW, this patch remove 'not_launched' from kwargs since no other code set this\nparameter into kwargs.\n\nCloses-bug: 1437111\nChange-Id: Id2fb561a79d627eb8c6b41e4fe3549dc69dc7d99","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/70f3c8d3d33a12ee002753f7867c6c12d2b0fc84"},{"sha":"e8006761d7c1f0392c2675e3eb6e8d1c49c3ecb9","author":{"email":"17a59e873133af25bef9d8a9fdaa6c3a6b7eebd2@nectechnologies.in","name":"ghanshyam"},"message":"Fix v2.1 list-host to remove 'services' filter\n\nIn v2.1, list-host supports 'services' filter also\nBut this is not case with v2 API. v2 list-host does not support\n'services' filter.\nv2.1 APIs should be same as v2 in all cases/scenarios.\n\nThis is bug fix so not putting as microversions, its just a change to\nthe v2.1 code so it is equivalent to v2. If later needed then, this can\nbe reverted back as current ways via microversion.\n\nThis was no best test coverage to catch this kind of issue.\nThis was caught while merging the v2 and v2.1 tests\n- Ibd53a7ddd4792942fe2dc45121dcc25fc9864903\n\nChange-Id: I11210babde0c5a668c794cd6aae7eb8c5093a99c\nCloses-Bug: #1437184","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/e8006761d7c1f0392c2675e3eb6e8d1c49c3ecb9"},{"sha":"db90b5b3958d9d9e6bd189de002442b6b652c31b","author":{"email":"643f6b463530c1c90b66996f2cbd59149b9bf3ff@us.ibm.com","name":"Jennifer Mulsow"},"message":"Expand valid server group name character set\n\nNames requested for a server group should use the same validation\nchecking as names in the other APIS. Right now it will not allow\nany non alphanumeric characters. Change this to allow all printable\nand horizontal whitespace unicode characters. This is the same check\nthat is done for flavor names, as well as names in v2.1 APIs.\nCloses-Bug: #1434335\n\nChange-Id: I6c675fb6c2f40e83499a41ecdccec58d99501433","distinct":false,"url":"https://api.github.com/repos/hanlind/nova/commits/db90b5b3958d9d9e6bd189de002442b6b652c31b"}]}