{"action":"created","comment":{"url":"https://api.github.com/repos/Mantle/Mantle/pulls/comments/35845874","id":35845874,"diff_hunk":"@@ -97,6 +97,20 @@ extern const NSInteger MTLTestModelNameMissing;\n @property (readonly, nonatomic, weak) id weakProperty;\n @property (readonly, nonatomic, strong) id strongProperty;\n \n+@property (readonly, nonatomic, copy) NSDate *dateFromProtocol;\n+\n+@end\n+\n+@protocol MTLDateProtocol <NSObject>\n+\n+@property (readonly, nonatomic, copy) NSDate *dateFromProtocol;","path":"MantleTests/MTLTestModel.h","position":10,"original_position":10,"commit_id":"93c0a5c3e4f14a5304dfa883222c42b0ff880928","original_commit_id":"93c0a5c3e4f14a5304dfa883222c42b0ff880928","user":{"login":"robb","id":212465,"avatar_url":"https://avatars.githubusercontent.com/u/212465?v=3","gravatar_id":"","url":"https://api.github.com/users/robb","html_url":"https://github.com/robb","followers_url":"https://api.github.com/users/robb/followers","following_url":"https://api.github.com/users/robb/following{/other_user}","gists_url":"https://api.github.com/users/robb/gists{/gist_id}","starred_url":"https://api.github.com/users/robb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robb/subscriptions","organizations_url":"https://api.github.com/users/robb/orgs","repos_url":"https://api.github.com/users/robb/repos","events_url":"https://api.github.com/users/robb/events{/privacy}","received_events_url":"https://api.github.com/users/robb/received_events","type":"User","site_admin":false},"body":"Is `copy` relevant here? If not, can we make it strong?\r\n\r\nSince the type of the property shouldn't matter, can we make this `id declaredInProtocol` or something like that?","created_at":"2015-07-30T07:43:31Z","updated_at":"2015-07-30T07:43:31Z","html_url":"https://github.com/Mantle/Mantle/pull/568#discussion_r35845874","pull_request_url":"https://api.github.com/repos/Mantle/Mantle/pulls/568","_links":{"self":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/comments/35845874"},"html":{"href":"https://github.com/Mantle/Mantle/pull/568#discussion_r35845874"},"pull_request":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/568"}}},"pull_request":{"url":"https://api.github.com/repos/Mantle/Mantle/pulls/568","id":41189660,"html_url":"https://github.com/Mantle/Mantle/pull/568","diff_url":"https://github.com/Mantle/Mantle/pull/568.diff","patch_url":"https://github.com/Mantle/Mantle/pull/568.patch","issue_url":"https://api.github.com/repos/Mantle/Mantle/issues/568","number":568,"state":"open","locked":false,"title":"Check superclass for property persistence","user":{"login":"jmah","id":2748,"avatar_url":"https://avatars.githubusercontent.com/u/2748?v=3","gravatar_id":"","url":"https://api.github.com/users/jmah","html_url":"https://github.com/jmah","followers_url":"https://api.github.com/users/jmah/followers","following_url":"https://api.github.com/users/jmah/following{/other_user}","gists_url":"https://api.github.com/users/jmah/gists{/gist_id}","starred_url":"https://api.github.com/users/jmah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmah/subscriptions","organizations_url":"https://api.github.com/users/jmah/orgs","repos_url":"https://api.github.com/users/jmah/repos","events_url":"https://api.github.com/users/jmah/events{/privacy}","received_events_url":"https://api.github.com/users/jmah/received_events","type":"User","site_admin":false},"body":"A subclass can shadow a parent's property declaration, either explicitly\r\nwith a `@property` directive or implicitly by conforming to a protocol\r\nthat requires a particular property. The result is that the subclass\r\nproperty record has no associated ivar (or methods), and calls to get /\r\nset the property will fall up to the superclass's methods (backed by the\r\nsuperclass's ivar).","created_at":"2015-07-30T01:18:11Z","updated_at":"2015-07-30T07:43:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dec8631a45bca4313f3c043f285602dfa24c9e77","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Mantle/Mantle/pulls/568/commits","review_comments_url":"https://api.github.com/repos/Mantle/Mantle/pulls/568/comments","review_comment_url":"https://api.github.com/repos/Mantle/Mantle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mantle/Mantle/issues/568/comments","statuses_url":"https://api.github.com/repos/Mantle/Mantle/statuses/93c0a5c3e4f14a5304dfa883222c42b0ff880928","head":{"label":"jmah:jmah/protocol-storage","ref":"jmah/protocol-storage","sha":"93c0a5c3e4f14a5304dfa883222c42b0ff880928","user":{"login":"jmah","id":2748,"avatar_url":"https://avatars.githubusercontent.com/u/2748?v=3","gravatar_id":"","url":"https://api.github.com/users/jmah","html_url":"https://github.com/jmah","followers_url":"https://api.github.com/users/jmah/followers","following_url":"https://api.github.com/users/jmah/following{/other_user}","gists_url":"https://api.github.com/users/jmah/gists{/gist_id}","starred_url":"https://api.github.com/users/jmah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmah/subscriptions","organizations_url":"https://api.github.com/users/jmah/orgs","repos_url":"https://api.github.com/users/jmah/repos","events_url":"https://api.github.com/users/jmah/events{/privacy}","received_events_url":"https://api.github.com/users/jmah/received_events","type":"User","site_admin":false},"repo":{"id":39414361,"name":"Mantle","full_name":"jmah/Mantle","owner":{"login":"jmah","id":2748,"avatar_url":"https://avatars.githubusercontent.com/u/2748?v=3","gravatar_id":"","url":"https://api.github.com/users/jmah","html_url":"https://github.com/jmah","followers_url":"https://api.github.com/users/jmah/followers","following_url":"https://api.github.com/users/jmah/following{/other_user}","gists_url":"https://api.github.com/users/jmah/gists{/gist_id}","starred_url":"https://api.github.com/users/jmah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmah/subscriptions","organizations_url":"https://api.github.com/users/jmah/orgs","repos_url":"https://api.github.com/users/jmah/repos","events_url":"https://api.github.com/users/jmah/events{/privacy}","received_events_url":"https://api.github.com/users/jmah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmah/Mantle","description":"Model framework for Cocoa and Cocoa Touch","fork":true,"url":"https://api.github.com/repos/jmah/Mantle","forks_url":"https://api.github.com/repos/jmah/Mantle/forks","keys_url":"https://api.github.com/repos/jmah/Mantle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmah/Mantle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmah/Mantle/teams","hooks_url":"https://api.github.com/repos/jmah/Mantle/hooks","issue_events_url":"https://api.github.com/repos/jmah/Mantle/issues/events{/number}","events_url":"https://api.github.com/repos/jmah/Mantle/events","assignees_url":"https://api.github.com/repos/jmah/Mantle/assignees{/user}","branches_url":"https://api.github.com/repos/jmah/Mantle/branches{/branch}","tags_url":"https://api.github.com/repos/jmah/Mantle/tags","blobs_url":"https://api.github.com/repos/jmah/Mantle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmah/Mantle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmah/Mantle/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmah/Mantle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmah/Mantle/statuses/{sha}","languages_url":"https://api.github.com/repos/jmah/Mantle/languages","stargazers_url":"https://api.github.com/repos/jmah/Mantle/stargazers","contributors_url":"https://api.github.com/repos/jmah/Mantle/contributors","subscribers_url":"https://api.github.com/repos/jmah/Mantle/subscribers","subscription_url":"https://api.github.com/repos/jmah/Mantle/subscription","commits_url":"https://api.github.com/repos/jmah/Mantle/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmah/Mantle/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmah/Mantle/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmah/Mantle/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmah/Mantle/contents/{+path}","compare_url":"https://api.github.com/repos/jmah/Mantle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmah/Mantle/merges","archive_url":"https://api.github.com/repos/jmah/Mantle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmah/Mantle/downloads","issues_url":"https://api.github.com/repos/jmah/Mantle/issues{/number}","pulls_url":"https://api.github.com/repos/jmah/Mantle/pulls{/number}","milestones_url":"https://api.github.com/repos/jmah/Mantle/milestones{/number}","notifications_url":"https://api.github.com/repos/jmah/Mantle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmah/Mantle/labels{/name}","releases_url":"https://api.github.com/repos/jmah/Mantle/releases{/id}","created_at":"2015-07-21T00:02:17Z","updated_at":"2015-07-21T00:02:18Z","pushed_at":"2015-07-30T01:16:31Z","git_url":"git://github.com/jmah/Mantle.git","ssh_url":"git@github.com:jmah/Mantle.git","clone_url":"https://github.com/jmah/Mantle.git","svn_url":"https://github.com/jmah/Mantle","homepage":"","size":1448,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Mantle:master","ref":"master","sha":"ec98991888ca46cef1117a550bb06d32b4ed92c7","user":{"login":"Mantle","id":7318467,"avatar_url":"https://avatars.githubusercontent.com/u/7318467?v=3","gravatar_id":"","url":"https://api.github.com/users/Mantle","html_url":"https://github.com/Mantle","followers_url":"https://api.github.com/users/Mantle/followers","following_url":"https://api.github.com/users/Mantle/following{/other_user}","gists_url":"https://api.github.com/users/Mantle/gists{/gist_id}","starred_url":"https://api.github.com/users/Mantle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mantle/subscriptions","organizations_url":"https://api.github.com/users/Mantle/orgs","repos_url":"https://api.github.com/users/Mantle/repos","events_url":"https://api.github.com/users/Mantle/events{/privacy}","received_events_url":"https://api.github.com/users/Mantle/received_events","type":"Organization","site_admin":false},"repo":{"id":5683364,"name":"Mantle","full_name":"Mantle/Mantle","owner":{"login":"Mantle","id":7318467,"avatar_url":"https://avatars.githubusercontent.com/u/7318467?v=3","gravatar_id":"","url":"https://api.github.com/users/Mantle","html_url":"https://github.com/Mantle","followers_url":"https://api.github.com/users/Mantle/followers","following_url":"https://api.github.com/users/Mantle/following{/other_user}","gists_url":"https://api.github.com/users/Mantle/gists{/gist_id}","starred_url":"https://api.github.com/users/Mantle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mantle/subscriptions","organizations_url":"https://api.github.com/users/Mantle/orgs","repos_url":"https://api.github.com/users/Mantle/repos","events_url":"https://api.github.com/users/Mantle/events{/privacy}","received_events_url":"https://api.github.com/users/Mantle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mantle/Mantle","description":"Model framework for Cocoa and Cocoa Touch","fork":false,"url":"https://api.github.com/repos/Mantle/Mantle","forks_url":"https://api.github.com/repos/Mantle/Mantle/forks","keys_url":"https://api.github.com/repos/Mantle/Mantle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mantle/Mantle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mantle/Mantle/teams","hooks_url":"https://api.github.com/repos/Mantle/Mantle/hooks","issue_events_url":"https://api.github.com/repos/Mantle/Mantle/issues/events{/number}","events_url":"https://api.github.com/repos/Mantle/Mantle/events","assignees_url":"https://api.github.com/repos/Mantle/Mantle/assignees{/user}","branches_url":"https://api.github.com/repos/Mantle/Mantle/branches{/branch}","tags_url":"https://api.github.com/repos/Mantle/Mantle/tags","blobs_url":"https://api.github.com/repos/Mantle/Mantle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mantle/Mantle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mantle/Mantle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mantle/Mantle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mantle/Mantle/statuses/{sha}","languages_url":"https://api.github.com/repos/Mantle/Mantle/languages","stargazers_url":"https://api.github.com/repos/Mantle/Mantle/stargazers","contributors_url":"https://api.github.com/repos/Mantle/Mantle/contributors","subscribers_url":"https://api.github.com/repos/Mantle/Mantle/subscribers","subscription_url":"https://api.github.com/repos/Mantle/Mantle/subscription","commits_url":"https://api.github.com/repos/Mantle/Mantle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mantle/Mantle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mantle/Mantle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mantle/Mantle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mantle/Mantle/contents/{+path}","compare_url":"https://api.github.com/repos/Mantle/Mantle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mantle/Mantle/merges","archive_url":"https://api.github.com/repos/Mantle/Mantle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mantle/Mantle/downloads","issues_url":"https://api.github.com/repos/Mantle/Mantle/issues{/number}","pulls_url":"https://api.github.com/repos/Mantle/Mantle/pulls{/number}","milestones_url":"https://api.github.com/repos/Mantle/Mantle/milestones{/number}","notifications_url":"https://api.github.com/repos/Mantle/Mantle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mantle/Mantle/labels{/name}","releases_url":"https://api.github.com/repos/Mantle/Mantle/releases{/id}","created_at":"2012-09-05T06:24:59Z","updated_at":"2015-07-30T07:13:18Z","pushed_at":"2015-07-30T01:26:09Z","git_url":"git://github.com/Mantle/Mantle.git","ssh_url":"git@github.com:Mantle/Mantle.git","clone_url":"https://github.com/Mantle/Mantle.git","svn_url":"https://github.com/Mantle/Mantle","homepage":"","size":64040,"stargazers_count":7391,"watchers_count":7391,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":905,"mirror_url":null,"open_issues_count":30,"forks":905,"open_issues":30,"watchers":7391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/568"},"html":{"href":"https://github.com/Mantle/Mantle/pull/568"},"issue":{"href":"https://api.github.com/repos/Mantle/Mantle/issues/568"},"comments":{"href":"https://api.github.com/repos/Mantle/Mantle/issues/568/comments"},"review_comments":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/568/comments"},"review_comment":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/568/commits"},"statuses":{"href":"https://api.github.com/repos/Mantle/Mantle/statuses/93c0a5c3e4f14a5304dfa883222c42b0ff880928"}}}}