{"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/cf-tables/pulls/comments/45345473","id":45345473,"diff_hunk":"@@ -436,14 +459,14 @@\n \n     .table__entry-header-on-small {\n         & > tbody td:first-child {\n+            padding-bottom: .75em;\n+            margin-bottom: unit( 10px / @base-font-size-px, em);\n             margin-top: 0;\n+            border-bottom: 1px solid @table-border;","path":"src/cf-tables.less","position":115,"original_position":115,"commit_id":"f4cef45c44259f5efbb897babb25d628aa8788bf","original_commit_id":"f4cef45c44259f5efbb897babb25d628aa8788bf","user":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"body":"Oops! Oversight. Fixed!","created_at":"2015-11-19T14:21:38Z","updated_at":"2015-11-19T14:21:38Z","html_url":"https://github.com/cfpb/cf-tables/pull/16#discussion_r45345473","pull_request_url":"https://api.github.com/repos/cfpb/cf-tables/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/cfpb/cf-tables/pulls/comments/45345473"},"html":{"href":"https://github.com/cfpb/cf-tables/pull/16#discussion_r45345473"},"pull_request":{"href":"https://api.github.com/repos/cfpb/cf-tables/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/cf-tables/pulls/16","id":51133483,"html_url":"https://github.com/cfpb/cf-tables/pull/16","diff_url":"https://github.com/cfpb/cf-tables/pull/16.diff","patch_url":"https://github.com/cfpb/cf-tables/pull/16.patch","issue_url":"https://api.github.com/repos/cfpb/cf-tables/issues/16","number":16,"state":"open","locked":false,"title":"cf-tables version 1.0.0 is ready!","user":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"body":"This PR addresses the accessibility question for sortable tables, and cleans up a few minor things.\r\n\r\n## Additions\r\n- Styles for `button.sortable` which mostly just strips the default button styles (and makes the button full width and height to fill the TH it's in)\r\n\r\n## Changes\r\n- `.sortable` changed to a button to address accessibility\r\n- JavaScript changes to match move to `.sortable` being a button\r\n- Updated docs to note button preference for .sortable\r\n- CSS properties re-ordered to better meet standards\r\n\r\n## Testing\r\n- Pull it down, check out the demo page or docs page.\r\n- `grunt test`\r\n\r\n## Review\r\n- @Scotchester and @KimberlyMunoz and @jimmynotjim and anyone else who's interested!\r\n\r\n## Todos\r\n- I'd like to make tables sortable by date\r\n- I'd like to expose public methods so that other apps can sort tables with those methods\r\n\r\n## Checklist\r\n* [x] Changes are limited to a single goal (no scope creep)\r\n* [x] Code can be automatically merged (no conflicts)\r\n* [x] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [x] Passes all existing automated tests\r\n* [x] New functions include new tests\r\n* [x] New functions are documented (with a description, list of inputs, and expected output)\r\n* [x] Placeholder code is flagged\r\n* [x] Visually tested in supported browsers and devices \r\n* [x] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)\r\n\r\n## Special Thanks\r\nThanks to everyone for their help on this, including @Scotchester and @KimberlyMunoz and @jimmynotjim and @ascott1 and @anselmbradford and @sebworks!\r\n\r\n## Animated GIF\r\n![](http://stream1.gifsoup.com/view5/4567938/cat-trapped-on-a-turntable-o.gif)\r\n\r\nIt's a turn<strong>TABLE</strong>. Get it? Get it? :wink: :grin: :rocket: :octopus: ","created_at":"2015-11-18T19:56:20Z","updated_at":"2015-11-19T14:21:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f01553b5019cdc7665db373ffceb668a4409f4d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/cf-tables/pulls/16/commits","review_comments_url":"https://api.github.com/repos/cfpb/cf-tables/pulls/16/comments","review_comment_url":"https://api.github.com/repos/cfpb/cf-tables/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/cf-tables/issues/16/comments","statuses_url":"https://api.github.com/repos/cfpb/cf-tables/statuses/f4cef45c44259f5efbb897babb25d628aa8788bf","head":{"label":"mistergone:gh-pages","ref":"gh-pages","sha":"f4cef45c44259f5efbb897babb25d628aa8788bf","user":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"repo":{"id":42466213,"name":"cf-tables","full_name":"mistergone/cf-tables","owner":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mistergone/cf-tables","description":"","fork":true,"url":"https://api.github.com/repos/mistergone/cf-tables","forks_url":"https://api.github.com/repos/mistergone/cf-tables/forks","keys_url":"https://api.github.com/repos/mistergone/cf-tables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mistergone/cf-tables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mistergone/cf-tables/teams","hooks_url":"https://api.github.com/repos/mistergone/cf-tables/hooks","issue_events_url":"https://api.github.com/repos/mistergone/cf-tables/issues/events{/number}","events_url":"https://api.github.com/repos/mistergone/cf-tables/events","assignees_url":"https://api.github.com/repos/mistergone/cf-tables/assignees{/user}","branches_url":"https://api.github.com/repos/mistergone/cf-tables/branches{/branch}","tags_url":"https://api.github.com/repos/mistergone/cf-tables/tags","blobs_url":"https://api.github.com/repos/mistergone/cf-tables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mistergone/cf-tables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mistergone/cf-tables/git/refs{/sha}","trees_url":"https://api.github.com/repos/mistergone/cf-tables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mistergone/cf-tables/statuses/{sha}","languages_url":"https://api.github.com/repos/mistergone/cf-tables/languages","stargazers_url":"https://api.github.com/repos/mistergone/cf-tables/stargazers","contributors_url":"https://api.github.com/repos/mistergone/cf-tables/contributors","subscribers_url":"https://api.github.com/repos/mistergone/cf-tables/subscribers","subscription_url":"https://api.github.com/repos/mistergone/cf-tables/subscription","commits_url":"https://api.github.com/repos/mistergone/cf-tables/commits{/sha}","git_commits_url":"https://api.github.com/repos/mistergone/cf-tables/git/commits{/sha}","comments_url":"https://api.github.com/repos/mistergone/cf-tables/comments{/number}","issue_comment_url":"https://api.github.com/repos/mistergone/cf-tables/issues/comments{/number}","contents_url":"https://api.github.com/repos/mistergone/cf-tables/contents/{+path}","compare_url":"https://api.github.com/repos/mistergone/cf-tables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mistergone/cf-tables/merges","archive_url":"https://api.github.com/repos/mistergone/cf-tables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mistergone/cf-tables/downloads","issues_url":"https://api.github.com/repos/mistergone/cf-tables/issues{/number}","pulls_url":"https://api.github.com/repos/mistergone/cf-tables/pulls{/number}","milestones_url":"https://api.github.com/repos/mistergone/cf-tables/milestones{/number}","notifications_url":"https://api.github.com/repos/mistergone/cf-tables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mistergone/cf-tables/labels{/name}","releases_url":"https://api.github.com/repos/mistergone/cf-tables/releases{/id}","created_at":"2015-09-14T17:47:58Z","updated_at":"2015-10-08T16:13:38Z","pushed_at":"2015-11-18T19:47:59Z","git_url":"git://github.com/mistergone/cf-tables.git","ssh_url":"git@github.com:mistergone/cf-tables.git","clone_url":"https://github.com/mistergone/cf-tables.git","svn_url":"https://github.com/mistergone/cf-tables","homepage":null,"size":233,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"cfpb:gh-pages","ref":"gh-pages","sha":"ce523e2e01f71f955863c9ce332f2d0d5f0c14eb","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":17714672,"name":"cf-tables","full_name":"cfpb/cf-tables","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cf-tables","description":"","fork":false,"url":"https://api.github.com/repos/cfpb/cf-tables","forks_url":"https://api.github.com/repos/cfpb/cf-tables/forks","keys_url":"https://api.github.com/repos/cfpb/cf-tables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cf-tables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cf-tables/teams","hooks_url":"https://api.github.com/repos/cfpb/cf-tables/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cf-tables/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cf-tables/events","assignees_url":"https://api.github.com/repos/cfpb/cf-tables/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cf-tables/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cf-tables/tags","blobs_url":"https://api.github.com/repos/cfpb/cf-tables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cf-tables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cf-tables/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cf-tables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cf-tables/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cf-tables/languages","stargazers_url":"https://api.github.com/repos/cfpb/cf-tables/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cf-tables/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cf-tables/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cf-tables/subscription","commits_url":"https://api.github.com/repos/cfpb/cf-tables/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cf-tables/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cf-tables/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cf-tables/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cf-tables/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cf-tables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cf-tables/merges","archive_url":"https://api.github.com/repos/cfpb/cf-tables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cf-tables/downloads","issues_url":"https://api.github.com/repos/cfpb/cf-tables/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cf-tables/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cf-tables/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cf-tables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cf-tables/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cf-tables/releases{/id}","created_at":"2014-03-13T15:20:47Z","updated_at":"2015-10-09T17:10:06Z","pushed_at":"2015-11-18T19:56:20Z","git_url":"git://github.com/cfpb/cf-tables.git","ssh_url":"git@github.com:cfpb/cf-tables.git","clone_url":"https://github.com/cfpb/cf-tables.git","svn_url":"https://github.com/cfpb/cf-tables","homepage":null,"size":406,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":2,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/cf-tables/pulls/16"},"html":{"href":"https://github.com/cfpb/cf-tables/pull/16"},"issue":{"href":"https://api.github.com/repos/cfpb/cf-tables/issues/16"},"comments":{"href":"https://api.github.com/repos/cfpb/cf-tables/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/cf-tables/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/cf-tables/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/cf-tables/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/cf-tables/statuses/f4cef45c44259f5efbb897babb25d628aa8788bf"}}}}