{"action":"closed","number":993,"pull_request":{"url":"https://api.github.com/repos/yesodweb/yesod/pulls/993","id":35692475,"html_url":"https://github.com/yesodweb/yesod/pull/993","diff_url":"https://github.com/yesodweb/yesod/pull/993.diff","patch_url":"https://github.com/yesodweb/yesod/pull/993.patch","issue_url":"https://api.github.com/repos/yesodweb/yesod/issues/993","number":993,"state":"closed","locked":false,"title":"remove shakespeare dependency from Yesod.Core","user":{"login":"gregwebs","id":1183,"avatar_url":"https://avatars.githubusercontent.com/u/1183?v=3","gravatar_id":"","url":"https://api.github.com/users/gregwebs","html_url":"https://github.com/gregwebs","followers_url":"https://api.github.com/users/gregwebs/followers","following_url":"https://api.github.com/users/gregwebs/following{/other_user}","gists_url":"https://api.github.com/users/gregwebs/gists{/gist_id}","starred_url":"https://api.github.com/users/gregwebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregwebs/subscriptions","organizations_url":"https://api.github.com/users/gregwebs/orgs","repos_url":"https://api.github.com/users/gregwebs/repos","events_url":"https://api.github.com/users/gregwebs/events{/privacy}","received_events_url":"https://api.github.com/users/gregwebs/received_events","type":"User","site_admin":false},"body":"This is an experimental PR that I am looking for feedback on.\r\n\r\n## Motivation\r\n\r\nThe motivation is to have a package yesod-core that has no dependency on the shakespeare package. This is beneficial for API servers that have no need for templates.\r\n\r\n## Overview\r\n\r\nAnything from the shakespeare package is moved into the module Yesod.Widget. None of the other module import Yesod.Widget. This can be confirmed by removing Yesod.Widget and shakespeare from the cabal file and seeing that things still compile. Note that I have not attempted to fix the test suite compilation.\r\n\r\nThis means that the Yesod.Widget module can now be cleanly moved into a separate yesod-widget package.\r\n\r\n## Remaining issues\r\n\r\nI ended up taking a few shortcuts to push out this PR tonight: those have a FIXME, but I think they are all fixable. I just realized some of these things can probably be made a lot easier by just copying this type into Yesod.Core\r\n\r\n    type HtmlUrl url = Render url -> Html\r\n\r\nI will try that tomorrow. Then the main blocker now is to figure out is how to deal with the Yesod typeclass having `defaultLayout :: WidgetT ...`. The main option that springs to mind is to have 2 typeclasses, the 2nd inheriting from the base and adding widget functionality. This could mean adding `Yesod site => YesodWidget site` or changing the current `Yesod` typeclass to `YesodCore` and having `YesodCore site => Yesod site`, where `Yesod site` resides in `yesod-widget`.","created_at":"2015-05-19T03:05:00Z","updated_at":"2015-06-07T23:49:10Z","closed_at":"2015-06-07T23:49:10Z","merged_at":null,"merge_commit_sha":"d054dad7449ad21388399f92a721bf5ba662e2fd","assignee":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars.githubusercontent.com/u/49415?v=3","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/yesodweb/yesod/pulls/993/commits","review_comments_url":"https://api.github.com/repos/yesodweb/yesod/pulls/993/comments","review_comment_url":"https://api.github.com/repos/yesodweb/yesod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yesodweb/yesod/issues/993/comments","statuses_url":"https://api.github.com/repos/yesodweb/yesod/statuses/09ff86c008b9be965bf7b0507f18c1108b7cb081","head":{"label":"yesodweb:core-no-shakespeare","ref":"core-no-shakespeare","sha":"09ff86c008b9be965bf7b0507f18c1108b7cb081","user":{"login":"yesodweb","id":930379,"avatar_url":"https://avatars.githubusercontent.com/u/930379?v=3","gravatar_id":"","url":"https://api.github.com/users/yesodweb","html_url":"https://github.com/yesodweb","followers_url":"https://api.github.com/users/yesodweb/followers","following_url":"https://api.github.com/users/yesodweb/following{/other_user}","gists_url":"https://api.github.com/users/yesodweb/gists{/gist_id}","starred_url":"https://api.github.com/users/yesodweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesodweb/subscriptions","organizations_url":"https://api.github.com/users/yesodweb/orgs","repos_url":"https://api.github.com/users/yesodweb/repos","events_url":"https://api.github.com/users/yesodweb/events{/privacy}","received_events_url":"https://api.github.com/users/yesodweb/received_events","type":"Organization","site_admin":false},"repo":{"id":237904,"name":"yesod","full_name":"yesodweb/yesod","owner":{"login":"yesodweb","id":930379,"avatar_url":"https://avatars.githubusercontent.com/u/930379?v=3","gravatar_id":"","url":"https://api.github.com/users/yesodweb","html_url":"https://github.com/yesodweb","followers_url":"https://api.github.com/users/yesodweb/followers","following_url":"https://api.github.com/users/yesodweb/following{/other_user}","gists_url":"https://api.github.com/users/yesodweb/gists{/gist_id}","starred_url":"https://api.github.com/users/yesodweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesodweb/subscriptions","organizations_url":"https://api.github.com/users/yesodweb/orgs","repos_url":"https://api.github.com/users/yesodweb/repos","events_url":"https://api.github.com/users/yesodweb/events{/privacy}","received_events_url":"https://api.github.com/users/yesodweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yesodweb/yesod","description":"A RESTful Haskell web framework built on WAI.","fork":false,"url":"https://api.github.com/repos/yesodweb/yesod","forks_url":"https://api.github.com/repos/yesodweb/yesod/forks","keys_url":"https://api.github.com/repos/yesodweb/yesod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yesodweb/yesod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yesodweb/yesod/teams","hooks_url":"https://api.github.com/repos/yesodweb/yesod/hooks","issue_events_url":"https://api.github.com/repos/yesodweb/yesod/issues/events{/number}","events_url":"https://api.github.com/repos/yesodweb/yesod/events","assignees_url":"https://api.github.com/repos/yesodweb/yesod/assignees{/user}","branches_url":"https://api.github.com/repos/yesodweb/yesod/branches{/branch}","tags_url":"https://api.github.com/repos/yesodweb/yesod/tags","blobs_url":"https://api.github.com/repos/yesodweb/yesod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yesodweb/yesod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yesodweb/yesod/git/refs{/sha}","trees_url":"https://api.github.com/repos/yesodweb/yesod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yesodweb/yesod/statuses/{sha}","languages_url":"https://api.github.com/repos/yesodweb/yesod/languages","stargazers_url":"https://api.github.com/repos/yesodweb/yesod/stargazers","contributors_url":"https://api.github.com/repos/yesodweb/yesod/contributors","subscribers_url":"https://api.github.com/repos/yesodweb/yesod/subscribers","subscription_url":"https://api.github.com/repos/yesodweb/yesod/subscription","commits_url":"https://api.github.com/repos/yesodweb/yesod/commits{/sha}","git_commits_url":"https://api.github.com/repos/yesodweb/yesod/git/commits{/sha}","comments_url":"https://api.github.com/repos/yesodweb/yesod/comments{/number}","issue_comment_url":"https://api.github.com/repos/yesodweb/yesod/issues/comments{/number}","contents_url":"https://api.github.com/repos/yesodweb/yesod/contents/{+path}","compare_url":"https://api.github.com/repos/yesodweb/yesod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yesodweb/yesod/merges","archive_url":"https://api.github.com/repos/yesodweb/yesod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yesodweb/yesod/downloads","issues_url":"https://api.github.com/repos/yesodweb/yesod/issues{/number}","pulls_url":"https://api.github.com/repos/yesodweb/yesod/pulls{/number}","milestones_url":"https://api.github.com/repos/yesodweb/yesod/milestones{/number}","notifications_url":"https://api.github.com/repos/yesodweb/yesod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yesodweb/yesod/labels{/name}","releases_url":"https://api.github.com/repos/yesodweb/yesod/releases{/id}","created_at":"2009-06-27T22:54:51Z","updated_at":"2015-06-04T06:37:00Z","pushed_at":"2015-06-07T23:48:36Z","git_url":"git://github.com/yesodweb/yesod.git","ssh_url":"git@github.com:yesodweb/yesod.git","clone_url":"https://github.com/yesodweb/yesod.git","svn_url":"https://github.com/yesodweb/yesod","homepage":"http://www.yesodweb.com/","size":14372,"stargazers_count":1186,"watchers_count":1186,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":218,"mirror_url":null,"open_issues_count":53,"forks":218,"open_issues":53,"watchers":1186,"default_branch":"master"}},"base":{"label":"yesodweb:master","ref":"master","sha":"814157a018a0a84c111eb052d19cb19486c34f10","user":{"login":"yesodweb","id":930379,"avatar_url":"https://avatars.githubusercontent.com/u/930379?v=3","gravatar_id":"","url":"https://api.github.com/users/yesodweb","html_url":"https://github.com/yesodweb","followers_url":"https://api.github.com/users/yesodweb/followers","following_url":"https://api.github.com/users/yesodweb/following{/other_user}","gists_url":"https://api.github.com/users/yesodweb/gists{/gist_id}","starred_url":"https://api.github.com/users/yesodweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesodweb/subscriptions","organizations_url":"https://api.github.com/users/yesodweb/orgs","repos_url":"https://api.github.com/users/yesodweb/repos","events_url":"https://api.github.com/users/yesodweb/events{/privacy}","received_events_url":"https://api.github.com/users/yesodweb/received_events","type":"Organization","site_admin":false},"repo":{"id":237904,"name":"yesod","full_name":"yesodweb/yesod","owner":{"login":"yesodweb","id":930379,"avatar_url":"https://avatars.githubusercontent.com/u/930379?v=3","gravatar_id":"","url":"https://api.github.com/users/yesodweb","html_url":"https://github.com/yesodweb","followers_url":"https://api.github.com/users/yesodweb/followers","following_url":"https://api.github.com/users/yesodweb/following{/other_user}","gists_url":"https://api.github.com/users/yesodweb/gists{/gist_id}","starred_url":"https://api.github.com/users/yesodweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesodweb/subscriptions","organizations_url":"https://api.github.com/users/yesodweb/orgs","repos_url":"https://api.github.com/users/yesodweb/repos","events_url":"https://api.github.com/users/yesodweb/events{/privacy}","received_events_url":"https://api.github.com/users/yesodweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yesodweb/yesod","description":"A RESTful Haskell web framework built on WAI.","fork":false,"url":"https://api.github.com/repos/yesodweb/yesod","forks_url":"https://api.github.com/repos/yesodweb/yesod/forks","keys_url":"https://api.github.com/repos/yesodweb/yesod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yesodweb/yesod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yesodweb/yesod/teams","hooks_url":"https://api.github.com/repos/yesodweb/yesod/hooks","issue_events_url":"https://api.github.com/repos/yesodweb/yesod/issues/events{/number}","events_url":"https://api.github.com/repos/yesodweb/yesod/events","assignees_url":"https://api.github.com/repos/yesodweb/yesod/assignees{/user}","branches_url":"https://api.github.com/repos/yesodweb/yesod/branches{/branch}","tags_url":"https://api.github.com/repos/yesodweb/yesod/tags","blobs_url":"https://api.github.com/repos/yesodweb/yesod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yesodweb/yesod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yesodweb/yesod/git/refs{/sha}","trees_url":"https://api.github.com/repos/yesodweb/yesod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yesodweb/yesod/statuses/{sha}","languages_url":"https://api.github.com/repos/yesodweb/yesod/languages","stargazers_url":"https://api.github.com/repos/yesodweb/yesod/stargazers","contributors_url":"https://api.github.com/repos/yesodweb/yesod/contributors","subscribers_url":"https://api.github.com/repos/yesodweb/yesod/subscribers","subscription_url":"https://api.github.com/repos/yesodweb/yesod/subscription","commits_url":"https://api.github.com/repos/yesodweb/yesod/commits{/sha}","git_commits_url":"https://api.github.com/repos/yesodweb/yesod/git/commits{/sha}","comments_url":"https://api.github.com/repos/yesodweb/yesod/comments{/number}","issue_comment_url":"https://api.github.com/repos/yesodweb/yesod/issues/comments{/number}","contents_url":"https://api.github.com/repos/yesodweb/yesod/contents/{+path}","compare_url":"https://api.github.com/repos/yesodweb/yesod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yesodweb/yesod/merges","archive_url":"https://api.github.com/repos/yesodweb/yesod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yesodweb/yesod/downloads","issues_url":"https://api.github.com/repos/yesodweb/yesod/issues{/number}","pulls_url":"https://api.github.com/repos/yesodweb/yesod/pulls{/number}","milestones_url":"https://api.github.com/repos/yesodweb/yesod/milestones{/number}","notifications_url":"https://api.github.com/repos/yesodweb/yesod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yesodweb/yesod/labels{/name}","releases_url":"https://api.github.com/repos/yesodweb/yesod/releases{/id}","created_at":"2009-06-27T22:54:51Z","updated_at":"2015-06-04T06:37:00Z","pushed_at":"2015-06-07T23:48:36Z","git_url":"git://github.com/yesodweb/yesod.git","ssh_url":"git@github.com:yesodweb/yesod.git","clone_url":"https://github.com/yesodweb/yesod.git","svn_url":"https://github.com/yesodweb/yesod","homepage":"http://www.yesodweb.com/","size":14372,"stargazers_count":1186,"watchers_count":1186,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":218,"mirror_url":null,"open_issues_count":53,"forks":218,"open_issues":53,"watchers":1186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yesodweb/yesod/pulls/993"},"html":{"href":"https://github.com/yesodweb/yesod/pull/993"},"issue":{"href":"https://api.github.com/repos/yesodweb/yesod/issues/993"},"comments":{"href":"https://api.github.com/repos/yesodweb/yesod/issues/993/comments"},"review_comments":{"href":"https://api.github.com/repos/yesodweb/yesod/pulls/993/comments"},"review_comment":{"href":"https://api.github.com/repos/yesodweb/yesod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yesodweb/yesod/pulls/993/commits"},"statuses":{"href":"https://api.github.com/repos/yesodweb/yesod/statuses/09ff86c008b9be965bf7b0507f18c1108b7cb081"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":26,"review_comments":0,"commits":12,"additions":1045,"deletions":673,"changed_files":31}}