{"action":"created","issue":{"url":"https://api.github.com/repos/bryankeller/BLKFlexibleHeightBar/issues/29","labels_url":"https://api.github.com/repos/bryankeller/BLKFlexibleHeightBar/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/bryankeller/BLKFlexibleHeightBar/issues/29/comments","events_url":"https://api.github.com/repos/bryankeller/BLKFlexibleHeightBar/issues/29/events","html_url":"https://github.com/bryankeller/BLKFlexibleHeightBar/pull/29","id":70894942,"number":29,"title":"Fix for tableView headers","user":{"login":"palcalde","id":1252619,"avatar_url":"https://avatars.githubusercontent.com/u/1252619?v=3","gravatar_id":"","url":"https://api.github.com/users/palcalde","html_url":"https://github.com/palcalde","followers_url":"https://api.github.com/users/palcalde/followers","following_url":"https://api.github.com/users/palcalde/following{/other_user}","gists_url":"https://api.github.com/users/palcalde/gists{/gist_id}","starred_url":"https://api.github.com/users/palcalde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palcalde/subscriptions","organizations_url":"https://api.github.com/users/palcalde/orgs","repos_url":"https://api.github.com/users/palcalde/repos","events_url":"https://api.github.com/users/palcalde/events{/privacy}","received_events_url":"https://api.github.com/users/palcalde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-04-25T11:26:32Z","updated_at":"2015-11-10T21:16:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bryankeller/BLKFlexibleHeightBar/pulls/29","html_url":"https://github.com/bryankeller/BLKFlexibleHeightBar/pull/29","diff_url":"https://github.com/bryankeller/BLKFlexibleHeightBar/pull/29.diff","patch_url":"https://github.com/bryankeller/BLKFlexibleHeightBar/pull/29.patch"},"body":"@bryankeller This solves the issues with the tableView headers in https://github.com/bryankeller/BLKFlexibleHeightBar/issues/8\r\nand maybe in (didn't test it) https://github.com/bryankeller/BLKFlexibleHeightBar/issues/14\r\n\r\nSection headers in UITableView are based on contentInset. If the bar shrinks, the tableView needs to have contentInset udpated in order to have the headers scroll smoothly.\r\n\r\nI don't think there is a need to change the contentInset for all UIScrollView's (just for the ones that are UITableViews) so I created one initializer in the bar to pass the tableview. This way people can still use the regular initializer you created for UIScrollViews.\r\n\r\nFinally, I had to change scrollViewDidScroll of SquareCashStyleBehaviorDefiner. It was doing a check based on the contentInset and since that changes now, it didn't work well. Now is based on the max bar height which works great.\r\n\r\nHope this helps!"},"comment":{"url":"https://api.github.com/repos/bryankeller/BLKFlexibleHeightBar/issues/comments/155569487","html_url":"https://github.com/bryankeller/BLKFlexibleHeightBar/pull/29#issuecomment-155569487","issue_url":"https://api.github.com/repos/bryankeller/BLKFlexibleHeightBar/issues/29","id":155569487,"user":{"login":"asterhouse","id":13340954,"avatar_url":"https://avatars.githubusercontent.com/u/13340954?v=3","gravatar_id":"","url":"https://api.github.com/users/asterhouse","html_url":"https://github.com/asterhouse","followers_url":"https://api.github.com/users/asterhouse/followers","following_url":"https://api.github.com/users/asterhouse/following{/other_user}","gists_url":"https://api.github.com/users/asterhouse/gists{/gist_id}","starred_url":"https://api.github.com/users/asterhouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterhouse/subscriptions","organizations_url":"https://api.github.com/users/asterhouse/orgs","repos_url":"https://api.github.com/users/asterhouse/repos","events_url":"https://api.github.com/users/asterhouse/events{/privacy}","received_events_url":"https://api.github.com/users/asterhouse/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T21:16:48Z","updated_at":"2015-11-10T21:16:48Z","body":"It sounds like you all have been really busy, but I had a question about this fix. Currently this assumes we will be using initWithFrame. If we are getting the layout from a xib file, would the best way to modify this be to create a setTableView method for the bar object?"}}