{"action":"opened","number":20,"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/pulls/20","id":32046092,"html_url":"https://github.com/logstash-plugins/logstash-filter-grok/pull/20","diff_url":"https://github.com/logstash-plugins/logstash-filter-grok/pull/20.diff","patch_url":"https://github.com/logstash-plugins/logstash-filter-grok/pull/20.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/20","number":20,"state":"open","locked":false,"title":"Make sure we respect nil values with coercion. See #2897","user":{"login":"suyograo","id":1595958,"avatar_url":"https://avatars.githubusercontent.com/u/1595958?v=3","gravatar_id":"","url":"https://api.github.com/users/suyograo","html_url":"https://github.com/suyograo","followers_url":"https://api.github.com/users/suyograo/followers","following_url":"https://api.github.com/users/suyograo/following{/other_user}","gists_url":"https://api.github.com/users/suyograo/gists{/gist_id}","starred_url":"https://api.github.com/users/suyograo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suyograo/subscriptions","organizations_url":"https://api.github.com/users/suyograo/orgs","repos_url":"https://api.github.com/users/suyograo/repos","events_url":"https://api.github.com/users/suyograo/events{/privacy}","received_events_url":"https://api.github.com/users/suyograo/received_events","type":"User","site_admin":false},"body":"This fixes a regression we introduced with the grok optimization changes\r\n\r\n```\r\n# 1.4.2\r\n$ ./logstash-1.4.2/bin/logstash --config testcase.conf \r\n{\"message\":\"test N/A\"}\r\n{\"message\":\"test 24.8ms\",\"duration\":24.8}\r\n\r\n# 1.5.0.rc2\r\n$ ./logstash-1.5.0.rc2/bin/logstash --config testcase.conf\r\n{\"message\":\"test N/A\",\"duration\":0.0}\r\n{\"message\":\"test 24.8ms\",\"duration\":24.8}\r\n```\r\n\r\nI ran the tests by pointing to my local gem from the source (in Gemfile)\r\n\r\n```\r\nsuyog@machine:~/ws/ls_plugins/logstash-filter-grok (fix/2897)$ bundle exec rspec\r\nUsing Accessor#strict_set for specs\r\nRun options: exclude {:redis=>true, :socket=>true, :performance=>true, :couchdb=>true, :elasticsearch=>true, :elasticsearch_secure=>true, :broken=>true, :export_cypher=>true, :integration=>true, :windows=>true}\r\n.........................................................................................\r\n\r\nFinished in 3.24 seconds\r\n89 examples, 0 failures\r\n\r\nRandomized with seed 6841\r\n```","created_at":"2015-03-26T18:22:43Z","updated_at":"2015-03-26T18:22:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/pulls/20/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/pulls/20/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/20/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/statuses/ee083d88dd66a960bb817cf2c35e9f7c1914a067","head":{"label":"suyograo:fix/2897","ref":"fix/2897","sha":"ee083d88dd66a960bb817cf2c35e9f7c1914a067","user":{"login":"suyograo","id":1595958,"avatar_url":"https://avatars.githubusercontent.com/u/1595958?v=3","gravatar_id":"","url":"https://api.github.com/users/suyograo","html_url":"https://github.com/suyograo","followers_url":"https://api.github.com/users/suyograo/followers","following_url":"https://api.github.com/users/suyograo/following{/other_user}","gists_url":"https://api.github.com/users/suyograo/gists{/gist_id}","starred_url":"https://api.github.com/users/suyograo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suyograo/subscriptions","organizations_url":"https://api.github.com/users/suyograo/orgs","repos_url":"https://api.github.com/users/suyograo/repos","events_url":"https://api.github.com/users/suyograo/events{/privacy}","received_events_url":"https://api.github.com/users/suyograo/received_events","type":"User","site_admin":false},"repo":{"id":32940102,"name":"logstash-filter-grok","full_name":"suyograo/logstash-filter-grok","owner":{"login":"suyograo","id":1595958,"avatar_url":"https://avatars.githubusercontent.com/u/1595958?v=3","gravatar_id":"","url":"https://api.github.com/users/suyograo","html_url":"https://github.com/suyograo","followers_url":"https://api.github.com/users/suyograo/followers","following_url":"https://api.github.com/users/suyograo/following{/other_user}","gists_url":"https://api.github.com/users/suyograo/gists{/gist_id}","starred_url":"https://api.github.com/users/suyograo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suyograo/subscriptions","organizations_url":"https://api.github.com/users/suyograo/orgs","repos_url":"https://api.github.com/users/suyograo/repos","events_url":"https://api.github.com/users/suyograo/events{/privacy}","received_events_url":"https://api.github.com/users/suyograo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/suyograo/logstash-filter-grok","description":"patterns_path","fork":true,"url":"https://api.github.com/repos/suyograo/logstash-filter-grok","forks_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/forks","keys_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/teams","hooks_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/hooks","issue_events_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/issues/events{/number}","events_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/events","assignees_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/assignees{/user}","branches_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/branches{/branch}","tags_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/tags","blobs_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/git/refs{/sha}","trees_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/statuses/{sha}","languages_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/languages","stargazers_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/stargazers","contributors_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/contributors","subscribers_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/subscribers","subscription_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/subscription","commits_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/commits{/sha}","git_commits_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/git/commits{/sha}","comments_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/comments{/number}","issue_comment_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/issues/comments{/number}","contents_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/contents/{+path}","compare_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/merges","archive_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/downloads","issues_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/issues{/number}","pulls_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/pulls{/number}","milestones_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/milestones{/number}","notifications_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/labels{/name}","releases_url":"https://api.github.com/repos/suyograo/logstash-filter-grok/releases{/id}","created_at":"2015-03-26T16:49:38Z","updated_at":"2015-03-26T16:49:39Z","pushed_at":"2015-03-26T18:19:34Z","git_url":"git://github.com/suyograo/logstash-filter-grok.git","ssh_url":"git@github.com:suyograo/logstash-filter-grok.git","clone_url":"https://github.com/suyograo/logstash-filter-grok.git","svn_url":"https://github.com/suyograo/logstash-filter-grok","homepage":"","size":360,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"068ba34d7089c617203f4a14db9ce2ed05f0f984","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":24894902,"name":"logstash-filter-grok","full_name":"logstash-plugins/logstash-filter-grok","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-filter-grok","description":"patterns_path","fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/releases{/id}","created_at":"2014-10-07T14:46:44Z","updated_at":"2015-03-03T15:43:16Z","pushed_at":"2015-03-03T15:45:18Z","git_url":"git://github.com/logstash-plugins/logstash-filter-grok.git","ssh_url":"git@github.com:logstash-plugins/logstash-filter-grok.git","clone_url":"https://github.com/logstash-plugins/logstash-filter-grok.git","svn_url":"https://github.com/logstash-plugins/logstash-filter-grok","homepage":"","size":360,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/pulls/20"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-grok/pull/20"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/20"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/statuses/ee083d88dd66a960bb817cf2c35e9f7c1914a067"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":54,"deletions":9,"changed_files":3}}