{"action":"closed","number":44,"pull_request":{"url":"https://api.github.com/repos/kabisaict/maji/pulls/44","id":35759863,"html_url":"https://github.com/kabisaict/maji/pull/44","diff_url":"https://github.com/kabisaict/maji/pull/44.diff","patch_url":"https://github.com/kabisaict/maji/pull/44.patch","issue_url":"https://api.github.com/repos/kabisaict/maji/issues/44","number":44,"state":"closed","locked":false,"title":"Add a polyfill for Function.bind in Phantomjs","user":{"login":"pascalw","id":304603,"avatar_url":"https://avatars.githubusercontent.com/u/304603?v=3","gravatar_id":"","url":"https://api.github.com/users/pascalw","html_url":"https://github.com/pascalw","followers_url":"https://api.github.com/users/pascalw/followers","following_url":"https://api.github.com/users/pascalw/following{/other_user}","gists_url":"https://api.github.com/users/pascalw/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalw/subscriptions","organizations_url":"https://api.github.com/users/pascalw/orgs","repos_url":"https://api.github.com/users/pascalw/repos","events_url":"https://api.github.com/users/pascalw/events{/privacy}","received_events_url":"https://api.github.com/users/pascalw/received_events","type":"User","site_admin":false},"body":"This addresses an issue @stefanvr was having; when running rspec against a livereload enabled server (or you're using any library that uses `Function.bind`) rspec will fail with the following error:\r\n\r\n```\r\n  1) Hello world shows a greeting\r\n     Failure/Error: visit '/index.html'\r\n     Capybara::Poltergeist::JavascriptError:\r\n       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).\r\n\r\n       TypeError: 'undefined' is not a function (evaluating 'this.window.console.error.bind(this.window.console)')\r\n       TypeError: 'undefined' is not a function (evaluating 'this.window.console.error.bind(this.window.console)')\r\n           at http://localhost:35729/livereload.js?snipver=1:301 in LiveReload\r\n           at http://localhost:35729/livereload.js?snipver=1:1111\r\n           at http://localhost:35729/livereload.js?snipver=1:1137\r\n           at http://localhost:35729/livereload.js?snipver=1:1 in s\r\n           at http://localhost:35729/livereload.js?snipver=1:1 in e\r\n           at http://localhost:35729/livereload.js?snipver=1:1183\r\n     # ./spec/features/welcome_spec.rb:5:in `block (2 levels) in <top (required)>'\r\n```\r\n\r\nThis is due to the fact that Phantomjs 1.x doesn't support `Function.bind`. This PR adds a polyfill that will add `Function.bind` if it's not available.\r\n\r\nNote that Phantomjs 2.x **does** support `Function.bind` so you won't have this issue if you're on Phantomjs 2.x. Phantomjs 2.x is however still in it's infancy, specially with Linux support.","created_at":"2015-05-19T18:25:47Z","updated_at":"2015-05-21T10:28:46Z","closed_at":"2015-05-21T10:28:46Z","merged_at":"2015-05-21T10:28:46Z","merge_commit_sha":"c36ed496aeddf05f50c74151787af8c6493f8517","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kabisaict/maji/pulls/44/commits","review_comments_url":"https://api.github.com/repos/kabisaict/maji/pulls/44/comments","review_comment_url":"https://api.github.com/repos/kabisaict/maji/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kabisaict/maji/issues/44/comments","statuses_url":"https://api.github.com/repos/kabisaict/maji/statuses/4c1639e432b5ac814a4bfa481dbe49ab27416b8e","head":{"label":"kabisaict:feature-function-bind-polyfill-for-phantomjs","ref":"feature-function-bind-polyfill-for-phantomjs","sha":"4c1639e432b5ac814a4bfa481dbe49ab27416b8e","user":{"login":"kabisaict","id":1531725,"avatar_url":"https://avatars.githubusercontent.com/u/1531725?v=3","gravatar_id":"","url":"https://api.github.com/users/kabisaict","html_url":"https://github.com/kabisaict","followers_url":"https://api.github.com/users/kabisaict/followers","following_url":"https://api.github.com/users/kabisaict/following{/other_user}","gists_url":"https://api.github.com/users/kabisaict/gists{/gist_id}","starred_url":"https://api.github.com/users/kabisaict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabisaict/subscriptions","organizations_url":"https://api.github.com/users/kabisaict/orgs","repos_url":"https://api.github.com/users/kabisaict/repos","events_url":"https://api.github.com/users/kabisaict/events{/privacy}","received_events_url":"https://api.github.com/users/kabisaict/received_events","type":"Organization","site_admin":false},"repo":{"id":31175060,"name":"maji","full_name":"kabisaict/maji","owner":{"login":"kabisaict","id":1531725,"avatar_url":"https://avatars.githubusercontent.com/u/1531725?v=3","gravatar_id":"","url":"https://api.github.com/users/kabisaict","html_url":"https://github.com/kabisaict","followers_url":"https://api.github.com/users/kabisaict/followers","following_url":"https://api.github.com/users/kabisaict/following{/other_user}","gists_url":"https://api.github.com/users/kabisaict/gists{/gist_id}","starred_url":"https://api.github.com/users/kabisaict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabisaict/subscriptions","organizations_url":"https://api.github.com/users/kabisaict/orgs","repos_url":"https://api.github.com/users/kabisaict/repos","events_url":"https://api.github.com/users/kabisaict/events{/privacy}","received_events_url":"https://api.github.com/users/kabisaict/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kabisaict/maji","description":"Repo for the Maji mobile framework","fork":false,"url":"https://api.github.com/repos/kabisaict/maji","forks_url":"https://api.github.com/repos/kabisaict/maji/forks","keys_url":"https://api.github.com/repos/kabisaict/maji/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kabisaict/maji/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kabisaict/maji/teams","hooks_url":"https://api.github.com/repos/kabisaict/maji/hooks","issue_events_url":"https://api.github.com/repos/kabisaict/maji/issues/events{/number}","events_url":"https://api.github.com/repos/kabisaict/maji/events","assignees_url":"https://api.github.com/repos/kabisaict/maji/assignees{/user}","branches_url":"https://api.github.com/repos/kabisaict/maji/branches{/branch}","tags_url":"https://api.github.com/repos/kabisaict/maji/tags","blobs_url":"https://api.github.com/repos/kabisaict/maji/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kabisaict/maji/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kabisaict/maji/git/refs{/sha}","trees_url":"https://api.github.com/repos/kabisaict/maji/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kabisaict/maji/statuses/{sha}","languages_url":"https://api.github.com/repos/kabisaict/maji/languages","stargazers_url":"https://api.github.com/repos/kabisaict/maji/stargazers","contributors_url":"https://api.github.com/repos/kabisaict/maji/contributors","subscribers_url":"https://api.github.com/repos/kabisaict/maji/subscribers","subscription_url":"https://api.github.com/repos/kabisaict/maji/subscription","commits_url":"https://api.github.com/repos/kabisaict/maji/commits{/sha}","git_commits_url":"https://api.github.com/repos/kabisaict/maji/git/commits{/sha}","comments_url":"https://api.github.com/repos/kabisaict/maji/comments{/number}","issue_comment_url":"https://api.github.com/repos/kabisaict/maji/issues/comments{/number}","contents_url":"https://api.github.com/repos/kabisaict/maji/contents/{+path}","compare_url":"https://api.github.com/repos/kabisaict/maji/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kabisaict/maji/merges","archive_url":"https://api.github.com/repos/kabisaict/maji/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kabisaict/maji/downloads","issues_url":"https://api.github.com/repos/kabisaict/maji/issues{/number}","pulls_url":"https://api.github.com/repos/kabisaict/maji/pulls{/number}","milestones_url":"https://api.github.com/repos/kabisaict/maji/milestones{/number}","notifications_url":"https://api.github.com/repos/kabisaict/maji/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kabisaict/maji/labels{/name}","releases_url":"https://api.github.com/repos/kabisaict/maji/releases{/id}","created_at":"2015-02-22T18:58:44Z","updated_at":"2015-05-13T08:07:13Z","pushed_at":"2015-05-21T10:28:46Z","git_url":"git://github.com/kabisaict/maji.git","ssh_url":"git@github.com:kabisaict/maji.git","clone_url":"https://github.com/kabisaict/maji.git","svn_url":"https://github.com/kabisaict/maji","homepage":null,"size":1212,"stargazers_count":3,"watchers_count":3,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":18,"forks":1,"open_issues":18,"watchers":3,"default_branch":"develop"}},"base":{"label":"kabisaict:develop","ref":"develop","sha":"4bd0609987040edb8f053b7a4e9e1651a523c704","user":{"login":"kabisaict","id":1531725,"avatar_url":"https://avatars.githubusercontent.com/u/1531725?v=3","gravatar_id":"","url":"https://api.github.com/users/kabisaict","html_url":"https://github.com/kabisaict","followers_url":"https://api.github.com/users/kabisaict/followers","following_url":"https://api.github.com/users/kabisaict/following{/other_user}","gists_url":"https://api.github.com/users/kabisaict/gists{/gist_id}","starred_url":"https://api.github.com/users/kabisaict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabisaict/subscriptions","organizations_url":"https://api.github.com/users/kabisaict/orgs","repos_url":"https://api.github.com/users/kabisaict/repos","events_url":"https://api.github.com/users/kabisaict/events{/privacy}","received_events_url":"https://api.github.com/users/kabisaict/received_events","type":"Organization","site_admin":false},"repo":{"id":31175060,"name":"maji","full_name":"kabisaict/maji","owner":{"login":"kabisaict","id":1531725,"avatar_url":"https://avatars.githubusercontent.com/u/1531725?v=3","gravatar_id":"","url":"https://api.github.com/users/kabisaict","html_url":"https://github.com/kabisaict","followers_url":"https://api.github.com/users/kabisaict/followers","following_url":"https://api.github.com/users/kabisaict/following{/other_user}","gists_url":"https://api.github.com/users/kabisaict/gists{/gist_id}","starred_url":"https://api.github.com/users/kabisaict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabisaict/subscriptions","organizations_url":"https://api.github.com/users/kabisaict/orgs","repos_url":"https://api.github.com/users/kabisaict/repos","events_url":"https://api.github.com/users/kabisaict/events{/privacy}","received_events_url":"https://api.github.com/users/kabisaict/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kabisaict/maji","description":"Repo for the Maji mobile framework","fork":false,"url":"https://api.github.com/repos/kabisaict/maji","forks_url":"https://api.github.com/repos/kabisaict/maji/forks","keys_url":"https://api.github.com/repos/kabisaict/maji/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kabisaict/maji/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kabisaict/maji/teams","hooks_url":"https://api.github.com/repos/kabisaict/maji/hooks","issue_events_url":"https://api.github.com/repos/kabisaict/maji/issues/events{/number}","events_url":"https://api.github.com/repos/kabisaict/maji/events","assignees_url":"https://api.github.com/repos/kabisaict/maji/assignees{/user}","branches_url":"https://api.github.com/repos/kabisaict/maji/branches{/branch}","tags_url":"https://api.github.com/repos/kabisaict/maji/tags","blobs_url":"https://api.github.com/repos/kabisaict/maji/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kabisaict/maji/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kabisaict/maji/git/refs{/sha}","trees_url":"https://api.github.com/repos/kabisaict/maji/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kabisaict/maji/statuses/{sha}","languages_url":"https://api.github.com/repos/kabisaict/maji/languages","stargazers_url":"https://api.github.com/repos/kabisaict/maji/stargazers","contributors_url":"https://api.github.com/repos/kabisaict/maji/contributors","subscribers_url":"https://api.github.com/repos/kabisaict/maji/subscribers","subscription_url":"https://api.github.com/repos/kabisaict/maji/subscription","commits_url":"https://api.github.com/repos/kabisaict/maji/commits{/sha}","git_commits_url":"https://api.github.com/repos/kabisaict/maji/git/commits{/sha}","comments_url":"https://api.github.com/repos/kabisaict/maji/comments{/number}","issue_comment_url":"https://api.github.com/repos/kabisaict/maji/issues/comments{/number}","contents_url":"https://api.github.com/repos/kabisaict/maji/contents/{+path}","compare_url":"https://api.github.com/repos/kabisaict/maji/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kabisaict/maji/merges","archive_url":"https://api.github.com/repos/kabisaict/maji/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kabisaict/maji/downloads","issues_url":"https://api.github.com/repos/kabisaict/maji/issues{/number}","pulls_url":"https://api.github.com/repos/kabisaict/maji/pulls{/number}","milestones_url":"https://api.github.com/repos/kabisaict/maji/milestones{/number}","notifications_url":"https://api.github.com/repos/kabisaict/maji/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kabisaict/maji/labels{/name}","releases_url":"https://api.github.com/repos/kabisaict/maji/releases{/id}","created_at":"2015-02-22T18:58:44Z","updated_at":"2015-05-13T08:07:13Z","pushed_at":"2015-05-21T10:28:46Z","git_url":"git://github.com/kabisaict/maji.git","ssh_url":"git@github.com:kabisaict/maji.git","clone_url":"https://github.com/kabisaict/maji.git","svn_url":"https://github.com/kabisaict/maji","homepage":null,"size":1212,"stargazers_count":3,"watchers_count":3,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":18,"forks":1,"open_issues":18,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/kabisaict/maji/pulls/44"},"html":{"href":"https://github.com/kabisaict/maji/pull/44"},"issue":{"href":"https://api.github.com/repos/kabisaict/maji/issues/44"},"comments":{"href":"https://api.github.com/repos/kabisaict/maji/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/kabisaict/maji/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/kabisaict/maji/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kabisaict/maji/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/kabisaict/maji/statuses/4c1639e432b5ac814a4bfa481dbe49ab27416b8e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pascalw","id":304603,"avatar_url":"https://avatars.githubusercontent.com/u/304603?v=3","gravatar_id":"","url":"https://api.github.com/users/pascalw","html_url":"https://github.com/pascalw","followers_url":"https://api.github.com/users/pascalw/followers","following_url":"https://api.github.com/users/pascalw/following{/other_user}","gists_url":"https://api.github.com/users/pascalw/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalw/subscriptions","organizations_url":"https://api.github.com/users/pascalw/orgs","repos_url":"https://api.github.com/users/pascalw/repos","events_url":"https://api.github.com/users/pascalw/events{/privacy}","received_events_url":"https://api.github.com/users/pascalw/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":31,"deletions":0,"changed_files":2}}