{"action":"created","comment":{"url":"https://api.github.com/repos/kangax/fabric.js/pulls/comments/47015226","id":47015226,"diff_hunk":"@@ -111,23 +111,24 @@\n      * @return {String} SVG representation of a shadow\n      */\n     toSVG: function(object) {\n-      var fBoxX = 40, fBoxY = 40,\n+      var fBoxX = 40, fBoxY = 40, NUM_FRACTION_DIGITS = fabric.Object.NUM_FRACTION_DIGITS,\n           offset = fabric.util.rotateVector({x: this.offsetX, y: this.offsetY},\n             fabric.util.degreesToRadians(-object.angle));\n \n       if (object.width && object.height) {\n         //http://www.w3.org/TR/SVG/filters.html#FilterEffectsRegion\n         // we add some extra space to filter box to contain the blur ( 20 )\n-        fBoxX = toFixed((Math.abs(offset.x) + this.blur) / object.width, 2) * 100 + 20;\n-        fBoxY = toFixed((Math.abs(offset.y) + this.blur) / object.height, 2) * 100 + 20;\n+        fBoxX = toFixed((Math.abs(offset.x) + this.blur) / object.width, NUM_FRACTION_DIGITS) * 100 + 20;","path":"src/shadow.class.js","position":14,"original_position":14,"commit_id":"411c8b446a700a9876f7ebf864086812954c6ae0","original_commit_id":"411c8b446a700a9876f7ebf864086812954c6ae0","user":{"login":"kangax","id":383,"avatar_url":"https://avatars.githubusercontent.com/u/383?v=3","gravatar_id":"","url":"https://api.github.com/users/kangax","html_url":"https://github.com/kangax","followers_url":"https://api.github.com/users/kangax/followers","following_url":"https://api.github.com/users/kangax/following{/other_user}","gists_url":"https://api.github.com/users/kangax/gists{/gist_id}","starred_url":"https://api.github.com/users/kangax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangax/subscriptions","organizations_url":"https://api.github.com/users/kangax/orgs","repos_url":"https://api.github.com/users/kangax/repos","events_url":"https://api.github.com/users/kangax/events{/privacy}","received_events_url":"https://api.github.com/users/kangax/received_events","type":"User","site_admin":false},"body":"Let's store 20 in a BLUR or something like that, for clarity","created_at":"2015-12-08T21:21:09Z","updated_at":"2015-12-08T21:21:09Z","html_url":"https://github.com/kangax/fabric.js/pull/2672#discussion_r47015226","pull_request_url":"https://api.github.com/repos/kangax/fabric.js/pulls/2672","_links":{"self":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/comments/47015226"},"html":{"href":"https://github.com/kangax/fabric.js/pull/2672#discussion_r47015226"},"pull_request":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/2672"}}},"pull_request":{"url":"https://api.github.com/repos/kangax/fabric.js/pulls/2672","id":52968874,"html_url":"https://github.com/kangax/fabric.js/pull/2672","diff_url":"https://github.com/kangax/fabric.js/pull/2672.diff","patch_url":"https://github.com/kangax/fabric.js/pull/2672.patch","issue_url":"https://api.github.com/repos/kangax/fabric.js/issues/2672","number":2672,"state":"open","locked":false,"title":"Shadow to svg fixed test","user":{"login":"asturur","id":1194048,"avatar_url":"https://avatars.githubusercontent.com/u/1194048?v=3","gravatar_id":"","url":"https://api.github.com/users/asturur","html_url":"https://github.com/asturur","followers_url":"https://api.github.com/users/asturur/followers","following_url":"https://api.github.com/users/asturur/following{/other_user}","gists_url":"https://api.github.com/users/asturur/gists{/gist_id}","starred_url":"https://api.github.com/users/asturur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturur/subscriptions","organizations_url":"https://api.github.com/users/asturur/orgs","repos_url":"https://api.github.com/users/asturur/repos","events_url":"https://api.github.com/users/asturur/events{/privacy}","received_events_url":"https://api.github.com/users/asturur/received_events","type":"User","site_admin":false},"body":"Using NUM_FRACTION_DIGITS for consistency and to fix the test.\r\n(avoid 8.1412543e-16)","created_at":"2015-12-08T11:30:01Z","updated_at":"2015-12-08T21:21:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c52a86263439e1b5eefed769d3b53e1784b16664","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kangax/fabric.js/pulls/2672/commits","review_comments_url":"https://api.github.com/repos/kangax/fabric.js/pulls/2672/comments","review_comment_url":"https://api.github.com/repos/kangax/fabric.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kangax/fabric.js/issues/2672/comments","statuses_url":"https://api.github.com/repos/kangax/fabric.js/statuses/411c8b446a700a9876f7ebf864086812954c6ae0","head":{"label":"asturur:shadow_to_s","ref":"shadow_to_s","sha":"411c8b446a700a9876f7ebf864086812954c6ae0","user":{"login":"asturur","id":1194048,"avatar_url":"https://avatars.githubusercontent.com/u/1194048?v=3","gravatar_id":"","url":"https://api.github.com/users/asturur","html_url":"https://github.com/asturur","followers_url":"https://api.github.com/users/asturur/followers","following_url":"https://api.github.com/users/asturur/following{/other_user}","gists_url":"https://api.github.com/users/asturur/gists{/gist_id}","starred_url":"https://api.github.com/users/asturur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturur/subscriptions","organizations_url":"https://api.github.com/users/asturur/orgs","repos_url":"https://api.github.com/users/asturur/repos","events_url":"https://api.github.com/users/asturur/events{/privacy}","received_events_url":"https://api.github.com/users/asturur/received_events","type":"User","site_admin":false},"repo":{"id":44141254,"name":"fabric.js","full_name":"asturur/fabric.js","owner":{"login":"asturur","id":1194048,"avatar_url":"https://avatars.githubusercontent.com/u/1194048?v=3","gravatar_id":"","url":"https://api.github.com/users/asturur","html_url":"https://github.com/asturur","followers_url":"https://api.github.com/users/asturur/followers","following_url":"https://api.github.com/users/asturur/following{/other_user}","gists_url":"https://api.github.com/users/asturur/gists{/gist_id}","starred_url":"https://api.github.com/users/asturur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturur/subscriptions","organizations_url":"https://api.github.com/users/asturur/orgs","repos_url":"https://api.github.com/users/asturur/repos","events_url":"https://api.github.com/users/asturur/events{/privacy}","received_events_url":"https://api.github.com/users/asturur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asturur/fabric.js","description":"Javascript Canvas Library, SVG-to-Canvas (& canvas-to-SVG) Parser","fork":true,"url":"https://api.github.com/repos/asturur/fabric.js","forks_url":"https://api.github.com/repos/asturur/fabric.js/forks","keys_url":"https://api.github.com/repos/asturur/fabric.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asturur/fabric.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asturur/fabric.js/teams","hooks_url":"https://api.github.com/repos/asturur/fabric.js/hooks","issue_events_url":"https://api.github.com/repos/asturur/fabric.js/issues/events{/number}","events_url":"https://api.github.com/repos/asturur/fabric.js/events","assignees_url":"https://api.github.com/repos/asturur/fabric.js/assignees{/user}","branches_url":"https://api.github.com/repos/asturur/fabric.js/branches{/branch}","tags_url":"https://api.github.com/repos/asturur/fabric.js/tags","blobs_url":"https://api.github.com/repos/asturur/fabric.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asturur/fabric.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asturur/fabric.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/asturur/fabric.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asturur/fabric.js/statuses/{sha}","languages_url":"https://api.github.com/repos/asturur/fabric.js/languages","stargazers_url":"https://api.github.com/repos/asturur/fabric.js/stargazers","contributors_url":"https://api.github.com/repos/asturur/fabric.js/contributors","subscribers_url":"https://api.github.com/repos/asturur/fabric.js/subscribers","subscription_url":"https://api.github.com/repos/asturur/fabric.js/subscription","commits_url":"https://api.github.com/repos/asturur/fabric.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/asturur/fabric.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/asturur/fabric.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/asturur/fabric.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/asturur/fabric.js/contents/{+path}","compare_url":"https://api.github.com/repos/asturur/fabric.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asturur/fabric.js/merges","archive_url":"https://api.github.com/repos/asturur/fabric.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asturur/fabric.js/downloads","issues_url":"https://api.github.com/repos/asturur/fabric.js/issues{/number}","pulls_url":"https://api.github.com/repos/asturur/fabric.js/pulls{/number}","milestones_url":"https://api.github.com/repos/asturur/fabric.js/milestones{/number}","notifications_url":"https://api.github.com/repos/asturur/fabric.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asturur/fabric.js/labels{/name}","releases_url":"https://api.github.com/repos/asturur/fabric.js/releases{/id}","created_at":"2015-10-13T00:14:09Z","updated_at":"2015-10-13T00:14:15Z","pushed_at":"2015-12-08T18:53:44Z","git_url":"git://github.com/asturur/fabric.js.git","ssh_url":"git@github.com:asturur/fabric.js.git","clone_url":"https://github.com/asturur/fabric.js.git","svn_url":"https://github.com/asturur/fabric.js","homepage":"http://fabricjs.com","size":96581,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kangax:master","ref":"master","sha":"9fbd20a0763e4b3b34dca0fe1188ff3e99c0be2e","user":{"login":"kangax","id":383,"avatar_url":"https://avatars.githubusercontent.com/u/383?v=3","gravatar_id":"","url":"https://api.github.com/users/kangax","html_url":"https://github.com/kangax","followers_url":"https://api.github.com/users/kangax/followers","following_url":"https://api.github.com/users/kangax/following{/other_user}","gists_url":"https://api.github.com/users/kangax/gists{/gist_id}","starred_url":"https://api.github.com/users/kangax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangax/subscriptions","organizations_url":"https://api.github.com/users/kangax/orgs","repos_url":"https://api.github.com/users/kangax/repos","events_url":"https://api.github.com/users/kangax/events{/privacy}","received_events_url":"https://api.github.com/users/kangax/received_events","type":"User","site_admin":false},"repo":{"id":712530,"name":"fabric.js","full_name":"kangax/fabric.js","owner":{"login":"kangax","id":383,"avatar_url":"https://avatars.githubusercontent.com/u/383?v=3","gravatar_id":"","url":"https://api.github.com/users/kangax","html_url":"https://github.com/kangax","followers_url":"https://api.github.com/users/kangax/followers","following_url":"https://api.github.com/users/kangax/following{/other_user}","gists_url":"https://api.github.com/users/kangax/gists{/gist_id}","starred_url":"https://api.github.com/users/kangax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangax/subscriptions","organizations_url":"https://api.github.com/users/kangax/orgs","repos_url":"https://api.github.com/users/kangax/repos","events_url":"https://api.github.com/users/kangax/events{/privacy}","received_events_url":"https://api.github.com/users/kangax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kangax/fabric.js","description":"Javascript Canvas Library, SVG-to-Canvas (& canvas-to-SVG) Parser","fork":false,"url":"https://api.github.com/repos/kangax/fabric.js","forks_url":"https://api.github.com/repos/kangax/fabric.js/forks","keys_url":"https://api.github.com/repos/kangax/fabric.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kangax/fabric.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kangax/fabric.js/teams","hooks_url":"https://api.github.com/repos/kangax/fabric.js/hooks","issue_events_url":"https://api.github.com/repos/kangax/fabric.js/issues/events{/number}","events_url":"https://api.github.com/repos/kangax/fabric.js/events","assignees_url":"https://api.github.com/repos/kangax/fabric.js/assignees{/user}","branches_url":"https://api.github.com/repos/kangax/fabric.js/branches{/branch}","tags_url":"https://api.github.com/repos/kangax/fabric.js/tags","blobs_url":"https://api.github.com/repos/kangax/fabric.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kangax/fabric.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kangax/fabric.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kangax/fabric.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kangax/fabric.js/statuses/{sha}","languages_url":"https://api.github.com/repos/kangax/fabric.js/languages","stargazers_url":"https://api.github.com/repos/kangax/fabric.js/stargazers","contributors_url":"https://api.github.com/repos/kangax/fabric.js/contributors","subscribers_url":"https://api.github.com/repos/kangax/fabric.js/subscribers","subscription_url":"https://api.github.com/repos/kangax/fabric.js/subscription","commits_url":"https://api.github.com/repos/kangax/fabric.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kangax/fabric.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kangax/fabric.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kangax/fabric.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kangax/fabric.js/contents/{+path}","compare_url":"https://api.github.com/repos/kangax/fabric.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kangax/fabric.js/merges","archive_url":"https://api.github.com/repos/kangax/fabric.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kangax/fabric.js/downloads","issues_url":"https://api.github.com/repos/kangax/fabric.js/issues{/number}","pulls_url":"https://api.github.com/repos/kangax/fabric.js/pulls{/number}","milestones_url":"https://api.github.com/repos/kangax/fabric.js/milestones{/number}","notifications_url":"https://api.github.com/repos/kangax/fabric.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kangax/fabric.js/labels{/name}","releases_url":"https://api.github.com/repos/kangax/fabric.js/releases{/id}","created_at":"2010-06-09T22:24:38Z","updated_at":"2015-12-08T05:04:54Z","pushed_at":"2015-12-08T11:30:01Z","git_url":"git://github.com/kangax/fabric.js.git","ssh_url":"git@github.com:kangax/fabric.js.git","clone_url":"https://github.com/kangax/fabric.js.git","svn_url":"https://github.com/kangax/fabric.js","homepage":"http://fabricjs.com","size":107522,"stargazers_count":5172,"watchers_count":5172,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":907,"mirror_url":null,"open_issues_count":299,"forks":907,"open_issues":299,"watchers":5172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/2672"},"html":{"href":"https://github.com/kangax/fabric.js/pull/2672"},"issue":{"href":"https://api.github.com/repos/kangax/fabric.js/issues/2672"},"comments":{"href":"https://api.github.com/repos/kangax/fabric.js/issues/2672/comments"},"review_comments":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/2672/comments"},"review_comment":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kangax/fabric.js/pulls/2672/commits"},"statuses":{"href":"https://api.github.com/repos/kangax/fabric.js/statuses/411c8b446a700a9876f7ebf864086812954c6ae0"}}}}