{"action":"reopened","number":2181,"pull_request":{"url":"https://api.github.com/repos/opentx/opentx/pulls/2181","id":32487441,"html_url":"https://github.com/opentx/opentx/pull/2181","diff_url":"https://github.com/opentx/opentx/pull/2181.diff","patch_url":"https://github.com/opentx/opentx/pull/2181.patch","issue_url":"https://api.github.com/repos/opentx/opentx/issues/2181","number":2181,"state":"open","locked":false,"title":"Add a continuous beep mode for radios w/ buzzers","user":{"login":"dkisselev","id":945848,"avatar_url":"https://avatars.githubusercontent.com/u/945848?v=3","gravatar_id":"","url":"https://api.github.com/users/dkisselev","html_url":"https://github.com/dkisselev","followers_url":"https://api.github.com/users/dkisselev/followers","following_url":"https://api.github.com/users/dkisselev/following{/other_user}","gists_url":"https://api.github.com/users/dkisselev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkisselev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkisselev/subscriptions","organizations_url":"https://api.github.com/users/dkisselev/orgs","repos_url":"https://api.github.com/users/dkisselev/repos","events_url":"https://api.github.com/users/dkisselev/events{/privacy}","received_events_url":"https://api.github.com/users/dkisselev/received_events","type":"User","site_admin":false},"body":"This PR isn't ready to merge yet, but I'd like to submit it for some help and a code review.\r\n\r\nThis is my proposed solution for #1679,\r\n\r\nI'd like to add a menu option right beside the 'Beep' label in Custom Functions to allow users to choose a beep type. (like how the Trainer mode comes with a channel choice)\r\n\r\nI got the basics of the menu implemented, but a problem that I've run into is that for the buzzer, we want to have both the beep type selection menu and a timer option. This specific combination hasn't been implemented anywhere else, and no matter what I do I can't disconnect the two (changing CFN_PLAY_REPEAT also changes CFN_BEEP_INDEX even though they're in separate columns). I'm wondering if this is even possible to do or if anyone has suggestions for other ways to accomplish the general idea. (The Trainer selection is a checkbox, not a time setting, so it does work)\r\n\r\nI wrote the function handler code such that we can also add more beep tones later on too, even though it's just beep once and continuous for now. BeepOnce is the current implementation and lets you choose those 10 second intervals. BeepCont beeps every second (and ignores the time setting)\r\n\r\nThanks!","created_at":"2015-04-02T07:03:37Z","updated_at":"2015-04-03T06:12:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9502b7ad2515132fd5ac6cf73e07d50882a1b7bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opentx/opentx/pulls/2181/commits","review_comments_url":"https://api.github.com/repos/opentx/opentx/pulls/2181/comments","review_comment_url":"https://api.github.com/repos/opentx/opentx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentx/opentx/issues/2181/comments","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/116a9f63aa33bbede33ba9bc37e1b1e0acd1fd05","head":{"label":"dkisselev:buzz-cont","ref":"buzz-cont","sha":"116a9f63aa33bbede33ba9bc37e1b1e0acd1fd05","user":{"login":"dkisselev","id":945848,"avatar_url":"https://avatars.githubusercontent.com/u/945848?v=3","gravatar_id":"","url":"https://api.github.com/users/dkisselev","html_url":"https://github.com/dkisselev","followers_url":"https://api.github.com/users/dkisselev/followers","following_url":"https://api.github.com/users/dkisselev/following{/other_user}","gists_url":"https://api.github.com/users/dkisselev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkisselev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkisselev/subscriptions","organizations_url":"https://api.github.com/users/dkisselev/orgs","repos_url":"https://api.github.com/users/dkisselev/repos","events_url":"https://api.github.com/users/dkisselev/events{/privacy}","received_events_url":"https://api.github.com/users/dkisselev/received_events","type":"User","site_admin":false},"repo":{"id":32832517,"name":"opentx","full_name":"dkisselev/opentx","owner":{"login":"dkisselev","id":945848,"avatar_url":"https://avatars.githubusercontent.com/u/945848?v=3","gravatar_id":"","url":"https://api.github.com/users/dkisselev","html_url":"https://github.com/dkisselev","followers_url":"https://api.github.com/users/dkisselev/followers","following_url":"https://api.github.com/users/dkisselev/following{/other_user}","gists_url":"https://api.github.com/users/dkisselev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkisselev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkisselev/subscriptions","organizations_url":"https://api.github.com/users/dkisselev/orgs","repos_url":"https://api.github.com/users/dkisselev/repos","events_url":"https://api.github.com/users/dkisselev/events{/privacy}","received_events_url":"https://api.github.com/users/dkisselev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkisselev/opentx","description":"OpenTX custom firmware for Transmitters","fork":true,"url":"https://api.github.com/repos/dkisselev/opentx","forks_url":"https://api.github.com/repos/dkisselev/opentx/forks","keys_url":"https://api.github.com/repos/dkisselev/opentx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkisselev/opentx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkisselev/opentx/teams","hooks_url":"https://api.github.com/repos/dkisselev/opentx/hooks","issue_events_url":"https://api.github.com/repos/dkisselev/opentx/issues/events{/number}","events_url":"https://api.github.com/repos/dkisselev/opentx/events","assignees_url":"https://api.github.com/repos/dkisselev/opentx/assignees{/user}","branches_url":"https://api.github.com/repos/dkisselev/opentx/branches{/branch}","tags_url":"https://api.github.com/repos/dkisselev/opentx/tags","blobs_url":"https://api.github.com/repos/dkisselev/opentx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkisselev/opentx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkisselev/opentx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkisselev/opentx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkisselev/opentx/statuses/{sha}","languages_url":"https://api.github.com/repos/dkisselev/opentx/languages","stargazers_url":"https://api.github.com/repos/dkisselev/opentx/stargazers","contributors_url":"https://api.github.com/repos/dkisselev/opentx/contributors","subscribers_url":"https://api.github.com/repos/dkisselev/opentx/subscribers","subscription_url":"https://api.github.com/repos/dkisselev/opentx/subscription","commits_url":"https://api.github.com/repos/dkisselev/opentx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkisselev/opentx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkisselev/opentx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkisselev/opentx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkisselev/opentx/contents/{+path}","compare_url":"https://api.github.com/repos/dkisselev/opentx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkisselev/opentx/merges","archive_url":"https://api.github.com/repos/dkisselev/opentx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkisselev/opentx/downloads","issues_url":"https://api.github.com/repos/dkisselev/opentx/issues{/number}","pulls_url":"https://api.github.com/repos/dkisselev/opentx/pulls{/number}","milestones_url":"https://api.github.com/repos/dkisselev/opentx/milestones{/number}","notifications_url":"https://api.github.com/repos/dkisselev/opentx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkisselev/opentx/labels{/name}","releases_url":"https://api.github.com/repos/dkisselev/opentx/releases{/id}","created_at":"2015-03-25T00:09:55Z","updated_at":"2015-04-02T07:43:30Z","pushed_at":"2015-04-02T20:53:54Z","git_url":"git://github.com/dkisselev/opentx.git","ssh_url":"git@github.com:dkisselev/opentx.git","clone_url":"https://github.com/dkisselev/opentx.git","svn_url":"https://github.com/dkisselev/opentx","homepage":"","size":103549,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"opentx:next","ref":"next","sha":"96fa39395473c724f8aa787601b7874a5377ffb6","user":{"login":"opentx","id":6073522,"avatar_url":"https://avatars.githubusercontent.com/u/6073522?v=3","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"repo":{"id":14794708,"name":"opentx","full_name":"opentx/opentx","owner":{"login":"opentx","id":6073522,"avatar_url":"https://avatars.githubusercontent.com/u/6073522?v=3","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentx/opentx","description":"OpenTX custom firmware for Transmitters","fork":false,"url":"https://api.github.com/repos/opentx/opentx","forks_url":"https://api.github.com/repos/opentx/opentx/forks","keys_url":"https://api.github.com/repos/opentx/opentx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentx/opentx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentx/opentx/teams","hooks_url":"https://api.github.com/repos/opentx/opentx/hooks","issue_events_url":"https://api.github.com/repos/opentx/opentx/issues/events{/number}","events_url":"https://api.github.com/repos/opentx/opentx/events","assignees_url":"https://api.github.com/repos/opentx/opentx/assignees{/user}","branches_url":"https://api.github.com/repos/opentx/opentx/branches{/branch}","tags_url":"https://api.github.com/repos/opentx/opentx/tags","blobs_url":"https://api.github.com/repos/opentx/opentx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentx/opentx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentx/opentx/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentx/opentx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/{sha}","languages_url":"https://api.github.com/repos/opentx/opentx/languages","stargazers_url":"https://api.github.com/repos/opentx/opentx/stargazers","contributors_url":"https://api.github.com/repos/opentx/opentx/contributors","subscribers_url":"https://api.github.com/repos/opentx/opentx/subscribers","subscription_url":"https://api.github.com/repos/opentx/opentx/subscription","commits_url":"https://api.github.com/repos/opentx/opentx/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentx/opentx/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentx/opentx/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentx/opentx/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentx/opentx/contents/{+path}","compare_url":"https://api.github.com/repos/opentx/opentx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentx/opentx/merges","archive_url":"https://api.github.com/repos/opentx/opentx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentx/opentx/downloads","issues_url":"https://api.github.com/repos/opentx/opentx/issues{/number}","pulls_url":"https://api.github.com/repos/opentx/opentx/pulls{/number}","milestones_url":"https://api.github.com/repos/opentx/opentx/milestones{/number}","notifications_url":"https://api.github.com/repos/opentx/opentx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentx/opentx/labels{/name}","releases_url":"https://api.github.com/repos/opentx/opentx/releases{/id}","created_at":"2013-11-29T07:02:56Z","updated_at":"2015-04-02T21:06:35Z","pushed_at":"2015-04-02T21:06:35Z","git_url":"git://github.com/opentx/opentx.git","ssh_url":"git@github.com:opentx/opentx.git","clone_url":"https://github.com/opentx/opentx.git","svn_url":"https://github.com/opentx/opentx","homepage":"","size":147195,"stargazers_count":214,"watchers_count":214,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":220,"forks":125,"open_issues":220,"watchers":214,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/opentx/opentx/pulls/2181"},"html":{"href":"https://github.com/opentx/opentx/pull/2181"},"issue":{"href":"https://api.github.com/repos/opentx/opentx/issues/2181"},"comments":{"href":"https://api.github.com/repos/opentx/opentx/issues/2181/comments"},"review_comments":{"href":"https://api.github.com/repos/opentx/opentx/pulls/2181/comments"},"review_comment":{"href":"https://api.github.com/repos/opentx/opentx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentx/opentx/pulls/2181/commits"},"statuses":{"href":"https://api.github.com/repos/opentx/opentx/statuses/116a9f63aa33bbede33ba9bc37e1b1e0acd1fd05"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":5,"review_comments":0,"commits":3,"additions":69,"deletions":8,"changed_files":7}}