{"action":"created","comment":{"url":"https://api.github.com/repos/Vestorly/torii/pulls/comments/37315233","id":37315233,"diff_hunk":"@@ -8,8 +8,6 @@ var UUIDGenerator = {\n     });\n     return uuid;","path":"lib/torii/lib/uuid-generator.js","position":2,"original_position":2,"commit_id":"59530e5324a6b5658d2e3c56247a715fd41e67cf","original_commit_id":"59530e5324a6b5658d2e3c56247a715fd41e67cf","user":{"login":"mixonic","id":8752,"avatar_url":"https://avatars.githubusercontent.com/u/8752?v=3","gravatar_id":"","url":"https://api.github.com/users/mixonic","html_url":"https://github.com/mixonic","followers_url":"https://api.github.com/users/mixonic/followers","following_url":"https://api.github.com/users/mixonic/following{/other_user}","gists_url":"https://api.github.com/users/mixonic/gists{/gist_id}","starred_url":"https://api.github.com/users/mixonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixonic/subscriptions","organizations_url":"https://api.github.com/users/mixonic/orgs","repos_url":"https://api.github.com/users/mixonic/repos","events_url":"https://api.github.com/users/mixonic/events{/privacy}","received_events_url":"https://api.github.com/users/mixonic/received_events","type":"User","site_admin":false},"body":"If you drop this whitespace plz drop this `,` as well. Seems weird it got by jshint","created_at":"2015-08-18T15:47:33Z","updated_at":"2015-08-18T15:47:33Z","html_url":"https://github.com/Vestorly/torii/pull/216#discussion_r37315233","pull_request_url":"https://api.github.com/repos/Vestorly/torii/pulls/216","_links":{"self":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/comments/37315233"},"html":{"href":"https://github.com/Vestorly/torii/pull/216#discussion_r37315233"},"pull_request":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/Vestorly/torii/pulls/216","id":42705765,"html_url":"https://github.com/Vestorly/torii/pull/216","diff_url":"https://github.com/Vestorly/torii/pull/216.diff","patch_url":"https://github.com/Vestorly/torii/pull/216.patch","issue_url":"https://api.github.com/repos/Vestorly/torii/issues/216","number":216,"state":"open","locked":false,"title":"add openid-connect with jwt tokens","user":{"login":"albertjan","id":301791,"avatar_url":"https://avatars.githubusercontent.com/u/301791?v=3","gravatar_id":"","url":"https://api.github.com/users/albertjan","html_url":"https://github.com/albertjan","followers_url":"https://api.github.com/users/albertjan/followers","following_url":"https://api.github.com/users/albertjan/following{/other_user}","gists_url":"https://api.github.com/users/albertjan/gists{/gist_id}","starred_url":"https://api.github.com/users/albertjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertjan/subscriptions","organizations_url":"https://api.github.com/users/albertjan/orgs","repos_url":"https://api.github.com/users/albertjan/repos","events_url":"https://api.github.com/users/albertjan/events{/privacy}","received_events_url":"https://api.github.com/users/albertjan/received_events","type":"User","site_admin":false},"body":"Adds a generic openid connect provider.\r\n\r\n - decodes the jwt to a javascript object\r\n - doesn't validate it that would mean adding a __lot__ of dependencies for certificate validation\r\n - tested irl with auth0 also borrowed some jwt decode tests from them\r\n\r\nThere are two places I've sinned:\r\n\r\n - https://github.com/Vestorly/torii/pull/216/files#diff-23d0d8b5a38b82137f4e75d6823cafc3R9\r\n  - I needed to call escape because that doesn't bother with utf8 stuff I linked to the so answer\r\n - https://github.com/Vestorly/torii/pull/216/files#diff-848166d56bb9eaef2df51ff601b48b18R48\r\n  - I wasn't able to override `optionalUrlParams` here: https://github.com/Vestorly/torii/pull/216/files#diff-848166d56bb9eaef2df51ff601b48b18R21 maybe you have a better idea how to fix it.\r\n","created_at":"2015-08-18T14:35:15Z","updated_at":"2015-08-18T15:47:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44f6669eead9788ce97d075119116f665da9729a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Vestorly/torii/pulls/216/commits","review_comments_url":"https://api.github.com/repos/Vestorly/torii/pulls/216/comments","review_comment_url":"https://api.github.com/repos/Vestorly/torii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vestorly/torii/issues/216/comments","statuses_url":"https://api.github.com/repos/Vestorly/torii/statuses/59530e5324a6b5658d2e3c56247a715fd41e67cf","head":{"label":"curit:openid-connect-provider","ref":"openid-connect-provider","sha":"59530e5324a6b5658d2e3c56247a715fd41e67cf","user":{"login":"curit","id":5174214,"avatar_url":"https://avatars.githubusercontent.com/u/5174214?v=3","gravatar_id":"","url":"https://api.github.com/users/curit","html_url":"https://github.com/curit","followers_url":"https://api.github.com/users/curit/followers","following_url":"https://api.github.com/users/curit/following{/other_user}","gists_url":"https://api.github.com/users/curit/gists{/gist_id}","starred_url":"https://api.github.com/users/curit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curit/subscriptions","organizations_url":"https://api.github.com/users/curit/orgs","repos_url":"https://api.github.com/users/curit/repos","events_url":"https://api.github.com/users/curit/events{/privacy}","received_events_url":"https://api.github.com/users/curit/received_events","type":"Organization","site_admin":false},"repo":{"id":30749154,"name":"torii","full_name":"curit/torii","owner":{"login":"curit","id":5174214,"avatar_url":"https://avatars.githubusercontent.com/u/5174214?v=3","gravatar_id":"","url":"https://api.github.com/users/curit","html_url":"https://github.com/curit","followers_url":"https://api.github.com/users/curit/followers","following_url":"https://api.github.com/users/curit/following{/other_user}","gists_url":"https://api.github.com/users/curit/gists{/gist_id}","starred_url":"https://api.github.com/users/curit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curit/subscriptions","organizations_url":"https://api.github.com/users/curit/orgs","repos_url":"https://api.github.com/users/curit/repos","events_url":"https://api.github.com/users/curit/events{/privacy}","received_events_url":"https://api.github.com/users/curit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/curit/torii","description":"A set of clean abstractions for authentication in Ember.js","fork":true,"url":"https://api.github.com/repos/curit/torii","forks_url":"https://api.github.com/repos/curit/torii/forks","keys_url":"https://api.github.com/repos/curit/torii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/curit/torii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/curit/torii/teams","hooks_url":"https://api.github.com/repos/curit/torii/hooks","issue_events_url":"https://api.github.com/repos/curit/torii/issues/events{/number}","events_url":"https://api.github.com/repos/curit/torii/events","assignees_url":"https://api.github.com/repos/curit/torii/assignees{/user}","branches_url":"https://api.github.com/repos/curit/torii/branches{/branch}","tags_url":"https://api.github.com/repos/curit/torii/tags","blobs_url":"https://api.github.com/repos/curit/torii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/curit/torii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/curit/torii/git/refs{/sha}","trees_url":"https://api.github.com/repos/curit/torii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/curit/torii/statuses/{sha}","languages_url":"https://api.github.com/repos/curit/torii/languages","stargazers_url":"https://api.github.com/repos/curit/torii/stargazers","contributors_url":"https://api.github.com/repos/curit/torii/contributors","subscribers_url":"https://api.github.com/repos/curit/torii/subscribers","subscription_url":"https://api.github.com/repos/curit/torii/subscription","commits_url":"https://api.github.com/repos/curit/torii/commits{/sha}","git_commits_url":"https://api.github.com/repos/curit/torii/git/commits{/sha}","comments_url":"https://api.github.com/repos/curit/torii/comments{/number}","issue_comment_url":"https://api.github.com/repos/curit/torii/issues/comments{/number}","contents_url":"https://api.github.com/repos/curit/torii/contents/{+path}","compare_url":"https://api.github.com/repos/curit/torii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/curit/torii/merges","archive_url":"https://api.github.com/repos/curit/torii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/curit/torii/downloads","issues_url":"https://api.github.com/repos/curit/torii/issues{/number}","pulls_url":"https://api.github.com/repos/curit/torii/pulls{/number}","milestones_url":"https://api.github.com/repos/curit/torii/milestones{/number}","notifications_url":"https://api.github.com/repos/curit/torii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/curit/torii/labels{/name}","releases_url":"https://api.github.com/repos/curit/torii/releases{/id}","created_at":"2015-02-13T09:18:22Z","updated_at":"2015-03-12T15:26:23Z","pushed_at":"2015-08-18T14:32:29Z","git_url":"git://github.com/curit/torii.git","ssh_url":"git@github.com:curit/torii.git","clone_url":"https://github.com/curit/torii.git","svn_url":"https://github.com/curit/torii","homepage":"vestorly.github.io/torii","size":2434,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Vestorly:master","ref":"master","sha":"b9417f136d213f112eede85eb3dd30d57cc3658a","user":{"login":"Vestorly","id":1341524,"avatar_url":"https://avatars.githubusercontent.com/u/1341524?v=3","gravatar_id":"","url":"https://api.github.com/users/Vestorly","html_url":"https://github.com/Vestorly","followers_url":"https://api.github.com/users/Vestorly/followers","following_url":"https://api.github.com/users/Vestorly/following{/other_user}","gists_url":"https://api.github.com/users/Vestorly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vestorly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vestorly/subscriptions","organizations_url":"https://api.github.com/users/Vestorly/orgs","repos_url":"https://api.github.com/users/Vestorly/repos","events_url":"https://api.github.com/users/Vestorly/events{/privacy}","received_events_url":"https://api.github.com/users/Vestorly/received_events","type":"Organization","site_admin":false},"repo":{"id":18303148,"name":"torii","full_name":"Vestorly/torii","owner":{"login":"Vestorly","id":1341524,"avatar_url":"https://avatars.githubusercontent.com/u/1341524?v=3","gravatar_id":"","url":"https://api.github.com/users/Vestorly","html_url":"https://github.com/Vestorly","followers_url":"https://api.github.com/users/Vestorly/followers","following_url":"https://api.github.com/users/Vestorly/following{/other_user}","gists_url":"https://api.github.com/users/Vestorly/gists{/gist_id}","starred_url":"https://api.github.com/users/Vestorly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vestorly/subscriptions","organizations_url":"https://api.github.com/users/Vestorly/orgs","repos_url":"https://api.github.com/users/Vestorly/repos","events_url":"https://api.github.com/users/Vestorly/events{/privacy}","received_events_url":"https://api.github.com/users/Vestorly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vestorly/torii","description":"A set of clean abstractions for authentication in Ember.js","fork":false,"url":"https://api.github.com/repos/Vestorly/torii","forks_url":"https://api.github.com/repos/Vestorly/torii/forks","keys_url":"https://api.github.com/repos/Vestorly/torii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vestorly/torii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vestorly/torii/teams","hooks_url":"https://api.github.com/repos/Vestorly/torii/hooks","issue_events_url":"https://api.github.com/repos/Vestorly/torii/issues/events{/number}","events_url":"https://api.github.com/repos/Vestorly/torii/events","assignees_url":"https://api.github.com/repos/Vestorly/torii/assignees{/user}","branches_url":"https://api.github.com/repos/Vestorly/torii/branches{/branch}","tags_url":"https://api.github.com/repos/Vestorly/torii/tags","blobs_url":"https://api.github.com/repos/Vestorly/torii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vestorly/torii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vestorly/torii/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vestorly/torii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vestorly/torii/statuses/{sha}","languages_url":"https://api.github.com/repos/Vestorly/torii/languages","stargazers_url":"https://api.github.com/repos/Vestorly/torii/stargazers","contributors_url":"https://api.github.com/repos/Vestorly/torii/contributors","subscribers_url":"https://api.github.com/repos/Vestorly/torii/subscribers","subscription_url":"https://api.github.com/repos/Vestorly/torii/subscription","commits_url":"https://api.github.com/repos/Vestorly/torii/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vestorly/torii/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vestorly/torii/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vestorly/torii/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vestorly/torii/contents/{+path}","compare_url":"https://api.github.com/repos/Vestorly/torii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vestorly/torii/merges","archive_url":"https://api.github.com/repos/Vestorly/torii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vestorly/torii/downloads","issues_url":"https://api.github.com/repos/Vestorly/torii/issues{/number}","pulls_url":"https://api.github.com/repos/Vestorly/torii/pulls{/number}","milestones_url":"https://api.github.com/repos/Vestorly/torii/milestones{/number}","notifications_url":"https://api.github.com/repos/Vestorly/torii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vestorly/torii/labels{/name}","releases_url":"https://api.github.com/repos/Vestorly/torii/releases{/id}","created_at":"2014-03-31T18:16:42Z","updated_at":"2015-08-13T14:56:35Z","pushed_at":"2015-08-18T14:35:15Z","git_url":"git://github.com/Vestorly/torii.git","ssh_url":"git@github.com:Vestorly/torii.git","clone_url":"https://github.com/Vestorly/torii.git","svn_url":"https://github.com/Vestorly/torii","homepage":"vestorly.github.io/torii","size":3702,"stargazers_count":521,"watchers_count":521,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":80,"mirror_url":null,"open_issues_count":34,"forks":80,"open_issues":34,"watchers":521,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/216"},"html":{"href":"https://github.com/Vestorly/torii/pull/216"},"issue":{"href":"https://api.github.com/repos/Vestorly/torii/issues/216"},"comments":{"href":"https://api.github.com/repos/Vestorly/torii/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vestorly/torii/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/Vestorly/torii/statuses/59530e5324a6b5658d2e3c56247a715fd41e67cf"}}}}