{"action":"created","issue":{"url":"https://api.github.com/repos/jgirald/ES2015C/issues/161","labels_url":"https://api.github.com/repos/jgirald/ES2015C/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/jgirald/ES2015C/issues/161/comments","events_url":"https://api.github.com/repos/jgirald/ES2015C/issues/161/events","html_url":"https://github.com/jgirald/ES2015C/issues/161","id":113175385,"number":161,"title":"Uniformize the character movement speed among different computers (bugfix)","user":{"login":"joanbm","id":519004,"avatar_url":"https://avatars.githubusercontent.com/u/519004?v=3","gravatar_id":"","url":"https://api.github.com/users/joanbm","html_url":"https://github.com/joanbm","followers_url":"https://api.github.com/users/joanbm/followers","following_url":"https://api.github.com/users/joanbm/following{/other_user}","gists_url":"https://api.github.com/users/joanbm/gists{/gist_id}","starred_url":"https://api.github.com/users/joanbm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joanbm/subscriptions","organizations_url":"https://api.github.com/users/joanbm/orgs","repos_url":"https://api.github.com/users/joanbm/repos","events_url":"https://api.github.com/users/joanbm/events{/privacy}","received_events_url":"https://api.github.com/users/joanbm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jgirald/ES2015C/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/jgirald/ES2015C/labels/High%20Priority","name":"High Priority","color":"e11d21"},{"url":"https://api.github.com/repos/jgirald/ES2015C/labels/Team%20C","name":"Team C","color":"5319e7"}],"state":"closed","locked":false,"assignee":{"login":"joanbm","id":519004,"avatar_url":"https://avatars.githubusercontent.com/u/519004?v=3","gravatar_id":"","url":"https://api.github.com/users/joanbm","html_url":"https://github.com/joanbm","followers_url":"https://api.github.com/users/joanbm/followers","following_url":"https://api.github.com/users/joanbm/following{/other_user}","gists_url":"https://api.github.com/users/joanbm/gists{/gist_id}","starred_url":"https://api.github.com/users/joanbm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joanbm/subscriptions","organizations_url":"https://api.github.com/users/joanbm/orgs","repos_url":"https://api.github.com/users/joanbm/repos","events_url":"https://api.github.com/users/joanbm/events{/privacy}","received_events_url":"https://api.github.com/users/joanbm/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/jgirald/ES2015C/milestones/5","html_url":"https://github.com/jgirald/ES2015C/milestones/Sprint%203","labels_url":"https://api.github.com/repos/jgirald/ES2015C/milestones/5/labels","id":1368722,"number":5,"title":"Sprint 3","description":"","creator":{"login":"howna13","id":5635059,"avatar_url":"https://avatars.githubusercontent.com/u/5635059?v=3","gravatar_id":"","url":"https://api.github.com/users/howna13","html_url":"https://github.com/howna13","followers_url":"https://api.github.com/users/howna13/followers","following_url":"https://api.github.com/users/howna13/following{/other_user}","gists_url":"https://api.github.com/users/howna13/gists{/gist_id}","starred_url":"https://api.github.com/users/howna13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howna13/subscriptions","organizations_url":"https://api.github.com/users/howna13/orgs","repos_url":"https://api.github.com/users/howna13/repos","events_url":"https://api.github.com/users/howna13/events{/privacy}","received_events_url":"https://api.github.com/users/howna13/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":4,"state":"open","created_at":"2015-10-21T17:24:40Z","updated_at":"2015-10-24T20:58:17Z","due_on":"2016-11-05T23:00:00Z","closed_at":null},"comments":1,"created_at":"2015-10-24T18:11:44Z","updated_at":"2015-10-24T20:58:17Z","closed_at":"2015-10-24T20:58:17Z","body":"At the end of the first sprint, it was found that units moved at radically different speeds depending on the computer. During the second sprint, it was uncovered that this was probably due to a programming error on the unit's movement implementation, specifically, a call to the *CharacterController.SimpleMove* function does not need to be normalized depending on time. However, a fix was never implemented or tested. The purpose of this issue is to implement a fix and make sure that it works. Since the root of the problem seems to have been located, I estimate this will take very few time to fix.\r\n\r\n**Product backlog item:** As a player, I want to create units by collected resources, so that I can grow my civilization. All units are characterized by degrees of life, attack and movement speed. \r\n\r\n**Estimated time:** 1h\r\n\r\n**Ending condition:** All units must move at the same speed independently of the computer."},"comment":{"url":"https://api.github.com/repos/jgirald/ES2015C/issues/comments/150850826","html_url":"https://github.com/jgirald/ES2015C/issues/161#issuecomment-150850826","issue_url":"https://api.github.com/repos/jgirald/ES2015C/issues/161","id":150850826,"user":{"login":"joanbm","id":519004,"avatar_url":"https://avatars.githubusercontent.com/u/519004?v=3","gravatar_id":"","url":"https://api.github.com/users/joanbm","html_url":"https://github.com/joanbm","followers_url":"https://api.github.com/users/joanbm/followers","following_url":"https://api.github.com/users/joanbm/following{/other_user}","gists_url":"https://api.github.com/users/joanbm/gists{/gist_id}","starred_url":"https://api.github.com/users/joanbm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joanbm/subscriptions","organizations_url":"https://api.github.com/users/joanbm/orgs","repos_url":"https://api.github.com/users/joanbm/repos","events_url":"https://api.github.com/users/joanbm/events{/privacy}","received_events_url":"https://api.github.com/users/joanbm/received_events","type":"User","site_admin":false},"created_at":"2015-10-24T20:58:17Z","updated_at":"2015-10-24T20:58:17Z","body":"The bug has been fixed and the fix has been pushed to the team branch.\r\n\r\nIn order to test the old behaviour and the fix, a program called CPUSTRES was used: http://blogs.msdn.com/b/vijaysk/archive/2012/10/27/tools-to-simulate-cpu-memory-disk-load.aspx\r\n\r\nIt could be tested that high CPU usage (equivalent to a slower computer) caused the units to move faster. After applying the fix, this is no longer the case.\r\n\r\nAs a result of this fix, units move faster than what they used to on most (but not all!) computers. This is not a bug because they are moving at exactly the speed (in game m/s) they are configured as. At worst, their speed should be reconsidered, but there was never a standard speed defined for them anyway."}}