{"action":"created","issue":{"url":"https://api.github.com/repos/caryfitzhugh/NYCCSC-map-viewer/issues/68","labels_url":"https://api.github.com/repos/caryfitzhugh/NYCCSC-map-viewer/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/caryfitzhugh/NYCCSC-map-viewer/issues/68/comments","events_url":"https://api.github.com/repos/caryfitzhugh/NYCCSC-map-viewer/issues/68/events","html_url":"https://github.com/caryfitzhugh/NYCCSC-map-viewer/issues/68","id":113571408,"number":68,"title":"getFeatureInfo behavior","user":{"login":"sasignell","id":4191479,"avatar_url":"https://avatars.githubusercontent.com/u/4191479?v=3","gravatar_id":"","url":"https://api.github.com/users/sasignell","html_url":"https://github.com/sasignell","followers_url":"https://api.github.com/users/sasignell/followers","following_url":"https://api.github.com/users/sasignell/following{/other_user}","gists_url":"https://api.github.com/users/sasignell/gists{/gist_id}","starred_url":"https://api.github.com/users/sasignell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasignell/subscriptions","organizations_url":"https://api.github.com/users/sasignell/orgs","repos_url":"https://api.github.com/users/sasignell/repos","events_url":"https://api.github.com/users/sasignell/events{/privacy}","received_events_url":"https://api.github.com/users/sasignell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-10-27T12:27:02Z","updated_at":"2015-10-27T14:12:11Z","closed_at":null,"body":"there should be no popup if nothing is returned\r\n\r\nonly layers with valid results should show up in the modal (no blank rows for active layers that return no results)"},"comment":{"url":"https://api.github.com/repos/caryfitzhugh/NYCCSC-map-viewer/issues/comments/151508386","html_url":"https://github.com/caryfitzhugh/NYCCSC-map-viewer/issues/68#issuecomment-151508386","issue_url":"https://api.github.com/repos/caryfitzhugh/NYCCSC-map-viewer/issues/68","id":151508386,"user":{"login":"caryfitzhugh","id":445848,"avatar_url":"https://avatars.githubusercontent.com/u/445848?v=3","gravatar_id":"","url":"https://api.github.com/users/caryfitzhugh","html_url":"https://github.com/caryfitzhugh","followers_url":"https://api.github.com/users/caryfitzhugh/followers","following_url":"https://api.github.com/users/caryfitzhugh/following{/other_user}","gists_url":"https://api.github.com/users/caryfitzhugh/gists{/gist_id}","starred_url":"https://api.github.com/users/caryfitzhugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caryfitzhugh/subscriptions","organizations_url":"https://api.github.com/users/caryfitzhugh/orgs","repos_url":"https://api.github.com/users/caryfitzhugh/repos","events_url":"https://api.github.com/users/caryfitzhugh/events{/privacy}","received_events_url":"https://api.github.com/users/caryfitzhugh/received_events","type":"User","site_admin":false},"created_at":"2015-10-27T14:12:11Z","updated_at":"2015-10-27T14:12:11Z","body":"This is tricky.\r\n\r\nIf we want to do this, we'd need to add some code into your iframe responses, to tell us (the parent container) what height to make you when you are done loading.\r\nIt might be some JS as simple as window.postMessage ( ) ...\r\nhttps://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage\r\nThe loading iframe would need to inform the parent iframe when it has loaded and what height it's view is.  So the parent modal could figure out when to display or not.\r\n\r\nOr we can go with just returning HTML.  If the getFeatureInfo calls return HTML via a JSONP call, I can manipulate the data easier. This is similar to what you had done before.\r\n\r\nWhich do you prefer?  I think, now realizing that we may make requests that return nothing, I think I'd lean towards the JSONP get_Feature_info...   It also doesn't keep things squished into a small box.\r\n\r\nOn the other hand -- if you want to do D3 and other complex things in those responses, it may be good to spend the time to have some postMessage callback messages (if only to keep the rendering separate and clean).\r\n\r\n"}}