{"action":"created","issue":{"url":"https://api.github.com/repos/androguard/androguard/issues/85","labels_url":"https://api.github.com/repos/androguard/androguard/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/androguard/androguard/issues/85/comments","events_url":"https://api.github.com/repos/androguard/androguard/issues/85/events","html_url":"https://github.com/androguard/androguard/pull/85","id":65779606,"number":85,"title":"fix some manifest issues","user":{"login":"dweinstein","id":794478,"avatar_url":"https://avatars.githubusercontent.com/u/794478?v=3","gravatar_id":"","url":"https://api.github.com/users/dweinstein","html_url":"https://github.com/dweinstein","followers_url":"https://api.github.com/users/dweinstein/followers","following_url":"https://api.github.com/users/dweinstein/following{/other_user}","gists_url":"https://api.github.com/users/dweinstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dweinstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dweinstein/subscriptions","organizations_url":"https://api.github.com/users/dweinstein/orgs","repos_url":"https://api.github.com/users/dweinstein/repos","events_url":"https://api.github.com/users/dweinstein/events{/privacy}","received_events_url":"https://api.github.com/users/dweinstein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-01T21:08:56Z","updated_at":"2015-04-01T22:48:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/androguard/androguard/pulls/85","html_url":"https://github.com/androguard/androguard/pull/85","diff_url":"https://github.com/androguard/androguard/pull/85.diff","patch_url":"https://github.com/androguard/androguard/pull/85.patch"},"body":"This somewhat more closely aligns with the way [aapt](http://androidxref.com/4.4.3_r1.1/xref/frameworks/base/tools/aapt/Command.cpp#317) performs resolving of attributes and will help with apps that are using dexguard xml resource obfuscation.\r\n\r\nOn an obfuscated app one would not be able to correctly retrieve the `versionCode` or `versionName` fields from the manifest (and possibly many other fields).  It was discussed in this [stack overflow](http://stackoverflow.com/questions/26529120/how-can-i-obfuscate-xml-resource-files-with-dexguard)\r\n\r\n> Each attribute in an XML resource file is identified by a name, but often also by a numeric identifier.  In AndroidManifest.xml for example:\r\nandroid:versionName(0x010102lc) = \"1.0\"\r\nIn the obfuscation step, DexGuard can remove the name of an attribute, but only if this attribute also has a numeric identifier.\r\nAfter DexGuard obfuscation the above attribute will look like this:\r\n:(0x010102lc) = \"1.0\"\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/androguard/androguard/issues/comments/88655716","html_url":"https://github.com/androguard/androguard/pull/85#issuecomment-88655716","issue_url":"https://api.github.com/repos/androguard/androguard/issues/85","id":88655716,"user":{"login":"dweinstein","id":794478,"avatar_url":"https://avatars.githubusercontent.com/u/794478?v=3","gravatar_id":"","url":"https://api.github.com/users/dweinstein","html_url":"https://github.com/dweinstein","followers_url":"https://api.github.com/users/dweinstein/followers","following_url":"https://api.github.com/users/dweinstein/following{/other_user}","gists_url":"https://api.github.com/users/dweinstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dweinstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dweinstein/subscriptions","organizations_url":"https://api.github.com/users/dweinstein/orgs","repos_url":"https://api.github.com/users/dweinstein/repos","events_url":"https://api.github.com/users/dweinstein/events{/privacy}","received_events_url":"https://api.github.com/users/dweinstein/received_events","type":"User","site_admin":false},"created_at":"2015-04-01T22:48:22Z","updated_at":"2015-04-01T22:48:22Z","body":"@subho007 thanks for the suggestion. Hopefully this is now more pythonic?"}}