{"action":"created","comment":{"url":"https://api.github.com/repos/basho/riak_test/pulls/comments/45658523","id":45658523,"diff_hunk":"@@ -0,0 +1,45 @@\n+%% -------------------------------------------------------------------\n+%%\n+%% Copyright (c) 2015 Basho Technologies, Inc.\n+%%\n+%% This file is provided to you under the Apache License,\n+%% Version 2.0 (the \"License\"); you may not use this file\n+%% except in compliance with the License.  You may obtain\n+%% a copy of the License at\n+%%\n+%%   http://www.apache.org/licenses/LICENSE-2.0\n+%%\n+%% Unless required by applicable law or agreed to in writing,\n+%% software distributed under the License is distributed on an\n+%% \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+%% KIND, either express or implied.  See the License for the\n+%% specific language governing permissions and limitations\n+%% under the License.\n+%%\n+%% -------------------------------------------------------------------\n+\n+%% Test for creating a utf8 table name. This should fail\n+%% because of mochijson decoding.\n+\n+-module(ts_unicode_2).","path":"tests/ts_unicode_2.erl","position":24,"original_position":24,"commit_id":"f8c25a33c107cd4a5160b0638cb32fae0d6f1436","original_commit_id":"f8c25a33c107cd4a5160b0638cb32fae0d6f1436","user":{"login":"javajolt","id":2357996,"avatar_url":"https://avatars.githubusercontent.com/u/2357996?v=3","gravatar_id":"","url":"https://api.github.com/users/javajolt","html_url":"https://github.com/javajolt","followers_url":"https://api.github.com/users/javajolt/followers","following_url":"https://api.github.com/users/javajolt/following{/other_user}","gists_url":"https://api.github.com/users/javajolt/gists{/gist_id}","starred_url":"https://api.github.com/users/javajolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javajolt/subscriptions","organizations_url":"https://api.github.com/users/javajolt/orgs","repos_url":"https://api.github.com/users/javajolt/repos","events_url":"https://api.github.com/users/javajolt/events{/privacy}","received_events_url":"https://api.github.com/users/javajolt/received_events","type":"User","site_admin":false},"body":"Just less bookkeeping.\r\n\r\nHow would you feel about naming your test something like `ts_unicode_create_table_not_allowed`? I'm always trying to get more explicit test names.","created_at":"2015-11-23T20:50:14Z","updated_at":"2015-11-23T20:50:14Z","html_url":"https://github.com/basho/riak_test/pull/936#discussion_r45658523","pull_request_url":"https://api.github.com/repos/basho/riak_test/pulls/936","_links":{"self":{"href":"https://api.github.com/repos/basho/riak_test/pulls/comments/45658523"},"html":{"href":"https://github.com/basho/riak_test/pull/936#discussion_r45658523"},"pull_request":{"href":"https://api.github.com/repos/basho/riak_test/pulls/936"}}},"pull_request":{"url":"https://api.github.com/repos/basho/riak_test/pulls/936","id":51541197,"html_url":"https://github.com/basho/riak_test/pull/936","diff_url":"https://github.com/basho/riak_test/pull/936.diff","patch_url":"https://github.com/basho/riak_test/pull/936.patch","issue_url":"https://api.github.com/repos/basho/riak_test/issues/936","number":936,"state":"open","locked":false,"title":"Add tests for utf8 and latin1 in the table definition","user":{"login":"andytill","id":213455,"avatar_url":"https://avatars.githubusercontent.com/u/213455?v=3","gravatar_id":"","url":"https://api.github.com/users/andytill","html_url":"https://github.com/andytill","followers_url":"https://api.github.com/users/andytill/followers","following_url":"https://api.github.com/users/andytill/following{/other_user}","gists_url":"https://api.github.com/users/andytill/gists{/gist_id}","starred_url":"https://api.github.com/users/andytill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andytill/subscriptions","organizations_url":"https://api.github.com/users/andytill/orgs","repos_url":"https://api.github.com/users/andytill/repos","events_url":"https://api.github.com/users/andytill/events{/privacy}","received_events_url":"https://api.github.com/users/andytill/received_events","type":"User","site_admin":false},"body":"Neither is currently supported because of the way JSON is encoded, when it is supported these tests should be modified to assert on correct table creation.","created_at":"2015-11-23T15:56:59Z","updated_at":"2015-11-23T20:50:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5a783d0dd2ba1a7044e08b378b553dea6db8968","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/basho/riak_test/pulls/936/commits","review_comments_url":"https://api.github.com/repos/basho/riak_test/pulls/936/comments","review_comment_url":"https://api.github.com/repos/basho/riak_test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/basho/riak_test/issues/936/comments","statuses_url":"https://api.github.com/repos/basho/riak_test/statuses/f8c25a33c107cd4a5160b0638cb32fae0d6f1436","head":{"label":"basho:at/ts_encoding_tests","ref":"at/ts_encoding_tests","sha":"f8c25a33c107cd4a5160b0638cb32fae0d6f1436","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":3149948,"name":"riak_test","full_name":"basho/riak_test","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/riak_test","description":"I'm in your cluster, testing your riaks","fork":false,"url":"https://api.github.com/repos/basho/riak_test","forks_url":"https://api.github.com/repos/basho/riak_test/forks","keys_url":"https://api.github.com/repos/basho/riak_test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/riak_test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/riak_test/teams","hooks_url":"https://api.github.com/repos/basho/riak_test/hooks","issue_events_url":"https://api.github.com/repos/basho/riak_test/issues/events{/number}","events_url":"https://api.github.com/repos/basho/riak_test/events","assignees_url":"https://api.github.com/repos/basho/riak_test/assignees{/user}","branches_url":"https://api.github.com/repos/basho/riak_test/branches{/branch}","tags_url":"https://api.github.com/repos/basho/riak_test/tags","blobs_url":"https://api.github.com/repos/basho/riak_test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/riak_test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/riak_test/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/riak_test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/riak_test/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/riak_test/languages","stargazers_url":"https://api.github.com/repos/basho/riak_test/stargazers","contributors_url":"https://api.github.com/repos/basho/riak_test/contributors","subscribers_url":"https://api.github.com/repos/basho/riak_test/subscribers","subscription_url":"https://api.github.com/repos/basho/riak_test/subscription","commits_url":"https://api.github.com/repos/basho/riak_test/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/riak_test/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/riak_test/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/riak_test/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho/riak_test/contents/{+path}","compare_url":"https://api.github.com/repos/basho/riak_test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/riak_test/merges","archive_url":"https://api.github.com/repos/basho/riak_test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/riak_test/downloads","issues_url":"https://api.github.com/repos/basho/riak_test/issues{/number}","pulls_url":"https://api.github.com/repos/basho/riak_test/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/riak_test/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/riak_test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/riak_test/labels{/name}","releases_url":"https://api.github.com/repos/basho/riak_test/releases{/id}","created_at":"2012-01-11T00:31:00Z","updated_at":"2015-11-05T13:59:16Z","pushed_at":"2015-11-23T16:13:02Z","git_url":"git://github.com/basho/riak_test.git","ssh_url":"git@github.com:basho/riak_test.git","clone_url":"https://github.com/basho/riak_test.git","svn_url":"https://github.com/basho/riak_test","homepage":"http://basho.github.com/riak_test/","size":28860,"stargazers_count":52,"watchers_count":52,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":65,"forks":27,"open_issues":65,"watchers":52,"default_branch":"master"}},"base":{"label":"basho:riak_ts","ref":"riak_ts","sha":"6977313983a22dba908f18b8b609f0f286b74b20","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":3149948,"name":"riak_test","full_name":"basho/riak_test","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/riak_test","description":"I'm in your cluster, testing your riaks","fork":false,"url":"https://api.github.com/repos/basho/riak_test","forks_url":"https://api.github.com/repos/basho/riak_test/forks","keys_url":"https://api.github.com/repos/basho/riak_test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/riak_test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/riak_test/teams","hooks_url":"https://api.github.com/repos/basho/riak_test/hooks","issue_events_url":"https://api.github.com/repos/basho/riak_test/issues/events{/number}","events_url":"https://api.github.com/repos/basho/riak_test/events","assignees_url":"https://api.github.com/repos/basho/riak_test/assignees{/user}","branches_url":"https://api.github.com/repos/basho/riak_test/branches{/branch}","tags_url":"https://api.github.com/repos/basho/riak_test/tags","blobs_url":"https://api.github.com/repos/basho/riak_test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/riak_test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/riak_test/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/riak_test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/riak_test/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/riak_test/languages","stargazers_url":"https://api.github.com/repos/basho/riak_test/stargazers","contributors_url":"https://api.github.com/repos/basho/riak_test/contributors","subscribers_url":"https://api.github.com/repos/basho/riak_test/subscribers","subscription_url":"https://api.github.com/repos/basho/riak_test/subscription","commits_url":"https://api.github.com/repos/basho/riak_test/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/riak_test/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/riak_test/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/riak_test/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho/riak_test/contents/{+path}","compare_url":"https://api.github.com/repos/basho/riak_test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/riak_test/merges","archive_url":"https://api.github.com/repos/basho/riak_test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/riak_test/downloads","issues_url":"https://api.github.com/repos/basho/riak_test/issues{/number}","pulls_url":"https://api.github.com/repos/basho/riak_test/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/riak_test/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/riak_test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/riak_test/labels{/name}","releases_url":"https://api.github.com/repos/basho/riak_test/releases{/id}","created_at":"2012-01-11T00:31:00Z","updated_at":"2015-11-05T13:59:16Z","pushed_at":"2015-11-23T16:13:02Z","git_url":"git://github.com/basho/riak_test.git","ssh_url":"git@github.com:basho/riak_test.git","clone_url":"https://github.com/basho/riak_test.git","svn_url":"https://github.com/basho/riak_test","homepage":"http://basho.github.com/riak_test/","size":28860,"stargazers_count":52,"watchers_count":52,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":65,"forks":27,"open_issues":65,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/basho/riak_test/pulls/936"},"html":{"href":"https://github.com/basho/riak_test/pull/936"},"issue":{"href":"https://api.github.com/repos/basho/riak_test/issues/936"},"comments":{"href":"https://api.github.com/repos/basho/riak_test/issues/936/comments"},"review_comments":{"href":"https://api.github.com/repos/basho/riak_test/pulls/936/comments"},"review_comment":{"href":"https://api.github.com/repos/basho/riak_test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/basho/riak_test/pulls/936/commits"},"statuses":{"href":"https://api.github.com/repos/basho/riak_test/statuses/f8c25a33c107cd4a5160b0638cb32fae0d6f1436"}}}}