{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/41060768","id":41060768,"diff_hunk":"@@ -504,10 +504,14 @@ def __virtual__():\n                 log.warning(\n                     'Insufficient Docker version for dockerng (required: '\n                     '{0}, installed: {1})'.format(\n-                        '.'.join(docker_versioninfo),\n-                        '.'.join(MIN_DOCKER)\n-                    )\n-                )\n+                        '.'.join(map(str, MIN_DOCKER)),\n+                        '.'.join(map(str, docker_versioninfo))))\n+        else:\n+            log.warning(","path":"salt/modules/dockerng.py","position":11,"original_position":11,"commit_id":"b92c36a92b4270e64b4f7ac03840a065b4dc8998","original_commit_id":"b92c36a92b4270e64b4f7ac03840a065b4dc8998","user":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"body":"@jfindlay \r\nThat's an awesome hint!  I was trying to figure out how to get this done, but could not find any documentation on it, and grepping the existing modules only revealed `return False` everywhere I've looked.\r\nWhere should (or is) this documented?","created_at":"2015-10-02T19:51:55Z","updated_at":"2015-10-02T19:51:55Z","html_url":"https://github.com/saltstack/salt/pull/27602#discussion_r41060768","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/27602","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/41060768"},"html":{"href":"https://github.com/saltstack/salt/pull/27602#discussion_r41060768"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/27602"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/27602","id":46568421,"html_url":"https://github.com/saltstack/salt/pull/27602","diff_url":"https://github.com/saltstack/salt/pull/27602.diff","patch_url":"https://github.com/saltstack/salt/pull/27602.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/27602","number":27602,"state":"open","locked":false,"title":"dockerng: fix/enhance version warning in __virtual__","user":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"body":"Currently the call to `log.warning` will throw an error, because\r\n`str.join` expects strings, not numbers.\r\n\r\nThis commit fixes it and also adds a warning for a mismatching docker-py\r\nversion.\r\n\r\nI wonder if it is possible to add more information to the `Reason` in\r\nthe result/report for the state failure, e.g. by using the warning\r\nthere, or throwing something instead?!\r\n\r\n          ID: example\r\n    Function: dockerng.running\r\n      Result: False\r\n     Comment: State 'dockerng.running' was not found in SLS 'example'\r\n              Reason: 'dockerng' __virtual__ returned False\r\n     Started:\r\n    Duration:\r\n     Changes:","created_at":"2015-10-01T19:51:25Z","updated_at":"2015-10-02T19:51:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ba6191ec1be85c8992f9b4b5fcd792d3510692a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/27602/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/27602/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/27602/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/b92c36a92b4270e64b4f7ac03840a065b4dc8998","head":{"label":"blueyed:dockerng-fix-version-warning","ref":"dockerng-fix-version-warning","sha":"b92c36a92b4270e64b4f7ac03840a065b4dc8998","user":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"repo":{"id":43085154,"name":"salt","full_name":"blueyed/salt","owner":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blueyed/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/blueyed/salt","forks_url":"https://api.github.com/repos/blueyed/salt/forks","keys_url":"https://api.github.com/repos/blueyed/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blueyed/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blueyed/salt/teams","hooks_url":"https://api.github.com/repos/blueyed/salt/hooks","issue_events_url":"https://api.github.com/repos/blueyed/salt/issues/events{/number}","events_url":"https://api.github.com/repos/blueyed/salt/events","assignees_url":"https://api.github.com/repos/blueyed/salt/assignees{/user}","branches_url":"https://api.github.com/repos/blueyed/salt/branches{/branch}","tags_url":"https://api.github.com/repos/blueyed/salt/tags","blobs_url":"https://api.github.com/repos/blueyed/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blueyed/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blueyed/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/blueyed/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blueyed/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/blueyed/salt/languages","stargazers_url":"https://api.github.com/repos/blueyed/salt/stargazers","contributors_url":"https://api.github.com/repos/blueyed/salt/contributors","subscribers_url":"https://api.github.com/repos/blueyed/salt/subscribers","subscription_url":"https://api.github.com/repos/blueyed/salt/subscription","commits_url":"https://api.github.com/repos/blueyed/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/blueyed/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/blueyed/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/blueyed/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/blueyed/salt/contents/{+path}","compare_url":"https://api.github.com/repos/blueyed/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blueyed/salt/merges","archive_url":"https://api.github.com/repos/blueyed/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blueyed/salt/downloads","issues_url":"https://api.github.com/repos/blueyed/salt/issues{/number}","pulls_url":"https://api.github.com/repos/blueyed/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/blueyed/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/blueyed/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blueyed/salt/labels{/name}","releases_url":"https://api.github.com/repos/blueyed/salt/releases{/id}","created_at":"2015-09-24T18:27:53Z","updated_at":"2015-09-24T18:28:16Z","pushed_at":"2015-10-02T15:58:13Z","git_url":"git://github.com/blueyed/salt.git","ssh_url":"git@github.com:blueyed/salt.git","clone_url":"https://github.com/blueyed/salt.git","svn_url":"https://github.com/blueyed/salt","homepage":"saltstack.com","size":123682,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:2015.8","ref":"2015.8","sha":"db963b7864b97de134c4db40274c0eafe5d9453e","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2015-10-02T18:24:05Z","pushed_at":"2015-10-02T19:35:04Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":251546,"stargazers_count":5697,"watchers_count":5697,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2433,"mirror_url":null,"open_issues_count":2990,"forks":2433,"open_issues":2990,"watchers":5697,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/27602"},"html":{"href":"https://github.com/saltstack/salt/pull/27602"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/27602"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/27602/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/27602/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/27602/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/b92c36a92b4270e64b4f7ac03840a065b4dc8998"}}}}