{"action":"created","comment":{"url":"https://api.github.com/repos/jmuheim/base/pulls/comments/31642635","id":31642635,"diff_hunk":"@@ -52,9 +55,12 @@\n \n     fill_in 'user_current_password', with: 's3cur3p@ssw0rd'\n \n+    image_before = @user.avatar.to_s","path":"spec/features/file_upload_spec.rb","position":45,"original_position":45,"commit_id":"a61dd62b32312bb9efffed1016214ac28c51db89","original_commit_id":"a61dd62b32312bb9efffed1016214ac28c51db89","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Useless assignment to variable - `image_before`.","created_at":"2015-06-03T16:38:45Z","updated_at":"2015-06-03T16:38:45Z","html_url":"https://github.com/jmuheim/base/pull/57#discussion_r31642635","pull_request_url":"https://api.github.com/repos/jmuheim/base/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/jmuheim/base/pulls/comments/31642635"},"html":{"href":"https://github.com/jmuheim/base/pull/57#discussion_r31642635"},"pull_request":{"href":"https://api.github.com/repos/jmuheim/base/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/jmuheim/base/pulls/57","id":33269873,"html_url":"https://github.com/jmuheim/base/pull/57","diff_url":"https://github.com/jmuheim/base/pull/57.diff","patch_url":"https://github.com/jmuheim/base/pull/57.patch","issue_url":"https://api.github.com/repos/jmuheim/base/issues/57","number":57,"state":"open","locked":false,"title":"Versioning model data with PaperTrail","user":{"login":"jmuheim","id":1814983,"avatar_url":"https://avatars.githubusercontent.com/u/1814983?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuheim","html_url":"https://github.com/jmuheim","followers_url":"https://api.github.com/users/jmuheim/followers","following_url":"https://api.github.com/users/jmuheim/following{/other_user}","gists_url":"https://api.github.com/users/jmuheim/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuheim/subscriptions","organizations_url":"https://api.github.com/users/jmuheim/orgs","repos_url":"https://api.github.com/users/jmuheim/repos","events_url":"https://api.github.com/users/jmuheim/events{/privacy}","received_events_url":"https://api.github.com/users/jmuheim/received_events","type":"User","site_admin":false},"body":"There seems to be a bug in either PaperTrail or Carrierwave which prevents me from merging this:\r\n\r\n[PaperTrail doesn't play nice with Carrierwave and `remove_previously_stored_files_after_update` option](http://stackoverflow.com/questions/29624223/papertrail-doesnt-play-nice-with-carrierwave-and-remove-previously-stored-file)\r\n\r\nOtherwise this is pretty cool. One \"solution\" for the problem above would to go without versioning file uploads.","created_at":"2015-04-14T15:36:28Z","updated_at":"2015-06-03T16:38:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fb937153105da4a4e83b8bf652d0d654c407bb7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmuheim/base/pulls/57/commits","review_comments_url":"https://api.github.com/repos/jmuheim/base/pulls/57/comments","review_comment_url":"https://api.github.com/repos/jmuheim/base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmuheim/base/issues/57/comments","statuses_url":"https://api.github.com/repos/jmuheim/base/statuses/a61dd62b32312bb9efffed1016214ac28c51db89","head":{"label":"jmuheim:features/paper_trail","ref":"features/paper_trail","sha":"a61dd62b32312bb9efffed1016214ac28c51db89","user":{"login":"jmuheim","id":1814983,"avatar_url":"https://avatars.githubusercontent.com/u/1814983?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuheim","html_url":"https://github.com/jmuheim","followers_url":"https://api.github.com/users/jmuheim/followers","following_url":"https://api.github.com/users/jmuheim/following{/other_user}","gists_url":"https://api.github.com/users/jmuheim/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuheim/subscriptions","organizations_url":"https://api.github.com/users/jmuheim/orgs","repos_url":"https://api.github.com/users/jmuheim/repos","events_url":"https://api.github.com/users/jmuheim/events{/privacy}","received_events_url":"https://api.github.com/users/jmuheim/received_events","type":"User","site_admin":false},"repo":{"id":14844899,"name":"base","full_name":"jmuheim/base","owner":{"login":"jmuheim","id":1814983,"avatar_url":"https://avatars.githubusercontent.com/u/1814983?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuheim","html_url":"https://github.com/jmuheim","followers_url":"https://api.github.com/users/jmuheim/followers","following_url":"https://api.github.com/users/jmuheim/following{/other_user}","gists_url":"https://api.github.com/users/jmuheim/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuheim/subscriptions","organizations_url":"https://api.github.com/users/jmuheim/orgs","repos_url":"https://api.github.com/users/jmuheim/repos","events_url":"https://api.github.com/users/jmuheim/events{/privacy}","received_events_url":"https://api.github.com/users/jmuheim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmuheim/base","description":"Pre-configured basic Rails project which aims to initialize a new preconfigured project fast and painless - simply fork it!","fork":false,"url":"https://api.github.com/repos/jmuheim/base","forks_url":"https://api.github.com/repos/jmuheim/base/forks","keys_url":"https://api.github.com/repos/jmuheim/base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmuheim/base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmuheim/base/teams","hooks_url":"https://api.github.com/repos/jmuheim/base/hooks","issue_events_url":"https://api.github.com/repos/jmuheim/base/issues/events{/number}","events_url":"https://api.github.com/repos/jmuheim/base/events","assignees_url":"https://api.github.com/repos/jmuheim/base/assignees{/user}","branches_url":"https://api.github.com/repos/jmuheim/base/branches{/branch}","tags_url":"https://api.github.com/repos/jmuheim/base/tags","blobs_url":"https://api.github.com/repos/jmuheim/base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmuheim/base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmuheim/base/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmuheim/base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmuheim/base/statuses/{sha}","languages_url":"https://api.github.com/repos/jmuheim/base/languages","stargazers_url":"https://api.github.com/repos/jmuheim/base/stargazers","contributors_url":"https://api.github.com/repos/jmuheim/base/contributors","subscribers_url":"https://api.github.com/repos/jmuheim/base/subscribers","subscription_url":"https://api.github.com/repos/jmuheim/base/subscription","commits_url":"https://api.github.com/repos/jmuheim/base/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmuheim/base/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmuheim/base/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmuheim/base/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmuheim/base/contents/{+path}","compare_url":"https://api.github.com/repos/jmuheim/base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmuheim/base/merges","archive_url":"https://api.github.com/repos/jmuheim/base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmuheim/base/downloads","issues_url":"https://api.github.com/repos/jmuheim/base/issues{/number}","pulls_url":"https://api.github.com/repos/jmuheim/base/pulls{/number}","milestones_url":"https://api.github.com/repos/jmuheim/base/milestones{/number}","notifications_url":"https://api.github.com/repos/jmuheim/base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmuheim/base/labels{/name}","releases_url":"https://api.github.com/repos/jmuheim/base/releases{/id}","created_at":"2013-12-01T19:40:01Z","updated_at":"2015-04-29T20:43:05Z","pushed_at":"2015-06-03T16:38:34Z","git_url":"git://github.com/jmuheim/base.git","ssh_url":"git@github.com:jmuheim/base.git","clone_url":"https://github.com/jmuheim/base.git","svn_url":"https://github.com/jmuheim/base","homepage":"","size":5034,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":15,"forks":7,"open_issues":15,"watchers":9,"default_branch":"master"}},"base":{"label":"jmuheim:master","ref":"master","sha":"09250706a95d3acfeaafc9dd3b929b09f5b3ac66","user":{"login":"jmuheim","id":1814983,"avatar_url":"https://avatars.githubusercontent.com/u/1814983?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuheim","html_url":"https://github.com/jmuheim","followers_url":"https://api.github.com/users/jmuheim/followers","following_url":"https://api.github.com/users/jmuheim/following{/other_user}","gists_url":"https://api.github.com/users/jmuheim/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuheim/subscriptions","organizations_url":"https://api.github.com/users/jmuheim/orgs","repos_url":"https://api.github.com/users/jmuheim/repos","events_url":"https://api.github.com/users/jmuheim/events{/privacy}","received_events_url":"https://api.github.com/users/jmuheim/received_events","type":"User","site_admin":false},"repo":{"id":14844899,"name":"base","full_name":"jmuheim/base","owner":{"login":"jmuheim","id":1814983,"avatar_url":"https://avatars.githubusercontent.com/u/1814983?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuheim","html_url":"https://github.com/jmuheim","followers_url":"https://api.github.com/users/jmuheim/followers","following_url":"https://api.github.com/users/jmuheim/following{/other_user}","gists_url":"https://api.github.com/users/jmuheim/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuheim/subscriptions","organizations_url":"https://api.github.com/users/jmuheim/orgs","repos_url":"https://api.github.com/users/jmuheim/repos","events_url":"https://api.github.com/users/jmuheim/events{/privacy}","received_events_url":"https://api.github.com/users/jmuheim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmuheim/base","description":"Pre-configured basic Rails project which aims to initialize a new preconfigured project fast and painless - simply fork it!","fork":false,"url":"https://api.github.com/repos/jmuheim/base","forks_url":"https://api.github.com/repos/jmuheim/base/forks","keys_url":"https://api.github.com/repos/jmuheim/base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmuheim/base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmuheim/base/teams","hooks_url":"https://api.github.com/repos/jmuheim/base/hooks","issue_events_url":"https://api.github.com/repos/jmuheim/base/issues/events{/number}","events_url":"https://api.github.com/repos/jmuheim/base/events","assignees_url":"https://api.github.com/repos/jmuheim/base/assignees{/user}","branches_url":"https://api.github.com/repos/jmuheim/base/branches{/branch}","tags_url":"https://api.github.com/repos/jmuheim/base/tags","blobs_url":"https://api.github.com/repos/jmuheim/base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmuheim/base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmuheim/base/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmuheim/base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmuheim/base/statuses/{sha}","languages_url":"https://api.github.com/repos/jmuheim/base/languages","stargazers_url":"https://api.github.com/repos/jmuheim/base/stargazers","contributors_url":"https://api.github.com/repos/jmuheim/base/contributors","subscribers_url":"https://api.github.com/repos/jmuheim/base/subscribers","subscription_url":"https://api.github.com/repos/jmuheim/base/subscription","commits_url":"https://api.github.com/repos/jmuheim/base/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmuheim/base/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmuheim/base/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmuheim/base/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmuheim/base/contents/{+path}","compare_url":"https://api.github.com/repos/jmuheim/base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmuheim/base/merges","archive_url":"https://api.github.com/repos/jmuheim/base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmuheim/base/downloads","issues_url":"https://api.github.com/repos/jmuheim/base/issues{/number}","pulls_url":"https://api.github.com/repos/jmuheim/base/pulls{/number}","milestones_url":"https://api.github.com/repos/jmuheim/base/milestones{/number}","notifications_url":"https://api.github.com/repos/jmuheim/base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmuheim/base/labels{/name}","releases_url":"https://api.github.com/repos/jmuheim/base/releases{/id}","created_at":"2013-12-01T19:40:01Z","updated_at":"2015-04-29T20:43:05Z","pushed_at":"2015-06-03T16:38:34Z","git_url":"git://github.com/jmuheim/base.git","ssh_url":"git@github.com:jmuheim/base.git","clone_url":"https://github.com/jmuheim/base.git","svn_url":"https://github.com/jmuheim/base","homepage":"","size":5034,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":15,"forks":7,"open_issues":15,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmuheim/base/pulls/57"},"html":{"href":"https://github.com/jmuheim/base/pull/57"},"issue":{"href":"https://api.github.com/repos/jmuheim/base/issues/57"},"comments":{"href":"https://api.github.com/repos/jmuheim/base/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/jmuheim/base/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/jmuheim/base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmuheim/base/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/jmuheim/base/statuses/a61dd62b32312bb9efffed1016214ac28c51db89"}}}}