{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/43039466","id":43039466,"diff_hunk":"@@ -0,0 +1,50 @@\n+#pragma once\n+\n+#include \"map/user_mark.hpp\"\n+#include \"map/styled_point.hpp\"\n+\n+class ApiMarkPoint : public StyledPoint","path":"map/api_mark_point.hpp","position":6,"original_position":6,"commit_id":"186b1472f2a61fb37dd2545fdc8aa75438beae1c","original_commit_id":"186b1472f2a61fb37dd2545fdc8aa75438beae1c","user":{"login":"deathbaba","id":170263,"avatar_url":"https://avatars.githubusercontent.com/u/170263?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbaba","html_url":"https://github.com/deathbaba","followers_url":"https://api.github.com/users/deathbaba/followers","following_url":"https://api.github.com/users/deathbaba/following{/other_user}","gists_url":"https://api.github.com/users/deathbaba/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbaba/subscriptions","organizations_url":"https://api.github.com/users/deathbaba/orgs","repos_url":"https://api.github.com/users/deathbaba/repos","events_url":"https://api.github.com/users/deathbaba/events{/privacy}","received_events_url":"https://api.github.com/users/deathbaba/received_events","type":"User","site_admin":false},"body":"Ok.","created_at":"2015-10-26T19:17:23Z","updated_at":"2015-10-26T19:17:23Z","html_url":"https://github.com/mapsme/omim/pull/335#discussion_r43039466","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/335","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/43039466"},"html":{"href":"https://github.com/mapsme/omim/pull/335#discussion_r43039466"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/335"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/335","id":48399778,"html_url":"https://github.com/mapsme/omim/pull/335","diff_url":"https://github.com/mapsme/omim/pull/335.diff","patch_url":"https://github.com/mapsme/omim/pull/335.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/335","number":335,"state":"open","locked":false,"title":"Parse URL s= parameter as point style","user":{"login":"kw217","id":587036,"avatar_url":"https://avatars.githubusercontent.com/u/587036?v=3","gravatar_id":"","url":"https://api.github.com/users/kw217","html_url":"https://github.com/kw217","followers_url":"https://api.github.com/users/kw217/followers","following_url":"https://api.github.com/users/kw217/following{/other_user}","gists_url":"https://api.github.com/users/kw217/gists{/gist_id}","starred_url":"https://api.github.com/users/kw217/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kw217/subscriptions","organizations_url":"https://api.github.com/users/kw217/orgs","repos_url":"https://api.github.com/users/kw217/repos","events_url":"https://api.github.com/users/kw217/events{/privacy}","received_events_url":"https://api.github.com/users/kw217/received_events","type":"User","site_admin":false},"body":"As outlined in #238:\r\n* Introduce StyledPoint class, and move style handling from Bookmark up to it.\r\n* Make ApiMarkPoint a StyledPoint.\r\n* Parse s= optional parameter in URL as the style.\r\n\r\nBefore and after shot below, for the same URL. The uppermost point is not styled (so defaults to red on the right). The original code (on left) ignores the style parameter and always shows a pink circle. After this PR (on right) the style parameter controls the appearance of the place marker.\r\n\r\n![omim-add-style](https://cloud.githubusercontent.com/assets/587036/10652691/8e036662-7850-11e5-88a0-a5d0eb8d462d.png)\r\n\r\nExisting tests all pass. Which tests should I be modifying to regression-test this fix?","created_at":"2015-10-21T23:07:36Z","updated_at":"2015-10-26T19:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcb054aff793eb587d42bf66f7354f538614ea9d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/335/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/335/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/335/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/186b1472f2a61fb37dd2545fdc8aa75438beae1c","head":{"label":"kw217:add-style","ref":"add-style","sha":"186b1472f2a61fb37dd2545fdc8aa75438beae1c","user":{"login":"kw217","id":587036,"avatar_url":"https://avatars.githubusercontent.com/u/587036?v=3","gravatar_id":"","url":"https://api.github.com/users/kw217","html_url":"https://github.com/kw217","followers_url":"https://api.github.com/users/kw217/followers","following_url":"https://api.github.com/users/kw217/following{/other_user}","gists_url":"https://api.github.com/users/kw217/gists{/gist_id}","starred_url":"https://api.github.com/users/kw217/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kw217/subscriptions","organizations_url":"https://api.github.com/users/kw217/orgs","repos_url":"https://api.github.com/users/kw217/repos","events_url":"https://api.github.com/users/kw217/events{/privacy}","received_events_url":"https://api.github.com/users/kw217/received_events","type":"User","site_admin":false},"repo":{"id":44248608,"name":"omim","full_name":"kw217/omim","owner":{"login":"kw217","id":587036,"avatar_url":"https://avatars.githubusercontent.com/u/587036?v=3","gravatar_id":"","url":"https://api.github.com/users/kw217","html_url":"https://github.com/kw217","followers_url":"https://api.github.com/users/kw217/followers","following_url":"https://api.github.com/users/kw217/following{/other_user}","gists_url":"https://api.github.com/users/kw217/gists{/gist_id}","starred_url":"https://api.github.com/users/kw217/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kw217/subscriptions","organizations_url":"https://api.github.com/users/kw217/orgs","repos_url":"https://api.github.com/users/kw217/repos","events_url":"https://api.github.com/users/kw217/events{/privacy}","received_events_url":"https://api.github.com/users/kw217/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kw217/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/kw217/omim","forks_url":"https://api.github.com/repos/kw217/omim/forks","keys_url":"https://api.github.com/repos/kw217/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kw217/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kw217/omim/teams","hooks_url":"https://api.github.com/repos/kw217/omim/hooks","issue_events_url":"https://api.github.com/repos/kw217/omim/issues/events{/number}","events_url":"https://api.github.com/repos/kw217/omim/events","assignees_url":"https://api.github.com/repos/kw217/omim/assignees{/user}","branches_url":"https://api.github.com/repos/kw217/omim/branches{/branch}","tags_url":"https://api.github.com/repos/kw217/omim/tags","blobs_url":"https://api.github.com/repos/kw217/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kw217/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kw217/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/kw217/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kw217/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/kw217/omim/languages","stargazers_url":"https://api.github.com/repos/kw217/omim/stargazers","contributors_url":"https://api.github.com/repos/kw217/omim/contributors","subscribers_url":"https://api.github.com/repos/kw217/omim/subscribers","subscription_url":"https://api.github.com/repos/kw217/omim/subscription","commits_url":"https://api.github.com/repos/kw217/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/kw217/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/kw217/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/kw217/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/kw217/omim/contents/{+path}","compare_url":"https://api.github.com/repos/kw217/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kw217/omim/merges","archive_url":"https://api.github.com/repos/kw217/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kw217/omim/downloads","issues_url":"https://api.github.com/repos/kw217/omim/issues{/number}","pulls_url":"https://api.github.com/repos/kw217/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/kw217/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/kw217/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kw217/omim/labels{/name}","releases_url":"https://api.github.com/repos/kw217/omim/releases{/id}","created_at":"2015-10-14T13:17:24Z","updated_at":"2015-10-14T13:19:35Z","pushed_at":"2015-10-21T23:01:52Z","git_url":"git://github.com/kw217/omim.git","ssh_url":"git@github.com:kw217/omim.git","clone_url":"https://github.com/kw217/omim.git","svn_url":"https://github.com/kw217/omim","homepage":null,"size":1788780,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"aa9a51afd2dcc6d5b3166d2876a2dc7845618600","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","created_at":"2015-09-20T02:57:13Z","updated_at":"2015-10-26T12:55:34Z","pushed_at":"2015-10-26T16:38:06Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":1828944,"stargazers_count":1414,"watchers_count":1414,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":48,"forks":148,"open_issues":48,"watchers":1414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/335"},"html":{"href":"https://github.com/mapsme/omim/pull/335"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/335"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/335/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/335/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/335/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/186b1472f2a61fb37dd2545fdc8aa75438beae1c"}}}}