{"action":"opened","number":946,"pull_request":{"url":"https://api.github.com/repos/ros-visualization/rviz/pulls/946","id":52580393,"html_url":"https://github.com/ros-visualization/rviz/pull/946","diff_url":"https://github.com/ros-visualization/rviz/pull/946.diff","patch_url":"https://github.com/ros-visualization/rviz/pull/946.patch","issue_url":"https://api.github.com/repos/ros-visualization/rviz/issues/946","number":946,"state":"open","locked":false,"title":"Fix for tf display not loading frame config","user":{"login":"bponsler","id":1627139,"avatar_url":"https://avatars.githubusercontent.com/u/1627139?v=3","gravatar_id":"","url":"https://api.github.com/users/bponsler","html_url":"https://github.com/bponsler","followers_url":"https://api.github.com/users/bponsler/followers","following_url":"https://api.github.com/users/bponsler/following{/other_user}","gists_url":"https://api.github.com/users/bponsler/gists{/gist_id}","starred_url":"https://api.github.com/users/bponsler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bponsler/subscriptions","organizations_url":"https://api.github.com/users/bponsler/orgs","repos_url":"https://api.github.com/users/bponsler/repos","events_url":"https://api.github.com/users/bponsler/events{/privacy}","received_events_url":"https://api.github.com/users/bponsler/received_events","type":"User","site_admin":false},"body":"This is a fix for issue [#834](https://github.com/ros-visualization/rviz/issues/834) using the changes from PR [#938](https://github.com/ros-visualization/rviz/pull/938) by @arntanguy with the following modifications:\r\n\r\n1. Rather than adding a new frame and setting the enabled state of the frame immediately when reading the config, the enabled state for each specified frame is stored in a map.\r\n2. Whenever a frame is being added to the display it looks up its enabled state in the map, and if it was configured as disabled the frame is set to be disabled.\r\n\r\nBecause no new frames are created when loading the config this properly handles the case where frames specified in the config file are not published at the time the config is read mentioned in PR [#938](https://github.com/ros-visualization/rviz/pull/938). \r\n\r\nThis also handles the case (mentioned by @hersh) where the set of frames specified in the config file are different than the set of frames being actively published. Since no new frames are created based on the config file only the intersection of those two sets will have their enabled state modified, and only the frames being actively published will be added to the display.","created_at":"2015-12-03T19:30:42Z","updated_at":"2015-12-03T19:30:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros-visualization/rviz/pulls/946/commits","review_comments_url":"https://api.github.com/repos/ros-visualization/rviz/pulls/946/comments","review_comment_url":"https://api.github.com/repos/ros-visualization/rviz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-visualization/rviz/issues/946/comments","statuses_url":"https://api.github.com/repos/ros-visualization/rviz/statuses/0baa9f351cb73f880141ecfabd61aaa224de7458","head":{"label":"bponsler:tf-load-frames","ref":"tf-load-frames","sha":"0baa9f351cb73f880141ecfabd61aaa224de7458","user":{"login":"bponsler","id":1627139,"avatar_url":"https://avatars.githubusercontent.com/u/1627139?v=3","gravatar_id":"","url":"https://api.github.com/users/bponsler","html_url":"https://github.com/bponsler","followers_url":"https://api.github.com/users/bponsler/followers","following_url":"https://api.github.com/users/bponsler/following{/other_user}","gists_url":"https://api.github.com/users/bponsler/gists{/gist_id}","starred_url":"https://api.github.com/users/bponsler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bponsler/subscriptions","organizations_url":"https://api.github.com/users/bponsler/orgs","repos_url":"https://api.github.com/users/bponsler/repos","events_url":"https://api.github.com/users/bponsler/events{/privacy}","received_events_url":"https://api.github.com/users/bponsler/received_events","type":"User","site_admin":false},"repo":{"id":47310875,"name":"rviz","full_name":"bponsler/rviz","owner":{"login":"bponsler","id":1627139,"avatar_url":"https://avatars.githubusercontent.com/u/1627139?v=3","gravatar_id":"","url":"https://api.github.com/users/bponsler","html_url":"https://github.com/bponsler","followers_url":"https://api.github.com/users/bponsler/followers","following_url":"https://api.github.com/users/bponsler/following{/other_user}","gists_url":"https://api.github.com/users/bponsler/gists{/gist_id}","starred_url":"https://api.github.com/users/bponsler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bponsler/subscriptions","organizations_url":"https://api.github.com/users/bponsler/orgs","repos_url":"https://api.github.com/users/bponsler/repos","events_url":"https://api.github.com/users/bponsler/events{/privacy}","received_events_url":"https://api.github.com/users/bponsler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bponsler/rviz","description":"ROS 3D Robot Visualizer","fork":true,"url":"https://api.github.com/repos/bponsler/rviz","forks_url":"https://api.github.com/repos/bponsler/rviz/forks","keys_url":"https://api.github.com/repos/bponsler/rviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bponsler/rviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bponsler/rviz/teams","hooks_url":"https://api.github.com/repos/bponsler/rviz/hooks","issue_events_url":"https://api.github.com/repos/bponsler/rviz/issues/events{/number}","events_url":"https://api.github.com/repos/bponsler/rviz/events","assignees_url":"https://api.github.com/repos/bponsler/rviz/assignees{/user}","branches_url":"https://api.github.com/repos/bponsler/rviz/branches{/branch}","tags_url":"https://api.github.com/repos/bponsler/rviz/tags","blobs_url":"https://api.github.com/repos/bponsler/rviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bponsler/rviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bponsler/rviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/bponsler/rviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bponsler/rviz/statuses/{sha}","languages_url":"https://api.github.com/repos/bponsler/rviz/languages","stargazers_url":"https://api.github.com/repos/bponsler/rviz/stargazers","contributors_url":"https://api.github.com/repos/bponsler/rviz/contributors","subscribers_url":"https://api.github.com/repos/bponsler/rviz/subscribers","subscription_url":"https://api.github.com/repos/bponsler/rviz/subscription","commits_url":"https://api.github.com/repos/bponsler/rviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/bponsler/rviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/bponsler/rviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/bponsler/rviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/bponsler/rviz/contents/{+path}","compare_url":"https://api.github.com/repos/bponsler/rviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bponsler/rviz/merges","archive_url":"https://api.github.com/repos/bponsler/rviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bponsler/rviz/downloads","issues_url":"https://api.github.com/repos/bponsler/rviz/issues{/number}","pulls_url":"https://api.github.com/repos/bponsler/rviz/pulls{/number}","milestones_url":"https://api.github.com/repos/bponsler/rviz/milestones{/number}","notifications_url":"https://api.github.com/repos/bponsler/rviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bponsler/rviz/labels{/name}","releases_url":"https://api.github.com/repos/bponsler/rviz/releases{/id}","created_at":"2015-12-03T05:44:37Z","updated_at":"2015-12-03T05:44:40Z","pushed_at":"2015-12-03T19:08:47Z","git_url":"git://github.com/bponsler/rviz.git","ssh_url":"git@github.com:bponsler/rviz.git","clone_url":"https://github.com/bponsler/rviz.git","svn_url":"https://github.com/bponsler/rviz","homepage":null,"size":12656,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"indigo-devel"}},"base":{"label":"ros-visualization:indigo-devel","ref":"indigo-devel","sha":"4a0f6c19b626b67d405eb0aa3f089b317c75da24","user":{"login":"ros-visualization","id":2328629,"avatar_url":"https://avatars.githubusercontent.com/u/2328629?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-visualization","html_url":"https://github.com/ros-visualization","followers_url":"https://api.github.com/users/ros-visualization/followers","following_url":"https://api.github.com/users/ros-visualization/following{/other_user}","gists_url":"https://api.github.com/users/ros-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-visualization/subscriptions","organizations_url":"https://api.github.com/users/ros-visualization/orgs","repos_url":"https://api.github.com/users/ros-visualization/repos","events_url":"https://api.github.com/users/ros-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/ros-visualization/received_events","type":"Organization","site_admin":false},"repo":{"id":5860736,"name":"rviz","full_name":"ros-visualization/rviz","owner":{"login":"ros-visualization","id":2328629,"avatar_url":"https://avatars.githubusercontent.com/u/2328629?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-visualization","html_url":"https://github.com/ros-visualization","followers_url":"https://api.github.com/users/ros-visualization/followers","following_url":"https://api.github.com/users/ros-visualization/following{/other_user}","gists_url":"https://api.github.com/users/ros-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-visualization/subscriptions","organizations_url":"https://api.github.com/users/ros-visualization/orgs","repos_url":"https://api.github.com/users/ros-visualization/repos","events_url":"https://api.github.com/users/ros-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/ros-visualization/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-visualization/rviz","description":"ROS 3D Robot Visualizer","fork":false,"url":"https://api.github.com/repos/ros-visualization/rviz","forks_url":"https://api.github.com/repos/ros-visualization/rviz/forks","keys_url":"https://api.github.com/repos/ros-visualization/rviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-visualization/rviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-visualization/rviz/teams","hooks_url":"https://api.github.com/repos/ros-visualization/rviz/hooks","issue_events_url":"https://api.github.com/repos/ros-visualization/rviz/issues/events{/number}","events_url":"https://api.github.com/repos/ros-visualization/rviz/events","assignees_url":"https://api.github.com/repos/ros-visualization/rviz/assignees{/user}","branches_url":"https://api.github.com/repos/ros-visualization/rviz/branches{/branch}","tags_url":"https://api.github.com/repos/ros-visualization/rviz/tags","blobs_url":"https://api.github.com/repos/ros-visualization/rviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-visualization/rviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-visualization/rviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-visualization/rviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-visualization/rviz/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-visualization/rviz/languages","stargazers_url":"https://api.github.com/repos/ros-visualization/rviz/stargazers","contributors_url":"https://api.github.com/repos/ros-visualization/rviz/contributors","subscribers_url":"https://api.github.com/repos/ros-visualization/rviz/subscribers","subscription_url":"https://api.github.com/repos/ros-visualization/rviz/subscription","commits_url":"https://api.github.com/repos/ros-visualization/rviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-visualization/rviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-visualization/rviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-visualization/rviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-visualization/rviz/contents/{+path}","compare_url":"https://api.github.com/repos/ros-visualization/rviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-visualization/rviz/merges","archive_url":"https://api.github.com/repos/ros-visualization/rviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-visualization/rviz/downloads","issues_url":"https://api.github.com/repos/ros-visualization/rviz/issues{/number}","pulls_url":"https://api.github.com/repos/ros-visualization/rviz/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-visualization/rviz/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-visualization/rviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-visualization/rviz/labels{/name}","releases_url":"https://api.github.com/repos/ros-visualization/rviz/releases{/id}","created_at":"2012-09-18T18:15:03Z","updated_at":"2015-11-05T09:09:09Z","pushed_at":"2015-11-30T14:56:50Z","git_url":"git://github.com/ros-visualization/rviz.git","ssh_url":"git@github.com:ros-visualization/rviz.git","clone_url":"https://github.com/ros-visualization/rviz.git","svn_url":"https://github.com/ros-visualization/rviz","homepage":null,"size":18116,"stargazers_count":44,"watchers_count":44,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":86,"forks":112,"open_issues":86,"watchers":44,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/946"},"html":{"href":"https://github.com/ros-visualization/rviz/pull/946"},"issue":{"href":"https://api.github.com/repos/ros-visualization/rviz/issues/946"},"comments":{"href":"https://api.github.com/repos/ros-visualization/rviz/issues/946/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/946/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/946/commits"},"statuses":{"href":"https://api.github.com/repos/ros-visualization/rviz/statuses/0baa9f351cb73f880141ecfabd61aaa224de7458"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":35,"deletions":0,"changed_files":2}}