{"action":"closed","issue":{"url":"https://api.github.com/repos/beanumber/openWAR/issues/84","labels_url":"https://api.github.com/repos/beanumber/openWAR/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/beanumber/openWAR/issues/84/comments","events_url":"https://api.github.com/repos/beanumber/openWAR/issues/84/events","html_url":"https://github.com/beanumber/openWAR/issues/84","id":91618272,"number":84,"title":"fix generics","user":{"login":"beanumber","id":2774211,"avatar_url":"https://avatars.githubusercontent.com/u/2774211?v=3","gravatar_id":"","url":"https://api.github.com/users/beanumber","html_url":"https://github.com/beanumber","followers_url":"https://api.github.com/users/beanumber/followers","following_url":"https://api.github.com/users/beanumber/following{/other_user}","gists_url":"https://api.github.com/users/beanumber/gists{/gist_id}","starred_url":"https://api.github.com/users/beanumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beanumber/subscriptions","organizations_url":"https://api.github.com/users/beanumber/orgs","repos_url":"https://api.github.com/users/beanumber/repos","events_url":"https://api.github.com/users/beanumber/events{/privacy}","received_events_url":"https://api.github.com/users/beanumber/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-28T17:23:36Z","updated_at":"2015-07-17T20:01:23Z","closed_at":"2015-07-17T20:01:23Z","body":"From @rpruim:\r\n> Just glancing through your shakeWAR.R file I see some stuff that I think you should fix sooner rather than later.\r\n\r\n```\r\nreturn(shakeWAR.openWARPlays(data$openWAR,\r\nN,\r\nresample,\r\n…))\r\n```\r\n\r\n> You should never make a call to `shakeWAR.openWARPlays()`. The call should be to `shakeWAR()` and method dispatch should do the right thing if `data$openWAR` is an `openWARPlays` object. If it is not, then you shouldn’t be using this function anyway. I think you should get a warning from CRAN checks about this."}}