{"action":"created","comment":{"url":"https://api.github.com/repos/vispy/vispy/pulls/comments/37188559","id":37188559,"diff_hunk":"@@ -64,8 +64,11 @@ def __init__(self, pos=(0, 0), size=(10, 10), border_color=None,\n         \n         # layout interaction\n         # todo: use Cassowary; see #277 \n-        self._fixed_size = (None, None)\n+        self._width_limits = [0, None]\n+        self._height_limits = [0, None]\n         self._stretch = (None, None)\n+        self.var_w = self.var_h = None  # HACK","path":"vispy/scene/widgets/widget.py","position":8,"original_position":8,"commit_id":"e9713cf051f4605ada36ca58a5acdf88b6df9c01","original_commit_id":"e9713cf051f4605ada36ca58a5acdf88b6df9c01","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"No need to squash\n","created_at":"2015-08-17T13:47:38Z","updated_at":"2015-08-17T13:47:38Z","html_url":"https://github.com/vispy/vispy/pull/1049#discussion_r37188559","pull_request_url":"https://api.github.com/repos/vispy/vispy/pulls/1049","_links":{"self":{"href":"https://api.github.com/repos/vispy/vispy/pulls/comments/37188559"},"html":{"href":"https://github.com/vispy/vispy/pull/1049#discussion_r37188559"},"pull_request":{"href":"https://api.github.com/repos/vispy/vispy/pulls/1049"}}},"pull_request":{"url":"https://api.github.com/repos/vispy/vispy/pulls/1049","id":42167920,"html_url":"https://github.com/vispy/vispy/pull/1049","diff_url":"https://github.com/vispy/vispy/pull/1049.diff","patch_url":"https://github.com/vispy/vispy/pull/1049.patch","issue_url":"https://api.github.com/repos/vispy/vispy/issues/1049","number":1049,"state":"open","locked":false,"title":"[WIP] Layout grids using Cassowary","user":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"body":"- [ ] Get baseline implementation working (just layout, no padding / margins)\r\n- [ ] Implement margins\r\n- [ ] Implement padding\r\n\r\n- [ ] document code\r\n- [ ] Regular test cases\r\n- [ ] Pathological extreme test cases ","created_at":"2015-08-11T19:31:21Z","updated_at":"2015-08-17T13:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"753e65f81f8463ba9fd5c169a1a823d1fa11ba3f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vispy/vispy/pulls/1049/commits","review_comments_url":"https://api.github.com/repos/vispy/vispy/pulls/1049/comments","review_comment_url":"https://api.github.com/repos/vispy/vispy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vispy/vispy/issues/1049/comments","statuses_url":"https://api.github.com/repos/vispy/vispy/statuses/e9713cf051f4605ada36ca58a5acdf88b6df9c01","head":{"label":"bollu:cassowary-constaints","ref":"cassowary-constaints","sha":"e9713cf051f4605ada36ca58a5acdf88b6df9c01","user":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"repo":{"id":31825193,"name":"vispy","full_name":"bollu/vispy","owner":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bollu/vispy","description":"Main repository for Vispy","fork":true,"url":"https://api.github.com/repos/bollu/vispy","forks_url":"https://api.github.com/repos/bollu/vispy/forks","keys_url":"https://api.github.com/repos/bollu/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bollu/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bollu/vispy/teams","hooks_url":"https://api.github.com/repos/bollu/vispy/hooks","issue_events_url":"https://api.github.com/repos/bollu/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/bollu/vispy/events","assignees_url":"https://api.github.com/repos/bollu/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/bollu/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/bollu/vispy/tags","blobs_url":"https://api.github.com/repos/bollu/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bollu/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bollu/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/bollu/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bollu/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/bollu/vispy/languages","stargazers_url":"https://api.github.com/repos/bollu/vispy/stargazers","contributors_url":"https://api.github.com/repos/bollu/vispy/contributors","subscribers_url":"https://api.github.com/repos/bollu/vispy/subscribers","subscription_url":"https://api.github.com/repos/bollu/vispy/subscription","commits_url":"https://api.github.com/repos/bollu/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/bollu/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/bollu/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/bollu/vispy/issues/comments{/number}","contents_url":"https://api.github.com/repos/bollu/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/bollu/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bollu/vispy/merges","archive_url":"https://api.github.com/repos/bollu/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bollu/vispy/downloads","issues_url":"https://api.github.com/repos/bollu/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/bollu/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/bollu/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/bollu/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bollu/vispy/labels{/name}","releases_url":"https://api.github.com/repos/bollu/vispy/releases{/id}","created_at":"2015-03-07T19:53:28Z","updated_at":"2015-03-07T19:53:30Z","pushed_at":"2015-08-17T06:32:12Z","git_url":"git://github.com/bollu/vispy.git","ssh_url":"git@github.com:bollu/vispy.git","clone_url":"https://github.com/bollu/vispy.git","svn_url":"https://github.com/bollu/vispy","homepage":"http://vispy.org","size":10027,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vispy:master","ref":"master","sha":"e50b4b57497aa5bfd6cc3ead4ab0588a466fac3d","user":{"login":"vispy","id":3934254,"avatar_url":"https://avatars.githubusercontent.com/u/3934254?v=3","gravatar_id":"","url":"https://api.github.com/users/vispy","html_url":"https://github.com/vispy","followers_url":"https://api.github.com/users/vispy/followers","following_url":"https://api.github.com/users/vispy/following{/other_user}","gists_url":"https://api.github.com/users/vispy/gists{/gist_id}","starred_url":"https://api.github.com/users/vispy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vispy/subscriptions","organizations_url":"https://api.github.com/users/vispy/orgs","repos_url":"https://api.github.com/users/vispy/repos","events_url":"https://api.github.com/users/vispy/events{/privacy}","received_events_url":"https://api.github.com/users/vispy/received_events","type":"Organization","site_admin":false},"repo":{"id":8935948,"name":"vispy","full_name":"vispy/vispy","owner":{"login":"vispy","id":3934254,"avatar_url":"https://avatars.githubusercontent.com/u/3934254?v=3","gravatar_id":"","url":"https://api.github.com/users/vispy","html_url":"https://github.com/vispy","followers_url":"https://api.github.com/users/vispy/followers","following_url":"https://api.github.com/users/vispy/following{/other_user}","gists_url":"https://api.github.com/users/vispy/gists{/gist_id}","starred_url":"https://api.github.com/users/vispy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vispy/subscriptions","organizations_url":"https://api.github.com/users/vispy/orgs","repos_url":"https://api.github.com/users/vispy/repos","events_url":"https://api.github.com/users/vispy/events{/privacy}","received_events_url":"https://api.github.com/users/vispy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vispy/vispy","description":"Main repository for Vispy","fork":false,"url":"https://api.github.com/repos/vispy/vispy","forks_url":"https://api.github.com/repos/vispy/vispy/forks","keys_url":"https://api.github.com/repos/vispy/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vispy/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vispy/vispy/teams","hooks_url":"https://api.github.com/repos/vispy/vispy/hooks","issue_events_url":"https://api.github.com/repos/vispy/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/vispy/vispy/events","assignees_url":"https://api.github.com/repos/vispy/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/vispy/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/vispy/vispy/tags","blobs_url":"https://api.github.com/repos/vispy/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vispy/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vispy/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/vispy/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vispy/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/vispy/vispy/languages","stargazers_url":"https://api.github.com/repos/vispy/vispy/stargazers","contributors_url":"https://api.github.com/repos/vispy/vispy/contributors","subscribers_url":"https://api.github.com/repos/vispy/vispy/subscribers","subscription_url":"https://api.github.com/repos/vispy/vispy/subscription","commits_url":"https://api.github.com/repos/vispy/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/vispy/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/vispy/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/vispy/vispy/issues/comments{/number}","contents_url":"https://api.github.com/repos/vispy/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/vispy/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vispy/vispy/merges","archive_url":"https://api.github.com/repos/vispy/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vispy/vispy/downloads","issues_url":"https://api.github.com/repos/vispy/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/vispy/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/vispy/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/vispy/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vispy/vispy/labels{/name}","releases_url":"https://api.github.com/repos/vispy/vispy/releases{/id}","created_at":"2013-03-21T18:43:22Z","updated_at":"2015-08-15T17:21:14Z","pushed_at":"2015-08-17T09:41:27Z","git_url":"git://github.com/vispy/vispy.git","ssh_url":"git@github.com:vispy/vispy.git","clone_url":"https://github.com/vispy/vispy.git","svn_url":"https://github.com/vispy/vispy","homepage":"http://vispy.org","size":18806,"stargazers_count":698,"watchers_count":698,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":165,"forks":125,"open_issues":165,"watchers":698,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vispy/vispy/pulls/1049"},"html":{"href":"https://github.com/vispy/vispy/pull/1049"},"issue":{"href":"https://api.github.com/repos/vispy/vispy/issues/1049"},"comments":{"href":"https://api.github.com/repos/vispy/vispy/issues/1049/comments"},"review_comments":{"href":"https://api.github.com/repos/vispy/vispy/pulls/1049/comments"},"review_comment":{"href":"https://api.github.com/repos/vispy/vispy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vispy/vispy/pulls/1049/commits"},"statuses":{"href":"https://api.github.com/repos/vispy/vispy/statuses/e9713cf051f4605ada36ca58a5acdf88b6df9c01"}}}}