{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/14079","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/14079/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/14079/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/14079/events","html_url":"https://github.com/JuliaLang/julia/pull/14079","id":118161294,"number":14079,"title":"Add BoundsError tests for getindex","user":{"login":"zygmuntszpak","id":14922863,"avatar_url":"https://avatars.githubusercontent.com/u/14922863?v=3","gravatar_id":"","url":"https://api.github.com/users/zygmuntszpak","html_url":"https://github.com/zygmuntszpak","followers_url":"https://api.github.com/users/zygmuntszpak/followers","following_url":"https://api.github.com/users/zygmuntszpak/following{/other_user}","gists_url":"https://api.github.com/users/zygmuntszpak/gists{/gist_id}","starred_url":"https://api.github.com/users/zygmuntszpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zygmuntszpak/subscriptions","organizations_url":"https://api.github.com/users/zygmuntszpak/orgs","repos_url":"https://api.github.com/users/zygmuntszpak/repos","events_url":"https://api.github.com/users/zygmuntszpak/events{/privacy}","received_events_url":"https://api.github.com/users/zygmuntszpak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/JuliaLang/julia/labels/backport%20pending%200.4","name":"backport pending 0.4","color":"fad8c7"},{"url":"https://api.github.com/repos/JuliaLang/julia/labels/test","name":"test","color":"e102d8"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-11-21T01:52:16Z","updated_at":"2015-11-21T19:56:51Z","closed_at":"2015-11-21T19:56:51Z","pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/14079","html_url":"https://github.com/JuliaLang/julia/pull/14079","diff_url":"https://github.com/JuliaLang/julia/pull/14079.diff","patch_url":"https://github.com/JuliaLang/julia/pull/14079.patch"},"body":"The tests verify that calling `getindex` with an index that falls outside the allowed bounds indeed  throws a `BoundsError`."},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/158677635","html_url":"https://github.com/JuliaLang/julia/pull/14079#issuecomment-158677635","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/14079","id":158677635,"user":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"created_at":"2015-11-21T19:56:49Z","updated_at":"2015-11-21T19:56:49Z","body":"My query wasn't in having comments at all, but that the comments didn't make sense (to me). IMO comments should describe the intention e.g. \"The following attempts to cover the the following method definitions:\"... but if this is already implicit by convention in the testing code that's fine. I wasn't sure on best practice, hence the cc to @kshyatt."}}