{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/27197","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/27197/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/27197/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/27197/events","html_url":"https://github.com/rust-lang/rust/pull/27197","id":96379642,"number":27197,"title":"Use generic trait implementations for Cursor when possible.","user":{"login":"nwin","id":949560,"avatar_url":"https://avatars.githubusercontent.com/u/949560?v=3","gravatar_id":"","url":"https://api.github.com/users/nwin","html_url":"https://github.com/nwin","followers_url":"https://api.github.com/users/nwin/followers","following_url":"https://api.github.com/users/nwin/following{/other_user}","gists_url":"https://api.github.com/users/nwin/gists{/gist_id}","starred_url":"https://api.github.com/users/nwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwin/subscriptions","organizations_url":"https://api.github.com/users/nwin/orgs","repos_url":"https://api.github.com/users/nwin/repos","events_url":"https://api.github.com/users/nwin/events{/privacy}","received_events_url":"https://api.github.com/users/nwin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rust-lang/rust/labels/regression-from-stable-to-nightly","name":"regression-from-stable-to-nightly","color":"FF309F"},{"url":"https://api.github.com/repos/rust-lang/rust/labels/relnotes","name":"relnotes","color":"fad8c7"},{"url":"https://api.github.com/repos/rust-lang/rust/labels/T-libs","name":"T-libs","color":"bfd4f2"}],"state":"open","locked":false,"assignee":{"login":"aturon","id":709807,"avatar_url":"https://avatars.githubusercontent.com/u/709807?v=3","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"milestone":null,"comments":18,"created_at":"2015-07-21T18:08:17Z","updated_at":"2015-10-02T19:46:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/27197","html_url":"https://github.com/rust-lang/rust/pull/27197","diff_url":"https://github.com/rust-lang/rust/pull/27197.diff","patch_url":"https://github.com/rust-lang/rust/pull/27197.patch"},"body":"This is a revival of #23364. Github didn’t recognize my updated branch there.\r\n\r\nThe cursor implementation now uses `AsRef` which means that fixed-sized array can now be used with `Cursor`. Besides that, the generic implementation simplifies the code as the macro can be avoided.\r\n\r\nThe only drawback is, that specialized implementation for fixed-sized arrays are now ruled out unless [RFC#1210](https://github.com/rust-lang/rfcs/pull/1210) is accepted & implemented.\r\n\r\n`Box<[u8]>` cannot be used yet, but that should be mitigated by [implementing `AsRef` for `Box` and friends](https://internals.rust-lang.org/t/forward-implement-traits-on-smart-pointers-make-smart-pointers-more-transparent/2380/3). I will submit a separate PR for that later as it is an orthogonal issue."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/145138545","html_url":"https://github.com/rust-lang/rust/pull/27197#issuecomment-145138545","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/27197","id":145138545,"user":{"login":"nwin","id":949560,"avatar_url":"https://avatars.githubusercontent.com/u/949560?v=3","gravatar_id":"","url":"https://api.github.com/users/nwin","html_url":"https://github.com/nwin","followers_url":"https://api.github.com/users/nwin/followers","following_url":"https://api.github.com/users/nwin/following{/other_user}","gists_url":"https://api.github.com/users/nwin/gists{/gist_id}","starred_url":"https://api.github.com/users/nwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwin/subscriptions","organizations_url":"https://api.github.com/users/nwin/orgs","repos_url":"https://api.github.com/users/nwin/repos","events_url":"https://api.github.com/users/nwin/events{/privacy}","received_events_url":"https://api.github.com/users/nwin/received_events","type":"User","site_admin":false},"created_at":"2015-10-02T19:46:15Z","updated_at":"2015-10-02T19:46:15Z","body":"Great. I removed my latest commit and rebased onto master.\r\n\r\n`process::tests::test_inherit_env` fails it also doesn’t pass on master, probably some OSX 10.11 issue…"}}