{"action":"closed","issue":{"url":"https://api.github.com/repos/phoemur/ipgetter/issues/7","labels_url":"https://api.github.com/repos/phoemur/ipgetter/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/phoemur/ipgetter/issues/7/comments","events_url":"https://api.github.com/repos/phoemur/ipgetter/issues/7/events","html_url":"https://github.com/phoemur/ipgetter/issues/7","id":68834357,"number":7,"title":"What do you think about having a limit for the loop in get_externalip?","user":{"login":"robertsdotpm","id":7320766,"avatar_url":"https://avatars.githubusercontent.com/u/7320766?v=3","gravatar_id":"","url":"https://api.github.com/users/robertsdotpm","html_url":"https://github.com/robertsdotpm","followers_url":"https://api.github.com/users/robertsdotpm/followers","following_url":"https://api.github.com/users/robertsdotpm/following{/other_user}","gists_url":"https://api.github.com/users/robertsdotpm/gists{/gist_id}","starred_url":"https://api.github.com/users/robertsdotpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertsdotpm/subscriptions","organizations_url":"https://api.github.com/users/robertsdotpm/orgs","repos_url":"https://api.github.com/users/robertsdotpm/repos","events_url":"https://api.github.com/users/robertsdotpm/events{/privacy}","received_events_url":"https://api.github.com/users/robertsdotpm/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-16T03:12:49Z","updated_at":"2015-04-16T18:41:01Z","closed_at":"2015-04-16T18:41:01Z","body":"So I was thinking maybe there should be a limit of say 5 checks in the get_externalip loop (and possibly lower.)  If you assume a timeout of 2 seconds and there's a network fault you're currently stuck having to check for a total of len(self.server_list) * self.timeout which is 90 seconds in my fork.\r\n\r\nI know this is only a simple script and maybe I'm over complicating things but it seems to me it should fail earlier rather than blocking a whole program for an indefinite amount of time (this bug has already bitten me simply because I use it literally every day :coffee: under many different conditions )"}}