{"action":"created","issue":{"url":"https://api.github.com/repos/01org/parameter-framework/issues/317","labels_url":"https://api.github.com/repos/01org/parameter-framework/issues/317/labels{/name}","comments_url":"https://api.github.com/repos/01org/parameter-framework/issues/317/comments","events_url":"https://api.github.com/repos/01org/parameter-framework/issues/317/events","html_url":"https://github.com/01org/parameter-framework/pull/317","id":119492309,"number":317,"title":"[review] Decorrelating auto-sync and tuning-mode","user":{"login":"tcahuzax","id":11178583,"avatar_url":"https://avatars.githubusercontent.com/u/11178583?v=3","gravatar_id":"","url":"https://api.github.com/users/tcahuzax","html_url":"https://github.com/tcahuzax","followers_url":"https://api.github.com/users/tcahuzax/followers","following_url":"https://api.github.com/users/tcahuzax/following{/other_user}","gists_url":"https://api.github.com/users/tcahuzax/gists{/gist_id}","starred_url":"https://api.github.com/users/tcahuzax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcahuzax/subscriptions","organizations_url":"https://api.github.com/users/tcahuzax/orgs","repos_url":"https://api.github.com/users/tcahuzax/repos","events_url":"https://api.github.com/users/tcahuzax/events{/privacy}","received_events_url":"https://api.github.com/users/tcahuzax/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-30T13:33:52Z","updated_at":"2015-12-03T15:57:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/317","html_url":"https://github.com/01org/parameter-framework/pull/317","diff_url":"https://github.com/01org/parameter-framework/pull/317.diff","patch_url":"https://github.com/01org/parameter-framework/pull/317.patch"},"body":"Signed-off-by: Thomas Cahuzac <thomasx.cahuzac@intel.com>\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/01org/parameter-framework/pull/317%23issuecomment-161270712%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/317%23issuecomment-161633608%22%2C%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761619%22%2C%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761626%22%2C%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761655%22%2C%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761668%22%2C%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761672%22%2C%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761703%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/317%23issuecomment-161270712%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%40dawagner%20%20%40krocard%20%20plz%20review%22%2C%20%22created_at%22%3A%20%222015-12-02T11%3A53%3A47Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/11178583%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tcahuzax%22%7D%7D%2C%20%7B%22body%22%3A%20%22In%20the%20%5C%22Adding%20the%20ability%20to%20set%20configuration%20value%5C%22%20and%20%5C%22Allowing%20to%20choose%20the%20subsystem%20type%5C%22%20commit%20messages%2C%20please%20add%20a%20context%20information%20in%20the%20headline%3A%20as%20they%20stand%2C%20they%20seem%20to%20suggest%2C%20for%20instance%2C%20that%20the%20Parameter%20Framework%20does%20not%20provide%20the%20ability%20to%20set%20a%20configuration%20value%20at%20all.%22%2C%20%22created_at%22%3A%20%222015-12-03T13%3A08%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Commit%202cf7ee147792da4bd384ffc6002614f8c4ae8a1a%20test/functional-tests/AutoSync.cpp%2099%2099%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761668%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Since%20it%20is%20a%20prerequisite%2C%20I%27d%20make%20this%20a%20require%20instead%20of%20a%20check.%22%2C%20%22created_at%22%3A%20%222015-12-03T13%3A28%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20test/functional-tests/AutoSync.cpp%3AL99%20%282cf7ee1%29%22%7D%2C%20%22Commit%202cf7ee147792da4bd384ffc6002614f8c4ae8a1a%20test/functional-tests/AutoSync.cpp%20107%20107%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761672%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22same%20comment%20as%20line%2099.%22%2C%20%22created_at%22%3A%20%222015-12-03T13%3A28%3A35Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20test/functional-tests/AutoSync.cpp%3AL107%20%282cf7ee1%29%22%7D%2C%20%22Commit%202cf7ee147792da4bd384ffc6002614f8c4ae8a1a%20test/functional-tests/AutoSync.cpp%2093%2093%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761655%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%27d%20make%20this%20a%20require%20instead%20of%20a%20check.%22%2C%20%22created_at%22%3A%20%222015-12-03T13%3A27%3A59Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20test/functional-tests/AutoSync.cpp%3AL93%20%282cf7ee1%29%22%7D%2C%20%22Commit%202cf7ee147792da4bd384ffc6002614f8c4ae8a1a%20test/functional-tests/AutoSync.cpp%20101%20101%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761626%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22s/when/as%20soon%20as/%22%2C%20%22created_at%22%3A%20%222015-12-03T13%3A26%3A41Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20test/functional-tests/AutoSync.cpp%3AL101%20%282cf7ee1%29%22%7D%2C%20%22Commit%202cf7ee147792da4bd384ffc6002614f8c4ae8a1a%20test/functional-tests/AutoSync.cpp%2098%2098%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761619%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22WHEN%28%5C%22Turning%20autosync%20on%5C%22%29%22%2C%20%22created_at%22%3A%20%222015-12-03T13%3A26%3A19Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20test/functional-tests/AutoSync.cpp%3AL98%20%282cf7ee1%29%22%7D%2C%20%22Commit%202cf7ee147792da4bd384ffc6002614f8c4ae8a1a%20test/functional-tests/AutoSync.cpp%20113%20113%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a%23commitcomment-14761703%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22You%20can%20replace%20comments%20with%20sections%2C%20so%20that%20they%20still%20%5C%22comment%5C%22%20the%20code%20and%20will%20also%20appear%20in%20test%20description/result.%22%2C%20%22created_at%22%3A%20%222015-12-03T13%3A30%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20test/functional-tests/AutoSync.cpp%3AL113%20%282cf7ee1%29%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/317#issuecomment-161270712'>General Comment</a></b>\n- <a href='https://github.com/tcahuzax'><img border=0 src='https://avatars.githubusercontent.com/u/11178583?v=3' height=16 width=16'></a> @dawagner  @krocard  plz review\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> In the \"Adding the ability to set configuration value\" and \"Allowing to choose the subsystem type\" commit messages, please add a context information in the headline: as they stand, they seem to suggest, for instance, that the Parameter Framework does not provide the ability to set a configuration value at all.\n- [ ] <a href='#crh-comment-Commit 2cf7ee147792da4bd384ffc6002614f8c4ae8a1a test/functional-tests/AutoSync.cpp 98 98'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a#commitcomment-14761619'>File: test/functional-tests/AutoSync.cpp:L98 (2cf7ee1)</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> WHEN(\"Turning autosync on\")\n- [ ] <a href='#crh-comment-Commit 2cf7ee147792da4bd384ffc6002614f8c4ae8a1a test/functional-tests/AutoSync.cpp 101 101'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a#commitcomment-14761626'>File: test/functional-tests/AutoSync.cpp:L101 (2cf7ee1)</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> s/when/as soon as/\n- [ ] <a href='#crh-comment-Commit 2cf7ee147792da4bd384ffc6002614f8c4ae8a1a test/functional-tests/AutoSync.cpp 93 93'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a#commitcomment-14761655'>File: test/functional-tests/AutoSync.cpp:L93 (2cf7ee1)</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> I'd make this a require instead of a check.\n- [ ] <a href='#crh-comment-Commit 2cf7ee147792da4bd384ffc6002614f8c4ae8a1a test/functional-tests/AutoSync.cpp 99 99'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a#commitcomment-14761668'>File: test/functional-tests/AutoSync.cpp:L99 (2cf7ee1)</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> Since it is a prerequisite, I'd make this a require instead of a check.\n- [ ] <a href='#crh-comment-Commit 2cf7ee147792da4bd384ffc6002614f8c4ae8a1a test/functional-tests/AutoSync.cpp 107 107'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a#commitcomment-14761672'>File: test/functional-tests/AutoSync.cpp:L107 (2cf7ee1)</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> same comment as line 99.\n- [ ] <a href='#crh-comment-Commit 2cf7ee147792da4bd384ffc6002614f8c4ae8a1a test/functional-tests/AutoSync.cpp 113 113'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/commit/2cf7ee147792da4bd384ffc6002614f8c4ae8a1a#commitcomment-14761703'>File: test/functional-tests/AutoSync.cpp:L113 (2cf7ee1)</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> You can replace comments with sections, so that they still \"comment\" the code and will also appear in test description/result.\n\n\n<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/317?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/317?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/01org/parameter-framework/pull/317'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>"},"comment":{"url":"https://api.github.com/repos/01org/parameter-framework/issues/comments/161688202","html_url":"https://github.com/01org/parameter-framework/pull/317#issuecomment-161688202","issue_url":"https://api.github.com/repos/01org/parameter-framework/issues/317","id":161688202,"user":{"login":"tcahuzax","id":11178583,"avatar_url":"https://avatars.githubusercontent.com/u/11178583?v=3","gravatar_id":"","url":"https://api.github.com/users/tcahuzax","html_url":"https://github.com/tcahuzax","followers_url":"https://api.github.com/users/tcahuzax/followers","following_url":"https://api.github.com/users/tcahuzax/following{/other_user}","gists_url":"https://api.github.com/users/tcahuzax/gists{/gist_id}","starred_url":"https://api.github.com/users/tcahuzax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcahuzax/subscriptions","organizations_url":"https://api.github.com/users/tcahuzax/orgs","repos_url":"https://api.github.com/users/tcahuzax/repos","events_url":"https://api.github.com/users/tcahuzax/events{/privacy}","received_events_url":"https://api.github.com/users/tcahuzax/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T15:57:54Z","updated_at":"2015-12-03T15:57:54Z","body":"@dawagner @krocard plz review"}}