{"action":"created","issue":{"url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/980","labels_url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/980/labels{/name}","comments_url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/980/comments","events_url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/980/events","html_url":"https://github.com/MongoEngine/mongoengine/pull/980","id":71933986,"number":980,"title":"Pep8 and more clean-up","user":{"login":"MRigal","id":2190327,"avatar_url":"https://avatars.githubusercontent.com/u/2190327?v=3","gravatar_id":"","url":"https://api.github.com/users/MRigal","html_url":"https://github.com/MRigal","followers_url":"https://api.github.com/users/MRigal/followers","following_url":"https://api.github.com/users/MRigal/following{/other_user}","gists_url":"https://api.github.com/users/MRigal/gists{/gist_id}","starred_url":"https://api.github.com/users/MRigal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRigal/subscriptions","organizations_url":"https://api.github.com/users/MRigal/orgs","repos_url":"https://api.github.com/users/MRigal/repos","events_url":"https://api.github.com/users/MRigal/events{/privacy}","received_events_url":"https://api.github.com/users/MRigal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MongoEngine/mongoengine/labels/In%20Progress","name":"In Progress","color":"ededed"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/MongoEngine/mongoengine/milestones/17","html_url":"https://github.com/MongoEngine/mongoengine/milestones/0.10","labels_url":"https://api.github.com/repos/MongoEngine/mongoengine/milestones/17/labels","id":1098863,"number":17,"title":"0.10","description":"","creator":{"login":"MRigal","id":2190327,"avatar_url":"https://avatars.githubusercontent.com/u/2190327?v=3","gravatar_id":"","url":"https://api.github.com/users/MRigal","html_url":"https://github.com/MRigal","followers_url":"https://api.github.com/users/MRigal/followers","following_url":"https://api.github.com/users/MRigal/following{/other_user}","gists_url":"https://api.github.com/users/MRigal/gists{/gist_id}","starred_url":"https://api.github.com/users/MRigal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MRigal/subscriptions","organizations_url":"https://api.github.com/users/MRigal/orgs","repos_url":"https://api.github.com/users/MRigal/repos","events_url":"https://api.github.com/users/MRigal/events{/privacy}","received_events_url":"https://api.github.com/users/MRigal/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":36,"state":"closed","created_at":"2015-05-06T16:17:07Z","updated_at":"2015-06-24T08:21:08Z","due_on":"2015-06-20T22:00:00Z","closed_at":"2015-06-24T08:21:08Z"},"comments":26,"created_at":"2015-04-29T17:15:56Z","updated_at":"2015-06-24T11:22:27Z","closed_at":"2015-06-24T08:20:42Z","pull_request":{"url":"https://api.github.com/repos/MongoEngine/mongoengine/pulls/980","html_url":"https://github.com/MongoEngine/mongoengine/pull/980","diff_url":"https://github.com/MongoEngine/mongoengine/pull/980.diff","patch_url":"https://github.com/MongoEngine/mongoengine/pull/980.patch"},"body":"Hi guys,\r\n\r\nSeveral times I ran into some cases where I came across these init() method returning a value, or some unused statements or variables, as well as many pep8 issues. It is never great to make a big change, but since we are now cleaning so many PRs and there will be anyway a big PR with #946 for next version, I thought it could be a good time to clean generally some code.\r\n\r\nI took some time to really read once (quickly) all the code line by line. It allowed me also to find some issues or strange behaviour and to add some TODOs.\r\n\r\nI would also like to take the opportunity to tackle one other point. We want to be PEP8 conform and this is very good. However one point is at least vague: line length. We have in our code some pieces which are strictly limited to 79 characters and some others to 119.\r\n\r\nPEP8 recommends 79 characters, however Django makes some exceptions there: https://docs.djangoproject.com/en/1.8/internals/contributing/writing-code/coding-style/\r\n\r\nShould we include the same point in our contribution guidelines? Some PRs have a lot of code doing only line breaks clean-up (which I tried to avoid in this cleaning effort to avoid unnecessary changes). And at the same time, I see a lot of places in the code where we have line breaks that do make the code significantly harder to read. @rozza @DavidBord @thedrow @seglberg @yograterol can I have your opinion on that point?\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/mongoengine/mongoengine/980)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/comments/114835542","html_url":"https://github.com/MongoEngine/mongoengine/pull/980#issuecomment-114835542","issue_url":"https://api.github.com/repos/MongoEngine/mongoengine/issues/980","id":114835542,"user":{"login":"thedrow","id":48936,"avatar_url":"https://avatars.githubusercontent.com/u/48936?v=3","gravatar_id":"","url":"https://api.github.com/users/thedrow","html_url":"https://github.com/thedrow","followers_url":"https://api.github.com/users/thedrow/followers","following_url":"https://api.github.com/users/thedrow/following{/other_user}","gists_url":"https://api.github.com/users/thedrow/gists{/gist_id}","starred_url":"https://api.github.com/users/thedrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedrow/subscriptions","organizations_url":"https://api.github.com/users/thedrow/orgs","repos_url":"https://api.github.com/users/thedrow/repos","events_url":"https://api.github.com/users/thedrow/events{/privacy}","received_events_url":"https://api.github.com/users/thedrow/received_events","type":"User","site_admin":false},"created_at":"2015-06-24T11:22:27Z","updated_at":"2015-06-24T11:22:27Z","body":"It's released."}}