{"action":"closed","number":136,"pull_request":{"url":"https://api.github.com/repos/non/cats/pulls/136","id":28884333,"html_url":"https://github.com/non/cats/pull/136","diff_url":"https://github.com/non/cats/pull/136.diff","patch_url":"https://github.com/non/cats/pull/136.patch","issue_url":"https://api.github.com/repos/non/cats/issues/136","number":136,"state":"closed","locked":false,"title":"Decouple laws from discipline test code","user":{"login":"fthomas","id":141252,"avatar_url":"https://avatars.githubusercontent.com/u/141252?v=3","gravatar_id":"","url":"https://api.github.com/users/fthomas","html_url":"https://github.com/fthomas","followers_url":"https://api.github.com/users/fthomas/followers","following_url":"https://api.github.com/users/fthomas/following{/other_user}","gists_url":"https://api.github.com/users/fthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/fthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fthomas/subscriptions","organizations_url":"https://api.github.com/users/fthomas/orgs","repos_url":"https://api.github.com/users/fthomas/repos","events_url":"https://api.github.com/users/fthomas/events{/privacy}","received_events_url":"https://api.github.com/users/fthomas/received_events","type":"User","site_admin":false},"body":"This PR decouples the laws from the test code by adding a dedicated `Laws` class in the `cats.laws` package for each typeclass. The laws are stated such that they return a pair of values of the same type which will be equal for lawfull instances. The intention for this PR is to make the laws more visible by putting them in their own classes and by decoupling them from the test framework. See #81 for more details.\r\n\r\nfixes #81","created_at":"2015-02-08T18:36:21Z","updated_at":"2015-02-09T05:06:04Z","closed_at":"2015-02-09T05:06:04Z","merged_at":"2015-02-09T05:06:04Z","merge_commit_sha":"5224421b966092529436d692d8d9835c71e55c5f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/non/cats/pulls/136/commits","review_comments_url":"https://api.github.com/repos/non/cats/pulls/136/comments","review_comment_url":"https://api.github.com/repos/non/cats/pulls/comments/{number}","comments_url":"https://api.github.com/repos/non/cats/issues/136/comments","statuses_url":"https://api.github.com/repos/non/cats/statuses/d926634deecf0c2697ebcf025dd88c0bae612fad","head":{"label":"fthomas:wip/move-laws2","ref":"wip/move-laws2","sha":"d926634deecf0c2697ebcf025dd88c0bae612fad","user":{"login":"fthomas","id":141252,"avatar_url":"https://avatars.githubusercontent.com/u/141252?v=3","gravatar_id":"","url":"https://api.github.com/users/fthomas","html_url":"https://github.com/fthomas","followers_url":"https://api.github.com/users/fthomas/followers","following_url":"https://api.github.com/users/fthomas/following{/other_user}","gists_url":"https://api.github.com/users/fthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/fthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fthomas/subscriptions","organizations_url":"https://api.github.com/users/fthomas/orgs","repos_url":"https://api.github.com/users/fthomas/repos","events_url":"https://api.github.com/users/fthomas/events{/privacy}","received_events_url":"https://api.github.com/users/fthomas/received_events","type":"User","site_admin":false},"repo":{"id":30058421,"name":"cats","full_name":"fthomas/cats","owner":{"login":"fthomas","id":141252,"avatar_url":"https://avatars.githubusercontent.com/u/141252?v=3","gravatar_id":"","url":"https://api.github.com/users/fthomas","html_url":"https://github.com/fthomas","followers_url":"https://api.github.com/users/fthomas/followers","following_url":"https://api.github.com/users/fthomas/following{/other_user}","gists_url":"https://api.github.com/users/fthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/fthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fthomas/subscriptions","organizations_url":"https://api.github.com/users/fthomas/orgs","repos_url":"https://api.github.com/users/fthomas/repos","events_url":"https://api.github.com/users/fthomas/events{/privacy}","received_events_url":"https://api.github.com/users/fthomas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fthomas/cats","description":"","fork":true,"url":"https://api.github.com/repos/fthomas/cats","forks_url":"https://api.github.com/repos/fthomas/cats/forks","keys_url":"https://api.github.com/repos/fthomas/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fthomas/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fthomas/cats/teams","hooks_url":"https://api.github.com/repos/fthomas/cats/hooks","issue_events_url":"https://api.github.com/repos/fthomas/cats/issues/events{/number}","events_url":"https://api.github.com/repos/fthomas/cats/events","assignees_url":"https://api.github.com/repos/fthomas/cats/assignees{/user}","branches_url":"https://api.github.com/repos/fthomas/cats/branches{/branch}","tags_url":"https://api.github.com/repos/fthomas/cats/tags","blobs_url":"https://api.github.com/repos/fthomas/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fthomas/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fthomas/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/fthomas/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fthomas/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/fthomas/cats/languages","stargazers_url":"https://api.github.com/repos/fthomas/cats/stargazers","contributors_url":"https://api.github.com/repos/fthomas/cats/contributors","subscribers_url":"https://api.github.com/repos/fthomas/cats/subscribers","subscription_url":"https://api.github.com/repos/fthomas/cats/subscription","commits_url":"https://api.github.com/repos/fthomas/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/fthomas/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/fthomas/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/fthomas/cats/issues/comments/{number}","contents_url":"https://api.github.com/repos/fthomas/cats/contents/{+path}","compare_url":"https://api.github.com/repos/fthomas/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fthomas/cats/merges","archive_url":"https://api.github.com/repos/fthomas/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fthomas/cats/downloads","issues_url":"https://api.github.com/repos/fthomas/cats/issues{/number}","pulls_url":"https://api.github.com/repos/fthomas/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/fthomas/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/fthomas/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fthomas/cats/labels{/name}","releases_url":"https://api.github.com/repos/fthomas/cats/releases{/id}","created_at":"2015-01-30T05:55:08Z","updated_at":"2015-02-08T06:23:50Z","pushed_at":"2015-02-08T19:05:46Z","git_url":"git://github.com/fthomas/cats.git","ssh_url":"git@github.com:fthomas/cats.git","clone_url":"https://github.com/fthomas/cats.git","svn_url":"https://github.com/fthomas/cats","homepage":null,"size":492,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"non:master","ref":"master","sha":"b8f7f5fa17116b87099f673dfa51bf8caab0613e","user":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"repo":{"id":29986727,"name":"cats","full_name":"non/cats","owner":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/non/cats","description":"","fork":false,"url":"https://api.github.com/repos/non/cats","forks_url":"https://api.github.com/repos/non/cats/forks","keys_url":"https://api.github.com/repos/non/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/non/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/non/cats/teams","hooks_url":"https://api.github.com/repos/non/cats/hooks","issue_events_url":"https://api.github.com/repos/non/cats/issues/events{/number}","events_url":"https://api.github.com/repos/non/cats/events","assignees_url":"https://api.github.com/repos/non/cats/assignees{/user}","branches_url":"https://api.github.com/repos/non/cats/branches{/branch}","tags_url":"https://api.github.com/repos/non/cats/tags","blobs_url":"https://api.github.com/repos/non/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/non/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/non/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/non/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/non/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/non/cats/languages","stargazers_url":"https://api.github.com/repos/non/cats/stargazers","contributors_url":"https://api.github.com/repos/non/cats/contributors","subscribers_url":"https://api.github.com/repos/non/cats/subscribers","subscription_url":"https://api.github.com/repos/non/cats/subscription","commits_url":"https://api.github.com/repos/non/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/non/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/non/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/non/cats/issues/comments/{number}","contents_url":"https://api.github.com/repos/non/cats/contents/{+path}","compare_url":"https://api.github.com/repos/non/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/non/cats/merges","archive_url":"https://api.github.com/repos/non/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/non/cats/downloads","issues_url":"https://api.github.com/repos/non/cats/issues{/number}","pulls_url":"https://api.github.com/repos/non/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/non/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/non/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/non/cats/labels{/name}","releases_url":"https://api.github.com/repos/non/cats/releases{/id}","created_at":"2015-01-28T20:26:48Z","updated_at":"2015-02-09T05:05:26Z","pushed_at":"2015-02-09T05:06:04Z","git_url":"git://github.com/non/cats.git","ssh_url":"git@github.com:non/cats.git","clone_url":"https://github.com/non/cats.git","svn_url":"https://github.com/non/cats","homepage":null,"size":1452,"stargazers_count":226,"watchers_count":226,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"open_issues_count":53,"forks":36,"open_issues":53,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/non/cats/pulls/136"},"html":{"href":"https://github.com/non/cats/pull/136"},"issue":{"href":"https://api.github.com/repos/non/cats/issues/136"},"comments":{"href":"https://api.github.com/repos/non/cats/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/non/cats/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/non/cats/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/non/cats/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/non/cats/statuses/d926634deecf0c2697ebcf025dd88c0bae612fad"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stew","id":66772,"avatar_url":"https://avatars.githubusercontent.com/u/66772?v=3","gravatar_id":"","url":"https://api.github.com/users/stew","html_url":"https://github.com/stew","followers_url":"https://api.github.com/users/stew/followers","following_url":"https://api.github.com/users/stew/following{/other_user}","gists_url":"https://api.github.com/users/stew/gists{/gist_id}","starred_url":"https://api.github.com/users/stew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stew/subscriptions","organizations_url":"https://api.github.com/users/stew/orgs","repos_url":"https://api.github.com/users/stew/repos","events_url":"https://api.github.com/users/stew/events{/privacy}","received_events_url":"https://api.github.com/users/stew/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":312,"deletions":183,"changed_files":19}}