{"action":"created","comment":{"url":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/comments/48459062","id":48459062,"diff_hunk":"@@ -33,6 +33,9 @@ postinst ()\n     # Install the wheels/requirements\n     ${INSTALL_DIR}/env/bin/pip install --use-wheel --no-deps --no-index -U --force-reinstall -f ${INSTALL_DIR}/share/wheelhouse -r ${INSTALL_DIR}/share/wheelhouse/requirements.txt > /dev/null 2>&1\n \n+    # Install OctoPrint\n+    cd ${INSTALL_DIR}/share/${DNAME} && ${INSTALL_DIR}/env/bin/python setup.py install > /dev/null 2>&1","path":"spk/octoprint/src/installer.sh","position":5,"original_position":5,"commit_id":"c261576cffcfc9630115860bd375fc75fda11129","original_commit_id":"c261576cffcfc9630115860bd375fc75fda11129","user":{"login":"Diaoul","id":319220,"avatar_url":"https://avatars.githubusercontent.com/u/319220?v=3","gravatar_id":"","url":"https://api.github.com/users/Diaoul","html_url":"https://github.com/Diaoul","followers_url":"https://api.github.com/users/Diaoul/followers","following_url":"https://api.github.com/users/Diaoul/following{/other_user}","gists_url":"https://api.github.com/users/Diaoul/gists{/gist_id}","starred_url":"https://api.github.com/users/Diaoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diaoul/subscriptions","organizations_url":"https://api.github.com/users/Diaoul/orgs","repos_url":"https://api.github.com/users/Diaoul/repos","events_url":"https://api.github.com/users/Diaoul/events{/privacy}","received_events_url":"https://api.github.com/users/Diaoul/received_events","type":"User","site_admin":false},"body":"This assumes DNAME of the package is the same name as the git repo. I think I'd prefer hardcoded OctoPrint here instead. This is more readable that using a variable that's not meant for that use.\r\nDNAME refers to Display Name, it's the package name as displayed in the package center and for any GUI rendering.","created_at":"2015-12-27T22:54:38Z","updated_at":"2015-12-27T22:54:38Z","html_url":"https://github.com/SynoCommunity/spksrc/pull/2029#discussion_r48459062","pull_request_url":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/2029","_links":{"self":{"href":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/comments/48459062"},"html":{"href":"https://github.com/SynoCommunity/spksrc/pull/2029#discussion_r48459062"},"pull_request":{"href":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/2029"}}},"pull_request":{"url":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/2029","id":54623742,"html_url":"https://github.com/SynoCommunity/spksrc/pull/2029","diff_url":"https://github.com/SynoCommunity/spksrc/pull/2029.diff","patch_url":"https://github.com/SynoCommunity/spksrc/pull/2029.patch","issue_url":"https://api.github.com/repos/SynoCommunity/spksrc/issues/2029","number":2029,"state":"open","locked":false,"title":"Fix for OctoPrint plugin installation","user":{"login":"markbastiaans","id":7204312,"avatar_url":"https://avatars.githubusercontent.com/u/7204312?v=3","gravatar_id":"","url":"https://api.github.com/users/markbastiaans","html_url":"https://github.com/markbastiaans","followers_url":"https://api.github.com/users/markbastiaans/followers","following_url":"https://api.github.com/users/markbastiaans/following{/other_user}","gists_url":"https://api.github.com/users/markbastiaans/gists{/gist_id}","starred_url":"https://api.github.com/users/markbastiaans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markbastiaans/subscriptions","organizations_url":"https://api.github.com/users/markbastiaans/orgs","repos_url":"https://api.github.com/users/markbastiaans/repos","events_url":"https://api.github.com/users/markbastiaans/events{/privacy}","received_events_url":"https://api.github.com/users/markbastiaans/received_events","type":"User","site_admin":false},"body":"As mentioned in #2026, some OctoPrint plugins which depend on `octoprint-setuptools` are not installing. I've fixed this by doing the following:\r\n* **Added OctoPrint to cross.** It now downloads the latest release from the GitHub archives instead of doing a `git clone`.\r\n* **Patched the hardcoded requirements in the OctoPrint `setup.py`** to the most up-to-date versions of the `netifaces`, `psutil` and `pyyaml` wheels in the repository. The alternative was to add the versions OctoPrint needs to cross, but I ran into problems building `netifaces 0.10.0` (as per [this issue](https://bitbucket.org/al45tair/netifaces/issues/1/gcc-fails-while-installing-0100-0101)).\r\n* **Moved the `tornado` wheel to `tornado-4.0.1`** since this version is not the latest version of `tornado` (which seems to be 4.3).\r\n* **Fixed the OctoPrint requirements and installation** script to use the correct wheels and to run `setup.py`.\r\n\r\nI've tested this fix on `evansport` and the plugin issue seems to be fixed with these changes.\r\n\r\n@Dr-Bean, could you review this PR? I'm also interested in your preference in navigating dependency hell. My current approach should work until OctoPrint is updated, but it's not as future-proof as including every dependency in cross. Thanks in advance!","created_at":"2015-12-27T20:55:12Z","updated_at":"2015-12-27T22:54:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ab6f593519f18248ab8e88e7be7e2937ed60bfb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/2029/commits","review_comments_url":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/2029/comments","review_comment_url":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SynoCommunity/spksrc/issues/2029/comments","statuses_url":"https://api.github.com/repos/SynoCommunity/spksrc/statuses/c261576cffcfc9630115860bd375fc75fda11129","head":{"label":"markbastiaans:octoprint","ref":"octoprint","sha":"c261576cffcfc9630115860bd375fc75fda11129","user":{"login":"markbastiaans","id":7204312,"avatar_url":"https://avatars.githubusercontent.com/u/7204312?v=3","gravatar_id":"","url":"https://api.github.com/users/markbastiaans","html_url":"https://github.com/markbastiaans","followers_url":"https://api.github.com/users/markbastiaans/followers","following_url":"https://api.github.com/users/markbastiaans/following{/other_user}","gists_url":"https://api.github.com/users/markbastiaans/gists{/gist_id}","starred_url":"https://api.github.com/users/markbastiaans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markbastiaans/subscriptions","organizations_url":"https://api.github.com/users/markbastiaans/orgs","repos_url":"https://api.github.com/users/markbastiaans/repos","events_url":"https://api.github.com/users/markbastiaans/events{/privacy}","received_events_url":"https://api.github.com/users/markbastiaans/received_events","type":"User","site_admin":false},"repo":{"id":42125716,"name":"spksrc","full_name":"markbastiaans/spksrc","owner":{"login":"markbastiaans","id":7204312,"avatar_url":"https://avatars.githubusercontent.com/u/7204312?v=3","gravatar_id":"","url":"https://api.github.com/users/markbastiaans","html_url":"https://github.com/markbastiaans","followers_url":"https://api.github.com/users/markbastiaans/followers","following_url":"https://api.github.com/users/markbastiaans/following{/other_user}","gists_url":"https://api.github.com/users/markbastiaans/gists{/gist_id}","starred_url":"https://api.github.com/users/markbastiaans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markbastiaans/subscriptions","organizations_url":"https://api.github.com/users/markbastiaans/orgs","repos_url":"https://api.github.com/users/markbastiaans/repos","events_url":"https://api.github.com/users/markbastiaans/events{/privacy}","received_events_url":"https://api.github.com/users/markbastiaans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markbastiaans/spksrc","description":"Cross compilation framework to create native packages for the Synology's NAS","fork":true,"url":"https://api.github.com/repos/markbastiaans/spksrc","forks_url":"https://api.github.com/repos/markbastiaans/spksrc/forks","keys_url":"https://api.github.com/repos/markbastiaans/spksrc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markbastiaans/spksrc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markbastiaans/spksrc/teams","hooks_url":"https://api.github.com/repos/markbastiaans/spksrc/hooks","issue_events_url":"https://api.github.com/repos/markbastiaans/spksrc/issues/events{/number}","events_url":"https://api.github.com/repos/markbastiaans/spksrc/events","assignees_url":"https://api.github.com/repos/markbastiaans/spksrc/assignees{/user}","branches_url":"https://api.github.com/repos/markbastiaans/spksrc/branches{/branch}","tags_url":"https://api.github.com/repos/markbastiaans/spksrc/tags","blobs_url":"https://api.github.com/repos/markbastiaans/spksrc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markbastiaans/spksrc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markbastiaans/spksrc/git/refs{/sha}","trees_url":"https://api.github.com/repos/markbastiaans/spksrc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markbastiaans/spksrc/statuses/{sha}","languages_url":"https://api.github.com/repos/markbastiaans/spksrc/languages","stargazers_url":"https://api.github.com/repos/markbastiaans/spksrc/stargazers","contributors_url":"https://api.github.com/repos/markbastiaans/spksrc/contributors","subscribers_url":"https://api.github.com/repos/markbastiaans/spksrc/subscribers","subscription_url":"https://api.github.com/repos/markbastiaans/spksrc/subscription","commits_url":"https://api.github.com/repos/markbastiaans/spksrc/commits{/sha}","git_commits_url":"https://api.github.com/repos/markbastiaans/spksrc/git/commits{/sha}","comments_url":"https://api.github.com/repos/markbastiaans/spksrc/comments{/number}","issue_comment_url":"https://api.github.com/repos/markbastiaans/spksrc/issues/comments{/number}","contents_url":"https://api.github.com/repos/markbastiaans/spksrc/contents/{+path}","compare_url":"https://api.github.com/repos/markbastiaans/spksrc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markbastiaans/spksrc/merges","archive_url":"https://api.github.com/repos/markbastiaans/spksrc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markbastiaans/spksrc/downloads","issues_url":"https://api.github.com/repos/markbastiaans/spksrc/issues{/number}","pulls_url":"https://api.github.com/repos/markbastiaans/spksrc/pulls{/number}","milestones_url":"https://api.github.com/repos/markbastiaans/spksrc/milestones{/number}","notifications_url":"https://api.github.com/repos/markbastiaans/spksrc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markbastiaans/spksrc/labels{/name}","releases_url":"https://api.github.com/repos/markbastiaans/spksrc/releases{/id}","created_at":"2015-09-08T16:46:07Z","updated_at":"2015-09-08T16:46:09Z","pushed_at":"2015-12-27T20:39:21Z","git_url":"git://github.com/markbastiaans/spksrc.git","ssh_url":"git@github.com:markbastiaans/spksrc.git","clone_url":"https://github.com/markbastiaans/spksrc.git","svn_url":"https://github.com/markbastiaans/spksrc","homepage":"https://github.com/SynoCommunity/spksrc","size":9478,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SynoCommunity:master","ref":"master","sha":"e61bc041aad2a6dc5aedf7899732f939c3a2c924","user":{"login":"SynoCommunity","id":1123581,"avatar_url":"https://avatars.githubusercontent.com/u/1123581?v=3","gravatar_id":"","url":"https://api.github.com/users/SynoCommunity","html_url":"https://github.com/SynoCommunity","followers_url":"https://api.github.com/users/SynoCommunity/followers","following_url":"https://api.github.com/users/SynoCommunity/following{/other_user}","gists_url":"https://api.github.com/users/SynoCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/SynoCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SynoCommunity/subscriptions","organizations_url":"https://api.github.com/users/SynoCommunity/orgs","repos_url":"https://api.github.com/users/SynoCommunity/repos","events_url":"https://api.github.com/users/SynoCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/SynoCommunity/received_events","type":"Organization","site_admin":false},"repo":{"id":2565137,"name":"spksrc","full_name":"SynoCommunity/spksrc","owner":{"login":"SynoCommunity","id":1123581,"avatar_url":"https://avatars.githubusercontent.com/u/1123581?v=3","gravatar_id":"","url":"https://api.github.com/users/SynoCommunity","html_url":"https://github.com/SynoCommunity","followers_url":"https://api.github.com/users/SynoCommunity/followers","following_url":"https://api.github.com/users/SynoCommunity/following{/other_user}","gists_url":"https://api.github.com/users/SynoCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/SynoCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SynoCommunity/subscriptions","organizations_url":"https://api.github.com/users/SynoCommunity/orgs","repos_url":"https://api.github.com/users/SynoCommunity/repos","events_url":"https://api.github.com/users/SynoCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/SynoCommunity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SynoCommunity/spksrc","description":"Cross compilation framework to create native packages for the Synology's NAS","fork":false,"url":"https://api.github.com/repos/SynoCommunity/spksrc","forks_url":"https://api.github.com/repos/SynoCommunity/spksrc/forks","keys_url":"https://api.github.com/repos/SynoCommunity/spksrc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SynoCommunity/spksrc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SynoCommunity/spksrc/teams","hooks_url":"https://api.github.com/repos/SynoCommunity/spksrc/hooks","issue_events_url":"https://api.github.com/repos/SynoCommunity/spksrc/issues/events{/number}","events_url":"https://api.github.com/repos/SynoCommunity/spksrc/events","assignees_url":"https://api.github.com/repos/SynoCommunity/spksrc/assignees{/user}","branches_url":"https://api.github.com/repos/SynoCommunity/spksrc/branches{/branch}","tags_url":"https://api.github.com/repos/SynoCommunity/spksrc/tags","blobs_url":"https://api.github.com/repos/SynoCommunity/spksrc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SynoCommunity/spksrc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SynoCommunity/spksrc/git/refs{/sha}","trees_url":"https://api.github.com/repos/SynoCommunity/spksrc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SynoCommunity/spksrc/statuses/{sha}","languages_url":"https://api.github.com/repos/SynoCommunity/spksrc/languages","stargazers_url":"https://api.github.com/repos/SynoCommunity/spksrc/stargazers","contributors_url":"https://api.github.com/repos/SynoCommunity/spksrc/contributors","subscribers_url":"https://api.github.com/repos/SynoCommunity/spksrc/subscribers","subscription_url":"https://api.github.com/repos/SynoCommunity/spksrc/subscription","commits_url":"https://api.github.com/repos/SynoCommunity/spksrc/commits{/sha}","git_commits_url":"https://api.github.com/repos/SynoCommunity/spksrc/git/commits{/sha}","comments_url":"https://api.github.com/repos/SynoCommunity/spksrc/comments{/number}","issue_comment_url":"https://api.github.com/repos/SynoCommunity/spksrc/issues/comments{/number}","contents_url":"https://api.github.com/repos/SynoCommunity/spksrc/contents/{+path}","compare_url":"https://api.github.com/repos/SynoCommunity/spksrc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SynoCommunity/spksrc/merges","archive_url":"https://api.github.com/repos/SynoCommunity/spksrc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SynoCommunity/spksrc/downloads","issues_url":"https://api.github.com/repos/SynoCommunity/spksrc/issues{/number}","pulls_url":"https://api.github.com/repos/SynoCommunity/spksrc/pulls{/number}","milestones_url":"https://api.github.com/repos/SynoCommunity/spksrc/milestones{/number}","notifications_url":"https://api.github.com/repos/SynoCommunity/spksrc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SynoCommunity/spksrc/labels{/name}","releases_url":"https://api.github.com/repos/SynoCommunity/spksrc/releases{/id}","created_at":"2011-10-12T20:25:50Z","updated_at":"2015-12-26T18:02:30Z","pushed_at":"2015-12-27T20:55:12Z","git_url":"git://github.com/SynoCommunity/spksrc.git","ssh_url":"git@github.com:SynoCommunity/spksrc.git","clone_url":"https://github.com/SynoCommunity/spksrc.git","svn_url":"https://github.com/SynoCommunity/spksrc","homepage":"https://github.com/SynoCommunity/spksrc","size":39637,"stargazers_count":858,"watchers_count":858,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":388,"mirror_url":null,"open_issues_count":250,"forks":388,"open_issues":250,"watchers":858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/2029"},"html":{"href":"https://github.com/SynoCommunity/spksrc/pull/2029"},"issue":{"href":"https://api.github.com/repos/SynoCommunity/spksrc/issues/2029"},"comments":{"href":"https://api.github.com/repos/SynoCommunity/spksrc/issues/2029/comments"},"review_comments":{"href":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/2029/comments"},"review_comment":{"href":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SynoCommunity/spksrc/pulls/2029/commits"},"statuses":{"href":"https://api.github.com/repos/SynoCommunity/spksrc/statuses/c261576cffcfc9630115860bd375fc75fda11129"}}}}