{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/30102750","id":30102750,"diff_hunk":"@@ -152,31 +153,82 @@ test('should asynchronously fire error events during source selection', function\n   Lib.log.error.restore();\n });\n \n-test('should set the width and height of the player', function(){\n-  var player = TestHelpers.makePlayer({ width: 123, height: '100%' });\n+// test('should set the width and height of the player', function(){","path":"test/unit/player.js","position":14,"original_position":14,"commit_id":"5fb6aedcec81cf26e331a74161f7a965acd13f2a","original_commit_id":"5fb6aedcec81cf26e331a74161f7a965acd13f2a","user":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"body":"Remove or still needs fixing?","created_at":"2015-05-12T03:41:03Z","updated_at":"2015-05-12T03:41:03Z","html_url":"https://github.com/videojs/video.js/pull/1952#discussion_r30102750","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/1952","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/30102750"},"html":{"href":"https://github.com/videojs/video.js/pull/1952#discussion_r30102750"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/1952"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/1952","id":31298971,"html_url":"https://github.com/videojs/video.js/pull/1952","diff_url":"https://github.com/videojs/video.js/pull/1952.diff","patch_url":"https://github.com/videojs/video.js/pull/1952.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/1952","number":1952,"state":"open","locked":false,"title":"Fluid widths and aspect ratios with metadata defaults","user":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"body":"Building on #1440 from @baloneysandwiches. (Would appreciate your feedback Alex.) This isn't completely finished and needs tests but wanted to get it out for review.\r\n\r\nThe big diff here is that I'm creating a style element and using that to add widths (user-set, metadata-provided, and defaults) and aspect ratios for fluid layouts. The goal was to let the video.js user override player dimensions with CSS the same way they can with the video element. Previously we were using inline styles to add width and height, and we were doing that with the default values, which meant you couldn't easily use CSS to size the player. (I'm able to make this change now because we're in 5.0 development)\r\n\r\nI've included a screen shot of all the different user stories from #982 passing.\r\n\r\nOne question that's come out of this is whether or not we need the width/height functions on other components, since everything is getting sized in the main stylesheet. It would be nice to drop or at least simplify those. In this PR I'm overriding the player's width/height functions so now they work differently from other components.\r\n\r\nAmazingly this works in IE8 with Flash, including the metadata widths. I'm just having an issue getting the poster image centered again.\r\n\r\n![responsive-examples](https://cloud.githubusercontent.com/assets/166/6679437/da42ad4c-cc04-11e4-927c-5061598f0b0f.png)\r\n\r\nRelated Issues: #983, #1440, #982","created_at":"2015-03-17T00:54:30Z","updated_at":"2015-05-12T03:41:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7afb5db9718395278e8db7c1feaae99ff2fc8cf0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/1952/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/1952/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/1952/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/5fb6aedcec81cf26e331a74161f7a965acd13f2a","head":{"label":"heff:responsive","ref":"responsive","sha":"5fb6aedcec81cf26e331a74161f7a965acd13f2a","user":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"repo":{"id":5362506,"name":"video.js","full_name":"heff/video.js","owner":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heff/video.js","description":"Universal video embed.","fork":true,"url":"https://api.github.com/repos/heff/video.js","forks_url":"https://api.github.com/repos/heff/video.js/forks","keys_url":"https://api.github.com/repos/heff/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heff/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heff/video.js/teams","hooks_url":"https://api.github.com/repos/heff/video.js/hooks","issue_events_url":"https://api.github.com/repos/heff/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/heff/video.js/events","assignees_url":"https://api.github.com/repos/heff/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/heff/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/heff/video.js/tags","blobs_url":"https://api.github.com/repos/heff/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heff/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heff/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/heff/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heff/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/heff/video.js/languages","stargazers_url":"https://api.github.com/repos/heff/video.js/stargazers","contributors_url":"https://api.github.com/repos/heff/video.js/contributors","subscribers_url":"https://api.github.com/repos/heff/video.js/subscribers","subscription_url":"https://api.github.com/repos/heff/video.js/subscription","commits_url":"https://api.github.com/repos/heff/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/heff/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/heff/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/heff/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/heff/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/heff/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heff/video.js/merges","archive_url":"https://api.github.com/repos/heff/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heff/video.js/downloads","issues_url":"https://api.github.com/repos/heff/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/heff/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/heff/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/heff/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heff/video.js/labels{/name}","releases_url":"https://api.github.com/repos/heff/video.js/releases{/id}","created_at":"2012-08-09T23:12:27Z","updated_at":"2015-05-06T18:12:27Z","pushed_at":"2015-05-12T00:12:15Z","git_url":"git://github.com/heff/video.js.git","ssh_url":"git@github.com:heff/video.js.git","clone_url":"https://github.com/heff/video.js.git","svn_url":"https://github.com/heff/video.js","homepage":"videojs.com","size":15658,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"b65bad8f209d039d99f653a5c97485f652f07d02","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","created_at":"2010-05-14T18:45:10Z","updated_at":"2015-05-12T03:27:48Z","pushed_at":"2015-05-12T00:12:16Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":32732,"stargazers_count":8863,"watchers_count":8863,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2447,"mirror_url":null,"open_issues_count":187,"forks":2447,"open_issues":187,"watchers":8863,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/1952"},"html":{"href":"https://github.com/videojs/video.js/pull/1952"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/1952"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/1952/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/1952/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/1952/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/5fb6aedcec81cf26e331a74161f7a965acd13f2a"}}}}