{"action":"created","issue":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/1806","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/1806/labels{/name}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/1806/comments","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/1806/events","html_url":"https://github.com/wiredtiger/wiredtiger/pull/1806","id":63864463,"number":1806,"title":"Set checkpoint LSN to existing log record. #1700","user":{"login":"sueloverso","id":2945957,"avatar_url":"https://avatars.githubusercontent.com/u/2945957?v=3","gravatar_id":"","url":"https://api.github.com/users/sueloverso","html_url":"https://github.com/sueloverso","followers_url":"https://api.github.com/users/sueloverso/followers","following_url":"https://api.github.com/users/sueloverso/following{/other_user}","gists_url":"https://api.github.com/users/sueloverso/gists{/gist_id}","starred_url":"https://api.github.com/users/sueloverso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sueloverso/subscriptions","organizations_url":"https://api.github.com/users/sueloverso/orgs","repos_url":"https://api.github.com/users/sueloverso/repos","events_url":"https://api.github.com/users/sueloverso/events{/privacy}","received_events_url":"https://api.github.com/users/sueloverso/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-24T00:27:09Z","updated_at":"2015-04-02T06:05:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/1806","html_url":"https://github.com/wiredtiger/wiredtiger/pull/1806","diff_url":"https://github.com/wiredtiger/wiredtiger/pull/1806.diff","patch_url":"https://github.com/wiredtiger/wiredtiger/pull/1806.patch"},"body":"@michaelcahill Please review. Don't merge, but so we can talk. This changes the checkpoint LSN for #1700 from the next not-yet-allocated record, to the LSN of the last record.  I was mistaken - this change does not fix all the issues in #1183 where we cannot run recovery on an incremental backup and then continue.\r\n\r\nIn order to get that working we need to initialize the new `write_start_lsn` to the beginning of the last record in the log.  Currently we do not walk the last file looking for that although it would be more correct.  On initialization I set `write_start_lsn` to the same potential LSN when creating the new log file.  So there is a window where that LSN is pointing to the not-yet-written checkpoint record.\r\n\r\nWe could add code to do that walk, since it would only be done once at startup."},"comment":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments/88755019","html_url":"https://github.com/wiredtiger/wiredtiger/pull/1806#issuecomment-88755019","issue_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/1806","id":88755019,"user":{"login":"michaelcahill","id":1264383,"avatar_url":"https://avatars.githubusercontent.com/u/1264383?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelcahill","html_url":"https://github.com/michaelcahill","followers_url":"https://api.github.com/users/michaelcahill/followers","following_url":"https://api.github.com/users/michaelcahill/following{/other_user}","gists_url":"https://api.github.com/users/michaelcahill/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelcahill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelcahill/subscriptions","organizations_url":"https://api.github.com/users/michaelcahill/orgs","repos_url":"https://api.github.com/users/michaelcahill/repos","events_url":"https://api.github.com/users/michaelcahill/events{/privacy}","received_events_url":"https://api.github.com/users/michaelcahill/received_events","type":"User","site_admin":false},"created_at":"2015-04-02T06:05:25Z","updated_at":"2015-04-02T06:05:25Z","body":"Hi @sueloverso, I haven't merged this because you said not to, but it lgtm.\r\n\r\nI think we should solve #1700 now, and worry about incremental hot backups after that...\r\n\r\nFeel free to merge whenever you're ready."}}