{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/30632306","id":30632306,"diff_hunk":"@@ -1088,8 +1088,11 @@ impl FragmentDisplayListBuilding for Fragment {\n     fn create_stacking_context(&self,\n                                base_flow: &BaseFlow,\n                                display_list: Box<DisplayList>,\n-                               layer: Option<Arc<PaintLayer>>)\n+                               layout_context: &LayoutContext,\n+                               potential_layer_id: LayerId,\n+                               layer: Option<PaintLayer>)\n                                -> Arc<StackingContext> {\n+        debug!(\"create_stacking_context\");","path":"components/layout/display_list_builder.rs","position":104,"original_position":104,"commit_id":"c8b6e65a1c308e9ad63c0706cc580833fad2156c","original_commit_id":"c8b6e65a1c308e9ad63c0706cc580833fad2156c","user":{"login":"pcwalton","id":157897,"avatar_url":"https://avatars.githubusercontent.com/u/157897?v=3","gravatar_id":"","url":"https://api.github.com/users/pcwalton","html_url":"https://github.com/pcwalton","followers_url":"https://api.github.com/users/pcwalton/followers","following_url":"https://api.github.com/users/pcwalton/following{/other_user}","gists_url":"https://api.github.com/users/pcwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwalton/subscriptions","organizations_url":"https://api.github.com/users/pcwalton/orgs","repos_url":"https://api.github.com/users/pcwalton/repos","events_url":"https://api.github.com/users/pcwalton/events{/privacy}","received_events_url":"https://api.github.com/users/pcwalton/received_events","type":"User","site_admin":false},"body":"Seems like not a very useful debug message; could you remove this?","created_at":"2015-05-19T18:44:18Z","updated_at":"2015-05-19T18:44:18Z","html_url":"https://github.com/servo/servo/pull/6083#discussion_r30632306","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/6083","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/30632306"},"html":{"href":"https://github.com/servo/servo/pull/6083#discussion_r30632306"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/6083"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/6083","id":35564263,"html_url":"https://github.com/servo/servo/pull/6083","diff_url":"https://github.com/servo/servo/pull/6083.diff","patch_url":"https://github.com/servo/servo/pull/6083.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/6083","number":6083,"state":"open","locked":false,"title":"First steps to layerize canvas","user":{"login":"ecoal95","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/ecoal95","html_url":"https://github.com/ecoal95","followers_url":"https://api.github.com/users/ecoal95/followers","following_url":"https://api.github.com/users/ecoal95/following{/other_user}","gists_url":"https://api.github.com/users/ecoal95/gists{/gist_id}","starred_url":"https://api.github.com/users/ecoal95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecoal95/subscriptions","organizations_url":"https://api.github.com/users/ecoal95/orgs","repos_url":"https://api.github.com/users/ecoal95/repos","events_url":"https://api.github.com/users/ecoal95/events{/privacy}","received_events_url":"https://api.github.com/users/ecoal95/received_events","type":"User","site_admin":false},"body":"I've done a bit of job to get this done. Right now readback is still used, but we have a `LayerId` -> `CanvasRenderer` map on the paint task, that we can use to get rid of that.\r\n\r\nI'd want review, to see if this is a good approach (I know it's not the initial `CanvasId` -> renderer approach, but it's pretty similar, since a canvas involves a `PaintLayer`).\r\n\r\nI had to do a bit of refactoring to avoid cyclic dependencies between canvas and gfx. I'd want you to review them too.\r\n\r\nIt's mergeable and doesn't break any tests :P\r\n\r\nSome of my main concerns:\r\n* Does the canvas render really need to be behind an `Arc<Mutex<T>>`?\r\n* I can't clone a `NativeSurface` right now (that's why the `SendNativeSurface()` msg is unimplemented in the WebGL task). It should be easy to add that to rust-layers, supposing the caller is responsible to mark it as non-leaking, any reason to not do it?\r\n\r\ncc @jdm @pcwalton\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/6083)\r\n<!-- Reviewable:end -->\r\n","created_at":"2015-05-16T02:50:33Z","updated_at":"2015-05-19T18:44:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06c8fb23d65b1eec8950bb17ded9e3c726baa840","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/6083/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/6083/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/6083/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/c8b6e65a1c308e9ad63c0706cc580833fad2156c","head":{"label":"ecoal95:layerize-canvas","ref":"layerize-canvas","sha":"c8b6e65a1c308e9ad63c0706cc580833fad2156c","user":{"login":"ecoal95","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/ecoal95","html_url":"https://github.com/ecoal95","followers_url":"https://api.github.com/users/ecoal95/followers","following_url":"https://api.github.com/users/ecoal95/following{/other_user}","gists_url":"https://api.github.com/users/ecoal95/gists{/gist_id}","starred_url":"https://api.github.com/users/ecoal95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecoal95/subscriptions","organizations_url":"https://api.github.com/users/ecoal95/orgs","repos_url":"https://api.github.com/users/ecoal95/repos","events_url":"https://api.github.com/users/ecoal95/events{/privacy}","received_events_url":"https://api.github.com/users/ecoal95/received_events","type":"User","site_admin":false},"repo":{"id":34808649,"name":"servo","full_name":"ecoal95/servo","owner":{"login":"ecoal95","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/ecoal95","html_url":"https://github.com/ecoal95","followers_url":"https://api.github.com/users/ecoal95/followers","following_url":"https://api.github.com/users/ecoal95/following{/other_user}","gists_url":"https://api.github.com/users/ecoal95/gists{/gist_id}","starred_url":"https://api.github.com/users/ecoal95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecoal95/subscriptions","organizations_url":"https://api.github.com/users/ecoal95/orgs","repos_url":"https://api.github.com/users/ecoal95/repos","events_url":"https://api.github.com/users/ecoal95/events{/privacy}","received_events_url":"https://api.github.com/users/ecoal95/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ecoal95/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/ecoal95/servo","forks_url":"https://api.github.com/repos/ecoal95/servo/forks","keys_url":"https://api.github.com/repos/ecoal95/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ecoal95/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ecoal95/servo/teams","hooks_url":"https://api.github.com/repos/ecoal95/servo/hooks","issue_events_url":"https://api.github.com/repos/ecoal95/servo/issues/events{/number}","events_url":"https://api.github.com/repos/ecoal95/servo/events","assignees_url":"https://api.github.com/repos/ecoal95/servo/assignees{/user}","branches_url":"https://api.github.com/repos/ecoal95/servo/branches{/branch}","tags_url":"https://api.github.com/repos/ecoal95/servo/tags","blobs_url":"https://api.github.com/repos/ecoal95/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ecoal95/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ecoal95/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ecoal95/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ecoal95/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/ecoal95/servo/languages","stargazers_url":"https://api.github.com/repos/ecoal95/servo/stargazers","contributors_url":"https://api.github.com/repos/ecoal95/servo/contributors","subscribers_url":"https://api.github.com/repos/ecoal95/servo/subscribers","subscription_url":"https://api.github.com/repos/ecoal95/servo/subscription","commits_url":"https://api.github.com/repos/ecoal95/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ecoal95/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ecoal95/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ecoal95/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ecoal95/servo/contents/{+path}","compare_url":"https://api.github.com/repos/ecoal95/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ecoal95/servo/merges","archive_url":"https://api.github.com/repos/ecoal95/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ecoal95/servo/downloads","issues_url":"https://api.github.com/repos/ecoal95/servo/issues{/number}","pulls_url":"https://api.github.com/repos/ecoal95/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/ecoal95/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/ecoal95/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ecoal95/servo/labels{/name}","releases_url":"https://api.github.com/repos/ecoal95/servo/releases{/id}","created_at":"2015-04-29T17:44:08Z","updated_at":"2015-05-06T01:36:54Z","pushed_at":"2015-05-18T18:35:27Z","git_url":"git://github.com/ecoal95/servo.git","ssh_url":"git@github.com:ecoal95/servo.git","clone_url":"https://github.com/ecoal95/servo.git","svn_url":"https://github.com/ecoal95/servo","homepage":"","size":102806,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"089862090285b1126deaa2357505d2a027e56b2e","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2015-05-19T15:21:56Z","pushed_at":"2015-05-19T18:42:57Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"","size":1891504,"stargazers_count":4045,"watchers_count":4045,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":638,"mirror_url":null,"open_issues_count":905,"forks":638,"open_issues":905,"watchers":4045,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/6083"},"html":{"href":"https://github.com/servo/servo/pull/6083"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/6083"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/6083/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/6083/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/6083/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/c8b6e65a1c308e9ad63c0706cc580833fad2156c"}}}}