{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Logging/pulls/comments/36694230","id":36694230,"diff_hunk":"@@ -31,7 +31,14 @@ public void Log(LogLevel logLevel, int eventId, object state, Exception exceptio\n             {\n                 foreach (var logger in _loggers)\n                 {\n-                    logger.Log(logLevel, eventId, state, exception, formatter);\n+                    try\n+                    {\n+                        logger.Log(logLevel, eventId, state, exception, formatter);\n+                    }\n+                    catch\n+                    {\n+                        // ignore exceptions thrown by a logger and continue calling other loggers","path":"src/Microsoft.Framework.Logging/Logger.cs","position":null,"original_position":11,"commit_id":"a09f47d65bad3f3f8738ea72ac503e5e580e9b5d","original_commit_id":"0885147431d5be89e5ff3531d70214cae4014c06","user":{"login":"Eilon","id":202643,"avatar_url":"https://avatars.githubusercontent.com/u/202643?v=3","gravatar_id":"","url":"https://api.github.com/users/Eilon","html_url":"https://github.com/Eilon","followers_url":"https://api.github.com/users/Eilon/followers","following_url":"https://api.github.com/users/Eilon/following{/other_user}","gists_url":"https://api.github.com/users/Eilon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eilon/subscriptions","organizations_url":"https://api.github.com/users/Eilon/orgs","repos_url":"https://api.github.com/users/Eilon/repos","events_url":"https://api.github.com/users/Eilon/events{/privacy}","received_events_url":"https://api.github.com/users/Eilon/received_events","type":"User","site_admin":false},"body":"Thanks, that looks much nicer!","created_at":"2015-08-10T22:50:15Z","updated_at":"2015-08-10T22:50:15Z","html_url":"https://github.com/aspnet/Logging/pull/224#discussion_r36694230","pull_request_url":"https://api.github.com/repos/aspnet/Logging/pulls/224","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/comments/36694230"},"html":{"href":"https://github.com/aspnet/Logging/pull/224#discussion_r36694230"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/224"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Logging/pulls/224","id":41255372,"html_url":"https://github.com/aspnet/Logging/pull/224","diff_url":"https://github.com/aspnet/Logging/pull/224.diff","patch_url":"https://github.com/aspnet/Logging/pull/224.patch","issue_url":"https://api.github.com/repos/aspnet/Logging/issues/224","number":224,"state":"open","locked":false,"title":"[Fixes #208] Exception in a logger stops execution of other registere…","user":{"login":"kichalla","id":6559784,"avatar_url":"https://avatars.githubusercontent.com/u/6559784?v=3","gravatar_id":"","url":"https://api.github.com/users/kichalla","html_url":"https://github.com/kichalla","followers_url":"https://api.github.com/users/kichalla/followers","following_url":"https://api.github.com/users/kichalla/following{/other_user}","gists_url":"https://api.github.com/users/kichalla/gists{/gist_id}","starred_url":"https://api.github.com/users/kichalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kichalla/subscriptions","organizations_url":"https://api.github.com/users/kichalla/orgs","repos_url":"https://api.github.com/users/kichalla/repos","events_url":"https://api.github.com/users/kichalla/events{/privacy}","received_events_url":"https://api.github.com/users/kichalla/received_events","type":"User","site_admin":false},"body":"…d loggers\r\n\r\n@muratg ","created_at":"2015-07-30T16:41:24Z","updated_at":"2015-08-10T22:50:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bb6ad0d103226465ec0f87660c905928f448052","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Logging/pulls/224/commits","review_comments_url":"https://api.github.com/repos/aspnet/Logging/pulls/224/comments","review_comment_url":"https://api.github.com/repos/aspnet/Logging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Logging/issues/224/comments","statuses_url":"https://api.github.com/repos/aspnet/Logging/statuses/a09f47d65bad3f3f8738ea72ac503e5e580e9b5d","head":{"label":"aspnet:kiran/logger-exceptions","ref":"kiran/logger-exceptions","sha":"a09f47d65bad3f3f8738ea72ac503e5e580e9b5d","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15836601,"name":"Logging","full_name":"aspnet/Logging","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Logging","description":"Common logging abstractions for DNX and ASP.NET 5.","fork":false,"url":"https://api.github.com/repos/aspnet/Logging","forks_url":"https://api.github.com/repos/aspnet/Logging/forks","keys_url":"https://api.github.com/repos/aspnet/Logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Logging/teams","hooks_url":"https://api.github.com/repos/aspnet/Logging/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Logging/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Logging/events","assignees_url":"https://api.github.com/repos/aspnet/Logging/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Logging/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Logging/tags","blobs_url":"https://api.github.com/repos/aspnet/Logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Logging/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Logging/languages","stargazers_url":"https://api.github.com/repos/aspnet/Logging/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Logging/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Logging/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Logging/subscription","commits_url":"https://api.github.com/repos/aspnet/Logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Logging/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Logging/merges","archive_url":"https://api.github.com/repos/aspnet/Logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Logging/downloads","issues_url":"https://api.github.com/repos/aspnet/Logging/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Logging/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Logging/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Logging/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Logging/releases{/id}","created_at":"2014-01-12T04:46:28Z","updated_at":"2015-08-06T20:45:26Z","pushed_at":"2015-08-10T22:43:23Z","git_url":"git://github.com/aspnet/Logging.git","ssh_url":"git@github.com:aspnet/Logging.git","clone_url":"https://github.com/aspnet/Logging.git","svn_url":"https://github.com/aspnet/Logging","homepage":"","size":2739,"stargazers_count":135,"watchers_count":135,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":30,"forks":61,"open_issues":30,"watchers":135,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"dd11ab2ce65a9a474177ba6668b5b55e904eeefd","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15836601,"name":"Logging","full_name":"aspnet/Logging","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Logging","description":"Common logging abstractions for DNX and ASP.NET 5.","fork":false,"url":"https://api.github.com/repos/aspnet/Logging","forks_url":"https://api.github.com/repos/aspnet/Logging/forks","keys_url":"https://api.github.com/repos/aspnet/Logging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Logging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Logging/teams","hooks_url":"https://api.github.com/repos/aspnet/Logging/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Logging/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Logging/events","assignees_url":"https://api.github.com/repos/aspnet/Logging/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Logging/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Logging/tags","blobs_url":"https://api.github.com/repos/aspnet/Logging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Logging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Logging/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Logging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Logging/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Logging/languages","stargazers_url":"https://api.github.com/repos/aspnet/Logging/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Logging/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Logging/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Logging/subscription","commits_url":"https://api.github.com/repos/aspnet/Logging/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Logging/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Logging/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Logging/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Logging/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Logging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Logging/merges","archive_url":"https://api.github.com/repos/aspnet/Logging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Logging/downloads","issues_url":"https://api.github.com/repos/aspnet/Logging/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Logging/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Logging/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Logging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Logging/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Logging/releases{/id}","created_at":"2014-01-12T04:46:28Z","updated_at":"2015-08-06T20:45:26Z","pushed_at":"2015-08-10T22:43:23Z","git_url":"git://github.com/aspnet/Logging.git","ssh_url":"git@github.com:aspnet/Logging.git","clone_url":"https://github.com/aspnet/Logging.git","svn_url":"https://github.com/aspnet/Logging","homepage":"","size":2739,"stargazers_count":135,"watchers_count":135,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":30,"forks":61,"open_issues":30,"watchers":135,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/224"},"html":{"href":"https://github.com/aspnet/Logging/pull/224"},"issue":{"href":"https://api.github.com/repos/aspnet/Logging/issues/224"},"comments":{"href":"https://api.github.com/repos/aspnet/Logging/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Logging/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Logging/statuses/a09f47d65bad3f3f8738ea72ac503e5e580e9b5d"}}}}