{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/26448137","id":26448137,"diff_hunk":"@@ -302,6 +302,11 @@ func setupIPTables(addr net.Addr, icc, ipmasq bool) error {\n \t)\n \n \tif !icc {\n+\t\toutput, err := ioutil.ReadFile(\"/proc/sys/net/bridge/bridge-nf-call-iptables\")\n+\t\tif err != nil || string(output[:1]) == \"0\" {\n+\t\t\tlog.Warnf(\"net.bridge.bridge-nf-call-iptables is not enabled. So --icc=false does not work.\")","path":"daemon/networkdriver/bridge/driver.go","position":6,"original_position":6,"commit_id":"1e1133090a33ebb6121a1ac151682d96ac2526cb","original_commit_id":"1e1133090a33ebb6121a1ac151682d96ac2526cb","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"Perhaps the warning should include the term \"intercontainer communication\" (as is used below).\r\n\r\n(thinking out loud here); \"WARNING: disabling intercontainer communication is not supported: net.bridge.bridge-nf-call-iptables is not enabled.\"","created_at":"2015-03-15T14:17:21Z","updated_at":"2015-03-15T14:17:21Z","html_url":"https://github.com/docker/docker/pull/11391#discussion_r26448137","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/11391","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/26448137"},"html":{"href":"https://github.com/docker/docker/pull/11391#discussion_r26448137"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/11391"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/11391","id":31195049,"html_url":"https://github.com/docker/docker/pull/11391","diff_url":"https://github.com/docker/docker/pull/11391.diff","patch_url":"https://github.com/docker/docker/pull/11391.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/11391","number":11391,"state":"open","locked":false,"title":"Show warning message when icc is false and bridge-nf-call-iptables is disabled","user":{"login":"mizzy","id":3620,"avatar_url":"https://avatars.githubusercontent.com/u/3620?v=3","gravatar_id":"","url":"https://api.github.com/users/mizzy","html_url":"https://github.com/mizzy","followers_url":"https://api.github.com/users/mizzy/followers","following_url":"https://api.github.com/users/mizzy/following{/other_user}","gists_url":"https://api.github.com/users/mizzy/gists{/gist_id}","starred_url":"https://api.github.com/users/mizzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mizzy/subscriptions","organizations_url":"https://api.github.com/users/mizzy/orgs","repos_url":"https://api.github.com/users/mizzy/repos","events_url":"https://api.github.com/users/mizzy/events{/privacy}","received_events_url":"https://api.github.com/users/mizzy/received_events","type":"User","site_admin":false},"body":"This pull request is for showing a warning message when --icc=false and net.bridge.bridge-nf-call-iptables is disabled.\r\n\r\nIf net.bridge.bridge-nf-call-iptables is disabled, iptables does not see bridge traffic. So contaniers can communicate with each other even though icc option is false.\r\n\r\nI found this problem when I tested Docker on CoreOS. Since Linux kernel 3.18 rc-1, you have to modprobe br_netfilter explicitly to enable net.bridge.bridge-nf-call-iptables.\r\n\r\nIt took very long time to investigate this problem because there were no messages and Docker worked correctly other than --icc=false did not work.\r\n\r\nSo it is kind to show this warning message to find the problem easily.\r\n\r\nPlease check it.\r\n","created_at":"2015-03-15T04:11:57Z","updated_at":"2015-03-15T14:17:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d807b02e1abd7765d534f5a24b2c6e6f56db4ffe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/11391/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/11391/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/11391/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/1e1133090a33ebb6121a1ac151682d96ac2526cb","head":{"label":"mizzy:show-warning-message-when-bridge-nf-call-iptables-is-disabled","ref":"show-warning-message-when-bridge-nf-call-iptables-is-disabled","sha":"1e1133090a33ebb6121a1ac151682d96ac2526cb","user":{"login":"mizzy","id":3620,"avatar_url":"https://avatars.githubusercontent.com/u/3620?v=3","gravatar_id":"","url":"https://api.github.com/users/mizzy","html_url":"https://github.com/mizzy","followers_url":"https://api.github.com/users/mizzy/followers","following_url":"https://api.github.com/users/mizzy/following{/other_user}","gists_url":"https://api.github.com/users/mizzy/gists{/gist_id}","starred_url":"https://api.github.com/users/mizzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mizzy/subscriptions","organizations_url":"https://api.github.com/users/mizzy/orgs","repos_url":"https://api.github.com/users/mizzy/repos","events_url":"https://api.github.com/users/mizzy/events{/privacy}","received_events_url":"https://api.github.com/users/mizzy/received_events","type":"User","site_admin":false},"repo":{"id":32147698,"name":"docker","full_name":"mizzy/docker","owner":{"login":"mizzy","id":3620,"avatar_url":"https://avatars.githubusercontent.com/u/3620?v=3","gravatar_id":"","url":"https://api.github.com/users/mizzy","html_url":"https://github.com/mizzy","followers_url":"https://api.github.com/users/mizzy/followers","following_url":"https://api.github.com/users/mizzy/following{/other_user}","gists_url":"https://api.github.com/users/mizzy/gists{/gist_id}","starred_url":"https://api.github.com/users/mizzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mizzy/subscriptions","organizations_url":"https://api.github.com/users/mizzy/orgs","repos_url":"https://api.github.com/users/mizzy/repos","events_url":"https://api.github.com/users/mizzy/events{/privacy}","received_events_url":"https://api.github.com/users/mizzy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mizzy/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/mizzy/docker","forks_url":"https://api.github.com/repos/mizzy/docker/forks","keys_url":"https://api.github.com/repos/mizzy/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mizzy/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mizzy/docker/teams","hooks_url":"https://api.github.com/repos/mizzy/docker/hooks","issue_events_url":"https://api.github.com/repos/mizzy/docker/issues/events{/number}","events_url":"https://api.github.com/repos/mizzy/docker/events","assignees_url":"https://api.github.com/repos/mizzy/docker/assignees{/user}","branches_url":"https://api.github.com/repos/mizzy/docker/branches{/branch}","tags_url":"https://api.github.com/repos/mizzy/docker/tags","blobs_url":"https://api.github.com/repos/mizzy/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mizzy/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mizzy/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mizzy/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mizzy/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/mizzy/docker/languages","stargazers_url":"https://api.github.com/repos/mizzy/docker/stargazers","contributors_url":"https://api.github.com/repos/mizzy/docker/contributors","subscribers_url":"https://api.github.com/repos/mizzy/docker/subscribers","subscription_url":"https://api.github.com/repos/mizzy/docker/subscription","commits_url":"https://api.github.com/repos/mizzy/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mizzy/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mizzy/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mizzy/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mizzy/docker/contents/{+path}","compare_url":"https://api.github.com/repos/mizzy/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mizzy/docker/merges","archive_url":"https://api.github.com/repos/mizzy/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mizzy/docker/downloads","issues_url":"https://api.github.com/repos/mizzy/docker/issues{/number}","pulls_url":"https://api.github.com/repos/mizzy/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/mizzy/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/mizzy/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mizzy/docker/labels{/name}","releases_url":"https://api.github.com/repos/mizzy/docker/releases{/id}","created_at":"2015-03-13T09:38:58Z","updated_at":"2015-03-13T09:39:06Z","pushed_at":"2015-03-15T04:10:21Z","git_url":"git://github.com/mizzy/docker.git","ssh_url":"git@github.com:mizzy/docker.git","clone_url":"https://github.com/mizzy/docker.git","svn_url":"https://github.com/mizzy/docker","homepage":"http://www.docker.com","size":44702,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"495f5e4998d5d6d4eb2115a196cb33ae7716ab9b","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-03-15T13:47:17Z","pushed_at":"2015-03-15T03:04:26Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":151023,"stargazers_count":19838,"watchers_count":19838,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4145,"mirror_url":null,"open_issues_count":828,"forks":4145,"open_issues":828,"watchers":19838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/11391"},"html":{"href":"https://github.com/docker/docker/pull/11391"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/11391"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/11391/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/11391/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/11391/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/1e1133090a33ebb6121a1ac151682d96ac2526cb"}}}}