{"action":"created","issue":{"url":"https://api.github.com/repos/plone/plone.jenkins_node/issues/3","labels_url":"https://api.github.com/repos/plone/plone.jenkins_node/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/plone/plone.jenkins_node/issues/3/comments","events_url":"https://api.github.com/repos/plone/plone.jenkins_node/issues/3/events","html_url":"https://github.com/plone/plone.jenkins_node/pull/3","id":60429594,"number":3,"title":"Fix and split tasks","user":{"login":"gforcada","id":1155680,"avatar_url":"https://avatars.githubusercontent.com/u/1155680?v=3","gravatar_id":"","url":"https://api.github.com/users/gforcada","html_url":"https://github.com/gforcada","followers_url":"https://api.github.com/users/gforcada/followers","following_url":"https://api.github.com/users/gforcada/following{/other_user}","gists_url":"https://api.github.com/users/gforcada/gists{/gist_id}","starred_url":"https://api.github.com/users/gforcada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gforcada/subscriptions","organizations_url":"https://api.github.com/users/gforcada/orgs","repos_url":"https://api.github.com/users/gforcada/repos","events_url":"https://api.github.com/users/gforcada/events{/privacy}","received_events_url":"https://api.github.com/users/gforcada/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-09T23:51:29Z","updated_at":"2015-03-15T17:04:47Z","closed_at":"2015-03-15T11:10:52Z","pull_request":{"url":"https://api.github.com/repos/plone/plone.jenkins_node/pulls/3","html_url":"https://github.com/plone/plone.jenkins_node/pull/3","diff_url":"https://github.com/plone/plone.jenkins_node/pull/3.diff","patch_url":"https://github.com/plone/plone.jenkins_node/pull/3.patch"},"body":"Split tasks into different yml files to ease the review and further\r\nenhancement.\r\n\r\nOn the way of doing it ensure that tasks are actually working.\r\n\r\nRemoved some redundant steps (some libraries were installed twice)."},"comment":{"url":"https://api.github.com/repos/plone/plone.jenkins_node/issues/comments/81159599","html_url":"https://github.com/plone/plone.jenkins_node/pull/3#issuecomment-81159599","issue_url":"https://api.github.com/repos/plone/plone.jenkins_node/issues/3","id":81159599,"user":{"login":"tisto","id":632105,"avatar_url":"https://avatars.githubusercontent.com/u/632105?v=3","gravatar_id":"","url":"https://api.github.com/users/tisto","html_url":"https://github.com/tisto","followers_url":"https://api.github.com/users/tisto/followers","following_url":"https://api.github.com/users/tisto/following{/other_user}","gists_url":"https://api.github.com/users/tisto/gists{/gist_id}","starred_url":"https://api.github.com/users/tisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tisto/subscriptions","organizations_url":"https://api.github.com/users/tisto/orgs","repos_url":"https://api.github.com/users/tisto/repos","events_url":"https://api.github.com/users/tisto/events{/privacy}","received_events_url":"https://api.github.com/users/tisto/received_events","type":"User","site_admin":false},"created_at":"2015-03-15T17:04:47Z","updated_at":"2015-03-15T17:04:47Z","body":"@gforcada I somehow put everything in one file intentionaly. The reason why I usually don't like to reuse ansible playbooks is because they tend to spread configuration across so many files that it is impossible to understand what they do (something that we love to do in the Plone community with buildout files). \r\n\r\nI would rather just factor out the parts that are really optional and that can not be overridden otherwise (munin, mr.roboto, maybe nginx). Our configuration is not so long, that it does not fit into one file. Readability and simplicity are more important than (possible) re-usability in my opinion (python zen: flat is better than nested).\r\n\r\nI'd say we should discuss which parts we want to be optional first and then think about ways how to accomplish that. Could be a good sprint task. :)"}}