{"action":"created","issue":{"url":"https://api.github.com/repos/thomseddon/node-oauth2-server/issues/37","labels_url":"https://api.github.com/repos/thomseddon/node-oauth2-server/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/thomseddon/node-oauth2-server/issues/37/comments","events_url":"https://api.github.com/repos/thomseddon/node-oauth2-server/issues/37/events","html_url":"https://github.com/thomseddon/node-oauth2-server/pull/37","id":27825287,"number":37,"title":"Fix ALL error codes and names","user":{"login":"thomseddon","id":747138,"avatar_url":"https://avatars.githubusercontent.com/u/747138?v=3","gravatar_id":"","url":"https://api.github.com/users/thomseddon","html_url":"https://github.com/thomseddon","followers_url":"https://api.github.com/users/thomseddon/followers","following_url":"https://api.github.com/users/thomseddon/following{/other_user}","gists_url":"https://api.github.com/users/thomseddon/gists{/gist_id}","starred_url":"https://api.github.com/users/thomseddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomseddon/subscriptions","organizations_url":"https://api.github.com/users/thomseddon/orgs","repos_url":"https://api.github.com/users/thomseddon/repos","events_url":"https://api.github.com/users/thomseddon/events{/privacy}","received_events_url":"https://api.github.com/users/thomseddon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/thomseddon/node-oauth2-server/labels/2.x","name":"2.x","color":"d4c5f9"},{"url":"https://api.github.com/repos/thomseddon/node-oauth2-server/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/thomseddon/node-oauth2-server/labels/proposal","name":"proposal","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/thomseddon/node-oauth2-server/milestones/2","labels_url":"https://api.github.com/repos/thomseddon/node-oauth2-server/milestones/2/labels","id":469960,"number":2,"title":"2.1","description":null,"creator":{"login":"thomseddon","id":747138,"avatar_url":"https://avatars.githubusercontent.com/u/747138?v=3","gravatar_id":"","url":"https://api.github.com/users/thomseddon","html_url":"https://github.com/thomseddon","followers_url":"https://api.github.com/users/thomseddon/followers","following_url":"https://api.github.com/users/thomseddon/following{/other_user}","gists_url":"https://api.github.com/users/thomseddon/gists{/gist_id}","starred_url":"https://api.github.com/users/thomseddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomseddon/subscriptions","organizations_url":"https://api.github.com/users/thomseddon/orgs","repos_url":"https://api.github.com/users/thomseddon/repos","events_url":"https://api.github.com/users/thomseddon/events{/privacy}","received_events_url":"https://api.github.com/users/thomseddon/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2013-10-31T08:45:42Z","updated_at":"2014-02-18T20:33:17Z","due_on":null,"closed_at":null},"comments":19,"created_at":"2014-02-18T20:33:07Z","updated_at":"2015-01-02T11:04:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thomseddon/node-oauth2-server/pulls/37","html_url":"https://github.com/thomseddon/node-oauth2-server/pull/37","diff_url":"https://github.com/thomseddon/node-oauth2-server/pull/37.diff","patch_url":"https://github.com/thomseddon/node-oauth2-server/pull/37.patch"},"body":"I've started to notice a few possible errors with regards to errors:\r\n\r\n 1. `invalid_client` should return a 401\r\n 2. Missing username/password with password grant should be an `invalid_request` not an `invalid_client`\r\n 3. Missing client_id when using auth_code grant should be an `invalid_client` not an `invalid_request`\r\n\r\nThis would be a breaking change so would go into 2.1 + may be others so wanted to discuss first.\r\n\r\nRelevant section of spec: http://tools.ietf.org/html/rfc6749#section-5.2\r\n\r\nWill also have a look at how other implementations handle these cases"},"comment":{"url":"https://api.github.com/repos/thomseddon/node-oauth2-server/issues/comments/68519773","html_url":"https://github.com/thomseddon/node-oauth2-server/pull/37#issuecomment-68519773","issue_url":"https://api.github.com/repos/thomseddon/node-oauth2-server/issues/37","id":68519773,"user":{"login":"thomseddon","id":747138,"avatar_url":"https://avatars.githubusercontent.com/u/747138?v=3","gravatar_id":"","url":"https://api.github.com/users/thomseddon","html_url":"https://github.com/thomseddon","followers_url":"https://api.github.com/users/thomseddon/followers","following_url":"https://api.github.com/users/thomseddon/following{/other_user}","gists_url":"https://api.github.com/users/thomseddon/gists{/gist_id}","starred_url":"https://api.github.com/users/thomseddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomseddon/subscriptions","organizations_url":"https://api.github.com/users/thomseddon/orgs","repos_url":"https://api.github.com/users/thomseddon/repos","events_url":"https://api.github.com/users/thomseddon/events{/privacy}","received_events_url":"https://api.github.com/users/thomseddon/received_events","type":"User","site_admin":false},"created_at":"2015-01-02T11:04:47Z","updated_at":"2015-01-02T11:04:47Z","body":"We have one more fix to go in before this can be merged, working on it for upcoming release"}}