{"action":"created","comment":{"url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments/46739792","id":46739792,"diff_hunk":"@@ -231,7 +240,7 @@ bool MediaDependentWirelessPort::processSync(uint16_t seq, bool grandmaster, lon\n \t\t\t\tunsigned residence_time;\n \t\t\t\tfollow_up->setPreciseOriginTimestamp\n \t\t\t\t\t(getClock()->getLastSyncOriginTime());\n-\t\t\t\t// Calculate residence time\n+\t\t\t\t// Calculate residence time  XXX : This looks suspicious as if residence time could be negative","path":"daemons/gptp/common/md_wireless.cpp","position":64,"original_position":64,"commit_id":"26ecc049502ff2aadba4c055f47be95748c296ad","original_commit_id":"26ecc049502ff2aadba4c055f47be95748c296ad","user":{"login":"pinealservo","id":1038011,"avatar_url":"https://avatars.githubusercontent.com/u/1038011?v=3","gravatar_id":"","url":"https://api.github.com/users/pinealservo","html_url":"https://github.com/pinealservo","followers_url":"https://api.github.com/users/pinealservo/followers","following_url":"https://api.github.com/users/pinealservo/following{/other_user}","gists_url":"https://api.github.com/users/pinealservo/gists{/gist_id}","starred_url":"https://api.github.com/users/pinealservo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinealservo/subscriptions","organizations_url":"https://api.github.com/users/pinealservo/orgs","repos_url":"https://api.github.com/users/pinealservo/repos","events_url":"https://api.github.com/users/pinealservo/events{/privacy}","received_events_url":"https://api.github.com/users/pinealservo/received_events","type":"User","site_admin":false},"body":"Could you elaborate on your concern in this comment?","created_at":"2015-12-04T22:23:24Z","updated_at":"2015-12-04T22:23:24Z","html_url":"https://github.com/AVnu/Open-AVB/pull/324#discussion_r46739792","pull_request_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/324","_links":{"self":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments/46739792"},"html":{"href":"https://github.com/AVnu/Open-AVB/pull/324#discussion_r46739792"},"pull_request":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/324"}}},"pull_request":{"url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/324","id":51385052,"html_url":"https://github.com/AVnu/Open-AVB/pull/324","diff_url":"https://github.com/AVnu/Open-AVB/pull/324.diff","patch_url":"https://github.com/AVnu/Open-AVB/pull/324.patch","issue_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/324","number":324,"state":"open","locked":false,"title":"Added support for Intel wireless adapters on Windows","user":{"login":"christopher-s-hall","id":4007366,"avatar_url":"https://avatars.githubusercontent.com/u/4007366?v=3","gravatar_id":"","url":"https://api.github.com/users/christopher-s-hall","html_url":"https://github.com/christopher-s-hall","followers_url":"https://api.github.com/users/christopher-s-hall/followers","following_url":"https://api.github.com/users/christopher-s-hall/following{/other_user}","gists_url":"https://api.github.com/users/christopher-s-hall/gists{/gist_id}","starred_url":"https://api.github.com/users/christopher-s-hall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopher-s-hall/subscriptions","organizations_url":"https://api.github.com/users/christopher-s-hall/orgs","repos_url":"https://api.github.com/users/christopher-s-hall/repos","events_url":"https://api.github.com/users/christopher-s-hall/events{/privacy}","received_events_url":"https://api.github.com/users/christopher-s-hall/received_events","type":"User","site_admin":false},"body":"Moved port states to ipcdef\r\nAdded additional simpler debug output that always prints used for compile\r\n\ttime #ifdef wrapping\r\nAt startup when in slave only or \"cached slave\" mode set restart\r\n\tsyntonization flag\r\nAdded wireless sync specific code for non-GM multiport operation\r\nDelete pdelay timeout in the default handler preventing asCapable from\r\n\tbecoming false on links that don't use pdelay\r\nRemove rollover handling from common wireless timestamper code\r\n\r\nRemoved broken functions/macros for timestamp arithmetic replacing them with\r\n\t\"C++ style\" operator overloading\r\nUse two wireless interface addresses, one for media independent functions\r\n\tthe other for media dependent functions\r\n\tNo longer necessary to \"hard-code\" transform from wireless hardware\r\n\t\taddress to ethernet wireless address (may be different for\r\n\t\tWiFi Direct)\r\nRemoved unnecessary TSC complication, instead use\r\n\tQPC frequency << 10 <=> TSC frequency\r\nAdded work queue for \"true\" asynchronous behavior\r\nSplit wired and wireless windows code\r\nInclude updated solution/project files\r\nPulled Linux code from the main branch enabling use of PTP driver\r\n\tcross-timestamp","created_at":"2015-11-20T17:34:55Z","updated_at":"2015-12-04T22:23:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3e416859a7cd0168e7fe88d628e9b54e7c1ef83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/324/commits","review_comments_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/324/comments","review_comment_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/324/comments","statuses_url":"https://api.github.com/repos/AVnu/Open-AVB/statuses/26ecc049502ff2aadba4c055f47be95748c296ad","head":{"label":"christopher-s-hall:wireless","ref":"wireless","sha":"26ecc049502ff2aadba4c055f47be95748c296ad","user":{"login":"christopher-s-hall","id":4007366,"avatar_url":"https://avatars.githubusercontent.com/u/4007366?v=3","gravatar_id":"","url":"https://api.github.com/users/christopher-s-hall","html_url":"https://github.com/christopher-s-hall","followers_url":"https://api.github.com/users/christopher-s-hall/followers","following_url":"https://api.github.com/users/christopher-s-hall/following{/other_user}","gists_url":"https://api.github.com/users/christopher-s-hall/gists{/gist_id}","starred_url":"https://api.github.com/users/christopher-s-hall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopher-s-hall/subscriptions","organizations_url":"https://api.github.com/users/christopher-s-hall/orgs","repos_url":"https://api.github.com/users/christopher-s-hall/repos","events_url":"https://api.github.com/users/christopher-s-hall/events{/privacy}","received_events_url":"https://api.github.com/users/christopher-s-hall/received_events","type":"User","site_admin":false},"repo":{"id":11827693,"name":"Open-AVB","full_name":"christopher-s-hall/Open-AVB","owner":{"login":"christopher-s-hall","id":4007366,"avatar_url":"https://avatars.githubusercontent.com/u/4007366?v=3","gravatar_id":"","url":"https://api.github.com/users/christopher-s-hall","html_url":"https://github.com/christopher-s-hall","followers_url":"https://api.github.com/users/christopher-s-hall/followers","following_url":"https://api.github.com/users/christopher-s-hall/following{/other_user}","gists_url":"https://api.github.com/users/christopher-s-hall/gists{/gist_id}","starred_url":"https://api.github.com/users/christopher-s-hall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopher-s-hall/subscriptions","organizations_url":"https://api.github.com/users/christopher-s-hall/orgs","repos_url":"https://api.github.com/users/christopher-s-hall/repos","events_url":"https://api.github.com/users/christopher-s-hall/events{/privacy}","received_events_url":"https://api.github.com/users/christopher-s-hall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christopher-s-hall/Open-AVB","description":"Open AVB - a repository for Audio/Video Bridging technology","fork":true,"url":"https://api.github.com/repos/christopher-s-hall/Open-AVB","forks_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/forks","keys_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/teams","hooks_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/hooks","issue_events_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/issues/events{/number}","events_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/events","assignees_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/assignees{/user}","branches_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/branches{/branch}","tags_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/tags","blobs_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/git/refs{/sha}","trees_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/statuses/{sha}","languages_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/languages","stargazers_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/stargazers","contributors_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/contributors","subscribers_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/subscribers","subscription_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/subscription","commits_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/commits{/sha}","git_commits_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/git/commits{/sha}","comments_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/comments{/number}","issue_comment_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/issues/comments{/number}","contents_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/contents/{+path}","compare_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/merges","archive_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/downloads","issues_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/issues{/number}","pulls_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/pulls{/number}","milestones_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/milestones{/number}","notifications_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/labels{/name}","releases_url":"https://api.github.com/repos/christopher-s-hall/Open-AVB/releases{/id}","created_at":"2013-08-01T21:07:05Z","updated_at":"2015-01-22T20:36:30Z","pushed_at":"2015-12-04T21:12:35Z","git_url":"git://github.com/christopher-s-hall/Open-AVB.git","ssh_url":"git@github.com:christopher-s-hall/Open-AVB.git","clone_url":"https://github.com/christopher-s-hall/Open-AVB.git","svn_url":"https://github.com/christopher-s-hall/Open-AVB","homepage":"","size":5883,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"open-avb-next"}},"base":{"label":"AVnu:wireless","ref":"wireless","sha":"f4c03e5664b1a7dd7e350739337abd26509a31ac","user":{"login":"AVnu","id":700271,"avatar_url":"https://avatars.githubusercontent.com/u/700271?v=3","gravatar_id":"","url":"https://api.github.com/users/AVnu","html_url":"https://github.com/AVnu","followers_url":"https://api.github.com/users/AVnu/followers","following_url":"https://api.github.com/users/AVnu/following{/other_user}","gists_url":"https://api.github.com/users/AVnu/gists{/gist_id}","starred_url":"https://api.github.com/users/AVnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVnu/subscriptions","organizations_url":"https://api.github.com/users/AVnu/orgs","repos_url":"https://api.github.com/users/AVnu/repos","events_url":"https://api.github.com/users/AVnu/events{/privacy}","received_events_url":"https://api.github.com/users/AVnu/received_events","type":"Organization","site_admin":false},"repo":{"id":5693778,"name":"Open-AVB","full_name":"AVnu/Open-AVB","owner":{"login":"AVnu","id":700271,"avatar_url":"https://avatars.githubusercontent.com/u/700271?v=3","gravatar_id":"","url":"https://api.github.com/users/AVnu","html_url":"https://github.com/AVnu","followers_url":"https://api.github.com/users/AVnu/followers","following_url":"https://api.github.com/users/AVnu/following{/other_user}","gists_url":"https://api.github.com/users/AVnu/gists{/gist_id}","starred_url":"https://api.github.com/users/AVnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AVnu/subscriptions","organizations_url":"https://api.github.com/users/AVnu/orgs","repos_url":"https://api.github.com/users/AVnu/repos","events_url":"https://api.github.com/users/AVnu/events{/privacy}","received_events_url":"https://api.github.com/users/AVnu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AVnu/Open-AVB","description":"Open AVB - an AVnu sponsored repository for Audio/Video Bridging technology","fork":false,"url":"https://api.github.com/repos/AVnu/Open-AVB","forks_url":"https://api.github.com/repos/AVnu/Open-AVB/forks","keys_url":"https://api.github.com/repos/AVnu/Open-AVB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AVnu/Open-AVB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AVnu/Open-AVB/teams","hooks_url":"https://api.github.com/repos/AVnu/Open-AVB/hooks","issue_events_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/events{/number}","events_url":"https://api.github.com/repos/AVnu/Open-AVB/events","assignees_url":"https://api.github.com/repos/AVnu/Open-AVB/assignees{/user}","branches_url":"https://api.github.com/repos/AVnu/Open-AVB/branches{/branch}","tags_url":"https://api.github.com/repos/AVnu/Open-AVB/tags","blobs_url":"https://api.github.com/repos/AVnu/Open-AVB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AVnu/Open-AVB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AVnu/Open-AVB/git/refs{/sha}","trees_url":"https://api.github.com/repos/AVnu/Open-AVB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AVnu/Open-AVB/statuses/{sha}","languages_url":"https://api.github.com/repos/AVnu/Open-AVB/languages","stargazers_url":"https://api.github.com/repos/AVnu/Open-AVB/stargazers","contributors_url":"https://api.github.com/repos/AVnu/Open-AVB/contributors","subscribers_url":"https://api.github.com/repos/AVnu/Open-AVB/subscribers","subscription_url":"https://api.github.com/repos/AVnu/Open-AVB/subscription","commits_url":"https://api.github.com/repos/AVnu/Open-AVB/commits{/sha}","git_commits_url":"https://api.github.com/repos/AVnu/Open-AVB/git/commits{/sha}","comments_url":"https://api.github.com/repos/AVnu/Open-AVB/comments{/number}","issue_comment_url":"https://api.github.com/repos/AVnu/Open-AVB/issues/comments{/number}","contents_url":"https://api.github.com/repos/AVnu/Open-AVB/contents/{+path}","compare_url":"https://api.github.com/repos/AVnu/Open-AVB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AVnu/Open-AVB/merges","archive_url":"https://api.github.com/repos/AVnu/Open-AVB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AVnu/Open-AVB/downloads","issues_url":"https://api.github.com/repos/AVnu/Open-AVB/issues{/number}","pulls_url":"https://api.github.com/repos/AVnu/Open-AVB/pulls{/number}","milestones_url":"https://api.github.com/repos/AVnu/Open-AVB/milestones{/number}","notifications_url":"https://api.github.com/repos/AVnu/Open-AVB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AVnu/Open-AVB/labels{/name}","releases_url":"https://api.github.com/repos/AVnu/Open-AVB/releases{/id}","created_at":"2012-09-05T21:19:39Z","updated_at":"2015-12-04T08:11:17Z","pushed_at":"2015-12-04T21:12:36Z","git_url":"git://github.com/AVnu/Open-AVB.git","ssh_url":"git@github.com:AVnu/Open-AVB.git","clone_url":"https://github.com/AVnu/Open-AVB.git","svn_url":"https://github.com/AVnu/Open-AVB","homepage":"","size":13070,"stargazers_count":73,"watchers_count":73,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":75,"mirror_url":null,"open_issues_count":89,"forks":75,"open_issues":89,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/324"},"html":{"href":"https://github.com/AVnu/Open-AVB/pull/324"},"issue":{"href":"https://api.github.com/repos/AVnu/Open-AVB/issues/324"},"comments":{"href":"https://api.github.com/repos/AVnu/Open-AVB/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AVnu/Open-AVB/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/AVnu/Open-AVB/statuses/26ecc049502ff2aadba4c055f47be95748c296ad"}}}}