{"action":"created","issue":{"url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/192","labels_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/192/labels{/name}","comments_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/192/comments","events_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/192/events","html_url":"https://github.com/BoltsFramework/Bolts-iOS/issues/192","id":114436613,"number":192,"title":"“Include of non-modular header inside framework module” error in project with framework sub-dependency","user":{"login":"marchy","id":1369360,"avatar_url":"https://avatars.githubusercontent.com/u/1369360?v=3","gravatar_id":"","url":"https://api.github.com/users/marchy","html_url":"https://github.com/marchy","followers_url":"https://api.github.com/users/marchy/followers","following_url":"https://api.github.com/users/marchy/following{/other_user}","gists_url":"https://api.github.com/users/marchy/gists{/gist_id}","starred_url":"https://api.github.com/users/marchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marchy/subscriptions","organizations_url":"https://api.github.com/users/marchy/orgs","repos_url":"https://api.github.com/users/marchy/repos","events_url":"https://api.github.com/users/marchy/events{/privacy}","received_events_url":"https://api.github.com/users/marchy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/labels/discussion","name":"discussion","color":"eeeeee"}],"state":"open","locked":false,"assignee":{"login":"nlutsenko","id":606991,"avatar_url":"https://avatars.githubusercontent.com/u/606991?v=3","gravatar_id":"","url":"https://api.github.com/users/nlutsenko","html_url":"https://github.com/nlutsenko","followers_url":"https://api.github.com/users/nlutsenko/followers","following_url":"https://api.github.com/users/nlutsenko/following{/other_user}","gists_url":"https://api.github.com/users/nlutsenko/gists{/gist_id}","starred_url":"https://api.github.com/users/nlutsenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlutsenko/subscriptions","organizations_url":"https://api.github.com/users/nlutsenko/orgs","repos_url":"https://api.github.com/users/nlutsenko/repos","events_url":"https://api.github.com/users/nlutsenko/events{/privacy}","received_events_url":"https://api.github.com/users/nlutsenko/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-10-31T21:56:39Z","updated_at":"2015-11-02T20:13:30Z","closed_at":null,"body":"The following error shows up on several Bolts library files when including a framework in a project which it itself requires Bolts.\r\nCompilation error: “Include of non-modular header inside framework module”\r\n\r\nThis seems to be caused by the fact that header files are included directly in .h files instead of the correct Objective-C approach of specifying @class and @protocol in the header and doing the actual include only in the .m file (see thread here for exact problem: http://stackoverflow.com/questions/28552500/xcode6-receiving-error-include-of-non-modular-header-inside-framework-module)\r\n\r\nIt looks like the Bolts code should be updated on these files with the correct Objective-C pattern in order to allow upper-level projects to correctly include frameworks that use Bolts as a sub-dependency."},"comment":{"url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/comments/153143774","html_url":"https://github.com/BoltsFramework/Bolts-iOS/issues/192#issuecomment-153143774","issue_url":"https://api.github.com/repos/BoltsFramework/Bolts-iOS/issues/192","id":153143774,"user":{"login":"marchy","id":1369360,"avatar_url":"https://avatars.githubusercontent.com/u/1369360?v=3","gravatar_id":"","url":"https://api.github.com/users/marchy","html_url":"https://github.com/marchy","followers_url":"https://api.github.com/users/marchy/followers","following_url":"https://api.github.com/users/marchy/following{/other_user}","gists_url":"https://api.github.com/users/marchy/gists{/gist_id}","starred_url":"https://api.github.com/users/marchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marchy/subscriptions","organizations_url":"https://api.github.com/users/marchy/orgs","repos_url":"https://api.github.com/users/marchy/repos","events_url":"https://api.github.com/users/marchy/events{/privacy}","received_events_url":"https://api.github.com/users/marchy/received_events","type":"User","site_admin":false},"created_at":"2015-11-02T20:13:30Z","updated_at":"2015-11-02T20:13:30Z","body":"Pull request ready: https://github.com/BoltsFramework/Bolts-iOS/pull/193"}}