{"action":"created","issue":{"url":"https://api.github.com/repos/dealii/dealii/issues/1944","labels_url":"https://api.github.com/repos/dealii/dealii/issues/1944/labels{/name}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/1944/comments","events_url":"https://api.github.com/repos/dealii/dealii/issues/1944/events","html_url":"https://github.com/dealii/dealii/pull/1944","id":120310140,"number":1944,"title":"Fix parameter handler dos files","user":{"login":"drwells","id":3917035,"avatar_url":"https://avatars.githubusercontent.com/u/3917035?v=3","gravatar_id":"","url":"https://api.github.com/users/drwells","html_url":"https://github.com/drwells","followers_url":"https://api.github.com/users/drwells/followers","following_url":"https://api.github.com/users/drwells/following{/other_user}","gists_url":"https://api.github.com/users/drwells/gists{/gist_id}","starred_url":"https://api.github.com/users/drwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwells/subscriptions","organizations_url":"https://api.github.com/users/drwells/orgs","repos_url":"https://api.github.com/users/drwells/repos","events_url":"https://api.github.com/users/drwells/events{/privacy}","received_events_url":"https://api.github.com/users/drwells/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-04T01:12:31Z","updated_at":"2015-12-04T02:29:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/1944","html_url":"https://github.com/dealii/dealii/pull/1944","diff_url":"https://github.com/dealii/dealii/pull/1944.diff","patch_url":"https://github.com/dealii/dealii/pull/1944.patch"},"body":"This should close #1691. The issue was in the function `Utilities::trim`, which left hanging `\\r`s at the end of lines. I resolved this by writing a more general `Utilities::trim_whitespace` function, which inspects the current locale to figure out what counts as a whitespace character or not."},"comment":{"url":"https://api.github.com/repos/dealii/dealii/issues/comments/161853438","html_url":"https://github.com/dealii/dealii/pull/1944#issuecomment-161853438","issue_url":"https://api.github.com/repos/dealii/dealii/issues/1944","id":161853438,"user":{"login":"natashasharma","id":8221730,"avatar_url":"https://avatars.githubusercontent.com/u/8221730?v=3","gravatar_id":"","url":"https://api.github.com/users/natashasharma","html_url":"https://github.com/natashasharma","followers_url":"https://api.github.com/users/natashasharma/followers","following_url":"https://api.github.com/users/natashasharma/following{/other_user}","gists_url":"https://api.github.com/users/natashasharma/gists{/gist_id}","starred_url":"https://api.github.com/users/natashasharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natashasharma/subscriptions","organizations_url":"https://api.github.com/users/natashasharma/orgs","repos_url":"https://api.github.com/users/natashasharma/repos","events_url":"https://api.github.com/users/natashasharma/events{/privacy}","received_events_url":"https://api.github.com/users/natashasharma/received_events","type":"User","site_admin":false},"created_at":"2015-12-04T02:29:51Z","updated_at":"2015-12-04T02:29:51Z","body":"E\nOn Dec 3, 2015 6:12 PM, \"David Wells\" <notifications@github.com> wrote:\n\n> This should close #1691 <https://github.com/dealii/dealii/issues/1691>.\n> The issue was in the function Utilities::trim, which left hanging \\rs at\n> the end of lines. I resolved this by writing a more general\n> Utilities::trim_whitespace function, which inspects the current locale to\n> figure out what counts as a whitespace character or not.\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/dealii/dealii/pull/1944\n> Commit Summary\n>\n>    - Add a function to trim general whitespace.\n>    - Fix ParameterHandler: it can now read DOS files.\n>\n> File Changes\n>\n>    - *M* include/deal.II/base/utilities.h\n>    <https://github.com/dealii/dealii/pull/1944/files#diff-0> (8)\n>    - *M* source/base/parameter_handler.cc\n>    <https://github.com/dealii/dealii/pull/1944/files#diff-1> (8)\n>    - *M* source/base/utilities.cc\n>    <https://github.com/dealii/dealii/pull/1944/files#diff-2> (32)\n>    - *A* tests/base/utilities_trim_whitespace.cc\n>    <https://github.com/dealii/dealii/pull/1944/files#diff-3> (58)\n>    - *A* tests/base/utilities_trim_whitespace.output\n>    <https://github.com/dealii/dealii/pull/1944/files#diff-4> (2)\n>    - *A* tests/bits/parameter_handler_dos_endings.cc\n>    <https://github.com/dealii/dealii/pull/1944/files#diff-5> (50)\n>    - *A* tests/bits/parameter_handler_dos_endings.output\n>    <https://github.com/dealii/dealii/pull/1944/files#diff-6> (2)\n>    - *A* tests/bits/parameter_handler_dos_endings.prm\n>    <https://github.com/dealii/dealii/pull/1944/files#diff-7> (5)\n>\n> Patch Links:\n>\n>    - https://github.com/dealii/dealii/pull/1944.patch\n>    - https://github.com/dealii/dealii/pull/1944.diff\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/dealii/dealii/pull/1944>.\n>\n"}}