{"action":"closed","number":3843,"pull_request":{"url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/pulls/3843","id":48407085,"html_url":"https://github.com/FreeCodeCamp/FreeCodeCamp/pull/3843","diff_url":"https://github.com/FreeCodeCamp/FreeCodeCamp/pull/3843.diff","patch_url":"https://github.com/FreeCodeCamp/FreeCodeCamp/pull/3843.patch","issue_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/issues/3843","number":3843,"state":"closed","locked":false,"title":"Fix infinite loop in challenges","user":{"login":"jlslew","id":1538744,"avatar_url":"https://avatars.githubusercontent.com/u/1538744?v=3","gravatar_id":"","url":"https://api.github.com/users/jlslew","html_url":"https://github.com/jlslew","followers_url":"https://api.github.com/users/jlslew/followers","following_url":"https://api.github.com/users/jlslew/following{/other_user}","gists_url":"https://api.github.com/users/jlslew/gists{/gist_id}","starred_url":"https://api.github.com/users/jlslew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlslew/subscriptions","organizations_url":"https://api.github.com/users/jlslew/orgs","repos_url":"https://api.github.com/users/jlslew/repos","events_url":"https://api.github.com/users/jlslew/events{/privacy}","received_events_url":"https://api.github.com/users/jlslew/received_events","type":"User","site_admin":false},"body":"- Remove the if statement to display a feedback when there is an\r\n  infinite loop and prevent issues; #3840, #3811, #3791, #3705, #3608...\r\n\r\n- Replace the simple for-each loop with `async.series` implementation\r\n  and execute the tests in the sandbox as well.\r\n\r\n- Without the setTimeout around the `sandBox.submit`, this is printed on\r\n  the console: `Uncaught TypeError: Cannot read property 'run' of null`\r\n  at line 283 in this file.\r\n\r\nIf this PR is merged, it closes #3732.","created_at":"2015-10-22T01:02:43Z","updated_at":"2015-10-22T21:27:46Z","closed_at":"2015-10-22T21:27:46Z","merged_at":null,"merge_commit_sha":"e2237b94ac1190b99fba10148e713e1e3b06490c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/pulls/3843/commits","review_comments_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/pulls/3843/comments","review_comment_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/issues/3843/comments","statuses_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/statuses/57de48f1838e101f2f30c351256682856754bdec","head":{"label":"jlslew:fix/infinite-loop-in-challenges","ref":"fix/infinite-loop-in-challenges","sha":"57de48f1838e101f2f30c351256682856754bdec","user":{"login":"jlslew","id":1538744,"avatar_url":"https://avatars.githubusercontent.com/u/1538744?v=3","gravatar_id":"","url":"https://api.github.com/users/jlslew","html_url":"https://github.com/jlslew","followers_url":"https://api.github.com/users/jlslew/followers","following_url":"https://api.github.com/users/jlslew/following{/other_user}","gists_url":"https://api.github.com/users/jlslew/gists{/gist_id}","starred_url":"https://api.github.com/users/jlslew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlslew/subscriptions","organizations_url":"https://api.github.com/users/jlslew/orgs","repos_url":"https://api.github.com/users/jlslew/repos","events_url":"https://api.github.com/users/jlslew/events{/privacy}","received_events_url":"https://api.github.com/users/jlslew/received_events","type":"User","site_admin":false},"repo":{"id":44454230,"name":"FreeCodeCamp","full_name":"jlslew/FreeCodeCamp","owner":{"login":"jlslew","id":1538744,"avatar_url":"https://avatars.githubusercontent.com/u/1538744?v=3","gravatar_id":"","url":"https://api.github.com/users/jlslew","html_url":"https://github.com/jlslew","followers_url":"https://api.github.com/users/jlslew/followers","following_url":"https://api.github.com/users/jlslew/following{/other_user}","gists_url":"https://api.github.com/users/jlslew/gists{/gist_id}","starred_url":"https://api.github.com/users/jlslew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlslew/subscriptions","organizations_url":"https://api.github.com/users/jlslew/orgs","repos_url":"https://api.github.com/users/jlslew/repos","events_url":"https://api.github.com/users/jlslew/events{/privacy}","received_events_url":"https://api.github.com/users/jlslew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlslew/FreeCodeCamp","description":"The http://FreeCodeCamp.com open-source codebase and curriculum. Learn to code and help nonprofits.","fork":true,"url":"https://api.github.com/repos/jlslew/FreeCodeCamp","forks_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/forks","keys_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/teams","hooks_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/hooks","issue_events_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/issues/events{/number}","events_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/events","assignees_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/assignees{/user}","branches_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/branches{/branch}","tags_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/tags","blobs_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/statuses/{sha}","languages_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/languages","stargazers_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/stargazers","contributors_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/contributors","subscribers_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/subscribers","subscription_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/subscription","commits_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/contents/{+path}","compare_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/merges","archive_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/downloads","issues_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/issues{/number}","pulls_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/pulls{/number}","milestones_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/milestones{/number}","notifications_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/labels{/name}","releases_url":"https://api.github.com/repos/jlslew/FreeCodeCamp/releases{/id}","created_at":"2015-10-17T20:54:11Z","updated_at":"2015-10-17T20:56:32Z","pushed_at":"2015-10-22T01:31:04Z","git_url":"git://github.com/jlslew/FreeCodeCamp.git","ssh_url":"git@github.com:jlslew/FreeCodeCamp.git","clone_url":"https://github.com/jlslew/FreeCodeCamp.git","svn_url":"https://github.com/jlslew/FreeCodeCamp","homepage":"","size":18096,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"FreeCodeCamp:staging","ref":"staging","sha":"6adbdc74caa5e7fb4f320b43554fc6df31c9bdbd","user":{"login":"FreeCodeCamp","id":9892522,"avatar_url":"https://avatars.githubusercontent.com/u/9892522?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeCodeCamp","html_url":"https://github.com/FreeCodeCamp","followers_url":"https://api.github.com/users/FreeCodeCamp/followers","following_url":"https://api.github.com/users/FreeCodeCamp/following{/other_user}","gists_url":"https://api.github.com/users/FreeCodeCamp/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeCodeCamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeCodeCamp/subscriptions","organizations_url":"https://api.github.com/users/FreeCodeCamp/orgs","repos_url":"https://api.github.com/users/FreeCodeCamp/repos","events_url":"https://api.github.com/users/FreeCodeCamp/events{/privacy}","received_events_url":"https://api.github.com/users/FreeCodeCamp/received_events","type":"Organization","site_admin":false},"repo":{"id":28457823,"name":"FreeCodeCamp","full_name":"FreeCodeCamp/FreeCodeCamp","owner":{"login":"FreeCodeCamp","id":9892522,"avatar_url":"https://avatars.githubusercontent.com/u/9892522?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeCodeCamp","html_url":"https://github.com/FreeCodeCamp","followers_url":"https://api.github.com/users/FreeCodeCamp/followers","following_url":"https://api.github.com/users/FreeCodeCamp/following{/other_user}","gists_url":"https://api.github.com/users/FreeCodeCamp/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeCodeCamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeCodeCamp/subscriptions","organizations_url":"https://api.github.com/users/FreeCodeCamp/orgs","repos_url":"https://api.github.com/users/FreeCodeCamp/repos","events_url":"https://api.github.com/users/FreeCodeCamp/events{/privacy}","received_events_url":"https://api.github.com/users/FreeCodeCamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeCodeCamp/FreeCodeCamp","description":"The http://FreeCodeCamp.com open-source codebase and curriculum. Learn to code and help nonprofits.","fork":false,"url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp","forks_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/forks","keys_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/teams","hooks_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/hooks","issue_events_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/issues/events{/number}","events_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/events","assignees_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/assignees{/user}","branches_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/branches{/branch}","tags_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/tags","blobs_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/languages","stargazers_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/stargazers","contributors_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/contributors","subscribers_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/subscribers","subscription_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/subscription","commits_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/contents/{+path}","compare_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/merges","archive_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/downloads","issues_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/issues{/number}","pulls_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/labels{/name}","releases_url":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/releases{/id}","created_at":"2014-12-24T17:49:19Z","updated_at":"2015-10-22T21:26:00Z","pushed_at":"2015-10-22T19:53:58Z","git_url":"git://github.com/FreeCodeCamp/FreeCodeCamp.git","ssh_url":"git@github.com:FreeCodeCamp/FreeCodeCamp.git","clone_url":"https://github.com/FreeCodeCamp/FreeCodeCamp.git","svn_url":"https://github.com/FreeCodeCamp/FreeCodeCamp","homepage":"","size":34095,"stargazers_count":25750,"watchers_count":25750,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1288,"mirror_url":null,"open_issues_count":225,"forks":1288,"open_issues":225,"watchers":25750,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/pulls/3843"},"html":{"href":"https://github.com/FreeCodeCamp/FreeCodeCamp/pull/3843"},"issue":{"href":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/issues/3843"},"comments":{"href":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/issues/3843/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/pulls/3843/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/pulls/3843/commits"},"statuses":{"href":"https://api.github.com/repos/FreeCodeCamp/FreeCodeCamp/statuses/57de48f1838e101f2f30c351256682856754bdec"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":1,"commits":1,"additions":28,"deletions":32,"changed_files":1}}