{"action":"created","issue":{"url":"https://api.github.com/repos/itteco/iframely/issues/99","labels_url":"https://api.github.com/repos/itteco/iframely/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/itteco/iframely/issues/99/comments","events_url":"https://api.github.com/repos/itteco/iframely/issues/99/events","html_url":"https://github.com/itteco/iframely/pull/99","id":118389507,"number":99,"title":"Support custom priority for plugins - for absolute ordering and overrides.","user":{"login":"snow01","id":3413079,"avatar_url":"https://avatars.githubusercontent.com/u/3413079?v=3","gravatar_id":"","url":"https://api.github.com/users/snow01","html_url":"https://github.com/snow01","followers_url":"https://api.github.com/users/snow01/followers","following_url":"https://api.github.com/users/snow01/following{/other_user}","gists_url":"https://api.github.com/users/snow01/gists{/gist_id}","starred_url":"https://api.github.com/users/snow01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snow01/subscriptions","organizations_url":"https://api.github.com/users/snow01/orgs","repos_url":"https://api.github.com/users/snow01/repos","events_url":"https://api.github.com/users/snow01/events{/privacy}","received_events_url":"https://api.github.com/users/snow01/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-23T14:21:11Z","updated_at":"2015-11-24T03:11:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/itteco/iframely/pulls/99","html_url":"https://github.com/itteco/iframely/pull/99","diff_url":"https://github.com/itteco/iframely/pull/99.diff","patch_url":"https://github.com/itteco/iframely/pull/99.patch"},"body":"1) Custom priority for plugins - other than having lowestPriority and highestPriority, this commit supports custom \"priority\" for absolute ordering of modules.\r\n\r\n2) Allows duplicate plugin-id with overriding of lower priority one by higher one - earlier duplicate one was getting ignored.\r\n\r\nJustification --\r\nMany of the domain plugins mention \"og-site\" as mixin. I wanted to override how \"site\" value is generated - that is I did not want to use twitter user as site. To achieve that without this commit changes would have required duplicating such domain plugins and then using another custom site meta plugin rather than og-site. But this change, I only need to declare a new og-site plugin and give it a higher priority.\r\n\r\nPlease let me know if more justifications are needed."},"comment":{"url":"https://api.github.com/repos/itteco/iframely/issues/comments/159138622","html_url":"https://github.com/itteco/iframely/pull/99#issuecomment-159138622","issue_url":"https://api.github.com/repos/itteco/iframely/issues/99","id":159138622,"user":{"login":"snow01","id":3413079,"avatar_url":"https://avatars.githubusercontent.com/u/3413079?v=3","gravatar_id":"","url":"https://api.github.com/users/snow01","html_url":"https://github.com/snow01","followers_url":"https://api.github.com/users/snow01/followers","following_url":"https://api.github.com/users/snow01/following{/other_user}","gists_url":"https://api.github.com/users/snow01/gists{/gist_id}","starred_url":"https://api.github.com/users/snow01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snow01/subscriptions","organizations_url":"https://api.github.com/users/snow01/orgs","repos_url":"https://api.github.com/users/snow01/repos","events_url":"https://api.github.com/users/snow01/events{/privacy}","received_events_url":"https://api.github.com/users/snow01/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T03:11:42Z","updated_at":"2015-11-24T03:11:42Z","body":"@iparamonau, \r\n\r\nLet me put some questions across --\r\n\r\n1) Without support for absolute ordering of plugins - which one among meta/twitter-site and meta/site gets picked up, both of them have lowestPriority ? \r\n\r\n2) How do I provide additional data for domains where mixins are not \"*\", without duplicating these domain plugins ? And such domains are many."}}