{"action":"created","issue":{"url":"https://api.github.com/repos/volmer/bootsy/issues/111","labels_url":"https://api.github.com/repos/volmer/bootsy/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/volmer/bootsy/issues/111/comments","events_url":"https://api.github.com/repos/volmer/bootsy/issues/111/events","html_url":"https://github.com/volmer/bootsy/pull/111","id":55091357,"number":111,"title":"Rescue failed gallery upload","user":{"login":"rzane","id":2731572,"avatar_url":"https://avatars.githubusercontent.com/u/2731572?v=3","gravatar_id":"","url":"https://api.github.com/users/rzane","html_url":"https://github.com/rzane","followers_url":"https://api.github.com/users/rzane/followers","following_url":"https://api.github.com/users/rzane/following{/other_user}","gists_url":"https://api.github.com/users/rzane/gists{/gist_id}","starred_url":"https://api.github.com/users/rzane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzane/subscriptions","organizations_url":"https://api.github.com/users/rzane/orgs","repos_url":"https://api.github.com/users/rzane/repos","events_url":"https://api.github.com/users/rzane/events{/privacy}","received_events_url":"https://api.github.com/users/rzane/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-21T23:08:40Z","updated_at":"2015-01-21T23:24:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/volmer/bootsy/pulls/111","html_url":"https://github.com/volmer/bootsy/pull/111","diff_url":"https://github.com/volmer/bootsy/pull/111.diff","patch_url":"https://github.com/volmer/bootsy/pull/111.patch"},"body":"When a file failed to upload to a gallery, the loading icon would just sit there spinning. The error wasn't being caught. The `imageUploadFailed` function was added because the error behavior was used in multiple places. The problem can be replicated by attempting to upload a file with a strange extension.\r\n\r\nAfter handling the errors, the refresh button wasn't being hidden after being clicked. Every time it was clicked, it would refetch the images without clearing the images that were already there.\r\n\r\nAlso, as far as I know, there's no reason to use class_eval inside the included block when using ActiveSupport::Concern. The included block is for class level macros, like `has_one` or `attr_accessor`. No need to put instance methods in the included block."},"comment":{"url":"https://api.github.com/repos/volmer/bootsy/issues/comments/70942928","html_url":"https://github.com/volmer/bootsy/pull/111#issuecomment-70942928","issue_url":"https://api.github.com/repos/volmer/bootsy/issues/111","id":70942928,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2015-01-21T23:24:19Z","updated_at":"2015-01-21T23:24:19Z","body":"\n[![Coverage Status](https://coveralls.io/builds/1783769/badge)](https://coveralls.io/builds/1783769)\n\nCoverage decreased (-0.01%) to 94.82% when pulling **869968c8216d5d15640e233a7c548313497ddc17 on rzane:catch-gallery-upload-errors** into **59105dda9b818dbad681bcebc441a2539e00e01d on volmer:master**.\n"}}