{"action":"opened","number":2152,"pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/2152","id":32428235,"html_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2152","diff_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2152.diff","patch_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2152.patch","issue_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2152","number":2152,"state":"open","locked":false,"title":"use package handle of attribute key category","user":{"login":"Remo","id":129864,"avatar_url":"https://avatars.githubusercontent.com/u/129864?v=3","gravatar_id":"","url":"https://api.github.com/users/Remo","html_url":"https://github.com/Remo","followers_url":"https://api.github.com/users/Remo/followers","following_url":"https://api.github.com/users/Remo/following{/other_user}","gists_url":"https://api.github.com/users/Remo/gists{/gist_id}","starred_url":"https://api.github.com/users/Remo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remo/subscriptions","organizations_url":"https://api.github.com/users/Remo/orgs","repos_url":"https://api.github.com/users/Remo/repos","events_url":"https://api.github.com/users/Remo/events{/privacy}","received_events_url":"https://api.github.com/users/Remo/received_events","type":"User","site_admin":false},"body":"This commit doesn't work for me:\r\nhttps://github.com/concrete5/concrete5-5.7.0/commit/80935590a040912bf71bde30e908a67f9ce52bdd\r\n\r\nGot an XML like this:\r\n```\r\n<?xml version=\"1.0\"?>\r\n<concrete5-cif version=\"1.0\">\r\n    <attributekeys>\r\n        <attributekey handle=\"exclude_subpages_from_nav\" name=\"Exclude Subpages from Nav\" package=\"webwende_theme\"\r\n                      searchable=\"1\" indexed=\"1\" type=\"boolean\" category=\"collection\" attributeset=\"navigation\"/>\r\n    </attributekeys>\r\n</concrete5-cif>\r\n```\r\n\r\nProduces an error like this:\r\n```\r\ncall_user_func() expects parameter 1 to be a valid callback, class '\\Concrete\\Package\\MyPackage\\Src\\Attribute\\Key\\CollectionKey' not found\r\n```\r\n\r\nThis is because you're checking the package of the attribute, but that's incorrect. You need to check the package of the attribute key category like I did in my pull request: https://github.com/concrete5/concrete5-5.7.0/pull/2100/files","created_at":"2015-04-01T15:11:35Z","updated_at":"2015-04-01T15:11:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/2152/commits","review_comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/2152/comments","review_comment_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2152/comments","statuses_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/statuses/d8eaa03a825099d5922e15c3bcf6bacbdc1e9a45","head":{"label":"Remo:patch-2","ref":"patch-2","sha":"d8eaa03a825099d5922e15c3bcf6bacbdc1e9a45","user":{"login":"Remo","id":129864,"avatar_url":"https://avatars.githubusercontent.com/u/129864?v=3","gravatar_id":"","url":"https://api.github.com/users/Remo","html_url":"https://github.com/Remo","followers_url":"https://api.github.com/users/Remo/followers","following_url":"https://api.github.com/users/Remo/following{/other_user}","gists_url":"https://api.github.com/users/Remo/gists{/gist_id}","starred_url":"https://api.github.com/users/Remo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remo/subscriptions","organizations_url":"https://api.github.com/users/Remo/orgs","repos_url":"https://api.github.com/users/Remo/repos","events_url":"https://api.github.com/users/Remo/events{/privacy}","received_events_url":"https://api.github.com/users/Remo/received_events","type":"User","site_admin":false},"repo":{"id":26751685,"name":"concrete5-5.7.0","full_name":"Remo/concrete5-5.7.0","owner":{"login":"Remo","id":129864,"avatar_url":"https://avatars.githubusercontent.com/u/129864?v=3","gravatar_id":"","url":"https://api.github.com/users/Remo","html_url":"https://github.com/Remo","followers_url":"https://api.github.com/users/Remo/followers","following_url":"https://api.github.com/users/Remo/following{/other_user}","gists_url":"https://api.github.com/users/Remo/gists{/gist_id}","starred_url":"https://api.github.com/users/Remo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remo/subscriptions","organizations_url":"https://api.github.com/users/Remo/orgs","repos_url":"https://api.github.com/users/Remo/repos","events_url":"https://api.github.com/users/Remo/events{/privacy}","received_events_url":"https://api.github.com/users/Remo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Remo/concrete5-5.7.0","description":"Official repository for concrete5 5.7 development","fork":true,"url":"https://api.github.com/repos/Remo/concrete5-5.7.0","forks_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/forks","keys_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/teams","hooks_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/hooks","issue_events_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/issues/events{/number}","events_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/events","assignees_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/assignees{/user}","branches_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/branches{/branch}","tags_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/tags","blobs_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/statuses/{sha}","languages_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/languages","stargazers_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/stargazers","contributors_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/contributors","subscribers_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/subscribers","subscription_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/subscription","commits_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/issues/comments{/number}","contents_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/contents/{+path}","compare_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/merges","archive_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/downloads","issues_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/issues{/number}","pulls_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/pulls{/number}","milestones_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/milestones{/number}","notifications_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/labels{/name}","releases_url":"https://api.github.com/repos/Remo/concrete5-5.7.0/releases{/id}","created_at":"2014-11-17T10:26:58Z","updated_at":"2014-12-18T09:38:54Z","pushed_at":"2015-04-01T15:11:02Z","git_url":"git://github.com/Remo/concrete5-5.7.0.git","ssh_url":"git@github.com:Remo/concrete5-5.7.0.git","clone_url":"https://github.com/Remo/concrete5-5.7.0.git","svn_url":"https://github.com/Remo/concrete5-5.7.0","homepage":"","size":73869,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"concrete5:develop","ref":"develop","sha":"baf956ffadf800830ac0971de27c353f959f5338","user":{"login":"concrete5","id":657929,"avatar_url":"https://avatars.githubusercontent.com/u/657929?v=3","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"repo":{"id":19040482,"name":"concrete5-5.7.0","full_name":"concrete5/concrete5-5.7.0","owner":{"login":"concrete5","id":657929,"avatar_url":"https://avatars.githubusercontent.com/u/657929?v=3","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concrete5/concrete5-5.7.0","description":"Official repository for concrete5 5.7 development","fork":false,"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0","forks_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/forks","keys_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/teams","hooks_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/hooks","issue_events_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/events{/number}","events_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/events","assignees_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/assignees{/user}","branches_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/branches{/branch}","tags_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/tags","blobs_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/statuses/{sha}","languages_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/languages","stargazers_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/stargazers","contributors_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/contributors","subscribers_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/subscribers","subscription_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/subscription","commits_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/comments{/number}","contents_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/contents/{+path}","compare_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/merges","archive_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/downloads","issues_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues{/number}","pulls_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls{/number}","milestones_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/milestones{/number}","notifications_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/labels{/name}","releases_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/releases{/id}","created_at":"2014-04-22T18:12:28Z","updated_at":"2015-03-31T17:28:02Z","pushed_at":"2015-04-01T14:16:24Z","git_url":"git://github.com/concrete5/concrete5-5.7.0.git","ssh_url":"git@github.com:concrete5/concrete5-5.7.0.git","clone_url":"https://github.com/concrete5/concrete5-5.7.0.git","svn_url":"https://github.com/concrete5/concrete5-5.7.0","homepage":"","size":119603,"stargazers_count":122,"watchers_count":122,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"open_issues_count":230,"forks":142,"open_issues":230,"watchers":122,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/2152"},"html":{"href":"https://github.com/concrete5/concrete5-5.7.0/pull/2152"},"issue":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2152"},"comments":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2152/comments"},"review_comments":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/2152/comments"},"review_comment":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/2152/commits"},"statuses":{"href":"https://api.github.com/repos/concrete5/concrete5-5.7.0/statuses/d8eaa03a825099d5922e15c3bcf6bacbdc1e9a45"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}