{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/chipper/issues/359","labels_url":"https://api.github.com/repos/phetsims/chipper/issues/359/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/chipper/issues/359/comments","events_url":"https://api.github.com/repos/phetsims/chipper/issues/359/events","html_url":"https://github.com/phetsims/chipper/issues/359","id":108062622,"number":359,"title":"[build-server] simTitle intialization","user":{"login":"jonathanolson","id":480878,"avatar_url":"https://avatars.githubusercontent.com/u/480878?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanolson","html_url":"https://github.com/jonathanolson","followers_url":"https://api.github.com/users/jonathanolson/followers","following_url":"https://api.github.com/users/jonathanolson/following{/other_user}","gists_url":"https://api.github.com/users/jonathanolson/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanolson/subscriptions","organizations_url":"https://api.github.com/users/jonathanolson/orgs","repos_url":"https://api.github.com/users/jonathanolson/repos","events_url":"https://api.github.com/users/jonathanolson/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanolson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phetsims/chipper/labels/review","name":"review","color":"0052cc"}],"state":"open","locked":false,"assignee":{"login":"aaronsamuel137","id":3193912,"avatar_url":"https://avatars.githubusercontent.com/u/3193912?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronsamuel137","html_url":"https://github.com/aaronsamuel137","followers_url":"https://api.github.com/users/aaronsamuel137/followers","following_url":"https://api.github.com/users/aaronsamuel137/following{/other_user}","gists_url":"https://api.github.com/users/aaronsamuel137/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronsamuel137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronsamuel137/subscriptions","organizations_url":"https://api.github.com/users/aaronsamuel137/orgs","repos_url":"https://api.github.com/users/aaronsamuel137/repos","events_url":"https://api.github.com/users/aaronsamuel137/events{/privacy}","received_events_url":"https://api.github.com/users/aaronsamuel137/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-09-24T05:45:25Z","updated_at":"2015-09-25T15:45:54Z","closed_at":null,"body":"createTranslationsXML is currently creating simTitle, which is used later in addToRosetta. I'd prefer this would be more explicit, so that createTranslationsXML would call a callback including the simTitle e.g.:\r\n```js\r\ncallback( simTitle )\r\n```\r\nthen have the callback put it in a closure:\r\n```js\r\ncreateTranslationsXML( function( simTitle ) {\r\n```\r\nand pass it to the function that needs it:\r\n```js\r\naddToRosetta( simTitle function() {\r\n```\r\n\r\nThat makes it very explicit that it's unsafe to reorder those two (I know it's specified in addToRosetta's docs, and I appreciate that), but also gets rid of the need for the global.\r\n\r\nThoughts?\r\n\r\nReview: https://github.com/phetsims/chipper/issues/141"},"comment":{"url":"https://api.github.com/repos/phetsims/chipper/issues/comments/143258008","html_url":"https://github.com/phetsims/chipper/issues/359#issuecomment-143258008","issue_url":"https://api.github.com/repos/phetsims/chipper/issues/359","id":143258008,"user":{"login":"aaronsamuel137","id":3193912,"avatar_url":"https://avatars.githubusercontent.com/u/3193912?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronsamuel137","html_url":"https://github.com/aaronsamuel137","followers_url":"https://api.github.com/users/aaronsamuel137/followers","following_url":"https://api.github.com/users/aaronsamuel137/following{/other_user}","gists_url":"https://api.github.com/users/aaronsamuel137/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronsamuel137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronsamuel137/subscriptions","organizations_url":"https://api.github.com/users/aaronsamuel137/orgs","repos_url":"https://api.github.com/users/aaronsamuel137/repos","events_url":"https://api.github.com/users/aaronsamuel137/events{/privacy}","received_events_url":"https://api.github.com/users/aaronsamuel137/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T15:45:53Z","updated_at":"2015-09-25T15:45:53Z","body":"Not sure if I followed exactly what you were suggesting, but I made an attempt at it. Assigning to @jonathanolson for review."}}