{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/calavera/dkvolume/pulls/5","id":45851990,"html_url":"https://github.com/calavera/dkvolume/pull/5","diff_url":"https://github.com/calavera/dkvolume/pull/5.diff","patch_url":"https://github.com/calavera/dkvolume/pull/5.patch","issue_url":"https://api.github.com/repos/calavera/dkvolume/issues/5","number":5,"state":"closed","locked":false,"title":"Use different request/response types for each endpoint","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"body":"When I used this library, I found it a bit confusing because all functions were sharing the same request type and I wasn't sure which one is used when –without reading other driver codes. Therefore, I separated  request/response types of each endpoint. \r\n\r\nThis is a breaking change but what users of the library will see is clearer and precise:\r\n\r\n> \r\n![image](https://cloud.githubusercontent.com/assets/159209/10063749/fb1b3aa4-6225-11e5-91cc-4f7fc20792f3.png)\r\n\r\n\r\nThere's a bit of repetitive code due to the type system and lacks of generics in Go –but it's not too much (hence it should be acceptable, I'm guessing).\r\n\r\nI am still not sure why the drivers are responding with  the mount point in both `Path()` and `Mount()` calls, though...","created_at":"2015-09-24T01:57:43Z","updated_at":"2015-09-28T17:33:06Z","closed_at":"2015-09-28T17:33:06Z","merged_at":null,"merge_commit_sha":"4d31da917a3c2265b28eb0790186045bce567315","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/calavera/dkvolume/pulls/5/commits","review_comments_url":"https://api.github.com/repos/calavera/dkvolume/pulls/5/comments","review_comment_url":"https://api.github.com/repos/calavera/dkvolume/pulls/comments{/number}","comments_url":"https://api.github.com/repos/calavera/dkvolume/issues/5/comments","statuses_url":"https://api.github.com/repos/calavera/dkvolume/statuses/d386f95879af15959a4c21aa7d0efd3a0771b503","head":{"label":"ahmetalpbalkan:master","ref":"master","sha":"d386f95879af15959a4c21aa7d0efd3a0771b503","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"repo":{"id":43036137,"name":"dkvolume","full_name":"ahmetalpbalkan/dkvolume","owner":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmetalpbalkan/dkvolume","description":"Docker external volumes API handler","fork":true,"url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume","forks_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/forks","keys_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/teams","hooks_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/hooks","issue_events_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/issues/events{/number}","events_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/events","assignees_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/assignees{/user}","branches_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/branches{/branch}","tags_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/tags","blobs_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/languages","stargazers_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/stargazers","contributors_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/contributors","subscribers_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/subscribers","subscription_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/subscription","commits_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/contents/{+path}","compare_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/merges","archive_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/downloads","issues_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/issues{/number}","pulls_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/labels{/name}","releases_url":"https://api.github.com/repos/ahmetalpbalkan/dkvolume/releases{/id}","created_at":"2015-09-24T01:02:47Z","updated_at":"2015-09-24T01:02:49Z","pushed_at":"2015-09-24T02:06:30Z","git_url":"git://github.com/ahmetalpbalkan/dkvolume.git","ssh_url":"git@github.com:ahmetalpbalkan/dkvolume.git","clone_url":"https://github.com/ahmetalpbalkan/dkvolume.git","svn_url":"https://github.com/ahmetalpbalkan/dkvolume","homepage":"","size":94,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"calavera:master","ref":"master","sha":"b8a36bf96d69f40db01804663f2425020a311973","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"repo":{"id":35846920,"name":"dkvolume","full_name":"calavera/dkvolume","owner":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/calavera/dkvolume","description":"Docker external volumes API handler","fork":false,"url":"https://api.github.com/repos/calavera/dkvolume","forks_url":"https://api.github.com/repos/calavera/dkvolume/forks","keys_url":"https://api.github.com/repos/calavera/dkvolume/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calavera/dkvolume/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calavera/dkvolume/teams","hooks_url":"https://api.github.com/repos/calavera/dkvolume/hooks","issue_events_url":"https://api.github.com/repos/calavera/dkvolume/issues/events{/number}","events_url":"https://api.github.com/repos/calavera/dkvolume/events","assignees_url":"https://api.github.com/repos/calavera/dkvolume/assignees{/user}","branches_url":"https://api.github.com/repos/calavera/dkvolume/branches{/branch}","tags_url":"https://api.github.com/repos/calavera/dkvolume/tags","blobs_url":"https://api.github.com/repos/calavera/dkvolume/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calavera/dkvolume/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calavera/dkvolume/git/refs{/sha}","trees_url":"https://api.github.com/repos/calavera/dkvolume/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calavera/dkvolume/statuses/{sha}","languages_url":"https://api.github.com/repos/calavera/dkvolume/languages","stargazers_url":"https://api.github.com/repos/calavera/dkvolume/stargazers","contributors_url":"https://api.github.com/repos/calavera/dkvolume/contributors","subscribers_url":"https://api.github.com/repos/calavera/dkvolume/subscribers","subscription_url":"https://api.github.com/repos/calavera/dkvolume/subscription","commits_url":"https://api.github.com/repos/calavera/dkvolume/commits{/sha}","git_commits_url":"https://api.github.com/repos/calavera/dkvolume/git/commits{/sha}","comments_url":"https://api.github.com/repos/calavera/dkvolume/comments{/number}","issue_comment_url":"https://api.github.com/repos/calavera/dkvolume/issues/comments{/number}","contents_url":"https://api.github.com/repos/calavera/dkvolume/contents/{+path}","compare_url":"https://api.github.com/repos/calavera/dkvolume/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calavera/dkvolume/merges","archive_url":"https://api.github.com/repos/calavera/dkvolume/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calavera/dkvolume/downloads","issues_url":"https://api.github.com/repos/calavera/dkvolume/issues{/number}","pulls_url":"https://api.github.com/repos/calavera/dkvolume/pulls{/number}","milestones_url":"https://api.github.com/repos/calavera/dkvolume/milestones{/number}","notifications_url":"https://api.github.com/repos/calavera/dkvolume/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calavera/dkvolume/labels{/name}","releases_url":"https://api.github.com/repos/calavera/dkvolume/releases{/id}","created_at":"2015-05-18T22:59:22Z","updated_at":"2015-09-10T04:56:58Z","pushed_at":"2015-09-28T16:57:04Z","git_url":"git://github.com/calavera/dkvolume.git","ssh_url":"git@github.com:calavera/dkvolume.git","clone_url":"https://github.com/calavera/dkvolume.git","svn_url":"https://github.com/calavera/dkvolume","homepage":"","size":180,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":0,"forks":7,"open_issues":0,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/calavera/dkvolume/pulls/5"},"html":{"href":"https://github.com/calavera/dkvolume/pull/5"},"issue":{"href":"https://api.github.com/repos/calavera/dkvolume/issues/5"},"comments":{"href":"https://api.github.com/repos/calavera/dkvolume/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/calavera/dkvolume/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/calavera/dkvolume/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/calavera/dkvolume/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/calavera/dkvolume/statuses/d386f95879af15959a4c21aa7d0efd3a0771b503"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":90,"deletions":47,"changed_files":1}}