{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/30194242","id":30194242,"diff_hunk":"@@ -137,6 +139,16 @@ void CustomPostEffectShader::render(\n         glUniform1i(u_texture_, texture_index++);\n     }\n \n+    if (u_projection_matrix_ != -1) {\n+        glm::mat4 view = camera->getViewMatrix();\n+        glm::mat4 proj = glm::mat4(","path":"GVRf/Framework/jni/shaders/posteffect/custom_post_effect_shader.cpp","position":24,"original_position":24,"commit_id":"8255e3753f7aa52d482a5b88304613c6154fe3b9","original_commit_id":"8255e3753f7aa52d482a5b88304613c6154fe3b9","user":{"login":"thomasflynn","id":9667914,"avatar_url":"https://avatars.githubusercontent.com/u/9667914?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasflynn","html_url":"https://github.com/thomasflynn","followers_url":"https://api.github.com/users/thomasflynn/followers","following_url":"https://api.github.com/users/thomasflynn/following{/other_user}","gists_url":"https://api.github.com/users/thomasflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasflynn/subscriptions","organizations_url":"https://api.github.com/users/thomasflynn/orgs","repos_url":"https://api.github.com/users/thomasflynn/repos","events_url":"https://api.github.com/users/thomasflynn/events{/privacy}","received_events_url":"https://api.github.com/users/thomasflynn/received_events","type":"User","site_admin":false},"body":"the rest of the code looks pretty straight-forward, this line is the only one I have a question on so far.  Why this extra step of creating another mat4?","created_at":"2015-05-13T00:34:05Z","updated_at":"2015-05-13T00:34:05Z","html_url":"https://github.com/Samsung/GearVRf/pull/40#discussion_r30194242","pull_request_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/30194242"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/40#discussion_r30194242"},"pull_request":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/40","id":35121230,"html_url":"https://github.com/Samsung/GearVRf/pull/40","diff_url":"https://github.com/Samsung/GearVRf/pull/40.diff","patch_url":"https://github.com/Samsung/GearVRf/pull/40.patch","issue_url":"https://api.github.com/repos/Samsung/GearVRf/issues/40","number":40,"state":"open","locked":false,"title":"Add a way for custom post effects to access latest projection matrix.","user":{"login":"KolorCompany","id":8290658,"avatar_url":"https://avatars.githubusercontent.com/u/8290658?v=3","gravatar_id":"","url":"https://api.github.com/users/KolorCompany","html_url":"https://github.com/KolorCompany","followers_url":"https://api.github.com/users/KolorCompany/followers","following_url":"https://api.github.com/users/KolorCompany/following{/other_user}","gists_url":"https://api.github.com/users/KolorCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/KolorCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KolorCompany/subscriptions","organizations_url":"https://api.github.com/users/KolorCompany/orgs","repos_url":"https://api.github.com/users/KolorCompany/repos","events_url":"https://api.github.com/users/KolorCompany/events{/privacy}","received_events_url":"https://api.github.com/users/KolorCompany/received_events","type":"User","site_admin":false},"body":"Add handling for the \"u_projection_matrix\" uniform, that will\r\nautomatically get the mapping of the predicted projection matrix when\r\nused in a custom shader.\r\n\r\nGearVRf-DCO-1.0-Signed-off-by: Benoit Fouet <benoit.fouet@kolor.com>","created_at":"2015-05-11T12:10:49Z","updated_at":"2015-05-13T00:34:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a15a585c4a3dede312b6581413b91c7a7754660c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/40/commits","review_comments_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/40/comments","review_comment_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/issues/40/comments","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/8255e3753f7aa52d482a5b88304613c6154fe3b9","head":{"label":"KolorCompany:bfouet","ref":"bfouet","sha":"8255e3753f7aa52d482a5b88304613c6154fe3b9","user":{"login":"KolorCompany","id":8290658,"avatar_url":"https://avatars.githubusercontent.com/u/8290658?v=3","gravatar_id":"","url":"https://api.github.com/users/KolorCompany","html_url":"https://github.com/KolorCompany","followers_url":"https://api.github.com/users/KolorCompany/followers","following_url":"https://api.github.com/users/KolorCompany/following{/other_user}","gists_url":"https://api.github.com/users/KolorCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/KolorCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KolorCompany/subscriptions","organizations_url":"https://api.github.com/users/KolorCompany/orgs","repos_url":"https://api.github.com/users/KolorCompany/repos","events_url":"https://api.github.com/users/KolorCompany/events{/privacy}","received_events_url":"https://api.github.com/users/KolorCompany/received_events","type":"User","site_admin":false},"repo":{"id":33981591,"name":"GearVRf","full_name":"KolorCompany/GearVRf","owner":{"login":"KolorCompany","id":8290658,"avatar_url":"https://avatars.githubusercontent.com/u/8290658?v=3","gravatar_id":"","url":"https://api.github.com/users/KolorCompany","html_url":"https://github.com/KolorCompany","followers_url":"https://api.github.com/users/KolorCompany/followers","following_url":"https://api.github.com/users/KolorCompany/following{/other_user}","gists_url":"https://api.github.com/users/KolorCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/KolorCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KolorCompany/subscriptions","organizations_url":"https://api.github.com/users/KolorCompany/orgs","repos_url":"https://api.github.com/users/KolorCompany/repos","events_url":"https://api.github.com/users/KolorCompany/events{/privacy}","received_events_url":"https://api.github.com/users/KolorCompany/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KolorCompany/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":true,"url":"https://api.github.com/repos/KolorCompany/GearVRf","forks_url":"https://api.github.com/repos/KolorCompany/GearVRf/forks","keys_url":"https://api.github.com/repos/KolorCompany/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KolorCompany/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KolorCompany/GearVRf/teams","hooks_url":"https://api.github.com/repos/KolorCompany/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/KolorCompany/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/KolorCompany/GearVRf/events","assignees_url":"https://api.github.com/repos/KolorCompany/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/KolorCompany/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/KolorCompany/GearVRf/tags","blobs_url":"https://api.github.com/repos/KolorCompany/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KolorCompany/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KolorCompany/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/KolorCompany/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KolorCompany/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/KolorCompany/GearVRf/languages","stargazers_url":"https://api.github.com/repos/KolorCompany/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/KolorCompany/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/KolorCompany/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/KolorCompany/GearVRf/subscription","commits_url":"https://api.github.com/repos/KolorCompany/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/KolorCompany/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/KolorCompany/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/KolorCompany/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/KolorCompany/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/KolorCompany/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KolorCompany/GearVRf/merges","archive_url":"https://api.github.com/repos/KolorCompany/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KolorCompany/GearVRf/downloads","issues_url":"https://api.github.com/repos/KolorCompany/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/KolorCompany/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/KolorCompany/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/KolorCompany/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KolorCompany/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/KolorCompany/GearVRf/releases{/id}","created_at":"2015-04-15T08:14:40Z","updated_at":"2015-04-15T08:14:52Z","pushed_at":"2015-05-12T09:06:41Z","git_url":"git://github.com/KolorCompany/GearVRf.git","ssh_url":"git@github.com:KolorCompany/GearVRf.git","clone_url":"https://github.com/KolorCompany/GearVRf.git","svn_url":"https://github.com/KolorCompany/GearVRf","homepage":"http://www.gearvrf.org","size":195445,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"5c815ea99811d7bc84c0a0d39fd489a496a44b88","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":32836701,"name":"GearVRf","full_name":"Samsung/GearVRf","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":false,"url":"https://api.github.com/repos/Samsung/GearVRf","forks_url":"https://api.github.com/repos/Samsung/GearVRf/forks","keys_url":"https://api.github.com/repos/Samsung/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/GearVRf/teams","hooks_url":"https://api.github.com/repos/Samsung/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/Samsung/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/GearVRf/events","assignees_url":"https://api.github.com/repos/Samsung/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/GearVRf/tags","blobs_url":"https://api.github.com/repos/Samsung/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/GearVRf/languages","stargazers_url":"https://api.github.com/repos/Samsung/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/Samsung/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/Samsung/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/Samsung/GearVRf/subscription","commits_url":"https://api.github.com/repos/Samsung/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/GearVRf/merges","archive_url":"https://api.github.com/repos/Samsung/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/GearVRf/downloads","issues_url":"https://api.github.com/repos/Samsung/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/GearVRf/releases{/id}","created_at":"2015-03-25T02:02:18Z","updated_at":"2015-05-12T16:10:16Z","pushed_at":"2015-05-12T22:41:37Z","git_url":"git://github.com/Samsung/GearVRf.git","ssh_url":"git@github.com:Samsung/GearVRf.git","clone_url":"https://github.com/Samsung/GearVRf.git","svn_url":"https://github.com/Samsung/GearVRf","homepage":"http://www.gearvrf.org","size":203293,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":14,"forks":17,"open_issues":14,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/40"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/40"},"issue":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/40"},"comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/GearVRf/statuses/8255e3753f7aa52d482a5b88304613c6154fe3b9"}}}}