{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12785","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12785/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12785/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12785/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12785","id":91245666,"number":12785,"title":"Monster upgrade fixes","user":{"login":"drbig","id":1252899,"avatar_url":"https://avatars.githubusercontent.com/u/1252899?v=3","gravatar_id":"","url":"https://api.github.com/users/drbig","html_url":"https://github.com/drbig","followers_url":"https://api.github.com/users/drbig/followers","following_url":"https://api.github.com/users/drbig/following{/other_user}","gists_url":"https://api.github.com/users/drbig/gists{/gist_id}","starred_url":"https://api.github.com/users/drbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbig/subscriptions","organizations_url":"https://api.github.com/users/drbig/orgs","repos_url":"https://api.github.com/users/drbig/repos","events_url":"https://api.github.com/users/drbig/events{/privacy}","received_events_url":"https://api.github.com/users/drbig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-26T13:07:54Z","updated_at":"2015-06-28T17:52:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12785","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12785","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12785.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12785.patch"},"body":"Relates to #12313.\r\n\r\nSo it was supposed to be simple... yeah. Commits are commented, so here's a TL;DR:\r\n\r\n - The first commit changes the description of the upgrade factor. IMO this should be in regardless of everything else\r\n - I've added both season length scaling and initial season offset\r\n - I recalculate the upgrade threshold once, directly on monster load\r\n - I've made `can_upgrade` an almost single-point of checking if upgrade is OK, this may turn off the upgrade special attack in some cases\r\n\r\nNote: with season length scaling the settings factor being 0.0 - 100.0 makes a bit more sense."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/116303693","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12785#issuecomment-116303693","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12785","id":116303693,"user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"created_at":"2015-06-28T17:52:00Z","updated_at":"2015-06-28T17:52:00Z","body":"Checked the code: the performance shouldn't be a problem (it is invoked on creature load, not every turn).\r\n\r\nNitpick: using `calendar::start` could result in cleaner code than `if-else` with seasons. Plus, if we later drop the whole strict day timing of evolutions, it would automatically take starting hour into account.\r\n\r\nLooks good, I think."}}