{"action":"created","comment":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/35399705","id":35399705,"diff_hunk":"@@ -72,6 +76,18 @@ THREE.Object3D = function () {\n \tthis.renderOrder = 0;\n \n \tthis.userData = {};\n+\t\n+\t//contains the last state of position, quaternion & scale\n+\tthis._matrixState = { positionx: 0, ","path":"src/core/Object3D.js","position":33,"original_position":33,"commit_id":"5ea84fcc3a7983bf650938c1a9b44d3496df21c0","original_commit_id":"5ea84fcc3a7983bf650938c1a9b44d3496df21c0","user":{"login":"gero3","id":155535,"avatar_url":"https://avatars.githubusercontent.com/u/155535?v=3","gravatar_id":"","url":"https://api.github.com/users/gero3","html_url":"https://github.com/gero3","followers_url":"https://api.github.com/users/gero3/followers","following_url":"https://api.github.com/users/gero3/following{/other_user}","gists_url":"https://api.github.com/users/gero3/gists{/gist_id}","starred_url":"https://api.github.com/users/gero3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gero3/subscriptions","organizations_url":"https://api.github.com/users/gero3/orgs","repos_url":"https://api.github.com/users/gero3/repos","events_url":"https://api.github.com/users/gero3/events{/privacy}","received_events_url":"https://api.github.com/users/gero3/received_events","type":"User","site_admin":false},"body":"I'll look into it but I think performance will degrade.","created_at":"2015-07-24T07:01:14Z","updated_at":"2015-07-24T07:01:14Z","html_url":"https://github.com/mrdoob/three.js/pull/6851#discussion_r35399705","pull_request_url":"https://api.github.com/repos/mrdoob/three.js/pulls/6851","_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/35399705"},"html":{"href":"https://github.com/mrdoob/three.js/pull/6851#discussion_r35399705"},"pull_request":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/6851"}}},"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/6851","id":40118270,"html_url":"https://github.com/mrdoob/three.js/pull/6851","diff_url":"https://github.com/mrdoob/three.js/pull/6851.diff","patch_url":"https://github.com/mrdoob/three.js/pull/6851.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/6851","number":6851,"state":"open","locked":false,"title":"Update Object3D.MatrixWorld to always be up to date ","user":{"login":"gero3","id":155535,"avatar_url":"https://avatars.githubusercontent.com/u/155535?v=3","gravatar_id":"","url":"https://api.github.com/users/gero3","html_url":"https://github.com/gero3","followers_url":"https://api.github.com/users/gero3/followers","following_url":"https://api.github.com/users/gero3/following{/other_user}","gists_url":"https://api.github.com/users/gero3/gists{/gist_id}","starred_url":"https://api.github.com/users/gero3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gero3/subscriptions","organizations_url":"https://api.github.com/users/gero3/orgs","repos_url":"https://api.github.com/users/gero3/repos","events_url":"https://api.github.com/users/gero3/events{/privacy}","received_events_url":"https://api.github.com/users/gero3/received_events","type":"User","site_admin":false},"body":"I dislike this one more then the previous one #6448 becuase now we have to maintain how to calculate matrixWorld in 2 different places:\r\n- The get of MatrixWorld \r\n- The function UpdateMatrixWorld ","created_at":"2015-07-16T11:13:11Z","updated_at":"2015-07-24T07:01:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59f99d9ea52007a86f6931247319ca7e1a0aae80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/6851/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/6851/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/6851/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/5ea84fcc3a7983bf650938c1a9b44d3496df21c0","head":{"label":"gero3:MatrixWorld","ref":"MatrixWorld","sha":"5ea84fcc3a7983bf650938c1a9b44d3496df21c0","user":{"login":"gero3","id":155535,"avatar_url":"https://avatars.githubusercontent.com/u/155535?v=3","gravatar_id":"","url":"https://api.github.com/users/gero3","html_url":"https://github.com/gero3","followers_url":"https://api.github.com/users/gero3/followers","following_url":"https://api.github.com/users/gero3/following{/other_user}","gists_url":"https://api.github.com/users/gero3/gists{/gist_id}","starred_url":"https://api.github.com/users/gero3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gero3/subscriptions","organizations_url":"https://api.github.com/users/gero3/orgs","repos_url":"https://api.github.com/users/gero3/repos","events_url":"https://api.github.com/users/gero3/events{/privacy}","received_events_url":"https://api.github.com/users/gero3/received_events","type":"User","site_admin":false},"repo":{"id":3983550,"name":"three.js","full_name":"gero3/three.js","owner":{"login":"gero3","id":155535,"avatar_url":"https://avatars.githubusercontent.com/u/155535?v=3","gravatar_id":"","url":"https://api.github.com/users/gero3","html_url":"https://github.com/gero3","followers_url":"https://api.github.com/users/gero3/followers","following_url":"https://api.github.com/users/gero3/following{/other_user}","gists_url":"https://api.github.com/users/gero3/gists{/gist_id}","starred_url":"https://api.github.com/users/gero3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gero3/subscriptions","organizations_url":"https://api.github.com/users/gero3/orgs","repos_url":"https://api.github.com/users/gero3/repos","events_url":"https://api.github.com/users/gero3/events{/privacy}","received_events_url":"https://api.github.com/users/gero3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gero3/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/gero3/three.js","forks_url":"https://api.github.com/repos/gero3/three.js/forks","keys_url":"https://api.github.com/repos/gero3/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gero3/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gero3/three.js/teams","hooks_url":"https://api.github.com/repos/gero3/three.js/hooks","issue_events_url":"https://api.github.com/repos/gero3/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/gero3/three.js/events","assignees_url":"https://api.github.com/repos/gero3/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/gero3/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/gero3/three.js/tags","blobs_url":"https://api.github.com/repos/gero3/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gero3/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gero3/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gero3/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gero3/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/gero3/three.js/languages","stargazers_url":"https://api.github.com/repos/gero3/three.js/stargazers","contributors_url":"https://api.github.com/repos/gero3/three.js/contributors","subscribers_url":"https://api.github.com/repos/gero3/three.js/subscribers","subscription_url":"https://api.github.com/repos/gero3/three.js/subscription","commits_url":"https://api.github.com/repos/gero3/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gero3/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gero3/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gero3/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/gero3/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/gero3/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gero3/three.js/merges","archive_url":"https://api.github.com/repos/gero3/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gero3/three.js/downloads","issues_url":"https://api.github.com/repos/gero3/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/gero3/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/gero3/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/gero3/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gero3/three.js/labels{/name}","releases_url":"https://api.github.com/repos/gero3/three.js/releases{/id}","created_at":"2012-04-10T15:05:30Z","updated_at":"2015-01-03T12:48:51Z","pushed_at":"2015-07-23T11:03:36Z","git_url":"git://github.com/gero3/three.js.git","ssh_url":"git@github.com:gero3/three.js.git","clone_url":"https://github.com/gero3/three.js.git","svn_url":"https://github.com/gero3/three.js","homepage":"http://mrdoob.github.com/three.js/","size":318217,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"acce472070159093101e8358f60cd54021445301","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","created_at":"2010-03-23T18:58:01Z","updated_at":"2015-07-24T03:13:14Z","pushed_at":"2015-07-24T00:53:47Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":385889,"stargazers_count":20420,"watchers_count":20420,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":6203,"mirror_url":null,"open_issues_count":793,"forks":6203,"open_issues":793,"watchers":20420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/6851"},"html":{"href":"https://github.com/mrdoob/three.js/pull/6851"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/6851"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/6851/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/6851/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/6851/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/5ea84fcc3a7983bf650938c1a9b44d3496df21c0"}}}}