{"action":"created","comment":{"url":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/47953009","id":47953009,"diff_hunk":"@@ -8,6 +9,7 @@\n import com.google.inject.Scopes;\n import com.google.inject.Singleton;\n import com.google.inject.name.Named;\n+import com.hubspot.singularity.SingularityTaskRequest;","path":"SingularityService/src/main/java/com/hubspot/singularity/mesos/SingularityMesosModule.java","position":11,"original_position":11,"commit_id":"1eda7543a1b1d67fdb72b379b97e8f987ca1a4af","original_commit_id":"1eda7543a1b1d67fdb72b379b97e8f987ca1a4af","user":{"login":"wsorenson","id":281687,"avatar_url":"https://avatars.githubusercontent.com/u/281687?v=3","gravatar_id":"","url":"https://api.github.com/users/wsorenson","html_url":"https://github.com/wsorenson","followers_url":"https://api.github.com/users/wsorenson/followers","following_url":"https://api.github.com/users/wsorenson/following{/other_user}","gists_url":"https://api.github.com/users/wsorenson/gists{/gist_id}","starred_url":"https://api.github.com/users/wsorenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsorenson/subscriptions","organizations_url":"https://api.github.com/users/wsorenson/orgs","repos_url":"https://api.github.com/users/wsorenson/repos","events_url":"https://api.github.com/users/wsorenson/events{/privacy}","received_events_url":"https://api.github.com/users/wsorenson/received_events","type":"User","site_admin":false},"body":"Are these unused imports?","created_at":"2015-12-17T19:56:36Z","updated_at":"2015-12-17T19:56:36Z","html_url":"https://github.com/HubSpot/Singularity/pull/747#discussion_r47953009","pull_request_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/747","_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/47953009"},"html":{"href":"https://github.com/HubSpot/Singularity/pull/747#discussion_r47953009"},"pull_request":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/747"}}},"pull_request":{"url":"https://api.github.com/repos/HubSpot/Singularity/pulls/747","id":49968564,"html_url":"https://github.com/HubSpot/Singularity/pull/747","diff_url":"https://github.com/HubSpot/Singularity/pull/747.diff","patch_url":"https://github.com/HubSpot/Singularity/pull/747.patch","issue_url":"https://api.github.com/repos/HubSpot/Singularity/issues/747","number":747,"state":"open","locked":false,"title":"Attribute placement","user":{"login":"ssalinas","id":6034439,"avatar_url":"https://avatars.githubusercontent.com/u/6034439?v=3","gravatar_id":"","url":"https://api.github.com/users/ssalinas","html_url":"https://github.com/ssalinas","followers_url":"https://api.github.com/users/ssalinas/followers","following_url":"https://api.github.com/users/ssalinas/following{/other_user}","gists_url":"https://api.github.com/users/ssalinas/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalinas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalinas/subscriptions","organizations_url":"https://api.github.com/users/ssalinas/orgs","repos_url":"https://api.github.com/users/ssalinas/repos","events_url":"https://api.github.com/users/ssalinas/events{/privacy}","received_events_url":"https://api.github.com/users/ssalinas/received_events","type":"User","site_admin":false},"body":"Going to complete this a bit more and add some better messaging so we can know when/why tasks might be/not be getting placed. Maybe along the lines of something that will help solve #636 as well\r\n\r\nOverall adds a few things:\r\n- Singularity will keep track of all attributes for a slave, not just rack\r\n- you can reserve slaves with certain attributes (i.e. only run tasks that request them on those slaves)\r\n- you can have tasks only run on salves that match the attributes they request\r\n- added unmatched offer information to the pending task json so we can see why a task might not be getting launched","created_at":"2015-11-06T15:45:21Z","updated_at":"2015-12-17T19:56:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7526538bd5c35164fc20d4235b3fd606ede2ea98","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/747/commits","review_comments_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/747/comments","review_comment_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/issues/747/comments","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/1eda7543a1b1d67fdb72b379b97e8f987ca1a4af","head":{"label":"HubSpot:attribute_placement","ref":"attribute_placement","sha":"1eda7543a1b1d67fdb72b379b97e8f987ca1a4af","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":13631804,"name":"Singularity","full_name":"HubSpot/Singularity","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Singularity","description":"Scheduler (HTTP API and webapp) for running mesos tasks—long running processes, one-off tasks, and scheduled jobs. #hubspot-open-source","fork":false,"url":"https://api.github.com/repos/HubSpot/Singularity","forks_url":"https://api.github.com/repos/HubSpot/Singularity/forks","keys_url":"https://api.github.com/repos/HubSpot/Singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Singularity/teams","hooks_url":"https://api.github.com/repos/HubSpot/Singularity/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Singularity/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Singularity/events","assignees_url":"https://api.github.com/repos/HubSpot/Singularity/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Singularity/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Singularity/tags","blobs_url":"https://api.github.com/repos/HubSpot/Singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Singularity/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Singularity/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Singularity/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Singularity/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Singularity/subscription","commits_url":"https://api.github.com/repos/HubSpot/Singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Singularity/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Singularity/merges","archive_url":"https://api.github.com/repos/HubSpot/Singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Singularity/downloads","issues_url":"https://api.github.com/repos/HubSpot/Singularity/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Singularity/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Singularity/releases{/id}","created_at":"2013-10-16T21:28:49Z","updated_at":"2015-12-14T03:45:26Z","pushed_at":"2015-12-17T19:37:48Z","git_url":"git://github.com/HubSpot/Singularity.git","ssh_url":"git@github.com:HubSpot/Singularity.git","clone_url":"https://github.com/HubSpot/Singularity.git","svn_url":"https://github.com/HubSpot/Singularity","homepage":"https://github.com/HubSpot/Singularity","size":26096,"stargazers_count":450,"watchers_count":450,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"open_issues_count":57,"forks":68,"open_issues":57,"watchers":450,"default_branch":"master"}},"base":{"label":"HubSpot:master","ref":"master","sha":"48b93351085b8d3b7af32b23e58d09213585c0ff","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":13631804,"name":"Singularity","full_name":"HubSpot/Singularity","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Singularity","description":"Scheduler (HTTP API and webapp) for running mesos tasks—long running processes, one-off tasks, and scheduled jobs. #hubspot-open-source","fork":false,"url":"https://api.github.com/repos/HubSpot/Singularity","forks_url":"https://api.github.com/repos/HubSpot/Singularity/forks","keys_url":"https://api.github.com/repos/HubSpot/Singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Singularity/teams","hooks_url":"https://api.github.com/repos/HubSpot/Singularity/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Singularity/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Singularity/events","assignees_url":"https://api.github.com/repos/HubSpot/Singularity/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Singularity/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Singularity/tags","blobs_url":"https://api.github.com/repos/HubSpot/Singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Singularity/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Singularity/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Singularity/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Singularity/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Singularity/subscription","commits_url":"https://api.github.com/repos/HubSpot/Singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Singularity/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Singularity/merges","archive_url":"https://api.github.com/repos/HubSpot/Singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Singularity/downloads","issues_url":"https://api.github.com/repos/HubSpot/Singularity/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Singularity/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Singularity/releases{/id}","created_at":"2013-10-16T21:28:49Z","updated_at":"2015-12-14T03:45:26Z","pushed_at":"2015-12-17T19:37:48Z","git_url":"git://github.com/HubSpot/Singularity.git","ssh_url":"git@github.com:HubSpot/Singularity.git","clone_url":"https://github.com/HubSpot/Singularity.git","svn_url":"https://github.com/HubSpot/Singularity","homepage":"https://github.com/HubSpot/Singularity","size":26096,"stargazers_count":450,"watchers_count":450,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":68,"mirror_url":null,"open_issues_count":57,"forks":68,"open_issues":57,"watchers":450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/747"},"html":{"href":"https://github.com/HubSpot/Singularity/pull/747"},"issue":{"href":"https://api.github.com/repos/HubSpot/Singularity/issues/747"},"comments":{"href":"https://api.github.com/repos/HubSpot/Singularity/issues/747/comments"},"review_comments":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/747/comments"},"review_comment":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/747/commits"},"statuses":{"href":"https://api.github.com/repos/HubSpot/Singularity/statuses/1eda7543a1b1d67fdb72b379b97e8f987ca1a4af"}}}}