{"action":"created","issue":{"url":"https://api.github.com/repos/iojs/io.js/issues/1193","labels_url":"https://api.github.com/repos/iojs/io.js/issues/1193/labels{/name}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/1193/comments","events_url":"https://api.github.com/repos/iojs/io.js/issues/1193/events","html_url":"https://github.com/iojs/io.js/issues/1193","id":62793351,"number":1193,"title":"src: add c++ test coverage","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/iojs/io.js/labels/c++","name":"c++","color":"e11d21"},{"url":"https://api.github.com/repos/iojs/io.js/labels/test","name":"test","color":"990099"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-03-18T20:37:38Z","updated_at":"2015-03-19T17:56:46Z","closed_at":null,"body":"Meta-issue for something that was discussed in today's TC meeting: test coverage for C++ code that is only tested indirectly now.\r\n\r\nStrawman proposal: bundle [gtest](https://code.google.com/p/googletest/), make it part of `make test` and start churning out `src/*_unittest.cc` tests like chromium has.\r\n\r\nProblem: most of the code in src/ is not very modular right now.  Turning it into something that is easily testable will no doubt create a lot of churn.  Probably unavoidable but it's acceptable to me.\r\n\r\n/cc @indutny @piscisaureus @trevnorris - if we can get some consensus on this, I volunteer to do the initial work."},"comment":{"url":"https://api.github.com/repos/iojs/io.js/issues/comments/83694187","html_url":"https://github.com/iojs/io.js/issues/1193#issuecomment-83694187","issue_url":"https://api.github.com/repos/iojs/io.js/issues/1193","id":83694187,"user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"created_at":"2015-03-19T17:56:46Z","updated_at":"2015-03-19T17:56:46Z","body":"Not right away but it could, longer term.  Not the part of `make test-addon` that scrapes the API documentation, though."}}