{"action":"created","comment":{"url":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/comments/32885898","id":32885898,"diff_hunk":"@@ -0,0 +1,2 @@\n+#! /usr/bin/env bash\n+python -m unittest discover --start-directory tests","path":"tests/run","position":2,"original_position":2,"commit_id":"7b1f2c4d3ee1de342a7b936043289afeecbe7bfd","original_commit_id":"7b1f2c4d3ee1de342a7b936043289afeecbe7bfd","user":{"login":"geokala","id":8859114,"avatar_url":"https://avatars.githubusercontent.com/u/8859114?v=3","gravatar_id":"","url":"https://api.github.com/users/geokala","html_url":"https://github.com/geokala","followers_url":"https://api.github.com/users/geokala/followers","following_url":"https://api.github.com/users/geokala/following{/other_user}","gists_url":"https://api.github.com/users/geokala/gists{/gist_id}","starred_url":"https://api.github.com/users/geokala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geokala/subscriptions","organizations_url":"https://api.github.com/users/geokala/orgs","repos_url":"https://api.github.com/users/geokala/repos","events_url":"https://api.github.com/users/geokala/events{/privacy}","received_events_url":"https://api.github.com/users/geokala/received_events","type":"User","site_admin":false},"body":"So the 'Closes #x' should be in the description for the commit message?","created_at":"2015-06-20T16:39:32Z","updated_at":"2015-06-20T16:39:32Z","html_url":"https://github.com/london-python-project-nights/romaine/pull/13#discussion_r32885898","pull_request_url":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/comments/32885898"},"html":{"href":"https://github.com/london-python-project-nights/romaine/pull/13#discussion_r32885898"},"pull_request":{"href":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/13","id":38129192,"html_url":"https://github.com/london-python-project-nights/romaine/pull/13","diff_url":"https://github.com/london-python-project-nights/romaine/pull/13.diff","patch_url":"https://github.com/london-python-project-nights/romaine/pull/13.patch","issue_url":"https://api.github.com/repos/london-python-project-nights/romaine/issues/13","number":13,"state":"open","locked":false,"title":"Features/001 Locate features","user":{"login":"geokala","id":8859114,"avatar_url":"https://avatars.githubusercontent.com/u/8859114?v=3","gravatar_id":"","url":"https://api.github.com/users/geokala","html_url":"https://github.com/geokala","followers_url":"https://api.github.com/users/geokala/followers","following_url":"https://api.github.com/users/geokala/following{/other_user}","gists_url":"https://api.github.com/users/geokala/gists{/gist_id}","starred_url":"https://api.github.com/users/geokala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geokala/subscriptions","organizations_url":"https://api.github.com/users/geokala/orgs","repos_url":"https://api.github.com/users/geokala/repos","events_url":"https://api.github.com/users/geokala/events{/privacy}","received_events_url":"https://api.github.com/users/geokala/received_events","type":"User","site_admin":false},"body":"#1 Add feature finding\r\n\r\n``` gherkin\r\nGiven that I have features in a path\r\nWhen I locate features\r\nThen my core has a feature list\r\n```\r\n\r\nNew PR created to work around merge conflicts.\r\n\r\nRegarding whether to put this into core or break it out into its own lib, I think we should keep it in core and only break it out if core becomes unwieldy.\r\n\r\nWhat was your grievance with os.walk? I can't see a better way to do it at the moment without basically reimplementing os.walk in a way that will probably be less readable and have more bugs.\r\n\r\nI'm going to create a separate issue for improving tests as there are a couple of irksome points I want to address with them.","created_at":"2015-06-19T17:24:23Z","updated_at":"2015-06-20T16:39:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5188eabdd1a27876d937048d65544651e67ab88f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/13/commits","review_comments_url":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/13/comments","review_comment_url":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/london-python-project-nights/romaine/issues/13/comments","statuses_url":"https://api.github.com/repos/london-python-project-nights/romaine/statuses/7b1f2c4d3ee1de342a7b936043289afeecbe7bfd","head":{"label":"geokala:feature_locate","ref":"feature_locate","sha":"7b1f2c4d3ee1de342a7b936043289afeecbe7bfd","user":{"login":"geokala","id":8859114,"avatar_url":"https://avatars.githubusercontent.com/u/8859114?v=3","gravatar_id":"","url":"https://api.github.com/users/geokala","html_url":"https://github.com/geokala","followers_url":"https://api.github.com/users/geokala/followers","following_url":"https://api.github.com/users/geokala/following{/other_user}","gists_url":"https://api.github.com/users/geokala/gists{/gist_id}","starred_url":"https://api.github.com/users/geokala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geokala/subscriptions","organizations_url":"https://api.github.com/users/geokala/orgs","repos_url":"https://api.github.com/users/geokala/repos","events_url":"https://api.github.com/users/geokala/events{/privacy}","received_events_url":"https://api.github.com/users/geokala/received_events","type":"User","site_admin":false},"repo":{"id":36032414,"name":"romaine","full_name":"geokala/romaine","owner":{"login":"geokala","id":8859114,"avatar_url":"https://avatars.githubusercontent.com/u/8859114?v=3","gravatar_id":"","url":"https://api.github.com/users/geokala","html_url":"https://github.com/geokala","followers_url":"https://api.github.com/users/geokala/followers","following_url":"https://api.github.com/users/geokala/following{/other_user}","gists_url":"https://api.github.com/users/geokala/gists{/gist_id}","starred_url":"https://api.github.com/users/geokala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geokala/subscriptions","organizations_url":"https://api.github.com/users/geokala/orgs","repos_url":"https://api.github.com/users/geokala/repos","events_url":"https://api.github.com/users/geokala/events{/privacy}","received_events_url":"https://api.github.com/users/geokala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geokala/romaine","description":"","fork":true,"url":"https://api.github.com/repos/geokala/romaine","forks_url":"https://api.github.com/repos/geokala/romaine/forks","keys_url":"https://api.github.com/repos/geokala/romaine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geokala/romaine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geokala/romaine/teams","hooks_url":"https://api.github.com/repos/geokala/romaine/hooks","issue_events_url":"https://api.github.com/repos/geokala/romaine/issues/events{/number}","events_url":"https://api.github.com/repos/geokala/romaine/events","assignees_url":"https://api.github.com/repos/geokala/romaine/assignees{/user}","branches_url":"https://api.github.com/repos/geokala/romaine/branches{/branch}","tags_url":"https://api.github.com/repos/geokala/romaine/tags","blobs_url":"https://api.github.com/repos/geokala/romaine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geokala/romaine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geokala/romaine/git/refs{/sha}","trees_url":"https://api.github.com/repos/geokala/romaine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geokala/romaine/statuses/{sha}","languages_url":"https://api.github.com/repos/geokala/romaine/languages","stargazers_url":"https://api.github.com/repos/geokala/romaine/stargazers","contributors_url":"https://api.github.com/repos/geokala/romaine/contributors","subscribers_url":"https://api.github.com/repos/geokala/romaine/subscribers","subscription_url":"https://api.github.com/repos/geokala/romaine/subscription","commits_url":"https://api.github.com/repos/geokala/romaine/commits{/sha}","git_commits_url":"https://api.github.com/repos/geokala/romaine/git/commits{/sha}","comments_url":"https://api.github.com/repos/geokala/romaine/comments{/number}","issue_comment_url":"https://api.github.com/repos/geokala/romaine/issues/comments{/number}","contents_url":"https://api.github.com/repos/geokala/romaine/contents/{+path}","compare_url":"https://api.github.com/repos/geokala/romaine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geokala/romaine/merges","archive_url":"https://api.github.com/repos/geokala/romaine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geokala/romaine/downloads","issues_url":"https://api.github.com/repos/geokala/romaine/issues{/number}","pulls_url":"https://api.github.com/repos/geokala/romaine/pulls{/number}","milestones_url":"https://api.github.com/repos/geokala/romaine/milestones{/number}","notifications_url":"https://api.github.com/repos/geokala/romaine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geokala/romaine/labels{/name}","releases_url":"https://api.github.com/repos/geokala/romaine/releases{/id}","created_at":"2015-05-21T19:13:27Z","updated_at":"2015-06-18T19:54:05Z","pushed_at":"2015-06-20T15:16:12Z","git_url":"git://github.com/geokala/romaine.git","ssh_url":"git@github.com:geokala/romaine.git","clone_url":"https://github.com/geokala/romaine.git","svn_url":"https://github.com/geokala/romaine","homepage":null,"size":79,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"london-python-project-nights:develop","ref":"develop","sha":"29bc13dfc57ff582b5c613024bb863824e55c3f2","user":{"login":"london-python-project-nights","id":11900441,"avatar_url":"https://avatars.githubusercontent.com/u/11900441?v=3","gravatar_id":"","url":"https://api.github.com/users/london-python-project-nights","html_url":"https://github.com/london-python-project-nights","followers_url":"https://api.github.com/users/london-python-project-nights/followers","following_url":"https://api.github.com/users/london-python-project-nights/following{/other_user}","gists_url":"https://api.github.com/users/london-python-project-nights/gists{/gist_id}","starred_url":"https://api.github.com/users/london-python-project-nights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/london-python-project-nights/subscriptions","organizations_url":"https://api.github.com/users/london-python-project-nights/orgs","repos_url":"https://api.github.com/users/london-python-project-nights/repos","events_url":"https://api.github.com/users/london-python-project-nights/events{/privacy}","received_events_url":"https://api.github.com/users/london-python-project-nights/received_events","type":"Organization","site_admin":false},"repo":{"id":36028029,"name":"romaine","full_name":"london-python-project-nights/romaine","owner":{"login":"london-python-project-nights","id":11900441,"avatar_url":"https://avatars.githubusercontent.com/u/11900441?v=3","gravatar_id":"","url":"https://api.github.com/users/london-python-project-nights","html_url":"https://github.com/london-python-project-nights","followers_url":"https://api.github.com/users/london-python-project-nights/followers","following_url":"https://api.github.com/users/london-python-project-nights/following{/other_user}","gists_url":"https://api.github.com/users/london-python-project-nights/gists{/gist_id}","starred_url":"https://api.github.com/users/london-python-project-nights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/london-python-project-nights/subscriptions","organizations_url":"https://api.github.com/users/london-python-project-nights/orgs","repos_url":"https://api.github.com/users/london-python-project-nights/repos","events_url":"https://api.github.com/users/london-python-project-nights/events{/privacy}","received_events_url":"https://api.github.com/users/london-python-project-nights/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/london-python-project-nights/romaine","description":"","fork":false,"url":"https://api.github.com/repos/london-python-project-nights/romaine","forks_url":"https://api.github.com/repos/london-python-project-nights/romaine/forks","keys_url":"https://api.github.com/repos/london-python-project-nights/romaine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/london-python-project-nights/romaine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/london-python-project-nights/romaine/teams","hooks_url":"https://api.github.com/repos/london-python-project-nights/romaine/hooks","issue_events_url":"https://api.github.com/repos/london-python-project-nights/romaine/issues/events{/number}","events_url":"https://api.github.com/repos/london-python-project-nights/romaine/events","assignees_url":"https://api.github.com/repos/london-python-project-nights/romaine/assignees{/user}","branches_url":"https://api.github.com/repos/london-python-project-nights/romaine/branches{/branch}","tags_url":"https://api.github.com/repos/london-python-project-nights/romaine/tags","blobs_url":"https://api.github.com/repos/london-python-project-nights/romaine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/london-python-project-nights/romaine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/london-python-project-nights/romaine/git/refs{/sha}","trees_url":"https://api.github.com/repos/london-python-project-nights/romaine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/london-python-project-nights/romaine/statuses/{sha}","languages_url":"https://api.github.com/repos/london-python-project-nights/romaine/languages","stargazers_url":"https://api.github.com/repos/london-python-project-nights/romaine/stargazers","contributors_url":"https://api.github.com/repos/london-python-project-nights/romaine/contributors","subscribers_url":"https://api.github.com/repos/london-python-project-nights/romaine/subscribers","subscription_url":"https://api.github.com/repos/london-python-project-nights/romaine/subscription","commits_url":"https://api.github.com/repos/london-python-project-nights/romaine/commits{/sha}","git_commits_url":"https://api.github.com/repos/london-python-project-nights/romaine/git/commits{/sha}","comments_url":"https://api.github.com/repos/london-python-project-nights/romaine/comments{/number}","issue_comment_url":"https://api.github.com/repos/london-python-project-nights/romaine/issues/comments{/number}","contents_url":"https://api.github.com/repos/london-python-project-nights/romaine/contents/{+path}","compare_url":"https://api.github.com/repos/london-python-project-nights/romaine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/london-python-project-nights/romaine/merges","archive_url":"https://api.github.com/repos/london-python-project-nights/romaine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/london-python-project-nights/romaine/downloads","issues_url":"https://api.github.com/repos/london-python-project-nights/romaine/issues{/number}","pulls_url":"https://api.github.com/repos/london-python-project-nights/romaine/pulls{/number}","milestones_url":"https://api.github.com/repos/london-python-project-nights/romaine/milestones{/number}","notifications_url":"https://api.github.com/repos/london-python-project-nights/romaine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/london-python-project-nights/romaine/labels{/name}","releases_url":"https://api.github.com/repos/london-python-project-nights/romaine/releases{/id}","created_at":"2015-05-21T17:42:47Z","updated_at":"2015-06-20T14:59:02Z","pushed_at":"2015-06-20T15:16:12Z","git_url":"git://github.com/london-python-project-nights/romaine.git","ssh_url":"git@github.com:london-python-project-nights/romaine.git","clone_url":"https://github.com/london-python-project-nights/romaine.git","svn_url":"https://github.com/london-python-project-nights/romaine","homepage":null,"size":124,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/13"},"html":{"href":"https://github.com/london-python-project-nights/romaine/pull/13"},"issue":{"href":"https://api.github.com/repos/london-python-project-nights/romaine/issues/13"},"comments":{"href":"https://api.github.com/repos/london-python-project-nights/romaine/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/london-python-project-nights/romaine/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/london-python-project-nights/romaine/statuses/7b1f2c4d3ee1de342a7b936043289afeecbe7bfd"}}}}