{"action":"created","issue":{"url":"https://api.github.com/repos/carllerche/mio/issues/310","labels_url":"https://api.github.com/repos/carllerche/mio/issues/310/labels{/name}","comments_url":"https://api.github.com/repos/carllerche/mio/issues/310/comments","events_url":"https://api.github.com/repos/carllerche/mio/issues/310/events","html_url":"https://github.com/carllerche/mio/pull/310","id":118953560,"number":310,"title":"Mark socket impl types on Windows as Send","user":{"login":"carllerche","id":6180,"avatar_url":"https://avatars.githubusercontent.com/u/6180?v=3","gravatar_id":"","url":"https://api.github.com/users/carllerche","html_url":"https://github.com/carllerche","followers_url":"https://api.github.com/users/carllerche/followers","following_url":"https://api.github.com/users/carllerche/following{/other_user}","gists_url":"https://api.github.com/users/carllerche/gists{/gist_id}","starred_url":"https://api.github.com/users/carllerche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllerche/subscriptions","organizations_url":"https://api.github.com/users/carllerche/orgs","repos_url":"https://api.github.com/users/carllerche/repos","events_url":"https://api.github.com/users/carllerche/events{/privacy}","received_events_url":"https://api.github.com/users/carllerche/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/carllerche/mio/milestones/3","html_url":"https://github.com/carllerche/mio/milestones/v0.5.0","labels_url":"https://api.github.com/repos/carllerche/mio/milestones/3/labels","id":1425735,"number":3,"title":"v0.5.0","description":"Initial release with windows support.","creator":{"login":"carllerche","id":6180,"avatar_url":"https://avatars.githubusercontent.com/u/6180?v=3","gravatar_id":"","url":"https://api.github.com/users/carllerche","html_url":"https://github.com/carllerche","followers_url":"https://api.github.com/users/carllerche/followers","following_url":"https://api.github.com/users/carllerche/following{/other_user}","gists_url":"https://api.github.com/users/carllerche/gists{/gist_id}","starred_url":"https://api.github.com/users/carllerche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllerche/subscriptions","organizations_url":"https://api.github.com/users/carllerche/orgs","repos_url":"https://api.github.com/users/carllerche/repos","events_url":"https://api.github.com/users/carllerche/events{/privacy}","received_events_url":"https://api.github.com/users/carllerche/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":1,"state":"open","created_at":"2015-11-23T18:25:09Z","updated_at":"2015-11-26T01:44:55Z","due_on":"2015-12-03T08:00:00Z","closed_at":null},"comments":6,"created_at":"2015-11-26T01:34:48Z","updated_at":"2015-11-29T19:32:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/carllerche/mio/pulls/310","html_url":"https://github.com/carllerche/mio/pull/310","diff_url":"https://github.com/carllerche/mio/pull/310.diff","patch_url":"https://github.com/carllerche/mio/pull/310.patch"},"body":"Closes #292\r\n\r\nThe implementations are thread safe however since they use `UnsafeCell`, they\r\nneed to explicitly implement `Send`.\r\n\r\nI visually inspected the code to make sure that the types are sendable. I don't know if there is a good way to test it.\r\n\r\ncc/ @alexcrichton "},"comment":{"url":"https://api.github.com/repos/carllerche/mio/issues/comments/160455335","html_url":"https://github.com/carllerche/mio/pull/310#issuecomment-160455335","issue_url":"https://api.github.com/repos/carllerche/mio/issues/310","id":160455335,"user":{"login":"carllerche","id":6180,"avatar_url":"https://avatars.githubusercontent.com/u/6180?v=3","gravatar_id":"","url":"https://api.github.com/users/carllerche","html_url":"https://github.com/carllerche","followers_url":"https://api.github.com/users/carllerche/followers","following_url":"https://api.github.com/users/carllerche/following{/other_user}","gists_url":"https://api.github.com/users/carllerche/gists{/gist_id}","starred_url":"https://api.github.com/users/carllerche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllerche/subscriptions","organizations_url":"https://api.github.com/users/carllerche/orgs","repos_url":"https://api.github.com/users/carllerche/repos","events_url":"https://api.github.com/users/carllerche/events{/privacy}","received_events_url":"https://api.github.com/users/carllerche/received_events","type":"User","site_admin":false},"created_at":"2015-11-29T19:32:31Z","updated_at":"2015-11-29T19:32:31Z","body":">  I would perhaps prefer to make that interface `unsafe`\r\n\r\nNot following this. Which interface?"}}