{"action":"created","comment":{"url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/comments/38813519","id":38813519,"diff_hunk":"@@ -71,49 +72,38 @@ class MemConnectionSpec extends WordSpec with Matchers with BeforeAndAfterAll wi\n     }\n     \"fail to create a doc if it already exists\" in {\n       val testCreate = createDoc(k, newvalue)\n-      val (data, res) = MemConnection.run(testCreate, seedData)\n-      res should be(left)\n+      MemConnection.run(testCreate, seedData)._2 should be(left)\n     }\n     \"update a doc that exists with correct hashver\" in {\n       val testUpdate = updateDoc(k, newvalue, hv)\n       val (data, res) = MemConnection.run(testUpdate, seedData)\n-      res should be(right)\n       data.get(k) should ===(Some(newvalue))\n     }\n     \"fail updating a doc that doesn't exist\" in {\n       val testUpdate = updateDoc(k, newvalue, hv)\n-      val (data, res) = MemConnection.run(testUpdate)\n-      res should be(left)\n-      data should ===(emptyData)\n+      MemConnection.run(testUpdate)._2 should be(left)","path":"src/test/scala/com/ironcorelabs/davenport/MemConnectionSpec.scala","position":49,"original_position":49,"commit_id":"1f534220f97fe998c123eca14a1ca8a1ce0a808b","original_commit_id":"1f534220f97fe998c123eca14a1ca8a1ce0a808b","user":{"login":"zmre","id":71791,"avatar_url":"https://avatars.githubusercontent.com/u/71791?v=3","gravatar_id":"","url":"https://api.github.com/users/zmre","html_url":"https://github.com/zmre","followers_url":"https://api.github.com/users/zmre/followers","following_url":"https://api.github.com/users/zmre/following{/other_user}","gists_url":"https://api.github.com/users/zmre/gists{/gist_id}","starred_url":"https://api.github.com/users/zmre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmre/subscriptions","organizations_url":"https://api.github.com/users/zmre/orgs","repos_url":"https://api.github.com/users/zmre/repos","events_url":"https://api.github.com/users/zmre/events{/privacy}","received_events_url":"https://api.github.com/users/zmre/received_events","type":"User","site_admin":false},"body":"if we're only going to look at the result and not check the resulting map, then might as well call `.apply` instead of `.run` and avoid the `._2`.  i kind of liked verifying that the result map was what i expected though.","created_at":"2015-09-05T18:38:24Z","updated_at":"2015-09-05T18:38:24Z","html_url":"https://github.com/IronCoreLabs/davenport/pull/4#discussion_r38813519","pull_request_url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/comments/38813519"},"html":{"href":"https://github.com/IronCoreLabs/davenport/pull/4#discussion_r38813519"},"pull_request":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/4","id":44285460,"html_url":"https://github.com/IronCoreLabs/davenport/pull/4","diff_url":"https://github.com/IronCoreLabs/davenport/pull/4.diff","patch_url":"https://github.com/IronCoreLabs/davenport/pull/4.patch","issue_url":"https://api.github.com/repos/IronCoreLabs/davenport/issues/4","number":4,"state":"open","locked":false,"title":"Use Scalaz.stream for batch imports","user":{"login":"coltfred","id":587319,"avatar_url":"https://avatars.githubusercontent.com/u/587319?v=3","gravatar_id":"","url":"https://api.github.com/users/coltfred","html_url":"https://github.com/coltfred","followers_url":"https://api.github.com/users/coltfred/followers","following_url":"https://api.github.com/users/coltfred/following{/other_user}","gists_url":"https://api.github.com/users/coltfred/gists{/gist_id}","starred_url":"https://api.github.com/users/coltfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coltfred/subscriptions","organizations_url":"https://api.github.com/users/coltfred/orgs","repos_url":"https://api.github.com/users/coltfred/repos","events_url":"https://api.github.com/users/coltfred/events{/privacy}","received_events_url":"https://api.github.com/users/coltfred/received_events","type":"User","site_admin":false},"body":"I've changed the batchImport api to use Scalaz.stream instead of iterator. Because of this I had to change MemConnection to use StateT so that we had a `Catchable` instance for the type Process is paramaterized over. I ignored errors thrown into it because the NT from DBOP ~> State will never throw. I could maybe do better there, but I think this is a step in the right direction.\r\n\r\nI'll be updating with a tut example page shortly.","created_at":"2015-09-05T16:05:49Z","updated_at":"2015-09-05T18:38:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"303ab199f27a61078faa4084e44798694d3044ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/4/commits","review_comments_url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/4/comments","review_comment_url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IronCoreLabs/davenport/issues/4/comments","statuses_url":"https://api.github.com/repos/IronCoreLabs/davenport/statuses/1f534220f97fe998c123eca14a1ca8a1ce0a808b","head":{"label":"coltfred:process","ref":"process","sha":"1f534220f97fe998c123eca14a1ca8a1ce0a808b","user":{"login":"coltfred","id":587319,"avatar_url":"https://avatars.githubusercontent.com/u/587319?v=3","gravatar_id":"","url":"https://api.github.com/users/coltfred","html_url":"https://github.com/coltfred","followers_url":"https://api.github.com/users/coltfred/followers","following_url":"https://api.github.com/users/coltfred/following{/other_user}","gists_url":"https://api.github.com/users/coltfred/gists{/gist_id}","starred_url":"https://api.github.com/users/coltfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coltfred/subscriptions","organizations_url":"https://api.github.com/users/coltfred/orgs","repos_url":"https://api.github.com/users/coltfred/repos","events_url":"https://api.github.com/users/coltfred/events{/privacy}","received_events_url":"https://api.github.com/users/coltfred/received_events","type":"User","site_admin":false},"repo":{"id":41130509,"name":"davenport","full_name":"coltfred/davenport","owner":{"login":"coltfred","id":587319,"avatar_url":"https://avatars.githubusercontent.com/u/587319?v=3","gravatar_id":"","url":"https://api.github.com/users/coltfred","html_url":"https://github.com/coltfred","followers_url":"https://api.github.com/users/coltfred/followers","following_url":"https://api.github.com/users/coltfred/following{/other_user}","gists_url":"https://api.github.com/users/coltfred/gists{/gist_id}","starred_url":"https://api.github.com/users/coltfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coltfred/subscriptions","organizations_url":"https://api.github.com/users/coltfred/orgs","repos_url":"https://api.github.com/users/coltfred/repos","events_url":"https://api.github.com/users/coltfred/events{/privacy}","received_events_url":"https://api.github.com/users/coltfred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coltfred/davenport","description":"A principled CouchBase library for Scala","fork":true,"url":"https://api.github.com/repos/coltfred/davenport","forks_url":"https://api.github.com/repos/coltfred/davenport/forks","keys_url":"https://api.github.com/repos/coltfred/davenport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coltfred/davenport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coltfred/davenport/teams","hooks_url":"https://api.github.com/repos/coltfred/davenport/hooks","issue_events_url":"https://api.github.com/repos/coltfred/davenport/issues/events{/number}","events_url":"https://api.github.com/repos/coltfred/davenport/events","assignees_url":"https://api.github.com/repos/coltfred/davenport/assignees{/user}","branches_url":"https://api.github.com/repos/coltfred/davenport/branches{/branch}","tags_url":"https://api.github.com/repos/coltfred/davenport/tags","blobs_url":"https://api.github.com/repos/coltfred/davenport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coltfred/davenport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coltfred/davenport/git/refs{/sha}","trees_url":"https://api.github.com/repos/coltfred/davenport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coltfred/davenport/statuses/{sha}","languages_url":"https://api.github.com/repos/coltfred/davenport/languages","stargazers_url":"https://api.github.com/repos/coltfred/davenport/stargazers","contributors_url":"https://api.github.com/repos/coltfred/davenport/contributors","subscribers_url":"https://api.github.com/repos/coltfred/davenport/subscribers","subscription_url":"https://api.github.com/repos/coltfred/davenport/subscription","commits_url":"https://api.github.com/repos/coltfred/davenport/commits{/sha}","git_commits_url":"https://api.github.com/repos/coltfred/davenport/git/commits{/sha}","comments_url":"https://api.github.com/repos/coltfred/davenport/comments{/number}","issue_comment_url":"https://api.github.com/repos/coltfred/davenport/issues/comments{/number}","contents_url":"https://api.github.com/repos/coltfred/davenport/contents/{+path}","compare_url":"https://api.github.com/repos/coltfred/davenport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coltfred/davenport/merges","archive_url":"https://api.github.com/repos/coltfred/davenport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coltfred/davenport/downloads","issues_url":"https://api.github.com/repos/coltfred/davenport/issues{/number}","pulls_url":"https://api.github.com/repos/coltfred/davenport/pulls{/number}","milestones_url":"https://api.github.com/repos/coltfred/davenport/milestones{/number}","notifications_url":"https://api.github.com/repos/coltfred/davenport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coltfred/davenport/labels{/name}","releases_url":"https://api.github.com/repos/coltfred/davenport/releases{/id}","created_at":"2015-08-21T02:46:20Z","updated_at":"2015-08-21T02:46:21Z","pushed_at":"2015-09-05T16:02:22Z","git_url":"git://github.com/coltfred/davenport.git","ssh_url":"git@github.com:coltfred/davenport.git","clone_url":"https://github.com/coltfred/davenport.git","svn_url":"https://github.com/coltfred/davenport","homepage":null,"size":203,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IronCoreLabs:master","ref":"master","sha":"6931e207319c572d38638f6d071101f2e65cf4de","user":{"login":"IronCoreLabs","id":11394047,"avatar_url":"https://avatars.githubusercontent.com/u/11394047?v=3","gravatar_id":"","url":"https://api.github.com/users/IronCoreLabs","html_url":"https://github.com/IronCoreLabs","followers_url":"https://api.github.com/users/IronCoreLabs/followers","following_url":"https://api.github.com/users/IronCoreLabs/following{/other_user}","gists_url":"https://api.github.com/users/IronCoreLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IronCoreLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronCoreLabs/subscriptions","organizations_url":"https://api.github.com/users/IronCoreLabs/orgs","repos_url":"https://api.github.com/users/IronCoreLabs/repos","events_url":"https://api.github.com/users/IronCoreLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IronCoreLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":41042360,"name":"davenport","full_name":"IronCoreLabs/davenport","owner":{"login":"IronCoreLabs","id":11394047,"avatar_url":"https://avatars.githubusercontent.com/u/11394047?v=3","gravatar_id":"","url":"https://api.github.com/users/IronCoreLabs","html_url":"https://github.com/IronCoreLabs","followers_url":"https://api.github.com/users/IronCoreLabs/followers","following_url":"https://api.github.com/users/IronCoreLabs/following{/other_user}","gists_url":"https://api.github.com/users/IronCoreLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/IronCoreLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IronCoreLabs/subscriptions","organizations_url":"https://api.github.com/users/IronCoreLabs/orgs","repos_url":"https://api.github.com/users/IronCoreLabs/repos","events_url":"https://api.github.com/users/IronCoreLabs/events{/privacy}","received_events_url":"https://api.github.com/users/IronCoreLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IronCoreLabs/davenport","description":"A principled CouchBase library for Scala","fork":false,"url":"https://api.github.com/repos/IronCoreLabs/davenport","forks_url":"https://api.github.com/repos/IronCoreLabs/davenport/forks","keys_url":"https://api.github.com/repos/IronCoreLabs/davenport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IronCoreLabs/davenport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IronCoreLabs/davenport/teams","hooks_url":"https://api.github.com/repos/IronCoreLabs/davenport/hooks","issue_events_url":"https://api.github.com/repos/IronCoreLabs/davenport/issues/events{/number}","events_url":"https://api.github.com/repos/IronCoreLabs/davenport/events","assignees_url":"https://api.github.com/repos/IronCoreLabs/davenport/assignees{/user}","branches_url":"https://api.github.com/repos/IronCoreLabs/davenport/branches{/branch}","tags_url":"https://api.github.com/repos/IronCoreLabs/davenport/tags","blobs_url":"https://api.github.com/repos/IronCoreLabs/davenport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IronCoreLabs/davenport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IronCoreLabs/davenport/git/refs{/sha}","trees_url":"https://api.github.com/repos/IronCoreLabs/davenport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IronCoreLabs/davenport/statuses/{sha}","languages_url":"https://api.github.com/repos/IronCoreLabs/davenport/languages","stargazers_url":"https://api.github.com/repos/IronCoreLabs/davenport/stargazers","contributors_url":"https://api.github.com/repos/IronCoreLabs/davenport/contributors","subscribers_url":"https://api.github.com/repos/IronCoreLabs/davenport/subscribers","subscription_url":"https://api.github.com/repos/IronCoreLabs/davenport/subscription","commits_url":"https://api.github.com/repos/IronCoreLabs/davenport/commits{/sha}","git_commits_url":"https://api.github.com/repos/IronCoreLabs/davenport/git/commits{/sha}","comments_url":"https://api.github.com/repos/IronCoreLabs/davenport/comments{/number}","issue_comment_url":"https://api.github.com/repos/IronCoreLabs/davenport/issues/comments{/number}","contents_url":"https://api.github.com/repos/IronCoreLabs/davenport/contents/{+path}","compare_url":"https://api.github.com/repos/IronCoreLabs/davenport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IronCoreLabs/davenport/merges","archive_url":"https://api.github.com/repos/IronCoreLabs/davenport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IronCoreLabs/davenport/downloads","issues_url":"https://api.github.com/repos/IronCoreLabs/davenport/issues{/number}","pulls_url":"https://api.github.com/repos/IronCoreLabs/davenport/pulls{/number}","milestones_url":"https://api.github.com/repos/IronCoreLabs/davenport/milestones{/number}","notifications_url":"https://api.github.com/repos/IronCoreLabs/davenport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IronCoreLabs/davenport/labels{/name}","releases_url":"https://api.github.com/repos/IronCoreLabs/davenport/releases{/id}","created_at":"2015-08-19T15:22:43Z","updated_at":"2015-08-27T04:12:40Z","pushed_at":"2015-09-05T16:05:49Z","git_url":"git://github.com/IronCoreLabs/davenport.git","ssh_url":"git@github.com:IronCoreLabs/davenport.git","clone_url":"https://github.com/IronCoreLabs/davenport.git","svn_url":"https://github.com/IronCoreLabs/davenport","homepage":"https://ironcorelabs.com/davenport","size":634,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/4"},"html":{"href":"https://github.com/IronCoreLabs/davenport/pull/4"},"issue":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/issues/4"},"comments":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/IronCoreLabs/davenport/statuses/1f534220f97fe998c123eca14a1ca8a1ce0a808b"}}}}