{"comment":{"url":"https://api.github.com/repos/killbill/killbill-plugin-framework-ruby/comments/10070651","html_url":"https://github.com/killbill/killbill-plugin-framework-ruby/commit/24427e1d5fa0a4f68dd769d8120427557c248ded#commitcomment-10070651","id":10070651,"user":{"login":"pierre","id":51940,"avatar_url":"https://avatars.githubusercontent.com/u/51940?v=3","gravatar_id":"","url":"https://api.github.com/users/pierre","html_url":"https://github.com/pierre","followers_url":"https://api.github.com/users/pierre/followers","following_url":"https://api.github.com/users/pierre/following{/other_user}","gists_url":"https://api.github.com/users/pierre/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre/subscriptions","organizations_url":"https://api.github.com/users/pierre/orgs","repos_url":"https://api.github.com/users/pierre/repos","events_url":"https://api.github.com/users/pierre/events{/privacy}","received_events_url":"https://api.github.com/users/pierre/received_events","type":"User","site_admin":false},"position":4,"line":22,"path":"generators/active_merchant/templates/spec/base_plugin_spec.rb","commit_id":"24427e1d5fa0a4f68dd769d8120427557c248ded","created_at":"2015-03-06T12:50:17Z","updated_at":"2015-03-06T12:50:17Z","body":"Maybe change it to `'/killbill-<%= identifier %>/0.0.1'`, to:\r\n\r\n* respect the actual plugin name (each generated plugin will be named  `killbill-<%= identifier %>` by default, see https://github.com/killbill/killbill-plugin-framework-ruby/blob/master/lib/killbill/rake_task.rb#L146 and https://github.com/killbill/killbill-plugin-framework-ruby/blob/master/generators/active_merchant/templates/plugin.gemspec.rb#L4)\r\n* use a real version scheme in case the code later on does some check on it (so it doesn't choke on a random string)"}}