{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/301","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/301/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/301/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/301/events","html_url":"https://github.com/TrinityCore/TrinityCore/issues/301","id":911553,"number":301,"title":"[WARLOCK] Imp Should not melee attack when OOM","user":{"login":"click","id":537477,"avatar_url":"https://avatars.githubusercontent.com/u/537477?v=3","gravatar_id":"","url":"https://api.github.com/users/click","html_url":"https://github.com/click","followers_url":"https://api.github.com/users/click/followers","following_url":"https://api.github.com/users/click/following{/other_user}","gists_url":"https://api.github.com/users/click/gists{/gist_id}","starred_url":"https://api.github.com/users/click/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/click/subscriptions","organizations_url":"https://api.github.com/users/click/orgs","repos_url":"https://api.github.com/users/click/repos","events_url":"https://api.github.com/users/click/events{/privacy}","received_events_url":"https://api.github.com/users/click/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Comp-Core","name":"Comp-Core","color":"FF6600"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Feedback-PatchFix","name":"Feedback-PatchFix","color":"d7e102"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Sub-Entities","name":"Sub-Entities","color":"e10c02"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Sub-Miscellaneous","name":"Sub-Miscellaneous","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2011-05-16T21:28:52Z","updated_at":"2015-08-22T04:25:37Z","closed_at":null,"body":"1.) Create a warlock\r\n2.) Learn Summon Imp\r\n3.) Have Imp Attack until Out of Mana\r\n\r\nObserved Result: Imp runs up to target and begins physical attack (melee) on target\r\nExpected Result: Imp should stay by your side, and wait for mana to regen, then continue casting Firebolts.\r\n\r\nVersion: 3.3.5a (12340)\r\nCore revision: Trinity Core 11032+\r\nUbuntu 64\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/66427-warlock-imp-should-not-melee-attack-when-oom?utm_campaign=plugin&utm_content=tracker%2F1310&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1310&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/133633783","html_url":"https://github.com/TrinityCore/TrinityCore/issues/301#issuecomment-133633783","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/301","id":133633783,"user":{"login":"MrSmite","id":1168404,"avatar_url":"https://avatars.githubusercontent.com/u/1168404?v=3","gravatar_id":"","url":"https://api.github.com/users/MrSmite","html_url":"https://github.com/MrSmite","followers_url":"https://api.github.com/users/MrSmite/followers","following_url":"https://api.github.com/users/MrSmite/following{/other_user}","gists_url":"https://api.github.com/users/MrSmite/gists{/gist_id}","starred_url":"https://api.github.com/users/MrSmite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrSmite/subscriptions","organizations_url":"https://api.github.com/users/MrSmite/orgs","repos_url":"https://api.github.com/users/MrSmite/repos","events_url":"https://api.github.com/users/MrSmite/events{/privacy}","received_events_url":"https://api.github.com/users/MrSmite/received_events","type":"User","site_admin":false},"created_at":"2015-08-22T04:25:37Z","updated_at":"2015-08-22T04:25:37Z","body":"Since #15289 is locked to collabs only, I thought I'd comment here...\r\n\r\nI reviewed the PR submitted by @tkrokli and it looks like it should work. In fact, as long as Hunter pets are always CLASS_WARRIOR then it should be future proof too. While my suggestion above works fine for the Imp, it doesn't cover the possibility of other mage type classes.\r\n\r\nThe only problem I could forsee is if Blizz added a hybrid melee / caster pet but that's an issue for a later date."}}