{"action":"created","comment":{"url":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/comments/36248094","id":36248094,"diff_hunk":"@@ -7,21 +7,17 @@\n     import urllib2 as request\n     from urllib2 import HTTPError\n \n+\n class YggAuth:\n-    def __init__(self, \n-        client_token=None, \n-        access_token=None, \n-        username=None, \n-        password=None\n-    ):\n+    def __init__(self, client_token=None, access_token=None, username=None,\n+                 password=None):\n         self.username = username\n         self.password = password\n         self.client_token = client_token\n \n-        self.access_token = None #validate needs self.access_token to exist\n-        self.access_token = (\n-            None if self.validate(access_token) else access_token\n-        )\n+        self.access_token = None  # validate needs self.access_token to exist\n+        self.access_token = None if self.validate(access_token) else \\","path":"spock/mcp/yggdrasil.py","position":30,"original_position":30,"commit_id":"1ad9ec81e23f25a556c85dd6a2067fb9b013ab44","original_commit_id":"b0f9d8b33f433c3d88bf81b859ddae46086bf3a8","user":{"login":"txomon","id":228250,"avatar_url":"https://avatars.githubusercontent.com/u/228250?v=3","gravatar_id":"","url":"https://api.github.com/users/txomon","html_url":"https://github.com/txomon","followers_url":"https://api.github.com/users/txomon/followers","following_url":"https://api.github.com/users/txomon/following{/other_user}","gists_url":"https://api.github.com/users/txomon/gists{/gist_id}","starred_url":"https://api.github.com/users/txomon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txomon/subscriptions","organizations_url":"https://api.github.com/users/txomon/orgs","repos_url":"https://api.github.com/users/txomon/repos","events_url":"https://api.github.com/users/txomon/events{/privacy}","received_events_url":"https://api.github.com/users/txomon/received_events","type":"User","site_admin":false},"body":"I am afraid this doesn't worth a rewrite because I will be refactoring the file. (notice that it has a double assignment of self.access_token! WTF!)","created_at":"2015-08-04T22:04:28Z","updated_at":"2015-08-04T22:04:28Z","html_url":"https://github.com/SpockBotMC/SpockBot/pull/68#discussion_r36248094","pull_request_url":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/comments/36248094"},"html":{"href":"https://github.com/SpockBotMC/SpockBot/pull/68#discussion_r36248094"},"pull_request":{"href":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/68","id":41621089,"html_url":"https://github.com/SpockBotMC/SpockBot/pull/68","diff_url":"https://github.com/SpockBotMC/SpockBot/pull/68.diff","patch_url":"https://github.com/SpockBotMC/SpockBot/pull/68.patch","issue_url":"https://api.github.com/repos/SpockBotMC/SpockBot/issues/68","number":68,"state":"open","locked":false,"title":"flake8: Making it almost happy, still have some undefined vars","user":{"login":"txomon","id":228250,"avatar_url":"https://avatars.githubusercontent.com/u/228250?v=3","gravatar_id":"","url":"https://api.github.com/users/txomon","html_url":"https://github.com/txomon","followers_url":"https://api.github.com/users/txomon/followers","following_url":"https://api.github.com/users/txomon/following{/other_user}","gists_url":"https://api.github.com/users/txomon/gists{/gist_id}","starred_url":"https://api.github.com/users/txomon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txomon/subscriptions","organizations_url":"https://api.github.com/users/txomon/orgs","repos_url":"https://api.github.com/users/txomon/repos","events_url":"https://api.github.com/users/txomon/events{/privacy}","received_events_url":"https://api.github.com/users/txomon/received_events","type":"User","site_admin":false},"body":"There are mainly 4 failures on undefined variables.\r\n\r\nThe refactor was just to make flake8 shut up, but without plugins. There should not be functionality changes. Review carefully!","created_at":"2015-08-04T21:41:25Z","updated_at":"2015-08-04T22:04:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c9efe309b35c91be5a3050c727a73ea599f3aa8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/68/commits","review_comments_url":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/68/comments","review_comment_url":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpockBotMC/SpockBot/issues/68/comments","statuses_url":"https://api.github.com/repos/SpockBotMC/SpockBot/statuses/1ad9ec81e23f25a556c85dd6a2067fb9b013ab44","head":{"label":"txomon:feature/flake8","ref":"feature/flake8","sha":"1ad9ec81e23f25a556c85dd6a2067fb9b013ab44","user":{"login":"txomon","id":228250,"avatar_url":"https://avatars.githubusercontent.com/u/228250?v=3","gravatar_id":"","url":"https://api.github.com/users/txomon","html_url":"https://github.com/txomon","followers_url":"https://api.github.com/users/txomon/followers","following_url":"https://api.github.com/users/txomon/following{/other_user}","gists_url":"https://api.github.com/users/txomon/gists{/gist_id}","starred_url":"https://api.github.com/users/txomon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txomon/subscriptions","organizations_url":"https://api.github.com/users/txomon/orgs","repos_url":"https://api.github.com/users/txomon/repos","events_url":"https://api.github.com/users/txomon/events{/privacy}","received_events_url":"https://api.github.com/users/txomon/received_events","type":"User","site_admin":false},"repo":{"id":40150713,"name":"SpockBot","full_name":"txomon/SpockBot","owner":{"login":"txomon","id":228250,"avatar_url":"https://avatars.githubusercontent.com/u/228250?v=3","gravatar_id":"","url":"https://api.github.com/users/txomon","html_url":"https://github.com/txomon","followers_url":"https://api.github.com/users/txomon/followers","following_url":"https://api.github.com/users/txomon/following{/other_user}","gists_url":"https://api.github.com/users/txomon/gists{/gist_id}","starred_url":"https://api.github.com/users/txomon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txomon/subscriptions","organizations_url":"https://api.github.com/users/txomon/orgs","repos_url":"https://api.github.com/users/txomon/repos","events_url":"https://api.github.com/users/txomon/events{/privacy}","received_events_url":"https://api.github.com/users/txomon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/txomon/SpockBot","description":"A pure python framework that implements the 1.8 Minecraft protocol for building Minecraft clients","fork":true,"url":"https://api.github.com/repos/txomon/SpockBot","forks_url":"https://api.github.com/repos/txomon/SpockBot/forks","keys_url":"https://api.github.com/repos/txomon/SpockBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/txomon/SpockBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/txomon/SpockBot/teams","hooks_url":"https://api.github.com/repos/txomon/SpockBot/hooks","issue_events_url":"https://api.github.com/repos/txomon/SpockBot/issues/events{/number}","events_url":"https://api.github.com/repos/txomon/SpockBot/events","assignees_url":"https://api.github.com/repos/txomon/SpockBot/assignees{/user}","branches_url":"https://api.github.com/repos/txomon/SpockBot/branches{/branch}","tags_url":"https://api.github.com/repos/txomon/SpockBot/tags","blobs_url":"https://api.github.com/repos/txomon/SpockBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/txomon/SpockBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/txomon/SpockBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/txomon/SpockBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/txomon/SpockBot/statuses/{sha}","languages_url":"https://api.github.com/repos/txomon/SpockBot/languages","stargazers_url":"https://api.github.com/repos/txomon/SpockBot/stargazers","contributors_url":"https://api.github.com/repos/txomon/SpockBot/contributors","subscribers_url":"https://api.github.com/repos/txomon/SpockBot/subscribers","subscription_url":"https://api.github.com/repos/txomon/SpockBot/subscription","commits_url":"https://api.github.com/repos/txomon/SpockBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/txomon/SpockBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/txomon/SpockBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/txomon/SpockBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/txomon/SpockBot/contents/{+path}","compare_url":"https://api.github.com/repos/txomon/SpockBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/txomon/SpockBot/merges","archive_url":"https://api.github.com/repos/txomon/SpockBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/txomon/SpockBot/downloads","issues_url":"https://api.github.com/repos/txomon/SpockBot/issues{/number}","pulls_url":"https://api.github.com/repos/txomon/SpockBot/pulls{/number}","milestones_url":"https://api.github.com/repos/txomon/SpockBot/milestones{/number}","notifications_url":"https://api.github.com/repos/txomon/SpockBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/txomon/SpockBot/labels{/name}","releases_url":"https://api.github.com/repos/txomon/SpockBot/releases{/id}","created_at":"2015-08-03T22:20:24Z","updated_at":"2015-08-03T22:20:24Z","pushed_at":"2015-08-04T21:54:42Z","git_url":"git://github.com/txomon/SpockBot.git","ssh_url":"git@github.com:txomon/SpockBot.git","clone_url":"https://github.com/txomon/SpockBot.git","svn_url":"https://github.com/txomon/SpockBot","homepage":"","size":2416,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpockBotMC:master","ref":"master","sha":"a9ce72852deeb960ea6130c9bcad49e5dda82a54","user":{"login":"SpockBotMC","id":10839172,"avatar_url":"https://avatars.githubusercontent.com/u/10839172?v=3","gravatar_id":"","url":"https://api.github.com/users/SpockBotMC","html_url":"https://github.com/SpockBotMC","followers_url":"https://api.github.com/users/SpockBotMC/followers","following_url":"https://api.github.com/users/SpockBotMC/following{/other_user}","gists_url":"https://api.github.com/users/SpockBotMC/gists{/gist_id}","starred_url":"https://api.github.com/users/SpockBotMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpockBotMC/subscriptions","organizations_url":"https://api.github.com/users/SpockBotMC/orgs","repos_url":"https://api.github.com/users/SpockBotMC/repos","events_url":"https://api.github.com/users/SpockBotMC/events{/privacy}","received_events_url":"https://api.github.com/users/SpockBotMC/received_events","type":"Organization","site_admin":false},"repo":{"id":7111791,"name":"SpockBot","full_name":"SpockBotMC/SpockBot","owner":{"login":"SpockBotMC","id":10839172,"avatar_url":"https://avatars.githubusercontent.com/u/10839172?v=3","gravatar_id":"","url":"https://api.github.com/users/SpockBotMC","html_url":"https://github.com/SpockBotMC","followers_url":"https://api.github.com/users/SpockBotMC/followers","following_url":"https://api.github.com/users/SpockBotMC/following{/other_user}","gists_url":"https://api.github.com/users/SpockBotMC/gists{/gist_id}","starred_url":"https://api.github.com/users/SpockBotMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpockBotMC/subscriptions","organizations_url":"https://api.github.com/users/SpockBotMC/orgs","repos_url":"https://api.github.com/users/SpockBotMC/repos","events_url":"https://api.github.com/users/SpockBotMC/events{/privacy}","received_events_url":"https://api.github.com/users/SpockBotMC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpockBotMC/SpockBot","description":"A pure python framework that implements the 1.8 Minecraft protocol for building Minecraft clients","fork":false,"url":"https://api.github.com/repos/SpockBotMC/SpockBot","forks_url":"https://api.github.com/repos/SpockBotMC/SpockBot/forks","keys_url":"https://api.github.com/repos/SpockBotMC/SpockBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpockBotMC/SpockBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpockBotMC/SpockBot/teams","hooks_url":"https://api.github.com/repos/SpockBotMC/SpockBot/hooks","issue_events_url":"https://api.github.com/repos/SpockBotMC/SpockBot/issues/events{/number}","events_url":"https://api.github.com/repos/SpockBotMC/SpockBot/events","assignees_url":"https://api.github.com/repos/SpockBotMC/SpockBot/assignees{/user}","branches_url":"https://api.github.com/repos/SpockBotMC/SpockBot/branches{/branch}","tags_url":"https://api.github.com/repos/SpockBotMC/SpockBot/tags","blobs_url":"https://api.github.com/repos/SpockBotMC/SpockBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpockBotMC/SpockBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpockBotMC/SpockBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpockBotMC/SpockBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpockBotMC/SpockBot/statuses/{sha}","languages_url":"https://api.github.com/repos/SpockBotMC/SpockBot/languages","stargazers_url":"https://api.github.com/repos/SpockBotMC/SpockBot/stargazers","contributors_url":"https://api.github.com/repos/SpockBotMC/SpockBot/contributors","subscribers_url":"https://api.github.com/repos/SpockBotMC/SpockBot/subscribers","subscription_url":"https://api.github.com/repos/SpockBotMC/SpockBot/subscription","commits_url":"https://api.github.com/repos/SpockBotMC/SpockBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpockBotMC/SpockBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpockBotMC/SpockBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpockBotMC/SpockBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpockBotMC/SpockBot/contents/{+path}","compare_url":"https://api.github.com/repos/SpockBotMC/SpockBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpockBotMC/SpockBot/merges","archive_url":"https://api.github.com/repos/SpockBotMC/SpockBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpockBotMC/SpockBot/downloads","issues_url":"https://api.github.com/repos/SpockBotMC/SpockBot/issues{/number}","pulls_url":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls{/number}","milestones_url":"https://api.github.com/repos/SpockBotMC/SpockBot/milestones{/number}","notifications_url":"https://api.github.com/repos/SpockBotMC/SpockBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpockBotMC/SpockBot/labels{/name}","releases_url":"https://api.github.com/repos/SpockBotMC/SpockBot/releases{/id}","created_at":"2012-12-11T13:01:23Z","updated_at":"2015-08-02T19:45:28Z","pushed_at":"2015-08-04T21:54:42Z","git_url":"git://github.com/SpockBotMC/SpockBot.git","ssh_url":"git@github.com:SpockBotMC/SpockBot.git","clone_url":"https://github.com/SpockBotMC/SpockBot.git","svn_url":"https://github.com/SpockBotMC/SpockBot","homepage":"","size":2416,"stargazers_count":76,"watchers_count":76,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":4,"forks":29,"open_issues":4,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/68"},"html":{"href":"https://github.com/SpockBotMC/SpockBot/pull/68"},"issue":{"href":"https://api.github.com/repos/SpockBotMC/SpockBot/issues/68"},"comments":{"href":"https://api.github.com/repos/SpockBotMC/SpockBot/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpockBotMC/SpockBot/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/SpockBotMC/SpockBot/statuses/1ad9ec81e23f25a556c85dd6a2067fb9b013ab44"}}}}