{"action":"created","comment":{"url":"https://api.github.com/repos/realm/realm-java/pulls/comments/48245966","id":48245966,"diff_hunk":"@@ -176,3 +176,18 @@ JNIEXPORT jboolean JNICALL Java_io_realm_internal_LinkView_nativeIsAttached\n     } CATCH_STD()\n     return 0;\n }\n+\n+JNIEXPORT jlong JNICALL Java_io_realm_internal_LinkView_nativeFind\n+  (JNIEnv *env, jobject, jlong nativeLinkViewPtr, jlong rowIndex)\n+{\n+    TR_ENTER_PTR(nativeLinkViewPtr)\n+    try {\n+        LinkView *lv = LV(nativeLinkViewPtr);\n+        if (!ROW_INDEX_VALID(env, lv, rowIndex)) {\n+            return -1;\n+        }\n+        size_t ndx = lv->find(rowIndex);\n+        return jlong(ndx);","path":"realm/realm-jni/src/io_realm_internal_LinkView.cpp","position":15,"original_position":15,"commit_id":"523ebba99928c3f8a03a8ff6f1866d17bce905a4","original_commit_id":"523ebba99928c3f8a03a8ff6f1866d17bce905a4","user":{"login":"donnfelker","id":91827,"avatar_url":"https://avatars.githubusercontent.com/u/91827?v=3","gravatar_id":"","url":"https://api.github.com/users/donnfelker","html_url":"https://github.com/donnfelker","followers_url":"https://api.github.com/users/donnfelker/followers","following_url":"https://api.github.com/users/donnfelker/following{/other_user}","gists_url":"https://api.github.com/users/donnfelker/gists{/gist_id}","starred_url":"https://api.github.com/users/donnfelker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnfelker/subscriptions","organizations_url":"https://api.github.com/users/donnfelker/orgs","repos_url":"https://api.github.com/users/donnfelker/repos","events_url":"https://api.github.com/users/donnfelker/events{/privacy}","received_events_url":"https://api.github.com/users/donnfelker/received_events","type":"User","site_admin":false},"body":"Thats what I had previously. @cmelchior @kneth what do you guys prefer me to do here? ","created_at":"2015-12-22T11:41:25Z","updated_at":"2015-12-22T11:41:25Z","html_url":"https://github.com/realm/realm-java/pull/1901#discussion_r48245966","pull_request_url":"https://api.github.com/repos/realm/realm-java/pulls/1901","_links":{"self":{"href":"https://api.github.com/repos/realm/realm-java/pulls/comments/48245966"},"html":{"href":"https://github.com/realm/realm-java/pull/1901#discussion_r48245966"},"pull_request":{"href":"https://api.github.com/repos/realm/realm-java/pulls/1901"}}},"pull_request":{"url":"https://api.github.com/repos/realm/realm-java/pulls/1901","id":52866404,"html_url":"https://github.com/realm/realm-java/pull/1901","diff_url":"https://github.com/realm/realm-java/pull/1901.diff","patch_url":"https://github.com/realm/realm-java/pull/1901.patch","issue_url":"https://api.github.com/repos/realm/realm-java/issues/1901","number":1901,"state":"open","locked":false,"title":"Using core method to help improve perf of RealmList#contains()","user":{"login":"donnfelker","id":91827,"avatar_url":"https://avatars.githubusercontent.com/u/91827?v=3","gravatar_id":"","url":"https://api.github.com/users/donnfelker","html_url":"https://github.com/donnfelker","followers_url":"https://api.github.com/users/donnfelker/followers","following_url":"https://api.github.com/users/donnfelker/following{/other_user}","gists_url":"https://api.github.com/users/donnfelker/gists{/gist_id}","starred_url":"https://api.github.com/users/donnfelker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnfelker/subscriptions","organizations_url":"https://api.github.com/users/donnfelker/orgs","repos_url":"https://api.github.com/users/donnfelker/repos","events_url":"https://api.github.com/users/donnfelker/events{/privacy}","received_events_url":"https://api.github.com/users/donnfelker/received_events","type":"User","site_admin":false},"body":"Adding jni layer interop code to utilize find method (broken currently).\r\nChecking to ensure we're on the right Realm before performing the contains check.","created_at":"2015-12-07T16:26:33Z","updated_at":"2015-12-22T11:41:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db4f3eab9cb938b3f4483222b99c357771ab94f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/realm/realm-java/pulls/1901/commits","review_comments_url":"https://api.github.com/repos/realm/realm-java/pulls/1901/comments","review_comment_url":"https://api.github.com/repos/realm/realm-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/realm-java/issues/1901/comments","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/523ebba99928c3f8a03a8ff6f1866d17bce905a4","head":{"label":"donnfelker:df/list-contains-perf","ref":"df/list-contains-perf","sha":"523ebba99928c3f8a03a8ff6f1866d17bce905a4","user":{"login":"donnfelker","id":91827,"avatar_url":"https://avatars.githubusercontent.com/u/91827?v=3","gravatar_id":"","url":"https://api.github.com/users/donnfelker","html_url":"https://github.com/donnfelker","followers_url":"https://api.github.com/users/donnfelker/followers","following_url":"https://api.github.com/users/donnfelker/following{/other_user}","gists_url":"https://api.github.com/users/donnfelker/gists{/gist_id}","starred_url":"https://api.github.com/users/donnfelker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnfelker/subscriptions","organizations_url":"https://api.github.com/users/donnfelker/orgs","repos_url":"https://api.github.com/users/donnfelker/repos","events_url":"https://api.github.com/users/donnfelker/events{/privacy}","received_events_url":"https://api.github.com/users/donnfelker/received_events","type":"User","site_admin":false},"repo":{"id":45628962,"name":"realm-java","full_name":"donnfelker/realm-java","owner":{"login":"donnfelker","id":91827,"avatar_url":"https://avatars.githubusercontent.com/u/91827?v=3","gravatar_id":"","url":"https://api.github.com/users/donnfelker","html_url":"https://github.com/donnfelker","followers_url":"https://api.github.com/users/donnfelker/followers","following_url":"https://api.github.com/users/donnfelker/following{/other_user}","gists_url":"https://api.github.com/users/donnfelker/gists{/gist_id}","starred_url":"https://api.github.com/users/donnfelker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donnfelker/subscriptions","organizations_url":"https://api.github.com/users/donnfelker/orgs","repos_url":"https://api.github.com/users/donnfelker/repos","events_url":"https://api.github.com/users/donnfelker/events{/privacy}","received_events_url":"https://api.github.com/users/donnfelker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/donnfelker/realm-java","description":"Realm is a mobile database: a replacement for SQLite & ORMs","fork":true,"url":"https://api.github.com/repos/donnfelker/realm-java","forks_url":"https://api.github.com/repos/donnfelker/realm-java/forks","keys_url":"https://api.github.com/repos/donnfelker/realm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donnfelker/realm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donnfelker/realm-java/teams","hooks_url":"https://api.github.com/repos/donnfelker/realm-java/hooks","issue_events_url":"https://api.github.com/repos/donnfelker/realm-java/issues/events{/number}","events_url":"https://api.github.com/repos/donnfelker/realm-java/events","assignees_url":"https://api.github.com/repos/donnfelker/realm-java/assignees{/user}","branches_url":"https://api.github.com/repos/donnfelker/realm-java/branches{/branch}","tags_url":"https://api.github.com/repos/donnfelker/realm-java/tags","blobs_url":"https://api.github.com/repos/donnfelker/realm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donnfelker/realm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donnfelker/realm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/donnfelker/realm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donnfelker/realm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/donnfelker/realm-java/languages","stargazers_url":"https://api.github.com/repos/donnfelker/realm-java/stargazers","contributors_url":"https://api.github.com/repos/donnfelker/realm-java/contributors","subscribers_url":"https://api.github.com/repos/donnfelker/realm-java/subscribers","subscription_url":"https://api.github.com/repos/donnfelker/realm-java/subscription","commits_url":"https://api.github.com/repos/donnfelker/realm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/donnfelker/realm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/donnfelker/realm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/donnfelker/realm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/donnfelker/realm-java/contents/{+path}","compare_url":"https://api.github.com/repos/donnfelker/realm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donnfelker/realm-java/merges","archive_url":"https://api.github.com/repos/donnfelker/realm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donnfelker/realm-java/downloads","issues_url":"https://api.github.com/repos/donnfelker/realm-java/issues{/number}","pulls_url":"https://api.github.com/repos/donnfelker/realm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/donnfelker/realm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/donnfelker/realm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donnfelker/realm-java/labels{/name}","releases_url":"https://api.github.com/repos/donnfelker/realm-java/releases{/id}","created_at":"2015-11-05T17:51:10Z","updated_at":"2015-11-05T17:51:15Z","pushed_at":"2015-12-22T11:23:04Z","git_url":"git://github.com/donnfelker/realm-java.git","ssh_url":"git@github.com:donnfelker/realm-java.git","clone_url":"https://github.com/donnfelker/realm-java.git","svn_url":"https://github.com/donnfelker/realm-java","homepage":"http://realm.io","size":40896,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"realm:master","ref":"master","sha":"49d69c94a237839709d074b80869e63e88e71b91","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":4084908,"name":"realm-java","full_name":"realm/realm-java","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-java","description":"Realm is a mobile database: a replacement for SQLite & ORMs","fork":false,"url":"https://api.github.com/repos/realm/realm-java","forks_url":"https://api.github.com/repos/realm/realm-java/forks","keys_url":"https://api.github.com/repos/realm/realm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-java/teams","hooks_url":"https://api.github.com/repos/realm/realm-java/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-java/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-java/events","assignees_url":"https://api.github.com/repos/realm/realm-java/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-java/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-java/tags","blobs_url":"https://api.github.com/repos/realm/realm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-java/languages","stargazers_url":"https://api.github.com/repos/realm/realm-java/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-java/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-java/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-java/subscription","commits_url":"https://api.github.com/repos/realm/realm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-java/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-java/merges","archive_url":"https://api.github.com/repos/realm/realm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-java/downloads","issues_url":"https://api.github.com/repos/realm/realm-java/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-java/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-java/releases{/id}","created_at":"2012-04-20T09:18:42Z","updated_at":"2015-12-22T09:45:08Z","pushed_at":"2015-12-22T11:23:04Z","git_url":"git://github.com/realm/realm-java.git","ssh_url":"git@github.com:realm/realm-java.git","clone_url":"https://github.com/realm/realm-java.git","svn_url":"https://github.com/realm/realm-java","homepage":"http://realm.io","size":43583,"stargazers_count":3155,"watchers_count":3155,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":346,"mirror_url":null,"open_issues_count":195,"forks":346,"open_issues":195,"watchers":3155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/realm-java/pulls/1901"},"html":{"href":"https://github.com/realm/realm-java/pull/1901"},"issue":{"href":"https://api.github.com/repos/realm/realm-java/issues/1901"},"comments":{"href":"https://api.github.com/repos/realm/realm-java/issues/1901/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/realm-java/pulls/1901/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/realm-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/realm-java/pulls/1901/commits"},"statuses":{"href":"https://api.github.com/repos/realm/realm-java/statuses/523ebba99928c3f8a03a8ff6f1866d17bce905a4"}}}}