{"action":"opened","number":618,"pull_request":{"url":"https://api.github.com/repos/sugarlabs/sugar/pulls/618","id":51880498,"html_url":"https://github.com/sugarlabs/sugar/pull/618","diff_url":"https://github.com/sugarlabs/sugar/pull/618.diff","patch_url":"https://github.com/sugarlabs/sugar/pull/618.patch","issue_url":"https://api.github.com/repos/sugarlabs/sugar/issues/618","number":618,"state":"open","locked":false,"title":"fix resume mode alt key handling in favourites","user":{"login":"quozl","id":2936481,"avatar_url":"https://avatars.githubusercontent.com/u/2936481?v=3","gravatar_id":"","url":"https://api.github.com/users/quozl","html_url":"https://github.com/quozl","followers_url":"https://api.github.com/users/quozl/followers","following_url":"https://api.github.com/users/quozl/following{/other_user}","gists_url":"https://api.github.com/users/quozl/gists{/gist_id}","starred_url":"https://api.github.com/users/quozl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quozl/subscriptions","organizations_url":"https://api.github.com/users/quozl/orgs","repos_url":"https://api.github.com/users/quozl/repos","events_url":"https://api.github.com/users/quozl/events{/privacy}","received_events_url":"https://api.github.com/users/quozl/received_events","type":"User","site_admin":false},"body":"Sometimes after stopping an activity that was started new with the Alt key, the visibility notify event is missed, and the favourites view is without user colour because the Alt key is presumed to be down.\r\n\r\nWorkaround is to briefly press and release the Alt key, and the colours return.\r\n\r\nFix is to abandon the visibility notify event, which also happens to be deprecated, in favour of a timeout that checks for Alt key release.\r\n\r\nAlso refactored the common code for detecting the Alt key in an event.\r\n\r\nA behaviour change is that the Alt key has to be pressed while the home view is shown.  Test case; show journal, expose frame, press Alt, click on home view icon, which results in home view appearing as if the Alt key is not down.\r\n","created_at":"2015-11-26T07:39:09Z","updated_at":"2015-11-26T07:39:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c23c8131615309d14e148884991b256c7f0fb1a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sugarlabs/sugar/pulls/618/commits","review_comments_url":"https://api.github.com/repos/sugarlabs/sugar/pulls/618/comments","review_comment_url":"https://api.github.com/repos/sugarlabs/sugar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sugarlabs/sugar/issues/618/comments","statuses_url":"https://api.github.com/repos/sugarlabs/sugar/statuses/31f66d20a43dbba053a8a331c779c33b20270a74","head":{"label":"quozl:2015-11-26-is-alt","ref":"2015-11-26-is-alt","sha":"31f66d20a43dbba053a8a331c779c33b20270a74","user":{"login":"quozl","id":2936481,"avatar_url":"https://avatars.githubusercontent.com/u/2936481?v=3","gravatar_id":"","url":"https://api.github.com/users/quozl","html_url":"https://github.com/quozl","followers_url":"https://api.github.com/users/quozl/followers","following_url":"https://api.github.com/users/quozl/following{/other_user}","gists_url":"https://api.github.com/users/quozl/gists{/gist_id}","starred_url":"https://api.github.com/users/quozl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quozl/subscriptions","organizations_url":"https://api.github.com/users/quozl/orgs","repos_url":"https://api.github.com/users/quozl/repos","events_url":"https://api.github.com/users/quozl/events{/privacy}","received_events_url":"https://api.github.com/users/quozl/received_events","type":"User","site_admin":false},"repo":{"id":24444299,"name":"sugar","full_name":"quozl/sugar","owner":{"login":"quozl","id":2936481,"avatar_url":"https://avatars.githubusercontent.com/u/2936481?v=3","gravatar_id":"","url":"https://api.github.com/users/quozl","html_url":"https://github.com/quozl","followers_url":"https://api.github.com/users/quozl/followers","following_url":"https://api.github.com/users/quozl/following{/other_user}","gists_url":"https://api.github.com/users/quozl/gists{/gist_id}","starred_url":"https://api.github.com/users/quozl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quozl/subscriptions","organizations_url":"https://api.github.com/users/quozl/orgs","repos_url":"https://api.github.com/users/quozl/repos","events_url":"https://api.github.com/users/quozl/events{/privacy}","received_events_url":"https://api.github.com/users/quozl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/quozl/sugar","description":"Sugar GTK shell","fork":true,"url":"https://api.github.com/repos/quozl/sugar","forks_url":"https://api.github.com/repos/quozl/sugar/forks","keys_url":"https://api.github.com/repos/quozl/sugar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quozl/sugar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quozl/sugar/teams","hooks_url":"https://api.github.com/repos/quozl/sugar/hooks","issue_events_url":"https://api.github.com/repos/quozl/sugar/issues/events{/number}","events_url":"https://api.github.com/repos/quozl/sugar/events","assignees_url":"https://api.github.com/repos/quozl/sugar/assignees{/user}","branches_url":"https://api.github.com/repos/quozl/sugar/branches{/branch}","tags_url":"https://api.github.com/repos/quozl/sugar/tags","blobs_url":"https://api.github.com/repos/quozl/sugar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quozl/sugar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quozl/sugar/git/refs{/sha}","trees_url":"https://api.github.com/repos/quozl/sugar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quozl/sugar/statuses/{sha}","languages_url":"https://api.github.com/repos/quozl/sugar/languages","stargazers_url":"https://api.github.com/repos/quozl/sugar/stargazers","contributors_url":"https://api.github.com/repos/quozl/sugar/contributors","subscribers_url":"https://api.github.com/repos/quozl/sugar/subscribers","subscription_url":"https://api.github.com/repos/quozl/sugar/subscription","commits_url":"https://api.github.com/repos/quozl/sugar/commits{/sha}","git_commits_url":"https://api.github.com/repos/quozl/sugar/git/commits{/sha}","comments_url":"https://api.github.com/repos/quozl/sugar/comments{/number}","issue_comment_url":"https://api.github.com/repos/quozl/sugar/issues/comments{/number}","contents_url":"https://api.github.com/repos/quozl/sugar/contents/{+path}","compare_url":"https://api.github.com/repos/quozl/sugar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quozl/sugar/merges","archive_url":"https://api.github.com/repos/quozl/sugar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quozl/sugar/downloads","issues_url":"https://api.github.com/repos/quozl/sugar/issues{/number}","pulls_url":"https://api.github.com/repos/quozl/sugar/pulls{/number}","milestones_url":"https://api.github.com/repos/quozl/sugar/milestones{/number}","notifications_url":"https://api.github.com/repos/quozl/sugar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quozl/sugar/labels{/name}","releases_url":"https://api.github.com/repos/quozl/sugar/releases{/id}","created_at":"2014-09-25T04:57:08Z","updated_at":"2014-12-10T03:13:15Z","pushed_at":"2015-11-26T07:33:21Z","git_url":"git://github.com/quozl/sugar.git","ssh_url":"git@github.com:quozl/sugar.git","clone_url":"https://github.com/quozl/sugar.git","svn_url":"https://github.com/quozl/sugar","homepage":"","size":24385,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sugarlabs:master","ref":"master","sha":"9dc71a0414c6d5bf41df329f2a9c690dc94bd2cc","user":{"login":"sugarlabs","id":3996398,"avatar_url":"https://avatars.githubusercontent.com/u/3996398?v=3","gravatar_id":"","url":"https://api.github.com/users/sugarlabs","html_url":"https://github.com/sugarlabs","followers_url":"https://api.github.com/users/sugarlabs/followers","following_url":"https://api.github.com/users/sugarlabs/following{/other_user}","gists_url":"https://api.github.com/users/sugarlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/sugarlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sugarlabs/subscriptions","organizations_url":"https://api.github.com/users/sugarlabs/orgs","repos_url":"https://api.github.com/users/sugarlabs/repos","events_url":"https://api.github.com/users/sugarlabs/events{/privacy}","received_events_url":"https://api.github.com/users/sugarlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10601176,"name":"sugar","full_name":"sugarlabs/sugar","owner":{"login":"sugarlabs","id":3996398,"avatar_url":"https://avatars.githubusercontent.com/u/3996398?v=3","gravatar_id":"","url":"https://api.github.com/users/sugarlabs","html_url":"https://github.com/sugarlabs","followers_url":"https://api.github.com/users/sugarlabs/followers","following_url":"https://api.github.com/users/sugarlabs/following{/other_user}","gists_url":"https://api.github.com/users/sugarlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/sugarlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sugarlabs/subscriptions","organizations_url":"https://api.github.com/users/sugarlabs/orgs","repos_url":"https://api.github.com/users/sugarlabs/repos","events_url":"https://api.github.com/users/sugarlabs/events{/privacy}","received_events_url":"https://api.github.com/users/sugarlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sugarlabs/sugar","description":"Sugar GTK shell","fork":false,"url":"https://api.github.com/repos/sugarlabs/sugar","forks_url":"https://api.github.com/repos/sugarlabs/sugar/forks","keys_url":"https://api.github.com/repos/sugarlabs/sugar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sugarlabs/sugar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sugarlabs/sugar/teams","hooks_url":"https://api.github.com/repos/sugarlabs/sugar/hooks","issue_events_url":"https://api.github.com/repos/sugarlabs/sugar/issues/events{/number}","events_url":"https://api.github.com/repos/sugarlabs/sugar/events","assignees_url":"https://api.github.com/repos/sugarlabs/sugar/assignees{/user}","branches_url":"https://api.github.com/repos/sugarlabs/sugar/branches{/branch}","tags_url":"https://api.github.com/repos/sugarlabs/sugar/tags","blobs_url":"https://api.github.com/repos/sugarlabs/sugar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sugarlabs/sugar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sugarlabs/sugar/git/refs{/sha}","trees_url":"https://api.github.com/repos/sugarlabs/sugar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sugarlabs/sugar/statuses/{sha}","languages_url":"https://api.github.com/repos/sugarlabs/sugar/languages","stargazers_url":"https://api.github.com/repos/sugarlabs/sugar/stargazers","contributors_url":"https://api.github.com/repos/sugarlabs/sugar/contributors","subscribers_url":"https://api.github.com/repos/sugarlabs/sugar/subscribers","subscription_url":"https://api.github.com/repos/sugarlabs/sugar/subscription","commits_url":"https://api.github.com/repos/sugarlabs/sugar/commits{/sha}","git_commits_url":"https://api.github.com/repos/sugarlabs/sugar/git/commits{/sha}","comments_url":"https://api.github.com/repos/sugarlabs/sugar/comments{/number}","issue_comment_url":"https://api.github.com/repos/sugarlabs/sugar/issues/comments{/number}","contents_url":"https://api.github.com/repos/sugarlabs/sugar/contents/{+path}","compare_url":"https://api.github.com/repos/sugarlabs/sugar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sugarlabs/sugar/merges","archive_url":"https://api.github.com/repos/sugarlabs/sugar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sugarlabs/sugar/downloads","issues_url":"https://api.github.com/repos/sugarlabs/sugar/issues{/number}","pulls_url":"https://api.github.com/repos/sugarlabs/sugar/pulls{/number}","milestones_url":"https://api.github.com/repos/sugarlabs/sugar/milestones{/number}","notifications_url":"https://api.github.com/repos/sugarlabs/sugar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sugarlabs/sugar/labels{/name}","releases_url":"https://api.github.com/repos/sugarlabs/sugar/releases{/id}","created_at":"2013-06-10T13:49:20Z","updated_at":"2015-11-25T09:21:19Z","pushed_at":"2015-11-26T07:39:10Z","git_url":"git://github.com/sugarlabs/sugar.git","ssh_url":"git@github.com:sugarlabs/sugar.git","clone_url":"https://github.com/sugarlabs/sugar.git","svn_url":"https://github.com/sugarlabs/sugar","homepage":"","size":25769,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":9,"forks":80,"open_issues":9,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sugarlabs/sugar/pulls/618"},"html":{"href":"https://github.com/sugarlabs/sugar/pull/618"},"issue":{"href":"https://api.github.com/repos/sugarlabs/sugar/issues/618"},"comments":{"href":"https://api.github.com/repos/sugarlabs/sugar/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/sugarlabs/sugar/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/sugarlabs/sugar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sugarlabs/sugar/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/sugarlabs/sugar/statuses/31f66d20a43dbba053a8a331c779c33b20270a74"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":26,"deletions":20,"changed_files":1}}