{"action":"created","comment":{"url":"https://api.github.com/repos/apache/tajo/pulls/comments/46091585","id":46091585,"diff_hunk":"@@ -0,0 +1,91 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.tajo.ws.rs.resources.outputs;\n+\n+import com.facebook.presto.hive.shaded.com.google.common.collect.Maps;","path":"tajo-core/src/main/java/org/apache/tajo/ws/rs/resources/outputs/RestOutputFactory.java","position":21,"original_position":21,"commit_id":"f7d7e61435237bc42198d2b1aa31db0d8295079c","original_commit_id":"f7d7e61435237bc42198d2b1aa31db0d8295079c","user":{"login":"jihoonson","id":2322288,"avatar_url":"https://avatars.githubusercontent.com/u/2322288?v=3","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"body":"Please use google's library instead of facebook's one.","created_at":"2015-11-29T12:44:23Z","updated_at":"2015-11-29T12:44:23Z","html_url":"https://github.com/apache/tajo/pull/876#discussion_r46091585","pull_request_url":"https://api.github.com/repos/apache/tajo/pulls/876","_links":{"self":{"href":"https://api.github.com/repos/apache/tajo/pulls/comments/46091585"},"html":{"href":"https://github.com/apache/tajo/pull/876#discussion_r46091585"},"pull_request":{"href":"https://api.github.com/repos/apache/tajo/pulls/876"}}},"pull_request":{"url":"https://api.github.com/repos/apache/tajo/pulls/876","id":51686166,"html_url":"https://github.com/apache/tajo/pull/876","diff_url":"https://github.com/apache/tajo/pull/876.diff","patch_url":"https://github.com/apache/tajo/pull/876.patch","issue_url":"https://api.github.com/repos/apache/tajo/issues/876","number":876,"state":"open","locked":false,"title":"TAJO-1944: Support text resultset for REST","user":{"login":"charsyam","id":439301,"avatar_url":"https://avatars.githubusercontent.com/u/439301?v=3","gravatar_id":"","url":"https://api.github.com/users/charsyam","html_url":"https://github.com/charsyam","followers_url":"https://api.github.com/users/charsyam/followers","following_url":"https://api.github.com/users/charsyam/following{/other_user}","gists_url":"https://api.github.com/users/charsyam/gists{/gist_id}","starred_url":"https://api.github.com/users/charsyam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charsyam/subscriptions","organizations_url":"https://api.github.com/users/charsyam/orgs","repos_url":"https://api.github.com/users/charsyam/repos","events_url":"https://api.github.com/users/charsyam/events{/privacy}","received_events_url":"https://api.github.com/users/charsyam/received_events","type":"User","site_admin":false},"body":"This is just for review. and I just add csv only now :)\r\n\r\nI worried about 3 points. \r\n\r\nfirst of all, memory usages for other type.\r\nI think most users want to download all data as csv one time.\r\n\r\nsecond, add new method for NonForwardQueryResultScanner to get tuple list.\r\n\r\nthird, removing base64 checking for consistency with other type(csv, binary)","created_at":"2015-11-24T16:53:30Z","updated_at":"2015-11-29T12:44:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d79c021232079ce24366f1b475ea5a9e1e1a9de0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/tajo/pulls/876/commits","review_comments_url":"https://api.github.com/repos/apache/tajo/pulls/876/comments","review_comment_url":"https://api.github.com/repos/apache/tajo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/tajo/issues/876/comments","statuses_url":"https://api.github.com/repos/apache/tajo/statuses/f7d7e61435237bc42198d2b1aa31db0d8295079c","head":{"label":"charsyam:feature/tajo-output","ref":"feature/tajo-output","sha":"f7d7e61435237bc42198d2b1aa31db0d8295079c","user":{"login":"charsyam","id":439301,"avatar_url":"https://avatars.githubusercontent.com/u/439301?v=3","gravatar_id":"","url":"https://api.github.com/users/charsyam","html_url":"https://github.com/charsyam","followers_url":"https://api.github.com/users/charsyam/followers","following_url":"https://api.github.com/users/charsyam/following{/other_user}","gists_url":"https://api.github.com/users/charsyam/gists{/gist_id}","starred_url":"https://api.github.com/users/charsyam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charsyam/subscriptions","organizations_url":"https://api.github.com/users/charsyam/orgs","repos_url":"https://api.github.com/users/charsyam/repos","events_url":"https://api.github.com/users/charsyam/events{/privacy}","received_events_url":"https://api.github.com/users/charsyam/received_events","type":"User","site_admin":false},"repo":{"id":21539304,"name":"tajo","full_name":"charsyam/tajo","owner":{"login":"charsyam","id":439301,"avatar_url":"https://avatars.githubusercontent.com/u/439301?v=3","gravatar_id":"","url":"https://api.github.com/users/charsyam","html_url":"https://github.com/charsyam","followers_url":"https://api.github.com/users/charsyam/followers","following_url":"https://api.github.com/users/charsyam/following{/other_user}","gists_url":"https://api.github.com/users/charsyam/gists{/gist_id}","starred_url":"https://api.github.com/users/charsyam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charsyam/subscriptions","organizations_url":"https://api.github.com/users/charsyam/orgs","repos_url":"https://api.github.com/users/charsyam/repos","events_url":"https://api.github.com/users/charsyam/events{/privacy}","received_events_url":"https://api.github.com/users/charsyam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charsyam/tajo","description":"Mirror of Apache Tajo","fork":true,"url":"https://api.github.com/repos/charsyam/tajo","forks_url":"https://api.github.com/repos/charsyam/tajo/forks","keys_url":"https://api.github.com/repos/charsyam/tajo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charsyam/tajo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charsyam/tajo/teams","hooks_url":"https://api.github.com/repos/charsyam/tajo/hooks","issue_events_url":"https://api.github.com/repos/charsyam/tajo/issues/events{/number}","events_url":"https://api.github.com/repos/charsyam/tajo/events","assignees_url":"https://api.github.com/repos/charsyam/tajo/assignees{/user}","branches_url":"https://api.github.com/repos/charsyam/tajo/branches{/branch}","tags_url":"https://api.github.com/repos/charsyam/tajo/tags","blobs_url":"https://api.github.com/repos/charsyam/tajo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charsyam/tajo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charsyam/tajo/git/refs{/sha}","trees_url":"https://api.github.com/repos/charsyam/tajo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charsyam/tajo/statuses/{sha}","languages_url":"https://api.github.com/repos/charsyam/tajo/languages","stargazers_url":"https://api.github.com/repos/charsyam/tajo/stargazers","contributors_url":"https://api.github.com/repos/charsyam/tajo/contributors","subscribers_url":"https://api.github.com/repos/charsyam/tajo/subscribers","subscription_url":"https://api.github.com/repos/charsyam/tajo/subscription","commits_url":"https://api.github.com/repos/charsyam/tajo/commits{/sha}","git_commits_url":"https://api.github.com/repos/charsyam/tajo/git/commits{/sha}","comments_url":"https://api.github.com/repos/charsyam/tajo/comments{/number}","issue_comment_url":"https://api.github.com/repos/charsyam/tajo/issues/comments{/number}","contents_url":"https://api.github.com/repos/charsyam/tajo/contents/{+path}","compare_url":"https://api.github.com/repos/charsyam/tajo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charsyam/tajo/merges","archive_url":"https://api.github.com/repos/charsyam/tajo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charsyam/tajo/downloads","issues_url":"https://api.github.com/repos/charsyam/tajo/issues{/number}","pulls_url":"https://api.github.com/repos/charsyam/tajo/pulls{/number}","milestones_url":"https://api.github.com/repos/charsyam/tajo/milestones{/number}","notifications_url":"https://api.github.com/repos/charsyam/tajo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charsyam/tajo/labels{/name}","releases_url":"https://api.github.com/repos/charsyam/tajo/releases{/id}","created_at":"2014-07-06T12:09:30Z","updated_at":"2015-05-08T06:28:41Z","pushed_at":"2015-11-28T04:33:59Z","git_url":"git://github.com/charsyam/tajo.git","ssh_url":"git@github.com:charsyam/tajo.git","clone_url":"https://github.com/charsyam/tajo.git","svn_url":"https://github.com/charsyam/tajo","homepage":null,"size":21167,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0be254c8bd5de1f992bcefb129b0b02904909f0a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17971138,"name":"tajo","full_name":"apache/tajo","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tajo","description":"Mirror of Apache Tajo","fork":false,"url":"https://api.github.com/repos/apache/tajo","forks_url":"https://api.github.com/repos/apache/tajo/forks","keys_url":"https://api.github.com/repos/apache/tajo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tajo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tajo/teams","hooks_url":"https://api.github.com/repos/apache/tajo/hooks","issue_events_url":"https://api.github.com/repos/apache/tajo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tajo/events","assignees_url":"https://api.github.com/repos/apache/tajo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tajo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tajo/tags","blobs_url":"https://api.github.com/repos/apache/tajo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tajo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tajo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tajo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tajo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tajo/languages","stargazers_url":"https://api.github.com/repos/apache/tajo/stargazers","contributors_url":"https://api.github.com/repos/apache/tajo/contributors","subscribers_url":"https://api.github.com/repos/apache/tajo/subscribers","subscription_url":"https://api.github.com/repos/apache/tajo/subscription","commits_url":"https://api.github.com/repos/apache/tajo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tajo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tajo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tajo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tajo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tajo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tajo/merges","archive_url":"https://api.github.com/repos/apache/tajo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tajo/downloads","issues_url":"https://api.github.com/repos/apache/tajo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tajo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tajo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tajo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tajo/labels{/name}","releases_url":"https://api.github.com/repos/apache/tajo/releases{/id}","created_at":"2014-03-21T07:00:07Z","updated_at":"2015-11-11T23:10:01Z","pushed_at":"2015-11-29T11:22:10Z","git_url":"git://github.com/apache/tajo.git","ssh_url":"git@github.com:apache/tajo.git","clone_url":"https://github.com/apache/tajo.git","svn_url":"https://github.com/apache/tajo","homepage":null,"size":37999,"stargazers_count":73,"watchers_count":73,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":"git://git.apache.org/tajo.git","open_issues_count":45,"forks":78,"open_issues":45,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/tajo/pulls/876"},"html":{"href":"https://github.com/apache/tajo/pull/876"},"issue":{"href":"https://api.github.com/repos/apache/tajo/issues/876"},"comments":{"href":"https://api.github.com/repos/apache/tajo/issues/876/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/tajo/pulls/876/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/tajo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/tajo/pulls/876/commits"},"statuses":{"href":"https://api.github.com/repos/apache/tajo/statuses/f7d7e61435237bc42198d2b1aa31db0d8295079c"}}}}