{"action":"closed","issue":{"url":"https://api.github.com/repos/cfpb/sentia/issues/14","labels_url":"https://api.github.com/repos/cfpb/sentia/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/sentia/issues/14/comments","events_url":"https://api.github.com/repos/cfpb/sentia/issues/14/events","html_url":"https://github.com/cfpb/sentia/issues/14","id":111533457,"number":14,"title":"Possible Injection with Shell=True ","user":{"login":"lfatty","id":6775261,"avatar_url":"https://avatars.githubusercontent.com/u/6775261?v=3","gravatar_id":"","url":"https://api.github.com/users/lfatty","html_url":"https://github.com/lfatty","followers_url":"https://api.github.com/users/lfatty/followers","following_url":"https://api.github.com/users/lfatty/following{/other_user}","gists_url":"https://api.github.com/users/lfatty/gists{/gist_id}","starred_url":"https://api.github.com/users/lfatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfatty/subscriptions","organizations_url":"https://api.github.com/users/lfatty/orgs","repos_url":"https://api.github.com/users/lfatty/repos","events_url":"https://api.github.com/users/lfatty/events{/privacy}","received_events_url":"https://api.github.com/users/lfatty/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-15T02:37:47Z","updated_at":"2015-10-26T20:05:40Z","closed_at":"2015-10-26T20:05:40Z","body":"I was looking at the source code and noted that you have lot of Shell=TRUE. See the following lines:\r\n\r\n/sentia/softwarediscovery/get_installed_software.py on line 94\r\n/sentia/softwarediscovery/get_installed_software.py on line 108\r\n/sentia/softwarediscovery/get_installed_software.py on line 124\r\n/sentia/softwarediscovery/get_installed_software.py:142\r\nsentia/softwarediscovery/get_installed_software.py:165\r\n\r\nIf someone (malicious person) executes shell commands that might include unsanitized input from an untrusted source, it will make the application vulnerable to shell injection, a serious security flaw which can result in arbitrary command execution. For this reason, the use of shell=True is strongly discouraged in cases where the command string is constructed from external input.\r\n"}}