{"action":"created","issue":{"url":"https://api.github.com/repos/GRIFFINCollaboration/beamCompanionExplorer/issues/19","labels_url":"https://api.github.com/repos/GRIFFINCollaboration/beamCompanionExplorer/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/GRIFFINCollaboration/beamCompanionExplorer/issues/19/comments","events_url":"https://api.github.com/repos/GRIFFINCollaboration/beamCompanionExplorer/issues/19/events","html_url":"https://github.com/GRIFFINCollaboration/beamCompanionExplorer/issues/19","id":109003978,"number":19,"title":"last thoughts before 0.1","user":{"login":"BillMills","id":1896943,"avatar_url":"https://avatars.githubusercontent.com/u/1896943?v=3","gravatar_id":"","url":"https://api.github.com/users/BillMills","html_url":"https://github.com/BillMills","followers_url":"https://api.github.com/users/BillMills/followers","following_url":"https://api.github.com/users/BillMills/following{/other_user}","gists_url":"https://api.github.com/users/BillMills/gists{/gist_id}","starred_url":"https://api.github.com/users/BillMills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillMills/subscriptions","organizations_url":"https://api.github.com/users/BillMills/orgs","repos_url":"https://api.github.com/users/BillMills/repos","events_url":"https://api.github.com/users/BillMills/events{/privacy}","received_events_url":"https://api.github.com/users/BillMills/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-30T02:48:10Z","updated_at":"2015-09-30T22:24:44Z","closed_at":null,"body":"All requested features are in place; will test and check Wednesday. A few outstanding points:\r\n\r\n - [This line](https://github.com/AdamGarnsworthy/CSBBasic/blob/master/index.php#L712) always bothered me in the original CSB page; it's clearly calculating an A/Q, but the Q in the denominator is different than the Q used to determine the number of electrons to subtract from the mass.\r\n - FYI both aluminium and stainless steel liners list the exact same constituent species. Intentional?\r\n - Note the RFQ and DSB prebuncher resolutions reported in the text for the original version (1/1000 and 1/400 respectively) are much different than the parameters found in the code (1/400 and 1/200).\r\n - there was a comment in the original code about the charge state width calculation being for Z>20; should this be enforced in the code? What about Z<=20?\r\n\r\n@AdamGarnsworthy, do please have a close read of the text at the bottom when you have a chance; I get what you're doing here, but I'm not intimately familiar with your hardware, so I may have used overly generic terms to describe some parts. Also, I tried to make sure the text reflects the code faithfully, so if something seems wrong, don't overlook it as a simple textual error - it likely indicates a real mistake in the code. "},"comment":{"url":"https://api.github.com/repos/GRIFFINCollaboration/beamCompanionExplorer/issues/comments/144561489","html_url":"https://github.com/GRIFFINCollaboration/beamCompanionExplorer/issues/19#issuecomment-144561489","issue_url":"https://api.github.com/repos/GRIFFINCollaboration/beamCompanionExplorer/issues/19","id":144561489,"user":{"login":"AdamGarnsworthy","id":5225574,"avatar_url":"https://avatars.githubusercontent.com/u/5225574?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamGarnsworthy","html_url":"https://github.com/AdamGarnsworthy","followers_url":"https://api.github.com/users/AdamGarnsworthy/followers","following_url":"https://api.github.com/users/AdamGarnsworthy/following{/other_user}","gists_url":"https://api.github.com/users/AdamGarnsworthy/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamGarnsworthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamGarnsworthy/subscriptions","organizations_url":"https://api.github.com/users/AdamGarnsworthy/orgs","repos_url":"https://api.github.com/users/AdamGarnsworthy/repos","events_url":"https://api.github.com/users/AdamGarnsworthy/events{/privacy}","received_events_url":"https://api.github.com/users/AdamGarnsworthy/received_events","type":"User","site_admin":false},"created_at":"2015-09-30T22:24:44Z","updated_at":"2015-09-30T22:24:44Z","body":"I think its a mistake in my original code. This should be corrected."}}