{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/420","labels_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/420/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/420/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/420/events","html_url":"https://github.com/puppetlabs/puppet-server/pull/420","id":59739189,"number":420,"title":"(SERVER-410) Always cache features in puppet server","user":{"login":"jeffmccune","id":8972,"avatar_url":"https://avatars.githubusercontent.com/u/8972?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmccune","html_url":"https://github.com/jeffmccune","followers_url":"https://api.github.com/users/jeffmccune/followers","following_url":"https://api.github.com/users/jeffmccune/following{/other_user}","gists_url":"https://api.github.com/users/jeffmccune/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmccune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmccune/subscriptions","organizations_url":"https://api.github.com/users/jeffmccune/orgs","repos_url":"https://api.github.com/users/jeffmccune/repos","events_url":"https://api.github.com/users/jeffmccune/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmccune/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-04T02:00:32Z","updated_at":"2015-03-04T16:11:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/420","html_url":"https://github.com/puppetlabs/puppet-server/pull/420","diff_url":"https://github.com/puppetlabs/puppet-server/pull/420.diff","patch_url":"https://github.com/puppetlabs/puppet-server/pull/420.patch"},"body":"Without this patch puppet server defers to puppet on the value of the\nalways_cache_features setting.  This is a problem because it does not make\nsense for features to be reloaded frequently on the puppet server, this\nbehavior is only useful for puppet agent processes that need to update the set\nof installed features mid-run.\n\nThis patch addresses the problem by explicitly passing in the\nalways_cache_features key with a value of true to the Puppet::Server::Master\ninitializer.\n\nThis approach is employed to keep all of the jruby-puppet related settings in\none place, external to JRuby, and injected into the system from the application\nlayer.\n\nThis could alternatively be implemented directly in server/master.rb, but this\napproach was not taken because it would change the behavior of the ruby code to\npull settings from multiple locations rather than the sole location of settings\ninjected via the initializer.  The injection approach also has the benefit of\nkeeping all settings together and performing a slightly more comprehensive\ntest."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/comments/77187388","html_url":"https://github.com/puppetlabs/puppet-server/pull/420#issuecomment-77187388","issue_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/420","id":77187388,"user":{"login":"cprice404","id":1341071,"avatar_url":"https://avatars.githubusercontent.com/u/1341071?v=3","gravatar_id":"","url":"https://api.github.com/users/cprice404","html_url":"https://github.com/cprice404","followers_url":"https://api.github.com/users/cprice404/followers","following_url":"https://api.github.com/users/cprice404/following{/other_user}","gists_url":"https://api.github.com/users/cprice404/gists{/gist_id}","starred_url":"https://api.github.com/users/cprice404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprice404/subscriptions","organizations_url":"https://api.github.com/users/cprice404/orgs","repos_url":"https://api.github.com/users/cprice404/repos","events_url":"https://api.github.com/users/cprice404/events{/privacy}","received_events_url":"https://api.github.com/users/cprice404/received_events","type":"User","site_admin":false},"created_at":"2015-03-04T16:11:13Z","updated_at":"2015-03-04T16:11:13Z","body":"@jeffmccune I left a couple of 'food-for-thought' comments on the jira ticket.  One other thing we should consider is whether or not this should maybe targeted at stable and merged up?"}}