{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/42230540","id":42230540,"diff_hunk":"@@ -78,52 +78,85 @@ def self.default_platform\n     end\n   end\n \n-  def self.available_platforms\n+  def self.available_platforms(architecture)\n     @available_platforms ||= begin\n       provisioner = NodeObject.find(\"roles:provisioner-server\").first\n       if provisioner.nil?\n-        []\n+        {}\n       else\n-        availables_oses = provisioner[\"provisioner\"][\"available_oses\"].keys\n-        # Sort the platforms:\n-        #  - first, the default platform\n-        #  - between first and the Hyper-V/Windows bits: others, sorted\n-        #    alphabetically\n-        #  - last Hyper-V, and just before that Windows\n-        platform_order = {\"windows\" => 90, \"hyperv\" => 100}\n-        availables_oses.uniq.sort {|x, y|\n-          platform_x, version_x = x.split(\"-\")\n-          platform_y, version_y = y.split(\"-\")\n-          platform_order_x = platform_order[platform_x] || 1\n-          platform_order_y = platform_order[platform_y] || 1\n-\n-          if x == default_platform\n-            -1\n-          elsif y == default_platform\n-            1\n-          elsif platform_x == platform_y\n-            version_y <=> version_x\n-          elsif platform_order_x == platform_order_y\n-            x <=> y\n-          else\n-            platform_order_x <=> platform_order_y\n-          end\n-        }\n+        platforms = {}\n+\n+        arches = provisioner[\"provisioner\"][\"available_oses\"].keys.map { |p|\n+          provisioner[\"provisioner\"][\"available_oses\"][p].keys\n+        }.flatten.uniq\n+\n+        arches.each do |arch|\n+          availables_oses = provisioner[\"provisioner\"][\"available_oses\"].keys.select { |p|\n+            provisioner[\"provisioner\"][\"available_oses\"][p].has_key? arch\n+          }\n+\n+          # Sort the platforms:\n+          #  - first, the default platform\n+          #  - between first and the Hyper-V/Windows bits: others, sorted\n+          #    alphabetically\n+          #  - last Hyper-V, and just before that Windows\n+          platform_order = {\"windows\" => 90, \"hyperv\" => 100}\n+          platforms[arch] = availables_oses.uniq.sort {|x, y|\n+            platform_x, version_x = x.split('-')\n+            platform_y, version_y = y.split('-')\n+            platform_order_x = platform_order[platform_x] || 1\n+            platform_order_y = platform_order[platform_y] || 1\n+\n+            if x == default_platform\n+              -1\n+            elsif y == default_platform\n+              1\n+            elsif platform_x == platform_y\n+              version_y <=> version_x\n+            elsif platform_order_x == platform_order_y\n+              x <=> y\n+            else\n+              platform_order_x <=> platform_order_y\n+            end\n+          }\n+        end\n+\n+        platforms\n       end\n     end\n+\n+    @available_platforms[architecture] || []\n   end\n \n-  def self.disabled_platforms\n+  def self.disabled_platforms(architecture)\n     @disabled_platforms ||= begin\n       provisioner = NodeObject.find(\"roles:provisioner-server\").first\n       if provisioner.nil?\n-        []\n+        {}\n       else\n-        provisioner[\"provisioner\"][\"available_oses\"].keys.select { |p|\n-          provisioner[\"provisioner\"][\"available_oses\"][p][\"disabled\"]\n-        }\n+        platforms = {}\n+\n+        arches = provisioner[\"provisioner\"][\"available_oses\"].keys.map { |p|\n+          provisioner[\"provisioner\"][\"available_oses\"][p].keys\n+        }.flatten.uniq\n+\n+        arches.each do |arch|\n+          available_oses = provisioner[\"provisioner\"][\"available_oses\"].keys.select { |p|\n+            provisioner[\"provisioner\"][\"available_oses\"][p].has_key? arch\n+          }\n+\n+          platforms[arch] = available_oses.select { |p|","path":"crowbar_framework/app/models/node_object.rb","position":103,"original_position":103,"commit_id":"d1a10281de0d0adab644b1bcad102edb888075a5","original_commit_id":"d1a10281de0d0adab644b1bcad102edb888075a5","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Style/BlockDelimiters: Avoid using `{...}` for multi-line blocks. (https://github.com/bbatsov/ruby-style-guide#single-line-blocks)","created_at":"2015-10-16T10:56:21Z","updated_at":"2015-10-16T10:56:21Z","html_url":"https://github.com/crowbar/crowbar-core/pull/83#discussion_r42230540","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/42230540"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/83#discussion_r42230540"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/83","id":47896480,"html_url":"https://github.com/crowbar/crowbar-core/pull/83","diff_url":"https://github.com/crowbar/crowbar-core/pull/83.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/83.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/83","number":83,"state":"open","locked":false,"title":"Support multiple architecture for repo layout and OS attributes","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"Note that this contains https://github.com/crowbar/crowbar-core/pull/81 and https://github.com/crowbar/crowbar-core/pull/82, so please review these first.\r\n\r\nAlso, this depends on https://github.com/SUSE-Cloud/automation/pull/613.","created_at":"2015-10-16T10:56:09Z","updated_at":"2015-10-16T10:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f90d9b0f18a529a0c0aca9d799a628753074228","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/83/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/83/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/83/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/d1a10281de0d0adab644b1bcad102edb888075a5","head":{"label":"vuntz:multiarch-layout","ref":"multiarch-layout","sha":"d1a10281de0d0adab644b1bcad102edb888075a5","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"repo":{"id":41142179,"name":"crowbar-core","full_name":"vuntz/crowbar-core","owner":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vuntz/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/vuntz/crowbar-core","forks_url":"https://api.github.com/repos/vuntz/crowbar-core/forks","keys_url":"https://api.github.com/repos/vuntz/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuntz/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuntz/crowbar-core/teams","hooks_url":"https://api.github.com/repos/vuntz/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/vuntz/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/vuntz/crowbar-core/events","assignees_url":"https://api.github.com/repos/vuntz/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/vuntz/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/vuntz/crowbar-core/tags","blobs_url":"https://api.github.com/repos/vuntz/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuntz/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuntz/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuntz/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuntz/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/vuntz/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/vuntz/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/vuntz/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/vuntz/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/vuntz/crowbar-core/subscription","commits_url":"https://api.github.com/repos/vuntz/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuntz/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuntz/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuntz/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuntz/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/vuntz/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuntz/crowbar-core/merges","archive_url":"https://api.github.com/repos/vuntz/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuntz/crowbar-core/downloads","issues_url":"https://api.github.com/repos/vuntz/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/vuntz/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/vuntz/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/vuntz/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuntz/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/vuntz/crowbar-core/releases{/id}","created_at":"2015-08-21T07:34:19Z","updated_at":"2015-08-21T07:34:21Z","pushed_at":"2015-10-16T10:54:27Z","git_url":"git://github.com/vuntz/crowbar-core.git","ssh_url":"git@github.com:vuntz/crowbar-core.git","clone_url":"https://github.com/vuntz/crowbar-core.git","svn_url":"https://github.com/vuntz/crowbar-core","homepage":null,"size":103729,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"c6c92d188db49a127789ef85ce8adfa1da7c8054","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","created_at":"2015-07-13T09:31:28Z","updated_at":"2015-10-15T10:15:04Z","pushed_at":"2015-10-16T10:56:09Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":119706,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":25,"forks":21,"open_issues":25,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/83"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/83"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/83"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/d1a10281de0d0adab644b1bcad102edb888075a5"}}}}