{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/socorro-infra/pulls/comments/27994338","id":27994338,"diff_hunk":"@@ -43,15 +27,16 @@ resource \"aws_launch_configuration\" \"lc_for_admin_asg\" {\n     image_id = \"${lookup(var.base_ami, var.region)}\"\n     instance_type = \"t2.micro\"\n     key_name = \"${lookup(var.ssh_key_name, var.region)}\"\n+    iam_instance_profile = \"generic\"\n+    associate_public_ip_address = true\n     security_groups = [\n-        \"${aws_security_group.any_to_admin__ssh.name}\",\n-        \"${aws_security_group.private_to_admin__icmp.name}\"\n+        \"${aws_security_group.any_to_admin__ssh.id}\"","path":"terraform/admin/main.tf","position":32,"original_position":32,"commit_id":"160790425dded3239dd6279c8eb2783c51ba6a73","original_commit_id":"160790425dded3239dd6279c8eb2783c51ba6a73","user":{"login":"rhelmer","id":61412,"avatar_url":"https://avatars.githubusercontent.com/u/61412?v=3","gravatar_id":"","url":"https://api.github.com/users/rhelmer","html_url":"https://github.com/rhelmer","followers_url":"https://api.github.com/users/rhelmer/followers","following_url":"https://api.github.com/users/rhelmer/following{/other_user}","gists_url":"https://api.github.com/users/rhelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhelmer/subscriptions","organizations_url":"https://api.github.com/users/rhelmer/orgs","repos_url":"https://api.github.com/users/rhelmer/repos","events_url":"https://api.github.com/users/rhelmer/events{/privacy}","received_events_url":"https://api.github.com/users/rhelmer/received_events","type":"User","site_admin":false},"body":"If you're launching EC2 \"classic\" infra you pass the name, for EC2 \"VPC\" infra you must use the id, otherwise everything will launch but ASG will fail to spin up instances and complain about invalid parameter ```SecurityGroup```.\r\n\r\nThis PR makes us use VPC everywhere to avoid future confusion.","created_at":"2015-04-08T17:48:15Z","updated_at":"2015-04-08T17:48:15Z","html_url":"https://github.com/mozilla/socorro-infra/pull/52#discussion_r27994338","pull_request_url":"https://api.github.com/repos/mozilla/socorro-infra/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/mozilla/socorro-infra/pulls/comments/27994338"},"html":{"href":"https://github.com/mozilla/socorro-infra/pull/52#discussion_r27994338"},"pull_request":{"href":"https://api.github.com/repos/mozilla/socorro-infra/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/socorro-infra/pulls/52","id":32819912,"html_url":"https://github.com/mozilla/socorro-infra/pull/52","diff_url":"https://github.com/mozilla/socorro-infra/pull/52.diff","patch_url":"https://github.com/mozilla/socorro-infra/pull/52.patch","issue_url":"https://api.github.com/repos/mozilla/socorro-infra/issues/52","number":52,"state":"open","locked":false,"title":"bug 1152427 - use internal ELBs for ES+Rabbit, upgrade to tform 0.4","user":{"login":"rhelmer","id":61412,"avatar_url":"https://avatars.githubusercontent.com/u/61412?v=3","gravatar_id":"","url":"https://api.github.com/users/rhelmer","html_url":"https://github.com/rhelmer","followers_url":"https://api.github.com/users/rhelmer/followers","following_url":"https://api.github.com/users/rhelmer/following{/other_user}","gists_url":"https://api.github.com/users/rhelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhelmer/subscriptions","organizations_url":"https://api.github.com/users/rhelmer/orgs","repos_url":"https://api.github.com/users/rhelmer/repos","events_url":"https://api.github.com/users/rhelmer/events{/privacy}","received_events_url":"https://api.github.com/users/rhelmer/received_events","type":"User","site_admin":false},"body":"@phrawzty, I spent some time today getting our config working in Terraform 0.4 and learned an interesting thing - our account only supports VPC EC2 infra and not Classic. You can see this by going here:\r\n\r\nhttps://console.aws.amazon.com/ec2/v2/home?region=us-west-2\r\n\r\nLook at \"Supported Platforms\" on the right, and \"Default VPC\" below that. That's why we're getting a default VPC and subnets created for us, and our infra is going into them. As of Terraform 0.4 this means that we have to start specifying our subnet IDs to our AutoScaling Groups.\r\n\r\nThanks to @phinze for finding this - this looked like a different bug at first, and it took a while to figure out that's why we were still hitting the issue.\r\n\r\nIncidentally, understanding this helped me to see how we can configure internal ELBs - I've tested at least ```Collector``` and ```Elasticsearch``` roles and they seem to work!\r\n\r\nThe only downside I can see so far is that nodes now are in the VPC with no public IP address, so we're going to need to figure out some way to SSH into the nodes (bastion host or VPN.)","created_at":"2015-04-08T00:50:57Z","updated_at":"2015-04-08T17:48:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f36b4cb8e1e138ba07e8737e3b6b5f1fd21a3fc1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/socorro-infra/pulls/52/commits","review_comments_url":"https://api.github.com/repos/mozilla/socorro-infra/pulls/52/comments","review_comment_url":"https://api.github.com/repos/mozilla/socorro-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/socorro-infra/issues/52/comments","statuses_url":"https://api.github.com/repos/mozilla/socorro-infra/statuses/160790425dded3239dd6279c8eb2783c51ba6a73","head":{"label":"rhelmer:vpc-terraform-04","ref":"vpc-terraform-04","sha":"160790425dded3239dd6279c8eb2783c51ba6a73","user":{"login":"rhelmer","id":61412,"avatar_url":"https://avatars.githubusercontent.com/u/61412?v=3","gravatar_id":"","url":"https://api.github.com/users/rhelmer","html_url":"https://github.com/rhelmer","followers_url":"https://api.github.com/users/rhelmer/followers","following_url":"https://api.github.com/users/rhelmer/following{/other_user}","gists_url":"https://api.github.com/users/rhelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhelmer/subscriptions","organizations_url":"https://api.github.com/users/rhelmer/orgs","repos_url":"https://api.github.com/users/rhelmer/repos","events_url":"https://api.github.com/users/rhelmer/events{/privacy}","received_events_url":"https://api.github.com/users/rhelmer/received_events","type":"User","site_admin":false},"repo":{"id":31325057,"name":"socorro-infra","full_name":"rhelmer/socorro-infra","owner":{"login":"rhelmer","id":61412,"avatar_url":"https://avatars.githubusercontent.com/u/61412?v=3","gravatar_id":"","url":"https://api.github.com/users/rhelmer","html_url":"https://github.com/rhelmer","followers_url":"https://api.github.com/users/rhelmer/followers","following_url":"https://api.github.com/users/rhelmer/following{/other_user}","gists_url":"https://api.github.com/users/rhelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhelmer/subscriptions","organizations_url":"https://api.github.com/users/rhelmer/orgs","repos_url":"https://api.github.com/users/rhelmer/repos","events_url":"https://api.github.com/users/rhelmer/events{/privacy}","received_events_url":"https://api.github.com/users/rhelmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhelmer/socorro-infra","description":"Socorro infra repo (public).","fork":true,"url":"https://api.github.com/repos/rhelmer/socorro-infra","forks_url":"https://api.github.com/repos/rhelmer/socorro-infra/forks","keys_url":"https://api.github.com/repos/rhelmer/socorro-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhelmer/socorro-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhelmer/socorro-infra/teams","hooks_url":"https://api.github.com/repos/rhelmer/socorro-infra/hooks","issue_events_url":"https://api.github.com/repos/rhelmer/socorro-infra/issues/events{/number}","events_url":"https://api.github.com/repos/rhelmer/socorro-infra/events","assignees_url":"https://api.github.com/repos/rhelmer/socorro-infra/assignees{/user}","branches_url":"https://api.github.com/repos/rhelmer/socorro-infra/branches{/branch}","tags_url":"https://api.github.com/repos/rhelmer/socorro-infra/tags","blobs_url":"https://api.github.com/repos/rhelmer/socorro-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhelmer/socorro-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhelmer/socorro-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhelmer/socorro-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhelmer/socorro-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/rhelmer/socorro-infra/languages","stargazers_url":"https://api.github.com/repos/rhelmer/socorro-infra/stargazers","contributors_url":"https://api.github.com/repos/rhelmer/socorro-infra/contributors","subscribers_url":"https://api.github.com/repos/rhelmer/socorro-infra/subscribers","subscription_url":"https://api.github.com/repos/rhelmer/socorro-infra/subscription","commits_url":"https://api.github.com/repos/rhelmer/socorro-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhelmer/socorro-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhelmer/socorro-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhelmer/socorro-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhelmer/socorro-infra/contents/{+path}","compare_url":"https://api.github.com/repos/rhelmer/socorro-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhelmer/socorro-infra/merges","archive_url":"https://api.github.com/repos/rhelmer/socorro-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhelmer/socorro-infra/downloads","issues_url":"https://api.github.com/repos/rhelmer/socorro-infra/issues{/number}","pulls_url":"https://api.github.com/repos/rhelmer/socorro-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/rhelmer/socorro-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/rhelmer/socorro-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhelmer/socorro-infra/labels{/name}","releases_url":"https://api.github.com/repos/rhelmer/socorro-infra/releases{/id}","created_at":"2015-02-25T17:02:19Z","updated_at":"2015-03-28T00:16:18Z","pushed_at":"2015-04-08T17:43:50Z","git_url":"git://github.com/rhelmer/socorro-infra.git","ssh_url":"git@github.com:rhelmer/socorro-infra.git","clone_url":"https://github.com/rhelmer/socorro-infra.git","svn_url":"https://github.com/rhelmer/socorro-infra","homepage":null,"size":418,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"74baba4c761966a8d02528094e0b03a2859837b2","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":29144582,"name":"socorro-infra","full_name":"mozilla/socorro-infra","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/socorro-infra","description":"Socorro infra repo (public).","fork":false,"url":"https://api.github.com/repos/mozilla/socorro-infra","forks_url":"https://api.github.com/repos/mozilla/socorro-infra/forks","keys_url":"https://api.github.com/repos/mozilla/socorro-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/socorro-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/socorro-infra/teams","hooks_url":"https://api.github.com/repos/mozilla/socorro-infra/hooks","issue_events_url":"https://api.github.com/repos/mozilla/socorro-infra/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/socorro-infra/events","assignees_url":"https://api.github.com/repos/mozilla/socorro-infra/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/socorro-infra/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/socorro-infra/tags","blobs_url":"https://api.github.com/repos/mozilla/socorro-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/socorro-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/socorro-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/socorro-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/socorro-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/socorro-infra/languages","stargazers_url":"https://api.github.com/repos/mozilla/socorro-infra/stargazers","contributors_url":"https://api.github.com/repos/mozilla/socorro-infra/contributors","subscribers_url":"https://api.github.com/repos/mozilla/socorro-infra/subscribers","subscription_url":"https://api.github.com/repos/mozilla/socorro-infra/subscription","commits_url":"https://api.github.com/repos/mozilla/socorro-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/socorro-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/socorro-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/socorro-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/socorro-infra/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/socorro-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/socorro-infra/merges","archive_url":"https://api.github.com/repos/mozilla/socorro-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/socorro-infra/downloads","issues_url":"https://api.github.com/repos/mozilla/socorro-infra/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/socorro-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/socorro-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/socorro-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/socorro-infra/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/socorro-infra/releases{/id}","created_at":"2015-01-12T16:25:58Z","updated_at":"2015-04-07T16:09:57Z","pushed_at":"2015-04-08T17:43:50Z","git_url":"git://github.com/mozilla/socorro-infra.git","ssh_url":"git@github.com:mozilla/socorro-infra.git","clone_url":"https://github.com/mozilla/socorro-infra.git","svn_url":"https://github.com/mozilla/socorro-infra","homepage":null,"size":862,"stargazers_count":1,"watchers_count":1,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/socorro-infra/pulls/52"},"html":{"href":"https://github.com/mozilla/socorro-infra/pull/52"},"issue":{"href":"https://api.github.com/repos/mozilla/socorro-infra/issues/52"},"comments":{"href":"https://api.github.com/repos/mozilla/socorro-infra/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/socorro-infra/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/socorro-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/socorro-infra/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/socorro-infra/statuses/160790425dded3239dd6279c8eb2783c51ba6a73"}}}}