{"action":"created","comment":{"url":"https://api.github.com/repos/basho/riak-php-client/pulls/comments/31140158","id":31140158,"diff_hunk":"@@ -63,7 +67,9 @@ public function getName()\n      * Returns the buckets R-value If it is set,\n      * otherwise return the R-value for the client.\n      *\n-     * @return integer\n+     * @param null $r\n+     *\n+     * @return int\n      */\n     public function getR($r = null)","path":"src/Basho/Riak/Bucket.php","position":50,"original_position":50,"commit_id":"aad6637188cb7bb7cc69f9b403c6b6516dc5bbe1","original_commit_id":"aad6637188cb7bb7cc69f9b403c6b6516dc5bbe1","user":{"login":"MarcoDeBortoli","id":493257,"avatar_url":"https://avatars.githubusercontent.com/u/493257?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoDeBortoli","html_url":"https://github.com/MarcoDeBortoli","followers_url":"https://api.github.com/users/MarcoDeBortoli/followers","following_url":"https://api.github.com/users/MarcoDeBortoli/following{/other_user}","gists_url":"https://api.github.com/users/MarcoDeBortoli/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoDeBortoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoDeBortoli/subscriptions","organizations_url":"https://api.github.com/users/MarcoDeBortoli/orgs","repos_url":"https://api.github.com/users/MarcoDeBortoli/repos","events_url":"https://api.github.com/users/MarcoDeBortoli/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoDeBortoli/received_events","type":"User","site_admin":false},"body":"The only reason I can think why that's there is for testing purposes, still injecting the expected value of an accessor is pure evil. Also, unfortunately, it seems like that approach has been used a bit all around the places.\r\nAt first sight the accessor should return either the \"object value\" or the \"client value\" not a parameter for sure.","created_at":"2015-05-27T14:40:55Z","updated_at":"2015-05-27T14:40:55Z","html_url":"https://github.com/basho/riak-php-client/pull/98#discussion_r31140158","pull_request_url":"https://api.github.com/repos/basho/riak-php-client/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/basho/riak-php-client/pulls/comments/31140158"},"html":{"href":"https://github.com/basho/riak-php-client/pull/98#discussion_r31140158"},"pull_request":{"href":"https://api.github.com/repos/basho/riak-php-client/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/basho/riak-php-client/pulls/98","id":36307425,"html_url":"https://github.com/basho/riak-php-client/pull/98","diff_url":"https://github.com/basho/riak-php-client/pull/98.diff","patch_url":"https://github.com/basho/riak-php-client/pull/98.patch","issue_url":"https://api.github.com/repos/basho/riak-php-client/issues/98","number":98,"state":"open","locked":false,"title":"Issue65 and some cleanup","user":{"login":"christophermancini","id":131620,"avatar_url":"https://avatars.githubusercontent.com/u/131620?v=3","gravatar_id":"","url":"https://api.github.com/users/christophermancini","html_url":"https://github.com/christophermancini","followers_url":"https://api.github.com/users/christophermancini/followers","following_url":"https://api.github.com/users/christophermancini/following{/other_user}","gists_url":"https://api.github.com/users/christophermancini/gists{/gist_id}","starred_url":"https://api.github.com/users/christophermancini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophermancini/subscriptions","organizations_url":"https://api.github.com/users/christophermancini/orgs","repos_url":"https://api.github.com/users/christophermancini/repos","events_url":"https://api.github.com/users/christophermancini/events{/privacy}","received_events_url":"https://api.github.com/users/christophermancini/received_events","type":"User","site_admin":false},"body":"This is for removing the urldecode as requested in Issue #65 (CLIENTS-90). I also did some cleanup while I was in there.","created_at":"2015-05-27T14:09:54Z","updated_at":"2015-05-27T14:40:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd0fb8ea06c0a2d30ddc94150f2c9d52579a4c2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/basho/riak-php-client/pulls/98/commits","review_comments_url":"https://api.github.com/repos/basho/riak-php-client/pulls/98/comments","review_comment_url":"https://api.github.com/repos/basho/riak-php-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/basho/riak-php-client/issues/98/comments","statuses_url":"https://api.github.com/repos/basho/riak-php-client/statuses/aad6637188cb7bb7cc69f9b403c6b6516dc5bbe1","head":{"label":"basho:issue65","ref":"issue65","sha":"aad6637188cb7bb7cc69f9b403c6b6516dc5bbe1","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":613740,"name":"riak-php-client","full_name":"basho/riak-php-client","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/riak-php-client","description":"PHP clients for Riak","fork":false,"url":"https://api.github.com/repos/basho/riak-php-client","forks_url":"https://api.github.com/repos/basho/riak-php-client/forks","keys_url":"https://api.github.com/repos/basho/riak-php-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/riak-php-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/riak-php-client/teams","hooks_url":"https://api.github.com/repos/basho/riak-php-client/hooks","issue_events_url":"https://api.github.com/repos/basho/riak-php-client/issues/events{/number}","events_url":"https://api.github.com/repos/basho/riak-php-client/events","assignees_url":"https://api.github.com/repos/basho/riak-php-client/assignees{/user}","branches_url":"https://api.github.com/repos/basho/riak-php-client/branches{/branch}","tags_url":"https://api.github.com/repos/basho/riak-php-client/tags","blobs_url":"https://api.github.com/repos/basho/riak-php-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/riak-php-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/riak-php-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/riak-php-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/riak-php-client/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/riak-php-client/languages","stargazers_url":"https://api.github.com/repos/basho/riak-php-client/stargazers","contributors_url":"https://api.github.com/repos/basho/riak-php-client/contributors","subscribers_url":"https://api.github.com/repos/basho/riak-php-client/subscribers","subscription_url":"https://api.github.com/repos/basho/riak-php-client/subscription","commits_url":"https://api.github.com/repos/basho/riak-php-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/riak-php-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/riak-php-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/riak-php-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho/riak-php-client/contents/{+path}","compare_url":"https://api.github.com/repos/basho/riak-php-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/riak-php-client/merges","archive_url":"https://api.github.com/repos/basho/riak-php-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/riak-php-client/downloads","issues_url":"https://api.github.com/repos/basho/riak-php-client/issues{/number}","pulls_url":"https://api.github.com/repos/basho/riak-php-client/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/riak-php-client/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/riak-php-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/riak-php-client/labels{/name}","releases_url":"https://api.github.com/repos/basho/riak-php-client/releases{/id}","created_at":"2010-04-16T14:56:23Z","updated_at":"2015-05-21T10:35:50Z","pushed_at":"2015-05-27T14:23:17Z","git_url":"git://github.com/basho/riak-php-client.git","ssh_url":"git@github.com:basho/riak-php-client.git","clone_url":"https://github.com/basho/riak-php-client.git","svn_url":"https://github.com/basho/riak-php-client","homepage":"","size":3265,"stargazers_count":143,"watchers_count":143,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":61,"mirror_url":null,"open_issues_count":4,"forks":61,"open_issues":4,"watchers":143,"default_branch":"develop"}},"base":{"label":"basho:1.4.x","ref":"1.4.x","sha":"5ec7b8bdf86b21c6a8f36c17ef3a7e2b1f27929f","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":613740,"name":"riak-php-client","full_name":"basho/riak-php-client","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/riak-php-client","description":"PHP clients for Riak","fork":false,"url":"https://api.github.com/repos/basho/riak-php-client","forks_url":"https://api.github.com/repos/basho/riak-php-client/forks","keys_url":"https://api.github.com/repos/basho/riak-php-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/riak-php-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/riak-php-client/teams","hooks_url":"https://api.github.com/repos/basho/riak-php-client/hooks","issue_events_url":"https://api.github.com/repos/basho/riak-php-client/issues/events{/number}","events_url":"https://api.github.com/repos/basho/riak-php-client/events","assignees_url":"https://api.github.com/repos/basho/riak-php-client/assignees{/user}","branches_url":"https://api.github.com/repos/basho/riak-php-client/branches{/branch}","tags_url":"https://api.github.com/repos/basho/riak-php-client/tags","blobs_url":"https://api.github.com/repos/basho/riak-php-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/riak-php-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/riak-php-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/riak-php-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/riak-php-client/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/riak-php-client/languages","stargazers_url":"https://api.github.com/repos/basho/riak-php-client/stargazers","contributors_url":"https://api.github.com/repos/basho/riak-php-client/contributors","subscribers_url":"https://api.github.com/repos/basho/riak-php-client/subscribers","subscription_url":"https://api.github.com/repos/basho/riak-php-client/subscription","commits_url":"https://api.github.com/repos/basho/riak-php-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/riak-php-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/riak-php-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/riak-php-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho/riak-php-client/contents/{+path}","compare_url":"https://api.github.com/repos/basho/riak-php-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/riak-php-client/merges","archive_url":"https://api.github.com/repos/basho/riak-php-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/riak-php-client/downloads","issues_url":"https://api.github.com/repos/basho/riak-php-client/issues{/number}","pulls_url":"https://api.github.com/repos/basho/riak-php-client/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/riak-php-client/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/riak-php-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/riak-php-client/labels{/name}","releases_url":"https://api.github.com/repos/basho/riak-php-client/releases{/id}","created_at":"2010-04-16T14:56:23Z","updated_at":"2015-05-21T10:35:50Z","pushed_at":"2015-05-27T14:23:17Z","git_url":"git://github.com/basho/riak-php-client.git","ssh_url":"git@github.com:basho/riak-php-client.git","clone_url":"https://github.com/basho/riak-php-client.git","svn_url":"https://github.com/basho/riak-php-client","homepage":"","size":3265,"stargazers_count":143,"watchers_count":143,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":61,"mirror_url":null,"open_issues_count":4,"forks":61,"open_issues":4,"watchers":143,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/basho/riak-php-client/pulls/98"},"html":{"href":"https://github.com/basho/riak-php-client/pull/98"},"issue":{"href":"https://api.github.com/repos/basho/riak-php-client/issues/98"},"comments":{"href":"https://api.github.com/repos/basho/riak-php-client/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/basho/riak-php-client/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/basho/riak-php-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/basho/riak-php-client/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/basho/riak-php-client/statuses/aad6637188cb7bb7cc69f9b403c6b6516dc5bbe1"}}}}