{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4670","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4670/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4670/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4670/events","html_url":"https://github.com/NREL/EnergyPlus/pull/4670","id":54484353,"number":4670,"title":"4558 hpwh coil removing heat from tank","user":{"login":"nmerket","id":5325034,"avatar_url":"https://avatars.githubusercontent.com/u/5325034?v=3","gravatar_id":"","url":"https://api.github.com/users/nmerket","html_url":"https://github.com/nmerket","followers_url":"https://api.github.com/users/nmerket/followers","following_url":"https://api.github.com/users/nmerket/following{/other_user}","gists_url":"https://api.github.com/users/nmerket/gists{/gist_id}","starred_url":"https://api.github.com/users/nmerket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmerket/subscriptions","organizations_url":"https://api.github.com/users/nmerket/orgs","repos_url":"https://api.github.com/users/nmerket/repos","events_url":"https://api.github.com/users/nmerket/events{/privacy}","received_events_url":"https://api.github.com/users/nmerket/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-01-15T18:17:12Z","updated_at":"2015-01-26T20:15:44Z","closed_at":"2015-01-26T20:15:37Z","pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/4670","html_url":"https://github.com/NREL/EnergyPlus/pull/4670","diff_url":"https://github.com/NREL/EnergyPlus/pull/4670.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/4670.patch"},"body":"This is finally happening. This addresses issue #4558 and by extension #4455. \r\n\r\n - Fixes convergence on the loop that determines the condenser operating temperature in `CalcHeatPumpWaterHeater`\r\n - Fixes problem in both `CalcWaterThermalTankMixed` and `CalcWaterThermalTankStratified` that was causing the source side heat transfer rate to go negative by changing logic to treat heat pump water heater source side inlet heat transfer as a constant heat rate during a timestep instead of a constant temperature.\r\n - Added unit tests.\r\n - Added regression tests for HPWH with stratified tanks.\r\n - Generally cleaned up code in `CalcHeatPumpWaterHeater`, `CalcWaterThermalTankMixed`, and `CalcWaterThermalTankStratified` removing unnecessary duplicate code blocks for heating mode and converting to use references for the tank and heat pump water heater structs, which helps with readability.\r\n\r\nReviewer:\r\n@rraustad "},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/71529732","html_url":"https://github.com/NREL/EnergyPlus/pull/4670#issuecomment-71529732","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/4670","id":71529732,"user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars.githubusercontent.com/u/5778156?v=3","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"created_at":"2015-01-26T20:15:44Z","updated_at":"2015-01-26T20:15:44Z","body":"HPWH example file is working correctly although there is a mismatch in source and use side heat transfer rates as described in this conversation. The COP's in the original defect file look much better now than before. There are still things that need fixing (e.g., issue 4693 fan not autosizing, and source/use heat transfer rate) but those will get addressed as different issues. "}}