{"action":"created","issue":{"url":"https://api.github.com/repos/mikera/core.matrix/issues/219","labels_url":"https://api.github.com/repos/mikera/core.matrix/issues/219/labels{/name}","comments_url":"https://api.github.com/repos/mikera/core.matrix/issues/219/comments","events_url":"https://api.github.com/repos/mikera/core.matrix/issues/219/events","html_url":"https://github.com/mikera/core.matrix/pull/219","id":53465368,"number":219,"title":"Changes suggested by running Eastwood lint tool, mostly enabling masked ...","user":{"login":"jafingerhut","id":109629,"avatar_url":"https://avatars.githubusercontent.com/u/109629?v=3","gravatar_id":"","url":"https://api.github.com/users/jafingerhut","html_url":"https://github.com/jafingerhut","followers_url":"https://api.github.com/users/jafingerhut/followers","following_url":"https://api.github.com/users/jafingerhut/following{/other_user}","gists_url":"https://api.github.com/users/jafingerhut/gists{/gist_id}","starred_url":"https://api.github.com/users/jafingerhut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafingerhut/subscriptions","organizations_url":"https://api.github.com/users/jafingerhut/orgs","repos_url":"https://api.github.com/users/jafingerhut/repos","events_url":"https://api.github.com/users/jafingerhut/events{/privacy}","received_events_url":"https://api.github.com/users/jafingerhut/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-06T00:16:24Z","updated_at":"2015-01-06T09:43:26Z","closed_at":"2015-01-06T09:43:24Z","pull_request":{"url":"https://api.github.com/repos/mikera/core.matrix/pulls/219","html_url":"https://github.com/mikera/core.matrix/pull/219","diff_url":"https://github.com/mikera/core.matrix/pull/219.diff","patch_url":"https://github.com/mikera/core.matrix/pull/219.patch"},"body":"...tests\r\n\r\nThe core.matrix changes below were suggested by running the latest\r\nunreleased version of Eastwood (after version 0.2.1) on a slightly\r\nmodified version of core.matrix.  The local modification to\r\ncore.matrix I made, *not* included in this pull request, is hinted at\r\nin issue #218, which I made to my local core.matrix copy to avoid the\r\ncrash it causes with Eastwood.  Eastwood still throws a couple of\r\nexceptions on core.matrix after these changes, which I hope to fix in\r\na future release.\r\n\r\nMost of these changes are straightforward, e.g.:\r\n\r\n+ doc strings belong before the arg vector, not after it.\r\n\r\n+ Added missing (is ...) forms around expressions in tests\r\n\r\nFile src/main/clojure/clojure/core/matrix/utils.clj:\r\n\r\n+ There were two identical definitions of the macro 'error'.  I\r\n  deleted one.\r\n\r\nFiles src/test/clojure/clojure/core/matrix/test_api.clj and\r\nsrc/test/clojure/clojure/core/matrix/test_ndarray_implementation.clj:\r\n\r\n+ Renamed some deftest Var's that were duplicates of earlier names,\r\n  leading to some tests never being run.\r\n  https://github.com/jonase/eastwood#redefd-vars\r\n\r\nA few of these changes you should examine more carefully, as they may\r\nnot be what you want.\r\n\r\nFile src/main/clojure/clojure/core/matrix/compliance_tester.clj:\r\n\r\n+ Replaced a couple of calls to (or (= expr1 expr2)) with (is (= expr1\r\n  expr2))\r\n\r\n+ Function test-qr had a call to map with (is ...) inside of the\r\n  function, that was never getting called because map is lazy and the\r\n  return value was discarded.  I added a doall around the map call to\r\n  force evaluation of the result.  This caused an exception, and my\r\n  guess is that the suggested change I have in this patch is what was\r\n  desired: the args to map after the function should be a single\r\n  vector of 3 matrices, not two vectors.\r\n\r\nBefore these changes, when I ran 'lein do clean, test' I saw:\r\n\r\nRan 234 tests containing 11794 assertions.\r\n0 failures, 0 errors.\r\n\r\nWith these changes, I see:\r\n\r\nRan 237 tests containing 12384 assertions.\r\n2 failures, 0 errors.\r\n\r\nI haven't attempted to fix the failing tests, since you will probably\r\nhave a better idea how you would like to address those.  The test\r\nfailures are due to tests that were not being run before, and thus the\r\nfailures were masked.  They are not due to changes in behavior of the\r\n(non-test) code."},"comment":{"url":"https://api.github.com/repos/mikera/core.matrix/issues/comments/68845042","html_url":"https://github.com/mikera/core.matrix/pull/219#issuecomment-68845042","issue_url":"https://api.github.com/repos/mikera/core.matrix/issues/219","id":68845042,"user":{"login":"mikera","id":212007,"avatar_url":"https://avatars.githubusercontent.com/u/212007?v=3","gravatar_id":"","url":"https://api.github.com/users/mikera","html_url":"https://github.com/mikera","followers_url":"https://api.github.com/users/mikera/followers","following_url":"https://api.github.com/users/mikera/following{/other_user}","gists_url":"https://api.github.com/users/mikera/gists{/gist_id}","starred_url":"https://api.github.com/users/mikera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikera/subscriptions","organizations_url":"https://api.github.com/users/mikera/orgs","repos_url":"https://api.github.com/users/mikera/repos","events_url":"https://api.github.com/users/mikera/events{/privacy}","received_events_url":"https://api.github.com/users/mikera/received_events","type":"User","site_admin":false},"created_at":"2015-01-06T09:43:26Z","updated_at":"2015-01-06T09:43:26Z","body":"Thanks Andy! I will merge and fix these up."}}