{"action":"closed","number":46,"pull_request":{"url":"https://api.github.com/repos/rapid7/convection/pulls/46","id":45252257,"html_url":"https://github.com/rapid7/convection/pull/46","diff_url":"https://github.com/rapid7/convection/pull/46.diff","patch_url":"https://github.com/rapid7/convection/pull/46.patch","issue_url":"https://api.github.com/repos/rapid7/convection/issues/46","number":46,"state":"closed","locked":false,"title":"Allow specifying network_interfaces in ec2_instances","user":{"login":"bturner-r7","id":2836432,"avatar_url":"https://avatars.githubusercontent.com/u/2836432?v=3","gravatar_id":"","url":"https://api.github.com/users/bturner-r7","html_url":"https://github.com/bturner-r7","followers_url":"https://api.github.com/users/bturner-r7/followers","following_url":"https://api.github.com/users/bturner-r7/following{/other_user}","gists_url":"https://api.github.com/users/bturner-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/bturner-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bturner-r7/subscriptions","organizations_url":"https://api.github.com/users/bturner-r7/orgs","repos_url":"https://api.github.com/users/bturner-r7/repos","events_url":"https://api.github.com/users/bturner-r7/events{/privacy}","received_events_url":"https://api.github.com/users/bturner-r7/received_events","type":"User","site_admin":false},"body":"This adds support for the [EC2 NetworkInterface Embedded Property Type](http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-network-iface-embedded.html).  This allows you to declare network interfaces as part of an EC2 instance.  As far as I know, this is the only way to auto assign a public IP address when the VPC's auto-assign public IP is false.\r\n\r\nFor example, this supports:\r\n\r\n```ruby\r\nec2_instance 'MyInstance' do\r\n  image_id 'ami-12345678'\r\n  instance_type 't2.micro'\r\n  network_interface do\r\n    associate_public_ip_address true\r\n    security_group 'sg-12345678'\r\n    subnet 'subnet-12345678'\r\n  end\r\n  network_interface do\r\n    associate_public_ip_address false\r\n    security_group 'sg-87654321'\r\n    subnet 'subnet-12345678'\r\n  end\r\nend\r\n```\r\n\r\nIf this is accepted, we could probably build a much improved DSL around [Resource Property Types](http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-product-property-reference.html).","created_at":"2015-09-17T05:03:33Z","updated_at":"2015-09-17T18:57:01Z","closed_at":"2015-09-17T18:57:01Z","merged_at":"2015-09-17T18:57:01Z","merge_commit_sha":"39cdb051b6a2c77c95406fa1da7bf6316761d308","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/convection/pulls/46/commits","review_comments_url":"https://api.github.com/repos/rapid7/convection/pulls/46/comments","review_comment_url":"https://api.github.com/repos/rapid7/convection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/convection/issues/46/comments","statuses_url":"https://api.github.com/repos/rapid7/convection/statuses/5a508273e77942ff8e24add7da229e4fa1a20d58","head":{"label":"rapid7:add-network-interface","ref":"add-network-interface","sha":"5a508273e77942ff8e24add7da229e4fa1a20d58","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":29038297,"name":"convection","full_name":"rapid7/convection","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/convection","description":"A fully generic, modular DSL for AWS CloudFormation","fork":false,"url":"https://api.github.com/repos/rapid7/convection","forks_url":"https://api.github.com/repos/rapid7/convection/forks","keys_url":"https://api.github.com/repos/rapid7/convection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/convection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/convection/teams","hooks_url":"https://api.github.com/repos/rapid7/convection/hooks","issue_events_url":"https://api.github.com/repos/rapid7/convection/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/convection/events","assignees_url":"https://api.github.com/repos/rapid7/convection/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/convection/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/convection/tags","blobs_url":"https://api.github.com/repos/rapid7/convection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/convection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/convection/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/convection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/convection/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/convection/languages","stargazers_url":"https://api.github.com/repos/rapid7/convection/stargazers","contributors_url":"https://api.github.com/repos/rapid7/convection/contributors","subscribers_url":"https://api.github.com/repos/rapid7/convection/subscribers","subscription_url":"https://api.github.com/repos/rapid7/convection/subscription","commits_url":"https://api.github.com/repos/rapid7/convection/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/convection/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/convection/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/convection/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/convection/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/convection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/convection/merges","archive_url":"https://api.github.com/repos/rapid7/convection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/convection/downloads","issues_url":"https://api.github.com/repos/rapid7/convection/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/convection/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/convection/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/convection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/convection/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/convection/releases{/id}","created_at":"2015-01-09T22:31:11Z","updated_at":"2015-09-10T14:03:34Z","pushed_at":"2015-09-17T18:57:01Z","git_url":"git://github.com/rapid7/convection.git","ssh_url":"git@github.com:rapid7/convection.git","clone_url":"https://github.com/rapid7/convection.git","svn_url":"https://github.com/rapid7/convection","homepage":null,"size":1142,"stargazers_count":19,"watchers_count":19,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":19,"default_branch":"master"}},"base":{"label":"rapid7:v0.2","ref":"v0.2","sha":"7ddab894bedab360318f745231791ecb2134fae4","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":29038297,"name":"convection","full_name":"rapid7/convection","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/convection","description":"A fully generic, modular DSL for AWS CloudFormation","fork":false,"url":"https://api.github.com/repos/rapid7/convection","forks_url":"https://api.github.com/repos/rapid7/convection/forks","keys_url":"https://api.github.com/repos/rapid7/convection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/convection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/convection/teams","hooks_url":"https://api.github.com/repos/rapid7/convection/hooks","issue_events_url":"https://api.github.com/repos/rapid7/convection/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/convection/events","assignees_url":"https://api.github.com/repos/rapid7/convection/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/convection/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/convection/tags","blobs_url":"https://api.github.com/repos/rapid7/convection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/convection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/convection/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/convection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/convection/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/convection/languages","stargazers_url":"https://api.github.com/repos/rapid7/convection/stargazers","contributors_url":"https://api.github.com/repos/rapid7/convection/contributors","subscribers_url":"https://api.github.com/repos/rapid7/convection/subscribers","subscription_url":"https://api.github.com/repos/rapid7/convection/subscription","commits_url":"https://api.github.com/repos/rapid7/convection/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/convection/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/convection/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/convection/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/convection/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/convection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/convection/merges","archive_url":"https://api.github.com/repos/rapid7/convection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/convection/downloads","issues_url":"https://api.github.com/repos/rapid7/convection/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/convection/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/convection/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/convection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/convection/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/convection/releases{/id}","created_at":"2015-01-09T22:31:11Z","updated_at":"2015-09-10T14:03:34Z","pushed_at":"2015-09-17T18:57:01Z","git_url":"git://github.com/rapid7/convection.git","ssh_url":"git@github.com:rapid7/convection.git","clone_url":"https://github.com/rapid7/convection.git","svn_url":"https://github.com/rapid7/convection","homepage":null,"size":1142,"stargazers_count":19,"watchers_count":19,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/convection/pulls/46"},"html":{"href":"https://github.com/rapid7/convection/pull/46"},"issue":{"href":"https://api.github.com/repos/rapid7/convection/issues/46"},"comments":{"href":"https://api.github.com/repos/rapid7/convection/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/convection/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/convection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/convection/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/convection/statuses/5a508273e77942ff8e24add7da229e4fa1a20d58"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jmanero-r7","id":8549280,"avatar_url":"https://avatars.githubusercontent.com/u/8549280?v=3","gravatar_id":"","url":"https://api.github.com/users/jmanero-r7","html_url":"https://github.com/jmanero-r7","followers_url":"https://api.github.com/users/jmanero-r7/followers","following_url":"https://api.github.com/users/jmanero-r7/following{/other_user}","gists_url":"https://api.github.com/users/jmanero-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jmanero-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmanero-r7/subscriptions","organizations_url":"https://api.github.com/users/jmanero-r7/orgs","repos_url":"https://api.github.com/users/jmanero-r7/repos","events_url":"https://api.github.com/users/jmanero-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jmanero-r7/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":3,"additions":95,"deletions":0,"changed_files":4}}