{"action":"created","comment":{"url":"https://api.github.com/repos/databricks/spark-tfocs/pulls/comments/35161767","id":35161767,"diff_hunk":"@@ -52,9 +53,17 @@ class LinearFunctionSuite extends FunSuite with MLlibTestSparkContext with Match\n   test(\"TransposeProductVectorRDDVector multiplies properly\") {\n \n     assert(Vectors.dense(29.0, 40.0, 51.0) ==\n-      new TransposeProductVectorRDDVector(matrix2)(sc.parallelize(Array(Vectors.dense(5.0),\n+      new TransposeProductVectorRDDVector(matrix)(sc.parallelize(Array(Vectors.dense(5.0),\n         Vectors.dense(6.0)), 2)),\n       \"should return the correct product\")\n   }\n \n+  test(\"TransposeProductVectorRDDVector checks for mismatched partition vectors\") {\n+\n+    a[SparkException] should be thrownBy {","path":"src/test/scala/org/apache/spark/mllib/optimization/tfocs/LinearFunctionSuite.scala","position":50,"original_position":50,"commit_id":"fb7f8e0fce04bad7820f141efcdf4e28eb0b8a9b","original_commit_id":"fb7f8e0fce04bad7820f141efcdf4e28eb0b8a9b","user":{"login":"mengxr","id":829644,"avatar_url":"https://avatars.githubusercontent.com/u/829644?v=3","gravatar_id":"","url":"https://api.github.com/users/mengxr","html_url":"https://github.com/mengxr","followers_url":"https://api.github.com/users/mengxr/followers","following_url":"https://api.github.com/users/mengxr/following{/other_user}","gists_url":"https://api.github.com/users/mengxr/gists{/gist_id}","starred_url":"https://api.github.com/users/mengxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengxr/subscriptions","organizations_url":"https://api.github.com/users/mengxr/orgs","repos_url":"https://api.github.com/users/mengxr/repos","events_url":"https://api.github.com/users/mengxr/events{/privacy}","received_events_url":"https://api.github.com/users/mengxr/received_events","type":"User","site_admin":false},"body":"~~~scala\r\nintercept[SparkException] {\r\n  new TransposeProductVectorRDDVector(matrix)(\r\n    sc.parallelize(Array(Vectors.dense(5.0, 6.0), Vectors.zeros(0)), 2))  \r\n}\r\n~~~","created_at":"2015-07-21T22:21:11Z","updated_at":"2015-07-21T22:21:11Z","html_url":"https://github.com/databricks/spark-tfocs/pull/4#discussion_r35161767","pull_request_url":"https://api.github.com/repos/databricks/spark-tfocs/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/databricks/spark-tfocs/pulls/comments/35161767"},"html":{"href":"https://github.com/databricks/spark-tfocs/pull/4#discussion_r35161767"},"pull_request":{"href":"https://api.github.com/repos/databricks/spark-tfocs/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/databricks/spark-tfocs/pulls/4","id":40072193,"html_url":"https://github.com/databricks/spark-tfocs/pull/4","diff_url":"https://github.com/databricks/spark-tfocs/pull/4.diff","patch_url":"https://github.com/databricks/spark-tfocs/pull/4.patch","issue_url":"https://api.github.com/repos/databricks/spark-tfocs/issues/4","number":4,"state":"open","locked":false,"title":"Miscellaneous clean ups.","user":{"login":"staple","id":307174,"avatar_url":"https://avatars.githubusercontent.com/u/307174?v=3","gravatar_id":"","url":"https://api.github.com/users/staple","html_url":"https://github.com/staple","followers_url":"https://api.github.com/users/staple/followers","following_url":"https://api.github.com/users/staple/following{/other_user}","gists_url":"https://api.github.com/users/staple/gists{/gist_id}","starred_url":"https://api.github.com/users/staple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staple/subscriptions","organizations_url":"https://api.github.com/users/staple/orgs","repos_url":"https://api.github.com/users/staple/repos","events_url":"https://api.github.com/users/staple/events{/privacy}","received_events_url":"https://api.github.com/users/staple/received_events","type":"User","site_admin":false},"body":"- added checked iterator function helper\r\n- rename functions to match tfocs names\r\n- converted tfocs suite to use RDD[Vector] and compared its output to the most recent revision of tfocs\r\n- added, using mllib TestingUtils\r\n- added additional tests\r\n- other minor cleanups","created_at":"2015-07-15T21:31:56Z","updated_at":"2015-07-21T22:21:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b6f35a55a11a108d86a0fa96006d38bbb52ec49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/databricks/spark-tfocs/pulls/4/commits","review_comments_url":"https://api.github.com/repos/databricks/spark-tfocs/pulls/4/comments","review_comment_url":"https://api.github.com/repos/databricks/spark-tfocs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/databricks/spark-tfocs/issues/4/comments","statuses_url":"https://api.github.com/repos/databricks/spark-tfocs/statuses/fb7f8e0fce04bad7820f141efcdf4e28eb0b8a9b","head":{"label":"staple:cleanups","ref":"cleanups","sha":"fb7f8e0fce04bad7820f141efcdf4e28eb0b8a9b","user":{"login":"staple","id":307174,"avatar_url":"https://avatars.githubusercontent.com/u/307174?v=3","gravatar_id":"","url":"https://api.github.com/users/staple","html_url":"https://github.com/staple","followers_url":"https://api.github.com/users/staple/followers","following_url":"https://api.github.com/users/staple/following{/other_user}","gists_url":"https://api.github.com/users/staple/gists{/gist_id}","starred_url":"https://api.github.com/users/staple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staple/subscriptions","organizations_url":"https://api.github.com/users/staple/orgs","repos_url":"https://api.github.com/users/staple/repos","events_url":"https://api.github.com/users/staple/events{/privacy}","received_events_url":"https://api.github.com/users/staple/received_events","type":"User","site_admin":false},"repo":{"id":39109608,"name":"spark-tfocs","full_name":"staple/spark-tfocs","owner":{"login":"staple","id":307174,"avatar_url":"https://avatars.githubusercontent.com/u/307174?v=3","gravatar_id":"","url":"https://api.github.com/users/staple","html_url":"https://github.com/staple","followers_url":"https://api.github.com/users/staple/followers","following_url":"https://api.github.com/users/staple/following{/other_user}","gists_url":"https://api.github.com/users/staple/gists{/gist_id}","starred_url":"https://api.github.com/users/staple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staple/subscriptions","organizations_url":"https://api.github.com/users/staple/orgs","repos_url":"https://api.github.com/users/staple/repos","events_url":"https://api.github.com/users/staple/events{/privacy}","received_events_url":"https://api.github.com/users/staple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/staple/spark-tfocs","description":"A Spark port of TFOCS: Templates for First-Order Conic Solvers (cvxr.com/tfocs)","fork":true,"url":"https://api.github.com/repos/staple/spark-tfocs","forks_url":"https://api.github.com/repos/staple/spark-tfocs/forks","keys_url":"https://api.github.com/repos/staple/spark-tfocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/staple/spark-tfocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/staple/spark-tfocs/teams","hooks_url":"https://api.github.com/repos/staple/spark-tfocs/hooks","issue_events_url":"https://api.github.com/repos/staple/spark-tfocs/issues/events{/number}","events_url":"https://api.github.com/repos/staple/spark-tfocs/events","assignees_url":"https://api.github.com/repos/staple/spark-tfocs/assignees{/user}","branches_url":"https://api.github.com/repos/staple/spark-tfocs/branches{/branch}","tags_url":"https://api.github.com/repos/staple/spark-tfocs/tags","blobs_url":"https://api.github.com/repos/staple/spark-tfocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/staple/spark-tfocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/staple/spark-tfocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/staple/spark-tfocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/staple/spark-tfocs/statuses/{sha}","languages_url":"https://api.github.com/repos/staple/spark-tfocs/languages","stargazers_url":"https://api.github.com/repos/staple/spark-tfocs/stargazers","contributors_url":"https://api.github.com/repos/staple/spark-tfocs/contributors","subscribers_url":"https://api.github.com/repos/staple/spark-tfocs/subscribers","subscription_url":"https://api.github.com/repos/staple/spark-tfocs/subscription","commits_url":"https://api.github.com/repos/staple/spark-tfocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/staple/spark-tfocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/staple/spark-tfocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/staple/spark-tfocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/staple/spark-tfocs/contents/{+path}","compare_url":"https://api.github.com/repos/staple/spark-tfocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/staple/spark-tfocs/merges","archive_url":"https://api.github.com/repos/staple/spark-tfocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/staple/spark-tfocs/downloads","issues_url":"https://api.github.com/repos/staple/spark-tfocs/issues{/number}","pulls_url":"https://api.github.com/repos/staple/spark-tfocs/pulls{/number}","milestones_url":"https://api.github.com/repos/staple/spark-tfocs/milestones{/number}","notifications_url":"https://api.github.com/repos/staple/spark-tfocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/staple/spark-tfocs/labels{/name}","releases_url":"https://api.github.com/repos/staple/spark-tfocs/releases{/id}","created_at":"2015-07-15T01:32:01Z","updated_at":"2015-07-15T01:36:51Z","pushed_at":"2015-07-21T22:11:35Z","git_url":"git://github.com/staple/spark-tfocs.git","ssh_url":"git@github.com:staple/spark-tfocs.git","clone_url":"https://github.com/staple/spark-tfocs.git","svn_url":"https://github.com/staple/spark-tfocs","homepage":"","size":114,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"databricks:master","ref":"master","sha":"0ffe15a4eb9e1bfe4f9108f0e725d31784ff5d52","user":{"login":"databricks","id":4998052,"avatar_url":"https://avatars.githubusercontent.com/u/4998052?v=3","gravatar_id":"","url":"https://api.github.com/users/databricks","html_url":"https://github.com/databricks","followers_url":"https://api.github.com/users/databricks/followers","following_url":"https://api.github.com/users/databricks/following{/other_user}","gists_url":"https://api.github.com/users/databricks/gists{/gist_id}","starred_url":"https://api.github.com/users/databricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databricks/subscriptions","organizations_url":"https://api.github.com/users/databricks/orgs","repos_url":"https://api.github.com/users/databricks/repos","events_url":"https://api.github.com/users/databricks/events{/privacy}","received_events_url":"https://api.github.com/users/databricks/received_events","type":"Organization","site_admin":false},"repo":{"id":38891827,"name":"spark-tfocs","full_name":"databricks/spark-tfocs","owner":{"login":"databricks","id":4998052,"avatar_url":"https://avatars.githubusercontent.com/u/4998052?v=3","gravatar_id":"","url":"https://api.github.com/users/databricks","html_url":"https://github.com/databricks","followers_url":"https://api.github.com/users/databricks/followers","following_url":"https://api.github.com/users/databricks/following{/other_user}","gists_url":"https://api.github.com/users/databricks/gists{/gist_id}","starred_url":"https://api.github.com/users/databricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databricks/subscriptions","organizations_url":"https://api.github.com/users/databricks/orgs","repos_url":"https://api.github.com/users/databricks/repos","events_url":"https://api.github.com/users/databricks/events{/privacy}","received_events_url":"https://api.github.com/users/databricks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/databricks/spark-tfocs","description":"A Spark port of TFOCS: Templates for First-Order Conic Solvers (cvxr.com/tfocs)","fork":false,"url":"https://api.github.com/repos/databricks/spark-tfocs","forks_url":"https://api.github.com/repos/databricks/spark-tfocs/forks","keys_url":"https://api.github.com/repos/databricks/spark-tfocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/databricks/spark-tfocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/databricks/spark-tfocs/teams","hooks_url":"https://api.github.com/repos/databricks/spark-tfocs/hooks","issue_events_url":"https://api.github.com/repos/databricks/spark-tfocs/issues/events{/number}","events_url":"https://api.github.com/repos/databricks/spark-tfocs/events","assignees_url":"https://api.github.com/repos/databricks/spark-tfocs/assignees{/user}","branches_url":"https://api.github.com/repos/databricks/spark-tfocs/branches{/branch}","tags_url":"https://api.github.com/repos/databricks/spark-tfocs/tags","blobs_url":"https://api.github.com/repos/databricks/spark-tfocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/databricks/spark-tfocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/databricks/spark-tfocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/databricks/spark-tfocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/databricks/spark-tfocs/statuses/{sha}","languages_url":"https://api.github.com/repos/databricks/spark-tfocs/languages","stargazers_url":"https://api.github.com/repos/databricks/spark-tfocs/stargazers","contributors_url":"https://api.github.com/repos/databricks/spark-tfocs/contributors","subscribers_url":"https://api.github.com/repos/databricks/spark-tfocs/subscribers","subscription_url":"https://api.github.com/repos/databricks/spark-tfocs/subscription","commits_url":"https://api.github.com/repos/databricks/spark-tfocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/databricks/spark-tfocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/databricks/spark-tfocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/databricks/spark-tfocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/databricks/spark-tfocs/contents/{+path}","compare_url":"https://api.github.com/repos/databricks/spark-tfocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/databricks/spark-tfocs/merges","archive_url":"https://api.github.com/repos/databricks/spark-tfocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/databricks/spark-tfocs/downloads","issues_url":"https://api.github.com/repos/databricks/spark-tfocs/issues{/number}","pulls_url":"https://api.github.com/repos/databricks/spark-tfocs/pulls{/number}","milestones_url":"https://api.github.com/repos/databricks/spark-tfocs/milestones{/number}","notifications_url":"https://api.github.com/repos/databricks/spark-tfocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/databricks/spark-tfocs/labels{/name}","releases_url":"https://api.github.com/repos/databricks/spark-tfocs/releases{/id}","created_at":"2015-07-10T16:57:01Z","updated_at":"2015-07-20T16:05:26Z","pushed_at":"2015-07-21T22:11:37Z","git_url":"git://github.com/databricks/spark-tfocs.git","ssh_url":"git@github.com:databricks/spark-tfocs.git","clone_url":"https://github.com/databricks/spark-tfocs.git","svn_url":"https://github.com/databricks/spark-tfocs","homepage":"","size":222,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/databricks/spark-tfocs/pulls/4"},"html":{"href":"https://github.com/databricks/spark-tfocs/pull/4"},"issue":{"href":"https://api.github.com/repos/databricks/spark-tfocs/issues/4"},"comments":{"href":"https://api.github.com/repos/databricks/spark-tfocs/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/databricks/spark-tfocs/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/databricks/spark-tfocs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/databricks/spark-tfocs/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/databricks/spark-tfocs/statuses/fb7f8e0fce04bad7820f141efcdf4e28eb0b8a9b"}}}}