{"action":"closed","number":116,"pull_request":{"url":"https://api.github.com/repos/FlipSideHR/FlyptoX/pulls/116","id":40728527,"html_url":"https://github.com/FlipSideHR/FlyptoX/pull/116","diff_url":"https://github.com/FlipSideHR/FlyptoX/pull/116.diff","patch_url":"https://github.com/FlipSideHR/FlyptoX/pull/116.patch","issue_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/issues/116","number":116,"state":"closed","locked":false,"title":"emit JSON in trade event, not a bookshelf model","user":{"login":"mnaamani","id":1621012,"avatar_url":"https://avatars.githubusercontent.com/u/1621012?v=3","gravatar_id":"","url":"https://api.github.com/users/mnaamani","html_url":"https://github.com/mnaamani","followers_url":"https://api.github.com/users/mnaamani/followers","following_url":"https://api.github.com/users/mnaamani/following{/other_user}","gists_url":"https://api.github.com/users/mnaamani/gists{/gist_id}","starred_url":"https://api.github.com/users/mnaamani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnaamani/subscriptions","organizations_url":"https://api.github.com/users/mnaamani/orgs","repos_url":"https://api.github.com/users/mnaamani/repos","events_url":"https://api.github.com/users/mnaamani/events{/privacy}","received_events_url":"https://api.github.com/users/mnaamani/received_events","type":"User","site_admin":false},"body":"Just attempting to keep a consistent data format of the models when being passed around in events.. with the data returned from api calls..  so data format coming down the pipe over socket.io and rest api calls is identical.. \r\n\r\nNeed to redo this again later.. especially  to make sure date strings are always in ISO 8601 format.\r\n\r\nBest place I think would be to override toJSON in the bookshelf  model definition.\r\n\r\nI'll explore that and come back with a solution.\r\n\r\nThis PR however can me merged once reviewed.","created_at":"2015-07-23T23:12:24Z","updated_at":"2015-07-23T23:44:13Z","closed_at":"2015-07-23T23:44:13Z","merged_at":"2015-07-23T23:44:13Z","merge_commit_sha":"53799e7286aa0143312478436592d78ca17cba54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/pulls/116/commits","review_comments_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/pulls/116/comments","review_comment_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/issues/116/comments","statuses_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/statuses/f4eeb425b4fb9104a75d6f2ea8c6f2f59ae4c35a","head":{"label":"mnaamani:matcher","ref":"matcher","sha":"f4eeb425b4fb9104a75d6f2ea8c6f2f59ae4c35a","user":{"login":"mnaamani","id":1621012,"avatar_url":"https://avatars.githubusercontent.com/u/1621012?v=3","gravatar_id":"","url":"https://api.github.com/users/mnaamani","html_url":"https://github.com/mnaamani","followers_url":"https://api.github.com/users/mnaamani/followers","following_url":"https://api.github.com/users/mnaamani/following{/other_user}","gists_url":"https://api.github.com/users/mnaamani/gists{/gist_id}","starred_url":"https://api.github.com/users/mnaamani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnaamani/subscriptions","organizations_url":"https://api.github.com/users/mnaamani/orgs","repos_url":"https://api.github.com/users/mnaamani/repos","events_url":"https://api.github.com/users/mnaamani/events{/privacy}","received_events_url":"https://api.github.com/users/mnaamani/received_events","type":"User","site_admin":false},"repo":{"id":39029624,"name":"FlyptoX","full_name":"mnaamani/FlyptoX","owner":{"login":"mnaamani","id":1621012,"avatar_url":"https://avatars.githubusercontent.com/u/1621012?v=3","gravatar_id":"","url":"https://api.github.com/users/mnaamani","html_url":"https://github.com/mnaamani","followers_url":"https://api.github.com/users/mnaamani/followers","following_url":"https://api.github.com/users/mnaamani/following{/other_user}","gists_url":"https://api.github.com/users/mnaamani/gists{/gist_id}","starred_url":"https://api.github.com/users/mnaamani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnaamani/subscriptions","organizations_url":"https://api.github.com/users/mnaamani/orgs","repos_url":"https://api.github.com/users/mnaamani/repos","events_url":"https://api.github.com/users/mnaamani/events{/privacy}","received_events_url":"https://api.github.com/users/mnaamani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mnaamani/FlyptoX","description":"Open-source implementation of a crypto-currency exchange with Node.js","fork":true,"url":"https://api.github.com/repos/mnaamani/FlyptoX","forks_url":"https://api.github.com/repos/mnaamani/FlyptoX/forks","keys_url":"https://api.github.com/repos/mnaamani/FlyptoX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnaamani/FlyptoX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnaamani/FlyptoX/teams","hooks_url":"https://api.github.com/repos/mnaamani/FlyptoX/hooks","issue_events_url":"https://api.github.com/repos/mnaamani/FlyptoX/issues/events{/number}","events_url":"https://api.github.com/repos/mnaamani/FlyptoX/events","assignees_url":"https://api.github.com/repos/mnaamani/FlyptoX/assignees{/user}","branches_url":"https://api.github.com/repos/mnaamani/FlyptoX/branches{/branch}","tags_url":"https://api.github.com/repos/mnaamani/FlyptoX/tags","blobs_url":"https://api.github.com/repos/mnaamani/FlyptoX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnaamani/FlyptoX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnaamani/FlyptoX/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnaamani/FlyptoX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnaamani/FlyptoX/statuses/{sha}","languages_url":"https://api.github.com/repos/mnaamani/FlyptoX/languages","stargazers_url":"https://api.github.com/repos/mnaamani/FlyptoX/stargazers","contributors_url":"https://api.github.com/repos/mnaamani/FlyptoX/contributors","subscribers_url":"https://api.github.com/repos/mnaamani/FlyptoX/subscribers","subscription_url":"https://api.github.com/repos/mnaamani/FlyptoX/subscription","commits_url":"https://api.github.com/repos/mnaamani/FlyptoX/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnaamani/FlyptoX/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnaamani/FlyptoX/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnaamani/FlyptoX/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnaamani/FlyptoX/contents/{+path}","compare_url":"https://api.github.com/repos/mnaamani/FlyptoX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnaamani/FlyptoX/merges","archive_url":"https://api.github.com/repos/mnaamani/FlyptoX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnaamani/FlyptoX/downloads","issues_url":"https://api.github.com/repos/mnaamani/FlyptoX/issues{/number}","pulls_url":"https://api.github.com/repos/mnaamani/FlyptoX/pulls{/number}","milestones_url":"https://api.github.com/repos/mnaamani/FlyptoX/milestones{/number}","notifications_url":"https://api.github.com/repos/mnaamani/FlyptoX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnaamani/FlyptoX/labels{/name}","releases_url":"https://api.github.com/repos/mnaamani/FlyptoX/releases{/id}","created_at":"2015-07-13T18:24:30Z","updated_at":"2015-07-13T18:24:31Z","pushed_at":"2015-07-23T23:14:04Z","git_url":"git://github.com/mnaamani/FlyptoX.git","ssh_url":"git@github.com:mnaamani/FlyptoX.git","clone_url":"https://github.com/mnaamani/FlyptoX.git","svn_url":"https://github.com/mnaamani/FlyptoX","homepage":"","size":475,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FlipSideHR:master","ref":"master","sha":"3b0ac987ca7eab7324e2513652fbb42d0fc6f46d","user":{"login":"FlipSideHR","id":13241933,"avatar_url":"https://avatars.githubusercontent.com/u/13241933?v=3","gravatar_id":"","url":"https://api.github.com/users/FlipSideHR","html_url":"https://github.com/FlipSideHR","followers_url":"https://api.github.com/users/FlipSideHR/followers","following_url":"https://api.github.com/users/FlipSideHR/following{/other_user}","gists_url":"https://api.github.com/users/FlipSideHR/gists{/gist_id}","starred_url":"https://api.github.com/users/FlipSideHR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlipSideHR/subscriptions","organizations_url":"https://api.github.com/users/FlipSideHR/orgs","repos_url":"https://api.github.com/users/FlipSideHR/repos","events_url":"https://api.github.com/users/FlipSideHR/events{/privacy}","received_events_url":"https://api.github.com/users/FlipSideHR/received_events","type":"Organization","site_admin":false},"repo":{"id":38936465,"name":"FlyptoX","full_name":"FlipSideHR/FlyptoX","owner":{"login":"FlipSideHR","id":13241933,"avatar_url":"https://avatars.githubusercontent.com/u/13241933?v=3","gravatar_id":"","url":"https://api.github.com/users/FlipSideHR","html_url":"https://github.com/FlipSideHR","followers_url":"https://api.github.com/users/FlipSideHR/followers","following_url":"https://api.github.com/users/FlipSideHR/following{/other_user}","gists_url":"https://api.github.com/users/FlipSideHR/gists{/gist_id}","starred_url":"https://api.github.com/users/FlipSideHR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlipSideHR/subscriptions","organizations_url":"https://api.github.com/users/FlipSideHR/orgs","repos_url":"https://api.github.com/users/FlipSideHR/repos","events_url":"https://api.github.com/users/FlipSideHR/events{/privacy}","received_events_url":"https://api.github.com/users/FlipSideHR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FlipSideHR/FlyptoX","description":"Open source Node.js crypto-currency exchange","fork":false,"url":"https://api.github.com/repos/FlipSideHR/FlyptoX","forks_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/forks","keys_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/teams","hooks_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/hooks","issue_events_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/issues/events{/number}","events_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/events","assignees_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/assignees{/user}","branches_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/branches{/branch}","tags_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/tags","blobs_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/git/refs{/sha}","trees_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/statuses/{sha}","languages_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/languages","stargazers_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/stargazers","contributors_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/contributors","subscribers_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/subscribers","subscription_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/subscription","commits_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/commits{/sha}","git_commits_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/git/commits{/sha}","comments_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/comments{/number}","issue_comment_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/issues/comments{/number}","contents_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/contents/{+path}","compare_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/merges","archive_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/downloads","issues_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/issues{/number}","pulls_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/pulls{/number}","milestones_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/milestones{/number}","notifications_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/labels{/name}","releases_url":"https://api.github.com/repos/FlipSideHR/FlyptoX/releases{/id}","created_at":"2015-07-11T18:41:41Z","updated_at":"2015-07-20T17:52:10Z","pushed_at":"2015-07-23T23:44:13Z","git_url":"git://github.com/FlipSideHR/FlyptoX.git","ssh_url":"git@github.com:FlipSideHR/FlyptoX.git","clone_url":"https://github.com/FlipSideHR/FlyptoX.git","svn_url":"https://github.com/FlipSideHR/FlyptoX","homepage":"","size":1132,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":14,"forks":5,"open_issues":14,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FlipSideHR/FlyptoX/pulls/116"},"html":{"href":"https://github.com/FlipSideHR/FlyptoX/pull/116"},"issue":{"href":"https://api.github.com/repos/FlipSideHR/FlyptoX/issues/116"},"comments":{"href":"https://api.github.com/repos/FlipSideHR/FlyptoX/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/FlipSideHR/FlyptoX/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/FlipSideHR/FlyptoX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FlipSideHR/FlyptoX/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/FlipSideHR/FlyptoX/statuses/f4eeb425b4fb9104a75d6f2ea8c6f2f59ae4c35a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"RWTreichel","id":7990780,"avatar_url":"https://avatars.githubusercontent.com/u/7990780?v=3","gravatar_id":"","url":"https://api.github.com/users/RWTreichel","html_url":"https://github.com/RWTreichel","followers_url":"https://api.github.com/users/RWTreichel/followers","following_url":"https://api.github.com/users/RWTreichel/following{/other_user}","gists_url":"https://api.github.com/users/RWTreichel/gists{/gist_id}","starred_url":"https://api.github.com/users/RWTreichel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWTreichel/subscriptions","organizations_url":"https://api.github.com/users/RWTreichel/orgs","repos_url":"https://api.github.com/users/RWTreichel/repos","events_url":"https://api.github.com/users/RWTreichel/events{/privacy}","received_events_url":"https://api.github.com/users/RWTreichel/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":5,"changed_files":2}}