{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/38752753","id":38752753,"diff_hunk":"@@ -1382,10 +1382,9 @@ bool ParameterHandler::read_input (const std::string &filename,\n   try\n     {\n       std::string openname = search.find(filename);\n-      std::ifstream input (openname.c_str());\n-      AssertThrow(input, ExcIO());\n-\n-      return read_input (input, filename);\n+      std::ifstream file (openname.c_str());\n+      AssertThrow(file, ExcIO());\n+      return read_input_from_string (openname.c_str());","path":"source/base/parameter_handler.cc","position":10,"original_position":10,"commit_id":"13a88994aa0455f0fa7a29484a2d3165a460d0fd","original_commit_id":"13a88994aa0455f0fa7a29484a2d3165a460d0fd","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"I don't think this would work. Did you test this? You pass the *file name*, not the *content of the file* to `read_input_from_string`. My idea was that you simply read the entire file into a string (basically like you did in the first round of review, but without the processing) and then pass that string to `read_input_from_string()`.","created_at":"2015-09-04T13:47:08Z","updated_at":"2015-09-04T13:47:08Z","html_url":"https://github.com/dealii/dealii/pull/1520#discussion_r38752753","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/1520","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/38752753"},"html":{"href":"https://github.com/dealii/dealii/pull/1520#discussion_r38752753"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1520"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/1520","id":44095553,"html_url":"https://github.com/dealii/dealii/pull/1520","diff_url":"https://github.com/dealii/dealii/pull/1520.diff","patch_url":"https://github.com/dealii/dealii/pull/1520.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/1520","number":1520,"state":"open","locked":false,"title":"[WIP] Allow to use \"\\\" in the file of parameters","user":{"login":"asartori86","id":10710861,"avatar_url":"https://avatars.githubusercontent.com/u/10710861?v=3","gravatar_id":"","url":"https://api.github.com/users/asartori86","html_url":"https://github.com/asartori86","followers_url":"https://api.github.com/users/asartori86/followers","following_url":"https://api.github.com/users/asartori86/following{/other_user}","gists_url":"https://api.github.com/users/asartori86/gists{/gist_id}","starred_url":"https://api.github.com/users/asartori86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asartori86/subscriptions","organizations_url":"https://api.github.com/users/asartori86/orgs","repos_url":"https://api.github.com/users/asartori86/repos","events_url":"https://api.github.com/users/asartori86/events{/privacy}","received_events_url":"https://api.github.com/users/asartori86/received_events","type":"User","site_admin":false},"body":"With this PR it is possible to split the definition of a parameter entry on multiple lines in the .prm file.\r\n\r\nsee the file `tests/bits/prm/parameter_handler_2_backslash.prm` at the bottom","created_at":"2015-09-03T11:27:15Z","updated_at":"2015-09-04T13:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab0533e4f7326fbab1615219a777b82f3a08c5e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/1520/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/1520/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/1520/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/13a88994aa0455f0fa7a29484a2d3165a460d0fd","head":{"label":"asartori86:prm_preprocess","ref":"prm_preprocess","sha":"13a88994aa0455f0fa7a29484a2d3165a460d0fd","user":{"login":"asartori86","id":10710861,"avatar_url":"https://avatars.githubusercontent.com/u/10710861?v=3","gravatar_id":"","url":"https://api.github.com/users/asartori86","html_url":"https://github.com/asartori86","followers_url":"https://api.github.com/users/asartori86/followers","following_url":"https://api.github.com/users/asartori86/following{/other_user}","gists_url":"https://api.github.com/users/asartori86/gists{/gist_id}","starred_url":"https://api.github.com/users/asartori86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asartori86/subscriptions","organizations_url":"https://api.github.com/users/asartori86/orgs","repos_url":"https://api.github.com/users/asartori86/repos","events_url":"https://api.github.com/users/asartori86/events{/privacy}","received_events_url":"https://api.github.com/users/asartori86/received_events","type":"User","site_admin":false},"repo":{"id":41853582,"name":"dealii","full_name":"asartori86/dealii","owner":{"login":"asartori86","id":10710861,"avatar_url":"https://avatars.githubusercontent.com/u/10710861?v=3","gravatar_id":"","url":"https://api.github.com/users/asartori86","html_url":"https://github.com/asartori86","followers_url":"https://api.github.com/users/asartori86/followers","following_url":"https://api.github.com/users/asartori86/following{/other_user}","gists_url":"https://api.github.com/users/asartori86/gists{/gist_id}","starred_url":"https://api.github.com/users/asartori86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asartori86/subscriptions","organizations_url":"https://api.github.com/users/asartori86/orgs","repos_url":"https://api.github.com/users/asartori86/repos","events_url":"https://api.github.com/users/asartori86/events{/privacy}","received_events_url":"https://api.github.com/users/asartori86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asartori86/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/asartori86/dealii","forks_url":"https://api.github.com/repos/asartori86/dealii/forks","keys_url":"https://api.github.com/repos/asartori86/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asartori86/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asartori86/dealii/teams","hooks_url":"https://api.github.com/repos/asartori86/dealii/hooks","issue_events_url":"https://api.github.com/repos/asartori86/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/asartori86/dealii/events","assignees_url":"https://api.github.com/repos/asartori86/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/asartori86/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/asartori86/dealii/tags","blobs_url":"https://api.github.com/repos/asartori86/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asartori86/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asartori86/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/asartori86/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asartori86/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/asartori86/dealii/languages","stargazers_url":"https://api.github.com/repos/asartori86/dealii/stargazers","contributors_url":"https://api.github.com/repos/asartori86/dealii/contributors","subscribers_url":"https://api.github.com/repos/asartori86/dealii/subscribers","subscription_url":"https://api.github.com/repos/asartori86/dealii/subscription","commits_url":"https://api.github.com/repos/asartori86/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/asartori86/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/asartori86/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/asartori86/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/asartori86/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/asartori86/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asartori86/dealii/merges","archive_url":"https://api.github.com/repos/asartori86/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asartori86/dealii/downloads","issues_url":"https://api.github.com/repos/asartori86/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/asartori86/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/asartori86/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/asartori86/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asartori86/dealii/labels{/name}","releases_url":"https://api.github.com/repos/asartori86/dealii/releases{/id}","created_at":"2015-09-03T10:16:08Z","updated_at":"2015-09-03T10:17:15Z","pushed_at":"2015-09-04T13:38:23Z","git_url":"git://github.com/asartori86/dealii.git","ssh_url":"git@github.com:asartori86/dealii.git","clone_url":"https://github.com/asartori86/dealii.git","svn_url":"https://github.com/asartori86/dealii","homepage":"http://www.dealii.org/","size":123796,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"5ba5df028e18ce24a59187e30a3f574f918d1f4f","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","created_at":"2014-07-17T14:00:26Z","updated_at":"2015-09-02T19:23:15Z","pushed_at":"2015-09-04T13:38:23Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":160266,"stargazers_count":82,"watchers_count":82,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":117,"forks":117,"open_issues":117,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1520"},"html":{"href":"https://github.com/dealii/dealii/pull/1520"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/1520"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/1520/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1520/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1520/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/13a88994aa0455f0fa7a29484a2d3165a460d0fd"}}}}