{"action":"created","comment":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/38858163","id":38858163,"diff_hunk":"@@ -67,6 +67,26 @@\n     end\n   end\n \n+  describe \"hstore_col#>>'field'_asc\" do\n+    let(:clause) { \"hstore_col->>'field'_asc\" }\n+\n+    it { is_expected.to be_valid }\n+\n+    describe '#field' do\n+      subject { super().field }\n+      it { is_expected.to eq(\"hstore_col->>'field'\") }\n+    end\n+\n+    describe '#order' do\n+      subject { super().order }\n+      it { is_expected.to eq('asc') }","path":"spec/unit/order_clause_spec.rb","position":16,"original_position":16,"commit_id":"8fb7de828873b0357e9ee2f3e55b3f118bc45b0e","original_commit_id":"8fb7de828873b0357e9ee2f3e55b3f118bc45b0e","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2015-09-07T12:30:34Z","updated_at":"2015-09-07T12:30:34Z","html_url":"https://github.com/activeadmin/activeadmin/pull/4115#discussion_r38858163","pull_request_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4115","_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/38858163"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/4115#discussion_r38858163"},"pull_request":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4115"}}},"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4115","id":44350498,"html_url":"https://github.com/activeadmin/activeadmin/pull/4115","diff_url":"https://github.com/activeadmin/activeadmin/pull/4115.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/4115.patch","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/4115","number":4115,"state":"open","locked":false,"title":"support for full range of JSON and JSONB operators in PostgreSQL","user":{"login":"dimakura","id":321926,"avatar_url":"https://avatars.githubusercontent.com/u/321926?v=3","gravatar_id":"","url":"https://api.github.com/users/dimakura","html_url":"https://github.com/dimakura","followers_url":"https://api.github.com/users/dimakura/followers","following_url":"https://api.github.com/users/dimakura/following{/other_user}","gists_url":"https://api.github.com/users/dimakura/gists{/gist_id}","starred_url":"https://api.github.com/users/dimakura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimakura/subscriptions","organizations_url":"https://api.github.com/users/dimakura/orgs","repos_url":"https://api.github.com/users/dimakura/repos","events_url":"https://api.github.com/users/dimakura/events{/privacy}","received_events_url":"https://api.github.com/users/dimakura/received_events","type":"User","site_admin":false},"body":"Based on this http://www.postgresql.org/docs/9.4/static/functions-\r\njson.html#FUNCTIONS-JSON-OP-TABLE there are 6 operators for JSON and\r\nJSONB columns in PostgreSQL. ActiveAdmin currently supports only 2 of\r\nthose operators. Just small modification in ActiveAdmin::OrderClause's\r\nregular expression gives us support for remaining 4 operators.\r\n\r\nIt only partially resolves #3085.","created_at":"2015-09-07T12:30:31Z","updated_at":"2015-09-07T12:30:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4496ec3c4811efd229409ee2a38dfa2af67459d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4115/commits","review_comments_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4115/comments","review_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/4115/comments","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/8fb7de828873b0357e9ee2f3e55b3f118bc45b0e","head":{"label":"dimakura:master","ref":"master","sha":"8fb7de828873b0357e9ee2f3e55b3f118bc45b0e","user":{"login":"dimakura","id":321926,"avatar_url":"https://avatars.githubusercontent.com/u/321926?v=3","gravatar_id":"","url":"https://api.github.com/users/dimakura","html_url":"https://github.com/dimakura","followers_url":"https://api.github.com/users/dimakura/followers","following_url":"https://api.github.com/users/dimakura/following{/other_user}","gists_url":"https://api.github.com/users/dimakura/gists{/gist_id}","starred_url":"https://api.github.com/users/dimakura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimakura/subscriptions","organizations_url":"https://api.github.com/users/dimakura/orgs","repos_url":"https://api.github.com/users/dimakura/repos","events_url":"https://api.github.com/users/dimakura/events{/privacy}","received_events_url":"https://api.github.com/users/dimakura/received_events","type":"User","site_admin":false},"repo":{"id":42050100,"name":"activeadmin","full_name":"dimakura/activeadmin","owner":{"login":"dimakura","id":321926,"avatar_url":"https://avatars.githubusercontent.com/u/321926?v=3","gravatar_id":"","url":"https://api.github.com/users/dimakura","html_url":"https://github.com/dimakura","followers_url":"https://api.github.com/users/dimakura/followers","following_url":"https://api.github.com/users/dimakura/following{/other_user}","gists_url":"https://api.github.com/users/dimakura/gists{/gist_id}","starred_url":"https://api.github.com/users/dimakura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimakura/subscriptions","organizations_url":"https://api.github.com/users/dimakura/orgs","repos_url":"https://api.github.com/users/dimakura/repos","events_url":"https://api.github.com/users/dimakura/events{/privacy}","received_events_url":"https://api.github.com/users/dimakura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dimakura/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":true,"url":"https://api.github.com/repos/dimakura/activeadmin","forks_url":"https://api.github.com/repos/dimakura/activeadmin/forks","keys_url":"https://api.github.com/repos/dimakura/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimakura/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimakura/activeadmin/teams","hooks_url":"https://api.github.com/repos/dimakura/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/dimakura/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/dimakura/activeadmin/events","assignees_url":"https://api.github.com/repos/dimakura/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/dimakura/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/dimakura/activeadmin/tags","blobs_url":"https://api.github.com/repos/dimakura/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimakura/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimakura/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimakura/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimakura/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/dimakura/activeadmin/languages","stargazers_url":"https://api.github.com/repos/dimakura/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/dimakura/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/dimakura/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/dimakura/activeadmin/subscription","commits_url":"https://api.github.com/repos/dimakura/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimakura/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimakura/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimakura/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimakura/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/dimakura/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimakura/activeadmin/merges","archive_url":"https://api.github.com/repos/dimakura/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimakura/activeadmin/downloads","issues_url":"https://api.github.com/repos/dimakura/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/dimakura/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/dimakura/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/dimakura/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimakura/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/dimakura/activeadmin/releases{/id}","created_at":"2015-09-07T11:49:43Z","updated_at":"2015-09-07T11:49:46Z","pushed_at":"2015-09-07T12:25:05Z","git_url":"git://github.com/dimakura/activeadmin.git","ssh_url":"git@github.com:dimakura/activeadmin.git","clone_url":"https://github.com/dimakura/activeadmin.git","svn_url":"https://github.com/dimakura/activeadmin","homepage":"activeadmin.info","size":19637,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activeadmin:master","ref":"master","sha":"a5a53c3f2b8fdfd2605575b62b158318f7651f46","user":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":611921,"name":"activeadmin","full_name":"activeadmin/activeadmin","owner":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeadmin/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":false,"url":"https://api.github.com/repos/activeadmin/activeadmin","forks_url":"https://api.github.com/repos/activeadmin/activeadmin/forks","keys_url":"https://api.github.com/repos/activeadmin/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeadmin/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeadmin/activeadmin/teams","hooks_url":"https://api.github.com/repos/activeadmin/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/activeadmin/activeadmin/events","assignees_url":"https://api.github.com/repos/activeadmin/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/activeadmin/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/activeadmin/activeadmin/tags","blobs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeadmin/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeadmin/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/activeadmin/activeadmin/languages","stargazers_url":"https://api.github.com/repos/activeadmin/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/activeadmin/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/activeadmin/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/activeadmin/activeadmin/subscription","commits_url":"https://api.github.com/repos/activeadmin/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeadmin/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeadmin/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/activeadmin/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeadmin/activeadmin/merges","archive_url":"https://api.github.com/repos/activeadmin/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeadmin/activeadmin/downloads","issues_url":"https://api.github.com/repos/activeadmin/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/activeadmin/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/activeadmin/activeadmin/releases{/id}","created_at":"2010-04-15T14:26:03Z","updated_at":"2015-09-07T08:57:45Z","pushed_at":"2015-09-07T12:30:31Z","git_url":"git://github.com/activeadmin/activeadmin.git","ssh_url":"git@github.com:activeadmin/activeadmin.git","clone_url":"https://github.com/activeadmin/activeadmin.git","svn_url":"https://github.com/activeadmin/activeadmin","homepage":"activeadmin.info","size":19637,"stargazers_count":6182,"watchers_count":6182,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2210,"mirror_url":null,"open_issues_count":222,"forks":2210,"open_issues":222,"watchers":6182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4115"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/4115"},"issue":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/4115"},"comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/4115/comments"},"review_comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4115/comments"},"review_comment":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/4115/commits"},"statuses":{"href":"https://api.github.com/repos/activeadmin/activeadmin/statuses/8fb7de828873b0357e9ee2f3e55b3f118bc45b0e"}}}}