{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/16288","labels_url":"https://api.github.com/repos/docker/docker/issues/16288/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/16288/comments","events_url":"https://api.github.com/repos/docker/docker/issues/16288/events","html_url":"https://github.com/docker/docker/pull/16288","id":106421849,"number":16288,"title":"Change DockerRegistrySuite and DockerTrustSuite to use an independent daemon and delete all images between tests and delete all images between tests","user":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-14T20:31:30Z","updated_at":"2015-09-23T06:44:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/16288","html_url":"https://github.com/docker/docker/pull/16288","diff_url":"https://github.com/docker/docker/pull/16288.diff","patch_url":"https://github.com/docker/docker/pull/16288.patch"},"body":"busybox is loaded from the main daemon after every test, but no other images\r\nare present in this daemon.\r\n\r\nThis will prevent push/pull tests from being polluted by changes made by\r\nother tests (i.e. busybox being repulled).\r\n\r\nCreate a DockerIsolatedDaemonSuite struct which is used to implement\r\nDockerRegistrySuite and DockerHubPullSuite.\r\n\r\nChange many functions in docker_utils.go to take a CmdMaker interface,\r\nso they can be used with a separate daemon. Update existing tests\r\naccordingly (this accounts for the bulk of the commit).\r\n\r\nAdjust tests in DockerRegistrySuite and DockerTrustSuite to all s.Cmd\r\ninstead of dockerCmd, and so on.\r\n\r\n@icecrime @vdemeester PTAL"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/142510195","html_url":"https://github.com/docker/docker/pull/16288#issuecomment-142510195","issue_url":"https://api.github.com/repos/docker/docker/issues/16288","id":142510195,"user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T06:44:57Z","updated_at":"2015-09-23T06:44:57Z","body":"Not really (was away for a few days), but it's on my priority list now :wink: "}}