{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/11137","labels_url":"https://api.github.com/repos/docker/docker/issues/11137/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/11137/comments","events_url":"https://api.github.com/repos/docker/docker/issues/11137/events","html_url":"https://github.com/docker/docker/pull/11137","id":59693707,"number":11137,"title":"Do not remove container if underlying resource cleanup failed","user":{"login":"rhvgoyal","id":9487534,"avatar_url":"https://avatars.githubusercontent.com/u/9487534?v=3","gravatar_id":"","url":"https://api.github.com/users/rhvgoyal","html_url":"https://github.com/rhvgoyal","followers_url":"https://api.github.com/users/rhvgoyal/followers","following_url":"https://api.github.com/users/rhvgoyal/following{/other_user}","gists_url":"https://api.github.com/users/rhvgoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/rhvgoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhvgoyal/subscriptions","organizations_url":"https://api.github.com/users/rhvgoyal/orgs","repos_url":"https://api.github.com/users/rhvgoyal/repos","events_url":"https://api.github.com/users/rhvgoyal/events{/privacy}","received_events_url":"https://api.github.com/users/rhvgoyal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/2-code-review","name":"2-code-review","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/37","html_url":"https://github.com/docker/docker/milestones/1.6.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/37/labels","id":952335,"number":37,"title":"1.6.0","description":"","creator":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":13,"state":"open","created_at":"2015-01-26T23:40:13Z","updated_at":"2015-03-11T20:44:13Z","due_on":"2015-03-18T07:00:00Z","closed_at":null},"comments":17,"created_at":"2015-03-03T19:39:36Z","updated_at":"2015-03-12T19:02:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/11137","html_url":"https://github.com/docker/docker/pull/11137","diff_url":"https://github.com/docker/docker/pull/11137.diff","patch_url":"https://github.com/docker/docker/pull/11137.patch"},"body":"This should fix issue #10955 and #6746 \r\n\r\nThis patch series does two things. First of all it does not remove container from a user's view if container removal failed. Secondly, it extends force option (-f) to forcibly remove the container even if resource cleanup failed. That way those user who are willing to let resources leak, can use --force.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/78571466","html_url":"https://github.com/docker/docker/pull/11137#issuecomment-78571466","issue_url":"https://api.github.com/repos/docker/docker/issues/11137","id":78571466,"user":{"login":"rhvgoyal","id":9487534,"avatar_url":"https://avatars.githubusercontent.com/u/9487534?v=3","gravatar_id":"","url":"https://api.github.com/users/rhvgoyal","html_url":"https://github.com/rhvgoyal","followers_url":"https://api.github.com/users/rhvgoyal/followers","following_url":"https://api.github.com/users/rhvgoyal/following{/other_user}","gists_url":"https://api.github.com/users/rhvgoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/rhvgoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhvgoyal/subscriptions","organizations_url":"https://api.github.com/users/rhvgoyal/orgs","repos_url":"https://api.github.com/users/rhvgoyal/repos","events_url":"https://api.github.com/users/rhvgoyal/events{/privacy}","received_events_url":"https://api.github.com/users/rhvgoyal/received_events","type":"User","site_admin":false},"created_at":"2015-03-12T19:02:29Z","updated_at":"2015-03-12T19:02:29Z","body":"Ok, /var/lib/docker/container/<container_id> directory is removed after container root and container init root has been removed. \r\n\r\nSo it depends on when failure occurs. If failure occurs before container file removal, it will come back to life. And I think it is a bad idea. Container might be half deleted and if somebody tries to start it, bad things will happen. I will save the container state \"Dead\" back to disk before proceeding with actual deletion. This will make sure that once container is marked dead, it remains dead even if docker is restarted."}}