{"action":"created","issue":{"url":"https://api.github.com/repos/YaleSTC/reservations/issues/1116","labels_url":"https://api.github.com/repos/YaleSTC/reservations/issues/1116/labels{/name}","comments_url":"https://api.github.com/repos/YaleSTC/reservations/issues/1116/comments","events_url":"https://api.github.com/repos/YaleSTC/reservations/issues/1116/events","html_url":"https://github.com/YaleSTC/reservations/pull/1116","id":56051832,"number":1116,"title":"Upgrade Bootstrap to latest version (v3.3.x)","user":{"login":"mnquintana","id":823545,"avatar_url":"https://avatars.githubusercontent.com/u/823545?v=3","gravatar_id":"","url":"https://api.github.com/users/mnquintana","html_url":"https://github.com/mnquintana","followers_url":"https://api.github.com/users/mnquintana/followers","following_url":"https://api.github.com/users/mnquintana/following{/other_user}","gists_url":"https://api.github.com/users/mnquintana/gists{/gist_id}","starred_url":"https://api.github.com/users/mnquintana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnquintana/subscriptions","organizations_url":"https://api.github.com/users/mnquintana/orgs","repos_url":"https://api.github.com/users/mnquintana/repos","events_url":"https://api.github.com/users/mnquintana/events{/privacy}","received_events_url":"https://api.github.com/users/mnquintana/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/YaleSTC/reservations/labels/4%20-%20Needs%20Review","name":"4 - Needs Review","color":"cccccc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2015-01-30T16:10:09Z","updated_at":"2015-02-09T19:13:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/YaleSTC/reservations/pulls/1116","html_url":"https://github.com/YaleSTC/reservations/pull/1116","diff_url":"https://github.com/YaleSTC/reservations/pull/1116.diff","patch_url":"https://github.com/YaleSTC/reservations/pull/1116.patch"},"body":"~~100~~ ... 114 commits and ~~120~~ 123 changed files later...\r\n\r\nThis upgrades Bootstrap to the latest version – *but wait! There's more!* It also includes:\r\n- A new, sexy navbar\r\n- Tweaked color scheme\r\n- Hundreds of style tweaks\r\n- Refactored layout\r\n- Updated select2\r\n- Updated jQuery.dataTables\r\n- Updated simple_form\r\n- Updated jQuery.dotdotdot\r\n- Removed jQuery.sticky (replaced with Bootstrap.affix)\r\n- Tons of other stuff I don't remember anymore\r\n\r\nSome notes:\r\n- So much about the views is just really brittle and hacky (in styling, structure, and content). Fixing that stuff was out of scope.\r\n- Our Sass has gotten messy. We need to refactor and reorganize (ie. there are variable and mixin definitions defined in random files instead of in `_variables.css.scss` and `_mixins.css.scss`)\r\n- I removed some unused CSS, but that's a job for another PR\r\n- ~~I commented out `rack-mini-profiler` in the Gemfile because it's too distracting during code review. Once review is done I'll uncomment it.~~ I uncommented to push a commit to force Travis to build.\r\n- MOBILE VIEWS ARE BROKEN AS HELL. The app's responsive design is acceptable down to tablet widths, but once you get to phone widths Reservations becomes comically unusable. (also a job for another PR)\r\n- We need to move vendor assets out of `app/assets` and into `vendor/assets` (also a job for another PR)\r\n  - We need a better way of managing vendor assets. Because we already have a few (jQuery.dotdotdot for example) that we just downloaded, unzipped, and stuck in the folder, which is a terrible way to manage dependencies. We should switch vendor asset management over to [Bower](http://bower.io/) and/or [Rails Assets](https://rails-assets.org/)\r\n- We need to post an updated screenshot to the site once this lands – Reservations looks a bit different now :smile: \r\n\r\nYeah, I think that's it for now. Have fun :wink: \r\n(Fixes #245)"},"comment":{"url":"https://api.github.com/repos/YaleSTC/reservations/issues/comments/73570261","html_url":"https://github.com/YaleSTC/reservations/pull/1116#issuecomment-73570261","issue_url":"https://api.github.com/repos/YaleSTC/reservations/issues/1116","id":73570261,"user":{"login":"orenyk","id":901808,"avatar_url":"https://avatars.githubusercontent.com/u/901808?v=3","gravatar_id":"","url":"https://api.github.com/users/orenyk","html_url":"https://github.com/orenyk","followers_url":"https://api.github.com/users/orenyk/followers","following_url":"https://api.github.com/users/orenyk/following{/other_user}","gists_url":"https://api.github.com/users/orenyk/gists{/gist_id}","starred_url":"https://api.github.com/users/orenyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orenyk/subscriptions","organizations_url":"https://api.github.com/users/orenyk/orgs","repos_url":"https://api.github.com/users/orenyk/repos","events_url":"https://api.github.com/users/orenyk/events{/privacy}","received_events_url":"https://api.github.com/users/orenyk/received_events","type":"User","site_admin":false},"created_at":"2015-02-09T19:13:24Z","updated_at":"2015-02-09T19:13:24Z","body":"The new user modal form is a bit messed up as well:\r\n\r\n![selection_049](https://cloud.githubusercontent.com/assets/901808/6113483/c8bbd9f0-b065-11e4-93d9-7db008369200.png)\r\n"}}