{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/42996974","id":42996974,"diff_hunk":"@@ -24,6 +24,7 @@ def self.load_defaults\n         self.set('ssl_priv_key', N_(\"SSL Private Key file that Foreman will use to communicate with its proxies\"), ssl_priv_key, N_('SSL private key')),\n         self.set('ssl_client_dn_env', N_('Environment variable containing the subject DN from a client SSL certificate'), 'SSL_CLIENT_S_DN', N_('SSL client DN env')),\n         self.set('ssl_client_verify_env', N_('Environment variable containing the verification status of a client SSL certificate'), 'SSL_CLIENT_VERIFY', N_('SSL client verify env')),\n+        self.set('ssl_client_cert_env', N_('Environment variable containing a client\\'s SSL certificate'), 'SSL_CLIENT_CERT', N_('SSL client cert env')),","path":"app/models/setting/auth.rb","position":4,"original_position":4,"commit_id":"7a6bfeb3e30c315e037ab4b4d4af16ab4bec2c6b","original_commit_id":"7a6bfeb3e30c315e037ab4b4d4af16ab4bec2c6b","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"Can you use double quotes here?  We use a code parser to extract strings for translation, and it might be safer than escape characters.. it's pretty dumb.","created_at":"2015-10-26T14:09:09Z","updated_at":"2015-10-26T14:09:09Z","html_url":"https://github.com/theforeman/foreman/pull/2807#discussion_r42996974","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/2807","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/42996974"},"html":{"href":"https://github.com/theforeman/foreman/pull/2807#discussion_r42996974"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2807"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2807","id":47287003,"html_url":"https://github.com/theforeman/foreman/pull/2807","diff_url":"https://github.com/theforeman/foreman/pull/2807.diff","patch_url":"https://github.com/theforeman/foreman/pull/2807.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2807","number":2807,"state":"open","locked":false,"title":"fixes #12127 - Foreman should verify x509 sans when authenticating a smart proxy","user":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"body":"This PR adds the feature, that Foreman verifies the subject alternative name attributes of the client cert if they are set in the client certificate. This requires ''SSLOptions +ExportCertData\" in Apache. Will add a pr for that soon.\r\nThis helps in a ha environment when using the vipname in the san.\r\n\r\nKudos to @martinpfeifer with whom I enjoyed working on that.\r\n\r\nDo we need any tests for that? If so, where and what should we test? :-)","created_at":"2015-10-09T15:40:26Z","updated_at":"2015-10-26T14:09:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"405ded126e3ff0f793a77b0a9901cb56cfdfe4f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/2807/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/2807/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2807/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/7a6bfeb3e30c315e037ab4b4d4af16ab4bec2c6b","head":{"label":"timogoebel:feature_smart_proxy_san","ref":"feature_smart_proxy_san","sha":"7a6bfeb3e30c315e037ab4b4d4af16ab4bec2c6b","user":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"repo":{"id":39135770,"name":"foreman","full_name":"timogoebel/foreman","owner":{"login":"timogoebel","id":4107560,"avatar_url":"https://avatars.githubusercontent.com/u/4107560?v=3","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timogoebel/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/timogoebel/foreman","forks_url":"https://api.github.com/repos/timogoebel/foreman/forks","keys_url":"https://api.github.com/repos/timogoebel/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timogoebel/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timogoebel/foreman/teams","hooks_url":"https://api.github.com/repos/timogoebel/foreman/hooks","issue_events_url":"https://api.github.com/repos/timogoebel/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/timogoebel/foreman/events","assignees_url":"https://api.github.com/repos/timogoebel/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/timogoebel/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/timogoebel/foreman/tags","blobs_url":"https://api.github.com/repos/timogoebel/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timogoebel/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timogoebel/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/timogoebel/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timogoebel/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/timogoebel/foreman/languages","stargazers_url":"https://api.github.com/repos/timogoebel/foreman/stargazers","contributors_url":"https://api.github.com/repos/timogoebel/foreman/contributors","subscribers_url":"https://api.github.com/repos/timogoebel/foreman/subscribers","subscription_url":"https://api.github.com/repos/timogoebel/foreman/subscription","commits_url":"https://api.github.com/repos/timogoebel/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/timogoebel/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/timogoebel/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/timogoebel/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/timogoebel/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/timogoebel/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timogoebel/foreman/merges","archive_url":"https://api.github.com/repos/timogoebel/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timogoebel/foreman/downloads","issues_url":"https://api.github.com/repos/timogoebel/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/timogoebel/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/timogoebel/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/timogoebel/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timogoebel/foreman/labels{/name}","releases_url":"https://api.github.com/repos/timogoebel/foreman/releases{/id}","created_at":"2015-07-15T12:33:09Z","updated_at":"2015-07-15T12:33:14Z","pushed_at":"2015-10-26T09:39:24Z","git_url":"git://github.com/timogoebel/foreman.git","ssh_url":"git@github.com:timogoebel/foreman.git","clone_url":"https://github.com/timogoebel/foreman.git","svn_url":"https://github.com/timogoebel/foreman","homepage":"http://theforeman.org","size":36985,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"85e82d04e0a7c9c86664240ea46138d303553069","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2015-10-21T17:34:17Z","pushed_at":"2015-10-26T13:17:10Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":98687,"stargazers_count":875,"watchers_count":875,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":440,"mirror_url":null,"open_issues_count":88,"forks":440,"open_issues":88,"watchers":875,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2807"},"html":{"href":"https://github.com/theforeman/foreman/pull/2807"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2807"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2807/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2807/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2807/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/7a6bfeb3e30c315e037ab4b4d4af16ab4bec2c6b"}}}}