{"push_id":624368146,"size":1,"distinct_size":1,"ref":"refs/heads/ticket/3.x/PUP-3653-empty-windows-groups","head":"a6393b07772146101ae1894381e96cea25f05ed2","before":"1318778d5540ef5959e6325df2696cb31a457f43","commits":[{"sha":"a6393b07772146101ae1894381e96cea25f05ed2","author":{"email":"6eaaec1336f7acb13686b98a3495c3d683fe0810@github","name":"Ethan J. Brown"},"message":"WIP - Emit better group error messages\n\nbundle exec puppet resource group guests\n\ngroup { 'guests':\n  ensure  => 'present',\n  gid     => 'S-1-5-32-546',\n  members => ['Guest', 'Administrator'],\n}\n\nPreviously, trying to apply the following manifest with a bad user:\n\ngroup { 'guests':\n  ensure => present,\n  members => ['Guest', 'Administrator', ''],\n}\n\nWould trigger a Puppet bug, and raise an error in resource_harness\nsync_if_needed method, and would lose important details about expected\nresource changes:\n\nNotice: Compiled catalog for vagrant-2008r2.corp.puppetlabs.net in environment production in 0.22 seconds Error: Could not resolve username:\nError: /Group[Guests]: Could not evaluate: Puppet::Util::Log requires a message\nNotice: Finished catalog run in 0.05 seconds\n\nThis change does not lose error detail, nor trigger an extraneous /\nmisleading message:\n\nNotice: Compiled catalog for vagrant-2008r2.corp.puppetlabs.net in environment production in 0.22 seconds Error: Could not resolve username:\nError: /Stage[main]/Main/Group[Guests]/members: change from VAGRANT-2008R2\\Guest,VAGRANT-2008R2\\Administrator to [\"Guest\", \"Administrator\", \"\"] failed: Could not resolve username:\nNotice: Finished catalog run in 0.05 seconds","distinct":true,"url":"https://api.github.com/repos/Iristyle/puppet/commits/a6393b07772146101ae1894381e96cea25f05ed2"}]}