{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/38548571","id":38548571,"diff_hunk":"@@ -15,6 +15,10 @@ type NodeConfig struct {\n \t// If you're describing a set of static nodes to the master, this value must match one of the values in the list\n \tNodeName string `json:\"nodeName\"`\n \n+\t// Node may have multiple IPs, specify the IP to use for pod traffic routing\n+\t// If not specified, network parse/lookup on the nodeName is performed and the first non-loopback address is used\n+\tNodeIP string `json:\"nodeIP\"`","path":"pkg/cmd/server/api/v1/types.go","position":6,"original_position":6,"commit_id":"9aed33a5013cf56ee7e7b3a70e5804fb99e189fd","original_commit_id":"9aed33a5013cf56ee7e7b3a70e5804fb99e189fd","user":{"login":"sdodson","id":48161,"avatar_url":"https://avatars.githubusercontent.com/u/48161?v=3","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"body":"Since this is closely related to the SDN should it be under networkConfig?","created_at":"2015-09-02T15:46:39Z","updated_at":"2015-09-02T15:46:39Z","html_url":"https://github.com/openshift/origin/pull/4459#discussion_r38548571","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/4459","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/38548571"},"html":{"href":"https://github.com/openshift/origin/pull/4459#discussion_r38548571"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/4459"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4459","id":43922023,"html_url":"https://github.com/openshift/origin/pull/4459","diff_url":"https://github.com/openshift/origin/pull/4459.diff","patch_url":"https://github.com/openshift/origin/pull/4459.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/4459","number":4459,"state":"open","locked":false,"title":"Node IP can be passed as node config option","user":{"login":"pravisankar","id":1258630,"avatar_url":"https://avatars.githubusercontent.com/u/1258630?v=3","gravatar_id":"","url":"https://api.github.com/users/pravisankar","html_url":"https://github.com/pravisankar","followers_url":"https://api.github.com/users/pravisankar/followers","following_url":"https://api.github.com/users/pravisankar/following{/other_user}","gists_url":"https://api.github.com/users/pravisankar/gists{/gist_id}","starred_url":"https://api.github.com/users/pravisankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravisankar/subscriptions","organizations_url":"https://api.github.com/users/pravisankar/orgs","repos_url":"https://api.github.com/users/pravisankar/repos","events_url":"https://api.github.com/users/pravisankar/events{/privacy}","received_events_url":"https://api.github.com/users/pravisankar/received_events","type":"User","site_admin":false},"body":"If 'nodeIP' option is provided, this IP will be used\r\nfor pod traffic communication, Otherwise we will do\r\nnetwork parse/lookup on the node name to fetch the IP\r\naddress and in case of multiple IP addresses, the first\r\nnon loopback IP address is used.\r\n\r\ncloses: https://github.com/openshift/openshift-sdn/issues/84","created_at":"2015-09-01T20:23:38Z","updated_at":"2015-09-02T15:46:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e757138849e67924afe61192d90314ff52e1d7e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/4459/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/4459/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4459/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/9aed33a5013cf56ee7e7b3a70e5804fb99e189fd","head":{"label":"pravisankar:node-ip-config","ref":"node-ip-config","sha":"9aed33a5013cf56ee7e7b3a70e5804fb99e189fd","user":{"login":"pravisankar","id":1258630,"avatar_url":"https://avatars.githubusercontent.com/u/1258630?v=3","gravatar_id":"","url":"https://api.github.com/users/pravisankar","html_url":"https://github.com/pravisankar","followers_url":"https://api.github.com/users/pravisankar/followers","following_url":"https://api.github.com/users/pravisankar/following{/other_user}","gists_url":"https://api.github.com/users/pravisankar/gists{/gist_id}","starred_url":"https://api.github.com/users/pravisankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravisankar/subscriptions","organizations_url":"https://api.github.com/users/pravisankar/orgs","repos_url":"https://api.github.com/users/pravisankar/repos","events_url":"https://api.github.com/users/pravisankar/events{/privacy}","received_events_url":"https://api.github.com/users/pravisankar/received_events","type":"User","site_admin":false},"repo":{"id":26983891,"name":"origin","full_name":"pravisankar/origin","owner":{"login":"pravisankar","id":1258630,"avatar_url":"https://avatars.githubusercontent.com/u/1258630?v=3","gravatar_id":"","url":"https://api.github.com/users/pravisankar","html_url":"https://github.com/pravisankar","followers_url":"https://api.github.com/users/pravisankar/followers","following_url":"https://api.github.com/users/pravisankar/following{/other_user}","gists_url":"https://api.github.com/users/pravisankar/gists{/gist_id}","starred_url":"https://api.github.com/users/pravisankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravisankar/subscriptions","organizations_url":"https://api.github.com/users/pravisankar/orgs","repos_url":"https://api.github.com/users/pravisankar/repos","events_url":"https://api.github.com/users/pravisankar/events{/privacy}","received_events_url":"https://api.github.com/users/pravisankar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pravisankar/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/pravisankar/origin","forks_url":"https://api.github.com/repos/pravisankar/origin/forks","keys_url":"https://api.github.com/repos/pravisankar/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pravisankar/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pravisankar/origin/teams","hooks_url":"https://api.github.com/repos/pravisankar/origin/hooks","issue_events_url":"https://api.github.com/repos/pravisankar/origin/issues/events{/number}","events_url":"https://api.github.com/repos/pravisankar/origin/events","assignees_url":"https://api.github.com/repos/pravisankar/origin/assignees{/user}","branches_url":"https://api.github.com/repos/pravisankar/origin/branches{/branch}","tags_url":"https://api.github.com/repos/pravisankar/origin/tags","blobs_url":"https://api.github.com/repos/pravisankar/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pravisankar/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pravisankar/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pravisankar/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pravisankar/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/pravisankar/origin/languages","stargazers_url":"https://api.github.com/repos/pravisankar/origin/stargazers","contributors_url":"https://api.github.com/repos/pravisankar/origin/contributors","subscribers_url":"https://api.github.com/repos/pravisankar/origin/subscribers","subscription_url":"https://api.github.com/repos/pravisankar/origin/subscription","commits_url":"https://api.github.com/repos/pravisankar/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pravisankar/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pravisankar/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pravisankar/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pravisankar/origin/contents/{+path}","compare_url":"https://api.github.com/repos/pravisankar/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pravisankar/origin/merges","archive_url":"https://api.github.com/repos/pravisankar/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pravisankar/origin/downloads","issues_url":"https://api.github.com/repos/pravisankar/origin/issues{/number}","pulls_url":"https://api.github.com/repos/pravisankar/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/pravisankar/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/pravisankar/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pravisankar/origin/labels{/name}","releases_url":"https://api.github.com/repos/pravisankar/origin/releases{/id}","created_at":"2014-11-22T00:39:33Z","updated_at":"2015-05-07T19:59:40Z","pushed_at":"2015-09-02T01:09:51Z","git_url":"git://github.com/pravisankar/origin.git","ssh_url":"git@github.com:pravisankar/origin.git","clone_url":"https://github.com/pravisankar/origin.git","svn_url":"https://github.com/pravisankar/origin","homepage":"https://openshift.github.io","size":133945,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"5b65241e686edd72d26b486377c431d11bba52cc","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-09-02T14:25:59Z","pushed_at":"2015-09-02T15:24:31Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":221586,"stargazers_count":659,"watchers_count":659,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":378,"mirror_url":null,"open_issues_count":556,"forks":378,"open_issues":556,"watchers":659,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/4459"},"html":{"href":"https://github.com/openshift/origin/pull/4459"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/4459"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/4459/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/4459/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/4459/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/9aed33a5013cf56ee7e7b3a70e5804fb99e189fd"}}}}