{"action":"created","issue":{"url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/191","labels_url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/191/comments","events_url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/191/events","html_url":"https://github.com/pattern-lab/patternlab-node/pull/191","id":117423828,"number":191,"title":"PatternEngines: support multiple template engines, v2","user":{"login":"geoffp","id":76232,"avatar_url":"https://avatars.githubusercontent.com/u/76232?v=3","gravatar_id":"","url":"https://api.github.com/users/geoffp","html_url":"https://github.com/geoffp","followers_url":"https://api.github.com/users/geoffp/followers","following_url":"https://api.github.com/users/geoffp/following{/other_user}","gists_url":"https://api.github.com/users/geoffp/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffp/subscriptions","organizations_url":"https://api.github.com/users/geoffp/orgs","repos_url":"https://api.github.com/users/geoffp/repos","events_url":"https://api.github.com/users/geoffp/events{/privacy}","received_events_url":"https://api.github.com/users/geoffp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-17T18:54:50Z","updated_at":"2015-11-25T17:09:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pattern-lab/patternlab-node/pulls/191","html_url":"https://github.com/pattern-lab/patternlab-node/pull/191","diff_url":"https://github.com/pattern-lab/patternlab-node/pull/191.diff","patch_url":"https://github.com/pattern-lab/patternlab-node/pull/191.patch"},"body":"NOT READY FOR MERGE YET, this PR is only for review.\r\n\r\nHey, @bmuenzenmeyer -- this one is merged and up to date as of the time you created the pattern-engines branch, which this PR is pointed at. It should merge, build, and it passes all the tests now, though it silently fails to build pseudo-patterns. I'm looking in to that today.\r\n\r\nOnce again -- there's kind of a lot here, and it's WIP, so if there's anything I can do to make this more reviewable, let me know.\r\n\r\nTODO:\r\n* Fix pseudo-pattern generation\r\n* Finish factoring out all direct uses of mustache\r\n* Hunt down all Mustache-specific regexes in the hunters and move them into the Mustache plugin\r\n* Use or remove the util module\r\n* Take out console.log()s someday, we like them for now"},"comment":{"url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/comments/159675235","html_url":"https://github.com/pattern-lab/patternlab-node/pull/191#issuecomment-159675235","issue_url":"https://api.github.com/repos/pattern-lab/patternlab-node/issues/191","id":159675235,"user":{"login":"sghoweri","id":1617209,"avatar_url":"https://avatars.githubusercontent.com/u/1617209?v=3","gravatar_id":"","url":"https://api.github.com/users/sghoweri","html_url":"https://github.com/sghoweri","followers_url":"https://api.github.com/users/sghoweri/followers","following_url":"https://api.github.com/users/sghoweri/following{/other_user}","gists_url":"https://api.github.com/users/sghoweri/gists{/gist_id}","starred_url":"https://api.github.com/users/sghoweri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghoweri/subscriptions","organizations_url":"https://api.github.com/users/sghoweri/orgs","repos_url":"https://api.github.com/users/sghoweri/repos","events_url":"https://api.github.com/users/sghoweri/events{/privacy}","received_events_url":"https://api.github.com/users/sghoweri/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T17:09:05Z","updated_at":"2015-11-25T17:09:05Z","body":"@geoffp and @bmuenzenmeyer For what it's worth, I'm also checking this out right now to see how straightforward it's going to be to add in new rendering engines (like Twig) with this direction you guys are heading. Already got a good bit of experience dealing with the new PL2 setup so I'm just reviewing to see how I might be able to help out with this as well."}}