{"action":"closed","number":4375,"pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/4375","id":43110923,"html_url":"https://github.com/sequelize/sequelize/pull/4375","diff_url":"https://github.com/sequelize/sequelize/pull/4375.diff","patch_url":"https://github.com/sequelize/sequelize/pull/4375.patch","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/4375","number":4375,"state":"closed","locked":false,"title":"include with separate:true fails if id is not part of the attributes list","user":{"login":"sorin","id":60167,"avatar_url":"https://avatars.githubusercontent.com/u/60167?v=3","gravatar_id":"","url":"https://api.github.com/users/sorin","html_url":"https://github.com/sorin","followers_url":"https://api.github.com/users/sorin/followers","following_url":"https://api.github.com/users/sorin/following{/other_user}","gists_url":"https://api.github.com/users/sorin/gists{/gist_id}","starred_url":"https://api.github.com/users/sorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorin/subscriptions","organizations_url":"https://api.github.com/users/sorin/orgs","repos_url":"https://api.github.com/users/sorin/repos","events_url":"https://api.github.com/users/sorin/events{/privacy}","received_events_url":"https://api.github.com/users/sorin/received_events","type":"User","site_admin":false},"body":"Should sequelize attempt to include the missing id field? Should it raise an appropriate error?","created_at":"2015-08-22T21:50:15Z","updated_at":"2015-08-23T17:53:54Z","closed_at":"2015-08-23T17:53:54Z","merged_at":"2015-08-23T17:53:54Z","merge_commit_sha":"4828000ef1ad1e0a818fb4c885a8c3b61431e1c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sequelize/sequelize/pulls/4375/commits","review_comments_url":"https://api.github.com/repos/sequelize/sequelize/pulls/4375/comments","review_comment_url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/4375/comments","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/da715a16ebcfcd72118c4bf06449a05a09e4ff54","head":{"label":"sorin:sorin-separate-missing-id","ref":"sorin-separate-missing-id","sha":"da715a16ebcfcd72118c4bf06449a05a09e4ff54","user":{"login":"sorin","id":60167,"avatar_url":"https://avatars.githubusercontent.com/u/60167?v=3","gravatar_id":"","url":"https://api.github.com/users/sorin","html_url":"https://github.com/sorin","followers_url":"https://api.github.com/users/sorin/followers","following_url":"https://api.github.com/users/sorin/following{/other_user}","gists_url":"https://api.github.com/users/sorin/gists{/gist_id}","starred_url":"https://api.github.com/users/sorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorin/subscriptions","organizations_url":"https://api.github.com/users/sorin/orgs","repos_url":"https://api.github.com/users/sorin/repos","events_url":"https://api.github.com/users/sorin/events{/privacy}","received_events_url":"https://api.github.com/users/sorin/received_events","type":"User","site_admin":false},"repo":{"id":40225497,"name":"sequelize","full_name":"sorin/sequelize","owner":{"login":"sorin","id":60167,"avatar_url":"https://avatars.githubusercontent.com/u/60167?v=3","gravatar_id":"","url":"https://api.github.com/users/sorin","html_url":"https://github.com/sorin","followers_url":"https://api.github.com/users/sorin/followers","following_url":"https://api.github.com/users/sorin/following{/other_user}","gists_url":"https://api.github.com/users/sorin/gists{/gist_id}","starred_url":"https://api.github.com/users/sorin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorin/subscriptions","organizations_url":"https://api.github.com/users/sorin/orgs","repos_url":"https://api.github.com/users/sorin/repos","events_url":"https://api.github.com/users/sorin/events{/privacy}","received_events_url":"https://api.github.com/users/sorin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sorin/sequelize","description":"Sequelize is an easy-to-use multi sql dialect ORM for Node.js & io.js. It currently supports MySQL, MariaDB, SQLite, PostgreSQL and MSSQL.","fork":true,"url":"https://api.github.com/repos/sorin/sequelize","forks_url":"https://api.github.com/repos/sorin/sequelize/forks","keys_url":"https://api.github.com/repos/sorin/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sorin/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sorin/sequelize/teams","hooks_url":"https://api.github.com/repos/sorin/sequelize/hooks","issue_events_url":"https://api.github.com/repos/sorin/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/sorin/sequelize/events","assignees_url":"https://api.github.com/repos/sorin/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/sorin/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/sorin/sequelize/tags","blobs_url":"https://api.github.com/repos/sorin/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sorin/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sorin/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/sorin/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sorin/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/sorin/sequelize/languages","stargazers_url":"https://api.github.com/repos/sorin/sequelize/stargazers","contributors_url":"https://api.github.com/repos/sorin/sequelize/contributors","subscribers_url":"https://api.github.com/repos/sorin/sequelize/subscribers","subscription_url":"https://api.github.com/repos/sorin/sequelize/subscription","commits_url":"https://api.github.com/repos/sorin/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/sorin/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/sorin/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/sorin/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/sorin/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/sorin/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sorin/sequelize/merges","archive_url":"https://api.github.com/repos/sorin/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sorin/sequelize/downloads","issues_url":"https://api.github.com/repos/sorin/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/sorin/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/sorin/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/sorin/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sorin/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/sorin/sequelize/releases{/id}","created_at":"2015-08-05T05:04:15Z","updated_at":"2015-08-05T05:04:17Z","pushed_at":"2015-08-23T17:31:54Z","git_url":"git://github.com/sorin/sequelize.git","ssh_url":"git@github.com:sorin/sequelize.git","clone_url":"https://github.com/sorin/sequelize.git","svn_url":"https://github.com/sorin/sequelize","homepage":"http://sequelizejs.com","size":15541,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"sequelize:master","ref":"master","sha":"673a59bd6721b601a55a75093f9f59f3d1a487a6","user":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"repo":{"id":790359,"name":"sequelize","full_name":"sequelize/sequelize","owner":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequelize/sequelize","description":"Sequelize is an easy-to-use multi sql dialect ORM for Node.js & io.js. It currently supports MySQL, MariaDB, SQLite, PostgreSQL and MSSQL.","fork":false,"url":"https://api.github.com/repos/sequelize/sequelize","forks_url":"https://api.github.com/repos/sequelize/sequelize/forks","keys_url":"https://api.github.com/repos/sequelize/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequelize/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequelize/sequelize/teams","hooks_url":"https://api.github.com/repos/sequelize/sequelize/hooks","issue_events_url":"https://api.github.com/repos/sequelize/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/sequelize/sequelize/events","assignees_url":"https://api.github.com/repos/sequelize/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/sequelize/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/sequelize/sequelize/tags","blobs_url":"https://api.github.com/repos/sequelize/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequelize/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequelize/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequelize/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/sequelize/sequelize/languages","stargazers_url":"https://api.github.com/repos/sequelize/sequelize/stargazers","contributors_url":"https://api.github.com/repos/sequelize/sequelize/contributors","subscribers_url":"https://api.github.com/repos/sequelize/sequelize/subscribers","subscription_url":"https://api.github.com/repos/sequelize/sequelize/subscription","commits_url":"https://api.github.com/repos/sequelize/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequelize/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequelize/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequelize/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/sequelize/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/sequelize/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequelize/sequelize/merges","archive_url":"https://api.github.com/repos/sequelize/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequelize/sequelize/downloads","issues_url":"https://api.github.com/repos/sequelize/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/sequelize/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/sequelize/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/sequelize/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequelize/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/sequelize/sequelize/releases{/id}","created_at":"2010-07-22T07:11:11Z","updated_at":"2015-08-23T16:43:51Z","pushed_at":"2015-08-23T17:53:53Z","git_url":"git://github.com/sequelize/sequelize.git","ssh_url":"git@github.com:sequelize/sequelize.git","clone_url":"https://github.com/sequelize/sequelize.git","svn_url":"https://github.com/sequelize/sequelize","homepage":"http://sequelizejs.com","size":59314,"stargazers_count":4364,"watchers_count":4364,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":980,"mirror_url":null,"open_issues_count":495,"forks":980,"open_issues":495,"watchers":4364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/4375"},"html":{"href":"https://github.com/sequelize/sequelize/pull/4375"},"issue":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/4375"},"comments":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/4375/comments"},"review_comments":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/4375/comments"},"review_comment":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/4375/commits"},"statuses":{"href":"https://api.github.com/repos/sequelize/sequelize/statuses/da715a16ebcfcd72118c4bf06449a05a09e4ff54"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mickhansen","id":699049,"avatar_url":"https://avatars.githubusercontent.com/u/699049?v=3","gravatar_id":"","url":"https://api.github.com/users/mickhansen","html_url":"https://github.com/mickhansen","followers_url":"https://api.github.com/users/mickhansen/followers","following_url":"https://api.github.com/users/mickhansen/following{/other_user}","gists_url":"https://api.github.com/users/mickhansen/gists{/gist_id}","starred_url":"https://api.github.com/users/mickhansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickhansen/subscriptions","organizations_url":"https://api.github.com/users/mickhansen/orgs","repos_url":"https://api.github.com/users/mickhansen/repos","events_url":"https://api.github.com/users/mickhansen/events{/privacy}","received_events_url":"https://api.github.com/users/mickhansen/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":43,"deletions":0,"changed_files":2}}