{"action":"created","comment":{"url":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/comments/25405689","id":25405689,"diff_hunk":"@@ -94,8 +93,7 @@ var ObjectRouter = BaseRouter.extend({\n   // route for per-route handling, or override this method\n   // to modify the default handling of errors.\n   onError(e, routeData) {\n-    if (!console) { return this; }\n-    console.assert(false, e, e.stack);\n+    if (typeof console === 'object') { console.assert(false, e, e.stack); }","path":"src/router.js","position":21,"original_position":21,"commit_id":"d9fd0ab2ead0eb13a396b73896f00aa0fd8a98b7","original_commit_id":"d9fd0ab2ead0eb13a396b73896f00aa0fd8a98b7","user":{"login":"jmeas","id":2322305,"avatar_url":"https://avatars.githubusercontent.com/u/2322305?v=3","gravatar_id":"","url":"https://api.github.com/users/jmeas","html_url":"https://github.com/jmeas","followers_url":"https://api.github.com/users/jmeas/followers","following_url":"https://api.github.com/users/jmeas/following{/other_user}","gists_url":"https://api.github.com/users/jmeas/gists{/gist_id}","starred_url":"https://api.github.com/users/jmeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmeas/subscriptions","organizations_url":"https://api.github.com/users/jmeas/orgs","repos_url":"https://api.github.com/users/jmeas/repos","events_url":"https://api.github.com/users/jmeas/events{/privacy}","received_events_url":"https://api.github.com/users/jmeas/received_events","type":"User","site_admin":false},"body":"@megawac, nope. I just borrowed it from some code I saw in Ember / one of Tilde's libraries sometime. Feel free to change it!","created_at":"2015-02-26T05:32:28Z","updated_at":"2015-02-26T05:32:28Z","html_url":"https://github.com/jmeas/backbone.object-router/pull/25#discussion_r25405689","pull_request_url":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/comments/25405689"},"html":{"href":"https://github.com/jmeas/backbone.object-router/pull/25#discussion_r25405689"},"pull_request":{"href":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/25","id":30051854,"html_url":"https://github.com/jmeas/backbone.object-router/pull/25","diff_url":"https://github.com/jmeas/backbone.object-router/pull/25.diff","patch_url":"https://github.com/jmeas/backbone.object-router/pull/25.patch","issue_url":"https://api.github.com/repos/jmeas/backbone.object-router/issues/25","number":25,"state":"open","locked":false,"title":"Minor logic simplifications and proper check for console","user":{"login":"megawac","id":3475472,"avatar_url":"https://avatars.githubusercontent.com/u/3475472?v=3","gravatar_id":"","url":"https://api.github.com/users/megawac","html_url":"https://github.com/megawac","followers_url":"https://api.github.com/users/megawac/followers","following_url":"https://api.github.com/users/megawac/following{/other_user}","gists_url":"https://api.github.com/users/megawac/gists{/gist_id}","starred_url":"https://api.github.com/users/megawac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megawac/subscriptions","organizations_url":"https://api.github.com/users/megawac/orgs","repos_url":"https://api.github.com/users/megawac/repos","events_url":"https://api.github.com/users/megawac/events{/privacy}","received_events_url":"https://api.github.com/users/megawac/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-26T05:30:06Z","updated_at":"2015-02-26T05:32:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ec9f0cebd7c3e185ba00775dec04bfac803f4ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/25/commits","review_comments_url":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/25/comments","review_comment_url":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmeas/backbone.object-router/issues/25/comments","statuses_url":"https://api.github.com/repos/jmeas/backbone.object-router/statuses/d9fd0ab2ead0eb13a396b73896f00aa0fd8a98b7","head":{"label":"megawac:logic-simp","ref":"logic-simp","sha":"d9fd0ab2ead0eb13a396b73896f00aa0fd8a98b7","user":{"login":"megawac","id":3475472,"avatar_url":"https://avatars.githubusercontent.com/u/3475472?v=3","gravatar_id":"","url":"https://api.github.com/users/megawac","html_url":"https://github.com/megawac","followers_url":"https://api.github.com/users/megawac/followers","following_url":"https://api.github.com/users/megawac/following{/other_user}","gists_url":"https://api.github.com/users/megawac/gists{/gist_id}","starred_url":"https://api.github.com/users/megawac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megawac/subscriptions","organizations_url":"https://api.github.com/users/megawac/orgs","repos_url":"https://api.github.com/users/megawac/repos","events_url":"https://api.github.com/users/megawac/events{/privacy}","received_events_url":"https://api.github.com/users/megawac/received_events","type":"User","site_admin":false},"repo":{"id":31352132,"name":"backbone.object-router","full_name":"megawac/backbone.object-router","owner":{"login":"megawac","id":3475472,"avatar_url":"https://avatars.githubusercontent.com/u/3475472?v=3","gravatar_id":"","url":"https://api.github.com/users/megawac","html_url":"https://github.com/megawac","followers_url":"https://api.github.com/users/megawac/followers","following_url":"https://api.github.com/users/megawac/following{/other_user}","gists_url":"https://api.github.com/users/megawac/gists{/gist_id}","starred_url":"https://api.github.com/users/megawac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megawac/subscriptions","organizations_url":"https://api.github.com/users/megawac/orgs","repos_url":"https://api.github.com/users/megawac/repos","events_url":"https://api.github.com/users/megawac/events{/privacy}","received_events_url":"https://api.github.com/users/megawac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/megawac/backbone.object-router","description":"A much better Router for Backbone.","fork":true,"url":"https://api.github.com/repos/megawac/backbone.object-router","forks_url":"https://api.github.com/repos/megawac/backbone.object-router/forks","keys_url":"https://api.github.com/repos/megawac/backbone.object-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/megawac/backbone.object-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/megawac/backbone.object-router/teams","hooks_url":"https://api.github.com/repos/megawac/backbone.object-router/hooks","issue_events_url":"https://api.github.com/repos/megawac/backbone.object-router/issues/events{/number}","events_url":"https://api.github.com/repos/megawac/backbone.object-router/events","assignees_url":"https://api.github.com/repos/megawac/backbone.object-router/assignees{/user}","branches_url":"https://api.github.com/repos/megawac/backbone.object-router/branches{/branch}","tags_url":"https://api.github.com/repos/megawac/backbone.object-router/tags","blobs_url":"https://api.github.com/repos/megawac/backbone.object-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/megawac/backbone.object-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/megawac/backbone.object-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/megawac/backbone.object-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/megawac/backbone.object-router/statuses/{sha}","languages_url":"https://api.github.com/repos/megawac/backbone.object-router/languages","stargazers_url":"https://api.github.com/repos/megawac/backbone.object-router/stargazers","contributors_url":"https://api.github.com/repos/megawac/backbone.object-router/contributors","subscribers_url":"https://api.github.com/repos/megawac/backbone.object-router/subscribers","subscription_url":"https://api.github.com/repos/megawac/backbone.object-router/subscription","commits_url":"https://api.github.com/repos/megawac/backbone.object-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/megawac/backbone.object-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/megawac/backbone.object-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/megawac/backbone.object-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/megawac/backbone.object-router/contents/{+path}","compare_url":"https://api.github.com/repos/megawac/backbone.object-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/megawac/backbone.object-router/merges","archive_url":"https://api.github.com/repos/megawac/backbone.object-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/megawac/backbone.object-router/downloads","issues_url":"https://api.github.com/repos/megawac/backbone.object-router/issues{/number}","pulls_url":"https://api.github.com/repos/megawac/backbone.object-router/pulls{/number}","milestones_url":"https://api.github.com/repos/megawac/backbone.object-router/milestones{/number}","notifications_url":"https://api.github.com/repos/megawac/backbone.object-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/megawac/backbone.object-router/labels{/name}","releases_url":"https://api.github.com/repos/megawac/backbone.object-router/releases{/id}","created_at":"2015-02-26T05:29:32Z","updated_at":"2015-02-26T05:29:33Z","pushed_at":"2015-02-26T05:29:46Z","git_url":"git://github.com/megawac/backbone.object-router.git","ssh_url":"git@github.com:megawac/backbone.object-router.git","clone_url":"https://github.com/megawac/backbone.object-router.git","svn_url":"https://github.com/megawac/backbone.object-router","homepage":"","size":192,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmeas:master","ref":"master","sha":"89e32f640cc75526516fb1c0d082a35b55e49f01","user":{"login":"jmeas","id":2322305,"avatar_url":"https://avatars.githubusercontent.com/u/2322305?v=3","gravatar_id":"","url":"https://api.github.com/users/jmeas","html_url":"https://github.com/jmeas","followers_url":"https://api.github.com/users/jmeas/followers","following_url":"https://api.github.com/users/jmeas/following{/other_user}","gists_url":"https://api.github.com/users/jmeas/gists{/gist_id}","starred_url":"https://api.github.com/users/jmeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmeas/subscriptions","organizations_url":"https://api.github.com/users/jmeas/orgs","repos_url":"https://api.github.com/users/jmeas/repos","events_url":"https://api.github.com/users/jmeas/events{/privacy}","received_events_url":"https://api.github.com/users/jmeas/received_events","type":"User","site_admin":false},"repo":{"id":26333729,"name":"backbone.object-router","full_name":"jmeas/backbone.object-router","owner":{"login":"jmeas","id":2322305,"avatar_url":"https://avatars.githubusercontent.com/u/2322305?v=3","gravatar_id":"","url":"https://api.github.com/users/jmeas","html_url":"https://github.com/jmeas","followers_url":"https://api.github.com/users/jmeas/followers","following_url":"https://api.github.com/users/jmeas/following{/other_user}","gists_url":"https://api.github.com/users/jmeas/gists{/gist_id}","starred_url":"https://api.github.com/users/jmeas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmeas/subscriptions","organizations_url":"https://api.github.com/users/jmeas/orgs","repos_url":"https://api.github.com/users/jmeas/repos","events_url":"https://api.github.com/users/jmeas/events{/privacy}","received_events_url":"https://api.github.com/users/jmeas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmeas/backbone.object-router","description":"A much better Router for Backbone.","fork":false,"url":"https://api.github.com/repos/jmeas/backbone.object-router","forks_url":"https://api.github.com/repos/jmeas/backbone.object-router/forks","keys_url":"https://api.github.com/repos/jmeas/backbone.object-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmeas/backbone.object-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmeas/backbone.object-router/teams","hooks_url":"https://api.github.com/repos/jmeas/backbone.object-router/hooks","issue_events_url":"https://api.github.com/repos/jmeas/backbone.object-router/issues/events{/number}","events_url":"https://api.github.com/repos/jmeas/backbone.object-router/events","assignees_url":"https://api.github.com/repos/jmeas/backbone.object-router/assignees{/user}","branches_url":"https://api.github.com/repos/jmeas/backbone.object-router/branches{/branch}","tags_url":"https://api.github.com/repos/jmeas/backbone.object-router/tags","blobs_url":"https://api.github.com/repos/jmeas/backbone.object-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmeas/backbone.object-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmeas/backbone.object-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmeas/backbone.object-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmeas/backbone.object-router/statuses/{sha}","languages_url":"https://api.github.com/repos/jmeas/backbone.object-router/languages","stargazers_url":"https://api.github.com/repos/jmeas/backbone.object-router/stargazers","contributors_url":"https://api.github.com/repos/jmeas/backbone.object-router/contributors","subscribers_url":"https://api.github.com/repos/jmeas/backbone.object-router/subscribers","subscription_url":"https://api.github.com/repos/jmeas/backbone.object-router/subscription","commits_url":"https://api.github.com/repos/jmeas/backbone.object-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmeas/backbone.object-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmeas/backbone.object-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmeas/backbone.object-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmeas/backbone.object-router/contents/{+path}","compare_url":"https://api.github.com/repos/jmeas/backbone.object-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmeas/backbone.object-router/merges","archive_url":"https://api.github.com/repos/jmeas/backbone.object-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmeas/backbone.object-router/downloads","issues_url":"https://api.github.com/repos/jmeas/backbone.object-router/issues{/number}","pulls_url":"https://api.github.com/repos/jmeas/backbone.object-router/pulls{/number}","milestones_url":"https://api.github.com/repos/jmeas/backbone.object-router/milestones{/number}","notifications_url":"https://api.github.com/repos/jmeas/backbone.object-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmeas/backbone.object-router/labels{/name}","releases_url":"https://api.github.com/repos/jmeas/backbone.object-router/releases{/id}","created_at":"2014-11-07T19:08:26Z","updated_at":"2015-02-26T05:29:27Z","pushed_at":"2015-02-26T05:29:28Z","git_url":"git://github.com/jmeas/backbone.object-router.git","ssh_url":"git@github.com:jmeas/backbone.object-router.git","clone_url":"https://github.com/jmeas/backbone.object-router.git","svn_url":"https://github.com/jmeas/backbone.object-router","homepage":"","size":192,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":10,"forks":1,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/25"},"html":{"href":"https://github.com/jmeas/backbone.object-router/pull/25"},"issue":{"href":"https://api.github.com/repos/jmeas/backbone.object-router/issues/25"},"comments":{"href":"https://api.github.com/repos/jmeas/backbone.object-router/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmeas/backbone.object-router/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/jmeas/backbone.object-router/statuses/d9fd0ab2ead0eb13a396b73896f00aa0fd8a98b7"}}}}