{"action":"created","comment":{"url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/comments/33024738","id":33024738,"diff_hunk":"@@ -44,21 +44,9 @@ angular.module('apacheZeppelinGsocApp').factory('NVD3ChartFactory', function(Cha\n     data: [{","path":"app/scripts/chart-factory/nvd3-chart-factory.js","position":12,"original_position":12,"commit_id":"47b67281d53fbd3bd572c111c2a440228c3c9faa","original_commit_id":"47b67281d53fbd3bd572c111c2a440228c3c9faa","user":{"login":"corneadoug","id":710411,"avatar_url":"https://avatars.githubusercontent.com/u/710411?v=3","gravatar_id":"","url":"https://api.github.com/users/corneadoug","html_url":"https://github.com/corneadoug","followers_url":"https://api.github.com/users/corneadoug/followers","following_url":"https://api.github.com/users/corneadoug/following{/other_user}","gists_url":"https://api.github.com/users/corneadoug/gists{/gist_id}","starred_url":"https://api.github.com/users/corneadoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corneadoug/subscriptions","organizations_url":"https://api.github.com/users/corneadoug/orgs","repos_url":"https://api.github.com/users/corneadoug/repos","events_url":"https://api.github.com/users/corneadoug/events{/privacy}","received_events_url":"https://api.github.com/users/corneadoug/received_events","type":"User","site_admin":false},"body":"still some dummy data?","created_at":"2015-06-23T09:38:40Z","updated_at":"2015-06-23T09:38:40Z","html_url":"https://github.com/Madhuka/apache-zeppelin-gsoc/pull/5#discussion_r33024738","pull_request_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/comments/33024738"},"html":{"href":"https://github.com/Madhuka/apache-zeppelin-gsoc/pull/5#discussion_r33024738"},"pull_request":{"href":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/5","id":38255879,"html_url":"https://github.com/Madhuka/apache-zeppelin-gsoc/pull/5","diff_url":"https://github.com/Madhuka/apache-zeppelin-gsoc/pull/5.diff","patch_url":"https://github.com/Madhuka/apache-zeppelin-gsoc/pull/5.patch","issue_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/issues/5","number":5,"state":"open","locked":false,"title":"Adding milestone 03","user":{"login":"Madhuka","id":1180128,"avatar_url":"https://avatars.githubusercontent.com/u/1180128?v=3","gravatar_id":"","url":"https://api.github.com/users/Madhuka","html_url":"https://github.com/Madhuka","followers_url":"https://api.github.com/users/Madhuka/followers","following_url":"https://api.github.com/users/Madhuka/following{/other_user}","gists_url":"https://api.github.com/users/Madhuka/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhuka/subscriptions","organizations_url":"https://api.github.com/users/Madhuka/orgs","repos_url":"https://api.github.com/users/Madhuka/repos","events_url":"https://api.github.com/users/Madhuka/events{/privacy}","received_events_url":"https://api.github.com/users/Madhuka/received_events","type":"User","site_admin":false},"body":"Feature List\r\n * Make library and charts plug-gable (Remove hard coded code, and simulate loading libraries)\r\n * Fixes and code improvement\r\n * Bigger Test Cover\r\n * Scenario Tests\r\n * Remove unused files\r\n\r\nReadme\r\n- [x] Add all the steps: Bower install and npm install are missing\r\nUI:\r\n- [x] No button style (just text) when we run grunt serve\r\n- [x] Need similar width for all charts (NVD3 is smaller than others for example)\r\n- [ ] Need to have meaningful legends\r\nBugs:\r\n- [x]  After selecting a dataset, then a chart library, it will draw the chart. However if you click again on the same chart type that the one shown, there won't be any data in the chart.\r\n\r\nCode Style:\r\n- [x]  Fix trailing spaces\r\n- [x]  Make code on multiple lines when html line are too long (~100-120 columns)\r\n- [x] Fix google-chart-factory indentation\r\n- [x] Fix Typos\r\n\r\nHtml reduction:\r\n- [x] Reduce HTML lines repetitions, use ng-repeat with a configuration object instead\r\n- [x] Remove unused files\r\n\r\nMake code scalable for pluggable libraries:\r\n- [ ] Remove hard coded library names etc... from javascript code. Only an Array with Library Names should be used as configuration to refer to.\r\n- [x] Include the Chart Html only when needed\r\n-> cf. ng-include, and https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/app/index.html line 51 for example\r\nFix a few bad things:\r\n- [x] Remove the dummy Data from chart factories\r\n- [ ] loadData should not be inside of ChartCtrl\r\n- [x] Change hardcoded loadChartLibrary function parameter inside the HTML: loadChartLibrary(2) -> should be loadChartLibrary($index) or (chart.name)\r\nTests:\r\n- [ ] Implement more tests, and change code if necessary\r\n- [ ] Implement some scenario type of tests","created_at":"2015-06-22T17:32:02Z","updated_at":"2015-06-23T09:38:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4c4821e954a8cdb5ce7c93fa74c80d578d4579d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/issues/5/comments","statuses_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/statuses/47b67281d53fbd3bd572c111c2a440228c3c9faa","head":{"label":"Madhuka:milestone-03","ref":"milestone-03","sha":"47b67281d53fbd3bd572c111c2a440228c3c9faa","user":{"login":"Madhuka","id":1180128,"avatar_url":"https://avatars.githubusercontent.com/u/1180128?v=3","gravatar_id":"","url":"https://api.github.com/users/Madhuka","html_url":"https://github.com/Madhuka","followers_url":"https://api.github.com/users/Madhuka/followers","following_url":"https://api.github.com/users/Madhuka/following{/other_user}","gists_url":"https://api.github.com/users/Madhuka/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhuka/subscriptions","organizations_url":"https://api.github.com/users/Madhuka/orgs","repos_url":"https://api.github.com/users/Madhuka/repos","events_url":"https://api.github.com/users/Madhuka/events{/privacy}","received_events_url":"https://api.github.com/users/Madhuka/received_events","type":"User","site_admin":false},"repo":{"id":36793550,"name":"apache-zeppelin-gsoc","full_name":"Madhuka/apache-zeppelin-gsoc","owner":{"login":"Madhuka","id":1180128,"avatar_url":"https://avatars.githubusercontent.com/u/1180128?v=3","gravatar_id":"","url":"https://api.github.com/users/Madhuka","html_url":"https://github.com/Madhuka","followers_url":"https://api.github.com/users/Madhuka/followers","following_url":"https://api.github.com/users/Madhuka/following{/other_user}","gists_url":"https://api.github.com/users/Madhuka/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhuka/subscriptions","organizations_url":"https://api.github.com/users/Madhuka/orgs","repos_url":"https://api.github.com/users/Madhuka/repos","events_url":"https://api.github.com/users/Madhuka/events{/privacy}","received_events_url":"https://api.github.com/users/Madhuka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Madhuka/apache-zeppelin-gsoc","description":"","fork":false,"url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc","forks_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/forks","keys_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/teams","hooks_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/hooks","issue_events_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/issues/events{/number}","events_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/events","assignees_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/assignees{/user}","branches_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/branches{/branch}","tags_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/tags","blobs_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/statuses/{sha}","languages_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/languages","stargazers_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/stargazers","contributors_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/contributors","subscribers_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/subscribers","subscription_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/subscription","commits_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/contents/{+path}","compare_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/merges","archive_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/downloads","issues_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/issues{/number}","pulls_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls{/number}","milestones_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/milestones{/number}","notifications_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/labels{/name}","releases_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/releases{/id}","created_at":"2015-06-03T09:26:06Z","updated_at":"2015-06-03T14:56:13Z","pushed_at":"2015-06-23T08:59:50Z","git_url":"git://github.com/Madhuka/apache-zeppelin-gsoc.git","ssh_url":"git@github.com:Madhuka/apache-zeppelin-gsoc.git","clone_url":"https://github.com/Madhuka/apache-zeppelin-gsoc.git","svn_url":"https://github.com/Madhuka/apache-zeppelin-gsoc","homepage":null,"size":432,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Madhuka:milestone-02","ref":"milestone-02","sha":"75d01abb0158956db2461fc934b90d714f7b2e20","user":{"login":"Madhuka","id":1180128,"avatar_url":"https://avatars.githubusercontent.com/u/1180128?v=3","gravatar_id":"","url":"https://api.github.com/users/Madhuka","html_url":"https://github.com/Madhuka","followers_url":"https://api.github.com/users/Madhuka/followers","following_url":"https://api.github.com/users/Madhuka/following{/other_user}","gists_url":"https://api.github.com/users/Madhuka/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhuka/subscriptions","organizations_url":"https://api.github.com/users/Madhuka/orgs","repos_url":"https://api.github.com/users/Madhuka/repos","events_url":"https://api.github.com/users/Madhuka/events{/privacy}","received_events_url":"https://api.github.com/users/Madhuka/received_events","type":"User","site_admin":false},"repo":{"id":36793550,"name":"apache-zeppelin-gsoc","full_name":"Madhuka/apache-zeppelin-gsoc","owner":{"login":"Madhuka","id":1180128,"avatar_url":"https://avatars.githubusercontent.com/u/1180128?v=3","gravatar_id":"","url":"https://api.github.com/users/Madhuka","html_url":"https://github.com/Madhuka","followers_url":"https://api.github.com/users/Madhuka/followers","following_url":"https://api.github.com/users/Madhuka/following{/other_user}","gists_url":"https://api.github.com/users/Madhuka/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhuka/subscriptions","organizations_url":"https://api.github.com/users/Madhuka/orgs","repos_url":"https://api.github.com/users/Madhuka/repos","events_url":"https://api.github.com/users/Madhuka/events{/privacy}","received_events_url":"https://api.github.com/users/Madhuka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Madhuka/apache-zeppelin-gsoc","description":"","fork":false,"url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc","forks_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/forks","keys_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/teams","hooks_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/hooks","issue_events_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/issues/events{/number}","events_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/events","assignees_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/assignees{/user}","branches_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/branches{/branch}","tags_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/tags","blobs_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/statuses/{sha}","languages_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/languages","stargazers_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/stargazers","contributors_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/contributors","subscribers_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/subscribers","subscription_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/subscription","commits_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/contents/{+path}","compare_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/merges","archive_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/downloads","issues_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/issues{/number}","pulls_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls{/number}","milestones_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/milestones{/number}","notifications_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/labels{/name}","releases_url":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/releases{/id}","created_at":"2015-06-03T09:26:06Z","updated_at":"2015-06-03T14:56:13Z","pushed_at":"2015-06-23T08:59:50Z","git_url":"git://github.com/Madhuka/apache-zeppelin-gsoc.git","ssh_url":"git@github.com:Madhuka/apache-zeppelin-gsoc.git","clone_url":"https://github.com/Madhuka/apache-zeppelin-gsoc.git","svn_url":"https://github.com/Madhuka/apache-zeppelin-gsoc","homepage":null,"size":432,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/5"},"html":{"href":"https://github.com/Madhuka/apache-zeppelin-gsoc/pull/5"},"issue":{"href":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/issues/5"},"comments":{"href":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Madhuka/apache-zeppelin-gsoc/statuses/47b67281d53fbd3bd572c111c2a440228c3c9faa"}}}}