{"action":"created","comment":{"url":"https://api.github.com/repos/lhorie/mithril.js/pulls/comments/47625739","id":47625739,"diff_hunk":"@@ -1193,9 +1193,52 @@ void (function (global, factory) { // eslint-disable-line\n \t\treturn prop\n \t}\n \n+\tfunction isPromise(object) {\n+\t\treturn object != null && (isObject(object) || isFunction(object)) &&\n+\t\t\t\tisFunction(object.then)\n+\t}\n+\n+\tfunction simpleResolve(p, callback) {\n+\t\tif (p.then) {\n+\t\t\treturn p.then(callback)\n+\t\t} else {\n+\t\t\treturn callback()\n+\t\t}\n+\t}\n+\n+\tfunction propify(promise) {\n+\t\tvar prop = m.prop()\n+\t\tpromise.then(prop)\n+\n+\t\tprop.then = function (fufill, reject) {","path":"mithril.js","position":null,"original_position":21,"commit_id":"9428fe729ccffcc4e710483de75dc494ae38ef16","original_commit_id":"90701a4cbbe3191be77a4311fd84497f90f43f80","user":{"login":"isiahmeadows","id":4483844,"avatar_url":"https://avatars.githubusercontent.com/u/4483844?v=3","gravatar_id":"","url":"https://api.github.com/users/isiahmeadows","html_url":"https://github.com/isiahmeadows","followers_url":"https://api.github.com/users/isiahmeadows/followers","following_url":"https://api.github.com/users/isiahmeadows/following{/other_user}","gists_url":"https://api.github.com/users/isiahmeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/isiahmeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isiahmeadows/subscriptions","organizations_url":"https://api.github.com/users/isiahmeadows/orgs","repos_url":"https://api.github.com/users/isiahmeadows/repos","events_url":"https://api.github.com/users/isiahmeadows/events{/privacy}","received_events_url":"https://api.github.com/users/isiahmeadows/received_events","type":"User","site_admin":false},"body":"Don't really know","created_at":"2015-12-15T11:38:50Z","updated_at":"2015-12-15T11:38:50Z","html_url":"https://github.com/lhorie/mithril.js/pull/853#discussion_r47625739","pull_request_url":"https://api.github.com/repos/lhorie/mithril.js/pulls/853","_links":{"self":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/comments/47625739"},"html":{"href":"https://github.com/lhorie/mithril.js/pull/853#discussion_r47625739"},"pull_request":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/853"}}},"pull_request":{"url":"https://api.github.com/repos/lhorie/mithril.js/pulls/853","id":51326946,"html_url":"https://github.com/lhorie/mithril.js/pull/853","diff_url":"https://github.com/lhorie/mithril.js/pull/853.diff","patch_url":"https://github.com/lhorie/mithril.js/pull/853.patch","issue_url":"https://api.github.com/repos/lhorie/mithril.js/issues/853","number":853,"state":"open","locked":false,"title":"Isolate m.prop() and m.deferred() implementations (mostly)","user":{"login":"isiahmeadows","id":4483844,"avatar_url":"https://avatars.githubusercontent.com/u/4483844?v=3","gravatar_id":"","url":"https://api.github.com/users/isiahmeadows","html_url":"https://github.com/isiahmeadows","followers_url":"https://api.github.com/users/isiahmeadows/followers","following_url":"https://api.github.com/users/isiahmeadows/following{/other_user}","gists_url":"https://api.github.com/users/isiahmeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/isiahmeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isiahmeadows/subscriptions","organizations_url":"https://api.github.com/users/isiahmeadows/orgs","repos_url":"https://api.github.com/users/isiahmeadows/repos","events_url":"https://api.github.com/users/isiahmeadows/events{/privacy}","received_events_url":"https://api.github.com/users/isiahmeadows/received_events","type":"User","site_admin":false},"body":"This mostly isolates the implementations for both of these. Now, everything\r\nhere calls the method itself, not any of the external methods.\r\n\r\nFew driveby fixes as well:\r\n\r\n1. Git now ignores archive/ again (it's a build artifact, and can be removed\r\n   when updating `master`)\r\n2. Since I had to rewrite most of the Deferred implementation, the new version\r\n   passes one of the skipped tests, so it is now enabled.\r\n\r\nPrepares for #800.","created_at":"2015-11-20T07:51:39Z","updated_at":"2015-12-15T11:38:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec80b5a463a851a0c497c20c00f5ad0c99fe7073","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lhorie/mithril.js/pulls/853/commits","review_comments_url":"https://api.github.com/repos/lhorie/mithril.js/pulls/853/comments","review_comment_url":"https://api.github.com/repos/lhorie/mithril.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lhorie/mithril.js/issues/853/comments","statuses_url":"https://api.github.com/repos/lhorie/mithril.js/statuses/9428fe729ccffcc4e710483de75dc494ae38ef16","head":{"label":"isiahmeadows:prop-fix","ref":"prop-fix","sha":"9428fe729ccffcc4e710483de75dc494ae38ef16","user":{"login":"isiahmeadows","id":4483844,"avatar_url":"https://avatars.githubusercontent.com/u/4483844?v=3","gravatar_id":"","url":"https://api.github.com/users/isiahmeadows","html_url":"https://github.com/isiahmeadows","followers_url":"https://api.github.com/users/isiahmeadows/followers","following_url":"https://api.github.com/users/isiahmeadows/following{/other_user}","gists_url":"https://api.github.com/users/isiahmeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/isiahmeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isiahmeadows/subscriptions","organizations_url":"https://api.github.com/users/isiahmeadows/orgs","repos_url":"https://api.github.com/users/isiahmeadows/repos","events_url":"https://api.github.com/users/isiahmeadows/events{/privacy}","received_events_url":"https://api.github.com/users/isiahmeadows/received_events","type":"User","site_admin":false},"repo":{"id":35352522,"name":"mithril.js","full_name":"isiahmeadows/mithril.js","owner":{"login":"isiahmeadows","id":4483844,"avatar_url":"https://avatars.githubusercontent.com/u/4483844?v=3","gravatar_id":"","url":"https://api.github.com/users/isiahmeadows","html_url":"https://github.com/isiahmeadows","followers_url":"https://api.github.com/users/isiahmeadows/followers","following_url":"https://api.github.com/users/isiahmeadows/following{/other_user}","gists_url":"https://api.github.com/users/isiahmeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/isiahmeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isiahmeadows/subscriptions","organizations_url":"https://api.github.com/users/isiahmeadows/orgs","repos_url":"https://api.github.com/users/isiahmeadows/repos","events_url":"https://api.github.com/users/isiahmeadows/events{/privacy}","received_events_url":"https://api.github.com/users/isiahmeadows/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isiahmeadows/mithril.js","description":"A Javascript Framework for Building Brilliant Applications (development repo)","fork":true,"url":"https://api.github.com/repos/isiahmeadows/mithril.js","forks_url":"https://api.github.com/repos/isiahmeadows/mithril.js/forks","keys_url":"https://api.github.com/repos/isiahmeadows/mithril.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isiahmeadows/mithril.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isiahmeadows/mithril.js/teams","hooks_url":"https://api.github.com/repos/isiahmeadows/mithril.js/hooks","issue_events_url":"https://api.github.com/repos/isiahmeadows/mithril.js/issues/events{/number}","events_url":"https://api.github.com/repos/isiahmeadows/mithril.js/events","assignees_url":"https://api.github.com/repos/isiahmeadows/mithril.js/assignees{/user}","branches_url":"https://api.github.com/repos/isiahmeadows/mithril.js/branches{/branch}","tags_url":"https://api.github.com/repos/isiahmeadows/mithril.js/tags","blobs_url":"https://api.github.com/repos/isiahmeadows/mithril.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isiahmeadows/mithril.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isiahmeadows/mithril.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/isiahmeadows/mithril.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isiahmeadows/mithril.js/statuses/{sha}","languages_url":"https://api.github.com/repos/isiahmeadows/mithril.js/languages","stargazers_url":"https://api.github.com/repos/isiahmeadows/mithril.js/stargazers","contributors_url":"https://api.github.com/repos/isiahmeadows/mithril.js/contributors","subscribers_url":"https://api.github.com/repos/isiahmeadows/mithril.js/subscribers","subscription_url":"https://api.github.com/repos/isiahmeadows/mithril.js/subscription","commits_url":"https://api.github.com/repos/isiahmeadows/mithril.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/isiahmeadows/mithril.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/isiahmeadows/mithril.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/isiahmeadows/mithril.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/isiahmeadows/mithril.js/contents/{+path}","compare_url":"https://api.github.com/repos/isiahmeadows/mithril.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isiahmeadows/mithril.js/merges","archive_url":"https://api.github.com/repos/isiahmeadows/mithril.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isiahmeadows/mithril.js/downloads","issues_url":"https://api.github.com/repos/isiahmeadows/mithril.js/issues{/number}","pulls_url":"https://api.github.com/repos/isiahmeadows/mithril.js/pulls{/number}","milestones_url":"https://api.github.com/repos/isiahmeadows/mithril.js/milestones{/number}","notifications_url":"https://api.github.com/repos/isiahmeadows/mithril.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isiahmeadows/mithril.js/labels{/name}","releases_url":"https://api.github.com/repos/isiahmeadows/mithril.js/releases{/id}","created_at":"2015-05-10T01:36:31Z","updated_at":"2015-05-10T01:36:31Z","pushed_at":"2015-12-15T11:38:15Z","git_url":"git://github.com/isiahmeadows/mithril.js.git","ssh_url":"git@github.com:isiahmeadows/mithril.js.git","clone_url":"https://github.com/isiahmeadows/mithril.js.git","svn_url":"https://github.com/isiahmeadows/mithril.js","homepage":"http://mithril.js.org","size":3920,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"lhorie:next","ref":"next","sha":"c202c04631369e8bb72158d065003f0762cf4912","user":{"login":"lhorie","id":1637573,"avatar_url":"https://avatars.githubusercontent.com/u/1637573?v=3","gravatar_id":"","url":"https://api.github.com/users/lhorie","html_url":"https://github.com/lhorie","followers_url":"https://api.github.com/users/lhorie/followers","following_url":"https://api.github.com/users/lhorie/following{/other_user}","gists_url":"https://api.github.com/users/lhorie/gists{/gist_id}","starred_url":"https://api.github.com/users/lhorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhorie/subscriptions","organizations_url":"https://api.github.com/users/lhorie/orgs","repos_url":"https://api.github.com/users/lhorie/repos","events_url":"https://api.github.com/users/lhorie/events{/privacy}","received_events_url":"https://api.github.com/users/lhorie/received_events","type":"User","site_admin":false},"repo":{"id":17814354,"name":"mithril.js","full_name":"lhorie/mithril.js","owner":{"login":"lhorie","id":1637573,"avatar_url":"https://avatars.githubusercontent.com/u/1637573?v=3","gravatar_id":"","url":"https://api.github.com/users/lhorie","html_url":"https://github.com/lhorie","followers_url":"https://api.github.com/users/lhorie/followers","following_url":"https://api.github.com/users/lhorie/following{/other_user}","gists_url":"https://api.github.com/users/lhorie/gists{/gist_id}","starred_url":"https://api.github.com/users/lhorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhorie/subscriptions","organizations_url":"https://api.github.com/users/lhorie/orgs","repos_url":"https://api.github.com/users/lhorie/repos","events_url":"https://api.github.com/users/lhorie/events{/privacy}","received_events_url":"https://api.github.com/users/lhorie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lhorie/mithril.js","description":"A Javascript Framework for Building Brilliant Applications (development repo)","fork":false,"url":"https://api.github.com/repos/lhorie/mithril.js","forks_url":"https://api.github.com/repos/lhorie/mithril.js/forks","keys_url":"https://api.github.com/repos/lhorie/mithril.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lhorie/mithril.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lhorie/mithril.js/teams","hooks_url":"https://api.github.com/repos/lhorie/mithril.js/hooks","issue_events_url":"https://api.github.com/repos/lhorie/mithril.js/issues/events{/number}","events_url":"https://api.github.com/repos/lhorie/mithril.js/events","assignees_url":"https://api.github.com/repos/lhorie/mithril.js/assignees{/user}","branches_url":"https://api.github.com/repos/lhorie/mithril.js/branches{/branch}","tags_url":"https://api.github.com/repos/lhorie/mithril.js/tags","blobs_url":"https://api.github.com/repos/lhorie/mithril.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lhorie/mithril.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lhorie/mithril.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/lhorie/mithril.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lhorie/mithril.js/statuses/{sha}","languages_url":"https://api.github.com/repos/lhorie/mithril.js/languages","stargazers_url":"https://api.github.com/repos/lhorie/mithril.js/stargazers","contributors_url":"https://api.github.com/repos/lhorie/mithril.js/contributors","subscribers_url":"https://api.github.com/repos/lhorie/mithril.js/subscribers","subscription_url":"https://api.github.com/repos/lhorie/mithril.js/subscription","commits_url":"https://api.github.com/repos/lhorie/mithril.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/lhorie/mithril.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/lhorie/mithril.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/lhorie/mithril.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/lhorie/mithril.js/contents/{+path}","compare_url":"https://api.github.com/repos/lhorie/mithril.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lhorie/mithril.js/merges","archive_url":"https://api.github.com/repos/lhorie/mithril.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lhorie/mithril.js/downloads","issues_url":"https://api.github.com/repos/lhorie/mithril.js/issues{/number}","pulls_url":"https://api.github.com/repos/lhorie/mithril.js/pulls{/number}","milestones_url":"https://api.github.com/repos/lhorie/mithril.js/milestones{/number}","notifications_url":"https://api.github.com/repos/lhorie/mithril.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lhorie/mithril.js/labels{/name}","releases_url":"https://api.github.com/repos/lhorie/mithril.js/releases{/id}","created_at":"2014-03-17T01:59:39Z","updated_at":"2015-12-15T08:05:01Z","pushed_at":"2015-12-15T11:38:16Z","git_url":"git://github.com/lhorie/mithril.js.git","ssh_url":"git@github.com:lhorie/mithril.js.git","clone_url":"https://github.com/lhorie/mithril.js.git","svn_url":"https://github.com/lhorie/mithril.js","homepage":"http://mithril.js.org","size":4493,"stargazers_count":5136,"watchers_count":5136,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":388,"mirror_url":null,"open_issues_count":99,"forks":388,"open_issues":99,"watchers":5136,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/853"},"html":{"href":"https://github.com/lhorie/mithril.js/pull/853"},"issue":{"href":"https://api.github.com/repos/lhorie/mithril.js/issues/853"},"comments":{"href":"https://api.github.com/repos/lhorie/mithril.js/issues/853/comments"},"review_comments":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/853/comments"},"review_comment":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lhorie/mithril.js/pulls/853/commits"},"statuses":{"href":"https://api.github.com/repos/lhorie/mithril.js/statuses/9428fe729ccffcc4e710483de75dc494ae38ef16"}}}}