{"action":"opened","number":354,"pull_request":{"url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/pulls/354","id":28354842,"html_url":"https://github.com/scalikejdbc/scalikejdbc/pull/354","diff_url":"https://github.com/scalikejdbc/scalikejdbc/pull/354.diff","patch_url":"https://github.com/scalikejdbc/scalikejdbc/pull/354.patch","issue_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/issues/354","number":354,"state":"open","locked":false,"title":"Performance improvement for BasicResultNameSQLSyntaxProvider","user":{"login":"mosche","id":1401430,"avatar_url":"https://avatars.githubusercontent.com/u/1401430?v=3","gravatar_id":"","url":"https://api.github.com/users/mosche","html_url":"https://github.com/mosche","followers_url":"https://api.github.com/users/mosche/followers","following_url":"https://api.github.com/users/mosche/following{/other_user}","gists_url":"https://api.github.com/users/mosche/gists{/gist_id}","starred_url":"https://api.github.com/users/mosche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosche/subscriptions","organizations_url":"https://api.github.com/users/mosche/orgs","repos_url":"https://api.github.com/users/mosche/repos","events_url":"https://api.github.com/users/mosche/events{/privacy}","received_events_url":"https://api.github.com/users/mosche/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nwe've just evaluated scalikejdbc as replacement for slick. However, whenever dealing with large result sets we run into serious performance issues. I've added a simple test case as part of the merge request to demonstrate the case.\r\n\r\nEventually we managed to track down the issue in the BasicResultNameSQLSyntaxProvider whenever dynamic fields are converted to column aliases. We'd like to suggest to store these aliases once they are created. \r\n\r\nPotentially it even makes sense to push this fix down into the concrete implementation of def field(name: String) \r\n\r\nThanks so much for the great work! \r\nBest,\r\nMoritz\r\n","created_at":"2015-01-30T11:30:33Z","updated_at":"2015-01-30T11:30:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e16ac18c600f51bb6b36f538f7c9bca8a141f332","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/pulls/354/commits","review_comments_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/pulls/354/comments","review_comment_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/issues/354/comments","statuses_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/statuses/4b69bf16871744abded1fffa2b9b155ea678052f","head":{"label":"mosche:performanceImprovement-resultNameSyntax","ref":"performanceImprovement-resultNameSyntax","sha":"4b69bf16871744abded1fffa2b9b155ea678052f","user":{"login":"mosche","id":1401430,"avatar_url":"https://avatars.githubusercontent.com/u/1401430?v=3","gravatar_id":"","url":"https://api.github.com/users/mosche","html_url":"https://github.com/mosche","followers_url":"https://api.github.com/users/mosche/followers","following_url":"https://api.github.com/users/mosche/following{/other_user}","gists_url":"https://api.github.com/users/mosche/gists{/gist_id}","starred_url":"https://api.github.com/users/mosche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosche/subscriptions","organizations_url":"https://api.github.com/users/mosche/orgs","repos_url":"https://api.github.com/users/mosche/repos","events_url":"https://api.github.com/users/mosche/events{/privacy}","received_events_url":"https://api.github.com/users/mosche/received_events","type":"User","site_admin":false},"repo":{"id":29980175,"name":"scalikejdbc","full_name":"mosche/scalikejdbc","owner":{"login":"mosche","id":1401430,"avatar_url":"https://avatars.githubusercontent.com/u/1401430?v=3","gravatar_id":"","url":"https://api.github.com/users/mosche","html_url":"https://github.com/mosche","followers_url":"https://api.github.com/users/mosche/followers","following_url":"https://api.github.com/users/mosche/following{/other_user}","gists_url":"https://api.github.com/users/mosche/gists{/gist_id}","starred_url":"https://api.github.com/users/mosche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosche/subscriptions","organizations_url":"https://api.github.com/users/mosche/orgs","repos_url":"https://api.github.com/users/mosche/repos","events_url":"https://api.github.com/users/mosche/events{/privacy}","received_events_url":"https://api.github.com/users/mosche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mosche/scalikejdbc","description":"A tidy SQL-based DB access library for Scala developers. This library naturally wraps JDBC APIs and provides you easy-to-use APIs.","fork":true,"url":"https://api.github.com/repos/mosche/scalikejdbc","forks_url":"https://api.github.com/repos/mosche/scalikejdbc/forks","keys_url":"https://api.github.com/repos/mosche/scalikejdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mosche/scalikejdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mosche/scalikejdbc/teams","hooks_url":"https://api.github.com/repos/mosche/scalikejdbc/hooks","issue_events_url":"https://api.github.com/repos/mosche/scalikejdbc/issues/events{/number}","events_url":"https://api.github.com/repos/mosche/scalikejdbc/events","assignees_url":"https://api.github.com/repos/mosche/scalikejdbc/assignees{/user}","branches_url":"https://api.github.com/repos/mosche/scalikejdbc/branches{/branch}","tags_url":"https://api.github.com/repos/mosche/scalikejdbc/tags","blobs_url":"https://api.github.com/repos/mosche/scalikejdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mosche/scalikejdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mosche/scalikejdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mosche/scalikejdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mosche/scalikejdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/mosche/scalikejdbc/languages","stargazers_url":"https://api.github.com/repos/mosche/scalikejdbc/stargazers","contributors_url":"https://api.github.com/repos/mosche/scalikejdbc/contributors","subscribers_url":"https://api.github.com/repos/mosche/scalikejdbc/subscribers","subscription_url":"https://api.github.com/repos/mosche/scalikejdbc/subscription","commits_url":"https://api.github.com/repos/mosche/scalikejdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mosche/scalikejdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mosche/scalikejdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mosche/scalikejdbc/issues/comments/{number}","contents_url":"https://api.github.com/repos/mosche/scalikejdbc/contents/{+path}","compare_url":"https://api.github.com/repos/mosche/scalikejdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mosche/scalikejdbc/merges","archive_url":"https://api.github.com/repos/mosche/scalikejdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mosche/scalikejdbc/downloads","issues_url":"https://api.github.com/repos/mosche/scalikejdbc/issues{/number}","pulls_url":"https://api.github.com/repos/mosche/scalikejdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/mosche/scalikejdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/mosche/scalikejdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mosche/scalikejdbc/labels{/name}","releases_url":"https://api.github.com/repos/mosche/scalikejdbc/releases{/id}","created_at":"2015-01-28T17:50:56Z","updated_at":"2015-01-30T11:17:24Z","pushed_at":"2015-01-30T11:17:24Z","git_url":"git://github.com/mosche/scalikejdbc.git","ssh_url":"git@github.com:mosche/scalikejdbc.git","clone_url":"https://github.com/mosche/scalikejdbc.git","svn_url":"https://github.com/mosche/scalikejdbc","homepage":"http://scalikejdbc.org/","size":4231,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"performanceImprovement-resultNameSyntax"}},"base":{"label":"scalikejdbc:develop","ref":"develop","sha":"c4bdb694ca9cd08b9d5fd2091023893ed94df731","user":{"login":"scalikejdbc","id":5978675,"avatar_url":"https://avatars.githubusercontent.com/u/5978675?v=3","gravatar_id":"","url":"https://api.github.com/users/scalikejdbc","html_url":"https://github.com/scalikejdbc","followers_url":"https://api.github.com/users/scalikejdbc/followers","following_url":"https://api.github.com/users/scalikejdbc/following{/other_user}","gists_url":"https://api.github.com/users/scalikejdbc/gists{/gist_id}","starred_url":"https://api.github.com/users/scalikejdbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalikejdbc/subscriptions","organizations_url":"https://api.github.com/users/scalikejdbc/orgs","repos_url":"https://api.github.com/users/scalikejdbc/repos","events_url":"https://api.github.com/users/scalikejdbc/events{/privacy}","received_events_url":"https://api.github.com/users/scalikejdbc/received_events","type":"Organization","site_admin":false},"repo":{"id":2801094,"name":"scalikejdbc","full_name":"scalikejdbc/scalikejdbc","owner":{"login":"scalikejdbc","id":5978675,"avatar_url":"https://avatars.githubusercontent.com/u/5978675?v=3","gravatar_id":"","url":"https://api.github.com/users/scalikejdbc","html_url":"https://github.com/scalikejdbc","followers_url":"https://api.github.com/users/scalikejdbc/followers","following_url":"https://api.github.com/users/scalikejdbc/following{/other_user}","gists_url":"https://api.github.com/users/scalikejdbc/gists{/gist_id}","starred_url":"https://api.github.com/users/scalikejdbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalikejdbc/subscriptions","organizations_url":"https://api.github.com/users/scalikejdbc/orgs","repos_url":"https://api.github.com/users/scalikejdbc/repos","events_url":"https://api.github.com/users/scalikejdbc/events{/privacy}","received_events_url":"https://api.github.com/users/scalikejdbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalikejdbc/scalikejdbc","description":"A tidy SQL-based DB access library for Scala developers. This library naturally wraps JDBC APIs and provides you easy-to-use APIs.","fork":false,"url":"https://api.github.com/repos/scalikejdbc/scalikejdbc","forks_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/forks","keys_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/teams","hooks_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/hooks","issue_events_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/issues/events{/number}","events_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/events","assignees_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/assignees{/user}","branches_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/branches{/branch}","tags_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/tags","blobs_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/languages","stargazers_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/stargazers","contributors_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/contributors","subscribers_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/subscribers","subscription_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/subscription","commits_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/issues/comments/{number}","contents_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/contents/{+path}","compare_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/merges","archive_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/downloads","issues_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/issues{/number}","pulls_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/labels{/name}","releases_url":"https://api.github.com/repos/scalikejdbc/scalikejdbc/releases{/id}","created_at":"2011-11-18T06:56:36Z","updated_at":"2015-01-29T16:28:02Z","pushed_at":"2015-01-29T01:40:30Z","git_url":"git://github.com/scalikejdbc/scalikejdbc.git","ssh_url":"git@github.com:scalikejdbc/scalikejdbc.git","clone_url":"https://github.com/scalikejdbc/scalikejdbc.git","svn_url":"https://github.com/scalikejdbc/scalikejdbc","homepage":"http://scalikejdbc.org/","size":7481,"stargazers_count":367,"watchers_count":367,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":5,"forks":56,"open_issues":5,"watchers":367,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/scalikejdbc/scalikejdbc/pulls/354"},"html":{"href":"https://github.com/scalikejdbc/scalikejdbc/pull/354"},"issue":{"href":"https://api.github.com/repos/scalikejdbc/scalikejdbc/issues/354"},"comments":{"href":"https://api.github.com/repos/scalikejdbc/scalikejdbc/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/scalikejdbc/scalikejdbc/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/scalikejdbc/scalikejdbc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/scalikejdbc/scalikejdbc/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/scalikejdbc/scalikejdbc/statuses/4b69bf16871744abded1fffa2b9b155ea678052f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":21,"deletions":0,"changed_files":2}}