{"action":"created","issue":{"url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7875","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7875/labels{/name}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7875/comments","events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7875/events","html_url":"https://github.com/OpenRA/OpenRA/pull/7875","id":66525432,"number":7875,"title":"Add upgrade rules support for map PlayerReferences","user":{"login":"penev92","id":7137365,"avatar_url":"https://avatars.githubusercontent.com/u/7137365?v=3","gravatar_id":"","url":"https://api.github.com/users/penev92","html_url":"https://github.com/penev92","followers_url":"https://api.github.com/users/penev92/followers","following_url":"https://api.github.com/users/penev92/following{/other_user}","gists_url":"https://api.github.com/users/penev92/gists{/gist_id}","starred_url":"https://api.github.com/users/penev92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penev92/subscriptions","organizations_url":"https://api.github.com/users/penev92/orgs","repos_url":"https://api.github.com/users/penev92/repos","events_url":"https://api.github.com/users/penev92/events{/privacy}","received_events_url":"https://api.github.com/users/penev92/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-06T04:49:58Z","updated_at":"2015-04-06T19:41:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/7875","html_url":"https://github.com/OpenRA/OpenRA/pull/7875","diff_url":"https://github.com/OpenRA/OpenRA/pull/7875.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/7875.patch"},"body":"Split off from #7873, because that needs to be able to upgrade the PlayerReferences in maps.\r\nThis just adds support for that. The other PR will add the first use-case.\r\n\r\nI used [this commit](https://github.com/pchote/OpenRA/commit/cb32f8aa80542c7f059bc62df6f4bdc043260eaf) as example and now the PlayerReferences are loaded as MiniYAML by the map and kept that way.\r\n\r\nReviews should start with `Map.cs`, because that is where all the action is happening. Most of the rest is noise."},"comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments/90212610","html_url":"https://github.com/OpenRA/OpenRA/pull/7875#issuecomment-90212610","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7875","id":90212610,"user":{"login":"pchote","id":167819,"avatar_url":"https://avatars.githubusercontent.com/u/167819?v=3","gravatar_id":"","url":"https://api.github.com/users/pchote","html_url":"https://github.com/pchote","followers_url":"https://api.github.com/users/pchote/followers","following_url":"https://api.github.com/users/pchote/following{/other_user}","gists_url":"https://api.github.com/users/pchote/gists{/gist_id}","starred_url":"https://api.github.com/users/pchote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchote/subscriptions","organizations_url":"https://api.github.com/users/pchote/orgs","repos_url":"https://api.github.com/users/pchote/repos","events_url":"https://api.github.com/users/pchote/events{/privacy}","received_events_url":"https://api.github.com/users/pchote/received_events","type":"User","site_admin":false},"created_at":"2015-04-06T19:41:12Z","updated_at":"2015-04-06T19:41:12Z","body":"This is a good start.  I have left a few more suggestions to improve it a bit more.\r\n\r\nI will adapt my future pr that does similar changes for actors and smudges to follow the conventions we're setting up here."}}