{"action":"created","comment":{"url":"https://api.github.com/repos/kaaproject/kaa/pulls/comments/23901880","id":23901880,"diff_hunk":"@@ -36,40 +40,58 @@\n public class DefaultLogCollector implements LogCollector, LogProcessor {\n     private static final Logger LOG = LoggerFactory.getLogger(DefaultLogCollector.class);\n \n-    private LogUploadConfiguration configuration;\n-    private LogStorage             storage;\n-    private LogStorageStatus       storageStatus;\n-    private LogUploadStrategy      uploadStrategy;\n-    private final LogTransport    transport;\n+    private LogUploadConfiguration    configuration;\n+    private LogStorage                storage;\n+    private LogStorageStatus          storageStatus;\n+    private LogUploadStrategy         uploadStrategy;\n+    private LogUploadFailoverStrategy failoverStrategy;\n+    private final LogTransport        transport;\n \n-    boolean isUploading;\n+    private final Map<Integer, Long> timeoutMap = new LinkedHashMap<>();\n \n-    public DefaultLogCollector(LogTransport transport) {\n-        configuration = new DefaultLogUploadConfiguration(8 * 1024, 4 * 8 * 1024, 1024 * 1024);\n+    private boolean isUploading = false;\n+\n+    public DefaultLogCollector(LogTransport transport, KaaChannelManager manager) {\n+        configuration = new DefaultLogUploadConfiguration.Builder()\n+                                .setBatchVolume(8 * 1024)","path":"client/client-multi/client-java-core/src/main/java/org/kaaproject/kaa/client/logging/DefaultLogCollector.java","position":41,"original_position":41,"commit_id":"43c7e2bd2b94b2f41311b59416a371df7223d5b7","original_commit_id":"43c7e2bd2b94b2f41311b59416a371df7223d5b7","user":{"login":"Shpigor","id":1051854,"avatar_url":"https://avatars.githubusercontent.com/u/1051854?v=3","gravatar_id":"","url":"https://api.github.com/users/Shpigor","html_url":"https://github.com/Shpigor","followers_url":"https://api.github.com/users/Shpigor/followers","following_url":"https://api.github.com/users/Shpigor/following{/other_user}","gists_url":"https://api.github.com/users/Shpigor/gists{/gist_id}","starred_url":"https://api.github.com/users/Shpigor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shpigor/subscriptions","organizations_url":"https://api.github.com/users/Shpigor/orgs","repos_url":"https://api.github.com/users/Shpigor/repos","events_url":"https://api.github.com/users/Shpigor/events{/privacy}","received_events_url":"https://api.github.com/users/Shpigor/received_events","type":"User","site_admin":false},"body":"Please, move these numbers to constants with clear names","created_at":"2015-02-01T22:13:13Z","updated_at":"2015-02-01T22:13:13Z","html_url":"https://github.com/kaaproject/kaa/pull/80#discussion_r23901880","pull_request_url":"https://api.github.com/repos/kaaproject/kaa/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/comments/23901880"},"html":{"href":"https://github.com/kaaproject/kaa/pull/80#discussion_r23901880"},"pull_request":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/kaaproject/kaa/pulls/80","id":28372740,"html_url":"https://github.com/kaaproject/kaa/pull/80","diff_url":"https://github.com/kaaproject/kaa/pull/80.diff","patch_url":"https://github.com/kaaproject/kaa/pull/80.patch","issue_url":"https://api.github.com/repos/kaaproject/kaa/issues/80","number":80,"state":"open","locked":false,"title":"Kaa-96: Logs delivery confirmation","user":{"login":"ashvayka","id":5016373,"avatar_url":"https://avatars.githubusercontent.com/u/5016373?v=3","gravatar_id":"","url":"https://api.github.com/users/ashvayka","html_url":"https://github.com/ashvayka","followers_url":"https://api.github.com/users/ashvayka/followers","following_url":"https://api.github.com/users/ashvayka/following{/other_user}","gists_url":"https://api.github.com/users/ashvayka/gists{/gist_id}","starred_url":"https://api.github.com/users/ashvayka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashvayka/subscriptions","organizations_url":"https://api.github.com/users/ashvayka/orgs","repos_url":"https://api.github.com/users/ashvayka/repos","events_url":"https://api.github.com/users/ashvayka/events{/privacy}","received_events_url":"https://api.github.com/users/ashvayka/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-30T16:17:52Z","updated_at":"2015-02-01T22:13:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c44dde08848002363c55d27048428e22836f4dce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kaaproject/kaa/pulls/80/commits","review_comments_url":"https://api.github.com/repos/kaaproject/kaa/pulls/80/comments","review_comment_url":"https://api.github.com/repos/kaaproject/kaa/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kaaproject/kaa/issues/80/comments","statuses_url":"https://api.github.com/repos/kaaproject/kaa/statuses/43c7e2bd2b94b2f41311b59416a371df7223d5b7","head":{"label":"kaaproject:feature/KAA-96","ref":"feature/KAA-96","sha":"43c7e2bd2b94b2f41311b59416a371df7223d5b7","user":{"login":"kaaproject","id":6984613,"avatar_url":"https://avatars.githubusercontent.com/u/6984613?v=3","gravatar_id":"","url":"https://api.github.com/users/kaaproject","html_url":"https://github.com/kaaproject","followers_url":"https://api.github.com/users/kaaproject/followers","following_url":"https://api.github.com/users/kaaproject/following{/other_user}","gists_url":"https://api.github.com/users/kaaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/kaaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaaproject/subscriptions","organizations_url":"https://api.github.com/users/kaaproject/orgs","repos_url":"https://api.github.com/users/kaaproject/repos","events_url":"https://api.github.com/users/kaaproject/events{/privacy}","received_events_url":"https://api.github.com/users/kaaproject/received_events","type":"Organization","site_admin":false},"repo":{"id":17839346,"name":"kaa","full_name":"kaaproject/kaa","owner":{"login":"kaaproject","id":6984613,"avatar_url":"https://avatars.githubusercontent.com/u/6984613?v=3","gravatar_id":"","url":"https://api.github.com/users/kaaproject","html_url":"https://github.com/kaaproject","followers_url":"https://api.github.com/users/kaaproject/followers","following_url":"https://api.github.com/users/kaaproject/following{/other_user}","gists_url":"https://api.github.com/users/kaaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/kaaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaaproject/subscriptions","organizations_url":"https://api.github.com/users/kaaproject/orgs","repos_url":"https://api.github.com/users/kaaproject/repos","events_url":"https://api.github.com/users/kaaproject/events{/privacy}","received_events_url":"https://api.github.com/users/kaaproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaaproject/kaa","description":"Kaa open-source middleware platform for building, managing, and integrating connected products with the Internet of Everything.","fork":false,"url":"https://api.github.com/repos/kaaproject/kaa","forks_url":"https://api.github.com/repos/kaaproject/kaa/forks","keys_url":"https://api.github.com/repos/kaaproject/kaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaaproject/kaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaaproject/kaa/teams","hooks_url":"https://api.github.com/repos/kaaproject/kaa/hooks","issue_events_url":"https://api.github.com/repos/kaaproject/kaa/issues/events{/number}","events_url":"https://api.github.com/repos/kaaproject/kaa/events","assignees_url":"https://api.github.com/repos/kaaproject/kaa/assignees{/user}","branches_url":"https://api.github.com/repos/kaaproject/kaa/branches{/branch}","tags_url":"https://api.github.com/repos/kaaproject/kaa/tags","blobs_url":"https://api.github.com/repos/kaaproject/kaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaaproject/kaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaaproject/kaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaaproject/kaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaaproject/kaa/statuses/{sha}","languages_url":"https://api.github.com/repos/kaaproject/kaa/languages","stargazers_url":"https://api.github.com/repos/kaaproject/kaa/stargazers","contributors_url":"https://api.github.com/repos/kaaproject/kaa/contributors","subscribers_url":"https://api.github.com/repos/kaaproject/kaa/subscribers","subscription_url":"https://api.github.com/repos/kaaproject/kaa/subscription","commits_url":"https://api.github.com/repos/kaaproject/kaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaaproject/kaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaaproject/kaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaaproject/kaa/issues/comments/{number}","contents_url":"https://api.github.com/repos/kaaproject/kaa/contents/{+path}","compare_url":"https://api.github.com/repos/kaaproject/kaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaaproject/kaa/merges","archive_url":"https://api.github.com/repos/kaaproject/kaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaaproject/kaa/downloads","issues_url":"https://api.github.com/repos/kaaproject/kaa/issues{/number}","pulls_url":"https://api.github.com/repos/kaaproject/kaa/pulls{/number}","milestones_url":"https://api.github.com/repos/kaaproject/kaa/milestones{/number}","notifications_url":"https://api.github.com/repos/kaaproject/kaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaaproject/kaa/labels{/name}","releases_url":"https://api.github.com/repos/kaaproject/kaa/releases{/id}","created_at":"2014-03-17T18:48:31Z","updated_at":"2015-01-31T14:51:49Z","pushed_at":"2015-02-01T14:48:44Z","git_url":"git://github.com/kaaproject/kaa.git","ssh_url":"git@github.com:kaaproject/kaa.git","clone_url":"https://github.com/kaaproject/kaa.git","svn_url":"https://github.com/kaaproject/kaa","homepage":"http://www.kaaproject.org","size":57532,"stargazers_count":72,"watchers_count":72,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":72,"default_branch":"master"}},"base":{"label":"kaaproject:master","ref":"master","sha":"dcba49383b987f07d698349661a781cddd6d40ea","user":{"login":"kaaproject","id":6984613,"avatar_url":"https://avatars.githubusercontent.com/u/6984613?v=3","gravatar_id":"","url":"https://api.github.com/users/kaaproject","html_url":"https://github.com/kaaproject","followers_url":"https://api.github.com/users/kaaproject/followers","following_url":"https://api.github.com/users/kaaproject/following{/other_user}","gists_url":"https://api.github.com/users/kaaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/kaaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaaproject/subscriptions","organizations_url":"https://api.github.com/users/kaaproject/orgs","repos_url":"https://api.github.com/users/kaaproject/repos","events_url":"https://api.github.com/users/kaaproject/events{/privacy}","received_events_url":"https://api.github.com/users/kaaproject/received_events","type":"Organization","site_admin":false},"repo":{"id":17839346,"name":"kaa","full_name":"kaaproject/kaa","owner":{"login":"kaaproject","id":6984613,"avatar_url":"https://avatars.githubusercontent.com/u/6984613?v=3","gravatar_id":"","url":"https://api.github.com/users/kaaproject","html_url":"https://github.com/kaaproject","followers_url":"https://api.github.com/users/kaaproject/followers","following_url":"https://api.github.com/users/kaaproject/following{/other_user}","gists_url":"https://api.github.com/users/kaaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/kaaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaaproject/subscriptions","organizations_url":"https://api.github.com/users/kaaproject/orgs","repos_url":"https://api.github.com/users/kaaproject/repos","events_url":"https://api.github.com/users/kaaproject/events{/privacy}","received_events_url":"https://api.github.com/users/kaaproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaaproject/kaa","description":"Kaa open-source middleware platform for building, managing, and integrating connected products with the Internet of Everything.","fork":false,"url":"https://api.github.com/repos/kaaproject/kaa","forks_url":"https://api.github.com/repos/kaaproject/kaa/forks","keys_url":"https://api.github.com/repos/kaaproject/kaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaaproject/kaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaaproject/kaa/teams","hooks_url":"https://api.github.com/repos/kaaproject/kaa/hooks","issue_events_url":"https://api.github.com/repos/kaaproject/kaa/issues/events{/number}","events_url":"https://api.github.com/repos/kaaproject/kaa/events","assignees_url":"https://api.github.com/repos/kaaproject/kaa/assignees{/user}","branches_url":"https://api.github.com/repos/kaaproject/kaa/branches{/branch}","tags_url":"https://api.github.com/repos/kaaproject/kaa/tags","blobs_url":"https://api.github.com/repos/kaaproject/kaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaaproject/kaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaaproject/kaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaaproject/kaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaaproject/kaa/statuses/{sha}","languages_url":"https://api.github.com/repos/kaaproject/kaa/languages","stargazers_url":"https://api.github.com/repos/kaaproject/kaa/stargazers","contributors_url":"https://api.github.com/repos/kaaproject/kaa/contributors","subscribers_url":"https://api.github.com/repos/kaaproject/kaa/subscribers","subscription_url":"https://api.github.com/repos/kaaproject/kaa/subscription","commits_url":"https://api.github.com/repos/kaaproject/kaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaaproject/kaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaaproject/kaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaaproject/kaa/issues/comments/{number}","contents_url":"https://api.github.com/repos/kaaproject/kaa/contents/{+path}","compare_url":"https://api.github.com/repos/kaaproject/kaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaaproject/kaa/merges","archive_url":"https://api.github.com/repos/kaaproject/kaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaaproject/kaa/downloads","issues_url":"https://api.github.com/repos/kaaproject/kaa/issues{/number}","pulls_url":"https://api.github.com/repos/kaaproject/kaa/pulls{/number}","milestones_url":"https://api.github.com/repos/kaaproject/kaa/milestones{/number}","notifications_url":"https://api.github.com/repos/kaaproject/kaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaaproject/kaa/labels{/name}","releases_url":"https://api.github.com/repos/kaaproject/kaa/releases{/id}","created_at":"2014-03-17T18:48:31Z","updated_at":"2015-01-31T14:51:49Z","pushed_at":"2015-02-01T14:48:44Z","git_url":"git://github.com/kaaproject/kaa.git","ssh_url":"git@github.com:kaaproject/kaa.git","clone_url":"https://github.com/kaaproject/kaa.git","svn_url":"https://github.com/kaaproject/kaa","homepage":"http://www.kaaproject.org","size":57532,"stargazers_count":72,"watchers_count":72,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/80"},"html":{"href":"https://github.com/kaaproject/kaa/pull/80"},"issue":{"href":"https://api.github.com/repos/kaaproject/kaa/issues/80"},"comments":{"href":"https://api.github.com/repos/kaaproject/kaa/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kaaproject/kaa/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/kaaproject/kaa/statuses/43c7e2bd2b94b2f41311b59416a371df7223d5b7"}}}}