{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/38762487","id":38762487,"diff_hunk":"@@ -1164,7 +1168,7 @@ func (container *Container) isDestinationMounted(destination string) bool {\n func (container *Container) prepareMountPoints() error {\n \tfor _, config := range container.MountPoints {\n \t\tif len(config.Driver) > 0 {\n-\t\t\tv, err := createVolume(config.Name, config.Driver)\n+\t\t\tv, err := createVolume(config.Name, config.ID, config.Driver)","path":"daemon/container.go","position":37,"original_position":37,"commit_id":"3fed281bbc310044c7024b50b005615672effa39","original_commit_id":"3fed281bbc310044c7024b50b005615672effa39","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"Does it need an ID here? Or can docker send the mount ID on mount/unmount only?","created_at":"2015-09-04T15:23:12Z","updated_at":"2015-09-04T15:23:12Z","html_url":"https://github.com/docker/docker/pull/14737#discussion_r38762487","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/14737","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/38762487"},"html":{"href":"https://github.com/docker/docker/pull/14737#discussion_r38762487"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/14737"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/14737","id":40306408,"html_url":"https://github.com/docker/docker/pull/14737","diff_url":"https://github.com/docker/docker/pull/14737.diff","patch_url":"https://github.com/docker/docker/pull/14737.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/14737","number":14737,"state":"open","locked":false,"title":"Proposal: add mountPoint.Id to Volumes API","user":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=3","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>\r\n\r\n@calavera :)\r\n\r\nthis allows the volume plugin to deal with\r\n\r\n`docker run --rm -it --volume-driver nfs -v 10.10.10.20/data:/data alpine ls -la /data`\r\n\r\nwithout needing to reference count, by mounting the remote fs at `/var/lib/docker/volumes/_nfs/d5bc87dace8baa990f0b3debe6d874dc446b033f678cf67f660209741b185fb0/10.10.10.20/data`","created_at":"2015-07-19T10:43:12Z","updated_at":"2015-09-04T15:23:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14e0181be2893ac688a33c5ad21ce9ece5aaaa07","assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/41","html_url":"https://github.com/docker/docker/milestones/1.9.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/41/labels","id":1211905,"number":41,"title":"1.9.0","description":"","creator":{"login":"dmp42","id":332946,"avatar_url":"https://avatars.githubusercontent.com/u/332946?v=3","gravatar_id":"","url":"https://api.github.com/users/dmp42","html_url":"https://github.com/dmp42","followers_url":"https://api.github.com/users/dmp42/followers","following_url":"https://api.github.com/users/dmp42/following{/other_user}","gists_url":"https://api.github.com/users/dmp42/gists{/gist_id}","starred_url":"https://api.github.com/users/dmp42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmp42/subscriptions","organizations_url":"https://api.github.com/users/dmp42/orgs","repos_url":"https://api.github.com/users/dmp42/repos","events_url":"https://api.github.com/users/dmp42/events{/privacy}","received_events_url":"https://api.github.com/users/dmp42/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":12,"state":"open","created_at":"2015-07-16T20:50:09Z","updated_at":"2015-09-03T23:12:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/14737/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/14737/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/14737/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/3fed281bbc310044c7024b50b005615672effa39","head":{"label":"SvenDowideit:add-vuid-to-docker-volumes","ref":"add-vuid-to-docker-volumes","sha":"3fed281bbc310044c7024b50b005615672effa39","user":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=3","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"repo":{"id":13399967,"name":"docker","full_name":"SvenDowideit/docker","owner":{"login":"SvenDowideit","id":28492,"avatar_url":"https://avatars.githubusercontent.com/u/28492?v=3","gravatar_id":"","url":"https://api.github.com/users/SvenDowideit","html_url":"https://github.com/SvenDowideit","followers_url":"https://api.github.com/users/SvenDowideit/followers","following_url":"https://api.github.com/users/SvenDowideit/following{/other_user}","gists_url":"https://api.github.com/users/SvenDowideit/gists{/gist_id}","starred_url":"https://api.github.com/users/SvenDowideit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvenDowideit/subscriptions","organizations_url":"https://api.github.com/users/SvenDowideit/orgs","repos_url":"https://api.github.com/users/SvenDowideit/repos","events_url":"https://api.github.com/users/SvenDowideit/events{/privacy}","received_events_url":"https://api.github.com/users/SvenDowideit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SvenDowideit/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/SvenDowideit/docker","forks_url":"https://api.github.com/repos/SvenDowideit/docker/forks","keys_url":"https://api.github.com/repos/SvenDowideit/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SvenDowideit/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SvenDowideit/docker/teams","hooks_url":"https://api.github.com/repos/SvenDowideit/docker/hooks","issue_events_url":"https://api.github.com/repos/SvenDowideit/docker/issues/events{/number}","events_url":"https://api.github.com/repos/SvenDowideit/docker/events","assignees_url":"https://api.github.com/repos/SvenDowideit/docker/assignees{/user}","branches_url":"https://api.github.com/repos/SvenDowideit/docker/branches{/branch}","tags_url":"https://api.github.com/repos/SvenDowideit/docker/tags","blobs_url":"https://api.github.com/repos/SvenDowideit/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SvenDowideit/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SvenDowideit/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/SvenDowideit/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SvenDowideit/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/SvenDowideit/docker/languages","stargazers_url":"https://api.github.com/repos/SvenDowideit/docker/stargazers","contributors_url":"https://api.github.com/repos/SvenDowideit/docker/contributors","subscribers_url":"https://api.github.com/repos/SvenDowideit/docker/subscribers","subscription_url":"https://api.github.com/repos/SvenDowideit/docker/subscription","commits_url":"https://api.github.com/repos/SvenDowideit/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/SvenDowideit/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/SvenDowideit/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/SvenDowideit/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/SvenDowideit/docker/contents/{+path}","compare_url":"https://api.github.com/repos/SvenDowideit/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SvenDowideit/docker/merges","archive_url":"https://api.github.com/repos/SvenDowideit/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SvenDowideit/docker/downloads","issues_url":"https://api.github.com/repos/SvenDowideit/docker/issues{/number}","pulls_url":"https://api.github.com/repos/SvenDowideit/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/SvenDowideit/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/SvenDowideit/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SvenDowideit/docker/labels{/name}","releases_url":"https://api.github.com/repos/SvenDowideit/docker/releases{/id}","created_at":"2013-10-08T00:56:36Z","updated_at":"2015-05-08T01:30:38Z","pushed_at":"2015-09-02T00:46:06Z","git_url":"git://github.com/SvenDowideit/docker.git","ssh_url":"git@github.com:SvenDowideit/docker.git","clone_url":"https://github.com/SvenDowideit/docker.git","svn_url":"https://github.com/SvenDowideit/docker","homepage":"http://www.docker.io","size":69362,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"a89370039a65f235d3dde5d36f20d0f463c615e9","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-09-04T13:27:52Z","pushed_at":"2015-09-04T14:51:53Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":250372,"stargazers_count":24509,"watchers_count":24509,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6300,"mirror_url":null,"open_issues_count":1074,"forks":6300,"open_issues":1074,"watchers":24509,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/14737"},"html":{"href":"https://github.com/docker/docker/pull/14737"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/14737"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/14737/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/14737/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/14737/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/3fed281bbc310044c7024b50b005615672effa39"}}}}