{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/25911646","id":25911646,"diff_hunk":"@@ -23,6 +24,17 @@ func CanonicalTarNameForPath(p string) (string, error) {\n \treturn strings.Replace(p, \"\\\\\", \"/\", -1), nil","path":"pkg/archive/archive_windows.go","position":9,"original_position":9,"commit_id":"1a22418f9f1573ca8521831d52c8e0562cb3ef8f","original_commit_id":"1a22418f9f1573ca8521831d52c8e0562cb3ef8f","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"body":"that's probably out of scope of this PR. but you're right. I'll submit a PR separately.","created_at":"2015-03-05T23:13:05Z","updated_at":"2015-03-05T23:13:05Z","html_url":"https://github.com/docker/docker/pull/11148#discussion_r25911646","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/11148","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/25911646"},"html":{"href":"https://github.com/docker/docker/pull/11148#discussion_r25911646"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/11148"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/11148","id":30434076,"html_url":"https://github.com/docker/docker/pull/11148","diff_url":"https://github.com/docker/docker/pull/11148.diff","patch_url":"https://github.com/docker/docker/pull/11148.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/11148","number":11148,"state":"open","locked":false,"title":"pkg/archive: adjust chmod bits on windows","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"body":"* Followup to proposal at #11047\r\n\r\nThis change modifies the chmod bits of build context archives built on\r\nwindows to preserve the execute bit and remove the r/w bits from\r\ngrp/others.\r\n\r\nI just created a post-processing step to modify tar headers retrieved from\r\ntar.FileInfoHeader() method. This fixes tests:\r\n\r\n* TestBuildAddSingleFileToRoot\r\n* TestBuildAddWholeDirToRoot\r\n* TestBuildCopySingleFileToRoot\r\n* TestBuildCopyWholeDirToRoot\r\n\r\nAlso adjusted integration-cli tests to verify permissions based on the platform\r\nthe tests are running. Fixes #11047.\r\n\r\nSigned-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>\r\ncc: @duglin @tiborvass @icecrime @jfrazelle @tianon ","created_at":"2015-03-04T02:46:02Z","updated_at":"2015-03-05T23:13:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f07149f64a6a88aeb6a91320bcb2e07b8768b4c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/11148/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/11148/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/11148/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/1a22418f9f1573ca8521831d52c8e0562cb3ef8f","head":{"label":"ahmetalpbalkan:win-cli/chmod-x-fix","ref":"win-cli/chmod-x-fix","sha":"1a22418f9f1573ca8521831d52c8e0562cb3ef8f","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"repo":{"id":30384043,"name":"docker","full_name":"ahmetalpbalkan/docker","owner":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmetalpbalkan/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/ahmetalpbalkan/docker","forks_url":"https://api.github.com/repos/ahmetalpbalkan/docker/forks","keys_url":"https://api.github.com/repos/ahmetalpbalkan/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmetalpbalkan/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmetalpbalkan/docker/teams","hooks_url":"https://api.github.com/repos/ahmetalpbalkan/docker/hooks","issue_events_url":"https://api.github.com/repos/ahmetalpbalkan/docker/issues/events{/number}","events_url":"https://api.github.com/repos/ahmetalpbalkan/docker/events","assignees_url":"https://api.github.com/repos/ahmetalpbalkan/docker/assignees{/user}","branches_url":"https://api.github.com/repos/ahmetalpbalkan/docker/branches{/branch}","tags_url":"https://api.github.com/repos/ahmetalpbalkan/docker/tags","blobs_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmetalpbalkan/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmetalpbalkan/docker/languages","stargazers_url":"https://api.github.com/repos/ahmetalpbalkan/docker/stargazers","contributors_url":"https://api.github.com/repos/ahmetalpbalkan/docker/contributors","subscribers_url":"https://api.github.com/repos/ahmetalpbalkan/docker/subscribers","subscription_url":"https://api.github.com/repos/ahmetalpbalkan/docker/subscription","commits_url":"https://api.github.com/repos/ahmetalpbalkan/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmetalpbalkan/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmetalpbalkan/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahmetalpbalkan/docker/contents/{+path}","compare_url":"https://api.github.com/repos/ahmetalpbalkan/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmetalpbalkan/docker/merges","archive_url":"https://api.github.com/repos/ahmetalpbalkan/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmetalpbalkan/docker/downloads","issues_url":"https://api.github.com/repos/ahmetalpbalkan/docker/issues{/number}","pulls_url":"https://api.github.com/repos/ahmetalpbalkan/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmetalpbalkan/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmetalpbalkan/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmetalpbalkan/docker/labels{/name}","releases_url":"https://api.github.com/repos/ahmetalpbalkan/docker/releases{/id}","created_at":"2015-02-05T23:23:10Z","updated_at":"2015-03-05T21:20:41Z","pushed_at":"2015-03-05T21:20:41Z","git_url":"git://github.com/ahmetalpbalkan/docker.git","ssh_url":"git@github.com:ahmetalpbalkan/docker.git","clone_url":"https://github.com/ahmetalpbalkan/docker.git","svn_url":"https://github.com/ahmetalpbalkan/docker","homepage":"http://www.docker.com","size":42605,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"5035fa1e21947bfd229639c5c83c89d6bda0a1a9","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-03-05T22:58:15Z","pushed_at":"2015-03-05T21:06:03Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":145205,"stargazers_count":19589,"watchers_count":19589,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4062,"mirror_url":null,"open_issues_count":801,"forks":4062,"open_issues":801,"watchers":19589,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/11148"},"html":{"href":"https://github.com/docker/docker/pull/11148"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/11148"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/11148/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/11148/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/11148/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/1a22418f9f1573ca8521831d52c8e0562cb3ef8f"}}}}