{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/6582","labels_url":"https://api.github.com/repos/ceph/ceph/issues/6582/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/6582/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/6582/events","html_url":"https://github.com/ceph/ceph/pull/6582","id":116920601,"number":6582,"title":"utime_t: transmit parameter by reference maybe better","user":{"login":"yangruifeng","id":12775013,"avatar_url":"https://avatars.githubusercontent.com/u/12775013?v=3","gravatar_id":"","url":"https://api.github.com/users/yangruifeng","html_url":"https://github.com/yangruifeng","followers_url":"https://api.github.com/users/yangruifeng/followers","following_url":"https://api.github.com/users/yangruifeng/following{/other_user}","gists_url":"https://api.github.com/users/yangruifeng/gists{/gist_id}","starred_url":"https://api.github.com/users/yangruifeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangruifeng/subscriptions","organizations_url":"https://api.github.com/users/yangruifeng/orgs","repos_url":"https://api.github.com/users/yangruifeng/repos","events_url":"https://api.github.com/users/yangruifeng/events{/privacy}","received_events_url":"https://api.github.com/users/yangruifeng/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/performance","name":"performance","color":"bfdadc"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-11-14T11:38:32Z","updated_at":"2015-11-30T02:53:13Z","closed_at":"2015-11-16T17:19:21Z","pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/6582","html_url":"https://github.com/ceph/ceph/pull/6582","diff_url":"https://github.com/ceph/ceph/pull/6582.diff","patch_url":"https://github.com/ceph/ceph/pull/6582.patch"},"body":"Signed-off-by: Ruifeng Yang <yangruifeng.09209@h3c.com>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/160504169","html_url":"https://github.com/ceph/ceph/pull/6582#issuecomment-160504169","issue_url":"https://api.github.com/repos/ceph/ceph/issues/6582","id":160504169,"user":{"login":"yangruifeng","id":12775013,"avatar_url":"https://avatars.githubusercontent.com/u/12775013?v=3","gravatar_id":"","url":"https://api.github.com/users/yangruifeng","html_url":"https://github.com/yangruifeng","followers_url":"https://api.github.com/users/yangruifeng/followers","following_url":"https://api.github.com/users/yangruifeng/following{/other_user}","gists_url":"https://api.github.com/users/yangruifeng/gists{/gist_id}","starred_url":"https://api.github.com/users/yangruifeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangruifeng/subscriptions","organizations_url":"https://api.github.com/users/yangruifeng/orgs","repos_url":"https://api.github.com/users/yangruifeng/repos","events_url":"https://api.github.com/users/yangruifeng/events{/privacy}","received_events_url":"https://api.github.com/users/yangruifeng/received_events","type":"User","site_admin":false},"created_at":"2015-11-30T02:53:13Z","updated_at":"2015-11-30T02:53:13Z","body":"@yuyuyu101 i test it in ceph also, \r\n```\r\n+int FileStore::get_index(const coll_t &cid, Index *index)\r\n {\r\n   int r = index_manager.get_index(cid, basedir, index);\r\n   assert(!m_filestore_fail_eio || r != -EIO);\r\n@@ -249,7 +249,10 @@ int FileStore::lfn_open(coll_t cid,\r\n     index = &index2;\r\n   }\r\n   if (!((*index).index)) {\r\n+    utime_t before = ceph_clock_now(g_ceph_context);\r\n     r = get_index(cid, index);\r\n+    utime_t after = ceph_clock_now(g_ceph_context);\r\n+    dout(0) << before << \"================\"  << after << dendl;\r\n```\r\n before modify get_index take  ~4976ns\r\nafter modify get_index take ~1694ns\r\n\r\n"}}