{"action":"closed","number":72,"pull_request":{"url":"https://api.github.com/repos/lpil/dogma/pulls/72","id":42973862,"html_url":"https://github.com/lpil/dogma/pull/72","diff_url":"https://github.com/lpil/dogma/pull/72.diff","patch_url":"https://github.com/lpil/dogma/pull/72.patch","issue_url":"https://api.github.com/repos/lpil/dogma/issues/72","number":72,"state":"closed","locked":false,"title":"Run rules on a script in parallel","user":{"login":"lpil","id":6134406,"avatar_url":"https://avatars.githubusercontent.com/u/6134406?v=3","gravatar_id":"","url":"https://api.github.com/users/lpil","html_url":"https://github.com/lpil","followers_url":"https://api.github.com/users/lpil/followers","following_url":"https://api.github.com/users/lpil/following{/other_user}","gists_url":"https://api.github.com/users/lpil/gists{/gist_id}","starred_url":"https://api.github.com/users/lpil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpil/subscriptions","organizations_url":"https://api.github.com/users/lpil/orgs","repos_url":"https://api.github.com/users/lpil/repos","events_url":"https://api.github.com/users/lpil/events{/privacy}","received_events_url":"https://api.github.com/users/lpil/received_events","type":"User","site_admin":false},"body":"This actually seems to negatively impact performance...\r\n\r\nUsing [this](https://github.com/lpil/dogma/blob/master/bench/single_file_bench.exs) benchmark:\r\n\r\n| Bench     | Typical result |\r\n| --------- | -------------- |\r\n| Series    | 204.51 µs/op   |\r\n| Parallel  | 445.52 µs/op   |\r\n\r\nI guess we shouldn't run things in parallel when we're not actually doing anything that expensive? I think I may have made an assumption about the amount of computation required to make it break even, much like when I was playing with the `Stream` module.\r\n\r\nOr am I doing something wrong?\r\n\r\n@meadsteve @jonnyarnold","created_at":"2015-08-20T20:23:22Z","updated_at":"2015-08-22T10:44:24Z","closed_at":"2015-08-22T10:44:24Z","merged_at":null,"merge_commit_sha":"563e9aa94089cf88960bee76b84df999188c1647","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lpil/dogma/pulls/72/commits","review_comments_url":"https://api.github.com/repos/lpil/dogma/pulls/72/comments","review_comment_url":"https://api.github.com/repos/lpil/dogma/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lpil/dogma/issues/72/comments","statuses_url":"https://api.github.com/repos/lpil/dogma/statuses/6f78b46dd6723a4da6f29d0f7fc1d3fd46ec09bf","head":{"label":"lpil:async","ref":"async","sha":"6f78b46dd6723a4da6f29d0f7fc1d3fd46ec09bf","user":{"login":"lpil","id":6134406,"avatar_url":"https://avatars.githubusercontent.com/u/6134406?v=3","gravatar_id":"","url":"https://api.github.com/users/lpil","html_url":"https://github.com/lpil","followers_url":"https://api.github.com/users/lpil/followers","following_url":"https://api.github.com/users/lpil/following{/other_user}","gists_url":"https://api.github.com/users/lpil/gists{/gist_id}","starred_url":"https://api.github.com/users/lpil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpil/subscriptions","organizations_url":"https://api.github.com/users/lpil/orgs","repos_url":"https://api.github.com/users/lpil/repos","events_url":"https://api.github.com/users/lpil/events{/privacy}","received_events_url":"https://api.github.com/users/lpil/received_events","type":"User","site_admin":false},"repo":{"id":37659054,"name":"dogma","full_name":"lpil/dogma","owner":{"login":"lpil","id":6134406,"avatar_url":"https://avatars.githubusercontent.com/u/6134406?v=3","gravatar_id":"","url":"https://api.github.com/users/lpil","html_url":"https://github.com/lpil","followers_url":"https://api.github.com/users/lpil/followers","following_url":"https://api.github.com/users/lpil/following{/other_user}","gists_url":"https://api.github.com/users/lpil/gists{/gist_id}","starred_url":"https://api.github.com/users/lpil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpil/subscriptions","organizations_url":"https://api.github.com/users/lpil/orgs","repos_url":"https://api.github.com/users/lpil/repos","events_url":"https://api.github.com/users/lpil/events{/privacy}","received_events_url":"https://api.github.com/users/lpil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lpil/dogma","description":"A code style linter for Elixir, powered by shame.","fork":false,"url":"https://api.github.com/repos/lpil/dogma","forks_url":"https://api.github.com/repos/lpil/dogma/forks","keys_url":"https://api.github.com/repos/lpil/dogma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lpil/dogma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lpil/dogma/teams","hooks_url":"https://api.github.com/repos/lpil/dogma/hooks","issue_events_url":"https://api.github.com/repos/lpil/dogma/issues/events{/number}","events_url":"https://api.github.com/repos/lpil/dogma/events","assignees_url":"https://api.github.com/repos/lpil/dogma/assignees{/user}","branches_url":"https://api.github.com/repos/lpil/dogma/branches{/branch}","tags_url":"https://api.github.com/repos/lpil/dogma/tags","blobs_url":"https://api.github.com/repos/lpil/dogma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lpil/dogma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lpil/dogma/git/refs{/sha}","trees_url":"https://api.github.com/repos/lpil/dogma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lpil/dogma/statuses/{sha}","languages_url":"https://api.github.com/repos/lpil/dogma/languages","stargazers_url":"https://api.github.com/repos/lpil/dogma/stargazers","contributors_url":"https://api.github.com/repos/lpil/dogma/contributors","subscribers_url":"https://api.github.com/repos/lpil/dogma/subscribers","subscription_url":"https://api.github.com/repos/lpil/dogma/subscription","commits_url":"https://api.github.com/repos/lpil/dogma/commits{/sha}","git_commits_url":"https://api.github.com/repos/lpil/dogma/git/commits{/sha}","comments_url":"https://api.github.com/repos/lpil/dogma/comments{/number}","issue_comment_url":"https://api.github.com/repos/lpil/dogma/issues/comments{/number}","contents_url":"https://api.github.com/repos/lpil/dogma/contents/{+path}","compare_url":"https://api.github.com/repos/lpil/dogma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lpil/dogma/merges","archive_url":"https://api.github.com/repos/lpil/dogma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lpil/dogma/downloads","issues_url":"https://api.github.com/repos/lpil/dogma/issues{/number}","pulls_url":"https://api.github.com/repos/lpil/dogma/pulls{/number}","milestones_url":"https://api.github.com/repos/lpil/dogma/milestones{/number}","notifications_url":"https://api.github.com/repos/lpil/dogma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lpil/dogma/labels{/name}","releases_url":"https://api.github.com/repos/lpil/dogma/releases{/id}","created_at":"2015-06-18T12:47:25Z","updated_at":"2015-08-21T20:42:11Z","pushed_at":"2015-08-20T20:23:23Z","git_url":"git://github.com/lpil/dogma.git","ssh_url":"git@github.com:lpil/dogma.git","clone_url":"https://github.com/lpil/dogma.git","svn_url":"https://github.com/lpil/dogma","homepage":"","size":577,"stargazers_count":19,"watchers_count":19,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":25,"forks":2,"open_issues":25,"watchers":19,"default_branch":"master"}},"base":{"label":"lpil:master","ref":"master","sha":"793485881a731a8b51e14bf6257475ec90ac164d","user":{"login":"lpil","id":6134406,"avatar_url":"https://avatars.githubusercontent.com/u/6134406?v=3","gravatar_id":"","url":"https://api.github.com/users/lpil","html_url":"https://github.com/lpil","followers_url":"https://api.github.com/users/lpil/followers","following_url":"https://api.github.com/users/lpil/following{/other_user}","gists_url":"https://api.github.com/users/lpil/gists{/gist_id}","starred_url":"https://api.github.com/users/lpil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpil/subscriptions","organizations_url":"https://api.github.com/users/lpil/orgs","repos_url":"https://api.github.com/users/lpil/repos","events_url":"https://api.github.com/users/lpil/events{/privacy}","received_events_url":"https://api.github.com/users/lpil/received_events","type":"User","site_admin":false},"repo":{"id":37659054,"name":"dogma","full_name":"lpil/dogma","owner":{"login":"lpil","id":6134406,"avatar_url":"https://avatars.githubusercontent.com/u/6134406?v=3","gravatar_id":"","url":"https://api.github.com/users/lpil","html_url":"https://github.com/lpil","followers_url":"https://api.github.com/users/lpil/followers","following_url":"https://api.github.com/users/lpil/following{/other_user}","gists_url":"https://api.github.com/users/lpil/gists{/gist_id}","starred_url":"https://api.github.com/users/lpil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpil/subscriptions","organizations_url":"https://api.github.com/users/lpil/orgs","repos_url":"https://api.github.com/users/lpil/repos","events_url":"https://api.github.com/users/lpil/events{/privacy}","received_events_url":"https://api.github.com/users/lpil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lpil/dogma","description":"A code style linter for Elixir, powered by shame.","fork":false,"url":"https://api.github.com/repos/lpil/dogma","forks_url":"https://api.github.com/repos/lpil/dogma/forks","keys_url":"https://api.github.com/repos/lpil/dogma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lpil/dogma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lpil/dogma/teams","hooks_url":"https://api.github.com/repos/lpil/dogma/hooks","issue_events_url":"https://api.github.com/repos/lpil/dogma/issues/events{/number}","events_url":"https://api.github.com/repos/lpil/dogma/events","assignees_url":"https://api.github.com/repos/lpil/dogma/assignees{/user}","branches_url":"https://api.github.com/repos/lpil/dogma/branches{/branch}","tags_url":"https://api.github.com/repos/lpil/dogma/tags","blobs_url":"https://api.github.com/repos/lpil/dogma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lpil/dogma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lpil/dogma/git/refs{/sha}","trees_url":"https://api.github.com/repos/lpil/dogma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lpil/dogma/statuses/{sha}","languages_url":"https://api.github.com/repos/lpil/dogma/languages","stargazers_url":"https://api.github.com/repos/lpil/dogma/stargazers","contributors_url":"https://api.github.com/repos/lpil/dogma/contributors","subscribers_url":"https://api.github.com/repos/lpil/dogma/subscribers","subscription_url":"https://api.github.com/repos/lpil/dogma/subscription","commits_url":"https://api.github.com/repos/lpil/dogma/commits{/sha}","git_commits_url":"https://api.github.com/repos/lpil/dogma/git/commits{/sha}","comments_url":"https://api.github.com/repos/lpil/dogma/comments{/number}","issue_comment_url":"https://api.github.com/repos/lpil/dogma/issues/comments{/number}","contents_url":"https://api.github.com/repos/lpil/dogma/contents/{+path}","compare_url":"https://api.github.com/repos/lpil/dogma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lpil/dogma/merges","archive_url":"https://api.github.com/repos/lpil/dogma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lpil/dogma/downloads","issues_url":"https://api.github.com/repos/lpil/dogma/issues{/number}","pulls_url":"https://api.github.com/repos/lpil/dogma/pulls{/number}","milestones_url":"https://api.github.com/repos/lpil/dogma/milestones{/number}","notifications_url":"https://api.github.com/repos/lpil/dogma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lpil/dogma/labels{/name}","releases_url":"https://api.github.com/repos/lpil/dogma/releases{/id}","created_at":"2015-06-18T12:47:25Z","updated_at":"2015-08-21T20:42:11Z","pushed_at":"2015-08-20T20:23:23Z","git_url":"git://github.com/lpil/dogma.git","ssh_url":"git@github.com:lpil/dogma.git","clone_url":"https://github.com/lpil/dogma.git","svn_url":"https://github.com/lpil/dogma","homepage":"","size":577,"stargazers_count":19,"watchers_count":19,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":25,"forks":2,"open_issues":25,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lpil/dogma/pulls/72"},"html":{"href":"https://github.com/lpil/dogma/pull/72"},"issue":{"href":"https://api.github.com/repos/lpil/dogma/issues/72"},"comments":{"href":"https://api.github.com/repos/lpil/dogma/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/lpil/dogma/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/lpil/dogma/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lpil/dogma/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/lpil/dogma/statuses/6f78b46dd6723a4da6f29d0f7fc1d3fd46ec09bf"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}