{"action":"created","issue":{"url":"https://api.github.com/repos/yyarp/WeedMoister/issues/5","labels_url":"https://api.github.com/repos/yyarp/WeedMoister/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/yyarp/WeedMoister/issues/5/comments","events_url":"https://api.github.com/repos/yyarp/WeedMoister/issues/5/events","html_url":"https://github.com/yyarp/WeedMoister/issues/5","id":54217042,"number":5,"title":"klarowność kodu","user":{"login":"czeskij","id":3092954,"avatar_url":"https://avatars.githubusercontent.com/u/3092954?v=3","gravatar_id":"","url":"https://api.github.com/users/czeskij","html_url":"https://github.com/czeskij","followers_url":"https://api.github.com/users/czeskij/followers","following_url":"https://api.github.com/users/czeskij/following{/other_user}","gists_url":"https://api.github.com/users/czeskij/gists{/gist_id}","starred_url":"https://api.github.com/users/czeskij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czeskij/subscriptions","organizations_url":"https://api.github.com/users/czeskij/orgs","repos_url":"https://api.github.com/users/czeskij/repos","events_url":"https://api.github.com/users/czeskij/events{/privacy}","received_events_url":"https://api.github.com/users/czeskij/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"yyarp","id":3093486,"avatar_url":"https://avatars.githubusercontent.com/u/3093486?v=3","gravatar_id":"","url":"https://api.github.com/users/yyarp","html_url":"https://github.com/yyarp","followers_url":"https://api.github.com/users/yyarp/followers","following_url":"https://api.github.com/users/yyarp/following{/other_user}","gists_url":"https://api.github.com/users/yyarp/gists{/gist_id}","starred_url":"https://api.github.com/users/yyarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyarp/subscriptions","organizations_url":"https://api.github.com/users/yyarp/orgs","repos_url":"https://api.github.com/users/yyarp/repos","events_url":"https://api.github.com/users/yyarp/events{/privacy}","received_events_url":"https://api.github.com/users/yyarp/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-01-13T16:49:50Z","updated_at":"2015-01-17T16:13:37Z","closed_at":null,"body":"czytam teraz kod, i mam parę propozycji:\r\n\r\n* co pozwoliłem sobie już zmienić: uprościłem generator zmiennych, sporo tam było obiektów niekoniecznie potrzebnych do działania, do obczajenia na moim branchu\r\n* nazewnictwo klas i metod: suprisingly, dopisywanie postfixu Class do klas czy Method do metod jest mylące i odciąga od sensu i funkcjonalności klasy/metody. żeby nie było, że piszę to z dupy: Kent Beck \"Wzorce implementacyjne\", cool story indeed. korzystniej nazywać metody odnośnie czynności, jakie wykonują, a klasy jako po prostu obiekt, np. `VariableGenerator` i `Generate()`.\r\n* zrobić z generatora singleton, i oszczędniej i czytelniej, nie wiem jak to się sprawdzi do końca ale warto spróbować."},"comment":{"url":"https://api.github.com/repos/yyarp/WeedMoister/issues/comments/70372530","html_url":"https://github.com/yyarp/WeedMoister/issues/5#issuecomment-70372530","issue_url":"https://api.github.com/repos/yyarp/WeedMoister/issues/5","id":70372530,"user":{"login":"yyarp","id":3093486,"avatar_url":"https://avatars.githubusercontent.com/u/3093486?v=3","gravatar_id":"","url":"https://api.github.com/users/yyarp","html_url":"https://github.com/yyarp","followers_url":"https://api.github.com/users/yyarp/followers","following_url":"https://api.github.com/users/yyarp/following{/other_user}","gists_url":"https://api.github.com/users/yyarp/gists{/gist_id}","starred_url":"https://api.github.com/users/yyarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyarp/subscriptions","organizations_url":"https://api.github.com/users/yyarp/orgs","repos_url":"https://api.github.com/users/yyarp/repos","events_url":"https://api.github.com/users/yyarp/events{/privacy}","received_events_url":"https://api.github.com/users/yyarp/received_events","type":"User","site_admin":false},"created_at":"2015-01-17T16:13:37Z","updated_at":"2015-01-17T16:13:37Z","body":"nazwy są pozmieniane, pytanie tylko jeszcze czy w fuzzificator są wystarczająco czytelne linie."}}