{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/comments/32307095","id":32307095,"diff_hunk":"@@ -68,6 +68,7 @@ func (sender *GossipSender) run() {\n \t\t\tcase pending := <-sender.cell:\n \t\t\t\tif pending != nil {\n \t\t\t\t\tsender.send(pending)\n+\t\t\t\t\tch <- true","path":"router/gossip.go","position":22,"original_position":22,"commit_id":"890325404592c54aaf6e58d87f2e48556880af77","original_commit_id":"890325404592c54aaf6e58d87f2e48556880af77","user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"body":"we don't actually need the nil check here.\r\n\r\nAlso, I reckon we should send true or false, and *not* close the channel.","created_at":"2015-06-12T11:03:32Z","updated_at":"2015-06-12T11:03:32Z","html_url":"https://github.com/weaveworks/weave/pull/902#discussion_r32307095","pull_request_url":"https://api.github.com/repos/weaveworks/weave/pulls/902","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments/32307095"},"html":{"href":"https://github.com/weaveworks/weave/pull/902#discussion_r32307095"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/902"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/902","id":37545970,"html_url":"https://github.com/weaveworks/weave/pull/902","diff_url":"https://github.com/weaveworks/weave/pull/902.diff","patch_url":"https://github.com/weaveworks/weave/pull/902.patch","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/902","number":902,"state":"open","locked":false,"title":"Keep flushing gossip until it's all gone","user":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"body":"Fix #885 more thoroughly, by looping across multiple routers until none of them have anything to say.","created_at":"2015-06-12T09:32:05Z","updated_at":"2015-06-12T11:03:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ec18836429be5a27224ee5741ecaf490b035b87","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/weave/pulls/902/commits","review_comments_url":"https://api.github.com/repos/weaveworks/weave/pulls/902/comments","review_comment_url":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/902/comments","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/890325404592c54aaf6e58d87f2e48556880af77","head":{"label":"bboreham:885-gossip-race","ref":"885-gossip-race","sha":"890325404592c54aaf6e58d87f2e48556880af77","user":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"repo":{"id":23360369,"name":"weave","full_name":"bboreham/weave","owner":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bboreham/weave","description":"The Docker Network","fork":true,"url":"https://api.github.com/repos/bboreham/weave","forks_url":"https://api.github.com/repos/bboreham/weave/forks","keys_url":"https://api.github.com/repos/bboreham/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bboreham/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bboreham/weave/teams","hooks_url":"https://api.github.com/repos/bboreham/weave/hooks","issue_events_url":"https://api.github.com/repos/bboreham/weave/issues/events{/number}","events_url":"https://api.github.com/repos/bboreham/weave/events","assignees_url":"https://api.github.com/repos/bboreham/weave/assignees{/user}","branches_url":"https://api.github.com/repos/bboreham/weave/branches{/branch}","tags_url":"https://api.github.com/repos/bboreham/weave/tags","blobs_url":"https://api.github.com/repos/bboreham/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bboreham/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bboreham/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/bboreham/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bboreham/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/bboreham/weave/languages","stargazers_url":"https://api.github.com/repos/bboreham/weave/stargazers","contributors_url":"https://api.github.com/repos/bboreham/weave/contributors","subscribers_url":"https://api.github.com/repos/bboreham/weave/subscribers","subscription_url":"https://api.github.com/repos/bboreham/weave/subscription","commits_url":"https://api.github.com/repos/bboreham/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/bboreham/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/bboreham/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/bboreham/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/bboreham/weave/contents/{+path}","compare_url":"https://api.github.com/repos/bboreham/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bboreham/weave/merges","archive_url":"https://api.github.com/repos/bboreham/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bboreham/weave/downloads","issues_url":"https://api.github.com/repos/bboreham/weave/issues{/number}","pulls_url":"https://api.github.com/repos/bboreham/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/bboreham/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/bboreham/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bboreham/weave/labels{/name}","releases_url":"https://api.github.com/repos/bboreham/weave/releases{/id}","created_at":"2014-08-26T17:24:12Z","updated_at":"2015-04-17T10:04:44Z","pushed_at":"2015-06-12T09:14:09Z","git_url":"git://github.com/bboreham/weave.git","ssh_url":"git@github.com:bboreham/weave.git","clone_url":"https://github.com/bboreham/weave.git","svn_url":"https://github.com/bboreham/weave","homepage":"","size":8211,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"8e04b135bbf3dd3a53ea72f210f236fa093726e4","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":23059575,"name":"weave","full_name":"weaveworks/weave","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/weave","description":"The Docker Network","fork":false,"url":"https://api.github.com/repos/weaveworks/weave","forks_url":"https://api.github.com/repos/weaveworks/weave/forks","keys_url":"https://api.github.com/repos/weaveworks/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/weave/teams","hooks_url":"https://api.github.com/repos/weaveworks/weave/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/weave/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/weave/events","assignees_url":"https://api.github.com/repos/weaveworks/weave/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/weave/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/weave/tags","blobs_url":"https://api.github.com/repos/weaveworks/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/weave/languages","stargazers_url":"https://api.github.com/repos/weaveworks/weave/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/weave/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/weave/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/weave/subscription","commits_url":"https://api.github.com/repos/weaveworks/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/weave/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/weave/merges","archive_url":"https://api.github.com/repos/weaveworks/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/weave/downloads","issues_url":"https://api.github.com/repos/weaveworks/weave/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/weave/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/weave/releases{/id}","created_at":"2014-08-18T05:19:07Z","updated_at":"2015-06-12T01:20:00Z","pushed_at":"2015-06-12T10:57:16Z","git_url":"git://github.com/weaveworks/weave.git","ssh_url":"git@github.com:weaveworks/weave.git","clone_url":"https://github.com/weaveworks/weave.git","svn_url":"https://github.com/weaveworks/weave","homepage":"http://weave.works","size":11491,"stargazers_count":3421,"watchers_count":3421,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":193,"mirror_url":null,"open_issues_count":136,"forks":193,"open_issues":136,"watchers":3421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/902"},"html":{"href":"https://github.com/weaveworks/weave/pull/902"},"issue":{"href":"https://api.github.com/repos/weaveworks/weave/issues/902"},"comments":{"href":"https://api.github.com/repos/weaveworks/weave/issues/902/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/902/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/902/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/weave/statuses/890325404592c54aaf6e58d87f2e48556880af77"}}}}