{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/presto/pulls/comments/29454120","id":29454120,"diff_hunk":"@@ -308,7 +319,9 @@ else if (Iterables.all(firstDependencies, right.canResolvePredicate()) && Iterab\n         }\n         Optional<Symbol> sampleWeight = Optional.empty();\n         if (leftPlanBuilder.getSampleWeight().isPresent() || rightPlanBuilder.getSampleWeight().isPresent()) {\n-            Expression expression = new ArithmeticBinaryExpression(ArithmeticBinaryExpression.Type.MULTIPLY, oneIfNull(leftPlanBuilder.getSampleWeight()), oneIfNull(rightPlanBuilder.getSampleWeight()));","path":"presto-main/src/main/java/com/facebook/presto/sql/planner/RelationPlanner.java","position":62,"original_position":62,"commit_id":"f1f0daa7541153b9204b0a1933bf9b7c03768210","original_commit_id":"f1f0daa7541153b9204b0a1933bf9b7c03768210","user":{"login":"martint","id":14387,"avatar_url":"https://avatars.githubusercontent.com/u/14387?v=3","gravatar_id":"","url":"https://api.github.com/users/martint","html_url":"https://github.com/martint","followers_url":"https://api.github.com/users/martint/followers","following_url":"https://api.github.com/users/martint/following{/other_user}","gists_url":"https://api.github.com/users/martint/gists{/gist_id}","starred_url":"https://api.github.com/users/martint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martint/subscriptions","organizations_url":"https://api.github.com/users/martint/orgs","repos_url":"https://api.github.com/users/martint/repos","events_url":"https://api.github.com/users/martint/events{/privacy}","received_events_url":"https://api.github.com/users/martint/received_events","type":"User","site_admin":false},"body":"Unrelated change?","created_at":"2015-04-30T18:04:10Z","updated_at":"2015-04-30T18:04:10Z","html_url":"https://github.com/facebook/presto/pull/2753#discussion_r29454120","pull_request_url":"https://api.github.com/repos/facebook/presto/pulls/2753","_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments/29454120"},"html":{"href":"https://github.com/facebook/presto/pull/2753#discussion_r29454120"},"pull_request":{"href":"https://api.github.com/repos/facebook/presto/pulls/2753"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/presto/pulls/2753","id":33685008,"html_url":"https://github.com/facebook/presto/pull/2753","diff_url":"https://github.com/facebook/presto/pull/2753.diff","patch_url":"https://github.com/facebook/presto/pull/2753.patch","issue_url":"https://api.github.com/repos/facebook/presto/issues/2753","number":2753,"state":"open","locked":false,"title":"Add implicit coersions to VALUES","user":{"login":"dain","id":58298,"avatar_url":"https://avatars.githubusercontent.com/u/58298?v=3","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-20T16:59:34Z","updated_at":"2015-04-30T18:04:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54846a37b843301b84d81dd7c37fb7fb50e89899","assignee":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/presto/pulls/2753/commits","review_comments_url":"https://api.github.com/repos/facebook/presto/pulls/2753/comments","review_comment_url":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/presto/issues/2753/comments","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/f1f0daa7541153b9204b0a1933bf9b7c03768210","head":{"label":"dain:values-implicit-coercion","ref":"values-implicit-coercion","sha":"f1f0daa7541153b9204b0a1933bf9b7c03768210","user":{"login":"dain","id":58298,"avatar_url":"https://avatars.githubusercontent.com/u/58298?v=3","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"repo":{"id":5403482,"name":"presto","full_name":"dain/presto","owner":{"login":"dain","id":58298,"avatar_url":"https://avatars.githubusercontent.com/u/58298?v=3","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dain/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/dain/presto","forks_url":"https://api.github.com/repos/dain/presto/forks","keys_url":"https://api.github.com/repos/dain/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dain/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dain/presto/teams","hooks_url":"https://api.github.com/repos/dain/presto/hooks","issue_events_url":"https://api.github.com/repos/dain/presto/issues/events{/number}","events_url":"https://api.github.com/repos/dain/presto/events","assignees_url":"https://api.github.com/repos/dain/presto/assignees{/user}","branches_url":"https://api.github.com/repos/dain/presto/branches{/branch}","tags_url":"https://api.github.com/repos/dain/presto/tags","blobs_url":"https://api.github.com/repos/dain/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dain/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dain/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/dain/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dain/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/dain/presto/languages","stargazers_url":"https://api.github.com/repos/dain/presto/stargazers","contributors_url":"https://api.github.com/repos/dain/presto/contributors","subscribers_url":"https://api.github.com/repos/dain/presto/subscribers","subscription_url":"https://api.github.com/repos/dain/presto/subscription","commits_url":"https://api.github.com/repos/dain/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/dain/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/dain/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/dain/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/dain/presto/contents/{+path}","compare_url":"https://api.github.com/repos/dain/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dain/presto/merges","archive_url":"https://api.github.com/repos/dain/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dain/presto/downloads","issues_url":"https://api.github.com/repos/dain/presto/issues{/number}","pulls_url":"https://api.github.com/repos/dain/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/dain/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/dain/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dain/presto/labels{/name}","releases_url":"https://api.github.com/repos/dain/presto/releases{/id}","created_at":"2012-08-13T19:14:12Z","updated_at":"2015-04-30T04:53:01Z","pushed_at":"2015-04-30T06:41:45Z","git_url":"git://github.com/dain/presto.git","ssh_url":"git@github.com:dain/presto.git","clone_url":"https://github.com/dain/presto.git","svn_url":"https://github.com/dain/presto","homepage":"http://prestodb.io/","size":42504,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"1392ecb04f03eb8def966a0c6527ec37b45f4022","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"facebook/presto","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":false,"url":"https://api.github.com/repos/facebook/presto","forks_url":"https://api.github.com/repos/facebook/presto/forks","keys_url":"https://api.github.com/repos/facebook/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/presto/teams","hooks_url":"https://api.github.com/repos/facebook/presto/hooks","issue_events_url":"https://api.github.com/repos/facebook/presto/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/presto/events","assignees_url":"https://api.github.com/repos/facebook/presto/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/presto/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/presto/tags","blobs_url":"https://api.github.com/repos/facebook/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/presto/languages","stargazers_url":"https://api.github.com/repos/facebook/presto/stargazers","contributors_url":"https://api.github.com/repos/facebook/presto/contributors","subscribers_url":"https://api.github.com/repos/facebook/presto/subscribers","subscription_url":"https://api.github.com/repos/facebook/presto/subscription","commits_url":"https://api.github.com/repos/facebook/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/presto/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/presto/merges","archive_url":"https://api.github.com/repos/facebook/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/presto/downloads","issues_url":"https://api.github.com/repos/facebook/presto/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/presto/labels{/name}","releases_url":"https://api.github.com/repos/facebook/presto/releases{/id}","created_at":"2012-08-09T01:03:37Z","updated_at":"2015-04-30T16:33:18Z","pushed_at":"2015-04-30T17:19:38Z","git_url":"git://github.com/facebook/presto.git","ssh_url":"git@github.com:facebook/presto.git","clone_url":"https://github.com/facebook/presto.git","svn_url":"https://github.com/facebook/presto","homepage":"https://prestodb.io","size":84878,"stargazers_count":3393,"watchers_count":3393,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":775,"mirror_url":null,"open_issues_count":214,"forks":775,"open_issues":214,"watchers":3393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/2753"},"html":{"href":"https://github.com/facebook/presto/pull/2753"},"issue":{"href":"https://api.github.com/repos/facebook/presto/issues/2753"},"comments":{"href":"https://api.github.com/repos/facebook/presto/issues/2753/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/presto/pulls/2753/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/presto/pulls/2753/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/presto/statuses/f1f0daa7541153b9204b0a1933bf9b7c03768210"}}}}