{"action":"created","issue":{"url":"https://api.github.com/repos/brikteknologier/seraph-model/issues/86","labels_url":"https://api.github.com/repos/brikteknologier/seraph-model/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/brikteknologier/seraph-model/issues/86/comments","events_url":"https://api.github.com/repos/brikteknologier/seraph-model/issues/86/events","html_url":"https://github.com/brikteknologier/seraph-model/pull/86","id":59224179,"number":86,"title":"adding properties to relationships","user":{"login":"IcanDivideBy0","id":673101,"avatar_url":"https://avatars.githubusercontent.com/u/673101?v=3","gravatar_id":"","url":"https://api.github.com/users/IcanDivideBy0","html_url":"https://github.com/IcanDivideBy0","followers_url":"https://api.github.com/users/IcanDivideBy0/followers","following_url":"https://api.github.com/users/IcanDivideBy0/following{/other_user}","gists_url":"https://api.github.com/users/IcanDivideBy0/gists{/gist_id}","starred_url":"https://api.github.com/users/IcanDivideBy0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IcanDivideBy0/subscriptions","organizations_url":"https://api.github.com/users/IcanDivideBy0/orgs","repos_url":"https://api.github.com/users/IcanDivideBy0/repos","events_url":"https://api.github.com/users/IcanDivideBy0/events{/privacy}","received_events_url":"https://api.github.com/users/IcanDivideBy0/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-02-27T11:26:04Z","updated_at":"2015-03-18T15:54:17Z","closed_at":"2015-03-18T15:52:59Z","pull_request":{"url":"https://api.github.com/repos/brikteknologier/seraph-model/pulls/86","html_url":"https://github.com/brikteknologier/seraph-model/pull/86","diff_url":"https://github.com/brikteknologier/seraph-model/pull/86.diff","patch_url":"https://github.com/brikteknologier/seraph-model/pull/86.patch"},"body":"fixes #64\r\n\r\nI just want to check with you guy if generating the relation identifier in cypher by prefixing the node name with `rel_` is the right way to go, or if you prefer to use some kind of name generator like [this one](https://github.com/brikteknologier/seraph-model/blob/master/lib/write.js#L15-L22).\r\nI think it might overlap if you have a model named `whatever` which is related to another model, AND a third model named `rel_whatever`, all involved in the same query.\r\n\r\nIf that's fine with you, I'll keep going :\r\n- [x] merge relationships properties while read the related models\r\n- [ ] ~~ability to filter on relationships properties~~ it looks like this can already be done with `model.query`\r\n- [x] add tests\r\n- [x] update README.md"},"comment":{"url":"https://api.github.com/repos/brikteknologier/seraph-model/issues/comments/83031786","html_url":"https://github.com/brikteknologier/seraph-model/pull/86#issuecomment-83031786","issue_url":"https://api.github.com/repos/brikteknologier/seraph-model/issues/86","id":83031786,"user":{"login":"jonpacker","id":678101,"avatar_url":"https://avatars.githubusercontent.com/u/678101?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpacker","html_url":"https://github.com/jonpacker","followers_url":"https://api.github.com/users/jonpacker/followers","following_url":"https://api.github.com/users/jonpacker/following{/other_user}","gists_url":"https://api.github.com/users/jonpacker/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpacker/subscriptions","organizations_url":"https://api.github.com/users/jonpacker/orgs","repos_url":"https://api.github.com/users/jonpacker/repos","events_url":"https://api.github.com/users/jonpacker/events{/privacy}","received_events_url":"https://api.github.com/users/jonpacker/received_events","type":"User","site_admin":false},"created_at":"2015-03-18T15:54:17Z","updated_at":"2015-03-18T15:54:17Z","body":"published as v0.10.0"}}