{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/10680","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/10680/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/10680/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/10680/events","html_url":"https://github.com/edx/edx-platform/pull/10680","id":117897476,"number":10680,"title":"Fixes TNL-3664 by collapsing actions dropdown after an action item is clicked.","user":{"login":"doganov","id":517815,"avatar_url":"https://avatars.githubusercontent.com/u/517815?v=3","gravatar_id":"","url":"https://api.github.com/users/doganov","html_url":"https://github.com/doganov","followers_url":"https://api.github.com/users/doganov/followers","following_url":"https://api.github.com/users/doganov/following{/other_user}","gists_url":"https://api.github.com/users/doganov/gists{/gist_id}","starred_url":"https://api.github.com/users/doganov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doganov/subscriptions","organizations_url":"https://api.github.com/users/doganov/orgs","repos_url":"https://api.github.com/users/doganov/repos","events_url":"https://api.github.com/users/doganov/events{/privacy}","received_events_url":"https://api.github.com/users/doganov/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/edx/edx-platform/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf"},{"url":"https://api.github.com/repos/edx/edx-platform/labels/waiting%20on%20author","name":"waiting on author","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-19T20:09:17Z","updated_at":"2015-11-20T18:41:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/10680","html_url":"https://github.com/edx/edx-platform/pull/10680","diff_url":"https://github.com/edx/edx-platform/pull/10680.diff","patch_url":"https://github.com/edx/edx-platform/pull/10680.patch"},"body":"### Fixes [TNL-3644](https://openedx.atlassian.net/browse/TNL-3644): Course settings dropdown doesn't disappear if you close modals\r\n\r\n#### Components affected:\r\n- LMS\r\n\r\n#### Steps to verify:\r\n\r\n1. Go to your student dashboard page in the LMS\r\n2. Click the \"gear\" icon and select \"Unenroll\"\r\n3. On the Unenroll modal, exit out of the modal\r\n\r\nNote that the settings menu is now collapsed. It stayed open before the fix.\r\n\r\n#### Additional discussion\r\nNormally, when we fix a bug, we would like to add a test alongside the fix, to be sure that the bug remains fixed. You will note that I do not include a test with this PR. My rationale is that the code in [legacy.js](https://github.com/edx/edx-platform/blob/69dc51859e57e458e1a64717224343ff90e19298/lms/static/js/dashboard/legacy.js) is not designed to be testable, so I do not see how to test the new behaviour without rewriting major part of [legacy.js](https://github.com/edx/edx-platform/blob/69dc51859e57e458e1a64717224343ff90e19298/lms/static/js/dashboard/legacy.js), [_dashboard_course_listing.html](https://github.com/edx/edx-platform/blob/69dc51859e57e458e1a64717224343ff90e19298/lms/templates/dashboard/_dashboard_course_listing.html), and perhaps introducing a new template file. My concern is that such change introduces much more risk (read: potential bugs and problems) than it actually fixes. Especially when it is done by someone who is completely new to the project such as me.\r\n\r\nIn comparison, the conservative bugfix is trivial. So I propose it here.\r\n\r\n#### Legal\r\nThis PR is covered by OpenCraft contributor agreement.\r\n\r\n@antoviaque"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/158486409","html_url":"https://github.com/edx/edx-platform/pull/10680#issuecomment-158486409","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/10680","id":158486409,"user":{"login":"doganov","id":517815,"avatar_url":"https://avatars.githubusercontent.com/u/517815?v=3","gravatar_id":"","url":"https://api.github.com/users/doganov","html_url":"https://github.com/doganov","followers_url":"https://api.github.com/users/doganov/followers","following_url":"https://api.github.com/users/doganov/following{/other_user}","gists_url":"https://api.github.com/users/doganov/gists{/gist_id}","starred_url":"https://api.github.com/users/doganov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doganov/subscriptions","organizations_url":"https://api.github.com/users/doganov/orgs","repos_url":"https://api.github.com/users/doganov/repos","events_url":"https://api.github.com/users/doganov/events{/privacy}","received_events_url":"https://api.github.com/users/doganov/received_events","type":"User","site_admin":false},"created_at":"2015-11-20T18:41:12Z","updated_at":"2015-11-20T18:41:12Z","body":"@sarina I just rebased it and can confirm that it works with Django 1.8.\r\n\r\n@antoviaque"}}