{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/comments/37605439","id":37605439,"diff_hunk":"@@ -126,8 +126,18 @@ public void processRecords(List<Record> records, IRecordProcessorCheckpointer ch\n                 } else {\n                     throw new RuntimeException(\"Transformer must implement ITransformer or ICollectionTransformer\");\n                 }\n-            } catch (IOException e) {\n+            } catch (Exception e) {\n                 LOG.error(e);\n+                try {\n+                    final String lastSequenceNumberProcessed = buffer.getLastSequenceNumber();","path":"src/main/java/com/amazonaws/services/kinesis/connectors/KinesisConnectorRecordProcessor.java","position":8,"original_position":8,"commit_id":"14638a5925a74be66e3bce8f7d84261a6487dc37","original_commit_id":"14638a5925a74be66e3bce8f7d84261a6487dc37","user":{"login":"darkcrawler01","id":3446395,"avatar_url":"https://avatars.githubusercontent.com/u/3446395?v=3","gravatar_id":"","url":"https://api.github.com/users/darkcrawler01","html_url":"https://github.com/darkcrawler01","followers_url":"https://api.github.com/users/darkcrawler01/followers","following_url":"https://api.github.com/users/darkcrawler01/following{/other_user}","gists_url":"https://api.github.com/users/darkcrawler01/gists{/gist_id}","starred_url":"https://api.github.com/users/darkcrawler01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkcrawler01/subscriptions","organizations_url":"https://api.github.com/users/darkcrawler01/orgs","repos_url":"https://api.github.com/users/darkcrawler01/repos","events_url":"https://api.github.com/users/darkcrawler01/events{/privacy}","received_events_url":"https://api.github.com/users/darkcrawler01/received_events","type":"User","site_admin":false},"body":"why do you want to checkpoint here ?","created_at":"2015-08-21T04:14:17Z","updated_at":"2015-08-21T04:14:17Z","html_url":"https://github.com/awslabs/amazon-kinesis-connectors/pull/54#discussion_r37605439","pull_request_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/comments/37605439"},"html":{"href":"https://github.com/awslabs/amazon-kinesis-connectors/pull/54#discussion_r37605439"},"pull_request":{"href":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/54","id":42987469,"html_url":"https://github.com/awslabs/amazon-kinesis-connectors/pull/54","diff_url":"https://github.com/awslabs/amazon-kinesis-connectors/pull/54.diff","patch_url":"https://github.com/awslabs/amazon-kinesis-connectors/pull/54.patch","issue_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/issues/54","number":54,"state":"open","locked":false,"title":"Catch all exceptions in Record Processor instead of just IOException.","user":{"login":"workanandr","id":10424213,"avatar_url":"https://avatars.githubusercontent.com/u/10424213?v=3","gravatar_id":"","url":"https://api.github.com/users/workanandr","html_url":"https://github.com/workanandr","followers_url":"https://api.github.com/users/workanandr/followers","following_url":"https://api.github.com/users/workanandr/following{/other_user}","gists_url":"https://api.github.com/users/workanandr/gists{/gist_id}","starred_url":"https://api.github.com/users/workanandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/workanandr/subscriptions","organizations_url":"https://api.github.com/users/workanandr/orgs","repos_url":"https://api.github.com/users/workanandr/repos","events_url":"https://api.github.com/users/workanandr/events{/privacy}","received_events_url":"https://api.github.com/users/workanandr/received_events","type":"User","site_admin":false},"body":"Checkpoint in the case of exception during record processing so that we don't go into an infinite loop of processing a bad record that throws an Exception.","created_at":"2015-08-20T22:49:13Z","updated_at":"2015-08-21T04:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"396446f90dcf798daf2bf9c4f0e2194c5e6850b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/54/commits","review_comments_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/54/comments","review_comment_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/issues/54/comments","statuses_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/statuses/14638a5925a74be66e3bce8f7d84261a6487dc37","head":{"label":"workanandr:master","ref":"master","sha":"14638a5925a74be66e3bce8f7d84261a6487dc37","user":{"login":"workanandr","id":10424213,"avatar_url":"https://avatars.githubusercontent.com/u/10424213?v=3","gravatar_id":"","url":"https://api.github.com/users/workanandr","html_url":"https://github.com/workanandr","followers_url":"https://api.github.com/users/workanandr/followers","following_url":"https://api.github.com/users/workanandr/following{/other_user}","gists_url":"https://api.github.com/users/workanandr/gists{/gist_id}","starred_url":"https://api.github.com/users/workanandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/workanandr/subscriptions","organizations_url":"https://api.github.com/users/workanandr/orgs","repos_url":"https://api.github.com/users/workanandr/repos","events_url":"https://api.github.com/users/workanandr/events{/privacy}","received_events_url":"https://api.github.com/users/workanandr/received_events","type":"User","site_admin":false},"repo":{"id":41120739,"name":"amazon-kinesis-connectors","full_name":"workanandr/amazon-kinesis-connectors","owner":{"login":"workanandr","id":10424213,"avatar_url":"https://avatars.githubusercontent.com/u/10424213?v=3","gravatar_id":"","url":"https://api.github.com/users/workanandr","html_url":"https://github.com/workanandr","followers_url":"https://api.github.com/users/workanandr/followers","following_url":"https://api.github.com/users/workanandr/following{/other_user}","gists_url":"https://api.github.com/users/workanandr/gists{/gist_id}","starred_url":"https://api.github.com/users/workanandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/workanandr/subscriptions","organizations_url":"https://api.github.com/users/workanandr/orgs","repos_url":"https://api.github.com/users/workanandr/repos","events_url":"https://api.github.com/users/workanandr/events{/privacy}","received_events_url":"https://api.github.com/users/workanandr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/workanandr/amazon-kinesis-connectors","description":"","fork":true,"url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors","forks_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/forks","keys_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/teams","hooks_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/hooks","issue_events_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/issues/events{/number}","events_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/events","assignees_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/assignees{/user}","branches_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/branches{/branch}","tags_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/tags","blobs_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/git/refs{/sha}","trees_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/statuses/{sha}","languages_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/languages","stargazers_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/stargazers","contributors_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/contributors","subscribers_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/subscribers","subscription_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/subscription","commits_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/commits{/sha}","git_commits_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/git/commits{/sha}","comments_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/comments{/number}","issue_comment_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/issues/comments{/number}","contents_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/contents/{+path}","compare_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/merges","archive_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/downloads","issues_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/issues{/number}","pulls_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/pulls{/number}","milestones_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/milestones{/number}","notifications_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/labels{/name}","releases_url":"https://api.github.com/repos/workanandr/amazon-kinesis-connectors/releases{/id}","created_at":"2015-08-20T21:58:26Z","updated_at":"2015-08-20T21:58:26Z","pushed_at":"2015-08-20T22:48:14Z","git_url":"git://github.com/workanandr/amazon-kinesis-connectors.git","ssh_url":"git@github.com:workanandr/amazon-kinesis-connectors.git","clone_url":"https://github.com/workanandr/amazon-kinesis-connectors.git","svn_url":"https://github.com/workanandr/amazon-kinesis-connectors","homepage":null,"size":517,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"9b34900413a25212f4dec9d7f1e64136df31db9b","user":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars.githubusercontent.com/u/3299148?v=3","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":14697005,"name":"amazon-kinesis-connectors","full_name":"awslabs/amazon-kinesis-connectors","owner":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars.githubusercontent.com/u/3299148?v=3","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/amazon-kinesis-connectors","description":"","fork":false,"url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors","forks_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/forks","keys_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/teams","hooks_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/hooks","issue_events_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/events","assignees_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/tags","blobs_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/languages","stargazers_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/stargazers","contributors_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/contributors","subscribers_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/subscribers","subscription_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/subscription","commits_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/merges","archive_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/downloads","issues_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/releases{/id}","created_at":"2013-11-25T20:10:14Z","updated_at":"2015-08-21T02:10:47Z","pushed_at":"2015-08-20T22:49:13Z","git_url":"git://github.com/awslabs/amazon-kinesis-connectors.git","ssh_url":"git@github.com:awslabs/amazon-kinesis-connectors.git","clone_url":"https://github.com/awslabs/amazon-kinesis-connectors.git","svn_url":"https://github.com/awslabs/amazon-kinesis-connectors","homepage":null,"size":777,"stargazers_count":151,"watchers_count":151,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":19,"forks":96,"open_issues":19,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/54"},"html":{"href":"https://github.com/awslabs/amazon-kinesis-connectors/pull/54"},"issue":{"href":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/issues/54"},"comments":{"href":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/amazon-kinesis-connectors/statuses/14638a5925a74be66e3bce8f7d84261a6487dc37"}}}}