{"action":"closed","number":44,"pull_request":{"url":"https://api.github.com/repos/jhund/filterrific/pulls/44","id":31748647,"html_url":"https://github.com/jhund/filterrific/pull/44","diff_url":"https://github.com/jhund/filterrific/pull/44.diff","patch_url":"https://github.com/jhund/filterrific/pull/44.patch","issue_url":"https://api.github.com/repos/jhund/filterrific/issues/44","number":44,"state":"closed","locked":false,"title":"set local variable to fix breaking bug on sorting links","user":{"login":"alankessler","id":1541397,"avatar_url":"https://avatars.githubusercontent.com/u/1541397?v=3","gravatar_id":"","url":"https://api.github.com/users/alankessler","html_url":"https://github.com/alankessler","followers_url":"https://api.github.com/users/alankessler/followers","following_url":"https://api.github.com/users/alankessler/following{/other_user}","gists_url":"https://api.github.com/users/alankessler/gists{/gist_id}","starred_url":"https://api.github.com/users/alankessler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alankessler/subscriptions","organizations_url":"https://api.github.com/users/alankessler/orgs","repos_url":"https://api.github.com/users/alankessler/repos","events_url":"https://api.github.com/users/alankessler/events{/privacy}","received_events_url":"https://api.github.com/users/alankessler/received_events","type":"User","site_admin":false},"body":"@jhund I'm trying to upgrade my app from 1.4.x to 2.0, and I'm getting this error:\r\n\r\nundefined local variable or method `current_sorting' for <#<Class:0x007fc18f8ea410>:0x007fc18bb7f5f8>\r\n\r\nIf I remove all of the filterrific_sorting_links or make the change in this pull request the error disappears.\r\n\r\nAnother problem I'm noticing is that after I make this fix, I don't get the ascending/descending indicators in my links anymore. The arrows were showing up in 1.4 but don't show up in 2.0. Any ideas why that might be happening?","created_at":"2015-03-23T16:26:39Z","updated_at":"2015-04-09T04:05:31Z","closed_at":"2015-04-09T04:05:31Z","merged_at":"2015-04-09T04:05:31Z","merge_commit_sha":"3ac50fde5bf1c1fe6ccc025b4d36f695635b2704","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jhund/filterrific/pulls/44/commits","review_comments_url":"https://api.github.com/repos/jhund/filterrific/pulls/44/comments","review_comment_url":"https://api.github.com/repos/jhund/filterrific/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhund/filterrific/issues/44/comments","statuses_url":"https://api.github.com/repos/jhund/filterrific/statuses/65006ad01e56e21637a981d37bd1f00beb35d6ae","head":{"label":"alankessler:master","ref":"master","sha":"65006ad01e56e21637a981d37bd1f00beb35d6ae","user":{"login":"alankessler","id":1541397,"avatar_url":"https://avatars.githubusercontent.com/u/1541397?v=3","gravatar_id":"","url":"https://api.github.com/users/alankessler","html_url":"https://github.com/alankessler","followers_url":"https://api.github.com/users/alankessler/followers","following_url":"https://api.github.com/users/alankessler/following{/other_user}","gists_url":"https://api.github.com/users/alankessler/gists{/gist_id}","starred_url":"https://api.github.com/users/alankessler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alankessler/subscriptions","organizations_url":"https://api.github.com/users/alankessler/orgs","repos_url":"https://api.github.com/users/alankessler/repos","events_url":"https://api.github.com/users/alankessler/events{/privacy}","received_events_url":"https://api.github.com/users/alankessler/received_events","type":"User","site_admin":false},"repo":{"id":32743804,"name":"filterrific","full_name":"alankessler/filterrific","owner":{"login":"alankessler","id":1541397,"avatar_url":"https://avatars.githubusercontent.com/u/1541397?v=3","gravatar_id":"","url":"https://api.github.com/users/alankessler","html_url":"https://github.com/alankessler","followers_url":"https://api.github.com/users/alankessler/followers","following_url":"https://api.github.com/users/alankessler/following{/other_user}","gists_url":"https://api.github.com/users/alankessler/gists{/gist_id}","starred_url":"https://api.github.com/users/alankessler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alankessler/subscriptions","organizations_url":"https://api.github.com/users/alankessler/orgs","repos_url":"https://api.github.com/users/alankessler/repos","events_url":"https://api.github.com/users/alankessler/events{/privacy}","received_events_url":"https://api.github.com/users/alankessler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alankessler/filterrific","description":"Filterrific is a Rails Engine plugin that makes it easy to filter, search, and sort your ActiveRecord lists.","fork":true,"url":"https://api.github.com/repos/alankessler/filterrific","forks_url":"https://api.github.com/repos/alankessler/filterrific/forks","keys_url":"https://api.github.com/repos/alankessler/filterrific/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alankessler/filterrific/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alankessler/filterrific/teams","hooks_url":"https://api.github.com/repos/alankessler/filterrific/hooks","issue_events_url":"https://api.github.com/repos/alankessler/filterrific/issues/events{/number}","events_url":"https://api.github.com/repos/alankessler/filterrific/events","assignees_url":"https://api.github.com/repos/alankessler/filterrific/assignees{/user}","branches_url":"https://api.github.com/repos/alankessler/filterrific/branches{/branch}","tags_url":"https://api.github.com/repos/alankessler/filterrific/tags","blobs_url":"https://api.github.com/repos/alankessler/filterrific/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alankessler/filterrific/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alankessler/filterrific/git/refs{/sha}","trees_url":"https://api.github.com/repos/alankessler/filterrific/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alankessler/filterrific/statuses/{sha}","languages_url":"https://api.github.com/repos/alankessler/filterrific/languages","stargazers_url":"https://api.github.com/repos/alankessler/filterrific/stargazers","contributors_url":"https://api.github.com/repos/alankessler/filterrific/contributors","subscribers_url":"https://api.github.com/repos/alankessler/filterrific/subscribers","subscription_url":"https://api.github.com/repos/alankessler/filterrific/subscription","commits_url":"https://api.github.com/repos/alankessler/filterrific/commits{/sha}","git_commits_url":"https://api.github.com/repos/alankessler/filterrific/git/commits{/sha}","comments_url":"https://api.github.com/repos/alankessler/filterrific/comments{/number}","issue_comment_url":"https://api.github.com/repos/alankessler/filterrific/issues/comments{/number}","contents_url":"https://api.github.com/repos/alankessler/filterrific/contents/{+path}","compare_url":"https://api.github.com/repos/alankessler/filterrific/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alankessler/filterrific/merges","archive_url":"https://api.github.com/repos/alankessler/filterrific/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alankessler/filterrific/downloads","issues_url":"https://api.github.com/repos/alankessler/filterrific/issues{/number}","pulls_url":"https://api.github.com/repos/alankessler/filterrific/pulls{/number}","milestones_url":"https://api.github.com/repos/alankessler/filterrific/milestones{/number}","notifications_url":"https://api.github.com/repos/alankessler/filterrific/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alankessler/filterrific/labels{/name}","releases_url":"https://api.github.com/repos/alankessler/filterrific/releases{/id}","created_at":"2015-03-23T16:17:52Z","updated_at":"2015-04-09T00:42:50Z","pushed_at":"2015-04-09T00:42:50Z","git_url":"git://github.com/alankessler/filterrific.git","ssh_url":"git@github.com:alankessler/filterrific.git","clone_url":"https://github.com/alankessler/filterrific.git","svn_url":"https://github.com/alankessler/filterrific","homepage":"http://filterrific.clearcove.ca","size":1000,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhund:master","ref":"master","sha":"47445e7d8a785a2d5a1c499ac697649ae73aa321","user":{"login":"jhund","id":4181,"avatar_url":"https://avatars.githubusercontent.com/u/4181?v=3","gravatar_id":"","url":"https://api.github.com/users/jhund","html_url":"https://github.com/jhund","followers_url":"https://api.github.com/users/jhund/followers","following_url":"https://api.github.com/users/jhund/following{/other_user}","gists_url":"https://api.github.com/users/jhund/gists{/gist_id}","starred_url":"https://api.github.com/users/jhund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhund/subscriptions","organizations_url":"https://api.github.com/users/jhund/orgs","repos_url":"https://api.github.com/users/jhund/repos","events_url":"https://api.github.com/users/jhund/events{/privacy}","received_events_url":"https://api.github.com/users/jhund/received_events","type":"User","site_admin":false},"repo":{"id":519395,"name":"filterrific","full_name":"jhund/filterrific","owner":{"login":"jhund","id":4181,"avatar_url":"https://avatars.githubusercontent.com/u/4181?v=3","gravatar_id":"","url":"https://api.github.com/users/jhund","html_url":"https://github.com/jhund","followers_url":"https://api.github.com/users/jhund/followers","following_url":"https://api.github.com/users/jhund/following{/other_user}","gists_url":"https://api.github.com/users/jhund/gists{/gist_id}","starred_url":"https://api.github.com/users/jhund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhund/subscriptions","organizations_url":"https://api.github.com/users/jhund/orgs","repos_url":"https://api.github.com/users/jhund/repos","events_url":"https://api.github.com/users/jhund/events{/privacy}","received_events_url":"https://api.github.com/users/jhund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhund/filterrific","description":"Filterrific is a Rails Engine plugin that makes it easy to filter, search, and sort your ActiveRecord lists.","fork":false,"url":"https://api.github.com/repos/jhund/filterrific","forks_url":"https://api.github.com/repos/jhund/filterrific/forks","keys_url":"https://api.github.com/repos/jhund/filterrific/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhund/filterrific/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhund/filterrific/teams","hooks_url":"https://api.github.com/repos/jhund/filterrific/hooks","issue_events_url":"https://api.github.com/repos/jhund/filterrific/issues/events{/number}","events_url":"https://api.github.com/repos/jhund/filterrific/events","assignees_url":"https://api.github.com/repos/jhund/filterrific/assignees{/user}","branches_url":"https://api.github.com/repos/jhund/filterrific/branches{/branch}","tags_url":"https://api.github.com/repos/jhund/filterrific/tags","blobs_url":"https://api.github.com/repos/jhund/filterrific/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhund/filterrific/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhund/filterrific/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhund/filterrific/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhund/filterrific/statuses/{sha}","languages_url":"https://api.github.com/repos/jhund/filterrific/languages","stargazers_url":"https://api.github.com/repos/jhund/filterrific/stargazers","contributors_url":"https://api.github.com/repos/jhund/filterrific/contributors","subscribers_url":"https://api.github.com/repos/jhund/filterrific/subscribers","subscription_url":"https://api.github.com/repos/jhund/filterrific/subscription","commits_url":"https://api.github.com/repos/jhund/filterrific/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhund/filterrific/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhund/filterrific/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhund/filterrific/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhund/filterrific/contents/{+path}","compare_url":"https://api.github.com/repos/jhund/filterrific/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhund/filterrific/merges","archive_url":"https://api.github.com/repos/jhund/filterrific/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhund/filterrific/downloads","issues_url":"https://api.github.com/repos/jhund/filterrific/issues{/number}","pulls_url":"https://api.github.com/repos/jhund/filterrific/pulls{/number}","milestones_url":"https://api.github.com/repos/jhund/filterrific/milestones{/number}","notifications_url":"https://api.github.com/repos/jhund/filterrific/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhund/filterrific/labels{/name}","releases_url":"https://api.github.com/repos/jhund/filterrific/releases{/id}","created_at":"2010-02-15T21:51:48Z","updated_at":"2015-04-07T16:16:48Z","pushed_at":"2015-04-09T04:05:32Z","git_url":"git://github.com/jhund/filterrific.git","ssh_url":"git@github.com:jhund/filterrific.git","clone_url":"https://github.com/jhund/filterrific.git","svn_url":"https://github.com/jhund/filterrific","homepage":"http://filterrific.clearcove.ca","size":1529,"stargazers_count":84,"watchers_count":84,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":4,"forks":16,"open_issues":4,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhund/filterrific/pulls/44"},"html":{"href":"https://github.com/jhund/filterrific/pull/44"},"issue":{"href":"https://api.github.com/repos/jhund/filterrific/issues/44"},"comments":{"href":"https://api.github.com/repos/jhund/filterrific/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/jhund/filterrific/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/jhund/filterrific/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhund/filterrific/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/jhund/filterrific/statuses/65006ad01e56e21637a981d37bd1f00beb35d6ae"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jhund","id":4181,"avatar_url":"https://avatars.githubusercontent.com/u/4181?v=3","gravatar_id":"","url":"https://api.github.com/users/jhund","html_url":"https://github.com/jhund","followers_url":"https://api.github.com/users/jhund/followers","following_url":"https://api.github.com/users/jhund/following{/other_user}","gists_url":"https://api.github.com/users/jhund/gists{/gist_id}","starred_url":"https://api.github.com/users/jhund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhund/subscriptions","organizations_url":"https://api.github.com/users/jhund/orgs","repos_url":"https://api.github.com/users/jhund/repos","events_url":"https://api.github.com/users/jhund/events{/privacy}","received_events_url":"https://api.github.com/users/jhund/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":2,"deletions":1,"changed_files":1}}