{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/39322427","id":39322427,"diff_hunk":"@@ -481,30 +466,28 @@ public HashJoinProbe setupHashJoinProbe() throws ClassTransformationException, I\n           outputType = inputType;\n         }\n \n-        ValueVector v = container.addOrGet(MaterializedField.create(vv.getField().getPath(), outputType));\n+        final ValueVector v = container.addOrGet(MaterializedField.create(vv.getField().getPath(), outputType));\n         if (v instanceof AbstractContainerVector) {\n           vv.getValueVector().makeTransferPair(v);\n           v.clear();\n         }\n \n-        JVar inVV = g.declareVectorValueSetupAndMember(\"probeBatch\", new TypedFieldId(inputType, false, fieldId));\n-        JVar outVV = g.declareVectorValueSetupAndMember(\"outgoing\", new TypedFieldId(outputType, false, outputFieldId));\n+        final JVar inVV = g.declareVectorValueSetupAndMember(\"probeBatch\", new TypedFieldId(inputType, false, fieldId));\n+        final JVar outVV = g.declareVectorValueSetupAndMember(\"outgoing\", new TypedFieldId(outputType, false, outputFieldId));\n \n         g.getEvalBlock().add(outVV.invoke(\"copyFromSafe\").arg(probeIndex).arg(outIndex).arg(inVV));\n \n         fieldId++;\n         outputFieldId++;\n       }\n-      recordCount = left.getRecordCount();\n     }\n \n-    HashJoinProbe hj = context.getImplementationClass(cg);\n-\n+    final HashJoinProbe hj = context.getImplementationClass(cg);","path":"exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java","position":235,"original_position":235,"commit_id":"baca735260a8f163df516f5174774461cf303661","original_commit_id":"baca735260a8f163df516f5174774461cf303661","user":{"login":"adeneche","id":8422943,"avatar_url":"https://avatars.githubusercontent.com/u/8422943?v=3","gravatar_id":"","url":"https://api.github.com/users/adeneche","html_url":"https://github.com/adeneche","followers_url":"https://api.github.com/users/adeneche/followers","following_url":"https://api.github.com/users/adeneche/following{/other_user}","gists_url":"https://api.github.com/users/adeneche/gists{/gist_id}","starred_url":"https://api.github.com/users/adeneche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeneche/subscriptions","organizations_url":"https://api.github.com/users/adeneche/orgs","repos_url":"https://api.github.com/users/adeneche/repos","events_url":"https://api.github.com/users/adeneche/events{/privacy}","received_events_url":"https://api.github.com/users/adeneche/received_events","type":"User","site_admin":false},"body":"you can also change this to:\r\n```\r\nreturn context.getImplementationClass(cg);\r\n```","created_at":"2015-09-11T21:58:17Z","updated_at":"2015-09-11T21:58:17Z","html_url":"https://github.com/apache/drill/pull/133#discussion_r39322427","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/133","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/39322427"},"html":{"href":"https://github.com/apache/drill/pull/133#discussion_r39322427"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/133","id":43354166,"html_url":"https://github.com/apache/drill/pull/133","diff_url":"https://github.com/apache/drill/pull/133.diff","patch_url":"https://github.com/apache/drill/pull/133.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/133","number":133,"state":"open","locked":false,"title":"DRILL-1942-hygiene:","user":{"login":"cwestin","id":462058,"avatar_url":"https://avatars.githubusercontent.com/u/462058?v=3","gravatar_id":"","url":"https://api.github.com/users/cwestin","html_url":"https://github.com/cwestin","followers_url":"https://api.github.com/users/cwestin/followers","following_url":"https://api.github.com/users/cwestin/following{/other_user}","gists_url":"https://api.github.com/users/cwestin/gists{/gist_id}","starred_url":"https://api.github.com/users/cwestin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwestin/subscriptions","organizations_url":"https://api.github.com/users/cwestin/orgs","repos_url":"https://api.github.com/users/cwestin/repos","events_url":"https://api.github.com/users/cwestin/events{/privacy}","received_events_url":"https://api.github.com/users/cwestin/received_events","type":"User","site_admin":false},"body":"DRILL-1942-hygiene (another preparatory patch):\r\n    - add AutoCloseable to some classes\r\n    - minor fixes\r\n    - formatting\r\n\r\nUnit tests pass\r\nRegression suite passed except for some window function queries (this branch needs to get rebased to pick up that code), and the known fragment distribution timeout.","created_at":"2015-08-26T00:59:19Z","updated_at":"2015-09-11T21:58:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"544a63cfd265d94c7d78f65fb7661fc72fa1bb4d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/133/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/133/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/133/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/baca735260a8f163df516f5174774461cf303661","head":{"label":"cwestin:hygiene-beta","ref":"hygiene-beta","sha":"baca735260a8f163df516f5174774461cf303661","user":{"login":"cwestin","id":462058,"avatar_url":"https://avatars.githubusercontent.com/u/462058?v=3","gravatar_id":"","url":"https://api.github.com/users/cwestin","html_url":"https://github.com/cwestin","followers_url":"https://api.github.com/users/cwestin/followers","following_url":"https://api.github.com/users/cwestin/following{/other_user}","gists_url":"https://api.github.com/users/cwestin/gists{/gist_id}","starred_url":"https://api.github.com/users/cwestin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwestin/subscriptions","organizations_url":"https://api.github.com/users/cwestin/orgs","repos_url":"https://api.github.com/users/cwestin/repos","events_url":"https://api.github.com/users/cwestin/events{/privacy}","received_events_url":"https://api.github.com/users/cwestin/received_events","type":"User","site_admin":false},"repo":{"id":26245223,"name":"incubator-drill","full_name":"cwestin/incubator-drill","owner":{"login":"cwestin","id":462058,"avatar_url":"https://avatars.githubusercontent.com/u/462058?v=3","gravatar_id":"","url":"https://api.github.com/users/cwestin","html_url":"https://github.com/cwestin","followers_url":"https://api.github.com/users/cwestin/followers","following_url":"https://api.github.com/users/cwestin/following{/other_user}","gists_url":"https://api.github.com/users/cwestin/gists{/gist_id}","starred_url":"https://api.github.com/users/cwestin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwestin/subscriptions","organizations_url":"https://api.github.com/users/cwestin/orgs","repos_url":"https://api.github.com/users/cwestin/repos","events_url":"https://api.github.com/users/cwestin/events{/privacy}","received_events_url":"https://api.github.com/users/cwestin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cwestin/incubator-drill","description":"Mirror of Apache Drill (Incubating)","fork":true,"url":"https://api.github.com/repos/cwestin/incubator-drill","forks_url":"https://api.github.com/repos/cwestin/incubator-drill/forks","keys_url":"https://api.github.com/repos/cwestin/incubator-drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cwestin/incubator-drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cwestin/incubator-drill/teams","hooks_url":"https://api.github.com/repos/cwestin/incubator-drill/hooks","issue_events_url":"https://api.github.com/repos/cwestin/incubator-drill/issues/events{/number}","events_url":"https://api.github.com/repos/cwestin/incubator-drill/events","assignees_url":"https://api.github.com/repos/cwestin/incubator-drill/assignees{/user}","branches_url":"https://api.github.com/repos/cwestin/incubator-drill/branches{/branch}","tags_url":"https://api.github.com/repos/cwestin/incubator-drill/tags","blobs_url":"https://api.github.com/repos/cwestin/incubator-drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cwestin/incubator-drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cwestin/incubator-drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/cwestin/incubator-drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cwestin/incubator-drill/statuses/{sha}","languages_url":"https://api.github.com/repos/cwestin/incubator-drill/languages","stargazers_url":"https://api.github.com/repos/cwestin/incubator-drill/stargazers","contributors_url":"https://api.github.com/repos/cwestin/incubator-drill/contributors","subscribers_url":"https://api.github.com/repos/cwestin/incubator-drill/subscribers","subscription_url":"https://api.github.com/repos/cwestin/incubator-drill/subscription","commits_url":"https://api.github.com/repos/cwestin/incubator-drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/cwestin/incubator-drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/cwestin/incubator-drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/cwestin/incubator-drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/cwestin/incubator-drill/contents/{+path}","compare_url":"https://api.github.com/repos/cwestin/incubator-drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cwestin/incubator-drill/merges","archive_url":"https://api.github.com/repos/cwestin/incubator-drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cwestin/incubator-drill/downloads","issues_url":"https://api.github.com/repos/cwestin/incubator-drill/issues{/number}","pulls_url":"https://api.github.com/repos/cwestin/incubator-drill/pulls{/number}","milestones_url":"https://api.github.com/repos/cwestin/incubator-drill/milestones{/number}","notifications_url":"https://api.github.com/repos/cwestin/incubator-drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cwestin/incubator-drill/labels{/name}","releases_url":"https://api.github.com/repos/cwestin/incubator-drill/releases{/id}","created_at":"2014-11-05T23:47:45Z","updated_at":"2015-02-13T21:50:28Z","pushed_at":"2015-09-11T02:50:26Z","git_url":"git://github.com/cwestin/incubator-drill.git","ssh_url":"git@github.com:cwestin/incubator-drill.git","clone_url":"https://github.com/cwestin/incubator-drill.git","svn_url":"https://github.com/cwestin/incubator-drill","homepage":null,"size":32642,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0686bc23e8fbbd14fd3bf852893449ef8552439d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"name":"drill","full_name":"apache/drill","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/drill","description":"Mirror of Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","created_at":"2012-09-05T07:00:26Z","updated_at":"2015-09-10T12:54:26Z","pushed_at":"2015-09-11T20:16:22Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":45018,"stargazers_count":478,"watchers_count":478,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":305,"mirror_url":"git://git.apache.org/incubator-drill.git","open_issues_count":34,"forks":305,"open_issues":34,"watchers":478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/133"},"html":{"href":"https://github.com/apache/drill/pull/133"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/133"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/baca735260a8f163df516f5174774461cf303661"}}}}