{"action":"created","issue":{"url":"https://api.github.com/repos/sasstools/sass-lint/issues/88","labels_url":"https://api.github.com/repos/sasstools/sass-lint/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/sasstools/sass-lint/issues/88/comments","events_url":"https://api.github.com/repos/sasstools/sass-lint/issues/88/events","html_url":"https://github.com/sasstools/sass-lint/pull/88","id":104675766,"number":88,"title":"Update mixin-before-declaration rule fix #80","user":{"login":"DanPurdy","id":1386054,"avatar_url":"https://avatars.githubusercontent.com/u/1386054?v=3","gravatar_id":"","url":"https://api.github.com/users/DanPurdy","html_url":"https://github.com/DanPurdy","followers_url":"https://api.github.com/users/DanPurdy/followers","following_url":"https://api.github.com/users/DanPurdy/following{/other_user}","gists_url":"https://api.github.com/users/DanPurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/DanPurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanPurdy/subscriptions","organizations_url":"https://api.github.com/users/DanPurdy/orgs","repos_url":"https://api.github.com/users/DanPurdy/repos","events_url":"https://api.github.com/users/DanPurdy/events{/privacy}","received_events_url":"https://api.github.com/users/DanPurdy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sasstools/sass-lint/labels/cleanup","name":"cleanup","color":"FFD791"},{"url":"https://api.github.com/repos/sasstools/sass-lint/labels/ready%20for%20review","name":"ready for review","color":"DB2780"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/sasstools/sass-lint/milestones/4","html_url":"https://github.com/sasstools/sass-lint/milestones/1.2.0","labels_url":"https://api.github.com/repos/sasstools/sass-lint/milestones/4/labels","id":1282728,"number":4,"title":"1.2.0","description":"Bug fixes and doc updates","creator":{"login":"Snugug","id":377188,"avatar_url":"https://avatars.githubusercontent.com/u/377188?v=3","gravatar_id":"","url":"https://api.github.com/users/Snugug","html_url":"https://github.com/Snugug","followers_url":"https://api.github.com/users/Snugug/followers","following_url":"https://api.github.com/users/Snugug/following{/other_user}","gists_url":"https://api.github.com/users/Snugug/gists{/gist_id}","starred_url":"https://api.github.com/users/Snugug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snugug/subscriptions","organizations_url":"https://api.github.com/users/Snugug/orgs","repos_url":"https://api.github.com/users/Snugug/repos","events_url":"https://api.github.com/users/Snugug/events{/privacy}","received_events_url":"https://api.github.com/users/Snugug/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":7,"state":"open","created_at":"2015-08-31T19:54:49Z","updated_at":"2015-09-03T19:22:05Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-09-03T12:02:53Z","updated_at":"2015-09-03T20:35:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sasstools/sass-lint/pulls/88","html_url":"https://github.com/sasstools/sass-lint/pull/88","diff_url":"https://github.com/sasstools/sass-lint/pull/88.diff","patch_url":"https://github.com/sasstools/sass-lint/pull/88.patch"},"body":"The current mixin before declaration rule was acting strangely due to the way Gonzales is passing it's node counter value, I rewrote the rule to take into account a 'depth' value when traversing across embedded (can't think of the right word!) rules.\r\n\r\nIt first looks for include statements and then traverses only the parent element so it's a little easier to keep track of where we are. It then looks for a ruleset block in order to increment depth.\r\n\r\nAlso added some more test cases as brought up in #80 and added some tests for passing in values to the exclude property.\r\n\r\nHopefully this is ok to rewrite?\r\n\r\nfixes #80 \r\n\r\nDCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com"},"comment":{"url":"https://api.github.com/repos/sasstools/sass-lint/issues/comments/137567335","html_url":"https://github.com/sasstools/sass-lint/pull/88#issuecomment-137567335","issue_url":"https://api.github.com/repos/sasstools/sass-lint/issues/88","id":137567335,"user":{"login":"bgriffith","id":2854338,"avatar_url":"https://avatars.githubusercontent.com/u/2854338?v=3","gravatar_id":"","url":"https://api.github.com/users/bgriffith","html_url":"https://github.com/bgriffith","followers_url":"https://api.github.com/users/bgriffith/followers","following_url":"https://api.github.com/users/bgriffith/following{/other_user}","gists_url":"https://api.github.com/users/bgriffith/gists{/gist_id}","starred_url":"https://api.github.com/users/bgriffith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgriffith/subscriptions","organizations_url":"https://api.github.com/users/bgriffith/orgs","repos_url":"https://api.github.com/users/bgriffith/repos","events_url":"https://api.github.com/users/bgriffith/events{/privacy}","received_events_url":"https://api.github.com/users/bgriffith/received_events","type":"User","site_admin":false},"created_at":"2015-09-03T20:35:38Z","updated_at":"2015-09-03T20:35:38Z","body":"Let's keep a standard. We're using it throughout. "}}