{"action":"opened","number":21,"pull_request":{"url":"https://api.github.com/repos/jrudolph/perf-map-agent/pulls/21","id":49403103,"html_url":"https://github.com/jrudolph/perf-map-agent/pull/21","diff_url":"https://github.com/jrudolph/perf-map-agent/pull/21.diff","patch_url":"https://github.com/jrudolph/perf-map-agent/pull/21.patch","issue_url":"https://api.github.com/repos/jrudolph/perf-map-agent/issues/21","number":21,"state":"open","locked":false,"title":"Bug fixes and output formatting","user":{"login":"nitsanw","id":2692655,"avatar_url":"https://avatars.githubusercontent.com/u/2692655?v=3","gravatar_id":"","url":"https://api.github.com/users/nitsanw","html_url":"https://github.com/nitsanw","followers_url":"https://api.github.com/users/nitsanw/followers","following_url":"https://api.github.com/users/nitsanw/following{/other_user}","gists_url":"https://api.github.com/users/nitsanw/gists{/gist_id}","starred_url":"https://api.github.com/users/nitsanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitsanw/subscriptions","organizations_url":"https://api.github.com/users/nitsanw/orgs","repos_url":"https://api.github.com/users/nitsanw/repos","events_url":"https://api.github.com/users/nitsanw/events{/privacy}","received_events_url":"https://api.github.com/users/nitsanw/received_events","type":"User","site_admin":false},"body":"Hi,\r\nThis is a bit of a mixed bag, so feel free to cherry pick the bits you find most relevant.\r\nThe most important aspects are:\r\n1. Fix a bug in the inlined address range computation where the range was assigned to the wrong method.\r\n2. Error handling for JVMTI calls (only in method signature, the same pattern needs applying to all JVMTI interactions).\r\n\r\nIn addition I added some comments, renamed variables for clarity (I think), and added a more compact format for inlined methods printing.\r\nHappy to have a discussion to make the PR more palatable. I would like to improve formatting further and settle on good way to configure it, but not sure how important backwards compatibility is.\r\nThanks,\r\nNitsan","created_at":"2015-11-02T07:51:02Z","updated_at":"2015-11-02T07:51:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jrudolph/perf-map-agent/pulls/21/commits","review_comments_url":"https://api.github.com/repos/jrudolph/perf-map-agent/pulls/21/comments","review_comment_url":"https://api.github.com/repos/jrudolph/perf-map-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jrudolph/perf-map-agent/issues/21/comments","statuses_url":"https://api.github.com/repos/jrudolph/perf-map-agent/statuses/0f421f5d7d64a96a0dad2484e68ad600abdc5f82","head":{"label":"nitsanw:master","ref":"master","sha":"0f421f5d7d64a96a0dad2484e68ad600abdc5f82","user":{"login":"nitsanw","id":2692655,"avatar_url":"https://avatars.githubusercontent.com/u/2692655?v=3","gravatar_id":"","url":"https://api.github.com/users/nitsanw","html_url":"https://github.com/nitsanw","followers_url":"https://api.github.com/users/nitsanw/followers","following_url":"https://api.github.com/users/nitsanw/following{/other_user}","gists_url":"https://api.github.com/users/nitsanw/gists{/gist_id}","starred_url":"https://api.github.com/users/nitsanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitsanw/subscriptions","organizations_url":"https://api.github.com/users/nitsanw/orgs","repos_url":"https://api.github.com/users/nitsanw/repos","events_url":"https://api.github.com/users/nitsanw/events{/privacy}","received_events_url":"https://api.github.com/users/nitsanw/received_events","type":"User","site_admin":false},"repo":{"id":43636289,"name":"perf-map-agent","full_name":"nitsanw/perf-map-agent","owner":{"login":"nitsanw","id":2692655,"avatar_url":"https://avatars.githubusercontent.com/u/2692655?v=3","gravatar_id":"","url":"https://api.github.com/users/nitsanw","html_url":"https://github.com/nitsanw","followers_url":"https://api.github.com/users/nitsanw/followers","following_url":"https://api.github.com/users/nitsanw/following{/other_user}","gists_url":"https://api.github.com/users/nitsanw/gists{/gist_id}","starred_url":"https://api.github.com/users/nitsanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitsanw/subscriptions","organizations_url":"https://api.github.com/users/nitsanw/orgs","repos_url":"https://api.github.com/users/nitsanw/repos","events_url":"https://api.github.com/users/nitsanw/events{/privacy}","received_events_url":"https://api.github.com/users/nitsanw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nitsanw/perf-map-agent","description":"A java agent to generate method mappings to use with the linux `perf` tool","fork":true,"url":"https://api.github.com/repos/nitsanw/perf-map-agent","forks_url":"https://api.github.com/repos/nitsanw/perf-map-agent/forks","keys_url":"https://api.github.com/repos/nitsanw/perf-map-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nitsanw/perf-map-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nitsanw/perf-map-agent/teams","hooks_url":"https://api.github.com/repos/nitsanw/perf-map-agent/hooks","issue_events_url":"https://api.github.com/repos/nitsanw/perf-map-agent/issues/events{/number}","events_url":"https://api.github.com/repos/nitsanw/perf-map-agent/events","assignees_url":"https://api.github.com/repos/nitsanw/perf-map-agent/assignees{/user}","branches_url":"https://api.github.com/repos/nitsanw/perf-map-agent/branches{/branch}","tags_url":"https://api.github.com/repos/nitsanw/perf-map-agent/tags","blobs_url":"https://api.github.com/repos/nitsanw/perf-map-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nitsanw/perf-map-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nitsanw/perf-map-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/nitsanw/perf-map-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nitsanw/perf-map-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/nitsanw/perf-map-agent/languages","stargazers_url":"https://api.github.com/repos/nitsanw/perf-map-agent/stargazers","contributors_url":"https://api.github.com/repos/nitsanw/perf-map-agent/contributors","subscribers_url":"https://api.github.com/repos/nitsanw/perf-map-agent/subscribers","subscription_url":"https://api.github.com/repos/nitsanw/perf-map-agent/subscription","commits_url":"https://api.github.com/repos/nitsanw/perf-map-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/nitsanw/perf-map-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/nitsanw/perf-map-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/nitsanw/perf-map-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/nitsanw/perf-map-agent/contents/{+path}","compare_url":"https://api.github.com/repos/nitsanw/perf-map-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nitsanw/perf-map-agent/merges","archive_url":"https://api.github.com/repos/nitsanw/perf-map-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nitsanw/perf-map-agent/downloads","issues_url":"https://api.github.com/repos/nitsanw/perf-map-agent/issues{/number}","pulls_url":"https://api.github.com/repos/nitsanw/perf-map-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/nitsanw/perf-map-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/nitsanw/perf-map-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nitsanw/perf-map-agent/labels{/name}","releases_url":"https://api.github.com/repos/nitsanw/perf-map-agent/releases{/id}","created_at":"2015-10-04T12:47:47Z","updated_at":"2015-10-04T12:47:48Z","pushed_at":"2015-11-02T07:45:27Z","git_url":"git://github.com/nitsanw/perf-map-agent.git","ssh_url":"git@github.com:nitsanw/perf-map-agent.git","clone_url":"https://github.com/nitsanw/perf-map-agent.git","svn_url":"https://github.com/nitsanw/perf-map-agent","homepage":null,"size":281,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jrudolph:master","ref":"master","sha":"3acf8f487c444266eaaa8037b5a6de8573347313","user":{"login":"jrudolph","id":9868,"avatar_url":"https://avatars.githubusercontent.com/u/9868?v=3","gravatar_id":"","url":"https://api.github.com/users/jrudolph","html_url":"https://github.com/jrudolph","followers_url":"https://api.github.com/users/jrudolph/followers","following_url":"https://api.github.com/users/jrudolph/following{/other_user}","gists_url":"https://api.github.com/users/jrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/jrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrudolph/subscriptions","organizations_url":"https://api.github.com/users/jrudolph/orgs","repos_url":"https://api.github.com/users/jrudolph/repos","events_url":"https://api.github.com/users/jrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/jrudolph/received_events","type":"User","site_admin":false},"repo":{"id":6813325,"name":"perf-map-agent","full_name":"jrudolph/perf-map-agent","owner":{"login":"jrudolph","id":9868,"avatar_url":"https://avatars.githubusercontent.com/u/9868?v=3","gravatar_id":"","url":"https://api.github.com/users/jrudolph","html_url":"https://github.com/jrudolph","followers_url":"https://api.github.com/users/jrudolph/followers","following_url":"https://api.github.com/users/jrudolph/following{/other_user}","gists_url":"https://api.github.com/users/jrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/jrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrudolph/subscriptions","organizations_url":"https://api.github.com/users/jrudolph/orgs","repos_url":"https://api.github.com/users/jrudolph/repos","events_url":"https://api.github.com/users/jrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/jrudolph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrudolph/perf-map-agent","description":"A java agent to generate method mappings to use with the linux `perf` tool","fork":false,"url":"https://api.github.com/repos/jrudolph/perf-map-agent","forks_url":"https://api.github.com/repos/jrudolph/perf-map-agent/forks","keys_url":"https://api.github.com/repos/jrudolph/perf-map-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrudolph/perf-map-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrudolph/perf-map-agent/teams","hooks_url":"https://api.github.com/repos/jrudolph/perf-map-agent/hooks","issue_events_url":"https://api.github.com/repos/jrudolph/perf-map-agent/issues/events{/number}","events_url":"https://api.github.com/repos/jrudolph/perf-map-agent/events","assignees_url":"https://api.github.com/repos/jrudolph/perf-map-agent/assignees{/user}","branches_url":"https://api.github.com/repos/jrudolph/perf-map-agent/branches{/branch}","tags_url":"https://api.github.com/repos/jrudolph/perf-map-agent/tags","blobs_url":"https://api.github.com/repos/jrudolph/perf-map-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrudolph/perf-map-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrudolph/perf-map-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrudolph/perf-map-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrudolph/perf-map-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/jrudolph/perf-map-agent/languages","stargazers_url":"https://api.github.com/repos/jrudolph/perf-map-agent/stargazers","contributors_url":"https://api.github.com/repos/jrudolph/perf-map-agent/contributors","subscribers_url":"https://api.github.com/repos/jrudolph/perf-map-agent/subscribers","subscription_url":"https://api.github.com/repos/jrudolph/perf-map-agent/subscription","commits_url":"https://api.github.com/repos/jrudolph/perf-map-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrudolph/perf-map-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrudolph/perf-map-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrudolph/perf-map-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrudolph/perf-map-agent/contents/{+path}","compare_url":"https://api.github.com/repos/jrudolph/perf-map-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrudolph/perf-map-agent/merges","archive_url":"https://api.github.com/repos/jrudolph/perf-map-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrudolph/perf-map-agent/downloads","issues_url":"https://api.github.com/repos/jrudolph/perf-map-agent/issues{/number}","pulls_url":"https://api.github.com/repos/jrudolph/perf-map-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/jrudolph/perf-map-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/jrudolph/perf-map-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrudolph/perf-map-agent/labels{/name}","releases_url":"https://api.github.com/repos/jrudolph/perf-map-agent/releases{/id}","created_at":"2012-11-22T13:14:49Z","updated_at":"2015-11-01T22:43:08Z","pushed_at":"2015-10-31T11:01:15Z","git_url":"git://github.com/jrudolph/perf-map-agent.git","ssh_url":"git@github.com:jrudolph/perf-map-agent.git","clone_url":"https://github.com/jrudolph/perf-map-agent.git","svn_url":"https://github.com/jrudolph/perf-map-agent","homepage":null,"size":295,"stargazers_count":178,"watchers_count":178,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":4,"forks":33,"open_issues":4,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jrudolph/perf-map-agent/pulls/21"},"html":{"href":"https://github.com/jrudolph/perf-map-agent/pull/21"},"issue":{"href":"https://api.github.com/repos/jrudolph/perf-map-agent/issues/21"},"comments":{"href":"https://api.github.com/repos/jrudolph/perf-map-agent/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/jrudolph/perf-map-agent/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/jrudolph/perf-map-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jrudolph/perf-map-agent/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/jrudolph/perf-map-agent/statuses/0f421f5d7d64a96a0dad2484e68ad600abdc5f82"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":111,"deletions":47,"changed_files":1}}