{"action":"closed","number":184,"pull_request":{"url":"https://api.github.com/repos/rails/docrails/pulls/184","id":41979231,"html_url":"https://github.com/rails/docrails/pull/184","diff_url":"https://github.com/rails/docrails/pull/184.diff","patch_url":"https://github.com/rails/docrails/pull/184.patch","issue_url":"https://api.github.com/repos/rails/docrails/issues/184","number":184,"state":"closed","locked":false,"title":"Remove unnecessary/confusing dynamic coding","user":{"login":"skwp","id":1731,"avatar_url":"https://avatars.githubusercontent.com/u/1731?v=3","gravatar_id":"","url":"https://api.github.com/users/skwp","html_url":"https://github.com/skwp","followers_url":"https://api.github.com/users/skwp/followers","following_url":"https://api.github.com/users/skwp/following{/other_user}","gists_url":"https://api.github.com/users/skwp/gists{/gist_id}","starred_url":"https://api.github.com/users/skwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skwp/subscriptions","organizations_url":"https://api.github.com/users/skwp/orgs","repos_url":"https://api.github.com/users/skwp/repos","events_url":"https://api.github.com/users/skwp/events{/privacy}","received_events_url":"https://api.github.com/users/skwp/received_events","type":"User","site_admin":false},"body":"This is a critical security document and introducing fancy ruby tricks for string interpretation seems like clouding the issue. The cleaned up example should hopefully suffice. ","created_at":"2015-08-09T23:29:09Z","updated_at":"2015-08-09T23:30:48Z","closed_at":"2015-08-09T23:30:48Z","merged_at":null,"merge_commit_sha":"c6a3265b50467a9406ddd39acc15a7308a8e1018","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/docrails/pulls/184/commits","review_comments_url":"https://api.github.com/repos/rails/docrails/pulls/184/comments","review_comment_url":"https://api.github.com/repos/rails/docrails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/docrails/issues/184/comments","statuses_url":"https://api.github.com/repos/rails/docrails/statuses/e107de037fa48bbced715368523dc645cf893f27","head":{"label":"skwp:master","ref":"master","sha":"e107de037fa48bbced715368523dc645cf893f27","user":{"login":"skwp","id":1731,"avatar_url":"https://avatars.githubusercontent.com/u/1731?v=3","gravatar_id":"","url":"https://api.github.com/users/skwp","html_url":"https://github.com/skwp","followers_url":"https://api.github.com/users/skwp/followers","following_url":"https://api.github.com/users/skwp/following{/other_user}","gists_url":"https://api.github.com/users/skwp/gists{/gist_id}","starred_url":"https://api.github.com/users/skwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skwp/subscriptions","organizations_url":"https://api.github.com/users/skwp/orgs","repos_url":"https://api.github.com/users/skwp/repos","events_url":"https://api.github.com/users/skwp/events{/privacy}","received_events_url":"https://api.github.com/users/skwp/received_events","type":"User","site_admin":false},"repo":{"id":40454064,"name":"docrails","full_name":"skwp/docrails","owner":{"login":"skwp","id":1731,"avatar_url":"https://avatars.githubusercontent.com/u/1731?v=3","gravatar_id":"","url":"https://api.github.com/users/skwp","html_url":"https://github.com/skwp","followers_url":"https://api.github.com/users/skwp/followers","following_url":"https://api.github.com/users/skwp/following{/other_user}","gists_url":"https://api.github.com/users/skwp/gists{/gist_id}","starred_url":"https://api.github.com/users/skwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skwp/subscriptions","organizations_url":"https://api.github.com/users/skwp/orgs","repos_url":"https://api.github.com/users/skwp/repos","events_url":"https://api.github.com/users/skwp/events{/privacy}","received_events_url":"https://api.github.com/users/skwp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skwp/docrails","description":"Rails branch for quick doc fixes, please DO NOT OPEN PULL REQUESTS IN HERE","fork":true,"url":"https://api.github.com/repos/skwp/docrails","forks_url":"https://api.github.com/repos/skwp/docrails/forks","keys_url":"https://api.github.com/repos/skwp/docrails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skwp/docrails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skwp/docrails/teams","hooks_url":"https://api.github.com/repos/skwp/docrails/hooks","issue_events_url":"https://api.github.com/repos/skwp/docrails/issues/events{/number}","events_url":"https://api.github.com/repos/skwp/docrails/events","assignees_url":"https://api.github.com/repos/skwp/docrails/assignees{/user}","branches_url":"https://api.github.com/repos/skwp/docrails/branches{/branch}","tags_url":"https://api.github.com/repos/skwp/docrails/tags","blobs_url":"https://api.github.com/repos/skwp/docrails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skwp/docrails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skwp/docrails/git/refs{/sha}","trees_url":"https://api.github.com/repos/skwp/docrails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skwp/docrails/statuses/{sha}","languages_url":"https://api.github.com/repos/skwp/docrails/languages","stargazers_url":"https://api.github.com/repos/skwp/docrails/stargazers","contributors_url":"https://api.github.com/repos/skwp/docrails/contributors","subscribers_url":"https://api.github.com/repos/skwp/docrails/subscribers","subscription_url":"https://api.github.com/repos/skwp/docrails/subscription","commits_url":"https://api.github.com/repos/skwp/docrails/commits{/sha}","git_commits_url":"https://api.github.com/repos/skwp/docrails/git/commits{/sha}","comments_url":"https://api.github.com/repos/skwp/docrails/comments{/number}","issue_comment_url":"https://api.github.com/repos/skwp/docrails/issues/comments{/number}","contents_url":"https://api.github.com/repos/skwp/docrails/contents/{+path}","compare_url":"https://api.github.com/repos/skwp/docrails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skwp/docrails/merges","archive_url":"https://api.github.com/repos/skwp/docrails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skwp/docrails/downloads","issues_url":"https://api.github.com/repos/skwp/docrails/issues{/number}","pulls_url":"https://api.github.com/repos/skwp/docrails/pulls{/number}","milestones_url":"https://api.github.com/repos/skwp/docrails/milestones{/number}","notifications_url":"https://api.github.com/repos/skwp/docrails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skwp/docrails/labels{/name}","releases_url":"https://api.github.com/repos/skwp/docrails/releases{/id}","created_at":"2015-08-09T23:26:58Z","updated_at":"2015-08-09T23:27:08Z","pushed_at":"2015-08-09T23:28:48Z","git_url":"git://github.com/skwp/docrails.git","ssh_url":"git@github.com:skwp/docrails.git","clone_url":"https://github.com/skwp/docrails.git","svn_url":"https://github.com/skwp/docrails","homepage":"http://weblog.rubyonrails.org/2013/6/14/docrails-back-to-the-roots/","size":115011,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"9876a16904f817e11713bc85479dd70da1de454b","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":13992,"name":"docrails","full_name":"rails/docrails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/docrails","description":"Rails branch for quick doc fixes, please DO NOT OPEN PULL REQUESTS IN HERE","fork":false,"url":"https://api.github.com/repos/rails/docrails","forks_url":"https://api.github.com/repos/rails/docrails/forks","keys_url":"https://api.github.com/repos/rails/docrails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/docrails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/docrails/teams","hooks_url":"https://api.github.com/repos/rails/docrails/hooks","issue_events_url":"https://api.github.com/repos/rails/docrails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/docrails/events","assignees_url":"https://api.github.com/repos/rails/docrails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/docrails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/docrails/tags","blobs_url":"https://api.github.com/repos/rails/docrails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/docrails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/docrails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/docrails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/docrails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/docrails/languages","stargazers_url":"https://api.github.com/repos/rails/docrails/stargazers","contributors_url":"https://api.github.com/repos/rails/docrails/contributors","subscribers_url":"https://api.github.com/repos/rails/docrails/subscribers","subscription_url":"https://api.github.com/repos/rails/docrails/subscription","commits_url":"https://api.github.com/repos/rails/docrails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/docrails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/docrails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/docrails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/docrails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/docrails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/docrails/merges","archive_url":"https://api.github.com/repos/rails/docrails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/docrails/downloads","issues_url":"https://api.github.com/repos/rails/docrails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/docrails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/docrails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/docrails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/docrails/labels{/name}","releases_url":"https://api.github.com/repos/rails/docrails/releases{/id}","created_at":"2008-05-02T10:37:07Z","updated_at":"2015-08-04T12:50:55Z","pushed_at":"2015-08-09T23:29:10Z","git_url":"git://github.com/rails/docrails.git","ssh_url":"git@github.com:rails/docrails.git","clone_url":"https://github.com/rails/docrails.git","svn_url":"https://github.com/rails/docrails","homepage":"http://weblog.rubyonrails.org/2013/6/14/docrails-back-to-the-roots/","size":115011,"stargazers_count":962,"watchers_count":962,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":809,"mirror_url":null,"open_issues_count":3,"forks":809,"open_issues":3,"watchers":962,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/docrails/pulls/184"},"html":{"href":"https://github.com/rails/docrails/pull/184"},"issue":{"href":"https://api.github.com/repos/rails/docrails/issues/184"},"comments":{"href":"https://api.github.com/repos/rails/docrails/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/docrails/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/docrails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/docrails/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/rails/docrails/statuses/e107de037fa48bbced715368523dc645cf893f27"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":5,"changed_files":1}}