{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/30834784","id":30834784,"diff_hunk":"@@ -387,20 +387,60 @@ func describeDeployments(node *graph.DeploymentConfigNode, count int) []string {\n \treturn out\n }\n \n-func describeDeploymentStatus(deploy *kapi.ReplicationController) string {\n+func describeDeploymentStatus(deploy *kapi.ReplicationController, first bool) string {\n \ttimeAt := strings.ToLower(formatRelativeTime(deploy.CreationTimestamp.Time))\n \tstatus := deployutil.DeploymentStatusFor(deploy)\n \tversion := deployutil.DeploymentVersionFor(deploy)\n \tswitch status {\n \tcase deployapi.DeploymentStatusFailed:\n+\t\treason := deployutil.DeploymentStatusReasonFor(deploy)\n+\t\tif len(reason) > 0 {\n+\t\t\treason = fmt.Sprintf(\": %s\", reason)\n+\t\t}\n \t\t// TODO: encode fail time in the rc\n-\t\treturn fmt.Sprintf(\"#%d deployment failed %s ago\", version, timeAt)\n+\t\treturn fmt.Sprintf(\"#%d deployment failed %s ago%s%s\", version, timeAt, reason, describeDeploymentPodSummaryInline(deploy, false))\n \tcase deployapi.DeploymentStatusComplete:\n \t\t// TODO: pod status output\n-\t\treturn fmt.Sprintf(\"#%d deployed %s ago\", version, timeAt)\n+\t\treturn fmt.Sprintf(\"#%d deployed %s ago%s\", version, timeAt, describeDeploymentPodSummaryInline(deploy, first))\n+\tcase deployapi.DeploymentStatusRunning:\n+\t\treturn fmt.Sprintf(\"#%d deployment running for %s%s\", version, timeAt, describeDeploymentPodSummaryInline(deploy, false))\n \tdefault:\n-\t\treturn fmt.Sprintf(\"#%d deployment %s %s ago\", version, strings.ToLower(string(status)), timeAt)\n+\t\treturn fmt.Sprintf(\"#%d deployment %s %s ago%s\", version, strings.ToLower(string(status)), timeAt, describeDeploymentPodSummaryInline(deploy, false))\n+\t}\n+}\n+\n+func describeDeploymentPodSummaryInline(deploy *kapi.ReplicationController, showEmpty bool) string {\n+\ts := describeDeploymentPodSummary(deploy, showEmpty)\n+\tif len(s) == 0 {\n+\t\treturn s\n+\t}\n+\tchange := \"\"\n+\tif changing, ok := deployutil.DeploymentDesiredReplicas(deploy); ok {\n+\t\tswitch {\n+\t\tcase changing < deploy.Spec.Replicas:\n+\t\t\tchange = fmt.Sprintf(\" reducing to %d\", changing)\n+\t\tcase changing > deploy.Spec.Replicas:\n+\t\t\tchange = fmt.Sprintf(\" growing to %d\", changing)\n+\t\t}\n+\t}\n+\treturn fmt.Sprintf(\" - %s%s\", s, change)\n+}\n+\n+func describeDeploymentPodSummary(deploy *kapi.ReplicationController, showEmpty bool) string {\n+\tactual, requested := deploy.Status.Replicas, deploy.Spec.Replicas\n+\tif actual == requested {\n+\t\tif actual == 0 {","path":"pkg/cmd/cli/describe/projectstatus.go","position":70,"original_position":70,"commit_id":"848f3b209a7162ec5234830b5d2f2b818eb0efe8","original_commit_id":"848f3b209a7162ec5234830b5d2f2b818eb0efe8","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"body":"`switch`","created_at":"2015-05-21T18:54:09Z","updated_at":"2015-05-21T18:54:09Z","html_url":"https://github.com/openshift/origin/pull/2423#discussion_r30834784","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/2423","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/30834784"},"html":{"href":"https://github.com/openshift/origin/pull/2423#discussion_r30834784"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/2423"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/2423","id":35963161,"html_url":"https://github.com/openshift/origin/pull/2423","diff_url":"https://github.com/openshift/origin/pull/2423.diff","patch_url":"https://github.com/openshift/origin/pull/2423.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/2423","number":2423,"state":"open","locked":false,"title":"Project status should include some pod information","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"Including the desired state annotations for rolling update\n\n@fabianofranz review please","created_at":"2015-05-21T18:28:30Z","updated_at":"2015-05-21T18:54:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39b11077d24676eff568a0496990b2bb0403e749","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/2423/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/2423/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/2423/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/848f3b209a7162ec5234830b5d2f2b818eb0efe8","head":{"label":"smarterclayton:pods_to_status","ref":"pods_to_status","sha":"848f3b209a7162ec5234830b5d2f2b818eb0efe8","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"repo":{"id":22921364,"name":"origin","full_name":"smarterclayton/origin","owner":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smarterclayton/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/smarterclayton/origin","forks_url":"https://api.github.com/repos/smarterclayton/origin/forks","keys_url":"https://api.github.com/repos/smarterclayton/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smarterclayton/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smarterclayton/origin/teams","hooks_url":"https://api.github.com/repos/smarterclayton/origin/hooks","issue_events_url":"https://api.github.com/repos/smarterclayton/origin/issues/events{/number}","events_url":"https://api.github.com/repos/smarterclayton/origin/events","assignees_url":"https://api.github.com/repos/smarterclayton/origin/assignees{/user}","branches_url":"https://api.github.com/repos/smarterclayton/origin/branches{/branch}","tags_url":"https://api.github.com/repos/smarterclayton/origin/tags","blobs_url":"https://api.github.com/repos/smarterclayton/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smarterclayton/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smarterclayton/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/smarterclayton/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smarterclayton/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/smarterclayton/origin/languages","stargazers_url":"https://api.github.com/repos/smarterclayton/origin/stargazers","contributors_url":"https://api.github.com/repos/smarterclayton/origin/contributors","subscribers_url":"https://api.github.com/repos/smarterclayton/origin/subscribers","subscription_url":"https://api.github.com/repos/smarterclayton/origin/subscription","commits_url":"https://api.github.com/repos/smarterclayton/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/smarterclayton/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/smarterclayton/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/smarterclayton/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/smarterclayton/origin/contents/{+path}","compare_url":"https://api.github.com/repos/smarterclayton/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smarterclayton/origin/merges","archive_url":"https://api.github.com/repos/smarterclayton/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smarterclayton/origin/downloads","issues_url":"https://api.github.com/repos/smarterclayton/origin/issues{/number}","pulls_url":"https://api.github.com/repos/smarterclayton/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/smarterclayton/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/smarterclayton/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smarterclayton/origin/labels{/name}","releases_url":"https://api.github.com/repos/smarterclayton/origin/releases{/id}","created_at":"2014-08-13T15:49:23Z","updated_at":"2015-05-17T00:07:22Z","pushed_at":"2015-05-21T18:27:44Z","git_url":"git://github.com/smarterclayton/origin.git","ssh_url":"git@github.com:smarterclayton/origin.git","clone_url":"https://github.com/smarterclayton/origin.git","svn_url":"https://github.com/smarterclayton/origin","homepage":"https://openshift.github.io","size":107612,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"42878a840bb17b7b9c4c86742174e16b457b06b7","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-05-21T05:41:01Z","pushed_at":"2015-05-21T18:54:02Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":181635,"stargazers_count":428,"watchers_count":428,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":211,"mirror_url":null,"open_issues_count":223,"forks":211,"open_issues":223,"watchers":428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/2423"},"html":{"href":"https://github.com/openshift/origin/pull/2423"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/2423"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/2423/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/2423/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/2423/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/848f3b209a7162ec5234830b5d2f2b818eb0efe8"}}}}