{"action":"created","comment":{"url":"https://api.github.com/repos/geoext/geoext3/pulls/comments/32701367","id":32701367,"diff_hunk":"@@ -33,10 +34,14 @@ Ext.application({\n             })\n         });\n \n-        mapPanel = Ext.create('GeoExt.panel.Map', {\n+        mapComponent = Ext.create('GeoExt.component.Map', {\n+            map: olMap\n+        });\n+\n+        mapPanel = Ext.create('Ext.panel.Panel', {\n             title: 'GeoExt.data.model.print.Capability Example',\n-            map: olMap,\n-            region: 'center'\n+            region: 'center',","path":"examples/print/basic-mapfish.js","position":28,"original_position":28,"commit_id":"6ca22a4d0d3bd4e400a9622654ec7af67345e0be","original_commit_id":"6ca22a4d0d3bd4e400a9622654ec7af67345e0be","user":{"login":"marcjansen","id":227934,"avatar_url":"https://avatars.githubusercontent.com/u/227934?v=3","gravatar_id":"","url":"https://api.github.com/users/marcjansen","html_url":"https://github.com/marcjansen","followers_url":"https://api.github.com/users/marcjansen/followers","following_url":"https://api.github.com/users/marcjansen/following{/other_user}","gists_url":"https://api.github.com/users/marcjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/marcjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcjansen/subscriptions","organizations_url":"https://api.github.com/users/marcjansen/orgs","repos_url":"https://api.github.com/users/marcjansen/repos","events_url":"https://api.github.com/users/marcjansen/events{/privacy}","received_events_url":"https://api.github.com/users/marcjansen/received_events","type":"User","site_admin":false},"body":"missing `layout: 'fit',`, right?","created_at":"2015-06-18T06:10:42Z","updated_at":"2015-06-18T06:10:42Z","html_url":"https://github.com/geoext/geoext3/pull/5#discussion_r32701367","pull_request_url":"https://api.github.com/repos/geoext/geoext3/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/geoext/geoext3/pulls/comments/32701367"},"html":{"href":"https://github.com/geoext/geoext3/pull/5#discussion_r32701367"},"pull_request":{"href":"https://api.github.com/repos/geoext/geoext3/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/geoext/geoext3/pulls/5","id":37922773,"html_url":"https://github.com/geoext/geoext3/pull/5","diff_url":"https://github.com/geoext/geoext3/pull/5.diff","patch_url":"https://github.com/geoext/geoext3/pull/5.patch","issue_url":"https://api.github.com/repos/geoext/geoext3/issues/5","number":5,"state":"open","locked":false,"title":"changing the mappanel to extend from component -> mapcomponent","user":{"login":"weskamm","id":1381363,"avatar_url":"https://avatars.githubusercontent.com/u/1381363?v=3","gravatar_id":"","url":"https://api.github.com/users/weskamm","html_url":"https://github.com/weskamm","followers_url":"https://api.github.com/users/weskamm/followers","following_url":"https://api.github.com/users/weskamm/following{/other_user}","gists_url":"https://api.github.com/users/weskamm/gists{/gist_id}","starred_url":"https://api.github.com/users/weskamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weskamm/subscriptions","organizations_url":"https://api.github.com/users/weskamm/orgs","repos_url":"https://api.github.com/users/weskamm/repos","events_url":"https://api.github.com/users/weskamm/events{/privacy}","received_events_url":"https://api.github.com/users/weskamm/received_events","type":"User","site_admin":false},"body":"the map now extends from Ext.Component instead of Ext.panel.Panel to avoid overhead and gain more compatibility between modern and classic toolkits","created_at":"2015-06-17T16:54:03Z","updated_at":"2015-06-18T06:10:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6117238d9610674ca7f51104b4b26458a058f38","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geoext/geoext3/pulls/5/commits","review_comments_url":"https://api.github.com/repos/geoext/geoext3/pulls/5/comments","review_comment_url":"https://api.github.com/repos/geoext/geoext3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geoext/geoext3/issues/5/comments","statuses_url":"https://api.github.com/repos/geoext/geoext3/statuses/6ca22a4d0d3bd4e400a9622654ec7af67345e0be","head":{"label":"weskamm:mappanel2component","ref":"mappanel2component","sha":"6ca22a4d0d3bd4e400a9622654ec7af67345e0be","user":{"login":"weskamm","id":1381363,"avatar_url":"https://avatars.githubusercontent.com/u/1381363?v=3","gravatar_id":"","url":"https://api.github.com/users/weskamm","html_url":"https://github.com/weskamm","followers_url":"https://api.github.com/users/weskamm/followers","following_url":"https://api.github.com/users/weskamm/following{/other_user}","gists_url":"https://api.github.com/users/weskamm/gists{/gist_id}","starred_url":"https://api.github.com/users/weskamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weskamm/subscriptions","organizations_url":"https://api.github.com/users/weskamm/orgs","repos_url":"https://api.github.com/users/weskamm/repos","events_url":"https://api.github.com/users/weskamm/events{/privacy}","received_events_url":"https://api.github.com/users/weskamm/received_events","type":"User","site_admin":false},"repo":{"id":37602522,"name":"geoext3","full_name":"weskamm/geoext3","owner":{"login":"weskamm","id":1381363,"avatar_url":"https://avatars.githubusercontent.com/u/1381363?v=3","gravatar_id":"","url":"https://api.github.com/users/weskamm","html_url":"https://github.com/weskamm","followers_url":"https://api.github.com/users/weskamm/followers","following_url":"https://api.github.com/users/weskamm/following{/other_user}","gists_url":"https://api.github.com/users/weskamm/gists{/gist_id}","starred_url":"https://api.github.com/users/weskamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weskamm/subscriptions","organizations_url":"https://api.github.com/users/weskamm/orgs","repos_url":"https://api.github.com/users/weskamm/repos","events_url":"https://api.github.com/users/weskamm/events{/privacy}","received_events_url":"https://api.github.com/users/weskamm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weskamm/geoext3","description":"Work in progress, stay tuned...","fork":true,"url":"https://api.github.com/repos/weskamm/geoext3","forks_url":"https://api.github.com/repos/weskamm/geoext3/forks","keys_url":"https://api.github.com/repos/weskamm/geoext3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weskamm/geoext3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weskamm/geoext3/teams","hooks_url":"https://api.github.com/repos/weskamm/geoext3/hooks","issue_events_url":"https://api.github.com/repos/weskamm/geoext3/issues/events{/number}","events_url":"https://api.github.com/repos/weskamm/geoext3/events","assignees_url":"https://api.github.com/repos/weskamm/geoext3/assignees{/user}","branches_url":"https://api.github.com/repos/weskamm/geoext3/branches{/branch}","tags_url":"https://api.github.com/repos/weskamm/geoext3/tags","blobs_url":"https://api.github.com/repos/weskamm/geoext3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weskamm/geoext3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weskamm/geoext3/git/refs{/sha}","trees_url":"https://api.github.com/repos/weskamm/geoext3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weskamm/geoext3/statuses/{sha}","languages_url":"https://api.github.com/repos/weskamm/geoext3/languages","stargazers_url":"https://api.github.com/repos/weskamm/geoext3/stargazers","contributors_url":"https://api.github.com/repos/weskamm/geoext3/contributors","subscribers_url":"https://api.github.com/repos/weskamm/geoext3/subscribers","subscription_url":"https://api.github.com/repos/weskamm/geoext3/subscription","commits_url":"https://api.github.com/repos/weskamm/geoext3/commits{/sha}","git_commits_url":"https://api.github.com/repos/weskamm/geoext3/git/commits{/sha}","comments_url":"https://api.github.com/repos/weskamm/geoext3/comments{/number}","issue_comment_url":"https://api.github.com/repos/weskamm/geoext3/issues/comments{/number}","contents_url":"https://api.github.com/repos/weskamm/geoext3/contents/{+path}","compare_url":"https://api.github.com/repos/weskamm/geoext3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weskamm/geoext3/merges","archive_url":"https://api.github.com/repos/weskamm/geoext3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weskamm/geoext3/downloads","issues_url":"https://api.github.com/repos/weskamm/geoext3/issues{/number}","pulls_url":"https://api.github.com/repos/weskamm/geoext3/pulls{/number}","milestones_url":"https://api.github.com/repos/weskamm/geoext3/milestones{/number}","notifications_url":"https://api.github.com/repos/weskamm/geoext3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weskamm/geoext3/labels{/name}","releases_url":"https://api.github.com/repos/weskamm/geoext3/releases{/id}","created_at":"2015-06-17T15:11:44Z","updated_at":"2015-06-17T15:11:44Z","pushed_at":"2015-06-17T16:50:09Z","git_url":"git://github.com/weskamm/geoext3.git","ssh_url":"git@github.com:weskamm/geoext3.git","clone_url":"https://github.com/weskamm/geoext3.git","svn_url":"https://github.com/weskamm/geoext3","homepage":null,"size":384,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geoext:master","ref":"master","sha":"61e75d85c999f0e510b0dcb2d6c852e573c3529b","user":{"login":"geoext","id":507290,"avatar_url":"https://avatars.githubusercontent.com/u/507290?v=3","gravatar_id":"","url":"https://api.github.com/users/geoext","html_url":"https://github.com/geoext","followers_url":"https://api.github.com/users/geoext/followers","following_url":"https://api.github.com/users/geoext/following{/other_user}","gists_url":"https://api.github.com/users/geoext/gists{/gist_id}","starred_url":"https://api.github.com/users/geoext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoext/subscriptions","organizations_url":"https://api.github.com/users/geoext/orgs","repos_url":"https://api.github.com/users/geoext/repos","events_url":"https://api.github.com/users/geoext/events{/privacy}","received_events_url":"https://api.github.com/users/geoext/received_events","type":"Organization","site_admin":false},"repo":{"id":34011884,"name":"geoext3","full_name":"geoext/geoext3","owner":{"login":"geoext","id":507290,"avatar_url":"https://avatars.githubusercontent.com/u/507290?v=3","gravatar_id":"","url":"https://api.github.com/users/geoext","html_url":"https://github.com/geoext","followers_url":"https://api.github.com/users/geoext/followers","following_url":"https://api.github.com/users/geoext/following{/other_user}","gists_url":"https://api.github.com/users/geoext/gists{/gist_id}","starred_url":"https://api.github.com/users/geoext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoext/subscriptions","organizations_url":"https://api.github.com/users/geoext/orgs","repos_url":"https://api.github.com/users/geoext/repos","events_url":"https://api.github.com/users/geoext/events{/privacy}","received_events_url":"https://api.github.com/users/geoext/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoext/geoext3","description":"Work in progress, stay tuned...","fork":false,"url":"https://api.github.com/repos/geoext/geoext3","forks_url":"https://api.github.com/repos/geoext/geoext3/forks","keys_url":"https://api.github.com/repos/geoext/geoext3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoext/geoext3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoext/geoext3/teams","hooks_url":"https://api.github.com/repos/geoext/geoext3/hooks","issue_events_url":"https://api.github.com/repos/geoext/geoext3/issues/events{/number}","events_url":"https://api.github.com/repos/geoext/geoext3/events","assignees_url":"https://api.github.com/repos/geoext/geoext3/assignees{/user}","branches_url":"https://api.github.com/repos/geoext/geoext3/branches{/branch}","tags_url":"https://api.github.com/repos/geoext/geoext3/tags","blobs_url":"https://api.github.com/repos/geoext/geoext3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoext/geoext3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoext/geoext3/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoext/geoext3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoext/geoext3/statuses/{sha}","languages_url":"https://api.github.com/repos/geoext/geoext3/languages","stargazers_url":"https://api.github.com/repos/geoext/geoext3/stargazers","contributors_url":"https://api.github.com/repos/geoext/geoext3/contributors","subscribers_url":"https://api.github.com/repos/geoext/geoext3/subscribers","subscription_url":"https://api.github.com/repos/geoext/geoext3/subscription","commits_url":"https://api.github.com/repos/geoext/geoext3/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoext/geoext3/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoext/geoext3/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoext/geoext3/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoext/geoext3/contents/{+path}","compare_url":"https://api.github.com/repos/geoext/geoext3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoext/geoext3/merges","archive_url":"https://api.github.com/repos/geoext/geoext3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoext/geoext3/downloads","issues_url":"https://api.github.com/repos/geoext/geoext3/issues{/number}","pulls_url":"https://api.github.com/repos/geoext/geoext3/pulls{/number}","milestones_url":"https://api.github.com/repos/geoext/geoext3/milestones{/number}","notifications_url":"https://api.github.com/repos/geoext/geoext3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoext/geoext3/labels{/name}","releases_url":"https://api.github.com/repos/geoext/geoext3/releases{/id}","created_at":"2015-04-15T18:41:13Z","updated_at":"2015-06-17T13:48:13Z","pushed_at":"2015-06-17T18:24:19Z","git_url":"git://github.com/geoext/geoext3.git","ssh_url":"git@github.com:geoext/geoext3.git","clone_url":"https://github.com/geoext/geoext3.git","svn_url":"https://github.com/geoext/geoext3","homepage":null,"size":1136,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geoext/geoext3/pulls/5"},"html":{"href":"https://github.com/geoext/geoext3/pull/5"},"issue":{"href":"https://api.github.com/repos/geoext/geoext3/issues/5"},"comments":{"href":"https://api.github.com/repos/geoext/geoext3/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/geoext/geoext3/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/geoext/geoext3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geoext/geoext3/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/geoext/geoext3/statuses/6ca22a4d0d3bd4e400a9622654ec7af67345e0be"}}}}