{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/35128773","id":35128773,"diff_hunk":"@@ -49,11 +50,10 @@\n import org.springframework.messaging.support.ChannelInterceptorAdapter;\n import org.springframework.util.Assert;\n import org.springframework.util.StringUtils;\n-import org.springframework.xd.dirt.integration.bus.MessageBus;\n-import org.springframework.xd.dirt.integration.bus.XdHeaders;\n+import org.springframework.cloud.stream.binder.Binder;\n \n /**\n- * Binds input/output channels to the bus.\n+ * Binds input/output channels to the binder.","path":"spring-cloud-stream/src/main/java/org/springframework/cloud/stream/adapter/ChannelBindingAdapter.java","position":18,"original_position":18,"commit_id":"e2691c73962f130b29dca8593b05124b4909f1d2","original_commit_id":"e2691c73962f130b29dca8593b05124b4909f1d2","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"body":"we aren't binding to the binder... should reword this javadoc","created_at":"2015-07-21T17:21:34Z","updated_at":"2015-07-21T17:21:34Z","html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/32#discussion_r35128773","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/35128773"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/32#discussion_r35128773"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/32","id":40405171,"html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/32","diff_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/32.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/32.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/32","number":32,"state":"open","locked":false,"title":"Renamed MessageBus to Binder","user":{"login":"dturanski","id":886859,"avatar_url":"https://avatars.githubusercontent.com/u/886859?v=3","gravatar_id":"","url":"https://api.github.com/users/dturanski","html_url":"https://github.com/dturanski","followers_url":"https://api.github.com/users/dturanski/followers","following_url":"https://api.github.com/users/dturanski/following{/other_user}","gists_url":"https://api.github.com/users/dturanski/gists{/gist_id}","starred_url":"https://api.github.com/users/dturanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturanski/subscriptions","organizations_url":"https://api.github.com/users/dturanski/orgs","repos_url":"https://api.github.com/users/dturanski/repos","events_url":"https://api.github.com/users/dturanski/events{/privacy}","received_events_url":"https://api.github.com/users/dturanski/received_events","type":"User","site_admin":false},"body":"Binder<T>;  MessageChannelBinderSupport implements Binder<MessageChannel>, etc. Still using property names `xd.messagebus.*` in the xml config. That will be replaced when we cut over to @Configuration.  Also this code will be refactored again once https://github.com/spring-projects/spring-integration/pull/1513 is applied. ","created_at":"2015-07-20T22:37:26Z","updated_at":"2015-07-21T17:21:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04111f3815280f98b6fd6c853412a19bf66085d9","assignee":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/32/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/32/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/32/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/e2691c73962f130b29dca8593b05124b4909f1d2","head":{"label":"dturanski:mb-to-binder","ref":"mb-to-binder","sha":"e2691c73962f130b29dca8593b05124b4909f1d2","user":{"login":"dturanski","id":886859,"avatar_url":"https://avatars.githubusercontent.com/u/886859?v=3","gravatar_id":"","url":"https://api.github.com/users/dturanski","html_url":"https://github.com/dturanski","followers_url":"https://api.github.com/users/dturanski/followers","following_url":"https://api.github.com/users/dturanski/following{/other_user}","gists_url":"https://api.github.com/users/dturanski/gists{/gist_id}","starred_url":"https://api.github.com/users/dturanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturanski/subscriptions","organizations_url":"https://api.github.com/users/dturanski/orgs","repos_url":"https://api.github.com/users/dturanski/repos","events_url":"https://api.github.com/users/dturanski/events{/privacy}","received_events_url":"https://api.github.com/users/dturanski/received_events","type":"User","site_admin":false},"repo":{"id":38768790,"name":"spring-cloud-streams","full_name":"dturanski/spring-cloud-streams","owner":{"login":"dturanski","id":886859,"avatar_url":"https://avatars.githubusercontent.com/u/886859?v=3","gravatar_id":"","url":"https://api.github.com/users/dturanski","html_url":"https://github.com/dturanski","followers_url":"https://api.github.com/users/dturanski/followers","following_url":"https://api.github.com/users/dturanski/following{/other_user}","gists_url":"https://api.github.com/users/dturanski/gists{/gist_id}","starred_url":"https://api.github.com/users/dturanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturanski/subscriptions","organizations_url":"https://api.github.com/users/dturanski/orgs","repos_url":"https://api.github.com/users/dturanski/repos","events_url":"https://api.github.com/users/dturanski/events{/privacy}","received_events_url":"https://api.github.com/users/dturanski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dturanski/spring-cloud-streams","description":"Messaging Microservices with Spring Integration","fork":true,"url":"https://api.github.com/repos/dturanski/spring-cloud-streams","forks_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/forks","keys_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/teams","hooks_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/hooks","issue_events_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/issues/events{/number}","events_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/events","assignees_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/assignees{/user}","branches_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/branches{/branch}","tags_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/tags","blobs_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/statuses/{sha}","languages_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/languages","stargazers_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/stargazers","contributors_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/contributors","subscribers_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/subscribers","subscription_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/subscription","commits_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/contents/{+path}","compare_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/merges","archive_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/downloads","issues_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/issues{/number}","pulls_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/pulls{/number}","milestones_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/milestones{/number}","notifications_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/labels{/name}","releases_url":"https://api.github.com/repos/dturanski/spring-cloud-streams/releases{/id}","created_at":"2015-07-08T17:21:32Z","updated_at":"2015-07-08T17:21:32Z","pushed_at":"2015-07-21T16:10:41Z","git_url":"git://github.com/dturanski/spring-cloud-streams.git","ssh_url":"git@github.com:dturanski/spring-cloud-streams.git","clone_url":"https://github.com/dturanski/spring-cloud-streams.git","svn_url":"https://github.com/dturanski/spring-cloud-streams","homepage":null,"size":538,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"11e9f269db81b099a407ede9756615d8d9121faa","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":38764029,"name":"spring-cloud-stream","full_name":"spring-cloud/spring-cloud-stream","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-stream","description":"Messaging Microservices with Spring Integration","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/releases{/id}","created_at":"2015-07-08T15:51:38Z","updated_at":"2015-07-15T15:03:18Z","pushed_at":"2015-07-21T16:10:42Z","git_url":"git://github.com/spring-cloud/spring-cloud-stream.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-stream.git","clone_url":"https://github.com/spring-cloud/spring-cloud-stream.git","svn_url":"https://github.com/spring-cloud/spring-cloud-stream","homepage":"http://cloud.spring.io/spring-cloud-stream/","size":1643,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":9,"forks":10,"open_issues":9,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/32"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/32"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/32"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/e2691c73962f130b29dca8593b05124b4909f1d2"}}}}