{"action":"created","comment":{"url":"https://api.github.com/repos/ppikula/x/pulls/comments/40138475","id":40138475,"diff_hunk":"@@ -47,29 +49,29 @@ is_jid(_) -> false.\n \n -spec new(username(), domain(), resource()) -> full_jid().\n new(User, Domain, Resource) ->\n-    x_contract:check(User, fun is_binary/1),\n-    x_contract:check(Domain, fun is_binary/1),\n-    x_contract:check(Resource, fun is_binary/1),\n-    #full_jid{username = User, domain = Domain, resource = Resource}.\n+  x_contract:check(User, fun is_binary/1),\n+  x_contract:check(Domain, fun is_binary/1),\n+  x_contract:check(Resource, fun is_binary/1),\n+  #full_jid{username = User, domain = Domain, resource = Resource}.\n \n -spec new(username(), domain()) -> bare_jid().\n new(User, Domain) ->\n-    x_contract:check(User, fun is_binary/1),\n-    x_contract:check(Domain, fun is_binary/1),\n-    #bare_jid{username = User, domain = Domain}.\n+  x_contract:check(User, fun is_binary/1),\n+  x_contract:check(Domain, fun is_binary/1),\n+  #bare_jid{username = User, domain = Domain}.\n \n -spec to_bin(jid()) -> binary().\n to_bin(#full_jid{username = U, domain = D, resource = R}) ->\n-    <<(maybe_user_at(U))/binary,D/binary,\"/\",R/binary>>;\n+  <<(maybe_user_at(U))/binary,D/binary,\"/\",R/binary>>;","path":"src/x_jid.erl","position":31,"original_position":31,"commit_id":"8a23b2cbdf33836d0753492430aa34497533237b","original_commit_id":"8a23b2cbdf33836d0753492430aa34497533237b","user":{"login":"gadgetci","id":10134338,"avatar_url":"https://avatars.githubusercontent.com/u/10134338?v=3","gravatar_id":"","url":"https://api.github.com/users/gadgetci","html_url":"https://github.com/gadgetci","followers_url":"https://api.github.com/users/gadgetci/followers","following_url":"https://api.github.com/users/gadgetci/following{/other_user}","gists_url":"https://api.github.com/users/gadgetci/gists{/gist_id}","starred_url":"https://api.github.com/users/gadgetci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadgetci/subscriptions","organizations_url":"https://api.github.com/users/gadgetci/orgs","repos_url":"https://api.github.com/users/gadgetci/repos","events_url":"https://api.github.com/users/gadgetci/events{/privacy}","received_events_url":"https://api.github.com/users/gadgetci/received_events","type":"User","site_admin":false},"body":"According to **Elvis**:\n> Missing space after \",\" on line 65","created_at":"2015-09-22T20:20:51Z","updated_at":"2015-09-22T20:20:51Z","html_url":"https://github.com/ppikula/x/pull/9#discussion_r40138475","pull_request_url":"https://api.github.com/repos/ppikula/x/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/ppikula/x/pulls/comments/40138475"},"html":{"href":"https://github.com/ppikula/x/pull/9#discussion_r40138475"},"pull_request":{"href":"https://api.github.com/repos/ppikula/x/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/ppikula/x/pulls/9","id":45711660,"html_url":"https://github.com/ppikula/x/pull/9","diff_url":"https://github.com/ppikula/x/pull/9.diff","patch_url":"https://github.com/ppikula/x/pull/9.patch","issue_url":"https://api.github.com/repos/ppikula/x/issues/9","number":9,"state":"open","locked":false,"title":"Stream features","user":{"login":"ppikula","id":244143,"avatar_url":"https://avatars.githubusercontent.com/u/244143?v=3","gravatar_id":"","url":"https://api.github.com/users/ppikula","html_url":"https://github.com/ppikula","followers_url":"https://api.github.com/users/ppikula/followers","following_url":"https://api.github.com/users/ppikula/following{/other_user}","gists_url":"https://api.github.com/users/ppikula/gists{/gist_id}","starred_url":"https://api.github.com/users/ppikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppikula/subscriptions","organizations_url":"https://api.github.com/users/ppikula/orgs","repos_url":"https://api.github.com/users/ppikula/repos","events_url":"https://api.github.com/users/ppikula/events{/privacy}","received_events_url":"https://api.github.com/users/ppikula/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-22T20:20:42Z","updated_at":"2015-09-22T20:20:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"929982f3c6d106802ffd107d63fabe04b9feaac6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ppikula/x/pulls/9/commits","review_comments_url":"https://api.github.com/repos/ppikula/x/pulls/9/comments","review_comment_url":"https://api.github.com/repos/ppikula/x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ppikula/x/issues/9/comments","statuses_url":"https://api.github.com/repos/ppikula/x/statuses/8a23b2cbdf33836d0753492430aa34497533237b","head":{"label":"ppikula:stream-features","ref":"stream-features","sha":"8a23b2cbdf33836d0753492430aa34497533237b","user":{"login":"ppikula","id":244143,"avatar_url":"https://avatars.githubusercontent.com/u/244143?v=3","gravatar_id":"","url":"https://api.github.com/users/ppikula","html_url":"https://github.com/ppikula","followers_url":"https://api.github.com/users/ppikula/followers","following_url":"https://api.github.com/users/ppikula/following{/other_user}","gists_url":"https://api.github.com/users/ppikula/gists{/gist_id}","starred_url":"https://api.github.com/users/ppikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppikula/subscriptions","organizations_url":"https://api.github.com/users/ppikula/orgs","repos_url":"https://api.github.com/users/ppikula/repos","events_url":"https://api.github.com/users/ppikula/events{/privacy}","received_events_url":"https://api.github.com/users/ppikula/received_events","type":"User","site_admin":false},"repo":{"id":39012523,"name":"x","full_name":"ppikula/x","owner":{"login":"ppikula","id":244143,"avatar_url":"https://avatars.githubusercontent.com/u/244143?v=3","gravatar_id":"","url":"https://api.github.com/users/ppikula","html_url":"https://github.com/ppikula","followers_url":"https://api.github.com/users/ppikula/followers","following_url":"https://api.github.com/users/ppikula/following{/other_user}","gists_url":"https://api.github.com/users/ppikula/gists{/gist_id}","starred_url":"https://api.github.com/users/ppikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppikula/subscriptions","organizations_url":"https://api.github.com/users/ppikula/orgs","repos_url":"https://api.github.com/users/ppikula/repos","events_url":"https://api.github.com/users/ppikula/events{/privacy}","received_events_url":"https://api.github.com/users/ppikula/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ppikula/x","description":"XMPP modeling toolkit","fork":false,"url":"https://api.github.com/repos/ppikula/x","forks_url":"https://api.github.com/repos/ppikula/x/forks","keys_url":"https://api.github.com/repos/ppikula/x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppikula/x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppikula/x/teams","hooks_url":"https://api.github.com/repos/ppikula/x/hooks","issue_events_url":"https://api.github.com/repos/ppikula/x/issues/events{/number}","events_url":"https://api.github.com/repos/ppikula/x/events","assignees_url":"https://api.github.com/repos/ppikula/x/assignees{/user}","branches_url":"https://api.github.com/repos/ppikula/x/branches{/branch}","tags_url":"https://api.github.com/repos/ppikula/x/tags","blobs_url":"https://api.github.com/repos/ppikula/x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppikula/x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppikula/x/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppikula/x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppikula/x/statuses/{sha}","languages_url":"https://api.github.com/repos/ppikula/x/languages","stargazers_url":"https://api.github.com/repos/ppikula/x/stargazers","contributors_url":"https://api.github.com/repos/ppikula/x/contributors","subscribers_url":"https://api.github.com/repos/ppikula/x/subscribers","subscription_url":"https://api.github.com/repos/ppikula/x/subscription","commits_url":"https://api.github.com/repos/ppikula/x/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppikula/x/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppikula/x/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppikula/x/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppikula/x/contents/{+path}","compare_url":"https://api.github.com/repos/ppikula/x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppikula/x/merges","archive_url":"https://api.github.com/repos/ppikula/x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppikula/x/downloads","issues_url":"https://api.github.com/repos/ppikula/x/issues{/number}","pulls_url":"https://api.github.com/repos/ppikula/x/pulls{/number}","milestones_url":"https://api.github.com/repos/ppikula/x/milestones{/number}","notifications_url":"https://api.github.com/repos/ppikula/x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppikula/x/labels{/name}","releases_url":"https://api.github.com/repos/ppikula/x/releases{/id}","created_at":"2015-07-13T13:06:21Z","updated_at":"2015-07-30T18:41:13Z","pushed_at":"2015-09-22T20:20:42Z","git_url":"git://github.com/ppikula/x.git","ssh_url":"git@github.com:ppikula/x.git","clone_url":"https://github.com/ppikula/x.git","svn_url":"https://github.com/ppikula/x","homepage":"","size":244,"stargazers_count":2,"watchers_count":2,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":2,"default_branch":"master"}},"base":{"label":"ppikula:master","ref":"master","sha":"243d70219a60167b8553e75665f45dc19577e5db","user":{"login":"ppikula","id":244143,"avatar_url":"https://avatars.githubusercontent.com/u/244143?v=3","gravatar_id":"","url":"https://api.github.com/users/ppikula","html_url":"https://github.com/ppikula","followers_url":"https://api.github.com/users/ppikula/followers","following_url":"https://api.github.com/users/ppikula/following{/other_user}","gists_url":"https://api.github.com/users/ppikula/gists{/gist_id}","starred_url":"https://api.github.com/users/ppikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppikula/subscriptions","organizations_url":"https://api.github.com/users/ppikula/orgs","repos_url":"https://api.github.com/users/ppikula/repos","events_url":"https://api.github.com/users/ppikula/events{/privacy}","received_events_url":"https://api.github.com/users/ppikula/received_events","type":"User","site_admin":false},"repo":{"id":39012523,"name":"x","full_name":"ppikula/x","owner":{"login":"ppikula","id":244143,"avatar_url":"https://avatars.githubusercontent.com/u/244143?v=3","gravatar_id":"","url":"https://api.github.com/users/ppikula","html_url":"https://github.com/ppikula","followers_url":"https://api.github.com/users/ppikula/followers","following_url":"https://api.github.com/users/ppikula/following{/other_user}","gists_url":"https://api.github.com/users/ppikula/gists{/gist_id}","starred_url":"https://api.github.com/users/ppikula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppikula/subscriptions","organizations_url":"https://api.github.com/users/ppikula/orgs","repos_url":"https://api.github.com/users/ppikula/repos","events_url":"https://api.github.com/users/ppikula/events{/privacy}","received_events_url":"https://api.github.com/users/ppikula/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ppikula/x","description":"XMPP modeling toolkit","fork":false,"url":"https://api.github.com/repos/ppikula/x","forks_url":"https://api.github.com/repos/ppikula/x/forks","keys_url":"https://api.github.com/repos/ppikula/x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppikula/x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppikula/x/teams","hooks_url":"https://api.github.com/repos/ppikula/x/hooks","issue_events_url":"https://api.github.com/repos/ppikula/x/issues/events{/number}","events_url":"https://api.github.com/repos/ppikula/x/events","assignees_url":"https://api.github.com/repos/ppikula/x/assignees{/user}","branches_url":"https://api.github.com/repos/ppikula/x/branches{/branch}","tags_url":"https://api.github.com/repos/ppikula/x/tags","blobs_url":"https://api.github.com/repos/ppikula/x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppikula/x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppikula/x/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppikula/x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppikula/x/statuses/{sha}","languages_url":"https://api.github.com/repos/ppikula/x/languages","stargazers_url":"https://api.github.com/repos/ppikula/x/stargazers","contributors_url":"https://api.github.com/repos/ppikula/x/contributors","subscribers_url":"https://api.github.com/repos/ppikula/x/subscribers","subscription_url":"https://api.github.com/repos/ppikula/x/subscription","commits_url":"https://api.github.com/repos/ppikula/x/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppikula/x/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppikula/x/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppikula/x/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppikula/x/contents/{+path}","compare_url":"https://api.github.com/repos/ppikula/x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppikula/x/merges","archive_url":"https://api.github.com/repos/ppikula/x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppikula/x/downloads","issues_url":"https://api.github.com/repos/ppikula/x/issues{/number}","pulls_url":"https://api.github.com/repos/ppikula/x/pulls{/number}","milestones_url":"https://api.github.com/repos/ppikula/x/milestones{/number}","notifications_url":"https://api.github.com/repos/ppikula/x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppikula/x/labels{/name}","releases_url":"https://api.github.com/repos/ppikula/x/releases{/id}","created_at":"2015-07-13T13:06:21Z","updated_at":"2015-07-30T18:41:13Z","pushed_at":"2015-09-22T20:20:42Z","git_url":"git://github.com/ppikula/x.git","ssh_url":"git@github.com:ppikula/x.git","clone_url":"https://github.com/ppikula/x.git","svn_url":"https://github.com/ppikula/x","homepage":"","size":244,"stargazers_count":2,"watchers_count":2,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ppikula/x/pulls/9"},"html":{"href":"https://github.com/ppikula/x/pull/9"},"issue":{"href":"https://api.github.com/repos/ppikula/x/issues/9"},"comments":{"href":"https://api.github.com/repos/ppikula/x/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/ppikula/x/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/ppikula/x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ppikula/x/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/ppikula/x/statuses/8a23b2cbdf33836d0753492430aa34497533237b"}}}}