{"action":"created","comment":{"url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/35739041","id":35739041,"diff_hunk":"@@ -37,15 +37,6 @@ from rust repo, then you should have [MSYS2](http://msys2.github.io/) with\n `mingw-w64-openssl` installed as part of `mingw-w64-x86_64-toolchain`\n (or `mingw-w64-i686-toolchain`) package.\n \n-Alternatively, install OpenSSL from [here][1]. Cargo will not be able to find OpenSSL if it's\n-installed to the default location. You can either copy the `include/openssl`\n-directory, `libssl32.dll`, and `libeay32.dll` to locations that Cargo can find\n-or pass the location to Cargo via environment variables:\n-\n-```bash\n-env OPENSSL_LIB_DIR=C:/OpenSSL-Win64 OPENSSL_INCLUDE_DIR=C:/OpenSSL-Win64/include cargo build","path":"README.md","position":19,"original_position":19,"commit_id":"cd5a48e6b44a421d49510ae20ccab58d8e6aefd7","original_commit_id":"cd5a48e6b44a421d49510ae20ccab58d8e6aefd7","user":{"login":"Zarathustra30","id":13055320,"avatar_url":"https://avatars.githubusercontent.com/u/13055320?v=3","gravatar_id":"","url":"https://api.github.com/users/Zarathustra30","html_url":"https://github.com/Zarathustra30","followers_url":"https://api.github.com/users/Zarathustra30/followers","following_url":"https://api.github.com/users/Zarathustra30/following{/other_user}","gists_url":"https://api.github.com/users/Zarathustra30/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarathustra30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarathustra30/subscriptions","organizations_url":"https://api.github.com/users/Zarathustra30/orgs","repos_url":"https://api.github.com/users/Zarathustra30/repos","events_url":"https://api.github.com/users/Zarathustra30/events{/privacy}","received_events_url":"https://api.github.com/users/Zarathustra30/received_events","type":"User","site_admin":false},"body":"The alternate Windows method only works if MinGW-w64 is already installed, due to the dependency on [gcc-rs](https://github.com/alexcrichton/gcc-rs) (which, in turn, depends on MinGW's version of gcc), so it should not be considered an alternative to using MinGW-w64.\r\n\r\nHowever, when I authored the pull, I was unaware of gcc-rs's dependency on MinGW-w64, and thought the failed compile was an actual bug. The pull would have been a band-aid until the bug was fixed.\r\n\r\nThis pull may be slightly confused, but the README should reflect that rust-openssl cannot be built without MinGW.","created_at":"2015-07-29T08:49:33Z","updated_at":"2015-07-29T08:49:33Z","html_url":"https://github.com/sfackler/rust-openssl/pull/246#discussion_r35739041","pull_request_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/246","_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments/35739041"},"html":{"href":"https://github.com/sfackler/rust-openssl/pull/246#discussion_r35739041"},"pull_request":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/246"}}},"pull_request":{"url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/246","id":40632404,"html_url":"https://github.com/sfackler/rust-openssl/pull/246","diff_url":"https://github.com/sfackler/rust-openssl/pull/246.diff","patch_url":"https://github.com/sfackler/rust-openssl/pull/246.patch","issue_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/246","number":246,"state":"open","locked":false,"title":"Removed Windows alternative build procedure","user":{"login":"Zarathustra30","id":13055320,"avatar_url":"https://avatars.githubusercontent.com/u/13055320?v=3","gravatar_id":"","url":"https://api.github.com/users/Zarathustra30","html_url":"https://github.com/Zarathustra30","followers_url":"https://api.github.com/users/Zarathustra30/followers","following_url":"https://api.github.com/users/Zarathustra30/following{/other_user}","gists_url":"https://api.github.com/users/Zarathustra30/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarathustra30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarathustra30/subscriptions","organizations_url":"https://api.github.com/users/Zarathustra30/orgs","repos_url":"https://api.github.com/users/Zarathustra30/repos","events_url":"https://api.github.com/users/Zarathustra30/events{/privacy}","received_events_url":"https://api.github.com/users/Zarathustra30/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/sfackler/rust-openssl/issues/245","created_at":"2015-07-23T02:46:33Z","updated_at":"2015-07-29T08:49:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61c284db0b05ce2e32ae78b2794bbd673eb2d4aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/246/commits","review_comments_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/246/comments","review_comment_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/246/comments","statuses_url":"https://api.github.com/repos/sfackler/rust-openssl/statuses/cd5a48e6b44a421d49510ae20ccab58d8e6aefd7","head":{"label":"Zarathustra30:master","ref":"master","sha":"cd5a48e6b44a421d49510ae20ccab58d8e6aefd7","user":{"login":"Zarathustra30","id":13055320,"avatar_url":"https://avatars.githubusercontent.com/u/13055320?v=3","gravatar_id":"","url":"https://api.github.com/users/Zarathustra30","html_url":"https://github.com/Zarathustra30","followers_url":"https://api.github.com/users/Zarathustra30/followers","following_url":"https://api.github.com/users/Zarathustra30/following{/other_user}","gists_url":"https://api.github.com/users/Zarathustra30/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarathustra30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarathustra30/subscriptions","organizations_url":"https://api.github.com/users/Zarathustra30/orgs","repos_url":"https://api.github.com/users/Zarathustra30/repos","events_url":"https://api.github.com/users/Zarathustra30/events{/privacy}","received_events_url":"https://api.github.com/users/Zarathustra30/received_events","type":"User","site_admin":false},"repo":{"id":39541723,"name":"rust-openssl","full_name":"Zarathustra30/rust-openssl","owner":{"login":"Zarathustra30","id":13055320,"avatar_url":"https://avatars.githubusercontent.com/u/13055320?v=3","gravatar_id":"","url":"https://api.github.com/users/Zarathustra30","html_url":"https://github.com/Zarathustra30","followers_url":"https://api.github.com/users/Zarathustra30/followers","following_url":"https://api.github.com/users/Zarathustra30/following{/other_user}","gists_url":"https://api.github.com/users/Zarathustra30/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarathustra30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarathustra30/subscriptions","organizations_url":"https://api.github.com/users/Zarathustra30/orgs","repos_url":"https://api.github.com/users/Zarathustra30/repos","events_url":"https://api.github.com/users/Zarathustra30/events{/privacy}","received_events_url":"https://api.github.com/users/Zarathustra30/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zarathustra30/rust-openssl","description":"OpenSSL bindings for Rust","fork":true,"url":"https://api.github.com/repos/Zarathustra30/rust-openssl","forks_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/forks","keys_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/teams","hooks_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/hooks","issue_events_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/issues/events{/number}","events_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/events","assignees_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/assignees{/user}","branches_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/branches{/branch}","tags_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/tags","blobs_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/languages","stargazers_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/stargazers","contributors_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/contributors","subscribers_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/subscribers","subscription_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/subscription","commits_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/contents/{+path}","compare_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/merges","archive_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/downloads","issues_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/issues{/number}","pulls_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/labels{/name}","releases_url":"https://api.github.com/repos/Zarathustra30/rust-openssl/releases{/id}","created_at":"2015-07-23T02:39:58Z","updated_at":"2015-07-23T02:39:58Z","pushed_at":"2015-07-23T02:43:46Z","git_url":"git://github.com/Zarathustra30/rust-openssl.git","ssh_url":"git@github.com:Zarathustra30/rust-openssl.git","clone_url":"https://github.com/Zarathustra30/rust-openssl.git","svn_url":"https://github.com/Zarathustra30/rust-openssl","homepage":"","size":5708,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sfackler:master","ref":"master","sha":"2e0ae7a8ca49fbfd0a99bbdd58fc673328abdc39","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"repo":{"id":15500883,"name":"rust-openssl","full_name":"sfackler/rust-openssl","owner":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfackler/rust-openssl","description":"OpenSSL bindings for Rust","fork":false,"url":"https://api.github.com/repos/sfackler/rust-openssl","forks_url":"https://api.github.com/repos/sfackler/rust-openssl/forks","keys_url":"https://api.github.com/repos/sfackler/rust-openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfackler/rust-openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfackler/rust-openssl/teams","hooks_url":"https://api.github.com/repos/sfackler/rust-openssl/hooks","issue_events_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/events{/number}","events_url":"https://api.github.com/repos/sfackler/rust-openssl/events","assignees_url":"https://api.github.com/repos/sfackler/rust-openssl/assignees{/user}","branches_url":"https://api.github.com/repos/sfackler/rust-openssl/branches{/branch}","tags_url":"https://api.github.com/repos/sfackler/rust-openssl/tags","blobs_url":"https://api.github.com/repos/sfackler/rust-openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfackler/rust-openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfackler/rust-openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfackler/rust-openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfackler/rust-openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/sfackler/rust-openssl/languages","stargazers_url":"https://api.github.com/repos/sfackler/rust-openssl/stargazers","contributors_url":"https://api.github.com/repos/sfackler/rust-openssl/contributors","subscribers_url":"https://api.github.com/repos/sfackler/rust-openssl/subscribers","subscription_url":"https://api.github.com/repos/sfackler/rust-openssl/subscription","commits_url":"https://api.github.com/repos/sfackler/rust-openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfackler/rust-openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfackler/rust-openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfackler/rust-openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfackler/rust-openssl/contents/{+path}","compare_url":"https://api.github.com/repos/sfackler/rust-openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfackler/rust-openssl/merges","archive_url":"https://api.github.com/repos/sfackler/rust-openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfackler/rust-openssl/downloads","issues_url":"https://api.github.com/repos/sfackler/rust-openssl/issues{/number}","pulls_url":"https://api.github.com/repos/sfackler/rust-openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/sfackler/rust-openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/sfackler/rust-openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfackler/rust-openssl/labels{/name}","releases_url":"https://api.github.com/repos/sfackler/rust-openssl/releases{/id}","created_at":"2013-12-28T23:56:50Z","updated_at":"2015-07-25T03:27:50Z","pushed_at":"2015-07-26T18:06:26Z","git_url":"git://github.com/sfackler/rust-openssl.git","ssh_url":"git@github.com:sfackler/rust-openssl.git","clone_url":"https://github.com/sfackler/rust-openssl.git","svn_url":"https://github.com/sfackler/rust-openssl","homepage":"","size":7845,"stargazers_count":97,"watchers_count":97,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":83,"mirror_url":null,"open_issues_count":33,"forks":83,"open_issues":33,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/246"},"html":{"href":"https://github.com/sfackler/rust-openssl/pull/246"},"issue":{"href":"https://api.github.com/repos/sfackler/rust-openssl/issues/246"},"comments":{"href":"https://api.github.com/repos/sfackler/rust-openssl/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sfackler/rust-openssl/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/sfackler/rust-openssl/statuses/cd5a48e6b44a421d49510ae20ccab58d8e6aefd7"}}}}