{"action":"created","comment":{"url":"https://api.github.com/repos/metricfu/metric_fu/pulls/comments/30545824","id":30545824,"diff_hunk":"@@ -43,51 +43,63 @@\n       MetricFu::Configuration.run {}\n       allow(File).to receive(:directory?).and_return(true)\n       @reek = MetricFu::ReekGenerator.new\n+      @examiner = @reek.send(:examiner)\n+      @smell_warning = Reek.const_defined?(:SmellWarning) ? Reek.const_get(:SmellWarning) : Reek.const_get(:Smells).const_get(:SmellWarning)\n+      if @smell_warning.instance_methods.include?(:subclass)","path":"spec/metric_fu/metrics/reek/generator_spec.rb","position":6,"original_position":6,"commit_id":"84ef8c8839f58e0e07d0bd0ee3ad104ad49317a1","original_commit_id":"84ef8c8839f58e0e07d0bd0ee3ad104ad49317a1","user":{"login":"MGotink","id":3357803,"avatar_url":"https://avatars.githubusercontent.com/u/3357803?v=3","gravatar_id":"","url":"https://api.github.com/users/MGotink","html_url":"https://github.com/MGotink","followers_url":"https://api.github.com/users/MGotink/followers","following_url":"https://api.github.com/users/MGotink/following{/other_user}","gists_url":"https://api.github.com/users/MGotink/gists{/gist_id}","starred_url":"https://api.github.com/users/MGotink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MGotink/subscriptions","organizations_url":"https://api.github.com/users/MGotink/orgs","repos_url":"https://api.github.com/users/MGotink/repos","events_url":"https://api.github.com/users/MGotink/events{/privacy}","received_events_url":"https://api.github.com/users/MGotink/received_events","type":"User","site_admin":false},"body":"I'm not too happy with this kind of hacks in the specs, but I can't think of a better solution right now.\r\nRuby 1.9.2. is using an older reek version which doesn't implement SmellWarning#smell_type, due to which the verified double fails.\r\nOTOH the older reek output is tested separately.\r\n\r\n@bf4, maybe you have a better solution?","created_at":"2015-05-18T20:47:53Z","updated_at":"2015-05-18T20:47:53Z","html_url":"https://github.com/metricfu/metric_fu/pull/260#discussion_r30545824","pull_request_url":"https://api.github.com/repos/metricfu/metric_fu/pulls/260","_links":{"self":{"href":"https://api.github.com/repos/metricfu/metric_fu/pulls/comments/30545824"},"html":{"href":"https://github.com/metricfu/metric_fu/pull/260#discussion_r30545824"},"pull_request":{"href":"https://api.github.com/repos/metricfu/metric_fu/pulls/260"}}},"pull_request":{"url":"https://api.github.com/repos/metricfu/metric_fu/pulls/260","id":35592509,"html_url":"https://github.com/metricfu/metric_fu/pull/260","diff_url":"https://github.com/metricfu/metric_fu/pull/260.diff","patch_url":"https://github.com/metricfu/metric_fu/pull/260.patch","issue_url":"https://api.github.com/repos/metricfu/metric_fu/issues/260","number":260,"state":"open","locked":false,"title":"Use verified doubles in specs","user":{"login":"MGotink","id":3357803,"avatar_url":"https://avatars.githubusercontent.com/u/3357803?v=3","gravatar_id":"","url":"https://api.github.com/users/MGotink","html_url":"https://github.com/MGotink","followers_url":"https://api.github.com/users/MGotink/followers","following_url":"https://api.github.com/users/MGotink/following{/other_user}","gists_url":"https://api.github.com/users/MGotink/gists{/gist_id}","starred_url":"https://api.github.com/users/MGotink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MGotink/subscriptions","organizations_url":"https://api.github.com/users/MGotink/orgs","repos_url":"https://api.github.com/users/MGotink/repos","events_url":"https://api.github.com/users/MGotink/events{/privacy}","received_events_url":"https://api.github.com/users/MGotink/received_events","type":"User","site_admin":false},"body":"As noted by @bf4 in #258.","created_at":"2015-05-17T20:12:29Z","updated_at":"2015-05-18T20:47:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7261de581fb36d566650e1a3e742c2834a51adcd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/metricfu/metric_fu/pulls/260/commits","review_comments_url":"https://api.github.com/repos/metricfu/metric_fu/pulls/260/comments","review_comment_url":"https://api.github.com/repos/metricfu/metric_fu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metricfu/metric_fu/issues/260/comments","statuses_url":"https://api.github.com/repos/metricfu/metric_fu/statuses/84ef8c8839f58e0e07d0bd0ee3ad104ad49317a1","head":{"label":"MGotink:verified_doubles","ref":"verified_doubles","sha":"84ef8c8839f58e0e07d0bd0ee3ad104ad49317a1","user":{"login":"MGotink","id":3357803,"avatar_url":"https://avatars.githubusercontent.com/u/3357803?v=3","gravatar_id":"","url":"https://api.github.com/users/MGotink","html_url":"https://github.com/MGotink","followers_url":"https://api.github.com/users/MGotink/followers","following_url":"https://api.github.com/users/MGotink/following{/other_user}","gists_url":"https://api.github.com/users/MGotink/gists{/gist_id}","starred_url":"https://api.github.com/users/MGotink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MGotink/subscriptions","organizations_url":"https://api.github.com/users/MGotink/orgs","repos_url":"https://api.github.com/users/MGotink/repos","events_url":"https://api.github.com/users/MGotink/events{/privacy}","received_events_url":"https://api.github.com/users/MGotink/received_events","type":"User","site_admin":false},"repo":{"id":11660632,"name":"metric_fu","full_name":"MGotink/metric_fu","owner":{"login":"MGotink","id":3357803,"avatar_url":"https://avatars.githubusercontent.com/u/3357803?v=3","gravatar_id":"","url":"https://api.github.com/users/MGotink","html_url":"https://github.com/MGotink","followers_url":"https://api.github.com/users/MGotink/followers","following_url":"https://api.github.com/users/MGotink/following{/other_user}","gists_url":"https://api.github.com/users/MGotink/gists{/gist_id}","starred_url":"https://api.github.com/users/MGotink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MGotink/subscriptions","organizations_url":"https://api.github.com/users/MGotink/orgs","repos_url":"https://api.github.com/users/MGotink/repos","events_url":"https://api.github.com/users/MGotink/events{/privacy}","received_events_url":"https://api.github.com/users/MGotink/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MGotink/metric_fu","description":"A fist full of code metrics","fork":true,"url":"https://api.github.com/repos/MGotink/metric_fu","forks_url":"https://api.github.com/repos/MGotink/metric_fu/forks","keys_url":"https://api.github.com/repos/MGotink/metric_fu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MGotink/metric_fu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MGotink/metric_fu/teams","hooks_url":"https://api.github.com/repos/MGotink/metric_fu/hooks","issue_events_url":"https://api.github.com/repos/MGotink/metric_fu/issues/events{/number}","events_url":"https://api.github.com/repos/MGotink/metric_fu/events","assignees_url":"https://api.github.com/repos/MGotink/metric_fu/assignees{/user}","branches_url":"https://api.github.com/repos/MGotink/metric_fu/branches{/branch}","tags_url":"https://api.github.com/repos/MGotink/metric_fu/tags","blobs_url":"https://api.github.com/repos/MGotink/metric_fu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MGotink/metric_fu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MGotink/metric_fu/git/refs{/sha}","trees_url":"https://api.github.com/repos/MGotink/metric_fu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MGotink/metric_fu/statuses/{sha}","languages_url":"https://api.github.com/repos/MGotink/metric_fu/languages","stargazers_url":"https://api.github.com/repos/MGotink/metric_fu/stargazers","contributors_url":"https://api.github.com/repos/MGotink/metric_fu/contributors","subscribers_url":"https://api.github.com/repos/MGotink/metric_fu/subscribers","subscription_url":"https://api.github.com/repos/MGotink/metric_fu/subscription","commits_url":"https://api.github.com/repos/MGotink/metric_fu/commits{/sha}","git_commits_url":"https://api.github.com/repos/MGotink/metric_fu/git/commits{/sha}","comments_url":"https://api.github.com/repos/MGotink/metric_fu/comments{/number}","issue_comment_url":"https://api.github.com/repos/MGotink/metric_fu/issues/comments{/number}","contents_url":"https://api.github.com/repos/MGotink/metric_fu/contents/{+path}","compare_url":"https://api.github.com/repos/MGotink/metric_fu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MGotink/metric_fu/merges","archive_url":"https://api.github.com/repos/MGotink/metric_fu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MGotink/metric_fu/downloads","issues_url":"https://api.github.com/repos/MGotink/metric_fu/issues{/number}","pulls_url":"https://api.github.com/repos/MGotink/metric_fu/pulls{/number}","milestones_url":"https://api.github.com/repos/MGotink/metric_fu/milestones{/number}","notifications_url":"https://api.github.com/repos/MGotink/metric_fu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MGotink/metric_fu/labels{/name}","releases_url":"https://api.github.com/repos/MGotink/metric_fu/releases{/id}","created_at":"2013-07-25T13:07:59Z","updated_at":"2015-02-26T21:18:52Z","pushed_at":"2015-05-18T20:37:24Z","git_url":"git://github.com/MGotink/metric_fu.git","ssh_url":"git@github.com:MGotink/metric_fu.git","clone_url":"https://github.com/MGotink/metric_fu.git","svn_url":"https://github.com/MGotink/metric_fu","homepage":"http://metricfu.github.com/metric_fu","size":10800,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metricfu:master","ref":"master","sha":"a079d976b34c2f8457a78897fbafcbcd90b46c5a","user":{"login":"metricfu","id":3143951,"avatar_url":"https://avatars.githubusercontent.com/u/3143951?v=3","gravatar_id":"","url":"https://api.github.com/users/metricfu","html_url":"https://github.com/metricfu","followers_url":"https://api.github.com/users/metricfu/followers","following_url":"https://api.github.com/users/metricfu/following{/other_user}","gists_url":"https://api.github.com/users/metricfu/gists{/gist_id}","starred_url":"https://api.github.com/users/metricfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metricfu/subscriptions","organizations_url":"https://api.github.com/users/metricfu/orgs","repos_url":"https://api.github.com/users/metricfu/repos","events_url":"https://api.github.com/users/metricfu/events{/privacy}","received_events_url":"https://api.github.com/users/metricfu/received_events","type":"Organization","site_admin":false},"repo":{"id":4979793,"name":"metric_fu","full_name":"metricfu/metric_fu","owner":{"login":"metricfu","id":3143951,"avatar_url":"https://avatars.githubusercontent.com/u/3143951?v=3","gravatar_id":"","url":"https://api.github.com/users/metricfu","html_url":"https://github.com/metricfu","followers_url":"https://api.github.com/users/metricfu/followers","following_url":"https://api.github.com/users/metricfu/following{/other_user}","gists_url":"https://api.github.com/users/metricfu/gists{/gist_id}","starred_url":"https://api.github.com/users/metricfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metricfu/subscriptions","organizations_url":"https://api.github.com/users/metricfu/orgs","repos_url":"https://api.github.com/users/metricfu/repos","events_url":"https://api.github.com/users/metricfu/events{/privacy}","received_events_url":"https://api.github.com/users/metricfu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metricfu/metric_fu","description":"A fist full of code metrics","fork":true,"url":"https://api.github.com/repos/metricfu/metric_fu","forks_url":"https://api.github.com/repos/metricfu/metric_fu/forks","keys_url":"https://api.github.com/repos/metricfu/metric_fu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metricfu/metric_fu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metricfu/metric_fu/teams","hooks_url":"https://api.github.com/repos/metricfu/metric_fu/hooks","issue_events_url":"https://api.github.com/repos/metricfu/metric_fu/issues/events{/number}","events_url":"https://api.github.com/repos/metricfu/metric_fu/events","assignees_url":"https://api.github.com/repos/metricfu/metric_fu/assignees{/user}","branches_url":"https://api.github.com/repos/metricfu/metric_fu/branches{/branch}","tags_url":"https://api.github.com/repos/metricfu/metric_fu/tags","blobs_url":"https://api.github.com/repos/metricfu/metric_fu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metricfu/metric_fu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metricfu/metric_fu/git/refs{/sha}","trees_url":"https://api.github.com/repos/metricfu/metric_fu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metricfu/metric_fu/statuses/{sha}","languages_url":"https://api.github.com/repos/metricfu/metric_fu/languages","stargazers_url":"https://api.github.com/repos/metricfu/metric_fu/stargazers","contributors_url":"https://api.github.com/repos/metricfu/metric_fu/contributors","subscribers_url":"https://api.github.com/repos/metricfu/metric_fu/subscribers","subscription_url":"https://api.github.com/repos/metricfu/metric_fu/subscription","commits_url":"https://api.github.com/repos/metricfu/metric_fu/commits{/sha}","git_commits_url":"https://api.github.com/repos/metricfu/metric_fu/git/commits{/sha}","comments_url":"https://api.github.com/repos/metricfu/metric_fu/comments{/number}","issue_comment_url":"https://api.github.com/repos/metricfu/metric_fu/issues/comments{/number}","contents_url":"https://api.github.com/repos/metricfu/metric_fu/contents/{+path}","compare_url":"https://api.github.com/repos/metricfu/metric_fu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metricfu/metric_fu/merges","archive_url":"https://api.github.com/repos/metricfu/metric_fu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metricfu/metric_fu/downloads","issues_url":"https://api.github.com/repos/metricfu/metric_fu/issues{/number}","pulls_url":"https://api.github.com/repos/metricfu/metric_fu/pulls{/number}","milestones_url":"https://api.github.com/repos/metricfu/metric_fu/milestones{/number}","notifications_url":"https://api.github.com/repos/metricfu/metric_fu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metricfu/metric_fu/labels{/name}","releases_url":"https://api.github.com/repos/metricfu/metric_fu/releases{/id}","created_at":"2012-07-10T20:10:14Z","updated_at":"2015-05-18T13:59:38Z","pushed_at":"2015-05-18T20:37:25Z","git_url":"git://github.com/metricfu/metric_fu.git","ssh_url":"git@github.com:metricfu/metric_fu.git","clone_url":"https://github.com/metricfu/metric_fu.git","svn_url":"https://github.com/metricfu/metric_fu","homepage":"http://metricfu.github.com/metric_fu","size":13274,"stargazers_count":431,"watchers_count":431,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":21,"forks":70,"open_issues":21,"watchers":431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metricfu/metric_fu/pulls/260"},"html":{"href":"https://github.com/metricfu/metric_fu/pull/260"},"issue":{"href":"https://api.github.com/repos/metricfu/metric_fu/issues/260"},"comments":{"href":"https://api.github.com/repos/metricfu/metric_fu/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/metricfu/metric_fu/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/metricfu/metric_fu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metricfu/metric_fu/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/metricfu/metric_fu/statuses/84ef8c8839f58e0e07d0bd0ee3ad104ad49317a1"}}}}