{"action":"created","issue":{"url":"https://api.github.com/repos/chef/chef/issues/3524","labels_url":"https://api.github.com/repos/chef/chef/issues/3524/labels{/name}","comments_url":"https://api.github.com/repos/chef/chef/issues/3524/comments","events_url":"https://api.github.com/repos/chef/chef/issues/3524/events","html_url":"https://github.com/chef/chef/issues/3524","id":87568202,"number":3524,"title":"Resource and provider resolver fallback non-functional","user":{"login":"coderanger","id":128243,"avatar_url":"https://avatars.githubusercontent.com/u/128243?v=3","gravatar_id":"","url":"https://api.github.com/users/coderanger","html_url":"https://github.com/coderanger","followers_url":"https://api.github.com/users/coderanger/followers","following_url":"https://api.github.com/users/coderanger/following{/other_user}","gists_url":"https://api.github.com/users/coderanger/gists{/gist_id}","starred_url":"https://api.github.com/users/coderanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderanger/subscriptions","organizations_url":"https://api.github.com/users/coderanger/orgs","repos_url":"https://api.github.com/users/coderanger/repos","events_url":"https://api.github.com/users/coderanger/events{/privacy}","received_events_url":"https://api.github.com/users/coderanger/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"jkeiser","id":654882,"avatar_url":"https://avatars.githubusercontent.com/u/654882?v=3","gravatar_id":"","url":"https://api.github.com/users/jkeiser","html_url":"https://github.com/jkeiser","followers_url":"https://api.github.com/users/jkeiser/followers","following_url":"https://api.github.com/users/jkeiser/following{/other_user}","gists_url":"https://api.github.com/users/jkeiser/gists{/gist_id}","starred_url":"https://api.github.com/users/jkeiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkeiser/subscriptions","organizations_url":"https://api.github.com/users/jkeiser/orgs","repos_url":"https://api.github.com/users/jkeiser/repos","events_url":"https://api.github.com/users/jkeiser/events{/privacy}","received_events_url":"https://api.github.com/users/jkeiser/received_events","type":"User","site_admin":false},"milestone":null,"comments":13,"created_at":"2015-06-12T01:36:45Z","updated_at":"2015-06-17T00:26:23Z","closed_at":"2015-06-17T00:16:19Z","body":"The code used for the non-`provides()` lookup on resources and providers is non-functional as far as I can tell.\r\n\r\n[The code looks like](https://github.com/chef/chef/blob/master/lib/chef/resource_resolver.rb#L143):\r\n\r\n```ruby\r\n@prioritized_handlers ||= super ||\r\n```\r\n\r\nbut `super` returns an empty array, not `nil` so the fallback code never runs.\r\n\r\nPing @jkeiser and @thommay (I think this is probably a release blocker for RC2)"},"comment":{"url":"https://api.github.com/repos/chef/chef/issues/comments/112610138","html_url":"https://github.com/chef/chef/issues/3524#issuecomment-112610138","issue_url":"https://api.github.com/repos/chef/chef/issues/3524","id":112610138,"user":{"login":"coderanger","id":128243,"avatar_url":"https://avatars.githubusercontent.com/u/128243?v=3","gravatar_id":"","url":"https://api.github.com/users/coderanger","html_url":"https://github.com/coderanger","followers_url":"https://api.github.com/users/coderanger/followers","following_url":"https://api.github.com/users/coderanger/following{/other_user}","gists_url":"https://api.github.com/users/coderanger/gists{/gist_id}","starred_url":"https://api.github.com/users/coderanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderanger/subscriptions","organizations_url":"https://api.github.com/users/coderanger/orgs","repos_url":"https://api.github.com/users/coderanger/repos","events_url":"https://api.github.com/users/coderanger/events{/privacy}","received_events_url":"https://api.github.com/users/coderanger/received_events","type":"User","site_admin":false},"created_at":"2015-06-17T00:26:23Z","updated_at":"2015-06-17T00:26:23Z","body":"This is not fixed, the line https://github.com/chef/chef/blob/master/lib/chef/resource_resolver.rb#L143 is still incorrect and represents two bugs:\r\n\r\n1. The second part of the `||` can never fire.\r\n2. The second part of the `||` can trivially cause infinite loops.\r\n\r\nBasically we should remove that whole warning, I don't think there is any safe way to implement it and only looks like it works right now because it never gets called."}}