{"action":"created","issue":{"url":"https://api.github.com/repos/laurentpetit/ccw/issues/776","labels_url":"https://api.github.com/repos/laurentpetit/ccw/issues/776/labels{/name}","comments_url":"https://api.github.com/repos/laurentpetit/ccw/issues/776/comments","events_url":"https://api.github.com/repos/laurentpetit/ccw/issues/776/events","html_url":"https://github.com/laurentpetit/ccw/pull/776","id":77650514,"number":776,"title":"Macro expansion hover","user":{"login":"arichiardi","id":1724788,"avatar_url":"https://avatars.githubusercontent.com/u/1724788?v=3","gravatar_id":"","url":"https://api.github.com/users/arichiardi","html_url":"https://github.com/arichiardi","followers_url":"https://api.github.com/users/arichiardi/followers","following_url":"https://api.github.com/users/arichiardi/following{/other_user}","gists_url":"https://api.github.com/users/arichiardi/gists{/gist_id}","starred_url":"https://api.github.com/users/arichiardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichiardi/subscriptions","organizations_url":"https://api.github.com/users/arichiardi/orgs","repos_url":"https://api.github.com/users/arichiardi/repos","events_url":"https://api.github.com/users/arichiardi/events{/privacy}","received_events_url":"https://api.github.com/users/arichiardi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/laurentpetit/ccw/labels/To%20Review","name":"To Review","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"laurentpetit","id":98286,"avatar_url":"https://avatars.githubusercontent.com/u/98286?v=3","gravatar_id":"","url":"https://api.github.com/users/laurentpetit","html_url":"https://github.com/laurentpetit","followers_url":"https://api.github.com/users/laurentpetit/followers","following_url":"https://api.github.com/users/laurentpetit/following{/other_user}","gists_url":"https://api.github.com/users/laurentpetit/gists{/gist_id}","starred_url":"https://api.github.com/users/laurentpetit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurentpetit/subscriptions","organizations_url":"https://api.github.com/users/laurentpetit/orgs","repos_url":"https://api.github.com/users/laurentpetit/repos","events_url":"https://api.github.com/users/laurentpetit/events{/privacy}","received_events_url":"https://api.github.com/users/laurentpetit/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/laurentpetit/ccw/milestones/1","html_url":"https://github.com/laurentpetit/ccw/milestones/0.31.2","labels_url":"https://api.github.com/repos/laurentpetit/ccw/milestones/1/labels","id":1033063,"number":1,"title":"0.31.2","description":"","creator":{"login":"laurentpetit","id":98286,"avatar_url":"https://avatars.githubusercontent.com/u/98286?v=3","gravatar_id":"","url":"https://api.github.com/users/laurentpetit","html_url":"https://github.com/laurentpetit","followers_url":"https://api.github.com/users/laurentpetit/followers","following_url":"https://api.github.com/users/laurentpetit/following{/other_user}","gists_url":"https://api.github.com/users/laurentpetit/gists{/gist_id}","starred_url":"https://api.github.com/users/laurentpetit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurentpetit/subscriptions","organizations_url":"https://api.github.com/users/laurentpetit/orgs","repos_url":"https://api.github.com/users/laurentpetit/repos","events_url":"https://api.github.com/users/laurentpetit/events{/privacy}","received_events_url":"https://api.github.com/users/laurentpetit/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":26,"state":"open","created_at":"2015-03-22T22:18:56Z","updated_at":"2015-05-21T16:17:09Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2015-05-18T13:08:12Z","updated_at":"2015-05-21T19:21:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/laurentpetit/ccw/pulls/776","html_url":"https://github.com/laurentpetit/ccw/pull/776","diff_url":"https://github.com/laurentpetit/ccw/pull/776.diff","patch_url":"https://github.com/laurentpetit/ccw/pull/776.patch"},"body":"Hello Laurent,\r\nI so like this addition :smile:  I still have some problem with the size of the html hover with ```<pre>``` tags, but I am going to try some other hack to make it work...nonetheless, it correctly shows hover expansion...and I reckon it can be very useful for users.\r\n\r\nForm the git message:\r\n\r\n    a second hover, which performs macro expansion if a repl is available, has been added to the group.\r\n    It expands using either the standard clojure.core/macroexpand method or cider-nrepl middleware (which has been configured with display-namespaces=tidy).\r\n    The Macro hover has default key modifier set to Ctrl.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/laurentpetit/ccw/issues/comments/104393777","html_url":"https://github.com/laurentpetit/ccw/pull/776#issuecomment-104393777","issue_url":"https://api.github.com/repos/laurentpetit/ccw/issues/776","id":104393777,"user":{"login":"laurentpetit","id":98286,"avatar_url":"https://avatars.githubusercontent.com/u/98286?v=3","gravatar_id":"","url":"https://api.github.com/users/laurentpetit","html_url":"https://github.com/laurentpetit","followers_url":"https://api.github.com/users/laurentpetit/followers","following_url":"https://api.github.com/users/laurentpetit/following{/other_user}","gists_url":"https://api.github.com/users/laurentpetit/gists{/gist_id}","starred_url":"https://api.github.com/users/laurentpetit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurentpetit/subscriptions","organizations_url":"https://api.github.com/users/laurentpetit/orgs","repos_url":"https://api.github.com/users/laurentpetit/repos","events_url":"https://api.github.com/users/laurentpetit/events{/privacy}","received_events_url":"https://api.github.com/users/laurentpetit/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T19:21:23Z","updated_at":"2015-05-21T19:21:23Z","body":"Actually, a REPLView knows which corresponding REPL, it's itself ! Same for the safe connection, it's derived from itself! I hadn't noticed this regression sooner in the refactoring.\r\nSo yes, the REPL view is totally aware that it is a REPL, if you ask me :-)\r\n\r\nThe subject of REPL affinity for editors / projects is a tough one. The current situation, which is \"always send to the corresponding REPL - which is defined as 'last active REPL' for editors, and 'this for REPLs-\" is the one which makes thinks very easy to explain, very easy to understand, and very powerful (no restriction for the user).\r\n\r\nFor instance, it allows to send code from any editor to the last active repl. No need to \"bind\" things, to rely on workspace resolution between projects, etc.\r\n\r\nThe problem is that with the advent of ClojureScript, there IS the need for REPL affinity, at least for code seen as clojure versus clojurescript.\r\n\r\nBut having been there already, I would be very careful before trying to be \"too smart\" at the cost of making things hard to understand for users."}}