{"action":"created","issue":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4635","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4635/labels{/name}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4635/comments","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4635/events","html_url":"https://github.com/DynamoDS/Dynamo/pull/4635","id":85238904,"number":4635,"title":"PublishButton greyed out - MAGN 7569","user":{"login":"holyjewsus","id":508936,"avatar_url":"https://avatars.githubusercontent.com/u/508936?v=3","gravatar_id":"","url":"https://api.github.com/users/holyjewsus","html_url":"https://github.com/holyjewsus","followers_url":"https://api.github.com/users/holyjewsus/followers","following_url":"https://api.github.com/users/holyjewsus/following{/other_user}","gists_url":"https://api.github.com/users/holyjewsus/gists{/gist_id}","starred_url":"https://api.github.com/users/holyjewsus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holyjewsus/subscriptions","organizations_url":"https://api.github.com/users/holyjewsus/orgs","repos_url":"https://api.github.com/users/holyjewsus/repos","events_url":"https://api.github.com/users/holyjewsus/events{/privacy}","received_events_url":"https://api.github.com/users/holyjewsus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DynamoDS/Dynamo/labels/PTAL","name":"PTAL","color":"207de5"}],"state":"open","locked":false,"assignee":{"login":"pboyer","id":916345,"avatar_url":"https://avatars.githubusercontent.com/u/916345?v=3","gravatar_id":"","url":"https://api.github.com/users/pboyer","html_url":"https://github.com/pboyer","followers_url":"https://api.github.com/users/pboyer/followers","following_url":"https://api.github.com/users/pboyer/following{/other_user}","gists_url":"https://api.github.com/users/pboyer/gists{/gist_id}","starred_url":"https://api.github.com/users/pboyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboyer/subscriptions","organizations_url":"https://api.github.com/users/pboyer/orgs","repos_url":"https://api.github.com/users/pboyer/repos","events_url":"https://api.github.com/users/pboyer/events{/privacy}","received_events_url":"https://api.github.com/users/pboyer/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-06-04T19:20:34Z","updated_at":"2015-06-11T18:50:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4635","html_url":"https://github.com/DynamoDS/Dynamo/pull/4635","diff_url":"https://github.com/DynamoDS/Dynamo/pull/4635.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/4635.patch"},"body":"… a can execute changed event on the submitCommand, this is raised when package contents changed when custom nodes or dlls are added\r\n\r\n\r\n### Purpose\r\nCan't upload packages, Publish! button is greyed out.\r\nhttp://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-7569\r\n\r\nI could reproduce this bug when adding custom nodes or dlls as the last step in the package info form fillout, I.E adding name, description .... finally a custom node.  Customnodes raise property notification manually not in a setter, and when OnSubmit bool is checked again we do not raise a can execute changed event on the SubmitCommand, which is bound to the button state. I just added this invoke to the property change handler on the view model. \r\n\r\n![screen shot 2015-06-04 at 3 14 16 pm](https://cloud.githubusercontent.com/assets/508936/7992415/26bc00ae-0acd-11e5-9ac4-90f997369a4e.png)\r\n\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [X] The code base is in a better state after this PR\r\n- [?] The level of testing this PR includes is appropriate, - @pboyer should this have a test? Not sure how this would work, is there a nice way to mock auth provider?\r\n\r\n### Reviewers\r\n\r\n@pboyer \r\n(if Peter does not have bandwidth, @ikeough or @lukechurch could merge)\r\n### FYIs\r\n\r\n@jnealb testing, have you encountered this bug when not adding package content as the last step?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments/111237481","html_url":"https://github.com/DynamoDS/Dynamo/pull/4635#issuecomment-111237481","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4635","id":111237481,"user":{"login":"holyjewsus","id":508936,"avatar_url":"https://avatars.githubusercontent.com/u/508936?v=3","gravatar_id":"","url":"https://api.github.com/users/holyjewsus","html_url":"https://github.com/holyjewsus","followers_url":"https://api.github.com/users/holyjewsus/followers","following_url":"https://api.github.com/users/holyjewsus/following{/other_user}","gists_url":"https://api.github.com/users/holyjewsus/gists{/gist_id}","starred_url":"https://api.github.com/users/holyjewsus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holyjewsus/subscriptions","organizations_url":"https://api.github.com/users/holyjewsus/orgs","repos_url":"https://api.github.com/users/holyjewsus/repos","events_url":"https://api.github.com/users/holyjewsus/events{/privacy}","received_events_url":"https://api.github.com/users/holyjewsus/received_events","type":"User","site_admin":false},"created_at":"2015-06-11T18:50:00Z","updated_at":"2015-06-11T18:50:00Z","body":"@pboyer passes on CI, test failure was a failing test from Ben's fix for run settings on Home workspacemodel.  If you are okay with the test, then OK to merge."}}