{"action":"created","comment":{"url":"https://api.github.com/repos/iojs/io.js/pulls/comments/28048046","id":28048046,"diff_hunk":"@@ -7,8 +7,10 @@ const util = require('util');\n const assert = require('assert');\n const cares = process.binding('cares_wrap');\n const uv = process.binding('uv');\n-const Pipe = process.binding('pipe_wrap').Pipe;\n \n+const TTY = process.binding('tty_wrap');","path":"lib/net.js","position":6,"original_position":6,"commit_id":"b44e373604eb5b23877a4741f6f0ae67eacf1057","original_commit_id":"b44e373604eb5b23877a4741f6f0ae67eacf1057","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"The naming suggests it's the TTY constructor but it's really the tty_wrap object (which has the constructor as a property.)","created_at":"2015-04-09T09:40:04Z","updated_at":"2015-04-09T09:40:04Z","html_url":"https://github.com/iojs/io.js/pull/1367#discussion_r28048046","pull_request_url":"https://api.github.com/repos/iojs/io.js/pulls/1367","_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/28048046"},"html":{"href":"https://github.com/iojs/io.js/pull/1367#discussion_r28048046"},"pull_request":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1367"}}},"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/1367","id":32820484,"html_url":"https://github.com/iojs/io.js/pull/1367","diff_url":"https://github.com/iojs/io.js/pull/1367.diff","patch_url":"https://github.com/iojs/io.js/pull/1367.patch","issue_url":"https://api.github.com/repos/iojs/io.js/issues/1367","number":1367,"state":"open","locked":false,"title":"lib: reduce process.binding() calls","user":{"login":"brendanashworth","id":3038254,"avatar_url":"https://avatars.githubusercontent.com/u/3038254?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanashworth","html_url":"https://github.com/brendanashworth","followers_url":"https://api.github.com/users/brendanashworth/followers","following_url":"https://api.github.com/users/brendanashworth/following{/other_user}","gists_url":"https://api.github.com/users/brendanashworth/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanashworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanashworth/subscriptions","organizations_url":"https://api.github.com/users/brendanashworth/orgs","repos_url":"https://api.github.com/users/brendanashworth/repos","events_url":"https://api.github.com/users/brendanashworth/events{/privacy}","received_events_url":"https://api.github.com/users/brendanashworth/received_events","type":"User","site_admin":false},"body":"This commit reduces the amount of times `process.binding()` is called by\r\nbetter lazy loading the values and always using a variable to hold the\r\nvalue instead of loading it each time.\r\n\r\nThis is important because, in my benchmarks, running process.binding()\r\nis about 172 times slower as referencing a variable with the same\r\nvalue.","created_at":"2015-04-08T01:03:58Z","updated_at":"2015-04-09T09:40:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3d94a5943c517de99ee7ac6b9dfc07bca77446d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iojs/io.js/pulls/1367/commits","review_comments_url":"https://api.github.com/repos/iojs/io.js/pulls/1367/comments","review_comment_url":"https://api.github.com/repos/iojs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/1367/comments","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/b44e373604eb5b23877a4741f6f0ae67eacf1057","head":{"label":"brendanashworth:reduce-process-binding","ref":"reduce-process-binding","sha":"b44e373604eb5b23877a4741f6f0ae67eacf1057","user":{"login":"brendanashworth","id":3038254,"avatar_url":"https://avatars.githubusercontent.com/u/3038254?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanashworth","html_url":"https://github.com/brendanashworth","followers_url":"https://api.github.com/users/brendanashworth/followers","following_url":"https://api.github.com/users/brendanashworth/following{/other_user}","gists_url":"https://api.github.com/users/brendanashworth/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanashworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanashworth/subscriptions","organizations_url":"https://api.github.com/users/brendanashworth/orgs","repos_url":"https://api.github.com/users/brendanashworth/repos","events_url":"https://api.github.com/users/brendanashworth/events{/privacy}","received_events_url":"https://api.github.com/users/brendanashworth/received_events","type":"User","site_admin":false},"repo":{"id":27578495,"name":"io.js","full_name":"brendanashworth/io.js","owner":{"login":"brendanashworth","id":3038254,"avatar_url":"https://avatars.githubusercontent.com/u/3038254?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanashworth","html_url":"https://github.com/brendanashworth","followers_url":"https://api.github.com/users/brendanashworth/followers","following_url":"https://api.github.com/users/brendanashworth/following{/other_user}","gists_url":"https://api.github.com/users/brendanashworth/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanashworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanashworth/subscriptions","organizations_url":"https://api.github.com/users/brendanashworth/orgs","repos_url":"https://api.github.com/users/brendanashworth/repos","events_url":"https://api.github.com/users/brendanashworth/events{/privacy}","received_events_url":"https://api.github.com/users/brendanashworth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brendanashworth/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/brendanashworth/io.js","forks_url":"https://api.github.com/repos/brendanashworth/io.js/forks","keys_url":"https://api.github.com/repos/brendanashworth/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brendanashworth/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brendanashworth/io.js/teams","hooks_url":"https://api.github.com/repos/brendanashworth/io.js/hooks","issue_events_url":"https://api.github.com/repos/brendanashworth/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/brendanashworth/io.js/events","assignees_url":"https://api.github.com/repos/brendanashworth/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/brendanashworth/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/brendanashworth/io.js/tags","blobs_url":"https://api.github.com/repos/brendanashworth/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brendanashworth/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brendanashworth/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/brendanashworth/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brendanashworth/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/brendanashworth/io.js/languages","stargazers_url":"https://api.github.com/repos/brendanashworth/io.js/stargazers","contributors_url":"https://api.github.com/repos/brendanashworth/io.js/contributors","subscribers_url":"https://api.github.com/repos/brendanashworth/io.js/subscribers","subscription_url":"https://api.github.com/repos/brendanashworth/io.js/subscription","commits_url":"https://api.github.com/repos/brendanashworth/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/brendanashworth/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/brendanashworth/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/brendanashworth/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/brendanashworth/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/brendanashworth/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brendanashworth/io.js/merges","archive_url":"https://api.github.com/repos/brendanashworth/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brendanashworth/io.js/downloads","issues_url":"https://api.github.com/repos/brendanashworth/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/brendanashworth/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/brendanashworth/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/brendanashworth/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brendanashworth/io.js/labels{/name}","releases_url":"https://api.github.com/repos/brendanashworth/io.js/releases{/id}","created_at":"2014-12-05T06:43:32Z","updated_at":"2015-04-06T04:14:04Z","pushed_at":"2015-04-08T03:11:41Z","git_url":"git://github.com/brendanashworth/io.js.git","ssh_url":"git@github.com:brendanashworth/io.js.git","clone_url":"https://github.com/brendanashworth/io.js.git","svn_url":"https://github.com/brendanashworth/io.js","homepage":null,"size":124580,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"iojs:v1.x","ref":"v1.x","sha":"264a8f3a1b1a46d813d244e811a6f6d12ad513ac","user":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"iojs/io.js","owner":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iojs/io.js","description":"A friendly fork of Node.js with an open governance model","fork":false,"url":"https://api.github.com/repos/iojs/io.js","forks_url":"https://api.github.com/repos/iojs/io.js/forks","keys_url":"https://api.github.com/repos/iojs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iojs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iojs/io.js/teams","hooks_url":"https://api.github.com/repos/iojs/io.js/hooks","issue_events_url":"https://api.github.com/repos/iojs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/iojs/io.js/events","assignees_url":"https://api.github.com/repos/iojs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/iojs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/iojs/io.js/tags","blobs_url":"https://api.github.com/repos/iojs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iojs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iojs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/iojs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/iojs/io.js/languages","stargazers_url":"https://api.github.com/repos/iojs/io.js/stargazers","contributors_url":"https://api.github.com/repos/iojs/io.js/contributors","subscribers_url":"https://api.github.com/repos/iojs/io.js/subscribers","subscription_url":"https://api.github.com/repos/iojs/io.js/subscription","commits_url":"https://api.github.com/repos/iojs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/iojs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/iojs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/iojs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/iojs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/iojs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iojs/io.js/merges","archive_url":"https://api.github.com/repos/iojs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iojs/io.js/downloads","issues_url":"https://api.github.com/repos/iojs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/iojs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/iojs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/iojs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iojs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/iojs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-04-09T09:36:28Z","pushed_at":"2015-04-09T09:39:11Z","git_url":"git://github.com/iojs/io.js.git","ssh_url":"git@github.com:iojs/io.js.git","clone_url":"https://github.com/iojs/io.js.git","svn_url":"https://github.com/iojs/io.js","homepage":"https://iojs.org","size":168380,"stargazers_count":11568,"watchers_count":11568,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":817,"mirror_url":null,"open_issues_count":216,"forks":817,"open_issues":216,"watchers":11568,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1367"},"html":{"href":"https://github.com/iojs/io.js/pull/1367"},"issue":{"href":"https://api.github.com/repos/iojs/io.js/issues/1367"},"comments":{"href":"https://api.github.com/repos/iojs/io.js/issues/1367/comments"},"review_comments":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1367/comments"},"review_comment":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1367/commits"},"statuses":{"href":"https://api.github.com/repos/iojs/io.js/statuses/b44e373604eb5b23877a4741f6f0ae67eacf1057"}}}}