{"action":"created","issue":{"url":"https://api.github.com/repos/dperezde/little-penguin/issues/2","labels_url":"https://api.github.com/repos/dperezde/little-penguin/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/dperezde/little-penguin/issues/2/comments","events_url":"https://api.github.com/repos/dperezde/little-penguin/issues/2/events","html_url":"https://github.com/dperezde/little-penguin/issues/2","id":109034645,"number":2,"title":"T04","user":{"login":"dperezde","id":6975007,"avatar_url":"https://avatars.githubusercontent.com/u/6975007?v=3","gravatar_id":"","url":"https://api.github.com/users/dperezde","html_url":"https://github.com/dperezde","followers_url":"https://api.github.com/users/dperezde/followers","following_url":"https://api.github.com/users/dperezde/following{/other_user}","gists_url":"https://api.github.com/users/dperezde/gists{/gist_id}","starred_url":"https://api.github.com/users/dperezde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperezde/subscriptions","organizations_url":"https://api.github.com/users/dperezde/orgs","repos_url":"https://api.github.com/users/dperezde/repos","events_url":"https://api.github.com/users/dperezde/events{/privacy}","received_events_url":"https://api.github.com/users/dperezde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-30T07:52:02Z","updated_at":"2015-10-13T10:14:54Z","closed_at":null,"body":"Wonderful job in making it this far.  I hope you have been having fun.\r\nOh, you're getting bored, just booting and installing kernels?  Well,\r\ntime for some pedantic things to make you feel that those kernel builds\r\nare actually fun!\r\n\r\nPart of the job of being a kernel developer is recognizing the proper\r\nLinux kernel coding style.  The full description of this coding style\r\ncan be found in the kernel itself, in the Documentation/CodingStyle\r\nfile.  I'd recommend going and reading that right now.  It's pretty\r\nsimple stuff, and something that you are going to need to know and\r\nunderstand.  There is also a tool in the kernel source tree in the\r\nscripts/ directory called checkpatch.pl that can be used to test for\r\nadhering to the coding style rules, as kernel programmers are lazy and\r\nprefer to let scripts do their work for them...\r\n\r\nWhy a coding standard at all?  Because of your brain (yes, yours, not\r\nmine, remember, I'm just some dumb shell scripts).  Once your brain\r\nlearns the patterns, the information contained really starts to sink in\r\nbetter.  So it's important that everyone follow the same standard so\r\nthat the patterns become consistent.  In other words, you want to make\r\nit really easy for other people to find the bugs in your code, and not\r\nbe confused and distracted by the fact that you happen to prefer 5\r\nspaces instead of tabs for indentation.  Of course you would never\r\nprefer such a thing, I'd never accuse you of that, it was just an\r\nexample, please forgive my impertinence!\r\n\r\nAnyway, the tasks for this round all deal with the Linux kernel coding\r\nstyle.  Attached to this message are is one kernel module that does not\r\nfollow the proper Linux kernel coding style rules.  Fix this file up,\r\nAND fix up the final submission you did for Task 01, and send them back\r\nto me as attachments in your response email.\r\n\r\nYes, the logic in attached second module is crazy, and probably wrong,\r\nbut don't focus on that, just look at the patterns here, and fix up the\r\ncoding style, do not remove lines of code.\r\n\r\nOh, and before you think \"Ah, but I got the coding style right for Task\r\n01, I already know this stuff!\", remember that so far only 10 people,\r\nout of over 4000, have gotten the coding style exactly right for their\r\nTask 01 module.  Yes, you could be one of those people, but the odds are\r\nnot in your favor.  You should look at it again just to be sure.\r\n\r\nSo again, attach 2 files, this one fixed up, and your Task 01\r\nsubmission.  Don't use base64 either, the scripts will instantly reject\r\nit, you don't want to get on their bad side."},"comment":{"url":"https://api.github.com/repos/dperezde/little-penguin/issues/comments/147672416","html_url":"https://github.com/dperezde/little-penguin/issues/2#issuecomment-147672416","issue_url":"https://api.github.com/repos/dperezde/little-penguin/issues/2","id":147672416,"user":{"login":"dperezde","id":6975007,"avatar_url":"https://avatars.githubusercontent.com/u/6975007?v=3","gravatar_id":"","url":"https://api.github.com/users/dperezde","html_url":"https://github.com/dperezde","followers_url":"https://api.github.com/users/dperezde/followers","following_url":"https://api.github.com/users/dperezde/following{/other_user}","gists_url":"https://api.github.com/users/dperezde/gists{/gist_id}","starred_url":"https://api.github.com/users/dperezde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperezde/subscriptions","organizations_url":"https://api.github.com/users/dperezde/orgs","repos_url":"https://api.github.com/users/dperezde/repos","events_url":"https://api.github.com/users/dperezde/events{/privacy}","received_events_url":"https://api.github.com/users/dperezde/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T10:14:54Z","updated_at":"2015-10-13T10:14:54Z","body":"Little commented:\r\n> Why did you change the logging level?"}}