{"action":"created","issue":{"url":"https://api.github.com/repos/xoreos/xoreos/issues/113","labels_url":"https://api.github.com/repos/xoreos/xoreos/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/xoreos/xoreos/issues/113/comments","events_url":"https://api.github.com/repos/xoreos/xoreos/issues/113/events","html_url":"https://github.com/xoreos/xoreos/pull/113","id":121290455,"number":113,"title":"EVENTS: Add counter to EventsManager::keyRepeat","user":{"login":"Koffeinfriedhof","id":16226571,"avatar_url":"https://avatars.githubusercontent.com/u/16226571?v=3","gravatar_id":"","url":"https://api.github.com/users/Koffeinfriedhof","html_url":"https://github.com/Koffeinfriedhof","followers_url":"https://api.github.com/users/Koffeinfriedhof/followers","following_url":"https://api.github.com/users/Koffeinfriedhof/following{/other_user}","gists_url":"https://api.github.com/users/Koffeinfriedhof/gists{/gist_id}","starred_url":"https://api.github.com/users/Koffeinfriedhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Koffeinfriedhof/subscriptions","organizations_url":"https://api.github.com/users/Koffeinfriedhof/orgs","repos_url":"https://api.github.com/users/Koffeinfriedhof/repos","events_url":"https://api.github.com/users/Koffeinfriedhof/events{/privacy}","received_events_url":"https://api.github.com/users/Koffeinfriedhof/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-12-09T16:52:55Z","updated_at":"2015-12-12T18:08:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xoreos/xoreos/pulls/113","html_url":"https://github.com/xoreos/xoreos/pull/113","diff_url":"https://github.com/xoreos/xoreos/pull/113.diff","patch_url":"https://github.com/xoreos/xoreos/pull/113.patch"},"body":"Make keyboard states recursive/re-entrant\r\n\r\nhttps://github.com/xoreos/xoreos/issues/99"},"comment":{"url":"https://api.github.com/repos/xoreos/xoreos/issues/comments/164172883","html_url":"https://github.com/xoreos/xoreos/pull/113#issuecomment-164172883","issue_url":"https://api.github.com/repos/xoreos/xoreos/issues/113","id":164172883,"user":{"login":"DrMcCoy","id":156130,"avatar_url":"https://avatars.githubusercontent.com/u/156130?v=3","gravatar_id":"","url":"https://api.github.com/users/DrMcCoy","html_url":"https://github.com/DrMcCoy","followers_url":"https://api.github.com/users/DrMcCoy/followers","following_url":"https://api.github.com/users/DrMcCoy/following{/other_user}","gists_url":"https://api.github.com/users/DrMcCoy/gists{/gist_id}","starred_url":"https://api.github.com/users/DrMcCoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrMcCoy/subscriptions","organizations_url":"https://api.github.com/users/DrMcCoy/orgs","repos_url":"https://api.github.com/users/DrMcCoy/repos","events_url":"https://api.github.com/users/DrMcCoy/events{/privacy}","received_events_url":"https://api.github.com/users/DrMcCoy/received_events","type":"User","site_admin":false},"created_at":"2015-12-12T18:08:14Z","updated_at":"2015-12-12T18:08:14Z","body":"Neat. :)\r\n\r\nThere is, unfortunately, another issue. I just ran xoreos with your changes, and it immediately dies with \"ERROR: EventsManager::enableTextInput(): Counter underrun\".\r\n\r\nThe problem is the `enableTextInput(false)` line in EventsManager::init(), in events.cpp:81. This is there to make sure that the init() function always disables text input.\r\n\r\nThe fix I propose is to set `_textInputCounter` to 1 before that `enableTextInput(false)` line. (You can then also remove the line below that sets it to 0). This, again, should be squashed into the commit enableTextInput commit, since it still belongs in there.\r\n\r\nWhile you're at it, can you add an explanatory sentence to the commit message of both commits (not in the first line; leave the second line empty, and then start writing in the third line)? Something like \"This is part of the implementation to make keyboard states re-entrant (see GitHub issue #99)\"."}}