{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/37076156","id":37076156,"diff_hunk":"@@ -195,10 +228,29 @@ class PFRecoTauDiscriminationByIsolation : public PFTauDiscriminationProducerBas\n   double offsetRelativeSumPt_;\n   double customIsoCone_;\n   \n+  bool applyPhotonPtSumOutsideSignalConeCut_;\n+  double maxAbsPhotonSumPt_outsideSignalCone_;\n+  double maxRelPhotonSumPt_outsideSignalCone_;\n+\n+  bool applyFootprintCorrection_;\n+  struct footprintCorrectionType\n+  {\n+    footprintCorrectionType(const std::string& selection, const std::string& offset)\n+      : selection_(selection),\n+\toffset_(offset)\n+    {}\n+    ~footprintCorrectionType() {}\n+    StringCutObjectSelector<PFTau> selection_;\n+    StringObjectFunction<PFTau> offset_;\n+  };\n+  std::vector<footprintCorrectionType*> footprintCorrections_;","path":"RecoTauTag/RecoTau/plugins/PFRecoTauDiscriminationByIsolation.cc","position":135,"original_position":135,"commit_id":"398866a1db973cb65ff7c87aaf76d1c71c08662d","original_commit_id":"398866a1db973cb65ff7c87aaf76d1c71c08662d","user":{"login":"andrewj314","id":6199470,"avatar_url":"https://avatars.githubusercontent.com/u/6199470?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewj314","html_url":"https://github.com/andrewj314","followers_url":"https://api.github.com/users/andrewj314/followers","following_url":"https://api.github.com/users/andrewj314/following{/other_user}","gists_url":"https://api.github.com/users/andrewj314/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewj314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewj314/subscriptions","organizations_url":"https://api.github.com/users/andrewj314/orgs","repos_url":"https://api.github.com/users/andrewj314/repos","events_url":"https://api.github.com/users/andrewj314/events{/privacy}","received_events_url":"https://api.github.com/users/andrewj314/received_events","type":"User","site_admin":false},"body":"@slava77 I'm not sure what this means - could you please give an example?","created_at":"2015-08-14T13:34:29Z","updated_at":"2015-08-14T13:34:29Z","html_url":"https://github.com/cms-sw/cmssw/pull/10605#discussion_r37076156","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10605","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/37076156"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/10605#discussion_r37076156"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/10605"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10605","id":41803044,"html_url":"https://github.com/cms-sw/cmssw/pull/10605","diff_url":"https://github.com/cms-sw/cmssw/pull/10605.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/10605.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/10605","number":10605,"state":"open","locked":false,"title":"Dynamic strip reco v3","user":{"login":"andrewj314","id":6199470,"avatar_url":"https://avatars.githubusercontent.com/u/6199470?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewj314","html_url":"https://github.com/andrewj314","followers_url":"https://api.github.com/users/andrewj314/followers","following_url":"https://api.github.com/users/andrewj314/following{/other_user}","gists_url":"https://api.github.com/users/andrewj314/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewj314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewj314/subscriptions","organizations_url":"https://api.github.com/users/andrewj314/orgs","repos_url":"https://api.github.com/users/andrewj314/repos","events_url":"https://api.github.com/users/andrewj314/events{/privacy}","received_events_url":"https://api.github.com/users/andrewj314/received_events","type":"User","site_admin":false},"body":"Implementation of dynamic strip reco algorithm designed to recover low-pT photons from pizero decays, addition of cleaner module rejecting tau candidates without unit charge, removal of obsolete tau ID discriminators. For an overview of the changes in this PR, see here:\r\nhttps://indico.cern.ch/event/434527/?filterActive=1&showDate=all&showSession=4#preview:1627952","created_at":"2015-08-06T15:46:47Z","updated_at":"2015-08-14T13:34:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc818ce81064a497f2c9727359d7222c91241310","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":90,"closed_issues":383,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-08-14T11:51:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10605/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10605/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/10605/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/398866a1db973cb65ff7c87aaf76d1c71c08662d","head":{"label":"cms-tau-pog:DynamicStripReco_v3","ref":"DynamicStripReco_v3","sha":"398866a1db973cb65ff7c87aaf76d1c71c08662d","user":{"login":"cms-tau-pog","id":5045946,"avatar_url":"https://avatars.githubusercontent.com/u/5045946?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-tau-pog","html_url":"https://github.com/cms-tau-pog","followers_url":"https://api.github.com/users/cms-tau-pog/followers","following_url":"https://api.github.com/users/cms-tau-pog/following{/other_user}","gists_url":"https://api.github.com/users/cms-tau-pog/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-tau-pog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-tau-pog/subscriptions","organizations_url":"https://api.github.com/users/cms-tau-pog/orgs","repos_url":"https://api.github.com/users/cms-tau-pog/repos","events_url":"https://api.github.com/users/cms-tau-pog/events{/privacy}","received_events_url":"https://api.github.com/users/cms-tau-pog/received_events","type":"Organization","site_admin":false},"repo":{"id":11524374,"name":"cmssw","full_name":"cms-tau-pog/cmssw","owner":{"login":"cms-tau-pog","id":5045946,"avatar_url":"https://avatars.githubusercontent.com/u/5045946?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-tau-pog","html_url":"https://github.com/cms-tau-pog","followers_url":"https://api.github.com/users/cms-tau-pog/followers","following_url":"https://api.github.com/users/cms-tau-pog/following{/other_user}","gists_url":"https://api.github.com/users/cms-tau-pog/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-tau-pog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-tau-pog/subscriptions","organizations_url":"https://api.github.com/users/cms-tau-pog/orgs","repos_url":"https://api.github.com/users/cms-tau-pog/repos","events_url":"https://api.github.com/users/cms-tau-pog/events{/privacy}","received_events_url":"https://api.github.com/users/cms-tau-pog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-tau-pog/cmssw","description":"CMS Offline Software fork - for all tau related developments","fork":true,"url":"https://api.github.com/repos/cms-tau-pog/cmssw","forks_url":"https://api.github.com/repos/cms-tau-pog/cmssw/forks","keys_url":"https://api.github.com/repos/cms-tau-pog/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-tau-pog/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-tau-pog/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-tau-pog/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-tau-pog/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-tau-pog/cmssw/events","assignees_url":"https://api.github.com/repos/cms-tau-pog/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-tau-pog/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-tau-pog/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-tau-pog/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-tau-pog/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-tau-pog/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-tau-pog/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-tau-pog/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-tau-pog/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-tau-pog/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-tau-pog/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-tau-pog/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-tau-pog/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-tau-pog/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-tau-pog/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-tau-pog/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-tau-pog/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-tau-pog/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-tau-pog/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-tau-pog/cmssw/merges","archive_url":"https://api.github.com/repos/cms-tau-pog/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-tau-pog/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-tau-pog/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-tau-pog/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-tau-pog/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-tau-pog/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-tau-pog/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-tau-pog/cmssw/releases{/id}","created_at":"2013-07-19T09:16:54Z","updated_at":"2014-06-24T16:56:02Z","pushed_at":"2015-08-13T09:41:22Z","git_url":"git://github.com/cms-tau-pog/cmssw.git","ssh_url":"git@github.com:cms-tau-pog/cmssw.git","clone_url":"https://github.com/cms-tau-pog/cmssw.git","svn_url":"https://github.com/cms-tau-pog/cmssw","homepage":"cms-sw.github.io/cmssw","size":727480,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"CMSSW_7_0_X_taus"}},"base":{"label":"cms-sw:CMSSW_7_6_X","ref":"CMSSW_7_6_X","sha":"320f27ccc123ec650cd295edb388688617beb64b","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-08-07T23:46:12Z","pushed_at":"2015-08-14T13:10:02Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1274746,"stargazers_count":256,"watchers_count":256,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1525,"mirror_url":null,"open_issues_count":261,"forks":1525,"open_issues":261,"watchers":256,"default_branch":"CMSSW_7_6_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/10605"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/10605"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/10605"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/10605/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/10605/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/10605/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/398866a1db973cb65ff7c87aaf76d1c71c08662d"}}}}