{"action":"created","comment":{"url":"https://api.github.com/repos/meanjs/mean/pulls/comments/36650553","id":36650553,"diff_hunk":"@@ -129,19 +129,24 @@ describe('User Model Unit Tests:', function () {\n       });\n     });\n \n-    it('should not be able to save different user with the same email address', function () {\n+    it('should not be able to save another user with the same email address', function (done) {\n+      // Test may take some time to complete due to db operations\n+      this.timeout(10000);","path":"modules/users/tests/server/user.server.model.tests.js","position":7,"original_position":7,"commit_id":"463f5b944f37856a7d10c3d8641441ce8a317486","original_commit_id":"463f5b944f37856a7d10c3d8641441ce8a317486","user":{"login":"ilanbiala","id":3695164,"avatar_url":"https://avatars.githubusercontent.com/u/3695164?v=3","gravatar_id":"","url":"https://api.github.com/users/ilanbiala","html_url":"https://github.com/ilanbiala","followers_url":"https://api.github.com/users/ilanbiala/followers","following_url":"https://api.github.com/users/ilanbiala/following{/other_user}","gists_url":"https://api.github.com/users/ilanbiala/gists{/gist_id}","starred_url":"https://api.github.com/users/ilanbiala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilanbiala/subscriptions","organizations_url":"https://api.github.com/users/ilanbiala/orgs","repos_url":"https://api.github.com/users/ilanbiala/repos","events_url":"https://api.github.com/users/ilanbiala/events{/privacy}","received_events_url":"https://api.github.com/users/ilanbiala/received_events","type":"User","site_admin":false},"body":"Quite long no? How long does the test take on average?","created_at":"2015-08-10T16:20:05Z","updated_at":"2015-08-10T16:20:05Z","html_url":"https://github.com/meanjs/mean/pull/771#discussion_r36650553","pull_request_url":"https://api.github.com/repos/meanjs/mean/pulls/771","_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments/36650553"},"html":{"href":"https://github.com/meanjs/mean/pull/771#discussion_r36650553"},"pull_request":{"href":"https://api.github.com/repos/meanjs/mean/pulls/771"}}},"pull_request":{"url":"https://api.github.com/repos/meanjs/mean/pulls/771","id":41936228,"html_url":"https://github.com/meanjs/mean/pull/771","diff_url":"https://github.com/meanjs/mean/pull/771.diff","patch_url":"https://github.com/meanjs/mean/pull/771.patch","issue_url":"https://api.github.com/repos/meanjs/mean/issues/771","number":771,"state":"open","locked":false,"title":"Fixing user model test's last test which fail or report a false positive","user":{"login":"lirantal","id":316371,"avatar_url":"https://avatars.githubusercontent.com/u/316371?v=3","gravatar_id":"","url":"https://api.github.com/users/lirantal","html_url":"https://github.com/lirantal","followers_url":"https://api.github.com/users/lirantal/followers","following_url":"https://api.github.com/users/lirantal/following{/other_user}","gists_url":"https://api.github.com/users/lirantal/gists{/gist_id}","starred_url":"https://api.github.com/users/lirantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lirantal/subscriptions","organizations_url":"https://api.github.com/users/lirantal/orgs","repos_url":"https://api.github.com/users/lirantal/repos","events_url":"https://api.github.com/users/lirantal/events{/privacy}","received_events_url":"https://api.github.com/users/lirantal/received_events","type":"User","site_admin":false},"body":"fixing up a user model test which was not setup correctly without the async done() callback, which led to false postivies. Adding timeouts to the test ensures that the test completes in time, otherwise mocha's 2s timeout will fail the test","created_at":"2015-08-07T21:43:51Z","updated_at":"2015-08-10T16:20:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29ea0a836a4fe971e0b1279c3b3964d949e822ac","assignee":{"login":"lirantal","id":316371,"avatar_url":"https://avatars.githubusercontent.com/u/316371?v=3","gravatar_id":"","url":"https://api.github.com/users/lirantal","html_url":"https://github.com/lirantal","followers_url":"https://api.github.com/users/lirantal/followers","following_url":"https://api.github.com/users/lirantal/following{/other_user}","gists_url":"https://api.github.com/users/lirantal/gists{/gist_id}","starred_url":"https://api.github.com/users/lirantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lirantal/subscriptions","organizations_url":"https://api.github.com/users/lirantal/orgs","repos_url":"https://api.github.com/users/lirantal/repos","events_url":"https://api.github.com/users/lirantal/events{/privacy}","received_events_url":"https://api.github.com/users/lirantal/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/meanjs/mean/milestones/4","html_url":"https://github.com/meanjs/mean/milestones/0.4.x","labels_url":"https://api.github.com/repos/meanjs/mean/milestones/4/labels","id":1035360,"number":4,"title":"0.4.x","description":"Issues that will be handled at some point in time through the 0.4.x release cycle","creator":{"login":"ilanbiala","id":3695164,"avatar_url":"https://avatars.githubusercontent.com/u/3695164?v=3","gravatar_id":"","url":"https://api.github.com/users/ilanbiala","html_url":"https://github.com/ilanbiala","followers_url":"https://api.github.com/users/ilanbiala/followers","following_url":"https://api.github.com/users/ilanbiala/following{/other_user}","gists_url":"https://api.github.com/users/ilanbiala/gists{/gist_id}","starred_url":"https://api.github.com/users/ilanbiala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilanbiala/subscriptions","organizations_url":"https://api.github.com/users/ilanbiala/orgs","repos_url":"https://api.github.com/users/ilanbiala/repos","events_url":"https://api.github.com/users/ilanbiala/events{/privacy}","received_events_url":"https://api.github.com/users/ilanbiala/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":32,"state":"open","created_at":"2015-03-23T22:38:37Z","updated_at":"2015-08-09T18:50:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/meanjs/mean/pulls/771/commits","review_comments_url":"https://api.github.com/repos/meanjs/mean/pulls/771/comments","review_comment_url":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meanjs/mean/issues/771/comments","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/463f5b944f37856a7d10c3d8641441ce8a317486","head":{"label":"lirantal:bugfix/fix_user_module_async_tests","ref":"bugfix/fix_user_module_async_tests","sha":"463f5b944f37856a7d10c3d8641441ce8a317486","user":{"login":"lirantal","id":316371,"avatar_url":"https://avatars.githubusercontent.com/u/316371?v=3","gravatar_id":"","url":"https://api.github.com/users/lirantal","html_url":"https://github.com/lirantal","followers_url":"https://api.github.com/users/lirantal/followers","following_url":"https://api.github.com/users/lirantal/following{/other_user}","gists_url":"https://api.github.com/users/lirantal/gists{/gist_id}","starred_url":"https://api.github.com/users/lirantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lirantal/subscriptions","organizations_url":"https://api.github.com/users/lirantal/orgs","repos_url":"https://api.github.com/users/lirantal/repos","events_url":"https://api.github.com/users/lirantal/events{/privacy}","received_events_url":"https://api.github.com/users/lirantal/received_events","type":"User","site_admin":false},"repo":{"id":25197324,"name":"meanjs","full_name":"lirantal/meanjs","owner":{"login":"lirantal","id":316371,"avatar_url":"https://avatars.githubusercontent.com/u/316371?v=3","gravatar_id":"","url":"https://api.github.com/users/lirantal","html_url":"https://github.com/lirantal","followers_url":"https://api.github.com/users/lirantal/followers","following_url":"https://api.github.com/users/lirantal/following{/other_user}","gists_url":"https://api.github.com/users/lirantal/gists{/gist_id}","starred_url":"https://api.github.com/users/lirantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lirantal/subscriptions","organizations_url":"https://api.github.com/users/lirantal/orgs","repos_url":"https://api.github.com/users/lirantal/repos","events_url":"https://api.github.com/users/lirantal/events{/privacy}","received_events_url":"https://api.github.com/users/lirantal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lirantal/meanjs","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js From Creators of MEAN.IO - ","fork":true,"url":"https://api.github.com/repos/lirantal/meanjs","forks_url":"https://api.github.com/repos/lirantal/meanjs/forks","keys_url":"https://api.github.com/repos/lirantal/meanjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lirantal/meanjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lirantal/meanjs/teams","hooks_url":"https://api.github.com/repos/lirantal/meanjs/hooks","issue_events_url":"https://api.github.com/repos/lirantal/meanjs/issues/events{/number}","events_url":"https://api.github.com/repos/lirantal/meanjs/events","assignees_url":"https://api.github.com/repos/lirantal/meanjs/assignees{/user}","branches_url":"https://api.github.com/repos/lirantal/meanjs/branches{/branch}","tags_url":"https://api.github.com/repos/lirantal/meanjs/tags","blobs_url":"https://api.github.com/repos/lirantal/meanjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lirantal/meanjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lirantal/meanjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lirantal/meanjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lirantal/meanjs/statuses/{sha}","languages_url":"https://api.github.com/repos/lirantal/meanjs/languages","stargazers_url":"https://api.github.com/repos/lirantal/meanjs/stargazers","contributors_url":"https://api.github.com/repos/lirantal/meanjs/contributors","subscribers_url":"https://api.github.com/repos/lirantal/meanjs/subscribers","subscription_url":"https://api.github.com/repos/lirantal/meanjs/subscription","commits_url":"https://api.github.com/repos/lirantal/meanjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lirantal/meanjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lirantal/meanjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lirantal/meanjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lirantal/meanjs/contents/{+path}","compare_url":"https://api.github.com/repos/lirantal/meanjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lirantal/meanjs/merges","archive_url":"https://api.github.com/repos/lirantal/meanjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lirantal/meanjs/downloads","issues_url":"https://api.github.com/repos/lirantal/meanjs/issues{/number}","pulls_url":"https://api.github.com/repos/lirantal/meanjs/pulls{/number}","milestones_url":"https://api.github.com/repos/lirantal/meanjs/milestones{/number}","notifications_url":"https://api.github.com/repos/lirantal/meanjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lirantal/meanjs/labels{/name}","releases_url":"https://api.github.com/repos/lirantal/meanjs/releases{/id}","created_at":"2014-10-14T08:34:11Z","updated_at":"2015-03-19T07:55:47Z","pushed_at":"2015-08-08T16:10:42Z","git_url":"git://github.com/lirantal/meanjs.git","ssh_url":"git@github.com:lirantal/meanjs.git","clone_url":"https://github.com/lirantal/meanjs.git","svn_url":"https://github.com/lirantal/meanjs","homepage":"meanjs.org","size":3195,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meanjs:master","ref":"master","sha":"21d87e9378e3598b75918c1f250701a71533a172","user":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"repo":{"id":15508537,"name":"mean","full_name":"meanjs/mean","owner":{"login":"meanjs","id":6232122,"avatar_url":"https://avatars.githubusercontent.com/u/6232122?v=3","gravatar_id":"","url":"https://api.github.com/users/meanjs","html_url":"https://github.com/meanjs","followers_url":"https://api.github.com/users/meanjs/followers","following_url":"https://api.github.com/users/meanjs/following{/other_user}","gists_url":"https://api.github.com/users/meanjs/gists{/gist_id}","starred_url":"https://api.github.com/users/meanjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meanjs/subscriptions","organizations_url":"https://api.github.com/users/meanjs/orgs","repos_url":"https://api.github.com/users/meanjs/repos","events_url":"https://api.github.com/users/meanjs/events{/privacy}","received_events_url":"https://api.github.com/users/meanjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meanjs/mean","description":"MEAN.JS - Full-Stack JavaScript Using MongoDB, Express, AngularJS, and Node.js - ","fork":false,"url":"https://api.github.com/repos/meanjs/mean","forks_url":"https://api.github.com/repos/meanjs/mean/forks","keys_url":"https://api.github.com/repos/meanjs/mean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meanjs/mean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meanjs/mean/teams","hooks_url":"https://api.github.com/repos/meanjs/mean/hooks","issue_events_url":"https://api.github.com/repos/meanjs/mean/issues/events{/number}","events_url":"https://api.github.com/repos/meanjs/mean/events","assignees_url":"https://api.github.com/repos/meanjs/mean/assignees{/user}","branches_url":"https://api.github.com/repos/meanjs/mean/branches{/branch}","tags_url":"https://api.github.com/repos/meanjs/mean/tags","blobs_url":"https://api.github.com/repos/meanjs/mean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meanjs/mean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meanjs/mean/git/refs{/sha}","trees_url":"https://api.github.com/repos/meanjs/mean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meanjs/mean/statuses/{sha}","languages_url":"https://api.github.com/repos/meanjs/mean/languages","stargazers_url":"https://api.github.com/repos/meanjs/mean/stargazers","contributors_url":"https://api.github.com/repos/meanjs/mean/contributors","subscribers_url":"https://api.github.com/repos/meanjs/mean/subscribers","subscription_url":"https://api.github.com/repos/meanjs/mean/subscription","commits_url":"https://api.github.com/repos/meanjs/mean/commits{/sha}","git_commits_url":"https://api.github.com/repos/meanjs/mean/git/commits{/sha}","comments_url":"https://api.github.com/repos/meanjs/mean/comments{/number}","issue_comment_url":"https://api.github.com/repos/meanjs/mean/issues/comments{/number}","contents_url":"https://api.github.com/repos/meanjs/mean/contents/{+path}","compare_url":"https://api.github.com/repos/meanjs/mean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meanjs/mean/merges","archive_url":"https://api.github.com/repos/meanjs/mean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meanjs/mean/downloads","issues_url":"https://api.github.com/repos/meanjs/mean/issues{/number}","pulls_url":"https://api.github.com/repos/meanjs/mean/pulls{/number}","milestones_url":"https://api.github.com/repos/meanjs/mean/milestones{/number}","notifications_url":"https://api.github.com/repos/meanjs/mean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meanjs/mean/labels{/name}","releases_url":"https://api.github.com/repos/meanjs/mean/releases{/id}","created_at":"2013-12-29T13:01:15Z","updated_at":"2015-08-10T15:01:11Z","pushed_at":"2015-08-09T18:50:35Z","git_url":"git://github.com/meanjs/mean.git","ssh_url":"git@github.com:meanjs/mean.git","clone_url":"https://github.com/meanjs/mean.git","svn_url":"https://github.com/meanjs/mean","homepage":"http://meanjs.org","size":6560,"stargazers_count":2426,"watchers_count":2426,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":843,"mirror_url":null,"open_issues_count":91,"forks":843,"open_issues":91,"watchers":2426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meanjs/mean/pulls/771"},"html":{"href":"https://github.com/meanjs/mean/pull/771"},"issue":{"href":"https://api.github.com/repos/meanjs/mean/issues/771"},"comments":{"href":"https://api.github.com/repos/meanjs/mean/issues/771/comments"},"review_comments":{"href":"https://api.github.com/repos/meanjs/mean/pulls/771/comments"},"review_comment":{"href":"https://api.github.com/repos/meanjs/mean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meanjs/mean/pulls/771/commits"},"statuses":{"href":"https://api.github.com/repos/meanjs/mean/statuses/463f5b944f37856a7d10c3d8641441ce8a317486"}}}}