{"action":"created","comment":{"url":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/comments/42033359","id":42033359,"diff_hunk":"@@ -10,4 +14,44 @@ module.exports =\n         type: 'string'\n \n   activate: ->\n-    console.log 'activate linter-gjslint'\n+    @subscriptions = new CompositeDisposable\n+    @subscriptions.add atom.config.observe 'linter-gjslint.executablePath',\n+      (executablePath) =>\n+        @executablePath = executablePath\n+  deactivate: ->\n+    @subscriptions.dispose()\n+  provideLinter: ->\n+    helpers = require('atom-linter')\n+    provider =\n+      name: 'gjslint'\n+      grammarScopes: ['source.js', 'source.js.jquery', 'text.html.basic']\n+      scope: 'file'\n+      lintOnFly: true\n+      lint: (editor) =>\n+        filePath = editor.getPath()\n+        cwd = path.dirname(filePath)","path":"lib/init.coffee","position":35,"original_position":35,"commit_id":"714b41ad646f22e875ce50055b81b1e8eeae7674","original_commit_id":"714b41ad646f22e875ce50055b81b1e8eeae7674","user":{"login":"Arcanemagus","id":427137,"avatar_url":"https://avatars.githubusercontent.com/u/427137?v=3","gravatar_id":"","url":"https://api.github.com/users/Arcanemagus","html_url":"https://github.com/Arcanemagus","followers_url":"https://api.github.com/users/Arcanemagus/followers","following_url":"https://api.github.com/users/Arcanemagus/following{/other_user}","gists_url":"https://api.github.com/users/Arcanemagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Arcanemagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arcanemagus/subscriptions","organizations_url":"https://api.github.com/users/Arcanemagus/orgs","repos_url":"https://api.github.com/users/Arcanemagus/repos","events_url":"https://api.github.com/users/Arcanemagus/events{/privacy}","received_events_url":"https://api.github.com/users/Arcanemagus/received_events","type":"User","site_admin":false},"body":"`path` hasn't been imported, so it crashes on this line currently.","created_at":"2015-10-14T18:31:50Z","updated_at":"2015-10-14T18:31:50Z","html_url":"https://github.com/AtomLinter/linter-gjslint/pull/16#discussion_r42033359","pull_request_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/comments/42033359"},"html":{"href":"https://github.com/AtomLinter/linter-gjslint/pull/16#discussion_r42033359"},"pull_request":{"href":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/16","id":47692424,"html_url":"https://github.com/AtomLinter/linter-gjslint/pull/16","diff_url":"https://github.com/AtomLinter/linter-gjslint/pull/16.diff","patch_url":"https://github.com/AtomLinter/linter-gjslint/pull/16.patch","issue_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/issues/16","number":16,"state":"open","locked":false,"title":"Update to support new linter APIs","user":{"login":"artoale","id":297661,"avatar_url":"https://avatars.githubusercontent.com/u/297661?v=3","gravatar_id":"","url":"https://api.github.com/users/artoale","html_url":"https://github.com/artoale","followers_url":"https://api.github.com/users/artoale/followers","following_url":"https://api.github.com/users/artoale/following{/other_user}","gists_url":"https://api.github.com/users/artoale/gists{/gist_id}","starred_url":"https://api.github.com/users/artoale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artoale/subscriptions","organizations_url":"https://api.github.com/users/artoale/orgs","repos_url":"https://api.github.com/users/artoale/repos","events_url":"https://api.github.com/users/artoale/events{/privacy}","received_events_url":"https://api.github.com/users/artoale/received_events","type":"User","site_admin":false},"body":"As reported in #10, #14 and #15, Linter APIs have changed. \r\nThis pull request is an attempt at fixing the issue.\r\nIt doesn't support ignored code - but it should at least work (since current implementation is not).\r\nI suspect adding support for ignored codes would be good for another issue/pr.\r\n\r\nLet me know if there's anything I should add/change.\r\n","created_at":"2015-10-14T17:54:13Z","updated_at":"2015-10-14T18:31:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"500890b04a8287750878304b1b315965eeb9eb8b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/16/commits","review_comments_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/16/comments","review_comment_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/issues/16/comments","statuses_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/statuses/714b41ad646f22e875ce50055b81b1e8eeae7674","head":{"label":"artoale:master","ref":"master","sha":"714b41ad646f22e875ce50055b81b1e8eeae7674","user":{"login":"artoale","id":297661,"avatar_url":"https://avatars.githubusercontent.com/u/297661?v=3","gravatar_id":"","url":"https://api.github.com/users/artoale","html_url":"https://github.com/artoale","followers_url":"https://api.github.com/users/artoale/followers","following_url":"https://api.github.com/users/artoale/following{/other_user}","gists_url":"https://api.github.com/users/artoale/gists{/gist_id}","starred_url":"https://api.github.com/users/artoale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artoale/subscriptions","organizations_url":"https://api.github.com/users/artoale/orgs","repos_url":"https://api.github.com/users/artoale/repos","events_url":"https://api.github.com/users/artoale/events{/privacy}","received_events_url":"https://api.github.com/users/artoale/received_events","type":"User","site_admin":false},"repo":{"id":44261005,"name":"linter-gjslint","full_name":"artoale/linter-gjslint","owner":{"login":"artoale","id":297661,"avatar_url":"https://avatars.githubusercontent.com/u/297661?v=3","gravatar_id":"","url":"https://api.github.com/users/artoale","html_url":"https://github.com/artoale","followers_url":"https://api.github.com/users/artoale/followers","following_url":"https://api.github.com/users/artoale/following{/other_user}","gists_url":"https://api.github.com/users/artoale/gists{/gist_id}","starred_url":"https://api.github.com/users/artoale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artoale/subscriptions","organizations_url":"https://api.github.com/users/artoale/orgs","repos_url":"https://api.github.com/users/artoale/repos","events_url":"https://api.github.com/users/artoale/events{/privacy}","received_events_url":"https://api.github.com/users/artoale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/artoale/linter-gjslint","description":"Atom linter plugin for JavaScript, using gjslint.","fork":true,"url":"https://api.github.com/repos/artoale/linter-gjslint","forks_url":"https://api.github.com/repos/artoale/linter-gjslint/forks","keys_url":"https://api.github.com/repos/artoale/linter-gjslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artoale/linter-gjslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artoale/linter-gjslint/teams","hooks_url":"https://api.github.com/repos/artoale/linter-gjslint/hooks","issue_events_url":"https://api.github.com/repos/artoale/linter-gjslint/issues/events{/number}","events_url":"https://api.github.com/repos/artoale/linter-gjslint/events","assignees_url":"https://api.github.com/repos/artoale/linter-gjslint/assignees{/user}","branches_url":"https://api.github.com/repos/artoale/linter-gjslint/branches{/branch}","tags_url":"https://api.github.com/repos/artoale/linter-gjslint/tags","blobs_url":"https://api.github.com/repos/artoale/linter-gjslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artoale/linter-gjslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artoale/linter-gjslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/artoale/linter-gjslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artoale/linter-gjslint/statuses/{sha}","languages_url":"https://api.github.com/repos/artoale/linter-gjslint/languages","stargazers_url":"https://api.github.com/repos/artoale/linter-gjslint/stargazers","contributors_url":"https://api.github.com/repos/artoale/linter-gjslint/contributors","subscribers_url":"https://api.github.com/repos/artoale/linter-gjslint/subscribers","subscription_url":"https://api.github.com/repos/artoale/linter-gjslint/subscription","commits_url":"https://api.github.com/repos/artoale/linter-gjslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/artoale/linter-gjslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/artoale/linter-gjslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/artoale/linter-gjslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/artoale/linter-gjslint/contents/{+path}","compare_url":"https://api.github.com/repos/artoale/linter-gjslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artoale/linter-gjslint/merges","archive_url":"https://api.github.com/repos/artoale/linter-gjslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artoale/linter-gjslint/downloads","issues_url":"https://api.github.com/repos/artoale/linter-gjslint/issues{/number}","pulls_url":"https://api.github.com/repos/artoale/linter-gjslint/pulls{/number}","milestones_url":"https://api.github.com/repos/artoale/linter-gjslint/milestones{/number}","notifications_url":"https://api.github.com/repos/artoale/linter-gjslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artoale/linter-gjslint/labels{/name}","releases_url":"https://api.github.com/repos/artoale/linter-gjslint/releases{/id}","created_at":"2015-10-14T16:26:00Z","updated_at":"2015-10-14T16:26:00Z","pushed_at":"2015-10-14T17:50:53Z","git_url":"git://github.com/artoale/linter-gjslint.git","ssh_url":"git@github.com:artoale/linter-gjslint.git","clone_url":"https://github.com/artoale/linter-gjslint.git","svn_url":"https://github.com/artoale/linter-gjslint","homepage":"","size":92,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AtomLinter:master","ref":"master","sha":"3dddc07257b387003df1d0189588c2529b756a22","user":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"repo":{"id":22639984,"name":"linter-gjslint","full_name":"AtomLinter/linter-gjslint","owner":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AtomLinter/linter-gjslint","description":"Atom linter plugin for JavaScript, using gjslint.","fork":false,"url":"https://api.github.com/repos/AtomLinter/linter-gjslint","forks_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/forks","keys_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/teams","hooks_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/hooks","issue_events_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/issues/events{/number}","events_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/events","assignees_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/assignees{/user}","branches_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/branches{/branch}","tags_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/tags","blobs_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/statuses/{sha}","languages_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/languages","stargazers_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/stargazers","contributors_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/contributors","subscribers_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/subscribers","subscription_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/subscription","commits_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/contents/{+path}","compare_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/merges","archive_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/downloads","issues_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/issues{/number}","pulls_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls{/number}","milestones_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/milestones{/number}","notifications_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/labels{/name}","releases_url":"https://api.github.com/repos/AtomLinter/linter-gjslint/releases{/id}","created_at":"2014-08-05T10:40:31Z","updated_at":"2015-05-22T15:50:23Z","pushed_at":"2015-10-14T17:54:13Z","git_url":"git://github.com/AtomLinter/linter-gjslint.git","ssh_url":"git@github.com:AtomLinter/linter-gjslint.git","clone_url":"https://github.com/AtomLinter/linter-gjslint.git","svn_url":"https://github.com/AtomLinter/linter-gjslint","homepage":"","size":236,"stargazers_count":1,"watchers_count":1,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":6,"forks":9,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/16"},"html":{"href":"https://github.com/AtomLinter/linter-gjslint/pull/16"},"issue":{"href":"https://api.github.com/repos/AtomLinter/linter-gjslint/issues/16"},"comments":{"href":"https://api.github.com/repos/AtomLinter/linter-gjslint/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AtomLinter/linter-gjslint/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/AtomLinter/linter-gjslint/statuses/714b41ad646f22e875ce50055b81b1e8eeae7674"}}}}