{"action":"created","issue":{"url":"https://api.github.com/repos/NodeRedis/node_redis/issues/772","labels_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/772/labels{/name}","comments_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/772/comments","events_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/772/events","html_url":"https://github.com/NodeRedis/node_redis/pull/772","id":92215642,"number":772,"title":"Small improvements (performance, ensure valid constructor usage)","user":{"login":"Ginden","id":3824055,"avatar_url":"https://avatars.githubusercontent.com/u/3824055?v=3","gravatar_id":"","url":"https://api.github.com/users/Ginden","html_url":"https://github.com/Ginden","followers_url":"https://api.github.com/users/Ginden/followers","following_url":"https://api.github.com/users/Ginden/following{/other_user}","gists_url":"https://api.github.com/users/Ginden/gists{/gist_id}","starred_url":"https://api.github.com/users/Ginden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ginden/subscriptions","organizations_url":"https://api.github.com/users/Ginden/orgs","repos_url":"https://api.github.com/users/Ginden/repos","events_url":"https://api.github.com/users/Ginden/events{/privacy}","received_events_url":"https://api.github.com/users/Ginden/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-30T22:29:50Z","updated_at":"2015-07-22T18:56:03Z","closed_at":"2015-07-22T15:16:35Z","pull_request":{"url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/772","html_url":"https://github.com/NodeRedis/node_redis/pull/772","diff_url":"https://github.com/NodeRedis/node_redis/pull/772.diff","patch_url":"https://github.com/NodeRedis/node_redis/pull/772.patch"},"body":"* Increased perfomance of `to_array` method.\r\nFollowing good rule \"any perfomance should be proven by benchmark\" I provide following code: https://gist.github.com/Ginden/4b3ca5bc48634fa9500c\r\n```\r\ntoArray1 took 13.677ms on 32768 arrays\r\ntoArray2 [current] took 20.659ms on 32768 arrays\r\ntoArray3 [new] took 11.943ms on 32768 arrays\r\ntoArray4 took 12.269ms on 32768 arrays\r\n```\r\n\r\n* `'use strict'` directive was added to enforce valid constructor usage. It's minor \"potentially breaking\" change - it will make already buggy code fail earlier.\r\n"},"comment":{"url":"https://api.github.com/repos/NodeRedis/node_redis/issues/comments/123826854","html_url":"https://github.com/NodeRedis/node_redis/pull/772#issuecomment-123826854","issue_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/772","id":123826854,"user":{"login":"mranney","id":210141,"avatar_url":"https://avatars.githubusercontent.com/u/210141?v=3","gravatar_id":"","url":"https://api.github.com/users/mranney","html_url":"https://github.com/mranney","followers_url":"https://api.github.com/users/mranney/followers","following_url":"https://api.github.com/users/mranney/following{/other_user}","gists_url":"https://api.github.com/users/mranney/gists{/gist_id}","starred_url":"https://api.github.com/users/mranney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mranney/subscriptions","organizations_url":"https://api.github.com/users/mranney/orgs","repos_url":"https://api.github.com/users/mranney/repos","events_url":"https://api.github.com/users/mranney/events{/privacy}","received_events_url":"https://api.github.com/users/mranney/received_events","type":"User","site_admin":false},"created_at":"2015-07-22T18:56:03Z","updated_at":"2015-07-22T18:56:03Z","body":"It wouldn't surprise me if at some point V8 would implement a faster way to do this. But to_array is there because this process kept showing up on the flame graphs."}}