{"action":"created","issue":{"url":"https://api.github.com/repos/cfengine/core/issues/2247","labels_url":"https://api.github.com/repos/cfengine/core/issues/2247/labels{/name}","comments_url":"https://api.github.com/repos/cfengine/core/issues/2247/comments","events_url":"https://api.github.com/repos/cfengine/core/issues/2247/events","html_url":"https://github.com/cfengine/core/pull/2247","id":90143111,"number":2247,"title":"libutils/json.c: support bareword keys in JSON parsing","user":{"login":"tzz","id":67764,"avatar_url":"https://avatars.githubusercontent.com/u/67764?v=3","gravatar_id":"","url":"https://api.github.com/users/tzz","html_url":"https://github.com/tzz","followers_url":"https://api.github.com/users/tzz/followers","following_url":"https://api.github.com/users/tzz/following{/other_user}","gists_url":"https://api.github.com/users/tzz/gists{/gist_id}","starred_url":"https://api.github.com/users/tzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzz/subscriptions","organizations_url":"https://api.github.com/users/tzz/orgs","repos_url":"https://api.github.com/users/tzz/repos","events_url":"https://api.github.com/users/tzz/events{/privacy}","received_events_url":"https://api.github.com/users/tzz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"kacfengine","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacfengine","html_url":"https://github.com/kacfengine","followers_url":"https://api.github.com/users/kacfengine/followers","following_url":"https://api.github.com/users/kacfengine/following{/other_user}","gists_url":"https://api.github.com/users/kacfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/kacfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacfengine/subscriptions","organizations_url":"https://api.github.com/users/kacfengine/orgs","repos_url":"https://api.github.com/users/kacfengine/repos","events_url":"https://api.github.com/users/kacfengine/events{/privacy}","received_events_url":"https://api.github.com/users/kacfengine/received_events","type":"User","site_admin":false},"milestone":null,"comments":15,"created_at":"2015-06-22T16:12:10Z","updated_at":"2015-08-20T10:42:56Z","closed_at":"2015-08-20T09:56:17Z","pull_request":{"url":"https://api.github.com/repos/cfengine/core/pulls/2247","html_url":"https://github.com/cfengine/core/pull/2247","diff_url":"https://github.com/cfengine/core/pull/2247.diff","patch_url":"https://github.com/cfengine/core/pull/2247.patch"},"body":"This code supports bareword JSON keys, e.g.\r\n\r\n```\r\n{\r\n  bar : \"zulu\",\r\n  foo: [\r\n    \"alpha\",\r\n    \"bravo\"\r\n  ]\r\n}\r\n```\r\n\r\nIt also defines a new hard class `feature_json_bareword_keys` to detect if this is enabled.\r\n\r\nI believe the code is safe and correct but appreciate some review.  Upon acceptance I can write tests and docs."},"comment":{"url":"https://api.github.com/repos/cfengine/core/issues/comments/132969992","html_url":"https://github.com/cfengine/core/pull/2247#issuecomment-132969992","issue_url":"https://api.github.com/repos/cfengine/core/issues/2247","id":132969992,"user":{"login":"kacfengine","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacfengine","html_url":"https://github.com/kacfengine","followers_url":"https://api.github.com/users/kacfengine/followers","following_url":"https://api.github.com/users/kacfengine/following{/other_user}","gists_url":"https://api.github.com/users/kacfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/kacfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacfengine/subscriptions","organizations_url":"https://api.github.com/users/kacfengine/orgs","repos_url":"https://api.github.com/users/kacfengine/repos","events_url":"https://api.github.com/users/kacfengine/events{/privacy}","received_events_url":"https://api.github.com/users/kacfengine/received_events","type":"User","site_admin":false},"created_at":"2015-08-20T10:42:56Z","updated_at":"2015-08-20T10:42:56Z","body":"Do you think that's needed? Many features are added in new versions, and we don't add feature classes for all of them. A version check can accomplish the same thing.\r\n\r\nNot necessarily against it though, it just seems a bit excessive."}}