{"action":"created","comment":{"url":"https://api.github.com/repos/open-craft/opencraft/pulls/comments/41097075","id":41097075,"diff_hunk":"@@ -139,17 +143,37 @@ def active_server_set(self):\n         return self.server_set.exclude_terminated()\n \n     @property\n-    def status(self):\n+    def current_server(self):\n         \"\"\"\n-        Instance status\n+        Current active server. Raises InconsistentInstanceState if more than\n+        one exists.\n         \"\"\"\n         active_server_set = self.active_server_set\n         if not active_server_set:\n-            return self.EMPTY\n+            return\n         elif active_server_set.count() > 1:\n             raise InconsistentInstanceState('Multiple servers are active, which is unsupported')\n-        else:\n-            return active_server_set[0].status\n+        return active_server_set[0]","path":"instance/models/instance.py","position":52,"original_position":52,"commit_id":"8b1640093dc1a35a31ce07844290e0f7e7290f90","original_commit_id":"8b1640093dc1a35a31ce07844290e0f7e7290f90","user":{"login":"chromano","id":26786,"avatar_url":"https://avatars.githubusercontent.com/u/26786?v=3","gravatar_id":"","url":"https://api.github.com/users/chromano","html_url":"https://github.com/chromano","followers_url":"https://api.github.com/users/chromano/followers","following_url":"https://api.github.com/users/chromano/following{/other_user}","gists_url":"https://api.github.com/users/chromano/gists{/gist_id}","starred_url":"https://api.github.com/users/chromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chromano/subscriptions","organizations_url":"https://api.github.com/users/chromano/orgs","repos_url":"https://api.github.com/users/chromano/repos","events_url":"https://api.github.com/users/chromano/events{/privacy}","received_events_url":"https://api.github.com/users/chromano/received_events","type":"User","site_admin":false},"body":"It has the same effect, but I think you are right, that's not the point of this PR. I will revert.","created_at":"2015-10-04T12:02:10Z","updated_at":"2015-10-04T12:02:10Z","html_url":"https://github.com/open-craft/opencraft/pull/13#discussion_r41097075","pull_request_url":"https://api.github.com/repos/open-craft/opencraft/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/open-craft/opencraft/pulls/comments/41097075"},"html":{"href":"https://github.com/open-craft/opencraft/pull/13#discussion_r41097075"},"pull_request":{"href":"https://api.github.com/repos/open-craft/opencraft/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/open-craft/opencraft/pulls/13","id":46358730,"html_url":"https://github.com/open-craft/opencraft/pull/13","diff_url":"https://github.com/open-craft/opencraft/pull/13.diff","patch_url":"https://github.com/open-craft/opencraft/pull/13.patch","issue_url":"https://api.github.com/repos/open-craft/opencraft/issues/13","number":13,"state":"open","locked":false,"title":"Error states handling","user":{"login":"chromano","id":26786,"avatar_url":"https://avatars.githubusercontent.com/u/26786?v=3","gravatar_id":"","url":"https://api.github.com/users/chromano","html_url":"https://github.com/chromano","followers_url":"https://api.github.com/users/chromano/followers","following_url":"https://api.github.com/users/chromano/following{/other_user}","gists_url":"https://api.github.com/users/chromano/gists{/gist_id}","starred_url":"https://api.github.com/users/chromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chromano/subscriptions","organizations_url":"https://api.github.com/users/chromano/orgs","repos_url":"https://api.github.com/users/chromano/repos","events_url":"https://api.github.com/users/chromano/events{/privacy}","received_events_url":"https://api.github.com/users/chromano/received_events","type":"User","site_admin":false},"body":"Handle properly error states during deployment and display in the UI the errors that happened.  Also enable retries (default: 3). /cc @antoviaque ","created_at":"2015-09-30T03:45:06Z","updated_at":"2015-10-04T12:02:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"995d1c2b4fac059d42c4cd8e0809dc9a3a28662f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/open-craft/opencraft/pulls/13/commits","review_comments_url":"https://api.github.com/repos/open-craft/opencraft/pulls/13/comments","review_comment_url":"https://api.github.com/repos/open-craft/opencraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-craft/opencraft/issues/13/comments","statuses_url":"https://api.github.com/repos/open-craft/opencraft/statuses/8b1640093dc1a35a31ce07844290e0f7e7290f90","head":{"label":"chromano:master","ref":"master","sha":"8b1640093dc1a35a31ce07844290e0f7e7290f90","user":{"login":"chromano","id":26786,"avatar_url":"https://avatars.githubusercontent.com/u/26786?v=3","gravatar_id":"","url":"https://api.github.com/users/chromano","html_url":"https://github.com/chromano","followers_url":"https://api.github.com/users/chromano/followers","following_url":"https://api.github.com/users/chromano/following{/other_user}","gists_url":"https://api.github.com/users/chromano/gists{/gist_id}","starred_url":"https://api.github.com/users/chromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chromano/subscriptions","organizations_url":"https://api.github.com/users/chromano/orgs","repos_url":"https://api.github.com/users/chromano/repos","events_url":"https://api.github.com/users/chromano/events{/privacy}","received_events_url":"https://api.github.com/users/chromano/received_events","type":"User","site_admin":false},"repo":{"id":43404581,"name":"opencraft","full_name":"chromano/opencraft","owner":{"login":"chromano","id":26786,"avatar_url":"https://avatars.githubusercontent.com/u/26786?v=3","gravatar_id":"","url":"https://api.github.com/users/chromano","html_url":"https://github.com/chromano","followers_url":"https://api.github.com/users/chromano/followers","following_url":"https://api.github.com/users/chromano/following{/other_user}","gists_url":"https://api.github.com/users/chromano/gists{/gist_id}","starred_url":"https://api.github.com/users/chromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chromano/subscriptions","organizations_url":"https://api.github.com/users/chromano/orgs","repos_url":"https://api.github.com/users/chromano/repos","events_url":"https://api.github.com/users/chromano/events{/privacy}","received_events_url":"https://api.github.com/users/chromano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chromano/opencraft","description":"OpenCraft - Instance Manager","fork":true,"url":"https://api.github.com/repos/chromano/opencraft","forks_url":"https://api.github.com/repos/chromano/opencraft/forks","keys_url":"https://api.github.com/repos/chromano/opencraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chromano/opencraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chromano/opencraft/teams","hooks_url":"https://api.github.com/repos/chromano/opencraft/hooks","issue_events_url":"https://api.github.com/repos/chromano/opencraft/issues/events{/number}","events_url":"https://api.github.com/repos/chromano/opencraft/events","assignees_url":"https://api.github.com/repos/chromano/opencraft/assignees{/user}","branches_url":"https://api.github.com/repos/chromano/opencraft/branches{/branch}","tags_url":"https://api.github.com/repos/chromano/opencraft/tags","blobs_url":"https://api.github.com/repos/chromano/opencraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chromano/opencraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chromano/opencraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/chromano/opencraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chromano/opencraft/statuses/{sha}","languages_url":"https://api.github.com/repos/chromano/opencraft/languages","stargazers_url":"https://api.github.com/repos/chromano/opencraft/stargazers","contributors_url":"https://api.github.com/repos/chromano/opencraft/contributors","subscribers_url":"https://api.github.com/repos/chromano/opencraft/subscribers","subscription_url":"https://api.github.com/repos/chromano/opencraft/subscription","commits_url":"https://api.github.com/repos/chromano/opencraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/chromano/opencraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/chromano/opencraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/chromano/opencraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/chromano/opencraft/contents/{+path}","compare_url":"https://api.github.com/repos/chromano/opencraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chromano/opencraft/merges","archive_url":"https://api.github.com/repos/chromano/opencraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chromano/opencraft/downloads","issues_url":"https://api.github.com/repos/chromano/opencraft/issues{/number}","pulls_url":"https://api.github.com/repos/chromano/opencraft/pulls{/number}","milestones_url":"https://api.github.com/repos/chromano/opencraft/milestones{/number}","notifications_url":"https://api.github.com/repos/chromano/opencraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chromano/opencraft/labels{/name}","releases_url":"https://api.github.com/repos/chromano/opencraft/releases{/id}","created_at":"2015-09-30T01:30:46Z","updated_at":"2015-09-30T01:30:47Z","pushed_at":"2015-10-04T00:37:51Z","git_url":"git://github.com/chromano/opencraft.git","ssh_url":"git@github.com:chromano/opencraft.git","clone_url":"https://github.com/chromano/opencraft.git","svn_url":"https://github.com/chromano/opencraft","homepage":null,"size":1830,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-craft:master","ref":"master","sha":"b58fabf98301bdc4129e4e3222c131f6235eab4b","user":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":40447973,"name":"opencraft","full_name":"open-craft/opencraft","owner":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/opencraft","description":"OpenCraft - Instance Manager","fork":false,"url":"https://api.github.com/repos/open-craft/opencraft","forks_url":"https://api.github.com/repos/open-craft/opencraft/forks","keys_url":"https://api.github.com/repos/open-craft/opencraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/opencraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/opencraft/teams","hooks_url":"https://api.github.com/repos/open-craft/opencraft/hooks","issue_events_url":"https://api.github.com/repos/open-craft/opencraft/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/opencraft/events","assignees_url":"https://api.github.com/repos/open-craft/opencraft/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/opencraft/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/opencraft/tags","blobs_url":"https://api.github.com/repos/open-craft/opencraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/opencraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/opencraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/opencraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/opencraft/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/opencraft/languages","stargazers_url":"https://api.github.com/repos/open-craft/opencraft/stargazers","contributors_url":"https://api.github.com/repos/open-craft/opencraft/contributors","subscribers_url":"https://api.github.com/repos/open-craft/opencraft/subscribers","subscription_url":"https://api.github.com/repos/open-craft/opencraft/subscription","commits_url":"https://api.github.com/repos/open-craft/opencraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/opencraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/opencraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/opencraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/opencraft/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/opencraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/opencraft/merges","archive_url":"https://api.github.com/repos/open-craft/opencraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/opencraft/downloads","issues_url":"https://api.github.com/repos/open-craft/opencraft/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/opencraft/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/opencraft/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/opencraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/opencraft/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/opencraft/releases{/id}","created_at":"2015-08-09T19:35:05Z","updated_at":"2015-10-01T14:21:50Z","pushed_at":"2015-10-04T11:38:38Z","git_url":"git://github.com/open-craft/opencraft.git","ssh_url":"git@github.com:open-craft/opencraft.git","clone_url":"https://github.com/open-craft/opencraft.git","svn_url":"https://github.com/open-craft/opencraft","homepage":null,"size":1830,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-craft/opencraft/pulls/13"},"html":{"href":"https://github.com/open-craft/opencraft/pull/13"},"issue":{"href":"https://api.github.com/repos/open-craft/opencraft/issues/13"},"comments":{"href":"https://api.github.com/repos/open-craft/opencraft/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/open-craft/opencraft/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/open-craft/opencraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-craft/opencraft/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/open-craft/opencraft/statuses/8b1640093dc1a35a31ce07844290e0f7e7290f90"}}}}