{"action":"created","comment":{"url":"https://api.github.com/repos/yhat/ggplot/pulls/comments/28764696","id":28764696,"diff_hunk":"@@ -24,32 +26,34 @@ def teardown_package():\n # Tests which should be run with 'python tests.py' or via 'must be\n # included here.\n default_test_modules = [\n-    'ggplot.tests.test_basic',\n-    'ggplot.tests.test_readme_examples',\n-    'ggplot.tests.test_ggplot_internals',\n-    'ggplot.tests.test_geom',\n-    'ggplot.tests.test_stat',\n-    'ggplot.tests.test_stat_calculate_methods',\n-    'ggplot.tests.test_geom_rect',\n-    'ggplot.tests.test_qplot',\n-    'ggplot.tests.test_geom_lines',\n-    'ggplot.tests.test_faceting',\n-    'ggplot.tests.test_stat_function',\n-    'ggplot.tests.test_scale_facet_wrap',\n-    'ggplot.tests.test_scale_log',\n-    'ggplot.tests.test_reverse',\n-    'ggplot.tests.test_ggsave',\n-    'ggplot.tests.test_theme_mpl',\n-    'ggplot.tests.test_colors',\n-    'ggplot.tests.test_chart_components',\n-    'ggplot.tests.test_legend',\n-    'ggplot.tests.test_element_target',\n-    'ggplot.tests.test_element_text',\n-    'ggplot.tests.test_theme',\n-    'ggplot.tests.test_theme_bw',\n-    'ggplot.tests.test_theme_gray',\n-    'ggplot.tests.test_theme_mpl',\n-    'ggplot.tests.test_theme_seaborn'\n+    # 'ggplot.tests.test_basic',","path":"ggplot/tests/__init__.py","position":39,"original_position":39,"commit_id":"18ba810220590d93cb6fe0b478f4b46f4e5519e5","original_commit_id":"18ba810220590d93cb6fe0b478f4b46f4e5519e5","user":{"login":"has2k1","id":780341,"avatar_url":"https://avatars.githubusercontent.com/u/780341?v=3","gravatar_id":"","url":"https://api.github.com/users/has2k1","html_url":"https://github.com/has2k1","followers_url":"https://api.github.com/users/has2k1/followers","following_url":"https://api.github.com/users/has2k1/following{/other_user}","gists_url":"https://api.github.com/users/has2k1/gists{/gist_id}","starred_url":"https://api.github.com/users/has2k1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/has2k1/subscriptions","organizations_url":"https://api.github.com/users/has2k1/orgs","repos_url":"https://api.github.com/users/has2k1/repos","events_url":"https://api.github.com/users/has2k1/events{/privacy}","received_events_url":"https://api.github.com/users/has2k1/received_events","type":"User","site_admin":false},"body":"As I add new tests, I don't want the full test suite running.","created_at":"2015-04-21T10:02:02Z","updated_at":"2015-04-21T10:02:02Z","html_url":"https://github.com/yhat/ggplot/pull/360#discussion_r28764696","pull_request_url":"https://api.github.com/repos/yhat/ggplot/pulls/360","_links":{"self":{"href":"https://api.github.com/repos/yhat/ggplot/pulls/comments/28764696"},"html":{"href":"https://github.com/yhat/ggplot/pull/360#discussion_r28764696"},"pull_request":{"href":"https://api.github.com/repos/yhat/ggplot/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/yhat/ggplot/pulls/360","id":19895364,"html_url":"https://github.com/yhat/ggplot/pull/360","diff_url":"https://github.com/yhat/ggplot/pull/360.diff","patch_url":"https://github.com/yhat/ggplot/pull/360.patch","issue_url":"https://api.github.com/repos/yhat/ggplot/issues/360","number":360,"state":"open","locked":false,"title":"WIP: Proper scales","user":{"login":"has2k1","id":780341,"avatar_url":"https://avatars.githubusercontent.com/u/780341?v=3","gravatar_id":"","url":"https://api.github.com/users/has2k1","html_url":"https://github.com/has2k1","followers_url":"https://api.github.com/users/has2k1/followers","following_url":"https://api.github.com/users/has2k1/following{/other_user}","gists_url":"https://api.github.com/users/has2k1/gists{/gist_id}","starred_url":"https://api.github.com/users/has2k1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/has2k1/subscriptions","organizations_url":"https://api.github.com/users/has2k1/orgs","repos_url":"https://api.github.com/users/has2k1/repos","events_url":"https://api.github.com/users/has2k1/events{/privacy}","received_events_url":"https://api.github.com/users/has2k1/received_events","type":"User","site_admin":false},"body":"Covers #283 and touches on stuff discussed in #259 and #221.\r\n\r\nThis is a complete rewrite of ~~the plotting pipeline~~ nearly everything so as to not to violate the [layered-grammar](http://vita.had.co.nz/papers/layered-grammar.pdf). As such there is a close adherence to the ggplot2 ~~plot building pipeline~~ code base.\r\n\r\nIt is far from being done, the following need to be addressed:\r\n- [x] scale transformations e.g. `log10, sqrt` (concerns in #283)\r\n- [x] matplotlib subplotting stuff\r\n- [x] Legend\r\n- [ ] Theme all elements of the plot\r\n- [ ] Rebase and apply changes\r\n- [ ] Comprehensive tests\r\n- [ ] Code profiling\r\n- [ ] pep8","created_at":"2014-08-18T00:40:51Z","updated_at":"2015-04-21T10:02:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yhat/ggplot/pulls/360/commits","review_comments_url":"https://api.github.com/repos/yhat/ggplot/pulls/360/comments","review_comment_url":"https://api.github.com/repos/yhat/ggplot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yhat/ggplot/issues/360/comments","statuses_url":"https://api.github.com/repos/yhat/ggplot/statuses/18ba810220590d93cb6fe0b478f4b46f4e5519e5","head":{"label":"has2k1:proper-scales","ref":"proper-scales","sha":"18ba810220590d93cb6fe0b478f4b46f4e5519e5","user":{"login":"has2k1","id":780341,"avatar_url":"https://avatars.githubusercontent.com/u/780341?v=3","gravatar_id":"","url":"https://api.github.com/users/has2k1","html_url":"https://github.com/has2k1","followers_url":"https://api.github.com/users/has2k1/followers","following_url":"https://api.github.com/users/has2k1/following{/other_user}","gists_url":"https://api.github.com/users/has2k1/gists{/gist_id}","starred_url":"https://api.github.com/users/has2k1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/has2k1/subscriptions","organizations_url":"https://api.github.com/users/has2k1/orgs","repos_url":"https://api.github.com/users/has2k1/repos","events_url":"https://api.github.com/users/has2k1/events{/privacy}","received_events_url":"https://api.github.com/users/has2k1/received_events","type":"User","site_admin":false},"repo":{"id":17321450,"name":"ggplot","full_name":"has2k1/ggplot","owner":{"login":"has2k1","id":780341,"avatar_url":"https://avatars.githubusercontent.com/u/780341?v=3","gravatar_id":"","url":"https://api.github.com/users/has2k1","html_url":"https://github.com/has2k1","followers_url":"https://api.github.com/users/has2k1/followers","following_url":"https://api.github.com/users/has2k1/following{/other_user}","gists_url":"https://api.github.com/users/has2k1/gists{/gist_id}","starred_url":"https://api.github.com/users/has2k1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/has2k1/subscriptions","organizations_url":"https://api.github.com/users/has2k1/orgs","repos_url":"https://api.github.com/users/has2k1/repos","events_url":"https://api.github.com/users/has2k1/events{/privacy}","received_events_url":"https://api.github.com/users/has2k1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/has2k1/ggplot","description":"ggplot for python","fork":true,"url":"https://api.github.com/repos/has2k1/ggplot","forks_url":"https://api.github.com/repos/has2k1/ggplot/forks","keys_url":"https://api.github.com/repos/has2k1/ggplot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/has2k1/ggplot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/has2k1/ggplot/teams","hooks_url":"https://api.github.com/repos/has2k1/ggplot/hooks","issue_events_url":"https://api.github.com/repos/has2k1/ggplot/issues/events{/number}","events_url":"https://api.github.com/repos/has2k1/ggplot/events","assignees_url":"https://api.github.com/repos/has2k1/ggplot/assignees{/user}","branches_url":"https://api.github.com/repos/has2k1/ggplot/branches{/branch}","tags_url":"https://api.github.com/repos/has2k1/ggplot/tags","blobs_url":"https://api.github.com/repos/has2k1/ggplot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/has2k1/ggplot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/has2k1/ggplot/git/refs{/sha}","trees_url":"https://api.github.com/repos/has2k1/ggplot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/has2k1/ggplot/statuses/{sha}","languages_url":"https://api.github.com/repos/has2k1/ggplot/languages","stargazers_url":"https://api.github.com/repos/has2k1/ggplot/stargazers","contributors_url":"https://api.github.com/repos/has2k1/ggplot/contributors","subscribers_url":"https://api.github.com/repos/has2k1/ggplot/subscribers","subscription_url":"https://api.github.com/repos/has2k1/ggplot/subscription","commits_url":"https://api.github.com/repos/has2k1/ggplot/commits{/sha}","git_commits_url":"https://api.github.com/repos/has2k1/ggplot/git/commits{/sha}","comments_url":"https://api.github.com/repos/has2k1/ggplot/comments{/number}","issue_comment_url":"https://api.github.com/repos/has2k1/ggplot/issues/comments{/number}","contents_url":"https://api.github.com/repos/has2k1/ggplot/contents/{+path}","compare_url":"https://api.github.com/repos/has2k1/ggplot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/has2k1/ggplot/merges","archive_url":"https://api.github.com/repos/has2k1/ggplot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/has2k1/ggplot/downloads","issues_url":"https://api.github.com/repos/has2k1/ggplot/issues{/number}","pulls_url":"https://api.github.com/repos/has2k1/ggplot/pulls{/number}","milestones_url":"https://api.github.com/repos/has2k1/ggplot/milestones{/number}","notifications_url":"https://api.github.com/repos/has2k1/ggplot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/has2k1/ggplot/labels{/name}","releases_url":"https://api.github.com/repos/has2k1/ggplot/releases{/id}","created_at":"2014-03-01T18:39:21Z","updated_at":"2014-04-30T07:48:37Z","pushed_at":"2015-04-19T23:07:23Z","git_url":"git://github.com/has2k1/ggplot.git","ssh_url":"git@github.com:has2k1/ggplot.git","clone_url":"https://github.com/has2k1/ggplot.git","svn_url":"https://github.com/has2k1/ggplot","homepage":"","size":44836,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yhat:master","ref":"master","sha":"0f3774e6a645796b843d3ce77fb388958773338e","user":{"login":"yhat","id":2684181,"avatar_url":"https://avatars.githubusercontent.com/u/2684181?v=3","gravatar_id":"","url":"https://api.github.com/users/yhat","html_url":"https://github.com/yhat","followers_url":"https://api.github.com/users/yhat/followers","following_url":"https://api.github.com/users/yhat/following{/other_user}","gists_url":"https://api.github.com/users/yhat/gists{/gist_id}","starred_url":"https://api.github.com/users/yhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhat/subscriptions","organizations_url":"https://api.github.com/users/yhat/orgs","repos_url":"https://api.github.com/users/yhat/repos","events_url":"https://api.github.com/users/yhat/events{/privacy}","received_events_url":"https://api.github.com/users/yhat/received_events","type":"Organization","site_admin":false},"repo":{"id":13384593,"name":"ggplot","full_name":"yhat/ggplot","owner":{"login":"yhat","id":2684181,"avatar_url":"https://avatars.githubusercontent.com/u/2684181?v=3","gravatar_id":"","url":"https://api.github.com/users/yhat","html_url":"https://github.com/yhat","followers_url":"https://api.github.com/users/yhat/followers","following_url":"https://api.github.com/users/yhat/following{/other_user}","gists_url":"https://api.github.com/users/yhat/gists{/gist_id}","starred_url":"https://api.github.com/users/yhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhat/subscriptions","organizations_url":"https://api.github.com/users/yhat/orgs","repos_url":"https://api.github.com/users/yhat/repos","events_url":"https://api.github.com/users/yhat/events{/privacy}","received_events_url":"https://api.github.com/users/yhat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yhat/ggplot","description":"ggplot for python","fork":false,"url":"https://api.github.com/repos/yhat/ggplot","forks_url":"https://api.github.com/repos/yhat/ggplot/forks","keys_url":"https://api.github.com/repos/yhat/ggplot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yhat/ggplot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yhat/ggplot/teams","hooks_url":"https://api.github.com/repos/yhat/ggplot/hooks","issue_events_url":"https://api.github.com/repos/yhat/ggplot/issues/events{/number}","events_url":"https://api.github.com/repos/yhat/ggplot/events","assignees_url":"https://api.github.com/repos/yhat/ggplot/assignees{/user}","branches_url":"https://api.github.com/repos/yhat/ggplot/branches{/branch}","tags_url":"https://api.github.com/repos/yhat/ggplot/tags","blobs_url":"https://api.github.com/repos/yhat/ggplot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yhat/ggplot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yhat/ggplot/git/refs{/sha}","trees_url":"https://api.github.com/repos/yhat/ggplot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yhat/ggplot/statuses/{sha}","languages_url":"https://api.github.com/repos/yhat/ggplot/languages","stargazers_url":"https://api.github.com/repos/yhat/ggplot/stargazers","contributors_url":"https://api.github.com/repos/yhat/ggplot/contributors","subscribers_url":"https://api.github.com/repos/yhat/ggplot/subscribers","subscription_url":"https://api.github.com/repos/yhat/ggplot/subscription","commits_url":"https://api.github.com/repos/yhat/ggplot/commits{/sha}","git_commits_url":"https://api.github.com/repos/yhat/ggplot/git/commits{/sha}","comments_url":"https://api.github.com/repos/yhat/ggplot/comments{/number}","issue_comment_url":"https://api.github.com/repos/yhat/ggplot/issues/comments{/number}","contents_url":"https://api.github.com/repos/yhat/ggplot/contents/{+path}","compare_url":"https://api.github.com/repos/yhat/ggplot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yhat/ggplot/merges","archive_url":"https://api.github.com/repos/yhat/ggplot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yhat/ggplot/downloads","issues_url":"https://api.github.com/repos/yhat/ggplot/issues{/number}","pulls_url":"https://api.github.com/repos/yhat/ggplot/pulls{/number}","milestones_url":"https://api.github.com/repos/yhat/ggplot/milestones{/number}","notifications_url":"https://api.github.com/repos/yhat/ggplot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yhat/ggplot/labels{/name}","releases_url":"https://api.github.com/repos/yhat/ggplot/releases{/id}","created_at":"2013-10-07T13:30:53Z","updated_at":"2015-04-20T18:57:33Z","pushed_at":"2015-04-19T23:07:23Z","git_url":"git://github.com/yhat/ggplot.git","ssh_url":"git@github.com:yhat/ggplot.git","clone_url":"https://github.com/yhat/ggplot.git","svn_url":"https://github.com/yhat/ggplot","homepage":"ggplot.yhathq.com","size":123396,"stargazers_count":2047,"watchers_count":2047,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":219,"mirror_url":null,"open_issues_count":185,"forks":219,"open_issues":185,"watchers":2047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yhat/ggplot/pulls/360"},"html":{"href":"https://github.com/yhat/ggplot/pull/360"},"issue":{"href":"https://api.github.com/repos/yhat/ggplot/issues/360"},"comments":{"href":"https://api.github.com/repos/yhat/ggplot/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/yhat/ggplot/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/yhat/ggplot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yhat/ggplot/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/yhat/ggplot/statuses/18ba810220590d93cb6fe0b478f4b46f4e5519e5"}}}}