{"action":"created","issue":{"url":"https://api.github.com/repos/EDmodel/ED2/issues/25","labels_url":"https://api.github.com/repos/EDmodel/ED2/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/EDmodel/ED2/issues/25/comments","events_url":"https://api.github.com/repos/EDmodel/ED2/issues/25/events","html_url":"https://github.com/EDmodel/ED2/issues/25","id":57392571,"number":25,"title":"Cold Deciduous PFT Growth","user":{"login":"DanielNScott","id":7492269,"avatar_url":"https://avatars.githubusercontent.com/u/7492269?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielNScott","html_url":"https://github.com/DanielNScott","followers_url":"https://api.github.com/users/DanielNScott/followers","following_url":"https://api.github.com/users/DanielNScott/following{/other_user}","gists_url":"https://api.github.com/users/DanielNScott/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielNScott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielNScott/subscriptions","organizations_url":"https://api.github.com/users/DanielNScott/orgs","repos_url":"https://api.github.com/users/DanielNScott/repos","events_url":"https://api.github.com/users/DanielNScott/events{/privacy}","received_events_url":"https://api.github.com/users/DanielNScott/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-02-11T23:12:40Z","updated_at":"2015-03-09T18:29:02Z","closed_at":null,"body":"I've found some sort of issue with cold deciduous pft growth at Harvard Forest, which may apply to other sites, and which looks like a code problem to me. These PFTs don't grow, at least under my inherited prescribed phenology scheme, so others running with cold-deciduous PFTs probably want to look at a breakdown of basal area by PFT to determine if this is the case for them as well. See the panels below, particularly the basal area plots. \r\n\r\n- Each set of panels is for a pft class\r\n   - the first 9 are for conifers\r\n   - the second 9 are for hardwoods.\r\n- Each plot has two trajectories;\r\n   - One in which I've changed the allowed hardwood growing season from strictly June to May - Aug.\r\n      - This is not presently a proposed fix, just an experiment.\r\n   - One in which I haven't, meaning hardwoods can only add to BDEAD in June (for lat>0)\r\n\r\nConifers:\r\n![pools - co](https://cloud.githubusercontent.com/assets/7492269/6158466/7084a56e-b1ff-11e4-9e93-040316b5946f.jpg)\r\n\r\nHardwoods (Cold Deciduous):\r\n![pools - hw](https://cloud.githubusercontent.com/assets/7492269/6158467/70858506-b1ff-11e4-8c84-42c7bba14e7b.jpg)\r\n\r\nI believe the issue has to do with the phenology flag system. Hardwoods can add to bdead provided the following code snippet is cleared (in structural_growth.f90:plant_structural_allocation):\r\n\r\n```fortran\r\n   !----- Check whether this is late spring... --------------------------------------------!\r\n   late_spring = (lat >= 0.0 .and. current_time%month ==  6) .or.                          &\r\n                 (lat <  0.0 .and. current_time%month == 12) \r\n   !---------------------------------------------------------------------------------------!\r\n\r\n\r\n   select case (ibigleaf)\r\n   case (0)\r\n      !------------------------------------------------------------------------------------!\r\n      !      Size and age structure.  Calculate fraction of bstorage going to bdead and    !\r\n      ! reproduction.  First we must make sure that the plant should do something here.  A !\r\n      ! plant should not allocate anything to reproduction or growth if it is not the      !\r\n      ! right time of year (for cold deciduous plants), or if the plants are actively      !\r\n      ! dropping leaves or off allometry.                                                  !\r\n      !------------------------------------------------------------------------------------!\r\n      if ((phenology(ipft) /= 2   .or.  late_spring) .and. phen_status == 0)    then\r\n```\r\n\r\nHere's a plot of phen_status by month, as seen by plant_structural_allocation, for 94,95, and 96.\r\n\r\n![hf_phenology_stat_by_pft](https://cloud.githubusercontent.com/assets/7492269/6174846/7fa65ea0-b2a6-11e4-990c-3fae8d68db91.jpg)\r\n\r\n\r\nYou can see that phen_status is typically not 0 for hardwoods in June. This is despite elongf being 1.0 as of late May in all the HDF5 output I've seen, which would seem to indicate that the prescribed phenology itself is not the issue. I'll update this when I know why...\r\n\r\nAny ideas/commentary appreciated...\r\n"},"comment":{"url":"https://api.github.com/repos/EDmodel/ED2/issues/comments/77913576","html_url":"https://github.com/EDmodel/ED2/issues/25#issuecomment-77913576","issue_url":"https://api.github.com/repos/EDmodel/ED2/issues/25","id":77913576,"user":{"login":"ryankelly-uiuc","id":6820366,"avatar_url":"https://avatars.githubusercontent.com/u/6820366?v=3","gravatar_id":"","url":"https://api.github.com/users/ryankelly-uiuc","html_url":"https://github.com/ryankelly-uiuc","followers_url":"https://api.github.com/users/ryankelly-uiuc/followers","following_url":"https://api.github.com/users/ryankelly-uiuc/following{/other_user}","gists_url":"https://api.github.com/users/ryankelly-uiuc/gists{/gist_id}","starred_url":"https://api.github.com/users/ryankelly-uiuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryankelly-uiuc/subscriptions","organizations_url":"https://api.github.com/users/ryankelly-uiuc/orgs","repos_url":"https://api.github.com/users/ryankelly-uiuc/repos","events_url":"https://api.github.com/users/ryankelly-uiuc/events{/privacy}","received_events_url":"https://api.github.com/users/ryankelly-uiuc/received_events","type":"User","site_admin":false},"created_at":"2015-03-09T18:29:02Z","updated_at":"2015-03-09T18:29:02Z","body":"@dlebauer ,@Viskari—the issue we were just discussing is gh-24, not this one."}}