{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/1336","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/1336/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/1336/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/1336/events","html_url":"https://github.com/mne-tools/mne-python/pull/1336","id":35564385,"number":1336,"title":"add local fdr correction","user":{"login":"maedoc","id":5189886,"avatar_url":"https://avatars.githubusercontent.com/u/5189886?v=3","gravatar_id":"","url":"https://api.github.com/users/maedoc","html_url":"https://github.com/maedoc","followers_url":"https://api.github.com/users/maedoc/followers","following_url":"https://api.github.com/users/maedoc/following{/other_user}","gists_url":"https://api.github.com/users/maedoc/gists{/gist_id}","starred_url":"https://api.github.com/users/maedoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maedoc/subscriptions","organizations_url":"https://api.github.com/users/maedoc/orgs","repos_url":"https://api.github.com/users/maedoc/repos","events_url":"https://api.github.com/users/maedoc/events{/privacy}","received_events_url":"https://api.github.com/users/maedoc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":28,"created_at":"2014-06-12T09:44:34Z","updated_at":"2015-01-12T15:30:12Z","closed_at":"2015-01-12T15:30:12Z","pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1336","html_url":"https://github.com/mne-tools/mne-python/pull/1336","diff_url":"https://github.com/mne-tools/mne-python/pull/1336.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/1336.patch"},"body":"This PR adds Efron's local false discovery rate correction for multiple comparisons. This can be useful when the number of comparisons is huge eg. source space x time or detection problems (our applications)."},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/69586782","html_url":"https://github.com/mne-tools/mne-python/pull/1336#issuecomment-69586782","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/1336","id":69586782,"user":{"login":"maedoc","id":5189886,"avatar_url":"https://avatars.githubusercontent.com/u/5189886?v=3","gravatar_id":"","url":"https://api.github.com/users/maedoc","html_url":"https://github.com/maedoc","followers_url":"https://api.github.com/users/maedoc/followers","following_url":"https://api.github.com/users/maedoc/following{/other_user}","gists_url":"https://api.github.com/users/maedoc/gists{/gist_id}","starred_url":"https://api.github.com/users/maedoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maedoc/subscriptions","organizations_url":"https://api.github.com/users/maedoc/orgs","repos_url":"https://api.github.com/users/maedoc/repos","events_url":"https://api.github.com/users/maedoc/events{/privacy}","received_events_url":"https://api.github.com/users/maedoc/received_events","type":"User","site_admin":false},"created_at":"2015-01-12T15:30:12Z","updated_at":"2015-01-12T15:30:12Z","body":"I'm closing the pull request: after further use of local FDR, I'm convinced it has drawbacks that prevent it from being reliably used along with FDR: \r\n\r\n1) the quantities aren't the same, and local FDR is not a p-value correction\r\n2) the estimation can, for certain data with weird distributions, completely fail, unlike FDR\r\n\r\nSo I no longer \"believe\" in the blind application of the method, and I'd prefer to be conservative and withdraw this code than try to \"make it work\"."}}