{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments/41609008","id":41609008,"diff_hunk":"@@ -61,80 +107,35 @@ def remove_extra_bdist_rpm_files():\n     \"\"\"\n     return []\n \n-# The following aims to import from setuptools, but if this is not available, we import the basic functionality from\n-# distutils instead. Note that setuptools make copies of the scripts, it does _not_ preserve symbolic links.\n-try:\n-    #raise ImportError(\"no setuptools\")  # to try distutils, uncomment\n-    from setuptools import setup\n-    from setuptools.command.bdist_rpm import bdist_rpm\n-    from distutils.command.bdist_rpm import bdist_rpm as orig_bdist_rpm\n-    from setuptools.command.build_py import build_py\n-    from setuptools.command.install_scripts import install_scripts\n-    from setuptools.command.sdist import sdist\n-\n-    # egg_info uses sdist directly through manifest_maker\n-    from setuptools.command.egg_info import egg_info\n-\n-    class vsc_egg_info(egg_info):\n-        \"\"\"Class to determine the set of files that should be included.\n-\n-        This amounts to including the default files, as determined by setuptools, extended with the\n-        few extra files we need to add for installation purposes.\n-        \"\"\"\n-\n-        def find_sources(self):\n-            \"\"\"Default lookup.\"\"\"\n-            egg_info.find_sources(self)\n-            self.filelist.extend(find_extra_sdist_files())\n-\n-    # TODO: this should be in the setup.py, here we should have a placeholder, so we need not change this for every\n-    # package we deploy\n-    class vsc_bdist_rpm_egg_info(vsc_egg_info):\n-        \"\"\"Class to determine the source files that should be present in an (S)RPM.\n-\n-        All __init__.py files that augment namespace packages should be installed by the\n-        dependent package, so we need not install it here.\n-        \"\"\"\n-\n-        def find_sources(self):\n-            \"\"\"Fins the sources as default and then drop the cruft.\"\"\"\n-            vsc_egg_info.find_sources(self)\n-            for f in remove_extra_bdist_rpm_files():\n-                print \"DEBUG: removing %s from source list\" % (f)\n-                self.filelist.files.remove(f)\n-\n-    has_setuptools = True\n-except ImportError as err:\n-    log.warn(\"ImportError, falling back to distutils-only: %s\", err)\n-    from distutils.core import setup\n-    from distutils.command.install_scripts import install_scripts\n-    from distutils.command.build_py import build_py\n-    from distutils.command.sdist import sdist\n-    from distutils.command.bdist_rpm import bdist_rpm as orig_bdist_rpm\n-    bdist_rpm = orig_bdist_rpm  # mimic setuptools' bdist_rpm\n \n-    class vsc_egg_info(object):\n-        pass  # dummy class for distutils\n+class vsc_egg_info(egg_info):\n+    \"\"\"Class to determine the set of files that should be included.\n \n-    class vsc_bdist_rpm_egg_info(vsc_egg_info):\n-        pass  # dummy class for distutils\n+    This amounts to including the default files, as determined by setuptools, extended with the\n+    few extra files we need to add for installation purposes.\n+    \"\"\"\n \n-    has_setuptools = False\n+    def find_sources(self):\n+        \"\"\"Default lookup.\"\"\"\n+        egg_info.find_sources(self)\n+        self.filelist.extend(find_extra_sdist_files())\n \n+# TODO: this should be in the setup.py, here we should have a placeholder, so we need not change this for every\n+# package we deploy\n+class vsc_bdist_rpm_egg_info(vsc_egg_info):\n+    \"\"\"Class to determine the source files that should be present in an (S)RPM.\n \n-# available authors\n-ag = ('Andy Georges', 'andy.georges@ugent.be')\n-jt = ('Jens Timmermans', 'jens.timmermans@ugent.be')\n-kh = ('Kenneth Hoste', 'kenneth.hoste@ugent.be')\n-lm = ('Luis Fernando Munoz Meji?as', 'luis.munoz@ugent.be')\n-sdw = ('Stijn De Weirdt', 'stijn.deweirdt@ugent.be')\n-wdp = ('Wouter Depypere', 'wouter.depypere@ugent.be')\n-kw = ('Kenneth Waegeman', 'Kenneth.Waegeman@UGent.be')\n-eh = ('Ewan Higgs', 'Ewan.Higgs@UGent.be')\n+    All __init__.py files that augment namespace packages should be installed by the\n+    dependent package, so we need not install it here.\n+    \"\"\"\n \n+    def find_sources(self):\n+        \"\"\"Fins the sources as default and then drop the cruft.\"\"\"","path":"lib/vsc/install/shared_setup.py","position":161,"original_position":161,"commit_id":"18ed55ab29ec566e811e21e66fdead7108a47aa0","original_commit_id":"18ed55ab29ec566e811e21e66fdead7108a47aa0","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"fix typo: Fins -> Finds","created_at":"2015-10-09T08:45:39Z","updated_at":"2015-10-09T08:45:39Z","html_url":"https://github.com/hpcugent/vsc-base/pull/193#discussion_r41609008","pull_request_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments/41609008"},"html":{"href":"https://github.com/hpcugent/vsc-base/pull/193#discussion_r41609008"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/193","id":47128020,"html_url":"https://github.com/hpcugent/vsc-base/pull/193","diff_url":"https://github.com/hpcugent/vsc-base/pull/193.diff","patch_url":"https://github.com/hpcugent/vsc-base/pull/193.patch","issue_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/193","number":193,"state":"open","locked":false,"title":"Support unittesting via 'python setup.py test'","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"body":"fixes #192","created_at":"2015-10-08T09:10:07Z","updated_at":"2015-10-09T08:45:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9400fe6abef4da18a0d2ebf8b4053b4ebee70ed5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/193/commits","review_comments_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/193/comments","review_comment_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/193/comments","statuses_url":"https://api.github.com/repos/hpcugent/vsc-base/statuses/18ed55ab29ec566e811e21e66fdead7108a47aa0","head":{"label":"stdweird:setup_test","ref":"setup_test","sha":"18ed55ab29ec566e811e21e66fdead7108a47aa0","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"repo":{"id":7770974,"name":"vsc-base","full_name":"stdweird/vsc-base","owner":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stdweird/vsc-base","description":"Basic Python libraries used by UGent's HPC group","fork":true,"url":"https://api.github.com/repos/stdweird/vsc-base","forks_url":"https://api.github.com/repos/stdweird/vsc-base/forks","keys_url":"https://api.github.com/repos/stdweird/vsc-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stdweird/vsc-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stdweird/vsc-base/teams","hooks_url":"https://api.github.com/repos/stdweird/vsc-base/hooks","issue_events_url":"https://api.github.com/repos/stdweird/vsc-base/issues/events{/number}","events_url":"https://api.github.com/repos/stdweird/vsc-base/events","assignees_url":"https://api.github.com/repos/stdweird/vsc-base/assignees{/user}","branches_url":"https://api.github.com/repos/stdweird/vsc-base/branches{/branch}","tags_url":"https://api.github.com/repos/stdweird/vsc-base/tags","blobs_url":"https://api.github.com/repos/stdweird/vsc-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stdweird/vsc-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stdweird/vsc-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/stdweird/vsc-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stdweird/vsc-base/statuses/{sha}","languages_url":"https://api.github.com/repos/stdweird/vsc-base/languages","stargazers_url":"https://api.github.com/repos/stdweird/vsc-base/stargazers","contributors_url":"https://api.github.com/repos/stdweird/vsc-base/contributors","subscribers_url":"https://api.github.com/repos/stdweird/vsc-base/subscribers","subscription_url":"https://api.github.com/repos/stdweird/vsc-base/subscription","commits_url":"https://api.github.com/repos/stdweird/vsc-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/stdweird/vsc-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/stdweird/vsc-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/stdweird/vsc-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/stdweird/vsc-base/contents/{+path}","compare_url":"https://api.github.com/repos/stdweird/vsc-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stdweird/vsc-base/merges","archive_url":"https://api.github.com/repos/stdweird/vsc-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stdweird/vsc-base/downloads","issues_url":"https://api.github.com/repos/stdweird/vsc-base/issues{/number}","pulls_url":"https://api.github.com/repos/stdweird/vsc-base/pulls{/number}","milestones_url":"https://api.github.com/repos/stdweird/vsc-base/milestones{/number}","notifications_url":"https://api.github.com/repos/stdweird/vsc-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stdweird/vsc-base/labels{/name}","releases_url":"https://api.github.com/repos/stdweird/vsc-base/releases{/id}","created_at":"2013-01-23T08:46:49Z","updated_at":"2014-09-05T07:09:08Z","pushed_at":"2015-10-09T08:16:52Z","git_url":"git://github.com/stdweird/vsc-base.git","ssh_url":"git@github.com:stdweird/vsc-base.git","clone_url":"https://github.com/stdweird/vsc-base.git","svn_url":"https://github.com/stdweird/vsc-base","homepage":null,"size":1755,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcugent:master","ref":"master","sha":"5f889197ccecf71af471ae7b8e27a16770cded63","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":7765704,"name":"vsc-base","full_name":"hpcugent/vsc-base","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/vsc-base","description":"Basic Python libraries used by UGent's HPC group","fork":false,"url":"https://api.github.com/repos/hpcugent/vsc-base","forks_url":"https://api.github.com/repos/hpcugent/vsc-base/forks","keys_url":"https://api.github.com/repos/hpcugent/vsc-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/vsc-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/vsc-base/teams","hooks_url":"https://api.github.com/repos/hpcugent/vsc-base/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/vsc-base/events","assignees_url":"https://api.github.com/repos/hpcugent/vsc-base/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/vsc-base/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/vsc-base/tags","blobs_url":"https://api.github.com/repos/hpcugent/vsc-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/vsc-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/vsc-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/vsc-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/vsc-base/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/vsc-base/languages","stargazers_url":"https://api.github.com/repos/hpcugent/vsc-base/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/vsc-base/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/vsc-base/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/vsc-base/subscription","commits_url":"https://api.github.com/repos/hpcugent/vsc-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/vsc-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/vsc-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/vsc-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/vsc-base/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/vsc-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/vsc-base/merges","archive_url":"https://api.github.com/repos/hpcugent/vsc-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/vsc-base/downloads","issues_url":"https://api.github.com/repos/hpcugent/vsc-base/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/vsc-base/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/vsc-base/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/vsc-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/vsc-base/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/vsc-base/releases{/id}","created_at":"2013-01-23T01:51:31Z","updated_at":"2015-08-17T21:34:39Z","pushed_at":"2015-10-09T08:16:53Z","git_url":"git://github.com/hpcugent/vsc-base.git","ssh_url":"git@github.com:hpcugent/vsc-base.git","clone_url":"https://github.com/hpcugent/vsc-base.git","svn_url":"https://github.com/hpcugent/vsc-base","homepage":null,"size":2091,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":24,"forks":24,"open_issues":24,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/193"},"html":{"href":"https://github.com/hpcugent/vsc-base/pull/193"},"issue":{"href":"https://api.github.com/repos/hpcugent/vsc-base/issues/193"},"comments":{"href":"https://api.github.com/repos/hpcugent/vsc-base/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/vsc-base/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/vsc-base/statuses/18ed55ab29ec566e811e21e66fdead7108a47aa0"}}}}