{"action":"created","issue":{"url":"https://api.github.com/repos/gordonwritescode/kad/issues/11","labels_url":"https://api.github.com/repos/gordonwritescode/kad/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/gordonwritescode/kad/issues/11/comments","events_url":"https://api.github.com/repos/gordonwritescode/kad/issues/11/events","html_url":"https://github.com/gordonwritescode/kad/pull/11","id":104598939,"number":11,"title":"WIP WebRTC transport","user":{"login":"omphalos","id":1930417,"avatar_url":"https://avatars.githubusercontent.com/u/1930417?v=3","gravatar_id":"","url":"https://api.github.com/users/omphalos","html_url":"https://github.com/omphalos","followers_url":"https://api.github.com/users/omphalos/followers","following_url":"https://api.github.com/users/omphalos/following{/other_user}","gists_url":"https://api.github.com/users/omphalos/gists{/gist_id}","starred_url":"https://api.github.com/users/omphalos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omphalos/subscriptions","organizations_url":"https://api.github.com/users/omphalos/orgs","repos_url":"https://api.github.com/users/omphalos/repos","events_url":"https://api.github.com/users/omphalos/events{/privacy}","received_events_url":"https://api.github.com/users/omphalos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":36,"created_at":"2015-09-03T00:43:33Z","updated_at":"2015-10-12T13:51:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gordonwritescode/kad/pulls/11","html_url":"https://github.com/gordonwritescode/kad/pull/11","diff_url":"https://github.com/gordonwritescode/kad/pull/11.diff","patch_url":"https://github.com/gordonwritescode/kad/pull/11.patch"},"body":"Continuing the conversation from [here](https://github.com/omphalos/kad/commit/8de7a4fe4fceb9ccc8f91c8adc6b72e94b975407#commitcomment-13023964).\r\n\r\n> Personally, I'm not fond of the places where I see this.Contact = .... It feels less than idiomatic to assign a constructor as a member of an instance. Perhaps we could avoid this.\r\n\r\nYeah, I agree with you.  I'm thinking just a `createContact` function on the transport would be better.\r\n\r\n> Right now the Transport._send method takes a port, address. Maybe it would be better to pass it a contact instead and let the transport handle checking if it's the right type of contact.\r\n\r\nGood point.\r\n\r\n> Another option is to leave Contact with IP and port and use the PeerJS server for those values and simply overload the method that assigns the nodeID.\r\n\r\nI think that's a good suggestion and would simplify things a bit."},"comment":{"url":"https://api.github.com/repos/gordonwritescode/kad/issues/comments/147405266","html_url":"https://github.com/gordonwritescode/kad/pull/11#issuecomment-147405266","issue_url":"https://api.github.com/repos/gordonwritescode/kad/issues/11","id":147405266,"user":{"login":"changetip","id":6137851,"avatar_url":"https://avatars.githubusercontent.com/u/6137851?v=3","gravatar_id":"","url":"https://api.github.com/users/changetip","html_url":"https://github.com/changetip","followers_url":"https://api.github.com/users/changetip/followers","following_url":"https://api.github.com/users/changetip/following{/other_user}","gists_url":"https://api.github.com/users/changetip/gists{/gist_id}","starred_url":"https://api.github.com/users/changetip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/changetip/subscriptions","organizations_url":"https://api.github.com/users/changetip/orgs","repos_url":"https://api.github.com/users/changetip/repos","events_url":"https://api.github.com/users/changetip/events{/privacy}","received_events_url":"https://api.github.com/users/changetip/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T13:51:01Z","updated_at":"2015-10-12T13:51:01Z","body":"Hi @omphalos, I've delivered a tip worth 1 celebrate (40,594 bits/$10.00) from @gordonwritescode to your ChangeTip pocket.\n\n\n![1 celebrate](https://media1.giphy.com/media/lz24Z42jLcTa8/giphy.gif)\n\n\n**[Learn about ChangeTip](https://www.changetip.com/tip-online/github)**"}}