{"action":"opened","number":3052,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3052","id":28298651,"html_url":"https://github.com/zfsonlinux/zfs/pull/3052","diff_url":"https://github.com/zfsonlinux/zfs/pull/3052.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/3052.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3052","number":3052,"state":"open","locked":false,"title":"Direct reclaim deadlock fixes","user":{"login":"ryao","id":1386373,"avatar_url":"https://avatars.githubusercontent.com/u/1386373?v=3","gravatar_id":"","url":"https://api.github.com/users/ryao","html_url":"https://github.com/ryao","followers_url":"https://api.github.com/users/ryao/followers","following_url":"https://api.github.com/users/ryao/following{/other_user}","gists_url":"https://api.github.com/users/ryao/gists{/gist_id}","starred_url":"https://api.github.com/users/ryao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryao/subscriptions","organizations_url":"https://api.github.com/users/ryao/orgs","repos_url":"https://api.github.com/users/ryao/repos","events_url":"https://api.github.com/users/ryao/events{/privacy}","received_events_url":"https://api.github.com/users/ryao/received_events","type":"User","site_admin":false},"body":"These are fixes for a couple of deadlocks that are possible in current HEAD. The first is a deadlock caused by recursive DMU transactions when atime updates are done by direct reclaim invoking zfs_inactive() inside DMU transactions. This is a rare issue, but one of SoftNAS' clieent systems were able to hit it consistently back in July. The fix had been in my original kmem rework proposal, but it was removed by the time it was merged. I did not notice until I rebased an old development branch. The second is a regression caused by the recent kmem rework where direct reclaim when an ARC buffer hash lock is held will attempt to lock an ARC buffer hash lock. This was not known to me when I first proposed spl_fstrans_mark()/spl_fstrans_unmark() and unfortuantely, it got past regression testing.\r\n\r\nI do not have time to run them through my usual testing at the moment, so I am leaning on the buildbot to test them.","created_at":"2015-01-29T17:37:24Z","updated_at":"2015-01-29T17:37:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3052/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3052/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3052/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/916e29afddc94dd0fc152db3d473adfbea1d4c45","head":{"label":"ryao:direct_reclaim","ref":"direct_reclaim","sha":"916e29afddc94dd0fc152db3d473adfbea1d4c45","user":{"login":"ryao","id":1386373,"avatar_url":"https://avatars.githubusercontent.com/u/1386373?v=3","gravatar_id":"","url":"https://api.github.com/users/ryao","html_url":"https://github.com/ryao","followers_url":"https://api.github.com/users/ryao/followers","following_url":"https://api.github.com/users/ryao/following{/other_user}","gists_url":"https://api.github.com/users/ryao/gists{/gist_id}","starred_url":"https://api.github.com/users/ryao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryao/subscriptions","organizations_url":"https://api.github.com/users/ryao/orgs","repos_url":"https://api.github.com/users/ryao/repos","events_url":"https://api.github.com/users/ryao/events{/privacy}","received_events_url":"https://api.github.com/users/ryao/received_events","type":"User","site_admin":false},"repo":{"id":3341695,"name":"zfs","full_name":"ryao/zfs","owner":{"login":"ryao","id":1386373,"avatar_url":"https://avatars.githubusercontent.com/u/1386373?v=3","gravatar_id":"","url":"https://api.github.com/users/ryao","html_url":"https://github.com/ryao","followers_url":"https://api.github.com/users/ryao/followers","following_url":"https://api.github.com/users/ryao/following{/other_user}","gists_url":"https://api.github.com/users/ryao/gists{/gist_id}","starred_url":"https://api.github.com/users/ryao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryao/subscriptions","organizations_url":"https://api.github.com/users/ryao/orgs","repos_url":"https://api.github.com/users/ryao/repos","events_url":"https://api.github.com/users/ryao/events{/privacy}","received_events_url":"https://api.github.com/users/ryao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryao/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/ryao/zfs","forks_url":"https://api.github.com/repos/ryao/zfs/forks","keys_url":"https://api.github.com/repos/ryao/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryao/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryao/zfs/teams","hooks_url":"https://api.github.com/repos/ryao/zfs/hooks","issue_events_url":"https://api.github.com/repos/ryao/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/ryao/zfs/events","assignees_url":"https://api.github.com/repos/ryao/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/ryao/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/ryao/zfs/tags","blobs_url":"https://api.github.com/repos/ryao/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryao/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryao/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryao/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryao/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ryao/zfs/languages","stargazers_url":"https://api.github.com/repos/ryao/zfs/stargazers","contributors_url":"https://api.github.com/repos/ryao/zfs/contributors","subscribers_url":"https://api.github.com/repos/ryao/zfs/subscribers","subscription_url":"https://api.github.com/repos/ryao/zfs/subscription","commits_url":"https://api.github.com/repos/ryao/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryao/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryao/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryao/zfs/issues/comments/{number}","contents_url":"https://api.github.com/repos/ryao/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/ryao/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryao/zfs/merges","archive_url":"https://api.github.com/repos/ryao/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryao/zfs/downloads","issues_url":"https://api.github.com/repos/ryao/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/ryao/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ryao/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ryao/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryao/zfs/labels{/name}","releases_url":"https://api.github.com/repos/ryao/zfs/releases{/id}","created_at":"2012-02-03T04:36:37Z","updated_at":"2015-01-29T17:01:22Z","pushed_at":"2015-01-29T17:20:57Z","git_url":"git://github.com/ryao/zfs.git","ssh_url":"git@github.com:ryao/zfs.git","clone_url":"https://github.com/ryao/zfs.git","svn_url":"https://github.com/ryao/zfs","homepage":"http://zfsonlinux.org/","size":27759,"stargazers_count":9,"watchers_count":9,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":9,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"6466b61db6b4def6b077882ebbd4c3e83e917613","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"Native ZFS for Linux","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments/{number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","created_at":"2009-12-14T20:20:34Z","updated_at":"2015-01-29T16:36:40Z","pushed_at":"2015-01-28T19:14:52Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":48631,"stargazers_count":1260,"watchers_count":1260,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":666,"forks":323,"open_issues":666,"watchers":1260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3052"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/3052"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/3052"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/3052/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3052/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3052/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/916e29afddc94dd0fc152db3d473adfbea1d4c45"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":46,"deletions":9,"changed_files":5}}