{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/41806263","id":41806263,"diff_hunk":"@@ -441,6 +456,44 @@ private Answer executeRequest(SyncVspCommand cmd) {\n         }\n     }\n \n+    private Answer executeRequest(SyncNuageVspCmsIdCommand cmd) {\n+        try {\n+            isNuageVspManagerLoaded();\n+            if (cmd.getSyncType() == SyncType.AUDIT || cmd.getSyncType() == SyncType.AUDIT_ONLY) {\n+                Pair<Boolean, String> answer = _nuageVspManagerClient.auditNuageVspCmsId(cmd.getNuageVspCmsId(), cmd.getSyncType() == SyncType.AUDIT_ONLY);\n+                return new SyncNuageVspCmsIdAnswer(answer.getLeft(), answer.getRight(), cmd.getSyncType());\n+            } else if (cmd.getSyncType() == SyncType.REGISTER) {\n+                String registeredNuageVspCmsId = _nuageVspManagerClient.registerNuageVspCmsId();\n+                return new SyncNuageVspCmsIdAnswer(StringUtils.isNotBlank(registeredNuageVspCmsId), registeredNuageVspCmsId, cmd.getSyncType());\n+            } else {\n+                boolean success = _nuageVspManagerClient.unregisterNuageVspCmsId(cmd.getNuageVspCmsId());\n+                return new SyncNuageVspCmsIdAnswer(success, cmd.getNuageVspCmsId(), cmd.getSyncType());\n+            }\n+        } catch (Exception e) {","path":"plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java","position":352,"original_position":315,"commit_id":"94c9dcebef03eb27521123c814d8d1426b85b671","original_commit_id":"d9530c337614530d7ab54e946d0dd733de4b048e","user":{"login":"jburwell","id":285646,"avatar_url":"https://avatars.githubusercontent.com/u/285646?v=3","gravatar_id":"","url":"https://api.github.com/users/jburwell","html_url":"https://github.com/jburwell","followers_url":"https://api.github.com/users/jburwell/followers","following_url":"https://api.github.com/users/jburwell/following{/other_user}","gists_url":"https://api.github.com/users/jburwell/gists{/gist_id}","starred_url":"https://api.github.com/users/jburwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jburwell/subscriptions","organizations_url":"https://api.github.com/users/jburwell/orgs","repos_url":"https://api.github.com/users/jburwell/repos","events_url":"https://api.github.com/users/jburwell/events{/privacy}","received_events_url":"https://api.github.com/users/jburwell/received_events","type":"User","site_admin":false},"body":"Why are all unchecked and checked exceptions being caught?  It seems like we should only be catching the expected checked exceptions, and allow unchecked exceptions simply bubble out.","created_at":"2015-10-12T22:03:15Z","updated_at":"2015-10-12T22:03:15Z","html_url":"https://github.com/apache/cloudstack/pull/801#discussion_r41806263","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/801","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/41806263"},"html":{"href":"https://github.com/apache/cloudstack/pull/801#discussion_r41806263"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/801"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/801","id":44755733,"html_url":"https://github.com/apache/cloudstack/pull/801","diff_url":"https://github.com/apache/cloudstack/pull/801.diff","patch_url":"https://github.com/apache/cloudstack/pull/801.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/801","number":801,"state":"open","locked":false,"title":"CLOUDSTACK-8832 : Update Nuage VSP plugin to work with Nuage VSP rele…","user":{"login":"nlivens","id":3336539,"avatar_url":"https://avatars.githubusercontent.com/u/3336539?v=3","gravatar_id":"","url":"https://api.github.com/users/nlivens","html_url":"https://github.com/nlivens","followers_url":"https://api.github.com/users/nlivens/followers","following_url":"https://api.github.com/users/nlivens/following{/other_user}","gists_url":"https://api.github.com/users/nlivens/gists{/gist_id}","starred_url":"https://api.github.com/users/nlivens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlivens/subscriptions","organizations_url":"https://api.github.com/users/nlivens/orgs","repos_url":"https://api.github.com/users/nlivens/repos","events_url":"https://api.github.com/users/nlivens/events{/privacy}","received_events_url":"https://api.github.com/users/nlivens/received_events","type":"User","site_admin":false},"body":"…ase 3.2","created_at":"2015-09-11T08:00:22Z","updated_at":"2015-10-12T22:03:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"119cc7aff4abe16b01c5772e2396bbca906eefe5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/801/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/801/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/801/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/94c9dcebef03eb27521123c814d8d1426b85b671","head":{"label":"nlivens:updated-nuage-vsp-plugin","ref":"updated-nuage-vsp-plugin","sha":"94c9dcebef03eb27521123c814d8d1426b85b671","user":{"login":"nlivens","id":3336539,"avatar_url":"https://avatars.githubusercontent.com/u/3336539?v=3","gravatar_id":"","url":"https://api.github.com/users/nlivens","html_url":"https://github.com/nlivens","followers_url":"https://api.github.com/users/nlivens/followers","following_url":"https://api.github.com/users/nlivens/following{/other_user}","gists_url":"https://api.github.com/users/nlivens/gists{/gist_id}","starred_url":"https://api.github.com/users/nlivens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlivens/subscriptions","organizations_url":"https://api.github.com/users/nlivens/orgs","repos_url":"https://api.github.com/users/nlivens/repos","events_url":"https://api.github.com/users/nlivens/events{/privacy}","received_events_url":"https://api.github.com/users/nlivens/received_events","type":"User","site_admin":false},"repo":{"id":41410234,"name":"cloudstack","full_name":"nlivens/cloudstack","owner":{"login":"nlivens","id":3336539,"avatar_url":"https://avatars.githubusercontent.com/u/3336539?v=3","gravatar_id":"","url":"https://api.github.com/users/nlivens","html_url":"https://github.com/nlivens","followers_url":"https://api.github.com/users/nlivens/followers","following_url":"https://api.github.com/users/nlivens/following{/other_user}","gists_url":"https://api.github.com/users/nlivens/gists{/gist_id}","starred_url":"https://api.github.com/users/nlivens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlivens/subscriptions","organizations_url":"https://api.github.com/users/nlivens/orgs","repos_url":"https://api.github.com/users/nlivens/repos","events_url":"https://api.github.com/users/nlivens/events{/privacy}","received_events_url":"https://api.github.com/users/nlivens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nlivens/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/nlivens/cloudstack","forks_url":"https://api.github.com/repos/nlivens/cloudstack/forks","keys_url":"https://api.github.com/repos/nlivens/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nlivens/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nlivens/cloudstack/teams","hooks_url":"https://api.github.com/repos/nlivens/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/nlivens/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/nlivens/cloudstack/events","assignees_url":"https://api.github.com/repos/nlivens/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/nlivens/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/nlivens/cloudstack/tags","blobs_url":"https://api.github.com/repos/nlivens/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nlivens/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nlivens/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/nlivens/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nlivens/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/nlivens/cloudstack/languages","stargazers_url":"https://api.github.com/repos/nlivens/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/nlivens/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/nlivens/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/nlivens/cloudstack/subscription","commits_url":"https://api.github.com/repos/nlivens/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/nlivens/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/nlivens/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/nlivens/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/nlivens/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/nlivens/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nlivens/cloudstack/merges","archive_url":"https://api.github.com/repos/nlivens/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nlivens/cloudstack/downloads","issues_url":"https://api.github.com/repos/nlivens/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/nlivens/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/nlivens/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/nlivens/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nlivens/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/nlivens/cloudstack/releases{/id}","created_at":"2015-08-26T07:06:01Z","updated_at":"2015-08-26T07:06:22Z","pushed_at":"2015-10-11T10:20:59Z","git_url":"git://github.com/nlivens/cloudstack.git","ssh_url":"git@github.com:nlivens/cloudstack.git","clone_url":"https://github.com/nlivens/cloudstack.git","svn_url":"https://github.com/nlivens/cloudstack","homepage":null,"size":493667,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"fddf59f8852000c5f3905197508d4cd129f6cc1b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-10-11T15:03:15Z","pushed_at":"2015-10-12T17:18:55Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":761478,"stargazers_count":299,"watchers_count":299,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":385,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":109,"forks":385,"open_issues":109,"watchers":299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/801"},"html":{"href":"https://github.com/apache/cloudstack/pull/801"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/801"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/801/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/801/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/801/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/94c9dcebef03eb27521123c814d8d1426b85b671"}}}}