{"action":"opened","number":558,"pull_request":{"url":"https://api.github.com/repos/deployd/deployd/pulls/558","id":34780461,"html_url":"https://github.com/deployd/deployd/pull/558","diff_url":"https://github.com/deployd/deployd/pull/558.diff","patch_url":"https://github.com/deployd/deployd/pull/558.patch","issue_url":"https://api.github.com/repos/deployd/deployd/issues/558","number":558,"state":"open","locked":false,"title":"fix(store): add error handling in callbacks","user":{"login":"chcokr","id":3670967,"avatar_url":"https://avatars.githubusercontent.com/u/3670967?v=3","gravatar_id":"","url":"https://api.github.com/users/chcokr","html_url":"https://github.com/chcokr","followers_url":"https://api.github.com/users/chcokr/followers","following_url":"https://api.github.com/users/chcokr/following{/other_user}","gists_url":"https://api.github.com/users/chcokr/gists{/gist_id}","starred_url":"https://api.github.com/users/chcokr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcokr/subscriptions","organizations_url":"https://api.github.com/users/chcokr/orgs","repos_url":"https://api.github.com/users/chcokr/repos","events_url":"https://api.github.com/users/chcokr/events{/privacy}","received_events_url":"https://api.github.com/users/chcokr/received_events","type":"User","site_admin":false},"body":"Add error handling inside certain callbacks in Store's methods. Despite an error being passed in and therefore no second argument such as `col` is being passed in, these callbacks assume the second argument is not `undefined` and make use of it, causing ReferenceErrors. Affected methods are as follows:\r\n- Store.protoype.find\r\n- Store.protoype.first\r\n- Store.protoype.insert\r\n- Store.protoype.update\r\n- Store.protoype.remove\r\n- Store.protoype.rename\r\n\r\nNo breaking changes, no GitHub issues being closed.","created_at":"2015-05-06T00:24:42Z","updated_at":"2015-05-06T00:24:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9246ea6303c02116f3a73421c057ba5633c90ba9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deployd/deployd/pulls/558/commits","review_comments_url":"https://api.github.com/repos/deployd/deployd/pulls/558/comments","review_comment_url":"https://api.github.com/repos/deployd/deployd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deployd/deployd/issues/558/comments","statuses_url":"https://api.github.com/repos/deployd/deployd/statuses/0bbce4e7940b84e96050a7cccbe304fc80656e02","head":{"label":"chcokr:store-err-handle","ref":"store-err-handle","sha":"0bbce4e7940b84e96050a7cccbe304fc80656e02","user":{"login":"chcokr","id":3670967,"avatar_url":"https://avatars.githubusercontent.com/u/3670967?v=3","gravatar_id":"","url":"https://api.github.com/users/chcokr","html_url":"https://github.com/chcokr","followers_url":"https://api.github.com/users/chcokr/followers","following_url":"https://api.github.com/users/chcokr/following{/other_user}","gists_url":"https://api.github.com/users/chcokr/gists{/gist_id}","starred_url":"https://api.github.com/users/chcokr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcokr/subscriptions","organizations_url":"https://api.github.com/users/chcokr/orgs","repos_url":"https://api.github.com/users/chcokr/repos","events_url":"https://api.github.com/users/chcokr/events{/privacy}","received_events_url":"https://api.github.com/users/chcokr/received_events","type":"User","site_admin":false},"repo":{"id":35128757,"name":"deployd","full_name":"chcokr/deployd","owner":{"login":"chcokr","id":3670967,"avatar_url":"https://avatars.githubusercontent.com/u/3670967?v=3","gravatar_id":"","url":"https://api.github.com/users/chcokr","html_url":"https://github.com/chcokr","followers_url":"https://api.github.com/users/chcokr/followers","following_url":"https://api.github.com/users/chcokr/following{/other_user}","gists_url":"https://api.github.com/users/chcokr/gists{/gist_id}","starred_url":"https://api.github.com/users/chcokr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcokr/subscriptions","organizations_url":"https://api.github.com/users/chcokr/orgs","repos_url":"https://api.github.com/users/chcokr/repos","events_url":"https://api.github.com/users/chcokr/events{/privacy}","received_events_url":"https://api.github.com/users/chcokr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chcokr/deployd","description":"a toolkit for building realtime APIs","fork":true,"url":"https://api.github.com/repos/chcokr/deployd","forks_url":"https://api.github.com/repos/chcokr/deployd/forks","keys_url":"https://api.github.com/repos/chcokr/deployd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chcokr/deployd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chcokr/deployd/teams","hooks_url":"https://api.github.com/repos/chcokr/deployd/hooks","issue_events_url":"https://api.github.com/repos/chcokr/deployd/issues/events{/number}","events_url":"https://api.github.com/repos/chcokr/deployd/events","assignees_url":"https://api.github.com/repos/chcokr/deployd/assignees{/user}","branches_url":"https://api.github.com/repos/chcokr/deployd/branches{/branch}","tags_url":"https://api.github.com/repos/chcokr/deployd/tags","blobs_url":"https://api.github.com/repos/chcokr/deployd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chcokr/deployd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chcokr/deployd/git/refs{/sha}","trees_url":"https://api.github.com/repos/chcokr/deployd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chcokr/deployd/statuses/{sha}","languages_url":"https://api.github.com/repos/chcokr/deployd/languages","stargazers_url":"https://api.github.com/repos/chcokr/deployd/stargazers","contributors_url":"https://api.github.com/repos/chcokr/deployd/contributors","subscribers_url":"https://api.github.com/repos/chcokr/deployd/subscribers","subscription_url":"https://api.github.com/repos/chcokr/deployd/subscription","commits_url":"https://api.github.com/repos/chcokr/deployd/commits{/sha}","git_commits_url":"https://api.github.com/repos/chcokr/deployd/git/commits{/sha}","comments_url":"https://api.github.com/repos/chcokr/deployd/comments{/number}","issue_comment_url":"https://api.github.com/repos/chcokr/deployd/issues/comments{/number}","contents_url":"https://api.github.com/repos/chcokr/deployd/contents/{+path}","compare_url":"https://api.github.com/repos/chcokr/deployd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chcokr/deployd/merges","archive_url":"https://api.github.com/repos/chcokr/deployd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chcokr/deployd/downloads","issues_url":"https://api.github.com/repos/chcokr/deployd/issues{/number}","pulls_url":"https://api.github.com/repos/chcokr/deployd/pulls{/number}","milestones_url":"https://api.github.com/repos/chcokr/deployd/milestones{/number}","notifications_url":"https://api.github.com/repos/chcokr/deployd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chcokr/deployd/labels{/name}","releases_url":"https://api.github.com/repos/chcokr/deployd/releases{/id}","created_at":"2015-05-05T23:22:37Z","updated_at":"2015-05-05T23:34:08Z","pushed_at":"2015-05-06T00:24:00Z","git_url":"git://github.com/chcokr/deployd.git","ssh_url":"git@github.com:chcokr/deployd.git","clone_url":"https://github.com/chcokr/deployd.git","svn_url":"https://github.com/chcokr/deployd","homepage":"http://www.deployd.com","size":19522,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deployd:master","ref":"master","sha":"1d6bec51e791b894c6dfa8286401045be709c93f","user":{"login":"deployd","id":1043054,"avatar_url":"https://avatars.githubusercontent.com/u/1043054?v=3","gravatar_id":"","url":"https://api.github.com/users/deployd","html_url":"https://github.com/deployd","followers_url":"https://api.github.com/users/deployd/followers","following_url":"https://api.github.com/users/deployd/following{/other_user}","gists_url":"https://api.github.com/users/deployd/gists{/gist_id}","starred_url":"https://api.github.com/users/deployd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deployd/subscriptions","organizations_url":"https://api.github.com/users/deployd/orgs","repos_url":"https://api.github.com/users/deployd/repos","events_url":"https://api.github.com/users/deployd/events{/privacy}","received_events_url":"https://api.github.com/users/deployd/received_events","type":"Organization","site_admin":false},"repo":{"id":2367681,"name":"deployd","full_name":"deployd/deployd","owner":{"login":"deployd","id":1043054,"avatar_url":"https://avatars.githubusercontent.com/u/1043054?v=3","gravatar_id":"","url":"https://api.github.com/users/deployd","html_url":"https://github.com/deployd","followers_url":"https://api.github.com/users/deployd/followers","following_url":"https://api.github.com/users/deployd/following{/other_user}","gists_url":"https://api.github.com/users/deployd/gists{/gist_id}","starred_url":"https://api.github.com/users/deployd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deployd/subscriptions","organizations_url":"https://api.github.com/users/deployd/orgs","repos_url":"https://api.github.com/users/deployd/repos","events_url":"https://api.github.com/users/deployd/events{/privacy}","received_events_url":"https://api.github.com/users/deployd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deployd/deployd","description":"a toolkit for building realtime APIs","fork":false,"url":"https://api.github.com/repos/deployd/deployd","forks_url":"https://api.github.com/repos/deployd/deployd/forks","keys_url":"https://api.github.com/repos/deployd/deployd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deployd/deployd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deployd/deployd/teams","hooks_url":"https://api.github.com/repos/deployd/deployd/hooks","issue_events_url":"https://api.github.com/repos/deployd/deployd/issues/events{/number}","events_url":"https://api.github.com/repos/deployd/deployd/events","assignees_url":"https://api.github.com/repos/deployd/deployd/assignees{/user}","branches_url":"https://api.github.com/repos/deployd/deployd/branches{/branch}","tags_url":"https://api.github.com/repos/deployd/deployd/tags","blobs_url":"https://api.github.com/repos/deployd/deployd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deployd/deployd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deployd/deployd/git/refs{/sha}","trees_url":"https://api.github.com/repos/deployd/deployd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deployd/deployd/statuses/{sha}","languages_url":"https://api.github.com/repos/deployd/deployd/languages","stargazers_url":"https://api.github.com/repos/deployd/deployd/stargazers","contributors_url":"https://api.github.com/repos/deployd/deployd/contributors","subscribers_url":"https://api.github.com/repos/deployd/deployd/subscribers","subscription_url":"https://api.github.com/repos/deployd/deployd/subscription","commits_url":"https://api.github.com/repos/deployd/deployd/commits{/sha}","git_commits_url":"https://api.github.com/repos/deployd/deployd/git/commits{/sha}","comments_url":"https://api.github.com/repos/deployd/deployd/comments{/number}","issue_comment_url":"https://api.github.com/repos/deployd/deployd/issues/comments{/number}","contents_url":"https://api.github.com/repos/deployd/deployd/contents/{+path}","compare_url":"https://api.github.com/repos/deployd/deployd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deployd/deployd/merges","archive_url":"https://api.github.com/repos/deployd/deployd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deployd/deployd/downloads","issues_url":"https://api.github.com/repos/deployd/deployd/issues{/number}","pulls_url":"https://api.github.com/repos/deployd/deployd/pulls{/number}","milestones_url":"https://api.github.com/repos/deployd/deployd/milestones{/number}","notifications_url":"https://api.github.com/repos/deployd/deployd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deployd/deployd/labels{/name}","releases_url":"https://api.github.com/repos/deployd/deployd/releases{/id}","created_at":"2011-09-11T21:58:04Z","updated_at":"2015-05-05T17:45:16Z","pushed_at":"2015-05-06T00:24:42Z","git_url":"git://github.com/deployd/deployd.git","ssh_url":"git@github.com:deployd/deployd.git","clone_url":"https://github.com/deployd/deployd.git","svn_url":"https://github.com/deployd/deployd","homepage":"http://www.deployd.com","size":19522,"stargazers_count":3179,"watchers_count":3179,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":457,"mirror_url":null,"open_issues_count":127,"forks":457,"open_issues":127,"watchers":3179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deployd/deployd/pulls/558"},"html":{"href":"https://github.com/deployd/deployd/pull/558"},"issue":{"href":"https://api.github.com/repos/deployd/deployd/issues/558"},"comments":{"href":"https://api.github.com/repos/deployd/deployd/issues/558/comments"},"review_comments":{"href":"https://api.github.com/repos/deployd/deployd/pulls/558/comments"},"review_comment":{"href":"https://api.github.com/repos/deployd/deployd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deployd/deployd/pulls/558/commits"},"statuses":{"href":"https://api.github.com/repos/deployd/deployd/statuses/0bbce4e7940b84e96050a7cccbe304fc80656e02"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":52,"deletions":0,"changed_files":1}}