{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/23401561","id":23401561,"diff_hunk":"@@ -120,6 +127,15 @@ def get(key)\n     #   person.errors.set(:name, [\"can't be nil\"])\n     #   person.errors.get(:name) # => [\"can't be nil\"]\n     def set(key, value)\n+      ActiveSupport::Deprecation.warn(<<-MESSAGE.squish)\n+        ActiveModel::Errors#set is deprecated and will be removed in Rails 5.1\n+\n+        To achieve the same use\n+        delete(:#{key}) followed by","path":"activemodel/lib/active_model/errors.rb","position":null,"original_position":41,"commit_id":"4d4f8c9a6f62ac48caa58f697844e12e9aa8268d","original_commit_id":"cddd4ea0c1ced8ffd2b616f3e9102a69d832c3b3","user":{"login":"morgoth","id":10766,"avatar_url":"https://avatars.githubusercontent.com/u/10766?v=3","gravatar_id":"","url":"https://api.github.com/users/morgoth","html_url":"https://github.com/morgoth","followers_url":"https://api.github.com/users/morgoth/followers","following_url":"https://api.github.com/users/morgoth/following{/other_user}","gists_url":"https://api.github.com/users/morgoth/gists{/gist_id}","starred_url":"https://api.github.com/users/morgoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgoth/subscriptions","organizations_url":"https://api.github.com/users/morgoth/orgs","repos_url":"https://api.github.com/users/morgoth/repos","events_url":"https://api.github.com/users/morgoth/events{/privacy}","received_events_url":"https://api.github.com/users/morgoth/received_events","type":"User","site_admin":false},"body":"It doesn't need to - already fixed.","created_at":"2015-01-22T19:19:54Z","updated_at":"2015-01-22T19:19:54Z","html_url":"https://github.com/rails/rails/pull/18634#discussion_r23401561","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/18634","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/23401561"},"html":{"href":"https://github.com/rails/rails/pull/18634#discussion_r23401561"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/18634"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/18634","id":27799627,"html_url":"https://github.com/rails/rails/pull/18634","diff_url":"https://github.com/rails/rails/pull/18634.diff","patch_url":"https://github.com/rails/rails/pull/18634.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/18634","number":18634,"state":"open","locked":false,"title":"Deprecate `ActiveModel::Errors` `get`, `set` and `[]=` methods.","user":{"login":"morgoth","id":10766,"avatar_url":"https://avatars.githubusercontent.com/u/10766?v=3","gravatar_id":"","url":"https://api.github.com/users/morgoth","html_url":"https://github.com/morgoth","followers_url":"https://api.github.com/users/morgoth/followers","following_url":"https://api.github.com/users/morgoth/following{/other_user}","gists_url":"https://api.github.com/users/morgoth/gists{/gist_id}","starred_url":"https://api.github.com/users/morgoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgoth/subscriptions","organizations_url":"https://api.github.com/users/morgoth/orgs","repos_url":"https://api.github.com/users/morgoth/repos","events_url":"https://api.github.com/users/morgoth/events{/privacy}","received_events_url":"https://api.github.com/users/morgoth/received_events","type":"User","site_admin":false},"body":"They have inconsistent behaviour currently.\r\n\r\nAs discussed in https://github.com/rails/rails/pull/18631\r\n\r\nDo you think we can go further and deprecate also `add_on_blank` and `add_on_empty`?\r\nNot sure what is the usecase for them and it's easy enough to write it on your own when needed.","created_at":"2015-01-21T22:08:27Z","updated_at":"2015-01-22T19:19:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"117be7d3bfa68c6d9bc66ea9161581219552a9de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/18634/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/18634/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/18634/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/4d4f8c9a6f62ac48caa58f697844e12e9aa8268d","head":{"label":"morgoth:deprecate-some-errors-methods","ref":"deprecate-some-errors-methods","sha":"4d4f8c9a6f62ac48caa58f697844e12e9aa8268d","user":{"login":"morgoth","id":10766,"avatar_url":"https://avatars.githubusercontent.com/u/10766?v=3","gravatar_id":"","url":"https://api.github.com/users/morgoth","html_url":"https://github.com/morgoth","followers_url":"https://api.github.com/users/morgoth/followers","following_url":"https://api.github.com/users/morgoth/following{/other_user}","gists_url":"https://api.github.com/users/morgoth/gists{/gist_id}","starred_url":"https://api.github.com/users/morgoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgoth/subscriptions","organizations_url":"https://api.github.com/users/morgoth/orgs","repos_url":"https://api.github.com/users/morgoth/repos","events_url":"https://api.github.com/users/morgoth/events{/privacy}","received_events_url":"https://api.github.com/users/morgoth/received_events","type":"User","site_admin":false},"repo":{"id":2748795,"name":"rails","full_name":"morgoth/rails","owner":{"login":"morgoth","id":10766,"avatar_url":"https://avatars.githubusercontent.com/u/10766?v=3","gravatar_id":"","url":"https://api.github.com/users/morgoth","html_url":"https://github.com/morgoth","followers_url":"https://api.github.com/users/morgoth/followers","following_url":"https://api.github.com/users/morgoth/following{/other_user}","gists_url":"https://api.github.com/users/morgoth/gists{/gist_id}","starred_url":"https://api.github.com/users/morgoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgoth/subscriptions","organizations_url":"https://api.github.com/users/morgoth/orgs","repos_url":"https://api.github.com/users/morgoth/repos","events_url":"https://api.github.com/users/morgoth/events{/privacy}","received_events_url":"https://api.github.com/users/morgoth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/morgoth/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/morgoth/rails","forks_url":"https://api.github.com/repos/morgoth/rails/forks","keys_url":"https://api.github.com/repos/morgoth/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morgoth/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morgoth/rails/teams","hooks_url":"https://api.github.com/repos/morgoth/rails/hooks","issue_events_url":"https://api.github.com/repos/morgoth/rails/issues/events{/number}","events_url":"https://api.github.com/repos/morgoth/rails/events","assignees_url":"https://api.github.com/repos/morgoth/rails/assignees{/user}","branches_url":"https://api.github.com/repos/morgoth/rails/branches{/branch}","tags_url":"https://api.github.com/repos/morgoth/rails/tags","blobs_url":"https://api.github.com/repos/morgoth/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morgoth/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morgoth/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/morgoth/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morgoth/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/morgoth/rails/languages","stargazers_url":"https://api.github.com/repos/morgoth/rails/stargazers","contributors_url":"https://api.github.com/repos/morgoth/rails/contributors","subscribers_url":"https://api.github.com/repos/morgoth/rails/subscribers","subscription_url":"https://api.github.com/repos/morgoth/rails/subscription","commits_url":"https://api.github.com/repos/morgoth/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/morgoth/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/morgoth/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/morgoth/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/morgoth/rails/contents/{+path}","compare_url":"https://api.github.com/repos/morgoth/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morgoth/rails/merges","archive_url":"https://api.github.com/repos/morgoth/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morgoth/rails/downloads","issues_url":"https://api.github.com/repos/morgoth/rails/issues{/number}","pulls_url":"https://api.github.com/repos/morgoth/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/morgoth/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/morgoth/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morgoth/rails/labels{/name}","releases_url":"https://api.github.com/repos/morgoth/rails/releases{/id}","created_at":"2011-11-10T13:53:52Z","updated_at":"2014-12-01T19:16:55Z","pushed_at":"2015-01-22T19:17:55Z","git_url":"git://github.com/morgoth/rails.git","ssh_url":"git@github.com:morgoth/rails.git","clone_url":"https://github.com/morgoth/rails.git","svn_url":"https://github.com/morgoth/rails","homepage":"http://rubyonrails.org","size":110662,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"139c232b075da940cdf1042dcaad4c3b514908c9","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-01-22T18:50:44Z","pushed_at":"2015-01-22T17:22:19Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":361473,"stargazers_count":24662,"watchers_count":24662,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9548,"mirror_url":null,"open_issues_count":767,"forks":9548,"open_issues":767,"watchers":24662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/18634"},"html":{"href":"https://github.com/rails/rails/pull/18634"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/18634"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/18634/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/18634/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/18634/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/4d4f8c9a6f62ac48caa58f697844e12e9aa8268d"}}}}