{"action":"created","comment":{"url":"https://api.github.com/repos/pypa/pip/pulls/comments/40612697","id":40612697,"diff_hunk":"@@ -668,19 +668,24 @@ def _build_one(self, req, output_dir):\n                     logger.info('Stored in directory: %s', output_dir)\n                     return wheel_path\n                 except:\n-                    return None\n+                    pass","path":"pip/wheel.py","position":5,"original_position":5,"commit_id":"7f58c07a251bcf8e309f6caeefeed24cf136b785","original_commit_id":"7f58c07a251bcf8e309f6caeefeed24cf136b785","user":{"login":"pfmoore","id":1110419,"avatar_url":"https://avatars.githubusercontent.com/u/1110419?v=3","gravatar_id":"","url":"https://api.github.com/users/pfmoore","html_url":"https://github.com/pfmoore","followers_url":"https://api.github.com/users/pfmoore/followers","following_url":"https://api.github.com/users/pfmoore/following{/other_user}","gists_url":"https://api.github.com/users/pfmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/pfmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfmoore/subscriptions","organizations_url":"https://api.github.com/users/pfmoore/orgs","repos_url":"https://api.github.com/users/pfmoore/repos","events_url":"https://api.github.com/users/pfmoore/events{/privacy}","received_events_url":"https://api.github.com/users/pfmoore/received_events","type":"User","site_admin":false},"body":"Correction - if the wheel build fails, that results in ```__build_one``` returning ```False```. The ```except``` clause here is solely if the wheel build *succeeded*, but the process of moving the wheel into ```wheel_path``` (the cache, presumably?) failed.\r\n\r\nIn that case, agreed a debug of the exception might be useful. But logging at warning level that caching the wheel failed is *also* probably useful. Both points are independent of this patch, though, so I think they should be dealt with separately.","created_at":"2015-09-28T22:15:41Z","updated_at":"2015-09-28T22:15:41Z","html_url":"https://github.com/pypa/pip/pull/3047#discussion_r40612697","pull_request_url":"https://api.github.com/repos/pypa/pip/pulls/3047","_links":{"self":{"href":"https://api.github.com/repos/pypa/pip/pulls/comments/40612697"},"html":{"href":"https://github.com/pypa/pip/pull/3047#discussion_r40612697"},"pull_request":{"href":"https://api.github.com/repos/pypa/pip/pulls/3047"}}},"pull_request":{"url":"https://api.github.com/repos/pypa/pip/pulls/3047","id":43085977,"html_url":"https://github.com/pypa/pip/pull/3047","diff_url":"https://github.com/pypa/pip/pull/3047.diff","patch_url":"https://github.com/pypa/pip/pull/3047.patch","issue_url":"https://api.github.com/repos/pypa/pip/issues/3047","number":3047,"state":"open","locked":false,"title":"Clean build dir if bdist_wheel fails","user":{"login":"tgs","id":229502,"avatar_url":"https://avatars.githubusercontent.com/u/229502?v=3","gravatar_id":"","url":"https://api.github.com/users/tgs","html_url":"https://github.com/tgs","followers_url":"https://api.github.com/users/tgs/followers","following_url":"https://api.github.com/users/tgs/following{/other_user}","gists_url":"https://api.github.com/users/tgs/gists{/gist_id}","starred_url":"https://api.github.com/users/tgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgs/subscriptions","organizations_url":"https://api.github.com/users/tgs/orgs","repos_url":"https://api.github.com/users/tgs/repos","events_url":"https://api.github.com/users/tgs/events{/privacy}","received_events_url":"https://api.github.com/users/tgs/received_events","type":"User","site_admin":false},"body":"When pip tries to build a wheel but fails, setup.py install is run in\r\nthe same directory.  However, some build files are not compatible\r\nbetween 'install' and 'bdist_wheel', particularly scripts - the shebang\r\nlines are different.  Pip now cleans the build dir after a failed\r\nbdist_wheel so that pip doesn't install broken scripts.\r\n\r\nCloses #3006","created_at":"2015-08-21T22:07:33Z","updated_at":"2015-09-28T22:15:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d5b70285e1a8d86cf561fe3aa7ef81d593e2d68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pypa/pip/pulls/3047/commits","review_comments_url":"https://api.github.com/repos/pypa/pip/pulls/3047/comments","review_comment_url":"https://api.github.com/repos/pypa/pip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypa/pip/issues/3047/comments","statuses_url":"https://api.github.com/repos/pypa/pip/statuses/7f58c07a251bcf8e309f6caeefeed24cf136b785","head":{"label":"tgs:clean_wheel_build_dir","ref":"clean_wheel_build_dir","sha":"7f58c07a251bcf8e309f6caeefeed24cf136b785","user":{"login":"tgs","id":229502,"avatar_url":"https://avatars.githubusercontent.com/u/229502?v=3","gravatar_id":"","url":"https://api.github.com/users/tgs","html_url":"https://github.com/tgs","followers_url":"https://api.github.com/users/tgs/followers","following_url":"https://api.github.com/users/tgs/following{/other_user}","gists_url":"https://api.github.com/users/tgs/gists{/gist_id}","starred_url":"https://api.github.com/users/tgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgs/subscriptions","organizations_url":"https://api.github.com/users/tgs/orgs","repos_url":"https://api.github.com/users/tgs/repos","events_url":"https://api.github.com/users/tgs/events{/privacy}","received_events_url":"https://api.github.com/users/tgs/received_events","type":"User","site_admin":false},"repo":{"id":41179186,"name":"pip","full_name":"tgs/pip","owner":{"login":"tgs","id":229502,"avatar_url":"https://avatars.githubusercontent.com/u/229502?v=3","gravatar_id":"","url":"https://api.github.com/users/tgs","html_url":"https://github.com/tgs","followers_url":"https://api.github.com/users/tgs/followers","following_url":"https://api.github.com/users/tgs/following{/other_user}","gists_url":"https://api.github.com/users/tgs/gists{/gist_id}","starred_url":"https://api.github.com/users/tgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgs/subscriptions","organizations_url":"https://api.github.com/users/tgs/orgs","repos_url":"https://api.github.com/users/tgs/repos","events_url":"https://api.github.com/users/tgs/events{/privacy}","received_events_url":"https://api.github.com/users/tgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tgs/pip","description":"The PyPA recommended tool for installing Python packages","fork":true,"url":"https://api.github.com/repos/tgs/pip","forks_url":"https://api.github.com/repos/tgs/pip/forks","keys_url":"https://api.github.com/repos/tgs/pip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgs/pip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgs/pip/teams","hooks_url":"https://api.github.com/repos/tgs/pip/hooks","issue_events_url":"https://api.github.com/repos/tgs/pip/issues/events{/number}","events_url":"https://api.github.com/repos/tgs/pip/events","assignees_url":"https://api.github.com/repos/tgs/pip/assignees{/user}","branches_url":"https://api.github.com/repos/tgs/pip/branches{/branch}","tags_url":"https://api.github.com/repos/tgs/pip/tags","blobs_url":"https://api.github.com/repos/tgs/pip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgs/pip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgs/pip/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgs/pip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgs/pip/statuses/{sha}","languages_url":"https://api.github.com/repos/tgs/pip/languages","stargazers_url":"https://api.github.com/repos/tgs/pip/stargazers","contributors_url":"https://api.github.com/repos/tgs/pip/contributors","subscribers_url":"https://api.github.com/repos/tgs/pip/subscribers","subscription_url":"https://api.github.com/repos/tgs/pip/subscription","commits_url":"https://api.github.com/repos/tgs/pip/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgs/pip/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgs/pip/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgs/pip/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgs/pip/contents/{+path}","compare_url":"https://api.github.com/repos/tgs/pip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgs/pip/merges","archive_url":"https://api.github.com/repos/tgs/pip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgs/pip/downloads","issues_url":"https://api.github.com/repos/tgs/pip/issues{/number}","pulls_url":"https://api.github.com/repos/tgs/pip/pulls{/number}","milestones_url":"https://api.github.com/repos/tgs/pip/milestones{/number}","notifications_url":"https://api.github.com/repos/tgs/pip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgs/pip/labels{/name}","releases_url":"https://api.github.com/repos/tgs/pip/releases{/id}","created_at":"2015-08-21T21:57:36Z","updated_at":"2015-08-21T21:57:37Z","pushed_at":"2015-09-09T19:17:33Z","git_url":"git://github.com/tgs/pip.git","ssh_url":"git@github.com:tgs/pip.git","clone_url":"https://github.com/tgs/pip.git","svn_url":"https://github.com/tgs/pip","homepage":"https://pip.pypa.io/","size":38306,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"pypa:develop","ref":"develop","sha":"bd863d7c6efd8cc8a0b41934766c8db561e57bc9","user":{"login":"pypa","id":647025,"avatar_url":"https://avatars.githubusercontent.com/u/647025?v=3","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":1446467,"name":"pip","full_name":"pypa/pip","owner":{"login":"pypa","id":647025,"avatar_url":"https://avatars.githubusercontent.com/u/647025?v=3","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pypa/pip","description":"The PyPA recommended tool for installing Python packages","fork":false,"url":"https://api.github.com/repos/pypa/pip","forks_url":"https://api.github.com/repos/pypa/pip/forks","keys_url":"https://api.github.com/repos/pypa/pip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/pip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/pip/teams","hooks_url":"https://api.github.com/repos/pypa/pip/hooks","issue_events_url":"https://api.github.com/repos/pypa/pip/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/pip/events","assignees_url":"https://api.github.com/repos/pypa/pip/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/pip/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/pip/tags","blobs_url":"https://api.github.com/repos/pypa/pip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/pip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/pip/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/pip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/pip/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/pip/languages","stargazers_url":"https://api.github.com/repos/pypa/pip/stargazers","contributors_url":"https://api.github.com/repos/pypa/pip/contributors","subscribers_url":"https://api.github.com/repos/pypa/pip/subscribers","subscription_url":"https://api.github.com/repos/pypa/pip/subscription","commits_url":"https://api.github.com/repos/pypa/pip/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/pip/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/pip/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/pip/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/pip/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/pip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/pip/merges","archive_url":"https://api.github.com/repos/pypa/pip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/pip/downloads","issues_url":"https://api.github.com/repos/pypa/pip/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/pip/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/pip/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/pip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/pip/labels{/name}","releases_url":"https://api.github.com/repos/pypa/pip/releases{/id}","created_at":"2011-03-06T14:30:46Z","updated_at":"2015-09-28T08:11:15Z","pushed_at":"2015-09-28T14:52:59Z","git_url":"git://github.com/pypa/pip.git","ssh_url":"git@github.com:pypa/pip.git","clone_url":"https://github.com/pypa/pip.git","svn_url":"https://github.com/pypa/pip","homepage":"https://pip.pypa.io/","size":55081,"stargazers_count":2359,"watchers_count":2359,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":924,"mirror_url":null,"open_issues_count":633,"forks":924,"open_issues":633,"watchers":2359,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/pip/pulls/3047"},"html":{"href":"https://github.com/pypa/pip/pull/3047"},"issue":{"href":"https://api.github.com/repos/pypa/pip/issues/3047"},"comments":{"href":"https://api.github.com/repos/pypa/pip/issues/3047/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/pip/pulls/3047/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/pip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypa/pip/pulls/3047/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/pip/statuses/7f58c07a251bcf8e309f6caeefeed24cf136b785"}}}}