{"action":"created","issue":{"url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/32","labels_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/32/comments","events_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/32/events","html_url":"https://github.com/ampedandwired/html-webpack-plugin/pull/32","id":74436447,"number":32,"title":"Add support for favicon","user":{"login":"SimenB","id":1404810,"avatar_url":"https://avatars.githubusercontent.com/u/1404810?v=3","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-05-08T17:28:59Z","updated_at":"2015-05-12T21:29:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/pulls/32","html_url":"https://github.com/ampedandwired/html-webpack-plugin/pull/32","diff_url":"https://github.com/ampedandwired/html-webpack-plugin/pull/32.diff","patch_url":"https://github.com/ampedandwired/html-webpack-plugin/pull/32.patch"},"body":"Ref #28 \r\n\r\nThis is supposed to be a temporary solution until #10 is implemented.\r\n\r\nA file named `favicon.ico` has to be included manually in some `require`, which I suppose is bad, but until #10 is done, I don't see any way around it"},"comment":{"url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/comments/101427334","html_url":"https://github.com/ampedandwired/html-webpack-plugin/pull/32#issuecomment-101427334","issue_url":"https://api.github.com/repos/ampedandwired/html-webpack-plugin/issues/32","id":101427334,"user":{"login":"jantimon","id":4113649,"avatar_url":"https://avatars.githubusercontent.com/u/4113649?v=3","gravatar_id":"","url":"https://api.github.com/users/jantimon","html_url":"https://github.com/jantimon","followers_url":"https://api.github.com/users/jantimon/followers","following_url":"https://api.github.com/users/jantimon/following{/other_user}","gists_url":"https://api.github.com/users/jantimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jantimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jantimon/subscriptions","organizations_url":"https://api.github.com/users/jantimon/orgs","repos_url":"https://api.github.com/users/jantimon/repos","events_url":"https://api.github.com/users/jantimon/events{/privacy}","received_events_url":"https://api.github.com/users/jantimon/received_events","type":"User","site_admin":false},"created_at":"2015-05-12T21:29:18Z","updated_at":"2015-05-12T21:29:18Z","body":"Although I really like the idea with the extra files I am not sure wether this is just an edge case or a common use case. It is already possible to pass a custom templateContent function which has access to everything needed to use these files.\r\n\r\nYou are correct the base64 encoding is missing as it doesn't use the loaders.\r\nHowever I would really prefer not to load the favicon into the javascript.\r\nMaybe you could come up with a good solution for this issue?  \r\n\r\nThe h5bp is referring only to the file name and is a solid starting point for creating web sites however imho there are still use cases where you would like to provide different icon versions depending on the size.\r\n\r\nI rebase this pr into #37 for the new 1.4.0 release but I would like to get the feedback of @ampedandwired before merging. "}}