{"action":"closed","number":183,"pull_request":{"url":"https://api.github.com/repos/get-iplayer/get_iplayer/pulls/183","id":41965639,"html_url":"https://github.com/get-iplayer/get_iplayer/pull/183","diff_url":"https://github.com/get-iplayer/get_iplayer/pull/183.diff","patch_url":"https://github.com/get-iplayer/get_iplayer/pull/183.patch","issue_url":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/183","number":183,"state":"closed","locked":true,"title":"Restore --aactomp3 compatibility with --liveradiomode=shoutcastaac","user":{"login":"Vangelis66","id":9669492,"avatar_url":"https://avatars.githubusercontent.com/u/9669492?v=3","gravatar_id":"","url":"https://api.github.com/users/Vangelis66","html_url":"https://github.com/Vangelis66","followers_url":"https://api.github.com/users/Vangelis66/followers","following_url":"https://api.github.com/users/Vangelis66/following{/other_user}","gists_url":"https://api.github.com/users/Vangelis66/gists{/gist_id}","starred_url":"https://api.github.com/users/Vangelis66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vangelis66/subscriptions","organizations_url":"https://api.github.com/users/Vangelis66/orgs","repos_url":"https://api.github.com/users/Vangelis66/repos","events_url":"https://api.github.com/users/Vangelis66/events{/privacy}","received_events_url":"https://api.github.com/users/Vangelis66/received_events","type":"User","site_admin":false},"body":" I believe currently only BBC Radio 3 is being streamed (inside the UK only :-( ) \r\nin the shoutcastaachigh liveradiomode - If we are to believe the beeb and its \r\nAudio Factory department, these streams (2CDNs) are ill-fated and could possibly \r\nbe killed off after the Proms season reaches its end ...\r\n Audio purists may also argue that transcoding from AAC-LC@320kbps \r\nto LAME mp3@128kbps (the default with --mp3 switch) should be totally \r\nout of the question!\r\nHowever, there is already code inside GiP meant to do exactly that!\r\n This code now fails because at the transcoding step it instructs \r\nFFmpeg to place the mp3 encoded stream inside an MP4 container \r\nwith an .m4a file extension; FFmpeg rightly refuses to!\r\nProposed patch fixes this!\r\n","created_at":"2015-08-09T05:31:30Z","updated_at":"2015-11-11T11:26:13Z","closed_at":"2015-11-11T11:26:13Z","merged_at":null,"merge_commit_sha":"7bfd4ea878c9cdbe0849f91901ff1cd1c8031a6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/get-iplayer/get_iplayer/pulls/183/commits","review_comments_url":"https://api.github.com/repos/get-iplayer/get_iplayer/pulls/183/comments","review_comment_url":"https://api.github.com/repos/get-iplayer/get_iplayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/183/comments","statuses_url":"https://api.github.com/repos/get-iplayer/get_iplayer/statuses/af723c936c8d91e8d064482b53f342aedab5e886","head":{"label":"Vangelis66:develop","ref":"develop","sha":"af723c936c8d91e8d064482b53f342aedab5e886","user":{"login":"Vangelis66","id":9669492,"avatar_url":"https://avatars.githubusercontent.com/u/9669492?v=3","gravatar_id":"","url":"https://api.github.com/users/Vangelis66","html_url":"https://github.com/Vangelis66","followers_url":"https://api.github.com/users/Vangelis66/followers","following_url":"https://api.github.com/users/Vangelis66/following{/other_user}","gists_url":"https://api.github.com/users/Vangelis66/gists{/gist_id}","starred_url":"https://api.github.com/users/Vangelis66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vangelis66/subscriptions","organizations_url":"https://api.github.com/users/Vangelis66/orgs","repos_url":"https://api.github.com/users/Vangelis66/repos","events_url":"https://api.github.com/users/Vangelis66/events{/privacy}","received_events_url":"https://api.github.com/users/Vangelis66/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"get-iplayer:develop","ref":"develop","sha":"3931d9cb199f97c2c90ca7da60fa63d4fbb86ee8","user":{"login":"get-iplayer","id":9755374,"avatar_url":"https://avatars.githubusercontent.com/u/9755374?v=3","gravatar_id":"","url":"https://api.github.com/users/get-iplayer","html_url":"https://github.com/get-iplayer","followers_url":"https://api.github.com/users/get-iplayer/followers","following_url":"https://api.github.com/users/get-iplayer/following{/other_user}","gists_url":"https://api.github.com/users/get-iplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/get-iplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/get-iplayer/subscriptions","organizations_url":"https://api.github.com/users/get-iplayer/orgs","repos_url":"https://api.github.com/users/get-iplayer/repos","events_url":"https://api.github.com/users/get-iplayer/events{/privacy}","received_events_url":"https://api.github.com/users/get-iplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":1469734,"name":"get_iplayer","full_name":"get-iplayer/get_iplayer","owner":{"login":"get-iplayer","id":9755374,"avatar_url":"https://avatars.githubusercontent.com/u/9755374?v=3","gravatar_id":"","url":"https://api.github.com/users/get-iplayer","html_url":"https://github.com/get-iplayer","followers_url":"https://api.github.com/users/get-iplayer/followers","following_url":"https://api.github.com/users/get-iplayer/following{/other_user}","gists_url":"https://api.github.com/users/get-iplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/get-iplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/get-iplayer/subscriptions","organizations_url":"https://api.github.com/users/get-iplayer/orgs","repos_url":"https://api.github.com/users/get-iplayer/repos","events_url":"https://api.github.com/users/get-iplayer/events{/privacy}","received_events_url":"https://api.github.com/users/get-iplayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/get-iplayer/get_iplayer","description":"A utility for downloading TV and radio from BBC iPlayer","fork":false,"url":"https://api.github.com/repos/get-iplayer/get_iplayer","forks_url":"https://api.github.com/repos/get-iplayer/get_iplayer/forks","keys_url":"https://api.github.com/repos/get-iplayer/get_iplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/get-iplayer/get_iplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/get-iplayer/get_iplayer/teams","hooks_url":"https://api.github.com/repos/get-iplayer/get_iplayer/hooks","issue_events_url":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/events{/number}","events_url":"https://api.github.com/repos/get-iplayer/get_iplayer/events","assignees_url":"https://api.github.com/repos/get-iplayer/get_iplayer/assignees{/user}","branches_url":"https://api.github.com/repos/get-iplayer/get_iplayer/branches{/branch}","tags_url":"https://api.github.com/repos/get-iplayer/get_iplayer/tags","blobs_url":"https://api.github.com/repos/get-iplayer/get_iplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/get-iplayer/get_iplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/get-iplayer/get_iplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/get-iplayer/get_iplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/get-iplayer/get_iplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/get-iplayer/get_iplayer/languages","stargazers_url":"https://api.github.com/repos/get-iplayer/get_iplayer/stargazers","contributors_url":"https://api.github.com/repos/get-iplayer/get_iplayer/contributors","subscribers_url":"https://api.github.com/repos/get-iplayer/get_iplayer/subscribers","subscription_url":"https://api.github.com/repos/get-iplayer/get_iplayer/subscription","commits_url":"https://api.github.com/repos/get-iplayer/get_iplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/get-iplayer/get_iplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/get-iplayer/get_iplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/get-iplayer/get_iplayer/contents/{+path}","compare_url":"https://api.github.com/repos/get-iplayer/get_iplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/get-iplayer/get_iplayer/merges","archive_url":"https://api.github.com/repos/get-iplayer/get_iplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/get-iplayer/get_iplayer/downloads","issues_url":"https://api.github.com/repos/get-iplayer/get_iplayer/issues{/number}","pulls_url":"https://api.github.com/repos/get-iplayer/get_iplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/get-iplayer/get_iplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/get-iplayer/get_iplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/get-iplayer/get_iplayer/labels{/name}","releases_url":"https://api.github.com/repos/get-iplayer/get_iplayer/releases{/id}","created_at":"2011-03-11T21:26:04Z","updated_at":"2015-11-11T00:14:47Z","pushed_at":"2015-11-11T00:07:05Z","git_url":"git://github.com/get-iplayer/get_iplayer.git","ssh_url":"git@github.com:get-iplayer/get_iplayer.git","clone_url":"https://github.com/get-iplayer/get_iplayer.git","svn_url":"https://github.com/get-iplayer/get_iplayer","homepage":"https://github.com/get-iplayer/get_iplayer/wiki","size":7191,"stargazers_count":442,"watchers_count":442,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":12,"forks":60,"open_issues":12,"watchers":442,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/get-iplayer/get_iplayer/pulls/183"},"html":{"href":"https://github.com/get-iplayer/get_iplayer/pull/183"},"issue":{"href":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/183"},"comments":{"href":"https://api.github.com/repos/get-iplayer/get_iplayer/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/get-iplayer/get_iplayer/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/get-iplayer/get_iplayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/get-iplayer/get_iplayer/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/get-iplayer/get_iplayer/statuses/af723c936c8d91e8d064482b53f342aedab5e886"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":0,"deletions":0,"changed_files":0}}