{"action":"created","issue":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2243","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2243/labels{/name}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2243/comments","events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2243/events","html_url":"https://github.com/fish-shell/fish-shell/pull/2243","id":97293208,"number":2243,"title":"Fix bug in sorin.fish theme","user":{"login":"pickfire","id":4687791,"avatar_url":"https://avatars.githubusercontent.com/u/4687791?v=3","gravatar_id":"","url":"https://api.github.com/users/pickfire","html_url":"https://github.com/pickfire","followers_url":"https://api.github.com/users/pickfire/followers","following_url":"https://api.github.com/users/pickfire/following{/other_user}","gists_url":"https://api.github.com/users/pickfire/gists{/gist_id}","starred_url":"https://api.github.com/users/pickfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pickfire/subscriptions","organizations_url":"https://api.github.com/users/pickfire/orgs","repos_url":"https://api.github.com/users/pickfire/repos","events_url":"https://api.github.com/users/pickfire/events{/privacy}","received_events_url":"https://api.github.com/users/pickfire/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"faho","id":5185367,"avatar_url":"https://avatars.githubusercontent.com/u/5185367?v=3","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"milestone":null,"comments":13,"created_at":"2015-07-26T07:03:30Z","updated_at":"2015-08-16T20:52:54Z","closed_at":"2015-08-16T20:52:24Z","pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/2243","html_url":"https://github.com/fish-shell/fish-shell/pull/2243","diff_url":"https://github.com/fish-shell/fish-shell/pull/2243.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/2243.patch"},"body":"- Look for $TERM\r\n- Remove unknown line\r\n- Change email"},"comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments/131620727","html_url":"https://github.com/fish-shell/fish-shell/pull/2243#issuecomment-131620727","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2243","id":131620727,"user":{"login":"faho","id":5185367,"avatar_url":"https://avatars.githubusercontent.com/u/5185367?v=3","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"created_at":"2015-08-16T20:52:54Z","updated_at":"2015-08-16T20:52:54Z","body":"Okay, I tested it again (with a fixed \"$TERM\"), and here's the issue with your approach:\r\n\r\n- It actually defines \"fish_prompt\" based on the \"TERM\" value of the term that fish_config is started in\r\n\r\n- It defines it, and then re-defines it again with the non-fallback value, which will then be used (this means that it is not possible to get the fallback prompt, even if you start it with $TERM set to \"linux\")\r\n\r\n- It defines it once, which means if you switch between xterm/konsole/gnome-terminal or whatever and the kernel-vt-thing (TERM=\"linux\"), you'll get one prompt for both - either the ugly fallback, or the incorrectly displayed real prompt on the 8-color VT\r\n\r\nWhat I've done now is remove the fallback completely, since the fallback displays no info whatsoever while the real prompt will look wrong but still _work_ for the most part. This is also the only prompt with such a fallback.\r\n\r\nIf you want such a fallback, there's probably a better and more consistent way to do it."}}