{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/comments/33327026","id":33327026,"diff_hunk":"@@ -0,0 +1,58 @@\n+package labels\n+\n+import (\n+\t\"fmt\"\n+)\n+\n+const (\n+\t// SeparatorChar delimits concatenated labels.\n+\tSeparatorChar = '.'\n+\n+\tDNS952MaxLength  int = 24\n+\tDNS1123MaxLength int = 63\n+\n+\t// see http://www.rfc-base.org/txt/rfc-952.txt\n+\tHostNameSpecType952 HostNameSpecType = iota\n+\n+\t// see http://www.rfc-base.org/txt/rfc-1123.txt\n+\tHostNameSpecType1123","path":"records/labels/spec.go","position":18,"original_position":18,"commit_id":"4ee280b5c5495df6fcd079d54ad4f6516512c1be","original_commit_id":"4ee280b5c5495df6fcd079d54ad4f6516512c1be","user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"body":"Yep, probably. I'll keep the constants for length though - trying to avoid\nintroducing magic numbers not assigned to constants.\n\nOn Thu, Jun 25, 2015 at 10:14 PM, Tomás Senart <notifications@github.com>\nwrote:\n\n> In records/labels/spec.go\n> <https://github.com/mesosphere/mesos-dns/pull/177#discussion_r33324053>:\n>\n> > +import (\n> > +\t\"fmt\"\n> > +)\n> > +\n> > +const (\n> > +\t// SeparatorChar delimits concatenated labels.\n> > +\tSeparatorChar = '.'\n> > +\n> > +\tDNS952MaxLength  int = 24\n> > +\tDNS1123MaxLength int = 63\n> > +\n> > +\t// see http://www.rfc-base.org/txt/rfc-952.txt\n> > +\tHostNameSpecType952 HostNameSpecType = iota\n> > +\n> > +\t// see http://www.rfc-base.org/txt/rfc-1123.txt\n> > +\tHostNameSpecType1123\n>\n> I believe this can be further simplified. No need for HostNameSpecType.\n>\n> var (\n>     RFC952   = HostNameSpec{table:  makeDNS952Table(), maxlen: 24}\n>     RFC1123  = HostNameSpec{table:  makeDNS1123Table(), maxlen: 63}\n> )\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/mesosphere/mesos-dns/pull/177/files#r33324053>.\n>\n","created_at":"2015-06-26T03:52:01Z","updated_at":"2015-06-26T03:52:01Z","html_url":"https://github.com/mesosphere/mesos-dns/pull/177#discussion_r33327026","pull_request_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/177","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/comments/33327026"},"html":{"href":"https://github.com/mesosphere/mesos-dns/pull/177#discussion_r33327026"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/177"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/177","id":38172961,"html_url":"https://github.com/mesosphere/mesos-dns/pull/177","diff_url":"https://github.com/mesosphere/mesos-dns/pull/177.diff","patch_url":"https://github.com/mesosphere/mesos-dns/pull/177.patch","issue_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/177","number":177,"state":"open","locked":false,"title":"fixes #149: enforcement of rfc952 is optional, default is now rfc1123","user":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"body":"* added config option  `EnforceRFC952` for interop w/ systems that rely on rfc952 labels\r\n* default record generation spec (rfc1123) allows:\r\n  * longer labels (63 chars per segment)\r\n  * host records that start with digits\r\n","created_at":"2015-06-20T19:28:44Z","updated_at":"2015-06-26T03:52:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1923885612ce77c204f6b0c00614c3cc469def7","assignee":{"login":"tsenart","id":67471,"avatar_url":"https://avatars.githubusercontent.com/u/67471?v=3","gravatar_id":"","url":"https://api.github.com/users/tsenart","html_url":"https://github.com/tsenart","followers_url":"https://api.github.com/users/tsenart/followers","following_url":"https://api.github.com/users/tsenart/following{/other_user}","gists_url":"https://api.github.com/users/tsenart/gists{/gist_id}","starred_url":"https://api.github.com/users/tsenart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsenart/subscriptions","organizations_url":"https://api.github.com/users/tsenart/orgs","repos_url":"https://api.github.com/users/tsenart/repos","events_url":"https://api.github.com/users/tsenart/events{/privacy}","received_events_url":"https://api.github.com/users/tsenart/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/177/commits","review_comments_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/177/comments","review_comment_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/177/comments","statuses_url":"https://api.github.com/repos/mesosphere/mesos-dns/statuses/4ee280b5c5495df6fcd079d54ad4f6516512c1be","head":{"label":"mesosphere:fix_149","ref":"fix_149","sha":"4ee280b5c5495df6fcd079d54ad4f6516512c1be","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":26509179,"name":"mesos-dns","full_name":"mesosphere/mesos-dns","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/mesos-dns","description":" DNS-based service discovery for Mesos.","fork":false,"url":"https://api.github.com/repos/mesosphere/mesos-dns","forks_url":"https://api.github.com/repos/mesosphere/mesos-dns/forks","keys_url":"https://api.github.com/repos/mesosphere/mesos-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/mesos-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/mesos-dns/teams","hooks_url":"https://api.github.com/repos/mesosphere/mesos-dns/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/mesos-dns/events","assignees_url":"https://api.github.com/repos/mesosphere/mesos-dns/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/mesos-dns/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/mesos-dns/tags","blobs_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/mesos-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/mesos-dns/languages","stargazers_url":"https://api.github.com/repos/mesosphere/mesos-dns/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/mesos-dns/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/mesos-dns/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/mesos-dns/subscription","commits_url":"https://api.github.com/repos/mesosphere/mesos-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/mesos-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/mesos-dns/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/mesos-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/mesos-dns/merges","archive_url":"https://api.github.com/repos/mesosphere/mesos-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/mesos-dns/downloads","issues_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/mesos-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/mesos-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/mesos-dns/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/mesos-dns/releases{/id}","created_at":"2014-11-11T23:06:33Z","updated_at":"2015-06-25T07:53:01Z","pushed_at":"2015-06-25T05:44:06Z","git_url":"git://github.com/mesosphere/mesos-dns.git","ssh_url":"git@github.com:mesosphere/mesos-dns.git","clone_url":"https://github.com/mesosphere/mesos-dns.git","svn_url":"https://github.com/mesosphere/mesos-dns","homepage":"https://mesosphere.github.com/mesos-dns","size":2316,"stargazers_count":198,"watchers_count":198,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":39,"forks":29,"open_issues":39,"watchers":198,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"72e41a6278de4dfa5a101bae4908923d0f51fec3","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":26509179,"name":"mesos-dns","full_name":"mesosphere/mesos-dns","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/mesos-dns","description":" DNS-based service discovery for Mesos.","fork":false,"url":"https://api.github.com/repos/mesosphere/mesos-dns","forks_url":"https://api.github.com/repos/mesosphere/mesos-dns/forks","keys_url":"https://api.github.com/repos/mesosphere/mesos-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/mesos-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/mesos-dns/teams","hooks_url":"https://api.github.com/repos/mesosphere/mesos-dns/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/mesos-dns/events","assignees_url":"https://api.github.com/repos/mesosphere/mesos-dns/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/mesos-dns/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/mesos-dns/tags","blobs_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/mesos-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/mesos-dns/languages","stargazers_url":"https://api.github.com/repos/mesosphere/mesos-dns/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/mesos-dns/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/mesos-dns/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/mesos-dns/subscription","commits_url":"https://api.github.com/repos/mesosphere/mesos-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/mesos-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/mesos-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/mesos-dns/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/mesos-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/mesos-dns/merges","archive_url":"https://api.github.com/repos/mesosphere/mesos-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/mesos-dns/downloads","issues_url":"https://api.github.com/repos/mesosphere/mesos-dns/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/mesos-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/mesos-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/mesos-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/mesos-dns/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/mesos-dns/releases{/id}","created_at":"2014-11-11T23:06:33Z","updated_at":"2015-06-25T07:53:01Z","pushed_at":"2015-06-25T05:44:06Z","git_url":"git://github.com/mesosphere/mesos-dns.git","ssh_url":"git@github.com:mesosphere/mesos-dns.git","clone_url":"https://github.com/mesosphere/mesos-dns.git","svn_url":"https://github.com/mesosphere/mesos-dns","homepage":"https://mesosphere.github.com/mesos-dns","size":2316,"stargazers_count":198,"watchers_count":198,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":39,"forks":29,"open_issues":39,"watchers":198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/177"},"html":{"href":"https://github.com/mesosphere/mesos-dns/pull/177"},"issue":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/issues/177"},"comments":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/mesos-dns/statuses/4ee280b5c5495df6fcd079d54ad4f6516512c1be"}}}}