{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/47941709","id":47941709,"diff_hunk":"@@ -345,7 +345,100 @@ public extension NSString {\n     /// - Experiment: This is a draft API currently under consideration for official import into Foundation\n     /// - Note: Since this API is under consideration it may be either removed or revised in the near future\n     public func completePathIntoString(inout outputName: NSString?, caseSensitive flag: Bool, inout matchesIntoArray outputArray: [NSString], filterTypes: [String]?) -> Int {","path":"Foundation/NSPathUtilities.swift","position":3,"original_position":3,"commit_id":"cd1ec9bf0b3ae6d2da0297c4d0e63a2e58112f29","original_commit_id":"cd1ec9bf0b3ae6d2da0297c4d0e63a2e58112f29","user":{"login":"phausler","id":278470,"avatar_url":"https://avatars.githubusercontent.com/u/278470?v=3","gravatar_id":"","url":"https://api.github.com/users/phausler","html_url":"https://github.com/phausler","followers_url":"https://api.github.com/users/phausler/followers","following_url":"https://api.github.com/users/phausler/following{/other_user}","gists_url":"https://api.github.com/users/phausler/gists{/gist_id}","starred_url":"https://api.github.com/users/phausler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phausler/subscriptions","organizations_url":"https://api.github.com/users/phausler/orgs","repos_url":"https://api.github.com/users/phausler/repos","events_url":"https://api.github.com/users/phausler/events{/privacy}","received_events_url":"https://api.github.com/users/phausler/received_events","type":"User","site_admin":false},"body":"so this method should handle a few cases: what if it starts with a \"~\"? consider both the case of \"~/\" and \"~\"\r\nalso isn't there a fast path case? where the input is \"\"\r\n","created_at":"2015-12-17T18:28:26Z","updated_at":"2015-12-17T18:28:26Z","html_url":"https://github.com/apple/swift-corelibs-foundation/pull/156#discussion_r47941709","pull_request_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/156","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments/47941709"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/156#discussion_r47941709"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/156","id":54007581,"html_url":"https://github.com/apple/swift-corelibs-foundation/pull/156","diff_url":"https://github.com/apple/swift-corelibs-foundation/pull/156.diff","patch_url":"https://github.com/apple/swift-corelibs-foundation/pull/156.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/156","number":156,"state":"open","locked":false,"title":"Implement NSString.completePathIntoString.","user":{"login":"HeMet","id":1213598,"avatar_url":"https://avatars.githubusercontent.com/u/1213598?v=3","gravatar_id":"","url":"https://api.github.com/users/HeMet","html_url":"https://github.com/HeMet","followers_url":"https://api.github.com/users/HeMet/followers","following_url":"https://api.github.com/users/HeMet/following{/other_user}","gists_url":"https://api.github.com/users/HeMet/gists{/gist_id}","starred_url":"https://api.github.com/users/HeMet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeMet/subscriptions","organizations_url":"https://api.github.com/users/HeMet/orgs","repos_url":"https://api.github.com/users/HeMet/repos","events_url":"https://api.github.com/users/HeMet/events{/privacy}","received_events_url":"https://api.github.com/users/HeMet/received_events","type":"User","site_admin":false},"body":"Implement NSString.completePathIntoString. Tests included.","created_at":"2015-12-17T17:39:28Z","updated_at":"2015-12-17T18:28:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"226806fa5b5640d61e011b5bb31bb2ab784ca6e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/156/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/156/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/156/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/cd1ec9bf0b3ae6d2da0297c4d0e63a2e58112f29","head":{"label":"HeMet:completePathIntoStrings","ref":"completePathIntoStrings","sha":"cd1ec9bf0b3ae6d2da0297c4d0e63a2e58112f29","user":{"login":"HeMet","id":1213598,"avatar_url":"https://avatars.githubusercontent.com/u/1213598?v=3","gravatar_id":"","url":"https://api.github.com/users/HeMet","html_url":"https://github.com/HeMet","followers_url":"https://api.github.com/users/HeMet/followers","following_url":"https://api.github.com/users/HeMet/following{/other_user}","gists_url":"https://api.github.com/users/HeMet/gists{/gist_id}","starred_url":"https://api.github.com/users/HeMet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeMet/subscriptions","organizations_url":"https://api.github.com/users/HeMet/orgs","repos_url":"https://api.github.com/users/HeMet/repos","events_url":"https://api.github.com/users/HeMet/events{/privacy}","received_events_url":"https://api.github.com/users/HeMet/received_events","type":"User","site_admin":false},"repo":{"id":47709504,"name":"swift-corelibs-foundation","full_name":"HeMet/swift-corelibs-foundation","owner":{"login":"HeMet","id":1213598,"avatar_url":"https://avatars.githubusercontent.com/u/1213598?v=3","gravatar_id":"","url":"https://api.github.com/users/HeMet","html_url":"https://github.com/HeMet","followers_url":"https://api.github.com/users/HeMet/followers","following_url":"https://api.github.com/users/HeMet/following{/other_user}","gists_url":"https://api.github.com/users/HeMet/gists{/gist_id}","starred_url":"https://api.github.com/users/HeMet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeMet/subscriptions","organizations_url":"https://api.github.com/users/HeMet/orgs","repos_url":"https://api.github.com/users/HeMet/repos","events_url":"https://api.github.com/users/HeMet/events{/privacy}","received_events_url":"https://api.github.com/users/HeMet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HeMet/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":true,"url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/HeMet/swift-corelibs-foundation/releases{/id}","created_at":"2015-12-09T18:06:12Z","updated_at":"2015-12-09T18:06:15Z","pushed_at":"2015-12-17T17:36:13Z","git_url":"git://github.com/HeMet/swift-corelibs-foundation.git","ssh_url":"git@github.com:HeMet/swift-corelibs-foundation.git","clone_url":"https://github.com/HeMet/swift-corelibs-foundation.git","svn_url":"https://github.com/HeMet/swift-corelibs-foundation","homepage":"swift.org","size":2955,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"32cc07090b635868d85639320cc3a92f8b42e883","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863890,"name":"swift-corelibs-foundation","full_name":"apple/swift-corelibs-foundation","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-corelibs-foundation","description":"The Foundation Project, providing core utilities, internationalization, and OS independence","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-foundation","forks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-foundation/releases{/id}","created_at":"2015-11-09T20:12:23Z","updated_at":"2015-12-17T17:07:21Z","pushed_at":"2015-12-17T17:39:28Z","git_url":"git://github.com/apple/swift-corelibs-foundation.git","ssh_url":"git@github.com:apple/swift-corelibs-foundation.git","clone_url":"https://github.com/apple/swift-corelibs-foundation.git","svn_url":"https://github.com/apple/swift-corelibs-foundation","homepage":"swift.org","size":3141,"stargazers_count":1415,"watchers_count":1415,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":242,"mirror_url":null,"open_issues_count":20,"forks":242,"open_issues":20,"watchers":1415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/156"},"html":{"href":"https://github.com/apple/swift-corelibs-foundation/pull/156"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/156"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-foundation/statuses/cd1ec9bf0b3ae6d2da0297c4d0e63a2e58112f29"}}}}