{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/andrewlow/node/pulls/40","id":35100315,"html_url":"https://github.com/andrewlow/node/pull/40","diff_url":"https://github.com/andrewlow/node/pull/40.diff","patch_url":"https://github.com/andrewlow/node/pull/40.patch","issue_url":"https://api.github.com/repos/andrewlow/node/issues/40","number":40,"state":"closed","locked":false,"title":"Update configure","user":{"login":"shahidhs","id":11160001,"avatar_url":"https://avatars.githubusercontent.com/u/11160001?v=3","gravatar_id":"","url":"https://api.github.com/users/shahidhs","html_url":"https://github.com/shahidhs","followers_url":"https://api.github.com/users/shahidhs/followers","following_url":"https://api.github.com/users/shahidhs/following{/other_user}","gists_url":"https://api.github.com/users/shahidhs/gists{/gist_id}","starred_url":"https://api.github.com/users/shahidhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahidhs/subscriptions","organizations_url":"https://api.github.com/users/shahidhs/orgs","repos_url":"https://api.github.com/users/shahidhs/repos","events_url":"https://api.github.com/users/shahidhs/events{/privacy}","received_events_url":"https://api.github.com/users/shahidhs/received_events","type":"User","site_admin":false},"body":"After running './configure' on s390x architecture VM, I was getting following output:\r\n\r\nbash-4.3# uname -rvmpio\r\n3.10.0-229.1.2.el7.s390x #1 SMP Fri Mar 6 17:14:40 EST 2015 s390x s390x s390x GNU/Linux\r\n\r\nbash-4.3# ./configure\r\n{ 'target_defaults': { 'cflags': [],\r\n                       'default_configuration': 'Release',\r\n                       'defines': [],\r\n                       'include_dirs': [],\r\n                       'libraries': []},\r\n  'variables': { 'clang': 0,\r\n                 'gcc_version': 49,\r\n                 'host_arch': 's390',\r\n                 'node_byteorder': 'big',\r\n                 'node_install_npm': 'true',\r\n                 'node_prefix': '',\r\n                 'node_shared_cares': 'false',\r\n                 'node_shared_http_parser': 'false',\r\n                 'node_shared_libuv': 'false',\r\n                 'node_shared_openssl': 'false',\r\n                 'node_shared_v8': 'false',\r\n                 'node_shared_zlib': 'false',\r\n                 'node_tag': '',\r\n                 'node_unsafe_optimizations': 0,\r\n                 'node_use_dtrace': 'false',\r\n                 'node_use_etw': 'false',\r\n                 'node_use_openssl': 'true',\r\n                 'node_use_perfctr': 'false',\r\n                 'node_use_systemtap': 'false',\r\n                 'openssl_no_asm': 0,\r\n                 'python': '/usr/bin/python',\r\n                 'target_arch': 's390',\r\n                 'v8_enable_gdbjit': 0,\r\n                 'v8_no_strict_aliasing': 1,\r\n                 'v8_use_snapshot': 'true',\r\n                 'want_separate_host_toolset': 0}}\r\ncreating  ./config.gypi\r\ncreating  ./config.mk\r\nbash-4.3#\r\n\r\n\r\nAs we could see, the configure script has returned me incorrect architecture i.e. 's390' instead of 's390x'. I got this behavior for Fedora21, RHEL7, SLES12 and MCP8 OS. This causes 'make' fail as it tries to build for 's390' instead on 's390x'.\r\n\r\nI am proposing the mentioned changes for fixing the issue.\r\n\r\nBelow is the output when I run the updated './configure' script:\r\n\r\nbash-4.3# ./configure\r\n{ 'target_defaults': { 'cflags': [],\r\n                       'default_configuration': 'Release',\r\n                       'defines': [],\r\n                       'include_dirs': [],\r\n                       'libraries': []},\r\n  'variables': { 'clang': 0,\r\n                 'gcc_version': 49,\r\n                 'host_arch': 's390x',\r\n                 'node_byteorder': 'big',\r\n                 'node_install_npm': 'true',\r\n                 'node_prefix': '',\r\n                 'node_shared_cares': 'false',\r\n                 'node_shared_http_parser': 'false',\r\n                 'node_shared_libuv': 'false',\r\n                 'node_shared_openssl': 'false',\r\n                 'node_shared_v8': 'false',\r\n                 'node_shared_zlib': 'false',\r\n                 'node_tag': '',\r\n                 'node_unsafe_optimizations': 0,\r\n                 'node_use_dtrace': 'false',\r\n                 'node_use_etw': 'false',\r\n                 'node_use_openssl': 'true',\r\n                 'node_use_perfctr': 'false',\r\n                 'node_use_systemtap': 'false',\r\n                 'openssl_no_asm': 0,\r\n                 'python': '/usr/bin/python',\r\n                 'target_arch': 's390x',\r\n                 'v8_enable_gdbjit': 0,\r\n                 'v8_no_strict_aliasing': 1,\r\n                 'v8_use_snapshot': 'true',\r\n                 'want_separate_host_toolset': 0}}\r\ncreating  ./config.gypi\r\ncreating  ./config.mk\r\nbash-4.3#\r\n\r\nNow it correctly identifies the host architecture for s390x.\r\n\r\nThanks.","created_at":"2015-05-11T06:17:57Z","updated_at":"2015-06-19T18:23:57Z","closed_at":"2015-06-19T18:23:57Z","merged_at":"2015-06-19T18:23:57Z","merge_commit_sha":"9708f59ce087e4d8ba65526da3777cf9fde32281","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/andrewlow/node/pulls/40/commits","review_comments_url":"https://api.github.com/repos/andrewlow/node/pulls/40/comments","review_comment_url":"https://api.github.com/repos/andrewlow/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andrewlow/node/issues/40/comments","statuses_url":"https://api.github.com/repos/andrewlow/node/statuses/f56c6b5bb6df68b52c85d1712fbdb05e70406f74","head":{"label":"shahidhs:patch-1","ref":"patch-1","sha":"f56c6b5bb6df68b52c85d1712fbdb05e70406f74","user":{"login":"shahidhs","id":11160001,"avatar_url":"https://avatars.githubusercontent.com/u/11160001?v=3","gravatar_id":"","url":"https://api.github.com/users/shahidhs","html_url":"https://github.com/shahidhs","followers_url":"https://api.github.com/users/shahidhs/followers","following_url":"https://api.github.com/users/shahidhs/following{/other_user}","gists_url":"https://api.github.com/users/shahidhs/gists{/gist_id}","starred_url":"https://api.github.com/users/shahidhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahidhs/subscriptions","organizations_url":"https://api.github.com/users/shahidhs/orgs","repos_url":"https://api.github.com/users/shahidhs/repos","events_url":"https://api.github.com/users/shahidhs/events{/privacy}","received_events_url":"https://api.github.com/users/shahidhs/received_events","type":"User","site_admin":false},"repo":{"id":35281705,"name":"node","full_name":"shahidhs/node","owner":{"login":"shahidhs","id":11160001,"avatar_url":"https://avatars.githubusercontent.com/u/11160001?v=3","gravatar_id":"","url":"https://api.github.com/users/shahidhs","html_url":"https://github.com/shahidhs","followers_url":"https://api.github.com/users/shahidhs/followers","following_url":"https://api.github.com/users/shahidhs/following{/other_user}","gists_url":"https://api.github.com/users/shahidhs/gists{/gist_id}","starred_url":"https://api.github.com/users/shahidhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahidhs/subscriptions","organizations_url":"https://api.github.com/users/shahidhs/orgs","repos_url":"https://api.github.com/users/shahidhs/repos","events_url":"https://api.github.com/users/shahidhs/events{/privacy}","received_events_url":"https://api.github.com/users/shahidhs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shahidhs/node","description":"evented I/O for v8 javascript","fork":true,"url":"https://api.github.com/repos/shahidhs/node","forks_url":"https://api.github.com/repos/shahidhs/node/forks","keys_url":"https://api.github.com/repos/shahidhs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shahidhs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shahidhs/node/teams","hooks_url":"https://api.github.com/repos/shahidhs/node/hooks","issue_events_url":"https://api.github.com/repos/shahidhs/node/issues/events{/number}","events_url":"https://api.github.com/repos/shahidhs/node/events","assignees_url":"https://api.github.com/repos/shahidhs/node/assignees{/user}","branches_url":"https://api.github.com/repos/shahidhs/node/branches{/branch}","tags_url":"https://api.github.com/repos/shahidhs/node/tags","blobs_url":"https://api.github.com/repos/shahidhs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shahidhs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shahidhs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/shahidhs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shahidhs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/shahidhs/node/languages","stargazers_url":"https://api.github.com/repos/shahidhs/node/stargazers","contributors_url":"https://api.github.com/repos/shahidhs/node/contributors","subscribers_url":"https://api.github.com/repos/shahidhs/node/subscribers","subscription_url":"https://api.github.com/repos/shahidhs/node/subscription","commits_url":"https://api.github.com/repos/shahidhs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/shahidhs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/shahidhs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/shahidhs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/shahidhs/node/contents/{+path}","compare_url":"https://api.github.com/repos/shahidhs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shahidhs/node/merges","archive_url":"https://api.github.com/repos/shahidhs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shahidhs/node/downloads","issues_url":"https://api.github.com/repos/shahidhs/node/issues{/number}","pulls_url":"https://api.github.com/repos/shahidhs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/shahidhs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/shahidhs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shahidhs/node/labels{/name}","releases_url":"https://api.github.com/repos/shahidhs/node/releases{/id}","created_at":"2015-05-08T13:46:14Z","updated_at":"2015-05-08T13:46:34Z","pushed_at":"2015-06-11T06:32:48Z","git_url":"git://github.com/shahidhs/node.git","ssh_url":"git@github.com:shahidhs/node.git","clone_url":"https://github.com/shahidhs/node.git","svn_url":"https://github.com/shahidhs/node","homepage":"http://nodejs.org/","size":133310,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v0.10.38-release-ppc"}},"base":{"label":"andrewlow:v0.10.38-release-ppc","ref":"v0.10.38-release-ppc","sha":"809d99df9c4e6791d783614760db6eb02b4def29","user":{"login":"andrewlow","id":2952475,"avatar_url":"https://avatars.githubusercontent.com/u/2952475?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewlow","html_url":"https://github.com/andrewlow","followers_url":"https://api.github.com/users/andrewlow/followers","following_url":"https://api.github.com/users/andrewlow/following{/other_user}","gists_url":"https://api.github.com/users/andrewlow/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewlow/subscriptions","organizations_url":"https://api.github.com/users/andrewlow/orgs","repos_url":"https://api.github.com/users/andrewlow/repos","events_url":"https://api.github.com/users/andrewlow/events{/privacy}","received_events_url":"https://api.github.com/users/andrewlow/received_events","type":"User","site_admin":false},"repo":{"id":12243435,"name":"node","full_name":"andrewlow/node","owner":{"login":"andrewlow","id":2952475,"avatar_url":"https://avatars.githubusercontent.com/u/2952475?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewlow","html_url":"https://github.com/andrewlow","followers_url":"https://api.github.com/users/andrewlow/followers","following_url":"https://api.github.com/users/andrewlow/following{/other_user}","gists_url":"https://api.github.com/users/andrewlow/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewlow/subscriptions","organizations_url":"https://api.github.com/users/andrewlow/orgs","repos_url":"https://api.github.com/users/andrewlow/repos","events_url":"https://api.github.com/users/andrewlow/events{/privacy}","received_events_url":"https://api.github.com/users/andrewlow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewlow/node","description":"evented I/O for v8 javascript","fork":true,"url":"https://api.github.com/repos/andrewlow/node","forks_url":"https://api.github.com/repos/andrewlow/node/forks","keys_url":"https://api.github.com/repos/andrewlow/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewlow/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewlow/node/teams","hooks_url":"https://api.github.com/repos/andrewlow/node/hooks","issue_events_url":"https://api.github.com/repos/andrewlow/node/issues/events{/number}","events_url":"https://api.github.com/repos/andrewlow/node/events","assignees_url":"https://api.github.com/repos/andrewlow/node/assignees{/user}","branches_url":"https://api.github.com/repos/andrewlow/node/branches{/branch}","tags_url":"https://api.github.com/repos/andrewlow/node/tags","blobs_url":"https://api.github.com/repos/andrewlow/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewlow/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewlow/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewlow/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewlow/node/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewlow/node/languages","stargazers_url":"https://api.github.com/repos/andrewlow/node/stargazers","contributors_url":"https://api.github.com/repos/andrewlow/node/contributors","subscribers_url":"https://api.github.com/repos/andrewlow/node/subscribers","subscription_url":"https://api.github.com/repos/andrewlow/node/subscription","commits_url":"https://api.github.com/repos/andrewlow/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewlow/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewlow/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewlow/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewlow/node/contents/{+path}","compare_url":"https://api.github.com/repos/andrewlow/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewlow/node/merges","archive_url":"https://api.github.com/repos/andrewlow/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewlow/node/downloads","issues_url":"https://api.github.com/repos/andrewlow/node/issues{/number}","pulls_url":"https://api.github.com/repos/andrewlow/node/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewlow/node/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewlow/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewlow/node/labels{/name}","releases_url":"https://api.github.com/repos/andrewlow/node/releases{/id}","created_at":"2013-08-20T13:13:32Z","updated_at":"2015-06-18T15:18:17Z","pushed_at":"2015-06-19T18:23:57Z","git_url":"git://github.com/andrewlow/node.git","ssh_url":"git@github.com:andrewlow/node.git","clone_url":"https://github.com/andrewlow/node.git","svn_url":"https://github.com/andrewlow/node","homepage":"http://nodejs.org/","size":312029,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":39,"default_branch":"v0.10.38-release-ppc"}},"_links":{"self":{"href":"https://api.github.com/repos/andrewlow/node/pulls/40"},"html":{"href":"https://github.com/andrewlow/node/pull/40"},"issue":{"href":"https://api.github.com/repos/andrewlow/node/issues/40"},"comments":{"href":"https://api.github.com/repos/andrewlow/node/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/andrewlow/node/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/andrewlow/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andrewlow/node/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/andrewlow/node/statuses/f56c6b5bb6df68b52c85d1712fbdb05e70406f74"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"joransiu","id":6609554,"avatar_url":"https://avatars.githubusercontent.com/u/6609554?v=3","gravatar_id":"","url":"https://api.github.com/users/joransiu","html_url":"https://github.com/joransiu","followers_url":"https://api.github.com/users/joransiu/followers","following_url":"https://api.github.com/users/joransiu/following{/other_user}","gists_url":"https://api.github.com/users/joransiu/gists{/gist_id}","starred_url":"https://api.github.com/users/joransiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joransiu/subscriptions","organizations_url":"https://api.github.com/users/joransiu/orgs","repos_url":"https://api.github.com/users/joransiu/repos","events_url":"https://api.github.com/users/joransiu/events{/privacy}","received_events_url":"https://api.github.com/users/joransiu/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":2,"additions":4,"deletions":1,"changed_files":1}}