{"action":"created","issue":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3216","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3216/labels{/name}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3216/comments","events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3216/events","html_url":"https://github.com/zfsonlinux/zfs/pull/3216","id":63841667,"number":3216,"title":"[buildbot, proof-of-concept (*2)/testing, #2129 + new (tracepoint multilist) #3115], <feedback, comments> ","user":{"login":"kernelOfTruth","id":4529709,"avatar_url":"https://avatars.githubusercontent.com/u/4529709?v=3","gravatar_id":"","url":"https://api.github.com/users/kernelOfTruth","html_url":"https://github.com/kernelOfTruth","followers_url":"https://api.github.com/users/kernelOfTruth/followers","following_url":"https://api.github.com/users/kernelOfTruth/following{/other_user}","gists_url":"https://api.github.com/users/kernelOfTruth/gists{/gist_id}","starred_url":"https://api.github.com/users/kernelOfTruth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernelOfTruth/subscriptions","organizations_url":"https://api.github.com/users/kernelOfTruth/orgs","repos_url":"https://api.github.com/users/kernelOfTruth/repos","events_url":"https://api.github.com/users/kernelOfTruth/events{/privacy}","received_events_url":"https://api.github.com/users/kernelOfTruth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2015-03-23T21:51:10Z","updated_at":"2015-05-22T00:13:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3216","html_url":"https://github.com/zfsonlinux/zfs/pull/3216","diff_url":"https://github.com/zfsonlinux/zfs/pull/3216.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/3216.patch"},"body":"The goal of this pull-request compared to ( #3189 , #3190 - working tests, so not doing too much changes to them)\r\n\r\nis to get an up-to-date base (zfs master from March 20th, latest),\r\n\r\nand clean, logical-split up commits to make any problems in this combination/porting as easily and clearly visible right from the start to prevent any long-standing issues or regressions introduced from this\r\n\r\nOverview/contents:\r\n1) zfs master\r\n\r\n2) ABD: linear/scatter dual typed buffer for ARC, ABD: https://github.com/kernelOfTruth/zfs/tree/tuxoko_zfs/abd_17.02.2015 (current state)\r\n\r\n3) Illumos - 5497 lock contention, Illumos - 5408 cache devices requiring lots of RAM, Illumos 5369 - arc flags enum and some additional minor changes: https://github.com/kernelOfTruth/zfs/tree/dweeezil_zfs/lock-contention-on-arcs_mtx_23.03.2015 (current state, just updated)\r\n\r\n\r\nI'm pushing  this early to get the buildbots running and to get an early insight if fixes or changes work\r\n\r\nedit:\r\n\r\npersonal porting notes in HTML, exported from tomboy:\r\n\r\nhttp://pastebin.com/A1sMCGXG\r\n\r\n\r\nThe difference in this approach from #3189 and #3190 was that\r\n\r\nRevert \"Allow arc_evict_ghost() to only evict meta data\"\r\nhttps://github.com/dweeezil/zfs/commit/730d690da8774ff7539521c65facf68d0aa881be\r\n\r\nwas omitted\r\n\r\nand that \"Fix arc_adjust_meta() behavior\"\r\nhttps://github.com/zfsonlinux/zfs/commit/bc88866657979c5658441e201e19df365c67ddfe\r\n\r\nthus the reverts of both practically where done in commit \"5497 lock contention on arcs_mtx\" https://github.com/kernelOfTruth/zfs/commit/21308417f78bc2ef02e9175add89893166e5eba4\r\n\r\n\r\nPreviously I had assumed that there would be *_at least some changes_* that would survive in the new code - but was wrong - like pointed out in https://github.com/zfsonlinux/zfs/pull/3115#issuecomment-87105207 .\r\n\r\nObviously: longer observation beforehand == less work later, less clutter\r\n\r\nthis made porting more difficult but still realizable.\r\n\r\n\r\nThe pull-requests are done on a per-commit basis which should give a better overview instead of a huge cumulative single \"blob\"\r\n\r\n\r\nNot sure how \"mergeable\" the code is - the single commits should be logical, working units by themselves, like pointed out by @behlendorf \r\n\r\nEach commit has some details in merge conflicts (due to #2119 and/or #3115 ) added\r\n\r\n\r\n\r\nThere's still the warning from #3115 , https://github.com/dweeezil/zfs/commit/716828565483fdec0eb5dcdd0cb9bc91483f4fdd\r\n\r\n```\r\nmultilist.c:31:1: warning: ‘multilist_d2l’ defined but not used [-Wunused-function]\r\n multilist_d2l(multilist_t *ml, void *obj)\r\n```\r\n\r\n\r\nThe buildbot issues with undefined PAGE_SHIFT have been dealt with in https://github.com/kernelOfTruth/zfs/commit/e19172fd519a55d4784e1e7cf64b4adef25f4cfa , will have to test it in the other proof-of-concept (*1) to see if that gets the green lights for the other failing buildbots\r\n\r\n\r\nNot sure why here some commits are still \"queued for automatic testing\" despite long time having passed\r\n\r\n\r\n*edit*:\r\n\r\nquick link to the tree: https://github.com/kernelOfTruth/zfs/commits/zfs_master_20.03.2015_2129+3115_WIP_clean"},"comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments/104455142","html_url":"https://github.com/zfsonlinux/zfs/pull/3216#issuecomment-104455142","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3216","id":104455142,"user":{"login":"kernelOfTruth","id":4529709,"avatar_url":"https://avatars.githubusercontent.com/u/4529709?v=3","gravatar_id":"","url":"https://api.github.com/users/kernelOfTruth","html_url":"https://github.com/kernelOfTruth","followers_url":"https://api.github.com/users/kernelOfTruth/followers","following_url":"https://api.github.com/users/kernelOfTruth/following{/other_user}","gists_url":"https://api.github.com/users/kernelOfTruth/gists{/gist_id}","starred_url":"https://api.github.com/users/kernelOfTruth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernelOfTruth/subscriptions","organizations_url":"https://api.github.com/users/kernelOfTruth/orgs","repos_url":"https://api.github.com/users/kernelOfTruth/repos","events_url":"https://api.github.com/users/kernelOfTruth/events{/privacy}","received_events_url":"https://api.github.com/users/kernelOfTruth/received_events","type":"User","site_admin":false},"created_at":"2015-05-22T00:13:57Z","updated_at":"2015-05-22T00:13:57Z","body":"Now contains the patch from https://github.com/zfsonlinux/zfs/pull/3433 l2arc-write-target-size.diff"}}