{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7181","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7181/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7181/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7181/events","html_url":"https://github.com/bitcoin/bitcoin/pull/7181","id":120798622,"number":7181,"title":"net: Add and document network messages in protocol.h","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Docs%20and%20Output","name":"Docs and Output","color":"02d7e1"},{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/P2P","name":"P2P","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-12-07T15:30:36Z","updated_at":"2015-12-09T01:20:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7181","html_url":"https://github.com/bitcoin/bitcoin/pull/7181","diff_url":"https://github.com/bitcoin/bitcoin/pull/7181.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/7181.patch"},"body":"- Avoids string typos (by making the compiler check).\r\n- Makes it easier to grep for handling/generation of a certain message type.\r\n- Refer directly to documentation by following the symbol in IDE or doxygen.\r\n- Make sure we have an overview of all handled/emitted messages, for functionality like #6589.\r\n\r\n@harding I've used your descriptions of the message types, hope you don't mind :)\r\n\r\n~~Edit: sendheaders is not yet documented in the developer docs, this is tracked here: https://github.com/bitcoin-dot-org/bitcoin.org/issues/1153~~"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/163076465","html_url":"https://github.com/bitcoin/bitcoin/pull/7181#issuecomment-163076465","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7181","id":163076465,"user":{"login":"jgarzik","id":494411,"avatar_url":"https://avatars.githubusercontent.com/u/494411?v=3","gravatar_id":"","url":"https://api.github.com/users/jgarzik","html_url":"https://github.com/jgarzik","followers_url":"https://api.github.com/users/jgarzik/followers","following_url":"https://api.github.com/users/jgarzik/following{/other_user}","gists_url":"https://api.github.com/users/jgarzik/gists{/gist_id}","starred_url":"https://api.github.com/users/jgarzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgarzik/subscriptions","organizations_url":"https://api.github.com/users/jgarzik/orgs","repos_url":"https://api.github.com/users/jgarzik/repos","events_url":"https://api.github.com/users/jgarzik/events{/privacy}","received_events_url":"https://api.github.com/users/jgarzik/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T01:20:56Z","updated_at":"2015-12-09T01:20:56Z","body":"@laanwj Yes - we should start using namespaces.  IMO first step is Bitcoin:: and second step is Net:: under that.\r\n"}}