{"action":"created","issue":{"url":"https://api.github.com/repos/square/Valet/issues/42","labels_url":"https://api.github.com/repos/square/Valet/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/square/Valet/issues/42/comments","events_url":"https://api.github.com/repos/square/Valet/issues/42/events","html_url":"https://github.com/square/Valet/pull/42","id":106646419,"number":42,"title":"Add framework targets for iOS and OS X","user":{"login":"eliperkins","id":1051453,"avatar_url":"https://avatars.githubusercontent.com/u/1051453?v=3","gravatar_id":"","url":"https://api.github.com/users/eliperkins","html_url":"https://github.com/eliperkins","followers_url":"https://api.github.com/users/eliperkins/followers","following_url":"https://api.github.com/users/eliperkins/following{/other_user}","gists_url":"https://api.github.com/users/eliperkins/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperkins/subscriptions","organizations_url":"https://api.github.com/users/eliperkins/orgs","repos_url":"https://api.github.com/users/eliperkins/repos","events_url":"https://api.github.com/users/eliperkins/events{/privacy}","received_events_url":"https://api.github.com/users/eliperkins/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/square/Valet/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-09-15T21:04:40Z","updated_at":"2015-09-16T21:20:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/square/Valet/pulls/42","html_url":"https://github.com/square/Valet/pull/42","diff_url":"https://github.com/square/Valet/pull/42.diff","patch_url":"https://github.com/square/Valet/pull/42.patch"},"body":"Closes #35 \r\n\r\nThis will allow the project to be used by Carthage and other dynamic framework tooling.\r\n\r\nBased loosely off of #37 from @EricMuller22, with a couple of changes. This adds two new targets for iOS and OS X that are both dynamic frameworks, compiling the source on their own, rather than including the static library into the dynamic framework.\r\n\r\nThis also scopes out the headers into their correct visibility, so we shouldn't ever get to see anything we shouldn't, like `mutableBaseQueryWithIdentifier:initializer:accessibility:` or any of it's friends.\r\n\r\nLastly, I renamed the framework files to be `Valet.framework` to better support universal frameworks."},"comment":{"url":"https://api.github.com/repos/square/Valet/issues/comments/140898179","html_url":"https://github.com/square/Valet/pull/42#issuecomment-140898179","issue_url":"https://api.github.com/repos/square/Valet/issues/42","id":140898179,"user":{"login":"dfed","id":139364,"avatar_url":"https://avatars.githubusercontent.com/u/139364?v=3","gravatar_id":"","url":"https://api.github.com/users/dfed","html_url":"https://github.com/dfed","followers_url":"https://api.github.com/users/dfed/followers","following_url":"https://api.github.com/users/dfed/following{/other_user}","gists_url":"https://api.github.com/users/dfed/gists{/gist_id}","starred_url":"https://api.github.com/users/dfed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfed/subscriptions","organizations_url":"https://api.github.com/users/dfed/orgs","repos_url":"https://api.github.com/users/dfed/repos","events_url":"https://api.github.com/users/dfed/events{/privacy}","received_events_url":"https://api.github.com/users/dfed/received_events","type":"User","site_admin":false},"created_at":"2015-09-16T21:20:00Z","updated_at":"2015-09-16T21:20:00Z","body":"@eliperkins want to just add the following to `.travis.yml`? If that builds, then we're good. It's def overkill, but Valet builds fast enough that I don't see an issue with some overkill.\r\n\r\n```\r\n    - xcodebuild -project Valet.xcodeproj -scheme \"Valet-iOS\" -sdk iphonesimulator -configuration Debug -PBXBuildsContinueAfterErrors=0 ACTIVE_ARCH_ONLY=0 build\r\n    - xcodebuild -project Valet.xcodeproj -scheme \"Valet-Mac\" -sdk iphonesimulator -configuration Debug -PBXBuildsContinueAfterErrors=0 ACTIVE_ARCH_ONLY=0 build\r\n```"}}