{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/25318","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/25318/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/25318/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/25318/events","html_url":"https://github.com/rust-lang/rust/pull/25318","id":75409022,"number":25318,"title":"Proper expansion info for for loops and other compiler expanded language items","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-05-12T00:44:50Z","updated_at":"2015-05-12T07:09:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/25318","html_url":"https://github.com/rust-lang/rust/pull/25318","diff_url":"https://github.com/rust-lang/rust/pull/25318.diff","patch_url":"https://github.com/rust-lang/rust/pull/25318.patch"},"body":"r? @sfackler "},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/101162279","html_url":"https://github.com/rust-lang/rust/pull/25318#issuecomment-101162279","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/25318","id":101162279,"user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"created_at":"2015-05-12T07:09:15Z","updated_at":"2015-05-12T07:09:15Z","body":"Because otherwise the spans are lies - we get a span for parts of the expansions of the for loop which are not what the span is for - i.e., a span for a type which is actually a value in the source. Furthermore, without expansion info you can't tell that the code has been expanded - a tool should assume that the expanded source is the same as the pre-expansion source, which it isn't."}}