{"action":"created","issue":{"url":"https://api.github.com/repos/brad-richards/AIGS/issues/7","labels_url":"https://api.github.com/repos/brad-richards/AIGS/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/brad-richards/AIGS/issues/7/comments","events_url":"https://api.github.com/repos/brad-richards/AIGS/issues/7/events","html_url":"https://github.com/brad-richards/AIGS/issues/7","id":69861248,"number":7,"title":"Erroneous handling of loading/waiting window in JavaFX (single player and autoConnect)","user":{"login":"rabanti-github","id":6697127,"avatar_url":"https://avatars.githubusercontent.com/u/6697127?v=3","gravatar_id":"","url":"https://api.github.com/users/rabanti-github","html_url":"https://github.com/rabanti-github","followers_url":"https://api.github.com/users/rabanti-github/followers","following_url":"https://api.github.com/users/rabanti-github/following{/other_user}","gists_url":"https://api.github.com/users/rabanti-github/gists{/gist_id}","starred_url":"https://api.github.com/users/rabanti-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabanti-github/subscriptions","organizations_url":"https://api.github.com/users/rabanti-github/orgs","repos_url":"https://api.github.com/users/rabanti-github/repos","events_url":"https://api.github.com/users/rabanti-github/events{/privacy}","received_events_url":"https://api.github.com/users/rabanti-github/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/brad-richards/AIGS/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"rabanti-github","id":6697127,"avatar_url":"https://avatars.githubusercontent.com/u/6697127?v=3","gravatar_id":"","url":"https://api.github.com/users/rabanti-github","html_url":"https://github.com/rabanti-github","followers_url":"https://api.github.com/users/rabanti-github/followers","following_url":"https://api.github.com/users/rabanti-github/following{/other_user}","gists_url":"https://api.github.com/users/rabanti-github/gists{/gist_id}","starred_url":"https://api.github.com/users/rabanti-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabanti-github/subscriptions","organizations_url":"https://api.github.com/users/rabanti-github/orgs","repos_url":"https://api.github.com/users/rabanti-github/repos","events_url":"https://api.github.com/users/rabanti-github/events{/privacy}","received_events_url":"https://api.github.com/users/rabanti-github/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-04-21T14:28:50Z","updated_at":"2015-04-23T11:14:22Z","closed_at":"2015-04-23T11:14:22Z","body":"The overlay handling of JavaFX games causes problems in single player games or autoConnect games.\r\nThe error is located in SetupWindow.java in AIGSBaseClient.\r\nCalling: `clientGame.getGameWindow().setOverlay(new LoadingWindow());` sets an instance of the loading screen (class LoadingWindow) on top of the client window. It seems that more than one instance of the loading screen is added. When fading out the loading screen, only the very top layer will be removed. If there is another loading screen layer beneath this, that second screen will be shown and not the game board.\r\n\r\nFirst:\r\nFix the multiple calling of LoadingWindow() in single player mode. Revise the init() method in SetupWindow.\r\n\r\nSecond:\r\nThe handling of overlay management must be fixed! Consider to tag the layers (possible in javaFX?). When fading out, remove ALL layers except layers with the tag \"BOARD\" (or so). Do not rely on the number of layers. If there is one loading screen, it will be removed; if ther is no loading screen (maybe single player), nothing will be removed; if there are more screens than the board and loading, everything except the board will be removed."},"comment":{"url":"https://api.github.com/repos/brad-richards/AIGS/issues/comments/95543309","html_url":"https://github.com/brad-richards/AIGS/issues/7#issuecomment-95543309","issue_url":"https://api.github.com/repos/brad-richards/AIGS/issues/7","id":95543309,"user":{"login":"rabanti-github","id":6697127,"avatar_url":"https://avatars.githubusercontent.com/u/6697127?v=3","gravatar_id":"","url":"https://api.github.com/users/rabanti-github","html_url":"https://github.com/rabanti-github","followers_url":"https://api.github.com/users/rabanti-github/followers","following_url":"https://api.github.com/users/rabanti-github/following{/other_user}","gists_url":"https://api.github.com/users/rabanti-github/gists{/gist_id}","starred_url":"https://api.github.com/users/rabanti-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabanti-github/subscriptions","organizations_url":"https://api.github.com/users/rabanti-github/orgs","repos_url":"https://api.github.com/users/rabanti-github/repos","events_url":"https://api.github.com/users/rabanti-github/events{/privacy}","received_events_url":"https://api.github.com/users/rabanti-github/received_events","type":"User","site_admin":false},"created_at":"2015-04-23T11:14:22Z","updated_at":"2015-04-23T11:14:22Z","body":"Fixed by using ID of overlay objects as identifier when calling setOverlay(). Obverlays with the same ID will be removed."}}