{"action":"opened","number":3883,"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3883","id":32847587,"html_url":"https://github.com/activeadmin/activeadmin/pull/3883","diff_url":"https://github.com/activeadmin/activeadmin/pull/3883.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/3883.patch","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3883","number":3883,"state":"open","locked":false,"title":"Fixed unexpected page title behavior on the show page of resources","user":{"login":"wolfemm","id":5006014,"avatar_url":"https://avatars.githubusercontent.com/u/5006014?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfemm","html_url":"https://github.com/wolfemm","followers_url":"https://api.github.com/users/wolfemm/followers","following_url":"https://api.github.com/users/wolfemm/following{/other_user}","gists_url":"https://api.github.com/users/wolfemm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfemm/subscriptions","organizations_url":"https://api.github.com/users/wolfemm/orgs","repos_url":"https://api.github.com/users/wolfemm/repos","events_url":"https://api.github.com/users/wolfemm/events{/privacy}","received_events_url":"https://api.github.com/users/wolfemm/received_events","type":"User","site_admin":false},"body":"Fixes #3860.\r\n\r\n`title == resource.to_s` prevented a user-defined to_s method on resources from being used as the page title, including any of the other display_name_methods aliased to it.\r\n\r\nCurrently the only workaround is to add `show title: :to_s`, which goes against the conventional nature of AA that I like so much.\r\n\r\nEven with my change, the kernel's to_s will not be used because of the more comprehensive check in [DisplayHelper#display_name_method_for](https://github.com/activeadmin/activeadmin/blob/6bde1f57ec5f9b724c21e5af146678f4ade839bc/lib/active_admin/view_helpers/display_helper.rb#L30).\r\n\r\nI can confirm that removing to_s from display_name_methods will not fix the problem, because if a method aliased to to_s is used `title == resource.to_s` will be true and result in the fallback.","created_at":"2015-04-08T10:38:54Z","updated_at":"2015-04-08T10:38:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3883/commits","review_comments_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3883/comments","review_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3883/comments","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/16095275eac695ae526340738a82faf0f3369f9f","head":{"label":"wolfemm:master","ref":"master","sha":"16095275eac695ae526340738a82faf0f3369f9f","user":{"login":"wolfemm","id":5006014,"avatar_url":"https://avatars.githubusercontent.com/u/5006014?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfemm","html_url":"https://github.com/wolfemm","followers_url":"https://api.github.com/users/wolfemm/followers","following_url":"https://api.github.com/users/wolfemm/following{/other_user}","gists_url":"https://api.github.com/users/wolfemm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfemm/subscriptions","organizations_url":"https://api.github.com/users/wolfemm/orgs","repos_url":"https://api.github.com/users/wolfemm/repos","events_url":"https://api.github.com/users/wolfemm/events{/privacy}","received_events_url":"https://api.github.com/users/wolfemm/received_events","type":"User","site_admin":false},"repo":{"id":33239459,"name":"activeadmin","full_name":"wolfemm/activeadmin","owner":{"login":"wolfemm","id":5006014,"avatar_url":"https://avatars.githubusercontent.com/u/5006014?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfemm","html_url":"https://github.com/wolfemm","followers_url":"https://api.github.com/users/wolfemm/followers","following_url":"https://api.github.com/users/wolfemm/following{/other_user}","gists_url":"https://api.github.com/users/wolfemm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfemm/subscriptions","organizations_url":"https://api.github.com/users/wolfemm/orgs","repos_url":"https://api.github.com/users/wolfemm/repos","events_url":"https://api.github.com/users/wolfemm/events{/privacy}","received_events_url":"https://api.github.com/users/wolfemm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wolfemm/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":true,"url":"https://api.github.com/repos/wolfemm/activeadmin","forks_url":"https://api.github.com/repos/wolfemm/activeadmin/forks","keys_url":"https://api.github.com/repos/wolfemm/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolfemm/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolfemm/activeadmin/teams","hooks_url":"https://api.github.com/repos/wolfemm/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/wolfemm/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/wolfemm/activeadmin/events","assignees_url":"https://api.github.com/repos/wolfemm/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/wolfemm/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/wolfemm/activeadmin/tags","blobs_url":"https://api.github.com/repos/wolfemm/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolfemm/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolfemm/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolfemm/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolfemm/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/wolfemm/activeadmin/languages","stargazers_url":"https://api.github.com/repos/wolfemm/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/wolfemm/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/wolfemm/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/wolfemm/activeadmin/subscription","commits_url":"https://api.github.com/repos/wolfemm/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolfemm/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolfemm/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolfemm/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolfemm/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/wolfemm/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolfemm/activeadmin/merges","archive_url":"https://api.github.com/repos/wolfemm/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolfemm/activeadmin/downloads","issues_url":"https://api.github.com/repos/wolfemm/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/wolfemm/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/wolfemm/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/wolfemm/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolfemm/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/wolfemm/activeadmin/releases{/id}","created_at":"2015-04-01T09:42:54Z","updated_at":"2015-04-08T10:09:36Z","pushed_at":"2015-04-08T10:09:35Z","git_url":"git://github.com/wolfemm/activeadmin.git","ssh_url":"git@github.com:wolfemm/activeadmin.git","clone_url":"https://github.com/wolfemm/activeadmin.git","svn_url":"https://github.com/wolfemm/activeadmin","homepage":"activeadmin.info","size":7135,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activeadmin:master","ref":"master","sha":"dd5d6573f8267c4f883bebd4d8ebf188b2446712","user":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":611921,"name":"activeadmin","full_name":"activeadmin/activeadmin","owner":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeadmin/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":false,"url":"https://api.github.com/repos/activeadmin/activeadmin","forks_url":"https://api.github.com/repos/activeadmin/activeadmin/forks","keys_url":"https://api.github.com/repos/activeadmin/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeadmin/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeadmin/activeadmin/teams","hooks_url":"https://api.github.com/repos/activeadmin/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/activeadmin/activeadmin/events","assignees_url":"https://api.github.com/repos/activeadmin/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/activeadmin/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/activeadmin/activeadmin/tags","blobs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeadmin/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeadmin/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/activeadmin/activeadmin/languages","stargazers_url":"https://api.github.com/repos/activeadmin/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/activeadmin/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/activeadmin/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/activeadmin/activeadmin/subscription","commits_url":"https://api.github.com/repos/activeadmin/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeadmin/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeadmin/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/activeadmin/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeadmin/activeadmin/merges","archive_url":"https://api.github.com/repos/activeadmin/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeadmin/activeadmin/downloads","issues_url":"https://api.github.com/repos/activeadmin/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/activeadmin/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/activeadmin/activeadmin/releases{/id}","created_at":"2010-04-15T14:26:03Z","updated_at":"2015-04-08T09:02:53Z","pushed_at":"2015-04-08T09:19:41Z","git_url":"git://github.com/activeadmin/activeadmin.git","ssh_url":"git@github.com:activeadmin/activeadmin.git","clone_url":"https://github.com/activeadmin/activeadmin.git","svn_url":"https://github.com/activeadmin/activeadmin","homepage":"activeadmin.info","size":19765,"stargazers_count":5839,"watchers_count":5839,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2076,"mirror_url":null,"open_issues_count":179,"forks":2076,"open_issues":179,"watchers":5839,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3883"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3883"},"issue":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3883"},"comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3883/comments"},"review_comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3883/comments"},"review_comment":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3883/commits"},"statuses":{"href":"https://api.github.com/repos/activeadmin/activeadmin/statuses/16095275eac695ae526340738a82faf0f3369f9f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}