{"action":"created","comment":{"url":"https://api.github.com/repos/osiell/ansible-odoo/pulls/comments/27374587","id":27374587,"diff_hunk":"@@ -0,0 +1,24 @@\n+---\n+\n+- name: Detect Debian architecture (i386 or amd64)\n+  set_fact: odoo_debian_arch={{ '64' in ansible_architecture and 'amd64' or 'i386' }}\n+\n+- name: Download wkhtmltox\n+  get_url: url={{ item }}\n+           dest={{ odoo_wkhtmltox_dest }}\n+  with_items: odoo_wkhtmltox_urls\n+  ignore_errors: True\n+  when: odoo_wkhtmltox_version is defined and odoo_wkhtmltox_version != False\n+\n+- name: Check wkhtmltox package\n+  stat: path={{ odoo_wkhtmltox_dest }}","path":"tasks/wkhtmltox.yml","position":14,"original_position":14,"commit_id":"5874c6915198c0436c0e71ba8c0201c907863eec","original_commit_id":"5874c6915198c0436c0e71ba8c0201c907863eec","user":{"login":"sebalix","id":5315285,"avatar_url":"https://avatars.githubusercontent.com/u/5315285?v=3","gravatar_id":"","url":"https://api.github.com/users/sebalix","html_url":"https://github.com/sebalix","followers_url":"https://api.github.com/users/sebalix/followers","following_url":"https://api.github.com/users/sebalix/following{/other_user}","gists_url":"https://api.github.com/users/sebalix/gists{/gist_id}","starred_url":"https://api.github.com/users/sebalix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebalix/subscriptions","organizations_url":"https://api.github.com/users/sebalix/orgs","repos_url":"https://api.github.com/users/sebalix/repos","events_url":"https://api.github.com/users/sebalix/events{/privacy}","received_events_url":"https://api.github.com/users/sebalix/received_events","type":"User","site_admin":false},"body":"I did not find a better way to detect that the package was downloaded, to perform the other tasks. I attempt to ``register`` the result of the download task, but if we put an older version (0.12.1), the first URL failed and it is enough for Ansible to flag the task as failed even if the download on the second URL was OK.\r\n\r\n","created_at":"2015-03-30T08:55:18Z","updated_at":"2015-03-30T08:55:18Z","html_url":"https://github.com/osiell/ansible-odoo/pull/17#discussion_r27374587","pull_request_url":"https://api.github.com/repos/osiell/ansible-odoo/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/osiell/ansible-odoo/pulls/comments/27374587"},"html":{"href":"https://github.com/osiell/ansible-odoo/pull/17#discussion_r27374587"},"pull_request":{"href":"https://api.github.com/repos/osiell/ansible-odoo/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/osiell/ansible-odoo/pulls/17","id":32172756,"html_url":"https://github.com/osiell/ansible-odoo/pull/17","diff_url":"https://github.com/osiell/ansible-odoo/pull/17.diff","patch_url":"https://github.com/osiell/ansible-odoo/pull/17.patch","issue_url":"https://api.github.com/repos/osiell/ansible-odoo/issues/17","number":17,"state":"open","locked":false,"title":"[IMP] Installation of the wkhtmltox tool.","user":{"login":"sebalix","id":5315285,"avatar_url":"https://avatars.githubusercontent.com/u/5315285?v=3","gravatar_id":"","url":"https://api.github.com/users/sebalix","html_url":"https://github.com/sebalix","followers_url":"https://api.github.com/users/sebalix/followers","following_url":"https://api.github.com/users/sebalix/following{/other_user}","gists_url":"https://api.github.com/users/sebalix/gists{/gist_id}","starred_url":"https://api.github.com/users/sebalix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebalix/subscriptions","organizations_url":"https://api.github.com/users/sebalix/orgs","repos_url":"https://api.github.com/users/sebalix/repos","events_url":"https://api.github.com/users/sebalix/events{/privacy}","received_events_url":"https://api.github.com/users/sebalix/received_events","type":"User","site_admin":false},"body":"The option ``odoo_wkhtmltox_version`` allows to choose the version to install, and the ``odoo_wkhtmltox_urls`` variable contains a list of URLs on which the download will be attempted (fix #5).\r\n\r\nAs ``wkhtmltopdf`` is installed from upstream Debian packages, it only works from the ``0.12.1`` version.\r\n\r\n@clonedagain : have you any feedback on this before a merge?","created_at":"2015-03-28T22:45:14Z","updated_at":"2015-03-30T08:55:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68710d8c05d4ce6c4720e1b99f81da0bcddefb37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/osiell/ansible-odoo/pulls/17/commits","review_comments_url":"https://api.github.com/repos/osiell/ansible-odoo/pulls/17/comments","review_comment_url":"https://api.github.com/repos/osiell/ansible-odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osiell/ansible-odoo/issues/17/comments","statuses_url":"https://api.github.com/repos/osiell/ansible-odoo/statuses/5874c6915198c0436c0e71ba8c0201c907863eec","head":{"label":"sebalix:dev/wkhtmltox","ref":"dev/wkhtmltox","sha":"5874c6915198c0436c0e71ba8c0201c907863eec","user":{"login":"sebalix","id":5315285,"avatar_url":"https://avatars.githubusercontent.com/u/5315285?v=3","gravatar_id":"","url":"https://api.github.com/users/sebalix","html_url":"https://github.com/sebalix","followers_url":"https://api.github.com/users/sebalix/followers","following_url":"https://api.github.com/users/sebalix/following{/other_user}","gists_url":"https://api.github.com/users/sebalix/gists{/gist_id}","starred_url":"https://api.github.com/users/sebalix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebalix/subscriptions","organizations_url":"https://api.github.com/users/sebalix/orgs","repos_url":"https://api.github.com/users/sebalix/repos","events_url":"https://api.github.com/users/sebalix/events{/privacy}","received_events_url":"https://api.github.com/users/sebalix/received_events","type":"User","site_admin":false},"repo":{"id":27957968,"name":"ansible-odoo","full_name":"sebalix/ansible-odoo","owner":{"login":"sebalix","id":5315285,"avatar_url":"https://avatars.githubusercontent.com/u/5315285?v=3","gravatar_id":"","url":"https://api.github.com/users/sebalix","html_url":"https://github.com/sebalix","followers_url":"https://api.github.com/users/sebalix/followers","following_url":"https://api.github.com/users/sebalix/following{/other_user}","gists_url":"https://api.github.com/users/sebalix/gists{/gist_id}","starred_url":"https://api.github.com/users/sebalix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebalix/subscriptions","organizations_url":"https://api.github.com/users/sebalix/orgs","repos_url":"https://api.github.com/users/sebalix/repos","events_url":"https://api.github.com/users/sebalix/events{/privacy}","received_events_url":"https://api.github.com/users/sebalix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebalix/ansible-odoo","description":"Ansible role for Odoo","fork":true,"url":"https://api.github.com/repos/sebalix/ansible-odoo","forks_url":"https://api.github.com/repos/sebalix/ansible-odoo/forks","keys_url":"https://api.github.com/repos/sebalix/ansible-odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebalix/ansible-odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebalix/ansible-odoo/teams","hooks_url":"https://api.github.com/repos/sebalix/ansible-odoo/hooks","issue_events_url":"https://api.github.com/repos/sebalix/ansible-odoo/issues/events{/number}","events_url":"https://api.github.com/repos/sebalix/ansible-odoo/events","assignees_url":"https://api.github.com/repos/sebalix/ansible-odoo/assignees{/user}","branches_url":"https://api.github.com/repos/sebalix/ansible-odoo/branches{/branch}","tags_url":"https://api.github.com/repos/sebalix/ansible-odoo/tags","blobs_url":"https://api.github.com/repos/sebalix/ansible-odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebalix/ansible-odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebalix/ansible-odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebalix/ansible-odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebalix/ansible-odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/sebalix/ansible-odoo/languages","stargazers_url":"https://api.github.com/repos/sebalix/ansible-odoo/stargazers","contributors_url":"https://api.github.com/repos/sebalix/ansible-odoo/contributors","subscribers_url":"https://api.github.com/repos/sebalix/ansible-odoo/subscribers","subscription_url":"https://api.github.com/repos/sebalix/ansible-odoo/subscription","commits_url":"https://api.github.com/repos/sebalix/ansible-odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebalix/ansible-odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebalix/ansible-odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebalix/ansible-odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebalix/ansible-odoo/contents/{+path}","compare_url":"https://api.github.com/repos/sebalix/ansible-odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebalix/ansible-odoo/merges","archive_url":"https://api.github.com/repos/sebalix/ansible-odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebalix/ansible-odoo/downloads","issues_url":"https://api.github.com/repos/sebalix/ansible-odoo/issues{/number}","pulls_url":"https://api.github.com/repos/sebalix/ansible-odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/sebalix/ansible-odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/sebalix/ansible-odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebalix/ansible-odoo/labels{/name}","releases_url":"https://api.github.com/repos/sebalix/ansible-odoo/releases{/id}","created_at":"2014-12-13T11:00:24Z","updated_at":"2015-03-28T22:36:36Z","pushed_at":"2015-03-30T08:21:07Z","git_url":"git://github.com/sebalix/ansible-odoo.git","ssh_url":"git@github.com:sebalix/ansible-odoo.git","clone_url":"https://github.com/sebalix/ansible-odoo.git","svn_url":"https://github.com/sebalix/ansible-odoo","homepage":"","size":278,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"osiell:master","ref":"master","sha":"b70edd1784cc4a5944af95df50e5d596c8652813","user":{"login":"osiell","id":7735915,"avatar_url":"https://avatars.githubusercontent.com/u/7735915?v=3","gravatar_id":"","url":"https://api.github.com/users/osiell","html_url":"https://github.com/osiell","followers_url":"https://api.github.com/users/osiell/followers","following_url":"https://api.github.com/users/osiell/following{/other_user}","gists_url":"https://api.github.com/users/osiell/gists{/gist_id}","starred_url":"https://api.github.com/users/osiell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osiell/subscriptions","organizations_url":"https://api.github.com/users/osiell/orgs","repos_url":"https://api.github.com/users/osiell/repos","events_url":"https://api.github.com/users/osiell/events{/privacy}","received_events_url":"https://api.github.com/users/osiell/received_events","type":"Organization","site_admin":false},"repo":{"id":26320682,"name":"ansible-odoo","full_name":"osiell/ansible-odoo","owner":{"login":"osiell","id":7735915,"avatar_url":"https://avatars.githubusercontent.com/u/7735915?v=3","gravatar_id":"","url":"https://api.github.com/users/osiell","html_url":"https://github.com/osiell","followers_url":"https://api.github.com/users/osiell/followers","following_url":"https://api.github.com/users/osiell/following{/other_user}","gists_url":"https://api.github.com/users/osiell/gists{/gist_id}","starred_url":"https://api.github.com/users/osiell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osiell/subscriptions","organizations_url":"https://api.github.com/users/osiell/orgs","repos_url":"https://api.github.com/users/osiell/repos","events_url":"https://api.github.com/users/osiell/events{/privacy}","received_events_url":"https://api.github.com/users/osiell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osiell/ansible-odoo","description":"Ansible role for Odoo","fork":false,"url":"https://api.github.com/repos/osiell/ansible-odoo","forks_url":"https://api.github.com/repos/osiell/ansible-odoo/forks","keys_url":"https://api.github.com/repos/osiell/ansible-odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osiell/ansible-odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osiell/ansible-odoo/teams","hooks_url":"https://api.github.com/repos/osiell/ansible-odoo/hooks","issue_events_url":"https://api.github.com/repos/osiell/ansible-odoo/issues/events{/number}","events_url":"https://api.github.com/repos/osiell/ansible-odoo/events","assignees_url":"https://api.github.com/repos/osiell/ansible-odoo/assignees{/user}","branches_url":"https://api.github.com/repos/osiell/ansible-odoo/branches{/branch}","tags_url":"https://api.github.com/repos/osiell/ansible-odoo/tags","blobs_url":"https://api.github.com/repos/osiell/ansible-odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osiell/ansible-odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osiell/ansible-odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/osiell/ansible-odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osiell/ansible-odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/osiell/ansible-odoo/languages","stargazers_url":"https://api.github.com/repos/osiell/ansible-odoo/stargazers","contributors_url":"https://api.github.com/repos/osiell/ansible-odoo/contributors","subscribers_url":"https://api.github.com/repos/osiell/ansible-odoo/subscribers","subscription_url":"https://api.github.com/repos/osiell/ansible-odoo/subscription","commits_url":"https://api.github.com/repos/osiell/ansible-odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/osiell/ansible-odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/osiell/ansible-odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/osiell/ansible-odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/osiell/ansible-odoo/contents/{+path}","compare_url":"https://api.github.com/repos/osiell/ansible-odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osiell/ansible-odoo/merges","archive_url":"https://api.github.com/repos/osiell/ansible-odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osiell/ansible-odoo/downloads","issues_url":"https://api.github.com/repos/osiell/ansible-odoo/issues{/number}","pulls_url":"https://api.github.com/repos/osiell/ansible-odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/osiell/ansible-odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/osiell/ansible-odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osiell/ansible-odoo/labels{/name}","releases_url":"https://api.github.com/repos/osiell/ansible-odoo/releases{/id}","created_at":"2014-11-07T13:25:06Z","updated_at":"2015-03-28T14:09:03Z","pushed_at":"2015-03-30T08:21:07Z","git_url":"git://github.com/osiell/ansible-odoo.git","ssh_url":"git@github.com:osiell/ansible-odoo.git","clone_url":"https://github.com/osiell/ansible-odoo.git","svn_url":"https://github.com/osiell/ansible-odoo","homepage":"","size":255,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osiell/ansible-odoo/pulls/17"},"html":{"href":"https://github.com/osiell/ansible-odoo/pull/17"},"issue":{"href":"https://api.github.com/repos/osiell/ansible-odoo/issues/17"},"comments":{"href":"https://api.github.com/repos/osiell/ansible-odoo/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/osiell/ansible-odoo/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/osiell/ansible-odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osiell/ansible-odoo/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/osiell/ansible-odoo/statuses/5874c6915198c0436c0e71ba8c0201c907863eec"}}}}