{"action":"created","comment":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments/31129520","id":31129520,"diff_hunk":"@@ -141,7 +141,8 @@ var cleanQuestProgress = function(merge){\n       down: 0,\n       collect: {}\n     },\n-    completed: null\n+    completed: null,\n+    invited: false","path":"website/src/models/group.js","position":6,"original_position":6,"commit_id":"0fa93506f5ea2eb68284486dc0a37bd970c1e7a3","original_commit_id":"0fa93506f5ea2eb68284486dc0a37bd970c1e7a3","user":{"login":"crookedneighbor","id":2916945,"avatar_url":"https://avatars.githubusercontent.com/u/2916945?v=3","gravatar_id":"","url":"https://api.github.com/users/crookedneighbor","html_url":"https://github.com/crookedneighbor","followers_url":"https://api.github.com/users/crookedneighbor/followers","following_url":"https://api.github.com/users/crookedneighbor/following{/other_user}","gists_url":"https://api.github.com/users/crookedneighbor/gists{/gist_id}","starred_url":"https://api.github.com/users/crookedneighbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crookedneighbor/subscriptions","organizations_url":"https://api.github.com/users/crookedneighbor/orgs","repos_url":"https://api.github.com/users/crookedneighbor/repos","events_url":"https://api.github.com/users/crookedneighbor/events{/privacy}","received_events_url":"https://api.github.com/users/crookedneighbor/received_events","type":"User","site_admin":false},"body":"Is this used any where?","created_at":"2015-05-27T12:52:50Z","updated_at":"2015-05-27T12:52:50Z","html_url":"https://github.com/HabitRPG/habitrpg/pull/5298#discussion_r31129520","pull_request_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/5298","_links":{"self":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments/31129520"},"html":{"href":"https://github.com/HabitRPG/habitrpg/pull/5298#discussion_r31129520"},"pull_request":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/5298"}}},"pull_request":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/5298","id":36266217,"html_url":"https://github.com/HabitRPG/habitrpg/pull/5298","diff_url":"https://github.com/HabitRPG/habitrpg/pull/5298.diff","patch_url":"https://github.com/HabitRPG/habitrpg/pull/5298.patch","issue_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5298","number":5298,"state":"open","locked":false,"title":"Make quest invite modal pop-up on user sync (rewards display currently nonfunctional)","user":{"login":"hairlessbear","id":7059890,"avatar_url":"https://avatars.githubusercontent.com/u/7059890?v=3","gravatar_id":"","url":"https://api.github.com/users/hairlessbear","html_url":"https://github.com/hairlessbear","followers_url":"https://api.github.com/users/hairlessbear/followers","following_url":"https://api.github.com/users/hairlessbear/following{/other_user}","gists_url":"https://api.github.com/users/hairlessbear/gists{/gist_id}","starred_url":"https://api.github.com/users/hairlessbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hairlessbear/subscriptions","organizations_url":"https://api.github.com/users/hairlessbear/orgs","repos_url":"https://api.github.com/users/hairlessbear/repos","events_url":"https://api.github.com/users/hairlessbear/events{/privacy}","received_events_url":"https://api.github.com/users/hairlessbear/received_events","type":"User","site_admin":false},"body":"+ Added a Boolean `invited` field to the user model that defaults to `false`\r\n+ Set `invited` to true for all group members (other than quest leader) when quest invitation is sent ([code link](https://github.com/HabitRPG/habitrpg/blob/0fa93506f5ea2eb68284486dc0a37bd970c1e7a3/website/src/controllers/groups.js#L915))\r\n+ Set `invited` to false when:\r\n  + Quest is cancelled before it starts (all group members; [code link](https://github.com/HabitRPG/habitrpg/blob/0fa93506f5ea2eb68284486dc0a37bd970c1e7a3/website/src/controllers/groups.js#L980-982))\r\n  + User accepts the invitation (single user; [code link](https://github.com/HabitRPG/habitrpg/blob/0fa93506f5ea2eb68284486dc0a37bd970c1e7a3/website/src/controllers/groups.js#L951))\r\n  + User rejects the invitation (single user; [code link](https://github.com/HabitRPG/habitrpg/blob/0fa93506f5ea2eb68284486dc0a37bd970c1e7a3/website/src/controllers/groups.js#L962))\r\n  + Quest starts (all group members; [code link](https://github.com/HabitRPG/habitrpg/blob/0fa93506f5ea2eb68284486dc0a37bd970c1e7a3/website/src/models/group.js#L145), function called [here](https://github.com/HabitRPG/habitrpg/blob/0fa93506f5ea2eb68284486dc0a37bd970c1e7a3/website/src/controllers/groups.js#L835))\r\n+ Replaced the quest invite modal notification logic with `user.party.quest.invited == true`, causing the invite modal to popup on user sync without causing overhead issues as discussed in [#5239](https://github.com/HabitRPG/habitrpg/pull/5239#issuecomment-103699467).\r\n\r\nEverything is working as intended, except for the rewards display. The quest invite modal is currently displaying like this:\r\n\r\n![selection_022](https://cloud.githubusercontent.com/assets/7059890/7828154/b7452faa-03fd-11e5-8fde-68c4a657bc1e.png)\r\n\r\n...and I can't figure out why. I'm guessing it has something to do with the scope of the [`quest-rewards`](https://github.com/HabitRPG/habitrpg/blob/develop/common/script/public/directives.js#L155-164) directive, but I'm really not sure. pinging @crookedneighbor and @Alys for help.","created_at":"2015-05-27T03:25:34Z","updated_at":"2015-05-27T12:52:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"110bc1b2b18f70bb3bed6fe567aef76835a72d1b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/5298/commits","review_comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/5298/comments","review_comment_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5298/comments","statuses_url":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/0fa93506f5ea2eb68284486dc0a37bd970c1e7a3","head":{"label":"hairlessbear:quest_invite_modal_on_user_sync","ref":"quest_invite_modal_on_user_sync","sha":"0fa93506f5ea2eb68284486dc0a37bd970c1e7a3","user":{"login":"hairlessbear","id":7059890,"avatar_url":"https://avatars.githubusercontent.com/u/7059890?v=3","gravatar_id":"","url":"https://api.github.com/users/hairlessbear","html_url":"https://github.com/hairlessbear","followers_url":"https://api.github.com/users/hairlessbear/followers","following_url":"https://api.github.com/users/hairlessbear/following{/other_user}","gists_url":"https://api.github.com/users/hairlessbear/gists{/gist_id}","starred_url":"https://api.github.com/users/hairlessbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hairlessbear/subscriptions","organizations_url":"https://api.github.com/users/hairlessbear/orgs","repos_url":"https://api.github.com/users/hairlessbear/repos","events_url":"https://api.github.com/users/hairlessbear/events{/privacy}","received_events_url":"https://api.github.com/users/hairlessbear/received_events","type":"User","site_admin":false},"repo":{"id":33798753,"name":"habitrpg","full_name":"hairlessbear/habitrpg","owner":{"login":"hairlessbear","id":7059890,"avatar_url":"https://avatars.githubusercontent.com/u/7059890?v=3","gravatar_id":"","url":"https://api.github.com/users/hairlessbear","html_url":"https://github.com/hairlessbear","followers_url":"https://api.github.com/users/hairlessbear/followers","following_url":"https://api.github.com/users/hairlessbear/following{/other_user}","gists_url":"https://api.github.com/users/hairlessbear/gists{/gist_id}","starred_url":"https://api.github.com/users/hairlessbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hairlessbear/subscriptions","organizations_url":"https://api.github.com/users/hairlessbear/orgs","repos_url":"https://api.github.com/users/hairlessbear/repos","events_url":"https://api.github.com/users/hairlessbear/events{/privacy}","received_events_url":"https://api.github.com/users/hairlessbear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hairlessbear/habitrpg","description":"A habit tracker app which treats your goals like a Role Playing Game.","fork":true,"url":"https://api.github.com/repos/hairlessbear/habitrpg","forks_url":"https://api.github.com/repos/hairlessbear/habitrpg/forks","keys_url":"https://api.github.com/repos/hairlessbear/habitrpg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hairlessbear/habitrpg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hairlessbear/habitrpg/teams","hooks_url":"https://api.github.com/repos/hairlessbear/habitrpg/hooks","issue_events_url":"https://api.github.com/repos/hairlessbear/habitrpg/issues/events{/number}","events_url":"https://api.github.com/repos/hairlessbear/habitrpg/events","assignees_url":"https://api.github.com/repos/hairlessbear/habitrpg/assignees{/user}","branches_url":"https://api.github.com/repos/hairlessbear/habitrpg/branches{/branch}","tags_url":"https://api.github.com/repos/hairlessbear/habitrpg/tags","blobs_url":"https://api.github.com/repos/hairlessbear/habitrpg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hairlessbear/habitrpg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hairlessbear/habitrpg/git/refs{/sha}","trees_url":"https://api.github.com/repos/hairlessbear/habitrpg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hairlessbear/habitrpg/statuses/{sha}","languages_url":"https://api.github.com/repos/hairlessbear/habitrpg/languages","stargazers_url":"https://api.github.com/repos/hairlessbear/habitrpg/stargazers","contributors_url":"https://api.github.com/repos/hairlessbear/habitrpg/contributors","subscribers_url":"https://api.github.com/repos/hairlessbear/habitrpg/subscribers","subscription_url":"https://api.github.com/repos/hairlessbear/habitrpg/subscription","commits_url":"https://api.github.com/repos/hairlessbear/habitrpg/commits{/sha}","git_commits_url":"https://api.github.com/repos/hairlessbear/habitrpg/git/commits{/sha}","comments_url":"https://api.github.com/repos/hairlessbear/habitrpg/comments{/number}","issue_comment_url":"https://api.github.com/repos/hairlessbear/habitrpg/issues/comments{/number}","contents_url":"https://api.github.com/repos/hairlessbear/habitrpg/contents/{+path}","compare_url":"https://api.github.com/repos/hairlessbear/habitrpg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hairlessbear/habitrpg/merges","archive_url":"https://api.github.com/repos/hairlessbear/habitrpg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hairlessbear/habitrpg/downloads","issues_url":"https://api.github.com/repos/hairlessbear/habitrpg/issues{/number}","pulls_url":"https://api.github.com/repos/hairlessbear/habitrpg/pulls{/number}","milestones_url":"https://api.github.com/repos/hairlessbear/habitrpg/milestones{/number}","notifications_url":"https://api.github.com/repos/hairlessbear/habitrpg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hairlessbear/habitrpg/labels{/name}","releases_url":"https://api.github.com/repos/hairlessbear/habitrpg/releases{/id}","created_at":"2015-04-12T01:22:43Z","updated_at":"2015-04-24T08:09:32Z","pushed_at":"2015-05-27T03:45:10Z","git_url":"git://github.com/hairlessbear/habitrpg.git","ssh_url":"git@github.com:hairlessbear/habitrpg.git","clone_url":"https://github.com/hairlessbear/habitrpg.git","svn_url":"https://github.com/hairlessbear/habitrpg","homepage":"habitrpg.com","size":181548,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"HabitRPG:develop","ref":"develop","sha":"85993d25cfc0f876d5480e174aadf0104322e37b","user":{"login":"HabitRPG","id":3834775,"avatar_url":"https://avatars.githubusercontent.com/u/3834775?v=3","gravatar_id":"","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":4578898,"name":"habitrpg","full_name":"HabitRPG/habitrpg","owner":{"login":"HabitRPG","id":3834775,"avatar_url":"https://avatars.githubusercontent.com/u/3834775?v=3","gravatar_id":"","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HabitRPG/habitrpg","description":"A habit tracker app which treats your goals like a Role Playing Game.","fork":false,"url":"https://api.github.com/repos/HabitRPG/habitrpg","forks_url":"https://api.github.com/repos/HabitRPG/habitrpg/forks","keys_url":"https://api.github.com/repos/HabitRPG/habitrpg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HabitRPG/habitrpg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HabitRPG/habitrpg/teams","hooks_url":"https://api.github.com/repos/HabitRPG/habitrpg/hooks","issue_events_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/events{/number}","events_url":"https://api.github.com/repos/HabitRPG/habitrpg/events","assignees_url":"https://api.github.com/repos/HabitRPG/habitrpg/assignees{/user}","branches_url":"https://api.github.com/repos/HabitRPG/habitrpg/branches{/branch}","tags_url":"https://api.github.com/repos/HabitRPG/habitrpg/tags","blobs_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/refs{/sha}","trees_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/{sha}","languages_url":"https://api.github.com/repos/HabitRPG/habitrpg/languages","stargazers_url":"https://api.github.com/repos/HabitRPG/habitrpg/stargazers","contributors_url":"https://api.github.com/repos/HabitRPG/habitrpg/contributors","subscribers_url":"https://api.github.com/repos/HabitRPG/habitrpg/subscribers","subscription_url":"https://api.github.com/repos/HabitRPG/habitrpg/subscription","commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/commits{/sha}","git_commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/commits{/sha}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/comments{/number}","issue_comment_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/comments{/number}","contents_url":"https://api.github.com/repos/HabitRPG/habitrpg/contents/{+path}","compare_url":"https://api.github.com/repos/HabitRPG/habitrpg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HabitRPG/habitrpg/merges","archive_url":"https://api.github.com/repos/HabitRPG/habitrpg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HabitRPG/habitrpg/downloads","issues_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues{/number}","pulls_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls{/number}","milestones_url":"https://api.github.com/repos/HabitRPG/habitrpg/milestones{/number}","notifications_url":"https://api.github.com/repos/HabitRPG/habitrpg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HabitRPG/habitrpg/labels{/name}","releases_url":"https://api.github.com/repos/HabitRPG/habitrpg/releases{/id}","created_at":"2012-06-06T22:49:48Z","updated_at":"2015-05-27T04:21:29Z","pushed_at":"2015-05-27T10:26:13Z","git_url":"git://github.com/HabitRPG/habitrpg.git","ssh_url":"git@github.com:HabitRPG/habitrpg.git","clone_url":"https://github.com/HabitRPG/habitrpg.git","svn_url":"https://github.com/HabitRPG/habitrpg","homepage":"habitrpg.com","size":209699,"stargazers_count":2748,"watchers_count":2748,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1074,"mirror_url":null,"open_issues_count":624,"forks":1074,"open_issues":624,"watchers":2748,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/5298"},"html":{"href":"https://github.com/HabitRPG/habitrpg/pull/5298"},"issue":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5298"},"comments":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5298/comments"},"review_comments":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/5298/comments"},"review_comment":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/5298/commits"},"statuses":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/0fa93506f5ea2eb68284486dc0a37bd970c1e7a3"}}}}