{"action":"created","issue":{"url":"https://api.github.com/repos/rackt/react-router/issues/1376","labels_url":"https://api.github.com/repos/rackt/react-router/issues/1376/labels{/name}","comments_url":"https://api.github.com/repos/rackt/react-router/issues/1376/comments","events_url":"https://api.github.com/repos/rackt/react-router/issues/1376/events","html_url":"https://github.com/rackt/react-router/pull/1376","id":89816073,"number":1376,"title":"Update Histories","user":{"login":"taurose","id":1550663,"avatar_url":"https://avatars.githubusercontent.com/u/1550663?v=3","gravatar_id":"","url":"https://api.github.com/users/taurose","html_url":"https://github.com/taurose","followers_url":"https://api.github.com/users/taurose/followers","following_url":"https://api.github.com/users/taurose/following{/other_user}","gists_url":"https://api.github.com/users/taurose/gists{/gist_id}","starred_url":"https://api.github.com/users/taurose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taurose/subscriptions","organizations_url":"https://api.github.com/users/taurose/orgs","repos_url":"https://api.github.com/users/taurose/repos","events_url":"https://api.github.com/users/taurose/events{/privacy}","received_events_url":"https://api.github.com/users/taurose/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-20T20:45:04Z","updated_at":"2015-06-21T01:51:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rackt/react-router/pulls/1376","html_url":"https://github.com/rackt/react-router/pull/1376","diff_url":"https://github.com/rackt/react-router/pull/1376.diff","patch_url":"https://github.com/rackt/react-router/pull/1376.patch"},"body":"See #1363 for previous discussion."},"comment":{"url":"https://api.github.com/repos/rackt/react-router/issues/comments/113848773","html_url":"https://github.com/rackt/react-router/pull/1376#issuecomment-113848773","issue_url":"https://api.github.com/repos/rackt/react-router/issues/1376","id":113848773,"user":{"login":"taurose","id":1550663,"avatar_url":"https://avatars.githubusercontent.com/u/1550663?v=3","gravatar_id":"","url":"https://api.github.com/users/taurose","html_url":"https://github.com/taurose","followers_url":"https://api.github.com/users/taurose/followers","following_url":"https://api.github.com/users/taurose/following{/other_user}","gists_url":"https://api.github.com/users/taurose/gists{/gist_id}","starred_url":"https://api.github.com/users/taurose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taurose/subscriptions","organizations_url":"https://api.github.com/users/taurose/orgs","repos_url":"https://api.github.com/users/taurose/repos","events_url":"https://api.github.com/users/taurose/events{/privacy}","received_events_url":"https://api.github.com/users/taurose/received_events","type":"User","site_admin":false},"created_at":"2015-06-21T01:51:01Z","updated_at":"2015-06-21T01:51:01Z","body":"@mjackson Added a new commit for `onBeforeChange`. Only a single listener is supported right now (not sure if it's worth adding more). Callback signature is `(location, navigate)`, where `navigate` is a callback that performs the actual navigation; can be called asynchronously or not at all. For DOM unload, `location` and `navigate` are not set, and the method is expected to return a string for the dialog message. \r\n\r\nAlso, I think the History classes would be a bit cleaner if all the listener setup happened in `setup`, and unbinding in an extra `teardown` method. Any objections?"}}