{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/34421217","id":34421217,"diff_hunk":"@@ -0,0 +1,46 @@\n+//\n+//Copyright (C) 2002-2005  3Dlabs Inc. Ltd.\n+//All rights reserved.\n+//\n+//Redistribution and use in source and binary forms, with or without\n+//modification, are permitted provided that the following conditions\n+//are met:\n+//\n+//    Redistributions of source code must retain the above copyright\n+//    notice, this list of conditions and the following disclaimer.\n+//\n+//    Redistributions in binary form must reproduce the above\n+//    copyright notice, this list of conditions and the following\n+//    disclaimer in the documentation and/or other materials provided\n+//    with the distribution.\n+//\n+//    Neither the name of 3Dlabs Inc. Ltd. nor the names of its\n+//    contributors may be used to endorse or promote products derived\n+//    from this software without specific prior written permission.\n+//\n+//THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+//\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+//LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS\n+//FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE\n+//COPYRIGHT HOLDERS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,\n+//INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,\n+//BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;\n+//LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER\n+//CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT\n+//LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN\n+//ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+//POSSIBILITY OF SUCH DAMAGE.\n+//\n+\n+#ifndef __ROOT_OSINCLUDE_H\n+#define __ROOT_OSINCLUDE_H\n+\n+#if defined(WIN32)\n+#include \"Windows/osinclude.h\"\n+#elif defined(__linux__)","path":"glslang/OSDependent/osinclude.h","position":40,"original_position":40,"commit_id":"047fd7a9256d447848914ba3c87b56c502228efe","original_commit_id":"047fd7a9256d447848914ba3c87b56c502228efe","user":{"login":"fkaa","id":768574,"avatar_url":"https://avatars.githubusercontent.com/u/768574?v=3","gravatar_id":"","url":"https://api.github.com/users/fkaa","html_url":"https://github.com/fkaa","followers_url":"https://api.github.com/users/fkaa/followers","following_url":"https://api.github.com/users/fkaa/following{/other_user}","gists_url":"https://api.github.com/users/fkaa/gists{/gist_id}","starred_url":"https://api.github.com/users/fkaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkaa/subscriptions","organizations_url":"https://api.github.com/users/fkaa/orgs","repos_url":"https://api.github.com/users/fkaa/repos","events_url":"https://api.github.com/users/fkaa/events{/privacy}","received_events_url":"https://api.github.com/users/fkaa/received_events","type":"User","site_admin":false},"body":"Fails on OS X (`__APPLE__`)","created_at":"2015-07-12T12:26:31Z","updated_at":"2015-07-12T12:26:31Z","html_url":"https://github.com/KhronosGroup/glslang/pull/10#discussion_r34421217","pull_request_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/34421217"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/10#discussion_r34421217"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/10","id":39759400,"html_url":"https://github.com/KhronosGroup/glslang/pull/10","diff_url":"https://github.com/KhronosGroup/glslang/pull/10.diff","patch_url":"https://github.com/KhronosGroup/glslang/pull/10.patch","issue_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/10","number":10,"state":"open","locked":false,"title":"common osinclude.h header file that redirects per-platform","user":{"login":"baldurk","id":661798,"avatar_url":"https://avatars.githubusercontent.com/u/661798?v=3","gravatar_id":"","url":"https://api.github.com/users/baldurk","html_url":"https://github.com/baldurk","followers_url":"https://api.github.com/users/baldurk/followers","following_url":"https://api.github.com/users/baldurk/following{/other_user}","gists_url":"https://api.github.com/users/baldurk/gists{/gist_id}","starred_url":"https://api.github.com/users/baldurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldurk/subscriptions","organizations_url":"https://api.github.com/users/baldurk/orgs","repos_url":"https://api.github.com/users/baldurk/repos","events_url":"https://api.github.com/users/baldurk/events{/privacy}","received_events_url":"https://api.github.com/users/baldurk/received_events","type":"User","site_admin":false},"body":"As I mentioned, this now makes files that need to include osinclude.h include it from a common root, that then checks platform macros to include the right one. I didn't see any existing platform macros (and I don't know if CMake defines any by default), so I just used WIN32 & __linux__ that should come from the compiler. If you'd like to define glslang-specific macros in CMakeLists.txt somewhere I can update the PR.\r\n\r\nI also changed bison to output to the source folder instead of to the build folder, so that relative includes will work and the include_directories lines can be removed from CMakeLists.txt. I think this makes sense but if you want to keep bison output in the build folder that's manageable without losing the rest of the change.","created_at":"2015-07-12T09:24:39Z","updated_at":"2015-07-12T12:26:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93028197b0047670afd21a66be64b14c716bde00","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/10/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/10/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/10/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/047fd7a9256d447848914ba3c87b56c502228efe","head":{"label":"baldurk:osinclude-common-header","ref":"osinclude-common-header","sha":"047fd7a9256d447848914ba3c87b56c502228efe","user":{"login":"baldurk","id":661798,"avatar_url":"https://avatars.githubusercontent.com/u/661798?v=3","gravatar_id":"","url":"https://api.github.com/users/baldurk","html_url":"https://github.com/baldurk","followers_url":"https://api.github.com/users/baldurk/followers","following_url":"https://api.github.com/users/baldurk/following{/other_user}","gists_url":"https://api.github.com/users/baldurk/gists{/gist_id}","starred_url":"https://api.github.com/users/baldurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldurk/subscriptions","organizations_url":"https://api.github.com/users/baldurk/orgs","repos_url":"https://api.github.com/users/baldurk/repos","events_url":"https://api.github.com/users/baldurk/events{/privacy}","received_events_url":"https://api.github.com/users/baldurk/received_events","type":"User","site_admin":false},"repo":{"id":38753174,"name":"glslang","full_name":"baldurk/glslang","owner":{"login":"baldurk","id":661798,"avatar_url":"https://avatars.githubusercontent.com/u/661798?v=3","gravatar_id":"","url":"https://api.github.com/users/baldurk","html_url":"https://github.com/baldurk","followers_url":"https://api.github.com/users/baldurk/followers","following_url":"https://api.github.com/users/baldurk/following{/other_user}","gists_url":"https://api.github.com/users/baldurk/gists{/gist_id}","starred_url":"https://api.github.com/users/baldurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baldurk/subscriptions","organizations_url":"https://api.github.com/users/baldurk/orgs","repos_url":"https://api.github.com/users/baldurk/repos","events_url":"https://api.github.com/users/baldurk/events{/privacy}","received_events_url":"https://api.github.com/users/baldurk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baldurk/glslang","description":"Khronos reference front-end for GLSL and ESSL","fork":true,"url":"https://api.github.com/repos/baldurk/glslang","forks_url":"https://api.github.com/repos/baldurk/glslang/forks","keys_url":"https://api.github.com/repos/baldurk/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baldurk/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baldurk/glslang/teams","hooks_url":"https://api.github.com/repos/baldurk/glslang/hooks","issue_events_url":"https://api.github.com/repos/baldurk/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/baldurk/glslang/events","assignees_url":"https://api.github.com/repos/baldurk/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/baldurk/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/baldurk/glslang/tags","blobs_url":"https://api.github.com/repos/baldurk/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baldurk/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baldurk/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/baldurk/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baldurk/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/baldurk/glslang/languages","stargazers_url":"https://api.github.com/repos/baldurk/glslang/stargazers","contributors_url":"https://api.github.com/repos/baldurk/glslang/contributors","subscribers_url":"https://api.github.com/repos/baldurk/glslang/subscribers","subscription_url":"https://api.github.com/repos/baldurk/glslang/subscription","commits_url":"https://api.github.com/repos/baldurk/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/baldurk/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/baldurk/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/baldurk/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/baldurk/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/baldurk/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baldurk/glslang/merges","archive_url":"https://api.github.com/repos/baldurk/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baldurk/glslang/downloads","issues_url":"https://api.github.com/repos/baldurk/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/baldurk/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/baldurk/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/baldurk/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baldurk/glslang/labels{/name}","releases_url":"https://api.github.com/repos/baldurk/glslang/releases{/id}","created_at":"2015-07-08T12:40:13Z","updated_at":"2015-07-08T12:40:16Z","pushed_at":"2015-07-12T10:07:26Z","git_url":"git://github.com/baldurk/glslang.git","ssh_url":"git@github.com:baldurk/glslang.git","clone_url":"https://github.com/baldurk/glslang.git","svn_url":"https://github.com/baldurk/glslang","homepage":null,"size":21477,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"b329715caf505feea29ebec5126f7bcd40f56cef","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":38064932,"name":"glslang","full_name":"KhronosGroup/glslang","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/glslang","description":"Khronos reference front-end for GLSL and ESSL","fork":false,"url":"https://api.github.com/repos/KhronosGroup/glslang","forks_url":"https://api.github.com/repos/KhronosGroup/glslang/forks","keys_url":"https://api.github.com/repos/KhronosGroup/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/glslang/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/glslang/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/glslang/events","assignees_url":"https://api.github.com/repos/KhronosGroup/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/glslang/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/glslang/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/glslang/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/glslang/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/glslang/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/glslang/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/glslang/merges","archive_url":"https://api.github.com/repos/KhronosGroup/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/glslang/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/glslang/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/glslang/releases{/id}","created_at":"2015-06-25T17:54:39Z","updated_at":"2015-07-11T14:08:47Z","pushed_at":"2015-07-12T09:35:02Z","git_url":"git://github.com/KhronosGroup/glslang.git","ssh_url":"git@github.com:KhronosGroup/glslang.git","clone_url":"https://github.com/KhronosGroup/glslang.git","svn_url":"https://github.com/KhronosGroup/glslang","homepage":null,"size":21578,"stargazers_count":73,"watchers_count":73,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/10"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/10"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/10"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/glslang/statuses/047fd7a9256d447848914ba3c87b56c502228efe"}}}}