{"action":"closed","number":661,"pull_request":{"url":"https://api.github.com/repos/github/android/pulls/661","id":26803601,"html_url":"https://github.com/github/android/pull/661","diff_url":"https://github.com/github/android/pull/661.diff","patch_url":"https://github.com/github/android/pull/661.patch","issue_url":"https://api.github.com/repos/github/android/issues/661","number":661,"state":"closed","locked":false,"title":"Switch from ActionBarSherlock to AppCompat","user":{"login":"hzsweers","id":1361086,"avatar_url":"https://avatars.githubusercontent.com/u/1361086?v=3","gravatar_id":"","url":"https://api.github.com/users/hzsweers","html_url":"https://github.com/hzsweers","followers_url":"https://api.github.com/users/hzsweers/followers","following_url":"https://api.github.com/users/hzsweers/following{/other_user}","gists_url":"https://api.github.com/users/hzsweers/gists{/gist_id}","starred_url":"https://api.github.com/users/hzsweers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzsweers/subscriptions","organizations_url":"https://api.github.com/users/hzsweers/orgs","repos_url":"https://api.github.com/users/hzsweers/repos","events_url":"https://api.github.com/users/hzsweers/events{/privacy}","received_events_url":"https://api.github.com/users/hzsweers/received_events","type":"User","site_admin":false},"body":"This should set the foundation to really allow developers to start digging in to implementing material design.\r\n\r\n* Removes ActionBarSherlock and the RoboSherlock library supporting it\r\n* Adds AppCompat and wrapper classes for `ActionBarActivity` that provide what RoboSherlock provided for ABS\r\n  * This still uses RoboGuice 2.0. 3.0 would be nice, as it has 1st party support for these wrapper classes.\r\n  * This also requires setting minSDK to 11, which in turn means we can really bump it up to 15. 15 still covers 90+% of all Android users, and almost certainly close to 100% of the tech savvy ones that use the Github app.\r\n* Set basic color palette (you guys can change this to whatever you like, I just went with a safe option of the grey primaryColor, darker version for primaryColorDark, and the blue for accentColor\r\n* Use AppCompat's new searchview UI (including using its new icon, which allows us to remove the old one)\r\n* Improved `.gitignore` (my IDE kept wanting to commit IntelliJ files...)\r\n* Removed unnecessary declarations from AndroidManifest\r\n\r\nThe actionbar cuts over the tab pager a little, but I don't think that's a new bug having seen it in the store version prior to this.\r\n\r\nYou guys should update your current actionbar items to fully-white versions of their new Material alternatives. They're available for free come google [here](https://github.com/google/material-design-icons), or I can add them in this pull request as well if you want.\r\n\r\nThis addresses #658 \r\n\r\nScreenshots album: http://imgur.com/a/x76xf\r\n\r\nCouple screen records of the new UI:\r\n* https://www.dropbox.com/s/7yoh831834u7nlm/device-2015-01-04-180254.mp4?dl=0\r\n* https://www.dropbox.com/s/68oy4v2lo1dv29c/device-2015-01-04-180455.mp4?dl=0","created_at":"2015-01-05T02:22:37Z","updated_at":"2015-01-07T01:59:40Z","closed_at":"2015-01-07T01:59:40Z","merged_at":"2015-01-07T01:59:40Z","merge_commit_sha":"fe39d0760b9a80ca06844d363a48491d44b00d78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/github/android/pulls/661/commits","review_comments_url":"https://api.github.com/repos/github/android/pulls/661/comments","review_comment_url":"https://api.github.com/repos/github/android/pulls/comments/{number}","comments_url":"https://api.github.com/repos/github/android/issues/661/comments","statuses_url":"https://api.github.com/repos/github/android/statuses/4b7c2778e43a88d078435e9123006572dab9dc90","head":{"label":"hzsweers:master","ref":"master","sha":"4b7c2778e43a88d078435e9123006572dab9dc90","user":{"login":"hzsweers","id":1361086,"avatar_url":"https://avatars.githubusercontent.com/u/1361086?v=3","gravatar_id":"","url":"https://api.github.com/users/hzsweers","html_url":"https://github.com/hzsweers","followers_url":"https://api.github.com/users/hzsweers/followers","following_url":"https://api.github.com/users/hzsweers/following{/other_user}","gists_url":"https://api.github.com/users/hzsweers/gists{/gist_id}","starred_url":"https://api.github.com/users/hzsweers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzsweers/subscriptions","organizations_url":"https://api.github.com/users/hzsweers/orgs","repos_url":"https://api.github.com/users/hzsweers/repos","events_url":"https://api.github.com/users/hzsweers/events{/privacy}","received_events_url":"https://api.github.com/users/hzsweers/received_events","type":"User","site_admin":false},"repo":{"id":28554842,"name":"android","full_name":"hzsweers/android","owner":{"login":"hzsweers","id":1361086,"avatar_url":"https://avatars.githubusercontent.com/u/1361086?v=3","gravatar_id":"","url":"https://api.github.com/users/hzsweers","html_url":"https://github.com/hzsweers","followers_url":"https://api.github.com/users/hzsweers/followers","following_url":"https://api.github.com/users/hzsweers/following{/other_user}","gists_url":"https://api.github.com/users/hzsweers/gists{/gist_id}","starred_url":"https://api.github.com/users/hzsweers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzsweers/subscriptions","organizations_url":"https://api.github.com/users/hzsweers/orgs","repos_url":"https://api.github.com/users/hzsweers/repos","events_url":"https://api.github.com/users/hzsweers/events{/privacy}","received_events_url":"https://api.github.com/users/hzsweers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hzsweers/android","description":"GitHub Android App","fork":true,"url":"https://api.github.com/repos/hzsweers/android","forks_url":"https://api.github.com/repos/hzsweers/android/forks","keys_url":"https://api.github.com/repos/hzsweers/android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hzsweers/android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hzsweers/android/teams","hooks_url":"https://api.github.com/repos/hzsweers/android/hooks","issue_events_url":"https://api.github.com/repos/hzsweers/android/issues/events{/number}","events_url":"https://api.github.com/repos/hzsweers/android/events","assignees_url":"https://api.github.com/repos/hzsweers/android/assignees{/user}","branches_url":"https://api.github.com/repos/hzsweers/android/branches{/branch}","tags_url":"https://api.github.com/repos/hzsweers/android/tags","blobs_url":"https://api.github.com/repos/hzsweers/android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hzsweers/android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hzsweers/android/git/refs{/sha}","trees_url":"https://api.github.com/repos/hzsweers/android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hzsweers/android/statuses/{sha}","languages_url":"https://api.github.com/repos/hzsweers/android/languages","stargazers_url":"https://api.github.com/repos/hzsweers/android/stargazers","contributors_url":"https://api.github.com/repos/hzsweers/android/contributors","subscribers_url":"https://api.github.com/repos/hzsweers/android/subscribers","subscription_url":"https://api.github.com/repos/hzsweers/android/subscription","commits_url":"https://api.github.com/repos/hzsweers/android/commits{/sha}","git_commits_url":"https://api.github.com/repos/hzsweers/android/git/commits{/sha}","comments_url":"https://api.github.com/repos/hzsweers/android/comments{/number}","issue_comment_url":"https://api.github.com/repos/hzsweers/android/issues/comments/{number}","contents_url":"https://api.github.com/repos/hzsweers/android/contents/{+path}","compare_url":"https://api.github.com/repos/hzsweers/android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hzsweers/android/merges","archive_url":"https://api.github.com/repos/hzsweers/android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hzsweers/android/downloads","issues_url":"https://api.github.com/repos/hzsweers/android/issues{/number}","pulls_url":"https://api.github.com/repos/hzsweers/android/pulls{/number}","milestones_url":"https://api.github.com/repos/hzsweers/android/milestones{/number}","notifications_url":"https://api.github.com/repos/hzsweers/android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hzsweers/android/labels{/name}","releases_url":"https://api.github.com/repos/hzsweers/android/releases{/id}","created_at":"2014-12-28T05:48:06Z","updated_at":"2015-01-05T16:11:35Z","pushed_at":"2015-01-05T16:11:35Z","git_url":"git://github.com/hzsweers/android.git","ssh_url":"git@github.com:hzsweers/android.git","clone_url":"https://github.com/hzsweers/android.git","svn_url":"https://github.com/hzsweers/android","homepage":"https://play.google.com/store/apps/details?id=com.github.mobile","size":7179,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"179dfa48613919c391037d514a9450838422f735","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":2349728,"name":"android","full_name":"github/android","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/android","description":"GitHub Android App","fork":false,"url":"https://api.github.com/repos/github/android","forks_url":"https://api.github.com/repos/github/android/forks","keys_url":"https://api.github.com/repos/github/android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/android/teams","hooks_url":"https://api.github.com/repos/github/android/hooks","issue_events_url":"https://api.github.com/repos/github/android/issues/events{/number}","events_url":"https://api.github.com/repos/github/android/events","assignees_url":"https://api.github.com/repos/github/android/assignees{/user}","branches_url":"https://api.github.com/repos/github/android/branches{/branch}","tags_url":"https://api.github.com/repos/github/android/tags","blobs_url":"https://api.github.com/repos/github/android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/android/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/android/statuses/{sha}","languages_url":"https://api.github.com/repos/github/android/languages","stargazers_url":"https://api.github.com/repos/github/android/stargazers","contributors_url":"https://api.github.com/repos/github/android/contributors","subscribers_url":"https://api.github.com/repos/github/android/subscribers","subscription_url":"https://api.github.com/repos/github/android/subscription","commits_url":"https://api.github.com/repos/github/android/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/android/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/android/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/android/issues/comments/{number}","contents_url":"https://api.github.com/repos/github/android/contents/{+path}","compare_url":"https://api.github.com/repos/github/android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/android/merges","archive_url":"https://api.github.com/repos/github/android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/android/downloads","issues_url":"https://api.github.com/repos/github/android/issues{/number}","pulls_url":"https://api.github.com/repos/github/android/pulls{/number}","milestones_url":"https://api.github.com/repos/github/android/milestones{/number}","notifications_url":"https://api.github.com/repos/github/android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/android/labels{/name}","releases_url":"https://api.github.com/repos/github/android/releases{/id}","created_at":"2011-09-08T16:52:50Z","updated_at":"2015-01-06T23:10:49Z","pushed_at":"2015-01-07T01:59:40Z","git_url":"git://github.com/github/android.git","ssh_url":"git@github.com:github/android.git","clone_url":"https://github.com/github/android.git","svn_url":"https://github.com/github/android","homepage":"https://play.google.com/store/apps/details?id=com.github.mobile","size":13347,"stargazers_count":5365,"watchers_count":5365,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2607,"mirror_url":null,"open_issues_count":192,"forks":2607,"open_issues":192,"watchers":5365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/android/pulls/661"},"html":{"href":"https://github.com/github/android/pull/661"},"issue":{"href":"https://api.github.com/repos/github/android/issues/661"},"comments":{"href":"https://api.github.com/repos/github/android/issues/661/comments"},"review_comments":{"href":"https://api.github.com/repos/github/android/pulls/661/comments"},"review_comment":{"href":"https://api.github.com/repos/github/android/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/github/android/pulls/661/commits"},"statuses":{"href":"https://api.github.com/repos/github/android/statuses/4b7c2778e43a88d078435e9123006572dab9dc90"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fadils","id":6204776,"avatar_url":"https://avatars.githubusercontent.com/u/6204776?v=3","gravatar_id":"","url":"https://api.github.com/users/fadils","html_url":"https://github.com/fadils","followers_url":"https://api.github.com/users/fadils/followers","following_url":"https://api.github.com/users/fadils/following{/other_user}","gists_url":"https://api.github.com/users/fadils/gists{/gist_id}","starred_url":"https://api.github.com/users/fadils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fadils/subscriptions","organizations_url":"https://api.github.com/users/fadils/orgs","repos_url":"https://api.github.com/users/fadils/repos","events_url":"https://api.github.com/users/fadils/events{/privacy}","received_events_url":"https://api.github.com/users/fadils/received_events","type":"User","site_admin":false},"comments":26,"review_comments":8,"commits":11,"additions":987,"deletions":334,"changed_files":135}}