{"action":"created","issue":{"url":"https://api.github.com/repos/dimbleby/rust-c-ares/issues/10","labels_url":"https://api.github.com/repos/dimbleby/rust-c-ares/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/dimbleby/rust-c-ares/issues/10/comments","events_url":"https://api.github.com/repos/dimbleby/rust-c-ares/issues/10/events","html_url":"https://github.com/dimbleby/rust-c-ares/pull/10","id":95933281,"number":10,"title":"Add SRV queries","user":{"login":"CJTozer","id":3398193,"avatar_url":"https://avatars.githubusercontent.com/u/3398193?v=3","gravatar_id":"","url":"https://api.github.com/users/CJTozer","html_url":"https://github.com/CJTozer","followers_url":"https://api.github.com/users/CJTozer/followers","following_url":"https://api.github.com/users/CJTozer/following{/other_user}","gists_url":"https://api.github.com/users/CJTozer/gists{/gist_id}","starred_url":"https://api.github.com/users/CJTozer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJTozer/subscriptions","organizations_url":"https://api.github.com/users/CJTozer/orgs","repos_url":"https://api.github.com/users/CJTozer/repos","events_url":"https://api.github.com/users/CJTozer/events{/privacy}","received_events_url":"https://api.github.com/users/CJTozer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-19T17:17:21Z","updated_at":"2015-07-19T21:18:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dimbleby/rust-c-ares/pulls/10","html_url":"https://github.com/dimbleby/rust-c-ares/pull/10","diff_url":"https://github.com/dimbleby/rust-c-ares/pull/10.diff","patch_url":"https://github.com/dimbleby/rust-c-ares/pull/10.patch"},"body":"I've not actually made a successful query (something odd with my VM perhaps - the query works with dig), so might not actually work.  :)\r\n\r\nFeel free to hold on and I'll try on another machine to get a proper query."},"comment":{"url":"https://api.github.com/repos/dimbleby/rust-c-ares/issues/comments/122707660","html_url":"https://github.com/dimbleby/rust-c-ares/pull/10#issuecomment-122707660","issue_url":"https://api.github.com/repos/dimbleby/rust-c-ares/issues/10","id":122707660,"user":{"login":"dimbleby","id":875184,"avatar_url":"https://avatars.githubusercontent.com/u/875184?v=3","gravatar_id":"","url":"https://api.github.com/users/dimbleby","html_url":"https://github.com/dimbleby","followers_url":"https://api.github.com/users/dimbleby/followers","following_url":"https://api.github.com/users/dimbleby/following{/other_user}","gists_url":"https://api.github.com/users/dimbleby/gists{/gist_id}","starred_url":"https://api.github.com/users/dimbleby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimbleby/subscriptions","organizations_url":"https://api.github.com/users/dimbleby/orgs","repos_url":"https://api.github.com/users/dimbleby/repos","events_url":"https://api.github.com/users/dimbleby/events{/privacy}","received_events_url":"https://api.github.com/users/dimbleby/received_events","type":"User","site_admin":false},"created_at":"2015-07-19T21:18:44Z","updated_at":"2015-07-19T21:18:44Z","body":"Yeah, and also - sorry for pulling the rug out from under your feet - but I've just pushed another fairly substantial reorg which this ought to fit in with.\r\n\r\nI decided that it would be desirable to avoid the extra allocations of creating Vec, String etc for results and figured out that we could do this by having (say):\r\n\r\n- `AResult` carries around a pointer to the `hostent` or whatever that c-ares allocated for it\r\n- implement iterators on the `AResult`, which convert this into a Rusty-structure on demand\r\n- (when that Rusty structure contains strings, they should be &str rather than String)\r\n\r\nSo I was planning to do the same for SRV (and other) query types.\r\n\r\nGive me a shout tomorrow if this makes no sense, or you just want to complain about how hard I'm making it for you to help.\r\n\r\nOn the plus side, this change has been excellent Rust exercise - which is kind of the point..."}}