{"action":"created","issue":{"url":"https://api.github.com/repos/ElementsProject/elements/issues/55","labels_url":"https://api.github.com/repos/ElementsProject/elements/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/ElementsProject/elements/issues/55/comments","events_url":"https://api.github.com/repos/ElementsProject/elements/issues/55/events","html_url":"https://github.com/ElementsProject/elements/pull/55","id":109148304,"number":55,"title":"Add commandline flag to set genesis block script destination","user":{"login":"apoelstra","id":1351933,"avatar_url":"https://avatars.githubusercontent.com/u/1351933?v=3","gravatar_id":"","url":"https://api.github.com/users/apoelstra","html_url":"https://github.com/apoelstra","followers_url":"https://api.github.com/users/apoelstra/followers","following_url":"https://api.github.com/users/apoelstra/following{/other_user}","gists_url":"https://api.github.com/users/apoelstra/gists{/gist_id}","starred_url":"https://api.github.com/users/apoelstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apoelstra/subscriptions","organizations_url":"https://api.github.com/users/apoelstra/orgs","repos_url":"https://api.github.com/users/apoelstra/repos","events_url":"https://api.github.com/users/apoelstra/events{/privacy}","received_events_url":"https://api.github.com/users/apoelstra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-09-30T18:10:45Z","updated_at":"2015-11-21T11:45:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ElementsProject/elements/pulls/55","html_url":"https://github.com/ElementsProject/elements/pull/55","diff_url":"https://github.com/ElementsProject/elements/pull/55.diff","patch_url":"https://github.com/ElementsProject/elements/pull/55.patch"},"body":"Fixes #54 "},"comment":{"url":"https://api.github.com/repos/ElementsProject/elements/issues/comments/158631987","html_url":"https://github.com/ElementsProject/elements/pull/55#issuecomment-158631987","issue_url":"https://api.github.com/repos/ElementsProject/elements/issues/55","id":158631987,"user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"created_at":"2015-11-21T11:45:53Z","updated_at":"2015-11-21T11:45:53Z","body":"If I understood it correctly, @gmaxwell 's nit was that I was making globalChainParams and globalSwitchingChainParams extern instead of static and it's already solved (but it would be nice if he can clarify whether his nit has been solved or not in https://github.com/bitcoin/bitcoin/pull/6907 ).\r\n\r\nAs said, I don't like the script being passed to SeelectParams(), the factory, nor the constructors and I would prefer ScriptDestinationFromCommandLine to be called directly within the constructors, but just a preference.\r\nI added a couple of minor nits though.\r\n\r\nThe overlapping PR/commits in Core are contained in https://github.com/jtimon/bitcoin/tree/alpha-base-0.12 which I will maintain rebased until 0.12 is forked and is what I would l would like @TheBlueMatt to use as a base when rebasing.\r\n"}}