{"action":"created","comment":{"url":"https://api.github.com/repos/arunoda/meteor-up/pulls/comments/23705400","id":23705400,"diff_hunk":"@@ -81,9 +81,7 @@ Actions.prototype.setup = function() {\n \n   for(var os in self.sessionsMap) {\n     var sessionsInfo = self.sessionsMap[os];\n-    var taskList = sessionsInfo.taskListsBuilder.setup(\n-      self.config.setupMongo, self.config.setupNode, self.config.nodeVersion,\n-      self.config.setupPhantom, self.config.appName);\n+    var taskList = sessionsInfo.taskListsBuilder.setup(self.config);","path":"lib/actions.js","position":7,"original_position":7,"commit_id":"c4f40f2cb4085194793737e8ecca7787ff71b2e8","original_commit_id":"c4f40f2cb4085194793737e8ecca7787ff71b2e8","user":{"login":"strikeout","id":1441025,"avatar_url":"https://avatars.githubusercontent.com/u/1441025?v=3","gravatar_id":"","url":"https://api.github.com/users/strikeout","html_url":"https://github.com/strikeout","followers_url":"https://api.github.com/users/strikeout/followers","following_url":"https://api.github.com/users/strikeout/following{/other_user}","gists_url":"https://api.github.com/users/strikeout/gists{/gist_id}","starred_url":"https://api.github.com/users/strikeout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strikeout/subscriptions","organizations_url":"https://api.github.com/users/strikeout/orgs","repos_url":"https://api.github.com/users/strikeout/repos","events_url":"https://api.github.com/users/strikeout/events{/privacy}","received_events_url":"https://api.github.com/users/strikeout/received_events","type":"User","site_admin":false},"body":"we just unify all args here","created_at":"2015-01-28T17:38:35Z","updated_at":"2015-01-28T17:38:35Z","html_url":"https://github.com/arunoda/meteor-up/pull/240#discussion_r23705400","pull_request_url":"https://api.github.com/repos/arunoda/meteor-up/pulls/240","_links":{"self":{"href":"https://api.github.com/repos/arunoda/meteor-up/pulls/comments/23705400"},"html":{"href":"https://github.com/arunoda/meteor-up/pull/240#discussion_r23705400"},"pull_request":{"href":"https://api.github.com/repos/arunoda/meteor-up/pulls/240"}}},"pull_request":{"url":"https://api.github.com/repos/arunoda/meteor-up/pulls/240","id":28212611,"html_url":"https://github.com/arunoda/meteor-up/pull/240","diff_url":"https://github.com/arunoda/meteor-up/pull/240.diff","patch_url":"https://github.com/arunoda/meteor-up/pull/240.patch","issue_url":"https://api.github.com/repos/arunoda/meteor-up/issues/240","number":240,"state":"open","locked":false,"title":"Fusion Passenger w/ Nginx build mode, autoscaling per CPU core","user":{"login":"strikeout","id":1441025,"avatar_url":"https://avatars.githubusercontent.com/u/1441025?v=3","gravatar_id":"","url":"https://api.github.com/users/strikeout","html_url":"https://github.com/strikeout","followers_url":"https://api.github.com/users/strikeout/followers","following_url":"https://api.github.com/users/strikeout/following{/other_user}","gists_url":"https://api.github.com/users/strikeout/gists{/gist_id}","starred_url":"https://api.github.com/users/strikeout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strikeout/subscriptions","organizations_url":"https://api.github.com/users/strikeout/orgs","repos_url":"https://api.github.com/users/strikeout/repos","events_url":"https://api.github.com/users/strikeout/events{/privacy}","received_events_url":"https://api.github.com/users/strikeout/received_events","type":"User","site_admin":false},"body":"Hi,\r\nI've integrated Fusion Passenger in Nginx mode as an OPTIONAL deployment mode - configurable via `mup.json`. \r\n\r\nAlso added a script to scale the app over all available CPU cores with passenger - so on an eight-core system we have by default eight apps - with a common database of course and a loadbalancing/static asset proxying Nginx with sticky sessions. \r\n\r\nWe do not need `forever` anymore because a request to Nginx triggers passenger which in turn is our process-manager that starts the app. \r\n\r\nThe setup is pretty cool and is tested on ubuntu/14.04, didn't care about solaris, but you're ditching it anyways :)\r\n\r\n","created_at":"2015-01-28T17:30:43Z","updated_at":"2015-01-28T17:38:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/arunoda/meteor-up/pulls/240/commits","review_comments_url":"https://api.github.com/repos/arunoda/meteor-up/pulls/240/comments","review_comment_url":"https://api.github.com/repos/arunoda/meteor-up/pulls/comments/{number}","comments_url":"https://api.github.com/repos/arunoda/meteor-up/issues/240/comments","statuses_url":"https://api.github.com/repos/arunoda/meteor-up/statuses/c4f40f2cb4085194793737e8ecca7787ff71b2e8","head":{"label":"strikeout:master","ref":"master","sha":"c4f40f2cb4085194793737e8ecca7787ff71b2e8","user":{"login":"strikeout","id":1441025,"avatar_url":"https://avatars.githubusercontent.com/u/1441025?v=3","gravatar_id":"","url":"https://api.github.com/users/strikeout","html_url":"https://github.com/strikeout","followers_url":"https://api.github.com/users/strikeout/followers","following_url":"https://api.github.com/users/strikeout/following{/other_user}","gists_url":"https://api.github.com/users/strikeout/gists{/gist_id}","starred_url":"https://api.github.com/users/strikeout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strikeout/subscriptions","organizations_url":"https://api.github.com/users/strikeout/orgs","repos_url":"https://api.github.com/users/strikeout/repos","events_url":"https://api.github.com/users/strikeout/events{/privacy}","received_events_url":"https://api.github.com/users/strikeout/received_events","type":"User","site_admin":false},"repo":{"id":29729468,"name":"meteor-up","full_name":"strikeout/meteor-up","owner":{"login":"strikeout","id":1441025,"avatar_url":"https://avatars.githubusercontent.com/u/1441025?v=3","gravatar_id":"","url":"https://api.github.com/users/strikeout","html_url":"https://github.com/strikeout","followers_url":"https://api.github.com/users/strikeout/followers","following_url":"https://api.github.com/users/strikeout/following{/other_user}","gists_url":"https://api.github.com/users/strikeout/gists{/gist_id}","starred_url":"https://api.github.com/users/strikeout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strikeout/subscriptions","organizations_url":"https://api.github.com/users/strikeout/orgs","repos_url":"https://api.github.com/users/strikeout/repos","events_url":"https://api.github.com/users/strikeout/events{/privacy}","received_events_url":"https://api.github.com/users/strikeout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/strikeout/meteor-up","description":"Production Quality Meteor Deployments","fork":true,"url":"https://api.github.com/repos/strikeout/meteor-up","forks_url":"https://api.github.com/repos/strikeout/meteor-up/forks","keys_url":"https://api.github.com/repos/strikeout/meteor-up/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strikeout/meteor-up/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strikeout/meteor-up/teams","hooks_url":"https://api.github.com/repos/strikeout/meteor-up/hooks","issue_events_url":"https://api.github.com/repos/strikeout/meteor-up/issues/events{/number}","events_url":"https://api.github.com/repos/strikeout/meteor-up/events","assignees_url":"https://api.github.com/repos/strikeout/meteor-up/assignees{/user}","branches_url":"https://api.github.com/repos/strikeout/meteor-up/branches{/branch}","tags_url":"https://api.github.com/repos/strikeout/meteor-up/tags","blobs_url":"https://api.github.com/repos/strikeout/meteor-up/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strikeout/meteor-up/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strikeout/meteor-up/git/refs{/sha}","trees_url":"https://api.github.com/repos/strikeout/meteor-up/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strikeout/meteor-up/statuses/{sha}","languages_url":"https://api.github.com/repos/strikeout/meteor-up/languages","stargazers_url":"https://api.github.com/repos/strikeout/meteor-up/stargazers","contributors_url":"https://api.github.com/repos/strikeout/meteor-up/contributors","subscribers_url":"https://api.github.com/repos/strikeout/meteor-up/subscribers","subscription_url":"https://api.github.com/repos/strikeout/meteor-up/subscription","commits_url":"https://api.github.com/repos/strikeout/meteor-up/commits{/sha}","git_commits_url":"https://api.github.com/repos/strikeout/meteor-up/git/commits{/sha}","comments_url":"https://api.github.com/repos/strikeout/meteor-up/comments{/number}","issue_comment_url":"https://api.github.com/repos/strikeout/meteor-up/issues/comments/{number}","contents_url":"https://api.github.com/repos/strikeout/meteor-up/contents/{+path}","compare_url":"https://api.github.com/repos/strikeout/meteor-up/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strikeout/meteor-up/merges","archive_url":"https://api.github.com/repos/strikeout/meteor-up/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strikeout/meteor-up/downloads","issues_url":"https://api.github.com/repos/strikeout/meteor-up/issues{/number}","pulls_url":"https://api.github.com/repos/strikeout/meteor-up/pulls{/number}","milestones_url":"https://api.github.com/repos/strikeout/meteor-up/milestones{/number}","notifications_url":"https://api.github.com/repos/strikeout/meteor-up/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strikeout/meteor-up/labels{/name}","releases_url":"https://api.github.com/repos/strikeout/meteor-up/releases{/id}","created_at":"2015-01-23T11:14:32Z","updated_at":"2015-01-28T16:08:00Z","pushed_at":"2015-01-28T16:07:59Z","git_url":"git://github.com/strikeout/meteor-up.git","ssh_url":"git@github.com:strikeout/meteor-up.git","clone_url":"https://github.com/strikeout/meteor-up.git","svn_url":"https://github.com/strikeout/meteor-up","homepage":null,"size":275,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arunoda:master","ref":"master","sha":"d13a6a5df244dbaac7e674df1b8df0859292b556","user":{"login":"arunoda","id":50838,"avatar_url":"https://avatars.githubusercontent.com/u/50838?v=3","gravatar_id":"","url":"https://api.github.com/users/arunoda","html_url":"https://github.com/arunoda","followers_url":"https://api.github.com/users/arunoda/followers","following_url":"https://api.github.com/users/arunoda/following{/other_user}","gists_url":"https://api.github.com/users/arunoda/gists{/gist_id}","starred_url":"https://api.github.com/users/arunoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunoda/subscriptions","organizations_url":"https://api.github.com/users/arunoda/orgs","repos_url":"https://api.github.com/users/arunoda/repos","events_url":"https://api.github.com/users/arunoda/events{/privacy}","received_events_url":"https://api.github.com/users/arunoda/received_events","type":"User","site_admin":false},"repo":{"id":14614459,"name":"meteor-up","full_name":"arunoda/meteor-up","owner":{"login":"arunoda","id":50838,"avatar_url":"https://avatars.githubusercontent.com/u/50838?v=3","gravatar_id":"","url":"https://api.github.com/users/arunoda","html_url":"https://github.com/arunoda","followers_url":"https://api.github.com/users/arunoda/followers","following_url":"https://api.github.com/users/arunoda/following{/other_user}","gists_url":"https://api.github.com/users/arunoda/gists{/gist_id}","starred_url":"https://api.github.com/users/arunoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunoda/subscriptions","organizations_url":"https://api.github.com/users/arunoda/orgs","repos_url":"https://api.github.com/users/arunoda/repos","events_url":"https://api.github.com/users/arunoda/events{/privacy}","received_events_url":"https://api.github.com/users/arunoda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arunoda/meteor-up","description":"Production Quality Meteor Deployments","fork":false,"url":"https://api.github.com/repos/arunoda/meteor-up","forks_url":"https://api.github.com/repos/arunoda/meteor-up/forks","keys_url":"https://api.github.com/repos/arunoda/meteor-up/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arunoda/meteor-up/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arunoda/meteor-up/teams","hooks_url":"https://api.github.com/repos/arunoda/meteor-up/hooks","issue_events_url":"https://api.github.com/repos/arunoda/meteor-up/issues/events{/number}","events_url":"https://api.github.com/repos/arunoda/meteor-up/events","assignees_url":"https://api.github.com/repos/arunoda/meteor-up/assignees{/user}","branches_url":"https://api.github.com/repos/arunoda/meteor-up/branches{/branch}","tags_url":"https://api.github.com/repos/arunoda/meteor-up/tags","blobs_url":"https://api.github.com/repos/arunoda/meteor-up/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arunoda/meteor-up/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arunoda/meteor-up/git/refs{/sha}","trees_url":"https://api.github.com/repos/arunoda/meteor-up/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arunoda/meteor-up/statuses/{sha}","languages_url":"https://api.github.com/repos/arunoda/meteor-up/languages","stargazers_url":"https://api.github.com/repos/arunoda/meteor-up/stargazers","contributors_url":"https://api.github.com/repos/arunoda/meteor-up/contributors","subscribers_url":"https://api.github.com/repos/arunoda/meteor-up/subscribers","subscription_url":"https://api.github.com/repos/arunoda/meteor-up/subscription","commits_url":"https://api.github.com/repos/arunoda/meteor-up/commits{/sha}","git_commits_url":"https://api.github.com/repos/arunoda/meteor-up/git/commits{/sha}","comments_url":"https://api.github.com/repos/arunoda/meteor-up/comments{/number}","issue_comment_url":"https://api.github.com/repos/arunoda/meteor-up/issues/comments/{number}","contents_url":"https://api.github.com/repos/arunoda/meteor-up/contents/{+path}","compare_url":"https://api.github.com/repos/arunoda/meteor-up/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arunoda/meteor-up/merges","archive_url":"https://api.github.com/repos/arunoda/meteor-up/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arunoda/meteor-up/downloads","issues_url":"https://api.github.com/repos/arunoda/meteor-up/issues{/number}","pulls_url":"https://api.github.com/repos/arunoda/meteor-up/pulls{/number}","milestones_url":"https://api.github.com/repos/arunoda/meteor-up/milestones{/number}","notifications_url":"https://api.github.com/repos/arunoda/meteor-up/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arunoda/meteor-up/labels{/name}","releases_url":"https://api.github.com/repos/arunoda/meteor-up/releases{/id}","created_at":"2013-11-22T10:05:50Z","updated_at":"2015-01-28T10:20:20Z","pushed_at":"2015-01-28T10:20:20Z","git_url":"git://github.com/arunoda/meteor-up.git","ssh_url":"git@github.com:arunoda/meteor-up.git","clone_url":"https://github.com/arunoda/meteor-up.git","svn_url":"https://github.com/arunoda/meteor-up","homepage":null,"size":1067,"stargazers_count":742,"watchers_count":742,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":107,"forks":94,"open_issues":107,"watchers":742,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arunoda/meteor-up/pulls/240"},"html":{"href":"https://github.com/arunoda/meteor-up/pull/240"},"issue":{"href":"https://api.github.com/repos/arunoda/meteor-up/issues/240"},"comments":{"href":"https://api.github.com/repos/arunoda/meteor-up/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/arunoda/meteor-up/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/arunoda/meteor-up/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/arunoda/meteor-up/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/arunoda/meteor-up/statuses/c4f40f2cb4085194793737e8ecca7787ff71b2e8"}}}}