{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/41770192","id":41770192,"diff_hunk":"@@ -85,7 +85,7 @@\n     when: etcd_server_certs_missing\n   roles:\n   - etcd\n-  - role: nickhammond.logrotate\n+  - { role: nickhammond.logrotate, when: not is_atomic }","path":"playbooks/common/openshift-etcd/config.yml","position":5,"original_position":5,"commit_id":"6782d0738603d764ab32aadf72fc1181e67d648c","original_commit_id":"6782d0738603d764ab32aadf72fc1181e67d648c","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"Just a stylistic concern, but this should be:\r\n```\r\n  - role: nickhammond.logrotate\r\n    when: not is_atomic\r\n```","created_at":"2015-10-12T15:46:05Z","updated_at":"2015-10-12T15:46:05Z","html_url":"https://github.com/openshift/openshift-ansible/pull/620#discussion_r41770192","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/620","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/41770192"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/620#discussion_r41770192"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/620"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/620","id":46100552,"html_url":"https://github.com/openshift/openshift-ansible/pull/620","diff_url":"https://github.com/openshift/openshift-ansible/pull/620.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/620.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/620","number":620,"state":"open","locked":false,"title":"WIP: openshift in docker","user":{"login":"ibotty","id":296430,"avatar_url":"https://avatars.githubusercontent.com/u/296430?v=3","gravatar_id":"","url":"https://api.github.com/users/ibotty","html_url":"https://github.com/ibotty","followers_url":"https://api.github.com/users/ibotty/followers","following_url":"https://api.github.com/users/ibotty/following{/other_user}","gists_url":"https://api.github.com/users/ibotty/gists{/gist_id}","starred_url":"https://api.github.com/users/ibotty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibotty/subscriptions","organizations_url":"https://api.github.com/users/ibotty/orgs","repos_url":"https://api.github.com/users/ibotty/repos","events_url":"https://api.github.com/users/ibotty/events{/privacy}","received_events_url":"https://api.github.com/users/ibotty/received_events","type":"User","site_admin":false},"body":"It works on my machine (tm).\r\n\r\nI've only tested with origin (not openshift or enterprise), I don't know how applicable the others are.\r\n\r\nNot working:\r\n * openshift sdn\r\n * logrotate\r\n * master ha\r\n * fluentd\r\n\r\nPain points as comments on the diff below.","created_at":"2015-09-27T12:47:57Z","updated_at":"2015-10-12T15:46:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01021f3b2f5583d25af2b794f01b6cf0c42e4cb9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/620/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/620/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/620/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/6782d0738603d764ab32aadf72fc1181e67d648c","head":{"label":"ibotty:master","ref":"master","sha":"6782d0738603d764ab32aadf72fc1181e67d648c","user":{"login":"ibotty","id":296430,"avatar_url":"https://avatars.githubusercontent.com/u/296430?v=3","gravatar_id":"","url":"https://api.github.com/users/ibotty","html_url":"https://github.com/ibotty","followers_url":"https://api.github.com/users/ibotty/followers","following_url":"https://api.github.com/users/ibotty/following{/other_user}","gists_url":"https://api.github.com/users/ibotty/gists{/gist_id}","starred_url":"https://api.github.com/users/ibotty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibotty/subscriptions","organizations_url":"https://api.github.com/users/ibotty/orgs","repos_url":"https://api.github.com/users/ibotty/repos","events_url":"https://api.github.com/users/ibotty/events{/privacy}","received_events_url":"https://api.github.com/users/ibotty/received_events","type":"User","site_admin":false},"repo":{"id":43001892,"name":"openshift-ansible","full_name":"ibotty/openshift-ansible","owner":{"login":"ibotty","id":296430,"avatar_url":"https://avatars.githubusercontent.com/u/296430?v=3","gravatar_id":"","url":"https://api.github.com/users/ibotty","html_url":"https://github.com/ibotty","followers_url":"https://api.github.com/users/ibotty/followers","following_url":"https://api.github.com/users/ibotty/following{/other_user}","gists_url":"https://api.github.com/users/ibotty/gists{/gist_id}","starred_url":"https://api.github.com/users/ibotty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibotty/subscriptions","organizations_url":"https://api.github.com/users/ibotty/orgs","repos_url":"https://api.github.com/users/ibotty/repos","events_url":"https://api.github.com/users/ibotty/events{/privacy}","received_events_url":"https://api.github.com/users/ibotty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibotty/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/ibotty/openshift-ansible","forks_url":"https://api.github.com/repos/ibotty/openshift-ansible/forks","keys_url":"https://api.github.com/repos/ibotty/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibotty/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibotty/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/ibotty/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/ibotty/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ibotty/openshift-ansible/events","assignees_url":"https://api.github.com/repos/ibotty/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ibotty/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ibotty/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/ibotty/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibotty/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibotty/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibotty/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibotty/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ibotty/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/ibotty/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/ibotty/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/ibotty/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/ibotty/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/ibotty/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibotty/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibotty/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibotty/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibotty/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ibotty/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibotty/openshift-ansible/merges","archive_url":"https://api.github.com/repos/ibotty/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibotty/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/ibotty/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ibotty/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ibotty/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ibotty/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibotty/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ibotty/openshift-ansible/releases{/id}","created_at":"2015-09-23T13:15:59Z","updated_at":"2015-09-23T13:16:00Z","pushed_at":"2015-10-07T07:45:55Z","git_url":"git://github.com/ibotty/openshift-ansible.git","ssh_url":"git@github.com:ibotty/openshift-ansible.git","clone_url":"https://github.com/ibotty/openshift-ansible.git","svn_url":"https://github.com/ibotty/openshift-ansible","homepage":"","size":1525,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"071eee9acb80621919dda2a07f9fe9c56dcfda27","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","created_at":"2014-09-16T17:07:51Z","updated_at":"2015-10-11T15:57:05Z","pushed_at":"2015-10-11T18:45:59Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"","size":5409,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":132,"forks":134,"open_issues":132,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/620"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/620"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/620"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/620/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/620/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/620/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/6782d0738603d764ab32aadf72fc1181e67d648c"}}}}