{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/29685456","id":29685456,"diff_hunk":"@@ -472,16 +482,29 @@ void fib_deinit(void)\n     mutex_unlock(&mtx_access);\n }\n \n-void fib_register_rrp(void)\n+int fib_register_rrp(uint8_t *prefix, size_t prefix_size)\n {\n     mutex_lock(&mtx_access);\n \n+    if (notify_rrp_pos >= FIB_MAX_RRP) {\n+        mutex_unlock(&mtx_access);\n+        return -ENOMEM;\n+    }\n+\n+    if ((prefix == NULL) || (prefix_size == 0)) {","path":"sys/net/network_layer/fib/fib.c","position":78,"original_position":78,"commit_id":"deb14d6123333eb4121dc97e2d0793c1c9ac1ccc","original_commit_id":"deb14d6123333eb4121dc97e2d0793c1c9ac1ccc","user":{"login":"Lotterleben","id":581552,"avatar_url":"https://avatars.githubusercontent.com/u/581552?v=3","gravatar_id":"","url":"https://api.github.com/users/Lotterleben","html_url":"https://github.com/Lotterleben","followers_url":"https://api.github.com/users/Lotterleben/followers","following_url":"https://api.github.com/users/Lotterleben/following{/other_user}","gists_url":"https://api.github.com/users/Lotterleben/gists{/gist_id}","starred_url":"https://api.github.com/users/Lotterleben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lotterleben/subscriptions","organizations_url":"https://api.github.com/users/Lotterleben/orgs","repos_url":"https://api.github.com/users/Lotterleben/repos","events_url":"https://api.github.com/users/Lotterleben/events{/privacy}","received_events_url":"https://api.github.com/users/Lotterleben/received_events","type":"User","site_admin":false},"body":"Makes sense. Other than the first comment, I have no other quibbles.. ACK when the 1st comment is addressed and travis is happy :)","created_at":"2015-05-05T16:20:29Z","updated_at":"2015-05-05T16:20:29Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/2915#discussion_r29685456","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2915","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/29685456"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/2915#discussion_r29685456"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2915"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2915","id":34701397,"html_url":"https://github.com/RIOT-OS/RIOT/pull/2915","diff_url":"https://github.com/RIOT-OS/RIOT/pull/2915.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/2915.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2915","number":2915,"state":"open","locked":false,"title":"net/network_layer/fib: added prefix consideration for RRP registration/signaling","user":{"login":"BytesGalore","id":3903215,"avatar_url":"https://avatars.githubusercontent.com/u/3903215?v=3","gravatar_id":"","url":"https://api.github.com/users/BytesGalore","html_url":"https://github.com/BytesGalore","followers_url":"https://api.github.com/users/BytesGalore/followers","following_url":"https://api.github.com/users/BytesGalore/following{/other_user}","gists_url":"https://api.github.com/users/BytesGalore/gists{/gist_id}","starred_url":"https://api.github.com/users/BytesGalore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BytesGalore/subscriptions","organizations_url":"https://api.github.com/users/BytesGalore/orgs","repos_url":"https://api.github.com/users/BytesGalore/repos","events_url":"https://api.github.com/users/BytesGalore/events{/privacy}","received_events_url":"https://api.github.com/users/BytesGalore/received_events","type":"User","site_admin":false},"body":"This PR forces to provide a prefix on register Reactive Routing Protocol (RRP), which is used to determine if the RRP can find a route to a searched destination address.\r\n \r\nRationale: \r\nThe current FIB does not consider a prefix per RRP registration.\r\nThis way all registered RRPs are signalled to start a route discovery for a given destination address without a check if the RRP can handle the prefix for the given destination.\r\n\r\n\r\n ","created_at":"2015-05-05T07:33:17Z","updated_at":"2015-05-05T16:20:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb3fd76dafc91c568b6a665266f2452c1cf0fb2f","assignee":{"login":"Lotterleben","id":581552,"avatar_url":"https://avatars.githubusercontent.com/u/581552?v=3","gravatar_id":"","url":"https://api.github.com/users/Lotterleben","html_url":"https://github.com/Lotterleben","followers_url":"https://api.github.com/users/Lotterleben/followers","following_url":"https://api.github.com/users/Lotterleben/following{/other_user}","gists_url":"https://api.github.com/users/Lotterleben/gists{/gist_id}","starred_url":"https://api.github.com/users/Lotterleben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lotterleben/subscriptions","organizations_url":"https://api.github.com/users/Lotterleben/orgs","repos_url":"https://api.github.com/users/Lotterleben/repos","events_url":"https://api.github.com/users/Lotterleben/events{/privacy}","received_events_url":"https://api.github.com/users/Lotterleben/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/11","html_url":"https://github.com/RIOT-OS/RIOT/milestones/Network%20Stack%20Task%20Force","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/11/labels","id":968921,"number":11,"title":"Network Stack Task Force","description":"The goal of this milestone is to implement the redesign of the network stack.\r\n\r\nTodo list at #2278.","creator":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":101,"state":"open","created_at":"2015-02-06T16:04:53Z","updated_at":"2015-05-05T07:33:17Z","due_on":"2015-04-29T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2915/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2915/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2915/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/deb14d6123333eb4121dc97e2d0793c1c9ac1ccc","head":{"label":"BytesGalore:fib_register_rrp_with_prefix","ref":"fib_register_rrp_with_prefix","sha":"deb14d6123333eb4121dc97e2d0793c1c9ac1ccc","user":{"login":"BytesGalore","id":3903215,"avatar_url":"https://avatars.githubusercontent.com/u/3903215?v=3","gravatar_id":"","url":"https://api.github.com/users/BytesGalore","html_url":"https://github.com/BytesGalore","followers_url":"https://api.github.com/users/BytesGalore/followers","following_url":"https://api.github.com/users/BytesGalore/following{/other_user}","gists_url":"https://api.github.com/users/BytesGalore/gists{/gist_id}","starred_url":"https://api.github.com/users/BytesGalore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BytesGalore/subscriptions","organizations_url":"https://api.github.com/users/BytesGalore/orgs","repos_url":"https://api.github.com/users/BytesGalore/repos","events_url":"https://api.github.com/users/BytesGalore/events{/privacy}","received_events_url":"https://api.github.com/users/BytesGalore/received_events","type":"User","site_admin":false},"repo":{"id":12703228,"name":"RIOT","full_name":"BytesGalore/RIOT","owner":{"login":"BytesGalore","id":3903215,"avatar_url":"https://avatars.githubusercontent.com/u/3903215?v=3","gravatar_id":"","url":"https://api.github.com/users/BytesGalore","html_url":"https://github.com/BytesGalore","followers_url":"https://api.github.com/users/BytesGalore/followers","following_url":"https://api.github.com/users/BytesGalore/following{/other_user}","gists_url":"https://api.github.com/users/BytesGalore/gists{/gist_id}","starred_url":"https://api.github.com/users/BytesGalore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BytesGalore/subscriptions","organizations_url":"https://api.github.com/users/BytesGalore/orgs","repos_url":"https://api.github.com/users/BytesGalore/repos","events_url":"https://api.github.com/users/BytesGalore/events{/privacy}","received_events_url":"https://api.github.com/users/BytesGalore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BytesGalore/RIOT","description":"RIOT OS -  The revolutionary IoT OS","fork":true,"url":"https://api.github.com/repos/BytesGalore/RIOT","forks_url":"https://api.github.com/repos/BytesGalore/RIOT/forks","keys_url":"https://api.github.com/repos/BytesGalore/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BytesGalore/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BytesGalore/RIOT/teams","hooks_url":"https://api.github.com/repos/BytesGalore/RIOT/hooks","issue_events_url":"https://api.github.com/repos/BytesGalore/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/BytesGalore/RIOT/events","assignees_url":"https://api.github.com/repos/BytesGalore/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/BytesGalore/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/BytesGalore/RIOT/tags","blobs_url":"https://api.github.com/repos/BytesGalore/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BytesGalore/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BytesGalore/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/BytesGalore/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BytesGalore/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/BytesGalore/RIOT/languages","stargazers_url":"https://api.github.com/repos/BytesGalore/RIOT/stargazers","contributors_url":"https://api.github.com/repos/BytesGalore/RIOT/contributors","subscribers_url":"https://api.github.com/repos/BytesGalore/RIOT/subscribers","subscription_url":"https://api.github.com/repos/BytesGalore/RIOT/subscription","commits_url":"https://api.github.com/repos/BytesGalore/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/BytesGalore/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/BytesGalore/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/BytesGalore/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/BytesGalore/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/BytesGalore/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BytesGalore/RIOT/merges","archive_url":"https://api.github.com/repos/BytesGalore/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BytesGalore/RIOT/downloads","issues_url":"https://api.github.com/repos/BytesGalore/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/BytesGalore/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/BytesGalore/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/BytesGalore/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BytesGalore/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/BytesGalore/RIOT/releases{/id}","created_at":"2013-09-09T14:15:30Z","updated_at":"2015-05-05T06:30:13Z","pushed_at":"2015-05-05T07:25:12Z","git_url":"git://github.com/BytesGalore/RIOT.git","ssh_url":"git@github.com:BytesGalore/RIOT.git","clone_url":"https://github.com/BytesGalore/RIOT.git","svn_url":"https://github.com/BytesGalore/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":17822,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"196689328f66618a1381cd742617539d9c0db2e0","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2015-05-04T15:55:44Z","pushed_at":"2015-05-05T13:21:37Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":107314,"stargazers_count":349,"watchers_count":349,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":285,"mirror_url":null,"open_issues_count":311,"forks":285,"open_issues":311,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2915"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/2915"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2915"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/2915/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2915/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/2915/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/deb14d6123333eb4121dc97e2d0793c1c9ac1ccc"}}}}