{"action":"created","comment":{"url":"https://api.github.com/repos/campagnola/vispy/pulls/comments/33306887","id":33306887,"diff_hunk":"@@ -38,17 +39,40 @@ class PolygonVisual(Visual):\n     \"\"\"\n     def __init__(self, pos=None, color='black',\n                  border_color=None, border_width=1, **kwargs):\n-        super(PolygonVisual, self).__init__(**kwargs)\n-\n-        self.mesh = MeshVisual()\n-        self.border = LineVisual()\n+        self._mesh = MeshVisual()\n+        self._border = LineVisual()\n         self._pos = pos\n         self._color = Color(color)\n         self._border_width = border_width\n         self._border_color = Color(border_color)\n+\n         self._update()\n-        #glopts = kwargs.pop('gl_options', 'translucent')\n-        #self.set_gl_options(glopts)\n+        CompoundVisual.__init__(self, [self._mesh, self._border], **kwargs)\n+        self._mesh.set_gl_state(polygon_offset_fill=True,","path":"vispy/visuals/polygon.py","position":44,"original_position":44,"commit_id":"727b0cdac8b17a5e1a4504bdada79e5672a85d6a","original_commit_id":"727b0cdac8b17a5e1a4504bdada79e5672a85d6a","user":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"body":"ah, I made my comment before reading yours :)\r\n\r\nSo, the bug is (if I understand correctly), the offset will be applied to _both_ the line and the mesh when drawn with AGG thereby nullifying the entire point of the offset?\r\n\r\n","created_at":"2015-06-25T21:23:45Z","updated_at":"2015-06-25T21:23:45Z","html_url":"https://github.com/campagnola/vispy/pull/2#discussion_r33306887","pull_request_url":"https://api.github.com/repos/campagnola/vispy/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/comments/33306887"},"html":{"href":"https://github.com/campagnola/vispy/pull/2#discussion_r33306887"},"pull_request":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/campagnola/vispy/pulls/2","id":37763827,"html_url":"https://github.com/campagnola/vispy/pull/2","diff_url":"https://github.com/campagnola/vispy/pull/2.diff","patch_url":"https://github.com/campagnola/vispy/pull/2.patch","issue_url":"https://api.github.com/repos/campagnola/vispy/issues/2","number":2,"state":"open","locked":false,"title":"[WIP] Visuals Port on new Visual system","user":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"body":"This will contain a list of all visuals that are to be ported.\r\n\r\nCross linking to https://github.com/vispy/vispy/pull/928 (Scenegraph overhaul) for context and easy access\r\n\r\n#### 2d visuals\r\n\r\n- [x] Ellipse\r\n- [x] Polygon\r\n- [x] Rectangle\r\n- [x] RegularPolygon\r\n- [x] LinePlot\r\n- [x] Markers\r\n- [ ] Axis\r\n- [ ] AGG for Line (?)\r\n\r\n#### 3d visuals\r\n - [x] Cube\r\n - [x] Mesh","created_at":"2015-06-16T06:40:40Z","updated_at":"2015-06-25T21:23:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb236fe09b26f6eb9b77a69ba4f8808c9e333bc4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/campagnola/vispy/pulls/2/commits","review_comments_url":"https://api.github.com/repos/campagnola/vispy/pulls/2/comments","review_comment_url":"https://api.github.com/repos/campagnola/vispy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/campagnola/vispy/issues/2/comments","statuses_url":"https://api.github.com/repos/campagnola/vispy/statuses/727b0cdac8b17a5e1a4504bdada79e5672a85d6a","head":{"label":"bollu:scenegraph-polygonvisual","ref":"scenegraph-polygonvisual","sha":"727b0cdac8b17a5e1a4504bdada79e5672a85d6a","user":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"repo":{"id":31825193,"name":"vispy","full_name":"bollu/vispy","owner":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bollu/vispy","description":"Main repository for Vispy","fork":true,"url":"https://api.github.com/repos/bollu/vispy","forks_url":"https://api.github.com/repos/bollu/vispy/forks","keys_url":"https://api.github.com/repos/bollu/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bollu/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bollu/vispy/teams","hooks_url":"https://api.github.com/repos/bollu/vispy/hooks","issue_events_url":"https://api.github.com/repos/bollu/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/bollu/vispy/events","assignees_url":"https://api.github.com/repos/bollu/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/bollu/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/bollu/vispy/tags","blobs_url":"https://api.github.com/repos/bollu/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bollu/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bollu/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/bollu/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bollu/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/bollu/vispy/languages","stargazers_url":"https://api.github.com/repos/bollu/vispy/stargazers","contributors_url":"https://api.github.com/repos/bollu/vispy/contributors","subscribers_url":"https://api.github.com/repos/bollu/vispy/subscribers","subscription_url":"https://api.github.com/repos/bollu/vispy/subscription","commits_url":"https://api.github.com/repos/bollu/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/bollu/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/bollu/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/bollu/vispy/issues/comments{/number}","contents_url":"https://api.github.com/repos/bollu/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/bollu/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bollu/vispy/merges","archive_url":"https://api.github.com/repos/bollu/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bollu/vispy/downloads","issues_url":"https://api.github.com/repos/bollu/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/bollu/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/bollu/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/bollu/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bollu/vispy/labels{/name}","releases_url":"https://api.github.com/repos/bollu/vispy/releases{/id}","created_at":"2015-03-07T19:53:28Z","updated_at":"2015-03-07T19:53:30Z","pushed_at":"2015-06-25T21:00:03Z","git_url":"git://github.com/bollu/vispy.git","ssh_url":"git@github.com:bollu/vispy.git","clone_url":"https://github.com/bollu/vispy.git","svn_url":"https://github.com/bollu/vispy","homepage":"http://vispy.org","size":9312,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"campagnola:scenegraph-update","ref":"scenegraph-update","sha":"652d04ab7c005a8643fab62170fb1d96a717607f","user":{"login":"campagnola","id":940580,"avatar_url":"https://avatars.githubusercontent.com/u/940580?v=3","gravatar_id":"","url":"https://api.github.com/users/campagnola","html_url":"https://github.com/campagnola","followers_url":"https://api.github.com/users/campagnola/followers","following_url":"https://api.github.com/users/campagnola/following{/other_user}","gists_url":"https://api.github.com/users/campagnola/gists{/gist_id}","starred_url":"https://api.github.com/users/campagnola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campagnola/subscriptions","organizations_url":"https://api.github.com/users/campagnola/orgs","repos_url":"https://api.github.com/users/campagnola/repos","events_url":"https://api.github.com/users/campagnola/events{/privacy}","received_events_url":"https://api.github.com/users/campagnola/received_events","type":"User","site_admin":false},"repo":{"id":16300808,"name":"vispy","full_name":"campagnola/vispy","owner":{"login":"campagnola","id":940580,"avatar_url":"https://avatars.githubusercontent.com/u/940580?v=3","gravatar_id":"","url":"https://api.github.com/users/campagnola","html_url":"https://github.com/campagnola","followers_url":"https://api.github.com/users/campagnola/followers","following_url":"https://api.github.com/users/campagnola/following{/other_user}","gists_url":"https://api.github.com/users/campagnola/gists{/gist_id}","starred_url":"https://api.github.com/users/campagnola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campagnola/subscriptions","organizations_url":"https://api.github.com/users/campagnola/orgs","repos_url":"https://api.github.com/users/campagnola/repos","events_url":"https://api.github.com/users/campagnola/events{/privacy}","received_events_url":"https://api.github.com/users/campagnola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/campagnola/vispy","description":"Luke's vispy fork","fork":true,"url":"https://api.github.com/repos/campagnola/vispy","forks_url":"https://api.github.com/repos/campagnola/vispy/forks","keys_url":"https://api.github.com/repos/campagnola/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/campagnola/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/campagnola/vispy/teams","hooks_url":"https://api.github.com/repos/campagnola/vispy/hooks","issue_events_url":"https://api.github.com/repos/campagnola/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/campagnola/vispy/events","assignees_url":"https://api.github.com/repos/campagnola/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/campagnola/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/campagnola/vispy/tags","blobs_url":"https://api.github.com/repos/campagnola/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/campagnola/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/campagnola/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/campagnola/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/campagnola/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/campagnola/vispy/languages","stargazers_url":"https://api.github.com/repos/campagnola/vispy/stargazers","contributors_url":"https://api.github.com/repos/campagnola/vispy/contributors","subscribers_url":"https://api.github.com/repos/campagnola/vispy/subscribers","subscription_url":"https://api.github.com/repos/campagnola/vispy/subscription","commits_url":"https://api.github.com/repos/campagnola/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/campagnola/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/campagnola/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/campagnola/vispy/issues/comments{/number}","contents_url":"https://api.github.com/repos/campagnola/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/campagnola/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/campagnola/vispy/merges","archive_url":"https://api.github.com/repos/campagnola/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/campagnola/vispy/downloads","issues_url":"https://api.github.com/repos/campagnola/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/campagnola/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/campagnola/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/campagnola/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/campagnola/vispy/labels{/name}","releases_url":"https://api.github.com/repos/campagnola/vispy/releases{/id}","created_at":"2014-01-28T03:13:59Z","updated_at":"2015-03-26T00:43:14Z","pushed_at":"2015-06-25T21:00:03Z","git_url":"git://github.com/campagnola/vispy.git","ssh_url":"git@github.com:campagnola/vispy.git","clone_url":"https://github.com/campagnola/vispy.git","svn_url":"https://github.com/campagnola/vispy","homepage":"","size":10815,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/2"},"html":{"href":"https://github.com/campagnola/vispy/pull/2"},"issue":{"href":"https://api.github.com/repos/campagnola/vispy/issues/2"},"comments":{"href":"https://api.github.com/repos/campagnola/vispy/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/campagnola/vispy/statuses/727b0cdac8b17a5e1a4504bdada79e5672a85d6a"}}}}