{"action":"created","issue":{"url":"https://api.github.com/repos/Metaswitch/ellis/issues/148","labels_url":"https://api.github.com/repos/Metaswitch/ellis/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/Metaswitch/ellis/issues/148/comments","events_url":"https://api.github.com/repos/Metaswitch/ellis/issues/148/events","html_url":"https://github.com/Metaswitch/ellis/pull/148","id":118428763,"number":148,"title":"[Reviewer Andy] Improve prov-tools local_settings creation. Fixes #144","user":{"login":"Tom-Rees","id":12893820,"avatar_url":"https://avatars.githubusercontent.com/u/12893820?v=3","gravatar_id":"","url":"https://api.github.com/users/Tom-Rees","html_url":"https://github.com/Tom-Rees","followers_url":"https://api.github.com/users/Tom-Rees/followers","following_url":"https://api.github.com/users/Tom-Rees/following{/other_user}","gists_url":"https://api.github.com/users/Tom-Rees/gists{/gist_id}","starred_url":"https://api.github.com/users/Tom-Rees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tom-Rees/subscriptions","organizations_url":"https://api.github.com/users/Tom-Rees/orgs","repos_url":"https://api.github.com/users/Tom-Rees/repos","events_url":"https://api.github.com/users/Tom-Rees/events{/privacy}","received_events_url":"https://api.github.com/users/Tom-Rees/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bossmc","id":1073983,"avatar_url":"https://avatars.githubusercontent.com/u/1073983?v=3","gravatar_id":"","url":"https://api.github.com/users/bossmc","html_url":"https://github.com/bossmc","followers_url":"https://api.github.com/users/bossmc/followers","following_url":"https://api.github.com/users/bossmc/following{/other_user}","gists_url":"https://api.github.com/users/bossmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bossmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bossmc/subscriptions","organizations_url":"https://api.github.com/users/bossmc/orgs","repos_url":"https://api.github.com/users/bossmc/repos","events_url":"https://api.github.com/users/bossmc/events{/privacy}","received_events_url":"https://api.github.com/users/bossmc/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-11-23T17:20:26Z","updated_at":"2015-11-23T17:35:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Metaswitch/ellis/pulls/148","html_url":"https://github.com/Metaswitch/ellis/pull/148","diff_url":"https://github.com/Metaswitch/ellis/pull/148.diff","patch_url":"https://github.com/Metaswitch/ellis/pull/148.patch"},"body":"Hi Andy,\r\n\r\nThis is a proposed fix for #144. I've tested it on our test system. Please could you review?\r\n\r\nI am a little concerned that this change means that the 'local_settings' file is always created by this script and thus we will always overwrite the defaults in 'settings.py' such as 'XDM_URL=homer.cw-ngv.com:7888' with E.g. 'XDM_URL=MUST_BE_CONFIGURED' and so this change may have consequences that I've not considered.\r\n\r\nI think that making it clear when these values have not been configured manually is a good thing, but I don't know if you rely on the defaults currently in use. \r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Metaswitch/ellis/issues/comments/159005787","html_url":"https://github.com/Metaswitch/ellis/pull/148#issuecomment-159005787","issue_url":"https://api.github.com/repos/Metaswitch/ellis/issues/148","id":159005787,"user":{"login":"bossmc","id":1073983,"avatar_url":"https://avatars.githubusercontent.com/u/1073983?v=3","gravatar_id":"","url":"https://api.github.com/users/bossmc","html_url":"https://github.com/bossmc","followers_url":"https://api.github.com/users/bossmc/followers","following_url":"https://api.github.com/users/bossmc/following{/other_user}","gists_url":"https://api.github.com/users/bossmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bossmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bossmc/subscriptions","organizations_url":"https://api.github.com/users/bossmc/orgs","repos_url":"https://api.github.com/users/bossmc/repos","events_url":"https://api.github.com/users/bossmc/events{/privacy}","received_events_url":"https://api.github.com/users/bossmc/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T17:35:40Z","updated_at":"2015-11-23T17:35:40Z","body":"@mirw This one's yours."}}