{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/39263237","id":39263237,"diff_hunk":"@@ -155,6 +160,43 @@ require(\n \t\t\ttracker.track(trackingParams);\n \t\t}\n \n+\t\tfunction getWIYLRequestSentKey() {\n+\t\t\treturn 'wikiaInYourLangRequestSent' + retrieveLinkTitle() + cacheVersion;\n+\t\t}\n+\n+\t\tfunction getWIYLNotificationShownKey() {\n+\t\t\treturn 'wikiaInYourLangNotificationShown' + retrieveLinkTitle() + cacheVersion;\n+\t\t}\n+\n+\t\tfunction getWIYLMessageKey() {\n+\t\t\treturn targetLanguage + 'WikiaInYourLangMessage' + retrieveLinkTitle() + cacheVersion;\n+\t\t}\n+\n+\t\tfunction getWIYLLinkTitlesKey() {\n+\t\t\treturn targetLanguage + 'WikiaInYourLangLinkTitles' + cacheVersion;\n+\t\t}\n+\n+\t\tfunction saveLinkTitle(linkAddress) {\n+\t\t\tvar linkAddressAry = linkAddress.split('/'),\n+\t\t\t\tlistOfCachedTitles = '',\n+\t\t\t\tlinkTitle = linkAddressAry[linkAddressAry.length - 1].length === 0 ? 'main' : linkAddressAry[linkAddressAry.length - 1];\n+\n+\t\t\tlistOfCachedTitles = cache.get(getWIYLLinkTitlesKey());\n+\t\t\tif ( listOfCachedTitles ) {\n+\t\t\t\tlistOfCachedTitles[articleTitle] = linkTitle;\n+\t\t\t} else {\n+\t\t\t\tlistOfCachedTitles = {};\n+\t\t\t\tlistOfCachedTitles[articleTitle] = linkTitle;\n+\t\t\t}\n+\n+\t\t\tcache.set(getWIYLLinkTitlesKey(),listOfCachedTitles, cache.CACHE_LONG);\n+\t\t}\n+\n+\t\tfunction retrieveLinkTitle() {","path":"extensions/wikia/WikiaInYourLang/modules/ext.wikiaInYourLang.js","position":104,"original_position":104,"commit_id":"36652bbe14d67eeffb080006e065cce66d52a247","original_commit_id":"36652bbe14d67eeffb080006e065cce66d52a247","user":{"login":"hakubo","id":1018759,"avatar_url":"https://avatars.githubusercontent.com/u/1018759?v=3","gravatar_id":"","url":"https://api.github.com/users/hakubo","html_url":"https://github.com/hakubo","followers_url":"https://api.github.com/users/hakubo/followers","following_url":"https://api.github.com/users/hakubo/following{/other_user}","gists_url":"https://api.github.com/users/hakubo/gists{/gist_id}","starred_url":"https://api.github.com/users/hakubo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakubo/subscriptions","organizations_url":"https://api.github.com/users/hakubo/orgs","repos_url":"https://api.github.com/users/hakubo/repos","events_url":"https://api.github.com/users/hakubo/events{/privacy}","received_events_url":"https://api.github.com/users/hakubo/received_events","type":"User","site_admin":false},"body":"1. some excerpt of what you wrote could end up in JSDoc\r\n2. I know that you don't have to, but the smaller the scope of a variable the easier it is to reason when it gets changed and harder to introduce bugs. There are 172 lines of code between declaration and use. It's just easy to forget where this variable is coming from.","created_at":"2015-09-11T11:45:54Z","updated_at":"2015-09-11T11:45:54Z","html_url":"https://github.com/Wikia/app/pull/8248#discussion_r39263237","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/8248","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/39263237"},"html":{"href":"https://github.com/Wikia/app/pull/8248#discussion_r39263237"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/8248"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/8248","id":43520065,"html_url":"https://github.com/Wikia/app/pull/8248","diff_url":"https://github.com/Wikia/app/pull/8248.diff","patch_url":"https://github.com/Wikia/app/pull/8248.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/8248","number":8248,"state":"open","locked":false,"title":"INT-35: Wikia In Your Language for Article","user":{"login":"mari-mcmurtrie","id":12705267,"avatar_url":"https://avatars.githubusercontent.com/u/12705267?v=3","gravatar_id":"","url":"https://api.github.com/users/mari-mcmurtrie","html_url":"https://github.com/mari-mcmurtrie","followers_url":"https://api.github.com/users/mari-mcmurtrie/followers","following_url":"https://api.github.com/users/mari-mcmurtrie/following{/other_user}","gists_url":"https://api.github.com/users/mari-mcmurtrie/gists{/gist_id}","starred_url":"https://api.github.com/users/mari-mcmurtrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mari-mcmurtrie/subscriptions","organizations_url":"https://api.github.com/users/mari-mcmurtrie/orgs","repos_url":"https://api.github.com/users/mari-mcmurtrie/repos","events_url":"https://api.github.com/users/mari-mcmurtrie/events{/privacy}","received_events_url":"https://api.github.com/users/mari-mcmurtrie/received_events","type":"User","site_admin":false},"body":"If corresponding article page is available, link to the article page instead of link to a main page always.","created_at":"2015-08-27T13:58:04Z","updated_at":"2015-09-11T11:45:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"503df4785621698712ec021fc124a2d2927c6fa6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/8248/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/8248/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/8248/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/36652bbe14d67eeffb080006e065cce66d52a247","head":{"label":"Wikia:INT-35","ref":"INT-35","sha":"36652bbe14d67eeffb080006e065cce66d52a247","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-09-11T11:45:30Z","pushed_at":"2015-09-11T11:41:50Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1482030,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":69,"forks":66,"open_issues":69,"watchers":86,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"8ba4aa3a262c65a91146363ebcd71892a7744c65","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-09-11T11:45:30Z","pushed_at":"2015-09-11T11:41:50Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1482030,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":69,"forks":66,"open_issues":69,"watchers":86,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/8248"},"html":{"href":"https://github.com/Wikia/app/pull/8248"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/8248"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/8248/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/8248/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/8248/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/36652bbe14d67eeffb080006e065cce66d52a247"}}}}