{"action":"created","issue":{"url":"https://api.github.com/repos/joomla-extensions/install-from-web-client/issues/23","labels_url":"https://api.github.com/repos/joomla-extensions/install-from-web-client/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/joomla-extensions/install-from-web-client/issues/23/comments","events_url":"https://api.github.com/repos/joomla-extensions/install-from-web-client/issues/23/events","html_url":"https://github.com/joomla-extensions/install-from-web-client/pull/23","id":79866350,"number":23,"title":"UX improvements","user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-05-23T14:48:07Z","updated_at":"2015-06-01T02:35:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla-extensions/install-from-web-client/pulls/23","html_url":"https://github.com/joomla-extensions/install-from-web-client/pull/23","diff_url":"https://github.com/joomla-extensions/install-from-web-client/pull/23.diff","patch_url":"https://github.com/joomla-extensions/install-from-web-client/pull/23.patch"},"body":"#### Few improvements for better UX\r\n\r\nWhat is changed:\r\n1. Removed from the javascript all the static styling and put it in the relative css/class\r\n2. Added css class `body.ifw-busy` to prevent scrolling of the page\r\n3. Apply and remove the class `ifw-busy` when a request is made and an answer is received\r\n4. this PR also replaces #7 with the suggestion of @gunjanpatel! Thanks!\r\n\r\n#### Testing \r\nMake sure you have web installer installed!\r\nDownload and replace:\r\nplugins/installer/webinstaller/css/client.css\r\nplugins/installer/webinstaller/css/client.min.css\r\nplugins/installer/webinstaller/js/client.js\r\nplugins/installer/webinstaller/js/client.min.js\r\n\r\nWhenever you click on any link in the iframe you should see an overlay and a spinner\r\nTry to scroll when spinner is shown, (no scrolling should happen)\r\nTry to change tab when the spinner is shown (the new tab should show up correctly)\r\n\r\n#### Preview\r\n![screenshot 2015-05-23 17 16 56](https://cloud.githubusercontent.com/assets/3889375/7784599/d67be666-0173-11e5-8ba3-4d99b8f318ab.png)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/joomla-extensions/install-from-web-client/issues/comments/107286726","html_url":"https://github.com/joomla-extensions/install-from-web-client/pull/23#issuecomment-107286726","issue_url":"https://api.github.com/repos/joomla-extensions/install-from-web-client/issues/23","id":107286726,"user":{"login":"nicksavov","id":906943,"avatar_url":"https://avatars.githubusercontent.com/u/906943?v=3","gravatar_id":"","url":"https://api.github.com/users/nicksavov","html_url":"https://github.com/nicksavov","followers_url":"https://api.github.com/users/nicksavov/followers","following_url":"https://api.github.com/users/nicksavov/following{/other_user}","gists_url":"https://api.github.com/users/nicksavov/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksavov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksavov/subscriptions","organizations_url":"https://api.github.com/users/nicksavov/orgs","repos_url":"https://api.github.com/users/nicksavov/repos","events_url":"https://api.github.com/users/nicksavov/events{/privacy}","received_events_url":"https://api.github.com/users/nicksavov/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T02:35:29Z","updated_at":"2015-06-01T02:35:29Z","body":"@dgt41 , looks like there are some merge conflicts. Could you re-sync?"}}