{"action":"created","issue":{"url":"https://api.github.com/repos/dart-lang/pub/issues/377","labels_url":"https://api.github.com/repos/dart-lang/pub/issues/377/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/pub/issues/377/comments","events_url":"https://api.github.com/repos/dart-lang/pub/issues/377/events","html_url":"https://github.com/dart-lang/pub/issues/377","id":85642936,"number":377,"title":"Need tests for code that determines what files are published with a package","user":{"login":"DartBot","id":8958862,"avatar_url":"https://avatars.githubusercontent.com/u/8958862?v=3","gravatar_id":"","url":"https://api.github.com/users/DartBot","html_url":"https://github.com/DartBot","followers_url":"https://api.github.com/users/DartBot/followers","following_url":"https://api.github.com/users/DartBot/following{/other_user}","gists_url":"https://api.github.com/users/DartBot/gists{/gist_id}","starred_url":"https://api.github.com/users/DartBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DartBot/subscriptions","organizations_url":"https://api.github.com/users/DartBot/orgs","repos_url":"https://api.github.com/users/DartBot/repos","events_url":"https://api.github.com/users/DartBot/events{/privacy}","received_events_url":"https://api.github.com/users/DartBot/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dart-lang/pub/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/dart-lang/pub/labels/Fixed","name":"Fixed","color":"ededed"},{"url":"https://api.github.com/repos/dart-lang/pub/labels/Priority-Medium","name":"Priority-Medium","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"nex3","id":188,"avatar_url":"https://avatars.githubusercontent.com/u/188?v=3","gravatar_id":"","url":"https://api.github.com/users/nex3","html_url":"https://github.com/nex3","followers_url":"https://api.github.com/users/nex3/followers","following_url":"https://api.github.com/users/nex3/following{/other_user}","gists_url":"https://api.github.com/users/nex3/gists{/gist_id}","starred_url":"https://api.github.com/users/nex3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nex3/subscriptions","organizations_url":"https://api.github.com/users/nex3/orgs","repos_url":"https://api.github.com/users/nex3/repos","events_url":"https://api.github.com/users/nex3/events{/privacy}","received_events_url":"https://api.github.com/users/nex3/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-06-05T22:04:36Z","updated_at":"2015-06-05T22:04:36Z","closed_at":null,"body":"<a href=\"https://github.com/munificent\"><img src=\"https://avatars.githubusercontent.com/u/46275?v=3\" align=\"left\" width=\"96\" height=\"96\"hspace=\"10\"></img></a> **Issue by [munificent](https://github.com/munificent)**\n_Originally opened as dart-lang/sdk#7391_\n\n----\n\nThe code for getting the list of files to include in a package has a bunch of interesting corners related to symlinks, git, etc. We've seen a few issues there where it doesn't give us the files we expect, and we don't have good test coverage for it. We should. In particular:\n\n1. Make sure packages directories are excluded.\n2. Make sure symlinks are handled correctly.\n3. Make sure .gitignored files are ignored.\n4. Make sure .gitignored directories (and their contents) are ignored.\n5. Make sure &quot;.&quot; files are ignored in non-git packages.\n\n"},"comment":{"url":"https://api.github.com/repos/dart-lang/pub/issues/comments/109454193","html_url":"https://github.com/dart-lang/pub/issues/377#issuecomment-109454193","issue_url":"https://api.github.com/repos/dart-lang/pub/issues/377","id":109454193,"user":{"login":"DartBot","id":8958862,"avatar_url":"https://avatars.githubusercontent.com/u/8958862?v=3","gravatar_id":"","url":"https://api.github.com/users/DartBot","html_url":"https://github.com/DartBot","followers_url":"https://api.github.com/users/DartBot/followers","following_url":"https://api.github.com/users/DartBot/following{/other_user}","gists_url":"https://api.github.com/users/DartBot/gists{/gist_id}","starred_url":"https://api.github.com/users/DartBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DartBot/subscriptions","organizations_url":"https://api.github.com/users/DartBot/orgs","repos_url":"https://api.github.com/users/DartBot/repos","events_url":"https://api.github.com/users/DartBot/events{/privacy}","received_events_url":"https://api.github.com/users/DartBot/received_events","type":"User","site_admin":false},"created_at":"2015-06-05T22:04:36Z","updated_at":"2015-06-05T22:04:36Z","body":"<a href=\"https://github.com/munificent\"><img src=\"https://avatars.githubusercontent.com/u/46275?v=3\" align=\"left\" width=\"48\" height=\"48\"hspace=\"10\"></img></a> **Comment by [munificent](https://github.com/munificent)**\n\n----\n\n*Removed this from the [M3](../milestones/M3) milestone.*\n*Added this to the [M4](../milestones/M4) milestone.*\n"}}