{"action":"created","comment":{"url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/comments/42468869","id":42468869,"diff_hunk":"@@ -1,2 +1,39 @@\n-# marathon-shiro-authentication-plugin\n-Shiro authentication plugin for Marathon\n+# [Shiro](http://shiro.apache.org/) authentication plugin for [Marathon](https://mesosphere.github.io/marathon/) [![Coverage Status](https://coveralls.io/repos/janisz/marathon-shiro-authentication-plugin/badge.svg?branch=shiro_authenticator&service=github)](https://coveralls.io/github/janisz/marathon-shiro-authentication-plugin?branch=master) [![Build Status](https://travis-ci.org/janisz/marathon-shiro-authentication-plugin.svg?branch=master)](https://travis-ci.org/janisz/marathon-shiro-authentication-plugin) [![Codacy Badge](https://api.codacy.com/project/badge/3ca99746b9c142ef83e8ffcdbe693ca3)](https://www.codacy.com/app/janiszt/marathon-shiro-authentication-plugin) \n+\n+\n+\n+Plugin is based on [HTTP Basic access authentication](https://en.wikipedia.org/wiki/Basic_access_authentication).\n+Currently it supports only authentication, so any authenticated user ca do anything. I'm working on\n+providing fine grained authorization based on paths, actions and Shiro roles.\n+\n+_Always set up HTTPS for your Marathon instance before using this plugin._\n+\n+## Configuration\n+\n+Read Marathon docs about Plugins interface and configuration flags.\n+To configure this plugin you need to create [Shiro configuration file](http://shiro.apache.org/configuration.html)\n+and place it somewhere in the system (e.g., `/etc/marathon/shiro.ini`).\n+ \n+ - Put `marathon-shiro-authentication-plugin.jar` in your plugins directory and\n+ provide path to this directory using `--plugin_dir` flag\n+ - Create configuration JSON for Marathon (e.g., in `/etc/marathon/plugin_conf.json`)\n+ \n+ ```json\n+ {\n+   \"plugins\": [\n+     {\n+       \"plugin\": \"mesosphere.marathon.plugin.auth.Authorizer\",\n+       \"implementation\": \"pl.allegro.tech.marathon.plugin.auth.ShiroAuthorizer\"\n+     },\n+     {\n+       \"plugin\": \"mesosphere.marathon.plugin.auth.Authenticator\",\n+       \"implementation\": \"pl.allegro.tech.marathon.plugin.auth.ShiroAuthenticator\",","path":"README.md","position":32,"original_position":32,"commit_id":"1a7a82d3f997998daec5deedd6f72887afd9b741","original_commit_id":"1a7a82d3f997998daec5deedd6f72887afd9b741","user":{"login":"janisz","id":1616386,"avatar_url":"https://avatars.githubusercontent.com/u/1616386?v=3","gravatar_id":"","url":"https://api.github.com/users/janisz","html_url":"https://github.com/janisz","followers_url":"https://api.github.com/users/janisz/followers","following_url":"https://api.github.com/users/janisz/following{/other_user}","gists_url":"https://api.github.com/users/janisz/gists{/gist_id}","starred_url":"https://api.github.com/users/janisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisz/subscriptions","organizations_url":"https://api.github.com/users/janisz/orgs","repos_url":"https://api.github.com/users/janisz/repos","events_url":"https://api.github.com/users/janisz/events{/privacy}","received_events_url":"https://api.github.com/users/janisz/received_events","type":"User","site_admin":false},"body":"[Same as here](https://github.com/allegro/hermes/blob/master/hermes-api/src/test/java/pl/allegro/tech/hermes/api/SubscriptionTest.java#L1)","created_at":"2015-10-20T08:41:19Z","updated_at":"2015-10-20T08:41:19Z","html_url":"https://github.com/janisz/marathon-shiro-authentication-plugin/pull/1#discussion_r42468869","pull_request_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/comments/42468869"},"html":{"href":"https://github.com/janisz/marathon-shiro-authentication-plugin/pull/1#discussion_r42468869"},"pull_request":{"href":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/1","id":48063261,"html_url":"https://github.com/janisz/marathon-shiro-authentication-plugin/pull/1","diff_url":"https://github.com/janisz/marathon-shiro-authentication-plugin/pull/1.diff","patch_url":"https://github.com/janisz/marathon-shiro-authentication-plugin/pull/1.patch","issue_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/issues/1","number":1,"state":"open","locked":false,"title":"Shiro authenticator","user":{"login":"janisz","id":1616386,"avatar_url":"https://avatars.githubusercontent.com/u/1616386?v=3","gravatar_id":"","url":"https://api.github.com/users/janisz","html_url":"https://github.com/janisz","followers_url":"https://api.github.com/users/janisz/followers","following_url":"https://api.github.com/users/janisz/following{/other_user}","gists_url":"https://api.github.com/users/janisz/gists{/gist_id}","starred_url":"https://api.github.com/users/janisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisz/subscriptions","organizations_url":"https://api.github.com/users/janisz/orgs","repos_url":"https://api.github.com/users/janisz/repos","events_url":"https://api.github.com/users/janisz/events{/privacy}","received_events_url":"https://api.github.com/users/janisz/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-19T12:12:32Z","updated_at":"2015-10-20T08:41:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf2908e93073e519425d18ff41bd93d65709db76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/1/commits","review_comments_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/1/comments","review_comment_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/issues/1/comments","statuses_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/statuses/1a7a82d3f997998daec5deedd6f72887afd9b741","head":{"label":"janisz:shiro_authenticator","ref":"shiro_authenticator","sha":"1a7a82d3f997998daec5deedd6f72887afd9b741","user":{"login":"janisz","id":1616386,"avatar_url":"https://avatars.githubusercontent.com/u/1616386?v=3","gravatar_id":"","url":"https://api.github.com/users/janisz","html_url":"https://github.com/janisz","followers_url":"https://api.github.com/users/janisz/followers","following_url":"https://api.github.com/users/janisz/following{/other_user}","gists_url":"https://api.github.com/users/janisz/gists{/gist_id}","starred_url":"https://api.github.com/users/janisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisz/subscriptions","organizations_url":"https://api.github.com/users/janisz/orgs","repos_url":"https://api.github.com/users/janisz/repos","events_url":"https://api.github.com/users/janisz/events{/privacy}","received_events_url":"https://api.github.com/users/janisz/received_events","type":"User","site_admin":false},"repo":{"id":42725481,"name":"marathon-shiro-authentication-plugin","full_name":"janisz/marathon-shiro-authentication-plugin","owner":{"login":"janisz","id":1616386,"avatar_url":"https://avatars.githubusercontent.com/u/1616386?v=3","gravatar_id":"","url":"https://api.github.com/users/janisz","html_url":"https://github.com/janisz","followers_url":"https://api.github.com/users/janisz/followers","following_url":"https://api.github.com/users/janisz/following{/other_user}","gists_url":"https://api.github.com/users/janisz/gists{/gist_id}","starred_url":"https://api.github.com/users/janisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisz/subscriptions","organizations_url":"https://api.github.com/users/janisz/orgs","repos_url":"https://api.github.com/users/janisz/repos","events_url":"https://api.github.com/users/janisz/events{/privacy}","received_events_url":"https://api.github.com/users/janisz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janisz/marathon-shiro-authentication-plugin","description":"Shiro authentication plugin for Marathon","fork":false,"url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin","forks_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/forks","keys_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/teams","hooks_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/hooks","issue_events_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/events","assignees_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/tags","blobs_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/languages","stargazers_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/stargazers","contributors_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/contributors","subscribers_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/subscribers","subscription_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/subscription","commits_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/merges","archive_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/downloads","issues_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/labels{/name}","releases_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/releases{/id}","created_at":"2015-09-18T13:58:30Z","updated_at":"2015-10-05T22:33:36Z","pushed_at":"2015-10-19T12:12:32Z","git_url":"git://github.com/janisz/marathon-shiro-authentication-plugin.git","ssh_url":"git@github.com:janisz/marathon-shiro-authentication-plugin.git","clone_url":"https://github.com/janisz/marathon-shiro-authentication-plugin.git","svn_url":"https://github.com/janisz/marathon-shiro-authentication-plugin","homepage":null,"size":188,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"janisz:master","ref":"master","sha":"a56025d0541af9438d69ecb65ff67b9f26cd7fe2","user":{"login":"janisz","id":1616386,"avatar_url":"https://avatars.githubusercontent.com/u/1616386?v=3","gravatar_id":"","url":"https://api.github.com/users/janisz","html_url":"https://github.com/janisz","followers_url":"https://api.github.com/users/janisz/followers","following_url":"https://api.github.com/users/janisz/following{/other_user}","gists_url":"https://api.github.com/users/janisz/gists{/gist_id}","starred_url":"https://api.github.com/users/janisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisz/subscriptions","organizations_url":"https://api.github.com/users/janisz/orgs","repos_url":"https://api.github.com/users/janisz/repos","events_url":"https://api.github.com/users/janisz/events{/privacy}","received_events_url":"https://api.github.com/users/janisz/received_events","type":"User","site_admin":false},"repo":{"id":42725481,"name":"marathon-shiro-authentication-plugin","full_name":"janisz/marathon-shiro-authentication-plugin","owner":{"login":"janisz","id":1616386,"avatar_url":"https://avatars.githubusercontent.com/u/1616386?v=3","gravatar_id":"","url":"https://api.github.com/users/janisz","html_url":"https://github.com/janisz","followers_url":"https://api.github.com/users/janisz/followers","following_url":"https://api.github.com/users/janisz/following{/other_user}","gists_url":"https://api.github.com/users/janisz/gists{/gist_id}","starred_url":"https://api.github.com/users/janisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janisz/subscriptions","organizations_url":"https://api.github.com/users/janisz/orgs","repos_url":"https://api.github.com/users/janisz/repos","events_url":"https://api.github.com/users/janisz/events{/privacy}","received_events_url":"https://api.github.com/users/janisz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janisz/marathon-shiro-authentication-plugin","description":"Shiro authentication plugin for Marathon","fork":false,"url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin","forks_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/forks","keys_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/teams","hooks_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/hooks","issue_events_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/events","assignees_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/tags","blobs_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/languages","stargazers_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/stargazers","contributors_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/contributors","subscribers_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/subscribers","subscription_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/subscription","commits_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/merges","archive_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/downloads","issues_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/labels{/name}","releases_url":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/releases{/id}","created_at":"2015-09-18T13:58:30Z","updated_at":"2015-10-05T22:33:36Z","pushed_at":"2015-10-19T12:12:32Z","git_url":"git://github.com/janisz/marathon-shiro-authentication-plugin.git","ssh_url":"git@github.com:janisz/marathon-shiro-authentication-plugin.git","clone_url":"https://github.com/janisz/marathon-shiro-authentication-plugin.git","svn_url":"https://github.com/janisz/marathon-shiro-authentication-plugin","homepage":null,"size":188,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/1"},"html":{"href":"https://github.com/janisz/marathon-shiro-authentication-plugin/pull/1"},"issue":{"href":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/issues/1"},"comments":{"href":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/janisz/marathon-shiro-authentication-plugin/statuses/1a7a82d3f997998daec5deedd6f72887afd9b741"}}}}