{"action":"created","comment":{"url":"https://api.github.com/repos/kovyl2404/rebar3/pulls/comments/31573364","id":31573364,"diff_hunk":"@@ -158,11 +158,21 @@ sh(Command0, Options0) ->\n     ?DEBUG(\"Port Cmd: ~s\\nPort Opts: ~p\\n\", [Command, PortSettings]),\n     Port = open_port({spawn, Command}, PortSettings),\n \n-    case sh_loop(Port, OutputHandler, []) of\n-        {ok, _Output} = Ok ->\n-            Ok;\n-        {error, {_Rc, _Output}=Err} ->\n-            ErrorHandler(Command, Err)\n+    case os:type() of\n+        {win32, _} ->","path":"src/rebar_utils.erl","position":10,"original_position":10,"commit_id":"fafd1e59d415425bfedf142a04f7d90da880821e","original_commit_id":"f85e374ffee3da5d3b3fd5490d10d5e1e0194471","user":{"login":"Taure","id":216711,"avatar_url":"https://avatars.githubusercontent.com/u/216711?v=3","gravatar_id":"","url":"https://api.github.com/users/Taure","html_url":"https://github.com/Taure","followers_url":"https://api.github.com/users/Taure/followers","following_url":"https://api.github.com/users/Taure/following{/other_user}","gists_url":"https://api.github.com/users/Taure/gists{/gist_id}","starred_url":"https://api.github.com/users/Taure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taure/subscriptions","organizations_url":"https://api.github.com/users/Taure/orgs","repos_url":"https://api.github.com/users/Taure/repos","events_url":"https://api.github.com/users/Taure/events{/privacy}","received_events_url":"https://api.github.com/users/Taure/received_events","type":"User","site_admin":false},"body":"Hmm.. true.\r\n\r\nI see that it uses it for git, hg and so..\r\n\r\nNeed to go to bed now. But if you want you can remove the sh_loop_win32 and add the checks in xcopy_win32 instead and the mv function?","created_at":"2015-06-02T21:29:15Z","updated_at":"2015-06-02T21:29:15Z","html_url":"https://github.com/kovyl2404/rebar3/pull/1#discussion_r31573364","pull_request_url":"https://api.github.com/repos/kovyl2404/rebar3/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/kovyl2404/rebar3/pulls/comments/31573364"},"html":{"href":"https://github.com/kovyl2404/rebar3/pull/1#discussion_r31573364"},"pull_request":{"href":"https://api.github.com/repos/kovyl2404/rebar3/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/kovyl2404/rebar3/pulls/1","id":36773777,"html_url":"https://github.com/kovyl2404/rebar3/pull/1","diff_url":"https://github.com/kovyl2404/rebar3/pull/1.diff","patch_url":"https://github.com/kovyl2404/rebar3/pull/1.patch","issue_url":"https://api.github.com/repos/kovyl2404/rebar3/issues/1","number":1,"state":"open","locked":false,"title":"Added the fixes","user":{"login":"Taure","id":216711,"avatar_url":"https://avatars.githubusercontent.com/u/216711?v=3","gravatar_id":"","url":"https://api.github.com/users/Taure","html_url":"https://github.com/Taure","followers_url":"https://api.github.com/users/Taure/followers","following_url":"https://api.github.com/users/Taure/following{/other_user}","gists_url":"https://api.github.com/users/Taure/gists{/gist_id}","starred_url":"https://api.github.com/users/Taure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taure/subscriptions","organizations_url":"https://api.github.com/users/Taure/orgs","repos_url":"https://api.github.com/users/Taure/repos","events_url":"https://api.github.com/users/Taure/events{/privacy}","received_events_url":"https://api.github.com/users/Taure/received_events","type":"User","site_admin":false},"body":"This is your branch and mine. Hope it don't break anything for you.","created_at":"2015-06-02T21:03:10Z","updated_at":"2015-06-02T21:29:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e446e4b59ec069e80788c54647524283bd296393","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kovyl2404/rebar3/pulls/1/commits","review_comments_url":"https://api.github.com/repos/kovyl2404/rebar3/pulls/1/comments","review_comment_url":"https://api.github.com/repos/kovyl2404/rebar3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kovyl2404/rebar3/issues/1/comments","statuses_url":"https://api.github.com/repos/kovyl2404/rebar3/statuses/fafd1e59d415425bfedf142a04f7d90da880821e","head":{"label":"Taure:kovyl2404","ref":"kovyl2404","sha":"fafd1e59d415425bfedf142a04f7d90da880821e","user":{"login":"Taure","id":216711,"avatar_url":"https://avatars.githubusercontent.com/u/216711?v=3","gravatar_id":"","url":"https://api.github.com/users/Taure","html_url":"https://github.com/Taure","followers_url":"https://api.github.com/users/Taure/followers","following_url":"https://api.github.com/users/Taure/following{/other_user}","gists_url":"https://api.github.com/users/Taure/gists{/gist_id}","starred_url":"https://api.github.com/users/Taure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taure/subscriptions","organizations_url":"https://api.github.com/users/Taure/orgs","repos_url":"https://api.github.com/users/Taure/repos","events_url":"https://api.github.com/users/Taure/events{/privacy}","received_events_url":"https://api.github.com/users/Taure/received_events","type":"User","site_admin":false},"repo":{"id":36028450,"name":"rebar3","full_name":"Taure/rebar3","owner":{"login":"Taure","id":216711,"avatar_url":"https://avatars.githubusercontent.com/u/216711?v=3","gravatar_id":"","url":"https://api.github.com/users/Taure","html_url":"https://github.com/Taure","followers_url":"https://api.github.com/users/Taure/followers","following_url":"https://api.github.com/users/Taure/following{/other_user}","gists_url":"https://api.github.com/users/Taure/gists{/gist_id}","starred_url":"https://api.github.com/users/Taure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taure/subscriptions","organizations_url":"https://api.github.com/users/Taure/orgs","repos_url":"https://api.github.com/users/Taure/repos","events_url":"https://api.github.com/users/Taure/events{/privacy}","received_events_url":"https://api.github.com/users/Taure/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Taure/rebar3","description":"Erlang build tool that makes it easy to compile and test Erlang applications, port drivers and releases.","fork":true,"url":"https://api.github.com/repos/Taure/rebar3","forks_url":"https://api.github.com/repos/Taure/rebar3/forks","keys_url":"https://api.github.com/repos/Taure/rebar3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Taure/rebar3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Taure/rebar3/teams","hooks_url":"https://api.github.com/repos/Taure/rebar3/hooks","issue_events_url":"https://api.github.com/repos/Taure/rebar3/issues/events{/number}","events_url":"https://api.github.com/repos/Taure/rebar3/events","assignees_url":"https://api.github.com/repos/Taure/rebar3/assignees{/user}","branches_url":"https://api.github.com/repos/Taure/rebar3/branches{/branch}","tags_url":"https://api.github.com/repos/Taure/rebar3/tags","blobs_url":"https://api.github.com/repos/Taure/rebar3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Taure/rebar3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Taure/rebar3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Taure/rebar3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Taure/rebar3/statuses/{sha}","languages_url":"https://api.github.com/repos/Taure/rebar3/languages","stargazers_url":"https://api.github.com/repos/Taure/rebar3/stargazers","contributors_url":"https://api.github.com/repos/Taure/rebar3/contributors","subscribers_url":"https://api.github.com/repos/Taure/rebar3/subscribers","subscription_url":"https://api.github.com/repos/Taure/rebar3/subscription","commits_url":"https://api.github.com/repos/Taure/rebar3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Taure/rebar3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Taure/rebar3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Taure/rebar3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Taure/rebar3/contents/{+path}","compare_url":"https://api.github.com/repos/Taure/rebar3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Taure/rebar3/merges","archive_url":"https://api.github.com/repos/Taure/rebar3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Taure/rebar3/downloads","issues_url":"https://api.github.com/repos/Taure/rebar3/issues{/number}","pulls_url":"https://api.github.com/repos/Taure/rebar3/pulls{/number}","milestones_url":"https://api.github.com/repos/Taure/rebar3/milestones{/number}","notifications_url":"https://api.github.com/repos/Taure/rebar3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Taure/rebar3/labels{/name}","releases_url":"https://api.github.com/repos/Taure/rebar3/releases{/id}","created_at":"2015-05-21T17:50:50Z","updated_at":"2015-05-21T17:50:51Z","pushed_at":"2015-06-02T21:08:56Z","git_url":"git://github.com/Taure/rebar3.git","ssh_url":"git@github.com:Taure/rebar3.git","clone_url":"https://github.com/Taure/rebar3.git","svn_url":"https://github.com/Taure/rebar3","homepage":"  http://www.rebar3.org","size":3317,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kovyl2404:windows-ct-fix","ref":"windows-ct-fix","sha":"245c3ed7b6c89f6007759db3297a61ff0ba15821","user":{"login":"kovyl2404","id":3457910,"avatar_url":"https://avatars.githubusercontent.com/u/3457910?v=3","gravatar_id":"","url":"https://api.github.com/users/kovyl2404","html_url":"https://github.com/kovyl2404","followers_url":"https://api.github.com/users/kovyl2404/followers","following_url":"https://api.github.com/users/kovyl2404/following{/other_user}","gists_url":"https://api.github.com/users/kovyl2404/gists{/gist_id}","starred_url":"https://api.github.com/users/kovyl2404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kovyl2404/subscriptions","organizations_url":"https://api.github.com/users/kovyl2404/orgs","repos_url":"https://api.github.com/users/kovyl2404/repos","events_url":"https://api.github.com/users/kovyl2404/events{/privacy}","received_events_url":"https://api.github.com/users/kovyl2404/received_events","type":"User","site_admin":false},"repo":{"id":31980120,"name":"rebar3","full_name":"kovyl2404/rebar3","owner":{"login":"kovyl2404","id":3457910,"avatar_url":"https://avatars.githubusercontent.com/u/3457910?v=3","gravatar_id":"","url":"https://api.github.com/users/kovyl2404","html_url":"https://github.com/kovyl2404","followers_url":"https://api.github.com/users/kovyl2404/followers","following_url":"https://api.github.com/users/kovyl2404/following{/other_user}","gists_url":"https://api.github.com/users/kovyl2404/gists{/gist_id}","starred_url":"https://api.github.com/users/kovyl2404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kovyl2404/subscriptions","organizations_url":"https://api.github.com/users/kovyl2404/orgs","repos_url":"https://api.github.com/users/kovyl2404/repos","events_url":"https://api.github.com/users/kovyl2404/events{/privacy}","received_events_url":"https://api.github.com/users/kovyl2404/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kovyl2404/rebar3","description":"Erlang build tool that makes it easy to compile and test Erlang applications, port drivers and releases.","fork":true,"url":"https://api.github.com/repos/kovyl2404/rebar3","forks_url":"https://api.github.com/repos/kovyl2404/rebar3/forks","keys_url":"https://api.github.com/repos/kovyl2404/rebar3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kovyl2404/rebar3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kovyl2404/rebar3/teams","hooks_url":"https://api.github.com/repos/kovyl2404/rebar3/hooks","issue_events_url":"https://api.github.com/repos/kovyl2404/rebar3/issues/events{/number}","events_url":"https://api.github.com/repos/kovyl2404/rebar3/events","assignees_url":"https://api.github.com/repos/kovyl2404/rebar3/assignees{/user}","branches_url":"https://api.github.com/repos/kovyl2404/rebar3/branches{/branch}","tags_url":"https://api.github.com/repos/kovyl2404/rebar3/tags","blobs_url":"https://api.github.com/repos/kovyl2404/rebar3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kovyl2404/rebar3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kovyl2404/rebar3/git/refs{/sha}","trees_url":"https://api.github.com/repos/kovyl2404/rebar3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kovyl2404/rebar3/statuses/{sha}","languages_url":"https://api.github.com/repos/kovyl2404/rebar3/languages","stargazers_url":"https://api.github.com/repos/kovyl2404/rebar3/stargazers","contributors_url":"https://api.github.com/repos/kovyl2404/rebar3/contributors","subscribers_url":"https://api.github.com/repos/kovyl2404/rebar3/subscribers","subscription_url":"https://api.github.com/repos/kovyl2404/rebar3/subscription","commits_url":"https://api.github.com/repos/kovyl2404/rebar3/commits{/sha}","git_commits_url":"https://api.github.com/repos/kovyl2404/rebar3/git/commits{/sha}","comments_url":"https://api.github.com/repos/kovyl2404/rebar3/comments{/number}","issue_comment_url":"https://api.github.com/repos/kovyl2404/rebar3/issues/comments{/number}","contents_url":"https://api.github.com/repos/kovyl2404/rebar3/contents/{+path}","compare_url":"https://api.github.com/repos/kovyl2404/rebar3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kovyl2404/rebar3/merges","archive_url":"https://api.github.com/repos/kovyl2404/rebar3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kovyl2404/rebar3/downloads","issues_url":"https://api.github.com/repos/kovyl2404/rebar3/issues{/number}","pulls_url":"https://api.github.com/repos/kovyl2404/rebar3/pulls{/number}","milestones_url":"https://api.github.com/repos/kovyl2404/rebar3/milestones{/number}","notifications_url":"https://api.github.com/repos/kovyl2404/rebar3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kovyl2404/rebar3/labels{/name}","releases_url":"https://api.github.com/repos/kovyl2404/rebar3/releases{/id}","created_at":"2015-03-10T20:28:12Z","updated_at":"2015-05-03T19:54:03Z","pushed_at":"2015-06-02T21:08:57Z","git_url":"git://github.com/kovyl2404/rebar3.git","ssh_url":"git@github.com:kovyl2404/rebar3.git","clone_url":"https://github.com/kovyl2404/rebar3.git","svn_url":"https://github.com/kovyl2404/rebar3","homepage":"  http://www.rebar3.org","size":3446,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kovyl2404/rebar3/pulls/1"},"html":{"href":"https://github.com/kovyl2404/rebar3/pull/1"},"issue":{"href":"https://api.github.com/repos/kovyl2404/rebar3/issues/1"},"comments":{"href":"https://api.github.com/repos/kovyl2404/rebar3/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/kovyl2404/rebar3/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/kovyl2404/rebar3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kovyl2404/rebar3/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/kovyl2404/rebar3/statuses/fafd1e59d415425bfedf142a04f7d90da880821e"}}}}