{"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/38024284","id":38024284,"diff_hunk":"@@ -231,6 +239,42 @@ def delete_orphans_by_type(content_type_id, content_unit_ids=None):\n                 OrphanManager.delete_orphaned_file(storage_path)\n \n     @staticmethod\n+    def delete_orphan_content_units_by_type(type_id):\n+        \"\"\"\n+        Delete the orphaned content units for the given content type.\n+        This method only applies to new style content units that are loaded via entry points\n+\n+        NOTE: this method deletes the content unit's bits from disk, if applicable.\n+\n+        :param type_id: id of the content type\n+        :type type_id: basestring\n+        \"\"\"\n+        # get the model matching the type\n+        content_model = plugin_api.get_unit_model_by_id(type_id)\n+        content_units = content_model.objects().only('id', 'storage_path')","path":"server/pulp/server/managers/content/orphan.py","position":48,"original_position":48,"commit_id":"b53db55404078a04fbea8bfdf0bc9ab3ea55a047","original_commit_id":"b53db55404078a04fbea8bfdf0bc9ab3ea55a047","user":{"login":"bmbouter","id":180319,"avatar_url":"https://avatars.githubusercontent.com/u/180319?v=3","gravatar_id":"","url":"https://api.github.com/users/bmbouter","html_url":"https://github.com/bmbouter","followers_url":"https://api.github.com/users/bmbouter/followers","following_url":"https://api.github.com/users/bmbouter/following{/other_user}","gists_url":"https://api.github.com/users/bmbouter/gists{/gist_id}","starred_url":"https://api.github.com/users/bmbouter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmbouter/subscriptions","organizations_url":"https://api.github.com/users/bmbouter/orgs","repos_url":"https://api.github.com/users/bmbouter/repos","events_url":"https://api.github.com/users/bmbouter/events{/privacy}","received_events_url":"https://api.github.com/users/bmbouter/received_events","type":"User","site_admin":false},"body":"FYI, you don't need the `()` on `objects()`. This could be written as `content_model.objects.only('id', 'storage_path')`.","created_at":"2015-08-26T19:29:32Z","updated_at":"2015-08-26T19:29:32Z","html_url":"https://github.com/pulp/pulp/pull/2012#discussion_r38024284","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/2012","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/38024284"},"html":{"href":"https://github.com/pulp/pulp/pull/2012#discussion_r38024284"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2012"}}},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp/pulls/2012","id":43433664,"html_url":"https://github.com/pulp/pulp/pull/2012","diff_url":"https://github.com/pulp/pulp/pull/2012.diff","patch_url":"https://github.com/pulp/pulp/pull/2012.patch","issue_url":"https://api.github.com/repos/pulp/pulp/issues/2012","number":2012,"state":"open","locked":false,"title":"add mongoengine orphan-cleanup support","user":{"login":"barnabycourt","id":5054204,"avatar_url":"https://avatars.githubusercontent.com/u/5054204?v=3","gravatar_id":"","url":"https://api.github.com/users/barnabycourt","html_url":"https://github.com/barnabycourt","followers_url":"https://api.github.com/users/barnabycourt/followers","following_url":"https://api.github.com/users/barnabycourt/following{/other_user}","gists_url":"https://api.github.com/users/barnabycourt/gists{/gist_id}","starred_url":"https://api.github.com/users/barnabycourt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barnabycourt/subscriptions","organizations_url":"https://api.github.com/users/barnabycourt/orgs","repos_url":"https://api.github.com/users/barnabycourt/repos","events_url":"https://api.github.com/users/barnabycourt/events{/privacy}","received_events_url":"https://api.github.com/users/barnabycourt/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-26T18:13:30Z","updated_at":"2015-08-26T19:29:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4abdd016c48a87787515b57ddd04182eef857d9","assignee":{"login":"bmbouter","id":180319,"avatar_url":"https://avatars.githubusercontent.com/u/180319?v=3","gravatar_id":"","url":"https://api.github.com/users/bmbouter","html_url":"https://github.com/bmbouter","followers_url":"https://api.github.com/users/bmbouter/followers","following_url":"https://api.github.com/users/bmbouter/following{/other_user}","gists_url":"https://api.github.com/users/bmbouter/gists{/gist_id}","starred_url":"https://api.github.com/users/bmbouter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmbouter/subscriptions","organizations_url":"https://api.github.com/users/bmbouter/orgs","repos_url":"https://api.github.com/users/bmbouter/repos","events_url":"https://api.github.com/users/bmbouter/events{/privacy}","received_events_url":"https://api.github.com/users/bmbouter/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp/pulls/2012/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp/pulls/2012/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulp/pulp/issues/2012/comments","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/b53db55404078a04fbea8bfdf0bc9ab3ea55a047","head":{"label":"barnabycourt:mongoengine-orphan-support","ref":"mongoengine-orphan-support","sha":"b53db55404078a04fbea8bfdf0bc9ab3ea55a047","user":{"login":"barnabycourt","id":5054204,"avatar_url":"https://avatars.githubusercontent.com/u/5054204?v=3","gravatar_id":"","url":"https://api.github.com/users/barnabycourt","html_url":"https://github.com/barnabycourt","followers_url":"https://api.github.com/users/barnabycourt/followers","following_url":"https://api.github.com/users/barnabycourt/following{/other_user}","gists_url":"https://api.github.com/users/barnabycourt/gists{/gist_id}","starred_url":"https://api.github.com/users/barnabycourt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barnabycourt/subscriptions","organizations_url":"https://api.github.com/users/barnabycourt/orgs","repos_url":"https://api.github.com/users/barnabycourt/repos","events_url":"https://api.github.com/users/barnabycourt/events{/privacy}","received_events_url":"https://api.github.com/users/barnabycourt/received_events","type":"User","site_admin":false},"repo":{"id":25038093,"name":"pulp","full_name":"barnabycourt/pulp","owner":{"login":"barnabycourt","id":5054204,"avatar_url":"https://avatars.githubusercontent.com/u/5054204?v=3","gravatar_id":"","url":"https://api.github.com/users/barnabycourt","html_url":"https://github.com/barnabycourt","followers_url":"https://api.github.com/users/barnabycourt/followers","following_url":"https://api.github.com/users/barnabycourt/following{/other_user}","gists_url":"https://api.github.com/users/barnabycourt/gists{/gist_id}","starred_url":"https://api.github.com/users/barnabycourt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barnabycourt/subscriptions","organizations_url":"https://api.github.com/users/barnabycourt/orgs","repos_url":"https://api.github.com/users/barnabycourt/repos","events_url":"https://api.github.com/users/barnabycourt/events{/privacy}","received_events_url":"https://api.github.com/users/barnabycourt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/barnabycourt/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":true,"url":"https://api.github.com/repos/barnabycourt/pulp","forks_url":"https://api.github.com/repos/barnabycourt/pulp/forks","keys_url":"https://api.github.com/repos/barnabycourt/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/barnabycourt/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/barnabycourt/pulp/teams","hooks_url":"https://api.github.com/repos/barnabycourt/pulp/hooks","issue_events_url":"https://api.github.com/repos/barnabycourt/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/barnabycourt/pulp/events","assignees_url":"https://api.github.com/repos/barnabycourt/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/barnabycourt/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/barnabycourt/pulp/tags","blobs_url":"https://api.github.com/repos/barnabycourt/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/barnabycourt/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/barnabycourt/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/barnabycourt/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/barnabycourt/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/barnabycourt/pulp/languages","stargazers_url":"https://api.github.com/repos/barnabycourt/pulp/stargazers","contributors_url":"https://api.github.com/repos/barnabycourt/pulp/contributors","subscribers_url":"https://api.github.com/repos/barnabycourt/pulp/subscribers","subscription_url":"https://api.github.com/repos/barnabycourt/pulp/subscription","commits_url":"https://api.github.com/repos/barnabycourt/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/barnabycourt/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/barnabycourt/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/barnabycourt/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/barnabycourt/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/barnabycourt/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/barnabycourt/pulp/merges","archive_url":"https://api.github.com/repos/barnabycourt/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/barnabycourt/pulp/downloads","issues_url":"https://api.github.com/repos/barnabycourt/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/barnabycourt/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/barnabycourt/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/barnabycourt/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/barnabycourt/pulp/labels{/name}","releases_url":"https://api.github.com/repos/barnabycourt/pulp/releases{/id}","created_at":"2014-10-10T14:04:33Z","updated_at":"2015-02-16T16:32:27Z","pushed_at":"2015-08-26T19:03:06Z","git_url":"git://github.com/barnabycourt/pulp.git","ssh_url":"git@github.com:barnabycourt/pulp.git","clone_url":"https://github.com/barnabycourt/pulp.git","svn_url":"https://github.com/barnabycourt/pulp","homepage":"","size":85303,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:master","ref":"master","sha":"5d314f22db57e7e0e8b45d79d997c7b5e2199dcc","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":5314652,"name":"pulp","full_name":"pulp/pulp","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":false,"url":"https://api.github.com/repos/pulp/pulp","forks_url":"https://api.github.com/repos/pulp/pulp/forks","keys_url":"https://api.github.com/repos/pulp/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp/teams","hooks_url":"https://api.github.com/repos/pulp/pulp/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp/events","assignees_url":"https://api.github.com/repos/pulp/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp/tags","blobs_url":"https://api.github.com/repos/pulp/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp/subscription","commits_url":"https://api.github.com/repos/pulp/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp/merges","archive_url":"https://api.github.com/repos/pulp/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp/downloads","issues_url":"https://api.github.com/repos/pulp/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp/releases{/id}","created_at":"2012-08-06T13:49:20Z","updated_at":"2015-08-25T22:34:03Z","pushed_at":"2015-08-26T19:03:07Z","git_url":"git://github.com/pulp/pulp.git","ssh_url":"git@github.com:pulp/pulp.git","clone_url":"https://github.com/pulp/pulp.git","svn_url":"https://github.com/pulp/pulp","homepage":"","size":207282,"stargazers_count":215,"watchers_count":215,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":21,"forks":86,"open_issues":21,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2012"},"html":{"href":"https://github.com/pulp/pulp/pull/2012"},"issue":{"href":"https://api.github.com/repos/pulp/pulp/issues/2012"},"comments":{"href":"https://api.github.com/repos/pulp/pulp/issues/2012/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2012/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp/pulls/2012/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp/statuses/b53db55404078a04fbea8bfdf0bc9ab3ea55a047"}}}}