{"action":"created","comment":{"url":"https://api.github.com/repos/apache/orc/pulls/comments/44282193","id":44282193,"diff_hunk":"@@ -1081,8 +1081,8 @@ namespace orc {\n   }\n \n   void ReaderImpl::selectType(const Type& type) {\n-    if (!selectedColumns[static_cast<size_t>(type.getColumnId())]) {\n-      selectedColumns[static_cast<size_t>(type.getColumnId())] = true;\n+    if (!selectedColumns[type.getColumnId()]) {","path":"c++/src/Reader.cc","position":35,"original_position":35,"commit_id":"01ea2074b413d7f95664338dc6df7d20224370f3","original_commit_id":"01ea2074b413d7f95664338dc6df7d20224370f3","user":{"login":"asandryh","id":9371145,"avatar_url":"https://avatars.githubusercontent.com/u/9371145?v=3","gravatar_id":"","url":"https://api.github.com/users/asandryh","html_url":"https://github.com/asandryh","followers_url":"https://api.github.com/users/asandryh/followers","following_url":"https://api.github.com/users/asandryh/following{/other_user}","gists_url":"https://api.github.com/users/asandryh/gists{/gist_id}","starred_url":"https://api.github.com/users/asandryh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asandryh/subscriptions","organizations_url":"https://api.github.com/users/asandryh/orgs","repos_url":"https://api.github.com/users/asandryh/repos","events_url":"https://api.github.com/users/asandryh/events{/privacy}","received_events_url":"https://api.github.com/users/asandryh/received_events","type":"User","site_admin":false},"body":"Will fix this, too.","created_at":"2015-11-09T14:48:46Z","updated_at":"2015-11-09T14:48:46Z","html_url":"https://github.com/apache/orc/pull/12#discussion_r44282193","pull_request_url":"https://api.github.com/repos/apache/orc/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/apache/orc/pulls/comments/44282193"},"html":{"href":"https://github.com/apache/orc/pull/12#discussion_r44282193"},"pull_request":{"href":"https://api.github.com/repos/apache/orc/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/apache/orc/pulls/12","id":49999271,"html_url":"https://github.com/apache/orc/pull/12","diff_url":"https://github.com/apache/orc/pull/12.diff","patch_url":"https://github.com/apache/orc/pull/12.patch","issue_url":"https://api.github.com/repos/apache/orc/issues/12","number":12,"state":"open","locked":false,"title":"Fixed ORC-21: Add dynamic memory usage estimation.","user":{"login":"asandryh","id":9371145,"avatar_url":"https://avatars.githubusercontent.com/u/9371145?v=3","gravatar_id":"","url":"https://api.github.com/users/asandryh","html_url":"https://github.com/asandryh","followers_url":"https://api.github.com/users/asandryh/followers","following_url":"https://api.github.com/users/asandryh/following{/other_user}","gists_url":"https://api.github.com/users/asandryh/gists{/gist_id}","starred_url":"https://api.github.com/users/asandryh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asandryh/subscriptions","organizations_url":"https://api.github.com/users/asandryh/orgs","repos_url":"https://api.github.com/users/asandryh/repos","events_url":"https://api.github.com/users/asandryh/events{/privacy}","received_events_url":"https://api.github.com/users/asandryh/received_events","type":"User","site_admin":false},"body":"An upper bound on memory requirements is provided by two components:\r\n* Reader::memoryUse() returns an upper bound on its memory needs. It depends on the file and columns read.\r\n* ColumnBatch::memoryUse() returns an upper bound on its memory needs. It depends on the file, columns, and number of rows read.\r\n\r\nThe new utility FileMemory.cc compares estimated and actual memory usage.","created_at":"2015-11-06T20:13:24Z","updated_at":"2015-11-09T14:48:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5540a9725db6fd2fccb3dd8d193cab3c66b62b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/orc/pulls/12/commits","review_comments_url":"https://api.github.com/repos/apache/orc/pulls/12/comments","review_comment_url":"https://api.github.com/repos/apache/orc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/orc/issues/12/comments","statuses_url":"https://api.github.com/repos/apache/orc/statuses/01ea2074b413d7f95664338dc6df7d20224370f3","head":{"label":"asandryh:orc-21","ref":"orc-21","sha":"01ea2074b413d7f95664338dc6df7d20224370f3","user":{"login":"asandryh","id":9371145,"avatar_url":"https://avatars.githubusercontent.com/u/9371145?v=3","gravatar_id":"","url":"https://api.github.com/users/asandryh","html_url":"https://github.com/asandryh","followers_url":"https://api.github.com/users/asandryh/followers","following_url":"https://api.github.com/users/asandryh/following{/other_user}","gists_url":"https://api.github.com/users/asandryh/gists{/gist_id}","starred_url":"https://api.github.com/users/asandryh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asandryh/subscriptions","organizations_url":"https://api.github.com/users/asandryh/orgs","repos_url":"https://api.github.com/users/asandryh/repos","events_url":"https://api.github.com/users/asandryh/events{/privacy}","received_events_url":"https://api.github.com/users/asandryh/received_events","type":"User","site_admin":false},"repo":{"id":38711838,"name":"orc","full_name":"asandryh/orc","owner":{"login":"asandryh","id":9371145,"avatar_url":"https://avatars.githubusercontent.com/u/9371145?v=3","gravatar_id":"","url":"https://api.github.com/users/asandryh","html_url":"https://github.com/asandryh","followers_url":"https://api.github.com/users/asandryh/followers","following_url":"https://api.github.com/users/asandryh/following{/other_user}","gists_url":"https://api.github.com/users/asandryh/gists{/gist_id}","starred_url":"https://api.github.com/users/asandryh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asandryh/subscriptions","organizations_url":"https://api.github.com/users/asandryh/orgs","repos_url":"https://api.github.com/users/asandryh/repos","events_url":"https://api.github.com/users/asandryh/events{/privacy}","received_events_url":"https://api.github.com/users/asandryh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asandryh/orc","description":"Mirror of Apache Orc","fork":true,"url":"https://api.github.com/repos/asandryh/orc","forks_url":"https://api.github.com/repos/asandryh/orc/forks","keys_url":"https://api.github.com/repos/asandryh/orc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asandryh/orc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asandryh/orc/teams","hooks_url":"https://api.github.com/repos/asandryh/orc/hooks","issue_events_url":"https://api.github.com/repos/asandryh/orc/issues/events{/number}","events_url":"https://api.github.com/repos/asandryh/orc/events","assignees_url":"https://api.github.com/repos/asandryh/orc/assignees{/user}","branches_url":"https://api.github.com/repos/asandryh/orc/branches{/branch}","tags_url":"https://api.github.com/repos/asandryh/orc/tags","blobs_url":"https://api.github.com/repos/asandryh/orc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asandryh/orc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asandryh/orc/git/refs{/sha}","trees_url":"https://api.github.com/repos/asandryh/orc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asandryh/orc/statuses/{sha}","languages_url":"https://api.github.com/repos/asandryh/orc/languages","stargazers_url":"https://api.github.com/repos/asandryh/orc/stargazers","contributors_url":"https://api.github.com/repos/asandryh/orc/contributors","subscribers_url":"https://api.github.com/repos/asandryh/orc/subscribers","subscription_url":"https://api.github.com/repos/asandryh/orc/subscription","commits_url":"https://api.github.com/repos/asandryh/orc/commits{/sha}","git_commits_url":"https://api.github.com/repos/asandryh/orc/git/commits{/sha}","comments_url":"https://api.github.com/repos/asandryh/orc/comments{/number}","issue_comment_url":"https://api.github.com/repos/asandryh/orc/issues/comments{/number}","contents_url":"https://api.github.com/repos/asandryh/orc/contents/{+path}","compare_url":"https://api.github.com/repos/asandryh/orc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asandryh/orc/merges","archive_url":"https://api.github.com/repos/asandryh/orc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asandryh/orc/downloads","issues_url":"https://api.github.com/repos/asandryh/orc/issues{/number}","pulls_url":"https://api.github.com/repos/asandryh/orc/pulls{/number}","milestones_url":"https://api.github.com/repos/asandryh/orc/milestones{/number}","notifications_url":"https://api.github.com/repos/asandryh/orc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asandryh/orc/labels{/name}","releases_url":"https://api.github.com/repos/asandryh/orc/releases{/id}","created_at":"2015-07-07T20:05:55Z","updated_at":"2015-07-07T20:05:55Z","pushed_at":"2015-11-06T20:11:33Z","git_url":"git://github.com/asandryh/orc.git","ssh_url":"git@github.com:asandryh/orc.git","clone_url":"https://github.com/asandryh/orc.git","svn_url":"https://github.com/asandryh/orc","homepage":null,"size":15012,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"asf-site"}},"base":{"label":"apache:master","ref":"master","sha":"d81c9a61f64cc63655b4e29dd4c8d11db4d6bc12","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":35144191,"name":"orc","full_name":"apache/orc","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/orc","description":"Mirror of Apache Orc","fork":false,"url":"https://api.github.com/repos/apache/orc","forks_url":"https://api.github.com/repos/apache/orc/forks","keys_url":"https://api.github.com/repos/apache/orc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/orc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/orc/teams","hooks_url":"https://api.github.com/repos/apache/orc/hooks","issue_events_url":"https://api.github.com/repos/apache/orc/issues/events{/number}","events_url":"https://api.github.com/repos/apache/orc/events","assignees_url":"https://api.github.com/repos/apache/orc/assignees{/user}","branches_url":"https://api.github.com/repos/apache/orc/branches{/branch}","tags_url":"https://api.github.com/repos/apache/orc/tags","blobs_url":"https://api.github.com/repos/apache/orc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/orc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/orc/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/orc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/orc/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/orc/languages","stargazers_url":"https://api.github.com/repos/apache/orc/stargazers","contributors_url":"https://api.github.com/repos/apache/orc/contributors","subscribers_url":"https://api.github.com/repos/apache/orc/subscribers","subscription_url":"https://api.github.com/repos/apache/orc/subscription","commits_url":"https://api.github.com/repos/apache/orc/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/orc/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/orc/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/orc/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/orc/contents/{+path}","compare_url":"https://api.github.com/repos/apache/orc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/orc/merges","archive_url":"https://api.github.com/repos/apache/orc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/orc/downloads","issues_url":"https://api.github.com/repos/apache/orc/issues{/number}","pulls_url":"https://api.github.com/repos/apache/orc/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/orc/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/orc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/orc/labels{/name}","releases_url":"https://api.github.com/repos/apache/orc/releases{/id}","created_at":"2015-05-06T07:00:05Z","updated_at":"2015-10-16T14:21:40Z","pushed_at":"2015-11-06T20:13:25Z","git_url":"git://github.com/apache/orc.git","ssh_url":"git@github.com:apache/orc.git","clone_url":"https://github.com/apache/orc.git","svn_url":"https://github.com/apache/orc","homepage":null,"size":15272,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":"git://git.apache.org/orc.git","open_issues_count":2,"forks":9,"open_issues":2,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/orc/pulls/12"},"html":{"href":"https://github.com/apache/orc/pull/12"},"issue":{"href":"https://api.github.com/repos/apache/orc/issues/12"},"comments":{"href":"https://api.github.com/repos/apache/orc/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/orc/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/orc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/orc/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/apache/orc/statuses/01ea2074b413d7f95664338dc6df7d20224370f3"}}}}