{"action":"opened","issue":{"url":"https://api.github.com/repos/SlimeKnights/TinkersConstruct/issues/1656","labels_url":"https://api.github.com/repos/SlimeKnights/TinkersConstruct/issues/1656/labels{/name}","comments_url":"https://api.github.com/repos/SlimeKnights/TinkersConstruct/issues/1656/comments","events_url":"https://api.github.com/repos/SlimeKnights/TinkersConstruct/issues/1656/events","html_url":"https://github.com/SlimeKnights/TinkersConstruct/issues/1656","id":88436315,"number":1656,"title":"Possible error in Mystcraft fluid blacklist.","user":{"login":"CombatZAK","id":4730921,"avatar_url":"https://avatars.githubusercontent.com/u/4730921?v=3","gravatar_id":"","url":"https://api.github.com/users/CombatZAK","html_url":"https://github.com/CombatZAK","followers_url":"https://api.github.com/users/CombatZAK/followers","following_url":"https://api.github.com/users/CombatZAK/following{/other_user}","gists_url":"https://api.github.com/users/CombatZAK/gists{/gist_id}","starred_url":"https://api.github.com/users/CombatZAK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CombatZAK/subscriptions","organizations_url":"https://api.github.com/users/CombatZAK/orgs","repos_url":"https://api.github.com/users/CombatZAK/repos","events_url":"https://api.github.com/users/CombatZAK/events{/privacy}","received_events_url":"https://api.github.com/users/CombatZAK/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-06-15T14:01:57Z","updated_at":"2015-06-15T14:01:57Z","closed_at":null,"body":"I have spent the last few days investigating some anomalies in mod compatibility behavior between Tinkers' Construct and Mystcraft. It turns out the TConstruct implementation of blacklisting fluids via IMC exposed a hidden bug in the Mystcraft code that caused all fluids examined after a blacklisted fluid to also be removed, even if they weren't on the blacklist. For reference: https://github.com/XCompWiz/Mystcraft-Issues/issues/97\r\n\r\nXCompWiz released the fix for this bug on 12-June. However, during that investigation, I believe I have uncovered two mistakes in the TinkerMystcraft class in Tinkers' Construct.\r\n\r\nHere is the **init** method from TinkerMystcraft.java file:\r\n\r\n```java\r\n@Handler\r\npublic void init (FMLInitializationEvent event)\r\n{\r\n\tfinal Fluid[] fluids = new Fluid[] {\r\n\t\t\t// precious tinker fluids\r\n\t\t\tmoltenGoldFluid,\r\n\t\t\tmoltenSteelFluid,\r\n\t\t\tmoltenEmeraldFluid,\r\n\t\t\tmoltenArditeFluid,\r\n\t\t\tmoltenCobaltFluid,\r\n\t\t\t// all alloys\r\n\t\t\tpigIronFluid,\r\n\t\t\tmoltenBronzeFluid,\r\n\t\t\tmoltenAlumiteFluid,\r\n\t\t\tmoltenAlubrassFluid,\r\n\t\t\tmoltenManyullynFluid,\r\n\t\t\t// precious TE fluids\r\n\t\t\tmoltenEnderFluid,\r\n\t\t\tmoltenSilverFluid,\r\n\t\t\tmoltenInvarFluid,\r\n\t\t\tmoltenElectrumFluid,\r\n\t\t\tmoltenShinyFluid,\r\n\t\t\tmoltenSignalumFluid,\r\n\t\t\tmoltenLumiumFluid,\r\n\t\t\tmoltenMithrilFluid\r\n\t};\r\n\r\n\tTConstruct.logger.info(\"Mystcraft detected. Blacklisting Mystcraft fluid symbols.\");\r\n\tfor(Fluid fluid : fluids)\r\n\t{\r\n\t\tif(fluid == null)\r\n\t\t\tcontinue;\r\n\t\tFMLInterModComms.sendMessage(\"Mystcraft\", \"blacklistfluid\", fluid.getName());\r\n\t}\r\n}\r\n```\r\n\r\nThe list includes one fluid that should probably not be there and is missing one fluid that probably should (very likely these things are related). The fluids in question are **moltenEnderFluid** and **moltenEnderiumFluid**.\r\n\r\n**moltenEnderFluid** very likely *Resonant Ender* is a Thermal Foundation fluid, not registered for Tinker's Construct compatibility, and TConstruct probably doesn't have standing to blacklist it. That choice/responsibility should fall to Team CoFH.\r\n\r\nBy contrast, **moltenEnderiumFluid**, very likely *Molten Enderium* is an alloy fluid added for Thermal Foundation / Tinkers' Construct compatibility: a means for creating Enderium Alloy in a Tinker's Construct smeltery. I suspect this is the precious fluid that was intended for blacklisting in the TinkerMystcraft class.\r\n\r\nI'll close this by saying that I have not had an opportunity to examine every facet of this issue. Any problems with blacklisting fluids in Mystcraft has been hidden for several months by the aforementioned Mystcraft bug. This included the unexpected blacklisting of materials that the Tinkers' Construct team did not intend to block - copper, tin, iron and aluminum, for example. However, I can confirm that even prior to the Mystcraft#97 fix, Molten Enderium was *not* blacklisted when TConstruct and Mystcraft were in the environment. In fact is was one of the two fluids that actually survived the Mystcraft anomaly - that is confirmation enough for me that even with the fix in place, oceans of Molten Enderium will probably still appear in Mystcraft ages.\r\n\r\nTL;DR summary: TinkerMystcraft class should probably not include moltenEnderFluid and should definitely include moltenEnderiumFluid in its blacklist. Also IMC blacklisting should now work as intended on the Mystcraft side."}}