{"action":"created","comment":{"url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/comments/40832586","id":40832586,"diff_hunk":"@@ -840,6 +840,13 @@ protected function addAnAddress($kind, $address, $name = '')\n             }\n             return false;\n         }\n+        if ($this->hasMultiBytes($address) && function_exists('idn_to_ascii')) {\n+            // can't use $this->parseAddresses, because it calls validateAddress, which will fail here\n+            list($U,$D) = explode('@',$address);","path":"class.phpmailer.php","position":6,"original_position":6,"commit_id":"e563443b1332b65fc76fb8ef82d2c23537f4da16","original_commit_id":"e563443b1332b65fc76fb8ef82d2c23537f4da16","user":{"login":"fbonzon","id":1116761,"avatar_url":"https://avatars.githubusercontent.com/u/1116761?v=3","gravatar_id":"","url":"https://api.github.com/users/fbonzon","html_url":"https://github.com/fbonzon","followers_url":"https://api.github.com/users/fbonzon/followers","following_url":"https://api.github.com/users/fbonzon/following{/other_user}","gists_url":"https://api.github.com/users/fbonzon/gists{/gist_id}","starred_url":"https://api.github.com/users/fbonzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbonzon/subscriptions","organizations_url":"https://api.github.com/users/fbonzon/orgs","repos_url":"https://api.github.com/users/fbonzon/repos","events_url":"https://api.github.com/users/fbonzon/events{/privacy}","received_events_url":"https://api.github.com/users/fbonzon/received_events","type":"User","site_admin":false},"body":"Like $this->parseAddresses that does `if ($useimap and function_exists('imap_rfc822_parse_adrlist'))`, I would first try to use here the builtin imap_rfc822_parse_adrlist() to extract the domain name, and then only use your own parser with explode().\r\n\r\nAlso, your parser should first verify that explode('@',$address) has exactly 2 elements. If there are less, it will produce a PHP Notice error for undefined $D. If there are more elements, the e-mail address is not valid…","created_at":"2015-09-30T18:34:00Z","updated_at":"2015-09-30T18:34:00Z","html_url":"https://github.com/PHPMailer/PHPMailer/pull/516#discussion_r40832586","pull_request_url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/516","_links":{"self":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/comments/40832586"},"html":{"href":"https://github.com/PHPMailer/PHPMailer/pull/516#discussion_r40832586"},"pull_request":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/516"}}},"pull_request":{"url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/516","id":46410244,"html_url":"https://github.com/PHPMailer/PHPMailer/pull/516","diff_url":"https://github.com/PHPMailer/PHPMailer/pull/516.diff","patch_url":"https://github.com/PHPMailer/PHPMailer/pull/516.patch","issue_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/516","number":516,"state":"open","locked":false,"title":"Accept email addresses with an UTF-8 domain","user":{"login":"michield","id":569843,"avatar_url":"https://avatars.githubusercontent.com/u/569843?v=3","gravatar_id":"","url":"https://api.github.com/users/michield","html_url":"https://github.com/michield","followers_url":"https://api.github.com/users/michield/followers","following_url":"https://api.github.com/users/michield/following{/other_user}","gists_url":"https://api.github.com/users/michield/gists{/gist_id}","starred_url":"https://api.github.com/users/michield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michield/subscriptions","organizations_url":"https://api.github.com/users/michield/orgs","repos_url":"https://api.github.com/users/michield/repos","events_url":"https://api.github.com/users/michield/events{/privacy}","received_events_url":"https://api.github.com/users/michield/received_events","type":"User","site_admin":false},"body":"When using a UTF8 address it is rejected with \"You must provide at least one recipient email address\".\r\n\r\nThis patch will accept UTF8 addresses. You can try this with eg \"phplist@phplíst.com\"\r\n\r\nIt requires [idn_to_ascii](http://php.net/idn_to_ascii) to work which is PHP5.3 and up\r\n\r\nIt will still require the MTA to handle UTF8 addresses, which Postfix 3.0 does. But at least PHPMailer won't stop it.","created_at":"2015-09-30T14:40:12Z","updated_at":"2015-09-30T18:34:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"131034478d2987fc537ebce869d4e33a5a8a08c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/516/commits","review_comments_url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/516/comments","review_comment_url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/516/comments","statuses_url":"https://api.github.com/repos/PHPMailer/PHPMailer/statuses/e563443b1332b65fc76fb8ef82d2c23537f4da16","head":{"label":"michield:utf8-validation","ref":"utf8-validation","sha":"e563443b1332b65fc76fb8ef82d2c23537f4da16","user":{"login":"michield","id":569843,"avatar_url":"https://avatars.githubusercontent.com/u/569843?v=3","gravatar_id":"","url":"https://api.github.com/users/michield","html_url":"https://github.com/michield","followers_url":"https://api.github.com/users/michield/followers","following_url":"https://api.github.com/users/michield/following{/other_user}","gists_url":"https://api.github.com/users/michield/gists{/gist_id}","starred_url":"https://api.github.com/users/michield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michield/subscriptions","organizations_url":"https://api.github.com/users/michield/orgs","repos_url":"https://api.github.com/users/michield/repos","events_url":"https://api.github.com/users/michield/events{/privacy}","received_events_url":"https://api.github.com/users/michield/received_events","type":"User","site_admin":false},"repo":{"id":12973645,"name":"PHPMailer","full_name":"michield/PHPMailer","owner":{"login":"michield","id":569843,"avatar_url":"https://avatars.githubusercontent.com/u/569843?v=3","gravatar_id":"","url":"https://api.github.com/users/michield","html_url":"https://github.com/michield","followers_url":"https://api.github.com/users/michield/followers","following_url":"https://api.github.com/users/michield/following{/other_user}","gists_url":"https://api.github.com/users/michield/gists{/gist_id}","starred_url":"https://api.github.com/users/michield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michield/subscriptions","organizations_url":"https://api.github.com/users/michield/orgs","repos_url":"https://api.github.com/users/michield/repos","events_url":"https://api.github.com/users/michield/events{/privacy}","received_events_url":"https://api.github.com/users/michield/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michield/PHPMailer","description":"The classic email sending library for PHP","fork":true,"url":"https://api.github.com/repos/michield/PHPMailer","forks_url":"https://api.github.com/repos/michield/PHPMailer/forks","keys_url":"https://api.github.com/repos/michield/PHPMailer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michield/PHPMailer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michield/PHPMailer/teams","hooks_url":"https://api.github.com/repos/michield/PHPMailer/hooks","issue_events_url":"https://api.github.com/repos/michield/PHPMailer/issues/events{/number}","events_url":"https://api.github.com/repos/michield/PHPMailer/events","assignees_url":"https://api.github.com/repos/michield/PHPMailer/assignees{/user}","branches_url":"https://api.github.com/repos/michield/PHPMailer/branches{/branch}","tags_url":"https://api.github.com/repos/michield/PHPMailer/tags","blobs_url":"https://api.github.com/repos/michield/PHPMailer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michield/PHPMailer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michield/PHPMailer/git/refs{/sha}","trees_url":"https://api.github.com/repos/michield/PHPMailer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michield/PHPMailer/statuses/{sha}","languages_url":"https://api.github.com/repos/michield/PHPMailer/languages","stargazers_url":"https://api.github.com/repos/michield/PHPMailer/stargazers","contributors_url":"https://api.github.com/repos/michield/PHPMailer/contributors","subscribers_url":"https://api.github.com/repos/michield/PHPMailer/subscribers","subscription_url":"https://api.github.com/repos/michield/PHPMailer/subscription","commits_url":"https://api.github.com/repos/michield/PHPMailer/commits{/sha}","git_commits_url":"https://api.github.com/repos/michield/PHPMailer/git/commits{/sha}","comments_url":"https://api.github.com/repos/michield/PHPMailer/comments{/number}","issue_comment_url":"https://api.github.com/repos/michield/PHPMailer/issues/comments{/number}","contents_url":"https://api.github.com/repos/michield/PHPMailer/contents/{+path}","compare_url":"https://api.github.com/repos/michield/PHPMailer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michield/PHPMailer/merges","archive_url":"https://api.github.com/repos/michield/PHPMailer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michield/PHPMailer/downloads","issues_url":"https://api.github.com/repos/michield/PHPMailer/issues{/number}","pulls_url":"https://api.github.com/repos/michield/PHPMailer/pulls{/number}","milestones_url":"https://api.github.com/repos/michield/PHPMailer/milestones{/number}","notifications_url":"https://api.github.com/repos/michield/PHPMailer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michield/PHPMailer/labels{/name}","releases_url":"https://api.github.com/repos/michield/PHPMailer/releases{/id}","created_at":"2013-09-20T13:08:42Z","updated_at":"2015-09-24T08:53:21Z","pushed_at":"2015-09-30T14:35:29Z","git_url":"git://github.com/michield/PHPMailer.git","ssh_url":"git@github.com:michield/PHPMailer.git","clone_url":"https://github.com/michield/PHPMailer.git","svn_url":"https://github.com/michield/PHPMailer","homepage":null,"size":2527,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PHPMailer:master","ref":"master","sha":"e2a9ec16bdbef51efb81adf7fcc6d0bd507e09e1","user":{"login":"PHPMailer","id":3959702,"avatar_url":"https://avatars.githubusercontent.com/u/3959702?v=3","gravatar_id":"","url":"https://api.github.com/users/PHPMailer","html_url":"https://github.com/PHPMailer","followers_url":"https://api.github.com/users/PHPMailer/followers","following_url":"https://api.github.com/users/PHPMailer/following{/other_user}","gists_url":"https://api.github.com/users/PHPMailer/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPMailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPMailer/subscriptions","organizations_url":"https://api.github.com/users/PHPMailer/orgs","repos_url":"https://api.github.com/users/PHPMailer/repos","events_url":"https://api.github.com/users/PHPMailer/events{/privacy}","received_events_url":"https://api.github.com/users/PHPMailer/received_events","type":"Organization","site_admin":false},"repo":{"id":2253830,"name":"PHPMailer","full_name":"PHPMailer/PHPMailer","owner":{"login":"PHPMailer","id":3959702,"avatar_url":"https://avatars.githubusercontent.com/u/3959702?v=3","gravatar_id":"","url":"https://api.github.com/users/PHPMailer","html_url":"https://github.com/PHPMailer","followers_url":"https://api.github.com/users/PHPMailer/followers","following_url":"https://api.github.com/users/PHPMailer/following{/other_user}","gists_url":"https://api.github.com/users/PHPMailer/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPMailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPMailer/subscriptions","organizations_url":"https://api.github.com/users/PHPMailer/orgs","repos_url":"https://api.github.com/users/PHPMailer/repos","events_url":"https://api.github.com/users/PHPMailer/events{/privacy}","received_events_url":"https://api.github.com/users/PHPMailer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PHPMailer/PHPMailer","description":"The classic email sending library for PHP","fork":false,"url":"https://api.github.com/repos/PHPMailer/PHPMailer","forks_url":"https://api.github.com/repos/PHPMailer/PHPMailer/forks","keys_url":"https://api.github.com/repos/PHPMailer/PHPMailer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PHPMailer/PHPMailer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PHPMailer/PHPMailer/teams","hooks_url":"https://api.github.com/repos/PHPMailer/PHPMailer/hooks","issue_events_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/events{/number}","events_url":"https://api.github.com/repos/PHPMailer/PHPMailer/events","assignees_url":"https://api.github.com/repos/PHPMailer/PHPMailer/assignees{/user}","branches_url":"https://api.github.com/repos/PHPMailer/PHPMailer/branches{/branch}","tags_url":"https://api.github.com/repos/PHPMailer/PHPMailer/tags","blobs_url":"https://api.github.com/repos/PHPMailer/PHPMailer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PHPMailer/PHPMailer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PHPMailer/PHPMailer/git/refs{/sha}","trees_url":"https://api.github.com/repos/PHPMailer/PHPMailer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PHPMailer/PHPMailer/statuses/{sha}","languages_url":"https://api.github.com/repos/PHPMailer/PHPMailer/languages","stargazers_url":"https://api.github.com/repos/PHPMailer/PHPMailer/stargazers","contributors_url":"https://api.github.com/repos/PHPMailer/PHPMailer/contributors","subscribers_url":"https://api.github.com/repos/PHPMailer/PHPMailer/subscribers","subscription_url":"https://api.github.com/repos/PHPMailer/PHPMailer/subscription","commits_url":"https://api.github.com/repos/PHPMailer/PHPMailer/commits{/sha}","git_commits_url":"https://api.github.com/repos/PHPMailer/PHPMailer/git/commits{/sha}","comments_url":"https://api.github.com/repos/PHPMailer/PHPMailer/comments{/number}","issue_comment_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/comments{/number}","contents_url":"https://api.github.com/repos/PHPMailer/PHPMailer/contents/{+path}","compare_url":"https://api.github.com/repos/PHPMailer/PHPMailer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PHPMailer/PHPMailer/merges","archive_url":"https://api.github.com/repos/PHPMailer/PHPMailer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PHPMailer/PHPMailer/downloads","issues_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues{/number}","pulls_url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls{/number}","milestones_url":"https://api.github.com/repos/PHPMailer/PHPMailer/milestones{/number}","notifications_url":"https://api.github.com/repos/PHPMailer/PHPMailer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PHPMailer/PHPMailer/labels{/name}","releases_url":"https://api.github.com/repos/PHPMailer/PHPMailer/releases{/id}","created_at":"2011-08-23T07:57:17Z","updated_at":"2015-09-30T16:06:27Z","pushed_at":"2015-09-30T14:40:13Z","git_url":"git://github.com/PHPMailer/PHPMailer.git","ssh_url":"git@github.com:PHPMailer/PHPMailer.git","clone_url":"https://github.com/PHPMailer/PHPMailer.git","svn_url":"https://github.com/PHPMailer/PHPMailer","homepage":null,"size":6597,"stargazers_count":4631,"watchers_count":4631,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2901,"mirror_url":null,"open_issues_count":28,"forks":2901,"open_issues":28,"watchers":4631,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/516"},"html":{"href":"https://github.com/PHPMailer/PHPMailer/pull/516"},"issue":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/516"},"comments":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/PHPMailer/PHPMailer/statuses/e563443b1332b65fc76fb8ef82d2c23537f4da16"}}}}