{"action":"created","issue":{"url":"https://api.github.com/repos/grahams/safari-utm-stripper/issues/4","labels_url":"https://api.github.com/repos/grahams/safari-utm-stripper/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/grahams/safari-utm-stripper/issues/4/comments","events_url":"https://api.github.com/repos/grahams/safari-utm-stripper/issues/4/events","html_url":"https://github.com/grahams/safari-utm-stripper/issues/4","id":94597962,"number":4,"title":"Pull in changes from mihaip/utm-stripper","user":{"login":"liam-m","id":3648097,"avatar_url":"https://avatars.githubusercontent.com/u/3648097?v=3","gravatar_id":"","url":"https://api.github.com/users/liam-m","html_url":"https://github.com/liam-m","followers_url":"https://api.github.com/users/liam-m/followers","following_url":"https://api.github.com/users/liam-m/following{/other_user}","gists_url":"https://api.github.com/users/liam-m/gists{/gist_id}","starred_url":"https://api.github.com/users/liam-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liam-m/subscriptions","organizations_url":"https://api.github.com/users/liam-m/orgs","repos_url":"https://api.github.com/users/liam-m/repos","events_url":"https://api.github.com/users/liam-m/events{/privacy}","received_events_url":"https://api.github.com/users/liam-m/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-12T20:44:35Z","updated_at":"2015-12-13T14:33:52Z","closed_at":"2015-12-13T07:09:24Z","body":"Hey @grahams, I've been using [mihaip/utm-stripper](https://github.com/mihaip/utm-stripper) which is a fork of [jparise/chrome-utm-stripper](https://github.com/jparise/chrome-utm-stripper) with some improvements (some of which were authored by me). \r\n\r\nWould you be interested in including any of these improvements in this extension? The ones I can see are:\r\n\r\n* Fixed URL parsing when there are parameters after UTM ones - https://github.com/mihaip/utm-stripper/commit/4561b7d89d8de0c9febc5a8477b278ce395c099e (not sure if this affects this extension)\r\n* Strips utm_reader - https://github.com/mihaip/utm-stripper/commit/52aa2788f9a0f64f6bda048fbd464b713781923e\r\n* Strips YouTube URLs - https://github.com/mihaip/utm-stripper/commit/2e506321bbeb4609078be415bb07633296148f4c, https://github.com/mihaip/utm-stripper/commit/f1bf60c699ee6b09ac119c0fbe84022fc9b8338c and https://github.com/mihaip/utm-stripper/commit/b202a3488236357ff2e87aab7cc07308d39ac260\r\n* Strips MailChimp tracking parameters - https://github.com/mihaip/utm-stripper/commit/f1bf60c699ee6b09ac119c0fbe84022fc9b8338c\r\n\r\nI think it would mainly be copying code from [background.js](https://github.com/mihaip/utm-stripper/blob/master/extension/background.js) to [charisma.js](https://github.com/grahams/safari-utm-stripper/blob/master/safari-utm-stripper.safariextension/charisma.js).\r\n\r\nThe extension also has some tests you could use to verify everything works.\r\n\r\nI'm trying to use Safari as my default browser on El Cap so anything I can do to reach extension parity with Chrome would be great. I'd be happy to implement/test any changes. I'm not currently a member of the ADP (I was a member of the Safari one but it's now been integrated to the main one, which costs money) which I think is required to be able to develop an extension."},"comment":{"url":"https://api.github.com/repos/grahams/safari-utm-stripper/issues/comments/164263388","html_url":"https://github.com/grahams/safari-utm-stripper/issues/4#issuecomment-164263388","issue_url":"https://api.github.com/repos/grahams/safari-utm-stripper/issues/4","id":164263388,"user":{"login":"liam-m","id":3648097,"avatar_url":"https://avatars.githubusercontent.com/u/3648097?v=3","gravatar_id":"","url":"https://api.github.com/users/liam-m","html_url":"https://github.com/liam-m","followers_url":"https://api.github.com/users/liam-m/followers","following_url":"https://api.github.com/users/liam-m/following{/other_user}","gists_url":"https://api.github.com/users/liam-m/gists{/gist_id}","starred_url":"https://api.github.com/users/liam-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liam-m/subscriptions","organizations_url":"https://api.github.com/users/liam-m/orgs","repos_url":"https://api.github.com/users/liam-m/repos","events_url":"https://api.github.com/users/liam-m/events{/privacy}","received_events_url":"https://api.github.com/users/liam-m/received_events","type":"User","site_admin":false},"created_at":"2015-12-13T14:33:52Z","updated_at":"2015-12-13T14:33:52Z","body":"<img width=\"532\" alt=\"screen shot 2015-12-13 at 14 33 41\" src=\"https://cloud.githubusercontent.com/assets/3648097/11767478/85a1859c-a1a6-11e5-94ef-963f796cfbec.png\">\r\n"}}