{"action":"created","issue":{"url":"https://api.github.com/repos/ssj71/infamousPlugins/issues/4","labels_url":"https://api.github.com/repos/ssj71/infamousPlugins/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/ssj71/infamousPlugins/issues/4/comments","events_url":"https://api.github.com/repos/ssj71/infamousPlugins/issues/4/events","html_url":"https://github.com/ssj71/infamousPlugins/pull/4","id":105747853,"number":4,"title":"refactor CMakeLists.txt files","user":{"login":"ycollet","id":1255536,"avatar_url":"https://avatars.githubusercontent.com/u/1255536?v=3","gravatar_id":"","url":"https://api.github.com/users/ycollet","html_url":"https://github.com/ycollet","followers_url":"https://api.github.com/users/ycollet/followers","following_url":"https://api.github.com/users/ycollet/following{/other_user}","gists_url":"https://api.github.com/users/ycollet/gists{/gist_id}","starred_url":"https://api.github.com/users/ycollet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycollet/subscriptions","organizations_url":"https://api.github.com/users/ycollet/orgs","repos_url":"https://api.github.com/users/ycollet/repos","events_url":"https://api.github.com/users/ycollet/events{/privacy}","received_events_url":"https://api.github.com/users/ycollet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-10T07:32:56Z","updated_at":"2015-09-15T06:00:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ssj71/infamousPlugins/pulls/4","html_url":"https://github.com/ssj71/infamousPlugins/pull/4","diff_url":"https://github.com/ssj71/infamousPlugins/pull/4.diff","patch_url":"https://github.com/ssj71/infamousPlugins/pull/4.patch"},"body":"Put package detection in the main CMakeLists.txt file.\r\nPut compiler flags in the main CMakeLists.txt file."},"comment":{"url":"https://api.github.com/repos/ssj71/infamousPlugins/issues/comments/140289267","html_url":"https://github.com/ssj71/infamousPlugins/pull/4#issuecomment-140289267","issue_url":"https://api.github.com/repos/ssj71/infamousPlugins/issues/4","id":140289267,"user":{"login":"ycollet","id":1255536,"avatar_url":"https://avatars.githubusercontent.com/u/1255536?v=3","gravatar_id":"","url":"https://api.github.com/users/ycollet","html_url":"https://github.com/ycollet","followers_url":"https://api.github.com/users/ycollet/followers","following_url":"https://api.github.com/users/ycollet/following{/other_user}","gists_url":"https://api.github.com/users/ycollet/gists{/gist_id}","starred_url":"https://api.github.com/users/ycollet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycollet/subscriptions","organizations_url":"https://api.github.com/users/ycollet/orgs","repos_url":"https://api.github.com/users/ycollet/repos","events_url":"https://api.github.com/users/ycollet/events{/privacy}","received_events_url":"https://api.github.com/users/ycollet/received_events","type":"User","site_admin":false},"created_at":"2015-09-15T06:00:45Z","updated_at":"2015-09-15T06:00:45Z","body":"Most of the time, when you compile plugins, you compile all the set of \nplugins depending on the libraries discovered on your system.\nFor example, for the plugin depending on zita resampler, if zita \nresample is not found on your system, then all the plugins will be built \nexcepted the one depending on zita resampler.\nThat's why I adjusted the CMakeLists.txt files like this.\nOn advantage: all the discovery machinery is centralized in one \nCMakeLists.txt file. The other advantage: if you want to change the \ncompiler flags, then this can be done in the main CMakeLists.txt file.\n\nBest regards,\n\nYC\n\nLe 14/09/2015 23:53, ssj71 a écrit :\n>\n> ok, I've looked at this. This breaks the ability to build any single \n> plugin by running cmake in its individual folder. What is the reason \n> for these changes you propose to the cmake files?\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/ssj71/infamousPlugins/pull/4#issuecomment-140215871>.\n>\n\n"}}