{"action":"closed","number":2579,"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/2579","id":54064424,"html_url":"https://github.com/callemall/material-ui/pull/2579","diff_url":"https://github.com/callemall/material-ui/pull/2579.diff","patch_url":"https://github.com/callemall/material-ui/pull/2579.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/2579","number":2579,"state":"closed","locked":false,"title":"[DatePicker] Call setState-muiTheme in componentWillReceiveProps","user":{"login":"ntgn81","id":4622542,"avatar_url":"https://avatars.githubusercontent.com/u/4622542?v=3","gravatar_id":"","url":"https://api.github.com/users/ntgn81","html_url":"https://github.com/ntgn81","followers_url":"https://api.github.com/users/ntgn81/followers","following_url":"https://api.github.com/users/ntgn81/following{/other_user}","gists_url":"https://api.github.com/users/ntgn81/gists{/gist_id}","starred_url":"https://api.github.com/users/ntgn81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntgn81/subscriptions","organizations_url":"https://api.github.com/users/ntgn81/orgs","repos_url":"https://api.github.com/users/ntgn81/repos","events_url":"https://api.github.com/users/ntgn81/events{/privacy}","received_events_url":"https://api.github.com/users/ntgn81/received_events","type":"User","site_admin":false},"body":"DatePicker does not update state.muiTheme on componentWillReceiveProps, resulting in the child component (TextField) not receiving updated theme values.\r\n\r\nSide note - would this conditional way of calling `this.setState` save a few milliseconds of calculation as compared to calling `this.setState{muiTheme:...}` without any checks like in all other components? \r\n```js\r\n// Taken from flat-button-label.jsx\r\n  componentWillReceiveProps(nextProps, nextContext) {\r\n    let newMuiTheme = nextContext.muiTheme ? nextContext.muiTheme : this.state.muiTheme;\r\n    this.setState({muiTheme: newMuiTheme});\r\n  }\r\n```\r\n\r\n\r\n![](http://g.recordit.co/z6TcCpk0sX.gif)","created_at":"2015-12-18T04:38:12Z","updated_at":"2015-12-18T07:45:37Z","closed_at":"2015-12-18T07:45:37Z","merged_at":"2015-12-18T07:45:37Z","merge_commit_sha":"b8e9434e890e72fda7608720789e10ec5e059e81","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/2579/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/2579/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/2579/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/c6a6d01e61129e3dbd1fa650be16b2b115ebaddb","head":{"label":"ntgn81:date-picker-update-muiTheme","ref":"date-picker-update-muiTheme","sha":"c6a6d01e61129e3dbd1fa650be16b2b115ebaddb","user":{"login":"ntgn81","id":4622542,"avatar_url":"https://avatars.githubusercontent.com/u/4622542?v=3","gravatar_id":"","url":"https://api.github.com/users/ntgn81","html_url":"https://github.com/ntgn81","followers_url":"https://api.github.com/users/ntgn81/followers","following_url":"https://api.github.com/users/ntgn81/following{/other_user}","gists_url":"https://api.github.com/users/ntgn81/gists{/gist_id}","starred_url":"https://api.github.com/users/ntgn81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntgn81/subscriptions","organizations_url":"https://api.github.com/users/ntgn81/orgs","repos_url":"https://api.github.com/users/ntgn81/repos","events_url":"https://api.github.com/users/ntgn81/events{/privacy}","received_events_url":"https://api.github.com/users/ntgn81/received_events","type":"User","site_admin":false},"repo":{"id":48113376,"name":"material-ui","full_name":"ntgn81/material-ui","owner":{"login":"ntgn81","id":4622542,"avatar_url":"https://avatars.githubusercontent.com/u/4622542?v=3","gravatar_id":"","url":"https://api.github.com/users/ntgn81","html_url":"https://github.com/ntgn81","followers_url":"https://api.github.com/users/ntgn81/followers","following_url":"https://api.github.com/users/ntgn81/following{/other_user}","gists_url":"https://api.github.com/users/ntgn81/gists{/gist_id}","starred_url":"https://api.github.com/users/ntgn81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntgn81/subscriptions","organizations_url":"https://api.github.com/users/ntgn81/orgs","repos_url":"https://api.github.com/users/ntgn81/repos","events_url":"https://api.github.com/users/ntgn81/events{/privacy}","received_events_url":"https://api.github.com/users/ntgn81/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ntgn81/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/ntgn81/material-ui","forks_url":"https://api.github.com/repos/ntgn81/material-ui/forks","keys_url":"https://api.github.com/repos/ntgn81/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ntgn81/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ntgn81/material-ui/teams","hooks_url":"https://api.github.com/repos/ntgn81/material-ui/hooks","issue_events_url":"https://api.github.com/repos/ntgn81/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/ntgn81/material-ui/events","assignees_url":"https://api.github.com/repos/ntgn81/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/ntgn81/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/ntgn81/material-ui/tags","blobs_url":"https://api.github.com/repos/ntgn81/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ntgn81/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ntgn81/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ntgn81/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ntgn81/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/ntgn81/material-ui/languages","stargazers_url":"https://api.github.com/repos/ntgn81/material-ui/stargazers","contributors_url":"https://api.github.com/repos/ntgn81/material-ui/contributors","subscribers_url":"https://api.github.com/repos/ntgn81/material-ui/subscribers","subscription_url":"https://api.github.com/repos/ntgn81/material-ui/subscription","commits_url":"https://api.github.com/repos/ntgn81/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ntgn81/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ntgn81/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ntgn81/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ntgn81/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/ntgn81/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ntgn81/material-ui/merges","archive_url":"https://api.github.com/repos/ntgn81/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ntgn81/material-ui/downloads","issues_url":"https://api.github.com/repos/ntgn81/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/ntgn81/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/ntgn81/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/ntgn81/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ntgn81/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/ntgn81/material-ui/releases{/id}","created_at":"2015-12-16T13:56:55Z","updated_at":"2015-12-16T13:56:57Z","pushed_at":"2015-12-18T04:23:41Z","git_url":"git://github.com/ntgn81/material-ui.git","ssh_url":"git@github.com:ntgn81/material-ui.git","clone_url":"https://github.com/ntgn81/material-ui.git","svn_url":"https://github.com/ntgn81/material-ui","homepage":"http://www.material-ui.com","size":34648,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:master","ref":"master","sha":"73daef7565c45dbaee52f0a15a963b50e58ea9f9","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","created_at":"2014-08-18T19:11:54Z","updated_at":"2015-12-18T02:42:33Z","pushed_at":"2015-12-18T07:45:37Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":39121,"stargazers_count":12502,"watchers_count":12502,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2031,"mirror_url":null,"open_issues_count":453,"forks":2031,"open_issues":453,"watchers":12502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2579"},"html":{"href":"https://github.com/callemall/material-ui/pull/2579"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/2579"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/2579/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2579/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2579/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/c6a6d01e61129e3dbd1fa650be16b2b115ebaddb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":1}}