{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/comments/46498676","id":46498676,"diff_hunk":"@@ -47,36 +55,46 @@ function Get-TargetResource\n     Write-Verbose -Message ( @( \"$($MyInvocation.MyCommand): \"\n         $($LocalizedData.GettingDNSServerAddressesMessage)\n         ) -join '')\n+    \n+    # obtain all the interface addresses\n+    $dnsClientServerAddresses = Get-NetAdapter -Name $InterfaceAlias `","path":"DSCResources/MSFT_xDNSServerAddress/MSFT_xDNSServerAddress.psm1","position":59,"original_position":59,"commit_id":"348e680cf9223dd31693c0b1741aff5a0ce45bf8","original_commit_id":"348e680cf9223dd31693c0b1741aff5a0ce45bf8","user":{"login":"tysonjhayes","id":651851,"avatar_url":"https://avatars.githubusercontent.com/u/651851?v=3","gravatar_id":"","url":"https://api.github.com/users/tysonjhayes","html_url":"https://github.com/tysonjhayes","followers_url":"https://api.github.com/users/tysonjhayes/followers","following_url":"https://api.github.com/users/tysonjhayes/following{/other_user}","gists_url":"https://api.github.com/users/tysonjhayes/gists{/gist_id}","starred_url":"https://api.github.com/users/tysonjhayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysonjhayes/subscriptions","organizations_url":"https://api.github.com/users/tysonjhayes/orgs","repos_url":"https://api.github.com/users/tysonjhayes/repos","events_url":"https://api.github.com/users/tysonjhayes/events{/privacy}","received_events_url":"https://api.github.com/users/tysonjhayes/received_events","type":"User","site_admin":false},"body":"Could you help me understand this change better? I'm not sure I'm clear on why its needed? Also when testing it on my machine I get an error when running this command.\r\n\r\n````powershell\r\n[4:29:27 PM] [pr-57] [0057] » Get-TargetResource -Address '127.0.0.1' -InterfaceAlias '*Ethernet*' -AddressFamily 'IPv4'\r\nGet-DnsClientServerAddress : No matching MSFT_DNSClientServerAddress objects found by CIM query for instances of the ROOT/StandardCimv2/MSFT_DNSClientServerAddress class on the  CIM server: SELECT * FROM MSFT_DNSClientServerAddress\r\nWHERE ((InterfaceAlias LIKE 'MSFT[_]NetAdapter (CreationClassName = \"MSFT[_]NetAdapter\", DeviceID = \"{EB44F4BF-30C1-401E-821A-AAAF8229A5E6}\", SystemCreationClassName = \"CIM[_]NetworkPort\", SystemName =\r\n\"<ComputerName>)')) AND ((AddressFamily = 2)). Verify query parameters and retry.\r\nAt C:\\GitHub\\tysonjhayes\\xNetworking\\DSCResources\\MSFT_xDNSServerAddress\\MSFT_xDNSServerAddress.psm1:61 char:24\r\n+     | ForEach-Object { Get-DnsClientServerAddress -InterfaceAlias $_  -AddressFa ...\r\n+                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n    + CategoryInfo          : ObjectNotFound: (MSFT_DNSClientServerAddress:String) [Get-DnsClientServerAddress], CimJobException\r\n    + FullyQualifiedErrorId : CmdletizationQuery_NotFound,Get-DnsClientServerAddress\r\n````\r\n\r\nI get the same thing when I don't try a wild card for the interface alias. Where the previous comamnd worked fine.","created_at":"2015-12-03T00:35:24Z","updated_at":"2015-12-03T00:35:24Z","html_url":"https://github.com/PowerShell/xNetworking/pull/57#discussion_r46498676","pull_request_url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/comments/46498676"},"html":{"href":"https://github.com/PowerShell/xNetworking/pull/57#discussion_r46498676"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/57","id":51141737,"html_url":"https://github.com/PowerShell/xNetworking/pull/57","diff_url":"https://github.com/PowerShell/xNetworking/pull/57.diff","patch_url":"https://github.com/PowerShell/xNetworking/pull/57.patch","issue_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/57","number":57,"state":"open","locked":false,"title":"Add wild card support for $InterfaceAlias.","user":{"login":"guitarrapc","id":3856350,"avatar_url":"https://avatars.githubusercontent.com/u/3856350?v=3","gravatar_id":"","url":"https://api.github.com/users/guitarrapc","html_url":"https://github.com/guitarrapc","followers_url":"https://api.github.com/users/guitarrapc/followers","following_url":"https://api.github.com/users/guitarrapc/following{/other_user}","gists_url":"https://api.github.com/users/guitarrapc/gists{/gist_id}","starred_url":"https://api.github.com/users/guitarrapc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitarrapc/subscriptions","organizations_url":"https://api.github.com/users/guitarrapc/orgs","repos_url":"https://api.github.com/users/guitarrapc/repos","events_url":"https://api.github.com/users/guitarrapc/events{/privacy}","received_events_url":"https://api.github.com/users/guitarrapc/received_events","type":"User","site_admin":false},"body":"Description\r\n----\r\n\r\nThis is re-create PR from https://github.com/PowerShell/xNetworking/pull/56 to be merged to dev branch.\r\n\r\nThere used to be support Wildcard for InterfaceAlis, but degraded with commit https://github.com/PowerShell/xNetworking/commit/89a9d95b611782a1848f7c9a3a66d550ab0a4afa#diff-da1b602b4060c5ac9213c9b402ca75aaR178\r\n\r\nThis PR add Wildcard support for InterfaceAlias.\r\n\r\nThere are many cases that user couldn't know or promise interface alias. Something like it is  \"Ethernet\" or \"Ethernet 2\" or \"Enternet n...\" in Cloud Infrastructure. Thus Wildcard support is useful and should be better supported.\r\n\r\nReproduce Procedure\r\n----\r\n\r\n```powershell\r\nconfiguration Hoge\r\n{\r\n    Import-DSCResource -Module xNetworking\r\n    xDNSServerAddress Test\r\n    {\r\n        Address = \"10.0.0.10\"\r\n        InterfaceAlias = \"Etthernet*\"\r\n        AddressFamily = \"IPv4\"\r\n    }\r\n}\r\n\r\nHoge\r\nStart-DscConfiguration -Verbose -Wait -Path Hoge -Force\r\nTest-DscConfiguration\r\nGet-DscConfiguration\r\n```\r\n\r\nIt will fail with previous psm1, but success in this PR as following.\r\n\r\n```\r\nAddress        : {10.0.0.10}\r\nAddressFamily  : IPv4\r\nInterfaceAlias : Ehternet*\r\nPSComputerName : \r\n```\r\n","created_at":"2015-11-18T21:03:26Z","updated_at":"2015-12-03T00:35:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4124bd9db7f754b7a05eff86ae0efead34ede38a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/57/commits","review_comments_url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/57/comments","review_comment_url":"https://api.github.com/repos/PowerShell/xNetworking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/57/comments","statuses_url":"https://api.github.com/repos/PowerShell/xNetworking/statuses/348e680cf9223dd31693c0b1741aff5a0ce45bf8","head":{"label":"guitarrapc:AddWildcardSupport","ref":"AddWildcardSupport","sha":"348e680cf9223dd31693c0b1741aff5a0ce45bf8","user":{"login":"guitarrapc","id":3856350,"avatar_url":"https://avatars.githubusercontent.com/u/3856350?v=3","gravatar_id":"","url":"https://api.github.com/users/guitarrapc","html_url":"https://github.com/guitarrapc","followers_url":"https://api.github.com/users/guitarrapc/followers","following_url":"https://api.github.com/users/guitarrapc/following{/other_user}","gists_url":"https://api.github.com/users/guitarrapc/gists{/gist_id}","starred_url":"https://api.github.com/users/guitarrapc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitarrapc/subscriptions","organizations_url":"https://api.github.com/users/guitarrapc/orgs","repos_url":"https://api.github.com/users/guitarrapc/repos","events_url":"https://api.github.com/users/guitarrapc/events{/privacy}","received_events_url":"https://api.github.com/users/guitarrapc/received_events","type":"User","site_admin":false},"repo":{"id":46394283,"name":"xNetworking","full_name":"guitarrapc/xNetworking","owner":{"login":"guitarrapc","id":3856350,"avatar_url":"https://avatars.githubusercontent.com/u/3856350?v=3","gravatar_id":"","url":"https://api.github.com/users/guitarrapc","html_url":"https://github.com/guitarrapc","followers_url":"https://api.github.com/users/guitarrapc/followers","following_url":"https://api.github.com/users/guitarrapc/following{/other_user}","gists_url":"https://api.github.com/users/guitarrapc/gists{/gist_id}","starred_url":"https://api.github.com/users/guitarrapc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitarrapc/subscriptions","organizations_url":"https://api.github.com/users/guitarrapc/orgs","repos_url":"https://api.github.com/users/guitarrapc/repos","events_url":"https://api.github.com/users/guitarrapc/events{/privacy}","received_events_url":"https://api.github.com/users/guitarrapc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guitarrapc/xNetworking","description":null,"fork":true,"url":"https://api.github.com/repos/guitarrapc/xNetworking","forks_url":"https://api.github.com/repos/guitarrapc/xNetworking/forks","keys_url":"https://api.github.com/repos/guitarrapc/xNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guitarrapc/xNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guitarrapc/xNetworking/teams","hooks_url":"https://api.github.com/repos/guitarrapc/xNetworking/hooks","issue_events_url":"https://api.github.com/repos/guitarrapc/xNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/guitarrapc/xNetworking/events","assignees_url":"https://api.github.com/repos/guitarrapc/xNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/guitarrapc/xNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/guitarrapc/xNetworking/tags","blobs_url":"https://api.github.com/repos/guitarrapc/xNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guitarrapc/xNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guitarrapc/xNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/guitarrapc/xNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guitarrapc/xNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/guitarrapc/xNetworking/languages","stargazers_url":"https://api.github.com/repos/guitarrapc/xNetworking/stargazers","contributors_url":"https://api.github.com/repos/guitarrapc/xNetworking/contributors","subscribers_url":"https://api.github.com/repos/guitarrapc/xNetworking/subscribers","subscription_url":"https://api.github.com/repos/guitarrapc/xNetworking/subscription","commits_url":"https://api.github.com/repos/guitarrapc/xNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/guitarrapc/xNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/guitarrapc/xNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/guitarrapc/xNetworking/issues/comments{/number}","contents_url":"https://api.github.com/repos/guitarrapc/xNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/guitarrapc/xNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guitarrapc/xNetworking/merges","archive_url":"https://api.github.com/repos/guitarrapc/xNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guitarrapc/xNetworking/downloads","issues_url":"https://api.github.com/repos/guitarrapc/xNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/guitarrapc/xNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/guitarrapc/xNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/guitarrapc/xNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guitarrapc/xNetworking/labels{/name}","releases_url":"https://api.github.com/repos/guitarrapc/xNetworking/releases{/id}","created_at":"2015-11-18T04:05:12Z","updated_at":"2015-11-18T04:05:13Z","pushed_at":"2015-12-01T06:35:45Z","git_url":"git://github.com/guitarrapc/xNetworking.git","ssh_url":"git@github.com:guitarrapc/xNetworking.git","clone_url":"https://github.com/guitarrapc/xNetworking.git","svn_url":"https://github.com/guitarrapc/xNetworking","homepage":null,"size":277,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"PowerShell:dev","ref":"dev","sha":"2153baba53263a0a8fa7bda8ec6ab040895350c4","user":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":34022240,"name":"xNetworking","full_name":"PowerShell/xNetworking","owner":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/xNetworking","description":null,"fork":false,"url":"https://api.github.com/repos/PowerShell/xNetworking","forks_url":"https://api.github.com/repos/PowerShell/xNetworking/forks","keys_url":"https://api.github.com/repos/PowerShell/xNetworking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/xNetworking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/xNetworking/teams","hooks_url":"https://api.github.com/repos/PowerShell/xNetworking/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/xNetworking/events","assignees_url":"https://api.github.com/repos/PowerShell/xNetworking/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/xNetworking/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/xNetworking/tags","blobs_url":"https://api.github.com/repos/PowerShell/xNetworking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/xNetworking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/xNetworking/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/xNetworking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/xNetworking/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/xNetworking/languages","stargazers_url":"https://api.github.com/repos/PowerShell/xNetworking/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/xNetworking/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/xNetworking/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/xNetworking/subscription","commits_url":"https://api.github.com/repos/PowerShell/xNetworking/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/xNetworking/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/xNetworking/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/xNetworking/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/xNetworking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/xNetworking/merges","archive_url":"https://api.github.com/repos/PowerShell/xNetworking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/xNetworking/downloads","issues_url":"https://api.github.com/repos/PowerShell/xNetworking/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/xNetworking/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/xNetworking/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/xNetworking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/xNetworking/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/xNetworking/releases{/id}","created_at":"2015-04-15T22:43:02Z","updated_at":"2015-12-01T13:33:40Z","pushed_at":"2015-12-02T23:45:04Z","git_url":"git://github.com/PowerShell/xNetworking.git","ssh_url":"git@github.com:PowerShell/xNetworking.git","clone_url":"https://github.com/PowerShell/xNetworking.git","svn_url":"https://github.com/PowerShell/xNetworking","homepage":null,"size":297,"stargazers_count":8,"watchers_count":8,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":8,"forks":14,"open_issues":8,"watchers":8,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/57"},"html":{"href":"https://github.com/PowerShell/xNetworking/pull/57"},"issue":{"href":"https://api.github.com/repos/PowerShell/xNetworking/issues/57"},"comments":{"href":"https://api.github.com/repos/PowerShell/xNetworking/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/xNetworking/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/xNetworking/statuses/348e680cf9223dd31693c0b1741aff5a0ce45bf8"}}}}