{"action":"opened","issue":{"url":"https://api.github.com/repos/artsy/eigen/issues/441","labels_url":"https://api.github.com/repos/artsy/eigen/issues/441/labels{/name}","comments_url":"https://api.github.com/repos/artsy/eigen/issues/441/comments","events_url":"https://api.github.com/repos/artsy/eigen/issues/441/events","html_url":"https://github.com/artsy/eigen/issues/441","id":76691871,"number":441,"title":"Facebook/Twitter sharing popover issues","user":{"login":"alloy","id":2320,"avatar_url":"https://avatars.githubusercontent.com/u/2320?v=3","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/artsy/eigen/labels/ipad","name":"ipad","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/artsy/eigen/milestones/11","html_url":"https://github.com/artsy/eigen/milestones/Sprint%20April%2021%E2%80%93June%202","labels_url":"https://api.github.com/repos/artsy/eigen/milestones/11/labels","id":1076332,"number":11,"title":"Sprint April 21–June 2","description":"","creator":{"login":"katarinabatina","id":6482926,"avatar_url":"https://avatars.githubusercontent.com/u/6482926?v=3","gravatar_id":"","url":"https://api.github.com/users/katarinabatina","html_url":"https://github.com/katarinabatina","followers_url":"https://api.github.com/users/katarinabatina/followers","following_url":"https://api.github.com/users/katarinabatina/following{/other_user}","gists_url":"https://api.github.com/users/katarinabatina/gists{/gist_id}","starred_url":"https://api.github.com/users/katarinabatina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katarinabatina/subscriptions","organizations_url":"https://api.github.com/users/katarinabatina/orgs","repos_url":"https://api.github.com/users/katarinabatina/repos","events_url":"https://api.github.com/users/katarinabatina/events{/privacy}","received_events_url":"https://api.github.com/users/katarinabatina/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":17,"state":"open","created_at":"2015-04-21T01:13:58Z","updated_at":"2015-05-15T10:59:21Z","due_on":"2015-06-02T04:00:00Z","closed_at":null},"comments":0,"created_at":"2015-05-15T10:59:21Z","updated_at":"2015-05-15T10:59:21Z","closed_at":null,"body":"After playing with #367 #435 for a bit, I ran into 2 issues:\r\n\r\n* Because the popover is shown from the touch point, _not_ the view frame, the popover is always in a different place:\r\n\r\n  ![ios simulator screen shot 15 may 2015 12 49 24](https://cloud.githubusercontent.com/assets/2320/7651464/0579c466-fb01-11e4-83c1-284f73b7a467.png)\r\n  ![ios simulator screen shot 15 may 2015 12 49 30](https://cloud.githubusercontent.com/assets/2320/7651466/085d91bc-fb01-11e4-86f4-2f1b39646aa5.png)\r\n\r\n* Changing orientation moves the popover to the wrong location, which without information about how the page will be laid out is going to be hard to get right:\r\n\r\n  ![ios simulator screen shot 15 may 2015 12 45 59](https://cloud.githubusercontent.com/assets/2320/7651487/4453756a-fb01-11e4-86ea-f1d30beeda37.png)\r\n\r\n----\r\n\r\nAll in all, I think that this isn’t the right solution. To get this right we really need to query the web view for the exact frame of the element.\r\n\r\nSo after giving it some more thought, I think that maybe we need to do this completely different, design wise.\r\n\r\n* All the articles on the [overview page](https://www.artsy.net/articles) have share links, but does that really make sense, as you haven’t even really read the article yet by that time?\r\n* It makes more sense to me to share from a specific article’s page, which means that there will only be 1 thing to share per page.\r\n* This also brings it much more in line with native iOS views, where you’d typically share what you’re currently looking at.\r\n* Finally, this means that we can just omit the button on martsy completely when shown in Eigen (see #433) and instead have some `meta` link in the HTML document that Eigen uses to determine it should show a ‘share’ button, which we can then just overlay over the web view. This being a native button takes away _all_ of these layout problems.\r\n\r\n@katarinabatina What do you think?"}}