{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/2369","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2369/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2369/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2369/events","html_url":"https://github.com/mne-tools/mne-python/pull/2369","id":98278851,"number":2369,"title":"[MRG] Fix logic checks in make_forward_solution","user":{"login":"wronk","id":5296721,"avatar_url":"https://avatars.githubusercontent.com/u/5296721?v=3","gravatar_id":"","url":"https://api.github.com/users/wronk","html_url":"https://github.com/wronk","followers_url":"https://api.github.com/users/wronk/followers","following_url":"https://api.github.com/users/wronk/following{/other_user}","gists_url":"https://api.github.com/users/wronk/gists{/gist_id}","starred_url":"https://api.github.com/users/wronk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wronk/subscriptions","organizations_url":"https://api.github.com/users/wronk/orgs","repos_url":"https://api.github.com/users/wronk/repos","events_url":"https://api.github.com/users/wronk/events{/privacy}","received_events_url":"https://api.github.com/users/wronk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-30T22:34:44Z","updated_at":"2015-07-30T23:42:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2369","html_url":"https://github.com/mne-tools/mne-python/pull/2369","diff_url":"https://github.com/mne-tools/mne-python/pull/2369.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/2369.patch"},"body":"Fix the error in `make_forward_solution` where user could erroneously ask for a solution with meg or eeg channels and the computation would bomb if those channels types weren't present."},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/126522344","html_url":"https://github.com/mne-tools/mne-python/pull/2369#issuecomment-126522344","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2369","id":126522344,"user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"created_at":"2015-07-30T23:42:28Z","updated_at":"2015-07-30T23:42:28Z","body":"1. No, don't add a warning. I think those parameters are mostly there for backward compatibility. Also think about cases where you just always want to compute the complete forward solution for your datasets -- with a warning, now you'd need to either do `with warnings.catch_warnings(record=True)` or add a conditional on your calling end to avoid the warning. You can update the docstring to say \"include EEG computations *if EEG channels are present*\" if you really want, but I don't think that's even necessary because what it says right now is correct.\r\n\r\n2. Take a look at what would have been done before (or really even what your code does now). In other words, if `ref_meg` channels get set up in `_prep_meg_channels`, then include them in your check, if not, then don't."}}