{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/-tg-station/issues/9231","labels_url":"https://api.github.com/repos/tgstation/-tg-station/issues/9231/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/issues/9231/comments","events_url":"https://api.github.com/repos/tgstation/-tg-station/issues/9231/events","html_url":"https://github.com/tgstation/-tg-station/pull/9231","id":71823058,"number":9231,"title":"Massive MC and subsystem rewrite","user":{"login":"MrStonedOne","id":7069733,"avatar_url":"https://avatars.githubusercontent.com/u/7069733?v=3","gravatar_id":"","url":"https://api.github.com/users/MrStonedOne","html_url":"https://github.com/MrStonedOne","followers_url":"https://api.github.com/users/MrStonedOne/followers","following_url":"https://api.github.com/users/MrStonedOne/following{/other_user}","gists_url":"https://api.github.com/users/MrStonedOne/gists{/gist_id}","starred_url":"https://api.github.com/users/MrStonedOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrStonedOne/subscriptions","organizations_url":"https://api.github.com/users/MrStonedOne/orgs","repos_url":"https://api.github.com/users/MrStonedOne/repos","events_url":"https://api.github.com/users/MrStonedOne/events{/privacy}","received_events_url":"https://api.github.com/users/MrStonedOne/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tgstation/-tg-station/labels/Atmos","name":"Atmos","color":"FF6EC7"},{"url":"https://api.github.com/repos/tgstation/-tg-station/labels/Blame%20MSO","name":"Blame MSO","color":"F2A5D7"},{"url":"https://api.github.com/repos/tgstation/-tg-station/labels/Performance","name":"Performance","color":"0b02e1"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-04-29T09:13:59Z","updated_at":"2015-04-29T21:14:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/9231","html_url":"https://github.com/tgstation/-tg-station/pull/9231","diff_url":"https://github.com/tgstation/-tg-station/pull/9231.diff","patch_url":"https://github.com/tgstation/-tg-station/pull/9231.patch"},"body":"fixes #9072\r\nmostly fixes #9031 (there is another issue report up for what this doesn't fix)\r\nfixes #4830 (pipenet's init running in the background was causing a race condition causing some pipenets to fail to setup fully. this would not be noticed until something new attempted to add itself to the bad pipenet)\r\nfixes #9209 but somebody else also fixed it(#9228), so I might scrap those changes.\r\nChanges:\r\n\r\n## MC:\r\nNo longer tracks a subsystem's cpu usage. This was basically worthless and took up space on the stat panel\r\n\r\nCan calculate wait down to a tenth of a decisecond to make it fps/world.ticklag agnostic\r\n\r\nNow allows subsystems to have a dynamic wait, this is based on a ratio of how long that subsystem has been taking to process(cost). (This system allows for an upper and lower bounds, and a changeable cost delta for each subsystem) (The algorithm is just cost*cost_delta, defaults to a cost delta of 3)\r\n\r\nMC can now be told to init a zlevel\r\n\r\n## All Subsystems:\r\nStats panel now allows child subsystems to pass it a message to add to its stats entry. All subsystems have been moved over to this system - This should cut down on subsystems having to copy and paste the stats proc in order to add to it\r\n\r\nAll subsystems now properlly handle being given a zlevel in their init proc\r\n\r\n## Subsystem changes:\r\n### Air:\r\nAdded air to the dynamic wait subsystem. upper bound: 50, lower bound: 5, cost delta: 3 times process cost\r\n\r\nAir now fires 4 times faster when it can do so without lagging things up\r\n\r\nPipenet subsystem has been merged into air\r\n\r\nAtmos machinery now processes with process_atmos(), ticked by air, not machinery.\r\n\r\nHotspots (the fire object) are now object pooled\r\n\r\n### Pipenet:\r\nDeleted, added to air\r\n\r\n### Machinery:\r\nMoved all atmos calcualtions in all objects's process() to process_atmos().\r\n\r\n### Lighting:\r\nAdded Lighting to the dynamic wait subsystem. upper bound: 20, lower bound: 5, cost delta: 3 times process cost\r\n\r\n### Ticker:\r\nFixed ticker not updating the lobby panel when game start delayed\r\n\r\nFixed the game start timer updating rapidly from queued fires when game start delay is removed\r\n\r\n### Garbage/qdel:\r\nqdel will now limit its process time to 2ds a fire.\r\n\r\nqdel can now be given hints as a return to Destroy() as to what should be done with the object.\r\nthe options are:\r\n\r\n* queue: (default) this is the normal behavior.\r\n* letmelive: old default to non-null/zero. does nothing with the object\r\n* iwillgc: functionally the same as above, mainly to let people working with objects know that the object will not be queued for GC checking\r\n* harddel: this will queue the object to be deleted without storing a soft reference, mainly to save locate() processing time.\r\n* harddel_now: this will del() the object. To allow for a clean removal of every del() in the code thats not in qdel\r\n\r\nAll objects have been updated to the new system, harddel and iwillgc was not added to any objects.\r\n\r\nFixed some objects not GCing because they didn't properlly clear references in Destory()\r\n\r\nFixed some objects getting qdel'ed preventing other objects from getting GCed because they did not null their reference to that object.\r\n"},"comment":{"url":"https://api.github.com/repos/tgstation/-tg-station/issues/comments/97587206","html_url":"https://github.com/tgstation/-tg-station/pull/9231#issuecomment-97587206","issue_url":"https://api.github.com/repos/tgstation/-tg-station/issues/9231","id":97587206,"user":{"login":"Fox-McCloud","id":5785200,"avatar_url":"https://avatars.githubusercontent.com/u/5785200?v=3","gravatar_id":"","url":"https://api.github.com/users/Fox-McCloud","html_url":"https://github.com/Fox-McCloud","followers_url":"https://api.github.com/users/Fox-McCloud/followers","following_url":"https://api.github.com/users/Fox-McCloud/following{/other_user}","gists_url":"https://api.github.com/users/Fox-McCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/Fox-McCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fox-McCloud/subscriptions","organizations_url":"https://api.github.com/users/Fox-McCloud/orgs","repos_url":"https://api.github.com/users/Fox-McCloud/repos","events_url":"https://api.github.com/users/Fox-McCloud/events{/privacy}","received_events_url":"https://api.github.com/users/Fox-McCloud/received_events","type":"User","site_admin":false},"created_at":"2015-04-29T21:14:04Z","updated_at":"2015-04-29T21:14:04Z","body":"Still don't see why you guys don't just port the process scheduler."}}