{"action":"created","comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/28457988","id":28457988,"diff_hunk":"@@ -204,11 +204,19 @@ class compress_zip extends compress\n \tvar $datasec_len = 0;\n \n \t/**\n+\t * @var \\phpbb\\filesystem\\filesystem_interface\n+\t */\n+\tprotected $filesystem;\n+\n+\t/**\n \t* Constructor\n \t*/\n \tfunction compress_zip($mode, $file)\n \t{\n+\t\tglobal $phpbb_filesystem;","path":"phpBB/includes/functions_compress.php","position":22,"original_position":22,"commit_id":"c2186e7196e4f367b0648ad1026c33eae82b9ee6","original_commit_id":"c2186e7196e4f367b0648ad1026c33eae82b9ee6","user":{"login":"Nicofuma","id":591456,"avatar_url":"https://avatars.githubusercontent.com/u/591456?v=3","gravatar_id":"","url":"https://api.github.com/users/Nicofuma","html_url":"https://github.com/Nicofuma","followers_url":"https://api.github.com/users/Nicofuma/followers","following_url":"https://api.github.com/users/Nicofuma/following{/other_user}","gists_url":"https://api.github.com/users/Nicofuma/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicofuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicofuma/subscriptions","organizations_url":"https://api.github.com/users/Nicofuma/orgs","repos_url":"https://api.github.com/users/Nicofuma/repos","events_url":"https://api.github.com/users/Nicofuma/events{/privacy}","received_events_url":"https://api.github.com/users/Nicofuma/received_events","type":"User","site_admin":false},"body":"use a constructor parameter please","created_at":"2015-04-15T20:14:53Z","updated_at":"2015-04-15T20:14:53Z","html_url":"https://github.com/phpbb/phpbb/pull/3487#discussion_r28457988","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3487","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/28457988"},"html":{"href":"https://github.com/phpbb/phpbb/pull/3487#discussion_r28457988"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3487"}}},"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/3487","id":31058454,"html_url":"https://github.com/phpbb/phpbb/pull/3487","diff_url":"https://github.com/phpbb/phpbb/pull/3487.diff","patch_url":"https://github.com/phpbb/phpbb/pull/3487.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/3487","number":3487,"state":"open","locked":false,"title":"[ticket/13697] Moving filesystem related functions to filesystem service","user":{"login":"MateBartus","id":10946388,"avatar_url":"https://avatars.githubusercontent.com/u/10946388?v=3","gravatar_id":"","url":"https://api.github.com/users/MateBartus","html_url":"https://github.com/MateBartus","followers_url":"https://api.github.com/users/MateBartus/followers","following_url":"https://api.github.com/users/MateBartus/following{/other_user}","gists_url":"https://api.github.com/users/MateBartus/gists{/gist_id}","starred_url":"https://api.github.com/users/MateBartus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MateBartus/subscriptions","organizations_url":"https://api.github.com/users/MateBartus/orgs","repos_url":"https://api.github.com/users/MateBartus/repos","events_url":"https://api.github.com/users/MateBartus/events{/privacy}","received_events_url":"https://api.github.com/users/MateBartus/received_events","type":"User","site_admin":false},"body":"https://tracker.phpbb.com/browse/PHPBB3-13697\r\n\r\n * Moving filesystem service to \\phpbb\\filesystem namespace\r\n * Wraping Symfony's Filesystem component\r\n * Moving filesystem related functions from includes/functions.php\r\n   into \\phpbb\\filesystem\\filesystem\r\n   Functions moved (and deprecated):\r\n     - phpbb_chmod\r\n     - phpbb_is_writable\r\n     - phpbb_is_absolute\r\n     - phpbb_own_realpath\r\n     - phpbb_realpath\r\n * Adding interface for filesystem service\r\n\r\nPHPBB3-13697","created_at":"2015-03-12T17:25:19Z","updated_at":"2015-04-15T20:14:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4ba3eb0b1c389e34f6381c0cd5bf4565aed8f77","assignee":null,"milestone":{"url":"https://api.github.com/repos/phpbb/phpbb/milestones/2","html_url":"https://github.com/phpbb/phpbb/milestones/3.2.0","labels_url":"https://api.github.com/repos/phpbb/phpbb/milestones/2/labels","id":835770,"number":2,"title":"3.2.0","description":"","creator":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=3","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":48,"state":"open","created_at":"2014-10-22T10:41:02Z","updated_at":"2015-04-14T07:48:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3487/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3487/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/3487/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/c2186e7196e4f367b0648ad1026c33eae82b9ee6","head":{"label":"MateBartus:ticket/13697","ref":"ticket/13697","sha":"c2186e7196e4f367b0648ad1026c33eae82b9ee6","user":{"login":"MateBartus","id":10946388,"avatar_url":"https://avatars.githubusercontent.com/u/10946388?v=3","gravatar_id":"","url":"https://api.github.com/users/MateBartus","html_url":"https://github.com/MateBartus","followers_url":"https://api.github.com/users/MateBartus/followers","following_url":"https://api.github.com/users/MateBartus/following{/other_user}","gists_url":"https://api.github.com/users/MateBartus/gists{/gist_id}","starred_url":"https://api.github.com/users/MateBartus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MateBartus/subscriptions","organizations_url":"https://api.github.com/users/MateBartus/orgs","repos_url":"https://api.github.com/users/MateBartus/repos","events_url":"https://api.github.com/users/MateBartus/events{/privacy}","received_events_url":"https://api.github.com/users/MateBartus/received_events","type":"User","site_admin":false},"repo":{"id":31021414,"name":"phpbb","full_name":"MateBartus/phpbb","owner":{"login":"MateBartus","id":10946388,"avatar_url":"https://avatars.githubusercontent.com/u/10946388?v=3","gravatar_id":"","url":"https://api.github.com/users/MateBartus","html_url":"https://github.com/MateBartus","followers_url":"https://api.github.com/users/MateBartus/followers","following_url":"https://api.github.com/users/MateBartus/following{/other_user}","gists_url":"https://api.github.com/users/MateBartus/gists{/gist_id}","starred_url":"https://api.github.com/users/MateBartus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MateBartus/subscriptions","organizations_url":"https://api.github.com/users/MateBartus/orgs","repos_url":"https://api.github.com/users/MateBartus/repos","events_url":"https://api.github.com/users/MateBartus/events{/privacy}","received_events_url":"https://api.github.com/users/MateBartus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MateBartus/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":true,"url":"https://api.github.com/repos/MateBartus/phpbb","forks_url":"https://api.github.com/repos/MateBartus/phpbb/forks","keys_url":"https://api.github.com/repos/MateBartus/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MateBartus/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MateBartus/phpbb/teams","hooks_url":"https://api.github.com/repos/MateBartus/phpbb/hooks","issue_events_url":"https://api.github.com/repos/MateBartus/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/MateBartus/phpbb/events","assignees_url":"https://api.github.com/repos/MateBartus/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/MateBartus/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/MateBartus/phpbb/tags","blobs_url":"https://api.github.com/repos/MateBartus/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MateBartus/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MateBartus/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/MateBartus/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MateBartus/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/MateBartus/phpbb/languages","stargazers_url":"https://api.github.com/repos/MateBartus/phpbb/stargazers","contributors_url":"https://api.github.com/repos/MateBartus/phpbb/contributors","subscribers_url":"https://api.github.com/repos/MateBartus/phpbb/subscribers","subscription_url":"https://api.github.com/repos/MateBartus/phpbb/subscription","commits_url":"https://api.github.com/repos/MateBartus/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/MateBartus/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/MateBartus/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/MateBartus/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/MateBartus/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/MateBartus/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MateBartus/phpbb/merges","archive_url":"https://api.github.com/repos/MateBartus/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MateBartus/phpbb/downloads","issues_url":"https://api.github.com/repos/MateBartus/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/MateBartus/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/MateBartus/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/MateBartus/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MateBartus/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/MateBartus/phpbb/releases{/id}","created_at":"2015-02-19T15:25:22Z","updated_at":"2015-04-14T00:31:51Z","pushed_at":"2015-04-15T20:10:50Z","git_url":"git://github.com/MateBartus/phpbb.git","ssh_url":"git@github.com:MateBartus/phpbb.git","clone_url":"https://github.com/MateBartus/phpbb.git","svn_url":"https://github.com/MateBartus/phpbb","homepage":"http://www.phpbb.com","size":53940,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phpbb:master","ref":"master","sha":"7541fab408a3200dd8514acde93889faf0193d83","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":541983,"name":"phpbb","full_name":"phpbb/phpbb","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb","forks_url":"https://api.github.com/repos/phpbb/phpbb/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpbb/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb/releases{/id}","created_at":"2010-03-01T22:33:17Z","updated_at":"2015-04-15T18:09:50Z","pushed_at":"2015-04-15T20:10:51Z","git_url":"git://github.com/phpbb/phpbb.git","ssh_url":"git@github.com:phpbb/phpbb.git","clone_url":"https://github.com/phpbb/phpbb.git","svn_url":"https://github.com/phpbb/phpbb","homepage":"http://www.phpbb.com","size":125984,"stargazers_count":722,"watchers_count":722,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":450,"mirror_url":null,"open_issues_count":78,"forks":450,"open_issues":78,"watchers":722,"default_branch":"3.1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3487"},"html":{"href":"https://github.com/phpbb/phpbb/pull/3487"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/3487"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/3487/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3487/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3487/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb/statuses/c2186e7196e4f367b0648ad1026c33eae82b9ee6"}}}}