{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/46144629","id":46144629,"diff_hunk":"@@ -86,18 +86,18 @@ Each spin of the garbage collector loop goes through the following steps:\n 1. Retrieve a list of available containers.\n 2. Filter out all containers that are running or are not alive longer than\n the `*minimum-container-ttl-duration*` parameter.\n-3. Determine pod membership of each remaining container.\n-4. Remove all unidentified containers (with no pod membership).\n-5. For each pod that contains more containers than the\n-`*maximum-dead-containers-per-container*` parameter, sort the containers by\n+3. Decompose all remaining containers into equivalence classes based on pod and image name membership.\n+4. Remove all unidentified containers (containers with unrecognizable name).","path":"admin_guide/garbage_collection.adoc","position":9,"original_position":9,"commit_id":"92267d49bf7f9b73583b503d2aebd3bc25606deb","original_commit_id":"92267d49bf7f9b73583b503d2aebd3bc25606deb","user":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"body":"So does this mean that the kubelet gc removes all non-kube dead containers? Didn't realize that.","created_at":"2015-11-30T13:55:05Z","updated_at":"2015-11-30T13:55:05Z","html_url":"https://github.com/openshift/openshift-docs/pull/1275#discussion_r46144629","pull_request_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/1275","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/46144629"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/1275#discussion_r46144629"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/1275"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/1275","id":52124906,"html_url":"https://github.com/openshift/openshift-docs/pull/1275","diff_url":"https://github.com/openshift/openshift-docs/pull/1275.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/1275.patch","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/1275","number":1275,"state":"open","locked":false,"title":"Update description of detection of containers for deletion","user":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"body":"The mechanism of selecting containers for deletion for `*maximum-dead-containers-per-container*` parameter is slightly different than I described in the previous pull request [1]. This one is closer to truth :).\r\n\r\n[1] https://github.com/openshift/openshift-docs/commit/4201233ad479c27991f4dff6cc959527a387509f","created_at":"2015-11-30T13:42:31Z","updated_at":"2015-11-30T13:55:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4f1412d91028c0604065d63429c8e130cf18ba6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/1275/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/1275/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/1275/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/92267d49bf7f9b73583b503d2aebd3bc25606deb","head":{"label":"ingvagabund:update-container-gc-steps","ref":"update-container-gc-steps","sha":"92267d49bf7f9b73583b503d2aebd3bc25606deb","user":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"repo":{"id":46431788,"name":"openshift-docs","full_name":"ingvagabund/openshift-docs","owner":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ingvagabund/openshift-docs","description":"OpenShift Documentation","fork":true,"url":"https://api.github.com/repos/ingvagabund/openshift-docs","forks_url":"https://api.github.com/repos/ingvagabund/openshift-docs/forks","keys_url":"https://api.github.com/repos/ingvagabund/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ingvagabund/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ingvagabund/openshift-docs/teams","hooks_url":"https://api.github.com/repos/ingvagabund/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/ingvagabund/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/ingvagabund/openshift-docs/events","assignees_url":"https://api.github.com/repos/ingvagabund/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/ingvagabund/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/ingvagabund/openshift-docs/tags","blobs_url":"https://api.github.com/repos/ingvagabund/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ingvagabund/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ingvagabund/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ingvagabund/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ingvagabund/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/ingvagabund/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/ingvagabund/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/ingvagabund/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/ingvagabund/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/ingvagabund/openshift-docs/subscription","commits_url":"https://api.github.com/repos/ingvagabund/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ingvagabund/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ingvagabund/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ingvagabund/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ingvagabund/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/ingvagabund/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ingvagabund/openshift-docs/merges","archive_url":"https://api.github.com/repos/ingvagabund/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ingvagabund/openshift-docs/downloads","issues_url":"https://api.github.com/repos/ingvagabund/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/ingvagabund/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/ingvagabund/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/ingvagabund/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ingvagabund/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/ingvagabund/openshift-docs/releases{/id}","created_at":"2015-11-18T16:29:18Z","updated_at":"2015-11-18T16:29:20Z","pushed_at":"2015-11-30T13:38:16Z","git_url":"git://github.com/ingvagabund/openshift-docs.git","ssh_url":"git@github.com:ingvagabund/openshift-docs.git","clone_url":"https://github.com/ingvagabund/openshift-docs.git","svn_url":"https://github.com/ingvagabund/openshift-docs","homepage":null,"size":6552,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"7df1f498dcd4d82d3517fd92449711e800cbfd43","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":21740844,"name":"openshift-docs","full_name":"openshift/openshift-docs","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-docs","description":"OpenShift Documentation","fork":false,"url":"https://api.github.com/repos/openshift/openshift-docs","forks_url":"https://api.github.com/repos/openshift/openshift-docs/forks","keys_url":"https://api.github.com/repos/openshift/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-docs/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-docs/events","assignees_url":"https://api.github.com/repos/openshift/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-docs/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-docs/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-docs/merges","archive_url":"https://api.github.com/repos/openshift/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-docs/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-docs/releases{/id}","created_at":"2014-07-11T15:14:42Z","updated_at":"2015-11-26T11:21:41Z","pushed_at":"2015-11-30T13:42:31Z","git_url":"git://github.com/openshift/openshift-docs.git","ssh_url":"git@github.com:openshift/openshift-docs.git","clone_url":"https://github.com/openshift/openshift-docs.git","svn_url":"https://github.com/openshift/openshift-docs","homepage":null,"size":8226,"stargazers_count":33,"watchers_count":33,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":83,"forks":154,"open_issues":83,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/1275"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/1275"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/1275"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/1275/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/1275/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/1275/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-docs/statuses/92267d49bf7f9b73583b503d2aebd3bc25606deb"}}}}