{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/12226","labels_url":"https://api.github.com/repos/docker/docker/issues/12226/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/12226/comments","events_url":"https://api.github.com/repos/docker/docker/issues/12226/events","html_url":"https://github.com/docker/docker/pull/12226","id":67325171,"number":12226,"title":"daemon: Logging drivers architectural refactoring","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/dco/no","name":"dco/no","color":"E6781E"},{"url":"https://api.github.com/repos/docker/docker/labels/status/0-needs-triage","name":"status/0-needs-triage","color":"EEEEEE"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-09T09:56:57Z","updated_at":"2015-04-09T10:00:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/12226","html_url":"https://github.com/docker/docker/pull/12226","diff_url":"https://github.com/docker/docker/pull/12226.diff","patch_url":"https://github.com/docker/docker/pull/12226.patch"},"body":"Followup to #12213.\r\n\r\n- daemon now doesn't start with an invalid log driver type\r\n- `noplog`  driver pkg for '--log-driver=none' (null object pattern)\r\n- centralized factory for log drivers (instead of case/switch)\r\n- logging drivers registers themselves to factory upon import\r\n  (easy plug/unplug of drivers in daemon/logdrivers.go)\r\n- Name() method of loggers is actually now their cli names (made it useful)\r\n- generalized Read() logic, made it unsupported except json-file (preserves\r\n  existing behavior). however makes it easy to support readable\r\n  log drivers in the future\r\n\r\nSpotted some duplication code around processing of legacy json-file\r\nformat, didn't touch that and refactored in both places.\r\n\r\n\r\nThanks @skarademir for the pair programming session!\r\ncc: @LK4D4 @crosbymichael "},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/91180171","html_url":"https://github.com/docker/docker/pull/12226#issuecomment-91180171","issue_url":"https://api.github.com/repos/docker/docker/issues/12226","id":91180171,"user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T10:00:15Z","updated_at":"2015-04-09T10:00:15Z","body":"chillax gordon its 3am\r\n\r\n![image](https://cloud.githubusercontent.com/assets/159209/7064555/72e01d48-de64-11e4-85a0-66aefc1dae81.png)\r\n"}}