{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/hiratake55/RForcecom/pulls/20","id":48388604,"html_url":"https://github.com/hiratake55/RForcecom/pull/20","diff_url":"https://github.com/hiratake55/RForcecom/pull/20.diff","patch_url":"https://github.com/hiratake55/RForcecom/pull/20.patch","issue_url":"https://api.github.com/repos/hiratake55/RForcecom/issues/20","number":20,"state":"closed","locked":false,"title":"Extend the unit testing","user":{"login":"ax42","id":1254869,"avatar_url":"https://avatars.githubusercontent.com/u/1254869?v=3","gravatar_id":"","url":"https://api.github.com/users/ax42","html_url":"https://github.com/ax42","followers_url":"https://api.github.com/users/ax42/followers","following_url":"https://api.github.com/users/ax42/following{/other_user}","gists_url":"https://api.github.com/users/ax42/gists{/gist_id}","starred_url":"https://api.github.com/users/ax42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax42/subscriptions","organizations_url":"https://api.github.com/users/ax42/orgs","repos_url":"https://api.github.com/users/ax42/repos","events_url":"https://api.github.com/users/ax42/events{/privacy}","received_events_url":"https://api.github.com/users/ax42/received_events","type":"User","site_admin":false},"body":"- Added some more unit tests, especially regarding the structure of returned values.  I'm using only standard field in standard objects, so this should work anywhere.\r\n- Made the unit tests log into https://login.salesforce.com instead of a dedicated instance.  I think this should actually be the standard behaviour, so we can potentially get rid of a (required) parameter to `rforcequery.login` (or at least make it a default) but I think hiratake55 is better placed to make that call\r\n\r\nThese changes should help if one wants to change the mechanics of rforcecom.query (e.g. going to JSON from XML) so one can check that one is not accidentally breaking the returned data frame.","created_at":"2015-10-21T21:13:10Z","updated_at":"2015-10-25T13:55:45Z","closed_at":"2015-10-25T13:55:45Z","merged_at":"2015-10-25T13:55:45Z","merge_commit_sha":"96124a8034e396e06f052fb0cbc89b998fcaff3f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hiratake55/RForcecom/pulls/20/commits","review_comments_url":"https://api.github.com/repos/hiratake55/RForcecom/pulls/20/comments","review_comment_url":"https://api.github.com/repos/hiratake55/RForcecom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hiratake55/RForcecom/issues/20/comments","statuses_url":"https://api.github.com/repos/hiratake55/RForcecom/statuses/923ef8414d74a4368e4c248273fec552aa17c79a","head":{"label":"ax42:master","ref":"master","sha":"923ef8414d74a4368e4c248273fec552aa17c79a","user":{"login":"ax42","id":1254869,"avatar_url":"https://avatars.githubusercontent.com/u/1254869?v=3","gravatar_id":"","url":"https://api.github.com/users/ax42","html_url":"https://github.com/ax42","followers_url":"https://api.github.com/users/ax42/followers","following_url":"https://api.github.com/users/ax42/following{/other_user}","gists_url":"https://api.github.com/users/ax42/gists{/gist_id}","starred_url":"https://api.github.com/users/ax42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax42/subscriptions","organizations_url":"https://api.github.com/users/ax42/orgs","repos_url":"https://api.github.com/users/ax42/repos","events_url":"https://api.github.com/users/ax42/events{/privacy}","received_events_url":"https://api.github.com/users/ax42/received_events","type":"User","site_admin":false},"repo":{"id":44390292,"name":"RForcecom","full_name":"ax42/RForcecom","owner":{"login":"ax42","id":1254869,"avatar_url":"https://avatars.githubusercontent.com/u/1254869?v=3","gravatar_id":"","url":"https://api.github.com/users/ax42","html_url":"https://github.com/ax42","followers_url":"https://api.github.com/users/ax42/followers","following_url":"https://api.github.com/users/ax42/following{/other_user}","gists_url":"https://api.github.com/users/ax42/gists{/gist_id}","starred_url":"https://api.github.com/users/ax42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax42/subscriptions","organizations_url":"https://api.github.com/users/ax42/orgs","repos_url":"https://api.github.com/users/ax42/repos","events_url":"https://api.github.com/users/ax42/events{/privacy}","received_events_url":"https://api.github.com/users/ax42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ax42/RForcecom","description":"RForcecom provides the connection to Force.com and Salesforce.com from R","fork":true,"url":"https://api.github.com/repos/ax42/RForcecom","forks_url":"https://api.github.com/repos/ax42/RForcecom/forks","keys_url":"https://api.github.com/repos/ax42/RForcecom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ax42/RForcecom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ax42/RForcecom/teams","hooks_url":"https://api.github.com/repos/ax42/RForcecom/hooks","issue_events_url":"https://api.github.com/repos/ax42/RForcecom/issues/events{/number}","events_url":"https://api.github.com/repos/ax42/RForcecom/events","assignees_url":"https://api.github.com/repos/ax42/RForcecom/assignees{/user}","branches_url":"https://api.github.com/repos/ax42/RForcecom/branches{/branch}","tags_url":"https://api.github.com/repos/ax42/RForcecom/tags","blobs_url":"https://api.github.com/repos/ax42/RForcecom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ax42/RForcecom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ax42/RForcecom/git/refs{/sha}","trees_url":"https://api.github.com/repos/ax42/RForcecom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ax42/RForcecom/statuses/{sha}","languages_url":"https://api.github.com/repos/ax42/RForcecom/languages","stargazers_url":"https://api.github.com/repos/ax42/RForcecom/stargazers","contributors_url":"https://api.github.com/repos/ax42/RForcecom/contributors","subscribers_url":"https://api.github.com/repos/ax42/RForcecom/subscribers","subscription_url":"https://api.github.com/repos/ax42/RForcecom/subscription","commits_url":"https://api.github.com/repos/ax42/RForcecom/commits{/sha}","git_commits_url":"https://api.github.com/repos/ax42/RForcecom/git/commits{/sha}","comments_url":"https://api.github.com/repos/ax42/RForcecom/comments{/number}","issue_comment_url":"https://api.github.com/repos/ax42/RForcecom/issues/comments{/number}","contents_url":"https://api.github.com/repos/ax42/RForcecom/contents/{+path}","compare_url":"https://api.github.com/repos/ax42/RForcecom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ax42/RForcecom/merges","archive_url":"https://api.github.com/repos/ax42/RForcecom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ax42/RForcecom/downloads","issues_url":"https://api.github.com/repos/ax42/RForcecom/issues{/number}","pulls_url":"https://api.github.com/repos/ax42/RForcecom/pulls{/number}","milestones_url":"https://api.github.com/repos/ax42/RForcecom/milestones{/number}","notifications_url":"https://api.github.com/repos/ax42/RForcecom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ax42/RForcecom/labels{/name}","releases_url":"https://api.github.com/repos/ax42/RForcecom/releases{/id}","created_at":"2015-10-16T14:27:49Z","updated_at":"2015-10-16T14:27:50Z","pushed_at":"2015-10-21T21:09:25Z","git_url":"git://github.com/ax42/RForcecom.git","ssh_url":"git@github.com:ax42/RForcecom.git","clone_url":"https://github.com/ax42/RForcecom.git","svn_url":"https://github.com/ax42/RForcecom","homepage":"http://cran.r-project.org/web/packages/RForcecom/index.html","size":740,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hiratake55:master","ref":"master","sha":"fdb4ddee38cb7f1faec1436f3b1f92da0d360456","user":{"login":"hiratake55","id":101812,"avatar_url":"https://avatars.githubusercontent.com/u/101812?v=3","gravatar_id":"","url":"https://api.github.com/users/hiratake55","html_url":"https://github.com/hiratake55","followers_url":"https://api.github.com/users/hiratake55/followers","following_url":"https://api.github.com/users/hiratake55/following{/other_user}","gists_url":"https://api.github.com/users/hiratake55/gists{/gist_id}","starred_url":"https://api.github.com/users/hiratake55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiratake55/subscriptions","organizations_url":"https://api.github.com/users/hiratake55/orgs","repos_url":"https://api.github.com/users/hiratake55/repos","events_url":"https://api.github.com/users/hiratake55/events{/privacy}","received_events_url":"https://api.github.com/users/hiratake55/received_events","type":"User","site_admin":false},"repo":{"id":3460879,"name":"RForcecom","full_name":"hiratake55/RForcecom","owner":{"login":"hiratake55","id":101812,"avatar_url":"https://avatars.githubusercontent.com/u/101812?v=3","gravatar_id":"","url":"https://api.github.com/users/hiratake55","html_url":"https://github.com/hiratake55","followers_url":"https://api.github.com/users/hiratake55/followers","following_url":"https://api.github.com/users/hiratake55/following{/other_user}","gists_url":"https://api.github.com/users/hiratake55/gists{/gist_id}","starred_url":"https://api.github.com/users/hiratake55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiratake55/subscriptions","organizations_url":"https://api.github.com/users/hiratake55/orgs","repos_url":"https://api.github.com/users/hiratake55/repos","events_url":"https://api.github.com/users/hiratake55/events{/privacy}","received_events_url":"https://api.github.com/users/hiratake55/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hiratake55/RForcecom","description":"RForcecom provides the connection to Force.com and Salesforce.com from R","fork":false,"url":"https://api.github.com/repos/hiratake55/RForcecom","forks_url":"https://api.github.com/repos/hiratake55/RForcecom/forks","keys_url":"https://api.github.com/repos/hiratake55/RForcecom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hiratake55/RForcecom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hiratake55/RForcecom/teams","hooks_url":"https://api.github.com/repos/hiratake55/RForcecom/hooks","issue_events_url":"https://api.github.com/repos/hiratake55/RForcecom/issues/events{/number}","events_url":"https://api.github.com/repos/hiratake55/RForcecom/events","assignees_url":"https://api.github.com/repos/hiratake55/RForcecom/assignees{/user}","branches_url":"https://api.github.com/repos/hiratake55/RForcecom/branches{/branch}","tags_url":"https://api.github.com/repos/hiratake55/RForcecom/tags","blobs_url":"https://api.github.com/repos/hiratake55/RForcecom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hiratake55/RForcecom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hiratake55/RForcecom/git/refs{/sha}","trees_url":"https://api.github.com/repos/hiratake55/RForcecom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hiratake55/RForcecom/statuses/{sha}","languages_url":"https://api.github.com/repos/hiratake55/RForcecom/languages","stargazers_url":"https://api.github.com/repos/hiratake55/RForcecom/stargazers","contributors_url":"https://api.github.com/repos/hiratake55/RForcecom/contributors","subscribers_url":"https://api.github.com/repos/hiratake55/RForcecom/subscribers","subscription_url":"https://api.github.com/repos/hiratake55/RForcecom/subscription","commits_url":"https://api.github.com/repos/hiratake55/RForcecom/commits{/sha}","git_commits_url":"https://api.github.com/repos/hiratake55/RForcecom/git/commits{/sha}","comments_url":"https://api.github.com/repos/hiratake55/RForcecom/comments{/number}","issue_comment_url":"https://api.github.com/repos/hiratake55/RForcecom/issues/comments{/number}","contents_url":"https://api.github.com/repos/hiratake55/RForcecom/contents/{+path}","compare_url":"https://api.github.com/repos/hiratake55/RForcecom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hiratake55/RForcecom/merges","archive_url":"https://api.github.com/repos/hiratake55/RForcecom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hiratake55/RForcecom/downloads","issues_url":"https://api.github.com/repos/hiratake55/RForcecom/issues{/number}","pulls_url":"https://api.github.com/repos/hiratake55/RForcecom/pulls{/number}","milestones_url":"https://api.github.com/repos/hiratake55/RForcecom/milestones{/number}","notifications_url":"https://api.github.com/repos/hiratake55/RForcecom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hiratake55/RForcecom/labels{/name}","releases_url":"https://api.github.com/repos/hiratake55/RForcecom/releases{/id}","created_at":"2012-02-16T15:10:55Z","updated_at":"2015-10-20T17:07:14Z","pushed_at":"2015-10-25T13:55:45Z","git_url":"git://github.com/hiratake55/RForcecom.git","ssh_url":"git@github.com:hiratake55/RForcecom.git","clone_url":"https://github.com/hiratake55/RForcecom.git","svn_url":"https://github.com/hiratake55/RForcecom","homepage":"http://cran.r-project.org/web/packages/RForcecom/index.html","size":1038,"stargazers_count":23,"watchers_count":23,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":9,"forks":10,"open_issues":9,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hiratake55/RForcecom/pulls/20"},"html":{"href":"https://github.com/hiratake55/RForcecom/pull/20"},"issue":{"href":"https://api.github.com/repos/hiratake55/RForcecom/issues/20"},"comments":{"href":"https://api.github.com/repos/hiratake55/RForcecom/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/hiratake55/RForcecom/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/hiratake55/RForcecom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hiratake55/RForcecom/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/hiratake55/RForcecom/statuses/923ef8414d74a4368e4c248273fec552aa17c79a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hiratake55","id":101812,"avatar_url":"https://avatars.githubusercontent.com/u/101812?v=3","gravatar_id":"","url":"https://api.github.com/users/hiratake55","html_url":"https://github.com/hiratake55","followers_url":"https://api.github.com/users/hiratake55/followers","following_url":"https://api.github.com/users/hiratake55/following{/other_user}","gists_url":"https://api.github.com/users/hiratake55/gists{/gist_id}","starred_url":"https://api.github.com/users/hiratake55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiratake55/subscriptions","organizations_url":"https://api.github.com/users/hiratake55/orgs","repos_url":"https://api.github.com/users/hiratake55/repos","events_url":"https://api.github.com/users/hiratake55/events{/privacy}","received_events_url":"https://api.github.com/users/hiratake55/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":29,"deletions":8,"changed_files":2}}