{"action":"created","issue":{"url":"https://api.github.com/repos/symfony-cmf/MenuBundle/issues/214","labels_url":"https://api.github.com/repos/symfony-cmf/MenuBundle/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/symfony-cmf/MenuBundle/issues/214/comments","events_url":"https://api.github.com/repos/symfony-cmf/MenuBundle/issues/214/events","html_url":"https://github.com/symfony-cmf/MenuBundle/pull/214","id":47507790,"number":214,"title":"[WIP] Refactoring to support 2.0","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/symfony-cmf/MenuBundle/labels/in+progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2014-11-01T14:57:19Z","updated_at":"2015-01-05T17:14:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symfony-cmf/MenuBundle/pulls/214","html_url":"https://github.com/symfony-cmf/MenuBundle/pull/214","diff_url":"https://github.com/symfony-cmf/MenuBundle/pull/214.diff","patch_url":"https://github.com/symfony-cmf/MenuBundle/pull/214.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | yes\r\n| BC breaks?    | yes\r\n| Deprecations? | no\r\n| Tests pass?   | no\r\n| Fixed tickets | #82, #83, #202\r\n| License       | MIT\r\n| Doc PR        | todo\r\n\r\nWhile updating to 2.0, I also tried to make the code cleaner and easier to understand. Since this will be released as CmfMenuBundle 2.0, we can have BC breaks in it. This is kind of the last change to make things really better.\r\n\r\nTodo\r\n---\r\n\r\n* [ ] Create functional tests for PublishWorkflow listeners\r\n* [ ] Create custom Loader to support PublishWorkflow\r\n* [ ] Create a tag in the CoreBundle to support decorating services (which is support by Sf 2.5)\r\n* [x] Update SE (https://github.com/symfony-cmf/standard-edition/pull/28)\r\n* [ ] Update sandbox\r\n* [ ] Update cmf website\r\n* [ ] Update docs"},"comment":{"url":"https://api.github.com/repos/symfony-cmf/MenuBundle/issues/comments/68740562","html_url":"https://github.com/symfony-cmf/MenuBundle/pull/214#issuecomment-68740562","issue_url":"https://api.github.com/repos/symfony-cmf/MenuBundle/issues/214","id":68740562,"user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"created_at":"2015-01-05T17:14:44Z","updated_at":"2015-01-05T17:14:44Z","body":"I don't think so.\r\n\r\nSee https://github.com/KnpLabs/KnpMenu/pull/189 for the Knp PR."}}