{"action":"created","comment":{"url":"https://api.github.com/repos/terrajobst/nuproj/pulls/comments/26913829","id":26913829,"diff_hunk":"@@ -143,5 +157,24 @@ public static void UpdateMember<T>(this T target, Expression<Func<T, string>> me\n             \n             property.SetValue(target, list, null);\n         }\n+\n+        public static string Combine(this PackageDirectory packageDirectory, string targetFramework, string fileName)\n+        { \n+            switch (packageDirectory)\n+            {\n+                case PackageDirectory.Root:\n+                    return fileName;\n+                case PackageDirectory.Content:\n+                    return Path.Combine(Constants.ContentDirectory, fileName);\n+                case PackageDirectory.Build:\n+                    return Path.Combine(Constants.BuildDirectory, targetFramework, fileName);","path":"src/NuProj.Tasks/Extensions.cs","position":41,"original_position":41,"commit_id":"3ce88b660116d754589b86428c29d9f3bf9c32a5","original_commit_id":"3ce88b660116d754589b86428c29d9f3bf9c32a5","user":{"login":"AArnott","id":3548,"avatar_url":"https://avatars.githubusercontent.com/u/3548?v=3","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false},"body":"This might be the line responsible for my ProjectReference with PackageDirectory=Build going into the build\\net451 directory instead of just \"build\". Is this an oversight, or did you intend to to put the project reference output into a targetFramework subfolder?\r\nIn my scenario, I have a .targets file in the build folder and I need to pick up the DLL next to it. But if it's in a subfolder, my .targets file now has to be aware of that. It certainly *can* be, but I wonder why it's necessary.","created_at":"2015-03-23T04:23:08Z","updated_at":"2015-03-23T04:23:08Z","html_url":"https://github.com/terrajobst/nuproj/pull/63#discussion_r26913829","pull_request_url":"https://api.github.com/repos/terrajobst/nuproj/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/terrajobst/nuproj/pulls/comments/26913829"},"html":{"href":"https://github.com/terrajobst/nuproj/pull/63#discussion_r26913829"},"pull_request":{"href":"https://api.github.com/repos/terrajobst/nuproj/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/terrajobst/nuproj/pulls/63","id":27560847,"html_url":"https://github.com/terrajobst/nuproj/pull/63","diff_url":"https://github.com/terrajobst/nuproj/pull/63.diff","patch_url":"https://github.com/terrajobst/nuproj/pull/63.patch","issue_url":"https://api.github.com/repos/terrajobst/nuproj/issues/63","number":63,"state":"open","locked":false,"title":"Issue #26 - Support project references that contribute to tools folder","user":{"login":"kovalikp","id":8546121,"avatar_url":"https://avatars.githubusercontent.com/u/8546121?v=3","gravatar_id":"","url":"https://api.github.com/users/kovalikp","html_url":"https://github.com/kovalikp","followers_url":"https://api.github.com/users/kovalikp/followers","following_url":"https://api.github.com/users/kovalikp/following{/other_user}","gists_url":"https://api.github.com/users/kovalikp/gists{/gist_id}","starred_url":"https://api.github.com/users/kovalikp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kovalikp/subscriptions","organizations_url":"https://api.github.com/users/kovalikp/orgs","repos_url":"https://api.github.com/users/kovalikp/repos","events_url":"https://api.github.com/users/kovalikp/events{/privacy}","received_events_url":"https://api.github.com/users/kovalikp/received_events","type":"User","site_admin":false},"body":"`ProjectReference` items can output to other package folders,\r\nlike tools or build based on `PackageDirectory` metadata. (resolving #26) \r\n\r\nUsing `Content` only items instead `Library` and `Tool` items. (as mentioned in #40)\r\n","created_at":"2015-01-17T19:21:20Z","updated_at":"2015-03-23T04:23:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4afd391b0fdbcb7579f252a3f22945acc3bf76ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/terrajobst/nuproj/pulls/63/commits","review_comments_url":"https://api.github.com/repos/terrajobst/nuproj/pulls/63/comments","review_comment_url":"https://api.github.com/repos/terrajobst/nuproj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terrajobst/nuproj/issues/63/comments","statuses_url":"https://api.github.com/repos/terrajobst/nuproj/statuses/3ce88b660116d754589b86428c29d9f3bf9c32a5","head":{"label":"kovalikp:issue26","ref":"issue26","sha":"3ce88b660116d754589b86428c29d9f3bf9c32a5","user":{"login":"kovalikp","id":8546121,"avatar_url":"https://avatars.githubusercontent.com/u/8546121?v=3","gravatar_id":"","url":"https://api.github.com/users/kovalikp","html_url":"https://github.com/kovalikp","followers_url":"https://api.github.com/users/kovalikp/followers","following_url":"https://api.github.com/users/kovalikp/following{/other_user}","gists_url":"https://api.github.com/users/kovalikp/gists{/gist_id}","starred_url":"https://api.github.com/users/kovalikp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kovalikp/subscriptions","organizations_url":"https://api.github.com/users/kovalikp/orgs","repos_url":"https://api.github.com/users/kovalikp/repos","events_url":"https://api.github.com/users/kovalikp/events{/privacy}","received_events_url":"https://api.github.com/users/kovalikp/received_events","type":"User","site_admin":false},"repo":{"id":23325173,"name":"nuproj","full_name":"kovalikp/nuproj","owner":{"login":"kovalikp","id":8546121,"avatar_url":"https://avatars.githubusercontent.com/u/8546121?v=3","gravatar_id":"","url":"https://api.github.com/users/kovalikp","html_url":"https://github.com/kovalikp","followers_url":"https://api.github.com/users/kovalikp/followers","following_url":"https://api.github.com/users/kovalikp/following{/other_user}","gists_url":"https://api.github.com/users/kovalikp/gists{/gist_id}","starred_url":"https://api.github.com/users/kovalikp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kovalikp/subscriptions","organizations_url":"https://api.github.com/users/kovalikp/orgs","repos_url":"https://api.github.com/users/kovalikp/repos","events_url":"https://api.github.com/users/kovalikp/events{/privacy}","received_events_url":"https://api.github.com/users/kovalikp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kovalikp/nuproj","description":"Creating NuGet packages the MSBuild way","fork":true,"url":"https://api.github.com/repos/kovalikp/nuproj","forks_url":"https://api.github.com/repos/kovalikp/nuproj/forks","keys_url":"https://api.github.com/repos/kovalikp/nuproj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kovalikp/nuproj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kovalikp/nuproj/teams","hooks_url":"https://api.github.com/repos/kovalikp/nuproj/hooks","issue_events_url":"https://api.github.com/repos/kovalikp/nuproj/issues/events{/number}","events_url":"https://api.github.com/repos/kovalikp/nuproj/events","assignees_url":"https://api.github.com/repos/kovalikp/nuproj/assignees{/user}","branches_url":"https://api.github.com/repos/kovalikp/nuproj/branches{/branch}","tags_url":"https://api.github.com/repos/kovalikp/nuproj/tags","blobs_url":"https://api.github.com/repos/kovalikp/nuproj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kovalikp/nuproj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kovalikp/nuproj/git/refs{/sha}","trees_url":"https://api.github.com/repos/kovalikp/nuproj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kovalikp/nuproj/statuses/{sha}","languages_url":"https://api.github.com/repos/kovalikp/nuproj/languages","stargazers_url":"https://api.github.com/repos/kovalikp/nuproj/stargazers","contributors_url":"https://api.github.com/repos/kovalikp/nuproj/contributors","subscribers_url":"https://api.github.com/repos/kovalikp/nuproj/subscribers","subscription_url":"https://api.github.com/repos/kovalikp/nuproj/subscription","commits_url":"https://api.github.com/repos/kovalikp/nuproj/commits{/sha}","git_commits_url":"https://api.github.com/repos/kovalikp/nuproj/git/commits{/sha}","comments_url":"https://api.github.com/repos/kovalikp/nuproj/comments{/number}","issue_comment_url":"https://api.github.com/repos/kovalikp/nuproj/issues/comments{/number}","contents_url":"https://api.github.com/repos/kovalikp/nuproj/contents/{+path}","compare_url":"https://api.github.com/repos/kovalikp/nuproj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kovalikp/nuproj/merges","archive_url":"https://api.github.com/repos/kovalikp/nuproj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kovalikp/nuproj/downloads","issues_url":"https://api.github.com/repos/kovalikp/nuproj/issues{/number}","pulls_url":"https://api.github.com/repos/kovalikp/nuproj/pulls{/number}","milestones_url":"https://api.github.com/repos/kovalikp/nuproj/milestones{/number}","notifications_url":"https://api.github.com/repos/kovalikp/nuproj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kovalikp/nuproj/labels{/name}","releases_url":"https://api.github.com/repos/kovalikp/nuproj/releases{/id}","created_at":"2014-08-25T19:07:00Z","updated_at":"2015-01-15T18:46:24Z","pushed_at":"2015-01-17T19:52:27Z","git_url":"git://github.com/kovalikp/nuproj.git","ssh_url":"git@github.com:kovalikp/nuproj.git","clone_url":"https://github.com/kovalikp/nuproj.git","svn_url":"https://github.com/kovalikp/nuproj","homepage":"","size":718,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terrajobst:master","ref":"master","sha":"c2e1b5fd0e4a7f9b13636d331a09a29fa616e61b","user":{"login":"terrajobst","id":5169960,"avatar_url":"https://avatars.githubusercontent.com/u/5169960?v=3","gravatar_id":"","url":"https://api.github.com/users/terrajobst","html_url":"https://github.com/terrajobst","followers_url":"https://api.github.com/users/terrajobst/followers","following_url":"https://api.github.com/users/terrajobst/following{/other_user}","gists_url":"https://api.github.com/users/terrajobst/gists{/gist_id}","starred_url":"https://api.github.com/users/terrajobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrajobst/subscriptions","organizations_url":"https://api.github.com/users/terrajobst/orgs","repos_url":"https://api.github.com/users/terrajobst/repos","events_url":"https://api.github.com/users/terrajobst/events{/privacy}","received_events_url":"https://api.github.com/users/terrajobst/received_events","type":"User","site_admin":false},"repo":{"id":23301402,"name":"nuproj","full_name":"terrajobst/nuproj","owner":{"login":"terrajobst","id":5169960,"avatar_url":"https://avatars.githubusercontent.com/u/5169960?v=3","gravatar_id":"","url":"https://api.github.com/users/terrajobst","html_url":"https://github.com/terrajobst","followers_url":"https://api.github.com/users/terrajobst/followers","following_url":"https://api.github.com/users/terrajobst/following{/other_user}","gists_url":"https://api.github.com/users/terrajobst/gists{/gist_id}","starred_url":"https://api.github.com/users/terrajobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrajobst/subscriptions","organizations_url":"https://api.github.com/users/terrajobst/orgs","repos_url":"https://api.github.com/users/terrajobst/repos","events_url":"https://api.github.com/users/terrajobst/events{/privacy}","received_events_url":"https://api.github.com/users/terrajobst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/terrajobst/nuproj","description":"Creating NuGet packages the MSBuild way","fork":false,"url":"https://api.github.com/repos/terrajobst/nuproj","forks_url":"https://api.github.com/repos/terrajobst/nuproj/forks","keys_url":"https://api.github.com/repos/terrajobst/nuproj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terrajobst/nuproj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terrajobst/nuproj/teams","hooks_url":"https://api.github.com/repos/terrajobst/nuproj/hooks","issue_events_url":"https://api.github.com/repos/terrajobst/nuproj/issues/events{/number}","events_url":"https://api.github.com/repos/terrajobst/nuproj/events","assignees_url":"https://api.github.com/repos/terrajobst/nuproj/assignees{/user}","branches_url":"https://api.github.com/repos/terrajobst/nuproj/branches{/branch}","tags_url":"https://api.github.com/repos/terrajobst/nuproj/tags","blobs_url":"https://api.github.com/repos/terrajobst/nuproj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terrajobst/nuproj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terrajobst/nuproj/git/refs{/sha}","trees_url":"https://api.github.com/repos/terrajobst/nuproj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terrajobst/nuproj/statuses/{sha}","languages_url":"https://api.github.com/repos/terrajobst/nuproj/languages","stargazers_url":"https://api.github.com/repos/terrajobst/nuproj/stargazers","contributors_url":"https://api.github.com/repos/terrajobst/nuproj/contributors","subscribers_url":"https://api.github.com/repos/terrajobst/nuproj/subscribers","subscription_url":"https://api.github.com/repos/terrajobst/nuproj/subscription","commits_url":"https://api.github.com/repos/terrajobst/nuproj/commits{/sha}","git_commits_url":"https://api.github.com/repos/terrajobst/nuproj/git/commits{/sha}","comments_url":"https://api.github.com/repos/terrajobst/nuproj/comments{/number}","issue_comment_url":"https://api.github.com/repos/terrajobst/nuproj/issues/comments{/number}","contents_url":"https://api.github.com/repos/terrajobst/nuproj/contents/{+path}","compare_url":"https://api.github.com/repos/terrajobst/nuproj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terrajobst/nuproj/merges","archive_url":"https://api.github.com/repos/terrajobst/nuproj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terrajobst/nuproj/downloads","issues_url":"https://api.github.com/repos/terrajobst/nuproj/issues{/number}","pulls_url":"https://api.github.com/repos/terrajobst/nuproj/pulls{/number}","milestones_url":"https://api.github.com/repos/terrajobst/nuproj/milestones{/number}","notifications_url":"https://api.github.com/repos/terrajobst/nuproj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terrajobst/nuproj/labels{/name}","releases_url":"https://api.github.com/repos/terrajobst/nuproj/releases{/id}","created_at":"2014-08-25T04:05:19Z","updated_at":"2015-02-24T21:17:43Z","pushed_at":"2015-02-07T18:20:38Z","git_url":"git://github.com/terrajobst/nuproj.git","ssh_url":"git@github.com:terrajobst/nuproj.git","clone_url":"https://github.com/terrajobst/nuproj.git","svn_url":"https://github.com/terrajobst/nuproj","homepage":"http://nuproj.net","size":1092,"stargazers_count":35,"watchers_count":35,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":38,"forks":10,"open_issues":38,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terrajobst/nuproj/pulls/63"},"html":{"href":"https://github.com/terrajobst/nuproj/pull/63"},"issue":{"href":"https://api.github.com/repos/terrajobst/nuproj/issues/63"},"comments":{"href":"https://api.github.com/repos/terrajobst/nuproj/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/terrajobst/nuproj/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/terrajobst/nuproj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terrajobst/nuproj/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/terrajobst/nuproj/statuses/3ce88b660116d754589b86428c29d9f3bf9c32a5"}}}}