{"action":"created","comment":{"url":"https://api.github.com/repos/rear/rear/pulls/comments/42125609","id":42125609,"diff_hunk":"@@ -373,8 +373,11 @@ LANG_RECOVER=C\n FDRUPSTREAM_INSTALL_PATH=\"/opt/fdrupstream\"\n COPY_AS_IS_FDRUPSTREAM=( \"$FDRUPSTREAM_INSTALL_PATH\" )\n COPY_AS_IS_EXCLUDE_FDRUPSTREAM=( \"$FDRUPSTREAM_INSTALL_PATH/usserver\" )\n-#CHECK_CONFIG_FILES_FDRUPSTREAM=( \"$FDRUPSTREAM_INSTALL_PATH/upstream.cfg\" \"$FDRUPSTREAM_INSTALL_PATH/uscmd1\" \"$FDRUPSTREAM_INSTALL_PATH/usdaemon2\" )\n+CHECK_CONFIG_FILES_FDRUPSTREAM=( \"$FDRUPSTREAM_INSTALL_PATH/uscmd*\" \"$FDRUPSTREAM_INSTALL_PATH/usdaemon*\" \"$FDRUPSTREAM_INSTALL_PATH/us\" \"$FDRUPSTREAM_INSTALL_PATH/us1\" \"$FDRUPSTREAM_INSTALL_PATH/us.ser\" \"$FDRUPSTREAM_INSTALL_PATH/*.so\" \"$FDRUPSTREAM_INSTALL_PATH/usudb*\" \"$FDRUPSTREAM_INSTALL_PATH/*.dat\" \"$FDRUPSTREAM_INSTALL_PATH/*.cfg\" )","path":"usr/share/rear/conf/default.conf","position":5,"original_position":5,"commit_id":"6f50b2712564d70742eabbee29ae0730904f0b13","original_commit_id":"6f50b2712564d70742eabbee29ae0730904f0b13","user":{"login":"rowens275","id":14808030,"avatar_url":"https://avatars.githubusercontent.com/u/14808030?v=3","gravatar_id":"","url":"https://api.github.com/users/rowens275","html_url":"https://github.com/rowens275","followers_url":"https://api.github.com/users/rowens275/followers","following_url":"https://api.github.com/users/rowens275/following{/other_user}","gists_url":"https://api.github.com/users/rowens275/gists{/gist_id}","starred_url":"https://api.github.com/users/rowens275/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowens275/subscriptions","organizations_url":"https://api.github.com/users/rowens275/orgs","repos_url":"https://api.github.com/users/rowens275/repos","events_url":"https://api.github.com/users/rowens275/events{/privacy}","received_events_url":"https://api.github.com/users/rowens275/received_events","type":"User","site_admin":false},"body":"I did test with <code>rear checklayout</code>, and the quoted patterns do work.  But I've just now tested without the quotes and they work as well.  Is there reason for concern that future code changes in <code>51_compare_files.sh</code> might make the quoted patterns stop working?  I'm not opposed to removing the quotes if you think they are risky.\r\n\r\nRegarding <code>FDRUPSTREAM_INSTALL_PATH</code>, let me give that some more thought.  My plan was that if <code>FDRUPSTREAM_INSTALL_PATH</code> were to be changed in <code>local.conf</code>, the user would need to copy the rest of the <code>\\*FDRUPSTREAM*</code> variables from <code>default.conf</code> to <code>local.conf</code> -- but I will look into other ways of handling this (like in the <code>prep</code> stage, as you suggested).\r\n\r\nThanks for the input.","created_at":"2015-10-15T13:47:41Z","updated_at":"2015-10-15T13:47:41Z","html_url":"https://github.com/rear/rear/pull/668#discussion_r42125609","pull_request_url":"https://api.github.com/repos/rear/rear/pulls/668","_links":{"self":{"href":"https://api.github.com/repos/rear/rear/pulls/comments/42125609"},"html":{"href":"https://github.com/rear/rear/pull/668#discussion_r42125609"},"pull_request":{"href":"https://api.github.com/repos/rear/rear/pulls/668"}}},"pull_request":{"url":"https://api.github.com/repos/rear/rear/pulls/668","id":47444472,"html_url":"https://github.com/rear/rear/pull/668","diff_url":"https://github.com/rear/rear/pull/668.diff","patch_url":"https://github.com/rear/rear/pull/668.patch","issue_url":"https://api.github.com/repos/rear/rear/issues/668","number":668,"state":"open","locked":false,"title":"Check for FDRUPSTREAM changed files and required programs","user":{"login":"rowens275","id":14808030,"avatar_url":"https://avatars.githubusercontent.com/u/14808030?v=3","gravatar_id":"","url":"https://api.github.com/users/rowens275","html_url":"https://github.com/rowens275","followers_url":"https://api.github.com/users/rowens275/followers","following_url":"https://api.github.com/users/rowens275/following{/other_user}","gists_url":"https://api.github.com/users/rowens275/gists{/gist_id}","starred_url":"https://api.github.com/users/rowens275/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowens275/subscriptions","organizations_url":"https://api.github.com/users/rowens275/orgs","repos_url":"https://api.github.com/users/rowens275/repos","events_url":"https://api.github.com/users/rowens275/events{/privacy}","received_events_url":"https://api.github.com/users/rowens275/received_events","type":"User","site_admin":false},"body":"Some improvements, but no major change in function.  I've created CHECK_CONFIG_FILES_FDRUPSTREAM to track changes in certain files in $FDRUPSTREAM_INSTALL_PATH which should trigger a new ISO build.  I've also created REQUIRED_PROGS_FDRUPSTREAM which only checks for one critical file, but that is enough to verify that the user has $FDRUPSTREAM_INSTALL_PATH set correctly.","created_at":"2015-10-12T17:25:40Z","updated_at":"2015-10-15T13:47:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dfd8e7690fcdb845ad7a2369caa92f5ef681f08","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rear/rear/pulls/668/commits","review_comments_url":"https://api.github.com/repos/rear/rear/pulls/668/comments","review_comment_url":"https://api.github.com/repos/rear/rear/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rear/rear/issues/668/comments","statuses_url":"https://api.github.com/repos/rear/rear/statuses/6f50b2712564d70742eabbee29ae0730904f0b13","head":{"label":"Innovation-Data-Processing:master","ref":"master","sha":"6f50b2712564d70742eabbee29ae0730904f0b13","user":{"login":"Innovation-Data-Processing","id":14808104,"avatar_url":"https://avatars.githubusercontent.com/u/14808104?v=3","gravatar_id":"","url":"https://api.github.com/users/Innovation-Data-Processing","html_url":"https://github.com/Innovation-Data-Processing","followers_url":"https://api.github.com/users/Innovation-Data-Processing/followers","following_url":"https://api.github.com/users/Innovation-Data-Processing/following{/other_user}","gists_url":"https://api.github.com/users/Innovation-Data-Processing/gists{/gist_id}","starred_url":"https://api.github.com/users/Innovation-Data-Processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Innovation-Data-Processing/subscriptions","organizations_url":"https://api.github.com/users/Innovation-Data-Processing/orgs","repos_url":"https://api.github.com/users/Innovation-Data-Processing/repos","events_url":"https://api.github.com/users/Innovation-Data-Processing/events{/privacy}","received_events_url":"https://api.github.com/users/Innovation-Data-Processing/received_events","type":"Organization","site_admin":false},"repo":{"id":43022795,"name":"rear","full_name":"Innovation-Data-Processing/rear","owner":{"login":"Innovation-Data-Processing","id":14808104,"avatar_url":"https://avatars.githubusercontent.com/u/14808104?v=3","gravatar_id":"","url":"https://api.github.com/users/Innovation-Data-Processing","html_url":"https://github.com/Innovation-Data-Processing","followers_url":"https://api.github.com/users/Innovation-Data-Processing/followers","following_url":"https://api.github.com/users/Innovation-Data-Processing/following{/other_user}","gists_url":"https://api.github.com/users/Innovation-Data-Processing/gists{/gist_id}","starred_url":"https://api.github.com/users/Innovation-Data-Processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Innovation-Data-Processing/subscriptions","organizations_url":"https://api.github.com/users/Innovation-Data-Processing/orgs","repos_url":"https://api.github.com/users/Innovation-Data-Processing/repos","events_url":"https://api.github.com/users/Innovation-Data-Processing/events{/privacy}","received_events_url":"https://api.github.com/users/Innovation-Data-Processing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Innovation-Data-Processing/rear","description":"Relax-and-Recover - Linux bare metal disaster recovery and system migration solution (cfr. mksysb, ignite)","fork":true,"url":"https://api.github.com/repos/Innovation-Data-Processing/rear","forks_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/forks","keys_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/teams","hooks_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/hooks","issue_events_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/issues/events{/number}","events_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/events","assignees_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/assignees{/user}","branches_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/branches{/branch}","tags_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/tags","blobs_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/git/refs{/sha}","trees_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/statuses/{sha}","languages_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/languages","stargazers_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/stargazers","contributors_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/contributors","subscribers_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/subscribers","subscription_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/subscription","commits_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/commits{/sha}","git_commits_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/git/commits{/sha}","comments_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/comments{/number}","issue_comment_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/issues/comments{/number}","contents_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/contents/{+path}","compare_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/merges","archive_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/downloads","issues_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/issues{/number}","pulls_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/pulls{/number}","milestones_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/milestones{/number}","notifications_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/labels{/name}","releases_url":"https://api.github.com/repos/Innovation-Data-Processing/rear/releases{/id}","created_at":"2015-09-23T19:41:46Z","updated_at":"2015-09-23T19:41:48Z","pushed_at":"2015-10-13T18:52:31Z","git_url":"git://github.com/Innovation-Data-Processing/rear.git","ssh_url":"git@github.com:Innovation-Data-Processing/rear.git","clone_url":"https://github.com/Innovation-Data-Processing/rear.git","svn_url":"https://github.com/Innovation-Data-Processing/rear","homepage":"http://relax-and-recover.org/","size":3619,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rear:master","ref":"master","sha":"f1606da52b22206a997a697d47c49e5659402081","user":{"login":"rear","id":1389578,"avatar_url":"https://avatars.githubusercontent.com/u/1389578?v=3","gravatar_id":"","url":"https://api.github.com/users/rear","html_url":"https://github.com/rear","followers_url":"https://api.github.com/users/rear/followers","following_url":"https://api.github.com/users/rear/following{/other_user}","gists_url":"https://api.github.com/users/rear/gists{/gist_id}","starred_url":"https://api.github.com/users/rear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rear/subscriptions","organizations_url":"https://api.github.com/users/rear/orgs","repos_url":"https://api.github.com/users/rear/repos","events_url":"https://api.github.com/users/rear/events{/privacy}","received_events_url":"https://api.github.com/users/rear/received_events","type":"Organization","site_admin":false},"repo":{"id":3449791,"name":"rear","full_name":"rear/rear","owner":{"login":"rear","id":1389578,"avatar_url":"https://avatars.githubusercontent.com/u/1389578?v=3","gravatar_id":"","url":"https://api.github.com/users/rear","html_url":"https://github.com/rear","followers_url":"https://api.github.com/users/rear/followers","following_url":"https://api.github.com/users/rear/following{/other_user}","gists_url":"https://api.github.com/users/rear/gists{/gist_id}","starred_url":"https://api.github.com/users/rear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rear/subscriptions","organizations_url":"https://api.github.com/users/rear/orgs","repos_url":"https://api.github.com/users/rear/repos","events_url":"https://api.github.com/users/rear/events{/privacy}","received_events_url":"https://api.github.com/users/rear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rear/rear","description":"Relax-and-Recover - Linux bare metal disaster recovery and system migration solution (cfr. mksysb, ignite)","fork":false,"url":"https://api.github.com/repos/rear/rear","forks_url":"https://api.github.com/repos/rear/rear/forks","keys_url":"https://api.github.com/repos/rear/rear/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rear/rear/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rear/rear/teams","hooks_url":"https://api.github.com/repos/rear/rear/hooks","issue_events_url":"https://api.github.com/repos/rear/rear/issues/events{/number}","events_url":"https://api.github.com/repos/rear/rear/events","assignees_url":"https://api.github.com/repos/rear/rear/assignees{/user}","branches_url":"https://api.github.com/repos/rear/rear/branches{/branch}","tags_url":"https://api.github.com/repos/rear/rear/tags","blobs_url":"https://api.github.com/repos/rear/rear/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rear/rear/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rear/rear/git/refs{/sha}","trees_url":"https://api.github.com/repos/rear/rear/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rear/rear/statuses/{sha}","languages_url":"https://api.github.com/repos/rear/rear/languages","stargazers_url":"https://api.github.com/repos/rear/rear/stargazers","contributors_url":"https://api.github.com/repos/rear/rear/contributors","subscribers_url":"https://api.github.com/repos/rear/rear/subscribers","subscription_url":"https://api.github.com/repos/rear/rear/subscription","commits_url":"https://api.github.com/repos/rear/rear/commits{/sha}","git_commits_url":"https://api.github.com/repos/rear/rear/git/commits{/sha}","comments_url":"https://api.github.com/repos/rear/rear/comments{/number}","issue_comment_url":"https://api.github.com/repos/rear/rear/issues/comments{/number}","contents_url":"https://api.github.com/repos/rear/rear/contents/{+path}","compare_url":"https://api.github.com/repos/rear/rear/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rear/rear/merges","archive_url":"https://api.github.com/repos/rear/rear/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rear/rear/downloads","issues_url":"https://api.github.com/repos/rear/rear/issues{/number}","pulls_url":"https://api.github.com/repos/rear/rear/pulls{/number}","milestones_url":"https://api.github.com/repos/rear/rear/milestones{/number}","notifications_url":"https://api.github.com/repos/rear/rear/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rear/rear/labels{/name}","releases_url":"https://api.github.com/repos/rear/rear/releases{/id}","created_at":"2012-02-15T13:44:45Z","updated_at":"2015-09-26T20:01:14Z","pushed_at":"2015-10-13T18:52:33Z","git_url":"git://github.com/rear/rear.git","ssh_url":"git@github.com:rear/rear.git","clone_url":"https://github.com/rear/rear.git","svn_url":"https://github.com/rear/rear","homepage":"http://relax-and-recover.org/","size":5462,"stargazers_count":102,"watchers_count":102,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":82,"forks":73,"open_issues":82,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rear/rear/pulls/668"},"html":{"href":"https://github.com/rear/rear/pull/668"},"issue":{"href":"https://api.github.com/repos/rear/rear/issues/668"},"comments":{"href":"https://api.github.com/repos/rear/rear/issues/668/comments"},"review_comments":{"href":"https://api.github.com/repos/rear/rear/pulls/668/comments"},"review_comment":{"href":"https://api.github.com/repos/rear/rear/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rear/rear/pulls/668/commits"},"statuses":{"href":"https://api.github.com/repos/rear/rear/statuses/6f50b2712564d70742eabbee29ae0730904f0b13"}}}}