{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/pulls/1","id":48004638,"html_url":"https://github.com/rexlucien/Rex.Skill.Tdd/pull/1","diff_url":"https://github.com/rexlucien/Rex.Skill.Tdd/pull/1.diff","patch_url":"https://github.com/rexlucien/Rex.Skill.Tdd/pull/1.patch","issue_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/issues/1","number":1,"state":"closed","locked":false,"title":"Update GroupPagingServiceTests.cs","user":{"login":"hatelove","id":1528587,"avatar_url":"https://avatars.githubusercontent.com/u/1528587?v=3","gravatar_id":"","url":"https://api.github.com/users/hatelove","html_url":"https://github.com/hatelove","followers_url":"https://api.github.com/users/hatelove/followers","following_url":"https://api.github.com/users/hatelove/following{/other_user}","gists_url":"https://api.github.com/users/hatelove/gists{/gist_id}","starred_url":"https://api.github.com/users/hatelove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatelove/subscriptions","organizations_url":"https://api.github.com/users/hatelove/orgs","repos_url":"https://api.github.com/users/hatelove/repos","events_url":"https://api.github.com/users/hatelove/events{/privacy}","received_events_url":"https://api.github.com/users/hatelove/received_events","type":"User","site_admin":false},"body":"請看 pull request 的註解差異。\r\n\r\n第二個 test case 的修正同第一個 test case。\r\n\r\n不應該是兩個方法：SumGoodsCost() 跟 SumGoodsRevenue(), 這樣未來如果 Goods 有新的欄位，就得新開一個方法，相當沒有彈性，也與需求不符。\r\n\r\n可以有更漂亮的作法，看您想不想再調整看看。","created_at":"2015-10-18T09:05:45Z","updated_at":"2015-10-18T09:23:59Z","closed_at":"2015-10-18T09:23:58Z","merged_at":"2015-10-18T09:23:58Z","merge_commit_sha":"25648412ff9141a2428edc7136c375a4ffea996b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/pulls/1/commits","review_comments_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/pulls/1/comments","review_comment_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/issues/1/comments","statuses_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/statuses/76bf803fede6772165e4f1a9ba023135605da96b","head":{"label":"hatelove:patch-1","ref":"patch-1","sha":"76bf803fede6772165e4f1a9ba023135605da96b","user":{"login":"hatelove","id":1528587,"avatar_url":"https://avatars.githubusercontent.com/u/1528587?v=3","gravatar_id":"","url":"https://api.github.com/users/hatelove","html_url":"https://github.com/hatelove","followers_url":"https://api.github.com/users/hatelove/followers","following_url":"https://api.github.com/users/hatelove/following{/other_user}","gists_url":"https://api.github.com/users/hatelove/gists{/gist_id}","starred_url":"https://api.github.com/users/hatelove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatelove/subscriptions","organizations_url":"https://api.github.com/users/hatelove/orgs","repos_url":"https://api.github.com/users/hatelove/repos","events_url":"https://api.github.com/users/hatelove/events{/privacy}","received_events_url":"https://api.github.com/users/hatelove/received_events","type":"User","site_admin":false},"repo":{"id":44471641,"name":"Rex.Skill.Tdd","full_name":"hatelove/Rex.Skill.Tdd","owner":{"login":"hatelove","id":1528587,"avatar_url":"https://avatars.githubusercontent.com/u/1528587?v=3","gravatar_id":"","url":"https://api.github.com/users/hatelove","html_url":"https://github.com/hatelove","followers_url":"https://api.github.com/users/hatelove/followers","following_url":"https://api.github.com/users/hatelove/following{/other_user}","gists_url":"https://api.github.com/users/hatelove/gists{/gist_id}","starred_url":"https://api.github.com/users/hatelove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatelove/subscriptions","organizations_url":"https://api.github.com/users/hatelove/orgs","repos_url":"https://api.github.com/users/hatelove/repos","events_url":"https://api.github.com/users/hatelove/events{/privacy}","received_events_url":"https://api.github.com/users/hatelove/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hatelove/Rex.Skill.Tdd","description":"Rex.Skill.Tdd","fork":true,"url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd","forks_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/forks","keys_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/teams","hooks_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/hooks","issue_events_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/issues/events{/number}","events_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/events","assignees_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/assignees{/user}","branches_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/branches{/branch}","tags_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/tags","blobs_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/git/refs{/sha}","trees_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/statuses/{sha}","languages_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/languages","stargazers_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/stargazers","contributors_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/contributors","subscribers_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/subscribers","subscription_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/subscription","commits_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/commits{/sha}","git_commits_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/git/commits{/sha}","comments_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/comments{/number}","issue_comment_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/issues/comments{/number}","contents_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/contents/{+path}","compare_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/merges","archive_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/downloads","issues_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/issues{/number}","pulls_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/pulls{/number}","milestones_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/milestones{/number}","notifications_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/labels{/name}","releases_url":"https://api.github.com/repos/hatelove/Rex.Skill.Tdd/releases{/id}","created_at":"2015-10-18T08:59:13Z","updated_at":"2015-10-18T08:59:14Z","pushed_at":"2015-10-18T09:05:35Z","git_url":"git://github.com/hatelove/Rex.Skill.Tdd.git","ssh_url":"git@github.com:hatelove/Rex.Skill.Tdd.git","clone_url":"https://github.com/hatelove/Rex.Skill.Tdd.git","svn_url":"https://github.com/hatelove/Rex.Skill.Tdd","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rexlucien:master","ref":"master","sha":"9b264834d57598a301c005ce539b8f7bd23e9aef","user":{"login":"rexlucien","id":7827971,"avatar_url":"https://avatars.githubusercontent.com/u/7827971?v=3","gravatar_id":"","url":"https://api.github.com/users/rexlucien","html_url":"https://github.com/rexlucien","followers_url":"https://api.github.com/users/rexlucien/followers","following_url":"https://api.github.com/users/rexlucien/following{/other_user}","gists_url":"https://api.github.com/users/rexlucien/gists{/gist_id}","starred_url":"https://api.github.com/users/rexlucien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexlucien/subscriptions","organizations_url":"https://api.github.com/users/rexlucien/orgs","repos_url":"https://api.github.com/users/rexlucien/repos","events_url":"https://api.github.com/users/rexlucien/events{/privacy}","received_events_url":"https://api.github.com/users/rexlucien/received_events","type":"User","site_admin":false},"repo":{"id":44470737,"name":"Rex.Skill.Tdd","full_name":"rexlucien/Rex.Skill.Tdd","owner":{"login":"rexlucien","id":7827971,"avatar_url":"https://avatars.githubusercontent.com/u/7827971?v=3","gravatar_id":"","url":"https://api.github.com/users/rexlucien","html_url":"https://github.com/rexlucien","followers_url":"https://api.github.com/users/rexlucien/followers","following_url":"https://api.github.com/users/rexlucien/following{/other_user}","gists_url":"https://api.github.com/users/rexlucien/gists{/gist_id}","starred_url":"https://api.github.com/users/rexlucien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexlucien/subscriptions","organizations_url":"https://api.github.com/users/rexlucien/orgs","repos_url":"https://api.github.com/users/rexlucien/repos","events_url":"https://api.github.com/users/rexlucien/events{/privacy}","received_events_url":"https://api.github.com/users/rexlucien/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rexlucien/Rex.Skill.Tdd","description":"Rex.Skill.Tdd","fork":false,"url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd","forks_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/forks","keys_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/teams","hooks_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/hooks","issue_events_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/issues/events{/number}","events_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/events","assignees_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/assignees{/user}","branches_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/branches{/branch}","tags_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/tags","blobs_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/statuses/{sha}","languages_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/languages","stargazers_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/stargazers","contributors_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/contributors","subscribers_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/subscribers","subscription_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/subscription","commits_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/contents/{+path}","compare_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/merges","archive_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/downloads","issues_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/issues{/number}","pulls_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/pulls{/number}","milestones_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/milestones{/number}","notifications_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/labels{/name}","releases_url":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/releases{/id}","created_at":"2015-10-18T08:24:11Z","updated_at":"2015-10-18T08:24:17Z","pushed_at":"2015-10-18T09:23:58Z","git_url":"git://github.com/rexlucien/Rex.Skill.Tdd.git","ssh_url":"git@github.com:rexlucien/Rex.Skill.Tdd.git","clone_url":"https://github.com/rexlucien/Rex.Skill.Tdd.git","svn_url":"https://github.com/rexlucien/Rex.Skill.Tdd","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/pulls/1"},"html":{"href":"https://github.com/rexlucien/Rex.Skill.Tdd/pull/1"},"issue":{"href":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/issues/1"},"comments":{"href":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/rexlucien/Rex.Skill.Tdd/statuses/76bf803fede6772165e4f1a9ba023135605da96b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rexlucien","id":7827971,"avatar_url":"https://avatars.githubusercontent.com/u/7827971?v=3","gravatar_id":"","url":"https://api.github.com/users/rexlucien","html_url":"https://github.com/rexlucien","followers_url":"https://api.github.com/users/rexlucien/followers","following_url":"https://api.github.com/users/rexlucien/following{/other_user}","gists_url":"https://api.github.com/users/rexlucien/gists{/gist_id}","starred_url":"https://api.github.com/users/rexlucien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexlucien/subscriptions","organizations_url":"https://api.github.com/users/rexlucien/orgs","repos_url":"https://api.github.com/users/rexlucien/repos","events_url":"https://api.github.com/users/rexlucien/events{/privacy}","received_events_url":"https://api.github.com/users/rexlucien/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":3,"changed_files":1}}