{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/3179","labels_url":"https://api.github.com/repos/nodejs/node/issues/3179/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/3179/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/3179/events","html_url":"https://github.com/nodejs/node/issues/3179","id":109767417,"number":3179,"title":"node compile failure on Solaris 11.2 and gcc 4.8 (undefined std::isnan)","user":{"login":"cgalibern","id":8974489,"avatar_url":"https://avatars.githubusercontent.com/u/8974489?v=3","gravatar_id":"","url":"https://api.github.com/users/cgalibern","html_url":"https://github.com/cgalibern","followers_url":"https://api.github.com/users/cgalibern/followers","following_url":"https://api.github.com/users/cgalibern/following{/other_user}","gists_url":"https://api.github.com/users/cgalibern/gists{/gist_id}","starred_url":"https://api.github.com/users/cgalibern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgalibern/subscriptions","organizations_url":"https://api.github.com/users/cgalibern/orgs","repos_url":"https://api.github.com/users/cgalibern/repos","events_url":"https://api.github.com/users/cgalibern/events{/privacy}","received_events_url":"https://api.github.com/users/cgalibern/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-10-05T10:13:45Z","updated_at":"2015-10-09T19:27:16Z","closed_at":null,"body":"# ./configure --dest-cpu=x64 --dest-os=solaris --prefix=/opt/node\r\nmake                                                                                                                                          \r\nmake -C out BUILDTYPE=Release V=1\r\nmake[1]: Entering directory `.../node.git/out'\r\ndeps/v8/tools/gyp/v8_base.target.mk:432: warning: overriding recipe for target `somewhere/node.git/out/Release/libv8_base.a'\r\ndeps/v8/tools/gyp/v8_base.host.mk:428: warning: ignoring old recipe for target `somewhere/node.git/out/Release/libv8_base.a'\r\ndeps/v8/tools/gyp/v8_libbase.target.mk:147: warning: overriding recipe for target `somewhere/node.git/out/Release/libv8_libbase.a'\r\ndeps/v8/tools/gyp/v8_libbase.host.mk:143: warning: ignoring old recipe for target `somewhere/node.git/out/Release/libv8_libbase.a'\r\ndeps/v8/tools/gyp/v8_libplatform.target.mk:135: warning: overriding recipe for target `somewhere/node.git/out/Release/libv8_libplatform.a'\r\ndeps/v8/tools/gyp/v8_libplatform.host.mk:131: warning: ignoring old recipe for target `somewhere/node.git/out/Release/libv8_libplatform.a'\r\ndeps/v8/tools/gyp/v8_nosnapshot.target.mk:139: warning: overriding recipe for target `somewhere/node.git/out/Release/libv8_nosnapshot.a'\r\ndeps/v8/tools/gyp/v8_nosnapshot.host.mk:135: warning: ignoring old recipe for target `somewhere/node.git/out/Release/libv8_nosnapshot.a'\r\ndeps/v8/tools/gyp/v8_snapshot.target.mk:158: warning: overriding recipe for target `somewhere/node.git/out/Release/libv8_snapshot.a'\r\ndeps/v8/tools/gyp/v8_snapshot.host.mk:158: warning: ignoring old recipe for target `somewhere/node.git/out/Release/libv8_snapshot.a'\r\n  g++ '-DV8_TARGET_ARCH_X64' '-D__C99FEATURES__=1' '-DENABLE_DISASSEMBLER' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' -I../deps/v8  -Wall -Wextra -Wno-unused-parameter -m64 -pthreads -fno-strict-aliasing -O3 -ffunction-sections -fdata-sections -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF somewhere/node.git/out/Release/.deps/somewhere/node.git/out/Release/obj.target/v8_base/deps/v8/src/accessors.o.d.raw  -c -o somewhere/node.git/out/Release/obj.target/v8_base/deps/v8/src/accessors.o ../deps/v8/src/accessors.cc\r\nIn file included from ../deps/v8/src/objects-inl.h:18:0,\r\n                 from ../deps/v8/src/v8.h:39,\r\n                 from ../deps/v8/src/accessors.cc:5:\r\n../deps/v8/src/conversions-inl.h: In function 'double v8::internal::DoubleToInteger(double)':\r\n../deps/v8/src/conversions-inl.h:79:7: error: '__builtin_isnan' is not a member of 'std'\r\n   if (std::isnan(x)) return 0;\r\n       ^\r\n../deps/v8/src/conversions-inl.h:79:7: note: suggested alternative:\r\n<built-in>:0:0: note:   '__builtin_isnan'\r\nIn file included from /usr/include/math.h:13:0,\r\n                 from /usr/gcc/4.8/include/c++/4.8.2/cmath:44,\r\n                 from ../deps/v8/src/utils.h:11,\r\n                 from ../deps/v8/src/v8.h:34,\r\n                 from ../deps/v8/src/accessors.cc:5:\r\n../deps/v8/src/conversions-inl.h:80:13: error: expected unqualified-id before '__extension__'\r\n   if (!std::isfinite(x) || x == 0) return x;\r\n             ^\r\n../deps/v8/src/conversions-inl.h:80:13: error: expected ')' before '__extension__'\r\nIn file included from ../deps/v8/src/v8.h:39:0,\r\n                 from ../deps/v8/src/accessors.cc:5:\r\n../deps/v8/src/objects-inl.h: In member function 'bool v8::internal::Object::IsNaN() const':\r\n../deps/v8/src/objects-inl.h:1125:34: error: '__builtin_isnan' is not a member of 'std'\r\n   return this->IsHeapNumber() && std::isnan(HeapNumber::cast(this)->value());\r\n                                  ^\r\n../deps/v8/src/objects-inl.h:1125:34: note: suggested alternative:\r\n<built-in>:0:0: note:   '__builtin_isnan'\r\n../deps/v8/src/objects-inl.h: In member function 'void v8::internal::FixedDoubleArray::set(int, double)':\r\n../deps/v8/src/objects-inl.h:2312:7: error: '__builtin_isnan' is not a member of 'std'\r\n   if (std::isnan(value)) {\r\n       ^\r\n../deps/v8/src/objects-inl.h:2312:7: note: suggested alternative:\r\n<built-in>:0:0: note:   '__builtin_isnan'\r\nmake[1]: *** [somewhere/node.git/out/Release/obj.target/v8_base/deps/v8/src/accessors.o] Error 1\r\nmake[1]: Leaving directory `somewhere/node.git/out'\r\nmake: *** [node] Error 2\r\n\r\nSame issue as  https://github.com/nodejs/node-v0.x-archive/issues/9351\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/146967075","html_url":"https://github.com/nodejs/node/issues/3179#issuecomment-146967075","issue_url":"https://api.github.com/repos/nodejs/node/issues/3179","id":146967075,"user":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T19:27:16Z","updated_at":"2015-10-09T19:27:16Z","body":"Without access to the same platform I don't have anything against defining `_GLIBCXX_USE_C99_MATH`, although I'd like to understand a bit more details about the problem.\r\n\r\nI would also suggest to upstream the change to V8 instead of making the change in node's `common.gypi`. @cgalibern @jbergstroem Is that something that you guys can do? If not, I can help you do that, but I'd need access to a Solaris machine to test the changes."}}