{"action":"created","issue":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/96","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/96/comments","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/96/events","html_url":"https://github.com/kaldi-asr/kaldi/pull/96","id":103194630,"number":96,"title":"initial commit for CUDA interface change","user":{"login":"naxingyu","id":3320260,"avatar_url":"https://avatars.githubusercontent.com/u/3320260?v=3","gravatar_id":"","url":"https://api.github.com/users/naxingyu","html_url":"https://github.com/naxingyu","followers_url":"https://api.github.com/users/naxingyu/followers","following_url":"https://api.github.com/users/naxingyu/following{/other_user}","gists_url":"https://api.github.com/users/naxingyu/gists{/gist_id}","starred_url":"https://api.github.com/users/naxingyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naxingyu/subscriptions","organizations_url":"https://api.github.com/users/naxingyu/orgs","repos_url":"https://api.github.com/users/naxingyu/repos","events_url":"https://api.github.com/users/naxingyu/events{/privacy}","received_events_url":"https://api.github.com/users/naxingyu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-26T07:10:06Z","updated_at":"2015-08-26T19:44:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/96","html_url":"https://github.com/kaldi-asr/kaldi/pull/96","diff_url":"https://github.com/kaldi-asr/kaldi/pull/96.diff","patch_url":"https://github.com/kaldi-asr/kaldi/pull/96.patch"},"body":"@danpovey This commit is to clarify my understandings of the requirements. It doesn't compile yet. Please drop in any comments to keep it on the right track."},"comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments/135150255","html_url":"https://github.com/kaldi-asr/kaldi/pull/96#issuecomment-135150255","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/96","id":135150255,"user":{"login":"danpovey","id":3298747,"avatar_url":"https://avatars.githubusercontent.com/u/3298747?v=3","gravatar_id":"","url":"https://api.github.com/users/danpovey","html_url":"https://github.com/danpovey","followers_url":"https://api.github.com/users/danpovey/followers","following_url":"https://api.github.com/users/danpovey/following{/other_user}","gists_url":"https://api.github.com/users/danpovey/gists{/gist_id}","starred_url":"https://api.github.com/users/danpovey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpovey/subscriptions","organizations_url":"https://api.github.com/users/danpovey/orgs","repos_url":"https://api.github.com/users/danpovey/repos","events_url":"https://api.github.com/users/danpovey/events{/privacy}","received_events_url":"https://api.github.com/users/danpovey/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T19:44:38Z","updated_at":"2015-08-26T19:44:38Z","body":"Hm, I just sent an email but it doesn't seem to have sent properly (bad\nconnection),\nYour implementation of lookup here\ntemplate<typename Real>+void CuMatrixBase<Real>::Lookup(const\nCuArray<Int32Pair> &indices,+ Real *output) const {\ndoes not look right because you need to back off to non-CUDA if CUDA is not\ncompiled in or is not available.\n\nThe way you malloc'ed the array in another Lookup fiunction was not right\nbecause (a) it should be new[], not malloc, and (b) output was passed by\nvalue so the malloc'ed array would simply be lost.  My interface implies\nthat 'output' already is allocated and has the correct size (of course, you\nshould document that).\nDan\n\n\n\nOn Wed, Aug 26, 2015 at 12:35 PM, Daniel Povey <dpovey@gmail.com> wrote:\n\n> I am flying to Baltimore today, I may not have a good connection to review\n> this.\n>\n> On Wed, Aug 26, 2015 at 12:10 AM, Xingyu Na <notifications@github.com>\n> wrote:\n>\n>> @danpovey <https://github.com/danpovey> This commit is to clarify my\n>> understandings of the requirements. It doesn't compile yet. Please drop in\n>> any comments to keep it on the right track.\n>> ------------------------------\n>> You can view, comment on, or merge this pull request online at:\n>>\n>>   https://github.com/kaldi-asr/kaldi/pull/96\n>> Commit Summary\n>>\n>>    - initial commit for CUDA interface change\n>>\n>> File Changes\n>>\n>>    - *M* src/cudamatrix/cu-array-inl.h\n>>    <https://github.com/kaldi-asr/kaldi/pull/96/files#diff-0> (19)\n>>    - *M* src/cudamatrix/cu-array.h\n>>    <https://github.com/kaldi-asr/kaldi/pull/96/files#diff-1> (1)\n>>    - *M* src/cudamatrix/cu-matrix.cc\n>>    <https://github.com/kaldi-asr/kaldi/pull/96/files#diff-2> (69)\n>>    - *M* src/cudamatrix/cu-matrix.h\n>>    <https://github.com/kaldi-asr/kaldi/pull/96/files#diff-3> (12)\n>>\n>> Patch Links:\n>>\n>>    - https://github.com/kaldi-asr/kaldi/pull/96.patch\n>>    - https://github.com/kaldi-asr/kaldi/pull/96.diff\n>>\n>> —\n>> Reply to this email directly or view it on GitHub\n>> <https://github.com/kaldi-asr/kaldi/pull/96>.\n>>\n>\n>\n"}}