{"action":"created","issue":{"url":"https://api.github.com/repos/gunthercox/ChatterBot/issues/80","labels_url":"https://api.github.com/repos/gunthercox/ChatterBot/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/gunthercox/ChatterBot/issues/80/comments","events_url":"https://api.github.com/repos/gunthercox/ChatterBot/issues/80/events","html_url":"https://github.com/gunthercox/ChatterBot/pull/80","id":118302041,"number":80,"title":"Add evaluate_mathematically","user":{"login":"DarkmatterVale","id":6094957,"avatar_url":"https://avatars.githubusercontent.com/u/6094957?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkmatterVale","html_url":"https://github.com/DarkmatterVale","followers_url":"https://api.github.com/users/DarkmatterVale/followers","following_url":"https://api.github.com/users/DarkmatterVale/following{/other_user}","gists_url":"https://api.github.com/users/DarkmatterVale/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkmatterVale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkmatterVale/subscriptions","organizations_url":"https://api.github.com/users/DarkmatterVale/orgs","repos_url":"https://api.github.com/users/DarkmatterVale/repos","events_url":"https://api.github.com/users/DarkmatterVale/events{/privacy}","received_events_url":"https://api.github.com/users/DarkmatterVale/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-23T00:46:53Z","updated_at":"2015-11-23T13:50:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gunthercox/ChatterBot/pulls/80","html_url":"https://github.com/gunthercox/ChatterBot/pull/80","diff_url":"https://github.com/gunthercox/ChatterBot/pull/80.diff","patch_url":"https://github.com/gunthercox/ChatterBot/pull/80.patch"},"body":"Here is my first attempt at adding a way to evaluate mathematical expressions. @gunthercox what do you think? What are your thoughts on improving implementation?\r\n\r\nA couple of notes. This is not finished, but I am at a point where I need to get input on how to implement it into the program. It currently looks at every incoming question or statement and attempts to decide whether or not the point is to evaluate a mathematical expression. This sort of works, but you run into issues pretty easily once you start describing the quantity of an object. It might think you are trying to have a mathematical expression evaluated, and then it will give the incorrect answer.\r\n\r\nAnother thing to note is the way I structured the function. I decided to create a new kind of adapter because this is definitely not an io adapter, nor is it a storage adapter. You could argue it is a logic adapter, but it doesn't work independent of another logic adapter.\r\n\r\nAlso, the reason the build is failing is because the answer in Python 3.x comes out to ```1.0``` while in 2.7 it is ```1```."},"comment":{"url":"https://api.github.com/repos/gunthercox/ChatterBot/issues/comments/158937337","html_url":"https://github.com/gunthercox/ChatterBot/pull/80#issuecomment-158937337","issue_url":"https://api.github.com/repos/gunthercox/ChatterBot/issues/80","id":158937337,"user":{"login":"gunthercox","id":2030578,"avatar_url":"https://avatars.githubusercontent.com/u/2030578?v=3","gravatar_id":"","url":"https://api.github.com/users/gunthercox","html_url":"https://github.com/gunthercox","followers_url":"https://api.github.com/users/gunthercox/followers","following_url":"https://api.github.com/users/gunthercox/following{/other_user}","gists_url":"https://api.github.com/users/gunthercox/gists{/gist_id}","starred_url":"https://api.github.com/users/gunthercox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunthercox/subscriptions","organizations_url":"https://api.github.com/users/gunthercox/orgs","repos_url":"https://api.github.com/users/gunthercox/repos","events_url":"https://api.github.com/users/gunthercox/events{/privacy}","received_events_url":"https://api.github.com/users/gunthercox/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T13:50:48Z","updated_at":"2015-11-23T13:50:48Z","body":"@DarkmatterVale This is awesome. I will go over this pull request and provide some thorough feedback as soon as possible.\r\n\r\nSo far I think I like the concept of the processor adapter. This might be a really good addition in the future for determining if logic adapters need to run in other multi-logic adapter scenarios."}}