{"action":"created","issue":{"url":"https://api.github.com/repos/fnando/i18n-js/issues/375","labels_url":"https://api.github.com/repos/fnando/i18n-js/issues/375/labels{/name}","comments_url":"https://api.github.com/repos/fnando/i18n-js/issues/375/comments","events_url":"https://api.github.com/repos/fnando/i18n-js/issues/375/events","html_url":"https://github.com/fnando/i18n-js/pull/375","id":122818453,"number":375,"title":"Replace instanceof checks with their Underscore.js equivalents","user":{"login":"TrevorBurnham","id":224895,"avatar_url":"https://avatars.githubusercontent.com/u/224895?v=3","gravatar_id":"","url":"https://api.github.com/users/TrevorBurnham","html_url":"https://github.com/TrevorBurnham","followers_url":"https://api.github.com/users/TrevorBurnham/followers","following_url":"https://api.github.com/users/TrevorBurnham/following{/other_user}","gists_url":"https://api.github.com/users/TrevorBurnham/gists{/gist_id}","starred_url":"https://api.github.com/users/TrevorBurnham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrevorBurnham/subscriptions","organizations_url":"https://api.github.com/users/TrevorBurnham/orgs","repos_url":"https://api.github.com/users/TrevorBurnham/repos","events_url":"https://api.github.com/users/TrevorBurnham/events{/privacy}","received_events_url":"https://api.github.com/users/TrevorBurnham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-17T20:37:06Z","updated_at":"2015-12-21T03:31:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fnando/i18n-js/pulls/375","html_url":"https://github.com/fnando/i18n-js/pull/375","diff_url":"https://github.com/fnando/i18n-js/pull/375.diff","patch_url":"https://github.com/fnando/i18n-js/pull/375.patch"},"body":"This PR replaces all uses of `instanceof Object` and `instanceof Array` with the `_.isObject` and `_.isArray` functions from the latest Underscore.js release: https://github.com/jashkenas/underscore/blob/1.8.3/underscore.js#L1205-L1215 The reason is that `instanceof` can return `false` for objects and arrays passed between different JavaScript environments, e.g. [between a document and an iframe](http://tobyho.com/2011/01/28/checking-types-in-javascript/). In all other cases, these functions should be equivalent."},"comment":{"url":"https://api.github.com/repos/fnando/i18n-js/issues/comments/166189644","html_url":"https://github.com/fnando/i18n-js/pull/375#issuecomment-166189644","issue_url":"https://api.github.com/repos/fnando/i18n-js/issues/375","id":166189644,"user":{"login":"PikachuEXE","id":1018543,"avatar_url":"https://avatars.githubusercontent.com/u/1018543?v=3","gravatar_id":"","url":"https://api.github.com/users/PikachuEXE","html_url":"https://github.com/PikachuEXE","followers_url":"https://api.github.com/users/PikachuEXE/followers","following_url":"https://api.github.com/users/PikachuEXE/following{/other_user}","gists_url":"https://api.github.com/users/PikachuEXE/gists{/gist_id}","starred_url":"https://api.github.com/users/PikachuEXE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PikachuEXE/subscriptions","organizations_url":"https://api.github.com/users/PikachuEXE/orgs","repos_url":"https://api.github.com/users/PikachuEXE/repos","events_url":"https://api.github.com/users/PikachuEXE/events{/privacy}","received_events_url":"https://api.github.com/users/PikachuEXE/received_events","type":"User","site_admin":false},"created_at":"2015-12-21T03:31:19Z","updated_at":"2015-12-21T03:31:19Z","body":"Looks fine\r\nCan you add CHANGELOG entry & squash commits like:\r\n- Add spec\r\n- Change implementation\r\n- Add CHANGELOG entry"}}