{"action":"created","issue":{"url":"https://api.github.com/repos/BobPalmer/MKS/issues/321","labels_url":"https://api.github.com/repos/BobPalmer/MKS/issues/321/labels{/name}","comments_url":"https://api.github.com/repos/BobPalmer/MKS/issues/321/comments","events_url":"https://api.github.com/repos/BobPalmer/MKS/issues/321/events","html_url":"https://github.com/BobPalmer/MKS/issues/321","id":55361903,"number":321,"title":"Tweakscaled radial supply tanks do not retain correct capacity","user":{"login":"wisq","id":255758,"avatar_url":"https://avatars.githubusercontent.com/u/255758?v=3","gravatar_id":"","url":"https://api.github.com/users/wisq","html_url":"https://github.com/wisq","followers_url":"https://api.github.com/users/wisq/followers","following_url":"https://api.github.com/users/wisq/following{/other_user}","gists_url":"https://api.github.com/users/wisq/gists{/gist_id}","starred_url":"https://api.github.com/users/wisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wisq/subscriptions","organizations_url":"https://api.github.com/users/wisq/orgs","repos_url":"https://api.github.com/users/wisq/repos","events_url":"https://api.github.com/users/wisq/events{/privacy}","received_events_url":"https://api.github.com/users/wisq/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/BobPalmer/MKS/labels/Dependency%20Bug","name":"Dependency Bug","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-24T07:10:15Z","updated_at":"2015-11-05T20:27:49Z","closed_at":null,"body":"There are a number of events that will reset the capacity of a radial supply tank to the default quantity:\r\n\r\n1. Applying symmetry\r\n2. Cloning the part\r\n3. Saving/loading (including launching)\r\n\r\nWhan this means is, if you have a tank that (say) holds 1200 of a resource, and you resize it from 1.25m to 2.5m, it now holds 9600 of that resource.  But when you grab it for symmetry, it will revert to only holding 1200 of that resource, despite the increased size.\r\n\r\nIf, instead of grabbing it, you just launch the ship, you'll find that you now have 9600 out of 1200 in that tank, i.e. it's over capacity.\r\n\r\nSo while radial supply tanks + tweakscale are okay for getting quantities of a resource into orbit, it won't work for long term storage (e.g. on an OKS space station), because they'll always have the 1.25m capacity no matter what size they are.\r\n\r\nDemonstration video: https://www.youtube.com/watch?v=akaeg7-gu9Y\r\n\r\nRunning Kolonization 0.22.3, Tweakscale 1.50, both from CKAN.  I'm also running *a ton* of other mods, so if it turns out this is some weird interaction and isn't reproducible on your end, please let me know and I'll dig deeper.  Right now I'm assuming it's just a simple oversight."},"comment":{"url":"https://api.github.com/repos/BobPalmer/MKS/issues/comments/154180771","html_url":"https://github.com/BobPalmer/MKS/issues/321#issuecomment-154180771","issue_url":"https://api.github.com/repos/BobPalmer/MKS/issues/321","id":154180771,"user":{"login":"pellinor0","id":11016463,"avatar_url":"https://avatars.githubusercontent.com/u/11016463?v=3","gravatar_id":"","url":"https://api.github.com/users/pellinor0","html_url":"https://github.com/pellinor0","followers_url":"https://api.github.com/users/pellinor0/followers","following_url":"https://api.github.com/users/pellinor0/following{/other_user}","gists_url":"https://api.github.com/users/pellinor0/gists{/gist_id}","starred_url":"https://api.github.com/users/pellinor0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pellinor0/subscriptions","organizations_url":"https://api.github.com/users/pellinor0/orgs","repos_url":"https://api.github.com/users/pellinor0/repos","events_url":"https://api.github.com/users/pellinor0/events{/privacy}","received_events_url":"https://api.github.com/users/pellinor0/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T20:27:49Z","updated_at":"2015-11-05T20:27:49Z","body":"It looks like this is fixed and can be closed. Please contact me if there is anything left to do from the TweakScale side. "}}