{"action":"created","issue":{"url":"https://api.github.com/repos/martinklepsch/s3-beam/issues/21","labels_url":"https://api.github.com/repos/martinklepsch/s3-beam/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/martinklepsch/s3-beam/issues/21/comments","events_url":"https://api.github.com/repos/martinklepsch/s3-beam/issues/21/events","html_url":"https://github.com/martinklepsch/s3-beam/pull/21","id":104609039,"number":21,"title":"Handle Errors & Object Key Naming","user":{"login":"GetContented","id":5661934,"avatar_url":"https://avatars.githubusercontent.com/u/5661934?v=3","gravatar_id":"","url":"https://api.github.com/users/GetContented","html_url":"https://github.com/GetContented","followers_url":"https://api.github.com/users/GetContented/followers","following_url":"https://api.github.com/users/GetContented/following{/other_user}","gists_url":"https://api.github.com/users/GetContented/gists{/gist_id}","starred_url":"https://api.github.com/users/GetContented/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GetContented/subscriptions","organizations_url":"https://api.github.com/users/GetContented/orgs","repos_url":"https://api.github.com/users/GetContented/repos","events_url":"https://api.github.com/users/GetContented/events{/privacy}","received_events_url":"https://api.github.com/users/GetContented/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-09-03T02:34:39Z","updated_at":"2015-11-26T01:25:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/martinklepsch/s3-beam/pulls/21","html_url":"https://github.com/martinklepsch/s3-beam/pull/21","diff_url":"https://github.com/martinklepsch/s3-beam/pull/21.diff","patch_url":"https://github.com/martinklepsch/s3-beam/pull/21.patch"},"body":"- Makes the s3-pipe put a response map of interpreted data from S3 onto its report-chan, instead of just the file object or location. \r\n- Makes so that the s3-pipe can have either a map or a file put onto its upload-file chan: in the case of the map, it will have a :file key that contains the file, and will later be adjusted to allow an \"object key\" key to be passed through as well. Add an identifier key to this map for later passing back on the response channel - for identification by the user code that handles the response - also pass the identifier back thru the upload-file function, too.\r\n- Make so that the sign-file handles errors and reports the errors back, and so that the upload-file function passes these errors through\r\n- Make so that upload-file function handles errors of its own - such as http errors, and response codes from AWS, and reports these back on the response map\r\n- Make so that s3-pipe can have a key-fn passed to it which will be used to generate file keys before signing\r\n- Make it so that the upload-file chan’s map can have an object key which will be used for the file key before signing which is preferred to the key-fn"},"comment":{"url":"https://api.github.com/repos/martinklepsch/s3-beam/issues/comments/159773901","html_url":"https://github.com/martinklepsch/s3-beam/pull/21#issuecomment-159773901","issue_url":"https://api.github.com/repos/martinklepsch/s3-beam/issues/21","id":159773901,"user":{"login":"kennyjwilli","id":2453976,"avatar_url":"https://avatars.githubusercontent.com/u/2453976?v=3","gravatar_id":"","url":"https://api.github.com/users/kennyjwilli","html_url":"https://github.com/kennyjwilli","followers_url":"https://api.github.com/users/kennyjwilli/followers","following_url":"https://api.github.com/users/kennyjwilli/following{/other_user}","gists_url":"https://api.github.com/users/kennyjwilli/gists{/gist_id}","starred_url":"https://api.github.com/users/kennyjwilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennyjwilli/subscriptions","organizations_url":"https://api.github.com/users/kennyjwilli/orgs","repos_url":"https://api.github.com/users/kennyjwilli/repos","events_url":"https://api.github.com/users/kennyjwilli/events{/privacy}","received_events_url":"https://api.github.com/users/kennyjwilli/received_events","type":"User","site_admin":false},"created_at":"2015-11-26T01:25:33Z","updated_at":"2015-11-26T01:25:33Z","body":"@martinklepsch and @GetContented I have updated #24 to include all changes. I believe this merge will satisfy all parties. @martinklepsch please review."}}