{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/comments/48442893","id":48442893,"diff_hunk":"@@ -154,6 +154,7 @@\n           'ssl_verify_depth'            => '3',\n           'ssl_options'                 => '+ExportCertData',\n           'ssl_openssl_conf_cmd'        => 'DHParameters \"foo.pem\"',\n+          'ssl_proxy_verify'            => 'require',","path":"spec/defines/vhost_spec.rb","position":4,"original_position":4,"commit_id":"0ab0e393f0e7254bc28f69b624cf212f120a254c","original_commit_id":"0ab0e393f0e7254bc28f69b624cf212f120a254c","user":{"login":"bmjen","id":5577705,"avatar_url":"https://avatars.githubusercontent.com/u/5577705?v=3","gravatar_id":"","url":"https://api.github.com/users/bmjen","html_url":"https://github.com/bmjen","followers_url":"https://api.github.com/users/bmjen/followers","following_url":"https://api.github.com/users/bmjen/following{/other_user}","gists_url":"https://api.github.com/users/bmjen/gists{/gist_id}","starred_url":"https://api.github.com/users/bmjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmjen/subscriptions","organizations_url":"https://api.github.com/users/bmjen/orgs","repos_url":"https://api.github.com/users/bmjen/repos","events_url":"https://api.github.com/users/bmjen/events{/privacy}","received_events_url":"https://api.github.com/users/bmjen/received_events","type":"User","site_admin":false},"body":"Since the template checks for existence of `@ssl_proxy_verify` before adding the line to the config, should this default be to `undef`? By setting a default, this means that the `SSLProxyVerify` line will always be present in the default config. Is that what we want?\r\n\r\ncc/ @igalic ","created_at":"2015-12-25T19:29:11Z","updated_at":"2015-12-25T19:29:11Z","html_url":"https://github.com/puppetlabs/puppetlabs-apache/pull/1311#discussion_r48442893","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/1311","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/comments/48442893"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-apache/pull/1311#discussion_r48442893"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/1311"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/1311","id":54101800,"html_url":"https://github.com/puppetlabs/puppetlabs-apache/pull/1311","diff_url":"https://github.com/puppetlabs/puppetlabs-apache/pull/1311.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-apache/pull/1311.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/issues/1311","number":1311,"state":"open","locked":false,"title":"SSLProxyVerify","user":{"login":"occelebi","id":11767714,"avatar_url":"https://avatars.githubusercontent.com/u/11767714?v=3","gravatar_id":"","url":"https://api.github.com/users/occelebi","html_url":"https://github.com/occelebi","followers_url":"https://api.github.com/users/occelebi/followers","following_url":"https://api.github.com/users/occelebi/following{/other_user}","gists_url":"https://api.github.com/users/occelebi/gists{/gist_id}","starred_url":"https://api.github.com/users/occelebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occelebi/subscriptions","organizations_url":"https://api.github.com/users/occelebi/orgs","repos_url":"https://api.github.com/users/occelebi/repos","events_url":"https://api.github.com/users/occelebi/events{/privacy}","received_events_url":"https://api.github.com/users/occelebi/received_events","type":"User","site_admin":false},"body":"I've added SSLProxyVerify directive in mod ssl.","created_at":"2015-12-18T13:22:48Z","updated_at":"2015-12-25T19:29:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"140b5c01b2d02dc9a459e1643a2474e1cd06f7f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/1311/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/1311/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/issues/1311/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/statuses/0ab0e393f0e7254bc28f69b624cf212f120a254c","head":{"label":"occelebi:ssl","ref":"ssl","sha":"0ab0e393f0e7254bc28f69b624cf212f120a254c","user":{"login":"occelebi","id":11767714,"avatar_url":"https://avatars.githubusercontent.com/u/11767714?v=3","gravatar_id":"","url":"https://api.github.com/users/occelebi","html_url":"https://github.com/occelebi","followers_url":"https://api.github.com/users/occelebi/followers","following_url":"https://api.github.com/users/occelebi/following{/other_user}","gists_url":"https://api.github.com/users/occelebi/gists{/gist_id}","starred_url":"https://api.github.com/users/occelebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occelebi/subscriptions","organizations_url":"https://api.github.com/users/occelebi/orgs","repos_url":"https://api.github.com/users/occelebi/repos","events_url":"https://api.github.com/users/occelebi/events{/privacy}","received_events_url":"https://api.github.com/users/occelebi/received_events","type":"User","site_admin":false},"repo":{"id":48102443,"name":"puppetlabs-apache","full_name":"occelebi/puppetlabs-apache","owner":{"login":"occelebi","id":11767714,"avatar_url":"https://avatars.githubusercontent.com/u/11767714?v=3","gravatar_id":"","url":"https://api.github.com/users/occelebi","html_url":"https://github.com/occelebi","followers_url":"https://api.github.com/users/occelebi/followers","following_url":"https://api.github.com/users/occelebi/following{/other_user}","gists_url":"https://api.github.com/users/occelebi/gists{/gist_id}","starred_url":"https://api.github.com/users/occelebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/occelebi/subscriptions","organizations_url":"https://api.github.com/users/occelebi/orgs","repos_url":"https://api.github.com/users/occelebi/repos","events_url":"https://api.github.com/users/occelebi/events{/privacy}","received_events_url":"https://api.github.com/users/occelebi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/occelebi/puppetlabs-apache","description":"Puppet Labs Apache module","fork":true,"url":"https://api.github.com/repos/occelebi/puppetlabs-apache","forks_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/forks","keys_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/teams","hooks_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/hooks","issue_events_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/issues/events{/number}","events_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/events","assignees_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/assignees{/user}","branches_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/branches{/branch}","tags_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/tags","blobs_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/git/refs{/sha}","trees_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/statuses/{sha}","languages_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/languages","stargazers_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/stargazers","contributors_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/contributors","subscribers_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/subscribers","subscription_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/subscription","commits_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/commits{/sha}","git_commits_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/git/commits{/sha}","comments_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/comments{/number}","issue_comment_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/issues/comments{/number}","contents_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/contents/{+path}","compare_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/merges","archive_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/downloads","issues_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/issues{/number}","pulls_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/pulls{/number}","milestones_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/milestones{/number}","notifications_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/labels{/name}","releases_url":"https://api.github.com/repos/occelebi/puppetlabs-apache/releases{/id}","created_at":"2015-12-16T10:04:21Z","updated_at":"2015-12-16T10:04:22Z","pushed_at":"2015-12-23T14:58:10Z","git_url":"git://github.com/occelebi/puppetlabs-apache.git","ssh_url":"git@github.com:occelebi/puppetlabs-apache.git","clone_url":"https://github.com/occelebi/puppetlabs-apache.git","svn_url":"https://github.com/occelebi/puppetlabs-apache","homepage":"https://forge.puppetlabs.com/puppetlabs/apache","size":3606,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"05437c0b6e4dd084b2336565aa13a8d152f97071","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":880770,"name":"puppetlabs-apache","full_name":"puppetlabs/puppetlabs-apache","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-apache","description":"Puppet Labs Apache module","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/releases{/id}","created_at":"2010-09-01T22:00:16Z","updated_at":"2015-12-15T21:38:23Z","pushed_at":"2015-12-25T02:19:00Z","git_url":"git://github.com/puppetlabs/puppetlabs-apache.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-apache.git","clone_url":"https://github.com/puppetlabs/puppetlabs-apache.git","svn_url":"https://github.com/puppetlabs/puppetlabs-apache","homepage":"https://forge.puppetlabs.com/puppetlabs/apache","size":6299,"stargazers_count":302,"watchers_count":302,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":793,"mirror_url":null,"open_issues_count":70,"forks":793,"open_issues":70,"watchers":302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/1311"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-apache/pull/1311"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/issues/1311"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/issues/1311/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/1311/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/pulls/1311/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-apache/statuses/0ab0e393f0e7254bc28f69b624cf212f120a254c"}}}}