{"action":"created","comment":{"url":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/comments/34021177","id":34021177,"diff_hunk":"@@ -345,7 +420,7 @@ public void setDisplayNames(Map<String, String> displayNames) {\n \t\tLDAPConnection connection = null;\n \t\ttry {\n \t\t\tconnection = getConnection();\n-\t\t\tLDAPSearchResults results = connection.search(externalId, LDAPConnection.SCOPE_BASE, null, new String[]{memberAttribute}, false);\n+\t\t\tLDAPSearchResults results = connection.search(externalId, LDAPConnection.SCOPE_BASE, \"member=*\", new String[]{memberAttribute}, false);","path":"impl/src/main/java/uk/ac/ox/oucs/vle/ExternalGroupManagerImpl.java","position":177,"original_position":177,"commit_id":"2611a50b98b05bea9c02edf3ccdc9b3df615817c","original_commit_id":"2611a50b98b05bea9c02edf3ccdc9b3df615817c","user":{"login":"buckett","id":5921,"avatar_url":"https://avatars.githubusercontent.com/u/5921?v=3","gravatar_id":"","url":"https://api.github.com/users/buckett","html_url":"https://github.com/buckett","followers_url":"https://api.github.com/users/buckett/followers","following_url":"https://api.github.com/users/buckett/following{/other_user}","gists_url":"https://api.github.com/users/buckett/gists{/gist_id}","starred_url":"https://api.github.com/users/buckett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buckett/subscriptions","organizations_url":"https://api.github.com/users/buckett/orgs","repos_url":"https://api.github.com/users/buckett/repos","events_url":"https://api.github.com/users/buckett/events{/privacy}","received_events_url":"https://api.github.com/users/buckett/received_events","type":"User","site_admin":false},"body":"Is this just to shortcut the loop?","created_at":"2015-07-07T09:15:03Z","updated_at":"2015-07-07T09:15:03Z","html_url":"https://github.com/ox-it/wl-external-groups/pull/9#discussion_r34021177","pull_request_url":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/comments/34021177"},"html":{"href":"https://github.com/ox-it/wl-external-groups/pull/9#discussion_r34021177"},"pull_request":{"href":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/9","id":39081362,"html_url":"https://github.com/ox-it/wl-external-groups/pull/9","diff_url":"https://github.com/ox-it/wl-external-groups/pull/9.diff","patch_url":"https://github.com/ox-it/wl-external-groups/pull/9.patch","issue_url":"https://api.github.com/repos/ox-it/wl-external-groups/issues/9","number":9,"state":"open","locked":false,"title":"WL-3732 : New groupstore","user":{"login":"nicholaswilson100","id":7457681,"avatar_url":"https://avatars.githubusercontent.com/u/7457681?v=3","gravatar_id":"","url":"https://api.github.com/users/nicholaswilson100","html_url":"https://github.com/nicholaswilson100","followers_url":"https://api.github.com/users/nicholaswilson100/followers","following_url":"https://api.github.com/users/nicholaswilson100/following{/other_user}","gists_url":"https://api.github.com/users/nicholaswilson100/gists{/gist_id}","starred_url":"https://api.github.com/users/nicholaswilson100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicholaswilson100/subscriptions","organizations_url":"https://api.github.com/users/nicholaswilson100/orgs","repos_url":"https://api.github.com/users/nicholaswilson100/repos","events_url":"https://api.github.com/users/nicholaswilson100/events{/privacy}","received_events_url":"https://api.github.com/users/nicholaswilson100/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-02T13:19:37Z","updated_at":"2015-07-07T09:15:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ad7d916df7d6cdd6798aaca21399b4a07b14061","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/9/commits","review_comments_url":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/9/comments","review_comment_url":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ox-it/wl-external-groups/issues/9/comments","statuses_url":"https://api.github.com/repos/ox-it/wl-external-groups/statuses/2611a50b98b05bea9c02edf3ccdc9b3df615817c","head":{"label":"ox-it:WL-3732","ref":"WL-3732","sha":"2611a50b98b05bea9c02edf3ccdc9b3df615817c","user":{"login":"ox-it","id":351950,"avatar_url":"https://avatars.githubusercontent.com/u/351950?v=3","gravatar_id":"","url":"https://api.github.com/users/ox-it","html_url":"https://github.com/ox-it","followers_url":"https://api.github.com/users/ox-it/followers","following_url":"https://api.github.com/users/ox-it/following{/other_user}","gists_url":"https://api.github.com/users/ox-it/gists{/gist_id}","starred_url":"https://api.github.com/users/ox-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ox-it/subscriptions","organizations_url":"https://api.github.com/users/ox-it/orgs","repos_url":"https://api.github.com/users/ox-it/repos","events_url":"https://api.github.com/users/ox-it/events{/privacy}","received_events_url":"https://api.github.com/users/ox-it/received_events","type":"Organization","site_admin":false},"repo":{"id":6059277,"name":"wl-external-groups","full_name":"ox-it/wl-external-groups","owner":{"login":"ox-it","id":351950,"avatar_url":"https://avatars.githubusercontent.com/u/351950?v=3","gravatar_id":"","url":"https://api.github.com/users/ox-it","html_url":"https://github.com/ox-it","followers_url":"https://api.github.com/users/ox-it/followers","following_url":"https://api.github.com/users/ox-it/following{/other_user}","gists_url":"https://api.github.com/users/ox-it/gists{/gist_id}","starred_url":"https://api.github.com/users/ox-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ox-it/subscriptions","organizations_url":"https://api.github.com/users/ox-it/orgs","repos_url":"https://api.github.com/users/ox-it/repos","events_url":"https://api.github.com/users/ox-it/events{/privacy}","received_events_url":"https://api.github.com/users/ox-it/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ox-it/wl-external-groups","description":null,"fork":false,"url":"https://api.github.com/repos/ox-it/wl-external-groups","forks_url":"https://api.github.com/repos/ox-it/wl-external-groups/forks","keys_url":"https://api.github.com/repos/ox-it/wl-external-groups/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ox-it/wl-external-groups/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ox-it/wl-external-groups/teams","hooks_url":"https://api.github.com/repos/ox-it/wl-external-groups/hooks","issue_events_url":"https://api.github.com/repos/ox-it/wl-external-groups/issues/events{/number}","events_url":"https://api.github.com/repos/ox-it/wl-external-groups/events","assignees_url":"https://api.github.com/repos/ox-it/wl-external-groups/assignees{/user}","branches_url":"https://api.github.com/repos/ox-it/wl-external-groups/branches{/branch}","tags_url":"https://api.github.com/repos/ox-it/wl-external-groups/tags","blobs_url":"https://api.github.com/repos/ox-it/wl-external-groups/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ox-it/wl-external-groups/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ox-it/wl-external-groups/git/refs{/sha}","trees_url":"https://api.github.com/repos/ox-it/wl-external-groups/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ox-it/wl-external-groups/statuses/{sha}","languages_url":"https://api.github.com/repos/ox-it/wl-external-groups/languages","stargazers_url":"https://api.github.com/repos/ox-it/wl-external-groups/stargazers","contributors_url":"https://api.github.com/repos/ox-it/wl-external-groups/contributors","subscribers_url":"https://api.github.com/repos/ox-it/wl-external-groups/subscribers","subscription_url":"https://api.github.com/repos/ox-it/wl-external-groups/subscription","commits_url":"https://api.github.com/repos/ox-it/wl-external-groups/commits{/sha}","git_commits_url":"https://api.github.com/repos/ox-it/wl-external-groups/git/commits{/sha}","comments_url":"https://api.github.com/repos/ox-it/wl-external-groups/comments{/number}","issue_comment_url":"https://api.github.com/repos/ox-it/wl-external-groups/issues/comments{/number}","contents_url":"https://api.github.com/repos/ox-it/wl-external-groups/contents/{+path}","compare_url":"https://api.github.com/repos/ox-it/wl-external-groups/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ox-it/wl-external-groups/merges","archive_url":"https://api.github.com/repos/ox-it/wl-external-groups/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ox-it/wl-external-groups/downloads","issues_url":"https://api.github.com/repos/ox-it/wl-external-groups/issues{/number}","pulls_url":"https://api.github.com/repos/ox-it/wl-external-groups/pulls{/number}","milestones_url":"https://api.github.com/repos/ox-it/wl-external-groups/milestones{/number}","notifications_url":"https://api.github.com/repos/ox-it/wl-external-groups/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ox-it/wl-external-groups/labels{/name}","releases_url":"https://api.github.com/repos/ox-it/wl-external-groups/releases{/id}","created_at":"2012-10-03T11:47:46Z","updated_at":"2015-02-16T17:20:20Z","pushed_at":"2015-07-03T11:08:48Z","git_url":"git://github.com/ox-it/wl-external-groups.git","ssh_url":"git@github.com:ox-it/wl-external-groups.git","clone_url":"https://github.com/ox-it/wl-external-groups.git","svn_url":"https://github.com/ox-it/wl-external-groups","homepage":null,"size":612,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ox-it:master","ref":"master","sha":"2dcafe97fae5b5d85c418e8899be884b1e8fdb00","user":{"login":"ox-it","id":351950,"avatar_url":"https://avatars.githubusercontent.com/u/351950?v=3","gravatar_id":"","url":"https://api.github.com/users/ox-it","html_url":"https://github.com/ox-it","followers_url":"https://api.github.com/users/ox-it/followers","following_url":"https://api.github.com/users/ox-it/following{/other_user}","gists_url":"https://api.github.com/users/ox-it/gists{/gist_id}","starred_url":"https://api.github.com/users/ox-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ox-it/subscriptions","organizations_url":"https://api.github.com/users/ox-it/orgs","repos_url":"https://api.github.com/users/ox-it/repos","events_url":"https://api.github.com/users/ox-it/events{/privacy}","received_events_url":"https://api.github.com/users/ox-it/received_events","type":"Organization","site_admin":false},"repo":{"id":6059277,"name":"wl-external-groups","full_name":"ox-it/wl-external-groups","owner":{"login":"ox-it","id":351950,"avatar_url":"https://avatars.githubusercontent.com/u/351950?v=3","gravatar_id":"","url":"https://api.github.com/users/ox-it","html_url":"https://github.com/ox-it","followers_url":"https://api.github.com/users/ox-it/followers","following_url":"https://api.github.com/users/ox-it/following{/other_user}","gists_url":"https://api.github.com/users/ox-it/gists{/gist_id}","starred_url":"https://api.github.com/users/ox-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ox-it/subscriptions","organizations_url":"https://api.github.com/users/ox-it/orgs","repos_url":"https://api.github.com/users/ox-it/repos","events_url":"https://api.github.com/users/ox-it/events{/privacy}","received_events_url":"https://api.github.com/users/ox-it/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ox-it/wl-external-groups","description":null,"fork":false,"url":"https://api.github.com/repos/ox-it/wl-external-groups","forks_url":"https://api.github.com/repos/ox-it/wl-external-groups/forks","keys_url":"https://api.github.com/repos/ox-it/wl-external-groups/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ox-it/wl-external-groups/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ox-it/wl-external-groups/teams","hooks_url":"https://api.github.com/repos/ox-it/wl-external-groups/hooks","issue_events_url":"https://api.github.com/repos/ox-it/wl-external-groups/issues/events{/number}","events_url":"https://api.github.com/repos/ox-it/wl-external-groups/events","assignees_url":"https://api.github.com/repos/ox-it/wl-external-groups/assignees{/user}","branches_url":"https://api.github.com/repos/ox-it/wl-external-groups/branches{/branch}","tags_url":"https://api.github.com/repos/ox-it/wl-external-groups/tags","blobs_url":"https://api.github.com/repos/ox-it/wl-external-groups/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ox-it/wl-external-groups/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ox-it/wl-external-groups/git/refs{/sha}","trees_url":"https://api.github.com/repos/ox-it/wl-external-groups/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ox-it/wl-external-groups/statuses/{sha}","languages_url":"https://api.github.com/repos/ox-it/wl-external-groups/languages","stargazers_url":"https://api.github.com/repos/ox-it/wl-external-groups/stargazers","contributors_url":"https://api.github.com/repos/ox-it/wl-external-groups/contributors","subscribers_url":"https://api.github.com/repos/ox-it/wl-external-groups/subscribers","subscription_url":"https://api.github.com/repos/ox-it/wl-external-groups/subscription","commits_url":"https://api.github.com/repos/ox-it/wl-external-groups/commits{/sha}","git_commits_url":"https://api.github.com/repos/ox-it/wl-external-groups/git/commits{/sha}","comments_url":"https://api.github.com/repos/ox-it/wl-external-groups/comments{/number}","issue_comment_url":"https://api.github.com/repos/ox-it/wl-external-groups/issues/comments{/number}","contents_url":"https://api.github.com/repos/ox-it/wl-external-groups/contents/{+path}","compare_url":"https://api.github.com/repos/ox-it/wl-external-groups/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ox-it/wl-external-groups/merges","archive_url":"https://api.github.com/repos/ox-it/wl-external-groups/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ox-it/wl-external-groups/downloads","issues_url":"https://api.github.com/repos/ox-it/wl-external-groups/issues{/number}","pulls_url":"https://api.github.com/repos/ox-it/wl-external-groups/pulls{/number}","milestones_url":"https://api.github.com/repos/ox-it/wl-external-groups/milestones{/number}","notifications_url":"https://api.github.com/repos/ox-it/wl-external-groups/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ox-it/wl-external-groups/labels{/name}","releases_url":"https://api.github.com/repos/ox-it/wl-external-groups/releases{/id}","created_at":"2012-10-03T11:47:46Z","updated_at":"2015-02-16T17:20:20Z","pushed_at":"2015-07-03T11:08:48Z","git_url":"git://github.com/ox-it/wl-external-groups.git","ssh_url":"git@github.com:ox-it/wl-external-groups.git","clone_url":"https://github.com/ox-it/wl-external-groups.git","svn_url":"https://github.com/ox-it/wl-external-groups","homepage":null,"size":612,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/9"},"html":{"href":"https://github.com/ox-it/wl-external-groups/pull/9"},"issue":{"href":"https://api.github.com/repos/ox-it/wl-external-groups/issues/9"},"comments":{"href":"https://api.github.com/repos/ox-it/wl-external-groups/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ox-it/wl-external-groups/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/ox-it/wl-external-groups/statuses/2611a50b98b05bea9c02edf3ccdc9b3df615817c"}}}}