{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/32072569","id":32072569,"diff_hunk":"@@ -48,6 +48,20 @@ def should\n         dearrayify(members)\n       end\n \n+      # Returns any values from the list that were returned by\n+      # retrieve but are not set as being managed.\n+      def is_but_shouldnt\n+        # We know that if inclusive is not set, we won't have to\n+        # remove any values from the system.\n+        inclusive? ? Set.new(retrieve) - Set.new(@should) : Set.new()\n+      end\n+\n+      # Returns any values from the list that we are managing but that\n+      # were not returned by retrieve\n+      def should_but_isnt\n+        Set.new(@should) - Set.new(retrieve)","path":"lib/puppet/property/list.rb","position":15,"original_position":15,"commit_id":"92463931c3651c7cbb9f0e8bc053c79ffe205081","original_commit_id":"92463931c3651c7cbb9f0e8bc053c79ffe205081","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"Probably should explicitly `require 'set'`.\r\n\r\n```\r\nirb(main):001:0> Set.new\r\nNameError: uninitialized constant Set\r\n\tfrom (irb):1\r\n\tfrom :0\r\nirb(main):002:0> require 'set'\r\n=> true\r\nirb(main):003:0> Set.new\r\n=> #<Set: {}>\r\n```\r\n\r\n","created_at":"2015-06-09T22:38:46Z","updated_at":"2015-06-09T22:38:46Z","html_url":"https://github.com/puppetlabs/puppet/pull/3995#discussion_r32072569","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3995","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/32072569"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3995#discussion_r32072569"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3995"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3995","id":36862554,"html_url":"https://github.com/puppetlabs/puppet/pull/3995","diff_url":"https://github.com/puppetlabs/puppet/pull/3995.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3995.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3995","number":3995,"state":"open","locked":false,"title":"(PUP-3774) Only apply minimal membership changes in useradd provider","user":{"login":"branan","id":37594,"avatar_url":"https://avatars.githubusercontent.com/u/37594?v=3","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"body":"Previously, the useradd provider would set all of a user's groups at\r\nonce using usermod. This would cause problems when a user had existing\r\ngroups coming from AD, which would not be valid as arguments to\r\nusermod.\r\n\r\nThe new implementation uses `gpasswd` to modify the user/group\r\nmappings only as needed. This means Puppet will completely ignore any\r\nexisting groups when adding a user to a new group.\r\n\r\nValidation will still fail if Puppet is asked to make changes to a\r\nuser/group mapping when the group has spaces in it, as that is not a\r\nvalid operation.","created_at":"2015-06-03T18:28:12Z","updated_at":"2015-06-09T22:38:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"676f87b4a3aaebe5309969ad0fe2bd5077d8283e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3995/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3995/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3995/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/92463931c3651c7cbb9f0e8bc053c79ffe205081","head":{"label":"branan:bug/stable/pup-3774/minimal_membership_changes","ref":"bug/stable/pup-3774/minimal_membership_changes","sha":"92463931c3651c7cbb9f0e8bc053c79ffe205081","user":{"login":"branan","id":37594,"avatar_url":"https://avatars.githubusercontent.com/u/37594?v=3","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"repo":{"id":5719668,"name":"puppet","full_name":"branan/puppet","owner":{"login":"branan","id":37594,"avatar_url":"https://avatars.githubusercontent.com/u/37594?v=3","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/branan/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/branan/puppet","forks_url":"https://api.github.com/repos/branan/puppet/forks","keys_url":"https://api.github.com/repos/branan/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/branan/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/branan/puppet/teams","hooks_url":"https://api.github.com/repos/branan/puppet/hooks","issue_events_url":"https://api.github.com/repos/branan/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/branan/puppet/events","assignees_url":"https://api.github.com/repos/branan/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/branan/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/branan/puppet/tags","blobs_url":"https://api.github.com/repos/branan/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/branan/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/branan/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/branan/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/branan/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/branan/puppet/languages","stargazers_url":"https://api.github.com/repos/branan/puppet/stargazers","contributors_url":"https://api.github.com/repos/branan/puppet/contributors","subscribers_url":"https://api.github.com/repos/branan/puppet/subscribers","subscription_url":"https://api.github.com/repos/branan/puppet/subscription","commits_url":"https://api.github.com/repos/branan/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/branan/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/branan/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/branan/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/branan/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/branan/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/branan/puppet/merges","archive_url":"https://api.github.com/repos/branan/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/branan/puppet/downloads","issues_url":"https://api.github.com/repos/branan/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/branan/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/branan/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/branan/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/branan/puppet/labels{/name}","releases_url":"https://api.github.com/repos/branan/puppet/releases{/id}","created_at":"2012-09-07T16:54:25Z","updated_at":"2015-04-02T22:11:41Z","pushed_at":"2015-06-09T17:30:53Z","git_url":"git://github.com/branan/puppet.git","ssh_url":"git@github.com:branan/puppet.git","clone_url":"https://github.com/branan/puppet.git","svn_url":"https://github.com/branan/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":51376,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"7988b07657674fd0f08cf6fb9cd8fc889dd9d77f","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-06-09T19:44:51Z","pushed_at":"2015-06-09T22:21:07Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":116132,"stargazers_count":3368,"watchers_count":3368,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1420,"mirror_url":null,"open_issues_count":25,"forks":1420,"open_issues":25,"watchers":3368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3995"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3995"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3995"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3995/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3995/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3995/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/92463931c3651c7cbb9f0e8bc053c79ffe205081"}}}}