{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments/37823067","id":37823067,"diff_hunk":"@@ -153,11 +157,25 @@\n         <CustomAction Id=\"VWDExpressSetup\" Property=\"VWDEXPRESS_PATH\" ExeCommand=\"/setup\" Execute=\"deferred\" Return=\"check\" Impersonate=\"no\" />\n         <CustomAction Id=\"VWDExpressSetup_Rollback\" Property=\"VWDEXPRESS_PATH\" ExeCommand=\"/setup\" Execute=\"rollback\" Return=\"check\" Impersonate=\"no\" />\n \n+      <Binary Id=\"InstallerTelemetryAction.CA.dll\" SourceFile=\"..\\..\\..\\BuildOutput\\$(var.Configuration)$(var.VSTargetVersion)\\Setup\\Microsoft.NodejsTools.InstallerTelemetryAction.CA.dll\" />\n+      \n+      <!-- Custom Action for installer telemetry-->\n+      <CustomAction Id=\"LogStart\" BinaryKey=\"InstallerTelemetryAction.CA.dll\" DllEntry=\"RecordInstallStartTime\"/>\n+      <CustomAction Id=\"LogSuccess\" BinaryKey=\"InstallerTelemetryAction.CA.dll\" DllEntry=\"LogInstallSuccessResult\"/>\n+      <CustomAction Id=\"LogFailure\" BinaryKey=\"InstallerTelemetryAction.CA.dll\" DllEntry=\"LogInstallErrorResult\"/>\n+      <CustomAction Id=\"LogCancel\" BinaryKey=\"InstallerTelemetryAction.CA.dll\" DllEntry=\"LogInstallCancelResult\"/>","path":"Nodejs/Setup/NodejsToolsInstaller/NodejsToolsInstaller.wxs","position":21,"original_position":21,"commit_id":"9d75c2983d66cfa678c6555fbb3a729c4596b77d","original_commit_id":"9d75c2983d66cfa678c6555fbb3a729c4596b77d","user":{"login":"mousetraps","id":762848,"avatar_url":"https://avatars.githubusercontent.com/u/762848?v=3","gravatar_id":"","url":"https://api.github.com/users/mousetraps","html_url":"https://github.com/mousetraps","followers_url":"https://api.github.com/users/mousetraps/followers","following_url":"https://api.github.com/users/mousetraps/following{/other_user}","gists_url":"https://api.github.com/users/mousetraps/gists{/gist_id}","starred_url":"https://api.github.com/users/mousetraps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mousetraps/subscriptions","organizations_url":"https://api.github.com/users/mousetraps/orgs","repos_url":"https://api.github.com/users/mousetraps/repos","events_url":"https://api.github.com/users/mousetraps/events{/privacy}","received_events_url":"https://api.github.com/users/mousetraps/received_events","type":"User","site_admin":false},"body":"You will also need to add these dlls to dev scripts - add them to generate.js (before VsLogger for the same reason as above), run the script, and check in the result \r\n\r\nSee https://github.com/Microsoft/nodejstools/tree/master/Nodejs/Prerequisites","created_at":"2015-08-25T01:01:40Z","updated_at":"2015-08-25T01:01:40Z","html_url":"https://github.com/Microsoft/nodejstools/pull/373#discussion_r37823067","pull_request_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/373","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments/37823067"},"html":{"href":"https://github.com/Microsoft/nodejstools/pull/373#discussion_r37823067"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/373"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/373","id":42766919,"html_url":"https://github.com/Microsoft/nodejstools/pull/373","diff_url":"https://github.com/Microsoft/nodejstools/pull/373.diff","patch_url":"https://github.com/Microsoft/nodejstools/pull/373.patch","issue_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/373","number":373,"state":"open","locked":false,"title":"Adding Installer Telemetry","user":{"login":"sanyamc-msft","id":13542302,"avatar_url":"https://avatars.githubusercontent.com/u/13542302?v=3","gravatar_id":"","url":"https://api.github.com/users/sanyamc-msft","html_url":"https://github.com/sanyamc-msft","followers_url":"https://api.github.com/users/sanyamc-msft/followers","following_url":"https://api.github.com/users/sanyamc-msft/following{/other_user}","gists_url":"https://api.github.com/users/sanyamc-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/sanyamc-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanyamc-msft/subscriptions","organizations_url":"https://api.github.com/users/sanyamc-msft/orgs","repos_url":"https://api.github.com/users/sanyamc-msft/repos","events_url":"https://api.github.com/users/sanyamc-msft/events{/privacy}","received_events_url":"https://api.github.com/users/sanyamc-msft/received_events","type":"User","site_admin":false},"body":"Adding a Custom Action to send back installer telemetry using http POST.","created_at":"2015-08-19T01:06:04Z","updated_at":"2015-08-25T01:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72fcd4b274fedd9751b01fb027b1462f828f0f64","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/373/commits","review_comments_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/373/comments","review_comment_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/373/comments","statuses_url":"https://api.github.com/repos/Microsoft/nodejstools/statuses/9d75c2983d66cfa678c6555fbb3a729c4596b77d","head":{"label":"sanyamc-msft:master","ref":"master","sha":"9d75c2983d66cfa678c6555fbb3a729c4596b77d","user":{"login":"sanyamc-msft","id":13542302,"avatar_url":"https://avatars.githubusercontent.com/u/13542302?v=3","gravatar_id":"","url":"https://api.github.com/users/sanyamc-msft","html_url":"https://github.com/sanyamc-msft","followers_url":"https://api.github.com/users/sanyamc-msft/followers","following_url":"https://api.github.com/users/sanyamc-msft/following{/other_user}","gists_url":"https://api.github.com/users/sanyamc-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/sanyamc-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanyamc-msft/subscriptions","organizations_url":"https://api.github.com/users/sanyamc-msft/orgs","repos_url":"https://api.github.com/users/sanyamc-msft/repos","events_url":"https://api.github.com/users/sanyamc-msft/events{/privacy}","received_events_url":"https://api.github.com/users/sanyamc-msft/received_events","type":"User","site_admin":false},"repo":{"id":41004794,"name":"nodejstools","full_name":"sanyamc-msft/nodejstools","owner":{"login":"sanyamc-msft","id":13542302,"avatar_url":"https://avatars.githubusercontent.com/u/13542302?v=3","gravatar_id":"","url":"https://api.github.com/users/sanyamc-msft","html_url":"https://github.com/sanyamc-msft","followers_url":"https://api.github.com/users/sanyamc-msft/followers","following_url":"https://api.github.com/users/sanyamc-msft/following{/other_user}","gists_url":"https://api.github.com/users/sanyamc-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/sanyamc-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanyamc-msft/subscriptions","organizations_url":"https://api.github.com/users/sanyamc-msft/orgs","repos_url":"https://api.github.com/users/sanyamc-msft/repos","events_url":"https://api.github.com/users/sanyamc-msft/events{/privacy}","received_events_url":"https://api.github.com/users/sanyamc-msft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sanyamc-msft/nodejstools","description":"Node.js Tools for Visual Studio","fork":true,"url":"https://api.github.com/repos/sanyamc-msft/nodejstools","forks_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/forks","keys_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/teams","hooks_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/hooks","issue_events_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/issues/events{/number}","events_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/events","assignees_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/assignees{/user}","branches_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/branches{/branch}","tags_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/tags","blobs_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/statuses/{sha}","languages_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/languages","stargazers_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/stargazers","contributors_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/contributors","subscribers_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/subscribers","subscription_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/subscription","commits_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/contents/{+path}","compare_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/merges","archive_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/downloads","issues_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/issues{/number}","pulls_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/pulls{/number}","milestones_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/milestones{/number}","notifications_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/labels{/name}","releases_url":"https://api.github.com/repos/sanyamc-msft/nodejstools/releases{/id}","created_at":"2015-08-19T00:42:05Z","updated_at":"2015-08-19T00:42:11Z","pushed_at":"2015-08-24T21:34:23Z","git_url":"git://github.com/sanyamc-msft/nodejstools.git","ssh_url":"git@github.com:sanyamc-msft/nodejstools.git","clone_url":"https://github.com/sanyamc-msft/nodejstools.git","svn_url":"https://github.com/sanyamc-msft/nodejstools","homepage":"http://aka.ms/explorentvs","size":98056,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"4f187a367b49140b256f7b751c3dc034e575ab39","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":33017149,"name":"nodejstools","full_name":"Microsoft/nodejstools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/nodejstools","description":"Node.js Tools for Visual Studio","fork":false,"url":"https://api.github.com/repos/Microsoft/nodejstools","forks_url":"https://api.github.com/repos/Microsoft/nodejstools/forks","keys_url":"https://api.github.com/repos/Microsoft/nodejstools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/nodejstools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/nodejstools/teams","hooks_url":"https://api.github.com/repos/Microsoft/nodejstools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/nodejstools/events","assignees_url":"https://api.github.com/repos/Microsoft/nodejstools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/nodejstools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/nodejstools/tags","blobs_url":"https://api.github.com/repos/Microsoft/nodejstools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/nodejstools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/nodejstools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/nodejstools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/nodejstools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/nodejstools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/nodejstools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/nodejstools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/nodejstools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/nodejstools/subscription","commits_url":"https://api.github.com/repos/Microsoft/nodejstools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/nodejstools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/nodejstools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/nodejstools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/nodejstools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/nodejstools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/nodejstools/merges","archive_url":"https://api.github.com/repos/Microsoft/nodejstools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/nodejstools/downloads","issues_url":"https://api.github.com/repos/Microsoft/nodejstools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/nodejstools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/nodejstools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/nodejstools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/nodejstools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/nodejstools/releases{/id}","created_at":"2015-03-28T01:37:20Z","updated_at":"2015-08-24T22:46:30Z","pushed_at":"2015-08-24T23:32:17Z","git_url":"git://github.com/Microsoft/nodejstools.git","ssh_url":"git@github.com:Microsoft/nodejstools.git","clone_url":"https://github.com/Microsoft/nodejstools.git","svn_url":"https://github.com/Microsoft/nodejstools","homepage":"http://aka.ms/explorentvs","size":98056,"stargazers_count":628,"watchers_count":628,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":181,"forks":80,"open_issues":181,"watchers":628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/373"},"html":{"href":"https://github.com/Microsoft/nodejstools/pull/373"},"issue":{"href":"https://api.github.com/repos/Microsoft/nodejstools/issues/373"},"comments":{"href":"https://api.github.com/repos/Microsoft/nodejstools/issues/373/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/373/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/nodejstools/pulls/373/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/nodejstools/statuses/9d75c2983d66cfa678c6555fbb3a729c4596b77d"}}}}