{"action":"created","comment":{"url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/comments/45927361","id":45927361,"diff_hunk":"@@ -44,18 +41,9 @@ angular.module('flintAndSteel')\n                 getProperty: function getProperty(propertyName) {\n                     return mockUserAccount[propertyName];\n                 },\n-                likeIdea: function likeIdea() {\n-                    throw new NotImplementedException('likeIdea');\n-                },\n-                unlikeIdea: function unlikeIdea() {\n-                    throw new NotImplementedException('unlikeIdea');\n-                },\n                 updateAccount: function updateAccount() {\n                     throw new NotImplementedException('updateAccount');\n                 },\n-                checkValidUsername: function checkValidUsername() {\n-                    throw new NotImplementedException('checkValidUsername');\n-                },\n                 getUserById: function getUserById() {\n                     return mockUserAccount;\n                 }","path":"src/users/loginSvc/loginSvc.mock.js","position":28,"original_position":28,"commit_id":"98763162ea78e72bdbabf62f306551790927df10","original_commit_id":"98763162ea78e72bdbabf62f306551790927df10","user":{"login":"Mctalian","id":5081281,"avatar_url":"https://avatars.githubusercontent.com/u/5081281?v=3","gravatar_id":"","url":"https://api.github.com/users/Mctalian","html_url":"https://github.com/Mctalian","followers_url":"https://api.github.com/users/Mctalian/followers","following_url":"https://api.github.com/users/Mctalian/following{/other_user}","gists_url":"https://api.github.com/users/Mctalian/gists{/gist_id}","starred_url":"https://api.github.com/users/Mctalian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mctalian/subscriptions","organizations_url":"https://api.github.com/users/Mctalian/orgs","repos_url":"https://api.github.com/users/Mctalian/repos","events_url":"https://api.github.com/users/Mctalian/events{/privacy}","received_events_url":"https://api.github.com/users/Mctalian/received_events","type":"User","site_admin":false},"body":"Removed old, unused code.","created_at":"2015-11-25T22:39:46Z","updated_at":"2015-11-25T22:39:46Z","html_url":"https://github.com/YashdalfTheGray/flintandsteel/pull/169#discussion_r45927361","pull_request_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/comments/45927361"},"html":{"href":"https://github.com/YashdalfTheGray/flintandsteel/pull/169#discussion_r45927361"},"pull_request":{"href":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/169","id":51853109,"html_url":"https://github.com/YashdalfTheGray/flintandsteel/pull/169","diff_url":"https://github.com/YashdalfTheGray/flintandsteel/pull/169.diff","patch_url":"https://github.com/YashdalfTheGray/flintandsteel/pull/169.patch","issue_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/issues/169","number":169,"state":"open","locked":false,"title":"Concurrency Issues","user":{"login":"Mctalian","id":5081281,"avatar_url":"https://avatars.githubusercontent.com/u/5081281?v=3","gravatar_id":"","url":"https://api.github.com/users/Mctalian","html_url":"https://github.com/Mctalian","followers_url":"https://api.github.com/users/Mctalian/followers","following_url":"https://api.github.com/users/Mctalian/following{/other_user}","gists_url":"https://api.github.com/users/Mctalian/gists{/gist_id}","starred_url":"https://api.github.com/users/Mctalian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mctalian/subscriptions","organizations_url":"https://api.github.com/users/Mctalian/orgs","repos_url":"https://api.github.com/users/Mctalian/repos","events_url":"https://api.github.com/users/Mctalian/events{/privacy}","received_events_url":"https://api.github.com/users/Mctalian/received_events","type":"User","site_admin":false},"body":"Will close issue #164\r\n\r\nAs of the time of submitting this PR, the following are atomic database operations:\r\n* Adding a comment to an idea (already implemented)\r\n* Removing a comment to an idea (already implemented)\r\n* Liking an idea\r\n* Unliking an idea\r\n* Adding a back to an idea\r\n* Removing a back from an idea (untested since that functionality doesn't exist)\r\n\r\nThings that are still needed:\r\n* Editing a back (this might be challenging)\r\n* Editing a comment (not yet implemented, but that should also be atomic for when it does get implemented. Might be outside scope of this PR)\r\n* Editing an update (not yet implemented, but that should also be atomic for when it does get implemented. Might be outside scope of this PR)\r\n* Adding an update to an idea\r\n* Removing an update from an idea\r\n* Anything team related\r\n\r\nWhy is there a concurrency issue? Anytime we call IdeaSvc.updateIdea in the client code, we are passing the entire Idea object to the server and overwriting it. So if 2 users submit a comment at the same time, only the second comment will show. We need to be updating tiny sections of the idea instead using atomic operations instead.\r\n\r\nMore to come, but feel free to have a look now:\r\n\r\n@YashdalfTheGray @davethenipper @alanlgirard @monotkate @bcbrennecke @LongArmMcGee @Daviddt17","created_at":"2015-11-25T22:28:10Z","updated_at":"2015-11-25T22:39:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"464b09d6aebe574766c8beb4051c0c13947c87cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/169/commits","review_comments_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/169/comments","review_comment_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/issues/169/comments","statuses_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/statuses/98763162ea78e72bdbabf62f306551790927df10","head":{"label":"Mctalian:master","ref":"master","sha":"98763162ea78e72bdbabf62f306551790927df10","user":{"login":"Mctalian","id":5081281,"avatar_url":"https://avatars.githubusercontent.com/u/5081281?v=3","gravatar_id":"","url":"https://api.github.com/users/Mctalian","html_url":"https://github.com/Mctalian","followers_url":"https://api.github.com/users/Mctalian/followers","following_url":"https://api.github.com/users/Mctalian/following{/other_user}","gists_url":"https://api.github.com/users/Mctalian/gists{/gist_id}","starred_url":"https://api.github.com/users/Mctalian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mctalian/subscriptions","organizations_url":"https://api.github.com/users/Mctalian/orgs","repos_url":"https://api.github.com/users/Mctalian/repos","events_url":"https://api.github.com/users/Mctalian/events{/privacy}","received_events_url":"https://api.github.com/users/Mctalian/received_events","type":"User","site_admin":false},"repo":{"id":36624239,"name":"flintandsteel","full_name":"Mctalian/flintandsteel","owner":{"login":"Mctalian","id":5081281,"avatar_url":"https://avatars.githubusercontent.com/u/5081281?v=3","gravatar_id":"","url":"https://api.github.com/users/Mctalian","html_url":"https://github.com/Mctalian","followers_url":"https://api.github.com/users/Mctalian/followers","following_url":"https://api.github.com/users/Mctalian/following{/other_user}","gists_url":"https://api.github.com/users/Mctalian/gists{/gist_id}","starred_url":"https://api.github.com/users/Mctalian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mctalian/subscriptions","organizations_url":"https://api.github.com/users/Mctalian/orgs","repos_url":"https://api.github.com/users/Mctalian/repos","events_url":"https://api.github.com/users/Mctalian/events{/privacy}","received_events_url":"https://api.github.com/users/Mctalian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mctalian/flintandsteel","description":"Cleveland Innovation Challenge 2015 Team #SynergisticSiloBusters","fork":true,"url":"https://api.github.com/repos/Mctalian/flintandsteel","forks_url":"https://api.github.com/repos/Mctalian/flintandsteel/forks","keys_url":"https://api.github.com/repos/Mctalian/flintandsteel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mctalian/flintandsteel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mctalian/flintandsteel/teams","hooks_url":"https://api.github.com/repos/Mctalian/flintandsteel/hooks","issue_events_url":"https://api.github.com/repos/Mctalian/flintandsteel/issues/events{/number}","events_url":"https://api.github.com/repos/Mctalian/flintandsteel/events","assignees_url":"https://api.github.com/repos/Mctalian/flintandsteel/assignees{/user}","branches_url":"https://api.github.com/repos/Mctalian/flintandsteel/branches{/branch}","tags_url":"https://api.github.com/repos/Mctalian/flintandsteel/tags","blobs_url":"https://api.github.com/repos/Mctalian/flintandsteel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mctalian/flintandsteel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mctalian/flintandsteel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mctalian/flintandsteel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mctalian/flintandsteel/statuses/{sha}","languages_url":"https://api.github.com/repos/Mctalian/flintandsteel/languages","stargazers_url":"https://api.github.com/repos/Mctalian/flintandsteel/stargazers","contributors_url":"https://api.github.com/repos/Mctalian/flintandsteel/contributors","subscribers_url":"https://api.github.com/repos/Mctalian/flintandsteel/subscribers","subscription_url":"https://api.github.com/repos/Mctalian/flintandsteel/subscription","commits_url":"https://api.github.com/repos/Mctalian/flintandsteel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mctalian/flintandsteel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mctalian/flintandsteel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mctalian/flintandsteel/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mctalian/flintandsteel/contents/{+path}","compare_url":"https://api.github.com/repos/Mctalian/flintandsteel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mctalian/flintandsteel/merges","archive_url":"https://api.github.com/repos/Mctalian/flintandsteel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mctalian/flintandsteel/downloads","issues_url":"https://api.github.com/repos/Mctalian/flintandsteel/issues{/number}","pulls_url":"https://api.github.com/repos/Mctalian/flintandsteel/pulls{/number}","milestones_url":"https://api.github.com/repos/Mctalian/flintandsteel/milestones{/number}","notifications_url":"https://api.github.com/repos/Mctalian/flintandsteel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mctalian/flintandsteel/labels{/name}","releases_url":"https://api.github.com/repos/Mctalian/flintandsteel/releases{/id}","created_at":"2015-05-31T22:07:40Z","updated_at":"2015-05-31T22:07:40Z","pushed_at":"2015-11-25T22:16:14Z","git_url":"git://github.com/Mctalian/flintandsteel.git","ssh_url":"git@github.com:Mctalian/flintandsteel.git","clone_url":"https://github.com/Mctalian/flintandsteel.git","svn_url":"https://github.com/Mctalian/flintandsteel","homepage":"","size":1643,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"YashdalfTheGray:master","ref":"master","sha":"1988dfd72093a1a64efc8093dccd1a6b061d0403","user":{"login":"YashdalfTheGray","id":3102848,"avatar_url":"https://avatars.githubusercontent.com/u/3102848?v=3","gravatar_id":"","url":"https://api.github.com/users/YashdalfTheGray","html_url":"https://github.com/YashdalfTheGray","followers_url":"https://api.github.com/users/YashdalfTheGray/followers","following_url":"https://api.github.com/users/YashdalfTheGray/following{/other_user}","gists_url":"https://api.github.com/users/YashdalfTheGray/gists{/gist_id}","starred_url":"https://api.github.com/users/YashdalfTheGray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YashdalfTheGray/subscriptions","organizations_url":"https://api.github.com/users/YashdalfTheGray/orgs","repos_url":"https://api.github.com/users/YashdalfTheGray/repos","events_url":"https://api.github.com/users/YashdalfTheGray/events{/privacy}","received_events_url":"https://api.github.com/users/YashdalfTheGray/received_events","type":"User","site_admin":false},"repo":{"id":34150685,"name":"flintandsteel","full_name":"YashdalfTheGray/flintandsteel","owner":{"login":"YashdalfTheGray","id":3102848,"avatar_url":"https://avatars.githubusercontent.com/u/3102848?v=3","gravatar_id":"","url":"https://api.github.com/users/YashdalfTheGray","html_url":"https://github.com/YashdalfTheGray","followers_url":"https://api.github.com/users/YashdalfTheGray/followers","following_url":"https://api.github.com/users/YashdalfTheGray/following{/other_user}","gists_url":"https://api.github.com/users/YashdalfTheGray/gists{/gist_id}","starred_url":"https://api.github.com/users/YashdalfTheGray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YashdalfTheGray/subscriptions","organizations_url":"https://api.github.com/users/YashdalfTheGray/orgs","repos_url":"https://api.github.com/users/YashdalfTheGray/repos","events_url":"https://api.github.com/users/YashdalfTheGray/events{/privacy}","received_events_url":"https://api.github.com/users/YashdalfTheGray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YashdalfTheGray/flintandsteel","description":"Cleveland Innovation Challenge 2015 Team #SynergisticSiloBusters","fork":false,"url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel","forks_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/forks","keys_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/teams","hooks_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/hooks","issue_events_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/issues/events{/number}","events_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/events","assignees_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/assignees{/user}","branches_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/branches{/branch}","tags_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/tags","blobs_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/git/refs{/sha}","trees_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/statuses/{sha}","languages_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/languages","stargazers_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/stargazers","contributors_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/contributors","subscribers_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/subscribers","subscription_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/subscription","commits_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/commits{/sha}","git_commits_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/git/commits{/sha}","comments_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/comments{/number}","issue_comment_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/issues/comments{/number}","contents_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/contents/{+path}","compare_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/merges","archive_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/downloads","issues_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/issues{/number}","pulls_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls{/number}","milestones_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/milestones{/number}","notifications_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/labels{/name}","releases_url":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/releases{/id}","created_at":"2015-04-18T03:20:39Z","updated_at":"2015-11-13T16:19:07Z","pushed_at":"2015-11-25T22:28:11Z","git_url":"git://github.com/YashdalfTheGray/flintandsteel.git","ssh_url":"git@github.com:YashdalfTheGray/flintandsteel.git","clone_url":"https://github.com/YashdalfTheGray/flintandsteel.git","svn_url":"https://github.com/YashdalfTheGray/flintandsteel","homepage":"","size":1619,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":11,"forks":8,"open_issues":11,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/169"},"html":{"href":"https://github.com/YashdalfTheGray/flintandsteel/pull/169"},"issue":{"href":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/issues/169"},"comments":{"href":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/YashdalfTheGray/flintandsteel/statuses/98763162ea78e72bdbabf62f306551790927df10"}}}}