{"push_id":652180900,"size":34,"distinct_size":34,"ref":"refs/heads/upstream-master","head":"b978b85b24967416902629249f0808b36d990dcc","before":"06313277f2628647e3d8dd403fe0d84548ec5aeb","commits":[{"sha":"fb9da19e90075a12aa84e6507e78a5d1efa6101c","author":{"email":"2a54bf90b2b53e2ab35ffe11dda2730a23b4aa9c@gmail.com","name":"Roman Bogorodskiy"},"message":"conf: explicitly initialize 'cpumask' variable\n\nBuild with clang fails with:\n\n  CC       conf/libvirt_conf_la-domain_conf.lo\n  conf/domain_conf.c:13377:9: error: variable 'cpumask' is used\n  uninitialized whenever 'if' condition is true\n  [-Werror,-Wsometimes-uninitialized]\n      if (!(tmp = virXMLPropString(node, \"cpuset\"))) {\n                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nand many other similar errors regarding the 'cpuset' variable.\n\nFix by explicitly initializing it with NULL.","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/fb9da19e90075a12aa84e6507e78a5d1efa6101c"},{"sha":"e505591e28a3bc84f4647afdd6df6884bd939e48","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"conf: Resolve some Coverity errors\n\nResolve some Coverity errors with IOThread changes\n\nSigned-off-by: John Ferlan <jferlan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/e505591e28a3bc84f4647afdd6df6884bd939e48"},{"sha":"4c2ca5664ac56c2b582a0f44851df73f0af39c92","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Remove need for qemuDomainParseIOThreadAlias\n\nRather than have a separate routine to parse the alias of an iothread\nreturned from qemu in order to get the iothread_id value, parse the alias\nwhen returning and just return the iothread_id in qemuMonitorIOThreadInfoPtr\n\nThis set of patches removes the function, changes the \"char *name\" to\n\"unsigned int\" and handles all the fallout.","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/4c2ca5664ac56c2b582a0f44851df73f0af39c92"},{"sha":"69b16513a5c5f2e9a0d269b659fa55ff6d6e8267","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: qemuProcessDetectIOThreadPIDs invert checks\n\nIf we received zero iothreads from the monitor, but were perhaps\nexpecting to receive something, then the code was skipping the check\nto ensure what's in the monitor matches our expectations.  So invert\nthe checks to check that what we get back matches expectations and\nthen check there are zero iothreads returned.","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/69b16513a5c5f2e9a0d269b659fa55ff6d6e8267"},{"sha":"b515339fe79f09b90dcdaf57ef5060cd4c4c5764","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Remove need for qemuMonitorIOThreadInfoFree\n\nReplace with just VIR_FREE.","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/b515339fe79f09b90dcdaf57ef5060cd4c4c5764"},{"sha":"b29aff322f517ae5c9d3b032e5bd1cad3b2dd8b7","author":{"email":"7cd45ff6ad1fb7cf556a02797d774247851499f8@redhat.com","name":"Cole Robinson"},"message":"storage: Fix autostart dir for qemu:///session","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/b29aff322f517ae5c9d3b032e5bd1cad3b2dd8b7"},{"sha":"c180a3dcf7c3f5ae640629b1b14f89357d6a4547","author":{"email":"7cd45ff6ad1fb7cf556a02797d774247851499f8@redhat.com","name":"Cole Robinson"},"message":"storage: Don't leave stale state file if pool startup fails\n\nAfter pool startup we call refreshPool(). If that fails, we leave\na stale pool state file hanging around.\n\nHit this trying to create a pool with qemu:///session containing\nroot owned files.","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/c180a3dcf7c3f5ae640629b1b14f89357d6a4547"},{"sha":"af9dc75c1faf23565345d7a653a85a09efee0ac0","author":{"email":"7cd45ff6ad1fb7cf556a02797d774247851499f8@redhat.com","name":"Cole Robinson"},"message":"storage: Break out storageDriverLoadPoolState\n\nWill simplify a future patch","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/af9dc75c1faf23565345d7a653a85a09efee0ac0"},{"sha":"65fc82466695045b83a4a90df5550c7fae6bfe25","author":{"email":"7cd45ff6ad1fb7cf556a02797d774247851499f8@redhat.com","name":"Cole Robinson"},"message":"storage: If driver startup state syncing fails, delete statefile\n\nIf you end up with a state file for a pool that no longer starts up\nor refreshes correctly, the state file is never removed and adds\nnoise to the logs everytime libvirtd is started.\n\nIf the initial state syncing fails, delete the statefile.","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/65fc82466695045b83a4a90df5550c7fae6bfe25"},{"sha":"56476f6a2d1564c040b749a385c3588a914921f0","author":{"email":"7cd45ff6ad1fb7cf556a02797d774247851499f8@redhat.com","name":"Cole Robinson"},"message":"storage: fs: Ignore volumes that fail to open with EACCESS/EPERM\n\nTrying to use qemu:///session to create a storage pool pointing at\n/tmp will usually fail with something like:\n\n$ virsh pool-start tmp\nerror: Failed to start pool tmp\nerror: cannot open volume '/tmp/systemd-private-c38cf0418d7a4734a66a8175996c384f-colord.service-kEyiTA': Permission denied\n\nIf any volume in an FS pool can't be opened by the daemon, the refresh\nfails, and the pool can't be used.\n\nThis causes pain for virt-install/virt-manager though. Imaging a user\ndownloads a disk image to /tmp. virt-manager wants to import /tmp as\na storage pool, so we can detect what disk format it is, and set the\nXML correctly. However this case will likely fail as explained above.\n\nChange the logic here to skip volumes that fail to open. This could\nconceivably cause user complaints along the lines of 'why doesn't\nlibvirt show $ROOT-OWNED-VOLUME-FOO', but figuring that currently\nthe pool won't even startup, I don't think there are any current\nusers that care about that case.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1103308","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/56476f6a2d1564c040b749a385c3588a914921f0"},{"sha":"6f5d29f40d6b3fad4476e5b0681ff2f93ff795a9","author":{"email":"cae72d1e73283b1efb9f7d3401b1ea60af16bc40@huawei.com","name":"Zhang Bo"},"message":"qemu: make qemuMonitorChardevInfoFree non-static\n\nIt would be used in qemumonitorjsontest, thus we make it non-static.\n\nSigned-off-by: Zhang Bo <oscar.zhangbo@huawei.com>\nSigned-off-by: Zhou Yimin <zhouyimin@huawei.com>","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/6f5d29f40d6b3fad4476e5b0681ff2f93ff795a9"},{"sha":"e6bb622032e8e98b85609f9a237aef5e56cb925f","author":{"email":"cae72d1e73283b1efb9f7d3401b1ea60af16bc40@huawei.com","name":"Zhang Bo"},"message":"tests: free ChardevInfo correctly in qemumonitorjsontest\n\nThe free callback should be qemuMonitorChardevInfoFree rather\nthan just 'free' when virHashCreate'ing the chardevInfo hash.\n\n==29959== 24 bytes in 2 blocks are definitely lost in loss record 19 of 53\n==29959==    at 0x4C29F80: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)\n==29959==    by 0xB95C679: strdup (in /lib64/libc-2.20.so)\n==29959==    by 0x63C6546: virStrdup (virstring.c:709)\n==29959==    by 0x4805ED: qemuMonitorJSONExtractChardevInfo (qemu_monitor_json.c:3429)\n==29959==    by 0x4807A5: qemuMonitorJSONGetChardevInfo (qemu_monitor_json.c:3479)\n==29959==    by 0x434AEC: testQemuMonitorJSONqemuMonitorJSONGetChardevInfo (qemumonitorjsontest.c:1824)\n==29959==    by 0x436F2F: virtTestRun (testutils.c:211)\n==29959==    by 0x436932: mymain (qemumonitorjsontest.c:2404)\n==29959==    by 0x4382EA: virtTestMain (testutils.c:863)\n==29959==    by 0x436B27: main (qemumonitorjsontest.c:2423)\n\nSigned-off-by: Zhang Bo <oscar.zhangbo@huawei.com>\nSigned-off-by: Zhou Yimin <zhouyimin@huawei.com>","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/e6bb622032e8e98b85609f9a237aef5e56cb925f"},{"sha":"922563e73ab5585205aba7a15ead04c458b9c02a","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"Fix building virnetserverclientmock with MinGW\n\nSigned-off-by: Pavel Fedin <p.fedin@samsung.com>\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/922563e73ab5585205aba7a15ead04c458b9c02a"},{"sha":"0d20195e532599d42962e4e8c2122b5cd4541b7b","author":{"email":"3521c777060d1ad4ae08bba7eb9d80264eaeb236@parallels.com","name":"Maxim Nestratov"},"message":"parallels: add prlsdkDelDisk and prlsdkGetDiskIndex functions\n\nSigned-off-by: Maxim Nestratov <mnestratov@parallels.com>","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/0d20195e532599d42962e4e8c2122b5cd4541b7b"},{"sha":"18f24c65d5c62ed172fd2bd22d148d79f8a408db","author":{"email":"3521c777060d1ad4ae08bba7eb9d80264eaeb236@parallels.com","name":"Maxim Nestratov"},"message":"parallels: implement domainDetachDevice and domainDetachDeviceFlags\n\nNew functions utilize previosly added prlsdkDelDisk and prlsdkGetDiskIndex\nSigned-off-by: Maxim Nestratov <mnestratov@parallels.com>","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/18f24c65d5c62ed172fd2bd22d148d79f8a408db"},{"sha":"ebe0bd5590415981f5b01a5cf4aa702b269566f9","author":{"email":"2cf5c04c61aa466e4a47bfedc747d17279c72ffc@redhat.com","name":"Peter Krempa"},"message":"qemu: blockCopy: Allow reuse of raw image for shallow block copy\n\nThe documentation states that for shallow block copy the image has to\nhave the same guest visible content as backing file of the current\nimage if the file is being reused. This condition can be achieved also\nwith a raw file (or a qcow without a backing file) so remove the\ncondition that would disallow it.\n\n(This patch additionally fixes crash described in\n https://bugzilla.redhat.com/show_bug.cgi?id=1215569 )","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/ebe0bd5590415981f5b01a5cf4aa702b269566f9"},{"sha":"406944e476729ce740da126d767b073e23c1af4d","author":{"email":"2cf5c04c61aa466e4a47bfedc747d17279c72ffc@redhat.com","name":"Peter Krempa"},"message":"qemu: conf: Reject memory device if it would exceed configured max size\n\nIf the added memory device would exceed the maximum memory size, reject\nit.\n\nResolves: https://bugzilla.redhat.com/show_bug.cgi?id=1216046","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/406944e476729ce740da126d767b073e23c1af4d"},{"sha":"6705d828fc44fabf9f24c73a649089f068b00f35","author":{"email":"2cf5c04c61aa466e4a47bfedc747d17279c72ffc@redhat.com","name":"Peter Krempa"},"message":"qemu: command: Validate that memory devices slot ID is in range\n\nslot id, if specified, has to be less than the slots count.","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/6705d828fc44fabf9f24c73a649089f068b00f35"},{"sha":"a83b2e253f0750c7053e2bf0f4510d6e1de73264","author":{"email":"2cf5c04c61aa466e4a47bfedc747d17279c72ffc@redhat.com","name":"Peter Krempa"},"message":"qemu: Validate available slot count for memory devices\n\nWhile qemu would reject the configuration we can check whether it makes\nsense to plug the device upfront.","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/a83b2e253f0750c7053e2bf0f4510d6e1de73264"},{"sha":"206dbf3f0a1b51ea667767858e7126083990885c","author":{"email":"a17fed27eaa842282862ff7c1b9c8395a26ac320@very.puzzling.org","name":"Michael Chapman"},"message":"qemuBlockJobEventProcess: move to new source file\n\nWe will want to use synchronous block jobs from qemu_migration as well,\nso split this function out into a new source file.\n\nSigned-off-by: Michael Chapman <mike@very.puzzling.org>","distinct":true,"url":"https://api.github.com/repos/olafhering/libvirt/commits/206dbf3f0a1b51ea667767858e7126083990885c"}]}