{"action":"opened","number":10006,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/10006","id":28429788,"html_url":"https://github.com/JuliaLang/julia/pull/10006","diff_url":"https://github.com/JuliaLang/julia/pull/10006.diff","patch_url":"https://github.com/JuliaLang/julia/pull/10006.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/10006","number":10006,"state":"open","locked":false,"title":"Fix windows support for `build_executable.jl`. fix #9973","user":{"login":"dhoegh","id":7973946,"avatar_url":"https://avatars.githubusercontent.com/u/7973946?v=3","gravatar_id":"","url":"https://api.github.com/users/dhoegh","html_url":"https://github.com/dhoegh","followers_url":"https://api.github.com/users/dhoegh/followers","following_url":"https://api.github.com/users/dhoegh/following{/other_user}","gists_url":"https://api.github.com/users/dhoegh/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoegh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoegh/subscriptions","organizations_url":"https://api.github.com/users/dhoegh/orgs","repos_url":"https://api.github.com/users/dhoegh/repos","events_url":"https://api.github.com/users/dhoegh/events{/privacy}","received_events_url":"https://api.github.com/users/dhoegh/received_events","type":"User","site_admin":false},"body":"The changes made to the script allow for use on windows.\r\n\r\nI have changed how `gcc` is found, the setup for the compiler and the changes in the copying/moving files. The things I would like to get thorough review is:\r\n* That I have disabled the fix rpath on windows, https://github.com/dhoegh/julia/blob/b76f234f777cb37f4686af11200e9ec928622908/contrib/build_executable.jl#L156-L168. The results still works also if the containing folder is moved, I do not know if this is correct please enlighten me.\r\n*  Changes in `find_patchelf` function. I changed it due to it did not return `nothing` when `patchelf` is not installed, which I think is not the intention.\r\n\r\nIt would also be great if someone could test it on windows, if possible windows xp due to https://github.com/dhoegh/julia/blob/b76f234f777cb37f4686af11200e9ec928622908/contrib/build_executable.jl#L114 which I have not tested but brought up in #9973.\r\n\r\n@few could you review my changes?","created_at":"2015-02-01T11:18:01Z","updated_at":"2015-02-01T11:18:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/10006/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/10006/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/10006/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/b76f234f777cb37f4686af11200e9ec928622908","head":{"label":"dhoegh:build_executable","ref":"build_executable","sha":"b76f234f777cb37f4686af11200e9ec928622908","user":{"login":"dhoegh","id":7973946,"avatar_url":"https://avatars.githubusercontent.com/u/7973946?v=3","gravatar_id":"","url":"https://api.github.com/users/dhoegh","html_url":"https://github.com/dhoegh","followers_url":"https://api.github.com/users/dhoegh/followers","following_url":"https://api.github.com/users/dhoegh/following{/other_user}","gists_url":"https://api.github.com/users/dhoegh/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoegh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoegh/subscriptions","organizations_url":"https://api.github.com/users/dhoegh/orgs","repos_url":"https://api.github.com/users/dhoegh/repos","events_url":"https://api.github.com/users/dhoegh/events{/privacy}","received_events_url":"https://api.github.com/users/dhoegh/received_events","type":"User","site_admin":false},"repo":{"id":25273106,"name":"julia","full_name":"dhoegh/julia","owner":{"login":"dhoegh","id":7973946,"avatar_url":"https://avatars.githubusercontent.com/u/7973946?v=3","gravatar_id":"","url":"https://api.github.com/users/dhoegh","html_url":"https://github.com/dhoegh","followers_url":"https://api.github.com/users/dhoegh/followers","following_url":"https://api.github.com/users/dhoegh/following{/other_user}","gists_url":"https://api.github.com/users/dhoegh/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoegh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoegh/subscriptions","organizations_url":"https://api.github.com/users/dhoegh/orgs","repos_url":"https://api.github.com/users/dhoegh/repos","events_url":"https://api.github.com/users/dhoegh/events{/privacy}","received_events_url":"https://api.github.com/users/dhoegh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhoegh/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/dhoegh/julia","forks_url":"https://api.github.com/repos/dhoegh/julia/forks","keys_url":"https://api.github.com/repos/dhoegh/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhoegh/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhoegh/julia/teams","hooks_url":"https://api.github.com/repos/dhoegh/julia/hooks","issue_events_url":"https://api.github.com/repos/dhoegh/julia/issues/events{/number}","events_url":"https://api.github.com/repos/dhoegh/julia/events","assignees_url":"https://api.github.com/repos/dhoegh/julia/assignees{/user}","branches_url":"https://api.github.com/repos/dhoegh/julia/branches{/branch}","tags_url":"https://api.github.com/repos/dhoegh/julia/tags","blobs_url":"https://api.github.com/repos/dhoegh/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhoegh/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhoegh/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhoegh/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhoegh/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/dhoegh/julia/languages","stargazers_url":"https://api.github.com/repos/dhoegh/julia/stargazers","contributors_url":"https://api.github.com/repos/dhoegh/julia/contributors","subscribers_url":"https://api.github.com/repos/dhoegh/julia/subscribers","subscription_url":"https://api.github.com/repos/dhoegh/julia/subscription","commits_url":"https://api.github.com/repos/dhoegh/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhoegh/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhoegh/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhoegh/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/dhoegh/julia/contents/{+path}","compare_url":"https://api.github.com/repos/dhoegh/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhoegh/julia/merges","archive_url":"https://api.github.com/repos/dhoegh/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhoegh/julia/downloads","issues_url":"https://api.github.com/repos/dhoegh/julia/issues{/number}","pulls_url":"https://api.github.com/repos/dhoegh/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/dhoegh/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/dhoegh/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhoegh/julia/labels{/name}","releases_url":"https://api.github.com/repos/dhoegh/julia/releases{/id}","created_at":"2014-10-15T20:53:01Z","updated_at":"2015-01-31T19:53:33Z","pushed_at":"2015-02-01T10:45:50Z","git_url":"git://github.com/dhoegh/julia.git","ssh_url":"git@github.com:dhoegh/julia.git","clone_url":"https://github.com/dhoegh/julia.git","svn_url":"https://github.com/dhoegh/julia","homepage":"http://julialang.org/","size":56925,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"311cd730ae14093b359db8852ddf0299db618816","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-02-01T06:20:18Z","pushed_at":"2015-02-01T09:54:37Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":158375,"stargazers_count":5010,"watchers_count":5010,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1050,"mirror_url":null,"open_issues_count":1148,"forks":1050,"open_issues":1148,"watchers":5010,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/10006"},"html":{"href":"https://github.com/JuliaLang/julia/pull/10006"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/10006"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/10006/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/10006/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/10006/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/b76f234f777cb37f4686af11200e9ec928622908"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":69,"deletions":34,"changed_files":1}}