{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14883","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14883/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14883/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14883/events","html_url":"https://github.com/kubernetes/kubernetes/pull/14883","id":109201679,"number":14883,"title":"support etcd tls in kube2sky","user":{"login":"roboll","id":1259631,"avatar_url":"https://avatars.githubusercontent.com/u/1259631?v=3","gravatar_id":"","url":"https://api.github.com/users/roboll","html_url":"https://github.com/roboll","followers_url":"https://api.github.com/users/roboll/followers","following_url":"https://api.github.com/users/roboll/following{/other_user}","gists_url":"https://api.github.com/users/roboll/gists{/gist_id}","starred_url":"https://api.github.com/users/roboll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roboll/subscriptions","organizations_url":"https://api.github.com/users/roboll/orgs","repos_url":"https://api.github.com/users/roboll/repos","events_url":"https://api.github.com/users/roboll/events{/privacy}","received_events_url":"https://api.github.com/users/roboll/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"open","locked":false,"assignee":{"login":"ArtfulCoder","id":1220660,"avatar_url":"https://avatars.githubusercontent.com/u/1220660?v=3","gravatar_id":"","url":"https://api.github.com/users/ArtfulCoder","html_url":"https://github.com/ArtfulCoder","followers_url":"https://api.github.com/users/ArtfulCoder/followers","following_url":"https://api.github.com/users/ArtfulCoder/following{/other_user}","gists_url":"https://api.github.com/users/ArtfulCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtfulCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtfulCoder/subscriptions","organizations_url":"https://api.github.com/users/ArtfulCoder/orgs","repos_url":"https://api.github.com/users/ArtfulCoder/repos","events_url":"https://api.github.com/users/ArtfulCoder/events{/privacy}","received_events_url":"https://api.github.com/users/ArtfulCoder/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-09-30T23:38:00Z","updated_at":"2015-11-17T00:28:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14883","html_url":"https://github.com/kubernetes/kubernetes/pull/14883","diff_url":"https://github.com/kubernetes/kubernetes/pull/14883.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/14883.patch"},"body":"adds support for connecting to a tls enabled etcd cluster.\r\n\r\nbecause the cluster is tls enabled, the code that is used to validate the endpoint is available wouldn't work as expected - it uses a plain http client. i'm not sure what the motivation was behind that, but it felt like overkill since the etcd client itself will return error if the machine is not reachable. open to feedback on that if you feel like it's necessary.\r\n\r\nthe way it's written is, if any tls option is specified, it tries to create a tls client, which should fail fast on errors. if none are specified, it defaults to the existing behavior, so it shouldn't affect any existing setups."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/157219363","html_url":"https://github.com/kubernetes/kubernetes/pull/14883#issuecomment-157219363","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14883","id":157219363,"user":{"login":"roboll","id":1259631,"avatar_url":"https://avatars.githubusercontent.com/u/1259631?v=3","gravatar_id":"","url":"https://api.github.com/users/roboll","html_url":"https://github.com/roboll","followers_url":"https://api.github.com/users/roboll/followers","following_url":"https://api.github.com/users/roboll/following{/other_user}","gists_url":"https://api.github.com/users/roboll/gists{/gist_id}","starred_url":"https://api.github.com/users/roboll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roboll/subscriptions","organizations_url":"https://api.github.com/users/roboll/orgs","repos_url":"https://api.github.com/users/roboll/repos","events_url":"https://api.github.com/users/roboll/events{/privacy}","received_events_url":"https://api.github.com/users/roboll/received_events","type":"User","site_admin":false},"created_at":"2015-11-17T00:28:21Z","updated_at":"2015-11-17T00:28:21Z","body":"i havent looked at this in a bit, i'll make some time tomorrow and see if we can get this working and consistent."}}