{"action":"closed","number":72,"pull_request":{"url":"https://api.github.com/repos/Teiid-Designer/komodo/pulls/72","id":29653294,"html_url":"https://github.com/Teiid-Designer/komodo/pull/72","diff_url":"https://github.com/Teiid-Designer/komodo/pull/72.diff","patch_url":"https://github.com/Teiid-Designer/komodo/pull/72.patch","issue_url":"https://api.github.com/repos/Teiid-Designer/komodo/issues/72","number":72,"state":"closed","locked":false,"title":"Adds ability to adapt KomodoObject into its relational implementation","user":{"login":"phantomjinx","id":1634180,"avatar_url":"https://avatars.githubusercontent.com/u/1634180?v=3","gravatar_id":"","url":"https://api.github.com/users/phantomjinx","html_url":"https://github.com/phantomjinx","followers_url":"https://api.github.com/users/phantomjinx/followers","following_url":"https://api.github.com/users/phantomjinx/following{/other_user}","gists_url":"https://api.github.com/users/phantomjinx/gists{/gist_id}","starred_url":"https://api.github.com/users/phantomjinx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phantomjinx/subscriptions","organizations_url":"https://api.github.com/users/phantomjinx/orgs","repos_url":"https://api.github.com/users/phantomjinx/repos","events_url":"https://api.github.com/users/phantomjinx/events{/privacy}","received_events_url":"https://api.github.com/users/phantomjinx/received_events","type":"User","site_admin":false},"body":"* The Cli DeployCommand requires a Vdb but the context only returns a\r\n  KomodoObject. The latter is an instance of Vdb but only with an adapter\r\n  can a Vdb be declared unless one resorts to instance checking.\r\n\r\n* The Cli CreateCommand requires the creation of any type of relational\r\n  object yet has only a type id available from the user input. This can be\r\n  solved with a generic create method that utilised the type id.\r\n\r\n* KomodoObject\r\n * getTypeId method declared that all objects adhere to\r\n\r\n* All relational objects implement getTypeId using KomodoType enum\r\n\r\n* ObjectImpl\r\n * Has no type itself but can infer the type from its own descriptors\r\n\r\n* KomodoTypeRegistry\r\n * Convenience registry indexes each KomodoType against its lexicon node\r\n   type id\r\n\r\n* WorkspaceManager\r\n * Provides adapt and create methods. The adapt method can adapt any\r\n   KomodoObject into its requisite relation impl. This includes ObjectImpl\r\n   in that an instance of ObjectImpl reference a vdb can be adapter to a\r\n   VdbImpl.\r\n\r\n* WorkspaceManagerTest\r\n * Tests to exercising adapt and create methods","created_at":"2015-02-19T22:01:43Z","updated_at":"2015-02-24T13:30:51Z","closed_at":"2015-02-24T13:30:51Z","merged_at":"2015-02-24T13:30:51Z","merge_commit_sha":"2e2b9bc72ef4ce293e7e3ad7f52c6e6e45171075","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Teiid-Designer/komodo/pulls/72/commits","review_comments_url":"https://api.github.com/repos/Teiid-Designer/komodo/pulls/72/comments","review_comment_url":"https://api.github.com/repos/Teiid-Designer/komodo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Teiid-Designer/komodo/issues/72/comments","statuses_url":"https://api.github.com/repos/Teiid-Designer/komodo/statuses/cf144c19fff11a3072cc95998bfcdf893a8cfad8","head":{"label":"phantomjinx:master","ref":"master","sha":"cf144c19fff11a3072cc95998bfcdf893a8cfad8","user":{"login":"phantomjinx","id":1634180,"avatar_url":"https://avatars.githubusercontent.com/u/1634180?v=3","gravatar_id":"","url":"https://api.github.com/users/phantomjinx","html_url":"https://github.com/phantomjinx","followers_url":"https://api.github.com/users/phantomjinx/followers","following_url":"https://api.github.com/users/phantomjinx/following{/other_user}","gists_url":"https://api.github.com/users/phantomjinx/gists{/gist_id}","starred_url":"https://api.github.com/users/phantomjinx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phantomjinx/subscriptions","organizations_url":"https://api.github.com/users/phantomjinx/orgs","repos_url":"https://api.github.com/users/phantomjinx/repos","events_url":"https://api.github.com/users/phantomjinx/events{/privacy}","received_events_url":"https://api.github.com/users/phantomjinx/received_events","type":"User","site_admin":false},"repo":{"id":20478824,"name":"komodo","full_name":"phantomjinx/komodo","owner":{"login":"phantomjinx","id":1634180,"avatar_url":"https://avatars.githubusercontent.com/u/1634180?v=3","gravatar_id":"","url":"https://api.github.com/users/phantomjinx","html_url":"https://github.com/phantomjinx","followers_url":"https://api.github.com/users/phantomjinx/followers","following_url":"https://api.github.com/users/phantomjinx/following{/other_user}","gists_url":"https://api.github.com/users/phantomjinx/gists{/gist_id}","starred_url":"https://api.github.com/users/phantomjinx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phantomjinx/subscriptions","organizations_url":"https://api.github.com/users/phantomjinx/orgs","repos_url":"https://api.github.com/users/phantomjinx/repos","events_url":"https://api.github.com/users/phantomjinx/events{/privacy}","received_events_url":"https://api.github.com/users/phantomjinx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phantomjinx/komodo","description":"teiid modeling tool development utilizing ddl-based metamodel","fork":true,"url":"https://api.github.com/repos/phantomjinx/komodo","forks_url":"https://api.github.com/repos/phantomjinx/komodo/forks","keys_url":"https://api.github.com/repos/phantomjinx/komodo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phantomjinx/komodo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phantomjinx/komodo/teams","hooks_url":"https://api.github.com/repos/phantomjinx/komodo/hooks","issue_events_url":"https://api.github.com/repos/phantomjinx/komodo/issues/events{/number}","events_url":"https://api.github.com/repos/phantomjinx/komodo/events","assignees_url":"https://api.github.com/repos/phantomjinx/komodo/assignees{/user}","branches_url":"https://api.github.com/repos/phantomjinx/komodo/branches{/branch}","tags_url":"https://api.github.com/repos/phantomjinx/komodo/tags","blobs_url":"https://api.github.com/repos/phantomjinx/komodo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phantomjinx/komodo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phantomjinx/komodo/git/refs{/sha}","trees_url":"https://api.github.com/repos/phantomjinx/komodo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phantomjinx/komodo/statuses/{sha}","languages_url":"https://api.github.com/repos/phantomjinx/komodo/languages","stargazers_url":"https://api.github.com/repos/phantomjinx/komodo/stargazers","contributors_url":"https://api.github.com/repos/phantomjinx/komodo/contributors","subscribers_url":"https://api.github.com/repos/phantomjinx/komodo/subscribers","subscription_url":"https://api.github.com/repos/phantomjinx/komodo/subscription","commits_url":"https://api.github.com/repos/phantomjinx/komodo/commits{/sha}","git_commits_url":"https://api.github.com/repos/phantomjinx/komodo/git/commits{/sha}","comments_url":"https://api.github.com/repos/phantomjinx/komodo/comments{/number}","issue_comment_url":"https://api.github.com/repos/phantomjinx/komodo/issues/comments{/number}","contents_url":"https://api.github.com/repos/phantomjinx/komodo/contents/{+path}","compare_url":"https://api.github.com/repos/phantomjinx/komodo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phantomjinx/komodo/merges","archive_url":"https://api.github.com/repos/phantomjinx/komodo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phantomjinx/komodo/downloads","issues_url":"https://api.github.com/repos/phantomjinx/komodo/issues{/number}","pulls_url":"https://api.github.com/repos/phantomjinx/komodo/pulls{/number}","milestones_url":"https://api.github.com/repos/phantomjinx/komodo/milestones{/number}","notifications_url":"https://api.github.com/repos/phantomjinx/komodo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phantomjinx/komodo/labels{/name}","releases_url":"https://api.github.com/repos/phantomjinx/komodo/releases{/id}","created_at":"2014-06-04T10:16:47Z","updated_at":"2015-02-24T11:13:59Z","pushed_at":"2015-02-24T11:13:59Z","git_url":"git://github.com/phantomjinx/komodo.git","ssh_url":"git@github.com:phantomjinx/komodo.git","clone_url":"https://github.com/phantomjinx/komodo.git","svn_url":"https://github.com/phantomjinx/komodo","homepage":null,"size":47033,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Teiid-Designer:master","ref":"master","sha":"9f8447f313b1c3d881a580e809b6520822f305cc","user":{"login":"Teiid-Designer","id":1641911,"avatar_url":"https://avatars.githubusercontent.com/u/1641911?v=3","gravatar_id":"","url":"https://api.github.com/users/Teiid-Designer","html_url":"https://github.com/Teiid-Designer","followers_url":"https://api.github.com/users/Teiid-Designer/followers","following_url":"https://api.github.com/users/Teiid-Designer/following{/other_user}","gists_url":"https://api.github.com/users/Teiid-Designer/gists{/gist_id}","starred_url":"https://api.github.com/users/Teiid-Designer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teiid-Designer/subscriptions","organizations_url":"https://api.github.com/users/Teiid-Designer/orgs","repos_url":"https://api.github.com/users/Teiid-Designer/repos","events_url":"https://api.github.com/users/Teiid-Designer/events{/privacy}","received_events_url":"https://api.github.com/users/Teiid-Designer/received_events","type":"Organization","site_admin":false},"repo":{"id":14528678,"name":"komodo","full_name":"Teiid-Designer/komodo","owner":{"login":"Teiid-Designer","id":1641911,"avatar_url":"https://avatars.githubusercontent.com/u/1641911?v=3","gravatar_id":"","url":"https://api.github.com/users/Teiid-Designer","html_url":"https://github.com/Teiid-Designer","followers_url":"https://api.github.com/users/Teiid-Designer/followers","following_url":"https://api.github.com/users/Teiid-Designer/following{/other_user}","gists_url":"https://api.github.com/users/Teiid-Designer/gists{/gist_id}","starred_url":"https://api.github.com/users/Teiid-Designer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teiid-Designer/subscriptions","organizations_url":"https://api.github.com/users/Teiid-Designer/orgs","repos_url":"https://api.github.com/users/Teiid-Designer/repos","events_url":"https://api.github.com/users/Teiid-Designer/events{/privacy}","received_events_url":"https://api.github.com/users/Teiid-Designer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teiid-Designer/komodo","description":"teiid modeling tool development utilizing ddl-based metamodel","fork":false,"url":"https://api.github.com/repos/Teiid-Designer/komodo","forks_url":"https://api.github.com/repos/Teiid-Designer/komodo/forks","keys_url":"https://api.github.com/repos/Teiid-Designer/komodo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teiid-Designer/komodo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teiid-Designer/komodo/teams","hooks_url":"https://api.github.com/repos/Teiid-Designer/komodo/hooks","issue_events_url":"https://api.github.com/repos/Teiid-Designer/komodo/issues/events{/number}","events_url":"https://api.github.com/repos/Teiid-Designer/komodo/events","assignees_url":"https://api.github.com/repos/Teiid-Designer/komodo/assignees{/user}","branches_url":"https://api.github.com/repos/Teiid-Designer/komodo/branches{/branch}","tags_url":"https://api.github.com/repos/Teiid-Designer/komodo/tags","blobs_url":"https://api.github.com/repos/Teiid-Designer/komodo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teiid-Designer/komodo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teiid-Designer/komodo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teiid-Designer/komodo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teiid-Designer/komodo/statuses/{sha}","languages_url":"https://api.github.com/repos/Teiid-Designer/komodo/languages","stargazers_url":"https://api.github.com/repos/Teiid-Designer/komodo/stargazers","contributors_url":"https://api.github.com/repos/Teiid-Designer/komodo/contributors","subscribers_url":"https://api.github.com/repos/Teiid-Designer/komodo/subscribers","subscription_url":"https://api.github.com/repos/Teiid-Designer/komodo/subscription","commits_url":"https://api.github.com/repos/Teiid-Designer/komodo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teiid-Designer/komodo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teiid-Designer/komodo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teiid-Designer/komodo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teiid-Designer/komodo/contents/{+path}","compare_url":"https://api.github.com/repos/Teiid-Designer/komodo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teiid-Designer/komodo/merges","archive_url":"https://api.github.com/repos/Teiid-Designer/komodo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teiid-Designer/komodo/downloads","issues_url":"https://api.github.com/repos/Teiid-Designer/komodo/issues{/number}","pulls_url":"https://api.github.com/repos/Teiid-Designer/komodo/pulls{/number}","milestones_url":"https://api.github.com/repos/Teiid-Designer/komodo/milestones{/number}","notifications_url":"https://api.github.com/repos/Teiid-Designer/komodo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teiid-Designer/komodo/labels{/name}","releases_url":"https://api.github.com/repos/Teiid-Designer/komodo/releases{/id}","created_at":"2013-11-19T15:32:23Z","updated_at":"2015-02-23T17:21:02Z","pushed_at":"2015-02-24T13:30:51Z","git_url":"git://github.com/Teiid-Designer/komodo.git","ssh_url":"git@github.com:Teiid-Designer/komodo.git","clone_url":"https://github.com/Teiid-Designer/komodo.git","svn_url":"https://github.com/Teiid-Designer/komodo","homepage":null,"size":47434,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Teiid-Designer/komodo/pulls/72"},"html":{"href":"https://github.com/Teiid-Designer/komodo/pull/72"},"issue":{"href":"https://api.github.com/repos/Teiid-Designer/komodo/issues/72"},"comments":{"href":"https://api.github.com/repos/Teiid-Designer/komodo/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/Teiid-Designer/komodo/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/Teiid-Designer/komodo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Teiid-Designer/komodo/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/Teiid-Designer/komodo/statuses/cf144c19fff11a3072cc95998bfcdf893a8cfad8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"elvisisking","id":557336,"avatar_url":"https://avatars.githubusercontent.com/u/557336?v=3","gravatar_id":"","url":"https://api.github.com/users/elvisisking","html_url":"https://github.com/elvisisking","followers_url":"https://api.github.com/users/elvisisking/followers","following_url":"https://api.github.com/users/elvisisking/following{/other_user}","gists_url":"https://api.github.com/users/elvisisking/gists{/gist_id}","starred_url":"https://api.github.com/users/elvisisking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elvisisking/subscriptions","organizations_url":"https://api.github.com/users/elvisisking/orgs","repos_url":"https://api.github.com/users/elvisisking/repos","events_url":"https://api.github.com/users/elvisisking/events{/privacy}","received_events_url":"https://api.github.com/users/elvisisking/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2467,"deletions":435,"changed_files":72}}