{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/23931088","id":23931088,"diff_hunk":"@@ -73,19 +74,28 @@ public void postProcessModule(Module module) {\n \t\tProperties messageBusProperties = getMessageBusProperties(module, transport);\n \t\tProperties inboundModuleProperties = this.extractConsumerProducerProperties(module)[0];\n \t\tProperties outboundModuleProperties = this.extractConsumerProducerProperties(module)[1];\n-\t\tString defaultStorageLevel = env.getProperty(Processor.SPARK_STORAGE_LEVEL_PROP);\n+\t\tString defaultStorageLevel = env.getProperty(SparkStreamingSupport.SPARK_STORAGE_LEVEL_PROP);\n \t\tStorageLevel configuredStorageLevel = StorageLevel.fromString(StringUtils.hasText(defaultStorageLevel) ?\n \t\t\t\tdefaultStorageLevel : DEFAULT_STORAGE_LEVEL);\n-\t\tString storageLevelFromModule = module.getProperties().getProperty(Processor.SPARK_STORAGE_LEVEL_MODULE_OPTION);\n+\t\tString storageLevelFromModule = module.getProperties().getProperty(SparkStreamingSupport.SPARK_STORAGE_LEVEL_MODULE_OPTION);\n \t\tStorageLevel storageLevel = StringUtils.hasText(storageLevelFromModule) ?\n \t\t\t\tStorageLevel.fromString(storageLevelFromModule) : configuredStorageLevel;\n \t\tMessageBusReceiver receiver = null;\n \t\tif (transport.equals(\"local\")) {\n-\t\t\tfinal Processor sparkModule = module.getComponent(Processor.class);\n-\t\t\tProperties sparkConfigs = SparkStreamingDriverModule.getSparkModuleProperties(sparkModule);\n-\t\t\tString sparkMasterUrl = env.getProperty(Processor.SPARK_MASTER_URL_PROP);\n-\t\t\tif (sparkConfigs != null && StringUtils.hasText(sparkConfigs.getProperty(Processor.SPARK_MASTER_URL_PROP))) {\n-\t\t\t\tsparkMasterUrl = sparkConfigs.getProperty(Processor.SPARK_MASTER_URL_PROP);\n+\t\t\tSparkStreamingSupport processor;\n+\t\t\tProperties sparkConfigs = null;\n+\t\t\ttry {\n+\t\t\t\tprocessor = module.getComponent(SparkStreamingSupport.class);\n+\t\t\t\tif (processor != null) {","path":"spring-xd-dirt/src/main/java/org/springframework/xd/dirt/plugins/spark/streaming/SparkStreamingPlugin.java","position":49,"original_position":49,"commit_id":"85c913047f3228a3aef1f4a2a806eeb6c2db424b","original_commit_id":"85c913047f3228a3aef1f4a2a806eeb6c2db424b","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":"That was an extra check to protect the returned value (from SimpleModule's getComponent) against null. I will add additional else block to throw an exception if this is null. does that make sense?","created_at":"2015-02-02T15:26:16Z","updated_at":"2015-02-02T15:26:16Z","html_url":"https://github.com/spring-projects/spring-xd/pull/1422#discussion_r23931088","pull_request_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1422","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/23931088"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1422#discussion_r23931088"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1422"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1422","id":28402744,"html_url":"https://github.com/spring-projects/spring-xd/pull/1422","diff_url":"https://github.com/spring-projects/spring-xd/pull/1422.diff","patch_url":"https://github.com/spring-projects/spring-xd/pull/1422.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1422","number":1422,"state":"open","locked":false,"title":"[DO NOT MERGE] XD-2672 Scala support for spark streaming module","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":"- Add `ScalaProcessor` trait that defines the `process` method\r\n  - Handle the scala module that extends this trait\r\n     - Update `SparkStreamingPlugin` and `SparkStreamingDriverModule`\r\nto handle this appropriately\r\n- Add examples that extend this trait\r\n- Add tests","created_at":"2015-01-30T23:41:31Z","updated_at":"2015-02-02T15:26:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05769bb074e6b9437e4306b59f20638a522f1d86","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1422/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1422/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1422/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/85c913047f3228a3aef1f4a2a806eeb6c2db424b","head":{"label":"ilayaperumalg:XD-2672","ref":"XD-2672","sha":"85c913047f3228a3aef1f4a2a806eeb6c2db424b","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"repo":{"id":9632331,"name":"spring-xd","full_name":"ilayaperumalg/spring-xd","owner":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilayaperumalg/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":true,"url":"https://api.github.com/repos/ilayaperumalg/spring-xd","forks_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/forks","keys_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/teams","hooks_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/events","assignees_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/tags","blobs_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/languages","stargazers_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/subscription","commits_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/merges","archive_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/downloads","issues_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/ilayaperumalg/spring-xd/releases{/id}","created_at":"2013-04-23T20:13:28Z","updated_at":"2014-11-17T20:36:21Z","pushed_at":"2015-01-30T23:38:36Z","git_url":"git://github.com/ilayaperumalg/spring-xd.git","ssh_url":"git@github.com:ilayaperumalg/spring-xd.git","clone_url":"https://github.com/ilayaperumalg/spring-xd.git","svn_url":"https://github.com/ilayaperumalg/spring-xd","homepage":null,"size":22301,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"613f6039c9534081f4426fdab170dffef490fc5b","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":9349347,"name":"spring-xd","full_name":"spring-projects/spring-xd","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-xd","forks_url":"https://api.github.com/repos/spring-projects/spring-xd/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-xd/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-xd/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-xd/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-xd/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-xd/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/spring-projects/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-xd/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-xd/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-xd/releases{/id}","created_at":"2013-04-10T15:31:44Z","updated_at":"2015-02-02T08:35:29Z","pushed_at":"2015-01-30T20:34:03Z","git_url":"git://github.com/spring-projects/spring-xd.git","ssh_url":"git@github.com:spring-projects/spring-xd.git","clone_url":"https://github.com/spring-projects/spring-xd.git","svn_url":"https://github.com/spring-projects/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":51934,"stargazers_count":220,"watchers_count":220,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":175,"mirror_url":null,"open_issues_count":23,"forks":175,"open_issues":23,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1422"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1422"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1422"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1422/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1422/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1422/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-xd/statuses/85c913047f3228a3aef1f4a2a806eeb6c2db424b"}}}}