{"action":"created","issue":{"url":"https://api.github.com/repos/ef4/fast-sourcemap-concat/issues/10","labels_url":"https://api.github.com/repos/ef4/fast-sourcemap-concat/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/ef4/fast-sourcemap-concat/issues/10/comments","events_url":"https://api.github.com/repos/ef4/fast-sourcemap-concat/issues/10/events","html_url":"https://github.com/ef4/fast-sourcemap-concat/issues/10","id":77479919,"number":10,"title":"Fork","user":{"login":"zertosh","id":830952,"avatar_url":"https://avatars.githubusercontent.com/u/830952?v=3","gravatar_id":"","url":"https://api.github.com/users/zertosh","html_url":"https://github.com/zertosh","followers_url":"https://api.github.com/users/zertosh/followers","following_url":"https://api.github.com/users/zertosh/following{/other_user}","gists_url":"https://api.github.com/users/zertosh/gists{/gist_id}","starred_url":"https://api.github.com/users/zertosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zertosh/subscriptions","organizations_url":"https://api.github.com/users/zertosh/orgs","repos_url":"https://api.github.com/users/zertosh/repos","events_url":"https://api.github.com/users/zertosh/events{/privacy}","received_events_url":"https://api.github.com/users/zertosh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-18T03:23:55Z","updated_at":"2015-05-19T00:58:28Z","closed_at":null,"body":"Hi, I forked fast-sourcemap-concat and created a version that only deals in inline sourcemaps. It only reads inline sourcemaps and only outputs inline sourcemaps. It's up on [zertosh/inline-sourcemap-concat](https://github.com/zertosh/inline-sourcemap-concat). It's part of an experiment on improving browserify build times - if it works out, then hopefully I'll get in there. Just wanted to let know :smile: Awesome job with library! I'm very happy with the results so far.\r\n\r\n---\r\n\r\nMaybe unfork these changes back into fast-sourcemap-concat? I've got mine passing all your tests with the same* fixtures (I on-the-fly [convert](https://github.com/zertosh/inline-sourcemap-concat/blob/728db3efe9d306492dc69c2ef8ca49efcb3d421c/test/test.js#L196-L212) the fixtures into sources with inline sourcemaps to make them work). If this is something you're open to, then let me know how the API should work and I'd be more than happy to submit a PR.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ef4/fast-sourcemap-concat/issues/comments/103286126","html_url":"https://github.com/ef4/fast-sourcemap-concat/issues/10#issuecomment-103286126","issue_url":"https://api.github.com/repos/ef4/fast-sourcemap-concat/issues/10","id":103286126,"user":{"login":"zertosh","id":830952,"avatar_url":"https://avatars.githubusercontent.com/u/830952?v=3","gravatar_id":"","url":"https://api.github.com/users/zertosh","html_url":"https://github.com/zertosh","followers_url":"https://api.github.com/users/zertosh/followers","following_url":"https://api.github.com/users/zertosh/following{/other_user}","gists_url":"https://api.github.com/users/zertosh/gists{/gist_id}","starred_url":"https://api.github.com/users/zertosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zertosh/subscriptions","organizations_url":"https://api.github.com/users/zertosh/orgs","repos_url":"https://api.github.com/users/zertosh/repos","events_url":"https://api.github.com/users/zertosh/events{/privacy}","received_events_url":"https://api.github.com/users/zertosh/received_events","type":"User","site_admin":false},"created_at":"2015-05-19T00:58:28Z","updated_at":"2015-05-19T00:58:28Z","body":"> Why is inline-only relevant to performance?\r\n\r\nIt's not so much about performance, as it is about inline maps being a browserifyism. The way the pipeline works, it only makes sense to deal in inline maps. There are [tools](https://github.com/thlorenz/exorcist) for extracting the sourcemap after the build is complete - but I'm using *-sourcemap-concat inside [core](https://github.com/substack/browser-pack) browserify.\r\n\r\n> I think the ideal API is to be generous about what inputs are accepted \r\n\r\nOh sorry - that's what I meant. I'm not suggesting to get rid of reading/writing external maps. What I would like is an option(s) that:\r\n\r\n  1. Turns \"writeMode off\". That is, it makes `opts.outputFile` optional and does not create `this.stream`. Instead, it'll just collect any sources/sourcemaps it reads, and returns them when you ask. \r\n\r\n  2. Turns \"readExternalMaps off\". So `_resolveSourcemap` only returns inline source maps, skipping external ones.\r\n\r\nThese two options wouldn't be mutually exclusive. I can see others finding one or the other useful by themselves. Independent of what options are enabled, there would have to be a `comment/getComment/toComment` method that returns the inline sourcemap.\r\n\r\n> if inline is clearly better, we can make that the default\r\n\r\nNah, it's ok, I'm fine with passing in opts.\r\n\r\n> A potential benefit of external sourcemaps over inline is that the browser can boot the application before downloading and parsing the sourcemap.\r\n\r\nThat's the big win for external sourcemaps for sure, but for core browserify, can't do it :(\r\n\r\n---\r\n\r\nThe size of the dependencies kinda sucks, but such is life - broccoli is big on promises right? Maybe  bundle the base64-vlq lib? source-map includes all of its tests in the published module x_x\r\n\r\nAnyway, I don't want to impose myself on your project, so if you're open to these additions, I just need a bit of guidance before I put together a PR. Things like option(s) and method names and behavior. You can see what I went with in my fork: https://github.com/zertosh/inline-sourcemap-concat#var-sm--sourcemapconcatcreateopts.\r\n\r\nThanks again!"}}