{"action":"closed","number":360,"pull_request":{"url":"https://api.github.com/repos/dronekit/dronekit-python/pulls/360","id":48286629,"html_url":"https://github.com/dronekit/dronekit-python/pull/360","diff_url":"https://github.com/dronekit/dronekit-python/pull/360.diff","patch_url":"https://github.com/dronekit/dronekit-python/pull/360.patch","issue_url":"https://api.github.com/repos/dronekit/dronekit-python/issues/360","number":360,"state":"closed","locked":false,"title":"Fix up flight_replay.py doc/example to DKPY2. Note, still has bug #355","user":{"login":"hamishwillee","id":5368500,"avatar_url":"https://avatars.githubusercontent.com/u/5368500?v=3","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"body":"This fixes up the flight_replay example and associated docs to be \"DKPY2 compliant\". This includes adding vehicle.close and connect, and making the example docs follow the same pattern as the other example docs.\r\n\r\nNOTE:\r\n\r\n* This does not work! There is an exception due to #355 . The docs have a note to this effect. When the bug is fixed we'll have to revisit and retest the docs/code.\r\n* This hamishwillee dronecode key and api. The old version failed because droneshare now insists on a key with the correct format.\r\n* Even though this does not \"work\", it is a better example to have for DKPY2 for people to learn from. The old example would not work either due to the bad key!","created_at":"2015-10-21T04:15:48Z","updated_at":"2015-10-22T17:52:58Z","closed_at":"2015-10-22T17:52:58Z","merged_at":"2015-10-22T17:52:58Z","merge_commit_sha":"38583a756daa54b564fd3f3fb8c90f6cfb40dc82","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dronekit/dronekit-python/pulls/360/commits","review_comments_url":"https://api.github.com/repos/dronekit/dronekit-python/pulls/360/comments","review_comment_url":"https://api.github.com/repos/dronekit/dronekit-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dronekit/dronekit-python/issues/360/comments","statuses_url":"https://api.github.com/repos/dronekit/dronekit-python/statuses/e6e6ed296a9bf16640ea2786a490d709df76beea","head":{"label":"dronekit:hgw_flight_replay_example_docs","ref":"hgw_flight_replay_example_docs","sha":"e6e6ed296a9bf16640ea2786a490d709df76beea","user":{"login":"dronekit","id":12973369,"avatar_url":"https://avatars.githubusercontent.com/u/12973369?v=3","gravatar_id":"","url":"https://api.github.com/users/dronekit","html_url":"https://github.com/dronekit","followers_url":"https://api.github.com/users/dronekit/followers","following_url":"https://api.github.com/users/dronekit/following{/other_user}","gists_url":"https://api.github.com/users/dronekit/gists{/gist_id}","starred_url":"https://api.github.com/users/dronekit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dronekit/subscriptions","organizations_url":"https://api.github.com/users/dronekit/orgs","repos_url":"https://api.github.com/users/dronekit/repos","events_url":"https://api.github.com/users/dronekit/events{/privacy}","received_events_url":"https://api.github.com/users/dronekit/received_events","type":"Organization","site_admin":false},"repo":{"id":18188537,"name":"dronekit-python","full_name":"dronekit/dronekit-python","owner":{"login":"dronekit","id":12973369,"avatar_url":"https://avatars.githubusercontent.com/u/12973369?v=3","gravatar_id":"","url":"https://api.github.com/users/dronekit","html_url":"https://github.com/dronekit","followers_url":"https://api.github.com/users/dronekit/followers","following_url":"https://api.github.com/users/dronekit/following{/other_user}","gists_url":"https://api.github.com/users/dronekit/gists{/gist_id}","starred_url":"https://api.github.com/users/dronekit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dronekit/subscriptions","organizations_url":"https://api.github.com/users/dronekit/orgs","repos_url":"https://api.github.com/users/dronekit/repos","events_url":"https://api.github.com/users/dronekit/events{/privacy}","received_events_url":"https://api.github.com/users/dronekit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dronekit/dronekit-python","description":"DroneKit-Python library for communicating with Drones via MAVLink.","fork":false,"url":"https://api.github.com/repos/dronekit/dronekit-python","forks_url":"https://api.github.com/repos/dronekit/dronekit-python/forks","keys_url":"https://api.github.com/repos/dronekit/dronekit-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dronekit/dronekit-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dronekit/dronekit-python/teams","hooks_url":"https://api.github.com/repos/dronekit/dronekit-python/hooks","issue_events_url":"https://api.github.com/repos/dronekit/dronekit-python/issues/events{/number}","events_url":"https://api.github.com/repos/dronekit/dronekit-python/events","assignees_url":"https://api.github.com/repos/dronekit/dronekit-python/assignees{/user}","branches_url":"https://api.github.com/repos/dronekit/dronekit-python/branches{/branch}","tags_url":"https://api.github.com/repos/dronekit/dronekit-python/tags","blobs_url":"https://api.github.com/repos/dronekit/dronekit-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dronekit/dronekit-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dronekit/dronekit-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dronekit/dronekit-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dronekit/dronekit-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dronekit/dronekit-python/languages","stargazers_url":"https://api.github.com/repos/dronekit/dronekit-python/stargazers","contributors_url":"https://api.github.com/repos/dronekit/dronekit-python/contributors","subscribers_url":"https://api.github.com/repos/dronekit/dronekit-python/subscribers","subscription_url":"https://api.github.com/repos/dronekit/dronekit-python/subscription","commits_url":"https://api.github.com/repos/dronekit/dronekit-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dronekit/dronekit-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dronekit/dronekit-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dronekit/dronekit-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dronekit/dronekit-python/contents/{+path}","compare_url":"https://api.github.com/repos/dronekit/dronekit-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dronekit/dronekit-python/merges","archive_url":"https://api.github.com/repos/dronekit/dronekit-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dronekit/dronekit-python/downloads","issues_url":"https://api.github.com/repos/dronekit/dronekit-python/issues{/number}","pulls_url":"https://api.github.com/repos/dronekit/dronekit-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dronekit/dronekit-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dronekit/dronekit-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dronekit/dronekit-python/labels{/name}","releases_url":"https://api.github.com/repos/dronekit/dronekit-python/releases{/id}","created_at":"2014-03-27T19:28:36Z","updated_at":"2015-10-22T17:12:40Z","pushed_at":"2015-10-22T17:52:58Z","git_url":"git://github.com/dronekit/dronekit-python.git","ssh_url":"git@github.com:dronekit/dronekit-python.git","clone_url":"https://github.com/dronekit/dronekit-python.git","svn_url":"https://github.com/dronekit/dronekit-python","homepage":"","size":5122,"stargazers_count":102,"watchers_count":102,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":117,"forks":75,"open_issues":117,"watchers":102,"default_branch":"master"}},"base":{"label":"dronekit:master","ref":"master","sha":"1e5bbb9f4ccb7853a09a7407b576e8c1c68af2b3","user":{"login":"dronekit","id":12973369,"avatar_url":"https://avatars.githubusercontent.com/u/12973369?v=3","gravatar_id":"","url":"https://api.github.com/users/dronekit","html_url":"https://github.com/dronekit","followers_url":"https://api.github.com/users/dronekit/followers","following_url":"https://api.github.com/users/dronekit/following{/other_user}","gists_url":"https://api.github.com/users/dronekit/gists{/gist_id}","starred_url":"https://api.github.com/users/dronekit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dronekit/subscriptions","organizations_url":"https://api.github.com/users/dronekit/orgs","repos_url":"https://api.github.com/users/dronekit/repos","events_url":"https://api.github.com/users/dronekit/events{/privacy}","received_events_url":"https://api.github.com/users/dronekit/received_events","type":"Organization","site_admin":false},"repo":{"id":18188537,"name":"dronekit-python","full_name":"dronekit/dronekit-python","owner":{"login":"dronekit","id":12973369,"avatar_url":"https://avatars.githubusercontent.com/u/12973369?v=3","gravatar_id":"","url":"https://api.github.com/users/dronekit","html_url":"https://github.com/dronekit","followers_url":"https://api.github.com/users/dronekit/followers","following_url":"https://api.github.com/users/dronekit/following{/other_user}","gists_url":"https://api.github.com/users/dronekit/gists{/gist_id}","starred_url":"https://api.github.com/users/dronekit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dronekit/subscriptions","organizations_url":"https://api.github.com/users/dronekit/orgs","repos_url":"https://api.github.com/users/dronekit/repos","events_url":"https://api.github.com/users/dronekit/events{/privacy}","received_events_url":"https://api.github.com/users/dronekit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dronekit/dronekit-python","description":"DroneKit-Python library for communicating with Drones via MAVLink.","fork":false,"url":"https://api.github.com/repos/dronekit/dronekit-python","forks_url":"https://api.github.com/repos/dronekit/dronekit-python/forks","keys_url":"https://api.github.com/repos/dronekit/dronekit-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dronekit/dronekit-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dronekit/dronekit-python/teams","hooks_url":"https://api.github.com/repos/dronekit/dronekit-python/hooks","issue_events_url":"https://api.github.com/repos/dronekit/dronekit-python/issues/events{/number}","events_url":"https://api.github.com/repos/dronekit/dronekit-python/events","assignees_url":"https://api.github.com/repos/dronekit/dronekit-python/assignees{/user}","branches_url":"https://api.github.com/repos/dronekit/dronekit-python/branches{/branch}","tags_url":"https://api.github.com/repos/dronekit/dronekit-python/tags","blobs_url":"https://api.github.com/repos/dronekit/dronekit-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dronekit/dronekit-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dronekit/dronekit-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dronekit/dronekit-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dronekit/dronekit-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dronekit/dronekit-python/languages","stargazers_url":"https://api.github.com/repos/dronekit/dronekit-python/stargazers","contributors_url":"https://api.github.com/repos/dronekit/dronekit-python/contributors","subscribers_url":"https://api.github.com/repos/dronekit/dronekit-python/subscribers","subscription_url":"https://api.github.com/repos/dronekit/dronekit-python/subscription","commits_url":"https://api.github.com/repos/dronekit/dronekit-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dronekit/dronekit-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dronekit/dronekit-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dronekit/dronekit-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dronekit/dronekit-python/contents/{+path}","compare_url":"https://api.github.com/repos/dronekit/dronekit-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dronekit/dronekit-python/merges","archive_url":"https://api.github.com/repos/dronekit/dronekit-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dronekit/dronekit-python/downloads","issues_url":"https://api.github.com/repos/dronekit/dronekit-python/issues{/number}","pulls_url":"https://api.github.com/repos/dronekit/dronekit-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dronekit/dronekit-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dronekit/dronekit-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dronekit/dronekit-python/labels{/name}","releases_url":"https://api.github.com/repos/dronekit/dronekit-python/releases{/id}","created_at":"2014-03-27T19:28:36Z","updated_at":"2015-10-22T17:12:40Z","pushed_at":"2015-10-22T17:52:58Z","git_url":"git://github.com/dronekit/dronekit-python.git","ssh_url":"git@github.com:dronekit/dronekit-python.git","clone_url":"https://github.com/dronekit/dronekit-python.git","svn_url":"https://github.com/dronekit/dronekit-python","homepage":"","size":5122,"stargazers_count":102,"watchers_count":102,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":117,"forks":75,"open_issues":117,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dronekit/dronekit-python/pulls/360"},"html":{"href":"https://github.com/dronekit/dronekit-python/pull/360"},"issue":{"href":"https://api.github.com/repos/dronekit/dronekit-python/issues/360"},"comments":{"href":"https://api.github.com/repos/dronekit/dronekit-python/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/dronekit/dronekit-python/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/dronekit/dronekit-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dronekit/dronekit-python/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/dronekit/dronekit-python/statuses/e6e6ed296a9bf16640ea2786a490d709df76beea"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tcr3dr","id":12703357,"avatar_url":"https://avatars.githubusercontent.com/u/12703357?v=3","gravatar_id":"","url":"https://api.github.com/users/tcr3dr","html_url":"https://github.com/tcr3dr","followers_url":"https://api.github.com/users/tcr3dr/followers","following_url":"https://api.github.com/users/tcr3dr/following{/other_user}","gists_url":"https://api.github.com/users/tcr3dr/gists{/gist_id}","starred_url":"https://api.github.com/users/tcr3dr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcr3dr/subscriptions","organizations_url":"https://api.github.com/users/tcr3dr/orgs","repos_url":"https://api.github.com/users/tcr3dr/repos","events_url":"https://api.github.com/users/tcr3dr/events{/privacy}","received_events_url":"https://api.github.com/users/tcr3dr/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"commits":2,"additions":132,"deletions":67,"changed_files":2}}