{"push_id":864362344,"size":7,"distinct_size":7,"ref":"refs/heads/master","head":"70f61c3c74db30eca1bb4572cca1b50d2a9566b2","before":"314345bfa4dc9466d0539cc6052e85f5aadf7693","commits":[{"sha":"7e26c554be106b2888f44bf92746e5fc7f6d819f","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Make SmartAnswer::I18nRenderer#value_for_interpolation private\n\nI want to be able to change the `SmartAnswer::QuestionPresenter` to use the\n`SmartAnswer::ErbRenderer` and so anything I can do to reduce the dependencies\non the `I18nRenderer` will make this easier.\n\nThis commit introduces a little duplication in the question presenter\nsub-classes. I plan to fix that in a later commit.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/7e26c554be106b2888f44bf92746e5fc7f6d819f"},{"sha":"761982750a08b7f7fe6ec8428f0a2d2afca0f4c6","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Avoid relying on I18nRenderer for #number_with_delimiter\n\nI want to be able to change the `SmartAnswer::QuestionPresenter` to use the\n`SmartAnswer::ErbRenderer` and so anything I can do to reduce the dependencies\non the `I18nRenderer` will make this easier.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/761982750a08b7f7fe6ec8428f0a2d2afca0f4c6"},{"sha":"346998703111490f6dd8c5f89a474f413445829a","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Rename OutcomeHelper to FormattingHelper\n\nI want to use this helper for formatting values in questions, so I've made the\nname more generic.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/346998703111490f6dd8c5f89a474f413445829a"},{"sha":"cc8debb7a0135d0b7f70b15d98737c2cfa089606","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Make SmartAnswer::FormattingHelper more self-contained\n\nThe `SmartAnswer::FormattingHelper` had an implicit dependency on\n`ActionView::Helpers::NumberHelper`.\n\nThis helper is currently only being used in the `SmartAnswer::ErbRenderer`\nwhich includes it and the `ActionView::Helpers::NumberHelper` into the view\nobject, thus satisfying the implicit dependency.\n\nI want to use this helper from within some of the sub-classes of\n`QuestionPresenter`. Including `ActionView::Helpers::NumberHelper` explicitly\nshould make this easier.\n\nI've left `ActionView::Helpers::NumberHelper` being included into the view,\nbecause there is code in some templates which use methods on this module\ndirectly i.e. not via `SmartAnswer::FormattingHelper`.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/cc8debb7a0135d0b7f70b15d98737c2cfa089606"},{"sha":"ee5dbdbb19b520221ff5336e906916116ce02655","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"DRY up formatting code in MoneyQuestionPresenter#response_label","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/ee5dbdbb19b520221ff5336e906916116ce02655"},{"sha":"1395259651d331e3b9a397bb909259d7174020a5","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Extract salary formatting into FormattingHelper#format_salary\n\nThis feels as if it makes the code a bit more consistent i.e. all formatting is\neither in `SmartAnswer::I18nRenderer#value_for_interpolation` or in methods on\n`SmartAnswer::FormattingHelper`.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/1395259651d331e3b9a397bb909259d7174020a5"},{"sha":"70f61c3c74db30eca1bb4572cca1b50d2a9566b2","author":{"email":"474ba67bdb289c6263b36dfd8a7bed6c85b04943@floehopper.org","name":"James Mead"},"message":"Merge pull request #2076 from alphagov/reduce-dependencies-on-i18n-renderer\n\nReduce dependencies on I18nRenderer","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/70f61c3c74db30eca1bb4572cca1b50d2a9566b2"}]}