{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/38358545","id":38358545,"diff_hunk":"@@ -31,16 +31,21 @@\n  *\n  */\n \n-#ifndef CENSUS_RPC_STAT_ID_H\n-#define CENSUS_RPC_STAT_ID_H\n+#ifndef CENSUS_RPC_METRIC_ID_H\n+#define CENSUS_RPC_METRIC_ID_H\n \n-/* Stats ID's used for RPC measurements. */\n-#define CENSUS_INVALID_STAT_ID 0     /* ID 0 is always invalid */\n-#define CENSUS_RPC_CLIENT_REQUESTS 1 /* Count of client requests sent. */\n-#define CENSUS_RPC_SERVER_REQUESTS 2 /* Count of server requests sent. */\n-#define CENSUS_RPC_CLIENT_ERRORS 3   /* Client error counts. */\n-#define CENSUS_RPC_SERVER_ERRORS 4   /* Server error counts. */\n-#define CENSUS_RPC_CLIENT_LATENCY 5  /* Client side request latency. */\n-#define CENSUS_RPC_SERVER_LATENCY 6  /* Server side request latency. */\n+/* Metric ID's used for RPC measurements. */\n+/* Count of client requests sent. */","path":"src/core/census/rpc_metric_id.h","position":18,"original_position":18,"commit_id":"aafe9725b058d3710209bf0c95911928428eb2f2","original_commit_id":"e41d9d5f930bb1ec3fc22a92c6f3604ca7e74575","user":{"login":"maxwell-demon","id":10470441,"avatar_url":"https://avatars.githubusercontent.com/u/10470441?v=3","gravatar_id":"","url":"https://api.github.com/users/maxwell-demon","html_url":"https://github.com/maxwell-demon","followers_url":"https://api.github.com/users/maxwell-demon/followers","following_url":"https://api.github.com/users/maxwell-demon/following{/other_user}","gists_url":"https://api.github.com/users/maxwell-demon/gists{/gist_id}","starred_url":"https://api.github.com/users/maxwell-demon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxwell-demon/subscriptions","organizations_url":"https://api.github.com/users/maxwell-demon/orgs","repos_url":"https://api.github.com/users/maxwell-demon/repos","events_url":"https://api.github.com/users/maxwell-demon/events{/privacy}","received_events_url":"https://api.github.com/users/maxwell-demon/received_events","type":"User","site_admin":false},"body":"Consider keeping CENSUS_INVALID_METRIC_ID.","created_at":"2015-08-31T20:57:25Z","updated_at":"2015-08-31T20:57:25Z","html_url":"https://github.com/grpc/grpc/pull/3107#discussion_r38358545","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/3107","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/38358545"},"html":{"href":"https://github.com/grpc/grpc/pull/3107#discussion_r38358545"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/3107"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/3107","id":43561781,"html_url":"https://github.com/grpc/grpc/pull/3107","diff_url":"https://github.com/grpc/grpc/pull/3107.diff","patch_url":"https://github.com/grpc/grpc/pull/3107.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/3107","number":3107,"state":"open","locked":false,"title":"API for: defining view and aggregations, associating them with metrics, and retrieving data","user":{"login":"a-veitch","id":10503072,"avatar_url":"https://avatars.githubusercontent.com/u/10503072?v=3","gravatar_id":"","url":"https://api.github.com/users/a-veitch","html_url":"https://github.com/a-veitch","followers_url":"https://api.github.com/users/a-veitch/followers","following_url":"https://api.github.com/users/a-veitch/following{/other_user}","gists_url":"https://api.github.com/users/a-veitch/gists{/gist_id}","starred_url":"https://api.github.com/users/a-veitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-veitch/subscriptions","organizations_url":"https://api.github.com/users/a-veitch/orgs","repos_url":"https://api.github.com/users/a-veitch/repos","events_url":"https://api.github.com/users/a-veitch/events{/privacy}","received_events_url":"https://api.github.com/users/a-veitch/received_events","type":"User","site_admin":false},"body":"Data is returned from all aggregations as a binary blob. The type of data is transparent to the API (so we can define/redefine these with some amount of flexibility).\r\n\r\nAlso did some renaming to bring in metric nomenclature.","created_at":"2015-08-27T20:18:22Z","updated_at":"2015-08-31T20:57:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66b874ef1f7de0425b42d03490c3d094e69a72ef","assignee":{"login":"maxwell-demon","id":10470441,"avatar_url":"https://avatars.githubusercontent.com/u/10470441?v=3","gravatar_id":"","url":"https://api.github.com/users/maxwell-demon","html_url":"https://github.com/maxwell-demon","followers_url":"https://api.github.com/users/maxwell-demon/followers","following_url":"https://api.github.com/users/maxwell-demon/following{/other_user}","gists_url":"https://api.github.com/users/maxwell-demon/gists{/gist_id}","starred_url":"https://api.github.com/users/maxwell-demon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxwell-demon/subscriptions","organizations_url":"https://api.github.com/users/maxwell-demon/orgs","repos_url":"https://api.github.com/users/maxwell-demon/repos","events_url":"https://api.github.com/users/maxwell-demon/events{/privacy}","received_events_url":"https://api.github.com/users/maxwell-demon/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/grpc/grpc/milestones/25","html_url":"https://github.com/grpc/grpc/milestones/Beta","labels_url":"https://api.github.com/repos/grpc/grpc/milestones/25/labels","id":1134869,"number":25,"title":"Beta","description":"","creator":{"login":"ctiller","id":10120821,"avatar_url":"https://avatars.githubusercontent.com/u/10120821?v=3","gravatar_id":"","url":"https://api.github.com/users/ctiller","html_url":"https://github.com/ctiller","followers_url":"https://api.github.com/users/ctiller/followers","following_url":"https://api.github.com/users/ctiller/following{/other_user}","gists_url":"https://api.github.com/users/ctiller/gists{/gist_id}","starred_url":"https://api.github.com/users/ctiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctiller/subscriptions","organizations_url":"https://api.github.com/users/ctiller/orgs","repos_url":"https://api.github.com/users/ctiller/repos","events_url":"https://api.github.com/users/ctiller/events{/privacy}","received_events_url":"https://api.github.com/users/ctiller/received_events","type":"User","site_admin":false},"open_issues":68,"closed_issues":501,"state":"open","created_at":"2015-05-26T22:29:20Z","updated_at":"2015-08-31T20:52:03Z","due_on":"2015-08-29T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/3107/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/3107/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/3107/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/aafe9725b058d3710209bf0c95911928428eb2f2","head":{"label":"a-veitch:view_api","ref":"view_api","sha":"aafe9725b058d3710209bf0c95911928428eb2f2","user":{"login":"a-veitch","id":10503072,"avatar_url":"https://avatars.githubusercontent.com/u/10503072?v=3","gravatar_id":"","url":"https://api.github.com/users/a-veitch","html_url":"https://github.com/a-veitch","followers_url":"https://api.github.com/users/a-veitch/followers","following_url":"https://api.github.com/users/a-veitch/following{/other_user}","gists_url":"https://api.github.com/users/a-veitch/gists{/gist_id}","starred_url":"https://api.github.com/users/a-veitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-veitch/subscriptions","organizations_url":"https://api.github.com/users/a-veitch/orgs","repos_url":"https://api.github.com/users/a-veitch/repos","events_url":"https://api.github.com/users/a-veitch/events{/privacy}","received_events_url":"https://api.github.com/users/a-veitch/received_events","type":"User","site_admin":false},"repo":{"id":32104318,"name":"grpc","full_name":"a-veitch/grpc","owner":{"login":"a-veitch","id":10503072,"avatar_url":"https://avatars.githubusercontent.com/u/10503072?v=3","gravatar_id":"","url":"https://api.github.com/users/a-veitch","html_url":"https://github.com/a-veitch","followers_url":"https://api.github.com/users/a-veitch/followers","following_url":"https://api.github.com/users/a-veitch/following{/other_user}","gists_url":"https://api.github.com/users/a-veitch/gists{/gist_id}","starred_url":"https://api.github.com/users/a-veitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-veitch/subscriptions","organizations_url":"https://api.github.com/users/a-veitch/orgs","repos_url":"https://api.github.com/users/a-veitch/repos","events_url":"https://api.github.com/users/a-veitch/events{/privacy}","received_events_url":"https://api.github.com/users/a-veitch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-veitch/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/a-veitch/grpc","forks_url":"https://api.github.com/repos/a-veitch/grpc/forks","keys_url":"https://api.github.com/repos/a-veitch/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-veitch/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-veitch/grpc/teams","hooks_url":"https://api.github.com/repos/a-veitch/grpc/hooks","issue_events_url":"https://api.github.com/repos/a-veitch/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/a-veitch/grpc/events","assignees_url":"https://api.github.com/repos/a-veitch/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/a-veitch/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/a-veitch/grpc/tags","blobs_url":"https://api.github.com/repos/a-veitch/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-veitch/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-veitch/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-veitch/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-veitch/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/a-veitch/grpc/languages","stargazers_url":"https://api.github.com/repos/a-veitch/grpc/stargazers","contributors_url":"https://api.github.com/repos/a-veitch/grpc/contributors","subscribers_url":"https://api.github.com/repos/a-veitch/grpc/subscribers","subscription_url":"https://api.github.com/repos/a-veitch/grpc/subscription","commits_url":"https://api.github.com/repos/a-veitch/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-veitch/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-veitch/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-veitch/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-veitch/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/a-veitch/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-veitch/grpc/merges","archive_url":"https://api.github.com/repos/a-veitch/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-veitch/grpc/downloads","issues_url":"https://api.github.com/repos/a-veitch/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/a-veitch/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/a-veitch/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/a-veitch/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-veitch/grpc/labels{/name}","releases_url":"https://api.github.com/repos/a-veitch/grpc/releases{/id}","created_at":"2015-03-12T21:42:01Z","updated_at":"2015-03-12T21:42:05Z","pushed_at":"2015-08-31T20:15:27Z","git_url":"git://github.com/a-veitch/grpc.git","ssh_url":"git@github.com:a-veitch/grpc.git","clone_url":"https://github.com/a-veitch/grpc.git","svn_url":"https://github.com/a-veitch/grpc","homepage":"","size":47315,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"2641c045a32cd519df5aae8b7419fe4d1c7c127a","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","created_at":"2014-12-08T18:58:53Z","updated_at":"2015-08-31T20:48:07Z","pushed_at":"2015-08-31T20:52:04Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":168075,"stargazers_count":3147,"watchers_count":3147,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":466,"mirror_url":null,"open_issues_count":367,"forks":466,"open_issues":367,"watchers":3147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/3107"},"html":{"href":"https://github.com/grpc/grpc/pull/3107"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/3107"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/3107/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/3107/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/3107/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/aafe9725b058d3710209bf0c95911928428eb2f2"}}}}