{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/comments/44896153","id":44896153,"diff_hunk":"@@ -411,14 +374,21 @@\n           event.stopPropagation();\n         }\n \n-        keyBindings.forEach(function(keyBinding) {\n-          var keyCombo = keyBinding[0];\n-          var handlerName = keyBinding[1];\n+        // if event has been already prevented, don't do anything\n+        if (event.defaultPrevented) {","path":"iron-a11y-keys-behavior.html","position":178,"original_position":178,"commit_id":"dc54677e3461b681c613abcf2979959262e43ab3","original_commit_id":"dc54677e3461b681c613abcf2979959262e43ab3","user":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"body":"It's possible that a handler of the `keyCombo` event may wish to prevent the default behavior of the originating `keyboardEvent`.","created_at":"2015-11-16T08:03:25Z","updated_at":"2015-11-16T08:03:25Z","html_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/23#discussion_r44896153","pull_request_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/comments/44896153"},"html":{"href":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/23#discussion_r44896153"},"pull_request":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/23","id":50204519,"html_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/23","diff_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/23.diff","patch_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/23.patch","issue_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/23","number":23,"state":"open","locked":false,"title":"support special symbols","user":{"login":"valdrinkoshi","id":6173664,"avatar_url":"https://avatars.githubusercontent.com/u/6173664?v=3","gravatar_id":"","url":"https://api.github.com/users/valdrinkoshi","html_url":"https://github.com/valdrinkoshi","followers_url":"https://api.github.com/users/valdrinkoshi/followers","following_url":"https://api.github.com/users/valdrinkoshi/following{/other_user}","gists_url":"https://api.github.com/users/valdrinkoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/valdrinkoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valdrinkoshi/subscriptions","organizations_url":"https://api.github.com/users/valdrinkoshi/orgs","repos_url":"https://api.github.com/users/valdrinkoshi/repos","events_url":"https://api.github.com/users/valdrinkoshi/events{/privacy}","received_events_url":"https://api.github.com/users/valdrinkoshi/received_events","type":"User","site_admin":false},"body":"Fixes #12 by adding support for special symbols\r\n\r\n- [x] Handle special characters like `@ # !` etc...  by relying on `event.key` (ff/ie) and `event.keyIdentifier` + `String.fromCharCode` (chrome/safari).\r\n- [x] Special handling for `+` and `:` since they're used as separators for combo keys.\r\n- [x] Allow shift/ctrl/meta key combination usage by default (e.g. \"a pressed!\" triggered if user presses or `a` or `shift+a`) \r\n- [x] unit tests for modifier keys combination by default\r\n- [x] unit tests for these special characters: space ( ), plus (+), colon (:)\r\n\r\nLimitations: \r\n- listeners to combos like `alt+@` are not supported (since it depends on the keyboard configuration)\r\n- on browsers that don't support [`KeyboardEvent.key`](https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key) (e.g. chrome/safari), all keyboard events that have `keyIdentifier = \"Unidentified\"` won't be recognized; e.g. on a french keyboard, this key combination used for typing `@` has `keyIdentifier = \"Unidentified\"`\r\n<img width=\"636\" alt=\"screen shot 2015-11-13 at 10 59 17 am\" src=\"https://cloud.githubusercontent.com/assets/6173664/11154839/99e1520c-89f6-11e5-97fa-172ed69bcb05.png\">","created_at":"2015-11-10T01:51:32Z","updated_at":"2015-11-16T08:03:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e8bd660ee421f4409f247f647d2710af2c8d1f4","assignee":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/23/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/23/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/23/comments","statuses_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/statuses/dc54677e3461b681c613abcf2979959262e43ab3","head":{"label":"PolymerElements:issue-12","ref":"issue-12","sha":"dc54677e3461b681c613abcf2979959262e43ab3","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":35118041,"name":"iron-a11y-keys-behavior","full_name":"PolymerElements/iron-a11y-keys-behavior","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior","description":"A behavior that enables keybindings for greater a11y","fork":false,"url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior","forks_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/forks","keys_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/teams","hooks_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/events","assignees_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/tags","blobs_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/subscription","commits_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/merges","archive_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/downloads","issues_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/releases{/id}","created_at":"2015-05-05T18:53:47Z","updated_at":"2015-06-04T16:24:11Z","pushed_at":"2015-11-12T21:55:43Z","git_url":"git://github.com/PolymerElements/iron-a11y-keys-behavior.git","ssh_url":"git@github.com:PolymerElements/iron-a11y-keys-behavior.git","clone_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior.git","svn_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior","homepage":"","size":1741,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"fcfb0dad8713599a39908260a8293d0907885e37","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":35118041,"name":"iron-a11y-keys-behavior","full_name":"PolymerElements/iron-a11y-keys-behavior","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior","description":"A behavior that enables keybindings for greater a11y","fork":false,"url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior","forks_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/forks","keys_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/teams","hooks_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/events","assignees_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/tags","blobs_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/subscription","commits_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/merges","archive_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/downloads","issues_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/releases{/id}","created_at":"2015-05-05T18:53:47Z","updated_at":"2015-06-04T16:24:11Z","pushed_at":"2015-11-12T21:55:43Z","git_url":"git://github.com/PolymerElements/iron-a11y-keys-behavior.git","ssh_url":"git@github.com:PolymerElements/iron-a11y-keys-behavior.git","clone_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior.git","svn_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior","homepage":"","size":1741,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/23"},"html":{"href":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/23"},"issue":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/23"},"comments":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/statuses/dc54677e3461b681c613abcf2979959262e43ab3"}}}}