{"action":"created","comment":{"url":"https://api.github.com/repos/apache/tajo/pulls/comments/47456988","id":47456988,"diff_hunk":"@@ -177,33 +177,32 @@ protected AnalyzerAdapter(final int api, final String owner,\n             }\n         }\n         Type[] types = Type.getArgumentTypes(desc);\n-        for (int i = 0; i < types.length; ++i) {\n-            Type type = types[i];\n+        for (Type type : types) {\n             switch (type.getSort()) {\n-            case Type.BOOLEAN:\n-            case Type.CHAR:\n-            case Type.BYTE:\n-            case Type.SHORT:\n-            case Type.INT:\n-                locals.add(Opcodes.INTEGER);\n-                break;\n-            case Type.FLOAT:\n-                locals.add(Opcodes.FLOAT);\n-                break;\n-            case Type.LONG:\n-                locals.add(Opcodes.LONG);\n-                locals.add(Opcodes.TOP);\n-                break;\n-            case Type.DOUBLE:\n-                locals.add(Opcodes.DOUBLE);\n-                locals.add(Opcodes.TOP);\n-                break;\n-            case Type.ARRAY:\n-                locals.add(types[i].getDescriptor());\n-                break;\n-            // case Type.OBJECT:\n-            default:\n-                locals.add(types[i].getInternalName());\n+                case Type.BOOLEAN:","path":"tajo-thirdparty/asm/src/main/java/org/apache/tajo/org/objectweb/asm/commons/AnalyzerAdapter.java","position":32,"original_position":32,"commit_id":"1a3448b415441a7546130a15dac1a87240cf4340","original_commit_id":"1a3448b415441a7546130a15dac1a87240cf4340","user":{"login":"jihoonson","id":2322288,"avatar_url":"https://avatars.githubusercontent.com/u/2322288?v=3","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"body":"Please remove unnecessary change.","created_at":"2015-12-14T02:25:06Z","updated_at":"2015-12-14T02:25:06Z","html_url":"https://github.com/apache/tajo/pull/890#discussion_r47456988","pull_request_url":"https://api.github.com/repos/apache/tajo/pulls/890","_links":{"self":{"href":"https://api.github.com/repos/apache/tajo/pulls/comments/47456988"},"html":{"href":"https://github.com/apache/tajo/pull/890#discussion_r47456988"},"pull_request":{"href":"https://api.github.com/repos/apache/tajo/pulls/890"}}},"pull_request":{"url":"https://api.github.com/repos/apache/tajo/pulls/890","id":52081940,"html_url":"https://github.com/apache/tajo/pull/890","diff_url":"https://github.com/apache/tajo/pull/890.diff","patch_url":"https://github.com/apache/tajo/pull/890.patch","issue_url":"https://api.github.com/repos/apache/tajo/issues/890","number":890,"state":"open","locked":false,"title":"TAJO-1971: Replace 'for' loop with 'foreach'","user":{"login":"dkhwangbo","id":13585249,"avatar_url":"https://avatars.githubusercontent.com/u/13585249?v=3","gravatar_id":"","url":"https://api.github.com/users/dkhwangbo","html_url":"https://github.com/dkhwangbo","followers_url":"https://api.github.com/users/dkhwangbo/followers","following_url":"https://api.github.com/users/dkhwangbo/following{/other_user}","gists_url":"https://api.github.com/users/dkhwangbo/gists{/gist_id}","starred_url":"https://api.github.com/users/dkhwangbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkhwangbo/subscriptions","organizations_url":"https://api.github.com/users/dkhwangbo/orgs","repos_url":"https://api.github.com/users/dkhwangbo/repos","events_url":"https://api.github.com/users/dkhwangbo/events{/privacy}","received_events_url":"https://api.github.com/users/dkhwangbo/received_events","type":"User","site_admin":false},"body":"Reports for loops which iterate over collections or arrays, and can be replaced with the foreach iteration syntax, available in Java 5 and newer, to get the improvement of readability and so on.","created_at":"2015-11-30T03:25:27Z","updated_at":"2015-12-14T02:25:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5b5b07daa12b69292e5d3900e91ed06da868a79","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/tajo/pulls/890/commits","review_comments_url":"https://api.github.com/repos/apache/tajo/pulls/890/comments","review_comment_url":"https://api.github.com/repos/apache/tajo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/tajo/issues/890/comments","statuses_url":"https://api.github.com/repos/apache/tajo/statuses/1a3448b415441a7546130a15dac1a87240cf4340","head":{"label":"dkhwangbo:TAJO-1971_2","ref":"TAJO-1971_2","sha":"1a3448b415441a7546130a15dac1a87240cf4340","user":{"login":"dkhwangbo","id":13585249,"avatar_url":"https://avatars.githubusercontent.com/u/13585249?v=3","gravatar_id":"","url":"https://api.github.com/users/dkhwangbo","html_url":"https://github.com/dkhwangbo","followers_url":"https://api.github.com/users/dkhwangbo/followers","following_url":"https://api.github.com/users/dkhwangbo/following{/other_user}","gists_url":"https://api.github.com/users/dkhwangbo/gists{/gist_id}","starred_url":"https://api.github.com/users/dkhwangbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkhwangbo/subscriptions","organizations_url":"https://api.github.com/users/dkhwangbo/orgs","repos_url":"https://api.github.com/users/dkhwangbo/repos","events_url":"https://api.github.com/users/dkhwangbo/events{/privacy}","received_events_url":"https://api.github.com/users/dkhwangbo/received_events","type":"User","site_admin":false},"repo":{"id":42637482,"name":"tajo","full_name":"dkhwangbo/tajo","owner":{"login":"dkhwangbo","id":13585249,"avatar_url":"https://avatars.githubusercontent.com/u/13585249?v=3","gravatar_id":"","url":"https://api.github.com/users/dkhwangbo","html_url":"https://github.com/dkhwangbo","followers_url":"https://api.github.com/users/dkhwangbo/followers","following_url":"https://api.github.com/users/dkhwangbo/following{/other_user}","gists_url":"https://api.github.com/users/dkhwangbo/gists{/gist_id}","starred_url":"https://api.github.com/users/dkhwangbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkhwangbo/subscriptions","organizations_url":"https://api.github.com/users/dkhwangbo/orgs","repos_url":"https://api.github.com/users/dkhwangbo/repos","events_url":"https://api.github.com/users/dkhwangbo/events{/privacy}","received_events_url":"https://api.github.com/users/dkhwangbo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkhwangbo/tajo","description":"Mirror of Apache Tajo","fork":true,"url":"https://api.github.com/repos/dkhwangbo/tajo","forks_url":"https://api.github.com/repos/dkhwangbo/tajo/forks","keys_url":"https://api.github.com/repos/dkhwangbo/tajo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkhwangbo/tajo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkhwangbo/tajo/teams","hooks_url":"https://api.github.com/repos/dkhwangbo/tajo/hooks","issue_events_url":"https://api.github.com/repos/dkhwangbo/tajo/issues/events{/number}","events_url":"https://api.github.com/repos/dkhwangbo/tajo/events","assignees_url":"https://api.github.com/repos/dkhwangbo/tajo/assignees{/user}","branches_url":"https://api.github.com/repos/dkhwangbo/tajo/branches{/branch}","tags_url":"https://api.github.com/repos/dkhwangbo/tajo/tags","blobs_url":"https://api.github.com/repos/dkhwangbo/tajo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkhwangbo/tajo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkhwangbo/tajo/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkhwangbo/tajo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkhwangbo/tajo/statuses/{sha}","languages_url":"https://api.github.com/repos/dkhwangbo/tajo/languages","stargazers_url":"https://api.github.com/repos/dkhwangbo/tajo/stargazers","contributors_url":"https://api.github.com/repos/dkhwangbo/tajo/contributors","subscribers_url":"https://api.github.com/repos/dkhwangbo/tajo/subscribers","subscription_url":"https://api.github.com/repos/dkhwangbo/tajo/subscription","commits_url":"https://api.github.com/repos/dkhwangbo/tajo/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkhwangbo/tajo/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkhwangbo/tajo/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkhwangbo/tajo/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkhwangbo/tajo/contents/{+path}","compare_url":"https://api.github.com/repos/dkhwangbo/tajo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkhwangbo/tajo/merges","archive_url":"https://api.github.com/repos/dkhwangbo/tajo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkhwangbo/tajo/downloads","issues_url":"https://api.github.com/repos/dkhwangbo/tajo/issues{/number}","pulls_url":"https://api.github.com/repos/dkhwangbo/tajo/pulls{/number}","milestones_url":"https://api.github.com/repos/dkhwangbo/tajo/milestones{/number}","notifications_url":"https://api.github.com/repos/dkhwangbo/tajo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkhwangbo/tajo/labels{/name}","releases_url":"https://api.github.com/repos/dkhwangbo/tajo/releases{/id}","created_at":"2015-09-17T05:49:06Z","updated_at":"2015-09-17T05:49:17Z","pushed_at":"2015-12-11T09:14:54Z","git_url":"git://github.com/dkhwangbo/tajo.git","ssh_url":"git@github.com:dkhwangbo/tajo.git","clone_url":"https://github.com/dkhwangbo/tajo.git","svn_url":"https://github.com/dkhwangbo/tajo","homepage":null,"size":24706,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0ec2a890c73c79944fb6a0233226c00a0d0b06d1","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17971138,"name":"tajo","full_name":"apache/tajo","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tajo","description":"Mirror of Apache Tajo","fork":false,"url":"https://api.github.com/repos/apache/tajo","forks_url":"https://api.github.com/repos/apache/tajo/forks","keys_url":"https://api.github.com/repos/apache/tajo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tajo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tajo/teams","hooks_url":"https://api.github.com/repos/apache/tajo/hooks","issue_events_url":"https://api.github.com/repos/apache/tajo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tajo/events","assignees_url":"https://api.github.com/repos/apache/tajo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tajo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tajo/tags","blobs_url":"https://api.github.com/repos/apache/tajo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tajo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tajo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tajo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tajo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tajo/languages","stargazers_url":"https://api.github.com/repos/apache/tajo/stargazers","contributors_url":"https://api.github.com/repos/apache/tajo/contributors","subscribers_url":"https://api.github.com/repos/apache/tajo/subscribers","subscription_url":"https://api.github.com/repos/apache/tajo/subscription","commits_url":"https://api.github.com/repos/apache/tajo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tajo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tajo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tajo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tajo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tajo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tajo/merges","archive_url":"https://api.github.com/repos/apache/tajo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tajo/downloads","issues_url":"https://api.github.com/repos/apache/tajo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tajo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tajo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tajo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tajo/labels{/name}","releases_url":"https://api.github.com/repos/apache/tajo/releases{/id}","created_at":"2014-03-21T07:00:07Z","updated_at":"2015-12-11T03:28:10Z","pushed_at":"2015-12-13T23:47:10Z","git_url":"git://github.com/apache/tajo.git","ssh_url":"git@github.com:apache/tajo.git","clone_url":"https://github.com/apache/tajo.git","svn_url":"https://github.com/apache/tajo","homepage":null,"size":40852,"stargazers_count":75,"watchers_count":75,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":"git://git.apache.org/tajo.git","open_issues_count":41,"forks":79,"open_issues":41,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/tajo/pulls/890"},"html":{"href":"https://github.com/apache/tajo/pull/890"},"issue":{"href":"https://api.github.com/repos/apache/tajo/issues/890"},"comments":{"href":"https://api.github.com/repos/apache/tajo/issues/890/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/tajo/pulls/890/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/tajo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/tajo/pulls/890/commits"},"statuses":{"href":"https://api.github.com/repos/apache/tajo/statuses/1a3448b415441a7546130a15dac1a87240cf4340"}}}}