{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/440","labels_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/440/labels{/name}","comments_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/440/comments","events_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/440/events","html_url":"https://github.com/facebook/facebook-php-sdk-v4/issues/440","id":79061666,"number":440,"title":"[5.0][Proposal] Remove Collection class","user":{"login":"yguedidi","id":1480128,"avatar_url":"https://avatars.githubusercontent.com/u/1480128?v=3","gravatar_id":"","url":"https://api.github.com/users/yguedidi","html_url":"https://github.com/yguedidi","followers_url":"https://api.github.com/users/yguedidi/followers","following_url":"https://api.github.com/users/yguedidi/following{/other_user}","gists_url":"https://api.github.com/users/yguedidi/gists{/gist_id}","starred_url":"https://api.github.com/users/yguedidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yguedidi/subscriptions","organizations_url":"https://api.github.com/users/yguedidi/orgs","repos_url":"https://api.github.com/users/yguedidi/repos","events_url":"https://api.github.com/users/yguedidi/events{/privacy}","received_events_url":"https://api.github.com/users/yguedidi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-05-21T16:07:45Z","updated_at":"2015-05-21T21:59:52Z","closed_at":null,"body":"A node is not a collection, an edge is.\r\n\r\nNode:\r\n- Counting fields of a node don't makes sense\r\n- Traversing its fields too\r\n- (ArrayAccess or not is not part of this issue)\r\n\r\nEdge:\r\n- Counting number of nodes of an edge makes sense\r\n- Tranversing its nodes too\r\n- ArrayAcces too (don't be surprizied here, I'm not against ArrayAccess, here it's a legitimate usage IMO :) )\r\n\r\nI propose to \"move\" methods that have sense from Collection to GraphEdge and add missing ones to GraphNode"},"comment":{"url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/comments/104433844","html_url":"https://github.com/facebook/facebook-php-sdk-v4/issues/440#issuecomment-104433844","issue_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/440","id":104433844,"user":{"login":"yguedidi","id":1480128,"avatar_url":"https://avatars.githubusercontent.com/u/1480128?v=3","gravatar_id":"","url":"https://api.github.com/users/yguedidi","html_url":"https://github.com/yguedidi","followers_url":"https://api.github.com/users/yguedidi/followers","following_url":"https://api.github.com/users/yguedidi/following{/other_user}","gists_url":"https://api.github.com/users/yguedidi/gists{/gist_id}","starred_url":"https://api.github.com/users/yguedidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yguedidi/subscriptions","organizations_url":"https://api.github.com/users/yguedidi/orgs","repos_url":"https://api.github.com/users/yguedidi/repos","events_url":"https://api.github.com/users/yguedidi/events{/privacy}","received_events_url":"https://api.github.com/users/yguedidi/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T21:59:52Z","updated_at":"2015-05-21T21:59:52Z","body":"PR opened: #443 :)"}}