{"action":"created","comment":{"url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/comments/24658268","id":24658268,"diff_hunk":"@@ -388,22 +388,30 @@\n     end\n \n     context 'enabled with invalid puppet_binary' do\n+      let(:facts) { { :osfamily => 'Debian' } }\n       let(:params) { {:env => 'production',\n                       :symlink_puppet_binary => true,\n-                      :puppet_binary => 'true',\n+                      :puppet_binary => 'invalid/path',\n                       :symlink_puppet_binary_target => '/bar' } }\n-      it do\n-        expect { should }.to raise_error(Puppet::Error)\n+\n+      it 'should fail' do\n+        expect {\n+          should contain_class('puppet::master')\n+        }.to raise_error(Puppet::Error,/^\"invalid\\/path\" is not an absolute path./)\n       end\n     end\n \n     context 'enabled with invalid symlink_puppet_binary_target' do\n+      let(:facts) { { :osfamily => 'Debian' } }\n       let(:params) { {:env => 'production',\n                       :symlink_puppet_binary => true,\n                       :puppet_binary => '/foo/bar',\n-                      :symlink_puppet_binary_target => 'undef' } }","path":"spec/classes/agent_spec.rb","position":43,"original_position":43,"commit_id":"91639dda1652b527ee150f33d1e5a732b7274b49","original_commit_id":"91639dda1652b527ee150f33d1e5a732b7274b49","user":{"login":"ghoneycutt","id":313891,"avatar_url":"https://avatars.githubusercontent.com/u/313891?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"body":"And here\r\n\r\n@Phil-Friderici @anders-larsson ","created_at":"2015-02-13T11:24:13Z","updated_at":"2015-02-13T11:24:13Z","html_url":"https://github.com/ghoneycutt/puppet-module-puppet/pull/96#discussion_r24658268","pull_request_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/comments/24658268"},"html":{"href":"https://github.com/ghoneycutt/puppet-module-puppet/pull/96#discussion_r24658268"},"pull_request":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/96","id":29253461,"html_url":"https://github.com/ghoneycutt/puppet-module-puppet/pull/96","diff_url":"https://github.com/ghoneycutt/puppet-module-puppet/pull/96.diff","patch_url":"https://github.com/ghoneycutt/puppet-module-puppet/pull/96.patch","issue_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/issues/96","number":96,"state":"open","locked":false,"title":"Improve spec tests for maintenance class","user":{"login":"ghoneycutt","id":313891,"avatar_url":"https://avatars.githubusercontent.com/u/313891?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-13T10:18:39Z","updated_at":"2015-02-13T11:24:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a2d1fbcb0a478047e9a9c7995413673820260ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/96/commits","review_comments_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/96/comments","review_comment_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/issues/96/comments","statuses_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/statuses/91639dda1652b527ee150f33d1e5a732b7274b49","head":{"label":"ghoneycutt:wtf_travis","ref":"wtf_travis","sha":"91639dda1652b527ee150f33d1e5a732b7274b49","user":{"login":"ghoneycutt","id":313891,"avatar_url":"https://avatars.githubusercontent.com/u/313891?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"repo":{"id":773617,"name":"puppet-module-puppet","full_name":"ghoneycutt/puppet-module-puppet","owner":{"login":"ghoneycutt","id":313891,"avatar_url":"https://avatars.githubusercontent.com/u/313891?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghoneycutt/puppet-module-puppet","description":"Puppet Module for managing Puppet","fork":false,"url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet","forks_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/forks","keys_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/teams","hooks_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/hooks","issue_events_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/events","assignees_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/tags","blobs_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/languages","stargazers_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/stargazers","contributors_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/contributors","subscribers_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/subscribers","subscription_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/subscription","commits_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/merges","archive_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/downloads","issues_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/labels{/name}","releases_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/releases{/id}","created_at":"2010-07-14T00:13:12Z","updated_at":"2014-12-20T10:49:43Z","pushed_at":"2015-02-13T11:17:52Z","git_url":"git://github.com/ghoneycutt/puppet-module-puppet.git","ssh_url":"git@github.com:ghoneycutt/puppet-module-puppet.git","clone_url":"https://github.com/ghoneycutt/puppet-module-puppet.git","svn_url":"https://github.com/ghoneycutt/puppet-module-puppet","homepage":"","size":945,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":7,"forks":25,"open_issues":7,"watchers":14,"default_branch":"master"}},"base":{"label":"ghoneycutt:master","ref":"master","sha":"5669902e755c54051e6d661959ad1793a1e906ea","user":{"login":"ghoneycutt","id":313891,"avatar_url":"https://avatars.githubusercontent.com/u/313891?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"repo":{"id":773617,"name":"puppet-module-puppet","full_name":"ghoneycutt/puppet-module-puppet","owner":{"login":"ghoneycutt","id":313891,"avatar_url":"https://avatars.githubusercontent.com/u/313891?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghoneycutt/puppet-module-puppet","description":"Puppet Module for managing Puppet","fork":false,"url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet","forks_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/forks","keys_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/teams","hooks_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/hooks","issue_events_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/events","assignees_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/tags","blobs_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/languages","stargazers_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/stargazers","contributors_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/contributors","subscribers_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/subscribers","subscription_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/subscription","commits_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/merges","archive_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/downloads","issues_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/labels{/name}","releases_url":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/releases{/id}","created_at":"2010-07-14T00:13:12Z","updated_at":"2014-12-20T10:49:43Z","pushed_at":"2015-02-13T11:17:52Z","git_url":"git://github.com/ghoneycutt/puppet-module-puppet.git","ssh_url":"git@github.com:ghoneycutt/puppet-module-puppet.git","clone_url":"https://github.com/ghoneycutt/puppet-module-puppet.git","svn_url":"https://github.com/ghoneycutt/puppet-module-puppet","homepage":"","size":945,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":7,"forks":25,"open_issues":7,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/96"},"html":{"href":"https://github.com/ghoneycutt/puppet-module-puppet/pull/96"},"issue":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/issues/96"},"comments":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-puppet/statuses/91639dda1652b527ee150f33d1e5a732b7274b49"}}}}