{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/40333237","id":40333237,"diff_hunk":"@@ -0,0 +1,61 @@\n+require 'spec_helper'\n+\n+describe ManageIQ::Providers::Amazon::CloudManager::Refresher do\n+  let(:hashes) do\n+    [\n+      {:type                => 'ManageIQ::Providers::Amazon::CloudManager::SecurityGroup',\n+       :ems_ref             => 'sg-e94055ac',\n+       :name                => 'default',\n+       :description         => 'default group',\n+       :cloud_network       => nil,\n+       :orchestration_stack => nil,\n+       :firewall_rules      => [\n+         {:direction             => nil,\n+          :host_protocol         => nil,\n+          :port                  => nil,\n+          :end_port              => nil,\n+          :source_security_group => nil\n+         },\n+         {:direction             => nil,\n+          :host_protocol         => nil,\n+          :port                  => nil,\n+          :end_port              => nil,\n+          :source_security_group => nil\n+         },\n+         {:direction             => 'inbound',\n+          :host_protocol         => 'ICMP',\n+          :port                  => -1,\n+          :end_port              => -1,\n+          :source_security_group => nil\n+         }]\n+      },\n+      {:type                => 'ManageIQ::Providers::Amazon::CloudManager::SecurityGroup',\n+       :ems_ref             => 'sg-2b87746f',\n+       :name                => 'EmsRefreshSpec-SecurityGroup-OtherRegion',\n+       :description         => 'EmsRefreshSpec-SecurityGroup-OtherRegion',\n+       :cloud_network       => nil,\n+       :orchestration_stack => nil,\n+       :firewall_rules      => [\n+         {:direction       => 'inbound',\n+          :host_protocol   => 'TCP',\n+          :port            => 0,\n+          :end_port        => 65_535,\n+          :source_ip_range => '0.0.0.0/0'\n+         }]\n+      }\n+    ]\n+  end\n+\n+  before(:each) do\n+    _guid, _server, zone = EvmSpecHelper.create_guid_miq_server_zone\n+    @ems = FactoryGirl.create(:ems_amazon, :zone => zone)\n+  end\n+\n+  context '.save_security_groups_inventory' do\n+    it 'should not raise an exception with empty firewall rules' do\n+      expect do\n+        EmsRefresh.save_security_groups_inventory(@ems, hashes)\n+      end.to_not raise_error","path":"spec/models/ems_refresh/refreshers/ec2_refresher_security_group_spec.rb","position":58,"original_position":58,"commit_id":"f619e351cd81591e11115e24c26380cb310865c2","original_commit_id":"f619e351cd81591e11115e24c26380cb310865c2","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"Can we change this to actually verify the output?\r\n\r\nIf so, then there's no need to wrap in a raise_error check.  If it blows up, it fails the spec anyway.\r\n\r\nAlso, I thought the error was that the parser was not processing things properly.  I'd rather not add the nil check to the save_inventory, but instead just not put null values in the hash in the first place at the parser level.","created_at":"2015-09-24T15:33:03Z","updated_at":"2015-09-24T15:33:03Z","html_url":"https://github.com/ManageIQ/manageiq/pull/4499#discussion_r40333237","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4499","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/40333237"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4499#discussion_r40333237"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4499"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4499","id":45824772,"html_url":"https://github.com/ManageIQ/manageiq/pull/4499","diff_url":"https://github.com/ManageIQ/manageiq/pull/4499.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4499.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4499","number":4499,"state":"open","locked":false,"title":"Handle ec2 security groups with empty firewall rules.","user":{"login":"jvlcek","id":729572,"avatar_url":"https://avatars.githubusercontent.com/u/729572?v=3","gravatar_id":"","url":"https://api.github.com/users/jvlcek","html_url":"https://github.com/jvlcek","followers_url":"https://api.github.com/users/jvlcek/followers","following_url":"https://api.github.com/users/jvlcek/following{/other_user}","gists_url":"https://api.github.com/users/jvlcek/gists{/gist_id}","starred_url":"https://api.github.com/users/jvlcek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvlcek/subscriptions","organizations_url":"https://api.github.com/users/jvlcek/orgs","repos_url":"https://api.github.com/users/jvlcek/repos","events_url":"https://api.github.com/users/jvlcek/events{/privacy}","received_events_url":"https://api.github.com/users/jvlcek/received_events","type":"User","site_admin":false},"body":"This code change will handle the case where an ec2 security group is defined with empty firewall rules.\r\n\r\nFixes #4359","created_at":"2015-09-23T20:06:22Z","updated_at":"2015-09-24T15:33:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c0cd5f94203cf084be12a2926aa25f4b3bdf1bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4499/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4499/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4499/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f619e351cd81591e11115e24c26380cb310865c2","head":{"label":"jvlcek:issue_4359_nil_fetch_path","ref":"issue_4359_nil_fetch_path","sha":"f619e351cd81591e11115e24c26380cb310865c2","user":{"login":"jvlcek","id":729572,"avatar_url":"https://avatars.githubusercontent.com/u/729572?v=3","gravatar_id":"","url":"https://api.github.com/users/jvlcek","html_url":"https://github.com/jvlcek","followers_url":"https://api.github.com/users/jvlcek/followers","following_url":"https://api.github.com/users/jvlcek/following{/other_user}","gists_url":"https://api.github.com/users/jvlcek/gists{/gist_id}","starred_url":"https://api.github.com/users/jvlcek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvlcek/subscriptions","organizations_url":"https://api.github.com/users/jvlcek/orgs","repos_url":"https://api.github.com/users/jvlcek/repos","events_url":"https://api.github.com/users/jvlcek/events{/privacy}","received_events_url":"https://api.github.com/users/jvlcek/received_events","type":"User","site_admin":false},"repo":{"id":20890511,"name":"manageiq","full_name":"jvlcek/manageiq","owner":{"login":"jvlcek","id":729572,"avatar_url":"https://avatars.githubusercontent.com/u/729572?v=3","gravatar_id":"","url":"https://api.github.com/users/jvlcek","html_url":"https://github.com/jvlcek","followers_url":"https://api.github.com/users/jvlcek/followers","following_url":"https://api.github.com/users/jvlcek/following{/other_user}","gists_url":"https://api.github.com/users/jvlcek/gists{/gist_id}","starred_url":"https://api.github.com/users/jvlcek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvlcek/subscriptions","organizations_url":"https://api.github.com/users/jvlcek/orgs","repos_url":"https://api.github.com/users/jvlcek/repos","events_url":"https://api.github.com/users/jvlcek/events{/privacy}","received_events_url":"https://api.github.com/users/jvlcek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvlcek/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/jvlcek/manageiq","forks_url":"https://api.github.com/repos/jvlcek/manageiq/forks","keys_url":"https://api.github.com/repos/jvlcek/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvlcek/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvlcek/manageiq/teams","hooks_url":"https://api.github.com/repos/jvlcek/manageiq/hooks","issue_events_url":"https://api.github.com/repos/jvlcek/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/jvlcek/manageiq/events","assignees_url":"https://api.github.com/repos/jvlcek/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/jvlcek/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/jvlcek/manageiq/tags","blobs_url":"https://api.github.com/repos/jvlcek/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvlcek/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvlcek/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvlcek/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvlcek/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/jvlcek/manageiq/languages","stargazers_url":"https://api.github.com/repos/jvlcek/manageiq/stargazers","contributors_url":"https://api.github.com/repos/jvlcek/manageiq/contributors","subscribers_url":"https://api.github.com/repos/jvlcek/manageiq/subscribers","subscription_url":"https://api.github.com/repos/jvlcek/manageiq/subscription","commits_url":"https://api.github.com/repos/jvlcek/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvlcek/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvlcek/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvlcek/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvlcek/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/jvlcek/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvlcek/manageiq/merges","archive_url":"https://api.github.com/repos/jvlcek/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvlcek/manageiq/downloads","issues_url":"https://api.github.com/repos/jvlcek/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/jvlcek/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/jvlcek/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/jvlcek/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvlcek/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/jvlcek/manageiq/releases{/id}","created_at":"2014-06-16T15:44:01Z","updated_at":"2015-04-23T15:03:22Z","pushed_at":"2015-09-23T22:39:17Z","git_url":"git://github.com/jvlcek/manageiq.git","ssh_url":"git@github.com:jvlcek/manageiq.git","clone_url":"https://github.com/jvlcek/manageiq.git","svn_url":"https://github.com/jvlcek/manageiq","homepage":null,"size":84426,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"4e62b91fba9e0c7d556bf25390cda593f0b92ec2","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-09-22T01:10:08Z","pushed_at":"2015-09-24T15:24:31Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":163663,"stargazers_count":152,"watchers_count":152,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":427,"forks":156,"open_issues":427,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4499"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4499"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4499"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4499/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4499/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4499/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f619e351cd81591e11115e24c26380cb310865c2"}}}}