{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml-batteries-team/batteries-included/issues/650","labels_url":"https://api.github.com/repos/ocaml-batteries-team/batteries-included/issues/650/labels{/name}","comments_url":"https://api.github.com/repos/ocaml-batteries-team/batteries-included/issues/650/comments","events_url":"https://api.github.com/repos/ocaml-batteries-team/batteries-included/issues/650/events","html_url":"https://github.com/ocaml-batteries-team/batteries-included/pull/650","id":116081954,"number":650,"title":"Lazy.from_val replaced by new lazy_from_val to be compatible with 3.12.1","user":{"login":"UnixJunkie","id":737920,"avatar_url":"https://avatars.githubusercontent.com/u/737920?v=3","gravatar_id":"","url":"https://api.github.com/users/UnixJunkie","html_url":"https://github.com/UnixJunkie","followers_url":"https://api.github.com/users/UnixJunkie/followers","following_url":"https://api.github.com/users/UnixJunkie/following{/other_user}","gists_url":"https://api.github.com/users/UnixJunkie/gists{/gist_id}","starred_url":"https://api.github.com/users/UnixJunkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnixJunkie/subscriptions","organizations_url":"https://api.github.com/users/UnixJunkie/orgs","repos_url":"https://api.github.com/users/UnixJunkie/repos","events_url":"https://api.github.com/users/UnixJunkie/events{/privacy}","received_events_url":"https://api.github.com/users/UnixJunkie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-10T10:46:11Z","updated_at":"2015-11-11T10:40:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ocaml-batteries-team/batteries-included/pulls/650","html_url":"https://github.com/ocaml-batteries-team/batteries-included/pull/650","diff_url":"https://github.com/ocaml-batteries-team/batteries-included/pull/650.diff","patch_url":"https://github.com/ocaml-batteries-team/batteries-included/pull/650.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/ocaml-batteries-team/batteries-included/issues/comments/155730943","html_url":"https://github.com/ocaml-batteries-team/batteries-included/pull/650#issuecomment-155730943","issue_url":"https://api.github.com/repos/ocaml-batteries-team/batteries-included/issues/650","id":155730943,"user":{"login":"gasche","id":426238,"avatar_url":"https://avatars.githubusercontent.com/u/426238?v=3","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T10:40:30Z","updated_at":"2015-11-11T10:40:30Z","body":"I think there is something wrong with this PR. On my machine, the current batteries master compiles fine with 3.12.1 (`opam config exec --switch=3.12.1 -- make all`). `man Lazy` says that `Lazy.from_val` is only available since 4.00, but `Lazy.lazy_from_val`, which is used in Batteries, seems to have always been available (and is now deprecated). In any case, I think the right replacement for (`Lazy.lazy_from_val v`) would be (`lazy v`), which is simpler than your re-implementation and is probably optimized reasonably by recent OCaml versions. the Lazy manual says something weird on that, but as neither of us are Lazy experts, let's do the simplest possible thing if we have to. But I don't think we do in this case."}}