{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/13937","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/13937/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/13937/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/13937/events","html_url":"https://github.com/elastic/elasticsearch/pull/13937","id":109785647,"number":13937,"title":"Java api: IdsQueryBuilder to accept only non null ids and types","user":{"login":"javanna","id":832460,"avatar_url":"https://avatars.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Query%20Refactoring","name":":Query Refactoring","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/breaking","name":"breaking","color":"ff0000"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-05T12:29:05Z","updated_at":"2015-10-05T13:15:05Z","closed_at":"2015-10-05T13:15:05Z","pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/13937","html_url":"https://github.com/elastic/elasticsearch/pull/13937","diff_url":"https://github.com/elastic/elasticsearch/pull/13937.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/13937.patch"},"body":"Types are still optional, but if you do provide them, they can't be null. Split the existing constructor that accepted nnull into two, one that accepts no arguments, and another one that accepts the types argument, which must be not null.\r\n\r\nAlso trimmed down different ways of setting ids, some were misleading as they would always add the ids to the existing ones and not set them, the add prefix makes that clear. Left `addIds` method that accepts a varargs argument. Added check for ids not be null.\r\n\r\nNote that this change is breaking for the java api."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/145523794","html_url":"https://github.com/elastic/elasticsearch/pull/13937#issuecomment-145523794","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/13937","id":145523794,"user":{"login":"javanna","id":832460,"avatar_url":"https://avatars.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T13:15:05Z","updated_at":"2015-10-05T13:15:05Z","body":"Merged https://github.com/elastic/elasticsearch/commit/e8653f51569580f23ca28a91106d90b07e989167"}}