{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/webrtc-pc/issues/420","labels_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/420/labels{/name}","comments_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/420/comments","events_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/420/events","html_url":"https://github.com/w3c/webrtc-pc/issues/420","id":120403418,"number":420,"title":"RTCSessionDescription should not allow nullable sdp","user":{"login":"dontcallmedom","id":216410,"avatar_url":"https://avatars.githubusercontent.com/u/216410?v=3","gravatar_id":"","url":"https://api.github.com/users/dontcallmedom","html_url":"https://github.com/dontcallmedom","followers_url":"https://api.github.com/users/dontcallmedom/followers","following_url":"https://api.github.com/users/dontcallmedom/following{/other_user}","gists_url":"https://api.github.com/users/dontcallmedom/gists{/gist_id}","starred_url":"https://api.github.com/users/dontcallmedom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dontcallmedom/subscriptions","organizations_url":"https://api.github.com/users/dontcallmedom/orgs","repos_url":"https://api.github.com/users/dontcallmedom/repos","events_url":"https://api.github.com/users/dontcallmedom/events{/privacy}","received_events_url":"https://api.github.com/users/dontcallmedom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-04T13:38:59Z","updated_at":"2015-12-06T17:56:40Z","closed_at":null,"body":"Unless I missed something, I see no reason why the sdp attribute of `RTCSessionDescription` is marked as nullable.\r\n\r\nFrom what I can tell, it was made nullable when `RTCSessionDescriptionInit` was introduced (commit fcda53c460a3f8e32db683f6284dfabed3688a3a), and that was probably needed to be compatible with dictionaries when they could not have required members.\r\n\r\nBut `RTCSessionDescriptionInit` has now `type` as required, and I think it should also have `sdp` as required, and the sdp attribute in `RTCSessionDescription` marked as non-nullable.\r\n\r\nHappy to provide the PR if I get confirmation the reasoning is valid."},"comment":{"url":"https://api.github.com/repos/w3c/webrtc-pc/issues/comments/162332097","html_url":"https://github.com/w3c/webrtc-pc/issues/420#issuecomment-162332097","issue_url":"https://api.github.com/repos/w3c/webrtc-pc/issues/420","id":162332097,"user":{"login":"dontcallmedom","id":216410,"avatar_url":"https://avatars.githubusercontent.com/u/216410?v=3","gravatar_id":"","url":"https://api.github.com/users/dontcallmedom","html_url":"https://github.com/dontcallmedom","followers_url":"https://api.github.com/users/dontcallmedom/followers","following_url":"https://api.github.com/users/dontcallmedom/following{/other_user}","gists_url":"https://api.github.com/users/dontcallmedom/gists{/gist_id}","starred_url":"https://api.github.com/users/dontcallmedom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dontcallmedom/subscriptions","organizations_url":"https://api.github.com/users/dontcallmedom/orgs","repos_url":"https://api.github.com/users/dontcallmedom/repos","events_url":"https://api.github.com/users/dontcallmedom/events{/privacy}","received_events_url":"https://api.github.com/users/dontcallmedom/received_events","type":"User","site_admin":false},"created_at":"2015-12-06T17:56:40Z","updated_at":"2015-12-06T17:56:40Z","body":"@martinthomson good point re rollback; that said, is nullable really needed for RTCSessionDescriptionInit.sdp or is it enough to not make it required?"}}