{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/866","labels_url":"https://api.github.com/repos/ripple/rippled/issues/866/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/866/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/866/events","html_url":"https://github.com/ripple/rippled/pull/866","id":57206601,"number":866,"title":"2-level multi-signing implementation [RIPD-182]","user":{"login":"scottschurr","id":7840379,"avatar_url":"https://avatars.githubusercontent.com/u/7840379?v=3","gravatar_id":"","url":"https://api.github.com/users/scottschurr","html_url":"https://github.com/scottschurr","followers_url":"https://api.github.com/users/scottschurr/followers","following_url":"https://api.github.com/users/scottschurr/following{/other_user}","gists_url":"https://api.github.com/users/scottschurr/gists{/gist_id}","starred_url":"https://api.github.com/users/scottschurr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottschurr/subscriptions","organizations_url":"https://api.github.com/users/scottschurr/orgs","repos_url":"https://api.github.com/users/scottschurr/repos","events_url":"https://api.github.com/users/scottschurr/events{/privacy}","received_events_url":"https://api.github.com/users/scottschurr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ripple/rippled/labels/David","name":"David","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Nik","name":"Nik","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Tx%20Change","name":"Tx Change","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-02-10T17:25:19Z","updated_at":"2015-03-26T21:42:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/866","html_url":"https://github.com/ripple/rippled/pull/866","diff_url":"https://github.com/ripple/rippled/pull/866.diff","patch_url":"https://github.com/ripple/rippled/pull/866.patch"},"body":"This set of commits brings support for 2-level multi-signing into\r\nthe code base.  The capability is (typically) compiled out, since\r\nmulti-signing is not feature complete.\r\n\r\nHere's a guide to the commits:\r\n\r\n o Improvements to protocol serialization: This commit pulled out a\r\n   few general improvements to SField and STObject.  It was\r\n   previously a separate pull request.  Vinnie and Nik suggested\r\n   changes that I have introduced in this version of the commit.\r\n\r\n o Multisign whitespace: changes to white space, adding or removing\r\n   virtuals.  Mostly trying to move noise out of the other commits.\r\n\r\n o SignerSetList transaction: this commit fully introduces the\r\n   SignerListSet transaction.  New, since the last m-of-n review,\r\n   is the addition of InnerObjectFormats.  Code related to the use\r\n   of InnerObjectFormats will need the closest review.\r\n\r\n o get_signingaccount RPC command: this commit fully introduces\r\n   the get_signing_account RPC command, which returns individual\r\n   multi-signatures.  New, since the last m-of-n review, is support\r\n   for 2-level signing.  That change impacted much of the previously\r\n   reviewed code.\r\n\r\n o 2-level transaction multi-signatures: this commit finally allows\r\n   for 2-level multi-signatures.  Again, much of the previously\r\n   reviewed code was touched in order to adjust from single- to\r\n   two-level multi-signing.\r\n\r\nThe user availability of the code is managed by a #define in\r\nBeastConfig.  Once amendments are available I'll switch the code\r\nover to be managed by an amendment.\r\n\r\n@nbougalis, @JoelKatz\r\n"},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/86729599","html_url":"https://github.com/ripple/rippled/pull/866#issuecomment-86729599","issue_url":"https://api.github.com/repos/ripple/rippled/issues/866","id":86729599,"user":{"login":"JoelKatz","id":877549,"avatar_url":"https://avatars.githubusercontent.com/u/877549?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelKatz","html_url":"https://github.com/JoelKatz","followers_url":"https://api.github.com/users/JoelKatz/followers","following_url":"https://api.github.com/users/JoelKatz/following{/other_user}","gists_url":"https://api.github.com/users/JoelKatz/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelKatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelKatz/subscriptions","organizations_url":"https://api.github.com/users/JoelKatz/orgs","repos_url":"https://api.github.com/users/JoelKatz/repos","events_url":"https://api.github.com/users/JoelKatz/events{/privacy}","received_events_url":"https://api.github.com/users/JoelKatz/received_events","type":"User","site_admin":false},"created_at":"2015-03-26T21:42:50Z","updated_at":"2015-03-26T21:42:50Z","body":"Okay, I've been over all the code. Other than the comments I made, it all looks good. We need to get it rebased though. If it will make the rebasing easier, IMO, it can be squashed."}}