{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/28218196","id":28218196,"diff_hunk":"@@ -235,7 +235,7 @@ def __Filter(list: var[]..[], predicate: _FunctionObject)\n         _count = Count(list);\n         if (_count == 0)\n         {\n-            return = {};\n+            return = {{}, {}};","path":"src/Engine/ProtoCore/ExtendedLibraries/FunctionObject.ds","position":5,"original_position":5,"commit_id":"0938194075446be5be4c2f7eb9c6491490453a50","original_commit_id":"0938194075446be5be4c2f7eb9c6491490453a50","user":{"login":"junmendoza","id":5109659,"avatar_url":"https://avatars.githubusercontent.com/u/5109659?v=3","gravatar_id":"","url":"https://api.github.com/users/junmendoza","html_url":"https://github.com/junmendoza","followers_url":"https://api.github.com/users/junmendoza/followers","following_url":"https://api.github.com/users/junmendoza/following{/other_user}","gists_url":"https://api.github.com/users/junmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/junmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmendoza/subscriptions","organizations_url":"https://api.github.com/users/junmendoza/orgs","repos_url":"https://api.github.com/users/junmendoza/repos","events_url":"https://api.github.com/users/junmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/junmendoza/received_events","type":"User","site_admin":false},"body":"Does __Filter always return 2d array for all cases?","created_at":"2015-04-13T07:07:22Z","updated_at":"2015-04-13T07:07:22Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/4231#discussion_r28218196","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4231","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/28218196"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/4231#discussion_r28218196"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4231"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4231","id":33139490,"html_url":"https://github.com/DynamoDS/Dynamo/pull/4231","diff_url":"https://github.com/DynamoDS/Dynamo/pull/4231.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/4231.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4231","number":4231,"state":"open","locked":false,"title":"Fix defect magn-6864 List operations on Empty List returns null","user":{"login":"ke-yu","id":2600379,"avatar_url":"https://avatars.githubusercontent.com/u/2600379?v=3","gravatar_id":"","url":"https://api.github.com/users/ke-yu","html_url":"https://github.com/ke-yu","followers_url":"https://api.github.com/users/ke-yu/followers","following_url":"https://api.github.com/users/ke-yu/following{/other_user}","gists_url":"https://api.github.com/users/ke-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/ke-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ke-yu/subscriptions","organizations_url":"https://api.github.com/users/ke-yu/orgs","repos_url":"https://api.github.com/users/ke-yu/repos","events_url":"https://api.github.com/users/ke-yu/events{/privacy}","received_events_url":"https://api.github.com/users/ke-yu/received_events","type":"User","site_admin":false},"body":"This PR fixes defect mang-6864 that `List.Filter` gets a warning on empty list, and it returns null. \r\n\r\nIn ``__Filter()``, it should returns ``{{},{}}``, the first is for filtered in result and the second is for filtered out result.\r\n\r\nLanguage test cases and Dynamo test case added.\r\n\r\n@junmendoza please take a look. ","created_at":"2015-04-13T06:54:21Z","updated_at":"2015-04-13T07:07:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a6ef09d2062fbda6391f7176bc0b20549a0bdba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4231/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4231/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4231/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/0938194075446be5be4c2f7eb9c6491490453a50","head":{"label":"ke-yu:magn-6864","ref":"magn-6864","sha":"0938194075446be5be4c2f7eb9c6491490453a50","user":{"login":"ke-yu","id":2600379,"avatar_url":"https://avatars.githubusercontent.com/u/2600379?v=3","gravatar_id":"","url":"https://api.github.com/users/ke-yu","html_url":"https://github.com/ke-yu","followers_url":"https://api.github.com/users/ke-yu/followers","following_url":"https://api.github.com/users/ke-yu/following{/other_user}","gists_url":"https://api.github.com/users/ke-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/ke-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ke-yu/subscriptions","organizations_url":"https://api.github.com/users/ke-yu/orgs","repos_url":"https://api.github.com/users/ke-yu/repos","events_url":"https://api.github.com/users/ke-yu/events{/privacy}","received_events_url":"https://api.github.com/users/ke-yu/received_events","type":"User","site_admin":false},"repo":{"id":18300645,"name":"Dynamo","full_name":"ke-yu/Dynamo","owner":{"login":"ke-yu","id":2600379,"avatar_url":"https://avatars.githubusercontent.com/u/2600379?v=3","gravatar_id":"","url":"https://api.github.com/users/ke-yu","html_url":"https://github.com/ke-yu","followers_url":"https://api.github.com/users/ke-yu/followers","following_url":"https://api.github.com/users/ke-yu/following{/other_user}","gists_url":"https://api.github.com/users/ke-yu/gists{/gist_id}","starred_url":"https://api.github.com/users/ke-yu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ke-yu/subscriptions","organizations_url":"https://api.github.com/users/ke-yu/orgs","repos_url":"https://api.github.com/users/ke-yu/repos","events_url":"https://api.github.com/users/ke-yu/events{/privacy}","received_events_url":"https://api.github.com/users/ke-yu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ke-yu/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/ke-yu/Dynamo","forks_url":"https://api.github.com/repos/ke-yu/Dynamo/forks","keys_url":"https://api.github.com/repos/ke-yu/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ke-yu/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ke-yu/Dynamo/teams","hooks_url":"https://api.github.com/repos/ke-yu/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/ke-yu/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/ke-yu/Dynamo/events","assignees_url":"https://api.github.com/repos/ke-yu/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/ke-yu/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/ke-yu/Dynamo/tags","blobs_url":"https://api.github.com/repos/ke-yu/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ke-yu/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ke-yu/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ke-yu/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ke-yu/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/ke-yu/Dynamo/languages","stargazers_url":"https://api.github.com/repos/ke-yu/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/ke-yu/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/ke-yu/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/ke-yu/Dynamo/subscription","commits_url":"https://api.github.com/repos/ke-yu/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ke-yu/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ke-yu/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ke-yu/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ke-yu/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/ke-yu/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ke-yu/Dynamo/merges","archive_url":"https://api.github.com/repos/ke-yu/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ke-yu/Dynamo/downloads","issues_url":"https://api.github.com/repos/ke-yu/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/ke-yu/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/ke-yu/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/ke-yu/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ke-yu/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/ke-yu/Dynamo/releases{/id}","created_at":"2014-03-31T16:53:50Z","updated_at":"2014-06-26T05:45:55Z","pushed_at":"2015-04-13T06:51:31Z","git_url":"git://github.com/ke-yu/Dynamo.git","ssh_url":"git@github.com:ke-yu/Dynamo.git","clone_url":"https://github.com/ke-yu/Dynamo.git","svn_url":"https://github.com/ke-yu/Dynamo","homepage":"http://dynamobim.org","size":671546,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"3a8df0feea9138303696606e2f248dc2c190bfab","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2015-04-13T05:58:34Z","pushed_at":"2015-04-13T06:54:21Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":912305,"stargazers_count":209,"watchers_count":209,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":571,"forks":154,"open_issues":571,"watchers":209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4231"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/4231"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4231"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4231/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4231/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4231/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/0938194075446be5be4c2f7eb9c6491490453a50"}}}}