{"action":"opened","issue":{"url":"https://api.github.com/repos/rear/rear/issues/718","labels_url":"https://api.github.com/repos/rear/rear/issues/718/labels{/name}","comments_url":"https://api.github.com/repos/rear/rear/issues/718/comments","events_url":"https://api.github.com/repos/rear/rear/issues/718/events","html_url":"https://github.com/rear/rear/issues/718","id":119043180,"number":718,"title":"DISKLAYOUT_FILE versus LAYOUT_FILE inconsistency","user":{"login":"jsmeix","id":1788608,"avatar_url":"https://avatars.githubusercontent.com/u/1788608?v=3","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rear/rear/labels/bug","name":"bug","color":"d7e102"},{"url":"https://api.github.com/repos/rear/rear/labels/cleanup","name":"cleanup","color":"DDDDDD"},{"url":"https://api.github.com/repos/rear/rear/labels/waiting%20for%20feedback","name":"waiting for feedback","color":"444444"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-11-26T13:20:37Z","updated_at":"2015-11-26T13:20:37Z","closed_at":null,"body":"I am confused about DISKLAYOUT_FILE versus LAYOUT_FILE.\r\n\r\nBoth are used but it seems both mean usually\r\nthe same \"$VAR_DIR/layout/disklayout.conf\".\r\n\r\nBut sometimes it seems to mean something else\r\nlike \"$TMP_DIR/backuplayout.conf\" and others.\r\n\r\nIt is so confusing that I regard it even as a bug\r\n(not a bug in runtime function but a bug in programming style).\r\n\r\nI suggest to use DISKLAYOUT_FILE everywhere\r\nwhen \"$VAR_DIR/layout/disklayout.conf\" is meant\r\nbecause its name is more descriptive (i.e. what kind of layout it is)\r\nand its name matches better to the file name \"disklayout.conf\".\r\n\r\nThe other meanings must use different variable names.\r\n\r\nWhere DISKLAYOUT_FILE versus LAYOUT_FILE is currently set:\r\n<pre>\r\ngithub/rear $ find * | xargs grep 'LAYOUT_FILE='\r\nusr/sbin/rear:DISKLAYOUT_FILE=\"$VAR_DIR/layout/disklayout.conf\"\r\nusr/share/rear/finalize/GNU/Linux/15_migrate_disk_devices_layout.sh:        LAYOUT_FILE=\"$file\"\r\nusr/share/rear/finalize/GNU/Linux/15_migrate_disk_devices_layout.sh:        LAYOUT_FILE=$tmp_layout\r\nusr/share/rear/layout/prepare/default/01_prepare_files.sh:LAYOUT_FILE=\"$VAR_DIR/layout/disklayout.conf\"\r\nusr/share/rear/layout/save/GNU/Linux/10_create_layout_file.sh:DISKLAYOUT_FILE=${DISKLAYOUT_FILE:-$VAR_DIR/layout/disklayout.conf}\r\nusr/share/rear/layout/save/GNU/Linux/10_create_layout_file.sh:LAYOUT_FILE=\"$DISKLAYOUT_FILE\"\r\nusr/share/rear/lib/checklayout-workflow.sh:    DISKLAYOUT_FILE=$TEMP_LAYOUT\r\nusr/share/rear/lib/mkbackuponly-workflow.sh:    DISKLAYOUT_FILE=$TMP_DIR/backuplayout.conf\r\nusr/share/rear/lib/savelayout-workflow.sh:    #DISKLAYOUT_FILE=$VAR_DIR/layout/disklayout.conf # defined in default.conf now (issue #678)\r\n</pre>\r\n"}}