{"action":"created","comment":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments/29341258","id":29341258,"diff_hunk":"@@ -1152,9 +1152,17 @@ public String getModifyColumnStatement( String tablename, ValueMetaInterface v,\n    * Customizes the ValueMetaInterface defined in the base\n    *\n    * @param v the determined valueMetaInterface\n-   * @param valueType the sql column type\n+   * @param rm the sql column type\n    * @return ValueMetaInterface customized with the data base specific types","path":"core/src/org/pentaho/di/core/database/DatabaseInterface.java","position":6,"original_position":6,"commit_id":"508b6430d028c4e3ab347cbabbae44e9646a96b0","original_commit_id":"508b6430d028c4e3ab347cbabbae44e9646a96b0","user":{"login":"dkincade","id":974494,"avatar_url":"https://avatars.githubusercontent.com/u/974494?v=3","gravatar_id":"","url":"https://api.github.com/users/dkincade","html_url":"https://github.com/dkincade","followers_url":"https://api.github.com/users/dkincade/followers","following_url":"https://api.github.com/users/dkincade/following{/other_user}","gists_url":"https://api.github.com/users/dkincade/gists{/gist_id}","starred_url":"https://api.github.com/users/dkincade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkincade/subscriptions","organizations_url":"https://api.github.com/users/dkincade/orgs","repos_url":"https://api.github.com/users/dkincade/repos","events_url":"https://api.github.com/users/dkincade/events{/privacy}","received_events_url":"https://api.github.com/users/dkincade/received_events","type":"User","site_admin":false},"body":"Since you were in here cleaning up the javadoc for this method, it would have been a good idea to complete the clean and add the index field (3rd parameter) that is missing as well...","created_at":"2015-04-29T14:34:26Z","updated_at":"2015-04-29T14:34:26Z","html_url":"https://github.com/pentaho/pentaho-kettle/pull/1248#discussion_r29341258","pull_request_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1248","_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments/29341258"},"html":{"href":"https://github.com/pentaho/pentaho-kettle/pull/1248#discussion_r29341258"},"pull_request":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1248"}}},"pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1248","id":34352427,"html_url":"https://github.com/pentaho/pentaho-kettle/pull/1248","diff_url":"https://github.com/pentaho/pentaho-kettle/pull/1248.diff","patch_url":"https://github.com/pentaho/pentaho-kettle/pull/1248.patch","issue_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/1248","number":1248,"state":"closed","locked":false,"title":"[BACKLOG-3098] - Added extension to dialect to support different create ...","user":{"login":"diogofscmariano","id":1148693,"avatar_url":"https://avatars.githubusercontent.com/u/1148693?v=3","gravatar_id":"","url":"https://api.github.com/users/diogofscmariano","html_url":"https://github.com/diogofscmariano","followers_url":"https://api.github.com/users/diogofscmariano/followers","following_url":"https://api.github.com/users/diogofscmariano/following{/other_user}","gists_url":"https://api.github.com/users/diogofscmariano/gists{/gist_id}","starred_url":"https://api.github.com/users/diogofscmariano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogofscmariano/subscriptions","organizations_url":"https://api.github.com/users/diogofscmariano/orgs","repos_url":"https://api.github.com/users/diogofscmariano/repos","events_url":"https://api.github.com/users/diogofscmariano/events{/privacy}","received_events_url":"https://api.github.com/users/diogofscmariano/received_events","type":"User","site_admin":false},"body":"...table statement. The original behaviour is the same. Unit tests added\r\n\r\n@pamval please review","created_at":"2015-04-29T11:09:04Z","updated_at":"2015-04-29T14:34:26Z","closed_at":"2015-04-29T13:38:35Z","merged_at":"2015-04-29T13:38:35Z","merge_commit_sha":"dead2fac47a178224b9745c886c5f47734209dd2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1248/commits","review_comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1248/comments","review_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/1248/comments","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/508b6430d028c4e3ab347cbabbae44e9646a96b0","head":{"label":"diogofscmariano:master","ref":"master","sha":"508b6430d028c4e3ab347cbabbae44e9646a96b0","user":{"login":"diogofscmariano","id":1148693,"avatar_url":"https://avatars.githubusercontent.com/u/1148693?v=3","gravatar_id":"","url":"https://api.github.com/users/diogofscmariano","html_url":"https://github.com/diogofscmariano","followers_url":"https://api.github.com/users/diogofscmariano/followers","following_url":"https://api.github.com/users/diogofscmariano/following{/other_user}","gists_url":"https://api.github.com/users/diogofscmariano/gists{/gist_id}","starred_url":"https://api.github.com/users/diogofscmariano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogofscmariano/subscriptions","organizations_url":"https://api.github.com/users/diogofscmariano/orgs","repos_url":"https://api.github.com/users/diogofscmariano/repos","events_url":"https://api.github.com/users/diogofscmariano/events{/privacy}","received_events_url":"https://api.github.com/users/diogofscmariano/received_events","type":"User","site_admin":false},"repo":{"id":31711927,"name":"pentaho-kettle","full_name":"diogofscmariano/pentaho-kettle","owner":{"login":"diogofscmariano","id":1148693,"avatar_url":"https://avatars.githubusercontent.com/u/1148693?v=3","gravatar_id":"","url":"https://api.github.com/users/diogofscmariano","html_url":"https://github.com/diogofscmariano","followers_url":"https://api.github.com/users/diogofscmariano/followers","following_url":"https://api.github.com/users/diogofscmariano/following{/other_user}","gists_url":"https://api.github.com/users/diogofscmariano/gists{/gist_id}","starred_url":"https://api.github.com/users/diogofscmariano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogofscmariano/subscriptions","organizations_url":"https://api.github.com/users/diogofscmariano/orgs","repos_url":"https://api.github.com/users/diogofscmariano/repos","events_url":"https://api.github.com/users/diogofscmariano/events{/privacy}","received_events_url":"https://api.github.com/users/diogofscmariano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diogofscmariano/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":true,"url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle","forks_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/diogofscmariano/pentaho-kettle/releases{/id}","created_at":"2015-03-05T12:04:28Z","updated_at":"2015-04-29T11:07:22Z","pushed_at":"2015-04-29T11:07:22Z","git_url":"git://github.com/diogofscmariano/pentaho-kettle.git","ssh_url":"git@github.com:diogofscmariano/pentaho-kettle.git","clone_url":"https://github.com/diogofscmariano/pentaho-kettle.git","svn_url":"https://github.com/diogofscmariano/pentaho-kettle","homepage":null,"size":480856,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pentaho:master","ref":"master","sha":"89637b8507c4f2090e7042d24c9784e0fd2e0a06","user":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":13421878,"name":"pentaho-kettle","full_name":"pentaho/pentaho-kettle","owner":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pentaho/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":false,"url":"https://api.github.com/repos/pentaho/pentaho-kettle","forks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/pentaho/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/pentaho/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/pentaho-kettle/releases{/id}","created_at":"2013-10-08T18:27:11Z","updated_at":"2015-04-29T13:38:35Z","pushed_at":"2015-04-29T13:38:35Z","git_url":"git://github.com/pentaho/pentaho-kettle.git","ssh_url":"git@github.com:pentaho/pentaho-kettle.git","clone_url":"https://github.com/pentaho/pentaho-kettle.git","svn_url":"https://github.com/pentaho/pentaho-kettle","homepage":null,"size":589347,"stargazers_count":215,"watchers_count":215,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":328,"mirror_url":null,"open_issues_count":67,"forks":328,"open_issues":67,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1248"},"html":{"href":"https://github.com/pentaho/pentaho-kettle/pull/1248"},"issue":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/1248"},"comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/1248/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1248/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1248/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/508b6430d028c4e3ab347cbabbae44e9646a96b0"}}}}