{"action":"created","issue":{"url":"https://api.github.com/repos/aririikonen/oracle/issues/8","labels_url":"https://api.github.com/repos/aririikonen/oracle/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/aririikonen/oracle/issues/8/comments","events_url":"https://api.github.com/repos/aririikonen/oracle/issues/8/events","html_url":"https://github.com/aririikonen/oracle/pull/8","id":63058856,"number":8,"title":"hard coded path","user":{"login":"powersln","id":8472707,"avatar_url":"https://avatars.githubusercontent.com/u/8472707?v=3","gravatar_id":"","url":"https://api.github.com/users/powersln","html_url":"https://github.com/powersln","followers_url":"https://api.github.com/users/powersln/followers","following_url":"https://api.github.com/users/powersln/following{/other_user}","gists_url":"https://api.github.com/users/powersln/gists{/gist_id}","starred_url":"https://api.github.com/users/powersln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powersln/subscriptions","organizations_url":"https://api.github.com/users/powersln/orgs","repos_url":"https://api.github.com/users/powersln/repos","events_url":"https://api.github.com/users/powersln/events{/privacy}","received_events_url":"https://api.github.com/users/powersln/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-19T18:30:29Z","updated_at":"2015-03-19T19:12:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aririikonen/oracle/pulls/8","html_url":"https://github.com/aririikonen/oracle/pull/8","diff_url":"https://github.com/aririikonen/oracle/pull/8.diff","patch_url":"https://github.com/aririikonen/oracle/pull/8.patch"},"body":"Change hard coded path to attribute."},"comment":{"url":"https://api.github.com/repos/aririikonen/oracle/issues/comments/83721106","html_url":"https://github.com/aririikonen/oracle/pull/8#issuecomment-83721106","issue_url":"https://api.github.com/repos/aririikonen/oracle/issues/8","id":83721106,"user":{"login":"aririikonen","id":4831511,"avatar_url":"https://avatars.githubusercontent.com/u/4831511?v=3","gravatar_id":"","url":"https://api.github.com/users/aririikonen","html_url":"https://github.com/aririikonen","followers_url":"https://api.github.com/users/aririikonen/followers","following_url":"https://api.github.com/users/aririikonen/following{/other_user}","gists_url":"https://api.github.com/users/aririikonen/gists{/gist_id}","starred_url":"https://api.github.com/users/aririikonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aririikonen/subscriptions","organizations_url":"https://api.github.com/users/aririikonen/orgs","repos_url":"https://api.github.com/users/aririikonen/repos","events_url":"https://api.github.com/users/aririikonen/events{/privacy}","received_events_url":"https://api.github.com/users/aririikonen/received_events","type":"User","site_admin":false},"created_at":"2015-03-19T19:12:09Z","updated_at":"2015-03-19T19:12:09Z","body":"Good catch powersln. Thank you! Obviously we need to change this to an attribute, but personally I would put the diag folders under ORACLE_BASE (Oracle default) instead of ORACLE_HOME, so node[:oracle][:ora_base].\r\n\r\nRef. http://docs.oracle.com/database/121/REFRN/refrn10280.htm#REFRN10280\r\n\r\nWhat do you think?"}}