{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/5964","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/5964/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/5964/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/5964/events","html_url":"https://github.com/joomla/joomla-cms/pull/5964","id":56511171,"number":5964,"title":"Optimizing system logout plugin","user":{"login":"Hackwar","id":313866,"avatar_url":"https://avatars.githubusercontent.com/u/313866?v=3","gravatar_id":"","url":"https://api.github.com/users/Hackwar","html_url":"https://github.com/Hackwar","followers_url":"https://api.github.com/users/Hackwar/followers","following_url":"https://api.github.com/users/Hackwar/following{/other_user}","gists_url":"https://api.github.com/users/Hackwar/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackwar/subscriptions","organizations_url":"https://api.github.com/users/Hackwar/orgs","repos_url":"https://api.github.com/users/Hackwar/repos","events_url":"https://api.github.com/users/Hackwar/events{/privacy}","received_events_url":"https://api.github.com/users/Hackwar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-04T10:49:17Z","updated_at":"2015-02-04T11:41:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/5964","html_url":"https://github.com/joomla/joomla-cms/pull/5964","diff_url":"https://github.com/joomla/joomla-cms/pull/5964.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/5964.patch"},"body":"This PR does not change the system, but optimizes it in a few key areas. This helps with testing and removes some minor potential issues.\r\n\r\nThe initialisation is done on onAfterInitialise instead of on constructing the plugin. That saves the additional code to call the parent constructor.\r\n\r\nSince there is only one string in this plugin, the autoload feature is disabled and the language file is only loaded right before the string is used.\r\n\r\nAll calls to the application object or the config object have been replaced by calls to $this->app, which is autoinjected into the plugin. This allows to write unittests for this with a fake application object.\r\n\r\nReading and setting the cookie is done through the input object and not with setCookie. Also, the path for the cookie is set to the root of the Joomla installation. This prevents interferences between different installations on the same host. If you have for example a Joomla in /joomla and cloned version of that installation in /joomla_test, the cookie would be set when you logout of /joomla and /joomla_test would read that cookie and thus register the error handler. The chances are slim, but anyway..."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/72841143","html_url":"https://github.com/joomla/joomla-cms/pull/5964#issuecomment-72841143","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/5964","id":72841143,"user":{"login":"Hackwar","id":313866,"avatar_url":"https://avatars.githubusercontent.com/u/313866?v=3","gravatar_id":"","url":"https://api.github.com/users/Hackwar","html_url":"https://github.com/Hackwar","followers_url":"https://api.github.com/users/Hackwar/followers","following_url":"https://api.github.com/users/Hackwar/following{/other_user}","gists_url":"https://api.github.com/users/Hackwar/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackwar/subscriptions","organizations_url":"https://api.github.com/users/Hackwar/orgs","repos_url":"https://api.github.com/users/Hackwar/repos","events_url":"https://api.github.com/users/Hackwar/events{/privacy}","received_events_url":"https://api.github.com/users/Hackwar/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T11:41:30Z","updated_at":"2015-02-04T11:41:30Z","body":"No, I'm saying that it uses the current root of the Joomla site as a default value instead of simply /. If the value is set in global configuration, that one overrules this default setting."}}