{"action":"created","issue":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1990","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1990/labels{/name}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1990/comments","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1990/events","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/1990","id":120251978,"number":1990,"title":"Adding rendering of shoal and reef, improving rendering of beach","user":{"login":"imagico","id":5408119,"avatar_url":"https://avatars.githubusercontent.com/u/5408119?v=3","gravatar_id":"","url":"https://api.github.com/users/imagico","html_url":"https://github.com/imagico","followers_url":"https://api.github.com/users/imagico/followers","following_url":"https://api.github.com/users/imagico/following{/other_user}","gists_url":"https://api.github.com/users/imagico/gists{/gist_id}","starred_url":"https://api.github.com/users/imagico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imagico/subscriptions","organizations_url":"https://api.github.com/users/imagico/orgs","repos_url":"https://api.github.com/users/imagico/repos","events_url":"https://api.github.com/users/imagico/events{/privacy}","received_events_url":"https://api.github.com/users/imagico/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-12-03T19:39:13Z","updated_at":"2015-12-12T22:23:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/1990","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/1990","diff_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/1990.diff","patch_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/1990.patch"},"body":"This makes the following changes to landcover rendering:\r\n\r\n`natural=reef` (8000 uses) is rendered with a random dot overlay pattern in dark blue.\r\n\r\n`natural=shoal` (~200 uses) is rendered exactly like beach (see below).  This is meant to counteract the widespread use of natural=beach to tag shoals.  Although beaches and shoals are quite different things they are related - many shoals are essentially small islands with beaches on all sides and not much else.\r\n\r\nFor `natural=beach` the old regular grid-dot pattern is removed.  Beaches with surface tag (14k uses) are rendered with a pattern at z>=14 depending on the surface value.  `surface=sand` is rendered with a fine grained pattern while `surface=gravel|fine_gravel|pebbles|pebblestone|shingle|stones|shells` is rendered with a coarser pattern (the same one as for scree/shingle).  `surface=rocky` (180 uses in combination with natural=beach) is ignored since this is abuse of natural=beach (rocky coasts are no beaches).  Beaches with no or no known surface tag are rendered in plain color.\r\n\r\nThe patterns are rendered separately in the landcover overlay layer so after moving to water polygons (#1982) the pattern can be rendered above water while the base color is below water.  This should lead to intuitive rendering of parts of beaches above and below the water line.\r\n\r\nFixes part of #545.\r\n\r\nExamples:\r\n\r\nReef:\r\n![reef](http://www.imagico.de/files/reef_z11.png)\r\n\r\nShoal:\r\n![shoal](http://www.imagico.de/files/shoal_z11.png)\r\n\r\nBeach with surface=sand:\r\n![surface=sand](http://www.imagico.de/files/beach_z13.png)\r\n\r\nBeach with surface=shingle (left) and surface=sand (right):\r\n![surface=shingle](http://www.imagico.de/files/beach_z17.png)\r\n\r\nBeach next to natural=sand:\r\n![beach+sand](http://www.imagico.de/files/beach_z15.png)\r\n"},"comment":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments/164198837","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/1990#issuecomment-164198837","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1990","id":164198837,"user":{"login":"talllguy","id":1827881,"avatar_url":"https://avatars.githubusercontent.com/u/1827881?v=3","gravatar_id":"","url":"https://api.github.com/users/talllguy","html_url":"https://github.com/talllguy","followers_url":"https://api.github.com/users/talllguy/followers","following_url":"https://api.github.com/users/talllguy/following{/other_user}","gists_url":"https://api.github.com/users/talllguy/gists{/gist_id}","starred_url":"https://api.github.com/users/talllguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talllguy/subscriptions","organizations_url":"https://api.github.com/users/talllguy/orgs","repos_url":"https://api.github.com/users/talllguy/repos","events_url":"https://api.github.com/users/talllguy/events{/privacy}","received_events_url":"https://api.github.com/users/talllguy/received_events","type":"User","site_admin":false},"created_at":"2015-12-12T22:23:14Z","updated_at":"2015-12-12T22:23:14Z","body":"I just mapped a reef that would be a good candidate for this type of proposed rendering. I think this would add value to the map for mappers.\r\n\r\n![screenshot 2015-12-12 17 22 42](https://cloud.githubusercontent.com/assets/1827881/11764206/ffb1898e-a0f4-11e5-94ed-a86747c2537c.png)\r\nhttp://www.openstreetmap.org/relation/5737665#map=14/-11.6340/166.9737"}}