{"action":"closed","issue":{"url":"https://api.github.com/repos/sttung/DAT_SF_16/issues/3","labels_url":"https://api.github.com/repos/sttung/DAT_SF_16/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/sttung/DAT_SF_16/issues/3/comments","events_url":"https://api.github.com/repos/sttung/DAT_SF_16/issues/3/events","html_url":"https://github.com/sttung/DAT_SF_16/issues/3","id":101813788,"number":3,"title":"Homework 3 Comments","user":{"login":"rickjunli","id":4419782,"avatar_url":"https://avatars.githubusercontent.com/u/4419782?v=3","gravatar_id":"","url":"https://api.github.com/users/rickjunli","html_url":"https://github.com/rickjunli","followers_url":"https://api.github.com/users/rickjunli/followers","following_url":"https://api.github.com/users/rickjunli/following{/other_user}","gists_url":"https://api.github.com/users/rickjunli/gists{/gist_id}","starred_url":"https://api.github.com/users/rickjunli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickjunli/subscriptions","organizations_url":"https://api.github.com/users/rickjunli/orgs","repos_url":"https://api.github.com/users/rickjunli/repos","events_url":"https://api.github.com/users/rickjunli/events{/privacy}","received_events_url":"https://api.github.com/users/rickjunli/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-19T05:57:15Z","updated_at":"2015-09-15T00:39:34Z","closed_at":"2015-09-15T00:39:34Z","body":"hey @sttung -\r\n\r\nnice work! sounds like you know a lot about diabetes. :)\r\n\r\ni liked how you did the list comprehension when you were plotting out the KNN accuracy as a function of K. it also helped me to see that your .fit functions took the df format directly. when i did my homework, I was not able to get the function to take df directly, so I did the following to convert into an array before putting them in the .fit function:\r\nX_train = X_train.values\r\nY_train = Y_train.values\r\n\r\nX_test = X_test.values\r\nY_test = Y_test.values\r\nYour code made me go back and try taking out those four lines. It turns out that my code was not necessary! Thank you!  :+1: \r\n\r\n@ghego @breucopter: this homework really made us get our hands dirty with python. :+1: \r\n"}}