{"action":"created","comment":{"url":"https://api.github.com/repos/zotero/zotero/pulls/comments/39836531","id":39836531,"diff_hunk":"@@ -46,13 +46,23 @@ Zotero.Collections = function() {\n \t\thasChildCollections: \"(SELECT COUNT(*) FROM collections WHERE \"\n \t\t\t+ \"parentCollectionID=O.collectionID) != 0 AS hasChildCollections\",\n \t\thasChildItems: \"(SELECT COUNT(*) FROM collectionItems WHERE \"\n-\t\t\t+ \"collectionID=O.collectionID) != 0 AS hasChildItems\"\n+\t\t\t+ \"collectionID=O.collectionID) != 0 AS hasChildItems\",\n \t};\n \t\n \t\t\n \tthis._primaryDataSQLFrom = \"FROM collections O \"\n-\t\t\t+ \"LEFT JOIN collections CP ON (O.parentCollectionID=CP.collectionID)\";\n+\t\t\t+ \"LEFT JOIN collections CP ON (O.parentCollectionID=CP.collectionID)\"\n \t\n+\tthis._relationsTable = \"collectionRelations\";\n+\t\n+\t// Choose correct item type when loading from DB row\n+\tthis._getObjectForRow = function(row) {\n+\t\tif (row.feedUrl) {\n+\t\t\treturn new Zotero.Feed();\n+\t\t}","path":"chrome/content/zotero/xpcom/data/collections.js","position":19,"original_position":19,"commit_id":"e27ad8fcb2d7a50fe2d53054623d3718fe3217a2","original_commit_id":"e27ad8fcb2d7a50fe2d53054623d3718fe3217a2","user":{"login":"aurimasv","id":1381759,"avatar_url":"https://avatars.githubusercontent.com/u/1381759?v=3","gravatar_id":"","url":"https://api.github.com/users/aurimasv","html_url":"https://github.com/aurimasv","followers_url":"https://api.github.com/users/aurimasv/followers","following_url":"https://api.github.com/users/aurimasv/following{/other_user}","gists_url":"https://api.github.com/users/aurimasv/gists{/gist_id}","starred_url":"https://api.github.com/users/aurimasv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurimasv/subscriptions","organizations_url":"https://api.github.com/users/aurimasv/orgs","repos_url":"https://api.github.com/users/aurimasv/repos","events_url":"https://api.github.com/users/aurimasv/events{/privacy}","received_events_url":"https://api.github.com/users/aurimasv/received_events","type":"User","site_admin":false},"body":"Another leftover chunk of code (sorry, making notes for myself)","created_at":"2015-09-18T09:07:16Z","updated_at":"2015-09-18T09:07:16Z","html_url":"https://github.com/zotero/zotero/pull/750#discussion_r39836531","pull_request_url":"https://api.github.com/repos/zotero/zotero/pulls/750","_links":{"self":{"href":"https://api.github.com/repos/zotero/zotero/pulls/comments/39836531"},"html":{"href":"https://github.com/zotero/zotero/pull/750#discussion_r39836531"},"pull_request":{"href":"https://api.github.com/repos/zotero/zotero/pulls/750"}}},"pull_request":{"url":"https://api.github.com/repos/zotero/zotero/pulls/750","id":36694574,"html_url":"https://github.com/zotero/zotero/pull/750","diff_url":"https://github.com/zotero/zotero/pull/750.diff","patch_url":"https://github.com/zotero/zotero/pull/750.patch","issue_url":"https://api.github.com/repos/zotero/zotero/issues/750","number":750,"state":"open","locked":false,"title":"[Feed Reader] Data layer","user":{"login":"aurimasv","id":1381759,"avatar_url":"https://avatars.githubusercontent.com/u/1381759?v=3","gravatar_id":"","url":"https://api.github.com/users/aurimasv","html_url":"https://github.com/aurimasv","followers_url":"https://api.github.com/users/aurimasv/followers","following_url":"https://api.github.com/users/aurimasv/following{/other_user}","gists_url":"https://api.github.com/users/aurimasv/gists{/gist_id}","starred_url":"https://api.github.com/users/aurimasv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurimasv/subscriptions","organizations_url":"https://api.github.com/users/aurimasv/orgs","repos_url":"https://api.github.com/users/aurimasv/repos","events_url":"https://api.github.com/users/aurimasv/events{/privacy}","received_events_url":"https://api.github.com/users/aurimasv/received_events","type":"User","site_admin":false},"body":"Let's try this.\r\n\r\nI still need to write more tests (and there are quite possibly some additional issues with the DB transactions), so don't read too much into it. It would probably be best to just look at the existing tests for now.","created_at":"2015-06-02T04:54:02Z","updated_at":"2015-09-18T09:07:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3da988aab163c3dc11e3c15cbaa7b8b08f26551f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zotero/zotero/pulls/750/commits","review_comments_url":"https://api.github.com/repos/zotero/zotero/pulls/750/comments","review_comment_url":"https://api.github.com/repos/zotero/zotero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zotero/zotero/issues/750/comments","statuses_url":"https://api.github.com/repos/zotero/zotero/statuses/e27ad8fcb2d7a50fe2d53054623d3718fe3217a2","head":{"label":"aurimasv:api_syncing-feed_reader-data_layer","ref":"api_syncing-feed_reader-data_layer","sha":"e27ad8fcb2d7a50fe2d53054623d3718fe3217a2","user":{"login":"aurimasv","id":1381759,"avatar_url":"https://avatars.githubusercontent.com/u/1381759?v=3","gravatar_id":"","url":"https://api.github.com/users/aurimasv","html_url":"https://github.com/aurimasv","followers_url":"https://api.github.com/users/aurimasv/followers","following_url":"https://api.github.com/users/aurimasv/following{/other_user}","gists_url":"https://api.github.com/users/aurimasv/gists{/gist_id}","starred_url":"https://api.github.com/users/aurimasv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurimasv/subscriptions","organizations_url":"https://api.github.com/users/aurimasv/orgs","repos_url":"https://api.github.com/users/aurimasv/repos","events_url":"https://api.github.com/users/aurimasv/events{/privacy}","received_events_url":"https://api.github.com/users/aurimasv/received_events","type":"User","site_admin":false},"repo":{"id":3656342,"name":"zotero","full_name":"aurimasv/zotero","owner":{"login":"aurimasv","id":1381759,"avatar_url":"https://avatars.githubusercontent.com/u/1381759?v=3","gravatar_id":"","url":"https://api.github.com/users/aurimasv","html_url":"https://github.com/aurimasv","followers_url":"https://api.github.com/users/aurimasv/followers","following_url":"https://api.github.com/users/aurimasv/following{/other_user}","gists_url":"https://api.github.com/users/aurimasv/gists{/gist_id}","starred_url":"https://api.github.com/users/aurimasv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurimasv/subscriptions","organizations_url":"https://api.github.com/users/aurimasv/orgs","repos_url":"https://api.github.com/users/aurimasv/repos","events_url":"https://api.github.com/users/aurimasv/events{/privacy}","received_events_url":"https://api.github.com/users/aurimasv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aurimasv/zotero","description":"","fork":true,"url":"https://api.github.com/repos/aurimasv/zotero","forks_url":"https://api.github.com/repos/aurimasv/zotero/forks","keys_url":"https://api.github.com/repos/aurimasv/zotero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurimasv/zotero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurimasv/zotero/teams","hooks_url":"https://api.github.com/repos/aurimasv/zotero/hooks","issue_events_url":"https://api.github.com/repos/aurimasv/zotero/issues/events{/number}","events_url":"https://api.github.com/repos/aurimasv/zotero/events","assignees_url":"https://api.github.com/repos/aurimasv/zotero/assignees{/user}","branches_url":"https://api.github.com/repos/aurimasv/zotero/branches{/branch}","tags_url":"https://api.github.com/repos/aurimasv/zotero/tags","blobs_url":"https://api.github.com/repos/aurimasv/zotero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurimasv/zotero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurimasv/zotero/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurimasv/zotero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurimasv/zotero/statuses/{sha}","languages_url":"https://api.github.com/repos/aurimasv/zotero/languages","stargazers_url":"https://api.github.com/repos/aurimasv/zotero/stargazers","contributors_url":"https://api.github.com/repos/aurimasv/zotero/contributors","subscribers_url":"https://api.github.com/repos/aurimasv/zotero/subscribers","subscription_url":"https://api.github.com/repos/aurimasv/zotero/subscription","commits_url":"https://api.github.com/repos/aurimasv/zotero/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurimasv/zotero/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurimasv/zotero/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurimasv/zotero/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurimasv/zotero/contents/{+path}","compare_url":"https://api.github.com/repos/aurimasv/zotero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurimasv/zotero/merges","archive_url":"https://api.github.com/repos/aurimasv/zotero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurimasv/zotero/downloads","issues_url":"https://api.github.com/repos/aurimasv/zotero/issues{/number}","pulls_url":"https://api.github.com/repos/aurimasv/zotero/pulls{/number}","milestones_url":"https://api.github.com/repos/aurimasv/zotero/milestones{/number}","notifications_url":"https://api.github.com/repos/aurimasv/zotero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurimasv/zotero/labels{/name}","releases_url":"https://api.github.com/repos/aurimasv/zotero/releases{/id}","created_at":"2012-03-08T03:22:17Z","updated_at":"2015-02-20T01:28:38Z","pushed_at":"2015-09-18T08:57:50Z","git_url":"git://github.com/aurimasv/zotero.git","ssh_url":"git@github.com:aurimasv/zotero.git","clone_url":"https://github.com/aurimasv/zotero.git","svn_url":"https://github.com/aurimasv/zotero","homepage":"https://zotero.org","size":64197,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":1,"default_branch":"api_syncing-feed-reader"}},"base":{"label":"zotero:master","ref":"master","sha":"b53892fe5458f0af8d63fc84dad640da7b00f883","user":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?v=3","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"repo":{"id":2656556,"name":"zotero","full_name":"zotero/zotero","owner":{"login":"zotero","id":891917,"avatar_url":"https://avatars.githubusercontent.com/u/891917?v=3","gravatar_id":"","url":"https://api.github.com/users/zotero","html_url":"https://github.com/zotero","followers_url":"https://api.github.com/users/zotero/followers","following_url":"https://api.github.com/users/zotero/following{/other_user}","gists_url":"https://api.github.com/users/zotero/gists{/gist_id}","starred_url":"https://api.github.com/users/zotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zotero/subscriptions","organizations_url":"https://api.github.com/users/zotero/orgs","repos_url":"https://api.github.com/users/zotero/repos","events_url":"https://api.github.com/users/zotero/events{/privacy}","received_events_url":"https://api.github.com/users/zotero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zotero/zotero","description":"Zotero is a free, easy-to-use tool to help you collect, organize, cite, and share your research sources.","fork":false,"url":"https://api.github.com/repos/zotero/zotero","forks_url":"https://api.github.com/repos/zotero/zotero/forks","keys_url":"https://api.github.com/repos/zotero/zotero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zotero/zotero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zotero/zotero/teams","hooks_url":"https://api.github.com/repos/zotero/zotero/hooks","issue_events_url":"https://api.github.com/repos/zotero/zotero/issues/events{/number}","events_url":"https://api.github.com/repos/zotero/zotero/events","assignees_url":"https://api.github.com/repos/zotero/zotero/assignees{/user}","branches_url":"https://api.github.com/repos/zotero/zotero/branches{/branch}","tags_url":"https://api.github.com/repos/zotero/zotero/tags","blobs_url":"https://api.github.com/repos/zotero/zotero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zotero/zotero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zotero/zotero/git/refs{/sha}","trees_url":"https://api.github.com/repos/zotero/zotero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zotero/zotero/statuses/{sha}","languages_url":"https://api.github.com/repos/zotero/zotero/languages","stargazers_url":"https://api.github.com/repos/zotero/zotero/stargazers","contributors_url":"https://api.github.com/repos/zotero/zotero/contributors","subscribers_url":"https://api.github.com/repos/zotero/zotero/subscribers","subscription_url":"https://api.github.com/repos/zotero/zotero/subscription","commits_url":"https://api.github.com/repos/zotero/zotero/commits{/sha}","git_commits_url":"https://api.github.com/repos/zotero/zotero/git/commits{/sha}","comments_url":"https://api.github.com/repos/zotero/zotero/comments{/number}","issue_comment_url":"https://api.github.com/repos/zotero/zotero/issues/comments{/number}","contents_url":"https://api.github.com/repos/zotero/zotero/contents/{+path}","compare_url":"https://api.github.com/repos/zotero/zotero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zotero/zotero/merges","archive_url":"https://api.github.com/repos/zotero/zotero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zotero/zotero/downloads","issues_url":"https://api.github.com/repos/zotero/zotero/issues{/number}","pulls_url":"https://api.github.com/repos/zotero/zotero/pulls{/number}","milestones_url":"https://api.github.com/repos/zotero/zotero/milestones{/number}","notifications_url":"https://api.github.com/repos/zotero/zotero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zotero/zotero/labels{/name}","releases_url":"https://api.github.com/repos/zotero/zotero/releases{/id}","created_at":"2011-10-27T07:46:48Z","updated_at":"2015-09-17T20:02:20Z","pushed_at":"2015-09-18T08:57:52Z","git_url":"git://github.com/zotero/zotero.git","ssh_url":"git@github.com:zotero/zotero.git","clone_url":"https://github.com/zotero/zotero.git","svn_url":"https://github.com/zotero/zotero","homepage":"https://www.zotero.org","size":88399,"stargazers_count":340,"watchers_count":340,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":316,"forks":127,"open_issues":316,"watchers":340,"default_branch":"4.0"}},"_links":{"self":{"href":"https://api.github.com/repos/zotero/zotero/pulls/750"},"html":{"href":"https://github.com/zotero/zotero/pull/750"},"issue":{"href":"https://api.github.com/repos/zotero/zotero/issues/750"},"comments":{"href":"https://api.github.com/repos/zotero/zotero/issues/750/comments"},"review_comments":{"href":"https://api.github.com/repos/zotero/zotero/pulls/750/comments"},"review_comment":{"href":"https://api.github.com/repos/zotero/zotero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zotero/zotero/pulls/750/commits"},"statuses":{"href":"https://api.github.com/repos/zotero/zotero/statuses/e27ad8fcb2d7a50fe2d53054623d3718fe3217a2"}}}}