{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember-rails/pulls/comments/23221339","id":23221339,"diff_hunk":"@@ -94,15 +94,46 @@ You can now use the flag `--javascript-engine=em` to specify EmberScript\n assets in your generators, but all of the generators will default to\n using an EmberScript variant first.\n \n+## For ES6 Modules support\n+\n+Ember.js recommends using ES6 module syntax.\n+It is supported by [es6_module_transpiler](https://github.com/dockyard/es6_module_transpiler-rails).\n+\n+Run the bootstrap generator with an extra flag:\n+\n+``` sh\n+rails g ember:bootstrap --javascript-engine=es6\n+```\n+\n Note:\n \n-Ember-rails include some flags options for bootstrap generator:\n+To use ES6 module in your application, the following configuration is required:\n+\n+`my_app.js.es6`\n+``` javascript\n+//= require ember-rails/application\n+// And require more modules...\n+\n+import Ember from 'ember-rails/application';\n+\n+var App = Ember.Application.extend();\n \n+App.craete();\n ```\n---ember-path or -d # custom ember path\n---skip-git or -g # skip git keeps\n---javascript-engine  # engine for javascript (js, coffee or em)\n---app-name or -n # custom ember app name\n+\n+`require ember-rails/application` is important.\n+It provides customized Ember application to resolve dependencies from ES6 modules.\n+\n+`application.js`\n+``` javascript\n+//= require jquery\n+//= require handlebars\n+//= require ember\n+//= require ember-data\n+//= require ./my_app","path":"README.md","position":54,"original_position":54,"commit_id":"53ad192759d7e094bd9401b33c4a247305302176","original_commit_id":"53ad192759d7e094bd9401b33c4a247305302176","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"body":"lets try to align this with ember-cli's conventions, all files/folders in the app are dasherized","created_at":"2015-01-20T13:26:17Z","updated_at":"2015-01-20T13:26:17Z","html_url":"https://github.com/emberjs/ember-rails/pull/416#discussion_r23221339","pull_request_url":"https://api.github.com/repos/emberjs/ember-rails/pulls/416","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-rails/pulls/comments/23221339"},"html":{"href":"https://github.com/emberjs/ember-rails/pull/416#discussion_r23221339"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember-rails/pulls/416"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember-rails/pulls/416","id":26418908,"html_url":"https://github.com/emberjs/ember-rails/pull/416","diff_url":"https://github.com/emberjs/ember-rails/pull/416.diff","patch_url":"https://github.com/emberjs/ember-rails/pull/416.patch","issue_url":"https://api.github.com/repos/emberjs/ember-rails/issues/416","number":416,"state":"open","locked":false,"title":"Support ES6 module syntax","user":{"login":"tricknotes","id":290782,"avatar_url":"https://avatars.githubusercontent.com/u/290782?v=3","gravatar_id":"","url":"https://api.github.com/users/tricknotes","html_url":"https://github.com/tricknotes","followers_url":"https://api.github.com/users/tricknotes/followers","following_url":"https://api.github.com/users/tricknotes/following{/other_user}","gists_url":"https://api.github.com/users/tricknotes/gists{/gist_id}","starred_url":"https://api.github.com/users/tricknotes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tricknotes/subscriptions","organizations_url":"https://api.github.com/users/tricknotes/orgs","repos_url":"https://api.github.com/users/tricknotes/repos","events_url":"https://api.github.com/users/tricknotes/events{/privacy}","received_events_url":"https://api.github.com/users/tricknotes/received_events","type":"User","site_admin":false},"body":"## Abstract\r\n\r\nWe can use es6 module syntax on asset pipeline.\r\nThis way is the same as [ember-cli](https://github.com/stefanpenner/ember-cli) .\r\n\r\nThe setting specified ember-rails is the followings:\r\n\r\n* `my_app.js.es6`\r\n  ``` javascript\r\n  //= require ember-rails/application\r\n  //= require_tree\r\n  //= require_self\r\n\r\n  import App from 'ember-rails/application';\r\n\r\n  App.create();\r\n  ```\r\n\r\n* `application.js`\r\n  ``` javascript\r\n  // = require ./my_app\r\n\r\n  require('my_app');\r\n  ```\r\n\r\n## TODO\r\n\r\n* [x] Support es6 module syntax\r\n* [x] Support generator option `javascript-engine=es6`\r\n* [x] Add test\r\n* [x] Write how to use es6 module syntax to README\r\n","created_at":"2014-12-20T17:57:09Z","updated_at":"2015-01-20T13:26:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b63e6a52621f2d3f42ddf290277c5bd6d3b0e63d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember-rails/pulls/416/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember-rails/pulls/416/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember-rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/emberjs/ember-rails/issues/416/comments","statuses_url":"https://api.github.com/repos/emberjs/ember-rails/statuses/53ad192759d7e094bd9401b33c4a247305302176","head":{"label":"emberjs:es6-module-syntax","ref":"es6-module-syntax","sha":"53ad192759d7e094bd9401b33c4a247305302176","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3091591,"name":"ember-rails","full_name":"emberjs/ember-rails","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember-rails","description":"Ember for Rails 3.1+","fork":false,"url":"https://api.github.com/repos/emberjs/ember-rails","forks_url":"https://api.github.com/repos/emberjs/ember-rails/forks","keys_url":"https://api.github.com/repos/emberjs/ember-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember-rails/teams","hooks_url":"https://api.github.com/repos/emberjs/ember-rails/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember-rails/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember-rails/events","assignees_url":"https://api.github.com/repos/emberjs/ember-rails/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember-rails/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember-rails/tags","blobs_url":"https://api.github.com/repos/emberjs/ember-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember-rails/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember-rails/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember-rails/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember-rails/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember-rails/subscription","commits_url":"https://api.github.com/repos/emberjs/ember-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember-rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/emberjs/ember-rails/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember-rails/merges","archive_url":"https://api.github.com/repos/emberjs/ember-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember-rails/downloads","issues_url":"https://api.github.com/repos/emberjs/ember-rails/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember-rails/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember-rails/releases{/id}","created_at":"2012-01-03T02:48:12Z","updated_at":"2015-01-20T03:04:43Z","pushed_at":"2015-01-01T10:06:42Z","git_url":"git://github.com/emberjs/ember-rails.git","ssh_url":"git@github.com:emberjs/ember-rails.git","clone_url":"https://github.com/emberjs/ember-rails.git","svn_url":"https://github.com/emberjs/ember-rails","homepage":"https://github.com/emberjs/ember-rails","size":9780,"stargazers_count":1162,"watchers_count":1162,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"open_issues_count":21,"forks":256,"open_issues":21,"watchers":1162,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"e2b5d367a3d724fedd8febf9876a2692e047fac4","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3091591,"name":"ember-rails","full_name":"emberjs/ember-rails","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember-rails","description":"Ember for Rails 3.1+","fork":false,"url":"https://api.github.com/repos/emberjs/ember-rails","forks_url":"https://api.github.com/repos/emberjs/ember-rails/forks","keys_url":"https://api.github.com/repos/emberjs/ember-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember-rails/teams","hooks_url":"https://api.github.com/repos/emberjs/ember-rails/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember-rails/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember-rails/events","assignees_url":"https://api.github.com/repos/emberjs/ember-rails/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember-rails/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember-rails/tags","blobs_url":"https://api.github.com/repos/emberjs/ember-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember-rails/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember-rails/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember-rails/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember-rails/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember-rails/subscription","commits_url":"https://api.github.com/repos/emberjs/ember-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember-rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/emberjs/ember-rails/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember-rails/merges","archive_url":"https://api.github.com/repos/emberjs/ember-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember-rails/downloads","issues_url":"https://api.github.com/repos/emberjs/ember-rails/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember-rails/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember-rails/releases{/id}","created_at":"2012-01-03T02:48:12Z","updated_at":"2015-01-20T03:04:43Z","pushed_at":"2015-01-01T10:06:42Z","git_url":"git://github.com/emberjs/ember-rails.git","ssh_url":"git@github.com:emberjs/ember-rails.git","clone_url":"https://github.com/emberjs/ember-rails.git","svn_url":"https://github.com/emberjs/ember-rails","homepage":"https://github.com/emberjs/ember-rails","size":9780,"stargazers_count":1162,"watchers_count":1162,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"open_issues_count":21,"forks":256,"open_issues":21,"watchers":1162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember-rails/pulls/416"},"html":{"href":"https://github.com/emberjs/ember-rails/pull/416"},"issue":{"href":"https://api.github.com/repos/emberjs/ember-rails/issues/416"},"comments":{"href":"https://api.github.com/repos/emberjs/ember-rails/issues/416/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember-rails/pulls/416/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember-rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember-rails/pulls/416/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember-rails/statuses/53ad192759d7e094bd9401b33c4a247305302176"}}}}