{"action":"opened","number":109,"pull_request":{"url":"https://api.github.com/repos/sbt/sbt-conductr/pulls/109","id":46540692,"html_url":"https://github.com/sbt/sbt-conductr/pull/109","diff_url":"https://github.com/sbt/sbt-conductr/pull/109.diff","patch_url":"https://github.com/sbt/sbt-conductr/pull/109.patch","issue_url":"https://api.github.com/repos/sbt/sbt-conductr/issues/109","number":109,"state":"open","locked":false,"title":"Merge bundle configurations","user":{"login":"markusjura","id":1832216,"avatar_url":"https://avatars.githubusercontent.com/u/1832216?v=3","gravatar_id":"","url":"https://api.github.com/users/markusjura","html_url":"https://github.com/markusjura","followers_url":"https://api.github.com/users/markusjura/followers","following_url":"https://api.github.com/users/markusjura/following{/other_user}","gists_url":"https://api.github.com/users/markusjura/gists{/gist_id}","starred_url":"https://api.github.com/users/markusjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusjura/subscriptions","organizations_url":"https://api.github.com/users/markusjura/orgs","repos_url":"https://api.github.com/users/markusjura/repos","events_url":"https://api.github.com/users/markusjura/events{/privacy}","received_events_url":"https://api.github.com/users/markusjura/received_events","type":"User","site_admin":false},"body":"This PR changes the `load bundle` logic. Instead of constructing the `LoadBundle` infos from the`BundleKeys`, the information are retrieved from the `bundle.conf`inside the bundle zip file.\r\n\r\nIf an additional configuration zip file (`configuration:dist`) is specified during `bundle load` then the infos of the `bundle.conf` inside the configuration zip file are used. These infos are overriding the values of the bundle.\r\n\r\nThis is the same logic as in the `conductr-cli`. It has been manually tested with and without additional configuration. Unit tests have not been provided, yet. First, @huntc should review the current approach. Afterwards I'll create tests for it.","created_at":"2015-10-01T15:45:09Z","updated_at":"2015-10-01T15:45:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sbt/sbt-conductr/pulls/109/commits","review_comments_url":"https://api.github.com/repos/sbt/sbt-conductr/pulls/109/comments","review_comment_url":"https://api.github.com/repos/sbt/sbt-conductr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sbt/sbt-conductr/issues/109/comments","statuses_url":"https://api.github.com/repos/sbt/sbt-conductr/statuses/e0a3e96f1433268eab40b4cfc59948e608910622","head":{"label":"markusjura:merge-config","ref":"merge-config","sha":"e0a3e96f1433268eab40b4cfc59948e608910622","user":{"login":"markusjura","id":1832216,"avatar_url":"https://avatars.githubusercontent.com/u/1832216?v=3","gravatar_id":"","url":"https://api.github.com/users/markusjura","html_url":"https://github.com/markusjura","followers_url":"https://api.github.com/users/markusjura/followers","following_url":"https://api.github.com/users/markusjura/following{/other_user}","gists_url":"https://api.github.com/users/markusjura/gists{/gist_id}","starred_url":"https://api.github.com/users/markusjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusjura/subscriptions","organizations_url":"https://api.github.com/users/markusjura/orgs","repos_url":"https://api.github.com/users/markusjura/repos","events_url":"https://api.github.com/users/markusjura/events{/privacy}","received_events_url":"https://api.github.com/users/markusjura/received_events","type":"User","site_admin":false},"repo":{"id":42823197,"name":"sbt-conductr","full_name":"markusjura/sbt-conductr","owner":{"login":"markusjura","id":1832216,"avatar_url":"https://avatars.githubusercontent.com/u/1832216?v=3","gravatar_id":"","url":"https://api.github.com/users/markusjura","html_url":"https://github.com/markusjura","followers_url":"https://api.github.com/users/markusjura/followers","following_url":"https://api.github.com/users/markusjura/following{/other_user}","gists_url":"https://api.github.com/users/markusjura/gists{/gist_id}","starred_url":"https://api.github.com/users/markusjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusjura/subscriptions","organizations_url":"https://api.github.com/users/markusjura/orgs","repos_url":"https://api.github.com/users/markusjura/repos","events_url":"https://api.github.com/users/markusjura/events{/privacy}","received_events_url":"https://api.github.com/users/markusjura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markusjura/sbt-conductr","description":"Typesafe ConductR plugin for sbt","fork":true,"url":"https://api.github.com/repos/markusjura/sbt-conductr","forks_url":"https://api.github.com/repos/markusjura/sbt-conductr/forks","keys_url":"https://api.github.com/repos/markusjura/sbt-conductr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markusjura/sbt-conductr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markusjura/sbt-conductr/teams","hooks_url":"https://api.github.com/repos/markusjura/sbt-conductr/hooks","issue_events_url":"https://api.github.com/repos/markusjura/sbt-conductr/issues/events{/number}","events_url":"https://api.github.com/repos/markusjura/sbt-conductr/events","assignees_url":"https://api.github.com/repos/markusjura/sbt-conductr/assignees{/user}","branches_url":"https://api.github.com/repos/markusjura/sbt-conductr/branches{/branch}","tags_url":"https://api.github.com/repos/markusjura/sbt-conductr/tags","blobs_url":"https://api.github.com/repos/markusjura/sbt-conductr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markusjura/sbt-conductr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markusjura/sbt-conductr/git/refs{/sha}","trees_url":"https://api.github.com/repos/markusjura/sbt-conductr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markusjura/sbt-conductr/statuses/{sha}","languages_url":"https://api.github.com/repos/markusjura/sbt-conductr/languages","stargazers_url":"https://api.github.com/repos/markusjura/sbt-conductr/stargazers","contributors_url":"https://api.github.com/repos/markusjura/sbt-conductr/contributors","subscribers_url":"https://api.github.com/repos/markusjura/sbt-conductr/subscribers","subscription_url":"https://api.github.com/repos/markusjura/sbt-conductr/subscription","commits_url":"https://api.github.com/repos/markusjura/sbt-conductr/commits{/sha}","git_commits_url":"https://api.github.com/repos/markusjura/sbt-conductr/git/commits{/sha}","comments_url":"https://api.github.com/repos/markusjura/sbt-conductr/comments{/number}","issue_comment_url":"https://api.github.com/repos/markusjura/sbt-conductr/issues/comments{/number}","contents_url":"https://api.github.com/repos/markusjura/sbt-conductr/contents/{+path}","compare_url":"https://api.github.com/repos/markusjura/sbt-conductr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markusjura/sbt-conductr/merges","archive_url":"https://api.github.com/repos/markusjura/sbt-conductr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markusjura/sbt-conductr/downloads","issues_url":"https://api.github.com/repos/markusjura/sbt-conductr/issues{/number}","pulls_url":"https://api.github.com/repos/markusjura/sbt-conductr/pulls{/number}","milestones_url":"https://api.github.com/repos/markusjura/sbt-conductr/milestones{/number}","notifications_url":"https://api.github.com/repos/markusjura/sbt-conductr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markusjura/sbt-conductr/labels{/name}","releases_url":"https://api.github.com/repos/markusjura/sbt-conductr/releases{/id}","created_at":"2015-09-20T17:57:48Z","updated_at":"2015-09-20T17:57:48Z","pushed_at":"2015-10-01T15:37:47Z","git_url":"git://github.com/markusjura/sbt-conductr.git","ssh_url":"git@github.com:markusjura/sbt-conductr.git","clone_url":"https://github.com/markusjura/sbt-conductr.git","svn_url":"https://github.com/markusjura/sbt-conductr","homepage":"","size":5176,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sbt:master","ref":"master","sha":"0a79568992358a0914bc8553d8f50a9c4a3a9ca2","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":26481223,"name":"sbt-conductr","full_name":"sbt/sbt-conductr","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars.githubusercontent.com/u/1158012?v=3","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/sbt-conductr","description":"Typesafe ConductR plugin for sbt","fork":false,"url":"https://api.github.com/repos/sbt/sbt-conductr","forks_url":"https://api.github.com/repos/sbt/sbt-conductr/forks","keys_url":"https://api.github.com/repos/sbt/sbt-conductr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/sbt-conductr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/sbt-conductr/teams","hooks_url":"https://api.github.com/repos/sbt/sbt-conductr/hooks","issue_events_url":"https://api.github.com/repos/sbt/sbt-conductr/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/sbt-conductr/events","assignees_url":"https://api.github.com/repos/sbt/sbt-conductr/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/sbt-conductr/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/sbt-conductr/tags","blobs_url":"https://api.github.com/repos/sbt/sbt-conductr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/sbt-conductr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/sbt-conductr/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/sbt-conductr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/sbt-conductr/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/sbt-conductr/languages","stargazers_url":"https://api.github.com/repos/sbt/sbt-conductr/stargazers","contributors_url":"https://api.github.com/repos/sbt/sbt-conductr/contributors","subscribers_url":"https://api.github.com/repos/sbt/sbt-conductr/subscribers","subscription_url":"https://api.github.com/repos/sbt/sbt-conductr/subscription","commits_url":"https://api.github.com/repos/sbt/sbt-conductr/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/sbt-conductr/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/sbt-conductr/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/sbt-conductr/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbt/sbt-conductr/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/sbt-conductr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/sbt-conductr/merges","archive_url":"https://api.github.com/repos/sbt/sbt-conductr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/sbt-conductr/downloads","issues_url":"https://api.github.com/repos/sbt/sbt-conductr/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/sbt-conductr/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/sbt-conductr/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/sbt-conductr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/sbt-conductr/labels{/name}","releases_url":"https://api.github.com/repos/sbt/sbt-conductr/releases{/id}","created_at":"2014-11-11T11:00:00Z","updated_at":"2015-06-22T06:04:12Z","pushed_at":"2015-09-29T07:04:57Z","git_url":"git://github.com/sbt/sbt-conductr.git","ssh_url":"git@github.com:sbt/sbt-conductr.git","clone_url":"https://github.com/sbt/sbt-conductr.git","svn_url":"https://github.com/sbt/sbt-conductr","homepage":"","size":5869,"stargazers_count":20,"watchers_count":20,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":8,"forks":10,"open_issues":8,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sbt/sbt-conductr/pulls/109"},"html":{"href":"https://github.com/sbt/sbt-conductr/pull/109"},"issue":{"href":"https://api.github.com/repos/sbt/sbt-conductr/issues/109"},"comments":{"href":"https://api.github.com/repos/sbt/sbt-conductr/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/sbt/sbt-conductr/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/sbt/sbt-conductr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sbt/sbt-conductr/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/sbt/sbt-conductr/statuses/e0a3e96f1433268eab40b4cfc59948e608910622"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":42,"deletions":22,"changed_files":1}}