{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/35533244","id":35533244,"diff_hunk":"@@ -3496,7 +3526,8 @@ bool map::open_door( const tripoint &p, const bool inside, const bool check_only\n         }\n \n         if(!check_only) {\n-            sounds::sound(p, 6, \"\", true, \"open_door\", furn.id);\n+            sounds::sound(p, 6, \"\", true, \"\", \"\");\n+            sfx::play_variant_sound( \"open_door\", ter.id, sfx::get_heard_volume(p));","path":"src/map.cpp","position":133,"original_position":133,"commit_id":"9ecc24070818b4ad194aa88112ca9235ae951165","original_commit_id":"9ecc24070818b4ad194aa88112ca9235ae951165","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"body":"Considering how often you write `get_heard_volume` in the call to `play_variant_sound` (like here), there should probably be an overload for `play_variant_sound`, which accepts a `tripoint` instead of the heard volume and calculates the volume itself:\r\n```C++\r\nvoid play_variant_sound( const std::string &a, const std::string &b, const tripoint &p ) {\r\n    play_variant_sound( a, b, get_heard_volume( p ) );\r\n}\r\n```\r\n\r\nAnyway, this PR has huge potential.\r\n","created_at":"2015-07-27T13:12:13Z","updated_at":"2015-07-27T13:12:13Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13081#discussion_r35533244","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13081","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/35533244"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13081#discussion_r35533244"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13081"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13081","id":40875064,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13081","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13081.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13081.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13081","number":13081,"state":"open","locked":false,"title":"Ambient Sounds - Now with less sounds!","user":{"login":"Chezzo","id":2432177,"avatar_url":"https://avatars.githubusercontent.com/u/2432177?v=3","gravatar_id":"","url":"https://api.github.com/users/Chezzo","html_url":"https://github.com/Chezzo","followers_url":"https://api.github.com/users/Chezzo/followers","following_url":"https://api.github.com/users/Chezzo/following{/other_user}","gists_url":"https://api.github.com/users/Chezzo/gists{/gist_id}","starred_url":"https://api.github.com/users/Chezzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chezzo/subscriptions","organizations_url":"https://api.github.com/users/Chezzo/orgs","repos_url":"https://api.github.com/users/Chezzo/repos","events_url":"https://api.github.com/users/Chezzo/events{/privacy}","received_events_url":"https://api.github.com/users/Chezzo/received_events","type":"User","site_admin":false},"body":"This is Vulkans' ambient sounds framework with a few changes to get it to compile by me. It adds multiple sounds at the same time, hooks for reloading sounds, weather sounds, death sounds, and lots lots more.","created_at":"2015-07-27T07:00:04Z","updated_at":"2015-07-27T13:12:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13081/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13081/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13081/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/9ecc24070818b4ad194aa88112ca9235ae951165","head":{"label":"Chezzo:ambient-sounds","ref":"ambient-sounds","sha":"9ecc24070818b4ad194aa88112ca9235ae951165","user":{"login":"Chezzo","id":2432177,"avatar_url":"https://avatars.githubusercontent.com/u/2432177?v=3","gravatar_id":"","url":"https://api.github.com/users/Chezzo","html_url":"https://github.com/Chezzo","followers_url":"https://api.github.com/users/Chezzo/followers","following_url":"https://api.github.com/users/Chezzo/following{/other_user}","gists_url":"https://api.github.com/users/Chezzo/gists{/gist_id}","starred_url":"https://api.github.com/users/Chezzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chezzo/subscriptions","organizations_url":"https://api.github.com/users/Chezzo/orgs","repos_url":"https://api.github.com/users/Chezzo/repos","events_url":"https://api.github.com/users/Chezzo/events{/privacy}","received_events_url":"https://api.github.com/users/Chezzo/received_events","type":"User","site_admin":false},"repo":{"id":31399362,"name":"Cataclysm-DDA","full_name":"Chezzo/Cataclysm-DDA","owner":{"login":"Chezzo","id":2432177,"avatar_url":"https://avatars.githubusercontent.com/u/2432177?v=3","gravatar_id":"","url":"https://api.github.com/users/Chezzo","html_url":"https://github.com/Chezzo","followers_url":"https://api.github.com/users/Chezzo/followers","following_url":"https://api.github.com/users/Chezzo/following{/other_user}","gists_url":"https://api.github.com/users/Chezzo/gists{/gist_id}","starred_url":"https://api.github.com/users/Chezzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chezzo/subscriptions","organizations_url":"https://api.github.com/users/Chezzo/orgs","repos_url":"https://api.github.com/users/Chezzo/repos","events_url":"https://api.github.com/users/Chezzo/events{/privacy}","received_events_url":"https://api.github.com/users/Chezzo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Chezzo/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA","forks_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/Chezzo/Cataclysm-DDA/releases{/id}","created_at":"2015-02-27T02:18:09Z","updated_at":"2015-06-01T17:54:24Z","pushed_at":"2015-07-27T06:58:07Z","git_url":"git://github.com/Chezzo/Cataclysm-DDA.git","ssh_url":"git@github.com:Chezzo/Cataclysm-DDA.git","clone_url":"https://github.com/Chezzo/Cataclysm-DDA.git","svn_url":"https://github.com/Chezzo/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":671741,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"ad4d55c8b12a0281c69e8338c60d6ae0eadd6a24","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-07-27T00:17:12Z","pushed_at":"2015-07-27T12:18:44Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":575245,"stargazers_count":705,"watchers_count":705,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":741,"mirror_url":null,"open_issues_count":1016,"forks":741,"open_issues":1016,"watchers":705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13081"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13081"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13081"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13081/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13081/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13081/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/9ecc24070818b4ad194aa88112ca9235ae951165"}}}}