{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/comments/32236625","id":32236625,"diff_hunk":"@@ -0,0 +1,84 @@\n+module LogStash::PluginMixins::AwsConfig::V1\n+  # This method is called when someone includes this module","path":"lib/logstash/plugin_mixins/aws_config/v1.rb","position":2,"original_position":2,"commit_id":"b4e19d307c4420ecbb9beb8a42b66f61658f69f3","original_commit_id":"b4e19d307c4420ecbb9beb8a42b66f61658f69f3","user":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"body":"This is comment necessary? (I know you just copies here as it was before) (_small style comment_)","created_at":"2015-06-11T15:58:32Z","updated_at":"2015-06-11T15:58:32Z","html_url":"https://github.com/logstash-plugins/logstash-mixin-aws/pull/13#discussion_r32236625","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/comments/32236625"},"html":{"href":"https://github.com/logstash-plugins/logstash-mixin-aws/pull/13#discussion_r32236625"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/13","id":37208229,"html_url":"https://github.com/logstash-plugins/logstash-mixin-aws/pull/13","diff_url":"https://github.com/logstash-plugins/logstash-mixin-aws/pull/13.diff","patch_url":"https://github.com/logstash-plugins/logstash-mixin-aws/pull/13.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/issues/13","number":13,"state":"open","locked":false,"title":"Fix/aws sdk v2","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"body":"If you include the module `LogStash::PluginMixins::AwsConfig` it will\r\nuse the V1 Api, if your plugin require the V2 Api make sure to include\r\nthe `LogStash::PluginMixins::AwsConfig::V2`.\r\n\r\nThis change was necessary because of how our dependencies works, if you\r\ninstall a plugin that need the V2 api it will install a newer version of the\r\nmixin. Previously installed plugins dependeing on the v1 api wont be updated.\r\n\r\nChanges include:\r\n- The V2 module also use the `Aws::Credentials` class when generating\r\n  the options hash.\r\n- If the plugin doesn't implement the `#aws_service_endpoint` method it\r\n  will fallback to `{ :region => 'east-1'}` (V2 only)\r\n- `use_ssl` option is now deprecated and its not in use in the V2 code, the\r\n  new version of the API now set it to true and only recommended to turn\r\n  it off when doing local testing.\r\n\r\nfixes #8","created_at":"2015-06-08T23:59:46Z","updated_at":"2015-06-11T15:58:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd532a0cfbfeb293c61b74961ca1fe723e5bc629","assignee":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/13/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/13/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/issues/13/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/statuses/b4e19d307c4420ecbb9beb8a42b66f61658f69f3","head":{"label":"ph:fix/aws-sdk-v2","ref":"fix/aws-sdk-v2","sha":"b4e19d307c4420ecbb9beb8a42b66f61658f69f3","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"repo":{"id":26241903,"name":"logstash-mixin-aws","full_name":"ph/logstash-mixin-aws","owner":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ph/logstash-mixin-aws","description":"","fork":true,"url":"https://api.github.com/repos/ph/logstash-mixin-aws","forks_url":"https://api.github.com/repos/ph/logstash-mixin-aws/forks","keys_url":"https://api.github.com/repos/ph/logstash-mixin-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ph/logstash-mixin-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ph/logstash-mixin-aws/teams","hooks_url":"https://api.github.com/repos/ph/logstash-mixin-aws/hooks","issue_events_url":"https://api.github.com/repos/ph/logstash-mixin-aws/issues/events{/number}","events_url":"https://api.github.com/repos/ph/logstash-mixin-aws/events","assignees_url":"https://api.github.com/repos/ph/logstash-mixin-aws/assignees{/user}","branches_url":"https://api.github.com/repos/ph/logstash-mixin-aws/branches{/branch}","tags_url":"https://api.github.com/repos/ph/logstash-mixin-aws/tags","blobs_url":"https://api.github.com/repos/ph/logstash-mixin-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ph/logstash-mixin-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ph/logstash-mixin-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/ph/logstash-mixin-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ph/logstash-mixin-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/ph/logstash-mixin-aws/languages","stargazers_url":"https://api.github.com/repos/ph/logstash-mixin-aws/stargazers","contributors_url":"https://api.github.com/repos/ph/logstash-mixin-aws/contributors","subscribers_url":"https://api.github.com/repos/ph/logstash-mixin-aws/subscribers","subscription_url":"https://api.github.com/repos/ph/logstash-mixin-aws/subscription","commits_url":"https://api.github.com/repos/ph/logstash-mixin-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/ph/logstash-mixin-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/ph/logstash-mixin-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/ph/logstash-mixin-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/ph/logstash-mixin-aws/contents/{+path}","compare_url":"https://api.github.com/repos/ph/logstash-mixin-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ph/logstash-mixin-aws/merges","archive_url":"https://api.github.com/repos/ph/logstash-mixin-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ph/logstash-mixin-aws/downloads","issues_url":"https://api.github.com/repos/ph/logstash-mixin-aws/issues{/number}","pulls_url":"https://api.github.com/repos/ph/logstash-mixin-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/ph/logstash-mixin-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/ph/logstash-mixin-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ph/logstash-mixin-aws/labels{/name}","releases_url":"https://api.github.com/repos/ph/logstash-mixin-aws/releases{/id}","created_at":"2014-11-05T22:06:03Z","updated_at":"2014-11-06T15:41:40Z","pushed_at":"2015-06-09T00:02:07Z","git_url":"git://github.com/ph/logstash-mixin-aws.git","ssh_url":"git@github.com:ph/logstash-mixin-aws.git","clone_url":"https://github.com/ph/logstash-mixin-aws.git","svn_url":"https://github.com/ph/logstash-mixin-aws","homepage":null,"size":168,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"e96656c897b70a0564cc759ddddce41c1411372f","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":26175627,"name":"logstash-mixin-aws","full_name":"logstash-plugins/logstash-mixin-aws","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-mixin-aws","description":"","fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/releases{/id}","created_at":"2014-11-04T15:43:07Z","updated_at":"2015-05-07T19:56:20Z","pushed_at":"2015-06-09T00:02:08Z","git_url":"git://github.com/logstash-plugins/logstash-mixin-aws.git","ssh_url":"git@github.com:logstash-plugins/logstash-mixin-aws.git","clone_url":"https://github.com/logstash-plugins/logstash-mixin-aws.git","svn_url":"https://github.com/logstash-plugins/logstash-mixin-aws","homepage":null,"size":396,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/13"},"html":{"href":"https://github.com/logstash-plugins/logstash-mixin-aws/pull/13"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/issues/13"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-mixin-aws/statuses/b4e19d307c4420ecbb9beb8a42b66f61658f69f3"}}}}