{"action":"closed","number":635,"pull_request":{"url":"https://api.github.com/repos/jfryman/puppet-nginx/pulls/635","id":36542096,"html_url":"https://github.com/jfryman/puppet-nginx/pull/635","diff_url":"https://github.com/jfryman/puppet-nginx/pull/635.diff","patch_url":"https://github.com/jfryman/puppet-nginx/pull/635.patch","issue_url":"https://api.github.com/repos/jfryman/puppet-nginx/issues/635","number":635,"state":"closed","locked":false,"title":"Create directory for log files","user":{"login":"geoffgarside","id":2704,"avatar_url":"https://avatars.githubusercontent.com/u/2704?v=3","gravatar_id":"","url":"https://api.github.com/users/geoffgarside","html_url":"https://github.com/geoffgarside","followers_url":"https://api.github.com/users/geoffgarside/followers","following_url":"https://api.github.com/users/geoffgarside/following{/other_user}","gists_url":"https://api.github.com/users/geoffgarside/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffgarside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffgarside/subscriptions","organizations_url":"https://api.github.com/users/geoffgarside/orgs","repos_url":"https://api.github.com/users/geoffgarside/repos","events_url":"https://api.github.com/users/geoffgarside/events{/privacy}","received_events_url":"https://api.github.com/users/geoffgarside/received_events","type":"User","site_admin":false},"body":"I've added loose management and creation of the nginx access log and error log files. If they don't exist then nginx will not pass its config test and won't start up (on FreeBSD at least), so these files need to exist prior to nginx being started or reloaded.\r\n\r\nI've included specs which are passing, and I think testing the right things I'm not very familiar with testing puppet yet. Testing my branch on a virtual machine results in a successfully started nginx service too.\r\n\r\nI also think I've managed to stick to the style guidelines, I've run the `rake lint`, `rake syntax` and `rake validate` tasks and I think they've all passed as well.\r\n\r\nI'm not sure if this is the right thing to do or not though\r\n\r\n``` puppet\r\nif $vhost_purge == true {\r\n   File[$log_dir] {\r\n     purge   => true,\r\n     recurse => true,\r\n   }\r\n}\r\n```\r\n\r\nFixes #619 ","created_at":"2015-05-29T20:29:13Z","updated_at":"2015-06-04T02:51:17Z","closed_at":"2015-06-04T02:51:17Z","merged_at":"2015-06-04T02:51:17Z","merge_commit_sha":"bfc6e4d2f28cc0eff891612184d79698bae71b50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jfryman/puppet-nginx/pulls/635/commits","review_comments_url":"https://api.github.com/repos/jfryman/puppet-nginx/pulls/635/comments","review_comment_url":"https://api.github.com/repos/jfryman/puppet-nginx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jfryman/puppet-nginx/issues/635/comments","statuses_url":"https://api.github.com/repos/jfryman/puppet-nginx/statuses/27334c1bd4321c5965192f8f8e17e585846b2990","head":{"label":"geoffgarside:create-log-files","ref":"create-log-files","sha":"27334c1bd4321c5965192f8f8e17e585846b2990","user":{"login":"geoffgarside","id":2704,"avatar_url":"https://avatars.githubusercontent.com/u/2704?v=3","gravatar_id":"","url":"https://api.github.com/users/geoffgarside","html_url":"https://github.com/geoffgarside","followers_url":"https://api.github.com/users/geoffgarside/followers","following_url":"https://api.github.com/users/geoffgarside/following{/other_user}","gists_url":"https://api.github.com/users/geoffgarside/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffgarside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffgarside/subscriptions","organizations_url":"https://api.github.com/users/geoffgarside/orgs","repos_url":"https://api.github.com/users/geoffgarside/repos","events_url":"https://api.github.com/users/geoffgarside/events{/privacy}","received_events_url":"https://api.github.com/users/geoffgarside/received_events","type":"User","site_admin":false},"repo":{"id":36470080,"name":"puppet-nginx-1","full_name":"geoffgarside/puppet-nginx-1","owner":{"login":"geoffgarside","id":2704,"avatar_url":"https://avatars.githubusercontent.com/u/2704?v=3","gravatar_id":"","url":"https://api.github.com/users/geoffgarside","html_url":"https://github.com/geoffgarside","followers_url":"https://api.github.com/users/geoffgarside/followers","following_url":"https://api.github.com/users/geoffgarside/following{/other_user}","gists_url":"https://api.github.com/users/geoffgarside/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffgarside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffgarside/subscriptions","organizations_url":"https://api.github.com/users/geoffgarside/orgs","repos_url":"https://api.github.com/users/geoffgarside/repos","events_url":"https://api.github.com/users/geoffgarside/events{/privacy}","received_events_url":"https://api.github.com/users/geoffgarside/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geoffgarside/puppet-nginx-1","description":"Puppet Module to manage NGINX on various UNIXes","fork":true,"url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1","forks_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/forks","keys_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/teams","hooks_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/hooks","issue_events_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/issues/events{/number}","events_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/events","assignees_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/assignees{/user}","branches_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/branches{/branch}","tags_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/tags","blobs_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/statuses/{sha}","languages_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/languages","stargazers_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/stargazers","contributors_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/contributors","subscribers_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/subscribers","subscription_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/subscription","commits_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/contents/{+path}","compare_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/merges","archive_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/downloads","issues_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/issues{/number}","pulls_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/pulls{/number}","milestones_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/milestones{/number}","notifications_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/labels{/name}","releases_url":"https://api.github.com/repos/geoffgarside/puppet-nginx-1/releases{/id}","created_at":"2015-05-28T22:40:04Z","updated_at":"2015-05-28T22:40:04Z","pushed_at":"2015-06-03T19:44:30Z","git_url":"git://github.com/geoffgarside/puppet-nginx-1.git","ssh_url":"git@github.com:geoffgarside/puppet-nginx-1.git","clone_url":"https://github.com/geoffgarside/puppet-nginx-1.git","svn_url":"https://github.com/geoffgarside/puppet-nginx-1","homepage":"","size":1318,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jfryman:master","ref":"master","sha":"517dba1cd9c6be815129c145d2f42c64d6cf67fd","user":{"login":"jfryman","id":20028,"avatar_url":"https://avatars.githubusercontent.com/u/20028?v=3","gravatar_id":"","url":"https://api.github.com/users/jfryman","html_url":"https://github.com/jfryman","followers_url":"https://api.github.com/users/jfryman/followers","following_url":"https://api.github.com/users/jfryman/following{/other_user}","gists_url":"https://api.github.com/users/jfryman/gists{/gist_id}","starred_url":"https://api.github.com/users/jfryman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfryman/subscriptions","organizations_url":"https://api.github.com/users/jfryman/orgs","repos_url":"https://api.github.com/users/jfryman/repos","events_url":"https://api.github.com/users/jfryman/events{/privacy}","received_events_url":"https://api.github.com/users/jfryman/received_events","type":"User","site_admin":false},"repo":{"id":1791219,"name":"puppet-nginx","full_name":"jfryman/puppet-nginx","owner":{"login":"jfryman","id":20028,"avatar_url":"https://avatars.githubusercontent.com/u/20028?v=3","gravatar_id":"","url":"https://api.github.com/users/jfryman","html_url":"https://github.com/jfryman","followers_url":"https://api.github.com/users/jfryman/followers","following_url":"https://api.github.com/users/jfryman/following{/other_user}","gists_url":"https://api.github.com/users/jfryman/gists{/gist_id}","starred_url":"https://api.github.com/users/jfryman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfryman/subscriptions","organizations_url":"https://api.github.com/users/jfryman/orgs","repos_url":"https://api.github.com/users/jfryman/repos","events_url":"https://api.github.com/users/jfryman/events{/privacy}","received_events_url":"https://api.github.com/users/jfryman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jfryman/puppet-nginx","description":"Puppet Module to manage NGINX on various UNIXes","fork":false,"url":"https://api.github.com/repos/jfryman/puppet-nginx","forks_url":"https://api.github.com/repos/jfryman/puppet-nginx/forks","keys_url":"https://api.github.com/repos/jfryman/puppet-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfryman/puppet-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfryman/puppet-nginx/teams","hooks_url":"https://api.github.com/repos/jfryman/puppet-nginx/hooks","issue_events_url":"https://api.github.com/repos/jfryman/puppet-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/jfryman/puppet-nginx/events","assignees_url":"https://api.github.com/repos/jfryman/puppet-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/jfryman/puppet-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/jfryman/puppet-nginx/tags","blobs_url":"https://api.github.com/repos/jfryman/puppet-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfryman/puppet-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfryman/puppet-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfryman/puppet-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfryman/puppet-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/jfryman/puppet-nginx/languages","stargazers_url":"https://api.github.com/repos/jfryman/puppet-nginx/stargazers","contributors_url":"https://api.github.com/repos/jfryman/puppet-nginx/contributors","subscribers_url":"https://api.github.com/repos/jfryman/puppet-nginx/subscribers","subscription_url":"https://api.github.com/repos/jfryman/puppet-nginx/subscription","commits_url":"https://api.github.com/repos/jfryman/puppet-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfryman/puppet-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfryman/puppet-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfryman/puppet-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/jfryman/puppet-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/jfryman/puppet-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfryman/puppet-nginx/merges","archive_url":"https://api.github.com/repos/jfryman/puppet-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfryman/puppet-nginx/downloads","issues_url":"https://api.github.com/repos/jfryman/puppet-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/jfryman/puppet-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/jfryman/puppet-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/jfryman/puppet-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfryman/puppet-nginx/labels{/name}","releases_url":"https://api.github.com/repos/jfryman/puppet-nginx/releases{/id}","created_at":"2011-05-24T01:53:48Z","updated_at":"2015-05-22T04:38:40Z","pushed_at":"2015-06-04T02:51:17Z","git_url":"git://github.com/jfryman/puppet-nginx.git","ssh_url":"git@github.com:jfryman/puppet-nginx.git","clone_url":"https://github.com/jfryman/puppet-nginx.git","svn_url":"https://github.com/jfryman/puppet-nginx","homepage":"","size":4986,"stargazers_count":297,"watchers_count":297,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":523,"mirror_url":null,"open_issues_count":58,"forks":523,"open_issues":58,"watchers":297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/pulls/635"},"html":{"href":"https://github.com/jfryman/puppet-nginx/pull/635"},"issue":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/issues/635"},"comments":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/jfryman/puppet-nginx/statuses/27334c1bd4321c5965192f8f8e17e585846b2990"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"3flex","id":170028,"avatar_url":"https://avatars.githubusercontent.com/u/170028?v=3","gravatar_id":"","url":"https://api.github.com/users/3flex","html_url":"https://github.com/3flex","followers_url":"https://api.github.com/users/3flex/followers","following_url":"https://api.github.com/users/3flex/following{/other_user}","gists_url":"https://api.github.com/users/3flex/gists{/gist_id}","starred_url":"https://api.github.com/users/3flex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3flex/subscriptions","organizations_url":"https://api.github.com/users/3flex/orgs","repos_url":"https://api.github.com/users/3flex/repos","events_url":"https://api.github.com/users/3flex/events{/privacy}","received_events_url":"https://api.github.com/users/3flex/received_events","type":"User","site_admin":false},"comments":12,"review_comments":0,"commits":1,"additions":15,"deletions":0,"changed_files":2}}