{"action":"created","comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/46953970","id":46953970,"diff_hunk":"@@ -231,8 +231,8 @@ class MovingWindow\n             float_64 offsetFirstGPU = 0.0;\n             getCurrentSlideInfo(currentStep, NULL, &offsetFirstGPU);\n \n-            /* global offset is all 0 except for y dimension */\n-            window.globalDimensions.offset.y() = offsetFirstGPU;\n+            /* moving window can only slide in y direction */\n+            window.globalDimensions.offset.y() += offsetFirstGPU;","path":"src/picongpu/include/simulationControl/MovingWindow.hpp","position":18,"original_position":18,"commit_id":"2128d571a63be90ab67b1e2ad15ca70e1cf45f7a","original_commit_id":"2128d571a63be90ab67b1e2ad15ca70e1cf45f7a","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"new comment:\r\n```c++\r\n/* while moving, the windows global offset within the global domain is between 0\r\n * and smaller than the local domain's size in y.\r\n */\r\n```","created_at":"2015-12-08T13:47:44Z","updated_at":"2015-12-08T13:47:44Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1273#discussion_r46953970","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1273","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/46953970"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1273#discussion_r46953970"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1273"}}},"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1273","id":51979761,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1273","diff_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1273.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1273.patch","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1273","number":1273,"state":"open","locked":false,"title":"Fix MovingWindow localDimension","user":{"login":"psychocoderHPC","id":4037125,"avatar_url":"https://avatars.githubusercontent.com/u/4037125?v=3","gravatar_id":"","url":"https://api.github.com/users/psychocoderHPC","html_url":"https://github.com/psychocoderHPC","followers_url":"https://api.github.com/users/psychocoderHPC/followers","following_url":"https://api.github.com/users/psychocoderHPC/following{/other_user}","gists_url":"https://api.github.com/users/psychocoderHPC/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocoderHPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocoderHPC/subscriptions","organizations_url":"https://api.github.com/users/psychocoderHPC/orgs","repos_url":"https://api.github.com/users/psychocoderHPC/repos","events_url":"https://api.github.com/users/psychocoderHPC/events{/privacy}","received_events_url":"https://api.github.com/users/psychocoderHPC/received_events","type":"User","site_admin":false},"body":"- close #568 *MovingWindow localDimension Values Not Updated*\r\n- fix that offsets for local and global dimensions always set to zero\r\n- copy full selction from `SubGrid` instead only the size\r\n- remove hard overwrite of the global window offset by add tu current value\r\n\r\nAdditional to the `window.localDimensions.offset` the `window.globalDimensions.offset` was also always zero.\r\n\r\n- [x] merge after #1272\r\n\r\nTests:\r\n- [x] HDF5 checkpoints LWFA with moving window; simulate 2k steps and restart from step 2k (simulate to step 3k)\r\n- [x] ADIOS checkpoints LWFA with moving window; simulate 2k steps and restart from step 2k (simulate to step 3k)\r\n- [x] LWFA with moving window - HDF5 plugin enabled; simulate 4k steps (checked with HDFView  -> picture; slice each dimension)\r\n- [x] LWFA with moving window - ADIOS plugin enabled; simulate 4k steps","created_at":"2015-11-27T10:26:35Z","updated_at":"2015-12-08T13:47:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a99a655cf0260f41099491d1e2b574924749ee5","assignee":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/milestones/Open%20Beta","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2/labels","id":395839,"number":2,"title":"Open Beta","description":"Tasks to complete until the release of our open beta (version 0.1)\r\n\r\nThe [beta](https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta) release shall be useful for *physicist* that used a Particle-in-Cell code *before*. Experience with *compiling libraries from source* and a *good Linux knowledge* is required for the initial installation.\r\n","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":143,"closed_issues":1045,"state":"open","created_at":"2013-08-06T16:38:57Z","updated_at":"2015-12-08T09:35:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1273/commits","review_comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1273/comments","review_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1273/comments","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/2128d571a63be90ab67b1e2ad15ca70e1cf45f7a","head":{"label":"psychocoderHPC:fix-movingWindowBug","ref":"fix-movingWindowBug","sha":"2128d571a63be90ab67b1e2ad15ca70e1cf45f7a","user":{"login":"psychocoderHPC","id":4037125,"avatar_url":"https://avatars.githubusercontent.com/u/4037125?v=3","gravatar_id":"","url":"https://api.github.com/users/psychocoderHPC","html_url":"https://github.com/psychocoderHPC","followers_url":"https://api.github.com/users/psychocoderHPC/followers","following_url":"https://api.github.com/users/psychocoderHPC/following{/other_user}","gists_url":"https://api.github.com/users/psychocoderHPC/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocoderHPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocoderHPC/subscriptions","organizations_url":"https://api.github.com/users/psychocoderHPC/orgs","repos_url":"https://api.github.com/users/psychocoderHPC/repos","events_url":"https://api.github.com/users/psychocoderHPC/events{/privacy}","received_events_url":"https://api.github.com/users/psychocoderHPC/received_events","type":"User","site_admin":false},"repo":{"id":12103789,"name":"picongpu","full_name":"psychocoderHPC/picongpu","owner":{"login":"psychocoderHPC","id":4037125,"avatar_url":"https://avatars.githubusercontent.com/u/4037125?v=3","gravatar_id":"","url":"https://api.github.com/users/psychocoderHPC","html_url":"https://github.com/psychocoderHPC","followers_url":"https://api.github.com/users/psychocoderHPC/followers","following_url":"https://api.github.com/users/psychocoderHPC/following{/other_user}","gists_url":"https://api.github.com/users/psychocoderHPC/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocoderHPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocoderHPC/subscriptions","organizations_url":"https://api.github.com/users/psychocoderHPC/orgs","repos_url":"https://api.github.com/users/psychocoderHPC/repos","events_url":"https://api.github.com/users/psychocoderHPC/events{/privacy}","received_events_url":"https://api.github.com/users/psychocoderHPC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psychocoderHPC/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":true,"url":"https://api.github.com/repos/psychocoderHPC/picongpu","forks_url":"https://api.github.com/repos/psychocoderHPC/picongpu/forks","keys_url":"https://api.github.com/repos/psychocoderHPC/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psychocoderHPC/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psychocoderHPC/picongpu/teams","hooks_url":"https://api.github.com/repos/psychocoderHPC/picongpu/hooks","issue_events_url":"https://api.github.com/repos/psychocoderHPC/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/psychocoderHPC/picongpu/events","assignees_url":"https://api.github.com/repos/psychocoderHPC/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/psychocoderHPC/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/psychocoderHPC/picongpu/tags","blobs_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psychocoderHPC/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/psychocoderHPC/picongpu/languages","stargazers_url":"https://api.github.com/repos/psychocoderHPC/picongpu/stargazers","contributors_url":"https://api.github.com/repos/psychocoderHPC/picongpu/contributors","subscribers_url":"https://api.github.com/repos/psychocoderHPC/picongpu/subscribers","subscription_url":"https://api.github.com/repos/psychocoderHPC/picongpu/subscription","commits_url":"https://api.github.com/repos/psychocoderHPC/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/psychocoderHPC/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/psychocoderHPC/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/psychocoderHPC/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/psychocoderHPC/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psychocoderHPC/picongpu/merges","archive_url":"https://api.github.com/repos/psychocoderHPC/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psychocoderHPC/picongpu/downloads","issues_url":"https://api.github.com/repos/psychocoderHPC/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/psychocoderHPC/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/psychocoderHPC/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/psychocoderHPC/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psychocoderHPC/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/psychocoderHPC/picongpu/releases{/id}","created_at":"2013-08-14T08:23:46Z","updated_at":"2015-10-14T10:57:17Z","pushed_at":"2015-12-08T09:35:21Z","git_url":"git://github.com/psychocoderHPC/picongpu.git","ssh_url":"git@github.com:psychocoderHPC/picongpu.git","clone_url":"https://github.com/psychocoderHPC/picongpu.git","svn_url":"https://github.com/psychocoderHPC/picongpu","homepage":"http://picongpu.hzdr.de","size":59178,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"dev"}},"base":{"label":"ComputationalRadiationPhysics:dev","ref":"dev","sha":"c90f507eee020563ab050dbbfdf856a9f2fa6709","user":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"repo":{"id":11764461,"name":"picongpu","full_name":"ComputationalRadiationPhysics/picongpu","owner":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":false,"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu","forks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/forks","keys_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/teams","hooks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/events","assignees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/tags","blobs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/languages","stargazers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscription","commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/merges","archive_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/downloads","issues_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/releases{/id}","created_at":"2013-07-30T12:28:20Z","updated_at":"2015-11-20T16:27:08Z","pushed_at":"2015-12-08T09:36:00Z","git_url":"git://github.com/ComputationalRadiationPhysics/picongpu.git","ssh_url":"git@github.com:ComputationalRadiationPhysics/picongpu.git","clone_url":"https://github.com/ComputationalRadiationPhysics/picongpu.git","svn_url":"https://github.com/ComputationalRadiationPhysics/picongpu","homepage":"http://picongpu.hzdr.de","size":10304,"stargazers_count":137,"watchers_count":137,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":208,"forks":73,"open_issues":208,"watchers":137,"default_branch":"release-0.1.1"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1273"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1273"},"issue":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1273"},"comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1273/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1273/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1273/commits"},"statuses":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/2128d571a63be90ab67b1e2ad15ca70e1cf45f7a"}}}}