{"action":"opened","number":57,"pull_request":{"url":"https://api.github.com/repos/canaryio/canary/pulls/57","id":37577286,"html_url":"https://github.com/canaryio/canary/pull/57","diff_url":"https://github.com/canaryio/canary/pull/57.diff","patch_url":"https://github.com/canaryio/canary/pull/57.patch","issue_url":"https://api.github.com/repos/canaryio/canary/issues/57","number":57,"state":"open","locked":false,"title":"Refactor sampler","user":{"login":"blalor","id":109915,"avatar_url":"https://avatars.githubusercontent.com/u/109915?v=3","gravatar_id":"","url":"https://api.github.com/users/blalor","html_url":"https://github.com/blalor","followers_url":"https://api.github.com/users/blalor/followers","following_url":"https://api.github.com/users/blalor/following{/other_user}","gists_url":"https://api.github.com/users/blalor/gists{/gist_id}","starred_url":"https://api.github.com/users/blalor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blalor/subscriptions","organizations_url":"https://api.github.com/users/blalor/orgs","repos_url":"https://api.github.com/users/blalor/repos","events_url":"https://api.github.com/users/blalor/events{/privacy}","received_events_url":"https://api.github.com/users/blalor/received_events","type":"User","site_admin":false},"body":"This got a little out of control, sorry about that.  I tried to at least make the individual commits self-contained.\n\n* `sampler.go` was getting kind of dense; I split it into separate files on rough type/functionality boundaries\n* I made `Target.URL` a `JsonURL` type that can be deserialized directly from JSON. This will cause invalid URLs to fail manifest parsing early, as opposed to on every invocation of `Ping`.  It also ensures that the URL is only parsed once, which avoids having to pass around a parsed URL instance when needed in multiple places.\n* The connection to the remote server did not honor the Ping timeout\n* The IP address of the remote server was only captured if a connection was successful\n* The time to resolve the IP address is now captured","created_at":"2015-06-12T15:50:32Z","updated_at":"2015-06-12T15:50:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/canaryio/canary/pulls/57/commits","review_comments_url":"https://api.github.com/repos/canaryio/canary/pulls/57/comments","review_comment_url":"https://api.github.com/repos/canaryio/canary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canaryio/canary/issues/57/comments","statuses_url":"https://api.github.com/repos/canaryio/canary/statuses/1bc77d88225e190c28c357b15ae9b0b4a888f75a","head":{"label":"blalor:refactor","ref":"refactor","sha":"1bc77d88225e190c28c357b15ae9b0b4a888f75a","user":{"login":"blalor","id":109915,"avatar_url":"https://avatars.githubusercontent.com/u/109915?v=3","gravatar_id":"","url":"https://api.github.com/users/blalor","html_url":"https://github.com/blalor","followers_url":"https://api.github.com/users/blalor/followers","following_url":"https://api.github.com/users/blalor/following{/other_user}","gists_url":"https://api.github.com/users/blalor/gists{/gist_id}","starred_url":"https://api.github.com/users/blalor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blalor/subscriptions","organizations_url":"https://api.github.com/users/blalor/orgs","repos_url":"https://api.github.com/users/blalor/repos","events_url":"https://api.github.com/users/blalor/events{/privacy}","received_events_url":"https://api.github.com/users/blalor/received_events","type":"User","site_admin":false},"repo":{"id":31462481,"name":"canary","full_name":"blalor/canary","owner":{"login":"blalor","id":109915,"avatar_url":"https://avatars.githubusercontent.com/u/109915?v=3","gravatar_id":"","url":"https://api.github.com/users/blalor","html_url":"https://github.com/blalor","followers_url":"https://api.github.com/users/blalor/followers","following_url":"https://api.github.com/users/blalor/following{/other_user}","gists_url":"https://api.github.com/users/blalor/gists{/gist_id}","starred_url":"https://api.github.com/users/blalor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blalor/subscriptions","organizations_url":"https://api.github.com/users/blalor/orgs","repos_url":"https://api.github.com/users/blalor/repos","events_url":"https://api.github.com/users/blalor/events{/privacy}","received_events_url":"https://api.github.com/users/blalor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blalor/canary","description":"open monitoring for the open web. default branch is my integration of various in-flight PRs.","fork":true,"url":"https://api.github.com/repos/blalor/canary","forks_url":"https://api.github.com/repos/blalor/canary/forks","keys_url":"https://api.github.com/repos/blalor/canary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blalor/canary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blalor/canary/teams","hooks_url":"https://api.github.com/repos/blalor/canary/hooks","issue_events_url":"https://api.github.com/repos/blalor/canary/issues/events{/number}","events_url":"https://api.github.com/repos/blalor/canary/events","assignees_url":"https://api.github.com/repos/blalor/canary/assignees{/user}","branches_url":"https://api.github.com/repos/blalor/canary/branches{/branch}","tags_url":"https://api.github.com/repos/blalor/canary/tags","blobs_url":"https://api.github.com/repos/blalor/canary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blalor/canary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blalor/canary/git/refs{/sha}","trees_url":"https://api.github.com/repos/blalor/canary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blalor/canary/statuses/{sha}","languages_url":"https://api.github.com/repos/blalor/canary/languages","stargazers_url":"https://api.github.com/repos/blalor/canary/stargazers","contributors_url":"https://api.github.com/repos/blalor/canary/contributors","subscribers_url":"https://api.github.com/repos/blalor/canary/subscribers","subscription_url":"https://api.github.com/repos/blalor/canary/subscription","commits_url":"https://api.github.com/repos/blalor/canary/commits{/sha}","git_commits_url":"https://api.github.com/repos/blalor/canary/git/commits{/sha}","comments_url":"https://api.github.com/repos/blalor/canary/comments{/number}","issue_comment_url":"https://api.github.com/repos/blalor/canary/issues/comments{/number}","contents_url":"https://api.github.com/repos/blalor/canary/contents/{+path}","compare_url":"https://api.github.com/repos/blalor/canary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blalor/canary/merges","archive_url":"https://api.github.com/repos/blalor/canary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blalor/canary/downloads","issues_url":"https://api.github.com/repos/blalor/canary/issues{/number}","pulls_url":"https://api.github.com/repos/blalor/canary/pulls{/number}","milestones_url":"https://api.github.com/repos/blalor/canary/milestones{/number}","notifications_url":"https://api.github.com/repos/blalor/canary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blalor/canary/labels{/name}","releases_url":"https://api.github.com/repos/blalor/canary/releases{/id}","created_at":"2015-02-28T12:49:30Z","updated_at":"2015-03-27T15:06:09Z","pushed_at":"2015-06-12T15:39:44Z","git_url":"git://github.com/blalor/canary.git","ssh_url":"git@github.com:blalor/canary.git","clone_url":"https://github.com/blalor/canary.git","svn_url":"https://github.com/blalor/canary","homepage":"https://github.com/canaryio/canary","size":238,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"integration"}},"base":{"label":"canaryio:master","ref":"master","sha":"76b70f24914c3c6f5a27b5aabb1ee122d4fbecf2","user":{"login":"canaryio","id":1618471,"avatar_url":"https://avatars.githubusercontent.com/u/1618471?v=3","gravatar_id":"","url":"https://api.github.com/users/canaryio","html_url":"https://github.com/canaryio","followers_url":"https://api.github.com/users/canaryio/followers","following_url":"https://api.github.com/users/canaryio/following{/other_user}","gists_url":"https://api.github.com/users/canaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/canaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canaryio/subscriptions","organizations_url":"https://api.github.com/users/canaryio/orgs","repos_url":"https://api.github.com/users/canaryio/repos","events_url":"https://api.github.com/users/canaryio/events{/privacy}","received_events_url":"https://api.github.com/users/canaryio/received_events","type":"Organization","site_admin":false},"repo":{"id":26513062,"name":"canary","full_name":"canaryio/canary","owner":{"login":"canaryio","id":1618471,"avatar_url":"https://avatars.githubusercontent.com/u/1618471?v=3","gravatar_id":"","url":"https://api.github.com/users/canaryio","html_url":"https://github.com/canaryio","followers_url":"https://api.github.com/users/canaryio/followers","following_url":"https://api.github.com/users/canaryio/following{/other_user}","gists_url":"https://api.github.com/users/canaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/canaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canaryio/subscriptions","organizations_url":"https://api.github.com/users/canaryio/orgs","repos_url":"https://api.github.com/users/canaryio/repos","events_url":"https://api.github.com/users/canaryio/events{/privacy}","received_events_url":"https://api.github.com/users/canaryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canaryio/canary","description":"open monitoring for the open web.","fork":false,"url":"https://api.github.com/repos/canaryio/canary","forks_url":"https://api.github.com/repos/canaryio/canary/forks","keys_url":"https://api.github.com/repos/canaryio/canary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canaryio/canary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canaryio/canary/teams","hooks_url":"https://api.github.com/repos/canaryio/canary/hooks","issue_events_url":"https://api.github.com/repos/canaryio/canary/issues/events{/number}","events_url":"https://api.github.com/repos/canaryio/canary/events","assignees_url":"https://api.github.com/repos/canaryio/canary/assignees{/user}","branches_url":"https://api.github.com/repos/canaryio/canary/branches{/branch}","tags_url":"https://api.github.com/repos/canaryio/canary/tags","blobs_url":"https://api.github.com/repos/canaryio/canary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canaryio/canary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canaryio/canary/git/refs{/sha}","trees_url":"https://api.github.com/repos/canaryio/canary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canaryio/canary/statuses/{sha}","languages_url":"https://api.github.com/repos/canaryio/canary/languages","stargazers_url":"https://api.github.com/repos/canaryio/canary/stargazers","contributors_url":"https://api.github.com/repos/canaryio/canary/contributors","subscribers_url":"https://api.github.com/repos/canaryio/canary/subscribers","subscription_url":"https://api.github.com/repos/canaryio/canary/subscription","commits_url":"https://api.github.com/repos/canaryio/canary/commits{/sha}","git_commits_url":"https://api.github.com/repos/canaryio/canary/git/commits{/sha}","comments_url":"https://api.github.com/repos/canaryio/canary/comments{/number}","issue_comment_url":"https://api.github.com/repos/canaryio/canary/issues/comments{/number}","contents_url":"https://api.github.com/repos/canaryio/canary/contents/{+path}","compare_url":"https://api.github.com/repos/canaryio/canary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canaryio/canary/merges","archive_url":"https://api.github.com/repos/canaryio/canary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canaryio/canary/downloads","issues_url":"https://api.github.com/repos/canaryio/canary/issues{/number}","pulls_url":"https://api.github.com/repos/canaryio/canary/pulls{/number}","milestones_url":"https://api.github.com/repos/canaryio/canary/milestones{/number}","notifications_url":"https://api.github.com/repos/canaryio/canary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canaryio/canary/labels{/name}","releases_url":"https://api.github.com/repos/canaryio/canary/releases{/id}","created_at":"2014-11-12T01:15:00Z","updated_at":"2015-06-05T02:56:36Z","pushed_at":"2015-06-10T14:35:44Z","git_url":"git://github.com/canaryio/canary.git","ssh_url":"git@github.com:canaryio/canary.git","clone_url":"https://github.com/canaryio/canary.git","svn_url":"https://github.com/canaryio/canary","homepage":"","size":836,"stargazers_count":28,"watchers_count":28,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":10,"forks":6,"open_issues":10,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canaryio/canary/pulls/57"},"html":{"href":"https://github.com/canaryio/canary/pull/57"},"issue":{"href":"https://api.github.com/repos/canaryio/canary/issues/57"},"comments":{"href":"https://api.github.com/repos/canaryio/canary/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/canaryio/canary/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/canaryio/canary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canaryio/canary/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/canaryio/canary/statuses/1bc77d88225e190c28c357b15ae9b0b4a888f75a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":298,"deletions":147,"changed_files":9}}