{"action":"created","issue":{"url":"https://api.github.com/repos/dropbox/zxcvbn/issues/56","labels_url":"https://api.github.com/repos/dropbox/zxcvbn/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/dropbox/zxcvbn/issues/56/comments","events_url":"https://api.github.com/repos/dropbox/zxcvbn/issues/56/events","html_url":"https://github.com/dropbox/zxcvbn/issues/56","id":42155210,"number":56,"title":"Cleanup Structure","user":{"login":"tracker1","id":444316,"avatar_url":"https://avatars.githubusercontent.com/u/444316?v=3","gravatar_id":"","url":"https://api.github.com/users/tracker1","html_url":"https://github.com/tracker1","followers_url":"https://api.github.com/users/tracker1/followers","following_url":"https://api.github.com/users/tracker1/following{/other_user}","gists_url":"https://api.github.com/users/tracker1/gists{/gist_id}","starred_url":"https://api.github.com/users/tracker1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tracker1/subscriptions","organizations_url":"https://api.github.com/users/tracker1/orgs","repos_url":"https://api.github.com/users/tracker1/repos","events_url":"https://api.github.com/users/tracker1/events{/privacy}","received_events_url":"https://api.github.com/users/tracker1/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2014-09-07T23:14:25Z","updated_at":"2015-08-08T23:13:40Z","closed_at":"2015-08-08T18:55:26Z","body":"Would suggest a preliminary cleanup of the project structure...\r\n\r\n```\r\ndata/          - data directory\r\ndata-scripts/  - python scripts to load/parse data\r\ndist/          - folder for target/compiled js\r\nsrc/           - coffeescript & javascript source files\r\ntests/         - unit tests (mocha?)\r\nbower.json     - bower package info\r\npackage.json   - npm/node package information\r\n```\r\n\r\n`package.json` can reference `src/(index.js)` as the primary file.  `npm` scripts can be added to `package.json` for build, and/or use something like [gulp](http://gulpjs.com/).\r\n\r\nGiven that npm is already used for the installation of coffee-script and the nature of this package, it may be worthwhile to use [uglify-js](https://www.npmjs.org/package/uglify-js) over closure compiler.  It may not be quite as tight, but would reduce the need for external tooling (beyond node/npm) for this.\r\n\r\nConverting the scripts to use CommonJS/node syntax could be used in combination with Browserify for the build, enabling a global and amd target in the dist directory from the same source.\r\n\r\nI'd be happy to take this on, creating a fork and PR for the changes if there would be interest for including such changes/updates."},"comment":{"url":"https://api.github.com/repos/dropbox/zxcvbn/issues/comments/129065158","html_url":"https://github.com/dropbox/zxcvbn/issues/56#issuecomment-129065158","issue_url":"https://api.github.com/repos/dropbox/zxcvbn/issues/56","id":129065158,"user":{"login":"avimar","id":314077,"avatar_url":"https://avatars.githubusercontent.com/u/314077?v=3","gravatar_id":"","url":"https://api.github.com/users/avimar","html_url":"https://github.com/avimar","followers_url":"https://api.github.com/users/avimar/followers","following_url":"https://api.github.com/users/avimar/following{/other_user}","gists_url":"https://api.github.com/users/avimar/gists{/gist_id}","starred_url":"https://api.github.com/users/avimar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avimar/subscriptions","organizations_url":"https://api.github.com/users/avimar/orgs","repos_url":"https://api.github.com/users/avimar/repos","events_url":"https://api.github.com/users/avimar/events{/privacy}","received_events_url":"https://api.github.com/users/avimar/received_events","type":"User","site_admin":false},"created_at":"2015-08-08T23:13:39Z","updated_at":"2015-08-08T23:13:39Z","body":"Thanks -- seems to work properly!"}}