{"action":"created","issue":{"url":"https://api.github.com/repos/erlang/otp/issues/773","labels_url":"https://api.github.com/repos/erlang/otp/issues/773/labels{/name}","comments_url":"https://api.github.com/repos/erlang/otp/issues/773/comments","events_url":"https://api.github.com/repos/erlang/otp/issues/773/events","html_url":"https://github.com/erlang/otp/pull/773","id":87839744,"number":773,"title":"Export disk_log types","user":{"login":"ypaq","id":1920167,"avatar_url":"https://avatars.githubusercontent.com/u/1920167?v=3","gravatar_id":"","url":"https://api.github.com/users/ypaq","html_url":"https://github.com/ypaq","followers_url":"https://api.github.com/users/ypaq/followers","following_url":"https://api.github.com/users/ypaq/following{/other_user}","gists_url":"https://api.github.com/users/ypaq/gists{/gist_id}","starred_url":"https://api.github.com/users/ypaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ypaq/subscriptions","organizations_url":"https://api.github.com/users/ypaq/orgs","repos_url":"https://api.github.com/users/ypaq/repos","events_url":"https://api.github.com/users/ypaq/events{/privacy}","received_events_url":"https://api.github.com/users/ypaq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-12T20:23:23Z","updated_at":"2015-10-05T14:20:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/erlang/otp/pulls/773","html_url":"https://github.com/erlang/otp/pull/773","diff_url":"https://github.com/erlang/otp/pull/773.diff","patch_url":"https://github.com/erlang/otp/pull/773.patch"},"body":"As listed in documentation."},"comment":{"url":"https://api.github.com/repos/erlang/otp/issues/comments/145543734","html_url":"https://github.com/erlang/otp/pull/773#issuecomment-145543734","issue_url":"https://api.github.com/repos/erlang/otp/issues/773","id":145543734,"user":{"login":"uabboli","id":133709,"avatar_url":"https://avatars.githubusercontent.com/u/133709?v=3","gravatar_id":"","url":"https://api.github.com/users/uabboli","html_url":"https://github.com/uabboli","followers_url":"https://api.github.com/users/uabboli/followers","following_url":"https://api.github.com/users/uabboli/following{/other_user}","gists_url":"https://api.github.com/users/uabboli/gists{/gist_id}","starred_url":"https://api.github.com/users/uabboli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uabboli/subscriptions","organizations_url":"https://api.github.com/users/uabboli/orgs","repos_url":"https://api.github.com/users/uabboli/repos","events_url":"https://api.github.com/users/uabboli/events{/privacy}","received_events_url":"https://api.github.com/users/uabboli/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T14:20:20Z","updated_at":"2015-10-05T14:20:20Z","body":"We normally don't export types unless there is a good reason for doing\r\nso. In this case, the selection of exported types seems arbitrary. For\r\ninstance, why is file_error() exported, but none of the types using\r\nfile_error(), such as open_error_rsn()? Have you enumerated all the\r\ntypes under the heading \"DATA TYPES\" without a particular use case in\r\nmind?\r\n\r\nGenerally it's not necessary to export every type under the heading\r\n\"DATA TYPES\". If a type has a description, it should be put under\r\n\"DATA TYPES\" even if it's not exported. If the type is neither\r\nexported nor has a description (dlog_mode() is an example), one has\r\nthe choice to put it under \"DATA TYPES\", or insert a copy in every\r\nspec where it's used. One could argue that in the case of dlog_mode()\r\nit would be better to insert a copy. Perhaps we'll do that; we have on\r\nour ToDo list to go through the types in ERTS, Kernel, and STDLIB, and\r\nimprove them further. I cannot say when this will happen, though.\r\n\r\nFinally, note that, for instance, dlog_mode() could be just mode(). I\r\nthink the names of the types were chosen before the introduction of\r\nexported types.\r\n"}}