{"action":"created","issue":{"url":"https://api.github.com/repos/mobify/descript/issues/8","labels_url":"https://api.github.com/repos/mobify/descript/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/mobify/descript/issues/8/comments","events_url":"https://api.github.com/repos/mobify/descript/issues/8/events","html_url":"https://github.com/mobify/descript/pull/8","id":112454597,"number":8,"title":"Make sure default container captures all scripts","user":{"login":"Helen-Mobify","id":2319002,"avatar_url":"https://avatars.githubusercontent.com/u/2319002?v=3","gravatar_id":"","url":"https://api.github.com/users/Helen-Mobify","html_url":"https://github.com/Helen-Mobify","followers_url":"https://api.github.com/users/Helen-Mobify/followers","following_url":"https://api.github.com/users/Helen-Mobify/following{/other_user}","gists_url":"https://api.github.com/users/Helen-Mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/Helen-Mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Helen-Mobify/subscriptions","organizations_url":"https://api.github.com/users/Helen-Mobify/orgs","repos_url":"https://api.github.com/users/Helen-Mobify/repos","events_url":"https://api.github.com/users/Helen-Mobify/events{/privacy}","received_events_url":"https://api.github.com/users/Helen-Mobify/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-20T20:35:35Z","updated_at":"2015-10-20T21:22:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mobify/descript/pulls/8","html_url":"https://github.com/mobify/descript/pull/8","diff_url":"https://github.com/mobify/descript/pull/8.diff","patch_url":"https://github.com/mobify/descript/pull/8.patch"},"body":"Descript is not pulling in all the scripts into the default container. Descript only pulls in the following:\r\n* script that have `x-src`\r\n* script that have `type=\"mobify-script\"`\r\n\r\nIt doesn't account for any script tags that isn't transformed properly by our capturejs. For example,\r\n\r\n```<script language=\"javascript\">```\r\n\r\nStatus: **Ready to Merge**\r\n\r\nReviewers: @donnielrt @fractaltheory \r\n\r\n## Changes\r\n- Make sure the default container is capturing all scripts\r\n\r\n## TODO\r\n- [ ] Eng + 1\r\n- [x] Test all passed\r\n- [x] Version incremented"},"comment":{"url":"https://api.github.com/repos/mobify/descript/issues/comments/149707255","html_url":"https://github.com/mobify/descript/pull/8#issuecomment-149707255","issue_url":"https://api.github.com/repos/mobify/descript/issues/8","id":149707255,"user":{"login":"jansepar","id":81582,"avatar_url":"https://avatars.githubusercontent.com/u/81582?v=3","gravatar_id":"","url":"https://api.github.com/users/jansepar","html_url":"https://github.com/jansepar","followers_url":"https://api.github.com/users/jansepar/followers","following_url":"https://api.github.com/users/jansepar/following{/other_user}","gists_url":"https://api.github.com/users/jansepar/gists{/gist_id}","starred_url":"https://api.github.com/users/jansepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jansepar/subscriptions","organizations_url":"https://api.github.com/users/jansepar/orgs","repos_url":"https://api.github.com/users/jansepar/repos","events_url":"https://api.github.com/users/jansepar/events{/privacy}","received_events_url":"https://api.github.com/users/jansepar/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T21:22:15Z","updated_at":"2015-10-20T21:22:15Z","body":"@Helen-Mobify I would actually consider that a bug - we should be making sure that all script elements are escaped. The reason we escape inline scripts is because if we don't, they would execute when creating the captured doc (although with the way we're creating the captured doc now, I'm not sure if that's still the case)."}}