{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/23369066","id":23369066,"diff_hunk":"@@ -307,34 +311,16 @@ void Jit64::dcbz(UGeckoInstruction inst)\n \tint a = inst.RA;\n \tint b = inst.RB;\n \n-\tu32 mem_mask = Memory::ADDR_MASK_HW_ACCESS;\n-\n-\t// The following masks the region used by the GC/Wii virtual memory lib\n-\tmem_mask |= Memory::ADDR_MASK_MEM1;\n-\n \tMOV(32, R(RSCRATCH), gpr.R(b));\n \tif (a)\n \t\tADD(32, R(RSCRATCH), gpr.R(a));\n \tAND(32, R(RSCRATCH), Imm32(~31));\n-\tTEST(32, R(RSCRATCH), Imm32(mem_mask));\n-\tFixupBranch slow = J_CC(CC_NZ, true);\n \n-\t// Should this code ever run? I can't find any games that use DCBZ on non-physical addresses, but\n-\t// supposedly there are, at least for some MMU titles. Let's be careful and support it to be sure.\n-\tSwitchToFarCode();\n-\tSetJumpTarget(slow);\n \tMOV(32, M(&PC), Imm32(jit->js.compilerPC));\n \tBitSet32 registersInUse = CallerSavedRegistersInUse();\n \tABI_PushRegistersAndAdjustStack(registersInUse, 0);\n-\tABI_CallFunctionR((void *)&Memory::ClearCacheLine, RSCRATCH);\n+\tABI_CallFunctionR((void *)&PowerPC::ClearCacheLine, RSCRATCH);","path":"Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp","position":54,"original_position":54,"commit_id":"ca17554552f8b4c12c74cf83e4e2f1c62e25d1d6","original_commit_id":"ca17554552f8b4c12c74cf83e4e2f1c62e25d1d6","user":{"login":"FioraAeterna","id":7761472,"avatar_url":"https://avatars.githubusercontent.com/u/7761472?v=3","gravatar_id":"","url":"https://api.github.com/users/FioraAeterna","html_url":"https://github.com/FioraAeterna","followers_url":"https://api.github.com/users/FioraAeterna/followers","following_url":"https://api.github.com/users/FioraAeterna/following{/other_user}","gists_url":"https://api.github.com/users/FioraAeterna/gists{/gist_id}","starred_url":"https://api.github.com/users/FioraAeterna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FioraAeterna/subscriptions","organizations_url":"https://api.github.com/users/FioraAeterna/orgs","repos_url":"https://api.github.com/users/FioraAeterna/repos","events_url":"https://api.github.com/users/FioraAeterna/events{/privacy}","received_events_url":"https://api.github.com/users/FioraAeterna/received_events","type":"User","site_admin":false},"body":"is there a way to make this take the fast path? an inlined BAT check or something?","created_at":"2015-01-22T11:19:35Z","updated_at":"2015-01-22T11:19:35Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/1882#discussion_r23369066","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1882","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/23369066"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1882#discussion_r23369066"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1882"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1882","id":27295610,"html_url":"https://github.com/dolphin-emu/dolphin/pull/1882","diff_url":"https://github.com/dolphin-emu/dolphin/pull/1882.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/1882.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1882","number":1882,"state":"open","locked":false,"title":"[WIP] Dynamic bat","user":{"login":"magumagu","id":7026757,"avatar_url":"https://avatars.githubusercontent.com/u/7026757?v=3","gravatar_id":"","url":"https://api.github.com/users/magumagu","html_url":"https://github.com/magumagu","followers_url":"https://api.github.com/users/magumagu/followers","following_url":"https://api.github.com/users/magumagu/following{/other_user}","gists_url":"https://api.github.com/users/magumagu/gists{/gist_id}","starred_url":"https://api.github.com/users/magumagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magumagu/subscriptions","organizations_url":"https://api.github.com/users/magumagu/orgs","repos_url":"https://api.github.com/users/magumagu/repos","events_url":"https://api.github.com/users/magumagu/events{/privacy}","received_events_url":"https://api.github.com/users/magumagu/received_events","type":"User","site_admin":false},"body":"Nowhere near ready for commit; just putting this up here to have a place to discuss testing/etc. since it's at the point where it does something useful.\r\n\r\nKnown to fix swcw, not sure if it'll immediately affect anything else.\r\n\r\nHopefully doesn't break Toy Story 3 anymore.","created_at":"2015-01-13T19:05:45Z","updated_at":"2015-01-22T11:19:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a966622f881e4b39a7680763988ec171db346f0b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1882/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1882/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1882/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/ca17554552f8b4c12c74cf83e4e2f1c62e25d1d6","head":{"label":"magumagu:dynamic-bat","ref":"dynamic-bat","sha":"ca17554552f8b4c12c74cf83e4e2f1c62e25d1d6","user":{"login":"magumagu","id":7026757,"avatar_url":"https://avatars.githubusercontent.com/u/7026757?v=3","gravatar_id":"","url":"https://api.github.com/users/magumagu","html_url":"https://github.com/magumagu","followers_url":"https://api.github.com/users/magumagu/followers","following_url":"https://api.github.com/users/magumagu/following{/other_user}","gists_url":"https://api.github.com/users/magumagu/gists{/gist_id}","starred_url":"https://api.github.com/users/magumagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magumagu/subscriptions","organizations_url":"https://api.github.com/users/magumagu/orgs","repos_url":"https://api.github.com/users/magumagu/repos","events_url":"https://api.github.com/users/magumagu/events{/privacy}","received_events_url":"https://api.github.com/users/magumagu/received_events","type":"User","site_admin":false},"repo":{"id":17995392,"name":"dolphin","full_name":"magumagu/dolphin","owner":{"login":"magumagu","id":7026757,"avatar_url":"https://avatars.githubusercontent.com/u/7026757?v=3","gravatar_id":"","url":"https://api.github.com/users/magumagu","html_url":"https://github.com/magumagu","followers_url":"https://api.github.com/users/magumagu/followers","following_url":"https://api.github.com/users/magumagu/following{/other_user}","gists_url":"https://api.github.com/users/magumagu/gists{/gist_id}","starred_url":"https://api.github.com/users/magumagu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magumagu/subscriptions","organizations_url":"https://api.github.com/users/magumagu/orgs","repos_url":"https://api.github.com/users/magumagu/repos","events_url":"https://api.github.com/users/magumagu/events{/privacy}","received_events_url":"https://api.github.com/users/magumagu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/magumagu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/magumagu/dolphin","forks_url":"https://api.github.com/repos/magumagu/dolphin/forks","keys_url":"https://api.github.com/repos/magumagu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magumagu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magumagu/dolphin/teams","hooks_url":"https://api.github.com/repos/magumagu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/magumagu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/magumagu/dolphin/events","assignees_url":"https://api.github.com/repos/magumagu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/magumagu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/magumagu/dolphin/tags","blobs_url":"https://api.github.com/repos/magumagu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magumagu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magumagu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/magumagu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magumagu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/magumagu/dolphin/languages","stargazers_url":"https://api.github.com/repos/magumagu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/magumagu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/magumagu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/magumagu/dolphin/subscription","commits_url":"https://api.github.com/repos/magumagu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/magumagu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/magumagu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/magumagu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/magumagu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/magumagu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magumagu/dolphin/merges","archive_url":"https://api.github.com/repos/magumagu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magumagu/dolphin/downloads","issues_url":"https://api.github.com/repos/magumagu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/magumagu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/magumagu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/magumagu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magumagu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/magumagu/dolphin/releases{/id}","created_at":"2014-03-21T21:43:50Z","updated_at":"2015-01-02T05:29:49Z","pushed_at":"2015-01-21T21:34:39Z","git_url":"git://github.com/magumagu/dolphin.git","ssh_url":"git@github.com:magumagu/dolphin.git","clone_url":"https://github.com/magumagu/dolphin.git","svn_url":"https://github.com/magumagu/dolphin","homepage":null,"size":203315,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"upstream-master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"5cd8a805530f5ccf36546a8ceb002b9a850608cb","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-01-22T10:46:33Z","pushed_at":"2015-01-22T10:46:33Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":269893,"stargazers_count":966,"watchers_count":966,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":307,"mirror_url":null,"open_issues_count":67,"forks":307,"open_issues":67,"watchers":966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1882"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1882"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1882"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1882/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1882/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1882/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/ca17554552f8b4c12c74cf83e4e2f1c62e25d1d6"}}}}