{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/38391661","id":38391661,"diff_hunk":"@@ -0,0 +1,76 @@\n+/*\n+ * Copyright 2015 The Netty Project\n+ *\n+ * The Netty Project licenses this file to you under the Apache License,\n+ * version 2.0 (the \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at:\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package io.netty.channel.epoll;\n+\n+import io.netty.util.internal.ObjectUtil;\n+import java.net.InetAddress;\n+import java.util.ArrayList;\n+import java.util.Collection;\n+import java.util.Collections;\n+import java.util.Map;\n+import java.util.Map.Entry;\n+\n+final class TcpMd5Util {\n+\n+    static Collection<InetAddress> setTcpMd5Sig(AbstractEpollChannel channel, Collection<InetAddress> current,","path":"transport-native-epoll/src/main/java/io/netty/channel/epoll/TcpMd5Util.java","position":28,"original_position":28,"commit_id":"82bcc19fd6d196848bee22bf3690d2cb6b1461ff","original_commit_id":"82bcc19fd6d196848bee22bf3690d2cb6b1461ff","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"Can we rename the method ? Prefix something with set and return a new Collection sounds strange to me. Maybe something like `newTcpMd5Sigs` ?","created_at":"2015-09-01T07:21:34Z","updated_at":"2015-09-01T07:21:34Z","html_url":"https://github.com/netty/netty/pull/4173#discussion_r38391661","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/4173","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/38391661"},"html":{"href":"https://github.com/netty/netty/pull/4173#discussion_r38391661"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/4173"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/4173","id":43718992,"html_url":"https://github.com/netty/netty/pull/4173","diff_url":"https://github.com/netty/netty/pull/4173.diff","patch_url":"https://github.com/netty/netty/pull/4173.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/4173","number":4173,"state":"open","locked":false,"title":"Add support for RFC2385 on Linux","user":{"login":"vargarob","id":3844981,"avatar_url":"https://avatars.githubusercontent.com/u/3844981?v=3","gravatar_id":"","url":"https://api.github.com/users/vargarob","html_url":"https://github.com/vargarob","followers_url":"https://api.github.com/users/vargarob/followers","following_url":"https://api.github.com/users/vargarob/following{/other_user}","gists_url":"https://api.github.com/users/vargarob/gists{/gist_id}","starred_url":"https://api.github.com/users/vargarob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vargarob/subscriptions","organizations_url":"https://api.github.com/users/vargarob/orgs","repos_url":"https://api.github.com/users/vargarob/repos","events_url":"https://api.github.com/users/vargarob/events{/privacy}","received_events_url":"https://api.github.com/users/vargarob/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nThere are protocols (BGP, SXP), which are typically deployed with TCP\r\nMD5 authentication to protect sessions from being hijacked/torn down by\r\nthird parties. This facility is not available on most operating systems,\r\nbut is typically present on Linux.\r\n\r\nModifications:\r\n\r\n- add a new EpollChannelOption, which is write-only\r\n- teach Epoll(Server)SocketChannel to track which addresses have keys\r\n  associated\r\n- teach Native how to set the MD5 signature keys for a socket\r\n\r\nResult:\r\n\r\nUsers of the native-epoll transport can set MD5 signature keys and thus\r\nleverage RFC-2385 protection on TCP connections.","created_at":"2015-08-30T19:40:14Z","updated_at":"2015-09-01T07:21:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf188efca260eab0806b709d8456963932c0be2e","assignee":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/124","html_url":"https://github.com/netty/netty/milestones/4.0.31.Final","labels_url":"https://api.github.com/repos/netty/netty/milestones/124/labels","id":1223728,"number":124,"title":"4.0.31.Final","description":"","creator":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":71,"state":"open","created_at":"2015-07-24T09:06:22Z","updated_at":"2015-09-01T07:14:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/netty/netty/pulls/4173/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/4173/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/4173/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/82bcc19fd6d196848bee22bf3690d2cb6b1461ff","head":{"label":"rovarga:tcpmd5","ref":"tcpmd5","sha":"82bcc19fd6d196848bee22bf3690d2cb6b1461ff","user":{"login":"rovarga","id":3847030,"avatar_url":"https://avatars.githubusercontent.com/u/3847030?v=3","gravatar_id":"","url":"https://api.github.com/users/rovarga","html_url":"https://github.com/rovarga","followers_url":"https://api.github.com/users/rovarga/followers","following_url":"https://api.github.com/users/rovarga/following{/other_user}","gists_url":"https://api.github.com/users/rovarga/gists{/gist_id}","starred_url":"https://api.github.com/users/rovarga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rovarga/subscriptions","organizations_url":"https://api.github.com/users/rovarga/orgs","repos_url":"https://api.github.com/users/rovarga/repos","events_url":"https://api.github.com/users/rovarga/events{/privacy}","received_events_url":"https://api.github.com/users/rovarga/received_events","type":"User","site_admin":false},"repo":{"id":30795276,"name":"netty","full_name":"rovarga/netty","owner":{"login":"rovarga","id":3847030,"avatar_url":"https://avatars.githubusercontent.com/u/3847030?v=3","gravatar_id":"","url":"https://api.github.com/users/rovarga","html_url":"https://github.com/rovarga","followers_url":"https://api.github.com/users/rovarga/followers","following_url":"https://api.github.com/users/rovarga/following{/other_user}","gists_url":"https://api.github.com/users/rovarga/gists{/gist_id}","starred_url":"https://api.github.com/users/rovarga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rovarga/subscriptions","organizations_url":"https://api.github.com/users/rovarga/orgs","repos_url":"https://api.github.com/users/rovarga/repos","events_url":"https://api.github.com/users/rovarga/events{/privacy}","received_events_url":"https://api.github.com/users/rovarga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rovarga/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/rovarga/netty","forks_url":"https://api.github.com/repos/rovarga/netty/forks","keys_url":"https://api.github.com/repos/rovarga/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rovarga/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rovarga/netty/teams","hooks_url":"https://api.github.com/repos/rovarga/netty/hooks","issue_events_url":"https://api.github.com/repos/rovarga/netty/issues/events{/number}","events_url":"https://api.github.com/repos/rovarga/netty/events","assignees_url":"https://api.github.com/repos/rovarga/netty/assignees{/user}","branches_url":"https://api.github.com/repos/rovarga/netty/branches{/branch}","tags_url":"https://api.github.com/repos/rovarga/netty/tags","blobs_url":"https://api.github.com/repos/rovarga/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rovarga/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rovarga/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/rovarga/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rovarga/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/rovarga/netty/languages","stargazers_url":"https://api.github.com/repos/rovarga/netty/stargazers","contributors_url":"https://api.github.com/repos/rovarga/netty/contributors","subscribers_url":"https://api.github.com/repos/rovarga/netty/subscribers","subscription_url":"https://api.github.com/repos/rovarga/netty/subscription","commits_url":"https://api.github.com/repos/rovarga/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/rovarga/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/rovarga/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/rovarga/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/rovarga/netty/contents/{+path}","compare_url":"https://api.github.com/repos/rovarga/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rovarga/netty/merges","archive_url":"https://api.github.com/repos/rovarga/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rovarga/netty/downloads","issues_url":"https://api.github.com/repos/rovarga/netty/issues{/number}","pulls_url":"https://api.github.com/repos/rovarga/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/rovarga/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/rovarga/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rovarga/netty/labels{/name}","releases_url":"https://api.github.com/repos/rovarga/netty/releases{/id}","created_at":"2015-02-14T11:54:12Z","updated_at":"2015-02-16T15:42:30Z","pushed_at":"2015-09-01T00:13:30Z","git_url":"git://github.com/rovarga/netty.git","ssh_url":"git@github.com:rovarga/netty.git","clone_url":"https://github.com/rovarga/netty.git","svn_url":"https://github.com/rovarga/netty","homepage":"http://netty.io/","size":42700,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:4.0","ref":"4.0","sha":"3a329f0a48d9729a74acb9d5448586bd72150ad9","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2015-09-01T06:57:39Z","pushed_at":"2015-09-01T07:10:54Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":130936,"stargazers_count":5140,"watchers_count":5140,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2611,"mirror_url":null,"open_issues_count":311,"forks":2611,"open_issues":311,"watchers":5140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/4173"},"html":{"href":"https://github.com/netty/netty/pull/4173"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/4173"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/4173/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/4173/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/4173/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/82bcc19fd6d196848bee22bf3690d2cb6b1461ff"}}}}