{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/27712428","id":27712428,"diff_hunk":"@@ -0,0 +1,580 @@\n+/**\n+ * Copyright (c) 2002-2015 \"Neo Technology,\"\n+ * Network Engine for Objects in Lund AB [http://neotechnology.com]\n+ *\n+ * This file is part of Neo4j.\n+ *\n+ * Neo4j is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as published by\n+ * the Free Software Foundation, either version 3 of the License, or\n+ * (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+ */\n+package org.neo4j.ndp.messaging.v1;\n+\n+import java.io.IOException;\n+import java.nio.channels.ReadableByteChannel;\n+import java.nio.channels.WritableByteChannel;\n+import java.util.ArrayList;\n+import java.util.Collection;\n+import java.util.Collections;\n+import java.util.HashMap;\n+import java.util.List;\n+import java.util.Map;\n+\n+import org.neo4j.graphdb.DynamicLabel;\n+import org.neo4j.graphdb.Label;\n+import org.neo4j.graphdb.Node;\n+import org.neo4j.graphdb.Path;\n+import org.neo4j.graphdb.PropertyContainer;\n+import org.neo4j.graphdb.Relationship;\n+import org.neo4j.helpers.collection.Iterables;\n+import org.neo4j.ndp.messaging.v1.infrastructure.ValueNode;\n+import org.neo4j.ndp.messaging.v1.infrastructure.ValuePath;\n+import org.neo4j.ndp.messaging.v1.infrastructure.ValueRelationship;\n+import org.neo4j.ndp.messaging.v1.message.Message;\n+import org.neo4j.packstream.PackStream;\n+import org.neo4j.packstream.PackType;\n+import org.neo4j.ndp.runtime.internal.Neo4jError;\n+import org.neo4j.stream.Record;\n+\n+import static org.neo4j.ndp.runtime.internal.Neo4jError.codeFromString;\n+import static org.neo4j.stream.Records.record;\n+\n+public class PackStreamMessageFormatV1 implements MessageFormat","path":"community/ndp/messaging-v1/src/main/java/org/neo4j/ndp/messaging/v1/PackStreamMessageFormatV1.java","position":51,"original_position":51,"commit_id":"6d88d86d13e4960e9ba60408bf9341a4217d14ee","original_commit_id":"f998fbff254f97249c5435785a5505a3d71c99c7","user":{"login":"jakewins","id":182752,"avatar_url":"https://avatars.githubusercontent.com/u/182752?v=3","gravatar_id":"","url":"https://api.github.com/users/jakewins","html_url":"https://github.com/jakewins","followers_url":"https://api.github.com/users/jakewins/followers","following_url":"https://api.github.com/users/jakewins/following{/other_user}","gists_url":"https://api.github.com/users/jakewins/gists{/gist_id}","starred_url":"https://api.github.com/users/jakewins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakewins/subscriptions","organizations_url":"https://api.github.com/users/jakewins/orgs","repos_url":"https://api.github.com/users/jakewins/repos","events_url":"https://api.github.com/users/jakewins/events{/privacy}","received_events_url":"https://api.github.com/users/jakewins/received_events","type":"User","site_admin":false},"body":"I actually like having it in both - the package groups the related stuff for that version, and the version in the name clarifies that this is the v1 message format and allows mixing this class with other versions without fully qualified names.","created_at":"2015-04-03T02:15:23Z","updated_at":"2015-04-03T02:15:23Z","html_url":"https://github.com/neo4j/neo4j/pull/4355#discussion_r27712428","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4355","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/27712428"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4355#discussion_r27712428"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4355"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/4355","id":32455638,"html_url":"https://github.com/neo4j/neo4j/pull/4355","diff_url":"https://github.com/neo4j/neo4j/pull/4355.diff","patch_url":"https://github.com/neo4j/neo4j/pull/4355.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/4355","number":4355,"state":"open","locked":false,"title":"Neo4j Data Protocol","user":{"login":"jakewins","id":182752,"avatar_url":"https://avatars.githubusercontent.com/u/182752?v=3","gravatar_id":"","url":"https://api.github.com/users/jakewins","html_url":"https://github.com/jakewins","followers_url":"https://api.github.com/users/jakewins/followers","following_url":"https://api.github.com/users/jakewins/following{/other_user}","gists_url":"https://api.github.com/users/jakewins/gists{/gist_id}","starred_url":"https://api.github.com/users/jakewins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakewins/subscriptions","organizations_url":"https://api.github.com/users/jakewins/orgs","repos_url":"https://api.github.com/users/jakewins/repos","events_url":"https://api.github.com/users/jakewins/events{/privacy}","received_events_url":"https://api.github.com/users/jakewins/received_events","type":"User","site_admin":false},"body":"This contains the initial work on a server portion of a lower-overhead data protocol for remote clients.","created_at":"2015-04-01T20:10:02Z","updated_at":"2015-04-03T02:15:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"412389346d197229f271c08c7f76058e9aa8b9f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4355/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4355/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/4355/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/6d88d86d13e4960e9ba60408bf9341a4217d14ee","head":{"label":"jakewins:2.3-ndp","ref":"2.3-ndp","sha":"6d88d86d13e4960e9ba60408bf9341a4217d14ee","user":{"login":"jakewins","id":182752,"avatar_url":"https://avatars.githubusercontent.com/u/182752?v=3","gravatar_id":"","url":"https://api.github.com/users/jakewins","html_url":"https://github.com/jakewins","followers_url":"https://api.github.com/users/jakewins/followers","following_url":"https://api.github.com/users/jakewins/following{/other_user}","gists_url":"https://api.github.com/users/jakewins/gists{/gist_id}","starred_url":"https://api.github.com/users/jakewins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakewins/subscriptions","organizations_url":"https://api.github.com/users/jakewins/orgs","repos_url":"https://api.github.com/users/jakewins/repos","events_url":"https://api.github.com/users/jakewins/events{/privacy}","received_events_url":"https://api.github.com/users/jakewins/received_events","type":"User","site_admin":false},"repo":{"id":6761171,"name":"neo4j","full_name":"jakewins/neo4j","owner":{"login":"jakewins","id":182752,"avatar_url":"https://avatars.githubusercontent.com/u/182752?v=3","gravatar_id":"","url":"https://api.github.com/users/jakewins","html_url":"https://github.com/jakewins","followers_url":"https://api.github.com/users/jakewins/followers","following_url":"https://api.github.com/users/jakewins/following{/other_user}","gists_url":"https://api.github.com/users/jakewins/gists{/gist_id}","starred_url":"https://api.github.com/users/jakewins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakewins/subscriptions","organizations_url":"https://api.github.com/users/jakewins/orgs","repos_url":"https://api.github.com/users/jakewins/repos","events_url":"https://api.github.com/users/jakewins/events{/privacy}","received_events_url":"https://api.github.com/users/jakewins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakewins/neo4j","description":"","fork":true,"url":"https://api.github.com/repos/jakewins/neo4j","forks_url":"https://api.github.com/repos/jakewins/neo4j/forks","keys_url":"https://api.github.com/repos/jakewins/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakewins/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakewins/neo4j/teams","hooks_url":"https://api.github.com/repos/jakewins/neo4j/hooks","issue_events_url":"https://api.github.com/repos/jakewins/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/jakewins/neo4j/events","assignees_url":"https://api.github.com/repos/jakewins/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/jakewins/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/jakewins/neo4j/tags","blobs_url":"https://api.github.com/repos/jakewins/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakewins/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakewins/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakewins/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakewins/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/jakewins/neo4j/languages","stargazers_url":"https://api.github.com/repos/jakewins/neo4j/stargazers","contributors_url":"https://api.github.com/repos/jakewins/neo4j/contributors","subscribers_url":"https://api.github.com/repos/jakewins/neo4j/subscribers","subscription_url":"https://api.github.com/repos/jakewins/neo4j/subscription","commits_url":"https://api.github.com/repos/jakewins/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakewins/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakewins/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakewins/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakewins/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/jakewins/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakewins/neo4j/merges","archive_url":"https://api.github.com/repos/jakewins/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakewins/neo4j/downloads","issues_url":"https://api.github.com/repos/jakewins/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/jakewins/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/jakewins/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/jakewins/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakewins/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/jakewins/neo4j/releases{/id}","created_at":"2012-11-19T13:59:44Z","updated_at":"2014-06-17T11:02:23Z","pushed_at":"2015-04-03T02:12:03Z","git_url":"git://github.com/jakewins/neo4j.git","ssh_url":"git@github.com:jakewins/neo4j.git","clone_url":"https://github.com/jakewins/neo4j.git","svn_url":"https://github.com/jakewins/neo4j","homepage":null,"size":188969,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:2.3","ref":"2.3","sha":"bafd1ab78686382fd841ad51583ee23c1bd0be16","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-04-03T02:14:40Z","pushed_at":"2015-04-03T02:12:05Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":399824,"stargazers_count":1569,"watchers_count":1569,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":642,"mirror_url":null,"open_issues_count":412,"forks":642,"open_issues":412,"watchers":1569,"default_branch":"2.3"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4355"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4355"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4355"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4355/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4355/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4355/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/6d88d86d13e4960e9ba60408bf9341a4217d14ee"}}}}