{"action":"closed","number":7819,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7819","id":44277949,"html_url":"https://github.com/joomla/joomla-cms/pull/7819","diff_url":"https://github.com/joomla/joomla-cms/pull/7819.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/7819.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7819","number":7819,"state":"closed","locked":false,"title":"Use bootstrap modal for preview on com_media","user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"body":"#### Scope\r\nEliminate mootools usage and use bootstrap modal for previewing the images.\r\nAlso scripts and stylesheets were called all over the place, now they follow Joomla's best practices\r\n\r\n#### B/C\r\nAs long as the templates use bootstrap (admin area) there shouldn’t be any problems. Any overrides NEED to be updated!\r\n\r\n#### Performance\r\nShould be a bit quicker without mootools eating some of the rendering time, downloading, http requests etc.\r\n\r\n#### Testing\r\nApply the patch and see if everything still works correctly.\r\nReport any problems or any ideas for improvement\r\n\r\n#### Preview\r\n![screen shot 2015-09-05 at 9 43 15](https://cloud.githubusercontent.com/assets/3889375/9698162/adf290e6-53b2-11e5-83fc-dd4beb4ea9ad.png)\r\n","created_at":"2015-09-05T06:46:51Z","updated_at":"2015-09-09T21:01:56Z","closed_at":"2015-09-09T21:01:56Z","merged_at":null,"merge_commit_sha":"02bfc0711f3466312f43ce9131e3d29e550e90f0","assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/11","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla!%203.4.5","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/11/labels","id":1269516,"number":11,"title":"Joomla! 3.4.5","description":"","creator":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":9,"state":"open","created_at":"2015-08-24T14:19:20Z","updated_at":"2015-09-09T21:01:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7819/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7819/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7819/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/212211e7d86293047f665df708a97fc564e35d72","head":{"label":"dgt41:____bootstrap.Com.Media.Modal","ref":"____bootstrap.Com.Media.Modal","sha":"212211e7d86293047f665df708a97fc564e35d72","user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"repo":{"id":17825580,"name":"joomla-cms","full_name":"dgt41/joomla-cms","owner":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgt41/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/dgt41/joomla-cms","forks_url":"https://api.github.com/repos/dgt41/joomla-cms/forks","keys_url":"https://api.github.com/repos/dgt41/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgt41/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgt41/joomla-cms/teams","hooks_url":"https://api.github.com/repos/dgt41/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/dgt41/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/dgt41/joomla-cms/events","assignees_url":"https://api.github.com/repos/dgt41/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/dgt41/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/dgt41/joomla-cms/tags","blobs_url":"https://api.github.com/repos/dgt41/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgt41/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgt41/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgt41/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgt41/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/dgt41/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/dgt41/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/dgt41/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/dgt41/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/dgt41/joomla-cms/subscription","commits_url":"https://api.github.com/repos/dgt41/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgt41/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgt41/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgt41/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgt41/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/dgt41/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgt41/joomla-cms/merges","archive_url":"https://api.github.com/repos/dgt41/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgt41/joomla-cms/downloads","issues_url":"https://api.github.com/repos/dgt41/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/dgt41/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/dgt41/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/dgt41/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgt41/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/dgt41/joomla-cms/releases{/id}","created_at":"2014-03-17T11:18:00Z","updated_at":"2014-09-07T15:23:48Z","pushed_at":"2015-09-09T13:10:12Z","git_url":"git://github.com/dgt41/joomla-cms.git","ssh_url":"git@github.com:dgt41/joomla-cms.git","clone_url":"https://github.com/dgt41/joomla-cms.git","svn_url":"https://github.com/dgt41/joomla-cms","homepage":"http://joomla.org","size":136842,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"a0ad3884060d0f9fdb87a8db2b44494a295d81ff","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","created_at":"2011-09-27T02:07:38Z","updated_at":"2015-09-09T15:00:51Z","pushed_at":"2015-09-09T21:01:21Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"http://joomla.org","size":338574,"stargazers_count":1647,"watchers_count":1647,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1875,"mirror_url":null,"open_issues_count":549,"forks":1875,"open_issues":549,"watchers":1647,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7819"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/7819"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/7819"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/7819/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7819/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/7819/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/212211e7d86293047f665df708a97fc564e35d72"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":5,"commits":6,"additions":118,"deletions":104,"changed_files":12}}