{"action":"created","comment":{"url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/comments/48536667","id":48536667,"diff_hunk":"@@ -121,7 +121,13 @@ public void start() {\n         // Requires authentication endpoint without specific authenticator attached\n         addProtectedEndpointWithoutAuthorizer(\"/protected/index.html\", \"\", router);\n \n-        router.get(\"/index.html\").handler(DemoHandlers.indexHandler(config));\n+        // Direct basic auth authentication (web services)\n+        addProtectedEndpointWithoutAuthorizer(\"/dba/index.html\", \"DirectBasicAuthClient\", router);","path":"src/main/java/org/pac4j/vertx/verticle/DemoServerVerticle.java","position":15,"original_position":15,"commit_id":"a7d641ceb741cfabe967326051b8daf686043700","original_commit_id":"a7d641ceb741cfabe967326051b8daf686043700","user":{"login":"leleuj","id":1038508,"avatar_url":"https://avatars.githubusercontent.com/u/1038508?v=3","gravatar_id":"","url":"https://api.github.com/users/leleuj","html_url":"https://github.com/leleuj","followers_url":"https://api.github.com/users/leleuj/followers","following_url":"https://api.github.com/users/leleuj/following{/other_user}","gists_url":"https://api.github.com/users/leleuj/gists{/gist_id}","starred_url":"https://api.github.com/users/leleuj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leleuj/subscriptions","organizations_url":"https://api.github.com/users/leleuj/orgs","repos_url":"https://api.github.com/users/leleuj/repos","events_url":"https://api.github.com/users/leleuj/events{/privacy}","received_events_url":"https://api.github.com/users/leleuj/received_events","type":"User","site_admin":false},"body":"Adding the new endpoints for web services. Providing more details soon on this...","created_at":"2015-12-29T12:14:47Z","updated_at":"2015-12-29T12:14:47Z","html_url":"https://github.com/pac4j/vertx-pac4j-demo/pull/35#discussion_r48536667","pull_request_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/comments/48536667"},"html":{"href":"https://github.com/pac4j/vertx-pac4j-demo/pull/35#discussion_r48536667"},"pull_request":{"href":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/35","id":54721959,"html_url":"https://github.com/pac4j/vertx-pac4j-demo/pull/35","diff_url":"https://github.com/pac4j/vertx-pac4j-demo/pull/35.diff","patch_url":"https://github.com/pac4j/vertx-pac4j-demo/pull/35.patch","issue_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/issues/35","number":35,"state":"open","locked":false,"title":"Some cleaning / refactoring proposal + last endpoints","user":{"login":"leleuj","id":1038508,"avatar_url":"https://avatars.githubusercontent.com/u/1038508?v=3","gravatar_id":"","url":"https://api.github.com/users/leleuj","html_url":"https://github.com/leleuj","followers_url":"https://api.github.com/users/leleuj/followers","following_url":"https://api.github.com/users/leleuj/following{/other_user}","gists_url":"https://api.github.com/users/leleuj/gists{/gist_id}","starred_url":"https://api.github.com/users/leleuj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leleuj/subscriptions","organizations_url":"https://api.github.com/users/leleuj/orgs","repos_url":"https://api.github.com/users/leleuj/repos","events_url":"https://api.github.com/users/leleuj/events{/privacy}","received_events_url":"https://api.github.com/users/leleuj/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-29T12:08:01Z","updated_at":"2015-12-29T12:14:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d076f9d43feb55e346b0353fb63910134685d45e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/35/commits","review_comments_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/35/comments","review_comment_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/issues/35/comments","statuses_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/statuses/a7d641ceb741cfabe967326051b8daf686043700","head":{"label":"leleuj:clean","ref":"clean","sha":"a7d641ceb741cfabe967326051b8daf686043700","user":{"login":"leleuj","id":1038508,"avatar_url":"https://avatars.githubusercontent.com/u/1038508?v=3","gravatar_id":"","url":"https://api.github.com/users/leleuj","html_url":"https://github.com/leleuj","followers_url":"https://api.github.com/users/leleuj/followers","following_url":"https://api.github.com/users/leleuj/following{/other_user}","gists_url":"https://api.github.com/users/leleuj/gists{/gist_id}","starred_url":"https://api.github.com/users/leleuj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leleuj/subscriptions","organizations_url":"https://api.github.com/users/leleuj/orgs","repos_url":"https://api.github.com/users/leleuj/repos","events_url":"https://api.github.com/users/leleuj/events{/privacy}","received_events_url":"https://api.github.com/users/leleuj/received_events","type":"User","site_admin":false},"repo":{"id":34390138,"name":"vertx-pac4j-demo","full_name":"leleuj/vertx-pac4j-demo","owner":{"login":"leleuj","id":1038508,"avatar_url":"https://avatars.githubusercontent.com/u/1038508?v=3","gravatar_id":"","url":"https://api.github.com/users/leleuj","html_url":"https://github.com/leleuj","followers_url":"https://api.github.com/users/leleuj/followers","following_url":"https://api.github.com/users/leleuj/following{/other_user}","gists_url":"https://api.github.com/users/leleuj/gists{/gist_id}","starred_url":"https://api.github.com/users/leleuj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leleuj/subscriptions","organizations_url":"https://api.github.com/users/leleuj/orgs","repos_url":"https://api.github.com/users/leleuj/repos","events_url":"https://api.github.com/users/leleuj/events{/privacy}","received_events_url":"https://api.github.com/users/leleuj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leleuj/vertx-pac4j-demo","description":"","fork":true,"url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo","forks_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/forks","keys_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/teams","hooks_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/hooks","issue_events_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/issues/events{/number}","events_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/events","assignees_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/assignees{/user}","branches_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/branches{/branch}","tags_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/tags","blobs_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/languages","stargazers_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/stargazers","contributors_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/contributors","subscribers_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/subscribers","subscription_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/subscription","commits_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/contents/{+path}","compare_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/merges","archive_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/downloads","issues_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/issues{/number}","pulls_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/labels{/name}","releases_url":"https://api.github.com/repos/leleuj/vertx-pac4j-demo/releases{/id}","created_at":"2015-04-22T12:53:34Z","updated_at":"2015-04-22T12:53:34Z","pushed_at":"2015-12-29T12:07:30Z","git_url":"git://github.com/leleuj/vertx-pac4j-demo.git","ssh_url":"git@github.com:leleuj/vertx-pac4j-demo.git","clone_url":"https://github.com/leleuj/vertx-pac4j-demo.git","svn_url":"https://github.com/leleuj/vertx-pac4j-demo","homepage":null,"size":110,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pac4j:master","ref":"master","sha":"a7159db869fe9517cdbbbd501e5afe77b4ace333","user":{"login":"pac4j","id":7540865,"avatar_url":"https://avatars.githubusercontent.com/u/7540865?v=3","gravatar_id":"","url":"https://api.github.com/users/pac4j","html_url":"https://github.com/pac4j","followers_url":"https://api.github.com/users/pac4j/followers","following_url":"https://api.github.com/users/pac4j/following{/other_user}","gists_url":"https://api.github.com/users/pac4j/gists{/gist_id}","starred_url":"https://api.github.com/users/pac4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pac4j/subscriptions","organizations_url":"https://api.github.com/users/pac4j/orgs","repos_url":"https://api.github.com/users/pac4j/repos","events_url":"https://api.github.com/users/pac4j/events{/privacy}","received_events_url":"https://api.github.com/users/pac4j/received_events","type":"Organization","site_admin":false},"repo":{"id":18869703,"name":"vertx-pac4j-demo","full_name":"pac4j/vertx-pac4j-demo","owner":{"login":"pac4j","id":7540865,"avatar_url":"https://avatars.githubusercontent.com/u/7540865?v=3","gravatar_id":"","url":"https://api.github.com/users/pac4j","html_url":"https://github.com/pac4j","followers_url":"https://api.github.com/users/pac4j/followers","following_url":"https://api.github.com/users/pac4j/following{/other_user}","gists_url":"https://api.github.com/users/pac4j/gists{/gist_id}","starred_url":"https://api.github.com/users/pac4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pac4j/subscriptions","organizations_url":"https://api.github.com/users/pac4j/orgs","repos_url":"https://api.github.com/users/pac4j/repos","events_url":"https://api.github.com/users/pac4j/events{/privacy}","received_events_url":"https://api.github.com/users/pac4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pac4j/vertx-pac4j-demo","description":"Vertx demo to test the vertx-pac4j security library","fork":false,"url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo","forks_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/forks","keys_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/teams","hooks_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/hooks","issue_events_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/issues/events{/number}","events_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/events","assignees_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/assignees{/user}","branches_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/branches{/branch}","tags_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/tags","blobs_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/languages","stargazers_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/stargazers","contributors_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/contributors","subscribers_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/subscribers","subscription_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/subscription","commits_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/contents/{+path}","compare_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/merges","archive_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/downloads","issues_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/issues{/number}","pulls_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/labels{/name}","releases_url":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/releases{/id}","created_at":"2014-04-17T07:04:06Z","updated_at":"2015-12-18T07:44:03Z","pushed_at":"2015-12-29T12:08:03Z","git_url":"git://github.com/pac4j/vertx-pac4j-demo.git","ssh_url":"git@github.com:pac4j/vertx-pac4j-demo.git","clone_url":"https://github.com/pac4j/vertx-pac4j-demo.git","svn_url":"https://github.com/pac4j/vertx-pac4j-demo","homepage":"http://www.pac4j.org","size":106,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/35"},"html":{"href":"https://github.com/pac4j/vertx-pac4j-demo/pull/35"},"issue":{"href":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/issues/35"},"comments":{"href":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/pac4j/vertx-pac4j-demo/statuses/a7d641ceb741cfabe967326051b8daf686043700"}}}}