{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/37476135","id":37476135,"diff_hunk":"@@ -0,0 +1,123 @@\n+﻿// Licensed to the Apache Software Foundation (ASF) under one\n+// or more contributor license agreements.  See the NOTICE file\n+// distributed with this work for additional information\n+// regarding copyright ownership.  The ASF licenses this file\n+// to you under the Apache License, Version 2.0 (the\n+// \"License\"); you may not use this file except in compliance\n+// with the License.  You may obtain a copy of the License at\n+// \n+//   http://www.apache.org/licenses/LICENSE-2.0\n+// \n+// Unless required by applicable law or agreed to in writing,\n+// software distributed under the License is distributed on an\n+// \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+// KIND, either express or implied.  See the License for the\n+// specific language governing permissions and limitations\n+// under the License.\n+\n+using System.Collections.Generic;\n+using System.Globalization;\n+using Org.Apache.REEF.Client.API;\n+using Org.Apache.REEF.Driver;\n+using Org.Apache.REEF.IMRU.API;\n+using Org.Apache.REEF.IMRU.OnREEF.Driver;\n+using Org.Apache.REEF.IMRU.OnREEF.Parameters;\n+using Org.Apache.REEF.Network.Group.Config;\n+using Org.Apache.REEF.Network.Group.Driver;\n+using Org.Apache.REEF.Network.Group.Driver.Impl;\n+using Org.Apache.REEF.Tang.Annotations;\n+using Org.Apache.REEF.Tang.Formats;\n+using Org.Apache.REEF.Tang.Implementations.Configuration;\n+using Org.Apache.REEF.Tang.Implementations.Tang;\n+using Org.Apache.REEF.Tang.Interface;\n+using Org.Apache.REEF.Tang.Util;\n+\n+namespace Org.Apache.REEF.IMRU.OnREEF.Client\n+{\n+    /// <summary>\n+    /// Implements the IMRU client API on REEF.\n+    /// </summary>\n+    /// <typeparam name=\"TMapInput\">The type of the side information provided to the Map function</typeparam>\n+    /// <typeparam name=\"TMapOutput\">The return type of the Map function</typeparam>\n+    /// <typeparam name=\"TResult\">The return type of the computation.</typeparam>\n+    public sealed class REEFIMRUClient<TMapInput, TMapOutput, TResult> : IIMRUClient<TMapInput, TMapOutput, TResult>","path":"lang/cs/Org.Apache.REEF.IMRU/OnREEF/Client/REEFIMRUClient.cs","position":43,"original_position":43,"commit_id":"3b927ab29bdb183fb589db28472701801a7ec96d","original_commit_id":"3b927ab29bdb183fb589db28472701801a7ec96d","user":{"login":"markusweimer","id":502371,"avatar_url":"https://avatars.githubusercontent.com/u/502371?v=3","gravatar_id":"","url":"https://api.github.com/users/markusweimer","html_url":"https://github.com/markusweimer","followers_url":"https://api.github.com/users/markusweimer/followers","following_url":"https://api.github.com/users/markusweimer/following{/other_user}","gists_url":"https://api.github.com/users/markusweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/markusweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusweimer/subscriptions","organizations_url":"https://api.github.com/users/markusweimer/orgs","repos_url":"https://api.github.com/users/markusweimer/repos","events_url":"https://api.github.com/users/markusweimer/events{/privacy}","received_events_url":"https://api.github.com/users/markusweimer/received_events","type":"User","site_admin":false},"body":"Yes, I meant for this class not to be `public`, but `internal`. You could have a `public` ConfigurationModule which binds this implementation to the interface, as well as other parameters. That is how I did it for the `HadoopFileSystem`.","created_at":"2015-08-19T22:22:37Z","updated_at":"2015-08-19T22:22:37Z","html_url":"https://github.com/apache/incubator-reef/pull/385#discussion_r37476135","pull_request_url":"https://api.github.com/repos/apache/incubator-reef/pulls/385","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/37476135"},"html":{"href":"https://github.com/apache/incubator-reef/pull/385#discussion_r37476135"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/385"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/385","id":42845938,"html_url":"https://github.com/apache/incubator-reef/pull/385","diff_url":"https://github.com/apache/incubator-reef/pull/385.diff","patch_url":"https://github.com/apache/incubator-reef/pull/385.patch","issue_url":"https://api.github.com/repos/apache/incubator-reef/issues/385","number":385,"state":"open","locked":false,"title":" [REEF-608] Implement IMRU driver and client ","user":{"login":"dkm2110","id":151031,"avatar_url":"https://avatars.githubusercontent.com/u/151031?v=3","gravatar_id":"","url":"https://api.github.com/users/dkm2110","html_url":"https://github.com/dkm2110","followers_url":"https://api.github.com/users/dkm2110/followers","following_url":"https://api.github.com/users/dkm2110/following{/other_user}","gists_url":"https://api.github.com/users/dkm2110/gists{/gist_id}","starred_url":"https://api.github.com/users/dkm2110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkm2110/subscriptions","organizations_url":"https://api.github.com/users/dkm2110/orgs","repos_url":"https://api.github.com/users/dkm2110/repos","events_url":"https://api.github.com/users/dkm2110/events{/privacy}","received_events_url":"https://api.github.com/users/dkm2110/received_events","type":"User","site_admin":false},"body":" [REEF-608] Implement IMRU driver and client \r\n\r\nThis addressed the issue by\r\n       * implementing REEF IMRU Driver that actually runs Map and Update tasks given the job definition given by user.\r\n       * implementing REEF IMRU Client\r\n       * introducing a StreamingCodecConfigurationMinusMessage configuration module in REEF.Network.Group.Config that gives internal codec configurations used within group communication to the external applications like IMRU.\r\n\r\nJIRA:\r\n[REEF-608](https://issues.apache.org/jira/browse/REEF-608)\r\n ","created_at":"2015-08-19T18:11:58Z","updated_at":"2015-08-19T22:22:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"325bc75b97ba3b354f1bcf18e42fd08ef669e1c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-reef/pulls/385/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-reef/pulls/385/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-reef/issues/385/comments","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/3b927ab29bdb183fb589db28472701801a7ec96d","head":{"label":"Microsoft-CISL:REEF-608","ref":"REEF-608","sha":"3b927ab29bdb183fb589db28472701801a7ec96d","user":{"login":"Microsoft-CISL","id":2067733,"avatar_url":"https://avatars.githubusercontent.com/u/2067733?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft-CISL","html_url":"https://github.com/Microsoft-CISL","followers_url":"https://api.github.com/users/Microsoft-CISL/followers","following_url":"https://api.github.com/users/Microsoft-CISL/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft-CISL/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft-CISL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft-CISL/subscriptions","organizations_url":"https://api.github.com/users/Microsoft-CISL/orgs","repos_url":"https://api.github.com/users/Microsoft-CISL/repos","events_url":"https://api.github.com/users/Microsoft-CISL/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft-CISL/received_events","type":"Organization","site_admin":false},"repo":{"id":30330372,"name":"incubator-reef","full_name":"Microsoft-CISL/incubator-reef","owner":{"login":"Microsoft-CISL","id":2067733,"avatar_url":"https://avatars.githubusercontent.com/u/2067733?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft-CISL","html_url":"https://github.com/Microsoft-CISL","followers_url":"https://api.github.com/users/Microsoft-CISL/followers","following_url":"https://api.github.com/users/Microsoft-CISL/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft-CISL/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft-CISL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft-CISL/subscriptions","organizations_url":"https://api.github.com/users/Microsoft-CISL/orgs","repos_url":"https://api.github.com/users/Microsoft-CISL/repos","events_url":"https://api.github.com/users/Microsoft-CISL/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft-CISL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft-CISL/incubator-reef","description":"Mirror of Apache REEF (Incubating) for Pull Request staging","fork":true,"url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef","forks_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/forks","keys_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/teams","hooks_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/events","assignees_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/tags","blobs_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/subscription","commits_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/merges","archive_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/downloads","issues_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/releases{/id}","created_at":"2015-02-05T01:06:12Z","updated_at":"2015-05-22T13:19:37Z","pushed_at":"2015-08-19T20:31:53Z","git_url":"git://github.com/Microsoft-CISL/incubator-reef.git","ssh_url":"git@github.com:Microsoft-CISL/incubator-reef.git","clone_url":"https://github.com/Microsoft-CISL/incubator-reef.git","svn_url":"https://github.com/Microsoft-CISL/incubator-reef","homepage":"","size":31704,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"658507289dad56a7379fa9f90a60ff99e8415e1f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"incubator-reef","full_name":"apache/incubator-reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-reef","description":"Mirror of Apache REEF (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-reef","forks_url":"https://api.github.com/repos/apache/incubator-reef/forks","keys_url":"https://api.github.com/repos/apache/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-reef/teams","hooks_url":"https://api.github.com/repos/apache/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-reef/events","assignees_url":"https://api.github.com/repos/apache/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-reef/tags","blobs_url":"https://api.github.com/repos/apache/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-reef/subscription","commits_url":"https://api.github.com/repos/apache/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-reef/merges","archive_url":"https://api.github.com/repos/apache/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-reef/downloads","issues_url":"https://api.github.com/repos/apache/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-reef/releases{/id}","created_at":"2014-10-23T07:00:10Z","updated_at":"2015-08-04T17:05:33Z","pushed_at":"2015-08-19T19:52:04Z","git_url":"git://github.com/apache/incubator-reef.git","ssh_url":"git@github.com:apache/incubator-reef.git","clone_url":"https://github.com/apache/incubator-reef.git","svn_url":"https://github.com/apache/incubator-reef","homepage":null,"size":43223,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":"git://git.apache.org/incubator-reef.git","open_issues_count":5,"forks":33,"open_issues":5,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/385"},"html":{"href":"https://github.com/apache/incubator-reef/pull/385"},"issue":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/385"},"comments":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/385/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/385/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/385/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-reef/statuses/3b927ab29bdb183fb589db28472701801a7ec96d"}}}}