{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/28051897","id":28051897,"diff_hunk":"@@ -156,7 +156,8 @@ then\n elif [ \"$cflag\" == \"1\" ]\n then\n   /usr/bin/logger -t heartbeat \"kvmheartbeat.sh rebooted system because it was unable to write the heartbeat to the storage.\"\n-  sync\n+  sync &","path":"scripts/vm/hypervisor/kvm/kvmheartbeat.sh","position":5,"original_position":5,"commit_id":"7bce656b409f6bc0e18fe963cfeb9c2134b095be","original_commit_id":"7bce656b409f6bc0e18fe963cfeb9c2134b095be","user":{"login":"bhaisaab","id":95203,"avatar_url":"https://avatars.githubusercontent.com/u/95203?v=3","gravatar_id":"","url":"https://api.github.com/users/bhaisaab","html_url":"https://github.com/bhaisaab","followers_url":"https://api.github.com/users/bhaisaab/followers","following_url":"https://api.github.com/users/bhaisaab/following{/other_user}","gists_url":"https://api.github.com/users/bhaisaab/gists{/gist_id}","starred_url":"https://api.github.com/users/bhaisaab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhaisaab/subscriptions","organizations_url":"https://api.github.com/users/bhaisaab/orgs","repos_url":"https://api.github.com/users/bhaisaab/repos","events_url":"https://api.github.com/users/bhaisaab/events{/privacy}","received_events_url":"https://api.github.com/users/bhaisaab/received_events","type":"User","site_admin":false},"body":"what if sync takes more than 5 seconds?\r\nWhy are we sync-ing at all if we don't want to block before rebooting?","created_at":"2015-04-09T10:49:08Z","updated_at":"2015-04-09T10:49:08Z","html_url":"https://github.com/apache/cloudstack/pull/152#discussion_r28051897","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/28051897"},"html":{"href":"https://github.com/apache/cloudstack/pull/152#discussion_r28051897"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/152","id":32942459,"html_url":"https://github.com/apache/cloudstack/pull/152","diff_url":"https://github.com/apache/cloudstack/pull/152.diff","patch_url":"https://github.com/apache/cloudstack/pull/152.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/152","number":152,"state":"open","locked":false,"title":"KVM: make sure sync cannot block reboot","user":{"login":"remibergsma","id":1630096,"avatar_url":"https://avatars.githubusercontent.com/u/1630096?v=3","gravatar_id":"","url":"https://api.github.com/users/remibergsma","html_url":"https://github.com/remibergsma","followers_url":"https://api.github.com/users/remibergsma/followers","following_url":"https://api.github.com/users/remibergsma/following{/other_user}","gists_url":"https://api.github.com/users/remibergsma/gists{/gist_id}","starred_url":"https://api.github.com/users/remibergsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remibergsma/subscriptions","organizations_url":"https://api.github.com/users/remibergsma/orgs","repos_url":"https://api.github.com/users/remibergsma/repos","events_url":"https://api.github.com/users/remibergsma/events{/privacy}","received_events_url":"https://api.github.com/users/remibergsma/received_events","type":"User","site_admin":false},"body":"The recent discussed improvement has the risk that if 'sync' hangs, the reboot may be delayed in the same way as the 'reboot' command would do. To work around, we're adding a 5 second timeout. If it cannot sync in 5 seconds, it will not succeed anyway and we should proceed the reset.\r\n\r\n@snuf: As a future improvement: Could we use your OVM3 heartbeat script for other hypervisors as well? One way to do it seems like a nice idea :-)","created_at":"2015-04-09T10:19:42Z","updated_at":"2015-04-09T10:49:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0d6e19c60d2b7289b3324a57e820908f52edbb1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/152/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/152/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/152/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/7bce656b409f6bc0e18fe963cfeb9c2134b095be","head":{"label":"remibergsma:master","ref":"master","sha":"7bce656b409f6bc0e18fe963cfeb9c2134b095be","user":{"login":"remibergsma","id":1630096,"avatar_url":"https://avatars.githubusercontent.com/u/1630096?v=3","gravatar_id":"","url":"https://api.github.com/users/remibergsma","html_url":"https://github.com/remibergsma","followers_url":"https://api.github.com/users/remibergsma/followers","following_url":"https://api.github.com/users/remibergsma/following{/other_user}","gists_url":"https://api.github.com/users/remibergsma/gists{/gist_id}","starred_url":"https://api.github.com/users/remibergsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remibergsma/subscriptions","organizations_url":"https://api.github.com/users/remibergsma/orgs","repos_url":"https://api.github.com/users/remibergsma/repos","events_url":"https://api.github.com/users/remibergsma/events{/privacy}","received_events_url":"https://api.github.com/users/remibergsma/received_events","type":"User","site_admin":false},"repo":{"id":33662311,"name":"cloudstack","full_name":"remibergsma/cloudstack","owner":{"login":"remibergsma","id":1630096,"avatar_url":"https://avatars.githubusercontent.com/u/1630096?v=3","gravatar_id":"","url":"https://api.github.com/users/remibergsma","html_url":"https://github.com/remibergsma","followers_url":"https://api.github.com/users/remibergsma/followers","following_url":"https://api.github.com/users/remibergsma/following{/other_user}","gists_url":"https://api.github.com/users/remibergsma/gists{/gist_id}","starred_url":"https://api.github.com/users/remibergsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remibergsma/subscriptions","organizations_url":"https://api.github.com/users/remibergsma/orgs","repos_url":"https://api.github.com/users/remibergsma/repos","events_url":"https://api.github.com/users/remibergsma/events{/privacy}","received_events_url":"https://api.github.com/users/remibergsma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/remibergsma/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/remibergsma/cloudstack","forks_url":"https://api.github.com/repos/remibergsma/cloudstack/forks","keys_url":"https://api.github.com/repos/remibergsma/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remibergsma/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remibergsma/cloudstack/teams","hooks_url":"https://api.github.com/repos/remibergsma/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/remibergsma/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/remibergsma/cloudstack/events","assignees_url":"https://api.github.com/repos/remibergsma/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/remibergsma/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/remibergsma/cloudstack/tags","blobs_url":"https://api.github.com/repos/remibergsma/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remibergsma/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remibergsma/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/remibergsma/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remibergsma/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/remibergsma/cloudstack/languages","stargazers_url":"https://api.github.com/repos/remibergsma/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/remibergsma/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/remibergsma/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/remibergsma/cloudstack/subscription","commits_url":"https://api.github.com/repos/remibergsma/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/remibergsma/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/remibergsma/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/remibergsma/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/remibergsma/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/remibergsma/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remibergsma/cloudstack/merges","archive_url":"https://api.github.com/repos/remibergsma/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remibergsma/cloudstack/downloads","issues_url":"https://api.github.com/repos/remibergsma/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/remibergsma/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/remibergsma/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/remibergsma/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remibergsma/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/remibergsma/cloudstack/releases{/id}","created_at":"2015-04-09T10:12:10Z","updated_at":"2015-04-09T10:18:22Z","pushed_at":"2015-04-09T10:18:22Z","git_url":"git://github.com/remibergsma/cloudstack.git","ssh_url":"git@github.com:remibergsma/cloudstack.git","clone_url":"https://github.com/remibergsma/cloudstack.git","svn_url":"https://github.com/remibergsma/cloudstack","homepage":null,"size":720198,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"770297e8cb14fea4dae2f5f0bfd8aaefa8ea0aa3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-04-09T07:45:46Z","pushed_at":"2015-04-09T10:40:48Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":720198,"stargazers_count":232,"watchers_count":232,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":265,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":6,"forks":265,"open_issues":6,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/152"},"html":{"href":"https://github.com/apache/cloudstack/pull/152"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/152"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/7bce656b409f6bc0e18fe963cfeb9c2134b095be"}}}}