{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/39225740","id":39225740,"diff_hunk":"@@ -1014,8 +1014,11 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler)\n \n     RegisterNodeSignals(GetNodeSignals());\n \n-    // format user agent, check total size\n-    strSubVersion = FormatSubVersion(CLIENT_NAME, CLIENT_VERSION, mapMultiArgs.count(\"-uacomment\") ? mapMultiArgs[\"-uacomment\"] : std::vector<string>());\n+    // sanitize comments per BIP-0014, format user agent and check total size\n+    std::vector<string> uacomments;\n+    BOOST_FOREACH(string cmt, mapMultiArgs[\"-uacomment\"])","path":"src/init.cpp","position":8,"original_position":8,"commit_id":"dfafd6fbec27051964b1a9e02dbb3821d0af1db8","original_commit_id":"63d8457f97665f8b45f22c3e33f83bb52cf30395","user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"body":"Made it to return error, but I am thinking about using warnings instead for the whole uacomment thing.","created_at":"2015-09-10T23:09:50Z","updated_at":"2015-09-10T23:09:50Z","html_url":"https://github.com/bitcoin/bitcoin/pull/6647#discussion_r39225740","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6647","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/39225740"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6647#discussion_r39225740"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6647"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6647","id":44343538,"html_url":"https://github.com/bitcoin/bitcoin/pull/6647","diff_url":"https://github.com/bitcoin/bitcoin/pull/6647.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6647.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6647","number":6647,"state":"open","locked":false,"title":"Sanitize uacomment","user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"body":"* `SanitizeString()` can be requested to be more strict\r\n* Actually apply `SanitizeString()` to `uacomment`s","created_at":"2015-09-07T10:55:00Z","updated_at":"2015-09-10T23:09:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"798d942976a87fdcb0d69718927b9cacf457aecb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6647/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6647/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6647/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/dfafd6fbec27051964b1a9e02dbb3821d0af1db8","head":{"label":"MarcoFalke:MarcoFalke-2015-uacommentFix","ref":"MarcoFalke-2015-uacommentFix","sha":"dfafd6fbec27051964b1a9e02dbb3821d0af1db8","user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"repo":{"id":40046254,"name":"bitcoin","full_name":"MarcoFalke/bitcoin","owner":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarcoFalke/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/MarcoFalke/bitcoin","forks_url":"https://api.github.com/repos/MarcoFalke/bitcoin/forks","keys_url":"https://api.github.com/repos/MarcoFalke/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarcoFalke/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarcoFalke/bitcoin/teams","hooks_url":"https://api.github.com/repos/MarcoFalke/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/MarcoFalke/bitcoin/events","assignees_url":"https://api.github.com/repos/MarcoFalke/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/MarcoFalke/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/MarcoFalke/bitcoin/tags","blobs_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarcoFalke/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/MarcoFalke/bitcoin/languages","stargazers_url":"https://api.github.com/repos/MarcoFalke/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/MarcoFalke/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/MarcoFalke/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/MarcoFalke/bitcoin/subscription","commits_url":"https://api.github.com/repos/MarcoFalke/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarcoFalke/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarcoFalke/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarcoFalke/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/MarcoFalke/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarcoFalke/bitcoin/merges","archive_url":"https://api.github.com/repos/MarcoFalke/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarcoFalke/bitcoin/downloads","issues_url":"https://api.github.com/repos/MarcoFalke/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/MarcoFalke/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/MarcoFalke/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/MarcoFalke/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarcoFalke/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/MarcoFalke/bitcoin/releases{/id}","created_at":"2015-08-01T12:42:47Z","updated_at":"2015-08-01T12:42:56Z","pushed_at":"2015-09-09T13:10:41Z","git_url":"git://github.com/MarcoFalke/bitcoin.git","ssh_url":"git@github.com:MarcoFalke/bitcoin.git","clone_url":"https://github.com/MarcoFalke/bitcoin.git","svn_url":"https://github.com/MarcoFalke/bitcoin","homepage":"https://bitcoin.org/en/download","size":55457,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"3224936bedd8fe777b23d43c253abd2c0cd95d22","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-09-10T18:14:08Z","pushed_at":"2015-09-10T22:47:13Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":134495,"stargazers_count":7441,"watchers_count":7441,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5166,"mirror_url":null,"open_issues_count":459,"forks":5166,"open_issues":459,"watchers":7441,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6647"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6647"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6647"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6647/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6647/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6647/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/dfafd6fbec27051964b1a9e02dbb3821d0af1db8"}}}}