{"action":"created","comment":{"url":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/comments/46949877","id":46949877,"diff_hunk":"@@ -35,6 +35,13 @@\n     mode   => '0700',\n   }\n \n+  file { $mcollective::ssldir:","path":"manifests/server/config.pp","position":4,"original_position":4,"commit_id":"9c845b23a6a3e734835725ba79d87bd3153babbd","original_commit_id":"9c845b23a6a3e734835725ba79d87bd3153babbd","user":{"login":"petems","id":1064715,"avatar_url":"https://avatars.githubusercontent.com/u/1064715?v=3","gravatar_id":"","url":"https://api.github.com/users/petems","html_url":"https://github.com/petems","followers_url":"https://api.github.com/users/petems/followers","following_url":"https://api.github.com/users/petems/following{/other_user}","gists_url":"https://api.github.com/users/petems/gists{/gist_id}","starred_url":"https://api.github.com/users/petems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petems/subscriptions","organizations_url":"https://api.github.com/users/petems/orgs","repos_url":"https://api.github.com/users/petems/repos","events_url":"https://api.github.com/users/petems/events{/privacy}","received_events_url":"https://api.github.com/users/petems/received_events","type":"User","site_admin":false},"body":"Might want to throw is inside of an if block, so people can choose to manage it or not :+1: ","created_at":"2015-12-08T13:04:23Z","updated_at":"2015-12-08T13:04:23Z","html_url":"https://github.com/puppet-community/puppet-mcollective/pull/265#discussion_r46949877","pull_request_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/265","_links":{"self":{"href":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/comments/46949877"},"html":{"href":"https://github.com/puppet-community/puppet-mcollective/pull/265#discussion_r46949877"},"pull_request":{"href":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/265","id":52976202,"html_url":"https://github.com/puppet-community/puppet-mcollective/pull/265","diff_url":"https://github.com/puppet-community/puppet-mcollective/pull/265.diff","patch_url":"https://github.com/puppet-community/puppet-mcollective/pull/265.patch","issue_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/issues/265","number":265,"state":"open","locked":false,"title":"Manage ssl directory for mcollective certs","user":{"login":"dnlsng","id":1486231,"avatar_url":"https://avatars.githubusercontent.com/u/1486231?v=3","gravatar_id":"","url":"https://api.github.com/users/dnlsng","html_url":"https://github.com/dnlsng","followers_url":"https://api.github.com/users/dnlsng/followers","following_url":"https://api.github.com/users/dnlsng/following{/other_user}","gists_url":"https://api.github.com/users/dnlsng/gists{/gist_id}","starred_url":"https://api.github.com/users/dnlsng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnlsng/subscriptions","organizations_url":"https://api.github.com/users/dnlsng/orgs","repos_url":"https://api.github.com/users/dnlsng/repos","events_url":"https://api.github.com/users/dnlsng/events{/privacy}","received_events_url":"https://api.github.com/users/dnlsng/received_events","type":"User","site_admin":false},"body":"The path for the certs in this module is $confdir/ssl. In the old style\r\nmcollective packages, this directory is created at installation. However in\r\nthe new AIO puppet-agent package, this directory is not present, therefore\r\nthis module will fail to run successfully.\r\n\r\nThis commit ensures the directory exists.","created_at":"2015-12-08T12:49:33Z","updated_at":"2015-12-08T13:04:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a72b1664e69431d304a5580c4e94c4d69eafc0f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/265/commits","review_comments_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/265/comments","review_comment_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/issues/265/comments","statuses_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/statuses/9c845b23a6a3e734835725ba79d87bd3153babbd","head":{"label":"dnlsng:manage-ssl-dir","ref":"manage-ssl-dir","sha":"9c845b23a6a3e734835725ba79d87bd3153babbd","user":{"login":"dnlsng","id":1486231,"avatar_url":"https://avatars.githubusercontent.com/u/1486231?v=3","gravatar_id":"","url":"https://api.github.com/users/dnlsng","html_url":"https://github.com/dnlsng","followers_url":"https://api.github.com/users/dnlsng/followers","following_url":"https://api.github.com/users/dnlsng/following{/other_user}","gists_url":"https://api.github.com/users/dnlsng/gists{/gist_id}","starred_url":"https://api.github.com/users/dnlsng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnlsng/subscriptions","organizations_url":"https://api.github.com/users/dnlsng/orgs","repos_url":"https://api.github.com/users/dnlsng/repos","events_url":"https://api.github.com/users/dnlsng/events{/privacy}","received_events_url":"https://api.github.com/users/dnlsng/received_events","type":"User","site_admin":false},"repo":{"id":47617607,"name":"puppet-mcollective","full_name":"dnlsng/puppet-mcollective","owner":{"login":"dnlsng","id":1486231,"avatar_url":"https://avatars.githubusercontent.com/u/1486231?v=3","gravatar_id":"","url":"https://api.github.com/users/dnlsng","html_url":"https://github.com/dnlsng","followers_url":"https://api.github.com/users/dnlsng/followers","following_url":"https://api.github.com/users/dnlsng/following{/other_user}","gists_url":"https://api.github.com/users/dnlsng/gists{/gist_id}","starred_url":"https://api.github.com/users/dnlsng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnlsng/subscriptions","organizations_url":"https://api.github.com/users/dnlsng/orgs","repos_url":"https://api.github.com/users/dnlsng/repos","events_url":"https://api.github.com/users/dnlsng/events{/privacy}","received_events_url":"https://api.github.com/users/dnlsng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnlsng/puppet-mcollective","description":"MCollective Server and Client Puppet Module","fork":true,"url":"https://api.github.com/repos/dnlsng/puppet-mcollective","forks_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/forks","keys_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/teams","hooks_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/hooks","issue_events_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/issues/events{/number}","events_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/events","assignees_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/assignees{/user}","branches_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/branches{/branch}","tags_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/tags","blobs_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/statuses/{sha}","languages_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/languages","stargazers_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/stargazers","contributors_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/contributors","subscribers_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/subscribers","subscription_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/subscription","commits_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/contents/{+path}","compare_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/merges","archive_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/downloads","issues_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/issues{/number}","pulls_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/pulls{/number}","milestones_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/milestones{/number}","notifications_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/labels{/name}","releases_url":"https://api.github.com/repos/dnlsng/puppet-mcollective/releases{/id}","created_at":"2015-12-08T11:19:15Z","updated_at":"2015-12-08T11:19:16Z","pushed_at":"2015-12-08T12:39:08Z","git_url":"git://github.com/dnlsng/puppet-mcollective.git","ssh_url":"git@github.com:dnlsng/puppet-mcollective.git","clone_url":"https://github.com/dnlsng/puppet-mcollective.git","svn_url":"https://github.com/dnlsng/puppet-mcollective","homepage":"https://forge.puppetlabs.com/puppet/mcollective","size":376,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppet-community:master","ref":"master","sha":"e2137de3527644a0f2a6727ea64bdded897450e7","user":{"login":"puppet-community","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/puppet-community","html_url":"https://github.com/puppet-community","followers_url":"https://api.github.com/users/puppet-community/followers","following_url":"https://api.github.com/users/puppet-community/following{/other_user}","gists_url":"https://api.github.com/users/puppet-community/gists{/gist_id}","starred_url":"https://api.github.com/users/puppet-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppet-community/subscriptions","organizations_url":"https://api.github.com/users/puppet-community/orgs","repos_url":"https://api.github.com/users/puppet-community/repos","events_url":"https://api.github.com/users/puppet-community/events{/privacy}","received_events_url":"https://api.github.com/users/puppet-community/received_events","type":"Organization","site_admin":false},"repo":{"id":1522671,"name":"puppet-mcollective","full_name":"puppet-community/puppet-mcollective","owner":{"login":"puppet-community","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/puppet-community","html_url":"https://github.com/puppet-community","followers_url":"https://api.github.com/users/puppet-community/followers","following_url":"https://api.github.com/users/puppet-community/following{/other_user}","gists_url":"https://api.github.com/users/puppet-community/gists{/gist_id}","starred_url":"https://api.github.com/users/puppet-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppet-community/subscriptions","organizations_url":"https://api.github.com/users/puppet-community/orgs","repos_url":"https://api.github.com/users/puppet-community/repos","events_url":"https://api.github.com/users/puppet-community/events{/privacy}","received_events_url":"https://api.github.com/users/puppet-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppet-community/puppet-mcollective","description":"MCollective Server and Client Puppet Module","fork":false,"url":"https://api.github.com/repos/puppet-community/puppet-mcollective","forks_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/forks","keys_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/teams","hooks_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/hooks","issue_events_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/issues/events{/number}","events_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/events","assignees_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/assignees{/user}","branches_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/branches{/branch}","tags_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/tags","blobs_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/statuses/{sha}","languages_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/languages","stargazers_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/stargazers","contributors_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/contributors","subscribers_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/subscribers","subscription_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/subscription","commits_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/contents/{+path}","compare_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/merges","archive_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/downloads","issues_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/issues{/number}","pulls_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls{/number}","milestones_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/milestones{/number}","notifications_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/labels{/name}","releases_url":"https://api.github.com/repos/puppet-community/puppet-mcollective/releases{/id}","created_at":"2011-03-24T20:18:16Z","updated_at":"2015-11-18T03:10:23Z","pushed_at":"2015-12-08T12:49:34Z","git_url":"git://github.com/puppet-community/puppet-mcollective.git","ssh_url":"git@github.com:puppet-community/puppet-mcollective.git","clone_url":"https://github.com/puppet-community/puppet-mcollective.git","svn_url":"https://github.com/puppet-community/puppet-mcollective","homepage":"https://forge.puppetlabs.com/puppet/mcollective","size":668,"stargazers_count":114,"watchers_count":114,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":33,"forks":185,"open_issues":33,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/265"},"html":{"href":"https://github.com/puppet-community/puppet-mcollective/pull/265"},"issue":{"href":"https://api.github.com/repos/puppet-community/puppet-mcollective/issues/265"},"comments":{"href":"https://api.github.com/repos/puppet-community/puppet-mcollective/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppet-community/puppet-mcollective/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/puppet-community/puppet-mcollective/statuses/9c845b23a6a3e734835725ba79d87bd3153babbd"}}}}