{"action":"closed","issue":{"url":"https://api.github.com/repos/scalaz/scalaz-stream/issues/344","labels_url":"https://api.github.com/repos/scalaz/scalaz-stream/issues/344/labels{/name}","comments_url":"https://api.github.com/repos/scalaz/scalaz-stream/issues/344/comments","events_url":"https://api.github.com/repos/scalaz/scalaz-stream/issues/344/events","html_url":"https://github.com/scalaz/scalaz-stream/issues/344","id":63567715,"number":344,"title":"Rename WriterSyntax.drain{W,O}?","user":{"login":"fthomas","id":141252,"avatar_url":"https://avatars.githubusercontent.com/u/141252?v=3","gravatar_id":"","url":"https://api.github.com/users/fthomas","html_url":"https://github.com/fthomas","followers_url":"https://api.github.com/users/fthomas/followers","following_url":"https://api.github.com/users/fthomas/following{/other_user}","gists_url":"https://api.github.com/users/fthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/fthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fthomas/subscriptions","organizations_url":"https://api.github.com/users/fthomas/orgs","repos_url":"https://api.github.com/users/fthomas/repos","events_url":"https://api.github.com/users/fthomas/events{/privacy}","received_events_url":"https://api.github.com/users/fthomas/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-03-22T19:42:20Z","updated_at":"2015-04-15T10:17:35Z","closed_at":"2015-04-15T10:17:35Z","body":"`Process.drain` is defined as\r\n```\r\ndef drain: Process[F, Nothing] = flatMap(_ => halt)\r\n```\r\nwhile `WriterSyntax.drainW` and `WriterSyntax.drainO` are defined as\r\n```\r\ndef drainW(snk: Sink[F,W]): Process[F,O] = observeW(snk).stripW\r\ndef drainO(snk: Sink[F,O]): Process[F,W] = observeO(snk).stripO\r\n```\r\nIMO this is unfortunate because `Process.drain` suggests that those two are more like\r\n```\r\ndef drainW: Writer[F, Nothing, O] = self.flatMapW(_ => halt)\r\ndef drainO: Writer[F, W, Nothing] = self.flatMapO(_ => halt)\r\n```\r\nwhich are useful functions on their own I'd like to add later. Should we rename `drainW` and `drainO`? What would be better names for them?"}}