{"action":"created","comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/35493976","id":35493976,"diff_hunk":"@@ -0,0 +1,115 @@\n+<?php","path":"phpBB/phpbb/install/helper/navigation/navigation_provider.php","position":1,"original_position":1,"commit_id":"f7641cd506bd8ad98e923ce84f9f39960a938a69","original_commit_id":"f7641cd506bd8ad98e923ce84f9f39960a938a69","user":{"login":"Nicofuma","id":591456,"avatar_url":"https://avatars.githubusercontent.com/u/591456?v=3","gravatar_id":"","url":"https://api.github.com/users/Nicofuma","html_url":"https://github.com/Nicofuma","followers_url":"https://api.github.com/users/Nicofuma/followers","following_url":"https://api.github.com/users/Nicofuma/following{/other_user}","gists_url":"https://api.github.com/users/Nicofuma/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicofuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicofuma/subscriptions","organizations_url":"https://api.github.com/users/Nicofuma/orgs","repos_url":"https://api.github.com/users/Nicofuma/repos","events_url":"https://api.github.com/users/Nicofuma/events{/privacy}","received_events_url":"https://api.github.com/users/Nicofuma/received_events","type":"User","site_admin":false},"body":"in some cases it can hurt performances very hard (when a performance is passed instead of a raw variable or the other side) and it often (always?) make the code more complicated to understand.","created_at":"2015-07-26T15:20:26Z","updated_at":"2015-07-26T15:20:26Z","html_url":"https://github.com/phpbb/phpbb/pull/3514#discussion_r35493976","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3514","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/35493976"},"html":{"href":"https://github.com/phpbb/phpbb/pull/3514#discussion_r35493976"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3514"}}},"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/3514","id":32552582,"html_url":"https://github.com/phpbb/phpbb/pull/3514","diff_url":"https://github.com/phpbb/phpbb/pull/3514.diff","patch_url":"https://github.com/phpbb/phpbb/pull/3514.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/3514","number":3514,"state":"open","locked":false,"title":"[ticket/13740] Refactoring installer","user":{"login":"CHItA","id":10946388,"avatar_url":"https://avatars.githubusercontent.com/u/10946388?v=3","gravatar_id":"","url":"https://api.github.com/users/CHItA","html_url":"https://github.com/CHItA","followers_url":"https://api.github.com/users/CHItA/followers","following_url":"https://api.github.com/users/CHItA/following{/other_user}","gists_url":"https://api.github.com/users/CHItA/gists{/gist_id}","starred_url":"https://api.github.com/users/CHItA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CHItA/subscriptions","organizations_url":"https://api.github.com/users/CHItA/orgs","repos_url":"https://api.github.com/users/CHItA/repos","events_url":"https://api.github.com/users/CHItA/events{/privacy}","received_events_url":"https://api.github.com/users/CHItA/received_events","type":"User","site_admin":false},"body":"Please note that this is a work in progress.\r\n\r\nThe description of this idea can be found in the [ticket](https://tracker.phpbb.com/browse/PHPBB3-13740).\r\n\r\n**List of removed features**:\r\n - config.php has to be writable, the download option has been removed\r\n\r\n**Dependencies that has to be merged before this**:\r\n - ~~#3487~~ - Moving filesystem related functions into a service (**merged**)\r\n - ~~#3535~~  - Moving language related functionality into a service (**merged**)\r\n - ~~#3577~~ -  Make router's extension manager dependency optional (**merged**)\r\n - ~~#3581~~ - Make template's user dependency optional (**merged**)\r\n - ~~#3608~~ - Don't fail if the cache isn't writable (**merged**)\r\n - ~~#3554~~ - Wither interface for container_builder (**merged**)\r\n - ~~#3552~~ - Moving module managing functionality into a service (**merged**)\r\n - ~~#3726~~ - Add orderable service collections (**merged**)\r\n\r\n**TODO**:\r\n - [x] Moving and refactoring old installer\r\n - [ ] ~~Moving and refactoring old updater~~\r\n - [ ] ~~Moving and refactoring old converter~~\r\n - [x] Implement AJAX UI\r\n - [ ] ~~Implement no JS UI~~\r\n - [x] Add install config environment and install service config files\r\n - [x] Add/implement new installer helpers\r\n - [x] Add tests\r\n\r\n**Screenshots**:\r\nPlease see the [ticket](https://tracker.phpbb.com/browse/PHPBB3-13740) for screenshots.","created_at":"2015-04-02T21:34:26Z","updated_at":"2015-07-26T15:20:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c347f65fe2c11f0a0c54b3361a0dc80f509418a9","assignee":null,"milestone":{"url":"https://api.github.com/repos/phpbb/phpbb/milestones/2","html_url":"https://github.com/phpbb/phpbb/milestones/3.2.0","labels_url":"https://api.github.com/repos/phpbb/phpbb/milestones/2/labels","id":835770,"number":2,"title":"3.2.0","description":"","creator":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=3","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":141,"state":"open","created_at":"2014-10-22T10:41:02Z","updated_at":"2015-07-22T09:34:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3514/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3514/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/3514/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/f7641cd506bd8ad98e923ce84f9f39960a938a69","head":{"label":"CHItA:ticket/13740","ref":"ticket/13740","sha":"f7641cd506bd8ad98e923ce84f9f39960a938a69","user":{"login":"CHItA","id":10946388,"avatar_url":"https://avatars.githubusercontent.com/u/10946388?v=3","gravatar_id":"","url":"https://api.github.com/users/CHItA","html_url":"https://github.com/CHItA","followers_url":"https://api.github.com/users/CHItA/followers","following_url":"https://api.github.com/users/CHItA/following{/other_user}","gists_url":"https://api.github.com/users/CHItA/gists{/gist_id}","starred_url":"https://api.github.com/users/CHItA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CHItA/subscriptions","organizations_url":"https://api.github.com/users/CHItA/orgs","repos_url":"https://api.github.com/users/CHItA/repos","events_url":"https://api.github.com/users/CHItA/events{/privacy}","received_events_url":"https://api.github.com/users/CHItA/received_events","type":"User","site_admin":false},"repo":{"id":31021414,"name":"phpbb","full_name":"CHItA/phpbb","owner":{"login":"CHItA","id":10946388,"avatar_url":"https://avatars.githubusercontent.com/u/10946388?v=3","gravatar_id":"","url":"https://api.github.com/users/CHItA","html_url":"https://github.com/CHItA","followers_url":"https://api.github.com/users/CHItA/followers","following_url":"https://api.github.com/users/CHItA/following{/other_user}","gists_url":"https://api.github.com/users/CHItA/gists{/gist_id}","starred_url":"https://api.github.com/users/CHItA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CHItA/subscriptions","organizations_url":"https://api.github.com/users/CHItA/orgs","repos_url":"https://api.github.com/users/CHItA/repos","events_url":"https://api.github.com/users/CHItA/events{/privacy}","received_events_url":"https://api.github.com/users/CHItA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CHItA/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":true,"url":"https://api.github.com/repos/CHItA/phpbb","forks_url":"https://api.github.com/repos/CHItA/phpbb/forks","keys_url":"https://api.github.com/repos/CHItA/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CHItA/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CHItA/phpbb/teams","hooks_url":"https://api.github.com/repos/CHItA/phpbb/hooks","issue_events_url":"https://api.github.com/repos/CHItA/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/CHItA/phpbb/events","assignees_url":"https://api.github.com/repos/CHItA/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/CHItA/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/CHItA/phpbb/tags","blobs_url":"https://api.github.com/repos/CHItA/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CHItA/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CHItA/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CHItA/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CHItA/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/CHItA/phpbb/languages","stargazers_url":"https://api.github.com/repos/CHItA/phpbb/stargazers","contributors_url":"https://api.github.com/repos/CHItA/phpbb/contributors","subscribers_url":"https://api.github.com/repos/CHItA/phpbb/subscribers","subscription_url":"https://api.github.com/repos/CHItA/phpbb/subscription","commits_url":"https://api.github.com/repos/CHItA/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CHItA/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CHItA/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CHItA/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CHItA/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/CHItA/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CHItA/phpbb/merges","archive_url":"https://api.github.com/repos/CHItA/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CHItA/phpbb/downloads","issues_url":"https://api.github.com/repos/CHItA/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/CHItA/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/CHItA/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/CHItA/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CHItA/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/CHItA/phpbb/releases{/id}","created_at":"2015-02-19T15:25:22Z","updated_at":"2015-05-05T17:16:42Z","pushed_at":"2015-07-25T13:41:17Z","git_url":"git://github.com/CHItA/phpbb.git","ssh_url":"git@github.com:CHItA/phpbb.git","clone_url":"https://github.com/CHItA/phpbb.git","svn_url":"https://github.com/CHItA/phpbb","homepage":"http://www.phpbb.com","size":57078,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phpbb:master","ref":"master","sha":"8df16ed92c65228593167d3f187a05ccf85f5a9d","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":541983,"name":"phpbb","full_name":"phpbb/phpbb","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb","forks_url":"https://api.github.com/repos/phpbb/phpbb/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpbb/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb/releases{/id}","created_at":"2010-03-01T22:33:17Z","updated_at":"2015-07-26T15:12:11Z","pushed_at":"2015-07-26T11:24:05Z","git_url":"git://github.com/phpbb/phpbb.git","ssh_url":"git@github.com:phpbb/phpbb.git","clone_url":"https://github.com/phpbb/phpbb.git","svn_url":"https://github.com/phpbb/phpbb","homepage":"http://www.phpbb.com","size":195370,"stargazers_count":758,"watchers_count":758,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":477,"mirror_url":null,"open_issues_count":79,"forks":477,"open_issues":79,"watchers":758,"default_branch":"3.1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3514"},"html":{"href":"https://github.com/phpbb/phpbb/pull/3514"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/3514"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/3514/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3514/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3514/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb/statuses/f7641cd506bd8ad98e923ce84f9f39960a938a69"}}}}