{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/4941","labels_url":"https://api.github.com/repos/openshift/origin/issues/4941/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4941/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/4941/events","html_url":"https://github.com/openshift/origin/pull/4941","id":109780151,"number":4941,"title":"Report transient deployment trigger errors via API field","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":27,"created_at":"2015-10-05T11:50:09Z","updated_at":"2015-10-12T12:43:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/4941","html_url":"https://github.com/openshift/origin/pull/4941","diff_url":"https://github.com/openshift/origin/pull/4941.diff","patch_url":"https://github.com/openshift/origin/pull/4941.patch"},"body":"Missing istag, bc points to it:\r\n```sh\r\n[vagrant@openshiftdev sample-app]$ oc process -f application-template-stibuild.json | oc create -f -\r\nservice \"frontend\" created\r\nroute \"route-edge\" created\r\nimagestream \"origin-ruby-sample\" created\r\nimagestream \"ruby-20-centos7\" created\r\nbuildconfig \"ruby-sample-build\" created\r\ndeploymentconfig \"frontend\" created\r\nservice \"database\" created\r\ndeploymentconfig \"database\" created\r\n[vagrant@openshiftdev sample-app]$ oc delete is origin-ruby-sample\r\nimagestream \"origin-ruby-sample\" deleted\r\n\r\n# Give some time to the controller until it touches the dc again\r\n\r\n[vagrant@openshiftdev sample-app]$ oc describe dc/frontend\r\nName:\t\tfrontend\r\nCreated:\t2 minutes ago\r\nLabels:\t\ttemplate=application-template-stibuild\r\nLatest Version:\tNot deployed\r\nTriggers:\tImage(origin-ruby-sample@latest, auto=true), Config\r\nStrategy:\tRolling\r\n\t\t  Pre-deployment hook (pod type, failure policy: Abort)\r\n\t\t    Container:\truby-helloworld\r\n\t\t    Command:\t/bin/true\r\n\t\t    Env:\tCUSTOM_VAR1=custom_value1\r\n\t\t  Post-deployment hook (pod type, failure policy: Ignore)\r\n\t\t    Container:\truby-helloworld\r\n\t\t    Command:\t/bin/false\r\n\t\t    Env:\tCUSTOM_VAR2=custom_value2\r\nTemplate:\r\n  Selector:\tname=frontend\r\n  Replicas:\t2\r\n  Containers:\r\n  NAME\t\t\tIMAGE\t\t\tENV\r\n  ruby-helloworld\torigin-ruby-sample\tADMIN_PASSWORD=quGqvBYF,ADMIN_USERNAME=admin1I5,MYSQL_DATABASE=root,MYSQL_PASSWORD=yDXht2OJ,MYSQL_USER=user3CA\r\nWarning:\t\t\"origin-ruby-sample:latest\" does not exist yet but will be created at some point since buildConfig \"ruby-sample-build\" points to it\r\nLatest Deployment:\t<none>\r\nNo events.\r\n```\r\nMissing istag, no bc output\r\n```sh\r\n[vagrant@openshiftdev sample-app]$ oc delete is origin-ruby-sample\r\nimagestream \"origin-ruby-sample\" deleted\r\n[vagrant@openshiftdev sample-app]$ oc delete bc ruby-sample-build\r\nbuildconfig \"ruby-sample-build\" deleted\r\n\r\n# Give some time to the controller until it touches the dc again\r\n\r\n[vagrant@openshiftdev sample-app]$ oc describe dc/frontend\r\nName:\t\tfrontend\r\nCreated:\tAbout a minute ago\r\nLabels:\t\ttemplate=application-template-stibuild\r\nLatest Version:\tNot deployed\r\nTriggers:\tImage(origin-ruby-sample@latest, auto=true), Config\r\nStrategy:\tRolling\r\n\t\t  Pre-deployment hook (pod type, failure policy: Abort)\r\n\t\t    Container:\truby-helloworld\r\n\t\t    Command:\t/bin/true\r\n\t\t    Env:\tCUSTOM_VAR1=custom_value1\r\n\t\t  Post-deployment hook (pod type, failure policy: Ignore)\r\n\t\t    Container:\truby-helloworld\r\n\t\t    Command:\t/bin/false\r\n\t\t    Env:\tCUSTOM_VAR2=custom_value2\r\nTemplate:\r\n  Selector:\tname=frontend\r\n  Replicas:\t2\r\n  Containers:\r\n  NAME\t\t\tIMAGE\t\t\tENV\r\n  ruby-helloworld\torigin-ruby-sample\tADMIN_PASSWORD=xU2H5PPU,ADMIN_USERNAME=adminVY3,MYSQL_DATABASE=root,MYSQL_PASSWORD=6lGryqNe,MYSQL_USER=user4PU\r\nWarning:\t\tThe config trigger for \"test/frontend:0\" will have no effect because \"origin-ruby-sample:latest\" does not exist\r\nLatest Deployment:\t<none>\r\nNo events.\r\n```\r\n\r\n@ironcladlou PTAL\r\n\r\nFixes https://github.com/openshift/origin/issues/3526\r\nFixes https://github.com/openshift/origin/issues/4192\r\nFixes https://github.com/openshift/origin/issues/3311"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/147386102","html_url":"https://github.com/openshift/origin/pull/4941#issuecomment-147386102","issue_url":"https://api.github.com/repos/openshift/origin/issues/4941","id":147386102,"user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T12:43:17Z","updated_at":"2015-10-12T12:43:17Z","body":"> Don't use \"istag/\" syntax in messages from a controller. Say \"image stream tag foo:bar\"\r\n\r\nNot trying to re-open this issue for this pull, but why not keep the `TYPE/NAME` syntax consistent throughout all messages?  It's really convenient to be able to get an error message from anywhere and copy/paste a resource reference into an `oc describe `, `oc get -o yaml`, a label filter, or any other command with zero friction.  Given the usage of that format throughout every command in arguments and output, I think its reasonable to expect people to be able to read it."}}