{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/40789482","id":40789482,"diff_hunk":"@@ -1,101 +1,162 @@\n // Copyright (c) Microsoft. All rights reserved.\n // Licensed under the MIT license. See LICENSE file in the project root for full license information.\n \n+using System.Collections;\n+using System.Collections.Generic;\n+using System.Diagnostics.Contracts;\n+using System.Text;\n+\n namespace System.Globalization\n {\n-    using System;\n-    using System.Text;\n-    using System.Collections;\n-    using System.Collections.Generic;\n-    using System.Runtime.CompilerServices;\n-    using System.Runtime.InteropServices;\n-    using System.Runtime.Versioning;\n-    using System.Security;\n-    using System.Threading;\n-    using System.Diagnostics.Contracts;\n-\n     internal static class EncodingTable\n     {\n+        //\n+        // This caches the data item which is indexed by the code page value.","path":"src/mscorlib/src/System/Globalization/EncodingTable.Unix.cs","position":25,"original_position":25,"commit_id":"967889dde340f0720559dba94640d7f0108fc485","original_commit_id":"967889dde340f0720559dba94640d7f0108fc485","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"It's probably worth commenting on why this is using a Hashtable instead of a Dictionary.  I assume it's because Hashtable supports readers concurrent with a single writer, which means reading from a Synchronized Hashtable doesn't require locking on reads, whereas protecting a Dictionary would?  What about ConcurrentDictionary?  Hashtable is fine for now... at some point it might be worthwhile examining whether a switch could be better.","created_at":"2015-09-30T12:56:15Z","updated_at":"2015-09-30T12:56:15Z","html_url":"https://github.com/dotnet/coreclr/pull/1645#discussion_r40789482","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1645","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/40789482"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1645#discussion_r40789482"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1645"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/1645","id":46324616,"html_url":"https://github.com/dotnet/coreclr/pull/1645","diff_url":"https://github.com/dotnet/coreclr/pull/1645.diff","patch_url":"https://github.com/dotnet/coreclr/pull/1645.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/1645","number":1645,"state":"open","locked":false,"title":"Implement Encodings on Linux","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"Our current Encodings implementation on Linux is stubbed out and\r\nneeds to be fully implemented for CoreClr.\r\n\r\nFix https://github.com/dotnet/corefx/issues/2774.\r\n\r\n@ellismg ","created_at":"2015-09-29T20:02:19Z","updated_at":"2015-09-30T12:56:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3de15a40996e224e1b6b6a4222c4fea14488555b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1645/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1645/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/1645/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/967889dde340f0720559dba94640d7f0108fc485","head":{"label":"eerhardt:Encoding","ref":"Encoding","sha":"967889dde340f0720559dba94640d7f0108fc485","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"repo":{"id":39392450,"name":"coreclr","full_name":"eerhardt/coreclr","owner":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eerhardt/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/eerhardt/coreclr","forks_url":"https://api.github.com/repos/eerhardt/coreclr/forks","keys_url":"https://api.github.com/repos/eerhardt/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eerhardt/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eerhardt/coreclr/teams","hooks_url":"https://api.github.com/repos/eerhardt/coreclr/hooks","issue_events_url":"https://api.github.com/repos/eerhardt/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/eerhardt/coreclr/events","assignees_url":"https://api.github.com/repos/eerhardt/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/eerhardt/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/eerhardt/coreclr/tags","blobs_url":"https://api.github.com/repos/eerhardt/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eerhardt/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eerhardt/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eerhardt/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eerhardt/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/eerhardt/coreclr/languages","stargazers_url":"https://api.github.com/repos/eerhardt/coreclr/stargazers","contributors_url":"https://api.github.com/repos/eerhardt/coreclr/contributors","subscribers_url":"https://api.github.com/repos/eerhardt/coreclr/subscribers","subscription_url":"https://api.github.com/repos/eerhardt/coreclr/subscription","commits_url":"https://api.github.com/repos/eerhardt/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eerhardt/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eerhardt/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eerhardt/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eerhardt/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/eerhardt/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eerhardt/coreclr/merges","archive_url":"https://api.github.com/repos/eerhardt/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eerhardt/coreclr/downloads","issues_url":"https://api.github.com/repos/eerhardt/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/eerhardt/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/eerhardt/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/eerhardt/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eerhardt/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/eerhardt/coreclr/releases{/id}","created_at":"2015-07-20T15:37:07Z","updated_at":"2015-07-20T15:37:45Z","pushed_at":"2015-09-29T22:23:01Z","git_url":"git://github.com/eerhardt/coreclr.git","ssh_url":"git@github.com:eerhardt/coreclr.git","clone_url":"https://github.com/eerhardt/coreclr.git","svn_url":"https://github.com/eerhardt/coreclr","homepage":"http://dotnet.github.io/core/","size":38157,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"1572a8ab9b4f30459b3ae071cab2ae58e09e213d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2015-09-30T12:25:52Z","pushed_at":"2015-09-30T09:20:25Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/core/","size":57144,"stargazers_count":5225,"watchers_count":5225,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1058,"mirror_url":null,"open_issues_count":293,"forks":1058,"open_issues":293,"watchers":5225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1645"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1645"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1645"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1645/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1645/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1645/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/967889dde340f0720559dba94640d7f0108fc485"}}}}