{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/22438901","id":22438901,"diff_hunk":"@@ -162,47 +162,36 @@ protected function getInput()\n \t\t\t$attributes['aria-required'] = 'true';\n \t\t}\n \n-\t\t// Handle the special case for \"now\".\n-\t\tif (strtoupper($this->value) == 'NOW')\n+\t\tif ($this->value && $this->value !== '0000-00-00 00:00:00')","path":"libraries/joomla/form/fields/calendar.php","position":6,"original_position":6,"commit_id":"bfb4edb6f7eea2866c9cc6959ee843de96cec172","original_commit_id":"bfb4edb6f7eea2866c9cc6959ee843de96cec172","user":{"login":"Fedik","id":1568198,"avatar_url":"https://avatars.githubusercontent.com/u/1568198?v=3","gravatar_id":"","url":"https://api.github.com/users/Fedik","html_url":"https://github.com/Fedik","followers_url":"https://api.github.com/users/Fedik/followers","following_url":"https://api.github.com/users/Fedik/following{/other_user}","gists_url":"https://api.github.com/users/Fedik/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedik/subscriptions","organizations_url":"https://api.github.com/users/Fedik/orgs","repos_url":"https://api.github.com/users/Fedik/repos","events_url":"https://api.github.com/users/Fedik/events{/privacy}","received_events_url":"https://api.github.com/users/Fedik/received_events","type":"User","site_admin":false},"body":"yes, good idea :wink:","created_at":"2015-01-04T12:39:33Z","updated_at":"2015-01-04T12:39:33Z","html_url":"https://github.com/joomla/joomla-cms/pull/5611#discussion_r22438901","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/5611","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/22438901"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/5611#discussion_r22438901"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/5611"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/5611","id":26794411,"html_url":"https://github.com/joomla/joomla-cms/pull/5611","diff_url":"https://github.com/joomla/joomla-cms/pull/5611.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/5611.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/5611","number":5611,"state":"open","locked":false,"title":"Calendar field improve - allow more flexible date modifiers","user":{"login":"Fedik","id":1568198,"avatar_url":"https://avatars.githubusercontent.com/u/1568198?v=3","gravatar_id":"","url":"https://api.github.com/users/Fedik","html_url":"https://github.com/Fedik","followers_url":"https://api.github.com/users/Fedik/followers","following_url":"https://api.github.com/users/Fedik/following{/other_user}","gists_url":"https://api.github.com/users/Fedik/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedik/subscriptions","organizations_url":"https://api.github.com/users/Fedik/orgs","repos_url":"https://api.github.com/users/Fedik/repos","events_url":"https://api.github.com/users/Fedik/events{/privacy}","received_events_url":"https://api.github.com/users/Fedik/received_events","type":"User","site_admin":false},"body":"This pull allow to use more flexible date modifiers in default value, like `now +1 day`, `now -10 years` and more http://php.net/manual/en/function.strtotime.php#refsect1-function.strtotime-examples \r\n\r\n**test**\r\nTry create/edit existing content, and make sure that all calendar fields works as was before patch.\r\n\r\nThen try set some default value to the some calendar field, like `default=\"now +1 day\"`, `default=\"now -10 years\"` and make sure that the calendar display correct date\r\n\r\nThis pull request absorb #4508","created_at":"2015-01-04T12:09:54Z","updated_at":"2015-01-04T12:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ed07d0366ce4d138e4eaf993b07fee86543e3b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/5611/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/5611/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/5611/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/bfb4edb6f7eea2866c9cc6959ee843de96cec172","head":{"label":"Fedik:field-calendar-imp","ref":"field-calendar-imp","sha":"bfb4edb6f7eea2866c9cc6959ee843de96cec172","user":{"login":"Fedik","id":1568198,"avatar_url":"https://avatars.githubusercontent.com/u/1568198?v=3","gravatar_id":"","url":"https://api.github.com/users/Fedik","html_url":"https://github.com/Fedik","followers_url":"https://api.github.com/users/Fedik/followers","following_url":"https://api.github.com/users/Fedik/following{/other_user}","gists_url":"https://api.github.com/users/Fedik/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedik/subscriptions","organizations_url":"https://api.github.com/users/Fedik/orgs","repos_url":"https://api.github.com/users/Fedik/repos","events_url":"https://api.github.com/users/Fedik/events{/privacy}","received_events_url":"https://api.github.com/users/Fedik/received_events","type":"User","site_admin":false},"repo":{"id":7179494,"name":"joomla-cms","full_name":"Fedik/joomla-cms","owner":{"login":"Fedik","id":1568198,"avatar_url":"https://avatars.githubusercontent.com/u/1568198?v=3","gravatar_id":"","url":"https://api.github.com/users/Fedik","html_url":"https://github.com/Fedik","followers_url":"https://api.github.com/users/Fedik/followers","following_url":"https://api.github.com/users/Fedik/following{/other_user}","gists_url":"https://api.github.com/users/Fedik/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedik/subscriptions","organizations_url":"https://api.github.com/users/Fedik/orgs","repos_url":"https://api.github.com/users/Fedik/repos","events_url":"https://api.github.com/users/Fedik/events{/privacy}","received_events_url":"https://api.github.com/users/Fedik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fedik/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/Fedik/joomla-cms","forks_url":"https://api.github.com/repos/Fedik/joomla-cms/forks","keys_url":"https://api.github.com/repos/Fedik/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fedik/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fedik/joomla-cms/teams","hooks_url":"https://api.github.com/repos/Fedik/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/Fedik/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Fedik/joomla-cms/events","assignees_url":"https://api.github.com/repos/Fedik/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Fedik/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Fedik/joomla-cms/tags","blobs_url":"https://api.github.com/repos/Fedik/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fedik/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fedik/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fedik/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fedik/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Fedik/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/Fedik/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/Fedik/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/Fedik/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/Fedik/joomla-cms/subscription","commits_url":"https://api.github.com/repos/Fedik/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fedik/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fedik/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fedik/joomla-cms/issues/comments/{number}","contents_url":"https://api.github.com/repos/Fedik/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Fedik/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fedik/joomla-cms/merges","archive_url":"https://api.github.com/repos/Fedik/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fedik/joomla-cms/downloads","issues_url":"https://api.github.com/repos/Fedik/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Fedik/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Fedik/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Fedik/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fedik/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/Fedik/joomla-cms/releases{/id}","created_at":"2012-12-15T13:09:18Z","updated_at":"2015-01-04T11:36:33Z","pushed_at":"2015-01-04T11:55:40Z","git_url":"git://github.com/Fedik/joomla-cms.git","ssh_url":"git@github.com:Fedik/joomla-cms.git","clone_url":"https://github.com/Fedik/joomla-cms.git","svn_url":"https://github.com/Fedik/joomla-cms","homepage":"http://joomla.org","size":109171,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"joomla:staging","ref":"staging","sha":"cbc8b441b103013f33305988448a33b7eeb6f7a2","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/{number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","created_at":"2011-09-27T02:07:38Z","updated_at":"2015-01-04T08:46:52Z","pushed_at":"2015-01-04T08:46:52Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"http://joomla.org","size":288615,"stargazers_count":1389,"watchers_count":1389,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1544,"mirror_url":null,"open_issues_count":447,"forks":1544,"open_issues":447,"watchers":1389,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/5611"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/5611"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/5611"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/5611/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/5611/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/5611/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/bfb4edb6f7eea2866c9cc6959ee843de96cec172"}}}}