{"action":"created","issue":{"url":"https://api.github.com/repos/IntelOrca/OpenRCT2/issues/1023","labels_url":"https://api.github.com/repos/IntelOrca/OpenRCT2/issues/1023/labels{/name}","comments_url":"https://api.github.com/repos/IntelOrca/OpenRCT2/issues/1023/comments","events_url":"https://api.github.com/repos/IntelOrca/OpenRCT2/issues/1023/events","html_url":"https://github.com/IntelOrca/OpenRCT2/pull/1023","id":68958932,"number":1023,"title":"Fix some compiler warnings and potential bugs","user":{"login":"duncanspumpkin","id":1277401,"avatar_url":"https://avatars.githubusercontent.com/u/1277401?v=3","gravatar_id":"","url":"https://api.github.com/users/duncanspumpkin","html_url":"https://github.com/duncanspumpkin","followers_url":"https://api.github.com/users/duncanspumpkin/followers","following_url":"https://api.github.com/users/duncanspumpkin/following{/other_user}","gists_url":"https://api.github.com/users/duncanspumpkin/gists{/gist_id}","starred_url":"https://api.github.com/users/duncanspumpkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duncanspumpkin/subscriptions","organizations_url":"https://api.github.com/users/duncanspumpkin/orgs","repos_url":"https://api.github.com/users/duncanspumpkin/repos","events_url":"https://api.github.com/users/duncanspumpkin/events{/privacy}","received_events_url":"https://api.github.com/users/duncanspumpkin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-16T16:19:37Z","updated_at":"2015-04-28T13:38:39Z","closed_at":"2015-04-16T19:06:02Z","pull_request":{"url":"https://api.github.com/repos/IntelOrca/OpenRCT2/pulls/1023","html_url":"https://github.com/IntelOrca/OpenRCT2/pull/1023","diff_url":"https://github.com/IntelOrca/OpenRCT2/pull/1023.diff","patch_url":"https://github.com/IntelOrca/OpenRCT2/pull/1023.patch"},"body":"Kills a couple of the warnings from #1022. The other ones I wasn't really sure how best to get rid of them. "},"comment":{"url":"https://api.github.com/repos/IntelOrca/OpenRCT2/issues/comments/97067462","html_url":"https://github.com/IntelOrca/OpenRCT2/pull/1023#issuecomment-97067462","issue_url":"https://api.github.com/repos/IntelOrca/OpenRCT2/issues/1023","id":97067462,"user":{"login":"mdtrooper","id":1285451,"avatar_url":"https://avatars.githubusercontent.com/u/1285451?v=3","gravatar_id":"","url":"https://api.github.com/users/mdtrooper","html_url":"https://github.com/mdtrooper","followers_url":"https://api.github.com/users/mdtrooper/followers","following_url":"https://api.github.com/users/mdtrooper/following{/other_user}","gists_url":"https://api.github.com/users/mdtrooper/gists{/gist_id}","starred_url":"https://api.github.com/users/mdtrooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdtrooper/subscriptions","organizations_url":"https://api.github.com/users/mdtrooper/orgs","repos_url":"https://api.github.com/users/mdtrooper/repos","events_url":"https://api.github.com/users/mdtrooper/events{/privacy}","received_events_url":"https://api.github.com/users/mdtrooper/received_events","type":"User","site_admin":false},"created_at":"2015-04-28T13:38:39Z","updated_at":"2015-04-28T13:38:39Z","body":"Thanks.\r\n\r\nThere are less warnings.\r\n\r\n```\r\n$ make\r\nScanning dependencies of target openrct2\r\n[  0%] Building C object CMakeFiles/openrct2.dir/src/game.c.obj\r\n[  1%] Building C object CMakeFiles/openrct2.dir/src/drawing/drawing.c.obj\r\n[  2%] Building C object CMakeFiles/openrct2.dir/src/drawing/sprite.c.obj\r\n[  3%] Building C object CMakeFiles/openrct2.dir/src/drawing/string.c.obj\r\n[  3%] Building C object CMakeFiles/openrct2.dir/src/drawing/rect.c.obj\r\n[  4%] Building C object CMakeFiles/openrct2.dir/src/drawing/line.c.obj\r\n[  5%] Building C object CMakeFiles/openrct2.dir/src/drawing/rain.c.obj\r\n[  6%] Building C object CMakeFiles/openrct2.dir/src/windows/scenery.c.obj\r\n[  6%] Building C object CMakeFiles/openrct2.dir/src/windows/research.c.obj\r\n[  7%] Building C object CMakeFiles/openrct2.dir/src/windows/about.c.obj\r\n[  8%] Building C object CMakeFiles/openrct2.dir/src/windows/water.c.obj\r\n[  9%] Building C object CMakeFiles/openrct2.dir/src/windows/guest_list.c.obj\r\n[ 10%] Building C object CMakeFiles/openrct2.dir/src/windows/options.c.obj\r\n/tmp/OpenRCT2/src/windows/options.c: In function ‘window_options_mousedown’:\r\n/tmp/OpenRCT2/src/windows/options.c:493:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\r\n    gDropdownItemsArgs[i - 1] = (sint64)language_names[i];\r\n                                ^\r\n[ 10%] Building C object CMakeFiles/openrct2.dir/src/windows/editor_scenario_options.c.obj\r\n[ 11%] Building C object CMakeFiles/openrct2.dir/src/windows/track_manage.c.obj\r\n[ 12%] Building C object CMakeFiles/openrct2.dir/src/windows/title_logo.c.obj\r\n[ 13%] Building C object CMakeFiles/openrct2.dir/src/windows/demolish_ride_prompt.c.obj\r\n[ 13%] Building C object CMakeFiles/openrct2.dir/src/windows/main.c.obj\r\n[ 14%] Building C object CMakeFiles/openrct2.dir/src/windows/banner.c.obj\r\n[ 15%] Building C object CMakeFiles/openrct2.dir/src/windows/loadsave.c.obj\r\n[ 16%] Building C object CMakeFiles/openrct2.dir/src/windows/map.c.obj\r\n[ 16%] Building C object CMakeFiles/openrct2.dir/src/windows/editor_object_selection.c.obj\r\n[ 17%] Building C object CMakeFiles/openrct2.dir/src/windows/tooltip.c.obj\r\n[ 18%] Building C object CMakeFiles/openrct2.dir/src/windows/mapgen.c.obj\r\n[ 19%] Building C object CMakeFiles/openrct2.dir/src/windows/staff.c.obj\r\n[ 20%] Building C object CMakeFiles/openrct2.dir/src/windows/text_input.c.obj\r\n[ 20%] Building C object CMakeFiles/openrct2.dir/src/windows/guest.c.obj\r\n[ 21%] Building C object CMakeFiles/openrct2.dir/src/windows/title_scenarioselect.c.obj\r\n[ 22%] Building C object CMakeFiles/openrct2.dir/src/windows/staff_list.c.obj\r\n[ 23%] Building C object CMakeFiles/openrct2.dir/src/windows/top_toolbar.c.obj\r\n[ 23%] Building C object CMakeFiles/openrct2.dir/src/windows/editor_objective_options.c.obj\r\n[ 24%] Building C object CMakeFiles/openrct2.dir/src/windows/save_prompt.c.obj\r\n[ 25%] Building C object CMakeFiles/openrct2.dir/src/windows/dropdown.c.obj\r\n[ 26%] Building C object CMakeFiles/openrct2.dir/src/windows/new_campaign.c.obj\r\n[ 26%] Building C object CMakeFiles/openrct2.dir/src/windows/track_place.c.obj\r\n[ 27%] Building C object CMakeFiles/openrct2.dir/src/windows/ride_construction.c.obj\r\n[ 28%] Building C object CMakeFiles/openrct2.dir/src/windows/map_tooltip.c.obj\r\n[ 29%] Building C object CMakeFiles/openrct2.dir/src/windows/clear_scenery.c.obj\r\n[ 30%] Building C object CMakeFiles/openrct2.dir/src/windows/title_options.c.obj\r\n[ 30%] Building C object CMakeFiles/openrct2.dir/src/windows/editor_inventions_list.c.obj\r\n[ 31%] Building C object CMakeFiles/openrct2.dir/src/windows/title_exit.c.obj\r\n[ 32%] Building C object CMakeFiles/openrct2.dir/src/windows/title_menu.c.obj\r\n[ 33%] Building C object CMakeFiles/openrct2.dir/src/windows/publisher_credits.c.obj\r\n[ 33%] Building C object CMakeFiles/openrct2.dir/src/windows/track_list.c.obj\r\n[ 34%] Building C object CMakeFiles/openrct2.dir/src/windows/park.c.obj\r\n[ 35%] Building C object CMakeFiles/openrct2.dir/src/windows/news.c.obj\r\n[ 36%] Building C object CMakeFiles/openrct2.dir/src/windows/sign.c.obj\r\n[ 36%] Building C object CMakeFiles/openrct2.dir/src/windows/viewport.c.obj\r\n[ 37%] Building C object CMakeFiles/openrct2.dir/src/windows/finances.c.obj\r\n[ 38%] Building C object CMakeFiles/openrct2.dir/src/windows/game_bottom_toolbar.c.obj\r\n[ 39%] Building C object CMakeFiles/openrct2.dir/src/windows/music_credits.c.obj\r\n[ 40%] Building C object CMakeFiles/openrct2.dir/src/windows/cheats.c.obj\r\n[ 40%] Building C object CMakeFiles/openrct2.dir/src/windows/footpath.c.obj\r\n[ 41%] Building C object CMakeFiles/openrct2.dir/src/windows/staff_fire_prompt.c.obj\r\n[ 42%] Building C object CMakeFiles/openrct2.dir/src/windows/error.c.obj\r\n[ 43%] Building C object CMakeFiles/openrct2.dir/src/windows/ride_list.c.obj\r\n[ 43%] Building C object CMakeFiles/openrct2.dir/src/windows/editor_bottom_toolbar.c.obj\r\n[ 44%] Building C object CMakeFiles/openrct2.dir/src/windows/shortcut_key_change.c.obj\r\n[ 45%] Building C object CMakeFiles/openrct2.dir/src/windows/new_ride.c.obj\r\n[ 46%] Building C object CMakeFiles/openrct2.dir/src/windows/ride.c.obj\r\n[ 46%] Building C object CMakeFiles/openrct2.dir/src/windows/editor_main.c.obj\r\n[ 47%] Building C object CMakeFiles/openrct2.dir/src/windows/land.c.obj\r\n[ 48%] Building C object CMakeFiles/openrct2.dir/src/windows/install_track.c.obj\r\n[ 49%] Building C object CMakeFiles/openrct2.dir/src/windows/shortcut_keys.c.obj\r\n[ 50%] Building C object CMakeFiles/openrct2.dir/src/cmdline.c.obj\r\n[ 50%] Building C object CMakeFiles/openrct2.dir/src/localisation/date.c.obj\r\n[ 51%] Building C object CMakeFiles/openrct2.dir/src/localisation/real_names.c.obj\r\n[ 52%] Building C object CMakeFiles/openrct2.dir/src/localisation/localisation.c.obj\r\n[ 53%] Building C object CMakeFiles/openrct2.dir/src/localisation/currency.c.obj\r\n[ 53%] Building C object CMakeFiles/openrct2.dir/src/localisation/language.c.obj\r\n[ 54%] Building C object CMakeFiles/openrct2.dir/src/localisation/user.c.obj\r\n[ 55%] Building C object CMakeFiles/openrct2.dir/src/object.c.obj\r\n[ 56%] Building C object CMakeFiles/openrct2.dir/src/ride/track_data.c.obj\r\n[ 56%] Building C object CMakeFiles/openrct2.dir/src/ride/vehicle.c.obj\r\n[ 57%] Building C object CMakeFiles/openrct2.dir/src/ride/station.c.obj\r\n[ 58%] Building C object CMakeFiles/openrct2.dir/src/ride/track.c.obj\r\n[ 59%] Building C object CMakeFiles/openrct2.dir/src/ride/ride_ratings.c.obj\r\n[ 60%] Building C object CMakeFiles/openrct2.dir/src/ride/ride_data.c.obj\r\n[ 60%] Building C object CMakeFiles/openrct2.dir/src/ride/ride.c.obj\r\n[ 61%] Building C object CMakeFiles/openrct2.dir/src/platform/osx.c.obj\r\n[ 62%] Building C object CMakeFiles/openrct2.dir/src/platform/unix.c.obj\r\n[ 63%] Building C object CMakeFiles/openrct2.dir/src/platform/windows.c.obj\r\n/tmp/OpenRCT2/src/platform/windows.c: In function ‘StartOpenRCT’:\r\n/tmp/OpenRCT2/src/platform/windows.c:77:2: warning: passing argument 1 of ‘cmdline_run’ from incompatible pointer type [enabled by default]\r\n  runGame = cmdline_run(argv, argc);\r\n  ^\r\nIn file included from /tmp/OpenRCT2/src/platform/windows.c:27:0:\r\n/tmp/OpenRCT2/src/platform/../cmdline.h:29:5: note: expected ‘const char **’ but argument is of type ‘char **’\r\n int cmdline_run(const char **argv, int argc);\r\n     ^\r\n[ 63%] Building C object CMakeFiles/openrct2.dir/src/platform/shared.c.obj\r\n[ 64%] Building C object CMakeFiles/openrct2.dir/src/world/scenery.c.obj\r\n[ 65%] Building C object CMakeFiles/openrct2.dir/src/world/sprite.c.obj\r\n[ 66%] Building C object CMakeFiles/openrct2.dir/src/world/map_animation.c.obj\r\n[ 66%] Building C object CMakeFiles/openrct2.dir/src/world/banner.c.obj\r\n[ 67%] Building C object CMakeFiles/openrct2.dir/src/world/map.c.obj\r\n[ 68%] Building C object CMakeFiles/openrct2.dir/src/world/mapgen.c.obj\r\n[ 69%] Building C object CMakeFiles/openrct2.dir/src/world/map_helpers.c.obj\r\n[ 70%] Building C object CMakeFiles/openrct2.dir/src/world/climate.c.obj\r\n[ 70%] Building C object CMakeFiles/openrct2.dir/src/world/fountain.c.obj\r\n[ 71%] Building C object CMakeFiles/openrct2.dir/src/world/park.c.obj\r\n[ 72%] Building C object CMakeFiles/openrct2.dir/src/world/footpath.c.obj\r\n[ 73%] Building C object CMakeFiles/openrct2.dir/src/rct2.c.obj\r\n[ 73%] Building C object CMakeFiles/openrct2.dir/src/util/sawyercoding.c.obj\r\n[ 74%] Building C object CMakeFiles/openrct2.dir/src/util/util.c.obj\r\n[ 75%] Building C object CMakeFiles/openrct2.dir/src/tutorial.c.obj\r\n[ 76%] Building C object CMakeFiles/openrct2.dir/src/hook.c.obj\r\n[ 76%] Building C object CMakeFiles/openrct2.dir/src/title.c.obj\r\n[ 77%] Building C object CMakeFiles/openrct2.dir/src/object_list.c.obj\r\n[ 78%] Building C object CMakeFiles/openrct2.dir/src/scenario.c.obj\r\n[ 79%] Building C object CMakeFiles/openrct2.dir/src/diagnostic.c.obj\r\n[ 80%] Building C object CMakeFiles/openrct2.dir/src/editor.c.obj\r\n[ 80%] Building C object CMakeFiles/openrct2.dir/src/config.c.obj\r\n[ 81%] Building C object CMakeFiles/openrct2.dir/src/openrct2.c.obj\r\n[ 82%] Building C object CMakeFiles/openrct2.dir/src/peep/staff.c.obj\r\n[ 83%] Building C object CMakeFiles/openrct2.dir/src/peep/peep.c.obj\r\n[ 83%] Building C object CMakeFiles/openrct2.dir/src/audio/audio.c.obj\r\n/tmp/OpenRCT2/src/audio/audio.c: In function ‘mmio_open’:\r\n/tmp/OpenRCT2/src/audio/audio.c:1118:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]\r\n     *((uint16*)*hmemold + 8) = (uint16)hmem;\r\n                                ^\r\n[ 84%] Building C object CMakeFiles/openrct2.dir/src/rct1.c.obj\r\n[ 85%] Building C object CMakeFiles/openrct2.dir/src/intro.c.obj\r\n[ 86%] Building C object CMakeFiles/openrct2.dir/src/management/research.c.obj\r\n[ 86%] Building C object CMakeFiles/openrct2.dir/src/management/finance.c.obj\r\n[ 87%] Building C object CMakeFiles/openrct2.dir/src/management/award.c.obj\r\n[ 88%] Building C object CMakeFiles/openrct2.dir/src/management/news_item.c.obj\r\n[ 89%] Building C object CMakeFiles/openrct2.dir/src/management/marketing.c.obj\r\n[ 90%] Building C object CMakeFiles/openrct2.dir/src/interface/keyboard_shortcut.c.obj\r\n[ 90%] Building C object CMakeFiles/openrct2.dir/src/interface/window.c.obj\r\n[ 91%] Building C object CMakeFiles/openrct2.dir/src/interface/graph.c.obj\r\n[ 92%] Building C object CMakeFiles/openrct2.dir/src/interface/widget.c.obj\r\n[ 93%] Building C object CMakeFiles/openrct2.dir/src/interface/viewport.c.obj\r\n[ 93%] Building C object CMakeFiles/openrct2.dir/src/interface/viewport_interaction.c.obj\r\n[ 94%] Building C object CMakeFiles/openrct2.dir/src/interface/screenshot.c.obj\r\n[ 95%] Building C object CMakeFiles/openrct2.dir/src/input.c.obj\r\n[ 96%] Building C object CMakeFiles/openrct2.dir/src/cursors.c.obj\r\n[ 96%] Building C object CMakeFiles/openrct2.dir/src/scenario_list.c.obj\r\n[ 97%] Building CXX object CMakeFiles/openrct2.dir/src/audio/mixer.cpp.obj\r\n[ 98%] Building C object CMakeFiles/openrct2.dir/lib/argparse/argparse.c.obj\r\n[ 99%] Building C object CMakeFiles/openrct2.dir/lib/libspeex/resample.c.obj\r\n[100%] Building C object CMakeFiles/openrct2.dir/lib/lodepng/lodepng.c.obj\r\nLinking CXX shared library openrct2.dll\r\n[100%] Built target openrct2\r\n```"}}