{"action":"created","comment":{"url":"https://api.github.com/repos/tumblr/collins/pulls/comments/23907373","id":23907373,"diff_hunk":"@@ -3,19 +3,17 @@ package actions\n package resources\n \n import forms._\n-\n import models.Truthy\n import util.IpmiCommand\n import util.concurrent.BackgroundProcessor\n import util.plugins.{IpmiPowerCommand, PowerManagement}\n import util.security.SecuritySpecification\n-\n import collins.power.Identify\n import collins.power.management.{PowerManagement, PowerManagementConfig}\n-\n import play.api.data.Form\n import play.api.data.Forms._\n import play.api.mvc.AsyncResult\n+import com.twitter.util.Await","path":"app/controllers/actions/resources/IntakeStage1Action.scala","position":17,"original_position":17,"commit_id":"a743b1ae64347717347d0f6aacdef438920d3afb","original_commit_id":"95c290192544a716e2a300fbece5717134e2806e","user":{"login":"maddalab","id":110992,"avatar_url":"https://avatars.githubusercontent.com/u/110992?v=3","gravatar_id":"","url":"https://api.github.com/users/maddalab","html_url":"https://github.com/maddalab","followers_url":"https://api.github.com/users/maddalab/followers","following_url":"https://api.github.com/users/maddalab/following{/other_user}","gists_url":"https://api.github.com/users/maddalab/gists{/gist_id}","starred_url":"https://api.github.com/users/maddalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maddalab/subscriptions","organizations_url":"https://api.github.com/users/maddalab/orgs","repos_url":"https://api.github.com/users/maddalab/repos","events_url":"https://api.github.com/users/maddalab/events{/privacy}","received_events_url":"https://api.github.com/users/maddalab/received_events","type":"User","site_admin":false},"body":"Twitter. Collins has used twitter finagle internally, we should probably remove it and just use akka but that is out of scope for this particular PR","created_at":"2015-02-02T05:21:54Z","updated_at":"2015-02-02T05:21:54Z","html_url":"https://github.com/tumblr/collins/pull/262#discussion_r23907373","pull_request_url":"https://api.github.com/repos/tumblr/collins/pulls/262","_links":{"self":{"href":"https://api.github.com/repos/tumblr/collins/pulls/comments/23907373"},"html":{"href":"https://github.com/tumblr/collins/pull/262#discussion_r23907373"},"pull_request":{"href":"https://api.github.com/repos/tumblr/collins/pulls/262"}}},"pull_request":{"url":"https://api.github.com/repos/tumblr/collins/pulls/262","id":28397613,"html_url":"https://github.com/tumblr/collins/pull/262","diff_url":"https://github.com/tumblr/collins/pull/262.diff","patch_url":"https://github.com/tumblr/collins/pull/262.patch","issue_url":"https://api.github.com/repos/tumblr/collins/issues/262","number":262,"state":"open","locked":false,"title":"Upgrade play to 2.1.5","user":{"login":"maddalab","id":110992,"avatar_url":"https://avatars.githubusercontent.com/u/110992?v=3","gravatar_id":"","url":"https://api.github.com/users/maddalab","html_url":"https://github.com/maddalab","followers_url":"https://api.github.com/users/maddalab/followers","following_url":"https://api.github.com/users/maddalab/following{/other_user}","gists_url":"https://api.github.com/users/maddalab/gists{/gist_id}","starred_url":"https://api.github.com/users/maddalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maddalab/subscriptions","organizations_url":"https://api.github.com/users/maddalab/orgs","repos_url":"https://api.github.com/users/maddalab/repos","events_url":"https://api.github.com/users/maddalab/events{/privacy}","received_events_url":"https://api.github.com/users/maddalab/received_events","type":"User","site_admin":false},"body":"This is a fairly long PR. It makes more sense to review the comments on each step. Unfortunately it is a all or nothing scenario. Each intermediate step will result in compilation failures.\r\n\r\nI have completed basic testing, creation of assets, setting attributes, search for attributes etc. The dockerfile has been updated to do the same.\r\n\r\nCurrently we get a large number of compiler warnings. Primarily around catching throwable exceptions. However included amongst these are instances of Future.get() which are important.\r\n\r\nThis PR does make the situation around running all unit tests at once worse and requires the use of test-only to run individual tests. I will follow up with updates to that.\r\n\r\nThis is now done. Upgraded solr, which also requires JDK 7 , 6 isn't supported. Updated other libraries and fixed all the test (bar one).\r\n\r\n```\r\n[info] Passed: : Total 153, Failed 0, Errors 0, Passed 153, Skipped 0\r\n[success] Total time: 24 s, completed Jan 31, 2015 9:54:38 PM\r\n```\r\n\r\nPlease take a look do your testing and lets commit this.\r\n\r\n@byxorna @Primer42 @DanSimon ","created_at":"2015-01-30T22:11:58Z","updated_at":"2015-02-02T05:21:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f980257f1fa45792ffcbb25b32ca289a663933dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tumblr/collins/pulls/262/commits","review_comments_url":"https://api.github.com/repos/tumblr/collins/pulls/262/comments","review_comment_url":"https://api.github.com/repos/tumblr/collins/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tumblr/collins/issues/262/comments","statuses_url":"https://api.github.com/repos/tumblr/collins/statuses/a743b1ae64347717347d0f6aacdef438920d3afb","head":{"label":"tumblr:bhaskar-upgrade-play-stepwise","ref":"bhaskar-upgrade-play-stepwise","sha":"a743b1ae64347717347d0f6aacdef438920d3afb","user":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"repo":{"id":5252760,"name":"collins","full_name":"tumblr/collins","owner":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tumblr/collins","description":"groovy kind of love","fork":false,"url":"https://api.github.com/repos/tumblr/collins","forks_url":"https://api.github.com/repos/tumblr/collins/forks","keys_url":"https://api.github.com/repos/tumblr/collins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tumblr/collins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tumblr/collins/teams","hooks_url":"https://api.github.com/repos/tumblr/collins/hooks","issue_events_url":"https://api.github.com/repos/tumblr/collins/issues/events{/number}","events_url":"https://api.github.com/repos/tumblr/collins/events","assignees_url":"https://api.github.com/repos/tumblr/collins/assignees{/user}","branches_url":"https://api.github.com/repos/tumblr/collins/branches{/branch}","tags_url":"https://api.github.com/repos/tumblr/collins/tags","blobs_url":"https://api.github.com/repos/tumblr/collins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tumblr/collins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tumblr/collins/git/refs{/sha}","trees_url":"https://api.github.com/repos/tumblr/collins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tumblr/collins/statuses/{sha}","languages_url":"https://api.github.com/repos/tumblr/collins/languages","stargazers_url":"https://api.github.com/repos/tumblr/collins/stargazers","contributors_url":"https://api.github.com/repos/tumblr/collins/contributors","subscribers_url":"https://api.github.com/repos/tumblr/collins/subscribers","subscription_url":"https://api.github.com/repos/tumblr/collins/subscription","commits_url":"https://api.github.com/repos/tumblr/collins/commits{/sha}","git_commits_url":"https://api.github.com/repos/tumblr/collins/git/commits{/sha}","comments_url":"https://api.github.com/repos/tumblr/collins/comments{/number}","issue_comment_url":"https://api.github.com/repos/tumblr/collins/issues/comments/{number}","contents_url":"https://api.github.com/repos/tumblr/collins/contents/{+path}","compare_url":"https://api.github.com/repos/tumblr/collins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tumblr/collins/merges","archive_url":"https://api.github.com/repos/tumblr/collins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tumblr/collins/downloads","issues_url":"https://api.github.com/repos/tumblr/collins/issues{/number}","pulls_url":"https://api.github.com/repos/tumblr/collins/pulls{/number}","milestones_url":"https://api.github.com/repos/tumblr/collins/milestones{/number}","notifications_url":"https://api.github.com/repos/tumblr/collins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tumblr/collins/labels{/name}","releases_url":"https://api.github.com/repos/tumblr/collins/releases{/id}","created_at":"2012-07-31T23:18:59Z","updated_at":"2015-02-01T17:13:52Z","pushed_at":"2015-02-02T05:20:15Z","git_url":"git://github.com/tumblr/collins.git","ssh_url":"git@github.com:tumblr/collins.git","clone_url":"https://github.com/tumblr/collins.git","svn_url":"https://github.com/tumblr/collins","homepage":"tumblr.github.com/collins","size":224292,"stargazers_count":268,"watchers_count":268,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":42,"forks":48,"open_issues":42,"watchers":268,"default_branch":"master"}},"base":{"label":"tumblr:master","ref":"master","sha":"e1fae35197592385836da4cc92549b5064f0a434","user":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"repo":{"id":5252760,"name":"collins","full_name":"tumblr/collins","owner":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tumblr/collins","description":"groovy kind of love","fork":false,"url":"https://api.github.com/repos/tumblr/collins","forks_url":"https://api.github.com/repos/tumblr/collins/forks","keys_url":"https://api.github.com/repos/tumblr/collins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tumblr/collins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tumblr/collins/teams","hooks_url":"https://api.github.com/repos/tumblr/collins/hooks","issue_events_url":"https://api.github.com/repos/tumblr/collins/issues/events{/number}","events_url":"https://api.github.com/repos/tumblr/collins/events","assignees_url":"https://api.github.com/repos/tumblr/collins/assignees{/user}","branches_url":"https://api.github.com/repos/tumblr/collins/branches{/branch}","tags_url":"https://api.github.com/repos/tumblr/collins/tags","blobs_url":"https://api.github.com/repos/tumblr/collins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tumblr/collins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tumblr/collins/git/refs{/sha}","trees_url":"https://api.github.com/repos/tumblr/collins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tumblr/collins/statuses/{sha}","languages_url":"https://api.github.com/repos/tumblr/collins/languages","stargazers_url":"https://api.github.com/repos/tumblr/collins/stargazers","contributors_url":"https://api.github.com/repos/tumblr/collins/contributors","subscribers_url":"https://api.github.com/repos/tumblr/collins/subscribers","subscription_url":"https://api.github.com/repos/tumblr/collins/subscription","commits_url":"https://api.github.com/repos/tumblr/collins/commits{/sha}","git_commits_url":"https://api.github.com/repos/tumblr/collins/git/commits{/sha}","comments_url":"https://api.github.com/repos/tumblr/collins/comments{/number}","issue_comment_url":"https://api.github.com/repos/tumblr/collins/issues/comments/{number}","contents_url":"https://api.github.com/repos/tumblr/collins/contents/{+path}","compare_url":"https://api.github.com/repos/tumblr/collins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tumblr/collins/merges","archive_url":"https://api.github.com/repos/tumblr/collins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tumblr/collins/downloads","issues_url":"https://api.github.com/repos/tumblr/collins/issues{/number}","pulls_url":"https://api.github.com/repos/tumblr/collins/pulls{/number}","milestones_url":"https://api.github.com/repos/tumblr/collins/milestones{/number}","notifications_url":"https://api.github.com/repos/tumblr/collins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tumblr/collins/labels{/name}","releases_url":"https://api.github.com/repos/tumblr/collins/releases{/id}","created_at":"2012-07-31T23:18:59Z","updated_at":"2015-02-01T17:13:52Z","pushed_at":"2015-02-02T05:20:15Z","git_url":"git://github.com/tumblr/collins.git","ssh_url":"git@github.com:tumblr/collins.git","clone_url":"https://github.com/tumblr/collins.git","svn_url":"https://github.com/tumblr/collins","homepage":"tumblr.github.com/collins","size":224292,"stargazers_count":268,"watchers_count":268,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":42,"forks":48,"open_issues":42,"watchers":268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tumblr/collins/pulls/262"},"html":{"href":"https://github.com/tumblr/collins/pull/262"},"issue":{"href":"https://api.github.com/repos/tumblr/collins/issues/262"},"comments":{"href":"https://api.github.com/repos/tumblr/collins/issues/262/comments"},"review_comments":{"href":"https://api.github.com/repos/tumblr/collins/pulls/262/comments"},"review_comment":{"href":"https://api.github.com/repos/tumblr/collins/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tumblr/collins/pulls/262/commits"},"statuses":{"href":"https://api.github.com/repos/tumblr/collins/statuses/a743b1ae64347717347d0f6aacdef438920d3afb"}}}}