{"action":"created","comment":{"url":"https://api.github.com/repos/divio/django-cms/pulls/comments/35236638","id":35236638,"diff_hunk":"@@ -1,7 +1,7 @@\n {% load i18n l10n %}\n \n {% language request.toolbar.toolbar_language %}\n-<div id=\"cms-toolbar\" class=\"cms-reset{% if not user.is_authenticated %} cms-toolbar-auth{% endif %}{% if debug %} cms-toolbar-debug{% endif %}\" dir=\"ltr\">\n+<div touch-action=\"none\" id=\"cms-toolbar\" class=\"cms-reset{% if not user.is_authenticated %} cms-toolbar-auth{% endif %}{% if debug %} cms-toolbar-debug{% endif %}\" dir=\"ltr\">","path":"cms/templates/cms/toolbar/toolbar.html","position":5,"original_position":5,"commit_id":"6e1f6d638b8bf9e77e8b5223a09ef7fc4cf22861","original_commit_id":"6e1f6d638b8bf9e77e8b5223a09ef7fc4cf22861","user":{"login":"FinalAngel","id":270307,"avatar_url":"https://avatars.githubusercontent.com/u/270307?v=3","gravatar_id":"","url":"https://api.github.com/users/FinalAngel","html_url":"https://github.com/FinalAngel","followers_url":"https://api.github.com/users/FinalAngel/followers","following_url":"https://api.github.com/users/FinalAngel/following{/other_user}","gists_url":"https://api.github.com/users/FinalAngel/gists{/gist_id}","starred_url":"https://api.github.com/users/FinalAngel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinalAngel/subscriptions","organizations_url":"https://api.github.com/users/FinalAngel/orgs","repos_url":"https://api.github.com/users/FinalAngel/repos","events_url":"https://api.github.com/users/FinalAngel/events{/privacy}","received_events_url":"https://api.github.com/users/FinalAngel/received_events","type":"User","site_admin":false},"body":"same on touch action notes","created_at":"2015-07-22T17:02:40Z","updated_at":"2015-07-22T17:02:40Z","html_url":"https://github.com/divio/django-cms/pull/4302#discussion_r35236638","pull_request_url":"https://api.github.com/repos/divio/django-cms/pulls/4302","_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments/35236638"},"html":{"href":"https://github.com/divio/django-cms/pull/4302#discussion_r35236638"},"pull_request":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4302"}}},"pull_request":{"url":"https://api.github.com/repos/divio/django-cms/pulls/4302","id":40578458,"html_url":"https://github.com/divio/django-cms/pull/4302","diff_url":"https://github.com/divio/django-cms/pull/4302.diff","patch_url":"https://github.com/divio/django-cms/pull/4302.patch","issue_url":"https://api.github.com/repos/divio/django-cms/issues/4302","number":4302,"state":"open","locked":false,"title":"Touch support","user":{"login":"vxsx","id":366813,"avatar_url":"https://avatars.githubusercontent.com/u/366813?v=3","gravatar_id":"","url":"https://api.github.com/users/vxsx","html_url":"https://github.com/vxsx","followers_url":"https://api.github.com/users/vxsx/followers","following_url":"https://api.github.com/users/vxsx/following{/other_user}","gists_url":"https://api.github.com/users/vxsx/gists{/gist_id}","starred_url":"https://api.github.com/users/vxsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vxsx/subscriptions","organizations_url":"https://api.github.com/users/vxsx/orgs","repos_url":"https://api.github.com/users/vxsx/repos","events_url":"https://api.github.com/users/vxsx/events{/privacy}","received_events_url":"https://api.github.com/users/vxsx/received_events","type":"User","site_admin":false},"body":"This PR adds generic touch support for modal, toolbar and structureboard drag and drop\r\ntouch support is not good enough everywhere yet, mostly because some things are very heavily hover based, but that will change soon.\r\n\r\nAlso fixes few bugs with drag n drop to empty placeholder and general jumping of the structureboard.\r\nAlso fixes annoying scrolling bug when you start dragging a plugin on a long page and it immediately scrolls all the way to the bottom\r\n\r\nPR also contains style changes, at the moment it looks like this\r\n\r\n![screen shot 2015-07-22 at 17 22 09](https://cloud.githubusercontent.com/assets/366813/8829582/b0ebf0be-3097-11e5-827e-37f908959cec.png)\r\n\r\nKeep in mind that this PR is pointing to `preview` branch and not components are completely ready yet.","created_at":"2015-07-22T15:35:10Z","updated_at":"2015-07-22T17:02:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1236819cad0015a9b98bdbc370fa47533be0b6f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/divio/django-cms/pulls/4302/commits","review_comments_url":"https://api.github.com/repos/divio/django-cms/pulls/4302/comments","review_comment_url":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divio/django-cms/issues/4302/comments","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/6e1f6d638b8bf9e77e8b5223a09ef7fc4cf22861","head":{"label":"FinalAngel:feature/touch-support-js","ref":"feature/touch-support-js","sha":"6e1f6d638b8bf9e77e8b5223a09ef7fc4cf22861","user":{"login":"FinalAngel","id":270307,"avatar_url":"https://avatars.githubusercontent.com/u/270307?v=3","gravatar_id":"","url":"https://api.github.com/users/FinalAngel","html_url":"https://github.com/FinalAngel","followers_url":"https://api.github.com/users/FinalAngel/followers","following_url":"https://api.github.com/users/FinalAngel/following{/other_user}","gists_url":"https://api.github.com/users/FinalAngel/gists{/gist_id}","starred_url":"https://api.github.com/users/FinalAngel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinalAngel/subscriptions","organizations_url":"https://api.github.com/users/FinalAngel/orgs","repos_url":"https://api.github.com/users/FinalAngel/repos","events_url":"https://api.github.com/users/FinalAngel/events{/privacy}","received_events_url":"https://api.github.com/users/FinalAngel/received_events","type":"User","site_admin":false},"repo":{"id":748738,"name":"django-cms","full_name":"FinalAngel/django-cms","owner":{"login":"FinalAngel","id":270307,"avatar_url":"https://avatars.githubusercontent.com/u/270307?v=3","gravatar_id":"","url":"https://api.github.com/users/FinalAngel","html_url":"https://github.com/FinalAngel","followers_url":"https://api.github.com/users/FinalAngel/followers","following_url":"https://api.github.com/users/FinalAngel/following{/other_user}","gists_url":"https://api.github.com/users/FinalAngel/gists{/gist_id}","starred_url":"https://api.github.com/users/FinalAngel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinalAngel/subscriptions","organizations_url":"https://api.github.com/users/FinalAngel/orgs","repos_url":"https://api.github.com/users/FinalAngel/repos","events_url":"https://api.github.com/users/FinalAngel/events{/privacy}","received_events_url":"https://api.github.com/users/FinalAngel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FinalAngel/django-cms","description":"An Advanced Django Cms","fork":true,"url":"https://api.github.com/repos/FinalAngel/django-cms","forks_url":"https://api.github.com/repos/FinalAngel/django-cms/forks","keys_url":"https://api.github.com/repos/FinalAngel/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FinalAngel/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FinalAngel/django-cms/teams","hooks_url":"https://api.github.com/repos/FinalAngel/django-cms/hooks","issue_events_url":"https://api.github.com/repos/FinalAngel/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/FinalAngel/django-cms/events","assignees_url":"https://api.github.com/repos/FinalAngel/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/FinalAngel/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/FinalAngel/django-cms/tags","blobs_url":"https://api.github.com/repos/FinalAngel/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FinalAngel/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FinalAngel/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/FinalAngel/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FinalAngel/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/FinalAngel/django-cms/languages","stargazers_url":"https://api.github.com/repos/FinalAngel/django-cms/stargazers","contributors_url":"https://api.github.com/repos/FinalAngel/django-cms/contributors","subscribers_url":"https://api.github.com/repos/FinalAngel/django-cms/subscribers","subscription_url":"https://api.github.com/repos/FinalAngel/django-cms/subscription","commits_url":"https://api.github.com/repos/FinalAngel/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/FinalAngel/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/FinalAngel/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/FinalAngel/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/FinalAngel/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/FinalAngel/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FinalAngel/django-cms/merges","archive_url":"https://api.github.com/repos/FinalAngel/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FinalAngel/django-cms/downloads","issues_url":"https://api.github.com/repos/FinalAngel/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/FinalAngel/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/FinalAngel/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/FinalAngel/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FinalAngel/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/FinalAngel/django-cms/releases{/id}","created_at":"2010-06-30T09:37:05Z","updated_at":"2014-08-06T23:53:12Z","pushed_at":"2015-07-22T15:55:54Z","git_url":"git://github.com/FinalAngel/django-cms.git","ssh_url":"git@github.com:FinalAngel/django-cms.git","clone_url":"https://github.com/FinalAngel/django-cms.git","svn_url":"https://github.com/FinalAngel/django-cms","homepage":"http://www.django-cms.org","size":49109,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"divio:preview","ref":"preview","sha":"ddd6c136ddd3b6a6c2984c87f9f0fafaa3d93626","user":{"login":"divio","id":117904,"avatar_url":"https://avatars.githubusercontent.com/u/117904?v=3","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"repo":{"id":143580,"name":"django-cms","full_name":"divio/django-cms","owner":{"login":"divio","id":117904,"avatar_url":"https://avatars.githubusercontent.com/u/117904?v=3","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/divio/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":false,"url":"https://api.github.com/repos/divio/django-cms","forks_url":"https://api.github.com/repos/divio/django-cms/forks","keys_url":"https://api.github.com/repos/divio/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divio/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divio/django-cms/teams","hooks_url":"https://api.github.com/repos/divio/django-cms/hooks","issue_events_url":"https://api.github.com/repos/divio/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/divio/django-cms/events","assignees_url":"https://api.github.com/repos/divio/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/divio/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/divio/django-cms/tags","blobs_url":"https://api.github.com/repos/divio/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divio/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divio/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/divio/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/divio/django-cms/languages","stargazers_url":"https://api.github.com/repos/divio/django-cms/stargazers","contributors_url":"https://api.github.com/repos/divio/django-cms/contributors","subscribers_url":"https://api.github.com/repos/divio/django-cms/subscribers","subscription_url":"https://api.github.com/repos/divio/django-cms/subscription","commits_url":"https://api.github.com/repos/divio/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/divio/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/divio/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/divio/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/divio/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/divio/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divio/django-cms/merges","archive_url":"https://api.github.com/repos/divio/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divio/django-cms/downloads","issues_url":"https://api.github.com/repos/divio/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/divio/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/divio/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/divio/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divio/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/divio/django-cms/releases{/id}","created_at":"2009-03-05T10:14:18Z","updated_at":"2015-07-22T13:12:47Z","pushed_at":"2015-07-22T15:55:57Z","git_url":"git://github.com/divio/django-cms.git","ssh_url":"git@github.com:divio/django-cms.git","clone_url":"https://github.com/divio/django-cms.git","svn_url":"https://github.com/divio/django-cms","homepage":"http://www.django-cms.org","size":63659,"stargazers_count":3557,"watchers_count":3557,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1367,"mirror_url":null,"open_issues_count":253,"forks":1367,"open_issues":253,"watchers":3557,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4302"},"html":{"href":"https://github.com/divio/django-cms/pull/4302"},"issue":{"href":"https://api.github.com/repos/divio/django-cms/issues/4302"},"comments":{"href":"https://api.github.com/repos/divio/django-cms/issues/4302/comments"},"review_comments":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4302/comments"},"review_comment":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4302/commits"},"statuses":{"href":"https://api.github.com/repos/divio/django-cms/statuses/6e1f6d638b8bf9e77e8b5223a09ef7fc4cf22861"}}}}