{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/39650510","id":39650510,"diff_hunk":"@@ -184,47 +274,45 @@ function convertRange(value, r1, r2) {\n \n             //actually grow the bubble\n             var dimensions = Entities.getEntityProperties(_t.currentBubble).dimensions;\n+            var avatarFront = Quat.getFront(MyAvatar.orientation);\n+            var forwardOffset = Vec3.multiply(avatarFront, 0.1);\n \n             if (velocityStrength > 1 || convertedVolume > 1) {\n \n                 //add some variation in bubble sizes\n                 var bubbleSize = randInt(1, 5);\n-                bubbleSize = bubbleSize / 10;\n+                bubbleSize = bubbleSize / 50;\n \n                 //release the bubble if its dimensions are bigger than the bubble size\n                 if (dimensions.x > bubbleSize) {\n                     //bubbles pop after existing for a bit -- so set a random lifetime\n                     var lifetime = randInt(3, 8);","path":"examples/toys/bubblewand/wand.js","position":313,"original_position":313,"commit_id":"37f45b57ff19acd8ddfde71498b411c3c373d041","original_commit_id":"37f45b57ff19acd8ddfde71498b411c3c373d041","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"coding standard: no magic numbers. use a named constant (can be locally defined)","created_at":"2015-09-16T16:14:44Z","updated_at":"2015-09-16T16:14:44Z","html_url":"https://github.com/highfidelity/hifi/pull/5751#discussion_r39650510","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5751","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/39650510"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5751#discussion_r39650510"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5751"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/5751","id":44574251,"html_url":"https://github.com/highfidelity/hifi/pull/5751","diff_url":"https://github.com/highfidelity/hifi/pull/5751.diff","patch_url":"https://github.com/highfidelity/hifi/pull/5751.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/5751","number":5751,"state":"open","locked":false,"title":"DO NOT MERGE - Update bubblewand","user":{"login":"imgntn","id":843228,"avatar_url":"https://avatars.githubusercontent.com/u/843228?v=3","gravatar_id":"","url":"https://api.github.com/users/imgntn","html_url":"https://github.com/imgntn","followers_url":"https://api.github.com/users/imgntn/followers","following_url":"https://api.github.com/users/imgntn/following{/other_user}","gists_url":"https://api.github.com/users/imgntn/gists{/gist_id}","starred_url":"https://api.github.com/users/imgntn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imgntn/subscriptions","organizations_url":"https://api.github.com/users/imgntn/orgs","repos_url":"https://api.github.com/users/imgntn/repos","events_url":"https://api.github.com/users/imgntn/events{/privacy}","received_events_url":"https://api.github.com/users/imgntn/received_events","type":"User","site_admin":false},"body":"Updates: \r\n- Fixes an issue where overlays were on & conflicting with other toys with overlays.  This one doesn't really need the overlays -- when it's near your avatar's head, you can make bubbles by blowing into the microphone. \r\n- Custom collision hull for wand, so that the tip doesn't impact bubbles.\r\n- Moves particles, sound into bubble.js\r\n- Still needs physics, sound, particles to work.","created_at":"2015-09-09T16:52:19Z","updated_at":"2015-09-16T16:14:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e74580bf7c0f79aebc5156ef014b20ff9e93c354","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5751/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5751/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/5751/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/37f45b57ff19acd8ddfde71498b411c3c373d041","head":{"label":"imgntn:bubblewand_hotfix_2","ref":"bubblewand_hotfix_2","sha":"37f45b57ff19acd8ddfde71498b411c3c373d041","user":{"login":"imgntn","id":843228,"avatar_url":"https://avatars.githubusercontent.com/u/843228?v=3","gravatar_id":"","url":"https://api.github.com/users/imgntn","html_url":"https://github.com/imgntn","followers_url":"https://api.github.com/users/imgntn/followers","following_url":"https://api.github.com/users/imgntn/following{/other_user}","gists_url":"https://api.github.com/users/imgntn/gists{/gist_id}","starred_url":"https://api.github.com/users/imgntn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imgntn/subscriptions","organizations_url":"https://api.github.com/users/imgntn/orgs","repos_url":"https://api.github.com/users/imgntn/repos","events_url":"https://api.github.com/users/imgntn/events{/privacy}","received_events_url":"https://api.github.com/users/imgntn/received_events","type":"User","site_admin":false},"repo":{"id":41923670,"name":"hifi","full_name":"imgntn/hifi","owner":{"login":"imgntn","id":843228,"avatar_url":"https://avatars.githubusercontent.com/u/843228?v=3","gravatar_id":"","url":"https://api.github.com/users/imgntn","html_url":"https://github.com/imgntn","followers_url":"https://api.github.com/users/imgntn/followers","following_url":"https://api.github.com/users/imgntn/following{/other_user}","gists_url":"https://api.github.com/users/imgntn/gists{/gist_id}","starred_url":"https://api.github.com/users/imgntn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imgntn/subscriptions","organizations_url":"https://api.github.com/users/imgntn/orgs","repos_url":"https://api.github.com/users/imgntn/repos","events_url":"https://api.github.com/users/imgntn/events{/privacy}","received_events_url":"https://api.github.com/users/imgntn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imgntn/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/imgntn/hifi","forks_url":"https://api.github.com/repos/imgntn/hifi/forks","keys_url":"https://api.github.com/repos/imgntn/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imgntn/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imgntn/hifi/teams","hooks_url":"https://api.github.com/repos/imgntn/hifi/hooks","issue_events_url":"https://api.github.com/repos/imgntn/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/imgntn/hifi/events","assignees_url":"https://api.github.com/repos/imgntn/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/imgntn/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/imgntn/hifi/tags","blobs_url":"https://api.github.com/repos/imgntn/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imgntn/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imgntn/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/imgntn/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imgntn/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/imgntn/hifi/languages","stargazers_url":"https://api.github.com/repos/imgntn/hifi/stargazers","contributors_url":"https://api.github.com/repos/imgntn/hifi/contributors","subscribers_url":"https://api.github.com/repos/imgntn/hifi/subscribers","subscription_url":"https://api.github.com/repos/imgntn/hifi/subscription","commits_url":"https://api.github.com/repos/imgntn/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/imgntn/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/imgntn/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/imgntn/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/imgntn/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/imgntn/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imgntn/hifi/merges","archive_url":"https://api.github.com/repos/imgntn/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imgntn/hifi/downloads","issues_url":"https://api.github.com/repos/imgntn/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/imgntn/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/imgntn/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/imgntn/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imgntn/hifi/labels{/name}","releases_url":"https://api.github.com/repos/imgntn/hifi/releases{/id}","created_at":"2015-09-04T15:35:51Z","updated_at":"2015-09-04T15:35:56Z","pushed_at":"2015-09-16T01:40:57Z","git_url":"git://github.com/imgntn/hifi.git","ssh_url":"git@github.com:imgntn/hifi.git","clone_url":"https://github.com/imgntn/hifi.git","svn_url":"https://github.com/imgntn/hifi","homepage":"","size":175601,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"74c92af8e00fe93dd9c66f3610d7b164010f0092","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-09-14T04:07:15Z","pushed_at":"2015-09-16T16:06:00Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":236420,"stargazers_count":305,"watchers_count":305,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":178,"mirror_url":null,"open_issues_count":54,"forks":178,"open_issues":54,"watchers":305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5751"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5751"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5751"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5751/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5751/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5751/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/37f45b57ff19acd8ddfde71498b411c3c373d041"}}}}