{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/35548345","id":35548345,"diff_hunk":"@@ -101,66 +101,77 @@ <h1 class=\"large\">{{_('Check Your Plugins')}}</h1>\n       <p class=\"enable-js warning\">{{_('Please turn on JavaScript to display this page correctly.')}}</p>\n \n       <h2>{{_('Plugin Status')}}</h2>\n-      <ul>\n-        <li>{{_('Step 1: Click Update to update a plugin.')}}</li>\n-        <li>{{_('Step 2: Complete all recommended updates before restarting your browser.')}}</li>\n-      </ul>\n \n-      <div class=\"plugincheck-loader\"></div>\n-\n-      <div id=\"sec-plugin-vulnerable\">\n-        <table class=\"table status\">\n-          <caption>{{_('Potentially vulnerable plugins')}}</caption>\n-          <thead>\n-            <tr>\n-              <th class=\"plugin-status-detail\" scope=\"col\">{{_('Plugin')}}</th>\n-              <th class=\"plugin-status-status\" scope=\"col\">{{_('Status')}}</th>\n-              <th class=\"plugin-status-action action\" scope=\"col\">{{_('Action')}}</th>\n-            </tr>\n-          </thead>\n-          <tbody id=\"plugin-vulnerable\"></tbody>\n-        </table>\n-      </div>\n+      <div class=\"plugincheck-loader hidden\"></div>\n \n-      <div id=\"sec-plugin-outdated\" class=\"shadow-separator\">\n-        <table class=\"table status\">\n-          <caption>{{_('Outdated Plugins')}}</caption>\n-          <thead>\n-            <tr>\n-              <th class=\"plugin-status-detail\" scope=\"col\">{{_('Plugin')}}</th>\n-              <th class=\"plugin-status-status\" scope=\"col\">{{_('Status')}}</th>\n-              <th class=\"plugin-status-action action\" scope=\"col\">{{_('Action')}}</th>\n-            </tr>\n-          </thead>\n-          <tbody id=\"plugin-outdated\"></tbody>\n-        </table>\n+      {% if l10n_has_tag('no_plugins') %}","path":"bedrock/mozorg/templates/mozorg/plugincheck.html","position":38,"original_position":38,"commit_id":"39c27975b3c10a3478c57b12d540c4e2481c6557","original_commit_id":"39c27975b3c10a3478c57b12d540c4e2481c6557","user":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars.githubusercontent.com/u/400117?v=3","gravatar_id":"","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"body":"Yeah. We do have to be a little careful conditionally including html like this, for example when using `$('#no-plugins')` on a non-localized page. Here we're ok and no JS will break, but it does increase scope for error. If we don't remove the l10n tag, perhaps we should put the tag inside the element as an additional measure.","created_at":"2015-07-27T15:23:51Z","updated_at":"2015-07-27T15:23:51Z","html_url":"https://github.com/mozilla/bedrock/pull/3159#discussion_r35548345","pull_request_url":"https://api.github.com/repos/mozilla/bedrock/pulls/3159","_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/35548345"},"html":{"href":"https://github.com/mozilla/bedrock/pull/3159#discussion_r35548345"},"pull_request":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/3159"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/3159","id":40908297,"html_url":"https://github.com/mozilla/bedrock/pull/3159","diff_url":"https://github.com/mozilla/bedrock/pull/3159.diff","patch_url":"https://github.com/mozilla/bedrock/pull/3159.patch","issue_url":"https://api.github.com/repos/mozilla/bedrock/issues/3159","number":3159,"state":"open","locked":false,"title":"Fix Bug 1172986, show message when no plugins are found","user":{"login":"schalkneethling","id":10350960,"avatar_url":"https://avatars.githubusercontent.com/u/10350960?v=3","gravatar_id":"","url":"https://api.github.com/users/schalkneethling","html_url":"https://github.com/schalkneethling","followers_url":"https://api.github.com/users/schalkneethling/followers","following_url":"https://api.github.com/users/schalkneethling/following{/other_user}","gists_url":"https://api.github.com/users/schalkneethling/gists{/gist_id}","starred_url":"https://api.github.com/users/schalkneethling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schalkneethling/subscriptions","organizations_url":"https://api.github.com/users/schalkneethling/orgs","repos_url":"https://api.github.com/users/schalkneethling/repos","events_url":"https://api.github.com/users/schalkneethling/events{/privacy}","received_events_url":"https://api.github.com/users/schalkneethling/received_events","type":"User","site_admin":false},"body":"@alexgibson r?","created_at":"2015-07-27T14:22:54Z","updated_at":"2015-07-27T15:23:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8ad2a0f08170e76db7b2471e24c88b87ddc2f7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/bedrock/pulls/3159/commits","review_comments_url":"https://api.github.com/repos/mozilla/bedrock/pulls/3159/comments","review_comment_url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/bedrock/issues/3159/comments","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/39c27975b3c10a3478c57b12d540c4e2481c6557","head":{"label":"schalkneethling:bug1172986-show-message-when-no-plugins-detected","ref":"bug1172986-show-message-when-no-plugins-detected","sha":"39c27975b3c10a3478c57b12d540c4e2481c6557","user":{"login":"schalkneethling","id":10350960,"avatar_url":"https://avatars.githubusercontent.com/u/10350960?v=3","gravatar_id":"","url":"https://api.github.com/users/schalkneethling","html_url":"https://github.com/schalkneethling","followers_url":"https://api.github.com/users/schalkneethling/followers","following_url":"https://api.github.com/users/schalkneethling/following{/other_user}","gists_url":"https://api.github.com/users/schalkneethling/gists{/gist_id}","starred_url":"https://api.github.com/users/schalkneethling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schalkneethling/subscriptions","organizations_url":"https://api.github.com/users/schalkneethling/orgs","repos_url":"https://api.github.com/users/schalkneethling/repos","events_url":"https://api.github.com/users/schalkneethling/events{/privacy}","received_events_url":"https://api.github.com/users/schalkneethling/received_events","type":"User","site_admin":false},"repo":{"id":4284689,"name":"bedrock","full_name":"schalkneethling/bedrock","owner":{"login":"schalkneethling","id":10350960,"avatar_url":"https://avatars.githubusercontent.com/u/10350960?v=3","gravatar_id":"","url":"https://api.github.com/users/schalkneethling","html_url":"https://github.com/schalkneethling","followers_url":"https://api.github.com/users/schalkneethling/followers","following_url":"https://api.github.com/users/schalkneethling/following{/other_user}","gists_url":"https://api.github.com/users/schalkneethling/gists{/gist_id}","starred_url":"https://api.github.com/users/schalkneethling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schalkneethling/subscriptions","organizations_url":"https://api.github.com/users/schalkneethling/orgs","repos_url":"https://api.github.com/users/schalkneethling/repos","events_url":"https://api.github.com/users/schalkneethling/events{/privacy}","received_events_url":"https://api.github.com/users/schalkneethling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schalkneethling/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":true,"url":"https://api.github.com/repos/schalkneethling/bedrock","forks_url":"https://api.github.com/repos/schalkneethling/bedrock/forks","keys_url":"https://api.github.com/repos/schalkneethling/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schalkneethling/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schalkneethling/bedrock/teams","hooks_url":"https://api.github.com/repos/schalkneethling/bedrock/hooks","issue_events_url":"https://api.github.com/repos/schalkneethling/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/schalkneethling/bedrock/events","assignees_url":"https://api.github.com/repos/schalkneethling/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/schalkneethling/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/schalkneethling/bedrock/tags","blobs_url":"https://api.github.com/repos/schalkneethling/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schalkneethling/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schalkneethling/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/schalkneethling/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schalkneethling/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/schalkneethling/bedrock/languages","stargazers_url":"https://api.github.com/repos/schalkneethling/bedrock/stargazers","contributors_url":"https://api.github.com/repos/schalkneethling/bedrock/contributors","subscribers_url":"https://api.github.com/repos/schalkneethling/bedrock/subscribers","subscription_url":"https://api.github.com/repos/schalkneethling/bedrock/subscription","commits_url":"https://api.github.com/repos/schalkneethling/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/schalkneethling/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/schalkneethling/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/schalkneethling/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/schalkneethling/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/schalkneethling/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schalkneethling/bedrock/merges","archive_url":"https://api.github.com/repos/schalkneethling/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schalkneethling/bedrock/downloads","issues_url":"https://api.github.com/repos/schalkneethling/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/schalkneethling/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/schalkneethling/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/schalkneethling/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schalkneethling/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/schalkneethling/bedrock/releases{/id}","created_at":"2012-05-10T13:21:55Z","updated_at":"2015-05-04T12:53:53Z","pushed_at":"2015-07-27T14:27:17Z","git_url":"git://github.com/schalkneethling/bedrock.git","ssh_url":"git@github.com:schalkneethling/bedrock.git","clone_url":"https://github.com/schalkneethling/bedrock.git","svn_url":"https://github.com/schalkneethling/bedrock","homepage":"http://mozilla.org","size":313126,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"1a9f267454421f3a96f4498ae7a8c6f9dbe469c5","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1616665,"name":"bedrock","full_name":"mozilla/bedrock","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":false,"url":"https://api.github.com/repos/mozilla/bedrock","forks_url":"https://api.github.com/repos/mozilla/bedrock/forks","keys_url":"https://api.github.com/repos/mozilla/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/bedrock/teams","hooks_url":"https://api.github.com/repos/mozilla/bedrock/hooks","issue_events_url":"https://api.github.com/repos/mozilla/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/bedrock/events","assignees_url":"https://api.github.com/repos/mozilla/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/bedrock/tags","blobs_url":"https://api.github.com/repos/mozilla/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/bedrock/languages","stargazers_url":"https://api.github.com/repos/mozilla/bedrock/stargazers","contributors_url":"https://api.github.com/repos/mozilla/bedrock/contributors","subscribers_url":"https://api.github.com/repos/mozilla/bedrock/subscribers","subscription_url":"https://api.github.com/repos/mozilla/bedrock/subscription","commits_url":"https://api.github.com/repos/mozilla/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/bedrock/merges","archive_url":"https://api.github.com/repos/mozilla/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/bedrock/downloads","issues_url":"https://api.github.com/repos/mozilla/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/bedrock/releases{/id}","created_at":"2011-04-14T22:57:57Z","updated_at":"2015-07-26T14:36:06Z","pushed_at":"2015-07-27T14:51:53Z","git_url":"git://github.com/mozilla/bedrock.git","ssh_url":"git@github.com:mozilla/bedrock.git","clone_url":"https://github.com/mozilla/bedrock.git","svn_url":"https://github.com/mozilla/bedrock","homepage":"https://www.mozilla.org","size":372873,"stargazers_count":245,"watchers_count":245,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":340,"mirror_url":null,"open_issues_count":13,"forks":340,"open_issues":13,"watchers":245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/3159"},"html":{"href":"https://github.com/mozilla/bedrock/pull/3159"},"issue":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/3159"},"comments":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/3159/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/3159/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/3159/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/bedrock/statuses/39c27975b3c10a3478c57b12d540c4e2481c6557"}}}}