{"action":"created","comment":{"url":"https://api.github.com/repos/qterminal/qtermwidget/pulls/comments/38727943","id":38727943,"diff_hunk":"@@ -242,9 +242,32 @@ void TerminalDisplay::fontChange(const QFont&)\n \n   emit changedFontMetricSignal( _fontHeight, _fontWidth );\n   propagateSize();\n+  \n+  // We will run paint event testing procedure.\n+  // Although this operation will destory the orignal content, \n+  // the content will be drawn again after the test.\n+  _drawTextTestFlag = true;\n   update();\n }\n \n+void TerminalDisplay::calDrawTextAdditionHeight(QPainter& painter)\n+{    \n+    QRect test_rect, feedback_rect;\n+\ttest_rect.setRect(1, 1, _fontWidth * 4, _fontHeight);\t\n+\tpainter.drawText(test_rect, Qt::AlignBottom, LTR_OVERRIDE_CHAR + QString(\"Mq\"), &feedback_rect);\n+\t\n+\t//qDebug() << \"test_rect:\" << test_rect << \"feeback_rect:\" << feedback_rect;","path":"lib/TerminalDisplay.cpp","position":18,"original_position":18,"commit_id":"139fe0971f5c3027e5c1ce0779c3c70e6b3a3524","original_commit_id":"139fe0971f5c3027e5c1ce0779c3c70e6b3a3524","user":{"login":"Mischanix","id":892369,"avatar_url":"https://avatars.githubusercontent.com/u/892369?v=3","gravatar_id":"","url":"https://api.github.com/users/Mischanix","html_url":"https://github.com/Mischanix","followers_url":"https://api.github.com/users/Mischanix/followers","following_url":"https://api.github.com/users/Mischanix/following{/other_user}","gists_url":"https://api.github.com/users/Mischanix/gists{/gist_id}","starred_url":"https://api.github.com/users/Mischanix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mischanix/subscriptions","organizations_url":"https://api.github.com/users/Mischanix/orgs","repos_url":"https://api.github.com/users/Mischanix/repos","events_url":"https://api.github.com/users/Mischanix/events{/privacy}","received_events_url":"https://api.github.com/users/Mischanix/received_events","type":"User","site_admin":false},"body":"Remove debug code","created_at":"2015-09-04T07:38:37Z","updated_at":"2015-09-04T07:38:37Z","html_url":"https://github.com/qterminal/qtermwidget/pull/49#discussion_r38727943","pull_request_url":"https://api.github.com/repos/qterminal/qtermwidget/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/qterminal/qtermwidget/pulls/comments/38727943"},"html":{"href":"https://github.com/qterminal/qtermwidget/pull/49#discussion_r38727943"},"pull_request":{"href":"https://api.github.com/repos/qterminal/qtermwidget/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/qterminal/qtermwidget/pulls/49","id":43749403,"html_url":"https://github.com/qterminal/qtermwidget/pull/49","diff_url":"https://github.com/qterminal/qtermwidget/pull/49.diff","patch_url":"https://github.com/qterminal/qtermwidget/pull/49.patch","issue_url":"https://api.github.com/repos/qterminal/qtermwidget/issues/49","number":49,"state":"open","locked":false,"title":"Fix fonts are truncated problem","user":{"login":"hykwok","id":11486595,"avatar_url":"https://avatars.githubusercontent.com/u/11486595?v=3","gravatar_id":"","url":"https://api.github.com/users/hykwok","html_url":"https://github.com/hykwok","followers_url":"https://api.github.com/users/hykwok/followers","following_url":"https://api.github.com/users/hykwok/following{/other_user}","gists_url":"https://api.github.com/users/hykwok/gists{/gist_id}","starred_url":"https://api.github.com/users/hykwok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hykwok/subscriptions","organizations_url":"https://api.github.com/users/hykwok/orgs","repos_url":"https://api.github.com/users/hykwok/repos","events_url":"https://api.github.com/users/hykwok/events{/privacy}","received_events_url":"https://api.github.com/users/hykwok/received_events","type":"User","site_admin":false},"body":"Calculate the additional height for the text area to solve font truncated problem (issue #46)","created_at":"2015-08-31T10:05:10Z","updated_at":"2015-09-04T07:38:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da46a4881e060a050b06fe7a905a1efc402c17c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qterminal/qtermwidget/pulls/49/commits","review_comments_url":"https://api.github.com/repos/qterminal/qtermwidget/pulls/49/comments","review_comment_url":"https://api.github.com/repos/qterminal/qtermwidget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qterminal/qtermwidget/issues/49/comments","statuses_url":"https://api.github.com/repos/qterminal/qtermwidget/statuses/139fe0971f5c3027e5c1ce0779c3c70e6b3a3524","head":{"label":"hykwok:fix-fonts-truncated-vertically","ref":"fix-fonts-truncated-vertically","sha":"139fe0971f5c3027e5c1ce0779c3c70e6b3a3524","user":{"login":"hykwok","id":11486595,"avatar_url":"https://avatars.githubusercontent.com/u/11486595?v=3","gravatar_id":"","url":"https://api.github.com/users/hykwok","html_url":"https://github.com/hykwok","followers_url":"https://api.github.com/users/hykwok/followers","following_url":"https://api.github.com/users/hykwok/following{/other_user}","gists_url":"https://api.github.com/users/hykwok/gists{/gist_id}","starred_url":"https://api.github.com/users/hykwok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hykwok/subscriptions","organizations_url":"https://api.github.com/users/hykwok/orgs","repos_url":"https://api.github.com/users/hykwok/repos","events_url":"https://api.github.com/users/hykwok/events{/privacy}","received_events_url":"https://api.github.com/users/hykwok/received_events","type":"User","site_admin":false},"repo":{"id":41577436,"name":"qtermwidget","full_name":"hykwok/qtermwidget","owner":{"login":"hykwok","id":11486595,"avatar_url":"https://avatars.githubusercontent.com/u/11486595?v=3","gravatar_id":"","url":"https://api.github.com/users/hykwok","html_url":"https://github.com/hykwok","followers_url":"https://api.github.com/users/hykwok/followers","following_url":"https://api.github.com/users/hykwok/following{/other_user}","gists_url":"https://api.github.com/users/hykwok/gists{/gist_id}","starred_url":"https://api.github.com/users/hykwok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hykwok/subscriptions","organizations_url":"https://api.github.com/users/hykwok/orgs","repos_url":"https://api.github.com/users/hykwok/repos","events_url":"https://api.github.com/users/hykwok/events{/privacy}","received_events_url":"https://api.github.com/users/hykwok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hykwok/qtermwidget","description":"The qterminal widget","fork":true,"url":"https://api.github.com/repos/hykwok/qtermwidget","forks_url":"https://api.github.com/repos/hykwok/qtermwidget/forks","keys_url":"https://api.github.com/repos/hykwok/qtermwidget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hykwok/qtermwidget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hykwok/qtermwidget/teams","hooks_url":"https://api.github.com/repos/hykwok/qtermwidget/hooks","issue_events_url":"https://api.github.com/repos/hykwok/qtermwidget/issues/events{/number}","events_url":"https://api.github.com/repos/hykwok/qtermwidget/events","assignees_url":"https://api.github.com/repos/hykwok/qtermwidget/assignees{/user}","branches_url":"https://api.github.com/repos/hykwok/qtermwidget/branches{/branch}","tags_url":"https://api.github.com/repos/hykwok/qtermwidget/tags","blobs_url":"https://api.github.com/repos/hykwok/qtermwidget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hykwok/qtermwidget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hykwok/qtermwidget/git/refs{/sha}","trees_url":"https://api.github.com/repos/hykwok/qtermwidget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hykwok/qtermwidget/statuses/{sha}","languages_url":"https://api.github.com/repos/hykwok/qtermwidget/languages","stargazers_url":"https://api.github.com/repos/hykwok/qtermwidget/stargazers","contributors_url":"https://api.github.com/repos/hykwok/qtermwidget/contributors","subscribers_url":"https://api.github.com/repos/hykwok/qtermwidget/subscribers","subscription_url":"https://api.github.com/repos/hykwok/qtermwidget/subscription","commits_url":"https://api.github.com/repos/hykwok/qtermwidget/commits{/sha}","git_commits_url":"https://api.github.com/repos/hykwok/qtermwidget/git/commits{/sha}","comments_url":"https://api.github.com/repos/hykwok/qtermwidget/comments{/number}","issue_comment_url":"https://api.github.com/repos/hykwok/qtermwidget/issues/comments{/number}","contents_url":"https://api.github.com/repos/hykwok/qtermwidget/contents/{+path}","compare_url":"https://api.github.com/repos/hykwok/qtermwidget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hykwok/qtermwidget/merges","archive_url":"https://api.github.com/repos/hykwok/qtermwidget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hykwok/qtermwidget/downloads","issues_url":"https://api.github.com/repos/hykwok/qtermwidget/issues{/number}","pulls_url":"https://api.github.com/repos/hykwok/qtermwidget/pulls{/number}","milestones_url":"https://api.github.com/repos/hykwok/qtermwidget/milestones{/number}","notifications_url":"https://api.github.com/repos/hykwok/qtermwidget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hykwok/qtermwidget/labels{/name}","releases_url":"https://api.github.com/repos/hykwok/qtermwidget/releases{/id}","created_at":"2015-08-29T02:19:31Z","updated_at":"2015-08-29T02:19:32Z","pushed_at":"2015-08-31T10:05:08Z","git_url":"git://github.com/hykwok/qtermwidget.git","ssh_url":"git@github.com:hykwok/qtermwidget.git","clone_url":"https://github.com/hykwok/qtermwidget.git","svn_url":"https://github.com/hykwok/qtermwidget","homepage":"","size":1101,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qterminal:master","ref":"master","sha":"72ffc262eb6cd5deaf3489068f7fe6a91f734998","user":{"login":"qterminal","id":1456224,"avatar_url":"https://avatars.githubusercontent.com/u/1456224?v=3","gravatar_id":"","url":"https://api.github.com/users/qterminal","html_url":"https://github.com/qterminal","followers_url":"https://api.github.com/users/qterminal/followers","following_url":"https://api.github.com/users/qterminal/following{/other_user}","gists_url":"https://api.github.com/users/qterminal/gists{/gist_id}","starred_url":"https://api.github.com/users/qterminal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qterminal/subscriptions","organizations_url":"https://api.github.com/users/qterminal/orgs","repos_url":"https://api.github.com/users/qterminal/repos","events_url":"https://api.github.com/users/qterminal/events{/privacy}","received_events_url":"https://api.github.com/users/qterminal/received_events","type":"Organization","site_admin":false},"repo":{"id":3504505,"name":"qtermwidget","full_name":"qterminal/qtermwidget","owner":{"login":"qterminal","id":1456224,"avatar_url":"https://avatars.githubusercontent.com/u/1456224?v=3","gravatar_id":"","url":"https://api.github.com/users/qterminal","html_url":"https://github.com/qterminal","followers_url":"https://api.github.com/users/qterminal/followers","following_url":"https://api.github.com/users/qterminal/following{/other_user}","gists_url":"https://api.github.com/users/qterminal/gists{/gist_id}","starred_url":"https://api.github.com/users/qterminal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qterminal/subscriptions","organizations_url":"https://api.github.com/users/qterminal/orgs","repos_url":"https://api.github.com/users/qterminal/repos","events_url":"https://api.github.com/users/qterminal/events{/privacy}","received_events_url":"https://api.github.com/users/qterminal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qterminal/qtermwidget","description":"A Terminal widget for Qt","fork":false,"url":"https://api.github.com/repos/qterminal/qtermwidget","forks_url":"https://api.github.com/repos/qterminal/qtermwidget/forks","keys_url":"https://api.github.com/repos/qterminal/qtermwidget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qterminal/qtermwidget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qterminal/qtermwidget/teams","hooks_url":"https://api.github.com/repos/qterminal/qtermwidget/hooks","issue_events_url":"https://api.github.com/repos/qterminal/qtermwidget/issues/events{/number}","events_url":"https://api.github.com/repos/qterminal/qtermwidget/events","assignees_url":"https://api.github.com/repos/qterminal/qtermwidget/assignees{/user}","branches_url":"https://api.github.com/repos/qterminal/qtermwidget/branches{/branch}","tags_url":"https://api.github.com/repos/qterminal/qtermwidget/tags","blobs_url":"https://api.github.com/repos/qterminal/qtermwidget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qterminal/qtermwidget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qterminal/qtermwidget/git/refs{/sha}","trees_url":"https://api.github.com/repos/qterminal/qtermwidget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qterminal/qtermwidget/statuses/{sha}","languages_url":"https://api.github.com/repos/qterminal/qtermwidget/languages","stargazers_url":"https://api.github.com/repos/qterminal/qtermwidget/stargazers","contributors_url":"https://api.github.com/repos/qterminal/qtermwidget/contributors","subscribers_url":"https://api.github.com/repos/qterminal/qtermwidget/subscribers","subscription_url":"https://api.github.com/repos/qterminal/qtermwidget/subscription","commits_url":"https://api.github.com/repos/qterminal/qtermwidget/commits{/sha}","git_commits_url":"https://api.github.com/repos/qterminal/qtermwidget/git/commits{/sha}","comments_url":"https://api.github.com/repos/qterminal/qtermwidget/comments{/number}","issue_comment_url":"https://api.github.com/repos/qterminal/qtermwidget/issues/comments{/number}","contents_url":"https://api.github.com/repos/qterminal/qtermwidget/contents/{+path}","compare_url":"https://api.github.com/repos/qterminal/qtermwidget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qterminal/qtermwidget/merges","archive_url":"https://api.github.com/repos/qterminal/qtermwidget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qterminal/qtermwidget/downloads","issues_url":"https://api.github.com/repos/qterminal/qtermwidget/issues{/number}","pulls_url":"https://api.github.com/repos/qterminal/qtermwidget/pulls{/number}","milestones_url":"https://api.github.com/repos/qterminal/qtermwidget/milestones{/number}","notifications_url":"https://api.github.com/repos/qterminal/qtermwidget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qterminal/qtermwidget/labels{/name}","releases_url":"https://api.github.com/repos/qterminal/qtermwidget/releases{/id}","created_at":"2012-02-21T14:24:17Z","updated_at":"2015-09-04T04:46:30Z","pushed_at":"2015-08-31T10:05:11Z","git_url":"git://github.com/qterminal/qtermwidget.git","ssh_url":"git@github.com:qterminal/qtermwidget.git","clone_url":"https://github.com/qterminal/qtermwidget.git","svn_url":"https://github.com/qterminal/qtermwidget","homepage":"http://lxqt.org","size":1101,"stargazers_count":60,"watchers_count":60,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":10,"forks":40,"open_issues":10,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qterminal/qtermwidget/pulls/49"},"html":{"href":"https://github.com/qterminal/qtermwidget/pull/49"},"issue":{"href":"https://api.github.com/repos/qterminal/qtermwidget/issues/49"},"comments":{"href":"https://api.github.com/repos/qterminal/qtermwidget/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/qterminal/qtermwidget/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/qterminal/qtermwidget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qterminal/qtermwidget/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/qterminal/qtermwidget/statuses/139fe0971f5c3027e5c1ce0779c3c70e6b3a3524"}}}}