{"action":"created","comment":{"url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments/22582767","id":22582767,"diff_hunk":"@@ -115,20 +118,25 @@ struct URL {\n     }\n   }\n \n-  URL(const std::string& url, const URL& previous)\n-      : URL(url, previous.protocol, previous.host, previous.port) {}\n+  URLWithoutParameters(const std::string& url, const URLWithoutParameters& previous)\n+      : URLWithoutParameters(url, previous.protocol, previous.host, previous.port) {}\n \n   std::string ComposeURL() const {\n-    std::ostringstream os;\n-    if (!protocol.empty()) {\n-      os << protocol << \"://\";\n-    }\n-    os << host;\n-    if (port != DefaultPortForProtocol(protocol)) {\n-      os << ':' << port;\n+    if (!host.empty()) {\n+      std::ostringstream os;\n+      if (!protocol.empty()) {\n+        os << protocol << \"://\";","path":"net/url/url.h","position":88,"original_position":88,"commit_id":"4063bdc93b72a5c9f2f48a4924f2df4a3711f60c","original_commit_id":"4063bdc93b72a5c9f2f48a4924f2df4a3711f60c","user":{"login":"deathbaba","id":170263,"avatar_url":"https://avatars.githubusercontent.com/u/170263?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbaba","html_url":"https://github.com/deathbaba","followers_url":"https://api.github.com/users/deathbaba/followers","following_url":"https://api.github.com/users/deathbaba/following{/other_user}","gists_url":"https://api.github.com/users/deathbaba/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbaba/subscriptions","organizations_url":"https://api.github.com/users/deathbaba/orgs","repos_url":"https://api.github.com/users/deathbaba/repos","events_url":"https://api.github.com/users/deathbaba/events{/privacy}","received_events_url":"https://api.github.com/users/deathbaba/received_events","type":"User","site_admin":false},"body":"may be scheme instead of protocol?","created_at":"2015-01-07T12:01:51Z","updated_at":"2015-01-07T12:01:51Z","html_url":"https://github.com/KnowSheet/Bricks/pull/36#discussion_r22582767","pull_request_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments/22582767"},"html":{"href":"https://github.com/KnowSheet/Bricks/pull/36#discussion_r22582767"},"pull_request":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/36","id":26942633,"html_url":"https://github.com/KnowSheet/Bricks/pull/36","diff_url":"https://github.com/KnowSheet/Bricks/pull/36.diff","patch_url":"https://github.com/KnowSheet/Bricks/pull/36.patch","issue_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/36","number":36,"state":"open","locked":false,"title":"URL Parsing.","user":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-07T07:54:23Z","updated_at":"2015-01-07T12:01:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5b31614754273eccdd5651b35b89d5445a7a5be","assignee":{"login":"deathbaba","id":170263,"avatar_url":"https://avatars.githubusercontent.com/u/170263?v=3","gravatar_id":"","url":"https://api.github.com/users/deathbaba","html_url":"https://github.com/deathbaba","followers_url":"https://api.github.com/users/deathbaba/followers","following_url":"https://api.github.com/users/deathbaba/following{/other_user}","gists_url":"https://api.github.com/users/deathbaba/gists{/gist_id}","starred_url":"https://api.github.com/users/deathbaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deathbaba/subscriptions","organizations_url":"https://api.github.com/users/deathbaba/orgs","repos_url":"https://api.github.com/users/deathbaba/repos","events_url":"https://api.github.com/users/deathbaba/events{/privacy}","received_events_url":"https://api.github.com/users/deathbaba/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/36/commits","review_comments_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/36/comments","review_comment_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments/{number}","comments_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/36/comments","statuses_url":"https://api.github.com/repos/KnowSheet/Bricks/statuses/4063bdc93b72a5c9f2f48a4924f2df4a3711f60c","head":{"label":"dkorolev:master","ref":"master","sha":"4063bdc93b72a5c9f2f48a4924f2df4a3711f60c","user":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"repo":{"id":27625438,"name":"Bricks","full_name":"dkorolev/Bricks","owner":{"login":"dkorolev","id":2159447,"avatar_url":"https://avatars.githubusercontent.com/u/2159447?v=3","gravatar_id":"","url":"https://api.github.com/users/dkorolev","html_url":"https://github.com/dkorolev","followers_url":"https://api.github.com/users/dkorolev/followers","following_url":"https://api.github.com/users/dkorolev/following{/other_user}","gists_url":"https://api.github.com/users/dkorolev/gists{/gist_id}","starred_url":"https://api.github.com/users/dkorolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkorolev/subscriptions","organizations_url":"https://api.github.com/users/dkorolev/orgs","repos_url":"https://api.github.com/users/dkorolev/repos","events_url":"https://api.github.com/users/dkorolev/events{/privacy}","received_events_url":"https://api.github.com/users/dkorolev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkorolev/Bricks","description":"Our own core pieces to reuse.","fork":true,"url":"https://api.github.com/repos/dkorolev/Bricks","forks_url":"https://api.github.com/repos/dkorolev/Bricks/forks","keys_url":"https://api.github.com/repos/dkorolev/Bricks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkorolev/Bricks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkorolev/Bricks/teams","hooks_url":"https://api.github.com/repos/dkorolev/Bricks/hooks","issue_events_url":"https://api.github.com/repos/dkorolev/Bricks/issues/events{/number}","events_url":"https://api.github.com/repos/dkorolev/Bricks/events","assignees_url":"https://api.github.com/repos/dkorolev/Bricks/assignees{/user}","branches_url":"https://api.github.com/repos/dkorolev/Bricks/branches{/branch}","tags_url":"https://api.github.com/repos/dkorolev/Bricks/tags","blobs_url":"https://api.github.com/repos/dkorolev/Bricks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkorolev/Bricks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkorolev/Bricks/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkorolev/Bricks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkorolev/Bricks/statuses/{sha}","languages_url":"https://api.github.com/repos/dkorolev/Bricks/languages","stargazers_url":"https://api.github.com/repos/dkorolev/Bricks/stargazers","contributors_url":"https://api.github.com/repos/dkorolev/Bricks/contributors","subscribers_url":"https://api.github.com/repos/dkorolev/Bricks/subscribers","subscription_url":"https://api.github.com/repos/dkorolev/Bricks/subscription","commits_url":"https://api.github.com/repos/dkorolev/Bricks/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkorolev/Bricks/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkorolev/Bricks/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkorolev/Bricks/issues/comments/{number}","contents_url":"https://api.github.com/repos/dkorolev/Bricks/contents/{+path}","compare_url":"https://api.github.com/repos/dkorolev/Bricks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkorolev/Bricks/merges","archive_url":"https://api.github.com/repos/dkorolev/Bricks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkorolev/Bricks/downloads","issues_url":"https://api.github.com/repos/dkorolev/Bricks/issues{/number}","pulls_url":"https://api.github.com/repos/dkorolev/Bricks/pulls{/number}","milestones_url":"https://api.github.com/repos/dkorolev/Bricks/milestones{/number}","notifications_url":"https://api.github.com/repos/dkorolev/Bricks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkorolev/Bricks/labels{/name}","releases_url":"https://api.github.com/repos/dkorolev/Bricks/releases{/id}","created_at":"2014-12-06T06:52:51Z","updated_at":"2015-01-07T11:37:42Z","pushed_at":"2015-01-07T11:37:42Z","git_url":"git://github.com/dkorolev/Bricks.git","ssh_url":"git@github.com:dkorolev/Bricks.git","clone_url":"https://github.com/dkorolev/Bricks.git","svn_url":"https://github.com/dkorolev/Bricks","homepage":null,"size":2832,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"KnowSheet:master","ref":"master","sha":"40799679445159e60712ab64ebd2c8ca749600d3","user":{"login":"KnowSheet","id":9897562,"avatar_url":"https://avatars.githubusercontent.com/u/9897562?v=3","gravatar_id":"","url":"https://api.github.com/users/KnowSheet","html_url":"https://github.com/KnowSheet","followers_url":"https://api.github.com/users/KnowSheet/followers","following_url":"https://api.github.com/users/KnowSheet/following{/other_user}","gists_url":"https://api.github.com/users/KnowSheet/gists{/gist_id}","starred_url":"https://api.github.com/users/KnowSheet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnowSheet/subscriptions","organizations_url":"https://api.github.com/users/KnowSheet/orgs","repos_url":"https://api.github.com/users/KnowSheet/repos","events_url":"https://api.github.com/users/KnowSheet/events{/privacy}","received_events_url":"https://api.github.com/users/KnowSheet/received_events","type":"Organization","site_admin":false},"repo":{"id":27625425,"name":"Bricks","full_name":"KnowSheet/Bricks","owner":{"login":"KnowSheet","id":9897562,"avatar_url":"https://avatars.githubusercontent.com/u/9897562?v=3","gravatar_id":"","url":"https://api.github.com/users/KnowSheet","html_url":"https://github.com/KnowSheet","followers_url":"https://api.github.com/users/KnowSheet/followers","following_url":"https://api.github.com/users/KnowSheet/following{/other_user}","gists_url":"https://api.github.com/users/KnowSheet/gists{/gist_id}","starred_url":"https://api.github.com/users/KnowSheet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnowSheet/subscriptions","organizations_url":"https://api.github.com/users/KnowSheet/orgs","repos_url":"https://api.github.com/users/KnowSheet/repos","events_url":"https://api.github.com/users/KnowSheet/events{/privacy}","received_events_url":"https://api.github.com/users/KnowSheet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KnowSheet/Bricks","description":"Our own core pieces to reuse.","fork":false,"url":"https://api.github.com/repos/KnowSheet/Bricks","forks_url":"https://api.github.com/repos/KnowSheet/Bricks/forks","keys_url":"https://api.github.com/repos/KnowSheet/Bricks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KnowSheet/Bricks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KnowSheet/Bricks/teams","hooks_url":"https://api.github.com/repos/KnowSheet/Bricks/hooks","issue_events_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/events{/number}","events_url":"https://api.github.com/repos/KnowSheet/Bricks/events","assignees_url":"https://api.github.com/repos/KnowSheet/Bricks/assignees{/user}","branches_url":"https://api.github.com/repos/KnowSheet/Bricks/branches{/branch}","tags_url":"https://api.github.com/repos/KnowSheet/Bricks/tags","blobs_url":"https://api.github.com/repos/KnowSheet/Bricks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KnowSheet/Bricks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KnowSheet/Bricks/git/refs{/sha}","trees_url":"https://api.github.com/repos/KnowSheet/Bricks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KnowSheet/Bricks/statuses/{sha}","languages_url":"https://api.github.com/repos/KnowSheet/Bricks/languages","stargazers_url":"https://api.github.com/repos/KnowSheet/Bricks/stargazers","contributors_url":"https://api.github.com/repos/KnowSheet/Bricks/contributors","subscribers_url":"https://api.github.com/repos/KnowSheet/Bricks/subscribers","subscription_url":"https://api.github.com/repos/KnowSheet/Bricks/subscription","commits_url":"https://api.github.com/repos/KnowSheet/Bricks/commits{/sha}","git_commits_url":"https://api.github.com/repos/KnowSheet/Bricks/git/commits{/sha}","comments_url":"https://api.github.com/repos/KnowSheet/Bricks/comments{/number}","issue_comment_url":"https://api.github.com/repos/KnowSheet/Bricks/issues/comments/{number}","contents_url":"https://api.github.com/repos/KnowSheet/Bricks/contents/{+path}","compare_url":"https://api.github.com/repos/KnowSheet/Bricks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KnowSheet/Bricks/merges","archive_url":"https://api.github.com/repos/KnowSheet/Bricks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KnowSheet/Bricks/downloads","issues_url":"https://api.github.com/repos/KnowSheet/Bricks/issues{/number}","pulls_url":"https://api.github.com/repos/KnowSheet/Bricks/pulls{/number}","milestones_url":"https://api.github.com/repos/KnowSheet/Bricks/milestones{/number}","notifications_url":"https://api.github.com/repos/KnowSheet/Bricks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KnowSheet/Bricks/labels{/name}","releases_url":"https://api.github.com/repos/KnowSheet/Bricks/releases{/id}","created_at":"2014-12-06T06:52:23Z","updated_at":"2015-01-05T23:48:13Z","pushed_at":"2015-01-05T23:48:13Z","git_url":"git://github.com/KnowSheet/Bricks.git","ssh_url":"git@github.com:KnowSheet/Bricks.git","clone_url":"https://github.com/KnowSheet/Bricks.git","svn_url":"https://github.com/KnowSheet/Bricks","homepage":null,"size":2463,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/36"},"html":{"href":"https://github.com/KnowSheet/Bricks/pull/36"},"issue":{"href":"https://api.github.com/repos/KnowSheet/Bricks/issues/36"},"comments":{"href":"https://api.github.com/repos/KnowSheet/Bricks/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/KnowSheet/Bricks/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/KnowSheet/Bricks/statuses/4063bdc93b72a5c9f2f48a4924f2df4a3711f60c"}}}}