{"action":"created","issue":{"url":"https://api.github.com/repos/youribonnaffe/gradle-format-plugin/issues/10","labels_url":"https://api.github.com/repos/youribonnaffe/gradle-format-plugin/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/youribonnaffe/gradle-format-plugin/issues/10/comments","events_url":"https://api.github.com/repos/youribonnaffe/gradle-format-plugin/issues/10/events","html_url":"https://github.com/youribonnaffe/gradle-format-plugin/pull/10","id":70035449,"number":10,"title":"Java 8 support progress","user":{"login":"nedtwigg","id":2924992,"avatar_url":"https://avatars.githubusercontent.com/u/2924992?v=3","gravatar_id":"","url":"https://api.github.com/users/nedtwigg","html_url":"https://github.com/nedtwigg","followers_url":"https://api.github.com/users/nedtwigg/followers","following_url":"https://api.github.com/users/nedtwigg/following{/other_user}","gists_url":"https://api.github.com/users/nedtwigg/gists{/gist_id}","starred_url":"https://api.github.com/users/nedtwigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nedtwigg/subscriptions","organizations_url":"https://api.github.com/users/nedtwigg/orgs","repos_url":"https://api.github.com/users/nedtwigg/repos","events_url":"https://api.github.com/users/nedtwigg/events{/privacy}","received_events_url":"https://api.github.com/users/nedtwigg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-04-22T06:24:11Z","updated_at":"2015-06-14T04:48:52Z","closed_at":"2015-05-08T14:37:44Z","pull_request":{"url":"https://api.github.com/repos/youribonnaffe/gradle-format-plugin/pulls/10","html_url":"https://github.com/youribonnaffe/gradle-format-plugin/pull/10","diff_url":"https://github.com/youribonnaffe/gradle-format-plugin/pull/10.diff","patch_url":"https://github.com/youribonnaffe/gradle-format-plugin/pull/10.patch"},"body":"Looks like my \"just update your dependency\" suggestion was pretty naive of me, sorry!  It seems that public maven repos didn't have all of the transitives, and it was failing silently.\r\n\r\nI went back to your last public release, then created a complicated Java 8 example that definitely fails (so that we can be sure we've fixed the issue when it passes).\r\n\r\nThen I resolved the dependencies of the latest Eclipse by hand using a hacked-up ivy downloader to access Eclipse's official p2 repository (p2 is Eclipse's own special repository format.  I just finished building an installer that uses p2, and it was a nightmare, but it's the only way to get recent Eclipse artifacts).\r\n\r\nWhen I run the tests in Eclipse (supposedly with the same class path), the formatter succeeds.  When I run them at the command line from gradle, it fails...\r\n\r\nSince I'm this far in, I'm probably gonna take a chunk of tomorrow to just go all the way and add:\r\n- a check task\r\n- incremental formatting (only run on changed files)\r\n- maybe license header enforcement (one formatting plugin to rule them all).\r\n\r\nAt least for me, I'm more comfortable doing this in Java, and I think I'm likely to write more new lines than currently exist in the project.\r\n\r\nTotally understand if this is more than you bargained for and you'd prefer that I just forked.  I'll keep you up-to-date as I make progress (or as I get stuck ;-)"},"comment":{"url":"https://api.github.com/repos/youribonnaffe/gradle-format-plugin/issues/comments/111783038","html_url":"https://github.com/youribonnaffe/gradle-format-plugin/pull/10#issuecomment-111783038","issue_url":"https://api.github.com/repos/youribonnaffe/gradle-format-plugin/issues/10","id":111783038,"user":{"login":"selvarajchennappan","id":11964876,"avatar_url":"https://avatars.githubusercontent.com/u/11964876?v=3","gravatar_id":"","url":"https://api.github.com/users/selvarajchennappan","html_url":"https://github.com/selvarajchennappan","followers_url":"https://api.github.com/users/selvarajchennappan/followers","following_url":"https://api.github.com/users/selvarajchennappan/following{/other_user}","gists_url":"https://api.github.com/users/selvarajchennappan/gists{/gist_id}","starred_url":"https://api.github.com/users/selvarajchennappan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvarajchennappan/subscriptions","organizations_url":"https://api.github.com/users/selvarajchennappan/orgs","repos_url":"https://api.github.com/users/selvarajchennappan/repos","events_url":"https://api.github.com/users/selvarajchennappan/events{/privacy}","received_events_url":"https://api.github.com/users/selvarajchennappan/received_events","type":"User","site_admin":false},"created_at":"2015-06-14T04:48:52Z","updated_at":"2015-06-14T04:48:52Z","body":"plugins {\r\n  id 'com.github.youribonnaffe.gradle.format'  version \"1.3\"\r\n}\r\n\r\nIt is not working ."}}