{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/28547898","id":28547898,"diff_hunk":"@@ -407,14 +418,18 @@ def grant_everyone_full_access(path)\n         end\n \n         describe \"#group=\" do\n+          it \"should accept the test group\" do\n+            check_group_depending_on_current_user(path)\n+          end\n+\n           it \"should accept a group sid\" do\n             winsec.set_group(sids[:power_users], path)\n             expect(winsec.get_group(path)).to eq(sids[:power_users])\n           end\n \n           it \"should accept a user sid\" do\n-            winsec.set_group(sids[:admin], path)\n-            expect(winsec.get_group(path)).to eq(sids[:admin])\n+            winsec.set_group(sids[:current_user], path)\n+            expect(winsec.get_group(path)).to eq(sids[:current_user])","path":"spec/integration/util/windows/security_spec.rb","position":56,"original_position":56,"commit_id":"ce9b542a3a2b46de4e7d54a93c121f8756f88ffd","original_commit_id":"ce9b542a3a2b46de4e7d54a93c121f8756f88ffd","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Line 383 (`set_group_depending_on_current_user(path)`) will set_group to guest (or a restricted permission set). I added line 422 (`check_group_depending_on_current_user(path)`) to verify it succeeded.","created_at":"2015-04-16T20:43:27Z","updated_at":"2015-04-16T20:43:27Z","html_url":"https://github.com/puppetlabs/puppet/pull/3821#discussion_r28547898","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3821","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/28547898"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3821#discussion_r28547898"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3821"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3821","id":33369371,"html_url":"https://github.com/puppetlabs/puppet/pull/3821","diff_url":"https://github.com/puppetlabs/puppet/pull/3821.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3821.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3821","number":3821,"state":"open","locked":false,"title":"(PUP-585, PUP-4404) Add AppVeyor, fix specs expecting Administrator user","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Windows spec tests cover behavior that's platform-specific and not\r\nexposed by running spec tests on other CI platforms. This sometimes\r\nleads to missing spec failures on pull requests that primarily affect\r\nWindows.\r\n\r\nAdd AppVeyor configuration to run spec tests on Windows.\r\n\r\n(PUP-4404) Use current user for SID spec test\r\n(PUP-4404) Use current user for security specs","created_at":"2015-04-15T15:56:51Z","updated_at":"2015-04-16T20:43:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7899a29020156abd73719f19517f75f005179553","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3821/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3821/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3821/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/ce9b542a3a2b46de4e7d54a93c121f8756f88ffd","head":{"label":"MikaelSmith:bug/master/PUP-585-4404-appveyor","ref":"bug/master/PUP-585-4404-appveyor","sha":"ce9b542a3a2b46de4e7d54a93c121f8756f88ffd","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"repo":{"id":22081114,"name":"puppet","full_name":"MikaelSmith/puppet","owner":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikaelSmith/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/MikaelSmith/puppet","forks_url":"https://api.github.com/repos/MikaelSmith/puppet/forks","keys_url":"https://api.github.com/repos/MikaelSmith/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikaelSmith/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikaelSmith/puppet/teams","hooks_url":"https://api.github.com/repos/MikaelSmith/puppet/hooks","issue_events_url":"https://api.github.com/repos/MikaelSmith/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/MikaelSmith/puppet/events","assignees_url":"https://api.github.com/repos/MikaelSmith/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/MikaelSmith/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/MikaelSmith/puppet/tags","blobs_url":"https://api.github.com/repos/MikaelSmith/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikaelSmith/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikaelSmith/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikaelSmith/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikaelSmith/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/MikaelSmith/puppet/languages","stargazers_url":"https://api.github.com/repos/MikaelSmith/puppet/stargazers","contributors_url":"https://api.github.com/repos/MikaelSmith/puppet/contributors","subscribers_url":"https://api.github.com/repos/MikaelSmith/puppet/subscribers","subscription_url":"https://api.github.com/repos/MikaelSmith/puppet/subscription","commits_url":"https://api.github.com/repos/MikaelSmith/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikaelSmith/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikaelSmith/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikaelSmith/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikaelSmith/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/MikaelSmith/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikaelSmith/puppet/merges","archive_url":"https://api.github.com/repos/MikaelSmith/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikaelSmith/puppet/downloads","issues_url":"https://api.github.com/repos/MikaelSmith/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/MikaelSmith/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/MikaelSmith/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/MikaelSmith/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikaelSmith/puppet/labels{/name}","releases_url":"https://api.github.com/repos/MikaelSmith/puppet/releases{/id}","created_at":"2014-07-21T21:34:58Z","updated_at":"2015-04-14T21:16:46Z","pushed_at":"2015-04-15T15:56:11Z","git_url":"git://github.com/MikaelSmith/puppet.git","ssh_url":"git@github.com:MikaelSmith/puppet.git","clone_url":"https://github.com/MikaelSmith/puppet.git","svn_url":"https://github.com/MikaelSmith/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":47662,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"f0b962b0ff87d778554b64e7ca1ea022b72f0444","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-04-16T18:36:25Z","pushed_at":"2015-04-16T20:27:34Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":112342,"stargazers_count":3170,"watchers_count":3170,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1344,"mirror_url":null,"open_issues_count":46,"forks":1344,"open_issues":46,"watchers":3170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3821"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3821"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3821"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3821/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3821/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3821/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/ce9b542a3a2b46de4e7d54a93c121f8756f88ffd"}}}}