{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/comments/37145130","id":37145130,"diff_hunk":"@@ -27,12 +27,26 @@ define([\n       PASSWORD_TOO_SHORT: 'PASSWORD_TOO_SHORT'\n     };\n \n-    function isStrongEnough(password) {\n-      // Check for passwords that at least contain a number and an alphabet,\n-      // or if alphabets, then at least (minLength + 4) characters long\n-      var regexString = '((?=.*[a-zA-Z])(?=.*[0-9])[A-Za-z0-9!@#$%^&*()_+ ]{' + minLength + ',' + (minLength + 4) + '})|([A-Za-z0-9!@#$%^&*()_+ ]{' + (minLength + 4) + ',})';","path":"src/passwordcheck.js","position":7,"original_position":7,"commit_id":"bf34300bfbcf265372565c0e19f0a0893af52b73","original_commit_id":"bf34300bfbcf265372565c0e19f0a0893af52b73","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"body":"@TDA - If we make this change, will the bloom filter data set need to be updated?","created_at":"2015-08-16T12:01:59Z","updated_at":"2015-08-16T12:01:59Z","html_url":"https://github.com/mozilla/fxa-password-strength-checker/pull/29#discussion_r37145130","pull_request_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/comments/37145130"},"html":{"href":"https://github.com/mozilla/fxa-password-strength-checker/pull/29#discussion_r37145130"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/29","id":42274926,"html_url":"https://github.com/mozilla/fxa-password-strength-checker/pull/29","diff_url":"https://github.com/mozilla/fxa-password-strength-checker/pull/29.diff","patch_url":"https://github.com/mozilla/fxa-password-strength-checker/pull/29.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/29","number":29,"state":"open","locked":false,"title":"refactor(src): refactor regex to blacklist all numbers or letters","user":{"login":"TDA","id":432707,"avatar_url":"https://avatars.githubusercontent.com/u/432707?v=3","gravatar_id":"","url":"https://api.github.com/users/TDA","html_url":"https://github.com/TDA","followers_url":"https://api.github.com/users/TDA/followers","following_url":"https://api.github.com/users/TDA/following{/other_user}","gists_url":"https://api.github.com/users/TDA/gists{/gist_id}","starred_url":"https://api.github.com/users/TDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TDA/subscriptions","organizations_url":"https://api.github.com/users/TDA/orgs","repos_url":"https://api.github.com/users/TDA/repos","events_url":"https://api.github.com/users/TDA/events{/privacy}","received_events_url":"https://api.github.com/users/TDA/received_events","type":"User","site_admin":false},"body":"refactor the regex to simplify usage, and to blacklist bad passwords instead of whitelisting strong passwords.\r\n@shane-tomlinson \r\nPS: Im sorry for all the merge-commit-messages, I dont know how to remove them :(","created_at":"2015-08-12T18:55:16Z","updated_at":"2015-08-16T12:01:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5acd920751cdad9dbe6ffffb321e9c077b62fe88","assignee":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/29/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/29/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/29/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/statuses/bf34300bfbcf265372565c0e19f0a0893af52b73","head":{"label":"mozilla:issue-fix-regex","ref":"issue-fix-regex","sha":"bf34300bfbcf265372565c0e19f0a0893af52b73","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":39597972,"name":"fxa-password-strength-checker","full_name":"mozilla/fxa-password-strength-checker","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-password-strength-checker","description":"Utility library for checking the strength of a user's password","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker","forks_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/releases{/id}","created_at":"2015-07-23T22:52:30Z","updated_at":"2015-07-23T23:12:01Z","pushed_at":"2015-08-16T11:37:48Z","git_url":"git://github.com/mozilla/fxa-password-strength-checker.git","ssh_url":"git@github.com:mozilla/fxa-password-strength-checker.git","clone_url":"https://github.com/mozilla/fxa-password-strength-checker.git","svn_url":"https://github.com/mozilla/fxa-password-strength-checker","homepage":null,"size":3712,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"8165cf7ed9a43e9fa2dc62d13a30878d208a7775","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":39597972,"name":"fxa-password-strength-checker","full_name":"mozilla/fxa-password-strength-checker","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-password-strength-checker","description":"Utility library for checking the strength of a user's password","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker","forks_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/releases{/id}","created_at":"2015-07-23T22:52:30Z","updated_at":"2015-07-23T23:12:01Z","pushed_at":"2015-08-16T11:37:48Z","git_url":"git://github.com/mozilla/fxa-password-strength-checker.git","ssh_url":"git@github.com:mozilla/fxa-password-strength-checker.git","clone_url":"https://github.com/mozilla/fxa-password-strength-checker.git","svn_url":"https://github.com/mozilla/fxa-password-strength-checker","homepage":null,"size":3712,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/29"},"html":{"href":"https://github.com/mozilla/fxa-password-strength-checker/pull/29"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/29"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/statuses/bf34300bfbcf265372565c0e19f0a0893af52b73"}}}}