{"action":"closed","issue":{"url":"https://api.github.com/repos/klauspost/rawspeed/issues/116","labels_url":"https://api.github.com/repos/klauspost/rawspeed/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/klauspost/rawspeed/issues/116/comments","events_url":"https://api.github.com/repos/klauspost/rawspeed/issues/116/events","html_url":"https://github.com/klauspost/rawspeed/issues/116","id":101259464,"number":116,"title":"Is the CFA pattern setting code in SrwDecoder really needed?","user":{"login":"pedrocr","id":246322,"avatar_url":"https://avatars.githubusercontent.com/u/246322?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrocr","html_url":"https://github.com/pedrocr","followers_url":"https://api.github.com/users/pedrocr/followers","following_url":"https://api.github.com/users/pedrocr/following{/other_user}","gists_url":"https://api.github.com/users/pedrocr/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrocr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrocr/subscriptions","organizations_url":"https://api.github.com/users/pedrocr/orgs","repos_url":"https://api.github.com/users/pedrocr/repos","events_url":"https://api.github.com/users/pedrocr/events{/privacy}","received_events_url":"https://api.github.com/users/pedrocr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-16T12:28:15Z","updated_at":"2015-08-29T14:01:18Z","closed_at":"2015-08-29T14:01:18Z","body":"While fixing some unrelated stuff I stumbled upon this code in SrwDecoder:\r\n\r\nhttps://github.com/klauspost/rawspeed/blob/develop/RawSpeed/SrwDecoder.cpp#L443-L473\r\n\r\nI doubt this is really needed. This sets the CFA pattern from the camera info but after this setMetadata should overwrite anything that was set. Any objections if I just remove this completely?"}}