{"action":"created","issue":{"url":"https://api.github.com/repos/hhuijser/liferay-portal/issues/2360","labels_url":"https://api.github.com/repos/hhuijser/liferay-portal/issues/2360/labels{/name}","comments_url":"https://api.github.com/repos/hhuijser/liferay-portal/issues/2360/comments","events_url":"https://api.github.com/repos/hhuijser/liferay-portal/issues/2360/events","html_url":"https://github.com/hhuijser/liferay-portal/pull/2360","id":81608354,"number":2360,"title":"LPS-55941","user":{"login":"jonathanmccann","id":1919610,"avatar_url":"https://avatars.githubusercontent.com/u/1919610?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanmccann","html_url":"https://github.com/jonathanmccann","followers_url":"https://api.github.com/users/jonathanmccann/followers","following_url":"https://api.github.com/users/jonathanmccann/following{/other_user}","gists_url":"https://api.github.com/users/jonathanmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanmccann/subscriptions","organizations_url":"https://api.github.com/users/jonathanmccann/orgs","repos_url":"https://api.github.com/users/jonathanmccann/repos","events_url":"https://api.github.com/users/jonathanmccann/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanmccann/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-27T20:22:17Z","updated_at":"2015-05-29T01:27:49Z","closed_at":"2015-05-29T01:27:49Z","pull_request":{"url":"https://api.github.com/repos/hhuijser/liferay-portal/pulls/2360","html_url":"https://github.com/hhuijser/liferay-portal/pull/2360","diff_url":"https://github.com/hhuijser/liferay-portal/pull/2360.diff","patch_url":"https://github.com/hhuijser/liferay-portal/pull/2360.patch"},"body":"Hey Hugo,\r\n\r\nI wasn't sure who would be the best to review this so I was hoping you'd be able to take a look at it.\r\n\r\nThere were a couple items where I wasn't sure of the best implementation:\r\n\r\n1. The error logged in https://github.com/jonathanmccann/liferay-portal/commit/32012931cfa00f2b424f69f3d52eb4b299b21e8d#diff-2d4284036aec4d8fc224e53dd49347c6R139 is using Google's error codes (\"missing-input-secret\", \"invalid-input-secret\") I thought about using the language util to translate the error messages but didn't since all of our logs are in English.\r\n2. Overriding the check methods in ReCaptchaImpl in order to throw the correct exception and log the right error message. I like the idea of throwing a specific error and having the error message not reference \"text\" since no text is inputted by the user anymore.\r\n\r\nLet me know what you think about the above and if you have any questions. Thanks!\r\n\r\nRelated to https://github.com/hhuijser/liferay-plugins/pull/275"},"comment":{"url":"https://api.github.com/repos/hhuijser/liferay-portal/issues/comments/106648575","html_url":"https://github.com/hhuijser/liferay-portal/pull/2360#issuecomment-106648575","issue_url":"https://api.github.com/repos/hhuijser/liferay-portal/issues/2360","id":106648575,"user":{"login":"hhuijser","id":862245,"avatar_url":"https://avatars.githubusercontent.com/u/862245?v=3","gravatar_id":"","url":"https://api.github.com/users/hhuijser","html_url":"https://github.com/hhuijser","followers_url":"https://api.github.com/users/hhuijser/followers","following_url":"https://api.github.com/users/hhuijser/following{/other_user}","gists_url":"https://api.github.com/users/hhuijser/gists{/gist_id}","starred_url":"https://api.github.com/users/hhuijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhuijser/subscriptions","organizations_url":"https://api.github.com/users/hhuijser/orgs","repos_url":"https://api.github.com/users/hhuijser/repos","events_url":"https://api.github.com/users/hhuijser/events{/privacy}","received_events_url":"https://api.github.com/users/hhuijser/received_events","type":"User","site_admin":false},"created_at":"2015-05-29T01:27:49Z","updated_at":"2015-05-29T01:27:49Z","body":"Sent to Jorge for further review: https://github.com/JorgeFerrer/liferay-portal/pull/543"}}