{"action":"created","comment":{"url":"https://api.github.com/repos/wikimedia/restbase/pulls/comments/48630321","id":48630321,"diff_hunk":"@@ -440,25 +441,25 @@ PSP.getFormat = function(format, restbase, req) {\n         }\n     }\n \n+    if (!self._okayToRerender(req)) {","path":"sys/parsoid.js","position":30,"original_position":30,"commit_id":"9f7b22f1fdccfe5bb4840086a096898f750c117f","original_commit_id":"9f7b22f1fdccfe5bb4840086a096898f750c117f","user":{"login":"gwicke","id":1225898,"avatar_url":"https://avatars.githubusercontent.com/u/1225898?v=3","gravatar_id":"","url":"https://api.github.com/users/gwicke","html_url":"https://github.com/gwicke","followers_url":"https://api.github.com/users/gwicke/followers","following_url":"https://api.github.com/users/gwicke/following{/other_user}","gists_url":"https://api.github.com/users/gwicke/gists{/gist_id}","starred_url":"https://api.github.com/users/gwicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwicke/subscriptions","organizations_url":"https://api.github.com/users/gwicke/orgs","repos_url":"https://api.github.com/users/gwicke/repos","events_url":"https://api.github.com/users/gwicke/events{/privacy}","received_events_url":"https://api.github.com/users/gwicke/received_events","type":"User","site_admin":false},"body":"This drops the no-cache check, rendering those pages completely unaccessible. Could you reinstate that check?","created_at":"2015-12-30T20:46:20Z","updated_at":"2015-12-30T20:46:20Z","html_url":"https://github.com/wikimedia/restbase/pull/461#discussion_r48630321","pull_request_url":"https://api.github.com/repos/wikimedia/restbase/pulls/461","_links":{"self":{"href":"https://api.github.com/repos/wikimedia/restbase/pulls/comments/48630321"},"html":{"href":"https://github.com/wikimedia/restbase/pull/461#discussion_r48630321"},"pull_request":{"href":"https://api.github.com/repos/wikimedia/restbase/pulls/461"}}},"pull_request":{"url":"https://api.github.com/repos/wikimedia/restbase/pulls/461","id":54824082,"html_url":"https://github.com/wikimedia/restbase/pull/461","diff_url":"https://github.com/wikimedia/restbase/pull/461.diff","patch_url":"https://github.com/wikimedia/restbase/pull/461.patch","issue_url":"https://api.github.com/repos/wikimedia/restbase/issues/461","number":461,"state":"open","locked":false,"title":"Parsoid: Do not query for html in case rerender is disabled","user":{"login":"Pchelolo","id":814754,"avatar_url":"https://avatars.githubusercontent.com/u/814754?v=3","gravatar_id":"","url":"https://api.github.com/users/Pchelolo","html_url":"https://github.com/Pchelolo","followers_url":"https://api.github.com/users/Pchelolo/followers","following_url":"https://api.github.com/users/Pchelolo/following{/other_user}","gists_url":"https://api.github.com/users/Pchelolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pchelolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pchelolo/subscriptions","organizations_url":"https://api.github.com/users/Pchelolo/orgs","repos_url":"https://api.github.com/users/Pchelolo/repos","events_url":"https://api.github.com/users/Pchelolo/events{/privacy}","received_events_url":"https://api.github.com/users/Pchelolo/received_events","type":"User","site_admin":false},"body":"Finally found the reason of EMERGENCY 'unhandled error' log messages. When the the serenader is disabled, we were still making a `get` request for html content, but didn't return that promise. But the request was made anyway, so if it failed, we got an unhandled rejection. And the result is ignored anyway, so we should check if the serenader is disabled prior to making the request for html.\r\n\r\ncc @wikimedia/services ","created_at":"2015-12-30T19:39:53Z","updated_at":"2015-12-30T20:46:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3af68e296e05a038c2cd1aefa91944c0e3d39c7d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/restbase/pulls/461/commits","review_comments_url":"https://api.github.com/repos/wikimedia/restbase/pulls/461/comments","review_comment_url":"https://api.github.com/repos/wikimedia/restbase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/restbase/issues/461/comments","statuses_url":"https://api.github.com/repos/wikimedia/restbase/statuses/9f7b22f1fdccfe5bb4840086a096898f750c117f","head":{"label":"Pchelolo:emergency","ref":"emergency","sha":"9f7b22f1fdccfe5bb4840086a096898f750c117f","user":{"login":"Pchelolo","id":814754,"avatar_url":"https://avatars.githubusercontent.com/u/814754?v=3","gravatar_id":"","url":"https://api.github.com/users/Pchelolo","html_url":"https://github.com/Pchelolo","followers_url":"https://api.github.com/users/Pchelolo/followers","following_url":"https://api.github.com/users/Pchelolo/following{/other_user}","gists_url":"https://api.github.com/users/Pchelolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pchelolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pchelolo/subscriptions","organizations_url":"https://api.github.com/users/Pchelolo/orgs","repos_url":"https://api.github.com/users/Pchelolo/repos","events_url":"https://api.github.com/users/Pchelolo/events{/privacy}","received_events_url":"https://api.github.com/users/Pchelolo/received_events","type":"User","site_admin":false},"repo":{"id":37933525,"name":"restbase","full_name":"Pchelolo/restbase","owner":{"login":"Pchelolo","id":814754,"avatar_url":"https://avatars.githubusercontent.com/u/814754?v=3","gravatar_id":"","url":"https://api.github.com/users/Pchelolo","html_url":"https://github.com/Pchelolo","followers_url":"https://api.github.com/users/Pchelolo/followers","following_url":"https://api.github.com/users/Pchelolo/following{/other_user}","gists_url":"https://api.github.com/users/Pchelolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pchelolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pchelolo/subscriptions","organizations_url":"https://api.github.com/users/Pchelolo/orgs","repos_url":"https://api.github.com/users/Pchelolo/repos","events_url":"https://api.github.com/users/Pchelolo/events{/privacy}","received_events_url":"https://api.github.com/users/Pchelolo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pchelolo/restbase","description":"Distributed storage with REST API & dispatcher for backend services","fork":true,"url":"https://api.github.com/repos/Pchelolo/restbase","forks_url":"https://api.github.com/repos/Pchelolo/restbase/forks","keys_url":"https://api.github.com/repos/Pchelolo/restbase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pchelolo/restbase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pchelolo/restbase/teams","hooks_url":"https://api.github.com/repos/Pchelolo/restbase/hooks","issue_events_url":"https://api.github.com/repos/Pchelolo/restbase/issues/events{/number}","events_url":"https://api.github.com/repos/Pchelolo/restbase/events","assignees_url":"https://api.github.com/repos/Pchelolo/restbase/assignees{/user}","branches_url":"https://api.github.com/repos/Pchelolo/restbase/branches{/branch}","tags_url":"https://api.github.com/repos/Pchelolo/restbase/tags","blobs_url":"https://api.github.com/repos/Pchelolo/restbase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pchelolo/restbase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pchelolo/restbase/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pchelolo/restbase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pchelolo/restbase/statuses/{sha}","languages_url":"https://api.github.com/repos/Pchelolo/restbase/languages","stargazers_url":"https://api.github.com/repos/Pchelolo/restbase/stargazers","contributors_url":"https://api.github.com/repos/Pchelolo/restbase/contributors","subscribers_url":"https://api.github.com/repos/Pchelolo/restbase/subscribers","subscription_url":"https://api.github.com/repos/Pchelolo/restbase/subscription","commits_url":"https://api.github.com/repos/Pchelolo/restbase/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pchelolo/restbase/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pchelolo/restbase/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pchelolo/restbase/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pchelolo/restbase/contents/{+path}","compare_url":"https://api.github.com/repos/Pchelolo/restbase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pchelolo/restbase/merges","archive_url":"https://api.github.com/repos/Pchelolo/restbase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pchelolo/restbase/downloads","issues_url":"https://api.github.com/repos/Pchelolo/restbase/issues{/number}","pulls_url":"https://api.github.com/repos/Pchelolo/restbase/pulls{/number}","milestones_url":"https://api.github.com/repos/Pchelolo/restbase/milestones{/number}","notifications_url":"https://api.github.com/repos/Pchelolo/restbase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pchelolo/restbase/labels{/name}","releases_url":"https://api.github.com/repos/Pchelolo/restbase/releases{/id}","created_at":"2015-06-23T17:22:56Z","updated_at":"2015-06-23T17:22:57Z","pushed_at":"2015-12-30T19:36:59Z","git_url":"git://github.com/Pchelolo/restbase.git","ssh_url":"git@github.com:Pchelolo/restbase.git","clone_url":"https://github.com/Pchelolo/restbase.git","svn_url":"https://github.com/Pchelolo/restbase","homepage":"https://www.mediawiki.org/wiki/RESTBase","size":2366,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"b6decf250bd41f4dc03e2c4b6fbba43eb116ccb3","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":19002414,"name":"restbase","full_name":"wikimedia/restbase","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/restbase","description":"Distributed storage with REST API & dispatcher for backend services","fork":false,"url":"https://api.github.com/repos/wikimedia/restbase","forks_url":"https://api.github.com/repos/wikimedia/restbase/forks","keys_url":"https://api.github.com/repos/wikimedia/restbase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/restbase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/restbase/teams","hooks_url":"https://api.github.com/repos/wikimedia/restbase/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/restbase/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/restbase/events","assignees_url":"https://api.github.com/repos/wikimedia/restbase/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/restbase/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/restbase/tags","blobs_url":"https://api.github.com/repos/wikimedia/restbase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/restbase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/restbase/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/restbase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/restbase/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/restbase/languages","stargazers_url":"https://api.github.com/repos/wikimedia/restbase/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/restbase/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/restbase/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/restbase/subscription","commits_url":"https://api.github.com/repos/wikimedia/restbase/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/restbase/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/restbase/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/restbase/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/restbase/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/restbase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/restbase/merges","archive_url":"https://api.github.com/repos/wikimedia/restbase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/restbase/downloads","issues_url":"https://api.github.com/repos/wikimedia/restbase/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/restbase/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/restbase/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/restbase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/restbase/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/restbase/releases{/id}","created_at":"2014-04-21T18:35:00Z","updated_at":"2015-12-22T04:55:05Z","pushed_at":"2015-12-30T19:39:53Z","git_url":"git://github.com/wikimedia/restbase.git","ssh_url":"git@github.com:wikimedia/restbase.git","clone_url":"https://github.com/wikimedia/restbase.git","svn_url":"https://github.com/wikimedia/restbase","homepage":"https://www.mediawiki.org/wiki/RESTBase","size":2502,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":8,"forks":29,"open_issues":8,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/restbase/pulls/461"},"html":{"href":"https://github.com/wikimedia/restbase/pull/461"},"issue":{"href":"https://api.github.com/repos/wikimedia/restbase/issues/461"},"comments":{"href":"https://api.github.com/repos/wikimedia/restbase/issues/461/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/restbase/pulls/461/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/restbase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/restbase/pulls/461/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/restbase/statuses/9f7b22f1fdccfe5bb4840086a096898f750c117f"}}}}