{"action":"created","comment":{"url":"https://api.github.com/repos/nodegit/nodegit/pulls/comments/42452328","id":42452328,"diff_hunk":"@@ -653,7 +653,11 @@ Repository.prototype.fetch = function(\n         return remote.disconnect();\n       });\n     })\n-    .then(finallyFn, finallyFn);\n+    .then(finallyFn)","path":"lib/repository.js","position":17,"original_position":17,"commit_id":"bee102b29aad115c3735b7059157b5af0279d843","original_commit_id":"bee102b29aad115c3735b7059157b5af0279d843","user":{"login":"johnhaley81","id":867780,"avatar_url":"https://avatars.githubusercontent.com/u/867780?v=3","gravatar_id":"","url":"https://api.github.com/users/johnhaley81","html_url":"https://github.com/johnhaley81","followers_url":"https://api.github.com/users/johnhaley81/followers","following_url":"https://api.github.com/users/johnhaley81/following{/other_user}","gists_url":"https://api.github.com/users/johnhaley81/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaley81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaley81/subscriptions","organizations_url":"https://api.github.com/users/johnhaley81/orgs","repos_url":"https://api.github.com/users/johnhaley81/repos","events_url":"https://api.github.com/users/johnhaley81/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaley81/received_events","type":"User","site_admin":false},"body":"We could simplify this further by using `.finally` in [then/promise](https://github.com/then/promise/blob/master/src/finally.js#L6-L16)","created_at":"2015-10-20T03:19:48Z","updated_at":"2015-10-20T03:19:48Z","html_url":"https://github.com/nodegit/nodegit/pull/755#discussion_r42452328","pull_request_url":"https://api.github.com/repos/nodegit/nodegit/pulls/755","_links":{"self":{"href":"https://api.github.com/repos/nodegit/nodegit/pulls/comments/42452328"},"html":{"href":"https://github.com/nodegit/nodegit/pull/755#discussion_r42452328"},"pull_request":{"href":"https://api.github.com/repos/nodegit/nodegit/pulls/755"}}},"pull_request":{"url":"https://api.github.com/repos/nodegit/nodegit/pulls/755","id":47763448,"html_url":"https://github.com/nodegit/nodegit/pull/755","diff_url":"https://github.com/nodegit/nodegit/pull/755.diff","patch_url":"https://github.com/nodegit/nodegit/pull/755.patch","issue_url":"https://api.github.com/repos/nodegit/nodegit/issues/755","number":755,"state":"open","locked":false,"title":"In repository.fetch don't swallow errors thrown by remote.fetch .","user":{"login":"jimCresswell","id":1314980,"avatar_url":"https://avatars.githubusercontent.com/u/1314980?v=3","gravatar_id":"","url":"https://api.github.com/users/jimCresswell","html_url":"https://github.com/jimCresswell","followers_url":"https://api.github.com/users/jimCresswell/followers","following_url":"https://api.github.com/users/jimCresswell/following{/other_user}","gists_url":"https://api.github.com/users/jimCresswell/gists{/gist_id}","starred_url":"https://api.github.com/users/jimCresswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimCresswell/subscriptions","organizations_url":"https://api.github.com/users/jimCresswell/orgs","repos_url":"https://api.github.com/users/jimCresswell/repos","events_url":"https://api.github.com/users/jimCresswell/events{/privacy}","received_events_url":"https://api.github.com/users/jimCresswell/received_events","type":"User","site_admin":false},"body":"In repository.fetch don't swallow errors thrown by remote.fetch, catch them, pass them to the callback and then rethrow them.\r\n\r\nThere is a failing test \"can reject fetching from private repository without valid credentials\" for remote.js but that is not caused by this work.\r\n\r\nHelps with https://github.com/nodegit/nodegit/issues/742 ","created_at":"2015-10-15T09:34:40Z","updated_at":"2015-10-20T03:19:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b9fd28fa73fe1caf6488d42bcc51e946f00b5fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodegit/nodegit/pulls/755/commits","review_comments_url":"https://api.github.com/repos/nodegit/nodegit/pulls/755/comments","review_comment_url":"https://api.github.com/repos/nodegit/nodegit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodegit/nodegit/issues/755/comments","statuses_url":"https://api.github.com/repos/nodegit/nodegit/statuses/bee102b29aad115c3735b7059157b5af0279d843","head":{"label":"jimCresswell:feature/dontSwallowErrorsInFetch","ref":"feature/dontSwallowErrorsInFetch","sha":"bee102b29aad115c3735b7059157b5af0279d843","user":{"login":"jimCresswell","id":1314980,"avatar_url":"https://avatars.githubusercontent.com/u/1314980?v=3","gravatar_id":"","url":"https://api.github.com/users/jimCresswell","html_url":"https://github.com/jimCresswell","followers_url":"https://api.github.com/users/jimCresswell/followers","following_url":"https://api.github.com/users/jimCresswell/following{/other_user}","gists_url":"https://api.github.com/users/jimCresswell/gists{/gist_id}","starred_url":"https://api.github.com/users/jimCresswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimCresswell/subscriptions","organizations_url":"https://api.github.com/users/jimCresswell/orgs","repos_url":"https://api.github.com/users/jimCresswell/repos","events_url":"https://api.github.com/users/jimCresswell/events{/privacy}","received_events_url":"https://api.github.com/users/jimCresswell/received_events","type":"User","site_admin":false},"repo":{"id":43879957,"name":"nodegit","full_name":"jimCresswell/nodegit","owner":{"login":"jimCresswell","id":1314980,"avatar_url":"https://avatars.githubusercontent.com/u/1314980?v=3","gravatar_id":"","url":"https://api.github.com/users/jimCresswell","html_url":"https://github.com/jimCresswell","followers_url":"https://api.github.com/users/jimCresswell/followers","following_url":"https://api.github.com/users/jimCresswell/following{/other_user}","gists_url":"https://api.github.com/users/jimCresswell/gists{/gist_id}","starred_url":"https://api.github.com/users/jimCresswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimCresswell/subscriptions","organizations_url":"https://api.github.com/users/jimCresswell/orgs","repos_url":"https://api.github.com/users/jimCresswell/repos","events_url":"https://api.github.com/users/jimCresswell/events{/privacy}","received_events_url":"https://api.github.com/users/jimCresswell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimCresswell/nodegit","description":"Native Node bindings to Git.","fork":true,"url":"https://api.github.com/repos/jimCresswell/nodegit","forks_url":"https://api.github.com/repos/jimCresswell/nodegit/forks","keys_url":"https://api.github.com/repos/jimCresswell/nodegit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimCresswell/nodegit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimCresswell/nodegit/teams","hooks_url":"https://api.github.com/repos/jimCresswell/nodegit/hooks","issue_events_url":"https://api.github.com/repos/jimCresswell/nodegit/issues/events{/number}","events_url":"https://api.github.com/repos/jimCresswell/nodegit/events","assignees_url":"https://api.github.com/repos/jimCresswell/nodegit/assignees{/user}","branches_url":"https://api.github.com/repos/jimCresswell/nodegit/branches{/branch}","tags_url":"https://api.github.com/repos/jimCresswell/nodegit/tags","blobs_url":"https://api.github.com/repos/jimCresswell/nodegit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimCresswell/nodegit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimCresswell/nodegit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimCresswell/nodegit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimCresswell/nodegit/statuses/{sha}","languages_url":"https://api.github.com/repos/jimCresswell/nodegit/languages","stargazers_url":"https://api.github.com/repos/jimCresswell/nodegit/stargazers","contributors_url":"https://api.github.com/repos/jimCresswell/nodegit/contributors","subscribers_url":"https://api.github.com/repos/jimCresswell/nodegit/subscribers","subscription_url":"https://api.github.com/repos/jimCresswell/nodegit/subscription","commits_url":"https://api.github.com/repos/jimCresswell/nodegit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimCresswell/nodegit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimCresswell/nodegit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimCresswell/nodegit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimCresswell/nodegit/contents/{+path}","compare_url":"https://api.github.com/repos/jimCresswell/nodegit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimCresswell/nodegit/merges","archive_url":"https://api.github.com/repos/jimCresswell/nodegit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimCresswell/nodegit/downloads","issues_url":"https://api.github.com/repos/jimCresswell/nodegit/issues{/number}","pulls_url":"https://api.github.com/repos/jimCresswell/nodegit/pulls{/number}","milestones_url":"https://api.github.com/repos/jimCresswell/nodegit/milestones{/number}","notifications_url":"https://api.github.com/repos/jimCresswell/nodegit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimCresswell/nodegit/labels{/name}","releases_url":"https://api.github.com/repos/jimCresswell/nodegit/releases{/id}","created_at":"2015-10-08T10:02:45Z","updated_at":"2015-10-08T10:02:48Z","pushed_at":"2015-10-15T09:31:18Z","git_url":"git://github.com/jimCresswell/nodegit.git","ssh_url":"git@github.com:jimCresswell/nodegit.git","clone_url":"https://github.com/jimCresswell/nodegit.git","svn_url":"https://github.com/jimCresswell/nodegit","homepage":"http://www.nodegit.org/","size":27328,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodegit:master","ref":"master","sha":"f7782b2909cc9c2254af05a480cc0b9432162a12","user":{"login":"nodegit","id":657068,"avatar_url":"https://avatars.githubusercontent.com/u/657068?v=3","gravatar_id":"","url":"https://api.github.com/users/nodegit","html_url":"https://github.com/nodegit","followers_url":"https://api.github.com/users/nodegit/followers","following_url":"https://api.github.com/users/nodegit/following{/other_user}","gists_url":"https://api.github.com/users/nodegit/gists{/gist_id}","starred_url":"https://api.github.com/users/nodegit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodegit/subscriptions","organizations_url":"https://api.github.com/users/nodegit/orgs","repos_url":"https://api.github.com/users/nodegit/repos","events_url":"https://api.github.com/users/nodegit/events{/privacy}","received_events_url":"https://api.github.com/users/nodegit/received_events","type":"Organization","site_admin":false},"repo":{"id":1383170,"name":"nodegit","full_name":"nodegit/nodegit","owner":{"login":"nodegit","id":657068,"avatar_url":"https://avatars.githubusercontent.com/u/657068?v=3","gravatar_id":"","url":"https://api.github.com/users/nodegit","html_url":"https://github.com/nodegit","followers_url":"https://api.github.com/users/nodegit/followers","following_url":"https://api.github.com/users/nodegit/following{/other_user}","gists_url":"https://api.github.com/users/nodegit/gists{/gist_id}","starred_url":"https://api.github.com/users/nodegit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodegit/subscriptions","organizations_url":"https://api.github.com/users/nodegit/orgs","repos_url":"https://api.github.com/users/nodegit/repos","events_url":"https://api.github.com/users/nodegit/events{/privacy}","received_events_url":"https://api.github.com/users/nodegit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodegit/nodegit","description":"Native Node bindings to Git.","fork":false,"url":"https://api.github.com/repos/nodegit/nodegit","forks_url":"https://api.github.com/repos/nodegit/nodegit/forks","keys_url":"https://api.github.com/repos/nodegit/nodegit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodegit/nodegit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodegit/nodegit/teams","hooks_url":"https://api.github.com/repos/nodegit/nodegit/hooks","issue_events_url":"https://api.github.com/repos/nodegit/nodegit/issues/events{/number}","events_url":"https://api.github.com/repos/nodegit/nodegit/events","assignees_url":"https://api.github.com/repos/nodegit/nodegit/assignees{/user}","branches_url":"https://api.github.com/repos/nodegit/nodegit/branches{/branch}","tags_url":"https://api.github.com/repos/nodegit/nodegit/tags","blobs_url":"https://api.github.com/repos/nodegit/nodegit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodegit/nodegit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodegit/nodegit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodegit/nodegit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodegit/nodegit/statuses/{sha}","languages_url":"https://api.github.com/repos/nodegit/nodegit/languages","stargazers_url":"https://api.github.com/repos/nodegit/nodegit/stargazers","contributors_url":"https://api.github.com/repos/nodegit/nodegit/contributors","subscribers_url":"https://api.github.com/repos/nodegit/nodegit/subscribers","subscription_url":"https://api.github.com/repos/nodegit/nodegit/subscription","commits_url":"https://api.github.com/repos/nodegit/nodegit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodegit/nodegit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodegit/nodegit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodegit/nodegit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodegit/nodegit/contents/{+path}","compare_url":"https://api.github.com/repos/nodegit/nodegit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodegit/nodegit/merges","archive_url":"https://api.github.com/repos/nodegit/nodegit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodegit/nodegit/downloads","issues_url":"https://api.github.com/repos/nodegit/nodegit/issues{/number}","pulls_url":"https://api.github.com/repos/nodegit/nodegit/pulls{/number}","milestones_url":"https://api.github.com/repos/nodegit/nodegit/milestones{/number}","notifications_url":"https://api.github.com/repos/nodegit/nodegit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodegit/nodegit/labels{/name}","releases_url":"https://api.github.com/repos/nodegit/nodegit/releases{/id}","created_at":"2011-02-18T16:42:46Z","updated_at":"2015-10-19T15:32:39Z","pushed_at":"2015-10-20T00:34:11Z","git_url":"git://github.com/nodegit/nodegit.git","ssh_url":"git@github.com:nodegit/nodegit.git","clone_url":"https://github.com/nodegit/nodegit.git","svn_url":"https://github.com/nodegit/nodegit","homepage":"http://www.nodegit.org/","size":26957,"stargazers_count":1350,"watchers_count":1350,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":193,"mirror_url":null,"open_issues_count":81,"forks":193,"open_issues":81,"watchers":1350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodegit/nodegit/pulls/755"},"html":{"href":"https://github.com/nodegit/nodegit/pull/755"},"issue":{"href":"https://api.github.com/repos/nodegit/nodegit/issues/755"},"comments":{"href":"https://api.github.com/repos/nodegit/nodegit/issues/755/comments"},"review_comments":{"href":"https://api.github.com/repos/nodegit/nodegit/pulls/755/comments"},"review_comment":{"href":"https://api.github.com/repos/nodegit/nodegit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodegit/nodegit/pulls/755/commits"},"statuses":{"href":"https://api.github.com/repos/nodegit/nodegit/statuses/bee102b29aad115c3735b7059157b5af0279d843"}}}}