{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/46768903","id":46768903,"diff_hunk":"@@ -666,7 +722,11 @@ def _predict(X, estimators):\n             y_pred = np.mean(y_pred, axis=2)\n \n     # Format shape\n-    y_pred = y_pred.reshape((n_epochs, predict_size))\n+    y_pred = y_pred.reshape((n_epochs_tmp, predict_size))\n+    if is_single_time_sample:\n+        y_pred = np.reshape(y_pred,\n+                            [n_epochs, n_times, y_pred.shape[-1]])","path":"mne/decoding/time_gen.py","position":168,"original_position":168,"commit_id":"5fa09c7a385ec3aae81c9d4692db9e1765bc616c","original_commit_id":"5fa09c7a385ec3aae81c9d4692db9e1765bc616c","user":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"body":"undo reshape.","created_at":"2015-12-06T10:45:47Z","updated_at":"2015-12-06T10:45:47Z","html_url":"https://github.com/mne-tools/mne-python/pull/2673#discussion_r46768903","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2673","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/46768903"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2673#discussion_r46768903"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2673"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2673","id":52777431,"html_url":"https://github.com/mne-tools/mne-python/pull/2673","diff_url":"https://github.com/mne-tools/mne-python/pull/2673.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/2673.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2673","number":2673,"state":"open","locked":false,"title":"ENH: vectorize predictions for the standard time gen case (window-size == 1)","user":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"body":"Joint [pair programming](https://en.wikipedia.org/wiki/Pair_programming) work with @fraimondo and @kingjr to make the time-gen considerably faster.\r\nIt looks as if we managed to impose a performance function that scales linearly with n_times. On MNE-Examples with we observed 6 seconds instead of 50 seconds single CPU time.\r\n\r\ncc @agramfort @jona-sassenhagen @cmoutard @jdsitt\r\n\r\nLet's see what is left to be done.","created_at":"2015-12-06T10:42:02Z","updated_at":"2015-12-06T10:45:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"206b1bd01a04969efe8f6045c815f73bf758cd7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2673/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2673/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2673/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/5fa09c7a385ec3aae81c9d4692db9e1765bc616c","head":{"label":"dengemann:time_gen_opt","ref":"time_gen_opt","sha":"5fa09c7a385ec3aae81c9d4692db9e1765bc616c","user":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"repo":{"id":5578745,"name":"mne-python","full_name":"dengemann/mne-python","owner":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dengemann/mne-python","description":"MNE scripting with Python","fork":true,"url":"https://api.github.com/repos/dengemann/mne-python","forks_url":"https://api.github.com/repos/dengemann/mne-python/forks","keys_url":"https://api.github.com/repos/dengemann/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dengemann/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dengemann/mne-python/teams","hooks_url":"https://api.github.com/repos/dengemann/mne-python/hooks","issue_events_url":"https://api.github.com/repos/dengemann/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/dengemann/mne-python/events","assignees_url":"https://api.github.com/repos/dengemann/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/dengemann/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/dengemann/mne-python/tags","blobs_url":"https://api.github.com/repos/dengemann/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dengemann/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dengemann/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dengemann/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dengemann/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dengemann/mne-python/languages","stargazers_url":"https://api.github.com/repos/dengemann/mne-python/stargazers","contributors_url":"https://api.github.com/repos/dengemann/mne-python/contributors","subscribers_url":"https://api.github.com/repos/dengemann/mne-python/subscribers","subscription_url":"https://api.github.com/repos/dengemann/mne-python/subscription","commits_url":"https://api.github.com/repos/dengemann/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dengemann/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dengemann/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dengemann/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dengemann/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/dengemann/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dengemann/mne-python/merges","archive_url":"https://api.github.com/repos/dengemann/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dengemann/mne-python/downloads","issues_url":"https://api.github.com/repos/dengemann/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/dengemann/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dengemann/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dengemann/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dengemann/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/dengemann/mne-python/releases{/id}","created_at":"2012-08-28T00:07:46Z","updated_at":"2014-09-16T13:18:12Z","pushed_at":"2015-12-06T10:38:27Z","git_url":"git://github.com/dengemann/mne-python.git","ssh_url":"git@github.com:dengemann/mne-python.git","clone_url":"https://github.com/dengemann/mne-python.git","svn_url":"https://github.com/dengemann/mne-python","homepage":"http://martinos.org/mne/","size":107247,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"09b4f9d58b42acfa0dbe4a7f5ba67e5a4661ea41","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","created_at":"2011-01-28T03:31:13Z","updated_at":"2015-12-02T16:18:24Z","pushed_at":"2015-12-06T10:42:03Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":168871,"stargazers_count":163,"watchers_count":163,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":184,"forks":150,"open_issues":184,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2673"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2673"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2673"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2673/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2673/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2673/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/5fa09c7a385ec3aae81c9d4692db9e1765bc616c"}}}}