{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/kue/issues/717","labels_url":"https://api.github.com/repos/Automattic/kue/issues/717/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/kue/issues/717/comments","events_url":"https://api.github.com/repos/Automattic/kue/issues/717/events","html_url":"https://github.com/Automattic/kue/pull/717","id":108191834,"number":717,"title":"Update dependencies","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars.githubusercontent.com/u/8822573?v=3","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/kue/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/Automattic/kue/labels/Optimization","name":"Optimization","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-09-24T18:53:45Z","updated_at":"2015-11-19T13:39:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/kue/pulls/717","html_url":"https://github.com/Automattic/kue/pull/717","diff_url":"https://github.com/Automattic/kue/pull/717.diff","patch_url":"https://github.com/Automattic/kue/pull/717.patch"},"body":"The dependencies were really old, so I thought I'll update them even though my main concern was just node-redis.\r\n\r\nThere are still two dependencies that have to be updated because they have breaking changes. Both are probably good for this library.\r\n\r\nOne is should that will throw on `'42' === 42` from version 4.x.x on and the other one is node-redis 2.0. In both cases the tests won't pass anymore. In some tests there are strings returned instead of numbers, so should breaks. And some other tests fail with node-redis 2.0, since it'll return errors that were earlier suppressed (`Uncaught Error: LPUSH can't be processed. The connection has already been closed.`).\r\n\r\nSo I highly recommend to check if everything is working as it should.\r\n\r\nI'm not even sure if everything works with the dependencies as I updated them, but at least the tests pass. I'm not sure what's with the build and test-tdd tasks in the Makefile btw."},"comment":{"url":"https://api.github.com/repos/Automattic/kue/issues/comments/158059121","html_url":"https://github.com/Automattic/kue/pull/717#issuecomment-158059121","issue_url":"https://api.github.com/repos/Automattic/kue/issues/717","id":158059121,"user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars.githubusercontent.com/u/8822573?v=3","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T13:39:37Z","updated_at":"2015-11-19T13:39:37Z","body":"@behrad ok, in that case I'd wait until this is merged. Do you want me to change anything else or is this ready to merge?"}}