{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/31350934","id":31350934,"diff_hunk":"@@ -227,7 +223,7 @@ describe('ReactChildren', function() {\n \n     var instance = (\n       <div>{\n-        [frag({\n+        [ReactFragment.create({","path":"src/isomorphic/children/__tests__/ReactChildren-test.js","position":16,"original_position":16,"commit_id":"9330414471c764b163c3d0f9160378c80bb04439","original_commit_id":"9330414471c764b163c3d0f9160378c80bb04439","user":{"login":"PiPeep","id":180404,"avatar_url":"https://avatars.githubusercontent.com/u/180404?v=3","gravatar_id":"","url":"https://api.github.com/users/PiPeep","html_url":"https://github.com/PiPeep","followers_url":"https://api.github.com/users/PiPeep/followers","following_url":"https://api.github.com/users/PiPeep/following{/other_user}","gists_url":"https://api.github.com/users/PiPeep/gists{/gist_id}","starred_url":"https://api.github.com/users/PiPeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiPeep/subscriptions","organizations_url":"https://api.github.com/users/PiPeep/orgs","repos_url":"https://api.github.com/users/PiPeep/repos","events_url":"https://api.github.com/users/PiPeep/events{/privacy}","received_events_url":"https://api.github.com/users/PiPeep/received_events","type":"User","site_admin":false},"body":"Later in the code, there's the test:\r\n\r\n```js\r\n   it('should warn if a fragment is accessed', function() {\r\n     spyOn(console, 'error');\r\n     var child = React.createElement('span');\r\n     var frag = ReactChildren.map([child, child], function(c) {\r\n       return c;\r\n     });\r\n     ...\r\n```\r\n\r\nWhich means there's shadowing. Since frag was just a stub method used in only two places, I figured it'd be better to just get rid of it rather than renaming things to avoid a conflict.","created_at":"2015-05-29T18:23:48Z","updated_at":"2015-05-29T18:23:48Z","html_url":"https://github.com/facebook/react/pull/3985#discussion_r31350934","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/3985","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/31350934"},"html":{"href":"https://github.com/facebook/react/pull/3985#discussion_r31350934"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/3985"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/3985","id":36530101,"html_url":"https://github.com/facebook/react/pull/3985","diff_url":"https://github.com/facebook/react/pull/3985.diff","patch_url":"https://github.com/facebook/react/pull/3985.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/3985","number":3985,"state":"open","locked":false,"title":"Enable linting for __tests__","user":{"login":"PiPeep","id":180404,"avatar_url":"https://avatars.githubusercontent.com/u/180404?v=3","gravatar_id":"","url":"https://api.github.com/users/PiPeep","html_url":"https://github.com/PiPeep","followers_url":"https://api.github.com/users/PiPeep/followers","following_url":"https://api.github.com/users/PiPeep/following{/other_user}","gists_url":"https://api.github.com/users/PiPeep/gists{/gist_id}","starred_url":"https://api.github.com/users/PiPeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiPeep/subscriptions","organizations_url":"https://api.github.com/users/PiPeep/orgs","repos_url":"https://api.github.com/users/PiPeep/repos","events_url":"https://api.github.com/users/PiPeep/events{/privacy}","received_events_url":"https://api.github.com/users/PiPeep/received_events","type":"User","site_admin":false},"body":"Closes #3971.\r\n\r\n> After #3968, the next thing we should do is start linting our tests.\r\n> Historically we've ignored them due to lack of parser compatibility.\r\n> But that shouldn't be a problem anymore. We may want to integrate\r\n> https://www.npmjs.com/package/eslint-plugin-react to more aggressively\r\n> lint our JSX in tests.\r\n\r\nI understand this diff touches a lot of stuff, so I tried to keep it to\r\na near-minimal set of changes to make eslint happy. If you're wondering\r\nwhy I changed something, let me know and I'll try to map it up to the\r\nrule that I was fixing it for.","created_at":"2015-05-29T18:03:25Z","updated_at":"2015-05-29T18:23:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a67b846f87c2babae9dbf59475f897613fc0da7","assignee":{"login":"zpao","id":8445,"avatar_url":"https://avatars.githubusercontent.com/u/8445?v=3","gravatar_id":"","url":"https://api.github.com/users/zpao","html_url":"https://github.com/zpao","followers_url":"https://api.github.com/users/zpao/followers","following_url":"https://api.github.com/users/zpao/following{/other_user}","gists_url":"https://api.github.com/users/zpao/gists{/gist_id}","starred_url":"https://api.github.com/users/zpao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpao/subscriptions","organizations_url":"https://api.github.com/users/zpao/orgs","repos_url":"https://api.github.com/users/zpao/repos","events_url":"https://api.github.com/users/zpao/events{/privacy}","received_events_url":"https://api.github.com/users/zpao/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/3985/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/3985/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/3985/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/9330414471c764b163c3d0f9160378c80bb04439","head":{"label":"PiPeep:eslint-tests","ref":"eslint-tests","sha":"9330414471c764b163c3d0f9160378c80bb04439","user":{"login":"PiPeep","id":180404,"avatar_url":"https://avatars.githubusercontent.com/u/180404?v=3","gravatar_id":"","url":"https://api.github.com/users/PiPeep","html_url":"https://github.com/PiPeep","followers_url":"https://api.github.com/users/PiPeep/followers","following_url":"https://api.github.com/users/PiPeep/following{/other_user}","gists_url":"https://api.github.com/users/PiPeep/gists{/gist_id}","starred_url":"https://api.github.com/users/PiPeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiPeep/subscriptions","organizations_url":"https://api.github.com/users/PiPeep/orgs","repos_url":"https://api.github.com/users/PiPeep/repos","events_url":"https://api.github.com/users/PiPeep/events{/privacy}","received_events_url":"https://api.github.com/users/PiPeep/received_events","type":"User","site_admin":false},"repo":{"id":36329454,"name":"react","full_name":"PiPeep/react","owner":{"login":"PiPeep","id":180404,"avatar_url":"https://avatars.githubusercontent.com/u/180404?v=3","gravatar_id":"","url":"https://api.github.com/users/PiPeep","html_url":"https://github.com/PiPeep","followers_url":"https://api.github.com/users/PiPeep/followers","following_url":"https://api.github.com/users/PiPeep/following{/other_user}","gists_url":"https://api.github.com/users/PiPeep/gists{/gist_id}","starred_url":"https://api.github.com/users/PiPeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PiPeep/subscriptions","organizations_url":"https://api.github.com/users/PiPeep/orgs","repos_url":"https://api.github.com/users/PiPeep/repos","events_url":"https://api.github.com/users/PiPeep/events{/privacy}","received_events_url":"https://api.github.com/users/PiPeep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PiPeep/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/PiPeep/react","forks_url":"https://api.github.com/repos/PiPeep/react/forks","keys_url":"https://api.github.com/repos/PiPeep/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PiPeep/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PiPeep/react/teams","hooks_url":"https://api.github.com/repos/PiPeep/react/hooks","issue_events_url":"https://api.github.com/repos/PiPeep/react/issues/events{/number}","events_url":"https://api.github.com/repos/PiPeep/react/events","assignees_url":"https://api.github.com/repos/PiPeep/react/assignees{/user}","branches_url":"https://api.github.com/repos/PiPeep/react/branches{/branch}","tags_url":"https://api.github.com/repos/PiPeep/react/tags","blobs_url":"https://api.github.com/repos/PiPeep/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PiPeep/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PiPeep/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/PiPeep/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PiPeep/react/statuses/{sha}","languages_url":"https://api.github.com/repos/PiPeep/react/languages","stargazers_url":"https://api.github.com/repos/PiPeep/react/stargazers","contributors_url":"https://api.github.com/repos/PiPeep/react/contributors","subscribers_url":"https://api.github.com/repos/PiPeep/react/subscribers","subscription_url":"https://api.github.com/repos/PiPeep/react/subscription","commits_url":"https://api.github.com/repos/PiPeep/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/PiPeep/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/PiPeep/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/PiPeep/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/PiPeep/react/contents/{+path}","compare_url":"https://api.github.com/repos/PiPeep/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PiPeep/react/merges","archive_url":"https://api.github.com/repos/PiPeep/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PiPeep/react/downloads","issues_url":"https://api.github.com/repos/PiPeep/react/issues{/number}","pulls_url":"https://api.github.com/repos/PiPeep/react/pulls{/number}","milestones_url":"https://api.github.com/repos/PiPeep/react/milestones{/number}","notifications_url":"https://api.github.com/repos/PiPeep/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PiPeep/react/labels{/name}","releases_url":"https://api.github.com/repos/PiPeep/react/releases{/id}","created_at":"2015-05-26T23:15:28Z","updated_at":"2015-05-26T23:15:31Z","pushed_at":"2015-05-29T18:02:01Z","git_url":"git://github.com/PiPeep/react.git","ssh_url":"git@github.com:PiPeep/react.git","clone_url":"https://github.com/PiPeep/react.git","svn_url":"https://github.com/PiPeep/react","homepage":"https://facebook.github.io/react/","size":59497,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"54e3f12877d3fed985dfcafd4e7afc41211bca14","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","created_at":"2013-05-24T16:15:54Z","updated_at":"2015-05-29T17:52:51Z","pushed_at":"2015-05-29T18:03:25Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":98048,"stargazers_count":22738,"watchers_count":22738,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3231,"mirror_url":null,"open_issues_count":555,"forks":3231,"open_issues":555,"watchers":22738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/3985"},"html":{"href":"https://github.com/facebook/react/pull/3985"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/3985"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/3985/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/3985/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/3985/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/9330414471c764b163c3d0f9160378c80bb04439"}}}}