{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/1594","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/1594/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/1594/comments","events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/1594/events","html_url":"https://github.com/ethereum/go-ethereum/pull/1594","id":99373596,"number":1594,"title":"faster hex-prefix codec and string -> []byte","user":{"login":"ebuchman","id":2300911,"avatar_url":"https://avatars.githubusercontent.com/u/2300911?v=3","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ethereum/go-ethereum/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ethereum/go-ethereum/labels/review","name":"review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/15","html_url":"https://github.com/ethereum/go-ethereum/milestones/1.0.2","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/15/labels","id":1236217,"number":15,"title":"1.0.2","description":"","creator":{"login":"obscuren","id":6264126,"avatar_url":"https://avatars.githubusercontent.com/u/6264126?v=3","gravatar_id":"","url":"https://api.github.com/users/obscuren","html_url":"https://github.com/obscuren","followers_url":"https://api.github.com/users/obscuren/followers","following_url":"https://api.github.com/users/obscuren/following{/other_user}","gists_url":"https://api.github.com/users/obscuren/gists{/gist_id}","starred_url":"https://api.github.com/users/obscuren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obscuren/subscriptions","organizations_url":"https://api.github.com/users/obscuren/orgs","repos_url":"https://api.github.com/users/obscuren/repos","events_url":"https://api.github.com/users/obscuren/events{/privacy}","received_events_url":"https://api.github.com/users/obscuren/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2015-08-01T15:50:05Z","updated_at":"2015-08-06T10:41:10Z","due_on":"2015-08-23T22:00:00Z","closed_at":null},"comments":3,"created_at":"2015-08-06T07:16:17Z","updated_at":"2015-08-06T15:21:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/1594","html_url":"https://github.com/ethereum/go-ethereum/pull/1594","diff_url":"https://github.com/ethereum/go-ethereum/pull/1594.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/1594.patch"},"body":"Some improvements to the hex-prefix encoder/decoder:\r\n- use []byte for all function arguments and returns (rather than strings, which are just being converted to []byte everywhere)\r\n- use integer based encoder/decoder rather than string concatenation and pushing through a hex codec\r\n\r\nBenchmarks:\r\n\r\nBefore the changes:\r\n----------------------------\r\nBatBuddha:trie$ go test --bench=Get\r\nPASS\r\nBenchmarkGets    1000000              1696 ns/op\r\nok      github.com/ethereum/go-ethereum/trie    1.913s\r\n\r\n\r\nWith this PR:\r\n----------------\r\nBatBuddha:trie$ go test --bench=Get\r\nPASS\r\nBenchmarkGets    2000000               966 ns/op\r\nok      github.com/ethereum/go-ethereum/trie    3.125s\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments/128409130","html_url":"https://github.com/ethereum/go-ethereum/pull/1594#issuecomment-128409130","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/1594","id":128409130,"user":{"login":"fjl","id":6915,"avatar_url":"https://avatars.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"created_at":"2015-08-06T15:21:52Z","updated_at":"2015-08-06T15:21:52Z","body":":+1: "}}