{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaQuantum/QuBase.jl/issues/22","labels_url":"https://api.github.com/repos/JuliaQuantum/QuBase.jl/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/JuliaQuantum/QuBase.jl/issues/22/comments","events_url":"https://api.github.com/repos/JuliaQuantum/QuBase.jl/issues/22/events","html_url":"https://github.com/JuliaQuantum/QuBase.jl/pull/22","id":65094805,"number":22,"title":"WIP : Spin Operators, Tests. WD : +,-,ops added.","user":{"login":"amitjamadagni","id":1212282,"avatar_url":"https://avatars.githubusercontent.com/u/1212282?v=3","gravatar_id":"","url":"https://api.github.com/users/amitjamadagni","html_url":"https://github.com/amitjamadagni","followers_url":"https://api.github.com/users/amitjamadagni/followers","following_url":"https://api.github.com/users/amitjamadagni/following{/other_user}","gists_url":"https://api.github.com/users/amitjamadagni/gists{/gist_id}","starred_url":"https://api.github.com/users/amitjamadagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitjamadagni/subscriptions","organizations_url":"https://api.github.com/users/amitjamadagni/orgs","repos_url":"https://api.github.com/users/amitjamadagni/repos","events_url":"https://api.github.com/users/amitjamadagni/events{/privacy}","received_events_url":"https://api.github.com/users/amitjamadagni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-03-29T20:53:31Z","updated_at":"2015-04-04T14:47:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaQuantum/QuBase.jl/pulls/22","html_url":"https://github.com/JuliaQuantum/QuBase.jl/pull/22","diff_url":"https://github.com/JuliaQuantum/QuBase.jl/pull/22.diff","patch_url":"https://github.com/JuliaQuantum/QuBase.jl/pull/22.patch"},"body":"WIP : \r\n- [x] Spin operators to be implemented\r\n- [ ] Tests\r\n\r\nImplemented \r\n- [x] +,- on QuArray, CTranspose\r\n- [x] momentm_op, position_op added. \r\n"},"comment":{"url":"https://api.github.com/repos/JuliaQuantum/QuBase.jl/issues/comments/89590250","html_url":"https://github.com/JuliaQuantum/QuBase.jl/pull/22#issuecomment-89590250","issue_url":"https://api.github.com/repos/JuliaQuantum/QuBase.jl/issues/22","id":89590250,"user":{"login":"jrevels","id":3277443,"avatar_url":"https://avatars.githubusercontent.com/u/3277443?v=3","gravatar_id":"","url":"https://api.github.com/users/jrevels","html_url":"https://github.com/jrevels","followers_url":"https://api.github.com/users/jrevels/followers","following_url":"https://api.github.com/users/jrevels/following{/other_user}","gists_url":"https://api.github.com/users/jrevels/gists{/gist_id}","starred_url":"https://api.github.com/users/jrevels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrevels/subscriptions","organizations_url":"https://api.github.com/users/jrevels/orgs","repos_url":"https://api.github.com/users/jrevels/repos","events_url":"https://api.github.com/users/jrevels/events{/privacy}","received_events_url":"https://api.github.com/users/jrevels/received_events","type":"User","site_admin":false},"created_at":"2015-04-04T14:47:13Z","updated_at":"2015-04-04T14:47:13Z","body":"I can understand passing the numerator or denominator separately.\r\n\r\nBut if we do go for allowing a single number argument for spin, I think it would be odd for user to enter something like `spin_jx(1/2)` and have it throw an error.\r\n\r\nI agree that we should test for edge cases like @acroy (and maybe start increasing/decreasing precision until we it hits a failure mode). I'd do it myself but I'm in transit right now..."}}