{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar/pulls/comments/46424891","id":46424891,"diff_hunk":"@@ -58,19 +55,41 @@ def usage()\n FileUtils.mkdir log_path unless File.directory? log_path\n log = File.join log_path, \"component_install.log\"\n \n+install_lib_path = Pathname.new(\"/var/lib/crowbar/install\")\n+installation_steps_path = install_lib_path.join(\"installation_steps\")\n+if installation_steps_path.exist?\n+  steps = installation_steps_path.readlines.map do |step|\n+    step.split.first\n+  end\n+  crowbar_installed_barclamps = steps.include? \"barclamp_install\"\n+else\n+  crowbar_installed_barclamps = false\n+end\n+crowbar_installed = install_lib_path.join(\"crowbar-installed-ok\").exist?\n+\n+do_chef = crowbar_installed_barclamps || crowbar_installed\n+\n barclamp_yml_files = Array.new\n component_paths = Array.new\n ARGV.each do |src|\n   debug \"src: #{src}\"\n+  component_dir = nil","path":"scripts/barclamp_install.rb","position":52,"original_position":52,"commit_id":"988c9936542dc53fbe4b344f1d64e695359e0230","original_commit_id":"988c9936542dc53fbe4b344f1d64e695359e0230","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"will it then not throw an exception in line 85?","created_at":"2015-12-02T15:09:11Z","updated_at":"2015-12-02T15:09:11Z","html_url":"https://github.com/crowbar/crowbar/pull/2195#discussion_r46424891","pull_request_url":"https://api.github.com/repos/crowbar/crowbar/pulls/2195","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/comments/46424891"},"html":{"href":"https://github.com/crowbar/crowbar/pull/2195#discussion_r46424891"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2195"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar/pulls/2195","id":52364773,"html_url":"https://github.com/crowbar/crowbar/pull/2195","diff_url":"https://github.com/crowbar/crowbar/pull/2195.diff","patch_url":"https://github.com/crowbar/crowbar/pull/2195.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar/issues/2195","number":2195,"state":"open","locked":false,"title":"Various fixes / cleanups / simplifications for barclamp_install","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"Note that gating cannot be green as this requires some changes in the packaging (the yml files and manifests need to be put directly in the right location by the packages, which makes sense anyway)","created_at":"2015-12-02T08:08:44Z","updated_at":"2015-12-02T15:09:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8435b1b187fc4916c035a2f2f26368aade3801ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar/pulls/2195/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar/pulls/2195/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar/issues/2195/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar/statuses/988c9936542dc53fbe4b344f1d64e695359e0230","head":{"label":"vuntz:barclamp-install-fixes","ref":"barclamp-install-fixes","sha":"988c9936542dc53fbe4b344f1d64e695359e0230","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"repo":{"id":10238607,"name":"crowbar","full_name":"vuntz/crowbar","owner":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vuntz/crowbar","description":"Cloud Installer (originated by Dell)","fork":true,"url":"https://api.github.com/repos/vuntz/crowbar","forks_url":"https://api.github.com/repos/vuntz/crowbar/forks","keys_url":"https://api.github.com/repos/vuntz/crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuntz/crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuntz/crowbar/teams","hooks_url":"https://api.github.com/repos/vuntz/crowbar/hooks","issue_events_url":"https://api.github.com/repos/vuntz/crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/vuntz/crowbar/events","assignees_url":"https://api.github.com/repos/vuntz/crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/vuntz/crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/vuntz/crowbar/tags","blobs_url":"https://api.github.com/repos/vuntz/crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuntz/crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuntz/crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuntz/crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuntz/crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/vuntz/crowbar/languages","stargazers_url":"https://api.github.com/repos/vuntz/crowbar/stargazers","contributors_url":"https://api.github.com/repos/vuntz/crowbar/contributors","subscribers_url":"https://api.github.com/repos/vuntz/crowbar/subscribers","subscription_url":"https://api.github.com/repos/vuntz/crowbar/subscription","commits_url":"https://api.github.com/repos/vuntz/crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuntz/crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuntz/crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuntz/crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuntz/crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/vuntz/crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuntz/crowbar/merges","archive_url":"https://api.github.com/repos/vuntz/crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuntz/crowbar/downloads","issues_url":"https://api.github.com/repos/vuntz/crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/vuntz/crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/vuntz/crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/vuntz/crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuntz/crowbar/labels{/name}","releases_url":"https://api.github.com/repos/vuntz/crowbar/releases{/id}","created_at":"2013-05-23T07:47:58Z","updated_at":"2014-02-26T11:44:17Z","pushed_at":"2015-12-02T14:57:05Z","git_url":"git://github.com/vuntz/crowbar.git","ssh_url":"git@github.com:vuntz/crowbar.git","clone_url":"https://github.com/vuntz/crowbar.git","svn_url":"https://github.com/vuntz/crowbar","homepage":"https://github.com/crowbar/crowbar/wiki","size":39382,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"0be0c5741bd559ecacfb5193680d2f8eaadb9712","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2040151,"name":"crowbar","full_name":"crowbar/crowbar","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar","description":"Cloud Operations Platform","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar","forks_url":"https://api.github.com/repos/crowbar/crowbar/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar/releases{/id}","created_at":"2011-07-13T05:02:51Z","updated_at":"2015-11-26T09:30:05Z","pushed_at":"2015-12-02T14:57:07Z","git_url":"git://github.com/crowbar/crowbar.git","ssh_url":"git@github.com:crowbar/crowbar.git","clone_url":"https://github.com/crowbar/crowbar.git","svn_url":"https://github.com/crowbar/crowbar","homepage":"https://github.com/crowbar/crowbar","size":33073,"stargazers_count":693,"watchers_count":693,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"open_issues_count":49,"forks":276,"open_issues":49,"watchers":693,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2195"},"html":{"href":"https://github.com/crowbar/crowbar/pull/2195"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar/issues/2195"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar/issues/2195/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2195/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2195/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar/statuses/988c9936542dc53fbe4b344f1d64e695359e0230"}}}}