{"action":"created","issue":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/412","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/412/labels{/name}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/412/comments","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/412/events","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/412","id":88789746,"number":412,"title":"Add Water Quality chart/table to model output","user":{"login":"lewfish","id":1896461,"avatar_url":"https://avatars.githubusercontent.com/u/1896461?v=3","gravatar_id":"","url":"https://api.github.com/users/lewfish","html_url":"https://github.com/lewfish","followers_url":"https://api.github.com/users/lewfish/followers","following_url":"https://api.github.com/users/lewfish/following{/other_user}","gists_url":"https://api.github.com/users/lewfish/gists{/gist_id}","starred_url":"https://api.github.com/users/lewfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewfish/subscriptions","organizations_url":"https://api.github.com/users/lewfish/orgs","repos_url":"https://api.github.com/users/lewfish/repos","events_url":"https://api.github.com/users/lewfish/events{/privacy}","received_events_url":"https://api.github.com/users/lewfish/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels/in%20review","name":"in review","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"mmcfarland","id":1014341,"avatar_url":"https://avatars.githubusercontent.com/u/1014341?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcfarland","html_url":"https://github.com/mmcfarland","followers_url":"https://api.github.com/users/mmcfarland/followers","following_url":"https://api.github.com/users/mmcfarland/following{/other_user}","gists_url":"https://api.github.com/users/mmcfarland/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcfarland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcfarland/subscriptions","organizations_url":"https://api.github.com/users/mmcfarland/orgs","repos_url":"https://api.github.com/users/mmcfarland/repos","events_url":"https://api.github.com/users/mmcfarland/events{/privacy}","received_events_url":"https://api.github.com/users/mmcfarland/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-06-16T17:28:15Z","updated_at":"2015-06-16T18:51:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/412","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/412","diff_url":"https://github.com/WikiWatershed/model-my-watershed/pull/412.diff","patch_url":"https://github.com/WikiWatershed/model-my-watershed/pull/412.patch"},"body":"To test:\r\n * Restart celery\r\n * Create a new project\r\n * Make modifications\r\n * The Runoff and Water Quality tabs should show spinners and then show results. The Water Quality tab should show a table and bar chart with four items.\r\n * Try hitting reload to make sure it works with a saved project.\r\n\r\nKnown Issues:\r\n * An extra space above the chart (only visible on high-contrast screens).\r\n![screen shot 2015-06-16 at 12 29 00 pm](https://cloud.githubusercontent.com/assets/1896461/8189701/17f7bc4e-142c-11e5-8a96-93fbd7346a24.png)\r\n\r\n * The ids for the Runoff and Water Quality view els are the same for each scenario because these views do not have access to the scenario they are part of. This isn't causing a problem, but generally speaking, ids should be unique.\r\n * The code/functionality for the Water Quality view is similar to that of the Analyze view. In the future, we might want to refactor these to exploit commonalities. \r\n\r\nConnects #261"},"comment":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments/112527381","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/412#issuecomment-112527381","issue_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/412","id":112527381,"user":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"created_at":"2015-06-16T18:51:35Z","updated_at":"2015-06-16T18:51:35Z","body":"It might be a nice idea to implement the loading animations defined in #80 here as well, but that can also be pushed into a later PR.\r\n\r\nThe numbers look really unwieldy in their current representation:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1430060/8191547/b144ae0c-1436-11e5-84b1-a58949178bf0.png)\r\n\r\nConsider rounding them to an acceptable number, or using scientific notation if accuracy is desired.\r\n\r\nThe \"Pounds\" unit label on the vertical axis is obstructed by the bar chart on small screens.\r\n\r\nThe bar chart label \"Biochemical Oxygen Demand\" is too wide and runs into the next \"Total Suspended Solids\" on small screens. Consider setting a max-width or percentage width for those labels and wrap text to ensure they don't overlap."}}