{"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/stepanhruda/STPTransitions/pulls/14","id":27115439,"html_url":"https://github.com/stepanhruda/STPTransitions/pull/14","diff_url":"https://github.com/stepanhruda/STPTransitions/pull/14.diff","patch_url":"https://github.com/stepanhruda/STPTransitions/pull/14.patch","issue_url":"https://api.github.com/repos/stepanhruda/STPTransitions/issues/14","number":14,"state":"open","locked":false,"title":"Use UIPresentationController controller for iOS8 SDK support and only apply rotation fix on iOS7 devices","user":{"login":"jamesjn","id":911842,"avatar_url":"https://avatars.githubusercontent.com/u/911842?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesjn","html_url":"https://github.com/jamesjn","followers_url":"https://api.github.com/users/jamesjn/followers","following_url":"https://api.github.com/users/jamesjn/following{/other_user}","gists_url":"https://api.github.com/users/jamesjn/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesjn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesjn/subscriptions","organizations_url":"https://api.github.com/users/jamesjn/orgs","repos_url":"https://api.github.com/users/jamesjn/repos","events_url":"https://api.github.com/users/jamesjn/events{/privacy}","received_events_url":"https://api.github.com/users/jamesjn/received_events","type":"User","site_admin":false},"body":"When using the iOS8 SDK, the `UIModalPresentationCustom` presentation style requires a custom `UIPresentationController` to be used for the view that will be transitioned to for the view to be added on to the view hierarchy after the transition.\r\n\r\nFrom the iOS8 SDK [documentation](https://developer.apple.com/library/prerelease/ios/documentation/UIKit/Reference/UIViewControllerTransitioningDelegate_protocol/index.html#//apple_ref/occ/intfm/UIViewControllerTransitioningDelegate/presentationControllerForPresentedViewController:presentingViewController:sourceViewController:) for the `UIViewControllerTransitioningDelegate` `presentationControllerForPresentedViewController:presentingViewController:sourceViewController:`:\r\n'If you do not implement this method, or if your implementation of this method returns nil, the system uses a default presentation controller object. The default presentation controller does not add any views or content to the view hierarchy.'\r\n\r\nAlso, `needsRotationFixForModals` should be set to `YES` only if the iOS version is `7`.  iOS8 properly handles the view rotations properly and if the rotation fix is applied on iOS8, the rotations will be incorrect.","created_at":"2015-01-09T17:31:49Z","updated_at":"2015-01-09T17:31:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stepanhruda/STPTransitions/pulls/14/commits","review_comments_url":"https://api.github.com/repos/stepanhruda/STPTransitions/pulls/14/comments","review_comment_url":"https://api.github.com/repos/stepanhruda/STPTransitions/pulls/comments/{number}","comments_url":"https://api.github.com/repos/stepanhruda/STPTransitions/issues/14/comments","statuses_url":"https://api.github.com/repos/stepanhruda/STPTransitions/statuses/699613ad93b223340a6a53f6397d49d55eb2eabd","head":{"label":"jamesjn:use-presentation-controller-for-ios8-sdk-support","ref":"use-presentation-controller-for-ios8-sdk-support","sha":"699613ad93b223340a6a53f6397d49d55eb2eabd","user":{"login":"jamesjn","id":911842,"avatar_url":"https://avatars.githubusercontent.com/u/911842?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesjn","html_url":"https://github.com/jamesjn","followers_url":"https://api.github.com/users/jamesjn/followers","following_url":"https://api.github.com/users/jamesjn/following{/other_user}","gists_url":"https://api.github.com/users/jamesjn/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesjn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesjn/subscriptions","organizations_url":"https://api.github.com/users/jamesjn/orgs","repos_url":"https://api.github.com/users/jamesjn/repos","events_url":"https://api.github.com/users/jamesjn/events{/privacy}","received_events_url":"https://api.github.com/users/jamesjn/received_events","type":"User","site_admin":false},"repo":{"id":28604595,"name":"STPTransitions","full_name":"jamesjn/STPTransitions","owner":{"login":"jamesjn","id":911842,"avatar_url":"https://avatars.githubusercontent.com/u/911842?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesjn","html_url":"https://github.com/jamesjn","followers_url":"https://api.github.com/users/jamesjn/followers","following_url":"https://api.github.com/users/jamesjn/following{/other_user}","gists_url":"https://api.github.com/users/jamesjn/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesjn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesjn/subscriptions","organizations_url":"https://api.github.com/users/jamesjn/orgs","repos_url":"https://api.github.com/users/jamesjn/repos","events_url":"https://api.github.com/users/jamesjn/events{/privacy}","received_events_url":"https://api.github.com/users/jamesjn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamesjn/STPTransitions","description":"Unified, easy API for custom iOS view controller transitioning","fork":true,"url":"https://api.github.com/repos/jamesjn/STPTransitions","forks_url":"https://api.github.com/repos/jamesjn/STPTransitions/forks","keys_url":"https://api.github.com/repos/jamesjn/STPTransitions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamesjn/STPTransitions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamesjn/STPTransitions/teams","hooks_url":"https://api.github.com/repos/jamesjn/STPTransitions/hooks","issue_events_url":"https://api.github.com/repos/jamesjn/STPTransitions/issues/events{/number}","events_url":"https://api.github.com/repos/jamesjn/STPTransitions/events","assignees_url":"https://api.github.com/repos/jamesjn/STPTransitions/assignees{/user}","branches_url":"https://api.github.com/repos/jamesjn/STPTransitions/branches{/branch}","tags_url":"https://api.github.com/repos/jamesjn/STPTransitions/tags","blobs_url":"https://api.github.com/repos/jamesjn/STPTransitions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamesjn/STPTransitions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamesjn/STPTransitions/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamesjn/STPTransitions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamesjn/STPTransitions/statuses/{sha}","languages_url":"https://api.github.com/repos/jamesjn/STPTransitions/languages","stargazers_url":"https://api.github.com/repos/jamesjn/STPTransitions/stargazers","contributors_url":"https://api.github.com/repos/jamesjn/STPTransitions/contributors","subscribers_url":"https://api.github.com/repos/jamesjn/STPTransitions/subscribers","subscription_url":"https://api.github.com/repos/jamesjn/STPTransitions/subscription","commits_url":"https://api.github.com/repos/jamesjn/STPTransitions/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamesjn/STPTransitions/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamesjn/STPTransitions/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamesjn/STPTransitions/issues/comments/{number}","contents_url":"https://api.github.com/repos/jamesjn/STPTransitions/contents/{+path}","compare_url":"https://api.github.com/repos/jamesjn/STPTransitions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamesjn/STPTransitions/merges","archive_url":"https://api.github.com/repos/jamesjn/STPTransitions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamesjn/STPTransitions/downloads","issues_url":"https://api.github.com/repos/jamesjn/STPTransitions/issues{/number}","pulls_url":"https://api.github.com/repos/jamesjn/STPTransitions/pulls{/number}","milestones_url":"https://api.github.com/repos/jamesjn/STPTransitions/milestones{/number}","notifications_url":"https://api.github.com/repos/jamesjn/STPTransitions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamesjn/STPTransitions/labels{/name}","releases_url":"https://api.github.com/repos/jamesjn/STPTransitions/releases{/id}","created_at":"2014-12-29T20:03:21Z","updated_at":"2014-12-29T20:03:21Z","pushed_at":"2015-01-09T17:27:55Z","git_url":"git://github.com/jamesjn/STPTransitions.git","ssh_url":"git@github.com:jamesjn/STPTransitions.git","clone_url":"https://github.com/jamesjn/STPTransitions.git","svn_url":"https://github.com/jamesjn/STPTransitions","homepage":"https://twitter.com/stepanhruda","size":205,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stepanhruda:master","ref":"master","sha":"b65b3c6eba19f90850f30ee1be7af2622b3cd2d8","user":{"login":"stepanhruda","id":2835783,"avatar_url":"https://avatars.githubusercontent.com/u/2835783?v=3","gravatar_id":"","url":"https://api.github.com/users/stepanhruda","html_url":"https://github.com/stepanhruda","followers_url":"https://api.github.com/users/stepanhruda/followers","following_url":"https://api.github.com/users/stepanhruda/following{/other_user}","gists_url":"https://api.github.com/users/stepanhruda/gists{/gist_id}","starred_url":"https://api.github.com/users/stepanhruda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepanhruda/subscriptions","organizations_url":"https://api.github.com/users/stepanhruda/orgs","repos_url":"https://api.github.com/users/stepanhruda/repos","events_url":"https://api.github.com/users/stepanhruda/events{/privacy}","received_events_url":"https://api.github.com/users/stepanhruda/received_events","type":"User","site_admin":false},"repo":{"id":14403000,"name":"STPTransitions","full_name":"stepanhruda/STPTransitions","owner":{"login":"stepanhruda","id":2835783,"avatar_url":"https://avatars.githubusercontent.com/u/2835783?v=3","gravatar_id":"","url":"https://api.github.com/users/stepanhruda","html_url":"https://github.com/stepanhruda","followers_url":"https://api.github.com/users/stepanhruda/followers","following_url":"https://api.github.com/users/stepanhruda/following{/other_user}","gists_url":"https://api.github.com/users/stepanhruda/gists{/gist_id}","starred_url":"https://api.github.com/users/stepanhruda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepanhruda/subscriptions","organizations_url":"https://api.github.com/users/stepanhruda/orgs","repos_url":"https://api.github.com/users/stepanhruda/repos","events_url":"https://api.github.com/users/stepanhruda/events{/privacy}","received_events_url":"https://api.github.com/users/stepanhruda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stepanhruda/STPTransitions","description":"Unified, easy API for custom iOS view controller transitioning","fork":false,"url":"https://api.github.com/repos/stepanhruda/STPTransitions","forks_url":"https://api.github.com/repos/stepanhruda/STPTransitions/forks","keys_url":"https://api.github.com/repos/stepanhruda/STPTransitions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stepanhruda/STPTransitions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stepanhruda/STPTransitions/teams","hooks_url":"https://api.github.com/repos/stepanhruda/STPTransitions/hooks","issue_events_url":"https://api.github.com/repos/stepanhruda/STPTransitions/issues/events{/number}","events_url":"https://api.github.com/repos/stepanhruda/STPTransitions/events","assignees_url":"https://api.github.com/repos/stepanhruda/STPTransitions/assignees{/user}","branches_url":"https://api.github.com/repos/stepanhruda/STPTransitions/branches{/branch}","tags_url":"https://api.github.com/repos/stepanhruda/STPTransitions/tags","blobs_url":"https://api.github.com/repos/stepanhruda/STPTransitions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stepanhruda/STPTransitions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stepanhruda/STPTransitions/git/refs{/sha}","trees_url":"https://api.github.com/repos/stepanhruda/STPTransitions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stepanhruda/STPTransitions/statuses/{sha}","languages_url":"https://api.github.com/repos/stepanhruda/STPTransitions/languages","stargazers_url":"https://api.github.com/repos/stepanhruda/STPTransitions/stargazers","contributors_url":"https://api.github.com/repos/stepanhruda/STPTransitions/contributors","subscribers_url":"https://api.github.com/repos/stepanhruda/STPTransitions/subscribers","subscription_url":"https://api.github.com/repos/stepanhruda/STPTransitions/subscription","commits_url":"https://api.github.com/repos/stepanhruda/STPTransitions/commits{/sha}","git_commits_url":"https://api.github.com/repos/stepanhruda/STPTransitions/git/commits{/sha}","comments_url":"https://api.github.com/repos/stepanhruda/STPTransitions/comments{/number}","issue_comment_url":"https://api.github.com/repos/stepanhruda/STPTransitions/issues/comments/{number}","contents_url":"https://api.github.com/repos/stepanhruda/STPTransitions/contents/{+path}","compare_url":"https://api.github.com/repos/stepanhruda/STPTransitions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stepanhruda/STPTransitions/merges","archive_url":"https://api.github.com/repos/stepanhruda/STPTransitions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stepanhruda/STPTransitions/downloads","issues_url":"https://api.github.com/repos/stepanhruda/STPTransitions/issues{/number}","pulls_url":"https://api.github.com/repos/stepanhruda/STPTransitions/pulls{/number}","milestones_url":"https://api.github.com/repos/stepanhruda/STPTransitions/milestones{/number}","notifications_url":"https://api.github.com/repos/stepanhruda/STPTransitions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stepanhruda/STPTransitions/labels{/name}","releases_url":"https://api.github.com/repos/stepanhruda/STPTransitions/releases{/id}","created_at":"2013-11-14T18:10:49Z","updated_at":"2015-01-09T10:56:53Z","pushed_at":"2014-09-04T11:43:48Z","git_url":"git://github.com/stepanhruda/STPTransitions.git","ssh_url":"git@github.com:stepanhruda/STPTransitions.git","clone_url":"https://github.com/stepanhruda/STPTransitions.git","svn_url":"https://github.com/stepanhruda/STPTransitions","homepage":"https://twitter.com/stepanhruda","size":639,"stargazers_count":311,"watchers_count":311,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":2,"forks":22,"open_issues":2,"watchers":311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stepanhruda/STPTransitions/pulls/14"},"html":{"href":"https://github.com/stepanhruda/STPTransitions/pull/14"},"issue":{"href":"https://api.github.com/repos/stepanhruda/STPTransitions/issues/14"},"comments":{"href":"https://api.github.com/repos/stepanhruda/STPTransitions/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/stepanhruda/STPTransitions/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/stepanhruda/STPTransitions/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/stepanhruda/STPTransitions/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/stepanhruda/STPTransitions/statuses/699613ad93b223340a6a53f6397d49d55eb2eabd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":39,"deletions":2,"changed_files":4}}