{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/46507581","id":46507581,"diff_hunk":"@@ -53,9 +63,14 @@\n   /** The journal writer for when the master is the leader. */\n   private JournalWriter mJournalWriter = null;\n \n-  protected MasterBase(Journal journal, ExecutorService executorService) {\n+  /**\n+   * @param journal the journal to use for tracking master operations\n+   * @param numThreads the number of threads to use in the Master's {@link ExecutorService}\n+   * @param executorService the name pattern for the executor service to use for asynchronous tasks","path":"servers/src/main/java/tachyon/master/MasterBase.java","position":47,"original_position":47,"commit_id":"ab94d11ee21d541faa175fe7cb581fdfedd71b26","original_commit_id":"ab94d11ee21d541faa175fe7cb581fdfedd71b26","user":{"login":"yupeng9","id":13425258,"avatar_url":"https://avatars.githubusercontent.com/u/13425258?v=3","gravatar_id":"","url":"https://api.github.com/users/yupeng9","html_url":"https://github.com/yupeng9","followers_url":"https://api.github.com/users/yupeng9/followers","following_url":"https://api.github.com/users/yupeng9/following{/other_user}","gists_url":"https://api.github.com/users/yupeng9/gists{/gist_id}","starred_url":"https://api.github.com/users/yupeng9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupeng9/subscriptions","organizations_url":"https://api.github.com/users/yupeng9/orgs","repos_url":"https://api.github.com/users/yupeng9/repos","events_url":"https://api.github.com/users/yupeng9/events{/privacy}","received_events_url":"https://api.github.com/users/yupeng9/received_events","type":"User","site_admin":false},"body":"This param is no longer needed.","created_at":"2015-12-03T02:54:16Z","updated_at":"2015-12-03T02:54:16Z","html_url":"https://github.com/amplab/tachyon/pull/2191#discussion_r46507581","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/2191","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/46507581"},"html":{"href":"https://github.com/amplab/tachyon/pull/2191#discussion_r46507581"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2191"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/2191","id":52339827,"html_url":"https://github.com/amplab/tachyon/pull/2191","diff_url":"https://github.com/amplab/tachyon/pull/2191.diff","patch_url":"https://github.com/amplab/tachyon/pull/2191.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/2191","number":2191,"state":"open","locked":false,"title":"[TACHYON-1386] Shut down executors when Masters are stopped","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"https://tachyon.atlassian.net/browse/TACHYON-1386\r\n\r\nThis PR moves creation of `ExecutorService`s into `MasterBase` and adds their shutdown to `MasterBase.stop()`. ","created_at":"2015-12-02T00:59:35Z","updated_at":"2015-12-03T02:54:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6d1bc8f5abeb1f2914a13995f2bc361402d8b37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/2191/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/2191/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/2191/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/ab94d11ee21d541faa175fe7cb581fdfedd71b26","head":{"label":"aaudiber:shutdown-executors","ref":"shutdown-executors","sha":"ab94d11ee21d541faa175fe7cb581fdfedd71b26","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"repo":{"id":42785459,"name":"tachyon","full_name":"aaudiber/tachyon","owner":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaudiber/tachyon","description":"Memory Centric Reliable Distributed Storage","fork":true,"url":"https://api.github.com/repos/aaudiber/tachyon","forks_url":"https://api.github.com/repos/aaudiber/tachyon/forks","keys_url":"https://api.github.com/repos/aaudiber/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaudiber/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaudiber/tachyon/teams","hooks_url":"https://api.github.com/repos/aaudiber/tachyon/hooks","issue_events_url":"https://api.github.com/repos/aaudiber/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/aaudiber/tachyon/events","assignees_url":"https://api.github.com/repos/aaudiber/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/aaudiber/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/aaudiber/tachyon/tags","blobs_url":"https://api.github.com/repos/aaudiber/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaudiber/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaudiber/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaudiber/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaudiber/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/aaudiber/tachyon/languages","stargazers_url":"https://api.github.com/repos/aaudiber/tachyon/stargazers","contributors_url":"https://api.github.com/repos/aaudiber/tachyon/contributors","subscribers_url":"https://api.github.com/repos/aaudiber/tachyon/subscribers","subscription_url":"https://api.github.com/repos/aaudiber/tachyon/subscription","commits_url":"https://api.github.com/repos/aaudiber/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaudiber/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaudiber/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaudiber/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaudiber/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/aaudiber/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaudiber/tachyon/merges","archive_url":"https://api.github.com/repos/aaudiber/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaudiber/tachyon/downloads","issues_url":"https://api.github.com/repos/aaudiber/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/aaudiber/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/aaudiber/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/aaudiber/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaudiber/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/aaudiber/tachyon/releases{/id}","created_at":"2015-09-19T18:48:47Z","updated_at":"2015-09-19T18:48:49Z","pushed_at":"2015-12-03T02:16:04Z","git_url":"git://github.com/aaudiber/tachyon.git","ssh_url":"git@github.com:aaudiber/tachyon.git","clone_url":"https://github.com/aaudiber/tachyon.git","svn_url":"https://github.com/aaudiber/tachyon","homepage":"http://tachyon-project.org","size":32371,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"877c9a57b4de9b8994b303b058f1b97006eef477","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":"Memory Centric Reliable Distributed Storage","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-12-03T02:45:11Z","pushed_at":"2015-12-03T02:45:22Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":40320,"stargazers_count":1775,"watchers_count":1775,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":700,"mirror_url":null,"open_issues_count":27,"forks":700,"open_issues":27,"watchers":1775,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2191"},"html":{"href":"https://github.com/amplab/tachyon/pull/2191"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2191"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2191/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2191/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2191/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/ab94d11ee21d541faa175fe7cb581fdfedd71b26"}}}}