{"action":"created","issue":{"url":"https://api.github.com/repos/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/issues/15","labels_url":"https://api.github.com/repos/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/issues/15/comments","events_url":"https://api.github.com/repos/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/issues/15/events","html_url":"https://github.com/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/issues/15","id":122401649,"number":15,"title":"Exclude composer packages?","user":{"login":"ginkgomzd","id":2687924,"avatar_url":"https://avatars.githubusercontent.com/u/2687924?v=3","gravatar_id":"","url":"https://api.github.com/users/ginkgomzd","html_url":"https://github.com/ginkgomzd","followers_url":"https://api.github.com/users/ginkgomzd/followers","following_url":"https://api.github.com/users/ginkgomzd/following{/other_user}","gists_url":"https://api.github.com/users/ginkgomzd/gists{/gist_id}","starred_url":"https://api.github.com/users/ginkgomzd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginkgomzd/subscriptions","organizations_url":"https://api.github.com/users/ginkgomzd/orgs","repos_url":"https://api.github.com/users/ginkgomzd/repos","events_url":"https://api.github.com/users/ginkgomzd/events{/privacy}","received_events_url":"https://api.github.com/users/ginkgomzd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-16T00:46:06Z","updated_at":"2015-12-16T01:33:13Z","closed_at":null,"body":"Wouldn't it be better to not be checking in the vendor packages?\r\nI saw John got tripped up over polyfill-php54 (PR#13). I wonder if there had been no dependencies present if it would have been more intuitive to have to run composer install to fetch all dependencies.\r\n\r\nI note that I am not able to run composer update because of exceptions due to missing .git directories in vendor packages. Blowing them away and running update again resolves it just fine.\r\n\r\nI haven't used composer enough to be real familiar with how it works. I'm wondering if the project is set up properly because it appears there are packages being tracked in the internal composer/installed.json that are not named in the top-project composer.json file. Maybe they are all sub-dependencies? I tried greping for polyfill-php54 and I could not see where it was declared as a dependency other than installed.json. I think this means that it was installed using composer install, checked in, but not added to the top-level composer.json. Maybe?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/issues/comments/164956039","html_url":"https://github.com/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/issues/15#issuecomment-164956039","issue_url":"https://api.github.com/repos/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/issues/15","id":164956039,"user":{"login":"eileenmcnaughton","id":336308,"avatar_url":"https://avatars.githubusercontent.com/u/336308?v=3","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"created_at":"2015-12-16T01:33:13Z","updated_at":"2015-12-16T01:33:13Z","body":"I think if I don't check in vendor I'm requiring installers to do that & mostly that is a bit too tricky for them. I agree it's not ideal but I feel like it probably needs to be resolved at the core level first."}}