{"action":"created","comment":{"url":"https://api.github.com/repos/meteor/meteor/pulls/comments/28824513","id":28824513,"diff_hunk":"@@ -614,17 +629,30 @@ var ensureCordovaPlugins = function (projectContext, options) {\n   // Due to the dependency structure of Cordova plugins, it is impossible to\n   // upgrade the version on an individual Cordova plugin. Instead, whenever a\n   // new Cordova plugin is added or removed, or its version is changed,\n-  // we just reinstall all of the plugins.\n+  // we just reinstall all of the plugins. Additionally if there are any plugins\n+  // added from the local path, we will reinstall them just to be sure they\n+  // are up to date since we do not track changes in their sources.\n \n-  var shouldReinstallPlugins = false;\n+  var shouldReinstallPlugins = false,\n+      shouldReinstallPluginsFromLocalPaths = false,","path":"tools/commands-cordova.js","position":74,"original_position":74,"commit_id":"b00aabc97f51b2c8c3f2bd8260061ee24b69818d","original_commit_id":"b00aabc97f51b2c8c3f2bd8260061ee24b69818d","user":{"login":"Slava","id":2608446,"avatar_url":"https://avatars.githubusercontent.com/u/2608446?v=3","gravatar_id":"","url":"https://api.github.com/users/Slava","html_url":"https://github.com/Slava","followers_url":"https://api.github.com/users/Slava/followers","following_url":"https://api.github.com/users/Slava/following{/other_user}","gists_url":"https://api.github.com/users/Slava/gists{/gist_id}","starred_url":"https://api.github.com/users/Slava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slava/subscriptions","organizations_url":"https://api.github.com/users/Slava/orgs","repos_url":"https://api.github.com/users/Slava/repos","events_url":"https://api.github.com/users/Slava/events{/privacy}","received_events_url":"https://api.github.com/users/Slava/received_events","type":"User","site_admin":false},"body":"why is it a separate variable? do we even need this distinction here?","created_at":"2015-04-21T21:31:34Z","updated_at":"2015-04-21T21:31:34Z","html_url":"https://github.com/meteor/meteor/pull/4229#discussion_r28824513","pull_request_url":"https://api.github.com/repos/meteor/meteor/pulls/4229","_links":{"self":{"href":"https://api.github.com/repos/meteor/meteor/pulls/comments/28824513"},"html":{"href":"https://github.com/meteor/meteor/pull/4229#discussion_r28824513"},"pull_request":{"href":"https://api.github.com/repos/meteor/meteor/pulls/4229"}}},"pull_request":{"url":"https://api.github.com/repos/meteor/meteor/pulls/4229","id":33550636,"html_url":"https://github.com/meteor/meteor/pull/4229","diff_url":"https://github.com/meteor/meteor/pull/4229.diff","patch_url":"https://github.com/meteor/meteor/pull/4229.patch","issue_url":"https://api.github.com/repos/meteor/meteor/issues/4229","number":4229,"state":"open","locked":false,"title":"Cordova: support for local plugins","user":{"login":"wojtkowiak","id":8668306,"avatar_url":"https://avatars.githubusercontent.com/u/8668306?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtkowiak","html_url":"https://github.com/wojtkowiak","followers_url":"https://api.github.com/users/wojtkowiak/followers","following_url":"https://api.github.com/users/wojtkowiak/following{/other_user}","gists_url":"https://api.github.com/users/wojtkowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtkowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtkowiak/subscriptions","organizations_url":"https://api.github.com/users/wojtkowiak/orgs","repos_url":"https://api.github.com/users/wojtkowiak/repos","events_url":"https://api.github.com/users/wojtkowiak/events{/privacy}","received_events_url":"https://api.github.com/users/wojtkowiak/received_events","type":"User","site_admin":false},"body":"I'm working on project which heavily depends on a cordova plugin which is also under development. Without support for plugins added from local path it was really hard to work on simultaneously on both meteor project and cordova plugin.\r\n\r\nSupported syntax is:\r\nmeteor add cordova:com.my.plugin@file://../../my/relative/path\r\nmeteor add cordova:com.my.plugin@file:///home/user/my/absolute/path\r\n\r\nBecause I did not want to check whether the plugin has changed I am refreshing the plugin on each build/run. This done by issuing remove and adding the plugin again.\r\nBecause cordova 4.2.0 is not properly handling removing plugins added from local path I had to switch to 4.3.0 in which this issue is resolved.\r\n\r\nI see that some discussion have been going on here https://github.com/meteor/meteor/issues/2925\r\nLet me know if there is any chance this could be accepted and if yes I am looking forward for comments on this. \r\n","created_at":"2015-04-17T14:43:55Z","updated_at":"2015-04-21T21:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"132e7e2217834fffba6b8b14231d86c9674da99f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/meteor/meteor/pulls/4229/commits","review_comments_url":"https://api.github.com/repos/meteor/meteor/pulls/4229/comments","review_comment_url":"https://api.github.com/repos/meteor/meteor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meteor/meteor/issues/4229/comments","statuses_url":"https://api.github.com/repos/meteor/meteor/statuses/b00aabc97f51b2c8c3f2bd8260061ee24b69818d","head":{"label":"wojtkowiak:cordova-local-plugins","ref":"cordova-local-plugins","sha":"b00aabc97f51b2c8c3f2bd8260061ee24b69818d","user":{"login":"wojtkowiak","id":8668306,"avatar_url":"https://avatars.githubusercontent.com/u/8668306?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtkowiak","html_url":"https://github.com/wojtkowiak","followers_url":"https://api.github.com/users/wojtkowiak/followers","following_url":"https://api.github.com/users/wojtkowiak/following{/other_user}","gists_url":"https://api.github.com/users/wojtkowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtkowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtkowiak/subscriptions","organizations_url":"https://api.github.com/users/wojtkowiak/orgs","repos_url":"https://api.github.com/users/wojtkowiak/repos","events_url":"https://api.github.com/users/wojtkowiak/events{/privacy}","received_events_url":"https://api.github.com/users/wojtkowiak/received_events","type":"User","site_admin":false},"repo":{"id":29912470,"name":"meteor","full_name":"wojtkowiak/meteor","owner":{"login":"wojtkowiak","id":8668306,"avatar_url":"https://avatars.githubusercontent.com/u/8668306?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtkowiak","html_url":"https://github.com/wojtkowiak","followers_url":"https://api.github.com/users/wojtkowiak/followers","following_url":"https://api.github.com/users/wojtkowiak/following{/other_user}","gists_url":"https://api.github.com/users/wojtkowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtkowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtkowiak/subscriptions","organizations_url":"https://api.github.com/users/wojtkowiak/orgs","repos_url":"https://api.github.com/users/wojtkowiak/repos","events_url":"https://api.github.com/users/wojtkowiak/events{/privacy}","received_events_url":"https://api.github.com/users/wojtkowiak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wojtkowiak/meteor","description":"Meteor, an ultra-simple, database-everywhere, data-on-the-wire, pure-Javascript web framework.","fork":true,"url":"https://api.github.com/repos/wojtkowiak/meteor","forks_url":"https://api.github.com/repos/wojtkowiak/meteor/forks","keys_url":"https://api.github.com/repos/wojtkowiak/meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wojtkowiak/meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wojtkowiak/meteor/teams","hooks_url":"https://api.github.com/repos/wojtkowiak/meteor/hooks","issue_events_url":"https://api.github.com/repos/wojtkowiak/meteor/issues/events{/number}","events_url":"https://api.github.com/repos/wojtkowiak/meteor/events","assignees_url":"https://api.github.com/repos/wojtkowiak/meteor/assignees{/user}","branches_url":"https://api.github.com/repos/wojtkowiak/meteor/branches{/branch}","tags_url":"https://api.github.com/repos/wojtkowiak/meteor/tags","blobs_url":"https://api.github.com/repos/wojtkowiak/meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wojtkowiak/meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wojtkowiak/meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/wojtkowiak/meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wojtkowiak/meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/wojtkowiak/meteor/languages","stargazers_url":"https://api.github.com/repos/wojtkowiak/meteor/stargazers","contributors_url":"https://api.github.com/repos/wojtkowiak/meteor/contributors","subscribers_url":"https://api.github.com/repos/wojtkowiak/meteor/subscribers","subscription_url":"https://api.github.com/repos/wojtkowiak/meteor/subscription","commits_url":"https://api.github.com/repos/wojtkowiak/meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/wojtkowiak/meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/wojtkowiak/meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/wojtkowiak/meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/wojtkowiak/meteor/contents/{+path}","compare_url":"https://api.github.com/repos/wojtkowiak/meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wojtkowiak/meteor/merges","archive_url":"https://api.github.com/repos/wojtkowiak/meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wojtkowiak/meteor/downloads","issues_url":"https://api.github.com/repos/wojtkowiak/meteor/issues{/number}","pulls_url":"https://api.github.com/repos/wojtkowiak/meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/wojtkowiak/meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/wojtkowiak/meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wojtkowiak/meteor/labels{/name}","releases_url":"https://api.github.com/repos/wojtkowiak/meteor/releases{/id}","created_at":"2015-01-27T12:06:37Z","updated_at":"2015-04-14T13:26:01Z","pushed_at":"2015-04-17T14:41:31Z","git_url":"git://github.com/wojtkowiak/meteor.git","ssh_url":"git@github.com:wojtkowiak/meteor.git","clone_url":"https://github.com/wojtkowiak/meteor.git","svn_url":"https://github.com/wojtkowiak/meteor","homepage":"www.meteor.com","size":52283,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"meteor:devel","ref":"devel","sha":"9039e6b2da88f6e7dfe26e7614693124686c9b58","user":{"login":"meteor","id":789528,"avatar_url":"https://avatars.githubusercontent.com/u/789528?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"repo":{"id":3214406,"name":"meteor","full_name":"meteor/meteor","owner":{"login":"meteor","id":789528,"avatar_url":"https://avatars.githubusercontent.com/u/789528?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meteor/meteor","description":"Meteor, an ultra-simple, database-everywhere, data-on-the-wire, pure-Javascript web framework.","fork":false,"url":"https://api.github.com/repos/meteor/meteor","forks_url":"https://api.github.com/repos/meteor/meteor/forks","keys_url":"https://api.github.com/repos/meteor/meteor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteor/meteor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteor/meteor/teams","hooks_url":"https://api.github.com/repos/meteor/meteor/hooks","issue_events_url":"https://api.github.com/repos/meteor/meteor/issues/events{/number}","events_url":"https://api.github.com/repos/meteor/meteor/events","assignees_url":"https://api.github.com/repos/meteor/meteor/assignees{/user}","branches_url":"https://api.github.com/repos/meteor/meteor/branches{/branch}","tags_url":"https://api.github.com/repos/meteor/meteor/tags","blobs_url":"https://api.github.com/repos/meteor/meteor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteor/meteor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteor/meteor/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteor/meteor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteor/meteor/statuses/{sha}","languages_url":"https://api.github.com/repos/meteor/meteor/languages","stargazers_url":"https://api.github.com/repos/meteor/meteor/stargazers","contributors_url":"https://api.github.com/repos/meteor/meteor/contributors","subscribers_url":"https://api.github.com/repos/meteor/meteor/subscribers","subscription_url":"https://api.github.com/repos/meteor/meteor/subscription","commits_url":"https://api.github.com/repos/meteor/meteor/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteor/meteor/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteor/meteor/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteor/meteor/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteor/meteor/contents/{+path}","compare_url":"https://api.github.com/repos/meteor/meteor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteor/meteor/merges","archive_url":"https://api.github.com/repos/meteor/meteor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteor/meteor/downloads","issues_url":"https://api.github.com/repos/meteor/meteor/issues{/number}","pulls_url":"https://api.github.com/repos/meteor/meteor/pulls{/number}","milestones_url":"https://api.github.com/repos/meteor/meteor/milestones{/number}","notifications_url":"https://api.github.com/repos/meteor/meteor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteor/meteor/labels{/name}","releases_url":"https://api.github.com/repos/meteor/meteor/releases{/id}","created_at":"2012-01-19T01:58:17Z","updated_at":"2015-04-21T21:24:09Z","pushed_at":"2015-04-21T21:24:08Z","git_url":"git://github.com/meteor/meteor.git","ssh_url":"git@github.com:meteor/meteor.git","clone_url":"https://github.com/meteor/meteor.git","svn_url":"https://github.com/meteor/meteor","homepage":"www.meteor.com","size":173045,"stargazers_count":24351,"watchers_count":24351,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2756,"mirror_url":null,"open_issues_count":519,"forks":2756,"open_issues":519,"watchers":24351,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/meteor/meteor/pulls/4229"},"html":{"href":"https://github.com/meteor/meteor/pull/4229"},"issue":{"href":"https://api.github.com/repos/meteor/meteor/issues/4229"},"comments":{"href":"https://api.github.com/repos/meteor/meteor/issues/4229/comments"},"review_comments":{"href":"https://api.github.com/repos/meteor/meteor/pulls/4229/comments"},"review_comment":{"href":"https://api.github.com/repos/meteor/meteor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meteor/meteor/pulls/4229/commits"},"statuses":{"href":"https://api.github.com/repos/meteor/meteor/statuses/b00aabc97f51b2c8c3f2bd8260061ee24b69818d"}}}}