{"action":"closed","number":673,"pull_request":{"url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/673","id":54279317,"html_url":"https://github.com/javiereguiluz/EasyAdminBundle/pull/673","diff_url":"https://github.com/javiereguiluz/EasyAdminBundle/pull/673.diff","patch_url":"https://github.com/javiereguiluz/EasyAdminBundle/pull/673.patch","issue_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/673","number":673,"state":"closed","locked":false,"title":"Add a delete button for removing non-compound items from collection.","user":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars.githubusercontent.com/u/2211145?v=3","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"body":"As reported in #383, the feature added in #451 only worked for compound field.\r\nUsing the collection form type to handle simple array of strings like tags didn't show a removal link:\r\n\r\n<img width=\"698\" alt=\"screenshot 2015-12-21 a 18 03 17\" src=\"https://cloud.githubusercontent.com/assets/2211145/11936306/3a4edeec-a80d-11e5-848d-e8936b809f16.PNG\">\r\n\r\nHere what it'll looks like now:\r\n\r\n<img width=\"690\" alt=\"screenshot 2015-12-21 a 18 51 18\" src=\"https://cloud.githubusercontent.com/assets/2211145/11937318/df117f06-a813-11e5-95b9-86269c98873c.PNG\">\r\n\r\nI also fixed the markup in order to avoid considering the whole link as a block (The previous markup had for consequence to make the link clickable on the whole width of the form).\r\n\r\n> :grey_question: Won't you prefer [proper buttons](https://cloud.githubusercontent.com/assets/2211145/11937444/bfe8883a-a814-11e5-90a9-542f4bba27ac.PNG) ?","created_at":"2015-12-21T17:04:35Z","updated_at":"2015-12-23T21:07:20Z","closed_at":"2015-12-23T21:07:20Z","merged_at":"2015-12-23T21:07:20Z","merge_commit_sha":"05b8d6b90c0d9fc9123de85f61d8e0cede0d9c96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/673/commits","review_comments_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/673/comments","review_comment_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/673/comments","statuses_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/statuses/a0ccca4bb35450a2c1120e4b5d7f8a31199c5911","head":{"label":"ogizanagi:feature_non_compound_item_removal","ref":"feature_non_compound_item_removal","sha":"a0ccca4bb35450a2c1120e4b5d7f8a31199c5911","user":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars.githubusercontent.com/u/2211145?v=3","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"repo":{"id":29977379,"name":"EasyAdminBundle","full_name":"ogizanagi/EasyAdminBundle","owner":{"login":"ogizanagi","id":2211145,"avatar_url":"https://avatars.githubusercontent.com/u/2211145?v=3","gravatar_id":"","url":"https://api.github.com/users/ogizanagi","html_url":"https://github.com/ogizanagi","followers_url":"https://api.github.com/users/ogizanagi/followers","following_url":"https://api.github.com/users/ogizanagi/following{/other_user}","gists_url":"https://api.github.com/users/ogizanagi/gists{/gist_id}","starred_url":"https://api.github.com/users/ogizanagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogizanagi/subscriptions","organizations_url":"https://api.github.com/users/ogizanagi/orgs","repos_url":"https://api.github.com/users/ogizanagi/repos","events_url":"https://api.github.com/users/ogizanagi/events{/privacy}","received_events_url":"https://api.github.com/users/ogizanagi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ogizanagi/EasyAdminBundle","description":"The new (and simple) admin generator for Symfony applications.","fork":true,"url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle","forks_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/forks","keys_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/teams","hooks_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/events","assignees_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/tags","blobs_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/languages","stargazers_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/subscription","commits_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/merges","archive_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/downloads","issues_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/ogizanagi/EasyAdminBundle/releases{/id}","created_at":"2015-01-28T16:45:06Z","updated_at":"2015-10-20T19:58:32Z","pushed_at":"2015-12-23T20:47:48Z","git_url":"git://github.com/ogizanagi/EasyAdminBundle.git","ssh_url":"git@github.com:ogizanagi/EasyAdminBundle.git","clone_url":"https://github.com/ogizanagi/EasyAdminBundle.git","svn_url":"https://github.com/ogizanagi/EasyAdminBundle","homepage":"","size":4973,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"javiereguiluz:master","ref":"master","sha":"ab76b096ae162886171a78011287cba4dc9bf456","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"repo":{"id":29126334,"name":"EasyAdminBundle","full_name":"javiereguiluz/EasyAdminBundle","owner":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javiereguiluz/EasyAdminBundle","description":"The new (and simple) admin generator for Symfony applications.","fork":false,"url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle","forks_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/forks","keys_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/teams","hooks_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/events","assignees_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/tags","blobs_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/languages","stargazers_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/subscription","commits_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/merges","archive_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/downloads","issues_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/releases{/id}","created_at":"2015-01-12T08:43:02Z","updated_at":"2015-12-23T18:49:45Z","pushed_at":"2015-12-23T21:07:20Z","git_url":"git://github.com/javiereguiluz/EasyAdminBundle.git","ssh_url":"git@github.com:javiereguiluz/EasyAdminBundle.git","clone_url":"https://github.com/javiereguiluz/EasyAdminBundle.git","svn_url":"https://github.com/javiereguiluz/EasyAdminBundle","homepage":"","size":5896,"stargazers_count":725,"watchers_count":725,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":44,"forks":112,"open_issues":44,"watchers":725,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/673"},"html":{"href":"https://github.com/javiereguiluz/EasyAdminBundle/pull/673"},"issue":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/673"},"comments":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/issues/673/comments"},"review_comments":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/673/comments"},"review_comment":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/pulls/673/commits"},"statuses":{"href":"https://api.github.com/repos/javiereguiluz/EasyAdminBundle/statuses/a0ccca4bb35450a2c1120e4b5d7f8a31199c5911"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":38,"deletions":22,"changed_files":2}}