{"action":"created","issue":{"url":"https://api.github.com/repos/candy-chat/candy-plugins/issues/148","labels_url":"https://api.github.com/repos/candy-chat/candy-plugins/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/candy-chat/candy-plugins/issues/148/comments","events_url":"https://api.github.com/repos/candy-chat/candy-plugins/issues/148/events","html_url":"https://github.com/candy-chat/candy-plugins/issues/148","id":114440798,"number":148,"title":"better inline-videos parsing","user":{"login":"Sudrien","id":24167,"avatar_url":"https://avatars.githubusercontent.com/u/24167?v=3","gravatar_id":"","url":"https://api.github.com/users/Sudrien","html_url":"https://github.com/Sudrien","followers_url":"https://api.github.com/users/Sudrien/followers","following_url":"https://api.github.com/users/Sudrien/following{/other_user}","gists_url":"https://api.github.com/users/Sudrien/gists{/gist_id}","starred_url":"https://api.github.com/users/Sudrien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sudrien/subscriptions","organizations_url":"https://api.github.com/users/Sudrien/orgs","repos_url":"https://api.github.com/users/Sudrien/repos","events_url":"https://api.github.com/users/Sudrien/events{/privacy}","received_events_url":"https://api.github.com/users/Sudrien/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/candy-chat/candy-plugins/labels/Improvement","name":"Improvement","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-31T23:45:26Z","updated_at":"2015-12-02T04:25:09Z","closed_at":null,"body":"#147 suggested adding youtube.be support, there is room for further improvements.\r\n* Force embed to https - testing shows youtube will do this anyways, might as well take away one opportunity to spoof urls.\r\n* Support `t=` - or, embeds can be started at a certain time during the video\r\n\r\nCaveats: \r\n* `t=#h##m##s` is not the format used in embeds - rather, it's `start=###` - a single integer, in seconds ( see https://developers.google.com/youtube/player_parameters#start ). At least `t=` uses a consistent order, so a single regex to break them out should be enough.\r\n* Looking at multiple url parameters or unknown order means we really should be doing proper url & parameter parsing - something complex enough to be a part of Candy.Util, or use an external library."},"comment":{"url":"https://api.github.com/repos/candy-chat/candy-plugins/issues/comments/161177320","html_url":"https://github.com/candy-chat/candy-plugins/issues/148#issuecomment-161177320","issue_url":"https://api.github.com/repos/candy-chat/candy-plugins/issues/148","id":161177320,"user":{"login":"Sudrien","id":24167,"avatar_url":"https://avatars.githubusercontent.com/u/24167?v=3","gravatar_id":"","url":"https://api.github.com/users/Sudrien","html_url":"https://github.com/Sudrien","followers_url":"https://api.github.com/users/Sudrien/followers","following_url":"https://api.github.com/users/Sudrien/following{/other_user}","gists_url":"https://api.github.com/users/Sudrien/gists{/gist_id}","starred_url":"https://api.github.com/users/Sudrien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sudrien/subscriptions","organizations_url":"https://api.github.com/users/Sudrien/orgs","repos_url":"https://api.github.com/users/Sudrien/repos","events_url":"https://api.github.com/users/Sudrien/events{/privacy}","received_events_url":"https://api.github.com/users/Sudrien/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T04:25:09Z","updated_at":"2015-12-02T04:25:09Z","body":"Pushed first attempt to branch. I'm wondering if I should be displaying the original URL or a sanitized one - leaning towards sanitized, but not very hard. @mweibel - is this code looking good to you?\r\n\r\n(note to self: remove debug console calls)"}}