{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/31360192","id":31360192,"diff_hunk":"@@ -54,6 +54,11 @@\n {% set token_auth_file = \"--token_auth_file=/dev/null\" -%}\n {% set basic_auth_file = \"\" -%}\n \n+{% set min_request_timeout = \"\" -%}\n+{% if grains.test is defined -%}\n+  {% set min_request_timeout = \"--min-request-timeout=300\" %}","path":"cluster/saltbase/salt/kube-apiserver/kube-apiserver.manifest","position":6,"original_position":6,"commit_id":"95d8a7ee2ba35296b29470fe15e580f600b7985b","original_commit_id":"95d8a7ee2ba35296b29470fe15e580f600b7985b","user":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"body":"So instead of having this logic in salt, you'd have a CONN_TIMEOUT variable or something in the config-test.sh/config-default.sh files.","created_at":"2015-05-29T20:09:09Z","updated_at":"2015-05-29T20:09:09Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8964#discussion_r31360192","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8964","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/31360192"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8964#discussion_r31360192"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8964"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8964","id":36459416,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8964","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8964.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8964.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8964","number":8964,"state":"open","locked":false,"title":"Extend read/write connection timeout of apiserver","user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"body":"* First commit pipes the min request timeout as a command line parameter for the apiserver,\r\n* Second commit sets it to 300s in test clusters\r\n* Final commit defaults it to 1800s \r\n\r\nOnly watch server currently uses this timeout. Still e2e-ing, salt/shell parts might need a rebase.\r\n\r\nreview @wojtek-t @davidopp \r\nfyi @lavalamp","created_at":"2015-05-28T22:56:06Z","updated_at":"2015-05-29T20:09:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a965448f0ce828171fbac729876bcec0e9b2dfd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8964/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8964/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8964/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/95d8a7ee2ba35296b29470fe15e580f600b7985b","head":{"label":"bprashanth:apiserver_cmd","ref":"apiserver_cmd","sha":"95d8a7ee2ba35296b29470fe15e580f600b7985b","user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"repo":{"id":30552514,"name":"kubernetes","full_name":"bprashanth/kubernetes","owner":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bprashanth/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/bprashanth/kubernetes","forks_url":"https://api.github.com/repos/bprashanth/kubernetes/forks","keys_url":"https://api.github.com/repos/bprashanth/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bprashanth/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bprashanth/kubernetes/teams","hooks_url":"https://api.github.com/repos/bprashanth/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/bprashanth/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/bprashanth/kubernetes/events","assignees_url":"https://api.github.com/repos/bprashanth/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/bprashanth/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/bprashanth/kubernetes/tags","blobs_url":"https://api.github.com/repos/bprashanth/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bprashanth/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bprashanth/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/bprashanth/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bprashanth/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/bprashanth/kubernetes/languages","stargazers_url":"https://api.github.com/repos/bprashanth/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/bprashanth/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/bprashanth/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/bprashanth/kubernetes/subscription","commits_url":"https://api.github.com/repos/bprashanth/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/bprashanth/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/bprashanth/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/bprashanth/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/bprashanth/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/bprashanth/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bprashanth/kubernetes/merges","archive_url":"https://api.github.com/repos/bprashanth/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bprashanth/kubernetes/downloads","issues_url":"https://api.github.com/repos/bprashanth/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/bprashanth/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/bprashanth/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/bprashanth/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bprashanth/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/bprashanth/kubernetes/releases{/id}","created_at":"2015-02-09T18:58:38Z","updated_at":"2015-02-09T18:58:42Z","pushed_at":"2015-05-29T06:50:35Z","git_url":"git://github.com/bprashanth/kubernetes.git","ssh_url":"git@github.com:bprashanth/kubernetes.git","clone_url":"https://github.com/bprashanth/kubernetes.git","svn_url":"https://github.com/bprashanth/kubernetes","homepage":"http://kubernetes.io","size":61415,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"ed4898d98c46869e9cbdb44186dfdeda9ff80cc2","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-05-29T19:11:28Z","pushed_at":"2015-05-29T19:30:19Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":297800,"stargazers_count":7988,"watchers_count":7988,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1674,"mirror_url":null,"open_issues_count":1249,"forks":1674,"open_issues":1249,"watchers":7988,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8964"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8964"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8964"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8964/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8964/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8964/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/95d8a7ee2ba35296b29470fe15e580f600b7985b"}}}}