{"action":"created","comment":{"url":"https://api.github.com/repos/nio-blocks/state_change/pulls/comments/25900915","id":25900915,"diff_hunk":"@@ -33,21 +21,22 @@ class StateChange(StateChangeBase):\n     a notification Signal.\n     \"\"\"\n \n-    exclude = BoolProperty(default=True, title = \"Exclude Existing Fields\")\n-    use_persistence = BoolProperty(title=\"Use Persistence\", default=True,\n-            visible=True)\n-\n-    def __init__(self):\n-        super().__init__()\n-        self._safe_lock = Lock()\n-\n-    def process_signals(self, signals):\n-        self._logger.debug(\n-            \"Ready to process {} incoming signals\".format(len(signals))\n-        )\n-        with self._safe_lock:\n-            for signal in signals:\n-                self._logger.debug(\"Attempting to set state\")\n-                out = self._process_state(signal, self.exclude)\n-                if out is not None:\n-                    self.notify_signals([out])\n+    exclude = BoolProperty(default=True, title=\"Exclude Existing Fields\")\n+\n+    def _process_group(self, signals, group, to_notify=list()):\n+        \"\"\" Process the signals for a group.\n+\n+        Add any signals that should be passed through to the to_notify list\n+        \"\"\"\n+        for signal in signals:\n+            state_change = self._process_state(signal, group)","path":"state_change_block.py","position":60,"original_position":60,"commit_id":"235f430f573d2523d14f73771caa57d0448d2d21","original_commit_id":"88034512252ff7882f7b6c502553d6bac5ba5b76","user":{"login":"hansmosh","id":5524215,"avatar_url":"https://avatars.githubusercontent.com/u/5524215?v=3","gravatar_id":"","url":"https://api.github.com/users/hansmosh","html_url":"https://github.com/hansmosh","followers_url":"https://api.github.com/users/hansmosh/followers","following_url":"https://api.github.com/users/hansmosh/following{/other_user}","gists_url":"https://api.github.com/users/hansmosh/gists{/gist_id}","starred_url":"https://api.github.com/users/hansmosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansmosh/subscriptions","organizations_url":"https://api.github.com/users/hansmosh/orgs","repos_url":"https://api.github.com/users/hansmosh/repos","events_url":"https://api.github.com/users/hansmosh/events{/privacy}","received_events_url":"https://api.github.com/users/hansmosh/received_events","type":"User","site_admin":false},"body":"The class docstring that says \"*state* changing from None to not None does not count as a state change.\" is no longer valid.","created_at":"2015-03-05T20:59:55Z","updated_at":"2015-03-05T20:59:55Z","html_url":"https://github.com/nio-blocks/state_change/pull/20#discussion_r25900915","pull_request_url":"https://api.github.com/repos/nio-blocks/state_change/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/nio-blocks/state_change/pulls/comments/25900915"},"html":{"href":"https://github.com/nio-blocks/state_change/pull/20#discussion_r25900915"},"pull_request":{"href":"https://api.github.com/repos/nio-blocks/state_change/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/nio-blocks/state_change/pulls/20","id":30592000,"html_url":"https://github.com/nio-blocks/state_change/pull/20","diff_url":"https://github.com/nio-blocks/state_change/pull/20.diff","patch_url":"https://github.com/nio-blocks/state_change/pull/20.patch","issue_url":"https://api.github.com/repos/nio-blocks/state_change/issues/20","number":20,"state":"open","locked":false,"title":"v1.0.0 refactor and features","user":{"login":"mattdodge","id":797259,"avatar_url":"https://avatars.githubusercontent.com/u/797259?v=3","gravatar_id":"","url":"https://api.github.com/users/mattdodge","html_url":"https://github.com/mattdodge","followers_url":"https://api.github.com/users/mattdodge/followers","following_url":"https://api.github.com/users/mattdodge/following{/other_user}","gists_url":"https://api.github.com/users/mattdodge/gists{/gist_id}","starred_url":"https://api.github.com/users/mattdodge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattdodge/subscriptions","organizations_url":"https://api.github.com/users/mattdodge/orgs","repos_url":"https://api.github.com/users/mattdodge/repos","events_url":"https://api.github.com/users/mattdodge/events{/privacy}","received_events_url":"https://api.github.com/users/mattdodge/received_events","type":"User","site_admin":false},"body":"Quite a bit of refactoring here. Includes these new features too:\r\n- Group by (#17)\r\n- Initial state (#19)\r\n- Better persistence (#18)","created_at":"2015-03-05T20:23:08Z","updated_at":"2015-03-05T20:59:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21ceacd66376b8c8eac91075ddbf50e9b13e3340","assignee":{"login":"hansmosh","id":5524215,"avatar_url":"https://avatars.githubusercontent.com/u/5524215?v=3","gravatar_id":"","url":"https://api.github.com/users/hansmosh","html_url":"https://github.com/hansmosh","followers_url":"https://api.github.com/users/hansmosh/followers","following_url":"https://api.github.com/users/hansmosh/following{/other_user}","gists_url":"https://api.github.com/users/hansmosh/gists{/gist_id}","starred_url":"https://api.github.com/users/hansmosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansmosh/subscriptions","organizations_url":"https://api.github.com/users/hansmosh/orgs","repos_url":"https://api.github.com/users/hansmosh/repos","events_url":"https://api.github.com/users/hansmosh/events{/privacy}","received_events_url":"https://api.github.com/users/hansmosh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/nio-blocks/state_change/pulls/20/commits","review_comments_url":"https://api.github.com/repos/nio-blocks/state_change/pulls/20/comments","review_comment_url":"https://api.github.com/repos/nio-blocks/state_change/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nio-blocks/state_change/issues/20/comments","statuses_url":"https://api.github.com/repos/nio-blocks/state_change/statuses/235f430f573d2523d14f73771caa57d0448d2d21","head":{"label":"nio-blocks:refactor","ref":"refactor","sha":"235f430f573d2523d14f73771caa57d0448d2d21","user":{"login":"nio-blocks","id":7684467,"avatar_url":"https://avatars.githubusercontent.com/u/7684467?v=3","gravatar_id":"","url":"https://api.github.com/users/nio-blocks","html_url":"https://github.com/nio-blocks","followers_url":"https://api.github.com/users/nio-blocks/followers","following_url":"https://api.github.com/users/nio-blocks/following{/other_user}","gists_url":"https://api.github.com/users/nio-blocks/gists{/gist_id}","starred_url":"https://api.github.com/users/nio-blocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nio-blocks/subscriptions","organizations_url":"https://api.github.com/users/nio-blocks/orgs","repos_url":"https://api.github.com/users/nio-blocks/repos","events_url":"https://api.github.com/users/nio-blocks/events{/privacy}","received_events_url":"https://api.github.com/users/nio-blocks/received_events","type":"Organization","site_admin":false},"repo":{"id":22268414,"name":"state_change","full_name":"nio-blocks/state_change","owner":{"login":"nio-blocks","id":7684467,"avatar_url":"https://avatars.githubusercontent.com/u/7684467?v=3","gravatar_id":"","url":"https://api.github.com/users/nio-blocks","html_url":"https://github.com/nio-blocks","followers_url":"https://api.github.com/users/nio-blocks/followers","following_url":"https://api.github.com/users/nio-blocks/following{/other_user}","gists_url":"https://api.github.com/users/nio-blocks/gists{/gist_id}","starred_url":"https://api.github.com/users/nio-blocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nio-blocks/subscriptions","organizations_url":"https://api.github.com/users/nio-blocks/orgs","repos_url":"https://api.github.com/users/nio-blocks/repos","events_url":"https://api.github.com/users/nio-blocks/events{/privacy}","received_events_url":"https://api.github.com/users/nio-blocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nio-blocks/state_change","description":"Notifies a signal when *state* changes.","fork":false,"url":"https://api.github.com/repos/nio-blocks/state_change","forks_url":"https://api.github.com/repos/nio-blocks/state_change/forks","keys_url":"https://api.github.com/repos/nio-blocks/state_change/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nio-blocks/state_change/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nio-blocks/state_change/teams","hooks_url":"https://api.github.com/repos/nio-blocks/state_change/hooks","issue_events_url":"https://api.github.com/repos/nio-blocks/state_change/issues/events{/number}","events_url":"https://api.github.com/repos/nio-blocks/state_change/events","assignees_url":"https://api.github.com/repos/nio-blocks/state_change/assignees{/user}","branches_url":"https://api.github.com/repos/nio-blocks/state_change/branches{/branch}","tags_url":"https://api.github.com/repos/nio-blocks/state_change/tags","blobs_url":"https://api.github.com/repos/nio-blocks/state_change/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nio-blocks/state_change/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nio-blocks/state_change/git/refs{/sha}","trees_url":"https://api.github.com/repos/nio-blocks/state_change/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nio-blocks/state_change/statuses/{sha}","languages_url":"https://api.github.com/repos/nio-blocks/state_change/languages","stargazers_url":"https://api.github.com/repos/nio-blocks/state_change/stargazers","contributors_url":"https://api.github.com/repos/nio-blocks/state_change/contributors","subscribers_url":"https://api.github.com/repos/nio-blocks/state_change/subscribers","subscription_url":"https://api.github.com/repos/nio-blocks/state_change/subscription","commits_url":"https://api.github.com/repos/nio-blocks/state_change/commits{/sha}","git_commits_url":"https://api.github.com/repos/nio-blocks/state_change/git/commits{/sha}","comments_url":"https://api.github.com/repos/nio-blocks/state_change/comments{/number}","issue_comment_url":"https://api.github.com/repos/nio-blocks/state_change/issues/comments{/number}","contents_url":"https://api.github.com/repos/nio-blocks/state_change/contents/{+path}","compare_url":"https://api.github.com/repos/nio-blocks/state_change/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nio-blocks/state_change/merges","archive_url":"https://api.github.com/repos/nio-blocks/state_change/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nio-blocks/state_change/downloads","issues_url":"https://api.github.com/repos/nio-blocks/state_change/issues{/number}","pulls_url":"https://api.github.com/repos/nio-blocks/state_change/pulls{/number}","milestones_url":"https://api.github.com/repos/nio-blocks/state_change/milestones{/number}","notifications_url":"https://api.github.com/repos/nio-blocks/state_change/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nio-blocks/state_change/labels{/name}","releases_url":"https://api.github.com/repos/nio-blocks/state_change/releases{/id}","created_at":"2014-07-25T19:33:57Z","updated_at":"2015-01-14T01:17:59Z","pushed_at":"2015-03-05T20:48:43Z","git_url":"git://github.com/nio-blocks/state_change.git","ssh_url":"git@github.com:nio-blocks/state_change.git","clone_url":"https://github.com/nio-blocks/state_change.git","svn_url":"https://github.com/nio-blocks/state_change","homepage":null,"size":440,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"nio-blocks:master","ref":"master","sha":"9b34cc78174d0b6fbe7b08ae637f8f67dc8d49f3","user":{"login":"nio-blocks","id":7684467,"avatar_url":"https://avatars.githubusercontent.com/u/7684467?v=3","gravatar_id":"","url":"https://api.github.com/users/nio-blocks","html_url":"https://github.com/nio-blocks","followers_url":"https://api.github.com/users/nio-blocks/followers","following_url":"https://api.github.com/users/nio-blocks/following{/other_user}","gists_url":"https://api.github.com/users/nio-blocks/gists{/gist_id}","starred_url":"https://api.github.com/users/nio-blocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nio-blocks/subscriptions","organizations_url":"https://api.github.com/users/nio-blocks/orgs","repos_url":"https://api.github.com/users/nio-blocks/repos","events_url":"https://api.github.com/users/nio-blocks/events{/privacy}","received_events_url":"https://api.github.com/users/nio-blocks/received_events","type":"Organization","site_admin":false},"repo":{"id":22268414,"name":"state_change","full_name":"nio-blocks/state_change","owner":{"login":"nio-blocks","id":7684467,"avatar_url":"https://avatars.githubusercontent.com/u/7684467?v=3","gravatar_id":"","url":"https://api.github.com/users/nio-blocks","html_url":"https://github.com/nio-blocks","followers_url":"https://api.github.com/users/nio-blocks/followers","following_url":"https://api.github.com/users/nio-blocks/following{/other_user}","gists_url":"https://api.github.com/users/nio-blocks/gists{/gist_id}","starred_url":"https://api.github.com/users/nio-blocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nio-blocks/subscriptions","organizations_url":"https://api.github.com/users/nio-blocks/orgs","repos_url":"https://api.github.com/users/nio-blocks/repos","events_url":"https://api.github.com/users/nio-blocks/events{/privacy}","received_events_url":"https://api.github.com/users/nio-blocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nio-blocks/state_change","description":"Notifies a signal when *state* changes.","fork":false,"url":"https://api.github.com/repos/nio-blocks/state_change","forks_url":"https://api.github.com/repos/nio-blocks/state_change/forks","keys_url":"https://api.github.com/repos/nio-blocks/state_change/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nio-blocks/state_change/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nio-blocks/state_change/teams","hooks_url":"https://api.github.com/repos/nio-blocks/state_change/hooks","issue_events_url":"https://api.github.com/repos/nio-blocks/state_change/issues/events{/number}","events_url":"https://api.github.com/repos/nio-blocks/state_change/events","assignees_url":"https://api.github.com/repos/nio-blocks/state_change/assignees{/user}","branches_url":"https://api.github.com/repos/nio-blocks/state_change/branches{/branch}","tags_url":"https://api.github.com/repos/nio-blocks/state_change/tags","blobs_url":"https://api.github.com/repos/nio-blocks/state_change/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nio-blocks/state_change/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nio-blocks/state_change/git/refs{/sha}","trees_url":"https://api.github.com/repos/nio-blocks/state_change/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nio-blocks/state_change/statuses/{sha}","languages_url":"https://api.github.com/repos/nio-blocks/state_change/languages","stargazers_url":"https://api.github.com/repos/nio-blocks/state_change/stargazers","contributors_url":"https://api.github.com/repos/nio-blocks/state_change/contributors","subscribers_url":"https://api.github.com/repos/nio-blocks/state_change/subscribers","subscription_url":"https://api.github.com/repos/nio-blocks/state_change/subscription","commits_url":"https://api.github.com/repos/nio-blocks/state_change/commits{/sha}","git_commits_url":"https://api.github.com/repos/nio-blocks/state_change/git/commits{/sha}","comments_url":"https://api.github.com/repos/nio-blocks/state_change/comments{/number}","issue_comment_url":"https://api.github.com/repos/nio-blocks/state_change/issues/comments{/number}","contents_url":"https://api.github.com/repos/nio-blocks/state_change/contents/{+path}","compare_url":"https://api.github.com/repos/nio-blocks/state_change/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nio-blocks/state_change/merges","archive_url":"https://api.github.com/repos/nio-blocks/state_change/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nio-blocks/state_change/downloads","issues_url":"https://api.github.com/repos/nio-blocks/state_change/issues{/number}","pulls_url":"https://api.github.com/repos/nio-blocks/state_change/pulls{/number}","milestones_url":"https://api.github.com/repos/nio-blocks/state_change/milestones{/number}","notifications_url":"https://api.github.com/repos/nio-blocks/state_change/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nio-blocks/state_change/labels{/name}","releases_url":"https://api.github.com/repos/nio-blocks/state_change/releases{/id}","created_at":"2014-07-25T19:33:57Z","updated_at":"2015-01-14T01:17:59Z","pushed_at":"2015-03-05T20:48:43Z","git_url":"git://github.com/nio-blocks/state_change.git","ssh_url":"git@github.com:nio-blocks/state_change.git","clone_url":"https://github.com/nio-blocks/state_change.git","svn_url":"https://github.com/nio-blocks/state_change","homepage":null,"size":440,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nio-blocks/state_change/pulls/20"},"html":{"href":"https://github.com/nio-blocks/state_change/pull/20"},"issue":{"href":"https://api.github.com/repos/nio-blocks/state_change/issues/20"},"comments":{"href":"https://api.github.com/repos/nio-blocks/state_change/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/nio-blocks/state_change/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/nio-blocks/state_change/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nio-blocks/state_change/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/nio-blocks/state_change/statuses/235f430f573d2523d14f73771caa57d0448d2d21"}}}}