{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3547","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3547/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3547/comments","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3547/events","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3547","id":59245521,"number":3547,"title":"Mapannotation search fixes","user":{"login":"dominikl","id":6575139,"avatar_url":"https://avatars.githubusercontent.com/u/6575139?v=3","gravatar_id":"","url":"https://api.github.com/users/dominikl","html_url":"https://github.com/dominikl","followers_url":"https://api.github.com/users/dominikl/followers","following_url":"https://api.github.com/users/dominikl/following{/other_user}","gists_url":"https://api.github.com/users/dominikl/gists{/gist_id}","starred_url":"https://api.github.com/users/dominikl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominikl/subscriptions","organizations_url":"https://api.github.com/users/dominikl/orgs","repos_url":"https://api.github.com/users/dominikl/repos","events_url":"https://api.github.com/users/dominikl/events{/privacy}","received_events_url":"https://api.github.com/users/dominikl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-27T14:51:03Z","updated_at":"2015-02-27T23:20:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3547","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3547","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3547.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3547.patch"},"body":"Fixes the blockers discovered in todays testing session, see [GDoc](https://docs.google.com/spreadsheets/d/1nPQbPov8dwIlHswGey0K779JirYsjdEg2CKK5khtI9w/edit#gid=1171413927) - not ready for a final review yet.\r\n\r\nTest:\r\n- Search for a MapAnnotation key or value, when the checkbox \"Annotation\" is ticked. \r\n- Enter an invalid expression, e. g. a term with two colons asdf:123:asdf. You should see a message dialog, saying that the search expression is invalid and not the default error/crash dialog like before.\r\n- Enter something in the search field in the main toolbar, hit enter. The search panel on the left should open and show the same what you've entered in the main toolbar without a trailing space.\r\n\r\nA few minor issues still persist:\r\n- Plate runs are annotatable but not searchable (planning to fix that in this PR)\r\n- If you search for a specific key-value pair, dashes/underscores matter for the key but not for the value. E. g. foo_bar:value is not equivalent to foo-bar:value, whereas key:foo_bar is equivalent to key:foo-bar. The reason for this is - I suspect - that the key is fed to the indexer as 'field' and the value as 'content', which is treated differently by lucene. I suppose there is no easy solution for this, is there? @joshmoore On the other hand, this is probably a very minor issue anyway.\r\n\r\n/cc @pwalczysko "},"comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments/76491345","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3547#issuecomment-76491345","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3547","id":76491345,"user":{"login":"snoopycrimecop","id":2544838,"avatar_url":"https://avatars.githubusercontent.com/u/2544838?v=3","gravatar_id":"","url":"https://api.github.com/users/snoopycrimecop","html_url":"https://github.com/snoopycrimecop","followers_url":"https://api.github.com/users/snoopycrimecop/followers","following_url":"https://api.github.com/users/snoopycrimecop/following{/other_user}","gists_url":"https://api.github.com/users/snoopycrimecop/gists{/gist_id}","starred_url":"https://api.github.com/users/snoopycrimecop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoopycrimecop/subscriptions","organizations_url":"https://api.github.com/users/snoopycrimecop/orgs","repos_url":"https://api.github.com/users/snoopycrimecop/repos","events_url":"https://api.github.com/users/snoopycrimecop/events{/privacy}","received_events_url":"https://api.github.com/users/snoopycrimecop/received_events","type":"User","site_admin":false},"created_at":"2015-02-27T23:20:20Z","updated_at":"2015-02-27T23:20:20Z","body":"Conflicting PR. Removed from build [OME-5.1-merge-push#812](https://ci.openmicroscopy.org/job/OME-5.1-merge-push/812/). See the [console output](https://ci.openmicroscopy.org/job/OME-5.1-merge-push/812/consoleText) for more details.\nPossible conflicts:\n  - PR #3536 snoopycrimecop 'Update develop submodules'\n    - docs/sphinx\n    - components/bioformats"}}