{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/comments/37399269","id":37399269,"diff_hunk":"@@ -71,6 +71,10 @@ treeherderApp.controller('JobsCtrl', [\n             }\n         };\n \n+        if($location.search().revision === 'undefined'){\n+            thNotify.send(\"Revision Undefined\", \"danger\");","path":"ui/js/controllers/jobs.js","position":19,"original_position":19,"commit_id":"a63277c284ccf08aa6122ddccf25f3edfbb102ca","original_commit_id":"a63277c284ccf08aa6122ddccf25f3edfbb102ca","user":{"login":"maurodoglio","id":508377,"avatar_url":"https://avatars.githubusercontent.com/u/508377?v=3","gravatar_id":"","url":"https://api.github.com/users/maurodoglio","html_url":"https://github.com/maurodoglio","followers_url":"https://api.github.com/users/maurodoglio/followers","following_url":"https://api.github.com/users/maurodoglio/following{/other_user}","gists_url":"https://api.github.com/users/maurodoglio/gists{/gist_id}","starred_url":"https://api.github.com/users/maurodoglio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurodoglio/subscriptions","organizations_url":"https://api.github.com/users/maurodoglio/orgs","repos_url":"https://api.github.com/users/maurodoglio/repos","events_url":"https://api.github.com/users/maurodoglio/events{/privacy}","received_events_url":"https://api.github.com/users/maurodoglio/received_events","type":"User","site_admin":false},"body":"out of curiosity, what's the rationale for that?","created_at":"2015-08-19T10:16:20Z","updated_at":"2015-08-19T10:16:20Z","html_url":"https://github.com/mozilla/treeherder/pull/830#discussion_r37399269","pull_request_url":"https://api.github.com/repos/mozilla/treeherder/pulls/830","_links":{"self":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/comments/37399269"},"html":{"href":"https://github.com/mozilla/treeherder/pull/830#discussion_r37399269"},"pull_request":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/830"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/830","id":41626196,"html_url":"https://github.com/mozilla/treeherder/pull/830","diff_url":"https://github.com/mozilla/treeherder/pull/830.diff","patch_url":"https://github.com/mozilla/treeherder/pull/830.patch","issue_url":"https://api.github.com/repos/mozilla/treeherder/issues/830","number":830,"state":"open","locked":false,"title":"Bug 1046229 - Handle invalid values for 'revision' in the URL (eg \"%s\")","user":{"login":"gbrmachado","id":81703,"avatar_url":"https://avatars.githubusercontent.com/u/81703?v=3","gravatar_id":"","url":"https://api.github.com/users/gbrmachado","html_url":"https://github.com/gbrmachado","followers_url":"https://api.github.com/users/gbrmachado/followers","following_url":"https://api.github.com/users/gbrmachado/following{/other_user}","gists_url":"https://api.github.com/users/gbrmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/gbrmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbrmachado/subscriptions","organizations_url":"https://api.github.com/users/gbrmachado/orgs","repos_url":"https://api.github.com/users/gbrmachado/repos","events_url":"https://api.github.com/users/gbrmachado/events{/privacy}","received_events_url":"https://api.github.com/users/gbrmachado/received_events","type":"User","site_admin":false},"body":"This first pull request is not working properly.\r\nWhen the link http://local.treeherder.mozilla.org/index.html#/jobs?repo=mozilla-inbound&revision=%s\r\nis clicked, it is redirected to \r\nhttp://local.treeherder.mozilla.org/index.html#/jobs?repo=mozilla-inbound&revision=undefined\r\nwithout any error alert.\r\n\r\nHowever, when the link\r\nhttp://local.treeherder.mozilla.org/index.html#/jobs?repo=mozilla-inbound&revision=undefined\r\nis clicked. An error is showed.\r\n\r\nBesides, the error messages are not completely right.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/mozilla/treeherder/830)\n<!-- Reviewable:end -->\n","created_at":"2015-08-04T22:41:25Z","updated_at":"2015-08-19T10:16:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4de2b5a281cd35e204f19b75a6947e62d33918a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/treeherder/pulls/830/commits","review_comments_url":"https://api.github.com/repos/mozilla/treeherder/pulls/830/comments","review_comment_url":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/treeherder/issues/830/comments","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/a63277c284ccf08aa6122ddccf25f3edfbb102ca","head":{"label":"gbrmachado:Bug-1046229","ref":"Bug-1046229","sha":"a63277c284ccf08aa6122ddccf25f3edfbb102ca","user":{"login":"gbrmachado","id":81703,"avatar_url":"https://avatars.githubusercontent.com/u/81703?v=3","gravatar_id":"","url":"https://api.github.com/users/gbrmachado","html_url":"https://github.com/gbrmachado","followers_url":"https://api.github.com/users/gbrmachado/followers","following_url":"https://api.github.com/users/gbrmachado/following{/other_user}","gists_url":"https://api.github.com/users/gbrmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/gbrmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbrmachado/subscriptions","organizations_url":"https://api.github.com/users/gbrmachado/orgs","repos_url":"https://api.github.com/users/gbrmachado/repos","events_url":"https://api.github.com/users/gbrmachado/events{/privacy}","received_events_url":"https://api.github.com/users/gbrmachado/received_events","type":"User","site_admin":false},"repo":{"id":38535862,"name":"treeherder","full_name":"gbrmachado/treeherder","owner":{"login":"gbrmachado","id":81703,"avatar_url":"https://avatars.githubusercontent.com/u/81703?v=3","gravatar_id":"","url":"https://api.github.com/users/gbrmachado","html_url":"https://github.com/gbrmachado","followers_url":"https://api.github.com/users/gbrmachado/followers","following_url":"https://api.github.com/users/gbrmachado/following{/other_user}","gists_url":"https://api.github.com/users/gbrmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/gbrmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbrmachado/subscriptions","organizations_url":"https://api.github.com/users/gbrmachado/orgs","repos_url":"https://api.github.com/users/gbrmachado/repos","events_url":"https://api.github.com/users/gbrmachado/events{/privacy}","received_events_url":"https://api.github.com/users/gbrmachado/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbrmachado/treeherder","description":"A reporting dashboard & service for managing CI data for commits to Mozilla projects","fork":true,"url":"https://api.github.com/repos/gbrmachado/treeherder","forks_url":"https://api.github.com/repos/gbrmachado/treeherder/forks","keys_url":"https://api.github.com/repos/gbrmachado/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbrmachado/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbrmachado/treeherder/teams","hooks_url":"https://api.github.com/repos/gbrmachado/treeherder/hooks","issue_events_url":"https://api.github.com/repos/gbrmachado/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/gbrmachado/treeherder/events","assignees_url":"https://api.github.com/repos/gbrmachado/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/gbrmachado/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/gbrmachado/treeherder/tags","blobs_url":"https://api.github.com/repos/gbrmachado/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbrmachado/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbrmachado/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbrmachado/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbrmachado/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/gbrmachado/treeherder/languages","stargazers_url":"https://api.github.com/repos/gbrmachado/treeherder/stargazers","contributors_url":"https://api.github.com/repos/gbrmachado/treeherder/contributors","subscribers_url":"https://api.github.com/repos/gbrmachado/treeherder/subscribers","subscription_url":"https://api.github.com/repos/gbrmachado/treeherder/subscription","commits_url":"https://api.github.com/repos/gbrmachado/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbrmachado/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbrmachado/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbrmachado/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbrmachado/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/gbrmachado/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbrmachado/treeherder/merges","archive_url":"https://api.github.com/repos/gbrmachado/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbrmachado/treeherder/downloads","issues_url":"https://api.github.com/repos/gbrmachado/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/gbrmachado/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/gbrmachado/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/gbrmachado/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbrmachado/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/gbrmachado/treeherder/releases{/id}","created_at":"2015-07-04T14:08:41Z","updated_at":"2015-07-04T14:08:42Z","pushed_at":"2015-08-19T00:13:58Z","git_url":"git://github.com/gbrmachado/treeherder.git","ssh_url":"git@github.com:gbrmachado/treeherder.git","clone_url":"https://github.com/gbrmachado/treeherder.git","svn_url":"https://github.com/gbrmachado/treeherder","homepage":"https://wiki.mozilla.org/Auto-tools/Projects/Treeherder","size":34259,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"392af575dc9bfba4000457b905a2cc919ea97b26","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8463294,"name":"treeherder","full_name":"mozilla/treeherder","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/treeherder","description":"A reporting dashboard & service for managing CI data for commits to Mozilla projects","fork":false,"url":"https://api.github.com/repos/mozilla/treeherder","forks_url":"https://api.github.com/repos/mozilla/treeherder/forks","keys_url":"https://api.github.com/repos/mozilla/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/treeherder/teams","hooks_url":"https://api.github.com/repos/mozilla/treeherder/hooks","issue_events_url":"https://api.github.com/repos/mozilla/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/treeherder/events","assignees_url":"https://api.github.com/repos/mozilla/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/treeherder/tags","blobs_url":"https://api.github.com/repos/mozilla/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/treeherder/languages","stargazers_url":"https://api.github.com/repos/mozilla/treeherder/stargazers","contributors_url":"https://api.github.com/repos/mozilla/treeherder/contributors","subscribers_url":"https://api.github.com/repos/mozilla/treeherder/subscribers","subscription_url":"https://api.github.com/repos/mozilla/treeherder/subscription","commits_url":"https://api.github.com/repos/mozilla/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/treeherder/merges","archive_url":"https://api.github.com/repos/mozilla/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/treeherder/downloads","issues_url":"https://api.github.com/repos/mozilla/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/treeherder/releases{/id}","created_at":"2013-02-27T19:17:37Z","updated_at":"2015-07-02T05:58:54Z","pushed_at":"2015-08-19T09:26:20Z","git_url":"git://github.com/mozilla/treeherder.git","ssh_url":"git@github.com:mozilla/treeherder.git","clone_url":"https://github.com/mozilla/treeherder.git","svn_url":"https://github.com/mozilla/treeherder","homepage":"https://wiki.mozilla.org/Auto-tools/Projects/Treeherder","size":401759,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":21,"forks":64,"open_issues":21,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/830"},"html":{"href":"https://github.com/mozilla/treeherder/pull/830"},"issue":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/830"},"comments":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/830/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/830/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/830/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/treeherder/statuses/a63277c284ccf08aa6122ddccf25f3edfbb102ca"}}}}