{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/718","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/718/labels{/name}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/718/comments","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/718/events","html_url":"https://github.com/facebook/AsyncDisplayKit/issues/718","id":110060835,"number":718,"title":"ASNetworkImageNode with unknown height don't update ASCellNode's height","user":{"login":"vitalybaev","id":724423,"avatar_url":"https://avatars.githubusercontent.com/u/724423?v=3","gravatar_id":"","url":"https://api.github.com/users/vitalybaev","html_url":"https://github.com/vitalybaev","followers_url":"https://api.github.com/users/vitalybaev/followers","following_url":"https://api.github.com/users/vitalybaev/following{/other_user}","gists_url":"https://api.github.com/users/vitalybaev/gists{/gist_id}","starred_url":"https://api.github.com/users/vitalybaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitalybaev/subscriptions","organizations_url":"https://api.github.com/users/vitalybaev/orgs","repos_url":"https://api.github.com/users/vitalybaev/repos","events_url":"https://api.github.com/users/vitalybaev/events{/privacy}","received_events_url":"https://api.github.com/users/vitalybaev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-06T17:38:12Z","updated_at":"2015-10-06T17:57:26Z","closed_at":null,"body":"Hi! There is ASCellNode with vertical ASStackLayoutSpec with 3 children:\r\n- ASTextNode - Title\r\n- ASNetworkImageNode - Some internet image with various size\r\n- ASTextNode - Some text\r\n\r\nWhen image not yet downloaded I'd like to place gray placeholder (horizontal rectangle, like in Twitter app), but when image downloaded it had to be full size.\r\n\r\nHere is test project https://github.com/vitalybaev/Test-ASDK of this\r\n\r\nWhen image downloaded, ASCellNode's size doesn't changed. So if image height greater than placeholder's height - there is white gap, if less than placeholder - some content doesn't visible;\r\n\r\nGot:\r\n![screen shot 2015-10-06 at 20 36 53](https://cloud.githubusercontent.com/assets/724423/10316840/08a59c16-6c6a-11e5-9f29-0bb27759dbfb.png)\r\nExpect \r\n![screen shot 2015-10-06 at 20 36 59](https://cloud.githubusercontent.com/assets/724423/10316861/1dd8ebc4-6c6a-11e5-879a-5c6ac4014a40.png)\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments/145946572","html_url":"https://github.com/facebook/AsyncDisplayKit/issues/718#issuecomment-145946572","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/718","id":145946572,"user":{"login":"appleguy","id":565251,"avatar_url":"https://avatars.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"created_at":"2015-10-06T17:57:26Z","updated_at":"2015-10-06T17:57:26Z","body":"Quick response — have you tried using preferredFrameSize?  Especially if you are using ASLayoutSpec to position everything, this will ensure the image is shown at the desired size even when the placeholder state (e.g. background color, or a default image you set for .placeholderImage) is shown.\n\n> On Oct 6, 2015, at 10:38 AM, Vitaly Baev <notifications@github.com> wrote:\n> \n> Hi! There is ASCellNode with vertical ASStackLayoutSpec with 3 children:\n> \n> ASTextNode - Title\n> ASNetworkImageNode - Some internet image with various size\n> ASTextNode - Some text\n> When image not yet downloaded I'd like to place gray placeholder (horizontal rectangle, like in Twitter app), but when image downloaded it had to be full size.\n> \n> Here is test project https://github.com/vitalybaev/Test-ASDK <https://github.com/vitalybaev/Test-ASDK> of this\n> \n> When image downloaded, ASCellNode's size doesn't changed. So if image height greater than placeholder's height - there is white gap, if less than placeholder - some content doesn't visible;\n> \n> Got:\n>  <https://cloud.githubusercontent.com/assets/724423/10316840/08a59c16-6c6a-11e5-9f29-0bb27759dbfb.png>\n> Expect \n>  <https://cloud.githubusercontent.com/assets/724423/10316861/1dd8ebc4-6c6a-11e5-879a-5c6ac4014a40.png>\n> —\n> Reply to this email directly or view it on GitHub <https://github.com/facebook/AsyncDisplayKit/issues/718>.\n> \n\n"}}