{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/30072810","id":30072810,"diff_hunk":"@@ -3,30 +3,26 @@ class NameCollisionError < RuntimeError; end\n class Robot\n   attr_accessor :name\n \n-  @@registry\n-\n-  def initialize(args = {})\n+  def initialize\n     @@registry ||= []\n-    @name_generator = args[:name_generator]\n-\n-    if @name_generator\n-      @name = @name_generator.call\n-    else\n-      generate_char = -> { ('A'..'Z').to_a.sample }\n-      generate_num = -> { rand(10) }\n+    @name = generate_name(2, 3)\n+    @@registry << @name\n+  end\n \n-      @name = \"#{generate_char.call}#{generate_char.call}#{generate_num.call}#{generate_num.call}#{generate_num.call}\"\n+  def generate_name(number_of_letters, number_of_digits)\n+    new_name = ''\n+    (1..number_of_letters).each { new_name += ('A'..'Z').to_a.sample }\n+    (1..number_of_digits).each { new_name += rand(10).to_s }\n+    unless name_exists(new_name)","path":"robot_name/robot_name.rb","position":25,"original_position":25,"commit_id":"895a4661e4298ae76be5cfced904fcc18153b57a","original_commit_id":"895a4661e4298ae76be5cfced904fcc18153b57a","user":{"login":"djkotowski","id":2326295,"avatar_url":"https://avatars.githubusercontent.com/u/2326295?v=3","gravatar_id":"","url":"https://api.github.com/users/djkotowski","html_url":"https://github.com/djkotowski","followers_url":"https://api.github.com/users/djkotowski/followers","following_url":"https://api.github.com/users/djkotowski/following{/other_user}","gists_url":"https://api.github.com/users/djkotowski/gists{/gist_id}","starred_url":"https://api.github.com/users/djkotowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djkotowski/subscriptions","organizations_url":"https://api.github.com/users/djkotowski/orgs","repos_url":"https://api.github.com/users/djkotowski/repos","events_url":"https://api.github.com/users/djkotowski/events{/privacy}","received_events_url":"https://api.github.com/users/djkotowski/received_events","type":"User","site_admin":false},"body":"Isn't the error supposed to be raised _if_ the name exists?","created_at":"2015-05-11T19:27:19Z","updated_at":"2015-05-11T19:27:19Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/647#discussion_r30072810","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/647","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/30072810"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/647#discussion_r30072810"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/647"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/647","id":34872690,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/647","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/647.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/647.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/647","number":647,"state":"open","locked":false,"title":"Ruby Basics Refactored","user":{"login":"dustinhansen","id":455498,"avatar_url":"https://avatars.githubusercontent.com/u/455498?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinhansen","html_url":"https://github.com/dustinhansen","followers_url":"https://api.github.com/users/dustinhansen/followers","following_url":"https://api.github.com/users/dustinhansen/following{/other_user}","gists_url":"https://api.github.com/users/dustinhansen/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinhansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinhansen/subscriptions","organizations_url":"https://api.github.com/users/dustinhansen/orgs","repos_url":"https://api.github.com/users/dustinhansen/repos","events_url":"https://api.github.com/users/dustinhansen/events{/privacy}","received_events_url":"https://api.github.com/users/dustinhansen/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-07T00:04:39Z","updated_at":"2015-05-11T19:27:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17b5b6d585aa021117468474faab947f4268546f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/647/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/647/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/647/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/895a4661e4298ae76be5cfced904fcc18153b57a","head":{"label":"dustinhansen:Ruby-Basics-Exercises","ref":"Ruby-Basics-Exercises","sha":"895a4661e4298ae76be5cfced904fcc18153b57a","user":{"login":"dustinhansen","id":455498,"avatar_url":"https://avatars.githubusercontent.com/u/455498?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinhansen","html_url":"https://github.com/dustinhansen","followers_url":"https://api.github.com/users/dustinhansen/followers","following_url":"https://api.github.com/users/dustinhansen/following{/other_user}","gists_url":"https://api.github.com/users/dustinhansen/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinhansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinhansen/subscriptions","organizations_url":"https://api.github.com/users/dustinhansen/orgs","repos_url":"https://api.github.com/users/dustinhansen/repos","events_url":"https://api.github.com/users/dustinhansen/events{/privacy}","received_events_url":"https://api.github.com/users/dustinhansen/received_events","type":"User","site_admin":false},"repo":{"id":34863904,"name":"level_up_exercises","full_name":"dustinhansen/level_up_exercises","owner":{"login":"dustinhansen","id":455498,"avatar_url":"https://avatars.githubusercontent.com/u/455498?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinhansen","html_url":"https://github.com/dustinhansen","followers_url":"https://api.github.com/users/dustinhansen/followers","following_url":"https://api.github.com/users/dustinhansen/following{/other_user}","gists_url":"https://api.github.com/users/dustinhansen/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinhansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinhansen/subscriptions","organizations_url":"https://api.github.com/users/dustinhansen/orgs","repos_url":"https://api.github.com/users/dustinhansen/repos","events_url":"https://api.github.com/users/dustinhansen/events{/privacy}","received_events_url":"https://api.github.com/users/dustinhansen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dustinhansen/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/dustinhansen/level_up_exercises","forks_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/forks","keys_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/events","assignees_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/merges","archive_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/dustinhansen/level_up_exercises/releases{/id}","created_at":"2015-04-30T16:08:59Z","updated_at":"2015-05-05T22:06:42Z","pushed_at":"2015-05-07T00:01:06Z","git_url":"git://github.com/dustinhansen/level_up_exercises.git","ssh_url":"git@github.com:dustinhansen/level_up_exercises.git","clone_url":"https://github.com/dustinhansen/level_up_exercises.git","svn_url":"https://github.com/dustinhansen/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":409,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"b941842eff3e5c5063d323069d7096d066054ef4","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-04-28T21:36:55Z","pushed_at":"2015-05-07T15:26:41Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":149181,"stargazers_count":22,"watchers_count":22,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":1,"forks":91,"open_issues":1,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/647"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/647"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/647"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/647/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/647/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/647/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/895a4661e4298ae76be5cfced904fcc18153b57a"}}}}