{"action":"created","comment":{"url":"https://api.github.com/repos/google/protobuf/pulls/comments/41324777","id":41324777,"diff_hunk":"@@ -131,6 +123,12 @@ def run(self):\n     # Generate necessary .proto file if it doesn't exist.\n     generate_proto(\"../src/google/protobuf/descriptor.proto\")\n     generate_proto(\"../src/google/protobuf/compiler/plugin.proto\")\n+    generate_proto(\"../src/google/protobuf/timestamp.proto\")","path":"python/setup.py","position":null,"original_position":19,"commit_id":"f6fa5c78829c8369523a844f3ef682353594680b","original_commit_id":"7464f40a7e1fa6d5d0c3d4131720e7863d864eb8","user":{"login":"pherl","id":315593,"avatar_url":"https://avatars.githubusercontent.com/u/315593?v=3","gravatar_id":"","url":"https://api.github.com/users/pherl","html_url":"https://github.com/pherl","followers_url":"https://api.github.com/users/pherl/followers","following_url":"https://api.github.com/users/pherl/following{/other_user}","gists_url":"https://api.github.com/users/pherl/gists{/gist_id}","starred_url":"https://api.github.com/users/pherl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pherl/subscriptions","organizations_url":"https://api.github.com/users/pherl/orgs","repos_url":"https://api.github.com/users/pherl/repos","events_url":"https://api.github.com/users/pherl/events{/privacy}","received_events_url":"https://api.github.com/users/pherl/received_events","type":"User","site_admin":false},"body":"Done\n\nOn Tue, Oct 6, 2015 at 2:23 PM Feng Xiao <notifications@github.com> wrote:\n\n> In python/setup.py\n> <https://github.com/google/protobuf/pull/860#discussion_r41324362>:\n>\n> > @@ -131,6 +123,12 @@ def run(self):\n> >      # Generate necessary .proto file if it doesn't exist.\n> >      generate_proto(\"../src/google/protobuf/descriptor.proto\")\n> >      generate_proto(\"../src/google/protobuf/compiler/plugin.proto\")\n> > +    generate_proto(\"../src/google/protobuf/timestamp.proto\")\n>\n> This list is not complete. See the complete list here:\n> https://github.com/google/protobuf/blob/master/src/Makefile.am#L35\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/google/protobuf/pull/860/files#r41324362>.\n>\n","created_at":"2015-10-06T21:26:34Z","updated_at":"2015-10-06T21:26:34Z","html_url":"https://github.com/google/protobuf/pull/860#discussion_r41324777","pull_request_url":"https://api.github.com/repos/google/protobuf/pulls/860","_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments/41324777"},"html":{"href":"https://github.com/google/protobuf/pull/860#discussion_r41324777"},"pull_request":{"href":"https://api.github.com/repos/google/protobuf/pulls/860"}}},"pull_request":{"url":"https://api.github.com/repos/google/protobuf/pulls/860","id":46959454,"html_url":"https://github.com/google/protobuf/pull/860","diff_url":"https://github.com/google/protobuf/pull/860.diff","patch_url":"https://github.com/google/protobuf/pull/860.patch","issue_url":"https://api.github.com/repos/google/protobuf/issues/860","number":860,"state":"open","locked":false,"title":"Generate well known types for python.","user":{"login":"pherl","id":315593,"avatar_url":"https://avatars.githubusercontent.com/u/315593?v=3","gravatar_id":"","url":"https://api.github.com/users/pherl","html_url":"https://github.com/pherl","followers_url":"https://api.github.com/users/pherl/followers","following_url":"https://api.github.com/users/pherl/following{/other_user}","gists_url":"https://api.github.com/users/pherl/gists{/gist_id}","starred_url":"https://api.github.com/users/pherl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pherl/subscriptions","organizations_url":"https://api.github.com/users/pherl/orgs","repos_url":"https://api.github.com/users/pherl/repos","events_url":"https://api.github.com/users/pherl/events{/privacy}","received_events_url":"https://api.github.com/users/pherl/received_events","type":"User","site_admin":false},"body":"@xfxyjwf @haberman for review.","created_at":"2015-10-06T21:21:04Z","updated_at":"2015-10-06T21:26:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1702d70c87daf05165acb7a902a1f020736b837","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/protobuf/pulls/860/commits","review_comments_url":"https://api.github.com/repos/google/protobuf/pulls/860/comments","review_comment_url":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/protobuf/issues/860/comments","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/f6fa5c78829c8369523a844f3ef682353594680b","head":{"label":"pherl:master","ref":"master","sha":"f6fa5c78829c8369523a844f3ef682353594680b","user":{"login":"pherl","id":315593,"avatar_url":"https://avatars.githubusercontent.com/u/315593?v=3","gravatar_id":"","url":"https://api.github.com/users/pherl","html_url":"https://github.com/pherl","followers_url":"https://api.github.com/users/pherl/followers","following_url":"https://api.github.com/users/pherl/following{/other_user}","gists_url":"https://api.github.com/users/pherl/gists{/gist_id}","starred_url":"https://api.github.com/users/pherl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pherl/subscriptions","organizations_url":"https://api.github.com/users/pherl/orgs","repos_url":"https://api.github.com/users/pherl/repos","events_url":"https://api.github.com/users/pherl/events{/privacy}","received_events_url":"https://api.github.com/users/pherl/received_events","type":"User","site_admin":false},"repo":{"id":27149978,"name":"protobuf","full_name":"pherl/protobuf","owner":{"login":"pherl","id":315593,"avatar_url":"https://avatars.githubusercontent.com/u/315593?v=3","gravatar_id":"","url":"https://api.github.com/users/pherl","html_url":"https://github.com/pherl","followers_url":"https://api.github.com/users/pherl/followers","following_url":"https://api.github.com/users/pherl/following{/other_user}","gists_url":"https://api.github.com/users/pherl/gists{/gist_id}","starred_url":"https://api.github.com/users/pherl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pherl/subscriptions","organizations_url":"https://api.github.com/users/pherl/orgs","repos_url":"https://api.github.com/users/pherl/repos","events_url":"https://api.github.com/users/pherl/events{/privacy}","received_events_url":"https://api.github.com/users/pherl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pherl/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":true,"url":"https://api.github.com/repos/pherl/protobuf","forks_url":"https://api.github.com/repos/pherl/protobuf/forks","keys_url":"https://api.github.com/repos/pherl/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pherl/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pherl/protobuf/teams","hooks_url":"https://api.github.com/repos/pherl/protobuf/hooks","issue_events_url":"https://api.github.com/repos/pherl/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/pherl/protobuf/events","assignees_url":"https://api.github.com/repos/pherl/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/pherl/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/pherl/protobuf/tags","blobs_url":"https://api.github.com/repos/pherl/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pherl/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pherl/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/pherl/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pherl/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/pherl/protobuf/languages","stargazers_url":"https://api.github.com/repos/pherl/protobuf/stargazers","contributors_url":"https://api.github.com/repos/pherl/protobuf/contributors","subscribers_url":"https://api.github.com/repos/pherl/protobuf/subscribers","subscription_url":"https://api.github.com/repos/pherl/protobuf/subscription","commits_url":"https://api.github.com/repos/pherl/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/pherl/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/pherl/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/pherl/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/pherl/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/pherl/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pherl/protobuf/merges","archive_url":"https://api.github.com/repos/pherl/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pherl/protobuf/downloads","issues_url":"https://api.github.com/repos/pherl/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/pherl/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/pherl/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/pherl/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pherl/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/pherl/protobuf/releases{/id}","created_at":"2014-11-25T22:54:13Z","updated_at":"2015-08-20T20:43:07Z","pushed_at":"2015-10-06T21:26:15Z","git_url":"git://github.com/pherl/protobuf.git","ssh_url":"git@github.com:pherl/protobuf.git","clone_url":"https://github.com/pherl/protobuf.git","svn_url":"https://github.com/pherl/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":32745,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"878b603d328697a027264c3f195df9b5981a4129","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":23357588,"name":"protobuf","full_name":"google/protobuf","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":false,"url":"https://api.github.com/repos/google/protobuf","forks_url":"https://api.github.com/repos/google/protobuf/forks","keys_url":"https://api.github.com/repos/google/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/protobuf/teams","hooks_url":"https://api.github.com/repos/google/protobuf/hooks","issue_events_url":"https://api.github.com/repos/google/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/google/protobuf/events","assignees_url":"https://api.github.com/repos/google/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/google/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/google/protobuf/tags","blobs_url":"https://api.github.com/repos/google/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/protobuf/languages","stargazers_url":"https://api.github.com/repos/google/protobuf/stargazers","contributors_url":"https://api.github.com/repos/google/protobuf/contributors","subscribers_url":"https://api.github.com/repos/google/protobuf/subscribers","subscription_url":"https://api.github.com/repos/google/protobuf/subscription","commits_url":"https://api.github.com/repos/google/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/google/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/protobuf/merges","archive_url":"https://api.github.com/repos/google/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/protobuf/downloads","issues_url":"https://api.github.com/repos/google/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/google/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/google/protobuf/releases{/id}","created_at":"2014-08-26T15:52:15Z","updated_at":"2015-10-06T20:49:10Z","pushed_at":"2015-10-06T21:26:15Z","git_url":"git://github.com/google/protobuf.git","ssh_url":"git@github.com:google/protobuf.git","clone_url":"https://github.com/google/protobuf.git","svn_url":"https://github.com/google/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":52502,"stargazers_count":5316,"watchers_count":5316,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1484,"mirror_url":null,"open_issues_count":249,"forks":1484,"open_issues":249,"watchers":5316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/860"},"html":{"href":"https://github.com/google/protobuf/pull/860"},"issue":{"href":"https://api.github.com/repos/google/protobuf/issues/860"},"comments":{"href":"https://api.github.com/repos/google/protobuf/issues/860/comments"},"review_comments":{"href":"https://api.github.com/repos/google/protobuf/pulls/860/comments"},"review_comment":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/protobuf/pulls/860/commits"},"statuses":{"href":"https://api.github.com/repos/google/protobuf/statuses/f6fa5c78829c8369523a844f3ef682353594680b"}}}}