{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/epics-base/pvDataCPP/pulls/8","id":40009335,"html_url":"https://github.com/epics-base/pvDataCPP/pull/8","diff_url":"https://github.com/epics-base/pvDataCPP/pull/8.diff","patch_url":"https://github.com/epics-base/pvDataCPP/pull/8.patch","issue_url":"https://api.github.com/repos/epics-base/pvDataCPP/issues/8","number":8,"state":"closed","locked":false,"title":"Move getSubFieldT definitions out of class body","user":{"login":"dhickin","id":6115551,"avatar_url":"https://avatars.githubusercontent.com/u/6115551?v=3","gravatar_id":"","url":"https://api.github.com/users/dhickin","html_url":"https://github.com/dhickin","followers_url":"https://api.github.com/users/dhickin/followers","following_url":"https://api.github.com/users/dhickin/following{/other_user}","gists_url":"https://api.github.com/users/dhickin/gists{/gist_id}","starred_url":"https://api.github.com/users/dhickin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhickin/subscriptions","organizations_url":"https://api.github.com/users/dhickin/orgs","repos_url":"https://api.github.com/users/dhickin/repos","events_url":"https://api.github.com/users/dhickin/events{/privacy}","received_events_url":"https://api.github.com/users/dhickin/received_events","type":"User","site_admin":false},"body":"<p>Move definitions of 2 getSubFieldT overloads:</p>\r\n\r\n<ol>\r\n<li>shared_ptr<PVT> PVStructure::getSubFieldT(const char *name) const\r\n<li>shared_ptr<PVT> PVStructure::getSubFieldT(size_t fieldOffset) const\r\n</ol>\r\n\r\n<p>out of function body so not implicitly inlined.</p>\r\n\r\n<p>Implementation now uses stringstream. Moving outside class to avoid code bloat.</p>","created_at":"2015-07-15T10:43:14Z","updated_at":"2015-09-01T16:03:15Z","closed_at":"2015-09-01T16:03:15Z","merged_at":"2015-09-01T16:03:15Z","merge_commit_sha":"59c4a67e258c47c0a005d22c67cebf5fd7497ab9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/epics-base/pvDataCPP/pulls/8/commits","review_comments_url":"https://api.github.com/repos/epics-base/pvDataCPP/pulls/8/comments","review_comment_url":"https://api.github.com/repos/epics-base/pvDataCPP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/epics-base/pvDataCPP/issues/8/comments","statuses_url":"https://api.github.com/repos/epics-base/pvDataCPP/statuses/52bc6d060d372b1e02e3e02b2c9ac87fc51238f7","head":{"label":"dhickin:move_getSubFieldT_def_from_class_body","ref":"move_getSubFieldT_def_from_class_body","sha":"52bc6d060d372b1e02e3e02b2c9ac87fc51238f7","user":{"login":"dhickin","id":6115551,"avatar_url":"https://avatars.githubusercontent.com/u/6115551?v=3","gravatar_id":"","url":"https://api.github.com/users/dhickin","html_url":"https://github.com/dhickin","followers_url":"https://api.github.com/users/dhickin/followers","following_url":"https://api.github.com/users/dhickin/following{/other_user}","gists_url":"https://api.github.com/users/dhickin/gists{/gist_id}","starred_url":"https://api.github.com/users/dhickin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhickin/subscriptions","organizations_url":"https://api.github.com/users/dhickin/orgs","repos_url":"https://api.github.com/users/dhickin/repos","events_url":"https://api.github.com/users/dhickin/events{/privacy}","received_events_url":"https://api.github.com/users/dhickin/received_events","type":"User","site_admin":false},"repo":{"id":37605762,"name":"pvDataCPP","full_name":"dhickin/pvDataCPP","owner":{"login":"dhickin","id":6115551,"avatar_url":"https://avatars.githubusercontent.com/u/6115551?v=3","gravatar_id":"","url":"https://api.github.com/users/dhickin","html_url":"https://github.com/dhickin","followers_url":"https://api.github.com/users/dhickin/followers","following_url":"https://api.github.com/users/dhickin/following{/other_user}","gists_url":"https://api.github.com/users/dhickin/gists{/gist_id}","starred_url":"https://api.github.com/users/dhickin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhickin/subscriptions","organizations_url":"https://api.github.com/users/dhickin/orgs","repos_url":"https://api.github.com/users/dhickin/repos","events_url":"https://api.github.com/users/dhickin/events{/privacy}","received_events_url":"https://api.github.com/users/dhickin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhickin/pvDataCPP","description":"","fork":true,"url":"https://api.github.com/repos/dhickin/pvDataCPP","forks_url":"https://api.github.com/repos/dhickin/pvDataCPP/forks","keys_url":"https://api.github.com/repos/dhickin/pvDataCPP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhickin/pvDataCPP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhickin/pvDataCPP/teams","hooks_url":"https://api.github.com/repos/dhickin/pvDataCPP/hooks","issue_events_url":"https://api.github.com/repos/dhickin/pvDataCPP/issues/events{/number}","events_url":"https://api.github.com/repos/dhickin/pvDataCPP/events","assignees_url":"https://api.github.com/repos/dhickin/pvDataCPP/assignees{/user}","branches_url":"https://api.github.com/repos/dhickin/pvDataCPP/branches{/branch}","tags_url":"https://api.github.com/repos/dhickin/pvDataCPP/tags","blobs_url":"https://api.github.com/repos/dhickin/pvDataCPP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhickin/pvDataCPP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhickin/pvDataCPP/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhickin/pvDataCPP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhickin/pvDataCPP/statuses/{sha}","languages_url":"https://api.github.com/repos/dhickin/pvDataCPP/languages","stargazers_url":"https://api.github.com/repos/dhickin/pvDataCPP/stargazers","contributors_url":"https://api.github.com/repos/dhickin/pvDataCPP/contributors","subscribers_url":"https://api.github.com/repos/dhickin/pvDataCPP/subscribers","subscription_url":"https://api.github.com/repos/dhickin/pvDataCPP/subscription","commits_url":"https://api.github.com/repos/dhickin/pvDataCPP/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhickin/pvDataCPP/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhickin/pvDataCPP/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhickin/pvDataCPP/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhickin/pvDataCPP/contents/{+path}","compare_url":"https://api.github.com/repos/dhickin/pvDataCPP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhickin/pvDataCPP/merges","archive_url":"https://api.github.com/repos/dhickin/pvDataCPP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhickin/pvDataCPP/downloads","issues_url":"https://api.github.com/repos/dhickin/pvDataCPP/issues{/number}","pulls_url":"https://api.github.com/repos/dhickin/pvDataCPP/pulls{/number}","milestones_url":"https://api.github.com/repos/dhickin/pvDataCPP/milestones{/number}","notifications_url":"https://api.github.com/repos/dhickin/pvDataCPP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhickin/pvDataCPP/labels{/name}","releases_url":"https://api.github.com/repos/dhickin/pvDataCPP/releases{/id}","created_at":"2015-06-17T16:07:31Z","updated_at":"2015-06-17T16:07:32Z","pushed_at":"2015-08-13T10:24:07Z","git_url":"git://github.com/dhickin/pvDataCPP.git","ssh_url":"git@github.com:dhickin/pvDataCPP.git","clone_url":"https://github.com/dhickin/pvDataCPP.git","svn_url":"https://github.com/dhickin/pvDataCPP","homepage":null,"size":6797,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"epics-base:master","ref":"master","sha":"35ca5f3aedc40374028ede763899330e286fd487","user":{"login":"epics-base","id":10711129,"avatar_url":"https://avatars.githubusercontent.com/u/10711129?v=3","gravatar_id":"","url":"https://api.github.com/users/epics-base","html_url":"https://github.com/epics-base","followers_url":"https://api.github.com/users/epics-base/followers","following_url":"https://api.github.com/users/epics-base/following{/other_user}","gists_url":"https://api.github.com/users/epics-base/gists{/gist_id}","starred_url":"https://api.github.com/users/epics-base/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epics-base/subscriptions","organizations_url":"https://api.github.com/users/epics-base/orgs","repos_url":"https://api.github.com/users/epics-base/repos","events_url":"https://api.github.com/users/epics-base/events{/privacy}","received_events_url":"https://api.github.com/users/epics-base/received_events","type":"Organization","site_admin":false},"repo":{"id":29925681,"name":"pvDataCPP","full_name":"epics-base/pvDataCPP","owner":{"login":"epics-base","id":10711129,"avatar_url":"https://avatars.githubusercontent.com/u/10711129?v=3","gravatar_id":"","url":"https://api.github.com/users/epics-base","html_url":"https://github.com/epics-base","followers_url":"https://api.github.com/users/epics-base/followers","following_url":"https://api.github.com/users/epics-base/following{/other_user}","gists_url":"https://api.github.com/users/epics-base/gists{/gist_id}","starred_url":"https://api.github.com/users/epics-base/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epics-base/subscriptions","organizations_url":"https://api.github.com/users/epics-base/orgs","repos_url":"https://api.github.com/users/epics-base/repos","events_url":"https://api.github.com/users/epics-base/events{/privacy}","received_events_url":"https://api.github.com/users/epics-base/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/epics-base/pvDataCPP","description":"","fork":false,"url":"https://api.github.com/repos/epics-base/pvDataCPP","forks_url":"https://api.github.com/repos/epics-base/pvDataCPP/forks","keys_url":"https://api.github.com/repos/epics-base/pvDataCPP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epics-base/pvDataCPP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epics-base/pvDataCPP/teams","hooks_url":"https://api.github.com/repos/epics-base/pvDataCPP/hooks","issue_events_url":"https://api.github.com/repos/epics-base/pvDataCPP/issues/events{/number}","events_url":"https://api.github.com/repos/epics-base/pvDataCPP/events","assignees_url":"https://api.github.com/repos/epics-base/pvDataCPP/assignees{/user}","branches_url":"https://api.github.com/repos/epics-base/pvDataCPP/branches{/branch}","tags_url":"https://api.github.com/repos/epics-base/pvDataCPP/tags","blobs_url":"https://api.github.com/repos/epics-base/pvDataCPP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epics-base/pvDataCPP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epics-base/pvDataCPP/git/refs{/sha}","trees_url":"https://api.github.com/repos/epics-base/pvDataCPP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epics-base/pvDataCPP/statuses/{sha}","languages_url":"https://api.github.com/repos/epics-base/pvDataCPP/languages","stargazers_url":"https://api.github.com/repos/epics-base/pvDataCPP/stargazers","contributors_url":"https://api.github.com/repos/epics-base/pvDataCPP/contributors","subscribers_url":"https://api.github.com/repos/epics-base/pvDataCPP/subscribers","subscription_url":"https://api.github.com/repos/epics-base/pvDataCPP/subscription","commits_url":"https://api.github.com/repos/epics-base/pvDataCPP/commits{/sha}","git_commits_url":"https://api.github.com/repos/epics-base/pvDataCPP/git/commits{/sha}","comments_url":"https://api.github.com/repos/epics-base/pvDataCPP/comments{/number}","issue_comment_url":"https://api.github.com/repos/epics-base/pvDataCPP/issues/comments{/number}","contents_url":"https://api.github.com/repos/epics-base/pvDataCPP/contents/{+path}","compare_url":"https://api.github.com/repos/epics-base/pvDataCPP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epics-base/pvDataCPP/merges","archive_url":"https://api.github.com/repos/epics-base/pvDataCPP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epics-base/pvDataCPP/downloads","issues_url":"https://api.github.com/repos/epics-base/pvDataCPP/issues{/number}","pulls_url":"https://api.github.com/repos/epics-base/pvDataCPP/pulls{/number}","milestones_url":"https://api.github.com/repos/epics-base/pvDataCPP/milestones{/number}","notifications_url":"https://api.github.com/repos/epics-base/pvDataCPP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epics-base/pvDataCPP/labels{/name}","releases_url":"https://api.github.com/repos/epics-base/pvDataCPP/releases{/id}","created_at":"2015-01-27T17:30:09Z","updated_at":"2015-06-22T17:27:48Z","pushed_at":"2015-09-01T16:03:14Z","git_url":"git://github.com/epics-base/pvDataCPP.git","ssh_url":"git@github.com:epics-base/pvDataCPP.git","clone_url":"https://github.com/epics-base/pvDataCPP.git","svn_url":"https://github.com/epics-base/pvDataCPP","homepage":null,"size":6927,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/epics-base/pvDataCPP/pulls/8"},"html":{"href":"https://github.com/epics-base/pvDataCPP/pull/8"},"issue":{"href":"https://api.github.com/repos/epics-base/pvDataCPP/issues/8"},"comments":{"href":"https://api.github.com/repos/epics-base/pvDataCPP/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/epics-base/pvDataCPP/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/epics-base/pvDataCPP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/epics-base/pvDataCPP/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/epics-base/pvDataCPP/statuses/52bc6d060d372b1e02e3e02b2c9ac87fc51238f7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dhickin","id":6115551,"avatar_url":"https://avatars.githubusercontent.com/u/6115551?v=3","gravatar_id":"","url":"https://api.github.com/users/dhickin","html_url":"https://github.com/dhickin","followers_url":"https://api.github.com/users/dhickin/followers","following_url":"https://api.github.com/users/dhickin/following{/other_user}","gists_url":"https://api.github.com/users/dhickin/gists{/gist_id}","starred_url":"https://api.github.com/users/dhickin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhickin/subscriptions","organizations_url":"https://api.github.com/users/dhickin/orgs","repos_url":"https://api.github.com/users/dhickin/repos","events_url":"https://api.github.com/users/dhickin/events{/privacy}","received_events_url":"https://api.github.com/users/dhickin/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":34,"deletions":27,"changed_files":1}}