{"action":"created","comment":{"url":"https://api.github.com/repos/swcarpentry/amy/pulls/comments/32372532","id":32372532,"diff_hunk":"@@ -227,9 +228,14 @@ def ongoing_events(self):\n         return queryset\n \n     def unpublished_events(self):\n-        '''Return a queryset for events that are not yet published.'''\n+        '''Return events without URLs that are upcoming or have unknown starts.","path":"workshops/models.py","position":40,"original_position":40,"commit_id":"dd6f8cc8b58d30a1f26f57eb9211ee4761d7c6d6","original_commit_id":"dd6f8cc8b58d30a1f26f57eb9211ee4761d7c6d6","user":{"login":"gvwilson","id":911566,"avatar_url":"https://avatars.githubusercontent.com/u/911566?v=3","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},"body":"It might make more sense to change the name from \"unpublished\" to \n\"incomplete\" to better reflect the actual semantics. If so, should I put \nthat into this PR or do it separately?\n","created_at":"2015-06-13T18:11:45Z","updated_at":"2015-06-13T18:11:45Z","html_url":"https://github.com/swcarpentry/amy/pull/363#discussion_r32372532","pull_request_url":"https://api.github.com/repos/swcarpentry/amy/pulls/363","_links":{"self":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/comments/32372532"},"html":{"href":"https://github.com/swcarpentry/amy/pull/363#discussion_r32372532"},"pull_request":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/363"}}},"pull_request":{"url":"https://api.github.com/repos/swcarpentry/amy/pulls/363","id":37626058,"html_url":"https://github.com/swcarpentry/amy/pull/363","diff_url":"https://github.com/swcarpentry/amy/pull/363.diff","patch_url":"https://github.com/swcarpentry/amy/pull/363.patch","issue_url":"https://api.github.com/repos/swcarpentry/amy/issues/363","number":363,"state":"open","locked":false,"title":"Removing published flag","user":{"login":"gvwilson","id":911566,"avatar_url":"https://avatars.githubusercontent.com/u/911566?v=3","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},"body":"`Event.published` was unnecessary and annoying, so this PR:\r\n\r\n1.  Removes it from the model.\r\n2.  Rewrites the generators for upcoming and unpublished events to use the logic we actually want.\r\n3.  Refactors tests to put event generation in a common place.\r\n4.  Modifies some tests to reflect the changes above.","created_at":"2015-06-13T14:57:09Z","updated_at":"2015-06-13T18:11:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b37ab415abd56170543d19dc3e1f386fe524dc2","assignee":{"login":"pbanaszkiewicz","id":72821,"avatar_url":"https://avatars.githubusercontent.com/u/72821?v=3","gravatar_id":"","url":"https://api.github.com/users/pbanaszkiewicz","html_url":"https://github.com/pbanaszkiewicz","followers_url":"https://api.github.com/users/pbanaszkiewicz/followers","following_url":"https://api.github.com/users/pbanaszkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/pbanaszkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/pbanaszkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbanaszkiewicz/subscriptions","organizations_url":"https://api.github.com/users/pbanaszkiewicz/orgs","repos_url":"https://api.github.com/users/pbanaszkiewicz/repos","events_url":"https://api.github.com/users/pbanaszkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/pbanaszkiewicz/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/swcarpentry/amy/milestones/3","html_url":"https://github.com/swcarpentry/amy/milestones/v0.4","labels_url":"https://api.github.com/repos/swcarpentry/amy/milestones/3/labels","id":1108676,"number":3,"title":"v0.4","description":"Adding further features.","creator":{"login":"pbanaszkiewicz","id":72821,"avatar_url":"https://avatars.githubusercontent.com/u/72821?v=3","gravatar_id":"","url":"https://api.github.com/users/pbanaszkiewicz","html_url":"https://github.com/pbanaszkiewicz","followers_url":"https://api.github.com/users/pbanaszkiewicz/followers","following_url":"https://api.github.com/users/pbanaszkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/pbanaszkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/pbanaszkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbanaszkiewicz/subscriptions","organizations_url":"https://api.github.com/users/pbanaszkiewicz/orgs","repos_url":"https://api.github.com/users/pbanaszkiewicz/repos","events_url":"https://api.github.com/users/pbanaszkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/pbanaszkiewicz/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":17,"state":"open","created_at":"2015-05-13T14:19:08Z","updated_at":"2015-06-13T14:57:09Z","due_on":"2015-06-19T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/swcarpentry/amy/pulls/363/commits","review_comments_url":"https://api.github.com/repos/swcarpentry/amy/pulls/363/comments","review_comment_url":"https://api.github.com/repos/swcarpentry/amy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swcarpentry/amy/issues/363/comments","statuses_url":"https://api.github.com/repos/swcarpentry/amy/statuses/dd6f8cc8b58d30a1f26f57eb9211ee4761d7c6d6","head":{"label":"gvwilson:removing-published-flag","ref":"removing-published-flag","sha":"dd6f8cc8b58d30a1f26f57eb9211ee4761d7c6d6","user":{"login":"gvwilson","id":911566,"avatar_url":"https://avatars.githubusercontent.com/u/911566?v=3","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},"repo":{"id":30499788,"name":"amy","full_name":"gvwilson/amy","owner":{"login":"gvwilson","id":911566,"avatar_url":"https://avatars.githubusercontent.com/u/911566?v=3","gravatar_id":"","url":"https://api.github.com/users/gvwilson","html_url":"https://github.com/gvwilson","followers_url":"https://api.github.com/users/gvwilson/followers","following_url":"https://api.github.com/users/gvwilson/following{/other_user}","gists_url":"https://api.github.com/users/gvwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/gvwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvwilson/subscriptions","organizations_url":"https://api.github.com/users/gvwilson/orgs","repos_url":"https://api.github.com/users/gvwilson/repos","events_url":"https://api.github.com/users/gvwilson/events{/privacy}","received_events_url":"https://api.github.com/users/gvwilson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gvwilson/amy","description":"A web-based workshop administration application built using Django.","fork":true,"url":"https://api.github.com/repos/gvwilson/amy","forks_url":"https://api.github.com/repos/gvwilson/amy/forks","keys_url":"https://api.github.com/repos/gvwilson/amy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gvwilson/amy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gvwilson/amy/teams","hooks_url":"https://api.github.com/repos/gvwilson/amy/hooks","issue_events_url":"https://api.github.com/repos/gvwilson/amy/issues/events{/number}","events_url":"https://api.github.com/repos/gvwilson/amy/events","assignees_url":"https://api.github.com/repos/gvwilson/amy/assignees{/user}","branches_url":"https://api.github.com/repos/gvwilson/amy/branches{/branch}","tags_url":"https://api.github.com/repos/gvwilson/amy/tags","blobs_url":"https://api.github.com/repos/gvwilson/amy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gvwilson/amy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gvwilson/amy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gvwilson/amy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gvwilson/amy/statuses/{sha}","languages_url":"https://api.github.com/repos/gvwilson/amy/languages","stargazers_url":"https://api.github.com/repos/gvwilson/amy/stargazers","contributors_url":"https://api.github.com/repos/gvwilson/amy/contributors","subscribers_url":"https://api.github.com/repos/gvwilson/amy/subscribers","subscription_url":"https://api.github.com/repos/gvwilson/amy/subscription","commits_url":"https://api.github.com/repos/gvwilson/amy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gvwilson/amy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gvwilson/amy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gvwilson/amy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gvwilson/amy/contents/{+path}","compare_url":"https://api.github.com/repos/gvwilson/amy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gvwilson/amy/merges","archive_url":"https://api.github.com/repos/gvwilson/amy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gvwilson/amy/downloads","issues_url":"https://api.github.com/repos/gvwilson/amy/issues{/number}","pulls_url":"https://api.github.com/repos/gvwilson/amy/pulls{/number}","milestones_url":"https://api.github.com/repos/gvwilson/amy/milestones{/number}","notifications_url":"https://api.github.com/repos/gvwilson/amy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gvwilson/amy/labels{/name}","releases_url":"https://api.github.com/repos/gvwilson/amy/releases{/id}","created_at":"2015-02-08T17:55:11Z","updated_at":"2015-05-10T12:28:29Z","pushed_at":"2015-06-13T14:54:17Z","git_url":"git://github.com/gvwilson/amy.git","ssh_url":"git@github.com:gvwilson/amy.git","clone_url":"https://github.com/gvwilson/amy.git","svn_url":"https://github.com/gvwilson/amy","homepage":null,"size":7178,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swcarpentry:master","ref":"master","sha":"eeee8b892a78fa6813975faa6e8bd257515cf45c","user":{"login":"swcarpentry","id":2238358,"avatar_url":"https://avatars.githubusercontent.com/u/2238358?v=3","gravatar_id":"","url":"https://api.github.com/users/swcarpentry","html_url":"https://github.com/swcarpentry","followers_url":"https://api.github.com/users/swcarpentry/followers","following_url":"https://api.github.com/users/swcarpentry/following{/other_user}","gists_url":"https://api.github.com/users/swcarpentry/gists{/gist_id}","starred_url":"https://api.github.com/users/swcarpentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcarpentry/subscriptions","organizations_url":"https://api.github.com/users/swcarpentry/orgs","repos_url":"https://api.github.com/users/swcarpentry/repos","events_url":"https://api.github.com/users/swcarpentry/events{/privacy}","received_events_url":"https://api.github.com/users/swcarpentry/received_events","type":"Organization","site_admin":false},"repo":{"id":27387287,"name":"amy","full_name":"swcarpentry/amy","owner":{"login":"swcarpentry","id":2238358,"avatar_url":"https://avatars.githubusercontent.com/u/2238358?v=3","gravatar_id":"","url":"https://api.github.com/users/swcarpentry","html_url":"https://github.com/swcarpentry","followers_url":"https://api.github.com/users/swcarpentry/followers","following_url":"https://api.github.com/users/swcarpentry/following{/other_user}","gists_url":"https://api.github.com/users/swcarpentry/gists{/gist_id}","starred_url":"https://api.github.com/users/swcarpentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swcarpentry/subscriptions","organizations_url":"https://api.github.com/users/swcarpentry/orgs","repos_url":"https://api.github.com/users/swcarpentry/repos","events_url":"https://api.github.com/users/swcarpentry/events{/privacy}","received_events_url":"https://api.github.com/users/swcarpentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swcarpentry/amy","description":"A web-based workshop administration application built using Django.","fork":false,"url":"https://api.github.com/repos/swcarpentry/amy","forks_url":"https://api.github.com/repos/swcarpentry/amy/forks","keys_url":"https://api.github.com/repos/swcarpentry/amy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swcarpentry/amy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swcarpentry/amy/teams","hooks_url":"https://api.github.com/repos/swcarpentry/amy/hooks","issue_events_url":"https://api.github.com/repos/swcarpentry/amy/issues/events{/number}","events_url":"https://api.github.com/repos/swcarpentry/amy/events","assignees_url":"https://api.github.com/repos/swcarpentry/amy/assignees{/user}","branches_url":"https://api.github.com/repos/swcarpentry/amy/branches{/branch}","tags_url":"https://api.github.com/repos/swcarpentry/amy/tags","blobs_url":"https://api.github.com/repos/swcarpentry/amy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swcarpentry/amy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swcarpentry/amy/git/refs{/sha}","trees_url":"https://api.github.com/repos/swcarpentry/amy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swcarpentry/amy/statuses/{sha}","languages_url":"https://api.github.com/repos/swcarpentry/amy/languages","stargazers_url":"https://api.github.com/repos/swcarpentry/amy/stargazers","contributors_url":"https://api.github.com/repos/swcarpentry/amy/contributors","subscribers_url":"https://api.github.com/repos/swcarpentry/amy/subscribers","subscription_url":"https://api.github.com/repos/swcarpentry/amy/subscription","commits_url":"https://api.github.com/repos/swcarpentry/amy/commits{/sha}","git_commits_url":"https://api.github.com/repos/swcarpentry/amy/git/commits{/sha}","comments_url":"https://api.github.com/repos/swcarpentry/amy/comments{/number}","issue_comment_url":"https://api.github.com/repos/swcarpentry/amy/issues/comments{/number}","contents_url":"https://api.github.com/repos/swcarpentry/amy/contents/{+path}","compare_url":"https://api.github.com/repos/swcarpentry/amy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swcarpentry/amy/merges","archive_url":"https://api.github.com/repos/swcarpentry/amy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swcarpentry/amy/downloads","issues_url":"https://api.github.com/repos/swcarpentry/amy/issues{/number}","pulls_url":"https://api.github.com/repos/swcarpentry/amy/pulls{/number}","milestones_url":"https://api.github.com/repos/swcarpentry/amy/milestones{/number}","notifications_url":"https://api.github.com/repos/swcarpentry/amy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swcarpentry/amy/labels{/name}","releases_url":"https://api.github.com/repos/swcarpentry/amy/releases{/id}","created_at":"2014-12-01T16:07:14Z","updated_at":"2015-06-09T04:55:10Z","pushed_at":"2015-06-13T14:57:09Z","git_url":"git://github.com/swcarpentry/amy.git","ssh_url":"git@github.com:swcarpentry/amy.git","clone_url":"https://github.com/swcarpentry/amy.git","svn_url":"https://github.com/swcarpentry/amy","homepage":null,"size":8384,"stargazers_count":19,"watchers_count":19,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":56,"forks":30,"open_issues":56,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/363"},"html":{"href":"https://github.com/swcarpentry/amy/pull/363"},"issue":{"href":"https://api.github.com/repos/swcarpentry/amy/issues/363"},"comments":{"href":"https://api.github.com/repos/swcarpentry/amy/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swcarpentry/amy/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/swcarpentry/amy/statuses/dd6f8cc8b58d30a1f26f57eb9211ee4761d7c6d6"}}}}