{"action":"created","comment":{"url":"https://api.github.com/repos/fwbrasil/clump/pulls/comments/22444804","id":22444804,"diff_hunk":"@@ -67,15 +67,6 @@ object Clump {\n \n   def collect[T](clumps: List[Clump[T]]): Clump[List[T]] =\n     new ClumpCollect(clumps)\n-\n-  def sourceFrom[T, U](fetch: Set[T] => Future[Map[T, U]], maxBatchSize: Int = Int.MaxValue) =","path":"src/main/scala/clump/Clump.scala","position":5,"original_position":5,"commit_id":"97ce150bd762f34ae403d3ee0127777454201639","original_commit_id":"97ce150bd762f34ae403d3ee0127777454201639","user":{"login":"williamboxhall","id":637891,"avatar_url":"https://avatars.githubusercontent.com/u/637891?v=3","gravatar_id":"","url":"https://api.github.com/users/williamboxhall","html_url":"https://github.com/williamboxhall","followers_url":"https://api.github.com/users/williamboxhall/followers","following_url":"https://api.github.com/users/williamboxhall/following{/other_user}","gists_url":"https://api.github.com/users/williamboxhall/gists{/gist_id}","starred_url":"https://api.github.com/users/williamboxhall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamboxhall/subscriptions","organizations_url":"https://api.github.com/users/williamboxhall/orgs","repos_url":"https://api.github.com/users/williamboxhall/repos","events_url":"https://api.github.com/users/williamboxhall/events{/privacy}","received_events_url":"https://api.github.com/users/williamboxhall/received_events","type":"User","site_admin":false},"body":"I'm a bit on the fence about this. I really like what you've done and made things really tidy and readable. However I still think there is something to be said for being able to initiate everything via the `Clump` object - so the user does not need to know about two classes.\r\n\r\nWDYT?\r\n\r\nIt would be 3 convenience method similar to what we had before that just call through:\r\n```scala\r\ndef sourceFrom[T, U, C](fetch: C => Future[Map[T, U]])(implicit cbf: CanBuildFrom[Nothing, T, C]) = ClumpSource.from(fetch)\r\ndef source[T, U, C](fetch: C => Future[Iterable[U]])(keyExtractor: U => T)(implicit cbf: CanBuildFrom[Nothing, T, C]) = ClumpSource(fetch, keyExtractor)\r\ndef sourceZip[T, U](fetch: List[T] => Future[List[U]]): ClumpSource[T, U] = ClumpSource.zip(fetch)\r\n```\r\n","created_at":"2015-01-05T00:52:41Z","updated_at":"2015-01-05T00:52:41Z","html_url":"https://github.com/fwbrasil/clump/pull/35#discussion_r22444804","pull_request_url":"https://api.github.com/repos/fwbrasil/clump/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/fwbrasil/clump/pulls/comments/22444804"},"html":{"href":"https://github.com/fwbrasil/clump/pull/35#discussion_r22444804"},"pull_request":{"href":"https://api.github.com/repos/fwbrasil/clump/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/fwbrasil/clump/pulls/35","id":26801134,"html_url":"https://github.com/fwbrasil/clump/pull/35","diff_url":"https://github.com/fwbrasil/clump/pull/35.diff","patch_url":"https://github.com/fwbrasil/clump/pull/35.patch","issue_url":"https://api.github.com/repos/fwbrasil/clump/issues/35","number":35,"state":"open","locked":false,"title":"Flexible sources","user":{"login":"fwbrasil","id":831175,"avatar_url":"https://avatars.githubusercontent.com/u/831175?v=3","gravatar_id":"","url":"https://api.github.com/users/fwbrasil","html_url":"https://github.com/fwbrasil","followers_url":"https://api.github.com/users/fwbrasil/followers","following_url":"https://api.github.com/users/fwbrasil/following{/other_user}","gists_url":"https://api.github.com/users/fwbrasil/gists{/gist_id}","starred_url":"https://api.github.com/users/fwbrasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwbrasil/subscriptions","organizations_url":"https://api.github.com/users/fwbrasil/orgs","repos_url":"https://api.github.com/users/fwbrasil/repos","events_url":"https://api.github.com/users/fwbrasil/events{/privacy}","received_events_url":"https://api.github.com/users/fwbrasil/received_events","type":"User","site_admin":false},"body":"@williamboxhall ","created_at":"2015-01-04T23:23:38Z","updated_at":"2015-01-05T00:52:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fwbrasil/clump/pulls/35/commits","review_comments_url":"https://api.github.com/repos/fwbrasil/clump/pulls/35/comments","review_comment_url":"https://api.github.com/repos/fwbrasil/clump/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fwbrasil/clump/issues/35/comments","statuses_url":"https://api.github.com/repos/fwbrasil/clump/statuses/97ce150bd762f34ae403d3ee0127777454201639","head":{"label":"fwbrasil:flexible-sources","ref":"flexible-sources","sha":"97ce150bd762f34ae403d3ee0127777454201639","user":{"login":"fwbrasil","id":831175,"avatar_url":"https://avatars.githubusercontent.com/u/831175?v=3","gravatar_id":"","url":"https://api.github.com/users/fwbrasil","html_url":"https://github.com/fwbrasil","followers_url":"https://api.github.com/users/fwbrasil/followers","following_url":"https://api.github.com/users/fwbrasil/following{/other_user}","gists_url":"https://api.github.com/users/fwbrasil/gists{/gist_id}","starred_url":"https://api.github.com/users/fwbrasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwbrasil/subscriptions","organizations_url":"https://api.github.com/users/fwbrasil/orgs","repos_url":"https://api.github.com/users/fwbrasil/repos","events_url":"https://api.github.com/users/fwbrasil/events{/privacy}","received_events_url":"https://api.github.com/users/fwbrasil/received_events","type":"User","site_admin":false},"repo":{"id":27430086,"name":"clump","full_name":"fwbrasil/clump","owner":{"login":"fwbrasil","id":831175,"avatar_url":"https://avatars.githubusercontent.com/u/831175?v=3","gravatar_id":"","url":"https://api.github.com/users/fwbrasil","html_url":"https://github.com/fwbrasil","followers_url":"https://api.github.com/users/fwbrasil/followers","following_url":"https://api.github.com/users/fwbrasil/following{/other_user}","gists_url":"https://api.github.com/users/fwbrasil/gists{/gist_id}","starred_url":"https://api.github.com/users/fwbrasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwbrasil/subscriptions","organizations_url":"https://api.github.com/users/fwbrasil/orgs","repos_url":"https://api.github.com/users/fwbrasil/repos","events_url":"https://api.github.com/users/fwbrasil/events{/privacy}","received_events_url":"https://api.github.com/users/fwbrasil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fwbrasil/clump","description":"A plagiarization of Twitter's unreleased Stitch","fork":true,"url":"https://api.github.com/repos/fwbrasil/clump","forks_url":"https://api.github.com/repos/fwbrasil/clump/forks","keys_url":"https://api.github.com/repos/fwbrasil/clump/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fwbrasil/clump/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fwbrasil/clump/teams","hooks_url":"https://api.github.com/repos/fwbrasil/clump/hooks","issue_events_url":"https://api.github.com/repos/fwbrasil/clump/issues/events{/number}","events_url":"https://api.github.com/repos/fwbrasil/clump/events","assignees_url":"https://api.github.com/repos/fwbrasil/clump/assignees{/user}","branches_url":"https://api.github.com/repos/fwbrasil/clump/branches{/branch}","tags_url":"https://api.github.com/repos/fwbrasil/clump/tags","blobs_url":"https://api.github.com/repos/fwbrasil/clump/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fwbrasil/clump/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fwbrasil/clump/git/refs{/sha}","trees_url":"https://api.github.com/repos/fwbrasil/clump/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fwbrasil/clump/statuses/{sha}","languages_url":"https://api.github.com/repos/fwbrasil/clump/languages","stargazers_url":"https://api.github.com/repos/fwbrasil/clump/stargazers","contributors_url":"https://api.github.com/repos/fwbrasil/clump/contributors","subscribers_url":"https://api.github.com/repos/fwbrasil/clump/subscribers","subscription_url":"https://api.github.com/repos/fwbrasil/clump/subscription","commits_url":"https://api.github.com/repos/fwbrasil/clump/commits{/sha}","git_commits_url":"https://api.github.com/repos/fwbrasil/clump/git/commits{/sha}","comments_url":"https://api.github.com/repos/fwbrasil/clump/comments{/number}","issue_comment_url":"https://api.github.com/repos/fwbrasil/clump/issues/comments/{number}","contents_url":"https://api.github.com/repos/fwbrasil/clump/contents/{+path}","compare_url":"https://api.github.com/repos/fwbrasil/clump/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fwbrasil/clump/merges","archive_url":"https://api.github.com/repos/fwbrasil/clump/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fwbrasil/clump/downloads","issues_url":"https://api.github.com/repos/fwbrasil/clump/issues{/number}","pulls_url":"https://api.github.com/repos/fwbrasil/clump/pulls{/number}","milestones_url":"https://api.github.com/repos/fwbrasil/clump/milestones{/number}","notifications_url":"https://api.github.com/repos/fwbrasil/clump/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fwbrasil/clump/labels{/name}","releases_url":"https://api.github.com/repos/fwbrasil/clump/releases{/id}","created_at":"2014-12-02T11:46:09Z","updated_at":"2015-01-04T22:17:52Z","pushed_at":"2015-01-05T00:17:45Z","git_url":"git://github.com/fwbrasil/clump.git","ssh_url":"git@github.com:fwbrasil/clump.git","clone_url":"https://github.com/fwbrasil/clump.git","svn_url":"https://github.com/fwbrasil/clump","homepage":"","size":1007,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"fwbrasil:master","ref":"master","sha":"d9012eabca0be1c4425b0b8d5d00bb92bb61455d","user":{"login":"fwbrasil","id":831175,"avatar_url":"https://avatars.githubusercontent.com/u/831175?v=3","gravatar_id":"","url":"https://api.github.com/users/fwbrasil","html_url":"https://github.com/fwbrasil","followers_url":"https://api.github.com/users/fwbrasil/followers","following_url":"https://api.github.com/users/fwbrasil/following{/other_user}","gists_url":"https://api.github.com/users/fwbrasil/gists{/gist_id}","starred_url":"https://api.github.com/users/fwbrasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwbrasil/subscriptions","organizations_url":"https://api.github.com/users/fwbrasil/orgs","repos_url":"https://api.github.com/users/fwbrasil/repos","events_url":"https://api.github.com/users/fwbrasil/events{/privacy}","received_events_url":"https://api.github.com/users/fwbrasil/received_events","type":"User","site_admin":false},"repo":{"id":27430086,"name":"clump","full_name":"fwbrasil/clump","owner":{"login":"fwbrasil","id":831175,"avatar_url":"https://avatars.githubusercontent.com/u/831175?v=3","gravatar_id":"","url":"https://api.github.com/users/fwbrasil","html_url":"https://github.com/fwbrasil","followers_url":"https://api.github.com/users/fwbrasil/followers","following_url":"https://api.github.com/users/fwbrasil/following{/other_user}","gists_url":"https://api.github.com/users/fwbrasil/gists{/gist_id}","starred_url":"https://api.github.com/users/fwbrasil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwbrasil/subscriptions","organizations_url":"https://api.github.com/users/fwbrasil/orgs","repos_url":"https://api.github.com/users/fwbrasil/repos","events_url":"https://api.github.com/users/fwbrasil/events{/privacy}","received_events_url":"https://api.github.com/users/fwbrasil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fwbrasil/clump","description":"A plagiarization of Twitter's unreleased Stitch","fork":true,"url":"https://api.github.com/repos/fwbrasil/clump","forks_url":"https://api.github.com/repos/fwbrasil/clump/forks","keys_url":"https://api.github.com/repos/fwbrasil/clump/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fwbrasil/clump/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fwbrasil/clump/teams","hooks_url":"https://api.github.com/repos/fwbrasil/clump/hooks","issue_events_url":"https://api.github.com/repos/fwbrasil/clump/issues/events{/number}","events_url":"https://api.github.com/repos/fwbrasil/clump/events","assignees_url":"https://api.github.com/repos/fwbrasil/clump/assignees{/user}","branches_url":"https://api.github.com/repos/fwbrasil/clump/branches{/branch}","tags_url":"https://api.github.com/repos/fwbrasil/clump/tags","blobs_url":"https://api.github.com/repos/fwbrasil/clump/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fwbrasil/clump/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fwbrasil/clump/git/refs{/sha}","trees_url":"https://api.github.com/repos/fwbrasil/clump/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fwbrasil/clump/statuses/{sha}","languages_url":"https://api.github.com/repos/fwbrasil/clump/languages","stargazers_url":"https://api.github.com/repos/fwbrasil/clump/stargazers","contributors_url":"https://api.github.com/repos/fwbrasil/clump/contributors","subscribers_url":"https://api.github.com/repos/fwbrasil/clump/subscribers","subscription_url":"https://api.github.com/repos/fwbrasil/clump/subscription","commits_url":"https://api.github.com/repos/fwbrasil/clump/commits{/sha}","git_commits_url":"https://api.github.com/repos/fwbrasil/clump/git/commits{/sha}","comments_url":"https://api.github.com/repos/fwbrasil/clump/comments{/number}","issue_comment_url":"https://api.github.com/repos/fwbrasil/clump/issues/comments/{number}","contents_url":"https://api.github.com/repos/fwbrasil/clump/contents/{+path}","compare_url":"https://api.github.com/repos/fwbrasil/clump/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fwbrasil/clump/merges","archive_url":"https://api.github.com/repos/fwbrasil/clump/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fwbrasil/clump/downloads","issues_url":"https://api.github.com/repos/fwbrasil/clump/issues{/number}","pulls_url":"https://api.github.com/repos/fwbrasil/clump/pulls{/number}","milestones_url":"https://api.github.com/repos/fwbrasil/clump/milestones{/number}","notifications_url":"https://api.github.com/repos/fwbrasil/clump/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fwbrasil/clump/labels{/name}","releases_url":"https://api.github.com/repos/fwbrasil/clump/releases{/id}","created_at":"2014-12-02T11:46:09Z","updated_at":"2015-01-04T22:17:52Z","pushed_at":"2015-01-05T00:17:45Z","git_url":"git://github.com/fwbrasil/clump.git","ssh_url":"git@github.com:fwbrasil/clump.git","clone_url":"https://github.com/fwbrasil/clump.git","svn_url":"https://github.com/fwbrasil/clump","homepage":"","size":1007,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fwbrasil/clump/pulls/35"},"html":{"href":"https://github.com/fwbrasil/clump/pull/35"},"issue":{"href":"https://api.github.com/repos/fwbrasil/clump/issues/35"},"comments":{"href":"https://api.github.com/repos/fwbrasil/clump/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/fwbrasil/clump/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/fwbrasil/clump/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fwbrasil/clump/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/fwbrasil/clump/statuses/97ce150bd762f34ae403d3ee0127777454201639"}}}}