{"action":"created","comment":{"url":"https://api.github.com/repos/xetorthio/jedis/pulls/comments/46667406","id":46667406,"diff_hunk":"@@ -155,6 +181,23 @@ public void connect() {\n \n         socket.connect(new InetSocketAddress(host, port), connectionTimeout);\n         socket.setSoTimeout(soTimeout);\n+\n+        if(ssl) {\n+          if (null == sslSocketFactory) {\n+            sslSocketFactory = (SSLSocketFactory)SSLSocketFactory.getDefault();\n+          }\n+          socket = (SSLSocket) sslSocketFactory.createSocket(socket, host, port, true);\n+          if (null != sslParameters) {\n+            ((SSLSocket) socket).setSSLParameters(sslParameters);\n+          }\n+          if((null != hostnameVerifier) && ","path":"src/main/java/redis/clients/jedis/Connection.java","position":60,"original_position":60,"commit_id":"d3a1004798a089d4112c220cbdb4a5cc96fa4c8b","original_commit_id":"d3a1004798a089d4112c220cbdb4a5cc96fa4c8b","user":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars.githubusercontent.com/u/1317309?v=3","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"body":"Nit: space between if and (","created_at":"2015-12-04T10:22:44Z","updated_at":"2015-12-04T10:22:44Z","html_url":"https://github.com/xetorthio/jedis/pull/1173#discussion_r46667406","pull_request_url":"https://api.github.com/repos/xetorthio/jedis/pulls/1173","_links":{"self":{"href":"https://api.github.com/repos/xetorthio/jedis/pulls/comments/46667406"},"html":{"href":"https://github.com/xetorthio/jedis/pull/1173#discussion_r46667406"},"pull_request":{"href":"https://api.github.com/repos/xetorthio/jedis/pulls/1173"}}},"pull_request":{"url":"https://api.github.com/repos/xetorthio/jedis/pulls/1173","id":52617349,"html_url":"https://github.com/xetorthio/jedis/pull/1173","diff_url":"https://github.com/xetorthio/jedis/pull/1173.diff","patch_url":"https://github.com/xetorthio/jedis/pull/1173.patch","issue_url":"https://api.github.com/repos/xetorthio/jedis/issues/1173","number":1173,"state":"open","locked":false,"title":"Support for ssl/tls using defaults or user specified SSLSocketFactory, SSLParameters, and HostnameVerifier.","user":{"login":"damiri-ts","id":14286310,"avatar_url":"https://avatars.githubusercontent.com/u/14286310?v=3","gravatar_id":"","url":"https://api.github.com/users/damiri-ts","html_url":"https://github.com/damiri-ts","followers_url":"https://api.github.com/users/damiri-ts/followers","following_url":"https://api.github.com/users/damiri-ts/following{/other_user}","gists_url":"https://api.github.com/users/damiri-ts/gists{/gist_id}","starred_url":"https://api.github.com/users/damiri-ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damiri-ts/subscriptions","organizations_url":"https://api.github.com/users/damiri-ts/orgs","repos_url":"https://api.github.com/users/damiri-ts/repos","events_url":"https://api.github.com/users/damiri-ts/events{/privacy}","received_events_url":"https://api.github.com/users/damiri-ts/received_events","type":"User","site_admin":false},"body":"This pull request provides support for SSL/TLS with the option to specify an SSLSocketFactory, SSLParameters, and HostnameVerifier.\r\n\r\nI am essentially resuscitating the content from the pull request submitted by RedisLabs (https://github.com/xetorthio/jedis/pull/611/files). The majority of the credit for these changes belongs to them. For my part, I added the ability for the user to explicitly set an SSLSocketFactory, SSLParameters, and HostnameVerifier which should alleviate any concerns about missing or sub-optimal hostname verification when using either Java 6 or 7.\r\n\r\nI have tested this with the Azure's Redis cache service.","created_at":"2015-12-04T01:09:20Z","updated_at":"2015-12-04T10:22:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21b7a50d59705144d09ff04173d46ce58db6ba45","assignee":null,"milestone":{"url":"https://api.github.com/repos/xetorthio/jedis/milestones/23","html_url":"https://github.com/xetorthio/jedis/milestones/2.9.0","labels_url":"https://api.github.com/repos/xetorthio/jedis/milestones/23/labels","id":1343537,"number":23,"title":"2.9.0","description":"","creator":{"login":"marcosnils","id":1578458,"avatar_url":"https://avatars.githubusercontent.com/u/1578458?v=3","gravatar_id":"","url":"https://api.github.com/users/marcosnils","html_url":"https://github.com/marcosnils","followers_url":"https://api.github.com/users/marcosnils/followers","following_url":"https://api.github.com/users/marcosnils/following{/other_user}","gists_url":"https://api.github.com/users/marcosnils/gists{/gist_id}","starred_url":"https://api.github.com/users/marcosnils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcosnils/subscriptions","organizations_url":"https://api.github.com/users/marcosnils/orgs","repos_url":"https://api.github.com/users/marcosnils/repos","events_url":"https://api.github.com/users/marcosnils/events{/privacy}","received_events_url":"https://api.github.com/users/marcosnils/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2015-10-07T21:53:44Z","updated_at":"2015-12-04T01:18:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/xetorthio/jedis/pulls/1173/commits","review_comments_url":"https://api.github.com/repos/xetorthio/jedis/pulls/1173/comments","review_comment_url":"https://api.github.com/repos/xetorthio/jedis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xetorthio/jedis/issues/1173/comments","statuses_url":"https://api.github.com/repos/xetorthio/jedis/statuses/d3a1004798a089d4112c220cbdb4a5cc96fa4c8b","head":{"label":"TruSphere:ssl_tls_support","ref":"ssl_tls_support","sha":"d3a1004798a089d4112c220cbdb4a5cc96fa4c8b","user":{"login":"TruSphere","id":13425472,"avatar_url":"https://avatars.githubusercontent.com/u/13425472?v=3","gravatar_id":"","url":"https://api.github.com/users/TruSphere","html_url":"https://github.com/TruSphere","followers_url":"https://api.github.com/users/TruSphere/followers","following_url":"https://api.github.com/users/TruSphere/following{/other_user}","gists_url":"https://api.github.com/users/TruSphere/gists{/gist_id}","starred_url":"https://api.github.com/users/TruSphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TruSphere/subscriptions","organizations_url":"https://api.github.com/users/TruSphere/orgs","repos_url":"https://api.github.com/users/TruSphere/repos","events_url":"https://api.github.com/users/TruSphere/events{/privacy}","received_events_url":"https://api.github.com/users/TruSphere/received_events","type":"Organization","site_admin":false},"repo":{"id":46994189,"name":"jedis","full_name":"TruSphere/jedis","owner":{"login":"TruSphere","id":13425472,"avatar_url":"https://avatars.githubusercontent.com/u/13425472?v=3","gravatar_id":"","url":"https://api.github.com/users/TruSphere","html_url":"https://github.com/TruSphere","followers_url":"https://api.github.com/users/TruSphere/followers","following_url":"https://api.github.com/users/TruSphere/following{/other_user}","gists_url":"https://api.github.com/users/TruSphere/gists{/gist_id}","starred_url":"https://api.github.com/users/TruSphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TruSphere/subscriptions","organizations_url":"https://api.github.com/users/TruSphere/orgs","repos_url":"https://api.github.com/users/TruSphere/repos","events_url":"https://api.github.com/users/TruSphere/events{/privacy}","received_events_url":"https://api.github.com/users/TruSphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TruSphere/jedis","description":"A blazingly small and sane redis java client","fork":true,"url":"https://api.github.com/repos/TruSphere/jedis","forks_url":"https://api.github.com/repos/TruSphere/jedis/forks","keys_url":"https://api.github.com/repos/TruSphere/jedis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TruSphere/jedis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TruSphere/jedis/teams","hooks_url":"https://api.github.com/repos/TruSphere/jedis/hooks","issue_events_url":"https://api.github.com/repos/TruSphere/jedis/issues/events{/number}","events_url":"https://api.github.com/repos/TruSphere/jedis/events","assignees_url":"https://api.github.com/repos/TruSphere/jedis/assignees{/user}","branches_url":"https://api.github.com/repos/TruSphere/jedis/branches{/branch}","tags_url":"https://api.github.com/repos/TruSphere/jedis/tags","blobs_url":"https://api.github.com/repos/TruSphere/jedis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TruSphere/jedis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TruSphere/jedis/git/refs{/sha}","trees_url":"https://api.github.com/repos/TruSphere/jedis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TruSphere/jedis/statuses/{sha}","languages_url":"https://api.github.com/repos/TruSphere/jedis/languages","stargazers_url":"https://api.github.com/repos/TruSphere/jedis/stargazers","contributors_url":"https://api.github.com/repos/TruSphere/jedis/contributors","subscribers_url":"https://api.github.com/repos/TruSphere/jedis/subscribers","subscription_url":"https://api.github.com/repos/TruSphere/jedis/subscription","commits_url":"https://api.github.com/repos/TruSphere/jedis/commits{/sha}","git_commits_url":"https://api.github.com/repos/TruSphere/jedis/git/commits{/sha}","comments_url":"https://api.github.com/repos/TruSphere/jedis/comments{/number}","issue_comment_url":"https://api.github.com/repos/TruSphere/jedis/issues/comments{/number}","contents_url":"https://api.github.com/repos/TruSphere/jedis/contents/{+path}","compare_url":"https://api.github.com/repos/TruSphere/jedis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TruSphere/jedis/merges","archive_url":"https://api.github.com/repos/TruSphere/jedis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TruSphere/jedis/downloads","issues_url":"https://api.github.com/repos/TruSphere/jedis/issues{/number}","pulls_url":"https://api.github.com/repos/TruSphere/jedis/pulls{/number}","milestones_url":"https://api.github.com/repos/TruSphere/jedis/milestones{/number}","notifications_url":"https://api.github.com/repos/TruSphere/jedis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TruSphere/jedis/labels{/name}","releases_url":"https://api.github.com/repos/TruSphere/jedis/releases{/id}","created_at":"2015-11-27T18:23:53Z","updated_at":"2015-11-27T18:23:56Z","pushed_at":"2015-12-04T02:21:51Z","git_url":"git://github.com/TruSphere/jedis.git","ssh_url":"git@github.com:TruSphere/jedis.git","clone_url":"https://github.com/TruSphere/jedis.git","svn_url":"https://github.com/TruSphere/jedis","homepage":"","size":6088,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xetorthio:master","ref":"master","sha":"1ae8379816ef020420b07ee802cc0c38e177c9d7","user":{"login":"xetorthio","id":139687,"avatar_url":"https://avatars.githubusercontent.com/u/139687?v=3","gravatar_id":"","url":"https://api.github.com/users/xetorthio","html_url":"https://github.com/xetorthio","followers_url":"https://api.github.com/users/xetorthio/followers","following_url":"https://api.github.com/users/xetorthio/following{/other_user}","gists_url":"https://api.github.com/users/xetorthio/gists{/gist_id}","starred_url":"https://api.github.com/users/xetorthio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xetorthio/subscriptions","organizations_url":"https://api.github.com/users/xetorthio/orgs","repos_url":"https://api.github.com/users/xetorthio/repos","events_url":"https://api.github.com/users/xetorthio/events{/privacy}","received_events_url":"https://api.github.com/users/xetorthio/received_events","type":"User","site_admin":false},"repo":{"id":715605,"name":"jedis","full_name":"xetorthio/jedis","owner":{"login":"xetorthio","id":139687,"avatar_url":"https://avatars.githubusercontent.com/u/139687?v=3","gravatar_id":"","url":"https://api.github.com/users/xetorthio","html_url":"https://github.com/xetorthio","followers_url":"https://api.github.com/users/xetorthio/followers","following_url":"https://api.github.com/users/xetorthio/following{/other_user}","gists_url":"https://api.github.com/users/xetorthio/gists{/gist_id}","starred_url":"https://api.github.com/users/xetorthio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xetorthio/subscriptions","organizations_url":"https://api.github.com/users/xetorthio/orgs","repos_url":"https://api.github.com/users/xetorthio/repos","events_url":"https://api.github.com/users/xetorthio/events{/privacy}","received_events_url":"https://api.github.com/users/xetorthio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xetorthio/jedis","description":"A blazingly small and sane redis java client","fork":false,"url":"https://api.github.com/repos/xetorthio/jedis","forks_url":"https://api.github.com/repos/xetorthio/jedis/forks","keys_url":"https://api.github.com/repos/xetorthio/jedis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xetorthio/jedis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xetorthio/jedis/teams","hooks_url":"https://api.github.com/repos/xetorthio/jedis/hooks","issue_events_url":"https://api.github.com/repos/xetorthio/jedis/issues/events{/number}","events_url":"https://api.github.com/repos/xetorthio/jedis/events","assignees_url":"https://api.github.com/repos/xetorthio/jedis/assignees{/user}","branches_url":"https://api.github.com/repos/xetorthio/jedis/branches{/branch}","tags_url":"https://api.github.com/repos/xetorthio/jedis/tags","blobs_url":"https://api.github.com/repos/xetorthio/jedis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xetorthio/jedis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xetorthio/jedis/git/refs{/sha}","trees_url":"https://api.github.com/repos/xetorthio/jedis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xetorthio/jedis/statuses/{sha}","languages_url":"https://api.github.com/repos/xetorthio/jedis/languages","stargazers_url":"https://api.github.com/repos/xetorthio/jedis/stargazers","contributors_url":"https://api.github.com/repos/xetorthio/jedis/contributors","subscribers_url":"https://api.github.com/repos/xetorthio/jedis/subscribers","subscription_url":"https://api.github.com/repos/xetorthio/jedis/subscription","commits_url":"https://api.github.com/repos/xetorthio/jedis/commits{/sha}","git_commits_url":"https://api.github.com/repos/xetorthio/jedis/git/commits{/sha}","comments_url":"https://api.github.com/repos/xetorthio/jedis/comments{/number}","issue_comment_url":"https://api.github.com/repos/xetorthio/jedis/issues/comments{/number}","contents_url":"https://api.github.com/repos/xetorthio/jedis/contents/{+path}","compare_url":"https://api.github.com/repos/xetorthio/jedis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xetorthio/jedis/merges","archive_url":"https://api.github.com/repos/xetorthio/jedis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xetorthio/jedis/downloads","issues_url":"https://api.github.com/repos/xetorthio/jedis/issues{/number}","pulls_url":"https://api.github.com/repos/xetorthio/jedis/pulls{/number}","milestones_url":"https://api.github.com/repos/xetorthio/jedis/milestones{/number}","notifications_url":"https://api.github.com/repos/xetorthio/jedis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xetorthio/jedis/labels{/name}","releases_url":"https://api.github.com/repos/xetorthio/jedis/releases{/id}","created_at":"2010-06-11T13:04:43Z","updated_at":"2015-12-04T06:42:18Z","pushed_at":"2015-12-04T02:09:41Z","git_url":"git://github.com/xetorthio/jedis.git","ssh_url":"git@github.com:xetorthio/jedis.git","clone_url":"https://github.com/xetorthio/jedis.git","svn_url":"https://github.com/xetorthio/jedis","homepage":"","size":90157,"stargazers_count":3009,"watchers_count":3009,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1447,"mirror_url":null,"open_issues_count":103,"forks":1447,"open_issues":103,"watchers":3009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xetorthio/jedis/pulls/1173"},"html":{"href":"https://github.com/xetorthio/jedis/pull/1173"},"issue":{"href":"https://api.github.com/repos/xetorthio/jedis/issues/1173"},"comments":{"href":"https://api.github.com/repos/xetorthio/jedis/issues/1173/comments"},"review_comments":{"href":"https://api.github.com/repos/xetorthio/jedis/pulls/1173/comments"},"review_comment":{"href":"https://api.github.com/repos/xetorthio/jedis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xetorthio/jedis/pulls/1173/commits"},"statuses":{"href":"https://api.github.com/repos/xetorthio/jedis/statuses/d3a1004798a089d4112c220cbdb4a5cc96fa4c8b"}}}}