{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/468","labels_url":"https://api.github.com/repos/guardian/membership-frontend/issues/468/labels{/name}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/issues/468/comments","events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/468/events","html_url":"https://github.com/guardian/membership-frontend/pull/468","id":68336719,"number":468,"title":"Fix video overlay firefox bug for blocked players","user":{"login":"davidrapson","id":123386,"avatar_url":"https://avatars.githubusercontent.com/u/123386?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrapson","html_url":"https://github.com/davidrapson","followers_url":"https://api.github.com/users/davidrapson/followers","following_url":"https://api.github.com/users/davidrapson/following{/other_user}","gists_url":"https://api.github.com/users/davidrapson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrapson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrapson/subscriptions","organizations_url":"https://api.github.com/users/davidrapson/orgs","repos_url":"https://api.github.com/users/davidrapson/repos","events_url":"https://api.github.com/users/davidrapson/events{/privacy}","received_events_url":"https://api.github.com/users/davidrapson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-14T10:43:42Z","updated_at":"2015-04-14T13:45:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/468","html_url":"https://github.com/guardian/membership-frontend/pull/468","diff_url":"https://github.com/guardian/membership-frontend/pull/468.diff","patch_url":"https://github.com/guardian/membership-frontend/pull/468.patch"},"body":"This PR fixes a bug in some versions of firefox on the new video player overlay. In new versions of firefox if your version of flash player is out of date it helpfully disables it, requiring you to opt-in to it.\r\n\r\nThis has the side effect of triggering an error when trying to play a video. By moving the click event to the player `onReady` event we don't do anything if players are blocked.\r\n\r\n![screen shot 2015-04-14 at 10 34 53](https://cloud.githubusercontent.com/assets/123386/7135111/731b371c-e29b-11e4-8634-2df4d0b02ef8.png)\r\n\r\nAlso removes `loadJs`, should've just used `require` and `js!` plugin (was missing ho to stop it adding the `.js` extension)\r\n\r\nFixes https://app.getsentry.com/the-guardian/membership/group/62535814/\r\n\r\n// @mattandrews "},"comment":{"url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments/92851923","html_url":"https://github.com/guardian/membership-frontend/pull/468#issuecomment-92851923","issue_url":"https://api.github.com/repos/guardian/membership-frontend/issues/468","id":92851923,"user":{"login":"davidrapson","id":123386,"avatar_url":"https://avatars.githubusercontent.com/u/123386?v=3","gravatar_id":"","url":"https://api.github.com/users/davidrapson","html_url":"https://github.com/davidrapson","followers_url":"https://api.github.com/users/davidrapson/followers","following_url":"https://api.github.com/users/davidrapson/following{/other_user}","gists_url":"https://api.github.com/users/davidrapson/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrapson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrapson/subscriptions","organizations_url":"https://api.github.com/users/davidrapson/orgs","repos_url":"https://api.github.com/users/davidrapson/repos","events_url":"https://api.github.com/users/davidrapson/events{/privacy}","received_events_url":"https://api.github.com/users/davidrapson/received_events","type":"User","site_admin":false},"created_at":"2015-04-14T13:45:26Z","updated_at":"2015-04-14T13:45:26Z","body":"Look OK to you @jamesoram ?"}}