{"action":"opened","number":2431,"pull_request":{"url":"https://api.github.com/repos/kennethreitz/requests/pulls/2431","id":28408827,"html_url":"https://github.com/kennethreitz/requests/pull/2431","diff_url":"https://github.com/kennethreitz/requests/pull/2431.diff","patch_url":"https://github.com/kennethreitz/requests/pull/2431.patch","issue_url":"https://api.github.com/repos/kennethreitz/requests/issues/2431","number":2431,"state":"open","locked":false,"title":"Fixes problems with iter_lines when the delimiter is split","user":{"login":"ianepperson","id":903537,"avatar_url":"https://avatars.githubusercontent.com/u/903537?v=3","gravatar_id":"","url":"https://api.github.com/users/ianepperson","html_url":"https://github.com/ianepperson","followers_url":"https://api.github.com/users/ianepperson/followers","following_url":"https://api.github.com/users/ianepperson/following{/other_user}","gists_url":"https://api.github.com/users/ianepperson/gists{/gist_id}","starred_url":"https://api.github.com/users/ianepperson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianepperson/subscriptions","organizations_url":"https://api.github.com/users/ianepperson/orgs","repos_url":"https://api.github.com/users/ianepperson/repos","events_url":"https://api.github.com/users/ianepperson/events{/privacy}","received_events_url":"https://api.github.com/users/ianepperson/received_events","type":"User","site_admin":false},"body":"I ran into this problem today where my data would randomly have additional null strings from iter_lines.  I added a test to show the issue, then fixed it.\r\n\r\nThe only weirdness might be when no data comes back, how should iter_lines behave?  Should there be a single yield of a null string, or should it just return without yielding anything?  This edit performs the latter.","created_at":"2015-01-31T03:29:19Z","updated_at":"2015-01-31T03:29:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kennethreitz/requests/pulls/2431/commits","review_comments_url":"https://api.github.com/repos/kennethreitz/requests/pulls/2431/comments","review_comment_url":"https://api.github.com/repos/kennethreitz/requests/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kennethreitz/requests/issues/2431/comments","statuses_url":"https://api.github.com/repos/kennethreitz/requests/statuses/7a32de2647abcbcb8dea0978745009e875b39d09","head":{"label":"ianepperson:master","ref":"master","sha":"7a32de2647abcbcb8dea0978745009e875b39d09","user":{"login":"ianepperson","id":903537,"avatar_url":"https://avatars.githubusercontent.com/u/903537?v=3","gravatar_id":"","url":"https://api.github.com/users/ianepperson","html_url":"https://github.com/ianepperson","followers_url":"https://api.github.com/users/ianepperson/followers","following_url":"https://api.github.com/users/ianepperson/following{/other_user}","gists_url":"https://api.github.com/users/ianepperson/gists{/gist_id}","starred_url":"https://api.github.com/users/ianepperson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianepperson/subscriptions","organizations_url":"https://api.github.com/users/ianepperson/orgs","repos_url":"https://api.github.com/users/ianepperson/repos","events_url":"https://api.github.com/users/ianepperson/events{/privacy}","received_events_url":"https://api.github.com/users/ianepperson/received_events","type":"User","site_admin":false},"repo":{"id":30100021,"name":"requests","full_name":"ianepperson/requests","owner":{"login":"ianepperson","id":903537,"avatar_url":"https://avatars.githubusercontent.com/u/903537?v=3","gravatar_id":"","url":"https://api.github.com/users/ianepperson","html_url":"https://github.com/ianepperson","followers_url":"https://api.github.com/users/ianepperson/followers","following_url":"https://api.github.com/users/ianepperson/following{/other_user}","gists_url":"https://api.github.com/users/ianepperson/gists{/gist_id}","starred_url":"https://api.github.com/users/ianepperson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianepperson/subscriptions","organizations_url":"https://api.github.com/users/ianepperson/orgs","repos_url":"https://api.github.com/users/ianepperson/repos","events_url":"https://api.github.com/users/ianepperson/events{/privacy}","received_events_url":"https://api.github.com/users/ianepperson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianepperson/requests","description":"Python HTTP Requests for Humans™.","fork":true,"url":"https://api.github.com/repos/ianepperson/requests","forks_url":"https://api.github.com/repos/ianepperson/requests/forks","keys_url":"https://api.github.com/repos/ianepperson/requests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianepperson/requests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianepperson/requests/teams","hooks_url":"https://api.github.com/repos/ianepperson/requests/hooks","issue_events_url":"https://api.github.com/repos/ianepperson/requests/issues/events{/number}","events_url":"https://api.github.com/repos/ianepperson/requests/events","assignees_url":"https://api.github.com/repos/ianepperson/requests/assignees{/user}","branches_url":"https://api.github.com/repos/ianepperson/requests/branches{/branch}","tags_url":"https://api.github.com/repos/ianepperson/requests/tags","blobs_url":"https://api.github.com/repos/ianepperson/requests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianepperson/requests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianepperson/requests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianepperson/requests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianepperson/requests/statuses/{sha}","languages_url":"https://api.github.com/repos/ianepperson/requests/languages","stargazers_url":"https://api.github.com/repos/ianepperson/requests/stargazers","contributors_url":"https://api.github.com/repos/ianepperson/requests/contributors","subscribers_url":"https://api.github.com/repos/ianepperson/requests/subscribers","subscription_url":"https://api.github.com/repos/ianepperson/requests/subscription","commits_url":"https://api.github.com/repos/ianepperson/requests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianepperson/requests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianepperson/requests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianepperson/requests/issues/comments/{number}","contents_url":"https://api.github.com/repos/ianepperson/requests/contents/{+path}","compare_url":"https://api.github.com/repos/ianepperson/requests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianepperson/requests/merges","archive_url":"https://api.github.com/repos/ianepperson/requests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianepperson/requests/downloads","issues_url":"https://api.github.com/repos/ianepperson/requests/issues{/number}","pulls_url":"https://api.github.com/repos/ianepperson/requests/pulls{/number}","milestones_url":"https://api.github.com/repos/ianepperson/requests/milestones{/number}","notifications_url":"https://api.github.com/repos/ianepperson/requests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianepperson/requests/labels{/name}","releases_url":"https://api.github.com/repos/ianepperson/requests/releases{/id}","created_at":"2015-01-31T02:47:47Z","updated_at":"2015-01-31T03:23:13Z","pushed_at":"2015-01-31T03:23:12Z","git_url":"git://github.com/ianepperson/requests.git","ssh_url":"git@github.com:ianepperson/requests.git","clone_url":"https://github.com/ianepperson/requests.git","svn_url":"https://github.com/ianepperson/requests","homepage":"python-requests.org","size":12666,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kennethreitz:master","ref":"master","sha":"b137472936cbe6a6acabab538c1d05ed4c7da638","user":{"login":"kennethreitz","id":119893,"avatar_url":"https://avatars.githubusercontent.com/u/119893?v=3","gravatar_id":"","url":"https://api.github.com/users/kennethreitz","html_url":"https://github.com/kennethreitz","followers_url":"https://api.github.com/users/kennethreitz/followers","following_url":"https://api.github.com/users/kennethreitz/following{/other_user}","gists_url":"https://api.github.com/users/kennethreitz/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethreitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethreitz/subscriptions","organizations_url":"https://api.github.com/users/kennethreitz/orgs","repos_url":"https://api.github.com/users/kennethreitz/repos","events_url":"https://api.github.com/users/kennethreitz/events{/privacy}","received_events_url":"https://api.github.com/users/kennethreitz/received_events","type":"User","site_admin":false},"repo":{"id":1362490,"name":"requests","full_name":"kennethreitz/requests","owner":{"login":"kennethreitz","id":119893,"avatar_url":"https://avatars.githubusercontent.com/u/119893?v=3","gravatar_id":"","url":"https://api.github.com/users/kennethreitz","html_url":"https://github.com/kennethreitz","followers_url":"https://api.github.com/users/kennethreitz/followers","following_url":"https://api.github.com/users/kennethreitz/following{/other_user}","gists_url":"https://api.github.com/users/kennethreitz/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethreitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethreitz/subscriptions","organizations_url":"https://api.github.com/users/kennethreitz/orgs","repos_url":"https://api.github.com/users/kennethreitz/repos","events_url":"https://api.github.com/users/kennethreitz/events{/privacy}","received_events_url":"https://api.github.com/users/kennethreitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kennethreitz/requests","description":"Python HTTP Requests for Humans™.","fork":false,"url":"https://api.github.com/repos/kennethreitz/requests","forks_url":"https://api.github.com/repos/kennethreitz/requests/forks","keys_url":"https://api.github.com/repos/kennethreitz/requests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kennethreitz/requests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kennethreitz/requests/teams","hooks_url":"https://api.github.com/repos/kennethreitz/requests/hooks","issue_events_url":"https://api.github.com/repos/kennethreitz/requests/issues/events{/number}","events_url":"https://api.github.com/repos/kennethreitz/requests/events","assignees_url":"https://api.github.com/repos/kennethreitz/requests/assignees{/user}","branches_url":"https://api.github.com/repos/kennethreitz/requests/branches{/branch}","tags_url":"https://api.github.com/repos/kennethreitz/requests/tags","blobs_url":"https://api.github.com/repos/kennethreitz/requests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kennethreitz/requests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kennethreitz/requests/git/refs{/sha}","trees_url":"https://api.github.com/repos/kennethreitz/requests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kennethreitz/requests/statuses/{sha}","languages_url":"https://api.github.com/repos/kennethreitz/requests/languages","stargazers_url":"https://api.github.com/repos/kennethreitz/requests/stargazers","contributors_url":"https://api.github.com/repos/kennethreitz/requests/contributors","subscribers_url":"https://api.github.com/repos/kennethreitz/requests/subscribers","subscription_url":"https://api.github.com/repos/kennethreitz/requests/subscription","commits_url":"https://api.github.com/repos/kennethreitz/requests/commits{/sha}","git_commits_url":"https://api.github.com/repos/kennethreitz/requests/git/commits{/sha}","comments_url":"https://api.github.com/repos/kennethreitz/requests/comments{/number}","issue_comment_url":"https://api.github.com/repos/kennethreitz/requests/issues/comments/{number}","contents_url":"https://api.github.com/repos/kennethreitz/requests/contents/{+path}","compare_url":"https://api.github.com/repos/kennethreitz/requests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kennethreitz/requests/merges","archive_url":"https://api.github.com/repos/kennethreitz/requests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kennethreitz/requests/downloads","issues_url":"https://api.github.com/repos/kennethreitz/requests/issues{/number}","pulls_url":"https://api.github.com/repos/kennethreitz/requests/pulls{/number}","milestones_url":"https://api.github.com/repos/kennethreitz/requests/milestones{/number}","notifications_url":"https://api.github.com/repos/kennethreitz/requests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kennethreitz/requests/labels{/name}","releases_url":"https://api.github.com/repos/kennethreitz/requests/releases{/id}","created_at":"2011-02-13T18:38:17Z","updated_at":"2015-01-31T02:08:12Z","pushed_at":"2015-01-29T02:48:22Z","git_url":"git://github.com/kennethreitz/requests.git","ssh_url":"git@github.com:kennethreitz/requests.git","clone_url":"https://github.com/kennethreitz/requests.git","svn_url":"https://github.com/kennethreitz/requests","homepage":"python-requests.org","size":12666,"stargazers_count":12488,"watchers_count":12488,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2023,"mirror_url":null,"open_issues_count":63,"forks":2023,"open_issues":63,"watchers":12488,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/2431"},"html":{"href":"https://github.com/kennethreitz/requests/pull/2431"},"issue":{"href":"https://api.github.com/repos/kennethreitz/requests/issues/2431"},"comments":{"href":"https://api.github.com/repos/kennethreitz/requests/issues/2431/comments"},"review_comments":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/2431/comments"},"review_comment":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kennethreitz/requests/pulls/2431/commits"},"statuses":{"href":"https://api.github.com/repos/kennethreitz/requests/statuses/7a32de2647abcbcb8dea0978745009e875b39d09"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":58,"deletions":5,"changed_files":2}}