{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/36833745","id":36833745,"diff_hunk":"@@ -478,6 +478,12 @@\n                 <copy todir=\"${basedir}/target/generated-webapp/WEB-INF/classes/scripts\">\n                   <fileset dir=\"${basedir}/../scripts\"/>\n                 </copy>\n+                <copy todir=\"${basedir}/target/generated-webapp/WEB-INF/classes/systemvm/js\">","path":"client/pom.xml","position":4,"original_position":4,"commit_id":"2d20c2c9b0bfa11157f3412080144df81d149438","original_commit_id":"2d20c2c9b0bfa11157f3412080144df81d149438","user":{"login":"anshul1886","id":1712815,"avatar_url":"https://avatars.githubusercontent.com/u/1712815?v=3","gravatar_id":"","url":"https://api.github.com/users/anshul1886","html_url":"https://github.com/anshul1886","followers_url":"https://api.github.com/users/anshul1886/followers","following_url":"https://api.github.com/users/anshul1886/following{/other_user}","gists_url":"https://api.github.com/users/anshul1886/gists{/gist_id}","starred_url":"https://api.github.com/users/anshul1886/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshul1886/subscriptions","organizations_url":"https://api.github.com/users/anshul1886/orgs","repos_url":"https://api.github.com/users/anshul1886/repos","events_url":"https://api.github.com/users/anshul1886/events{/privacy}","received_events_url":"https://api.github.com/users/anshul1886/received_events","type":"User","site_admin":false},"body":"FS https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+non-US+keyboards+in+Console+Proxy has details regarding console proxy workflow which is present in description.\r\n\r\nIn developer setup these files are always present so adding unit test for certain (which will always pass) thing doesn't make sense to me. In my opinion unit test are meant to test corner cases or some uncertainty.\r\n\r\nI will try to improve description.\r\n\r\n","created_at":"2015-08-12T07:43:46Z","updated_at":"2015-08-12T07:43:46Z","html_url":"https://github.com/apache/cloudstack/pull/669#discussion_r36833745","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/669","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/36833745"},"html":{"href":"https://github.com/apache/cloudstack/pull/669#discussion_r36833745"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/669"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/669","id":41994109,"html_url":"https://github.com/apache/cloudstack/pull/669","diff_url":"https://github.com/apache/cloudstack/pull/669.diff","patch_url":"https://github.com/apache/cloudstack/pull/669.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/669","number":669,"state":"open","locked":false,"title":"Made the adding new keyboard language support easier","user":{"login":"anshul1886","id":1712815,"avatar_url":"https://avatars.githubusercontent.com/u/1712815?v=3","gravatar_id":"","url":"https://api.github.com/users/anshul1886","html_url":"https://github.com/anshul1886","followers_url":"https://api.github.com/users/anshul1886/followers","following_url":"https://api.github.com/users/anshul1886/following{/other_user}","gists_url":"https://api.github.com/users/anshul1886/gists{/gist_id}","starred_url":"https://api.github.com/users/anshul1886/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshul1886/subscriptions","organizations_url":"https://api.github.com/users/anshul1886/orgs","repos_url":"https://api.github.com/users/anshul1886/repos","events_url":"https://api.github.com/users/anshul1886/events{/privacy}","received_events_url":"https://api.github.com/users/anshul1886/received_events","type":"User","site_admin":false},"body":"This branch has implemented following improvements in console proxy keyboard language support\r\n\r\n1) ajaxviewer.js and ajaxkeys.js are main files involved in key code translations. These files now can be copied in systemvm/js folder and they will be copied to CPVM with stop/start performed on it.\r\n2) Started passing parameters to CPVM needed to resolve the ambiguous cases of keycode translations.\r\n3) Generalise the framework such that one needs to modify only ajaxkeys.js (file which has keycode mappings) without need of much knowledge in js.\r\n\r\nFS for this feature is available at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+non-US+keyboards+in+Console+Proxy","created_at":"2015-08-10T07:38:56Z","updated_at":"2015-08-12T07:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6304924ccd84ed04ec8a5c61f87779ed4e01b03e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/669/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/669/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/669/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/2d20c2c9b0bfa11157f3412080144df81d149438","head":{"label":"anshul1886:nonuskeyboardsupport","ref":"nonuskeyboardsupport","sha":"2d20c2c9b0bfa11157f3412080144df81d149438","user":{"login":"anshul1886","id":1712815,"avatar_url":"https://avatars.githubusercontent.com/u/1712815?v=3","gravatar_id":"","url":"https://api.github.com/users/anshul1886","html_url":"https://github.com/anshul1886","followers_url":"https://api.github.com/users/anshul1886/followers","following_url":"https://api.github.com/users/anshul1886/following{/other_user}","gists_url":"https://api.github.com/users/anshul1886/gists{/gist_id}","starred_url":"https://api.github.com/users/anshul1886/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshul1886/subscriptions","organizations_url":"https://api.github.com/users/anshul1886/orgs","repos_url":"https://api.github.com/users/anshul1886/repos","events_url":"https://api.github.com/users/anshul1886/events{/privacy}","received_events_url":"https://api.github.com/users/anshul1886/received_events","type":"User","site_admin":false},"repo":{"id":25956790,"name":"cloudstack-1","full_name":"anshul1886/cloudstack-1","owner":{"login":"anshul1886","id":1712815,"avatar_url":"https://avatars.githubusercontent.com/u/1712815?v=3","gravatar_id":"","url":"https://api.github.com/users/anshul1886","html_url":"https://github.com/anshul1886","followers_url":"https://api.github.com/users/anshul1886/followers","following_url":"https://api.github.com/users/anshul1886/following{/other_user}","gists_url":"https://api.github.com/users/anshul1886/gists{/gist_id}","starred_url":"https://api.github.com/users/anshul1886/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshul1886/subscriptions","organizations_url":"https://api.github.com/users/anshul1886/orgs","repos_url":"https://api.github.com/users/anshul1886/repos","events_url":"https://api.github.com/users/anshul1886/events{/privacy}","received_events_url":"https://api.github.com/users/anshul1886/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anshul1886/cloudstack-1","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/anshul1886/cloudstack-1","forks_url":"https://api.github.com/repos/anshul1886/cloudstack-1/forks","keys_url":"https://api.github.com/repos/anshul1886/cloudstack-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anshul1886/cloudstack-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anshul1886/cloudstack-1/teams","hooks_url":"https://api.github.com/repos/anshul1886/cloudstack-1/hooks","issue_events_url":"https://api.github.com/repos/anshul1886/cloudstack-1/issues/events{/number}","events_url":"https://api.github.com/repos/anshul1886/cloudstack-1/events","assignees_url":"https://api.github.com/repos/anshul1886/cloudstack-1/assignees{/user}","branches_url":"https://api.github.com/repos/anshul1886/cloudstack-1/branches{/branch}","tags_url":"https://api.github.com/repos/anshul1886/cloudstack-1/tags","blobs_url":"https://api.github.com/repos/anshul1886/cloudstack-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anshul1886/cloudstack-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anshul1886/cloudstack-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/anshul1886/cloudstack-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anshul1886/cloudstack-1/statuses/{sha}","languages_url":"https://api.github.com/repos/anshul1886/cloudstack-1/languages","stargazers_url":"https://api.github.com/repos/anshul1886/cloudstack-1/stargazers","contributors_url":"https://api.github.com/repos/anshul1886/cloudstack-1/contributors","subscribers_url":"https://api.github.com/repos/anshul1886/cloudstack-1/subscribers","subscription_url":"https://api.github.com/repos/anshul1886/cloudstack-1/subscription","commits_url":"https://api.github.com/repos/anshul1886/cloudstack-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/anshul1886/cloudstack-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/anshul1886/cloudstack-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/anshul1886/cloudstack-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/anshul1886/cloudstack-1/contents/{+path}","compare_url":"https://api.github.com/repos/anshul1886/cloudstack-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anshul1886/cloudstack-1/merges","archive_url":"https://api.github.com/repos/anshul1886/cloudstack-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anshul1886/cloudstack-1/downloads","issues_url":"https://api.github.com/repos/anshul1886/cloudstack-1/issues{/number}","pulls_url":"https://api.github.com/repos/anshul1886/cloudstack-1/pulls{/number}","milestones_url":"https://api.github.com/repos/anshul1886/cloudstack-1/milestones{/number}","notifications_url":"https://api.github.com/repos/anshul1886/cloudstack-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anshul1886/cloudstack-1/labels{/name}","releases_url":"https://api.github.com/repos/anshul1886/cloudstack-1/releases{/id}","created_at":"2014-10-30T05:52:06Z","updated_at":"2014-11-18T06:08:32Z","pushed_at":"2015-08-10T10:46:21Z","git_url":"git://github.com/anshul1886/cloudstack-1.git","ssh_url":"git@github.com:anshul1886/cloudstack-1.git","clone_url":"https://github.com/anshul1886/cloudstack-1.git","svn_url":"https://github.com/anshul1886/cloudstack-1","homepage":null,"size":485011,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e8ade2dd9edb59f2bb5aaee1573e03363586c2c2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-08-11T18:45:07Z","pushed_at":"2015-08-12T06:01:55Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":751987,"stargazers_count":271,"watchers_count":271,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":342,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":33,"forks":342,"open_issues":33,"watchers":271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/669"},"html":{"href":"https://github.com/apache/cloudstack/pull/669"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/669"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/669/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/669/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/669/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/2d20c2c9b0bfa11157f3412080144df81d149438"}}}}