{"action":"created","issue":{"url":"https://api.github.com/repos/NebulousLabs/Sia/issues/313","labels_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/313/labels{/name}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/313/comments","events_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/313/events","html_url":"https://github.com/NebulousLabs/Sia/pull/313","id":56427096,"number":313,"title":"Further testing","user":{"login":"DavidVorick","id":2316841,"avatar_url":"https://avatars.githubusercontent.com/u/2316841?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidVorick","html_url":"https://github.com/DavidVorick","followers_url":"https://api.github.com/users/DavidVorick/followers","following_url":"https://api.github.com/users/DavidVorick/following{/other_user}","gists_url":"https://api.github.com/users/DavidVorick/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidVorick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidVorick/subscriptions","organizations_url":"https://api.github.com/users/DavidVorick/orgs","repos_url":"https://api.github.com/users/DavidVorick/repos","events_url":"https://api.github.com/users/DavidVorick/events{/privacy}","received_events_url":"https://api.github.com/users/DavidVorick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-03T19:49:41Z","updated_at":"2015-02-06T00:17:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/313","html_url":"https://github.com/NebulousLabs/Sia/pull/313","diff_url":"https://github.com/NebulousLabs/Sia/pull/313.diff","patch_url":"https://github.com/NebulousLabs/Sia/pull/313.patch"},"body":"I change Standard.md to be an actual markdown file.\r\n\r\nI renamed Transaction.Output and Transaction.Input to SiacoinOutput and SiacoinInput respectively, because there are siafunds as well.\r\n\r\nI added a forking test to make sure the state rewinds and reapplies correctly (it didn't, but now it does).\r\n\r\nI added contract testing, transaction testing, and expanded the crypto package a little bit to check for nil stuff.\r\n\r\nI changed to using `encoding.Marshal` and `encoding.Unmarshal` instead of doing it manually. This may have introduced regressions, but only in packages that have minimal to no testing. The bugs should pop up immediately once we add testing.\r\n\r\nThe consensus testing suite is a bit of a mess right now. The functions could be more oragnized, and it could use better tooling in general. I've decided to let it be messy for now though, because the testing is now pretty thorough (74%!) and we don't need to test it to death before we return to working on the user experience. I think we can come back in a few weeks and do organizational cleanup, and improve the testing tooling.\r\n\r\nPretty much all that remains at this point is the 100 block limit and the siafunds, and testing for each. (We also need to test the exported functions)."},"comment":{"url":"https://api.github.com/repos/NebulousLabs/Sia/issues/comments/73158246","html_url":"https://github.com/NebulousLabs/Sia/pull/313#issuecomment-73158246","issue_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/313","id":73158246,"user":{"login":"DavidVorick","id":2316841,"avatar_url":"https://avatars.githubusercontent.com/u/2316841?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidVorick","html_url":"https://github.com/DavidVorick","followers_url":"https://api.github.com/users/DavidVorick/followers","following_url":"https://api.github.com/users/DavidVorick/following{/other_user}","gists_url":"https://api.github.com/users/DavidVorick/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidVorick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidVorick/subscriptions","organizations_url":"https://api.github.com/users/DavidVorick/orgs","repos_url":"https://api.github.com/users/DavidVorick/repos","events_url":"https://api.github.com/users/DavidVorick/events{/privacy}","received_events_url":"https://api.github.com/users/DavidVorick/received_events","type":"User","site_admin":false},"created_at":"2015-02-06T00:17:28Z","updated_at":"2015-02-06T00:17:28Z","body":"unless there is something urgent about one of these, I would like to implement them in my next pr. I think there would be merge conflicts otherwise."}}