{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments/30726850","id":30726850,"diff_hunk":"@@ -23,20 +23,18 @@ LICENSE=\"Apache-2.0\"\n SLOT=\"0\"\n IUSE=\"\"\n \n-DEPEND=\">=dev-lang/go-1.2\"\n-\n src_compile() {\n \t# work around gentoo hardened gcc incompatibilities with cgo\n \t# see https://bugs.gentoo.org/show_bug.cgi?id=493328\n \tif gcc-specs-pie; then\n-\t\tGOLDFLAGS=\"-extldflags -fno-PIC\"\n+\t\tCGO_LDFLAGS+=\" -extldflags -fno-PIC\"","path":"app-admin/locksmith/locksmith-9999.ebuild","position":37,"original_position":37,"commit_id":"1d2be460360794c7aedc448eb2f937e8825654b5","original_commit_id":"acb6f408195c9b7057691f8059ec4a27364ac3e7","user":{"login":"glevand","id":10858804,"avatar_url":"https://avatars.githubusercontent.com/u/10858804?v=3","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"body":"In this case I just converted what was already there.  On reading bug 493328, there is some mention of disabling PIC, but the problem seems to be PIE, and no other ebuilds disable PIC, so I think we should remove this, then if a problem is found, disable PIC in the eclass.","created_at":"2015-05-20T17:30:28Z","updated_at":"2015-05-20T17:30:28Z","html_url":"https://github.com/coreos/coreos-overlay/pull/1261#discussion_r30726850","pull_request_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1261","_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments/30726850"},"html":{"href":"https://github.com/coreos/coreos-overlay/pull/1261#discussion_r30726850"},"pull_request":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1261"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1261","id":35786043,"html_url":"https://github.com/coreos/coreos-overlay/pull/1261","diff_url":"https://github.com/coreos/coreos-overlay/pull/1261.diff","patch_url":"https://github.com/coreos/coreos-overlay/pull/1261.patch","issue_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/1261","number":1261,"state":"open","locked":false,"title":"Update go program ebuilds for arm64","user":{"login":"glevand","id":10858804,"avatar_url":"https://avatars.githubusercontent.com/u/10858804?v=3","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"body":"This series re-works the go language program ebuilds to allow building for arm64.  I have not finished rkt, as it is has a long and involved build procedure which I'll continue to work on.  \r\n\r\nIncluded in the series are some minor fixups to the coreos-go eclass.\r\n\r\nSince coreos-go eclass has a dependency on dev-lang/go and the current stable is go-1.4 I could remove several redundant DEPENDS from the ebuilds.\r\n\r\nPlease consider.\r\n\r\n-Geoff\r\n","created_at":"2015-05-19T23:40:01Z","updated_at":"2015-05-20T17:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"779174fe7d527eb13759d88d76d42658b34228de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1261/commits","review_comments_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1261/comments","review_comment_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/1261/comments","statuses_url":"https://api.github.com/repos/coreos/coreos-overlay/statuses/1d2be460360794c7aedc448eb2f937e8825654b5","head":{"label":"glevand:for-merge-1","ref":"for-merge-1","sha":"1d2be460360794c7aedc448eb2f937e8825654b5","user":{"login":"glevand","id":10858804,"avatar_url":"https://avatars.githubusercontent.com/u/10858804?v=3","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"repo":{"id":32751511,"name":"coreos--coreos-overlay","full_name":"glevand/coreos--coreos-overlay","owner":{"login":"glevand","id":10858804,"avatar_url":"https://avatars.githubusercontent.com/u/10858804?v=3","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glevand/coreos--coreos-overlay","description":"CoreOS arm64 port","fork":true,"url":"https://api.github.com/repos/glevand/coreos--coreos-overlay","forks_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/forks","keys_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/teams","hooks_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/hooks","issue_events_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/events","assignees_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/tags","blobs_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/languages","stargazers_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/stargazers","contributors_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/contributors","subscribers_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/subscribers","subscription_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/subscription","commits_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/merges","archive_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/downloads","issues_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/labels{/name}","releases_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/releases{/id}","created_at":"2015-03-23T18:39:29Z","updated_at":"2015-05-08T19:51:14Z","pushed_at":"2015-05-20T16:51:19Z","git_url":"git://github.com/glevand/coreos--coreos-overlay.git","ssh_url":"git@github.com:glevand/coreos--coreos-overlay.git","clone_url":"https://github.com/glevand/coreos--coreos-overlay.git","svn_url":"https://github.com/glevand/coreos--coreos-overlay","homepage":"","size":8137,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"de3a75ca0777e9de59b6fb443d443b8a06c914e5","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":8488820,"name":"coreos-overlay","full_name":"coreos/coreos-overlay","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/coreos-overlay","description":"Custom ebuilds for CoreOS","fork":false,"url":"https://api.github.com/repos/coreos/coreos-overlay","forks_url":"https://api.github.com/repos/coreos/coreos-overlay/forks","keys_url":"https://api.github.com/repos/coreos/coreos-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/coreos-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/coreos-overlay/teams","hooks_url":"https://api.github.com/repos/coreos/coreos-overlay/hooks","issue_events_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/coreos-overlay/events","assignees_url":"https://api.github.com/repos/coreos/coreos-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/coreos-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/coreos-overlay/tags","blobs_url":"https://api.github.com/repos/coreos/coreos-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/coreos-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/coreos-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/coreos-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/coreos-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/coreos-overlay/languages","stargazers_url":"https://api.github.com/repos/coreos/coreos-overlay/stargazers","contributors_url":"https://api.github.com/repos/coreos/coreos-overlay/contributors","subscribers_url":"https://api.github.com/repos/coreos/coreos-overlay/subscribers","subscription_url":"https://api.github.com/repos/coreos/coreos-overlay/subscription","commits_url":"https://api.github.com/repos/coreos/coreos-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/coreos-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/coreos-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/coreos-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/coreos-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/coreos-overlay/merges","archive_url":"https://api.github.com/repos/coreos/coreos-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/coreos-overlay/downloads","issues_url":"https://api.github.com/repos/coreos/coreos-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/coreos-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/coreos-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/coreos-overlay/labels{/name}","releases_url":"https://api.github.com/repos/coreos/coreos-overlay/releases{/id}","created_at":"2013-02-28T21:43:07Z","updated_at":"2015-05-20T03:40:03Z","pushed_at":"2015-05-20T01:21:24Z","git_url":"git://github.com/coreos/coreos-overlay.git","ssh_url":"git@github.com:coreos/coreos-overlay.git","clone_url":"https://github.com/coreos/coreos-overlay.git","svn_url":"https://github.com/coreos/coreos-overlay","homepage":"http://coreos.com/docs/sdk/","size":16018,"stargazers_count":107,"watchers_count":107,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":33,"forks":79,"open_issues":33,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1261"},"html":{"href":"https://github.com/coreos/coreos-overlay/pull/1261"},"issue":{"href":"https://api.github.com/repos/coreos/coreos-overlay/issues/1261"},"comments":{"href":"https://api.github.com/repos/coreos/coreos-overlay/issues/1261/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1261/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1261/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/coreos-overlay/statuses/1d2be460360794c7aedc448eb2f937e8825654b5"}}}}