{"action":"created","comment":{"url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/comments/28342346","id":28342346,"diff_hunk":"@@ -84,13 +89,18 @@ define(['../core', '../lib/utils', './analytics-mixin'], function(Openhose, Util\n     validate: function(metrics, dimensions) {\n       var validated = true;\n       var error = null;\n-      if (dimensions.length !== 1) {\n+      var errorMsg = \"Motion-Scatter needs at least 1 metric with 2 to 3 ids or 1 dimension with 2 to 3 metrics\";","path":"src/processor/motion-scatter.js","position":45,"original_position":45,"commit_id":"df2b2ee8ae6b00c0c3fd783265ad0ffede52cfb0","original_commit_id":"df2b2ee8ae6b00c0c3fd783265ad0ffede52cfb0","user":{"login":"kevinvandijk","id":223256,"avatar_url":"https://avatars.githubusercontent.com/u/223256?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinvandijk","html_url":"https://github.com/kevinvandijk","followers_url":"https://api.github.com/users/kevinvandijk/followers","following_url":"https://api.github.com/users/kevinvandijk/following{/other_user}","gists_url":"https://api.github.com/users/kevinvandijk/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinvandijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinvandijk/subscriptions","organizations_url":"https://api.github.com/users/kevinvandijk/orgs","repos_url":"https://api.github.com/users/kevinvandijk/repos","events_url":"https://api.github.com/users/kevinvandijk/events{/privacy}","received_events_url":"https://api.github.com/users/kevinvandijk/received_events","type":"User","site_admin":false},"body":"I think the error is  a bit unclear. Maybe: '[..] or exactly 1 dimension [..]' would make it a bit clearer","created_at":"2015-04-14T16:14:31Z","updated_at":"2015-04-14T16:14:31Z","html_url":"https://github.com/openhose/openhose-visualizations-sdk/pull/17#discussion_r28342346","pull_request_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/comments/28342346"},"html":{"href":"https://github.com/openhose/openhose-visualizations-sdk/pull/17#discussion_r28342346"},"pull_request":{"href":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/17","id":33174478,"html_url":"https://github.com/openhose/openhose-visualizations-sdk/pull/17","diff_url":"https://github.com/openhose/openhose-visualizations-sdk/pull/17.diff","patch_url":"https://github.com/openhose/openhose-visualizations-sdk/pull/17.patch","issue_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/issues/17","number":17,"state":"open","locked":false,"title":"Motion scatter enhancements","user":{"login":"Juice10","id":4106,"avatar_url":"https://avatars.githubusercontent.com/u/4106?v=3","gravatar_id":"","url":"https://api.github.com/users/Juice10","html_url":"https://github.com/Juice10","followers_url":"https://api.github.com/users/Juice10/followers","following_url":"https://api.github.com/users/Juice10/following{/other_user}","gists_url":"https://api.github.com/users/Juice10/gists{/gist_id}","starred_url":"https://api.github.com/users/Juice10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juice10/subscriptions","organizations_url":"https://api.github.com/users/Juice10/orgs","repos_url":"https://api.github.com/users/Juice10/repos","events_url":"https://api.github.com/users/Juice10/events{/privacy}","received_events_url":"https://api.github.com/users/Juice10/received_events","type":"User","site_admin":false},"body":"  - Timeline deals better with daylight savings time\r\n  - Motion Scatter can now handle custom metrics\r\n  - Validation is enhanced (and correct)\r\n\r\n@kevinvandijk @drakonen @kaareal @aaronz8 @cthacker ","created_at":"2015-04-13T15:30:25Z","updated_at":"2015-04-14T16:14:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8a6a21b8b9fc01b11b50b798b22be687aefd0ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/17/commits","review_comments_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/17/comments","review_comment_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/issues/17/comments","statuses_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/statuses/df2b2ee8ae6b00c0c3fd783265ad0ffede52cfb0","head":{"label":"openhose:motion-scatter-enhancements","ref":"motion-scatter-enhancements","sha":"df2b2ee8ae6b00c0c3fd783265ad0ffede52cfb0","user":{"login":"openhose","id":10420257,"avatar_url":"https://avatars.githubusercontent.com/u/10420257?v=3","gravatar_id":"","url":"https://api.github.com/users/openhose","html_url":"https://github.com/openhose","followers_url":"https://api.github.com/users/openhose/followers","following_url":"https://api.github.com/users/openhose/following{/other_user}","gists_url":"https://api.github.com/users/openhose/gists{/gist_id}","starred_url":"https://api.github.com/users/openhose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhose/subscriptions","organizations_url":"https://api.github.com/users/openhose/orgs","repos_url":"https://api.github.com/users/openhose/repos","events_url":"https://api.github.com/users/openhose/events{/privacy}","received_events_url":"https://api.github.com/users/openhose/received_events","type":"Organization","site_admin":false},"repo":{"id":29737607,"name":"openhose-visualizations-sdk","full_name":"openhose/openhose-visualizations-sdk","owner":{"login":"openhose","id":10420257,"avatar_url":"https://avatars.githubusercontent.com/u/10420257?v=3","gravatar_id":"","url":"https://api.github.com/users/openhose","html_url":"https://github.com/openhose","followers_url":"https://api.github.com/users/openhose/followers","following_url":"https://api.github.com/users/openhose/following{/other_user}","gists_url":"https://api.github.com/users/openhose/gists{/gist_id}","starred_url":"https://api.github.com/users/openhose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhose/subscriptions","organizations_url":"https://api.github.com/users/openhose/orgs","repos_url":"https://api.github.com/users/openhose/repos","events_url":"https://api.github.com/users/openhose/events{/privacy}","received_events_url":"https://api.github.com/users/openhose/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhose/openhose-visualizations-sdk","description":"Openhose Visualizations SDK","fork":false,"url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk","forks_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/forks","keys_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/teams","hooks_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/hooks","issue_events_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/events","assignees_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/tags","blobs_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/languages","stargazers_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/stargazers","contributors_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/contributors","subscribers_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/subscribers","subscription_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/subscription","commits_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/merges","archive_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/downloads","issues_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/labels{/name}","releases_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/releases{/id}","created_at":"2015-01-23T15:02:49Z","updated_at":"2015-04-13T15:33:23Z","pushed_at":"2015-04-14T15:47:09Z","git_url":"git://github.com/openhose/openhose-visualizations-sdk.git","ssh_url":"git@github.com:openhose/openhose-visualizations-sdk.git","clone_url":"https://github.com/openhose/openhose-visualizations-sdk.git","svn_url":"https://github.com/openhose/openhose-visualizations-sdk","homepage":null,"size":4343,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"openhose:master","ref":"master","sha":"2c190ce95b525f8e2f0d15cbb75c727945e20954","user":{"login":"openhose","id":10420257,"avatar_url":"https://avatars.githubusercontent.com/u/10420257?v=3","gravatar_id":"","url":"https://api.github.com/users/openhose","html_url":"https://github.com/openhose","followers_url":"https://api.github.com/users/openhose/followers","following_url":"https://api.github.com/users/openhose/following{/other_user}","gists_url":"https://api.github.com/users/openhose/gists{/gist_id}","starred_url":"https://api.github.com/users/openhose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhose/subscriptions","organizations_url":"https://api.github.com/users/openhose/orgs","repos_url":"https://api.github.com/users/openhose/repos","events_url":"https://api.github.com/users/openhose/events{/privacy}","received_events_url":"https://api.github.com/users/openhose/received_events","type":"Organization","site_admin":false},"repo":{"id":29737607,"name":"openhose-visualizations-sdk","full_name":"openhose/openhose-visualizations-sdk","owner":{"login":"openhose","id":10420257,"avatar_url":"https://avatars.githubusercontent.com/u/10420257?v=3","gravatar_id":"","url":"https://api.github.com/users/openhose","html_url":"https://github.com/openhose","followers_url":"https://api.github.com/users/openhose/followers","following_url":"https://api.github.com/users/openhose/following{/other_user}","gists_url":"https://api.github.com/users/openhose/gists{/gist_id}","starred_url":"https://api.github.com/users/openhose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhose/subscriptions","organizations_url":"https://api.github.com/users/openhose/orgs","repos_url":"https://api.github.com/users/openhose/repos","events_url":"https://api.github.com/users/openhose/events{/privacy}","received_events_url":"https://api.github.com/users/openhose/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhose/openhose-visualizations-sdk","description":"Openhose Visualizations SDK","fork":false,"url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk","forks_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/forks","keys_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/teams","hooks_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/hooks","issue_events_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/events","assignees_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/tags","blobs_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/languages","stargazers_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/stargazers","contributors_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/contributors","subscribers_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/subscribers","subscription_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/subscription","commits_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/merges","archive_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/downloads","issues_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/labels{/name}","releases_url":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/releases{/id}","created_at":"2015-01-23T15:02:49Z","updated_at":"2015-04-13T15:33:23Z","pushed_at":"2015-04-14T15:47:09Z","git_url":"git://github.com/openhose/openhose-visualizations-sdk.git","ssh_url":"git@github.com:openhose/openhose-visualizations-sdk.git","clone_url":"https://github.com/openhose/openhose-visualizations-sdk.git","svn_url":"https://github.com/openhose/openhose-visualizations-sdk","homepage":null,"size":4343,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/17"},"html":{"href":"https://github.com/openhose/openhose-visualizations-sdk/pull/17"},"issue":{"href":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/issues/17"},"comments":{"href":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/openhose/openhose-visualizations-sdk/statuses/df2b2ee8ae6b00c0c3fd783265ad0ffede52cfb0"}}}}