{"action":"created","comment":{"url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/comments/23390828","id":23390828,"diff_hunk":"@@ -44,14 +48,13 @@ private void persist() {\n \t\t\t@Override\n \t\t\tpublic void run() {\n \t\t\t\tJSONArray jsonArr = new JSONArray();\n-\t\t\t\tsynchronized(queue) {\n-\t\t\t\t\tIterator<ServerRequest> iter = queue.iterator();\n-\t\t\t\t\twhile (iter.hasNext()) {\n-\t\t\t\t\t\tJSONObject json = iter.next().toJSON();\n-\t\t\t\t\t\tif (json != null) {\n-\t\t\t\t\t\t\tjsonArr.put(json);\n-\t\t\t\t\t\t}\n-\t\t\t\t\t}\n+\t\t\t\tsynchronized(lock) {\n+                    for ( ServerRequest aQueue : queue ) {","path":"Branch-SDK/src/io/branch/referral/ServerRequestQueue.java","position":60,"original_position":60,"commit_id":"5c657406ee7d51d9e8023d716250a2f1229eec24","original_commit_id":"5c657406ee7d51d9e8023d716250a2f1229eec24","user":{"login":"aaustin","id":1332632,"avatar_url":"https://avatars.githubusercontent.com/u/1332632?v=3","gravatar_id":"","url":"https://api.github.com/users/aaustin","html_url":"https://github.com/aaustin","followers_url":"https://api.github.com/users/aaustin/followers","following_url":"https://api.github.com/users/aaustin/following{/other_user}","gists_url":"https://api.github.com/users/aaustin/gists{/gist_id}","starred_url":"https://api.github.com/users/aaustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaustin/subscriptions","organizations_url":"https://api.github.com/users/aaustin/orgs","repos_url":"https://api.github.com/users/aaustin/repos","events_url":"https://api.github.com/users/aaustin/events{/privacy}","received_events_url":"https://api.github.com/users/aaustin/received_events","type":"User","site_admin":false},"body":"same here!","created_at":"2015-01-22T17:06:09Z","updated_at":"2015-01-22T17:06:09Z","html_url":"https://github.com/BranchMetrics/Branch-Android-SDK/pull/33#discussion_r23390828","pull_request_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/comments/23390828"},"html":{"href":"https://github.com/BranchMetrics/Branch-Android-SDK/pull/33#discussion_r23390828"},"pull_request":{"href":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/33","id":27803615,"html_url":"https://github.com/BranchMetrics/Branch-Android-SDK/pull/33","diff_url":"https://github.com/BranchMetrics/Branch-Android-SDK/pull/33.diff","patch_url":"https://github.com/BranchMetrics/Branch-Android-SDK/pull/33.patch","issue_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/issues/33","number":33,"state":"open","locked":false,"title":"Android-Lint fixes","user":{"login":"SleeplessByte","id":1964376,"avatar_url":"https://avatars.githubusercontent.com/u/1964376?v=3","gravatar_id":"","url":"https://api.github.com/users/SleeplessByte","html_url":"https://github.com/SleeplessByte","followers_url":"https://api.github.com/users/SleeplessByte/followers","following_url":"https://api.github.com/users/SleeplessByte/following{/other_user}","gists_url":"https://api.github.com/users/SleeplessByte/gists{/gist_id}","starred_url":"https://api.github.com/users/SleeplessByte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SleeplessByte/subscriptions","organizations_url":"https://api.github.com/users/SleeplessByte/orgs","repos_url":"https://api.github.com/users/SleeplessByte/repos","events_url":"https://api.github.com/users/SleeplessByte/events{/privacy}","received_events_url":"https://api.github.com/users/SleeplessByte/received_events","type":"User","site_admin":false},"body":"This includes #32, so you can ignore that if you are going to merge this, or merge that first and then this.\r\n\r\n- [Assertion are not supported on Dalvik](http://tools.android.com/recent/androidstudio045released)\r\n- [Try not to use iterators](http://developer.android.com/training/articles/perf-tips.html) or `for( int i )` loops\r\n- Mark exceptions as purposefully unhandled","created_at":"2015-01-21T23:02:53Z","updated_at":"2015-01-22T17:06:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"256e4483f95d7371ad08fa7359976ca163fb1029","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/33/commits","review_comments_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/33/comments","review_comment_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/comments/{number}","comments_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/issues/33/comments","statuses_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/statuses/5c657406ee7d51d9e8023d716250a2f1229eec24","head":{"label":"paystik:feature/lint","ref":"feature/lint","sha":"5c657406ee7d51d9e8023d716250a2f1229eec24","user":{"login":"paystik","id":2375593,"avatar_url":"https://avatars.githubusercontent.com/u/2375593?v=3","gravatar_id":"","url":"https://api.github.com/users/paystik","html_url":"https://github.com/paystik","followers_url":"https://api.github.com/users/paystik/followers","following_url":"https://api.github.com/users/paystik/following{/other_user}","gists_url":"https://api.github.com/users/paystik/gists{/gist_id}","starred_url":"https://api.github.com/users/paystik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paystik/subscriptions","organizations_url":"https://api.github.com/users/paystik/orgs","repos_url":"https://api.github.com/users/paystik/repos","events_url":"https://api.github.com/users/paystik/events{/privacy}","received_events_url":"https://api.github.com/users/paystik/received_events","type":"Organization","site_admin":false},"repo":{"id":29500643,"name":"Branch-Android-SDK","full_name":"paystik/Branch-Android-SDK","owner":{"login":"paystik","id":2375593,"avatar_url":"https://avatars.githubusercontent.com/u/2375593?v=3","gravatar_id":"","url":"https://api.github.com/users/paystik","html_url":"https://github.com/paystik","followers_url":"https://api.github.com/users/paystik/followers","following_url":"https://api.github.com/users/paystik/following{/other_user}","gists_url":"https://api.github.com/users/paystik/gists{/gist_id}","starred_url":"https://api.github.com/users/paystik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paystik/subscriptions","organizations_url":"https://api.github.com/users/paystik/orgs","repos_url":"https://api.github.com/users/paystik/repos","events_url":"https://api.github.com/users/paystik/events{/privacy}","received_events_url":"https://api.github.com/users/paystik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paystik/Branch-Android-SDK","description":"","fork":true,"url":"https://api.github.com/repos/paystik/Branch-Android-SDK","forks_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/forks","keys_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/teams","hooks_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/hooks","issue_events_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/issues/events{/number}","events_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/events","assignees_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/assignees{/user}","branches_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/branches{/branch}","tags_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/tags","blobs_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/statuses/{sha}","languages_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/languages","stargazers_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/stargazers","contributors_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/contributors","subscribers_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/subscribers","subscription_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/subscription","commits_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/issues/comments/{number}","contents_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/contents/{+path}","compare_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/merges","archive_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/downloads","issues_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/issues{/number}","pulls_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/pulls{/number}","milestones_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/milestones{/number}","notifications_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/labels{/name}","releases_url":"https://api.github.com/repos/paystik/Branch-Android-SDK/releases{/id}","created_at":"2015-01-19T22:48:04Z","updated_at":"2015-01-21T22:12:53Z","pushed_at":"2015-01-21T23:49:48Z","git_url":"git://github.com/paystik/Branch-Android-SDK.git","ssh_url":"git@github.com:paystik/Branch-Android-SDK.git","clone_url":"https://github.com/paystik/Branch-Android-SDK.git","svn_url":"https://github.com/paystik/Branch-Android-SDK","homepage":"","size":4587,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BranchMetrics:master","ref":"master","sha":"ffd582e4997f0a682005c9698c5eccc4bc547761","user":{"login":"BranchMetrics","id":7772941,"avatar_url":"https://avatars.githubusercontent.com/u/7772941?v=3","gravatar_id":"","url":"https://api.github.com/users/BranchMetrics","html_url":"https://github.com/BranchMetrics","followers_url":"https://api.github.com/users/BranchMetrics/followers","following_url":"https://api.github.com/users/BranchMetrics/following{/other_user}","gists_url":"https://api.github.com/users/BranchMetrics/gists{/gist_id}","starred_url":"https://api.github.com/users/BranchMetrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BranchMetrics/subscriptions","organizations_url":"https://api.github.com/users/BranchMetrics/orgs","repos_url":"https://api.github.com/users/BranchMetrics/repos","events_url":"https://api.github.com/users/BranchMetrics/events{/privacy}","received_events_url":"https://api.github.com/users/BranchMetrics/received_events","type":"Organization","site_admin":false},"repo":{"id":20421659,"name":"Branch-Android-SDK","full_name":"BranchMetrics/Branch-Android-SDK","owner":{"login":"BranchMetrics","id":7772941,"avatar_url":"https://avatars.githubusercontent.com/u/7772941?v=3","gravatar_id":"","url":"https://api.github.com/users/BranchMetrics","html_url":"https://github.com/BranchMetrics","followers_url":"https://api.github.com/users/BranchMetrics/followers","following_url":"https://api.github.com/users/BranchMetrics/following{/other_user}","gists_url":"https://api.github.com/users/BranchMetrics/gists{/gist_id}","starred_url":"https://api.github.com/users/BranchMetrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BranchMetrics/subscriptions","organizations_url":"https://api.github.com/users/BranchMetrics/orgs","repos_url":"https://api.github.com/users/BranchMetrics/repos","events_url":"https://api.github.com/users/BranchMetrics/events{/privacy}","received_events_url":"https://api.github.com/users/BranchMetrics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BranchMetrics/Branch-Android-SDK","description":null,"fork":false,"url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK","forks_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/forks","keys_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/teams","hooks_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/hooks","issue_events_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/issues/events{/number}","events_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/events","assignees_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/assignees{/user}","branches_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/branches{/branch}","tags_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/tags","blobs_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/statuses/{sha}","languages_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/languages","stargazers_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/stargazers","contributors_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/contributors","subscribers_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/subscribers","subscription_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/subscription","commits_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/issues/comments/{number}","contents_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/contents/{+path}","compare_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/merges","archive_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/downloads","issues_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/issues{/number}","pulls_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls{/number}","milestones_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/milestones{/number}","notifications_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/labels{/name}","releases_url":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/releases{/id}","created_at":"2014-06-02T22:17:59Z","updated_at":"2015-01-21T04:22:21Z","pushed_at":"2015-01-22T01:33:59Z","git_url":"git://github.com/BranchMetrics/Branch-Android-SDK.git","ssh_url":"git@github.com:BranchMetrics/Branch-Android-SDK.git","clone_url":"https://github.com/BranchMetrics/Branch-Android-SDK.git","svn_url":"https://github.com/BranchMetrics/Branch-Android-SDK","homepage":null,"size":5636,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/33"},"html":{"href":"https://github.com/BranchMetrics/Branch-Android-SDK/pull/33"},"issue":{"href":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/issues/33"},"comments":{"href":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/BranchMetrics/Branch-Android-SDK/statuses/5c657406ee7d51d9e8023d716250a2f1229eec24"}}}}