{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/34611540","id":34611540,"diff_hunk":"@@ -30,11 +30,11 @@\n  */\n public interface Kafka {\n \n-    ConfigKey<String> SUGGESTED_VERSION = ConfigKeys.newConfigKeyWithDefault(SoftwareProcess.SUGGESTED_VERSION, \"0.7.2-incubating\");\n+    ConfigKey<String> SUGGESTED_VERSION = ConfigKeys.newConfigKeyWithDefault(SoftwareProcess.SUGGESTED_VERSION, \"2.9.2-0.8.2.1\");\n \n     @SetFromFlag(\"downloadUrl\")\n     BasicAttributeSensorAndConfigKey<String> DOWNLOAD_URL = new BasicAttributeSensorAndConfigKey<String>(\n-            Attributes.DOWNLOAD_URL, \"http://mirror.catn.com/pub/apache/incubator/kafka/kafka-${version}/kafka-${version}-src.tgz\");\n+            Attributes.DOWNLOAD_URL, \"http://apache.cbox.biz/kafka/0.8.2.1/kafka_${version}.tgz\");","path":"software/messaging/src/main/java/brooklyn/entity/messaging/kafka/Kafka.java","position":10,"original_position":10,"commit_id":"2117808f99878f60bb8ef1681419767d98a8997b","original_commit_id":"2117808f99878f60bb8ef1681419767d98a8997b","user":{"login":"mikezaccardo","id":11599963,"avatar_url":"https://avatars.githubusercontent.com/u/11599963?v=3","gravatar_id":"","url":"https://api.github.com/users/mikezaccardo","html_url":"https://github.com/mikezaccardo","followers_url":"https://api.github.com/users/mikezaccardo/followers","following_url":"https://api.github.com/users/mikezaccardo/following{/other_user}","gists_url":"https://api.github.com/users/mikezaccardo/gists{/gist_id}","starred_url":"https://api.github.com/users/mikezaccardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikezaccardo/subscriptions","organizations_url":"https://api.github.com/users/mikezaccardo/orgs","repos_url":"https://api.github.com/users/mikezaccardo/repos","events_url":"https://api.github.com/users/mikezaccardo/events{/privacy}","received_events_url":"https://api.github.com/users/mikezaccardo/received_events","type":"User","site_admin":false},"body":"Can the hardcoded `0.8.2.1` be avoided?","created_at":"2015-07-14T19:53:57Z","updated_at":"2015-07-14T19:53:57Z","html_url":"https://github.com/apache/incubator-brooklyn/pull/742#discussion_r34611540","pull_request_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/742","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments/34611540"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/742#discussion_r34611540"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/742"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/742","id":39610717,"html_url":"https://github.com/apache/incubator-brooklyn/pull/742","diff_url":"https://github.com/apache/incubator-brooklyn/pull/742.diff","patch_url":"https://github.com/apache/incubator-brooklyn/pull/742.patch","issue_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/742","number":742,"state":"open","locked":false,"title":"Fix KafkaIntegrationTest tests","user":{"login":"bostko","id":1595054,"avatar_url":"https://avatars.githubusercontent.com/u/1595054?v=3","gravatar_id":"","url":"https://api.github.com/users/bostko","html_url":"https://github.com/bostko","followers_url":"https://api.github.com/users/bostko/followers","following_url":"https://api.github.com/users/bostko/following{/other_user}","gists_url":"https://api.github.com/users/bostko/gists{/gist_id}","starred_url":"https://api.github.com/users/bostko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bostko/subscriptions","organizations_url":"https://api.github.com/users/bostko/orgs","repos_url":"https://api.github.com/users/bostko/repos","events_url":"https://api.github.com/users/bostko/events{/privacy}","received_events_url":"https://api.github.com/users/bostko/received_events","type":"User","site_admin":false},"body":"- updated kafka version\r\n- installing from binary instead of compiling from source\r\n\r\nNote on `KafkaIntegrationTest.testTwoBrokerCluster`:\r\nThe `getMessage()` return value is hardcoded since the new kafka client is still [not implemented](https://github.com/apache/kafka/blob/0.8.2/clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java#L553).\r\nI tried other version kafka_2.10, 0.8.2-beta  etc, but it is unfortunately it is still not supported, it is available only in trunk.\r\n","created_at":"2015-07-09T17:59:33Z","updated_at":"2015-07-14T19:53:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c85038a537ea5743dfe394d3f42257bd18aaa7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/742/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/742/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/742/comments","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/2117808f99878f60bb8ef1681419767d98a8997b","head":{"label":"bostko:fix_messaging_integration_tests","ref":"fix_messaging_integration_tests","sha":"2117808f99878f60bb8ef1681419767d98a8997b","user":{"login":"bostko","id":1595054,"avatar_url":"https://avatars.githubusercontent.com/u/1595054?v=3","gravatar_id":"","url":"https://api.github.com/users/bostko","html_url":"https://github.com/bostko","followers_url":"https://api.github.com/users/bostko/followers","following_url":"https://api.github.com/users/bostko/following{/other_user}","gists_url":"https://api.github.com/users/bostko/gists{/gist_id}","starred_url":"https://api.github.com/users/bostko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bostko/subscriptions","organizations_url":"https://api.github.com/users/bostko/orgs","repos_url":"https://api.github.com/users/bostko/repos","events_url":"https://api.github.com/users/bostko/events{/privacy}","received_events_url":"https://api.github.com/users/bostko/received_events","type":"User","site_admin":false},"repo":{"id":30598571,"name":"incubator-brooklyn","full_name":"bostko/incubator-brooklyn","owner":{"login":"bostko","id":1595054,"avatar_url":"https://avatars.githubusercontent.com/u/1595054?v=3","gravatar_id":"","url":"https://api.github.com/users/bostko","html_url":"https://github.com/bostko","followers_url":"https://api.github.com/users/bostko/followers","following_url":"https://api.github.com/users/bostko/following{/other_user}","gists_url":"https://api.github.com/users/bostko/gists{/gist_id}","starred_url":"https://api.github.com/users/bostko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bostko/subscriptions","organizations_url":"https://api.github.com/users/bostko/orgs","repos_url":"https://api.github.com/users/bostko/repos","events_url":"https://api.github.com/users/bostko/events{/privacy}","received_events_url":"https://api.github.com/users/bostko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bostko/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":true,"url":"https://api.github.com/repos/bostko/incubator-brooklyn","forks_url":"https://api.github.com/repos/bostko/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/bostko/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bostko/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bostko/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/bostko/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/bostko/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/bostko/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/bostko/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/bostko/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/bostko/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/bostko/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bostko/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bostko/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/bostko/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bostko/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/bostko/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/bostko/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/bostko/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/bostko/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/bostko/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/bostko/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/bostko/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/bostko/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/bostko/incubator-brooklyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/bostko/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/bostko/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bostko/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/bostko/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bostko/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/bostko/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/bostko/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/bostko/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/bostko/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bostko/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/bostko/incubator-brooklyn/releases{/id}","created_at":"2015-02-10T15:28:17Z","updated_at":"2015-02-26T07:39:42Z","pushed_at":"2015-07-14T18:49:06Z","git_url":"git://github.com/bostko/incubator-brooklyn.git","ssh_url":"git@github.com:bostko/incubator-brooklyn.git","clone_url":"https://github.com/bostko/incubator-brooklyn.git","svn_url":"https://github.com/bostko/incubator-brooklyn","homepage":null,"size":238735,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b2d3f336c8b59dd1b80a6bf5e14c8ce99236b144","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":19368221,"name":"incubator-brooklyn","full_name":"apache/incubator-brooklyn","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-brooklyn","description":"Mirror of Apache Brooklyn","fork":false,"url":"https://api.github.com/repos/apache/incubator-brooklyn","forks_url":"https://api.github.com/repos/apache/incubator-brooklyn/forks","keys_url":"https://api.github.com/repos/apache/incubator-brooklyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-brooklyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-brooklyn/teams","hooks_url":"https://api.github.com/repos/apache/incubator-brooklyn/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-brooklyn/events","assignees_url":"https://api.github.com/repos/apache/incubator-brooklyn/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-brooklyn/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/tags","blobs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-brooklyn/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-brooklyn/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-brooklyn/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-brooklyn/subscription","commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-brooklyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-brooklyn/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-brooklyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-brooklyn/merges","archive_url":"https://api.github.com/repos/apache/incubator-brooklyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-brooklyn/downloads","issues_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-brooklyn/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-brooklyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-brooklyn/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-brooklyn/releases{/id}","created_at":"2014-05-02T07:00:07Z","updated_at":"2015-07-07T15:37:42Z","pushed_at":"2015-07-14T19:43:19Z","git_url":"git://github.com/apache/incubator-brooklyn.git","ssh_url":"git@github.com:apache/incubator-brooklyn.git","clone_url":"https://github.com/apache/incubator-brooklyn.git","svn_url":"https://github.com/apache/incubator-brooklyn","homepage":null,"size":248681,"stargazers_count":88,"watchers_count":88,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":"git://git.apache.org/incubator-brooklyn.git","open_issues_count":26,"forks":78,"open_issues":26,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/742"},"html":{"href":"https://github.com/apache/incubator-brooklyn/pull/742"},"issue":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/742"},"comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/issues/742/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/742/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/742/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-brooklyn/statuses/2117808f99878f60bb8ef1681419767d98a8997b"}}}}