{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/3577","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/3577/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/3577/comments","events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/3577/events","html_url":"https://github.com/ember-cli/ember-cli/pull/3577","id":63214416,"number":3577,"title":"Added Ember + DS to predef to align with guides","user":{"login":"joostdevries","id":3824616,"avatar_url":"https://avatars.githubusercontent.com/u/3824616?v=3","gravatar_id":"","url":"https://api.github.com/users/joostdevries","html_url":"https://github.com/joostdevries","followers_url":"https://api.github.com/users/joostdevries/followers","following_url":"https://api.github.com/users/joostdevries/following{/other_user}","gists_url":"https://api.github.com/users/joostdevries/gists{/gist_id}","starred_url":"https://api.github.com/users/joostdevries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joostdevries/subscriptions","organizations_url":"https://api.github.com/users/joostdevries/orgs","repos_url":"https://api.github.com/users/joostdevries/repos","events_url":"https://api.github.com/users/joostdevries/events{/privacy}","received_events_url":"https://api.github.com/users/joostdevries/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/discussion","name":"discussion","color":"009800"},{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-03-20T11:49:53Z","updated_at":"2015-03-25T12:47:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/3577","html_url":"https://github.com/ember-cli/ember-cli/pull/3577","diff_url":"https://github.com/ember-cli/ember-cli/pull/3577.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/3577.patch"},"body":"DO NOT MERGE\r\n\r\nIn the [guides rewrite](https://github.com/emberjs/guides/issues/9#issuecomment-82526641) it was decided to leave out importing `Ember` and `DS`. In the current implementation that will confront users with jshint errors if they copy code examples from the guides.\r\n\r\nIf the guides rewrite is going to push a lot of people to try Ember CLI, we should [avoid people running into this](https://www.google.nl/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=%22ember%20is%20not%20defined%22).\r\n\r\nAlternate solutions:\r\n- Clearly document the need to import in the guides (for example the \"Concepts\" section), like on the [ember cli website](https://github.com/ember-cli/ember-cli/pull/1016/files)\r\n- Add imports to the examples/snippets"},"comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments/86010998","html_url":"https://github.com/ember-cli/ember-cli/pull/3577#issuecomment-86010998","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/3577","id":86010998,"user":{"login":"trek","id":9736,"avatar_url":"https://avatars.githubusercontent.com/u/9736?v=3","gravatar_id":"","url":"https://api.github.com/users/trek","html_url":"https://github.com/trek","followers_url":"https://api.github.com/users/trek/followers","following_url":"https://api.github.com/users/trek/following{/other_user}","gists_url":"https://api.github.com/users/trek/gists{/gist_id}","starred_url":"https://api.github.com/users/trek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trek/subscriptions","organizations_url":"https://api.github.com/users/trek/orgs","repos_url":"https://api.github.com/users/trek/repos","events_url":"https://api.github.com/users/trek/events{/privacy}","received_events_url":"https://api.github.com/users/trek/received_events","type":"User","site_admin":false},"created_at":"2015-03-25T12:47:14Z","updated_at":"2015-03-25T12:47:14Z","body":"> That argument makes sense in a world where everyone understands ES6 modules.  \r\n\r\nHappy to address when it proves to be a problem."}}