{"action":"created","comment":{"url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/comments/44827160","id":44827160,"diff_hunk":"@@ -0,0 +1,162 @@\n+import itertools\n+import logging\n+from lazy.lazy import lazy\n+from xblock.fields import String, Scope\n+from xblock.validation import ValidationMessage\n+from group_project_v2.stage.utils import DISPLAY_NAME_NAME, DISPLAY_NAME_HELP\n+from group_project_v2.stage.base import BaseGroupActivityStage\n+from group_project_v2.stage.mixins import SimpleCompletionStageMixin\n+from group_project_v2.stage_components import (\n+    GroupProjectTeamEvaluationDisplayXBlock, GroupProjectGradeEvaluationDisplayXBlock\n+)\n+from group_project_v2.utils import gettext as _, MUST_BE_OVERRIDDEN\n+\n+\n+log = logging.getLogger(__name__)\n+\n+\n+class FeedbackDisplayBaseStage(SimpleCompletionStageMixin, BaseGroupActivityStage):\n+    NAVIGATION_LABEL = _(u'Review')\n+    FEEDBACK_DISPLAY_BLOCK_CATEGORY = None\n+\n+    @property\n+    def feedback_display_blocks(self):\n+        return self.get_children_by_category(self.FEEDBACK_DISPLAY_BLOCK_CATEGORY)\n+\n+    @lazy\n+    def required_questions(self):\n+        return [\n+            feedback_display.question_id for feedback_display in self.feedback_display_blocks\n+            if feedback_display.question and feedback_display.question.required\n+        ]\n+\n+    def get_reviewer_ids(self):","path":"group_project_v2/stage/feedback_review.py","position":33,"original_position":33,"commit_id":"cc5ba0580139d7a33d0e05e9e2801aacdb615b9a","original_commit_id":"cc5ba0580139d7a33d0e05e9e2801aacdb615b9a","user":{"login":"Kelketek","id":1099483,"avatar_url":"https://avatars.githubusercontent.com/u/1099483?v=3","gravatar_id":"","url":"https://api.github.com/users/Kelketek","html_url":"https://github.com/Kelketek","followers_url":"https://api.github.com/users/Kelketek/followers","following_url":"https://api.github.com/users/Kelketek/following{/other_user}","gists_url":"https://api.github.com/users/Kelketek/gists{/gist_id}","starred_url":"https://api.github.com/users/Kelketek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kelketek/subscriptions","organizations_url":"https://api.github.com/users/Kelketek/orgs","repos_url":"https://api.github.com/users/Kelketek/repos","events_url":"https://api.github.com/users/Kelketek/events{/privacy}","received_events_url":"https://api.github.com/users/Kelketek/received_events","type":"User","site_admin":false},"body":"Same question here about abstract methods, but this is a moved class rather than new. Not sure if it would be better to update all examples like this or just continue on with existing convention.","created_at":"2015-11-13T19:59:26Z","updated_at":"2015-11-13T19:59:26Z","html_url":"https://github.com/open-craft/xblock-group-project-v2/pull/63#discussion_r44827160","pull_request_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/comments/44827160"},"html":{"href":"https://github.com/open-craft/xblock-group-project-v2/pull/63#discussion_r44827160"},"pull_request":{"href":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/63","id":50379861,"html_url":"https://github.com/open-craft/xblock-group-project-v2/pull/63","diff_url":"https://github.com/open-craft/xblock-group-project-v2/pull/63.diff","patch_url":"https://github.com/open-craft/xblock-group-project-v2/pull/63.patch","issue_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/issues/63","number":63,"state":"open","locked":false,"title":"Admin dashboard","user":{"login":"e-kolpakov","id":3330048,"avatar_url":"https://avatars.githubusercontent.com/u/3330048?v=3","gravatar_id":"","url":"https://api.github.com/users/e-kolpakov","html_url":"https://github.com/e-kolpakov","followers_url":"https://api.github.com/users/e-kolpakov/followers","following_url":"https://api.github.com/users/e-kolpakov/following{/other_user}","gists_url":"https://api.github.com/users/e-kolpakov/gists{/gist_id}","starred_url":"https://api.github.com/users/e-kolpakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-kolpakov/subscriptions","organizations_url":"https://api.github.com/users/e-kolpakov/orgs","repos_url":"https://api.github.com/users/e-kolpakov/repos","events_url":"https://api.github.com/users/e-kolpakov/events{/privacy}","received_events_url":"https://api.github.com/users/e-kolpakov/received_events","type":"User","site_admin":false},"body":"**Description:** This is a part of multi-PR changeset. Instructions and details are given on the [other PR](https://github.com/mckinseyacademy/mcka_apros/pull/1245)\r\n\r\n**Dependencies:**\r\n* https://github.com/edx-solutions/edx-platform/pull/568","created_at":"2015-11-11T12:49:06Z","updated_at":"2015-11-13T19:59:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a805c1bac94a9c0f741b4bd66fcfa1d4b32c3f3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/63/commits","review_comments_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/63/comments","review_comment_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/issues/63/comments","statuses_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/statuses/cc5ba0580139d7a33d0e05e9e2801aacdb615b9a","head":{"label":"open-craft:admin_dashboard","ref":"admin_dashboard","sha":"cc5ba0580139d7a33d0e05e9e2801aacdb615b9a","user":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":36354647,"name":"xblock-group-project-v2","full_name":"open-craft/xblock-group-project-v2","owner":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/xblock-group-project-v2","description":"Group Project XBlock v2","fork":false,"url":"https://api.github.com/repos/open-craft/xblock-group-project-v2","forks_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/forks","keys_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/teams","hooks_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/hooks","issue_events_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/events","assignees_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/tags","blobs_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/languages","stargazers_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/stargazers","contributors_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/contributors","subscribers_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/subscribers","subscription_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/subscription","commits_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/merges","archive_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/downloads","issues_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/releases{/id}","created_at":"2015-05-27T08:45:35Z","updated_at":"2015-10-05T11:45:34Z","pushed_at":"2015-11-13T11:42:12Z","git_url":"git://github.com/open-craft/xblock-group-project-v2.git","ssh_url":"git@github.com:open-craft/xblock-group-project-v2.git","clone_url":"https://github.com/open-craft/xblock-group-project-v2.git","svn_url":"https://github.com/open-craft/xblock-group-project-v2","homepage":null,"size":2816,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"open-craft:master","ref":"master","sha":"53bd6f45a27857764ce0e9cdad07413cca2cad1e","user":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":36354647,"name":"xblock-group-project-v2","full_name":"open-craft/xblock-group-project-v2","owner":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars.githubusercontent.com/u/7414786?v=3","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/xblock-group-project-v2","description":"Group Project XBlock v2","fork":false,"url":"https://api.github.com/repos/open-craft/xblock-group-project-v2","forks_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/forks","keys_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/teams","hooks_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/hooks","issue_events_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/events","assignees_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/tags","blobs_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/languages","stargazers_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/stargazers","contributors_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/contributors","subscribers_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/subscribers","subscription_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/subscription","commits_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/merges","archive_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/downloads","issues_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/xblock-group-project-v2/releases{/id}","created_at":"2015-05-27T08:45:35Z","updated_at":"2015-10-05T11:45:34Z","pushed_at":"2015-11-13T11:42:12Z","git_url":"git://github.com/open-craft/xblock-group-project-v2.git","ssh_url":"git@github.com:open-craft/xblock-group-project-v2.git","clone_url":"https://github.com/open-craft/xblock-group-project-v2.git","svn_url":"https://github.com/open-craft/xblock-group-project-v2","homepage":null,"size":2816,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/63"},"html":{"href":"https://github.com/open-craft/xblock-group-project-v2/pull/63"},"issue":{"href":"https://api.github.com/repos/open-craft/xblock-group-project-v2/issues/63"},"comments":{"href":"https://api.github.com/repos/open-craft/xblock-group-project-v2/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-craft/xblock-group-project-v2/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/open-craft/xblock-group-project-v2/statuses/cc5ba0580139d7a33d0e05e9e2801aacdb615b9a"}}}}