{"action":"closed","issue":{"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/28","labels_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/28/comments","events_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/28/events","html_url":"https://github.com/nom-tam-fits/nom-tam-fits/issues/28","id":85265845,"number":28,"title":"Problems with multidimensional strings","user":{"login":"TomMcGlynn","id":3277276,"avatar_url":"https://avatars.githubusercontent.com/u/3277276?v=3","gravatar_id":"","url":"https://api.github.com/users/TomMcGlynn","html_url":"https://github.com/TomMcGlynn","followers_url":"https://api.github.com/users/TomMcGlynn/followers","following_url":"https://api.github.com/users/TomMcGlynn/following{/other_user}","gists_url":"https://api.github.com/users/TomMcGlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/TomMcGlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomMcGlynn/subscriptions","organizations_url":"https://api.github.com/users/TomMcGlynn/orgs","repos_url":"https://api.github.com/users/TomMcGlynn/repos","events_url":"https://api.github.com/users/TomMcGlynn/events{/privacy}","received_events_url":"https://api.github.com/users/TomMcGlynn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"ritchieGitHub","id":9456779,"avatar_url":"https://avatars.githubusercontent.com/u/9456779?v=3","gravatar_id":"","url":"https://api.github.com/users/ritchieGitHub","html_url":"https://github.com/ritchieGitHub","followers_url":"https://api.github.com/users/ritchieGitHub/followers","following_url":"https://api.github.com/users/ritchieGitHub/following{/other_user}","gists_url":"https://api.github.com/users/ritchieGitHub/gists{/gist_id}","starred_url":"https://api.github.com/users/ritchieGitHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritchieGitHub/subscriptions","organizations_url":"https://api.github.com/users/ritchieGitHub/orgs","repos_url":"https://api.github.com/users/ritchieGitHub/repos","events_url":"https://api.github.com/users/ritchieGitHub/events{/privacy}","received_events_url":"https://api.github.com/users/ritchieGitHub/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/milestones/3","html_url":"https://github.com/nom-tam-fits/nom-tam-fits/milestones/1.13.0","labels_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/milestones/3/labels","id":1058034,"number":3,"title":"1.13.0","description":"comment handling, long strings and primitive refactorings","creator":{"login":"ritchieGitHub","id":9456779,"avatar_url":"https://avatars.githubusercontent.com/u/9456779?v=3","gravatar_id":"","url":"https://api.github.com/users/ritchieGitHub","html_url":"https://github.com/ritchieGitHub","followers_url":"https://api.github.com/users/ritchieGitHub/followers","following_url":"https://api.github.com/users/ritchieGitHub/following{/other_user}","gists_url":"https://api.github.com/users/ritchieGitHub/gists{/gist_id}","starred_url":"https://api.github.com/users/ritchieGitHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritchieGitHub/subscriptions","organizations_url":"https://api.github.com/users/ritchieGitHub/orgs","repos_url":"https://api.github.com/users/ritchieGitHub/repos","events_url":"https://api.github.com/users/ritchieGitHub/events{/privacy}","received_events_url":"https://api.github.com/users/ritchieGitHub/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":8,"state":"open","created_at":"2015-04-08T11:19:57Z","updated_at":"2015-06-05T04:32:14Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-06-04T20:35:45Z","updated_at":"2015-06-05T04:32:14Z","closed_at":"2015-06-05T04:32:14Z","body":"Looks like BinaryTable is not handling arrays of strings as elements properly.   Seems to have done so in the past. The problem seems to be that in changing some of the ArrayFuncs capabilities there was an assumption that flatten would reference only primitive arrays -- which is almost but not quite true.  We need to flatten String arrays also.  The initial problem is that there is a null exception when we look for the appropriate PrimitiveArrayCopierFactory in the FACTORIES hash, but I don't know if that's the extent of the issue.\r\n\r\nNot sure what the best approach is here.  Could just add in String/String in the FACTORIES hash, but in principle I think flatten should work for any kind of object, though it will only be used for Strings currently.  Maybe could have an Object/Object instance which throws an IllegalArgumentException if the input and output object types are different?  Or just let it run into a runtime cast exception then?\r\n\r\n"}}