{"action":"created","issue":{"url":"https://api.github.com/repos/collective/collective.workspace/issues/4","labels_url":"https://api.github.com/repos/collective/collective.workspace/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/collective/collective.workspace/issues/4/comments","events_url":"https://api.github.com/repos/collective/collective.workspace/issues/4/events","html_url":"https://github.com/collective/collective.workspace/pull/4","id":52757646,"number":4,"title":"Use normal Plone groups","user":{"login":"davisagli","id":49014,"avatar_url":"https://avatars.githubusercontent.com/u/49014?v=3","gravatar_id":"","url":"https://api.github.com/users/davisagli","html_url":"https://github.com/davisagli","followers_url":"https://api.github.com/users/davisagli/followers","following_url":"https://api.github.com/users/davisagli/following{/other_user}","gists_url":"https://api.github.com/users/davisagli/gists{/gist_id}","starred_url":"https://api.github.com/users/davisagli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisagli/subscriptions","organizations_url":"https://api.github.com/users/davisagli/orgs","repos_url":"https://api.github.com/users/davisagli/repos","events_url":"https://api.github.com/users/davisagli/events{/privacy}","received_events_url":"https://api.github.com/users/davisagli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2014-12-23T17:10:05Z","updated_at":"2015-01-19T15:01:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/collective/collective.workspace/pulls/4","html_url":"https://github.com/collective/collective.workspace/pull/4","diff_url":"https://github.com/collective/collective.workspace/pull/4.diff","patch_url":"https://github.com/collective/collective.workspace/pull/4.patch"},"body":"@adamcheasley @mattss Could you take a look at this fairly major change and let me know if it looks like it will cause problems for the Plone intranet project?\r\n\r\nThe gist of the change is that instead of workspace groups being looked up via a special PAS plugin that does catalog queries, workspace rosters now add people to normal Plone groups. This was motivated by performance (turns out looking up all the workspaces via the catalog can take a while if you have many workspaces, even if things are well cached; whereas with standard Plone groups it's just a single BTree lookup to find a user's groups).\r\n\r\nThere is an upgrade step to add the groups based on existing rosters.\r\n\r\nI've been using this in production on my project for a number of months and the kinks seem to be worked out, but can't hurt to have another review!"},"comment":{"url":"https://api.github.com/repos/collective/collective.workspace/issues/comments/70506678","html_url":"https://github.com/collective/collective.workspace/pull/4#issuecomment-70506678","issue_url":"https://api.github.com/repos/collective/collective.workspace/issues/4","id":70506678,"user":{"login":"mattss","id":1155400,"avatar_url":"https://avatars.githubusercontent.com/u/1155400?v=3","gravatar_id":"","url":"https://api.github.com/users/mattss","html_url":"https://github.com/mattss","followers_url":"https://api.github.com/users/mattss/followers","following_url":"https://api.github.com/users/mattss/following{/other_user}","gists_url":"https://api.github.com/users/mattss/gists{/gist_id}","starred_url":"https://api.github.com/users/mattss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattss/subscriptions","organizations_url":"https://api.github.com/users/mattss/orgs","repos_url":"https://api.github.com/users/mattss/repos","events_url":"https://api.github.com/users/mattss/events{/privacy}","received_events_url":"https://api.github.com/users/mattss/received_events","type":"User","site_admin":false},"created_at":"2015-01-19T15:01:09Z","updated_at":"2015-01-19T15:01:09Z","body":"Rather than patching, would it be possibly to have a specific custom PAS plugin for the workspace, but one which simply extended the standard plone groups plugin, adding the ability to customise the visibility of those groups?"}}