{"action":"created","comment":{"url":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/23056141","id":23056141,"diff_hunk":"@@ -60,11 +60,11 @@ def downcased_tag_name\n   end\n \n   def prep_tags_for_javascript\n-    @tags = @tags.map {|tag|\n-      { :name  => (\"#\" + tag.name) }\n-    }\n+    @tags = @tags.map do|tag|\n+      { name: ('#' + tag.name) }","path":"app/controllers/tags_controller.rb","position":63,"original_position":63,"commit_id":"2ee04b4d78bb5190b56be226d618ae58d950d491","original_commit_id":"2ee04b4d78bb5190b56be226d618ae58d950d491","user":{"login":"jhass","id":141294,"avatar_url":"https://avatars.githubusercontent.com/u/141294?v=3","gravatar_id":"","url":"https://api.github.com/users/jhass","html_url":"https://github.com/jhass","followers_url":"https://api.github.com/users/jhass/followers","following_url":"https://api.github.com/users/jhass/following{/other_user}","gists_url":"https://api.github.com/users/jhass/gists{/gist_id}","starred_url":"https://api.github.com/users/jhass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhass/subscriptions","organizations_url":"https://api.github.com/users/jhass/orgs","repos_url":"https://api.github.com/users/jhass/repos","events_url":"https://api.github.com/users/jhass/events{/privacy}","received_events_url":"https://api.github.com/users/jhass/received_events","type":"User","site_admin":false},"body":"String interpolation","created_at":"2015-01-16T00:37:30Z","updated_at":"2015-01-16T00:37:30Z","html_url":"https://github.com/diaspora/diaspora/pull/5561#discussion_r23056141","pull_request_url":"https://api.github.com/repos/diaspora/diaspora/pulls/5561","_links":{"self":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/23056141"},"html":{"href":"https://github.com/diaspora/diaspora/pull/5561#discussion_r23056141"},"pull_request":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5561"}}},"pull_request":{"url":"https://api.github.com/repos/diaspora/diaspora/pulls/5561","id":27473513,"html_url":"https://github.com/diaspora/diaspora/pull/5561","diff_url":"https://github.com/diaspora/diaspora/pull/5561.diff","patch_url":"https://github.com/diaspora/diaspora/pull/5561.patch","issue_url":"https://api.github.com/repos/diaspora/diaspora/issues/5561","number":5561,"state":"open","locked":false,"title":"Rubocop linter and styleguide","user":{"login":"dimaursu","id":1288910,"avatar_url":"https://avatars.githubusercontent.com/u/1288910?v=3","gravatar_id":"","url":"https://api.github.com/users/dimaursu","html_url":"https://github.com/dimaursu","followers_url":"https://api.github.com/users/dimaursu/followers","following_url":"https://api.github.com/users/dimaursu/following{/other_user}","gists_url":"https://api.github.com/users/dimaursu/gists{/gist_id}","starred_url":"https://api.github.com/users/dimaursu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimaursu/subscriptions","organizations_url":"https://api.github.com/users/dimaursu/orgs","repos_url":"https://api.github.com/users/dimaursu/repos","events_url":"https://api.github.com/users/dimaursu/events{/privacy}","received_events_url":"https://api.github.com/users/dimaursu/received_events","type":"User","site_admin":false},"body":"This should take care of #5531 .\r\nAlso, notice that there is a `.rubocop_todo.yml`, to shut rubocop mouth about existing warnings: there are about 4500 of them left (17k in the begining). You can also see the count in that file, per warning.\r\nEventually we should get rid of that file, but I'd say to take it slow, and do it gradually.\r\n\r\nThis is the workflow: you remove a `cop` from that file, run rubocop in the rood of `d*`, and fix the warnings, until it's all green again.\r\n\r\nThis should be an excellent training for someone who wants to learn more about ruby and the best practices. ","created_at":"2015-01-15T23:52:26Z","updated_at":"2015-01-16T00:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a905fbefc78e734a463c1c085c204fbe2290fb3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/diaspora/diaspora/pulls/5561/commits","review_comments_url":"https://api.github.com/repos/diaspora/diaspora/pulls/5561/comments","review_comment_url":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/{number}","comments_url":"https://api.github.com/repos/diaspora/diaspora/issues/5561/comments","statuses_url":"https://api.github.com/repos/diaspora/diaspora/statuses/2ee04b4d78bb5190b56be226d618ae58d950d491","head":{"label":"dimaursu:rubocop","ref":"rubocop","sha":"2ee04b4d78bb5190b56be226d618ae58d950d491","user":{"login":"dimaursu","id":1288910,"avatar_url":"https://avatars.githubusercontent.com/u/1288910?v=3","gravatar_id":"","url":"https://api.github.com/users/dimaursu","html_url":"https://github.com/dimaursu","followers_url":"https://api.github.com/users/dimaursu/followers","following_url":"https://api.github.com/users/dimaursu/following{/other_user}","gists_url":"https://api.github.com/users/dimaursu/gists{/gist_id}","starred_url":"https://api.github.com/users/dimaursu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimaursu/subscriptions","organizations_url":"https://api.github.com/users/dimaursu/orgs","repos_url":"https://api.github.com/users/dimaursu/repos","events_url":"https://api.github.com/users/dimaursu/events{/privacy}","received_events_url":"https://api.github.com/users/dimaursu/received_events","type":"User","site_admin":false},"repo":{"id":24935334,"name":"diaspora","full_name":"dimaursu/diaspora","owner":{"login":"dimaursu","id":1288910,"avatar_url":"https://avatars.githubusercontent.com/u/1288910?v=3","gravatar_id":"","url":"https://api.github.com/users/dimaursu","html_url":"https://github.com/dimaursu","followers_url":"https://api.github.com/users/dimaursu/followers","following_url":"https://api.github.com/users/dimaursu/following{/other_user}","gists_url":"https://api.github.com/users/dimaursu/gists{/gist_id}","starred_url":"https://api.github.com/users/dimaursu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimaursu/subscriptions","organizations_url":"https://api.github.com/users/dimaursu/orgs","repos_url":"https://api.github.com/users/dimaursu/repos","events_url":"https://api.github.com/users/dimaursu/events{/privacy}","received_events_url":"https://api.github.com/users/dimaursu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dimaursu/diaspora","description":"Distributed and contextual social networking","fork":true,"url":"https://api.github.com/repos/dimaursu/diaspora","forks_url":"https://api.github.com/repos/dimaursu/diaspora/forks","keys_url":"https://api.github.com/repos/dimaursu/diaspora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimaursu/diaspora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimaursu/diaspora/teams","hooks_url":"https://api.github.com/repos/dimaursu/diaspora/hooks","issue_events_url":"https://api.github.com/repos/dimaursu/diaspora/issues/events{/number}","events_url":"https://api.github.com/repos/dimaursu/diaspora/events","assignees_url":"https://api.github.com/repos/dimaursu/diaspora/assignees{/user}","branches_url":"https://api.github.com/repos/dimaursu/diaspora/branches{/branch}","tags_url":"https://api.github.com/repos/dimaursu/diaspora/tags","blobs_url":"https://api.github.com/repos/dimaursu/diaspora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimaursu/diaspora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimaursu/diaspora/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimaursu/diaspora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimaursu/diaspora/statuses/{sha}","languages_url":"https://api.github.com/repos/dimaursu/diaspora/languages","stargazers_url":"https://api.github.com/repos/dimaursu/diaspora/stargazers","contributors_url":"https://api.github.com/repos/dimaursu/diaspora/contributors","subscribers_url":"https://api.github.com/repos/dimaursu/diaspora/subscribers","subscription_url":"https://api.github.com/repos/dimaursu/diaspora/subscription","commits_url":"https://api.github.com/repos/dimaursu/diaspora/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimaursu/diaspora/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimaursu/diaspora/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimaursu/diaspora/issues/comments/{number}","contents_url":"https://api.github.com/repos/dimaursu/diaspora/contents/{+path}","compare_url":"https://api.github.com/repos/dimaursu/diaspora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimaursu/diaspora/merges","archive_url":"https://api.github.com/repos/dimaursu/diaspora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimaursu/diaspora/downloads","issues_url":"https://api.github.com/repos/dimaursu/diaspora/issues{/number}","pulls_url":"https://api.github.com/repos/dimaursu/diaspora/pulls{/number}","milestones_url":"https://api.github.com/repos/dimaursu/diaspora/milestones{/number}","notifications_url":"https://api.github.com/repos/dimaursu/diaspora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimaursu/diaspora/labels{/name}","releases_url":"https://api.github.com/repos/dimaursu/diaspora/releases{/id}","created_at":"2014-10-08T10:16:58Z","updated_at":"2014-12-24T02:17:42Z","pushed_at":"2015-01-15T23:43:50Z","git_url":"git://github.com/dimaursu/diaspora.git","ssh_url":"git@github.com:dimaursu/diaspora.git","clone_url":"https://github.com/dimaursu/diaspora.git","svn_url":"https://github.com/dimaursu/diaspora","homepage":"https://diasporafoundation.org/","size":112683,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diaspora:develop","ref":"develop","sha":"df0691cf9a8abc02653514648280bd340de1fe32","user":{"login":"diaspora","id":293207,"avatar_url":"https://avatars.githubusercontent.com/u/293207?v=3","gravatar_id":"","url":"https://api.github.com/users/diaspora","html_url":"https://github.com/diaspora","followers_url":"https://api.github.com/users/diaspora/followers","following_url":"https://api.github.com/users/diaspora/following{/other_user}","gists_url":"https://api.github.com/users/diaspora/gists{/gist_id}","starred_url":"https://api.github.com/users/diaspora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diaspora/subscriptions","organizations_url":"https://api.github.com/users/diaspora/orgs","repos_url":"https://api.github.com/users/diaspora/repos","events_url":"https://api.github.com/users/diaspora/events{/privacy}","received_events_url":"https://api.github.com/users/diaspora/received_events","type":"Organization","site_admin":false},"repo":{"id":911765,"name":"diaspora","full_name":"diaspora/diaspora","owner":{"login":"diaspora","id":293207,"avatar_url":"https://avatars.githubusercontent.com/u/293207?v=3","gravatar_id":"","url":"https://api.github.com/users/diaspora","html_url":"https://github.com/diaspora","followers_url":"https://api.github.com/users/diaspora/followers","following_url":"https://api.github.com/users/diaspora/following{/other_user}","gists_url":"https://api.github.com/users/diaspora/gists{/gist_id}","starred_url":"https://api.github.com/users/diaspora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diaspora/subscriptions","organizations_url":"https://api.github.com/users/diaspora/orgs","repos_url":"https://api.github.com/users/diaspora/repos","events_url":"https://api.github.com/users/diaspora/events{/privacy}","received_events_url":"https://api.github.com/users/diaspora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diaspora/diaspora","description":"Distributed and contextual social networking","fork":false,"url":"https://api.github.com/repos/diaspora/diaspora","forks_url":"https://api.github.com/repos/diaspora/diaspora/forks","keys_url":"https://api.github.com/repos/diaspora/diaspora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diaspora/diaspora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diaspora/diaspora/teams","hooks_url":"https://api.github.com/repos/diaspora/diaspora/hooks","issue_events_url":"https://api.github.com/repos/diaspora/diaspora/issues/events{/number}","events_url":"https://api.github.com/repos/diaspora/diaspora/events","assignees_url":"https://api.github.com/repos/diaspora/diaspora/assignees{/user}","branches_url":"https://api.github.com/repos/diaspora/diaspora/branches{/branch}","tags_url":"https://api.github.com/repos/diaspora/diaspora/tags","blobs_url":"https://api.github.com/repos/diaspora/diaspora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diaspora/diaspora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diaspora/diaspora/git/refs{/sha}","trees_url":"https://api.github.com/repos/diaspora/diaspora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diaspora/diaspora/statuses/{sha}","languages_url":"https://api.github.com/repos/diaspora/diaspora/languages","stargazers_url":"https://api.github.com/repos/diaspora/diaspora/stargazers","contributors_url":"https://api.github.com/repos/diaspora/diaspora/contributors","subscribers_url":"https://api.github.com/repos/diaspora/diaspora/subscribers","subscription_url":"https://api.github.com/repos/diaspora/diaspora/subscription","commits_url":"https://api.github.com/repos/diaspora/diaspora/commits{/sha}","git_commits_url":"https://api.github.com/repos/diaspora/diaspora/git/commits{/sha}","comments_url":"https://api.github.com/repos/diaspora/diaspora/comments{/number}","issue_comment_url":"https://api.github.com/repos/diaspora/diaspora/issues/comments/{number}","contents_url":"https://api.github.com/repos/diaspora/diaspora/contents/{+path}","compare_url":"https://api.github.com/repos/diaspora/diaspora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diaspora/diaspora/merges","archive_url":"https://api.github.com/repos/diaspora/diaspora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diaspora/diaspora/downloads","issues_url":"https://api.github.com/repos/diaspora/diaspora/issues{/number}","pulls_url":"https://api.github.com/repos/diaspora/diaspora/pulls{/number}","milestones_url":"https://api.github.com/repos/diaspora/diaspora/milestones{/number}","notifications_url":"https://api.github.com/repos/diaspora/diaspora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diaspora/diaspora/labels{/name}","releases_url":"https://api.github.com/repos/diaspora/diaspora/releases{/id}","created_at":"2010-09-15T05:20:04Z","updated_at":"2015-01-16T00:14:08Z","pushed_at":"2015-01-15T16:23:13Z","git_url":"git://github.com/diaspora/diaspora.git","ssh_url":"git@github.com:diaspora/diaspora.git","clone_url":"https://github.com/diaspora/diaspora.git","svn_url":"https://github.com/diaspora/diaspora","homepage":"https://diasporafoundation.org/","size":247135,"stargazers_count":9726,"watchers_count":9726,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2480,"mirror_url":null,"open_issues_count":439,"forks":2480,"open_issues":439,"watchers":9726,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5561"},"html":{"href":"https://github.com/diaspora/diaspora/pull/5561"},"issue":{"href":"https://api.github.com/repos/diaspora/diaspora/issues/5561"},"comments":{"href":"https://api.github.com/repos/diaspora/diaspora/issues/5561/comments"},"review_comments":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5561/comments"},"review_comment":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/diaspora/diaspora/pulls/5561/commits"},"statuses":{"href":"https://api.github.com/repos/diaspora/diaspora/statuses/2ee04b4d78bb5190b56be226d618ae58d950d491"}}}}