{"action":"closed","number":11312,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/11312","id":35587681,"html_url":"https://github.com/JuliaLang/julia/pull/11312","diff_url":"https://github.com/JuliaLang/julia/pull/11312.diff","patch_url":"https://github.com/JuliaLang/julia/pull/11312.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/11312","number":11312,"state":"closed","locked":false,"title":"WIP: Rewrite git://github.com to https://github.com in package URLs.","user":{"login":"LachlanGunn","id":427759,"avatar_url":"https://avatars.githubusercontent.com/u/427759?v=3","gravatar_id":"","url":"https://api.github.com/users/LachlanGunn","html_url":"https://github.com/LachlanGunn","followers_url":"https://api.github.com/users/LachlanGunn/followers","following_url":"https://api.github.com/users/LachlanGunn/following{/other_user}","gists_url":"https://api.github.com/users/LachlanGunn/gists{/gist_id}","starred_url":"https://api.github.com/users/LachlanGunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LachlanGunn/subscriptions","organizations_url":"https://api.github.com/users/LachlanGunn/orgs","repos_url":"https://api.github.com/users/LachlanGunn/repos","events_url":"https://api.github.com/users/LachlanGunn/events{/privacy}","received_events_url":"https://api.github.com/users/LachlanGunn/received_events","type":"User","site_admin":false},"body":"Introduction\r\n---------------\r\nAs git:// URLs cannot be loaded behind proxies, the current package manager is broken for many institutional users without manual configuration of Git using the \"git://\".insteadOf workaround.  This is a major usability problem, and leaves a bad first impression for new users who are used to the polished installer of Matlab.\r\n\r\nAs discussed in #7005, the git:// protocol also provides no security against man-in-the-middle attacks, to which the current system is vulnerable due to the lack of digital signatures in the process.\r\n\r\nThe Pkg package has therefore been made to automatically change all git://github.com URLs to https://github.com.  URLs pointing to other domains will be unaffected.  If a complete change from git:// to https:// is made, then it is anticipated that existing URLs in METADATA.jl will be changed from git:// to https://.  This may render the URL normalisation part of these changes unnecessary, however it would still be necessary to change the METADATA.jl URL to use HTTPS.\r\n\r\nChanges\r\n-----------\r\n\r\n1. The JuliaLang/METADATA.jl repository URL has been changed from git:// to https:// .\r\n2. Generated URLS have all been changed from git:// to https://\r\n3. The existing URL normalisation code in base/pkg/git.jl has been modified so that it normalises to https:// rather than git://\r\n4. All URLs are now normalised before being passed to \"git clone\" or Git.set_remote_url.\r\n\r\nTogether, these changes allow packages to be installed without access to the git:// port.\r\n\r\nTest procedure\r\n--------------------\r\n\r\n1. Compile Julia in Vagrant-setup virtual machine\r\n2. Run 'sudo iptables -I OUTPUT -p tcp --dport 9418 -j REJECT'\r\n3. Ensure that port is blocked by running 'git clone git://github.com/JuliaLang/Example.jl'.\r\n4. Run 'jlmake test-pkg'","created_at":"2015-05-17T14:14:01Z","updated_at":"2015-10-16T14:12:35Z","closed_at":"2015-10-16T14:12:35Z","merged_at":null,"merge_commit_sha":"13465d80f933c132e1d03be3ff6fdae48088f0b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/11312/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/11312/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/11312/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/706600408aba8b142c47c2bc887bde0d9bf774cf","head":{"label":"LachlanGunn:master","ref":"master","sha":"706600408aba8b142c47c2bc887bde0d9bf774cf","user":{"login":"LachlanGunn","id":427759,"avatar_url":"https://avatars.githubusercontent.com/u/427759?v=3","gravatar_id":"","url":"https://api.github.com/users/LachlanGunn","html_url":"https://github.com/LachlanGunn","followers_url":"https://api.github.com/users/LachlanGunn/followers","following_url":"https://api.github.com/users/LachlanGunn/following{/other_user}","gists_url":"https://api.github.com/users/LachlanGunn/gists{/gist_id}","starred_url":"https://api.github.com/users/LachlanGunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LachlanGunn/subscriptions","organizations_url":"https://api.github.com/users/LachlanGunn/orgs","repos_url":"https://api.github.com/users/LachlanGunn/repos","events_url":"https://api.github.com/users/LachlanGunn/events{/privacy}","received_events_url":"https://api.github.com/users/LachlanGunn/received_events","type":"User","site_admin":false},"repo":{"id":35706758,"name":"julia","full_name":"LachlanGunn/julia","owner":{"login":"LachlanGunn","id":427759,"avatar_url":"https://avatars.githubusercontent.com/u/427759?v=3","gravatar_id":"","url":"https://api.github.com/users/LachlanGunn","html_url":"https://github.com/LachlanGunn","followers_url":"https://api.github.com/users/LachlanGunn/followers","following_url":"https://api.github.com/users/LachlanGunn/following{/other_user}","gists_url":"https://api.github.com/users/LachlanGunn/gists{/gist_id}","starred_url":"https://api.github.com/users/LachlanGunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LachlanGunn/subscriptions","organizations_url":"https://api.github.com/users/LachlanGunn/orgs","repos_url":"https://api.github.com/users/LachlanGunn/repos","events_url":"https://api.github.com/users/LachlanGunn/events{/privacy}","received_events_url":"https://api.github.com/users/LachlanGunn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LachlanGunn/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/LachlanGunn/julia","forks_url":"https://api.github.com/repos/LachlanGunn/julia/forks","keys_url":"https://api.github.com/repos/LachlanGunn/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LachlanGunn/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LachlanGunn/julia/teams","hooks_url":"https://api.github.com/repos/LachlanGunn/julia/hooks","issue_events_url":"https://api.github.com/repos/LachlanGunn/julia/issues/events{/number}","events_url":"https://api.github.com/repos/LachlanGunn/julia/events","assignees_url":"https://api.github.com/repos/LachlanGunn/julia/assignees{/user}","branches_url":"https://api.github.com/repos/LachlanGunn/julia/branches{/branch}","tags_url":"https://api.github.com/repos/LachlanGunn/julia/tags","blobs_url":"https://api.github.com/repos/LachlanGunn/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LachlanGunn/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LachlanGunn/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/LachlanGunn/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LachlanGunn/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/LachlanGunn/julia/languages","stargazers_url":"https://api.github.com/repos/LachlanGunn/julia/stargazers","contributors_url":"https://api.github.com/repos/LachlanGunn/julia/contributors","subscribers_url":"https://api.github.com/repos/LachlanGunn/julia/subscribers","subscription_url":"https://api.github.com/repos/LachlanGunn/julia/subscription","commits_url":"https://api.github.com/repos/LachlanGunn/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/LachlanGunn/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/LachlanGunn/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/LachlanGunn/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/LachlanGunn/julia/contents/{+path}","compare_url":"https://api.github.com/repos/LachlanGunn/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LachlanGunn/julia/merges","archive_url":"https://api.github.com/repos/LachlanGunn/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LachlanGunn/julia/downloads","issues_url":"https://api.github.com/repos/LachlanGunn/julia/issues{/number}","pulls_url":"https://api.github.com/repos/LachlanGunn/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/LachlanGunn/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/LachlanGunn/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LachlanGunn/julia/labels{/name}","releases_url":"https://api.github.com/repos/LachlanGunn/julia/releases{/id}","created_at":"2015-05-16T02:34:27Z","updated_at":"2015-05-16T02:34:32Z","pushed_at":"2015-10-16T14:12:35Z","git_url":"git://github.com/LachlanGunn/julia.git","ssh_url":"git@github.com:LachlanGunn/julia.git","clone_url":"https://github.com/LachlanGunn/julia.git","svn_url":"https://github.com/LachlanGunn/julia","homepage":"http://julialang.org/","size":71444,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"706600408aba8b142c47c2bc887bde0d9bf774cf","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-10-16T10:54:18Z","pushed_at":"2015-10-16T14:09:25Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":234821,"stargazers_count":6147,"watchers_count":6147,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1349,"mirror_url":null,"open_issues_count":1467,"forks":1349,"open_issues":1467,"watchers":6147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/11312"},"html":{"href":"https://github.com/JuliaLang/julia/pull/11312"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/11312"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/11312/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/11312/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/11312/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/706600408aba8b142c47c2bc887bde0d9bf774cf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":15,"review_comments":3,"commits":0,"additions":0,"deletions":0,"changed_files":0}}