{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/31392233","id":31392233,"diff_hunk":"@@ -111,10 +111,10 @@ public override bool HandleMouseInput(MouseInput mi)\n \n \t\t\t\t\t\tif (unit != null && unit.Owner == (World.RenderPlayer ?? World.LocalPlayer))\n \t\t\t\t\t\t{\n-\t\t\t\t\t\t\tvar newSelection2 = SelectActorsInBox(World, worldRenderer.Viewport.TopLeft, worldRenderer.Viewport.BottomRight,\n-\t\t\t\t\t\t\t\ta => a.Owner == unit.Owner && a.Info.Name == unit.Info.Name);\n+\t\t\t\t\t\t\tvar newSelection = SelectActorsInBox(World, worldRenderer.Viewport.TopLeft, worldRenderer.Viewport.BottomRight,\n+\t\t\t\t\t\t\t\ta => a.Owner == unit.Owner && a.Trait<Selectable>().Class == unit.Trait<Selectable>().Class);","path":"OpenRA.Game/Widgets/WorldInteractionControllerWidget.cs","position":7,"original_position":7,"commit_id":"25df78ec5214640451f1d74b6e73d399bb83c20c","original_commit_id":"25df78ec5214640451f1d74b6e73d399bb83c20c","user":{"login":"penev92","id":7137365,"avatar_url":"https://avatars.githubusercontent.com/u/7137365?v=3","gravatar_id":"","url":"https://api.github.com/users/penev92","html_url":"https://github.com/penev92","followers_url":"https://api.github.com/users/penev92/followers","following_url":"https://api.github.com/users/penev92/following{/other_user}","gists_url":"https://api.github.com/users/penev92/gists{/gist_id}","starred_url":"https://api.github.com/users/penev92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penev92/subscriptions","organizations_url":"https://api.github.com/users/penev92/orgs","repos_url":"https://api.github.com/users/penev92/repos","events_url":"https://api.github.com/users/penev92/events{/privacy}","received_events_url":"https://api.github.com/users/penev92/received_events","type":"User","site_admin":false},"body":"Repeated trait lookups is not the best thing to do, so add a `var class = unit.Trait<Selectable>().Class;` above and check against that here.","created_at":"2015-05-31T17:06:16Z","updated_at":"2015-05-31T17:06:16Z","html_url":"https://github.com/OpenRA/OpenRA/pull/8212#discussion_r31392233","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8212","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/31392233"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/8212#discussion_r31392233"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8212"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8212","id":35979315,"html_url":"https://github.com/OpenRA/OpenRA/pull/8212","diff_url":"https://github.com/OpenRA/OpenRA/pull/8212.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/8212.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/8212","number":8212,"state":"open","locked":false,"title":"Added selection classes","user":{"login":"matija-hustic","id":5747153,"avatar_url":"https://avatars.githubusercontent.com/u/5747153?v=3","gravatar_id":"","url":"https://api.github.com/users/matija-hustic","html_url":"https://github.com/matija-hustic","followers_url":"https://api.github.com/users/matija-hustic/followers","following_url":"https://api.github.com/users/matija-hustic/following{/other_user}","gists_url":"https://api.github.com/users/matija-hustic/gists{/gist_id}","starred_url":"https://api.github.com/users/matija-hustic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matija-hustic/subscriptions","organizations_url":"https://api.github.com/users/matija-hustic/orgs","repos_url":"https://api.github.com/users/matija-hustic/repos","events_url":"https://api.github.com/users/matija-hustic/events{/privacy}","received_events_url":"https://api.github.com/users/matija-hustic/received_events","type":"User","site_admin":false},"body":"Option 3 from #7469 that would support the type of functionality proposed by @MustaphaTR:\r\n\r\nhttp://ares-developers.github.io/Ares-docs/new/typeselect.html\r\n\r\nBasically whenever the standard select-by-type functionality is supposed to be extended to select any custom class of selectable actors, these custom classes can be defined using the Class property of the Selectable trait.\r\n\r\nIf the basic idea is fine, I'd define any remaining selection classes in the YAMLs.","created_at":"2015-05-21T21:25:17Z","updated_at":"2015-05-31T17:06:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9ffecf70ab2c180e296d957386398a67e769130","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8212/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8212/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/8212/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/25df78ec5214640451f1d74b6e73d399bb83c20c","head":{"label":"matija-hustic:selectable_classes","ref":"selectable_classes","sha":"25df78ec5214640451f1d74b6e73d399bb83c20c","user":{"login":"matija-hustic","id":5747153,"avatar_url":"https://avatars.githubusercontent.com/u/5747153?v=3","gravatar_id":"","url":"https://api.github.com/users/matija-hustic","html_url":"https://github.com/matija-hustic","followers_url":"https://api.github.com/users/matija-hustic/followers","following_url":"https://api.github.com/users/matija-hustic/following{/other_user}","gists_url":"https://api.github.com/users/matija-hustic/gists{/gist_id}","starred_url":"https://api.github.com/users/matija-hustic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matija-hustic/subscriptions","organizations_url":"https://api.github.com/users/matija-hustic/orgs","repos_url":"https://api.github.com/users/matija-hustic/repos","events_url":"https://api.github.com/users/matija-hustic/events{/privacy}","received_events_url":"https://api.github.com/users/matija-hustic/received_events","type":"User","site_admin":false},"repo":{"id":19147701,"name":"OpenRA","full_name":"matija-hustic/OpenRA","owner":{"login":"matija-hustic","id":5747153,"avatar_url":"https://avatars.githubusercontent.com/u/5747153?v=3","gravatar_id":"","url":"https://api.github.com/users/matija-hustic","html_url":"https://github.com/matija-hustic","followers_url":"https://api.github.com/users/matija-hustic/followers","following_url":"https://api.github.com/users/matija-hustic/following{/other_user}","gists_url":"https://api.github.com/users/matija-hustic/gists{/gist_id}","starred_url":"https://api.github.com/users/matija-hustic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matija-hustic/subscriptions","organizations_url":"https://api.github.com/users/matija-hustic/orgs","repos_url":"https://api.github.com/users/matija-hustic/repos","events_url":"https://api.github.com/users/matija-hustic/events{/privacy}","received_events_url":"https://api.github.com/users/matija-hustic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matija-hustic/OpenRA","description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":true,"url":"https://api.github.com/repos/matija-hustic/OpenRA","forks_url":"https://api.github.com/repos/matija-hustic/OpenRA/forks","keys_url":"https://api.github.com/repos/matija-hustic/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matija-hustic/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matija-hustic/OpenRA/teams","hooks_url":"https://api.github.com/repos/matija-hustic/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/matija-hustic/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/matija-hustic/OpenRA/events","assignees_url":"https://api.github.com/repos/matija-hustic/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/matija-hustic/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/matija-hustic/OpenRA/tags","blobs_url":"https://api.github.com/repos/matija-hustic/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matija-hustic/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matija-hustic/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/matija-hustic/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matija-hustic/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/matija-hustic/OpenRA/languages","stargazers_url":"https://api.github.com/repos/matija-hustic/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/matija-hustic/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/matija-hustic/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/matija-hustic/OpenRA/subscription","commits_url":"https://api.github.com/repos/matija-hustic/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/matija-hustic/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/matija-hustic/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/matija-hustic/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/matija-hustic/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/matija-hustic/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matija-hustic/OpenRA/merges","archive_url":"https://api.github.com/repos/matija-hustic/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matija-hustic/OpenRA/downloads","issues_url":"https://api.github.com/repos/matija-hustic/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/matija-hustic/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/matija-hustic/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/matija-hustic/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matija-hustic/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/matija-hustic/OpenRA/releases{/id}","created_at":"2014-04-25T13:51:56Z","updated_at":"2015-04-28T22:34:07Z","pushed_at":"2015-05-31T16:06:19Z","git_url":"git://github.com/matija-hustic/OpenRA.git","ssh_url":"git@github.com:matija-hustic/OpenRA.git","clone_url":"https://github.com/matija-hustic/OpenRA.git","svn_url":"https://github.com/matija-hustic/OpenRA","homepage":"http://open-ra.org","size":88273,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"f88c1fd5692d08f481487e755feaf74e2aaed193","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-05-31T06:42:59Z","pushed_at":"2015-05-31T17:02:33Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":180101,"stargazers_count":1931,"watchers_count":1931,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":697,"mirror_url":null,"open_issues_count":780,"forks":697,"open_issues":780,"watchers":1931,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8212"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/8212"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/8212"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/8212/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8212/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/8212/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/25df78ec5214640451f1d74b6e73d399bb83c20c"}}}}