{"push_id":806773179,"size":41,"distinct_size":41,"ref":"refs/heads/master","head":"b4b98dadef6e8682d5b9efef7ab6b724847309e0","before":"8ceb827cc0b3414d68772e99e24b2bfbeb347525","commits":[{"sha":"e020e10ffa038b54c80cb8617c10dc65a2ca62f4","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Add a method to query whether an AASTNode is a descendent of another node\n\nSummary: Ref T8674. This implementation is not really very efficient, but I'll try to iterate on that.\n\nTest Plan: See next diff.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: Korvin\n\nManiphest Tasks: T8674\n\nDifferential Revision: https://secure.phabricator.com/D13819","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/e020e10ffa038b54c80cb8617c10dc65a2ca62f4"},{"sha":"f26954065e59db877e256581f3c17e7e103cef1f","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Use the configuration driven unit test engine\n\nSummary: Ref T5568. Use the very-new, very-beta `ArcanistConfigurationDrivenUnitTestEngine` unit test engine.\n\nTest Plan: `arc unit`\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nManiphest Tasks: T5568\n\nDifferential Revision: https://secure.phabricator.com/D13851","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/f26954065e59db877e256581f3c17e7e103cef1f"},{"sha":"d052c489a283609c7ed9e4d011f4b93337b45c92","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Include parentheses in n_ARRAY_VALUE_LIST node\n\nSummary: Currently parsing `array(1, 2, 3)` results in a `n_ARRAY_VALUE_LIST` with a concrete string of `1, 2, 3`. Compare this to `list($x, $y)` which results in a `n_ASSIGNMENT_LIST` with a concrete string of `($x, $y)`.\n\nTest Plan: See next diff.\n\nReviewers: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13858","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/d052c489a283609c7ed9e4d011f4b93337b45c92"},{"sha":"6c0118085afdc6c6802849cac363efbc76def972","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Various linter fixes\n\nSummary: Self explanatory.\n\nTest Plan: `arc lint`\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13862","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/6c0118085afdc6c6802849cac363efbc76def972"},{"sha":"c76b692447afe6574a1689491aaf99be0a46b650","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Micro-optimization for linting performance\n\nSummary: This is a micro-optimization to improve the performance of the XHPAST linter.\n\nTest Plan: Ran `arc lint --everything --never-apply-patches --xprofile=profile.json` in rP. Compared the XHProf profile [[https://secure.phabricator.com/xhprof/profile/PHID-FILE-qxksskgu3plnmu5swnki/?symbol=assert_instances_of | before]] and [[https://secure.phabricator.com/xhprof/profile/PHID-FILE-wvx7mf6sxqeti3ajbrle/?symbol=assert_instances_of | after]].\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13876","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/c76b692447afe6574a1689491aaf99be0a46b650"},{"sha":"e509fc30ae782af97f3535b1febbf50d0f919d5a","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Allow PhutilClassMapQuery to load implementors of an interface\n\nSummary: Fixes T9179. The old way worked for interfaces, but the new way didn't; it should.\n\nTest Plan: No more fatal on `/flag/`.\n\nReviewers: chad, joshuaspence\n\nReviewed By: joshuaspence\n\nManiphest Tasks: T9179\n\nDifferential Revision: https://secure.phabricator.com/D13898","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/e509fc30ae782af97f3535b1febbf50d0f919d5a"},{"sha":"d266f8554c45dd670a16245a401da283bd6b3499","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"(stable) Promote 2015 Week 33","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/d266f8554c45dd670a16245a401da283bd6b3499"},{"sha":"e276f31b7117d97b8e0e9d948b49085ce75a8f91","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Use semantic versioning for XHPAST\n\nSummary: Currently XHPAST is versioned as `x.y.z/w` which seems a little odd. Instead, use `x.y.z` as the version number to make it possible to use `version_compare`.\n\nTest Plan: N/A\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13960","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/e276f31b7117d97b8e0e9d948b49085ce75a8f91"},{"sha":"c9bc0fc54ce804ed92a17fef13429d304025361d","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"(stable) Promote 2015 Week 34","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/c9bc0fc54ce804ed92a17fef13429d304025361d"},{"sha":"76966a6f6b3e9d2028f5db29f69a45cb06b9d1db","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Remove flex and bison debug flags\n\nSummary: Remove `--debug` from `flex` and `bison` unless compiling with `DEBUG` defined.\n\nTest Plan: Ran `arc lint --everything --never-apply-patches --xprofile=profile.json` in rP. Compared [[https://secure.phabricator.com/xhprof/profile/PHID-FILE-k4qrjifhmfxkuaef5e7s/?symbol=Future::waitForSockets | before]] and [[https://secure.phabricator.com/xhprof/profile/PHID-FILE-m74verekyuu6eys6s7ad/?symbol=Future::waitForSockets | after]].\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: Korvin, epriestley\n\nDifferential Revision: https://secure.phabricator.com/D13969","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/76966a6f6b3e9d2028f5db29f69a45cb06b9d1db"},{"sha":"3cdc554b99cf7d2368353caa1dd8039c4e96e571","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@freelancer.com","name":"Joshua Spence"},"message":"Enable bison warnings\n\nSummary: Pass the `-Wall` flag to `bison` to show warnings.\n\nTest Plan: Ran `make -C support/xhpast parser` and saw warnings.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13970","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/3cdc554b99cf7d2368353caa1dd8039c4e96e571"},{"sha":"e456246d5446b67b466c523a2f6a7416f7b98982","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Fix bison \"empty\" warnings\n\nSummary: See https://www.gnu.org/software/bison/manual/html_node/Empty-Rules.html. Depends on D13970.\n\nTest Plan: Less warnings.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13971","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/e456246d5446b67b466c523a2f6a7416f7b98982"},{"sha":"7e6455c6912e14c07281c9c07dd934cca24499d7","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Fix a bison deprecation warning\n\nSummary:\nCurrently, running `make parser` produces the following warning:\n\n```\nparser.y:72.1-14: warning: deprecated directive, use ‘%name-prefix’ [-Wdeprecated]\n %name-prefix = \"xhpast\"\n  ^^^^^^^^^^^^^^\n```\n\nTest Plan: One less warning.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13972","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/7e6455c6912e14c07281c9c07dd934cca24499d7"},{"sha":"04f31e16d0b5aec080621ff57bf7da353389e622","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Remove some unused fields from yy_extra_type\n\nSummary: These fields are no longer used after D1319. Removed them should save some precious bytes.\n\nTest Plan: Ran `arc unit -- src/parser/xhpast/__tests__/PHPASTParserTestCase.php`.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13973","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/04f31e16d0b5aec080621ff57bf7da353389e622"},{"sha":"ff51f8d44312d680279d3eb4cdbb6bc0c1465f89","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Remove include_debug from yy_extra_type\n\nSummary: This field doesn't seem to be used.\n\nTest Plan: `grep`\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13975","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/ff51f8d44312d680279d3eb4cdbb6bc0c1465f89"},{"sha":"ff71c34f3e8f8212490b13ddf4ea3091933b0f48","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@freelancer.com","name":"Joshua Spence"},"message":"Remove unused replacestr function from XHPAST\n\nSummary: This method is unused after D1319.\n\nTest Plan: `grep`\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13976","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/ff71c34f3e8f8212490b13ddf4ea3091933b0f48"},{"sha":"2a099c8296ff73eb56f12179fb0133d575a27497","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@freelancer.com","name":"Joshua Spence"},"message":"Update generated parser files\n\nI forgot to run `make parser scanner` after D13976.\n\nAuditors: epriestley","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/2a099c8296ff73eb56f12179fb0133d575a27497"},{"sha":"c5e78941746d938f5504b047c7629cecebcf531d","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@freelancer.com","name":"Joshua Spence"},"message":"Remove unused last_token macro\n\nSummary: This macro is unused after D1319.\n\nTest Plan: `grep`\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13986","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/c5e78941746d938f5504b047c7629cecebcf531d"},{"sha":"6e8db556dbb92dd97c16a52a501d934060b2080a","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@freelancer.com","name":"Joshua Spence"},"message":"Make XHPAST scanner non-interactive\n\nSummary: Make the XHPAST scanner batch instead of interactive. To be honest I don't quite understand the difference, but it seems to perform better.\n\nTest Plan: Ran `arc lint --everything --never-apply-patches --xprofile=profile.json` in rP. Compared [[https://secure.phabricator.com/xhprof/profile/PHID-FILE-htvkzitiyv3og7zcxpp4/ | before]] and [[https://secure.phabricator.com/xhprof/profile/PHID-FILE-ltrxuaqahtrizbybcj5n/ | after]].\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13979","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/6e8db556dbb92dd97c16a52a501d934060b2080a"},{"sha":"d9ce77915302146571d335117c053a8ecb9beff4","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@freelancer.com","name":"Joshua Spence"},"message":"Remove some unused includes\n\nSummary: Remove some unused `#include`s from XHPAST.\n\nTest Plan: Compiled successfully.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13996","distinct":true,"url":"https://api.github.com/repos/aik099/libphutil/commits/d9ce77915302146571d335117c053a8ecb9beff4"}]}