{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/5529","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/5529/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/5529/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/5529/events","html_url":"https://github.com/NixOS/nixpkgs/pull/5529","id":53254262,"number":5529,"title":"Add: XAPI (or Xenserver or XCP) + dependencies","user":{"login":"ts468","id":6641027,"avatar_url":"https://avatars.githubusercontent.com/u/6641027?v=3","gravatar_id":"","url":"https://api.github.com/users/ts468","html_url":"https://github.com/ts468","followers_url":"https://api.github.com/users/ts468/followers","following_url":"https://api.github.com/users/ts468/following{/other_user}","gists_url":"https://api.github.com/users/ts468/gists{/gist_id}","starred_url":"https://api.github.com/users/ts468/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ts468/subscriptions","organizations_url":"https://api.github.com/users/ts468/orgs","repos_url":"https://api.github.com/users/ts468/repos","events_url":"https://api.github.com/users/ts468/events{/privacy}","received_events_url":"https://api.github.com/users/ts468/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/new-package","name":"new-package","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-01-02T14:10:07Z","updated_at":"2015-03-14T18:03:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/5529","html_url":"https://github.com/NixOS/nixpkgs/pull/5529","diff_url":"https://github.com/NixOS/nixpkgs/pull/5529.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/5529.patch"},"body":"That PR brings in XAPI, or Xenserver or XCP if you want to call it like that.\r\nXAPI is build out of a lot of individual packages and ocaml dependencies, and the PR contains all of them.\r\n\r\nThe PR should be safe to merge as it only upgrades three ocaml packages and adds a ton of new packages.\r\nEvery package built at least once on my local machine.\r\n\r\nXAPI is not expected to be usable yet. The packages might have to be adapted or fixed when the nixos modules are written.\r\n\r\nI would appreciate an early merge to allow more people to start playing with the XAPI tools. I also intend to invite the people behind XAPI/Xenserver to have a look at the NixOS integration once the raw packages have been merged."},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/80645917","html_url":"https://github.com/NixOS/nixpkgs/pull/5529#issuecomment-80645917","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/5529","id":80645917,"user":{"login":"falsifian","id":225893,"avatar_url":"https://avatars.githubusercontent.com/u/225893?v=3","gravatar_id":"","url":"https://api.github.com/users/falsifian","html_url":"https://github.com/falsifian","followers_url":"https://api.github.com/users/falsifian/followers","following_url":"https://api.github.com/users/falsifian/following{/other_user}","gists_url":"https://api.github.com/users/falsifian/gists{/gist_id}","starred_url":"https://api.github.com/users/falsifian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falsifian/subscriptions","organizations_url":"https://api.github.com/users/falsifian/orgs","repos_url":"https://api.github.com/users/falsifian/repos","events_url":"https://api.github.com/users/falsifian/events{/privacy}","received_events_url":"https://api.github.com/users/falsifian/received_events","type":"User","site_admin":false},"created_at":"2015-03-14T18:03:06Z","updated_at":"2015-03-14T18:03:06Z","body":"Consistent naming in nixpkgs would be nice. Probably a topic for the mailing list.\r\n\r\nSorry for the slow review process. I agree with @vbgl that it would be easier to review in smaller pieces. It doesn't have to be 100 different PRs... e.g. it's probably fine to stick all the new OCaml modules in one PR, if they're all similar to each other. To be honest I haven't yet taken the time to learn how many different kinds of thing this PR does (partly due to laziness) which would be the first step for me to really review this. I think a PR that just does one kind of thing (add new OCaml modules, even if it's 30 of them at once) would be easier to review.\r\n\r\nFixing little things after merging is probably fine, but I haven't found the time to read the PR yet except for little pieces :-("}}