{"action":"created","issue":{"url":"https://api.github.com/repos/svaarala/duktape/issues/347","labels_url":"https://api.github.com/repos/svaarala/duktape/issues/347/labels{/name}","comments_url":"https://api.github.com/repos/svaarala/duktape/issues/347/comments","events_url":"https://api.github.com/repos/svaarala/duktape/issues/347/events","html_url":"https://github.com/svaarala/duktape/pull/347","id":106395722,"number":347,"title":"Debugger throw notify cleanups","user":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/svaarala/duktape/labels/debugger","name":"debugger","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/svaarala/duktape/milestones/13","html_url":"https://github.com/svaarala/duktape/milestones/v1.4.0","labels_url":"https://api.github.com/repos/svaarala/duktape/milestones/13/labels","id":1225990,"number":13,"title":"v1.4.0","description":"Call handling, Emscripten performance","creator":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":9,"state":"open","created_at":"2015-07-26T04:06:08Z","updated_at":"2015-09-16T19:34:45Z","due_on":null,"closed_at":null},"comments":26,"created_at":"2015-09-14T17:58:29Z","updated_at":"2015-09-16T21:09:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/svaarala/duktape/pulls/347","html_url":"https://github.com/svaarala/duktape/pull/347","diff_url":"https://github.com/svaarala/duktape/pull/347.diff","patch_url":"https://github.com/svaarala/duktape/pull/347.patch"},"body":"Cleanups and additions to #286:\r\n\r\n- [x] Add support for Throw notify to debugger web UI\r\n- [x] Minor fixes to compilation warnings -> separate small pull #351, to make master clean\r\n- [x] Add missing `DUK_USE_DEBUGGER_SUPPORT` guards where missing\r\n- [x] DUK_USE_xxx flags for supporting Throw notify, and for default automatic pause-on-uncaught-throw behavior (alternatively, add control flags to debug protocol)\r\n- [x] Test caught and uncaught throw from lightfunc\r\n- [x] Change lightfunc handling to so that lightfunc `.name` is reported in Throw => This might not actually make sense: .fileName is used to locate sources in the web UI (and other debug clients) and lightfunc virtual name is not very useful for that. Callstack shows lightfunc virtual name anyway.\r\n- [x] Fix paused-in-lightfunc assertion failure\r\n- [x] Change DEBUGGER opcode to use `duk_debug_halt_execution()` to fix off-by-one PC\r\n- [x] Add `duk_safe_to_hstring()` helper and make debugger code use it instead of `duk_safe_to_string()` + `duk_require_hstring()`\r\n- [x] Fix other instances of `duk_write_xxx(..., duk_require_xxx(...))` to use assert + `duk_get_xxx()` instead (throwing an error is not OK)\r\n- [x] Review `duk_debugger.c` with respect to the topmost activation being a non-Ecmascript function\r\n- [x] Test all debugger commands while paused in a native function, e.g. StepOver/StepInfo?\r\n- [x] Releases entry"},"comment":{"url":"https://api.github.com/repos/svaarala/duktape/issues/comments/140895866","html_url":"https://github.com/svaarala/duktape/pull/347#issuecomment-140895866","issue_url":"https://api.github.com/repos/svaarala/duktape/issues/347","id":140895866,"user":{"login":"fatcerberus","id":4097841,"avatar_url":"https://avatars.githubusercontent.com/u/4097841?v=3","gravatar_id":"","url":"https://api.github.com/users/fatcerberus","html_url":"https://github.com/fatcerberus","followers_url":"https://api.github.com/users/fatcerberus/followers","following_url":"https://api.github.com/users/fatcerberus/following{/other_user}","gists_url":"https://api.github.com/users/fatcerberus/gists{/gist_id}","starred_url":"https://api.github.com/users/fatcerberus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatcerberus/subscriptions","organizations_url":"https://api.github.com/users/fatcerberus/orgs","repos_url":"https://api.github.com/users/fatcerberus/repos","events_url":"https://api.github.com/users/fatcerberus/events{/privacy}","received_events_url":"https://api.github.com/users/fatcerberus/received_events","type":"User","site_admin":false},"created_at":"2015-09-16T21:09:43Z","updated_at":"2015-09-16T21:09:43Z","body":"A hacky way to do it now might be to request bytecode for the current function (GetBytecode request) but of course for a large Ecmascript that would send the entire thing over the wire which might be inefficient..."}}