{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/39759612","id":39759612,"diff_hunk":"@@ -42,13 +42,18 @@ us enforce that it can't leave the current thread.\n ### `Sync`\n \n The second of these traits is called [`Sync`](../std/marker/trait.Sync.html).\n-When a type `T` implements `Sync`, it indicates to the compiler that something\n-of this type has no possibility of introducing memory unsafety when used from\n-multiple threads concurrently.\n-\n-For example, sharing immutable data with an atomic reference count is\n-threadsafe. Rust provides a type like this, `Arc<T>`, and it implements `Sync`,\n-so it is safe to share between threads.\n+When a type `T` implements `Sync`, it indicates that something of this type has\n+no possibility of introducing memory unsafety when shared\n+[immutably](mutability.html) between threads. This implies that types which","path":"src/doc/trpl/concurrency.md","position":24,"original_position":24,"commit_id":"0e70720a5a337019bf478201659f3c185f0c590a","original_commit_id":"0e70720a5a337019bf478201659f3c185f0c590a","user":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"body":"I don't believe that `Sync` has anything to do with mutability, strictly speaking.","created_at":"2015-09-17T15:28:20Z","updated_at":"2015-09-17T15:28:20Z","html_url":"https://github.com/rust-lang/rust/pull/28463#discussion_r39759612","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/28463","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/39759612"},"html":{"href":"https://github.com/rust-lang/rust/pull/28463#discussion_r39759612"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28463"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/28463","id":45301984,"html_url":"https://github.com/rust-lang/rust/pull/28463","diff_url":"https://github.com/rust-lang/rust/pull/28463.diff","patch_url":"https://github.com/rust-lang/rust/pull/28463.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/28463","number":28463,"state":"open","locked":false,"title":"doc-book: Improve clarity of Sync in Concurrency","user":{"login":"critiqjo","id":1436441,"avatar_url":"https://avatars.githubusercontent.com/u/1436441?v=3","gravatar_id":"","url":"https://api.github.com/users/critiqjo","html_url":"https://github.com/critiqjo","followers_url":"https://api.github.com/users/critiqjo/followers","following_url":"https://api.github.com/users/critiqjo/following{/other_user}","gists_url":"https://api.github.com/users/critiqjo/gists{/gist_id}","starred_url":"https://api.github.com/users/critiqjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/critiqjo/subscriptions","organizations_url":"https://api.github.com/users/critiqjo/orgs","repos_url":"https://api.github.com/users/critiqjo/repos","events_url":"https://api.github.com/users/critiqjo/events{/privacy}","received_events_url":"https://api.github.com/users/critiqjo/received_events","type":"User","site_admin":false},"body":"Fixes #28458\r\n\r\nDetails about `Arc` may be too soon to be described together with `Sync`... Tell me what you think.\r\n\r\nr? @steveklabnik ","created_at":"2015-09-17T15:09:00Z","updated_at":"2015-09-17T15:28:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"799a8e9f055ee65e0e9c3a6c0575d6873e5ff57b","assignee":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/28463/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/28463/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/28463/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/0e70720a5a337019bf478201659f3c185f0c590a","head":{"label":"critiqjo:book-concurrency","ref":"book-concurrency","sha":"0e70720a5a337019bf478201659f3c185f0c590a","user":{"login":"critiqjo","id":1436441,"avatar_url":"https://avatars.githubusercontent.com/u/1436441?v=3","gravatar_id":"","url":"https://api.github.com/users/critiqjo","html_url":"https://github.com/critiqjo","followers_url":"https://api.github.com/users/critiqjo/followers","following_url":"https://api.github.com/users/critiqjo/following{/other_user}","gists_url":"https://api.github.com/users/critiqjo/gists{/gist_id}","starred_url":"https://api.github.com/users/critiqjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/critiqjo/subscriptions","organizations_url":"https://api.github.com/users/critiqjo/orgs","repos_url":"https://api.github.com/users/critiqjo/repos","events_url":"https://api.github.com/users/critiqjo/events{/privacy}","received_events_url":"https://api.github.com/users/critiqjo/received_events","type":"User","site_admin":false},"repo":{"id":34447834,"name":"rust","full_name":"critiqjo/rust","owner":{"login":"critiqjo","id":1436441,"avatar_url":"https://avatars.githubusercontent.com/u/1436441?v=3","gravatar_id":"","url":"https://api.github.com/users/critiqjo","html_url":"https://github.com/critiqjo","followers_url":"https://api.github.com/users/critiqjo/followers","following_url":"https://api.github.com/users/critiqjo/following{/other_user}","gists_url":"https://api.github.com/users/critiqjo/gists{/gist_id}","starred_url":"https://api.github.com/users/critiqjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/critiqjo/subscriptions","organizations_url":"https://api.github.com/users/critiqjo/orgs","repos_url":"https://api.github.com/users/critiqjo/repos","events_url":"https://api.github.com/users/critiqjo/events{/privacy}","received_events_url":"https://api.github.com/users/critiqjo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/critiqjo/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/critiqjo/rust","forks_url":"https://api.github.com/repos/critiqjo/rust/forks","keys_url":"https://api.github.com/repos/critiqjo/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/critiqjo/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/critiqjo/rust/teams","hooks_url":"https://api.github.com/repos/critiqjo/rust/hooks","issue_events_url":"https://api.github.com/repos/critiqjo/rust/issues/events{/number}","events_url":"https://api.github.com/repos/critiqjo/rust/events","assignees_url":"https://api.github.com/repos/critiqjo/rust/assignees{/user}","branches_url":"https://api.github.com/repos/critiqjo/rust/branches{/branch}","tags_url":"https://api.github.com/repos/critiqjo/rust/tags","blobs_url":"https://api.github.com/repos/critiqjo/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/critiqjo/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/critiqjo/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/critiqjo/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/critiqjo/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/critiqjo/rust/languages","stargazers_url":"https://api.github.com/repos/critiqjo/rust/stargazers","contributors_url":"https://api.github.com/repos/critiqjo/rust/contributors","subscribers_url":"https://api.github.com/repos/critiqjo/rust/subscribers","subscription_url":"https://api.github.com/repos/critiqjo/rust/subscription","commits_url":"https://api.github.com/repos/critiqjo/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/critiqjo/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/critiqjo/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/critiqjo/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/critiqjo/rust/contents/{+path}","compare_url":"https://api.github.com/repos/critiqjo/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/critiqjo/rust/merges","archive_url":"https://api.github.com/repos/critiqjo/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/critiqjo/rust/downloads","issues_url":"https://api.github.com/repos/critiqjo/rust/issues{/number}","pulls_url":"https://api.github.com/repos/critiqjo/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/critiqjo/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/critiqjo/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/critiqjo/rust/labels{/name}","releases_url":"https://api.github.com/repos/critiqjo/rust/releases{/id}","created_at":"2015-04-23T09:48:54Z","updated_at":"2015-04-23T09:49:20Z","pushed_at":"2015-09-17T15:21:57Z","git_url":"git://github.com/critiqjo/rust.git","ssh_url":"git@github.com:critiqjo/rust.git","clone_url":"https://github.com/critiqjo/rust.git","svn_url":"https://github.com/critiqjo/rust","homepage":"http://www.rust-lang.org","size":277083,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"c9fc4efd24ede43bed844f44a14b35eb406825aa","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-09-17T13:38:53Z","pushed_at":"2015-09-17T15:21:59Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":677200,"stargazers_count":13365,"watchers_count":13365,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2590,"mirror_url":null,"open_issues_count":2256,"forks":2590,"open_issues":2256,"watchers":13365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28463"},"html":{"href":"https://github.com/rust-lang/rust/pull/28463"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/28463"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/28463/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28463/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28463/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/0e70720a5a337019bf478201659f3c185f0c590a"}}}}