{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/29328938","id":29328938,"diff_hunk":"@@ -92,7 +93,28 @@ def install\n \n     args << \"--without-gcc\" if ENV.compiler == :clang\n \n-    distutils_fix_superenv(args)\n+    unless MacOS::CLT.installed?\n+      # Help Python's build system (setuptools/pip) to build things on Xcode-only systems\n+      # The setup.py looks at \"-isysroot\" to get the sysroot (and not at --sysroot)\n+      cflags = \"CFLAGS=-isysroot #{MacOS.sdk_path}\"\n+      ldflags = \"LDFLAGS=-isysroot #{MacOS.sdk_path}\"\n+      args << \"CPPFLAGS=-I#{MacOS.sdk_path}/usr/include\" # find zlib\n+      # For the Xlib.h, Python needs this header dir with the system Tk\n+      if build.without? \"tcl-tk\"\n+        cflags += \" -I#{MacOS.sdk_path}/System/Library/Frameworks/Tk.framework/Versions/8.5/Headers\"\n+      end\n+      args << cflags\n+      args << ldflags\n+    end","path":"Library/Formula/python.rb","position":49,"original_position":49,"commit_id":"f89752dc4a21e382abd82d27ffa166e5f31417ca","original_commit_id":"f89752dc4a21e382abd82d27ffa166e5f31417ca","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"Will this blow up on bottles on non-CLT systems (or vide-versa)?","created_at":"2015-04-29T12:00:41Z","updated_at":"2015-04-29T12:00:41Z","html_url":"https://github.com/Homebrew/homebrew/pull/39154#discussion_r29328938","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39154","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/29328938"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/39154#discussion_r29328938"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39154"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39154","id":34303115,"html_url":"https://github.com/Homebrew/homebrew/pull/39154","diff_url":"https://github.com/Homebrew/homebrew/pull/39154.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/39154.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/39154","number":39154,"state":"open","locked":false,"title":"pythons: improve distutils hinting","user":{"login":"tdsmith","id":173889,"avatar_url":"https://avatars.githubusercontent.com/u/173889?v=3","gravatar_id":"","url":"https://api.github.com/users/tdsmith","html_url":"https://github.com/tdsmith","followers_url":"https://api.github.com/users/tdsmith/followers","following_url":"https://api.github.com/users/tdsmith/following{/other_user}","gists_url":"https://api.github.com/users/tdsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/tdsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdsmith/subscriptions","organizations_url":"https://api.github.com/users/tdsmith/orgs","repos_url":"https://api.github.com/users/tdsmith/repos","events_url":"https://api.github.com/users/tdsmith/events{/privacy}","received_events_url":"https://api.github.com/users/tdsmith/received_events","type":"User","site_admin":false},"body":"WIP to address #26272. Needs testing and should be ported to python3.\n\nThe upshot is that we should use distutils.cfg to tell distutils about brewed packages instead of passing CFLAGS to python's configure script at build time, because distutils places CFLAGS at the head of the compiler invocation and we risk shadowing other include paths.","created_at":"2015-04-28T19:38:10Z","updated_at":"2015-04-29T12:00:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d46fe02741d143b355de148267df47400e2e88f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39154/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39154/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/39154/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/f89752dc4a21e382abd82d27ffa166e5f31417ca","head":{"label":"tdsmith:python-cflags","ref":"python-cflags","sha":"f89752dc4a21e382abd82d27ffa166e5f31417ca","user":{"login":"tdsmith","id":173889,"avatar_url":"https://avatars.githubusercontent.com/u/173889?v=3","gravatar_id":"","url":"https://api.github.com/users/tdsmith","html_url":"https://github.com/tdsmith","followers_url":"https://api.github.com/users/tdsmith/followers","following_url":"https://api.github.com/users/tdsmith/following{/other_user}","gists_url":"https://api.github.com/users/tdsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/tdsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdsmith/subscriptions","organizations_url":"https://api.github.com/users/tdsmith/orgs","repos_url":"https://api.github.com/users/tdsmith/repos","events_url":"https://api.github.com/users/tdsmith/events{/privacy}","received_events_url":"https://api.github.com/users/tdsmith/received_events","type":"User","site_admin":false},"repo":{"id":20579806,"name":"homebrew","full_name":"tdsmith/homebrew","owner":{"login":"tdsmith","id":173889,"avatar_url":"https://avatars.githubusercontent.com/u/173889?v=3","gravatar_id":"","url":"https://api.github.com/users/tdsmith","html_url":"https://github.com/tdsmith","followers_url":"https://api.github.com/users/tdsmith/followers","following_url":"https://api.github.com/users/tdsmith/following{/other_user}","gists_url":"https://api.github.com/users/tdsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/tdsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdsmith/subscriptions","organizations_url":"https://api.github.com/users/tdsmith/orgs","repos_url":"https://api.github.com/users/tdsmith/repos","events_url":"https://api.github.com/users/tdsmith/events{/privacy}","received_events_url":"https://api.github.com/users/tdsmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tdsmith/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/tdsmith/homebrew","forks_url":"https://api.github.com/repos/tdsmith/homebrew/forks","keys_url":"https://api.github.com/repos/tdsmith/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdsmith/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdsmith/homebrew/teams","hooks_url":"https://api.github.com/repos/tdsmith/homebrew/hooks","issue_events_url":"https://api.github.com/repos/tdsmith/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/tdsmith/homebrew/events","assignees_url":"https://api.github.com/repos/tdsmith/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/tdsmith/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/tdsmith/homebrew/tags","blobs_url":"https://api.github.com/repos/tdsmith/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdsmith/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdsmith/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdsmith/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdsmith/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/tdsmith/homebrew/languages","stargazers_url":"https://api.github.com/repos/tdsmith/homebrew/stargazers","contributors_url":"https://api.github.com/repos/tdsmith/homebrew/contributors","subscribers_url":"https://api.github.com/repos/tdsmith/homebrew/subscribers","subscription_url":"https://api.github.com/repos/tdsmith/homebrew/subscription","commits_url":"https://api.github.com/repos/tdsmith/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdsmith/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdsmith/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdsmith/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdsmith/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/tdsmith/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdsmith/homebrew/merges","archive_url":"https://api.github.com/repos/tdsmith/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdsmith/homebrew/downloads","issues_url":"https://api.github.com/repos/tdsmith/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/tdsmith/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/tdsmith/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/tdsmith/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdsmith/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/tdsmith/homebrew/releases{/id}","created_at":"2014-06-06T22:16:54Z","updated_at":"2014-06-06T22:17:18Z","pushed_at":"2015-04-28T19:27:05Z","git_url":"git://github.com/tdsmith/homebrew.git","ssh_url":"git@github.com:tdsmith/homebrew.git","clone_url":"https://github.com/tdsmith/homebrew.git","svn_url":"https://github.com/tdsmith/homebrew","homepage":"http://brew.sh","size":39412,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"4cb6a9a9886b40c27c2d4f729ae66682717e27d4","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":":beer: The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2015-04-29T11:57:30Z","pushed_at":"2015-04-29T11:57:25Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1483932,"stargazers_count":22680,"watchers_count":22680,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":11410,"mirror_url":null,"open_issues_count":423,"forks":11410,"open_issues":423,"watchers":22680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39154"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/39154"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/39154"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/39154/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39154/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39154/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/f89752dc4a21e382abd82d27ffa166e5f31417ca"}}}}