{"action":"created","issue":{"url":"https://api.github.com/repos/manastech/crystal/issues/482","labels_url":"https://api.github.com/repos/manastech/crystal/issues/482/labels{/name}","comments_url":"https://api.github.com/repos/manastech/crystal/issues/482/comments","events_url":"https://api.github.com/repos/manastech/crystal/issues/482/events","html_url":"https://github.com/manastech/crystal/pull/482","id":61703497,"number":482,"title":"Include Comparable into Number, changed Comparable#between? to match Rub...","user":{"login":"Exilor","id":5578107,"avatar_url":"https://avatars.githubusercontent.com/u/5578107?v=3","gravatar_id":"","url":"https://api.github.com/users/Exilor","html_url":"https://github.com/Exilor","followers_url":"https://api.github.com/users/Exilor/followers","following_url":"https://api.github.com/users/Exilor/following{/other_user}","gists_url":"https://api.github.com/users/Exilor/gists{/gist_id}","starred_url":"https://api.github.com/users/Exilor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exilor/subscriptions","organizations_url":"https://api.github.com/users/Exilor/orgs","repos_url":"https://api.github.com/users/Exilor/repos","events_url":"https://api.github.com/users/Exilor/events{/privacy}","received_events_url":"https://api.github.com/users/Exilor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-14T21:59:29Z","updated_at":"2015-03-14T23:26:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/manastech/crystal/pulls/482","html_url":"https://github.com/manastech/crystal/pull/482","diff_url":"https://github.com/manastech/crystal/pull/482.diff","patch_url":"https://github.com/manastech/crystal/pull/482.patch"},"body":"...y's behavior"},"comment":{"url":"https://api.github.com/repos/manastech/crystal/issues/comments/80759862","html_url":"https://github.com/manastech/crystal/pull/482#issuecomment-80759862","issue_url":"https://api.github.com/repos/manastech/crystal/issues/482","id":80759862,"user":{"login":"asterite","id":209371,"avatar_url":"https://avatars.githubusercontent.com/u/209371?v=3","gravatar_id":"","url":"https://api.github.com/users/asterite","html_url":"https://github.com/asterite","followers_url":"https://api.github.com/users/asterite/followers","following_url":"https://api.github.com/users/asterite/following{/other_user}","gists_url":"https://api.github.com/users/asterite/gists{/gist_id}","starred_url":"https://api.github.com/users/asterite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterite/subscriptions","organizations_url":"https://api.github.com/users/asterite/orgs","repos_url":"https://api.github.com/users/asterite/repos","events_url":"https://api.github.com/users/asterite/events{/privacy}","received_events_url":"https://api.github.com/users/asterite/received_events","type":"User","site_admin":false},"created_at":"2015-03-14T23:26:03Z","updated_at":"2015-03-14T23:26:03Z","body":"Thanks!\r\n\r\nWe had the logic wrong for `between?`, I always thought it was exclusive. But your spec doesn't test that logic.\r\n\r\nIn any case, I think I'm now inclined to remove the `between?` method altogether. In Crystal you can do:\r\n\r\n```crystal\r\na <= value <= b\r\n```\r\n\r\nwhich is much more clear, because then you don't have to check whether `between?` is inclusive or exclusive. You can even do all of these:\r\n\r\n```crystal\r\na <= value <= b\r\na <= value < b\r\na < value <= b\r\na < value < b\r\n```\r\n\r\nso `between?` feels week against these.\r\n\r\nWhat do you think?\r\n\r\n(I'll accept the pull request anyway in case we decide to keep that method)."}}