{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/2606","labels_url":"https://api.github.com/repos/openshift/origin/issues/2606/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/2606/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/2606/events","html_url":"https://github.com/openshift/origin/pull/2606","id":82520294,"number":2606,"title":"BZ 1219420 - Do not admit routes with the same scheme/host/path","user":{"login":"pweil-","id":5230419,"avatar_url":"https://avatars.githubusercontent.com/u/5230419?v=3","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-05-29T17:46:37Z","updated_at":"2015-06-10T02:45:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/2606","html_url":"https://github.com/openshift/origin/pull/2606","diff_url":"https://github.com/openshift/origin/pull/2606.diff","patch_url":"https://github.com/openshift/origin/pull/2606.patch"},"body":"As discussed with @danmcp and @liggitt.  We will not admit duplicate routes.  \r\n\r\nRules:\r\n\r\n1.  Routes will be considered unique by the scheme/host/path combination.  A route will any type of TLS will be considered as using the https scheme for admission purposes.\r\n1.  When adding, if the unique key already exists then deny\r\n1.  When updating, if the unique key already exists only admit if it is the same namespace/name\r\n\r\nOf note:  Admission controllers do not have access to an openshift client which is required to maintain the route store.  To work around this I used the `admission.NewChainHandler` function to add a pre-initialized plugin to the chain of plugins created by `admission.NewFromPlugins`.  This method is currently marked as \"for test use\".  @derekwaynecarr PTAL at that section.\r\n\r\n@liggitt @smarterclayton PTAL\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/110566794","html_url":"https://github.com/openshift/origin/pull/2606#issuecomment-110566794","issue_url":"https://api.github.com/repos/openshift/origin/issues/2606","id":110566794,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2015-06-10T02:45:22Z","updated_at":"2015-06-10T02:45:22Z","body":"Origin Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again"}}