{"action":"created","issue":{"url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/958","labels_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/958/labels{/name}","comments_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/958/comments","events_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/958/events","html_url":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/958","id":114905760,"number":958,"title":"Could Address expose a getId()?","user":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-11-03T20:44:42Z","updated_at":"2015-11-03T22:30:39Z","closed_at":null,"body":"Writing my own impl of AddressRepository. There is no way I can simply rely on the Address interface to look up addresses based on id. Because that method is not available to me. Example:\r\n\r\n```\r\npublic class StaticAddressRepository implements AddressRepository {\r\n\r\n    private final Set<DefaultAddress> addresses = new HashSet<>();\r\n\r\n    @Override\r\n    public Address getById(final Long aLong) {\r\n        for (DefaultAddress address : addresses) {\r\n            if (address.getId().equals(aLong)) {\r\n                return address;\r\n            }\r\n        }\r\n        return null;\r\n    }\r\n}\r\n```\r\n\r\nSo I am forced to use DefaultAddress. Would be better if I didnt have to use the actual impl. "},"comment":{"url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/comments/153509799","html_url":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/958#issuecomment-153509799","issue_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/958","id":153509799,"user":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"created_at":"2015-11-03T22:30:39Z","updated_at":"2015-11-03T22:30:39Z","body":">There have been a couple of requests in the past to loosen the dependency on JPA at the data layer, but we haven't yet been able to do that without making the base project very complicated as a result. I'm open to suggestions in rearchitecting the data model for 1.3.\r\n\r\n:+1: \r\n\r\nI am completely moving away from the JPA layer, and this would tremendously help. I have so far tried to re-implement all JPA-based repositories and things work fine, but I obviously wouldnt object to making this even simpler :) \r\n\r\nJust for reference, I am working on adding OIDC support to the Shibboleth IdP. JPA could be an option, but certainly not the default option there. "}}