{"action":"created","issue":{"url":"https://api.github.com/repos/dankelley/oce/issues/715","labels_url":"https://api.github.com/repos/dankelley/oce/issues/715/labels{/name}","comments_url":"https://api.github.com/repos/dankelley/oce/issues/715/comments","events_url":"https://api.github.com/repos/dankelley/oce/issues/715/events","html_url":"https://github.com/dankelley/oce/issues/715","id":100557228,"number":715,"title":"handle moored-ctd data differently","user":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dankelley/oce/labels/ctd","name":"ctd","color":"5319e7"},{"url":"https://api.github.com/repos/dankelley/oce/labels/Development","name":"Development","color":"bfd4f2"},{"url":"https://api.github.com/repos/dankelley/oce/labels/request","name":"request","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-12T14:34:57Z","updated_at":"2015-08-14T14:42:10Z","closed_at":null,"body":"The screenshot shows what comes up for a moored-ctd datafile. The profiles aren't of much use. In this particular case, an ODF file, there is something in the header that indicate that this is a moored CTD. In other cases, this could probably be inferred (maybe ``sd(p)/mean(p) < 0.1`` or something). In any case, I think it might make sense to show timeseries instead.\r\n\r\nMaybe we need a subclass of ctd, for moored ctd.  @richardsc -- what do you think?\r\n\r\n<img width=\"1268\" alt=\"screen shot 2015-08-12 at 11 31 12 am\" src=\"https://cloud.githubusercontent.com/assets/99469/9226687/1d135fa8-40e6-11e5-9c3b-91a49c3bfde5.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/dankelley/oce/issues/comments/131130238","html_url":"https://github.com/dankelley/oce/issues/715#issuecomment-131130238","issue_url":"https://api.github.com/repos/dankelley/oce/issues/715","id":131130238,"user":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"created_at":"2015-08-14T14:42:10Z","updated_at":"2015-08-14T14:42:10Z","body":"I've got reasonable results with the following types:\r\n```\r\n$ grep DATA_TYPE *ODF\r\nCTD_BCD2010666_01_01_DN.ODF:  DATA_TYPE='CTD',\r\nCTD_DGR2006001_9_1_DN.ODF:  DATA_TYPE='CTD',\r\nMCTD_DGR2005001_1576_0862_1800.ODF:  DATA_TYPE='MCTD',\r\nMVCTD_HUD2008004_021_001_DN.ODF:  DATA_TYPE='MVCTD',\r\n```\r\nThese tests require ODF and R code that are private, but of course I'll send them to @richardsc by email, upon request. I propose we use this scheme for tests, i.e. add testing code here, and email files privately. We should use the ``list.files()`` trick in ``715b.R`` to give a message to non-developers who try the tests. That way, we can get a good test suite without having files scattered across several computers.\r\n\r\nMy experience with ODF is that many files have subtle differences from the others. For an example:\r\n```\r\n$ grep mmH *ODF\r\nMVCTD_HUD2008004_021_001_DN.ODF:  UNITS='mmHo',\r\n```\r\nindicates a unit that I had to guess on. I think they mean mho/m (=S/m), but I'm really not too sure of that, given the funky caps and spelling."}}