{"action":"closed","number":26,"pull_request":{"url":"https://api.github.com/repos/icewind1991/SMB/pulls/26","id":32985626,"html_url":"https://github.com/icewind1991/SMB/pull/26","diff_url":"https://github.com/icewind1991/SMB/pull/26.diff","patch_url":"https://github.com/icewind1991/SMB/pull/26.patch","issue_url":"https://api.github.com/repos/icewind1991/SMB/issues/26","number":26,"state":"closed","locked":false,"title":"close smbclient connections properly","user":{"login":"mmattel","id":3321281,"avatar_url":"https://avatars.githubusercontent.com/u/3321281?v=3","gravatar_id":"","url":"https://api.github.com/users/mmattel","html_url":"https://github.com/mmattel","followers_url":"https://api.github.com/users/mmattel/followers","following_url":"https://api.github.com/users/mmattel/following{/other_user}","gists_url":"https://api.github.com/users/mmattel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmattel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmattel/subscriptions","organizations_url":"https://api.github.com/users/mmattel/orgs","repos_url":"https://api.github.com/users/mmattel/repos","events_url":"https://api.github.com/users/mmattel/events{/privacy}","received_events_url":"https://api.github.com/users/mmattel/received_events","type":"User","site_admin":false},"body":"This PR supersedes #22\r\n\r\nIt does the same but adds a try/catch around the posix_ function to do proper handling if it is not available. owncloud, where this SMB implementation is used as 3rdparty module has the requirement, that php posix functions have to be available anyway. This is also documented in their admin manual https://github.com/owncloud/documentation/blob/master/admin_manual/installation/source_installation.rst#prerequisites\r\n\r\nA merge of this PR and #25 and the update in owncloud would greatly improve SMB\r\n\r\n@icewind1991 @Xenopathic ","created_at":"2015-04-09T19:01:19Z","updated_at":"2015-04-10T11:09:24Z","closed_at":"2015-04-10T11:09:24Z","merged_at":null,"merge_commit_sha":"e5bf6eba93f926849b775d701853f704f1056a9f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/icewind1991/SMB/pulls/26/commits","review_comments_url":"https://api.github.com/repos/icewind1991/SMB/pulls/26/comments","review_comment_url":"https://api.github.com/repos/icewind1991/SMB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/icewind1991/SMB/issues/26/comments","statuses_url":"https://api.github.com/repos/icewind1991/SMB/statuses/99f1289b28700f4b3b4c078167023fd39da94b14","head":{"label":"mmattel:close_child_processes_of_smbclient","ref":"close_child_processes_of_smbclient","sha":"99f1289b28700f4b3b4c078167023fd39da94b14","user":{"login":"mmattel","id":3321281,"avatar_url":"https://avatars.githubusercontent.com/u/3321281?v=3","gravatar_id":"","url":"https://api.github.com/users/mmattel","html_url":"https://github.com/mmattel","followers_url":"https://api.github.com/users/mmattel/followers","following_url":"https://api.github.com/users/mmattel/following{/other_user}","gists_url":"https://api.github.com/users/mmattel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmattel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmattel/subscriptions","organizations_url":"https://api.github.com/users/mmattel/orgs","repos_url":"https://api.github.com/users/mmattel/repos","events_url":"https://api.github.com/users/mmattel/events{/privacy}","received_events_url":"https://api.github.com/users/mmattel/received_events","type":"User","site_admin":false},"repo":{"id":33354475,"name":"SMB","full_name":"mmattel/SMB","owner":{"login":"mmattel","id":3321281,"avatar_url":"https://avatars.githubusercontent.com/u/3321281?v=3","gravatar_id":"","url":"https://api.github.com/users/mmattel","html_url":"https://github.com/mmattel","followers_url":"https://api.github.com/users/mmattel/followers","following_url":"https://api.github.com/users/mmattel/following{/other_user}","gists_url":"https://api.github.com/users/mmattel/gists{/gist_id}","starred_url":"https://api.github.com/users/mmattel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmattel/subscriptions","organizations_url":"https://api.github.com/users/mmattel/orgs","repos_url":"https://api.github.com/users/mmattel/repos","events_url":"https://api.github.com/users/mmattel/events{/privacy}","received_events_url":"https://api.github.com/users/mmattel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmattel/SMB","description":"PHP wrapper for smbclient","fork":true,"url":"https://api.github.com/repos/mmattel/SMB","forks_url":"https://api.github.com/repos/mmattel/SMB/forks","keys_url":"https://api.github.com/repos/mmattel/SMB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmattel/SMB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmattel/SMB/teams","hooks_url":"https://api.github.com/repos/mmattel/SMB/hooks","issue_events_url":"https://api.github.com/repos/mmattel/SMB/issues/events{/number}","events_url":"https://api.github.com/repos/mmattel/SMB/events","assignees_url":"https://api.github.com/repos/mmattel/SMB/assignees{/user}","branches_url":"https://api.github.com/repos/mmattel/SMB/branches{/branch}","tags_url":"https://api.github.com/repos/mmattel/SMB/tags","blobs_url":"https://api.github.com/repos/mmattel/SMB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmattel/SMB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmattel/SMB/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmattel/SMB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmattel/SMB/statuses/{sha}","languages_url":"https://api.github.com/repos/mmattel/SMB/languages","stargazers_url":"https://api.github.com/repos/mmattel/SMB/stargazers","contributors_url":"https://api.github.com/repos/mmattel/SMB/contributors","subscribers_url":"https://api.github.com/repos/mmattel/SMB/subscribers","subscription_url":"https://api.github.com/repos/mmattel/SMB/subscription","commits_url":"https://api.github.com/repos/mmattel/SMB/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmattel/SMB/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmattel/SMB/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmattel/SMB/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmattel/SMB/contents/{+path}","compare_url":"https://api.github.com/repos/mmattel/SMB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmattel/SMB/merges","archive_url":"https://api.github.com/repos/mmattel/SMB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmattel/SMB/downloads","issues_url":"https://api.github.com/repos/mmattel/SMB/issues{/number}","pulls_url":"https://api.github.com/repos/mmattel/SMB/pulls{/number}","milestones_url":"https://api.github.com/repos/mmattel/SMB/milestones{/number}","notifications_url":"https://api.github.com/repos/mmattel/SMB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmattel/SMB/labels{/name}","releases_url":"https://api.github.com/repos/mmattel/SMB/releases{/id}","created_at":"2015-04-03T08:27:27Z","updated_at":"2015-04-03T08:27:27Z","pushed_at":"2015-04-10T07:20:06Z","git_url":"git://github.com/mmattel/SMB.git","ssh_url":"git@github.com:mmattel/SMB.git","clone_url":"https://github.com/mmattel/SMB.git","svn_url":"https://github.com/mmattel/SMB","homepage":null,"size":252,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"icewind1991:master","ref":"master","sha":"ef4b128143b7272e97665b84862d77faabf7d36d","user":{"login":"icewind1991","id":1283854,"avatar_url":"https://avatars.githubusercontent.com/u/1283854?v=3","gravatar_id":"","url":"https://api.github.com/users/icewind1991","html_url":"https://github.com/icewind1991","followers_url":"https://api.github.com/users/icewind1991/followers","following_url":"https://api.github.com/users/icewind1991/following{/other_user}","gists_url":"https://api.github.com/users/icewind1991/gists{/gist_id}","starred_url":"https://api.github.com/users/icewind1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icewind1991/subscriptions","organizations_url":"https://api.github.com/users/icewind1991/orgs","repos_url":"https://api.github.com/users/icewind1991/repos","events_url":"https://api.github.com/users/icewind1991/events{/privacy}","received_events_url":"https://api.github.com/users/icewind1991/received_events","type":"User","site_admin":false},"repo":{"id":7084911,"name":"SMB","full_name":"icewind1991/SMB","owner":{"login":"icewind1991","id":1283854,"avatar_url":"https://avatars.githubusercontent.com/u/1283854?v=3","gravatar_id":"","url":"https://api.github.com/users/icewind1991","html_url":"https://github.com/icewind1991","followers_url":"https://api.github.com/users/icewind1991/followers","following_url":"https://api.github.com/users/icewind1991/following{/other_user}","gists_url":"https://api.github.com/users/icewind1991/gists{/gist_id}","starred_url":"https://api.github.com/users/icewind1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icewind1991/subscriptions","organizations_url":"https://api.github.com/users/icewind1991/orgs","repos_url":"https://api.github.com/users/icewind1991/repos","events_url":"https://api.github.com/users/icewind1991/events{/privacy}","received_events_url":"https://api.github.com/users/icewind1991/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/icewind1991/SMB","description":"PHP wrapper for smbclient","fork":false,"url":"https://api.github.com/repos/icewind1991/SMB","forks_url":"https://api.github.com/repos/icewind1991/SMB/forks","keys_url":"https://api.github.com/repos/icewind1991/SMB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icewind1991/SMB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icewind1991/SMB/teams","hooks_url":"https://api.github.com/repos/icewind1991/SMB/hooks","issue_events_url":"https://api.github.com/repos/icewind1991/SMB/issues/events{/number}","events_url":"https://api.github.com/repos/icewind1991/SMB/events","assignees_url":"https://api.github.com/repos/icewind1991/SMB/assignees{/user}","branches_url":"https://api.github.com/repos/icewind1991/SMB/branches{/branch}","tags_url":"https://api.github.com/repos/icewind1991/SMB/tags","blobs_url":"https://api.github.com/repos/icewind1991/SMB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icewind1991/SMB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icewind1991/SMB/git/refs{/sha}","trees_url":"https://api.github.com/repos/icewind1991/SMB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icewind1991/SMB/statuses/{sha}","languages_url":"https://api.github.com/repos/icewind1991/SMB/languages","stargazers_url":"https://api.github.com/repos/icewind1991/SMB/stargazers","contributors_url":"https://api.github.com/repos/icewind1991/SMB/contributors","subscribers_url":"https://api.github.com/repos/icewind1991/SMB/subscribers","subscription_url":"https://api.github.com/repos/icewind1991/SMB/subscription","commits_url":"https://api.github.com/repos/icewind1991/SMB/commits{/sha}","git_commits_url":"https://api.github.com/repos/icewind1991/SMB/git/commits{/sha}","comments_url":"https://api.github.com/repos/icewind1991/SMB/comments{/number}","issue_comment_url":"https://api.github.com/repos/icewind1991/SMB/issues/comments{/number}","contents_url":"https://api.github.com/repos/icewind1991/SMB/contents/{+path}","compare_url":"https://api.github.com/repos/icewind1991/SMB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icewind1991/SMB/merges","archive_url":"https://api.github.com/repos/icewind1991/SMB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icewind1991/SMB/downloads","issues_url":"https://api.github.com/repos/icewind1991/SMB/issues{/number}","pulls_url":"https://api.github.com/repos/icewind1991/SMB/pulls{/number}","milestones_url":"https://api.github.com/repos/icewind1991/SMB/milestones{/number}","notifications_url":"https://api.github.com/repos/icewind1991/SMB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icewind1991/SMB/labels{/name}","releases_url":"https://api.github.com/repos/icewind1991/SMB/releases{/id}","created_at":"2012-12-09T23:25:28Z","updated_at":"2015-03-13T12:17:20Z","pushed_at":"2015-04-10T07:20:07Z","git_url":"git://github.com/icewind1991/SMB.git","ssh_url":"git@github.com:icewind1991/SMB.git","clone_url":"https://github.com/icewind1991/SMB.git","svn_url":"https://github.com/icewind1991/SMB","homepage":null,"size":819,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/icewind1991/SMB/pulls/26"},"html":{"href":"https://github.com/icewind1991/SMB/pull/26"},"issue":{"href":"https://api.github.com/repos/icewind1991/SMB/issues/26"},"comments":{"href":"https://api.github.com/repos/icewind1991/SMB/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/icewind1991/SMB/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/icewind1991/SMB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/icewind1991/SMB/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/icewind1991/SMB/statuses/99f1289b28700f4b3b4c078167023fd39da94b14"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":3,"additions":35,"deletions":0,"changed_files":3}}