{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/otter/pulls/comments/42159678","id":42159678,"diff_hunk":"@@ -817,7 +823,8 @@ def setUp(self):\n                    links=freeze([{'href': 'link2', 'rel': 'self'}]))\n         )\n         self.state_active = {}\n-        self.cache = [thaw(self.servers[0].json), thaw(self.servers[1].json)]\n+        self.cache = [thaw(self.servers[0].json.set('_is_as_active', True)),\n+                      thaw(self.servers[1].json.set('_is_as_active', True))]","path":"otter/test/convergence/test_service.py","position":21,"original_position":21,"commit_id":"9e132db7f9fa44c08d6523d2e673eeff3f5ff011","original_commit_id":"9e132db7f9fa44c08d6523d2e673eeff3f5ff011","user":{"login":"manishtomar","id":758529,"avatar_url":"https://avatars.githubusercontent.com/u/758529?v=3","gravatar_id":"","url":"https://api.github.com/users/manishtomar","html_url":"https://github.com/manishtomar","followers_url":"https://api.github.com/users/manishtomar/followers","following_url":"https://api.github.com/users/manishtomar/following{/other_user}","gists_url":"https://api.github.com/users/manishtomar/gists{/gist_id}","starred_url":"https://api.github.com/users/manishtomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishtomar/subscriptions","organizations_url":"https://api.github.com/users/manishtomar/orgs","repos_url":"https://api.github.com/users/manishtomar/repos","events_url":"https://api.github.com/users/manishtomar/events{/privacy}","received_events_url":"https://api.github.com/users/manishtomar/received_events","type":"User","site_admin":false},"body":"I may be failing to understand but based on above `update_cache` changes I don't think servers need to become AS active.","created_at":"2015-10-15T18:12:27Z","updated_at":"2015-10-15T18:12:27Z","html_url":"https://github.com/rackerlabs/otter/pull/1767#discussion_r42159678","pull_request_url":"https://api.github.com/repos/rackerlabs/otter/pulls/1767","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/comments/42159678"},"html":{"href":"https://github.com/rackerlabs/otter/pull/1767#discussion_r42159678"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/1767"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/otter/pulls/1767","id":47737512,"html_url":"https://github.com/rackerlabs/otter/pull/1767","diff_url":"https://github.com/rackerlabs/otter/pull/1767.diff","patch_url":"https://github.com/rackerlabs/otter/pull/1767.patch","issue_url":"https://api.github.com/repos/rackerlabs/otter/issues/1767","number":1767,"state":"open","locked":false,"title":"WIP only one update_cache method","user":{"login":"dragorosson","id":2906354,"avatar_url":"https://avatars.githubusercontent.com/u/2906354?v=3","gravatar_id":"","url":"https://api.github.com/users/dragorosson","html_url":"https://github.com/dragorosson","followers_url":"https://api.github.com/users/dragorosson/followers","following_url":"https://api.github.com/users/dragorosson/following{/other_user}","gists_url":"https://api.github.com/users/dragorosson/gists{/gist_id}","starred_url":"https://api.github.com/users/dragorosson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragorosson/subscriptions","organizations_url":"https://api.github.com/users/dragorosson/orgs","repos_url":"https://api.github.com/users/dragorosson/repos","events_url":"https://api.github.com/users/dragorosson/events{/privacy}","received_events_url":"https://api.github.com/users/dragorosson/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-15T02:19:32Z","updated_at":"2015-10-15T18:12:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb5125034174b53fbc3a0a0ecd5111121386d544","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/otter/pulls/1767/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/otter/pulls/1767/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/otter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/otter/issues/1767/comments","statuses_url":"https://api.github.com/repos/rackerlabs/otter/statuses/9e132db7f9fa44c08d6523d2e673eeff3f5ff011","head":{"label":"dragorosson:update_cache","ref":"update_cache","sha":"9e132db7f9fa44c08d6523d2e673eeff3f5ff011","user":{"login":"dragorosson","id":2906354,"avatar_url":"https://avatars.githubusercontent.com/u/2906354?v=3","gravatar_id":"","url":"https://api.github.com/users/dragorosson","html_url":"https://github.com/dragorosson","followers_url":"https://api.github.com/users/dragorosson/followers","following_url":"https://api.github.com/users/dragorosson/following{/other_user}","gists_url":"https://api.github.com/users/dragorosson/gists{/gist_id}","starred_url":"https://api.github.com/users/dragorosson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragorosson/subscriptions","organizations_url":"https://api.github.com/users/dragorosson/orgs","repos_url":"https://api.github.com/users/dragorosson/repos","events_url":"https://api.github.com/users/dragorosson/events{/privacy}","received_events_url":"https://api.github.com/users/dragorosson/received_events","type":"User","site_admin":false},"repo":{"id":43506383,"name":"otter","full_name":"dragorosson/otter","owner":{"login":"dragorosson","id":2906354,"avatar_url":"https://avatars.githubusercontent.com/u/2906354?v=3","gravatar_id":"","url":"https://api.github.com/users/dragorosson","html_url":"https://github.com/dragorosson","followers_url":"https://api.github.com/users/dragorosson/followers","following_url":"https://api.github.com/users/dragorosson/following{/other_user}","gists_url":"https://api.github.com/users/dragorosson/gists{/gist_id}","starred_url":"https://api.github.com/users/dragorosson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragorosson/subscriptions","organizations_url":"https://api.github.com/users/dragorosson/orgs","repos_url":"https://api.github.com/users/dragorosson/repos","events_url":"https://api.github.com/users/dragorosson/events{/privacy}","received_events_url":"https://api.github.com/users/dragorosson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dragorosson/otter","description":"Rackspace Auto Scale","fork":true,"url":"https://api.github.com/repos/dragorosson/otter","forks_url":"https://api.github.com/repos/dragorosson/otter/forks","keys_url":"https://api.github.com/repos/dragorosson/otter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dragorosson/otter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dragorosson/otter/teams","hooks_url":"https://api.github.com/repos/dragorosson/otter/hooks","issue_events_url":"https://api.github.com/repos/dragorosson/otter/issues/events{/number}","events_url":"https://api.github.com/repos/dragorosson/otter/events","assignees_url":"https://api.github.com/repos/dragorosson/otter/assignees{/user}","branches_url":"https://api.github.com/repos/dragorosson/otter/branches{/branch}","tags_url":"https://api.github.com/repos/dragorosson/otter/tags","blobs_url":"https://api.github.com/repos/dragorosson/otter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dragorosson/otter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dragorosson/otter/git/refs{/sha}","trees_url":"https://api.github.com/repos/dragorosson/otter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dragorosson/otter/statuses/{sha}","languages_url":"https://api.github.com/repos/dragorosson/otter/languages","stargazers_url":"https://api.github.com/repos/dragorosson/otter/stargazers","contributors_url":"https://api.github.com/repos/dragorosson/otter/contributors","subscribers_url":"https://api.github.com/repos/dragorosson/otter/subscribers","subscription_url":"https://api.github.com/repos/dragorosson/otter/subscription","commits_url":"https://api.github.com/repos/dragorosson/otter/commits{/sha}","git_commits_url":"https://api.github.com/repos/dragorosson/otter/git/commits{/sha}","comments_url":"https://api.github.com/repos/dragorosson/otter/comments{/number}","issue_comment_url":"https://api.github.com/repos/dragorosson/otter/issues/comments{/number}","contents_url":"https://api.github.com/repos/dragorosson/otter/contents/{+path}","compare_url":"https://api.github.com/repos/dragorosson/otter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dragorosson/otter/merges","archive_url":"https://api.github.com/repos/dragorosson/otter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dragorosson/otter/downloads","issues_url":"https://api.github.com/repos/dragorosson/otter/issues{/number}","pulls_url":"https://api.github.com/repos/dragorosson/otter/pulls{/number}","milestones_url":"https://api.github.com/repos/dragorosson/otter/milestones{/number}","notifications_url":"https://api.github.com/repos/dragorosson/otter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dragorosson/otter/labels{/name}","releases_url":"https://api.github.com/repos/dragorosson/otter/releases{/id}","created_at":"2015-10-01T16:05:23Z","updated_at":"2015-10-01T16:05:28Z","pushed_at":"2015-10-15T17:01:02Z","git_url":"git://github.com/dragorosson/otter.git","ssh_url":"git@github.com:dragorosson/otter.git","clone_url":"https://github.com/dragorosson/otter.git","svn_url":"https://github.com/dragorosson/otter","homepage":"http://www.rackspace.com/cloud/auto-scale/","size":27236,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"41395b2615b3f6d9246993b84cda41914cc62233","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":6097139,"name":"otter","full_name":"rackerlabs/otter","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/otter","description":"Rackspace Auto Scale","fork":false,"url":"https://api.github.com/repos/rackerlabs/otter","forks_url":"https://api.github.com/repos/rackerlabs/otter/forks","keys_url":"https://api.github.com/repos/rackerlabs/otter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/otter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/otter/teams","hooks_url":"https://api.github.com/repos/rackerlabs/otter/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/otter/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/otter/events","assignees_url":"https://api.github.com/repos/rackerlabs/otter/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/otter/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/otter/tags","blobs_url":"https://api.github.com/repos/rackerlabs/otter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/otter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/otter/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/otter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/otter/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/otter/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/otter/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/otter/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/otter/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/otter/subscription","commits_url":"https://api.github.com/repos/rackerlabs/otter/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/otter/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/otter/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/otter/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/otter/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/otter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/otter/merges","archive_url":"https://api.github.com/repos/rackerlabs/otter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/otter/downloads","issues_url":"https://api.github.com/repos/rackerlabs/otter/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/otter/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/otter/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/otter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/otter/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/otter/releases{/id}","created_at":"2012-10-05T21:35:59Z","updated_at":"2015-09-28T09:25:57Z","pushed_at":"2015-10-15T17:01:03Z","git_url":"git://github.com/rackerlabs/otter.git","ssh_url":"git@github.com:rackerlabs/otter.git","clone_url":"https://github.com/rackerlabs/otter.git","svn_url":"https://github.com/rackerlabs/otter","homepage":"http://www.rackspace.com/cloud/auto-scale/","size":46789,"stargazers_count":45,"watchers_count":45,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":101,"forks":21,"open_issues":101,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/1767"},"html":{"href":"https://github.com/rackerlabs/otter/pull/1767"},"issue":{"href":"https://api.github.com/repos/rackerlabs/otter/issues/1767"},"comments":{"href":"https://api.github.com/repos/rackerlabs/otter/issues/1767/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/1767/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/1767/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/otter/statuses/9e132db7f9fa44c08d6523d2e673eeff3f5ff011"}}}}