{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/griddle/issues/11","labels_url":"https://api.github.com/repos/phetsims/griddle/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/griddle/issues/11/comments","events_url":"https://api.github.com/repos/phetsims/griddle/issues/11/events","html_url":"https://github.com/phetsims/griddle/pull/11","id":63281420,"number":11,"title":"Added clear function","user":{"login":"willzfarmer","id":546524,"avatar_url":"https://avatars.githubusercontent.com/u/546524?v=3","gravatar_id":"","url":"https://api.github.com/users/willzfarmer","html_url":"https://github.com/willzfarmer","followers_url":"https://api.github.com/users/willzfarmer/followers","following_url":"https://api.github.com/users/willzfarmer/following{/other_user}","gists_url":"https://api.github.com/users/willzfarmer/gists{/gist_id}","starred_url":"https://api.github.com/users/willzfarmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willzfarmer/subscriptions","organizations_url":"https://api.github.com/users/willzfarmer/orgs","repos_url":"https://api.github.com/users/willzfarmer/repos","events_url":"https://api.github.com/users/willzfarmer/events{/privacy}","received_events_url":"https://api.github.com/users/willzfarmer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ariel-phet","id":4051174,"avatar_url":"https://avatars.githubusercontent.com/u/4051174?v=3","gravatar_id":"","url":"https://api.github.com/users/ariel-phet","html_url":"https://github.com/ariel-phet","followers_url":"https://api.github.com/users/ariel-phet/followers","following_url":"https://api.github.com/users/ariel-phet/following{/other_user}","gists_url":"https://api.github.com/users/ariel-phet/gists{/gist_id}","starred_url":"https://api.github.com/users/ariel-phet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariel-phet/subscriptions","organizations_url":"https://api.github.com/users/ariel-phet/orgs","repos_url":"https://api.github.com/users/ariel-phet/repos","events_url":"https://api.github.com/users/ariel-phet/events{/privacy}","received_events_url":"https://api.github.com/users/ariel-phet/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-03-20T18:45:10Z","updated_at":"2015-03-23T14:42:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phetsims/griddle/pulls/11","html_url":"https://github.com/phetsims/griddle/pull/11","diff_url":"https://github.com/phetsims/griddle/pull/11.diff","patch_url":"https://github.com/phetsims/griddle/pull/11.patch"},"body":"\"clear\" function now part of XYPlot. This function sets the plot's data series to an empty array and initializes a new view with Node()."},"comment":{"url":"https://api.github.com/repos/phetsims/griddle/issues/comments/85030008","html_url":"https://github.com/phetsims/griddle/pull/11#issuecomment-85030008","issue_url":"https://api.github.com/repos/phetsims/griddle/issues/11","id":85030008,"user":{"login":"samreid","id":679486,"avatar_url":"https://avatars.githubusercontent.com/u/679486?v=3","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"created_at":"2015-03-23T14:42:48Z","updated_at":"2015-03-23T14:42:48Z","body":"It looks like there are several commits in the pull request history that are transient--changes that were made in the fork then reverted.  For example ac2e0eb8e0e6d274e6efc48f17d06b15aa148217 introduces this function into XYDataSeries.js:\r\n\r\n```js\r\n    setPoints: function(xarr, yarr) {\r\n      this.clear();\r\n      for (var j=0; j < xarr.length; j++) {\r\n          this.addPoint(xarr[j], yarr[j]);\r\n      }\r\n    }\r\n```\r\n\r\nThen in 5060461a0ccb46f523fa4548cfe4f512100c99b0 this function is removed.\r\n\r\nI noticed this sort of transient commit for several features, including XYDataSeries.setPoints, XYDataSeries.range and griddle-main's step function.  \r\n\r\nIn the future, pull requests should not contain any transient changes--they make the history more difficult to understand and reviewing the pull request more difficult.\r\n\r\nI'll continue my review in the next comment.\r\n"}}