{"action":"created","issue":{"url":"https://api.github.com/repos/ches/docker-kafka/issues/4","labels_url":"https://api.github.com/repos/ches/docker-kafka/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/ches/docker-kafka/issues/4/comments","events_url":"https://api.github.com/repos/ches/docker-kafka/issues/4/events","html_url":"https://github.com/ches/docker-kafka/pull/4","id":98157714,"number":4,"title":"Support multiple ZooKeeper servers","user":{"login":"androa","id":588046,"avatar_url":"https://avatars.githubusercontent.com/u/588046?v=3","gravatar_id":"","url":"https://api.github.com/users/androa","html_url":"https://github.com/androa","followers_url":"https://api.github.com/users/androa/followers","following_url":"https://api.github.com/users/androa/following{/other_user}","gists_url":"https://api.github.com/users/androa/gists{/gist_id}","starred_url":"https://api.github.com/users/androa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/androa/subscriptions","organizations_url":"https://api.github.com/users/androa/orgs","repos_url":"https://api.github.com/users/androa/repos","events_url":"https://api.github.com/users/androa/events{/privacy}","received_events_url":"https://api.github.com/users/androa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-30T12:26:10Z","updated_at":"2015-08-24T17:37:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ches/docker-kafka/pulls/4","html_url":"https://github.com/ches/docker-kafka/pull/4","diff_url":"https://github.com/ches/docker-kafka/pull/4.diff","patch_url":"https://github.com/ches/docker-kafka/pull/4.patch"},"body":"In order to connect to a ZooKeeper cluster, one should/need to have several ZooKeeper hosts in the connection string. This is a comma separated host:port pairs, each corresponding to a zk server. \r\n\r\nFor example: \"127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002\".\r\n\r\nThe PR is backwards compatible with the ZOOKEEPER_HOST + ZOOKEEPER_IP settings."},"comment":{"url":"https://api.github.com/repos/ches/docker-kafka/issues/comments/134312043","html_url":"https://github.com/ches/docker-kafka/pull/4#issuecomment-134312043","issue_url":"https://api.github.com/repos/ches/docker-kafka/issues/4","id":134312043,"user":{"login":"ches","id":13277,"avatar_url":"https://avatars.githubusercontent.com/u/13277?v=3","gravatar_id":"","url":"https://api.github.com/users/ches","html_url":"https://github.com/ches","followers_url":"https://api.github.com/users/ches/followers","following_url":"https://api.github.com/users/ches/following{/other_user}","gists_url":"https://api.github.com/users/ches/gists{/gist_id}","starred_url":"https://api.github.com/users/ches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ches/subscriptions","organizations_url":"https://api.github.com/users/ches/orgs","repos_url":"https://api.github.com/users/ches/repos","events_url":"https://api.github.com/users/ches/events{/privacy}","received_events_url":"https://api.github.com/users/ches/received_events","type":"User","site_admin":false},"created_at":"2015-08-24T17:37:56Z","updated_at":"2015-08-24T17:37:56Z","body":"Thank you for the PR! I was thinking about this need as well, it's a welcome change.\r\n\r\nA few requests if you wouldn't mind updating:\r\n\r\n- Could you rebase on latest master? Apologies that I didn't review sooner, but the conflicts should be trivial to sort out.\r\n- Please remove the commit that changes whitespace in the README, it will result in multiple single-element lists in the HTML rendered from Markdown whereas the existing format properly produces one list in GitHub's rendering. It used to look poor on the Docker Hub, it still doesn't render as one list with their parser but at least it looks legible in their new UI.\r\n- Did you have particular reasoning for changing to relative paths in the `sed` command in `start.sh`? It seems problematic: a.) it appears incorrect, one path includes `./config` and the other doesn't, and b.) if a user happens to run a shell with this container and then manually runs `start.sh` from there, it is going to behave badly if the user has changed directories from the default `WORKDIR` of `/kafka` and invokes `start.sh` with an absolute path. I'd rather avoid that possibility, and not have a brittle implicit dependency on how `WORKDIR` is set.\r\n\r\nThanks!"}}