{"action":"created","comment":{"url":"https://api.github.com/repos/L-MA/calico-rkt/pulls/comments/47417105","id":47417105,"diff_hunk":"@@ -146,15 +152,20 @@ def execute(self):\n             _log.debug(\"Starting plugin execution.\")\n             self._execute()\n         except SystemExit, e:\n-            # SystemExit indicates an error that was handled earlier\n-            # in the stack.  Just set the return code.\n-            rc = e.code \n+            # Defer printing the error message and setting the rc in the\n+            # finally clause\n+            pass\n         except BaseException:\n             # An unexpected Exception has bubbled up - catch it and\n             # log it out.\n-            _log.exception(\"Unhandled Exception killed plugin\")","path":"calico_rkt/calico_rkt.py","position":26,"original_position":26,"commit_id":"2aaa9b53fa7b4fb6681c577cdf31450cfc732d40","original_commit_id":"2aaa9b53fa7b4fb6681c577cdf31450cfc732d40","user":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"body":"We still want this _log.exception here - it will include the stacktrace which killed the plugin, which is crucial for debugging.","created_at":"2015-12-11T23:13:23Z","updated_at":"2015-12-11T23:13:23Z","html_url":"https://github.com/L-MA/calico-rkt/pull/1#discussion_r47417105","pull_request_url":"https://api.github.com/repos/L-MA/calico-rkt/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/L-MA/calico-rkt/pulls/comments/47417105"},"html":{"href":"https://github.com/L-MA/calico-rkt/pull/1#discussion_r47417105"},"pull_request":{"href":"https://api.github.com/repos/L-MA/calico-rkt/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/L-MA/calico-rkt/pulls/1","id":53455812,"html_url":"https://github.com/L-MA/calico-rkt/pull/1","diff_url":"https://github.com/L-MA/calico-rkt/pull/1.diff","patch_url":"https://github.com/L-MA/calico-rkt/pull/1.patch","issue_url":"https://api.github.com/repos/L-MA/calico-rkt/issues/1","number":1,"state":"open","locked":false,"title":"Initial error response design","user":{"login":"L-MA","id":9704719,"avatar_url":"https://avatars.githubusercontent.com/u/9704719?v=3","gravatar_id":"","url":"https://api.github.com/users/L-MA","html_url":"https://github.com/L-MA","followers_url":"https://api.github.com/users/L-MA/followers","following_url":"https://api.github.com/users/L-MA/following{/other_user}","gists_url":"https://api.github.com/users/L-MA/gists{/gist_id}","starred_url":"https://api.github.com/users/L-MA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-MA/subscriptions","organizations_url":"https://api.github.com/users/L-MA/orgs","repos_url":"https://api.github.com/users/L-MA/repos","events_url":"https://api.github.com/users/L-MA/events{/privacy}","received_events_url":"https://api.github.com/users/L-MA/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-11T23:07:41Z","updated_at":"2015-12-11T23:13:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39c4479a1e3a098db62883577357bf11bb837677","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/L-MA/calico-rkt/pulls/1/commits","review_comments_url":"https://api.github.com/repos/L-MA/calico-rkt/pulls/1/comments","review_comment_url":"https://api.github.com/repos/L-MA/calico-rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/L-MA/calico-rkt/issues/1/comments","statuses_url":"https://api.github.com/repos/L-MA/calico-rkt/statuses/2aaa9b53fa7b4fb6681c577cdf31450cfc732d40","head":{"label":"L-MA:error-handling","ref":"error-handling","sha":"2aaa9b53fa7b4fb6681c577cdf31450cfc732d40","user":{"login":"L-MA","id":9704719,"avatar_url":"https://avatars.githubusercontent.com/u/9704719?v=3","gravatar_id":"","url":"https://api.github.com/users/L-MA","html_url":"https://github.com/L-MA","followers_url":"https://api.github.com/users/L-MA/followers","following_url":"https://api.github.com/users/L-MA/following{/other_user}","gists_url":"https://api.github.com/users/L-MA/gists{/gist_id}","starred_url":"https://api.github.com/users/L-MA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-MA/subscriptions","organizations_url":"https://api.github.com/users/L-MA/orgs","repos_url":"https://api.github.com/users/L-MA/repos","events_url":"https://api.github.com/users/L-MA/events{/privacy}","received_events_url":"https://api.github.com/users/L-MA/received_events","type":"User","site_admin":false},"repo":{"id":44204927,"name":"calico-rkt","full_name":"L-MA/calico-rkt","owner":{"login":"L-MA","id":9704719,"avatar_url":"https://avatars.githubusercontent.com/u/9704719?v=3","gravatar_id":"","url":"https://api.github.com/users/L-MA","html_url":"https://github.com/L-MA","followers_url":"https://api.github.com/users/L-MA/followers","following_url":"https://api.github.com/users/L-MA/following{/other_user}","gists_url":"https://api.github.com/users/L-MA/gists{/gist_id}","starred_url":"https://api.github.com/users/L-MA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-MA/subscriptions","organizations_url":"https://api.github.com/users/L-MA/orgs","repos_url":"https://api.github.com/users/L-MA/repos","events_url":"https://api.github.com/users/L-MA/events{/privacy}","received_events_url":"https://api.github.com/users/L-MA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/L-MA/calico-rkt","description":"Calico plugin for rkt deployments","fork":true,"url":"https://api.github.com/repos/L-MA/calico-rkt","forks_url":"https://api.github.com/repos/L-MA/calico-rkt/forks","keys_url":"https://api.github.com/repos/L-MA/calico-rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/L-MA/calico-rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/L-MA/calico-rkt/teams","hooks_url":"https://api.github.com/repos/L-MA/calico-rkt/hooks","issue_events_url":"https://api.github.com/repos/L-MA/calico-rkt/issues/events{/number}","events_url":"https://api.github.com/repos/L-MA/calico-rkt/events","assignees_url":"https://api.github.com/repos/L-MA/calico-rkt/assignees{/user}","branches_url":"https://api.github.com/repos/L-MA/calico-rkt/branches{/branch}","tags_url":"https://api.github.com/repos/L-MA/calico-rkt/tags","blobs_url":"https://api.github.com/repos/L-MA/calico-rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/L-MA/calico-rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/L-MA/calico-rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/L-MA/calico-rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/L-MA/calico-rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/L-MA/calico-rkt/languages","stargazers_url":"https://api.github.com/repos/L-MA/calico-rkt/stargazers","contributors_url":"https://api.github.com/repos/L-MA/calico-rkt/contributors","subscribers_url":"https://api.github.com/repos/L-MA/calico-rkt/subscribers","subscription_url":"https://api.github.com/repos/L-MA/calico-rkt/subscription","commits_url":"https://api.github.com/repos/L-MA/calico-rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/L-MA/calico-rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/L-MA/calico-rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/L-MA/calico-rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/L-MA/calico-rkt/contents/{+path}","compare_url":"https://api.github.com/repos/L-MA/calico-rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/L-MA/calico-rkt/merges","archive_url":"https://api.github.com/repos/L-MA/calico-rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/L-MA/calico-rkt/downloads","issues_url":"https://api.github.com/repos/L-MA/calico-rkt/issues{/number}","pulls_url":"https://api.github.com/repos/L-MA/calico-rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/L-MA/calico-rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/L-MA/calico-rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/L-MA/calico-rkt/labels{/name}","releases_url":"https://api.github.com/repos/L-MA/calico-rkt/releases{/id}","created_at":"2015-10-13T21:07:45Z","updated_at":"2015-10-13T21:07:45Z","pushed_at":"2015-12-11T23:07:41Z","git_url":"git://github.com/L-MA/calico-rkt.git","ssh_url":"git@github.com:L-MA/calico-rkt.git","clone_url":"https://github.com/L-MA/calico-rkt.git","svn_url":"https://github.com/L-MA/calico-rkt","homepage":"http://www.projectcalico.org/","size":68,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"L-MA:ipam","ref":"ipam","sha":"debd3d18fc03f904eb468646a2be04e1040a0e3b","user":{"login":"L-MA","id":9704719,"avatar_url":"https://avatars.githubusercontent.com/u/9704719?v=3","gravatar_id":"","url":"https://api.github.com/users/L-MA","html_url":"https://github.com/L-MA","followers_url":"https://api.github.com/users/L-MA/followers","following_url":"https://api.github.com/users/L-MA/following{/other_user}","gists_url":"https://api.github.com/users/L-MA/gists{/gist_id}","starred_url":"https://api.github.com/users/L-MA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-MA/subscriptions","organizations_url":"https://api.github.com/users/L-MA/orgs","repos_url":"https://api.github.com/users/L-MA/repos","events_url":"https://api.github.com/users/L-MA/events{/privacy}","received_events_url":"https://api.github.com/users/L-MA/received_events","type":"User","site_admin":false},"repo":{"id":44204927,"name":"calico-rkt","full_name":"L-MA/calico-rkt","owner":{"login":"L-MA","id":9704719,"avatar_url":"https://avatars.githubusercontent.com/u/9704719?v=3","gravatar_id":"","url":"https://api.github.com/users/L-MA","html_url":"https://github.com/L-MA","followers_url":"https://api.github.com/users/L-MA/followers","following_url":"https://api.github.com/users/L-MA/following{/other_user}","gists_url":"https://api.github.com/users/L-MA/gists{/gist_id}","starred_url":"https://api.github.com/users/L-MA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-MA/subscriptions","organizations_url":"https://api.github.com/users/L-MA/orgs","repos_url":"https://api.github.com/users/L-MA/repos","events_url":"https://api.github.com/users/L-MA/events{/privacy}","received_events_url":"https://api.github.com/users/L-MA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/L-MA/calico-rkt","description":"Calico plugin for rkt deployments","fork":true,"url":"https://api.github.com/repos/L-MA/calico-rkt","forks_url":"https://api.github.com/repos/L-MA/calico-rkt/forks","keys_url":"https://api.github.com/repos/L-MA/calico-rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/L-MA/calico-rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/L-MA/calico-rkt/teams","hooks_url":"https://api.github.com/repos/L-MA/calico-rkt/hooks","issue_events_url":"https://api.github.com/repos/L-MA/calico-rkt/issues/events{/number}","events_url":"https://api.github.com/repos/L-MA/calico-rkt/events","assignees_url":"https://api.github.com/repos/L-MA/calico-rkt/assignees{/user}","branches_url":"https://api.github.com/repos/L-MA/calico-rkt/branches{/branch}","tags_url":"https://api.github.com/repos/L-MA/calico-rkt/tags","blobs_url":"https://api.github.com/repos/L-MA/calico-rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/L-MA/calico-rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/L-MA/calico-rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/L-MA/calico-rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/L-MA/calico-rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/L-MA/calico-rkt/languages","stargazers_url":"https://api.github.com/repos/L-MA/calico-rkt/stargazers","contributors_url":"https://api.github.com/repos/L-MA/calico-rkt/contributors","subscribers_url":"https://api.github.com/repos/L-MA/calico-rkt/subscribers","subscription_url":"https://api.github.com/repos/L-MA/calico-rkt/subscription","commits_url":"https://api.github.com/repos/L-MA/calico-rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/L-MA/calico-rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/L-MA/calico-rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/L-MA/calico-rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/L-MA/calico-rkt/contents/{+path}","compare_url":"https://api.github.com/repos/L-MA/calico-rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/L-MA/calico-rkt/merges","archive_url":"https://api.github.com/repos/L-MA/calico-rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/L-MA/calico-rkt/downloads","issues_url":"https://api.github.com/repos/L-MA/calico-rkt/issues{/number}","pulls_url":"https://api.github.com/repos/L-MA/calico-rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/L-MA/calico-rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/L-MA/calico-rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/L-MA/calico-rkt/labels{/name}","releases_url":"https://api.github.com/repos/L-MA/calico-rkt/releases{/id}","created_at":"2015-10-13T21:07:45Z","updated_at":"2015-10-13T21:07:45Z","pushed_at":"2015-12-11T23:07:41Z","git_url":"git://github.com/L-MA/calico-rkt.git","ssh_url":"git@github.com:L-MA/calico-rkt.git","clone_url":"https://github.com/L-MA/calico-rkt.git","svn_url":"https://github.com/L-MA/calico-rkt","homepage":"http://www.projectcalico.org/","size":68,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/L-MA/calico-rkt/pulls/1"},"html":{"href":"https://github.com/L-MA/calico-rkt/pull/1"},"issue":{"href":"https://api.github.com/repos/L-MA/calico-rkt/issues/1"},"comments":{"href":"https://api.github.com/repos/L-MA/calico-rkt/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/L-MA/calico-rkt/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/L-MA/calico-rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/L-MA/calico-rkt/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/L-MA/calico-rkt/statuses/2aaa9b53fa7b4fb6681c577cdf31450cfc732d40"}}}}