{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/41211994","id":41211994,"diff_hunk":"@@ -1,5 +1,5 @@\n <span ng-model=\"$parent.$parent.$parent.$parent.localValue\" ui-validate=\"'validate($value)'\">\n-  <span ng-if=\"availableParamNames.length === 0\">\n+  <span style=\"color:red\" ng-if=\"availableParamNames.length === 0\">","path":"extensions/objects/templates/parameter_name_editor.html","position":3,"original_position":3,"commit_id":"533d2e46710149b0349d36737fbd3370ef7df684","original_commit_id":"533d2e46710149b0349d36737fbd3370ef7df684","user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"body":"nit: add space after :","created_at":"2015-10-05T23:45:14Z","updated_at":"2015-10-05T23:45:14Z","html_url":"https://github.com/oppia/oppia/pull/993#discussion_r41211994","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/993","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/41211994"},"html":{"href":"https://github.com/oppia/oppia/pull/993#discussion_r41211994"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/993"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/993","id":46122907,"html_url":"https://github.com/oppia/oppia/pull/993","diff_url":"https://github.com/oppia/oppia/pull/993.diff","patch_url":"https://github.com/oppia/oppia/pull/993.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/993","number":993,"state":"open","locked":false,"title":"Initial work on gadget-ui updates. Gadgets can be added and managed v…","user":{"login":"anuzis","id":1622682,"avatar_url":"https://avatars.githubusercontent.com/u/1622682?v=3","gravatar_id":"","url":"https://api.github.com/users/anuzis","html_url":"https://github.com/anuzis","followers_url":"https://api.github.com/users/anuzis/followers","following_url":"https://api.github.com/users/anuzis/following{/other_user}","gists_url":"https://api.github.com/users/anuzis/gists{/gist_id}","starred_url":"https://api.github.com/users/anuzis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuzis/subscriptions","organizations_url":"https://api.github.com/users/anuzis/orgs","repos_url":"https://api.github.com/users/anuzis/repos","events_url":"https://api.github.com/users/anuzis/events{/privacy}","received_events_url":"https://api.github.com/users/anuzis/received_events","type":"User","site_admin":false},"body":"Initial work on gadget-ui updates. Gadgets can be added and managed via a new single pane on the right. All BE and FE tests pass. Integration tests are in progress, pending final UI tweaks from review.\r\n\r\n@seanlip : Is this close to the approach you had in mind? I tried to remove specifying panelName from many front-end areas where it should now be hard-coded, while preserving much of the back-end logic that seems likely to remain useful in future iterations.\r\n\r\nIn terms of UI, if we have a contextService similar to what we discussed before that would allow the ScoreBar to see if it's in Editor-Edit mode as opposed to Player mode, we could use that to preserve most of the dynamic rendering of gadgets within the preview on the right. Alternatively, we might ultimately want to shift to thumbnail icons in any case since larger gadgets like coding consoles won't fit well in a preview regardless of customization args.\r\n\r\nI'm also expecting we want to do some fine tuning on the CSS that contains this preview (for example, changing the green bar to a softer color). If this implementation is in line with what you expect, I'll take it the rest of the way with integration tests and give it to you and Amit for any final CSS tweaks.","created_at":"2015-09-28T06:08:20Z","updated_at":"2015-10-05T23:45:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"710bfef901afbcf9b595fb9a462c8c8839f65c16","assignee":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/993/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/993/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/993/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/533d2e46710149b0349d36737fbd3370ef7df684","head":{"label":"anuzis:gadgets-ui","ref":"gadgets-ui","sha":"533d2e46710149b0349d36737fbd3370ef7df684","user":{"login":"anuzis","id":1622682,"avatar_url":"https://avatars.githubusercontent.com/u/1622682?v=3","gravatar_id":"","url":"https://api.github.com/users/anuzis","html_url":"https://github.com/anuzis","followers_url":"https://api.github.com/users/anuzis/followers","following_url":"https://api.github.com/users/anuzis/following{/other_user}","gists_url":"https://api.github.com/users/anuzis/gists{/gist_id}","starred_url":"https://api.github.com/users/anuzis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuzis/subscriptions","organizations_url":"https://api.github.com/users/anuzis/orgs","repos_url":"https://api.github.com/users/anuzis/repos","events_url":"https://api.github.com/users/anuzis/events{/privacy}","received_events_url":"https://api.github.com/users/anuzis/received_events","type":"User","site_admin":false},"repo":{"id":42024376,"name":"oppia","full_name":"anuzis/oppia","owner":{"login":"anuzis","id":1622682,"avatar_url":"https://avatars.githubusercontent.com/u/1622682?v=3","gravatar_id":"","url":"https://api.github.com/users/anuzis","html_url":"https://github.com/anuzis","followers_url":"https://api.github.com/users/anuzis/followers","following_url":"https://api.github.com/users/anuzis/following{/other_user}","gists_url":"https://api.github.com/users/anuzis/gists{/gist_id}","starred_url":"https://api.github.com/users/anuzis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuzis/subscriptions","organizations_url":"https://api.github.com/users/anuzis/orgs","repos_url":"https://api.github.com/users/anuzis/repos","events_url":"https://api.github.com/users/anuzis/events{/privacy}","received_events_url":"https://api.github.com/users/anuzis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anuzis/oppia","description":"Tool for creating interactive tutors.","fork":true,"url":"https://api.github.com/repos/anuzis/oppia","forks_url":"https://api.github.com/repos/anuzis/oppia/forks","keys_url":"https://api.github.com/repos/anuzis/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anuzis/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anuzis/oppia/teams","hooks_url":"https://api.github.com/repos/anuzis/oppia/hooks","issue_events_url":"https://api.github.com/repos/anuzis/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/anuzis/oppia/events","assignees_url":"https://api.github.com/repos/anuzis/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/anuzis/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/anuzis/oppia/tags","blobs_url":"https://api.github.com/repos/anuzis/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anuzis/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anuzis/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/anuzis/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anuzis/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/anuzis/oppia/languages","stargazers_url":"https://api.github.com/repos/anuzis/oppia/stargazers","contributors_url":"https://api.github.com/repos/anuzis/oppia/contributors","subscribers_url":"https://api.github.com/repos/anuzis/oppia/subscribers","subscription_url":"https://api.github.com/repos/anuzis/oppia/subscription","commits_url":"https://api.github.com/repos/anuzis/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/anuzis/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/anuzis/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/anuzis/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/anuzis/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/anuzis/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anuzis/oppia/merges","archive_url":"https://api.github.com/repos/anuzis/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anuzis/oppia/downloads","issues_url":"https://api.github.com/repos/anuzis/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/anuzis/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/anuzis/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/anuzis/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anuzis/oppia/labels{/name}","releases_url":"https://api.github.com/repos/anuzis/oppia/releases{/id}","created_at":"2015-09-07T01:02:26Z","updated_at":"2015-09-07T01:02:28Z","pushed_at":"2015-10-05T18:40:08Z","git_url":"git://github.com/anuzis/oppia.git","ssh_url":"git@github.com:anuzis/oppia.git","clone_url":"https://github.com/anuzis/oppia.git","svn_url":"https://github.com/anuzis/oppia","homepage":"https://www.oppia.org","size":37256,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:gadgets","ref":"gadgets","sha":"1c8451afb6ac182c22f60dd317d5e183e9188c6d","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive tutors.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","created_at":"2015-08-14T00:16:14Z","updated_at":"2015-10-03T22:14:51Z","pushed_at":"2015-10-05T22:38:11Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":43656,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":176,"forks":51,"open_issues":176,"watchers":42,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/993"},"html":{"href":"https://github.com/oppia/oppia/pull/993"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/993"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/993/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/993/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/993/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/533d2e46710149b0349d36737fbd3370ef7df684"}}}}