{"action":"created","issue":{"url":"https://api.github.com/repos/purescript/purescript/issues/1752","labels_url":"https://api.github.com/repos/purescript/purescript/issues/1752/labels{/name}","comments_url":"https://api.github.com/repos/purescript/purescript/issues/1752/comments","events_url":"https://api.github.com/repos/purescript/purescript/issues/1752/events","html_url":"https://github.com/purescript/purescript/pull/1752","id":123307804,"number":1752,"title":"allow git@github.com in extractGithub. Fixes #1549","user":{"login":"codedmart","id":40686,"avatar_url":"https://avatars.githubusercontent.com/u/40686?v=3","gravatar_id":"","url":"https://api.github.com/users/codedmart","html_url":"https://github.com/codedmart","followers_url":"https://api.github.com/users/codedmart/followers","following_url":"https://api.github.com/users/codedmart/following{/other_user}","gists_url":"https://api.github.com/users/codedmart/gists{/gist_id}","starred_url":"https://api.github.com/users/codedmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codedmart/subscriptions","organizations_url":"https://api.github.com/users/codedmart/orgs","repos_url":"https://api.github.com/users/codedmart/repos","events_url":"https://api.github.com/users/codedmart/events{/privacy}","received_events_url":"https://api.github.com/users/codedmart/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-12-21T16:13:10Z","updated_at":"2015-12-22T19:55:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/purescript/purescript/pulls/1752","html_url":"https://github.com/purescript/purescript/pull/1752","diff_url":"https://github.com/purescript/purescript/pull/1752.diff","patch_url":"https://github.com/purescript/purescript/pull/1752.patch"},"body":"Didn't see anywhere that the url is tested. Please let me know if I missed anything. Just starting to look around the codebase."},"comment":{"url":"https://api.github.com/repos/purescript/purescript/issues/comments/166715282","html_url":"https://github.com/purescript/purescript/pull/1752#issuecomment-166715282","issue_url":"https://api.github.com/repos/purescript/purescript/issues/1752","id":166715282,"user":{"login":"hdgarrood","id":1270186,"avatar_url":"https://avatars.githubusercontent.com/u/1270186?v=3","gravatar_id":"","url":"https://api.github.com/users/hdgarrood","html_url":"https://github.com/hdgarrood","followers_url":"https://api.github.com/users/hdgarrood/followers","following_url":"https://api.github.com/users/hdgarrood/following{/other_user}","gists_url":"https://api.github.com/users/hdgarrood/gists{/gist_id}","starred_url":"https://api.github.com/users/hdgarrood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdgarrood/subscriptions","organizations_url":"https://api.github.com/users/hdgarrood/orgs","repos_url":"https://api.github.com/users/hdgarrood/repos","events_url":"https://api.github.com/users/hdgarrood/events{/privacy}","received_events_url":"https://api.github.com/users/hdgarrood/received_events","type":"User","site_admin":false},"created_at":"2015-12-22T19:55:49Z","updated_at":"2015-12-22T19:55:49Z","body":"Now that I've had a proper look at regex-applicative it doesn't look like too bad an option. When I said :-1: I was imagining a single regex that would extract the GitHub username and password through capturing groups.\r\n\r\nAnyway I still think sticking with the current approach is ok for now, but I could be persuaded otherwise. If we do stick with the current approach then i do think <|> would be better. Using isPrefixOf as well as stripPrefix in the same line is a code smell, I think."}}