{"action":"created","comment":{"url":"https://api.github.com/repos/randombit/botan/pulls/comments/40446712","id":40446712,"diff_hunk":"@@ -0,0 +1,17 @@\n+define ENTROPY_SRC_DARWIN_SECRANDOM 20150925\n+\n+<source>\n+darwin_secrandom.cpp\n+</source>\n+\n+<header:internal>\n+darwin_secrandom.h\n+</header:internal>\n+\n+<os>\n+darwin\n+</os>\n+\n+<frameworks>\n+darwin -> Security","path":"src/lib/entropy/darwin_secrandom/info.txt","position":16,"original_position":16,"commit_id":"ee0460cff538a3de7ca89fb54d37215757659a42","original_commit_id":"ee0460cff538a3de7ca89fb54d37215757659a42","user":{"login":"tiwoc","id":1260821,"avatar_url":"https://avatars.githubusercontent.com/u/1260821?v=3","gravatar_id":"","url":"https://api.github.com/users/tiwoc","html_url":"https://github.com/tiwoc","followers_url":"https://api.github.com/users/tiwoc/followers","following_url":"https://api.github.com/users/tiwoc/following{/other_user}","gists_url":"https://api.github.com/users/tiwoc/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwoc/subscriptions","organizations_url":"https://api.github.com/users/tiwoc/orgs","repos_url":"https://api.github.com/users/tiwoc/repos","events_url":"https://api.github.com/users/tiwoc/events{/privacy}","received_events_url":"https://api.github.com/users/tiwoc/received_events","type":"User","site_admin":false},"body":"Yes, it must be added. This is similar to what is necessary when linking to a regular library with `-l`. Therefore, `./botan config libs` now returns `-lbotan-1.1 -framework Security` on my system.","created_at":"2015-09-25T16:10:43Z","updated_at":"2015-09-25T16:10:43Z","html_url":"https://github.com/randombit/botan/pull/288#discussion_r40446712","pull_request_url":"https://api.github.com/repos/randombit/botan/pulls/288","_links":{"self":{"href":"https://api.github.com/repos/randombit/botan/pulls/comments/40446712"},"html":{"href":"https://github.com/randombit/botan/pull/288#discussion_r40446712"},"pull_request":{"href":"https://api.github.com/repos/randombit/botan/pulls/288"}}},"pull_request":{"url":"https://api.github.com/repos/randombit/botan/pulls/288","id":46006561,"html_url":"https://github.com/randombit/botan/pull/288","diff_url":"https://github.com/randombit/botan/pull/288.diff","patch_url":"https://github.com/randombit/botan/pull/288.patch","issue_url":"https://api.github.com/repos/randombit/botan/issues/288","number":288,"state":"open","locked":false,"title":"Add the Darwin_SecRandom entropy source","user":{"login":"tiwoc","id":1260821,"avatar_url":"https://avatars.githubusercontent.com/u/1260821?v=3","gravatar_id":"","url":"https://api.github.com/users/tiwoc","html_url":"https://github.com/tiwoc","followers_url":"https://api.github.com/users/tiwoc/followers","following_url":"https://api.github.com/users/tiwoc/following{/other_user}","gists_url":"https://api.github.com/users/tiwoc/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwoc/subscriptions","organizations_url":"https://api.github.com/users/tiwoc/orgs","repos_url":"https://api.github.com/users/tiwoc/repos","events_url":"https://api.github.com/users/tiwoc/events{/privacy}","received_events_url":"https://api.github.com/users/tiwoc/received_events","type":"User","site_admin":false},"body":"It uses the SecRandomCopyBytes function from the Security framework of OS X and iOS. We need this because it is the official way to get cryptographically secure random numbers on iOS, where /dev/random is not accessible due to sandboxing.\r\n\r\nTo get access to Security.framework, this PR also introduces framework support to the build system.","created_at":"2015-09-25T12:31:20Z","updated_at":"2015-09-25T16:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e5c46b44a253a6a10fa4c781cc19d43cdaeaebc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/randombit/botan/pulls/288/commits","review_comments_url":"https://api.github.com/repos/randombit/botan/pulls/288/comments","review_comment_url":"https://api.github.com/repos/randombit/botan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/randombit/botan/issues/288/comments","statuses_url":"https://api.github.com/repos/randombit/botan/statuses/ee0460cff538a3de7ca89fb54d37215757659a42","head":{"label":"tiwoc:darwin_secrandom","ref":"darwin_secrandom","sha":"ee0460cff538a3de7ca89fb54d37215757659a42","user":{"login":"tiwoc","id":1260821,"avatar_url":"https://avatars.githubusercontent.com/u/1260821?v=3","gravatar_id":"","url":"https://api.github.com/users/tiwoc","html_url":"https://github.com/tiwoc","followers_url":"https://api.github.com/users/tiwoc/followers","following_url":"https://api.github.com/users/tiwoc/following{/other_user}","gists_url":"https://api.github.com/users/tiwoc/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwoc/subscriptions","organizations_url":"https://api.github.com/users/tiwoc/orgs","repos_url":"https://api.github.com/users/tiwoc/repos","events_url":"https://api.github.com/users/tiwoc/events{/privacy}","received_events_url":"https://api.github.com/users/tiwoc/received_events","type":"User","site_admin":false},"repo":{"id":27933832,"name":"botan","full_name":"tiwoc/botan","owner":{"login":"tiwoc","id":1260821,"avatar_url":"https://avatars.githubusercontent.com/u/1260821?v=3","gravatar_id":"","url":"https://api.github.com/users/tiwoc","html_url":"https://github.com/tiwoc","followers_url":"https://api.github.com/users/tiwoc/followers","following_url":"https://api.github.com/users/tiwoc/following{/other_user}","gists_url":"https://api.github.com/users/tiwoc/gists{/gist_id}","starred_url":"https://api.github.com/users/tiwoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiwoc/subscriptions","organizations_url":"https://api.github.com/users/tiwoc/orgs","repos_url":"https://api.github.com/users/tiwoc/repos","events_url":"https://api.github.com/users/tiwoc/events{/privacy}","received_events_url":"https://api.github.com/users/tiwoc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiwoc/botan","description":"Crypto and TLS for C++11","fork":true,"url":"https://api.github.com/repos/tiwoc/botan","forks_url":"https://api.github.com/repos/tiwoc/botan/forks","keys_url":"https://api.github.com/repos/tiwoc/botan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiwoc/botan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiwoc/botan/teams","hooks_url":"https://api.github.com/repos/tiwoc/botan/hooks","issue_events_url":"https://api.github.com/repos/tiwoc/botan/issues/events{/number}","events_url":"https://api.github.com/repos/tiwoc/botan/events","assignees_url":"https://api.github.com/repos/tiwoc/botan/assignees{/user}","branches_url":"https://api.github.com/repos/tiwoc/botan/branches{/branch}","tags_url":"https://api.github.com/repos/tiwoc/botan/tags","blobs_url":"https://api.github.com/repos/tiwoc/botan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiwoc/botan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiwoc/botan/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiwoc/botan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiwoc/botan/statuses/{sha}","languages_url":"https://api.github.com/repos/tiwoc/botan/languages","stargazers_url":"https://api.github.com/repos/tiwoc/botan/stargazers","contributors_url":"https://api.github.com/repos/tiwoc/botan/contributors","subscribers_url":"https://api.github.com/repos/tiwoc/botan/subscribers","subscription_url":"https://api.github.com/repos/tiwoc/botan/subscription","commits_url":"https://api.github.com/repos/tiwoc/botan/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiwoc/botan/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiwoc/botan/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiwoc/botan/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiwoc/botan/contents/{+path}","compare_url":"https://api.github.com/repos/tiwoc/botan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiwoc/botan/merges","archive_url":"https://api.github.com/repos/tiwoc/botan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiwoc/botan/downloads","issues_url":"https://api.github.com/repos/tiwoc/botan/issues{/number}","pulls_url":"https://api.github.com/repos/tiwoc/botan/pulls{/number}","milestones_url":"https://api.github.com/repos/tiwoc/botan/milestones{/number}","notifications_url":"https://api.github.com/repos/tiwoc/botan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiwoc/botan/labels{/name}","releases_url":"https://api.github.com/repos/tiwoc/botan/releases{/id}","created_at":"2014-12-12T19:00:10Z","updated_at":"2015-02-10T20:03:53Z","pushed_at":"2015-09-25T12:29:21Z","git_url":"git://github.com/tiwoc/botan.git","ssh_url":"git@github.com:tiwoc/botan.git","clone_url":"https://github.com/tiwoc/botan.git","svn_url":"https://github.com/tiwoc/botan","homepage":"http://botan.randombit.net","size":47466,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"randombit:master","ref":"master","sha":"49502d7508cd5445322187043af564cd2306990b","user":{"login":"randombit","id":469092,"avatar_url":"https://avatars.githubusercontent.com/u/469092?v=3","gravatar_id":"","url":"https://api.github.com/users/randombit","html_url":"https://github.com/randombit","followers_url":"https://api.github.com/users/randombit/followers","following_url":"https://api.github.com/users/randombit/following{/other_user}","gists_url":"https://api.github.com/users/randombit/gists{/gist_id}","starred_url":"https://api.github.com/users/randombit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randombit/subscriptions","organizations_url":"https://api.github.com/users/randombit/orgs","repos_url":"https://api.github.com/users/randombit/repos","events_url":"https://api.github.com/users/randombit/events{/privacy}","received_events_url":"https://api.github.com/users/randombit/received_events","type":"User","site_admin":false},"repo":{"id":8608254,"name":"botan","full_name":"randombit/botan","owner":{"login":"randombit","id":469092,"avatar_url":"https://avatars.githubusercontent.com/u/469092?v=3","gravatar_id":"","url":"https://api.github.com/users/randombit","html_url":"https://github.com/randombit","followers_url":"https://api.github.com/users/randombit/followers","following_url":"https://api.github.com/users/randombit/following{/other_user}","gists_url":"https://api.github.com/users/randombit/gists{/gist_id}","starred_url":"https://api.github.com/users/randombit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randombit/subscriptions","organizations_url":"https://api.github.com/users/randombit/orgs","repos_url":"https://api.github.com/users/randombit/repos","events_url":"https://api.github.com/users/randombit/events{/privacy}","received_events_url":"https://api.github.com/users/randombit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/randombit/botan","description":"Crypto and TLS for C++11","fork":false,"url":"https://api.github.com/repos/randombit/botan","forks_url":"https://api.github.com/repos/randombit/botan/forks","keys_url":"https://api.github.com/repos/randombit/botan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/randombit/botan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/randombit/botan/teams","hooks_url":"https://api.github.com/repos/randombit/botan/hooks","issue_events_url":"https://api.github.com/repos/randombit/botan/issues/events{/number}","events_url":"https://api.github.com/repos/randombit/botan/events","assignees_url":"https://api.github.com/repos/randombit/botan/assignees{/user}","branches_url":"https://api.github.com/repos/randombit/botan/branches{/branch}","tags_url":"https://api.github.com/repos/randombit/botan/tags","blobs_url":"https://api.github.com/repos/randombit/botan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/randombit/botan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/randombit/botan/git/refs{/sha}","trees_url":"https://api.github.com/repos/randombit/botan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/randombit/botan/statuses/{sha}","languages_url":"https://api.github.com/repos/randombit/botan/languages","stargazers_url":"https://api.github.com/repos/randombit/botan/stargazers","contributors_url":"https://api.github.com/repos/randombit/botan/contributors","subscribers_url":"https://api.github.com/repos/randombit/botan/subscribers","subscription_url":"https://api.github.com/repos/randombit/botan/subscription","commits_url":"https://api.github.com/repos/randombit/botan/commits{/sha}","git_commits_url":"https://api.github.com/repos/randombit/botan/git/commits{/sha}","comments_url":"https://api.github.com/repos/randombit/botan/comments{/number}","issue_comment_url":"https://api.github.com/repos/randombit/botan/issues/comments{/number}","contents_url":"https://api.github.com/repos/randombit/botan/contents/{+path}","compare_url":"https://api.github.com/repos/randombit/botan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/randombit/botan/merges","archive_url":"https://api.github.com/repos/randombit/botan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/randombit/botan/downloads","issues_url":"https://api.github.com/repos/randombit/botan/issues{/number}","pulls_url":"https://api.github.com/repos/randombit/botan/pulls{/number}","milestones_url":"https://api.github.com/repos/randombit/botan/milestones{/number}","notifications_url":"https://api.github.com/repos/randombit/botan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/randombit/botan/labels{/name}","releases_url":"https://api.github.com/repos/randombit/botan/releases{/id}","created_at":"2013-03-06T16:51:39Z","updated_at":"2015-09-25T09:51:10Z","pushed_at":"2015-09-25T12:31:20Z","git_url":"git://github.com/randombit/botan.git","ssh_url":"git@github.com:randombit/botan.git","clone_url":"https://github.com/randombit/botan.git","svn_url":"https://github.com/randombit/botan","homepage":"http://botan.randombit.net","size":61423,"stargazers_count":162,"watchers_count":162,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":33,"forks":47,"open_issues":33,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/randombit/botan/pulls/288"},"html":{"href":"https://github.com/randombit/botan/pull/288"},"issue":{"href":"https://api.github.com/repos/randombit/botan/issues/288"},"comments":{"href":"https://api.github.com/repos/randombit/botan/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/randombit/botan/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/randombit/botan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/randombit/botan/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/randombit/botan/statuses/ee0460cff538a3de7ca89fb54d37215757659a42"}}}}