{"action":"created","issue":{"url":"https://api.github.com/repos/nochowderforyou/clams/issues/155","labels_url":"https://api.github.com/repos/nochowderforyou/clams/issues/155/labels{/name}","comments_url":"https://api.github.com/repos/nochowderforyou/clams/issues/155/comments","events_url":"https://api.github.com/repos/nochowderforyou/clams/issues/155/events","html_url":"https://github.com/nochowderforyou/clams/issues/155","id":57252318,"number":155,"title":"v1.4.4 is a bandwidth hog - should we shun it?","user":{"login":"dooglus","id":573356,"avatar_url":"https://avatars.githubusercontent.com/u/573356?v=3","gravatar_id":"","url":"https://api.github.com/users/dooglus","html_url":"https://github.com/dooglus","followers_url":"https://api.github.com/users/dooglus/followers","following_url":"https://api.github.com/users/dooglus/following{/other_user}","gists_url":"https://api.github.com/users/dooglus/gists{/gist_id}","starred_url":"https://api.github.com/users/dooglus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dooglus/subscriptions","organizations_url":"https://api.github.com/users/dooglus/orgs","repos_url":"https://api.github.com/users/dooglus/repos","events_url":"https://api.github.com/users/dooglus/events{/privacy}","received_events_url":"https://api.github.com/users/dooglus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-10T23:07:31Z","updated_at":"2015-02-11T07:11:11Z","closed_at":null,"body":"Due to issue #133, v1.4.4 often finds itself stuck at an old block in the chain, and keeps requesting the same block over and over from its peers, which they keep sending it.\r\n\r\nThis is quite a resource drain on any peer connected to a stuck v1.4.4 peer.\r\n\r\nI propose we add code to drop connections from peers claiming to be v1.4.4.\r\n\r\nUnfortunately, v1.4.5 incorrectly identifies itself as v1.4.4, so we would be dropping connections from that version too.\r\n\r\nAnyone experiencing trouble connecting just needs to upgrade to v1.4.7 or later.\r\n\r\nWhat do we think? Is this reasonable?\r\n\r\nSomething like this would do the trick:\r\n\r\n    diff --git a/src/main.cpp b/src/main.cpp\r\n    index d4c83ea..2fd8450 100644\r\n    --- a/src/main.cpp\r\n    +++ b/src/main.cpp\r\n    @@ -3165,6 +3165,14 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv,\r\n             if (!vRecv.empty())\r\n                 vRecv >> pfrom->nStartingHeight;\r\n     \r\n    +        if (pfrom->strSubVer == \"/Satoshi:1.4.4/\")\r\n    +        {\r\n    +            // disconnect from peers running v1.4.4 because it repeatedly requests the same block\r\n    +            LogPrintf(\"disconnecting %s\\n\", pfrom->strSubVer);\r\n    +            pfrom->fDisconnect = true;\r\n    +            return false;\r\n    +        }\r\n    +\r\n             pfrom->addrLocal = addrMe;\r\n             if (pfrom->fInbound && addrMe.IsRoutable())\r\n                 SeenLocal(addrMe);\r\n"},"comment":{"url":"https://api.github.com/repos/nochowderforyou/clams/issues/comments/73841573","html_url":"https://github.com/nochowderforyou/clams/issues/155#issuecomment-73841573","issue_url":"https://api.github.com/repos/nochowderforyou/clams/issues/155","id":73841573,"user":{"login":"creativecuriosity","id":5631416,"avatar_url":"https://avatars.githubusercontent.com/u/5631416?v=3","gravatar_id":"","url":"https://api.github.com/users/creativecuriosity","html_url":"https://github.com/creativecuriosity","followers_url":"https://api.github.com/users/creativecuriosity/followers","following_url":"https://api.github.com/users/creativecuriosity/following{/other_user}","gists_url":"https://api.github.com/users/creativecuriosity/gists{/gist_id}","starred_url":"https://api.github.com/users/creativecuriosity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creativecuriosity/subscriptions","organizations_url":"https://api.github.com/users/creativecuriosity/orgs","repos_url":"https://api.github.com/users/creativecuriosity/repos","events_url":"https://api.github.com/users/creativecuriosity/events{/privacy}","received_events_url":"https://api.github.com/users/creativecuriosity/received_events","type":"User","site_admin":false},"created_at":"2015-02-11T07:11:11Z","updated_at":"2015-02-11T07:11:11Z","body":"Was just thinking that this is sort of a self-inflicted DDoS attack in a way.  That it might be helpful in the long-perspective to identify behavior from peers that negatively affects the network; regardless of version."}}