{"action":"created","issue":{"url":"https://api.github.com/repos/CanalTP/navitia/issues/1309","labels_url":"https://api.github.com/repos/CanalTP/navitia/issues/1309/labels{/name}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/1309/comments","events_url":"https://api.github.com/repos/CanalTP/navitia/issues/1309/events","html_url":"https://github.com/CanalTP/navitia/pull/1309","id":119748894,"number":1309,"title":"kraken: fix journey pattern auto generation with multiple utc offset on vjs","user":{"login":"xavierraffin","id":1170030,"avatar_url":"https://avatars.githubusercontent.com/u/1170030?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierraffin","html_url":"https://github.com/xavierraffin","followers_url":"https://api.github.com/users/xavierraffin/followers","following_url":"https://api.github.com/users/xavierraffin/following{/other_user}","gists_url":"https://api.github.com/users/xavierraffin/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierraffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierraffin/subscriptions","organizations_url":"https://api.github.com/users/xavierraffin/orgs","repos_url":"https://api.github.com/users/xavierraffin/repos","events_url":"https://api.github.com/users/xavierraffin/events{/privacy}","received_events_url":"https://api.github.com/users/xavierraffin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-01T16:03:40Z","updated_at":"2015-12-02T16:17:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/1309","html_url":"https://github.com/CanalTP/navitia/pull/1309","diff_url":"https://github.com/CanalTP/navitia/pull/1309.diff","patch_url":"https://github.com/CanalTP/navitia/pull/1309.patch"},"body":"I push this without test because I would like be sure that you won't fix the same issue at the same time.\r\nUnit tests will follow if you don't already solve it yourself.\r\n\r\n__So please tell me if you are already working on it or if I could continue__\r\n\r\nThe issue is quite simple to understand.\r\n\r\nWhen there is different time offset on vehicule journey on a unique route, the journey pattern auto generation (overtake function) is wrong because it compares times off different offset.\r\n\r\nImagine you have a VJ starting at 15h with an offset of 3600 and a VJ starting at 16h with a 7200 offset (with different speeds).\r\nThen overtake function will detect an overtake and create a journey pattern.\r\n\r\nThis additionnal JP creates very bad things in services like route_schedules."},"comment":{"url":"https://api.github.com/repos/CanalTP/navitia/issues/comments/161350372","html_url":"https://github.com/CanalTP/navitia/pull/1309#issuecomment-161350372","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/1309","id":161350372,"user":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T16:17:21Z","updated_at":"2015-12-02T16:17:21Z","body":"By construction, this is not a bug as 2 vj on different timezone will not have their validity patterns that overlap (and thus can't overtake). But I suspect your problem is on calendar route schedule...\r\n\r\nYour fix will not do the job as the validity patterns will not overlap, and thus, the overtake test will not be done https://github.com/CanalTP/navitia/blob/0566c4339e71373e1874b5948bd26045109b1527/source/routing/journey_pattern_container.cpp#L143\r\n\r\nIn another hand, we can't remove this test as it may increase the number of journey patterns, which is bad for performances.\r\n\r\nI don't know how to fix that."}}