{"action":"created","comment":{"url":"https://api.github.com/repos/twbs/ratchet/pulls/comments/28760937","id":28760937,"diff_hunk":"@@ -32,8 +32,21 @@\n \n   var getModal = function (event) {\n     var modalToggle = findModals(event.target);\n-    if (modalToggle && modalToggle.hash) {\n-      return document.querySelector(modalToggle.hash);\n+    if (modalToggle) {\n+      var modalSelector = modalToggle.getAttribute('data-modal');\n+      if (modalSelector) {\n+        return document.querySelector(modalSelector);\n+      }\n+      if (modalToggle.hash) {","path":"js/modals.js","position":null,"original_position":11,"commit_id":"85de75ebb396a66dbe065fd4e63c07b8d91f6198","original_commit_id":"4a41bb0afec0e79d4dcb723c70f44c9dd6360cd3","user":{"login":"juriejan","id":85799,"avatar_url":"https://avatars.githubusercontent.com/u/85799?v=3","gravatar_id":"","url":"https://api.github.com/users/juriejan","html_url":"https://github.com/juriejan","followers_url":"https://api.github.com/users/juriejan/followers","following_url":"https://api.github.com/users/juriejan/following{/other_user}","gists_url":"https://api.github.com/users/juriejan/gists{/gist_id}","starred_url":"https://api.github.com/users/juriejan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juriejan/subscriptions","organizations_url":"https://api.github.com/users/juriejan/orgs","repos_url":"https://api.github.com/users/juriejan/repos","events_url":"https://api.github.com/users/juriejan/events{/privacy}","received_events_url":"https://api.github.com/users/juriejan/received_events","type":"User","site_admin":false},"body":"I've just added the 'else if' where I though you meant to have it.","created_at":"2015-04-21T09:04:22Z","updated_at":"2015-04-21T09:04:22Z","html_url":"https://github.com/twbs/ratchet/pull/730#discussion_r28760937","pull_request_url":"https://api.github.com/repos/twbs/ratchet/pulls/730","_links":{"self":{"href":"https://api.github.com/repos/twbs/ratchet/pulls/comments/28760937"},"html":{"href":"https://github.com/twbs/ratchet/pull/730#discussion_r28760937"},"pull_request":{"href":"https://api.github.com/repos/twbs/ratchet/pulls/730"}}},"pull_request":{"url":"https://api.github.com/repos/twbs/ratchet/pulls/730","id":26593858,"html_url":"https://github.com/twbs/ratchet/pull/730","diff_url":"https://github.com/twbs/ratchet/pull/730.diff","patch_url":"https://github.com/twbs/ratchet/pull/730.patch","issue_url":"https://api.github.com/repos/twbs/ratchet/issues/730","number":730,"state":"open","locked":false,"title":"Specify modal selector in data attribute","user":{"login":"juriejan","id":85799,"avatar_url":"https://avatars.githubusercontent.com/u/85799?v=3","gravatar_id":"","url":"https://api.github.com/users/juriejan","html_url":"https://github.com/juriejan","followers_url":"https://api.github.com/users/juriejan/followers","following_url":"https://api.github.com/users/juriejan/following{/other_user}","gists_url":"https://api.github.com/users/juriejan/gists{/gist_id}","starred_url":"https://api.github.com/users/juriejan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juriejan/subscriptions","organizations_url":"https://api.github.com/users/juriejan/orgs","repos_url":"https://api.github.com/users/juriejan/repos","events_url":"https://api.github.com/users/juriejan/events{/privacy}","received_events_url":"https://api.github.com/users/juriejan/received_events","type":"User","site_admin":false},"body":"Fixes #682.\r\n\r\nInstead of hijacking the `href` attribute of an anchor tag to indicate a selector of a modal that we'd like to display on it being clicked. We can rather make use of a `data-modal` attribute to indicate the selector of the desired modal.","created_at":"2014-12-26T08:23:16Z","updated_at":"2015-04-21T09:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff9f56e087307de5426cb785498db3de70212f93","assignee":null,"milestone":{"url":"https://api.github.com/repos/twbs/ratchet/milestones/2","html_url":"https://github.com/twbs/ratchet/milestones/2.1.0","labels_url":"https://api.github.com/repos/twbs/ratchet/milestones/2/labels","id":573459,"number":2,"title":"2.1.0","description":"","creator":{"login":"connors","id":874145,"avatar_url":"https://avatars.githubusercontent.com/u/874145?v=3","gravatar_id":"","url":"https://api.github.com/users/connors","html_url":"https://github.com/connors","followers_url":"https://api.github.com/users/connors/followers","following_url":"https://api.github.com/users/connors/following{/other_user}","gists_url":"https://api.github.com/users/connors/gists{/gist_id}","starred_url":"https://api.github.com/users/connors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connors/subscriptions","organizations_url":"https://api.github.com/users/connors/orgs","repos_url":"https://api.github.com/users/connors/repos","events_url":"https://api.github.com/users/connors/events{/privacy}","received_events_url":"https://api.github.com/users/connors/received_events","type":"User","site_admin":true},"open_issues":23,"closed_issues":37,"state":"open","created_at":"2014-02-18T21:01:46Z","updated_at":"2015-03-31T22:58:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/twbs/ratchet/pulls/730/commits","review_comments_url":"https://api.github.com/repos/twbs/ratchet/pulls/730/comments","review_comment_url":"https://api.github.com/repos/twbs/ratchet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twbs/ratchet/issues/730/comments","statuses_url":"https://api.github.com/repos/twbs/ratchet/statuses/85de75ebb396a66dbe065fd4e63c07b8d91f6198","head":{"label":"juriejan:modal-selector-attribute","ref":"modal-selector-attribute","sha":"85de75ebb396a66dbe065fd4e63c07b8d91f6198","user":{"login":"juriejan","id":85799,"avatar_url":"https://avatars.githubusercontent.com/u/85799?v=3","gravatar_id":"","url":"https://api.github.com/users/juriejan","html_url":"https://github.com/juriejan","followers_url":"https://api.github.com/users/juriejan/followers","following_url":"https://api.github.com/users/juriejan/following{/other_user}","gists_url":"https://api.github.com/users/juriejan/gists{/gist_id}","starred_url":"https://api.github.com/users/juriejan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juriejan/subscriptions","organizations_url":"https://api.github.com/users/juriejan/orgs","repos_url":"https://api.github.com/users/juriejan/repos","events_url":"https://api.github.com/users/juriejan/events{/privacy}","received_events_url":"https://api.github.com/users/juriejan/received_events","type":"User","site_admin":false},"repo":{"id":28503867,"name":"ratchet","full_name":"juriejan/ratchet","owner":{"login":"juriejan","id":85799,"avatar_url":"https://avatars.githubusercontent.com/u/85799?v=3","gravatar_id":"","url":"https://api.github.com/users/juriejan","html_url":"https://github.com/juriejan","followers_url":"https://api.github.com/users/juriejan/followers","following_url":"https://api.github.com/users/juriejan/following{/other_user}","gists_url":"https://api.github.com/users/juriejan/gists{/gist_id}","starred_url":"https://api.github.com/users/juriejan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juriejan/subscriptions","organizations_url":"https://api.github.com/users/juriejan/orgs","repos_url":"https://api.github.com/users/juriejan/repos","events_url":"https://api.github.com/users/juriejan/events{/privacy}","received_events_url":"https://api.github.com/users/juriejan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juriejan/ratchet","description":"Build mobile apps with simple HTML, CSS, and JS components. ","fork":true,"url":"https://api.github.com/repos/juriejan/ratchet","forks_url":"https://api.github.com/repos/juriejan/ratchet/forks","keys_url":"https://api.github.com/repos/juriejan/ratchet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juriejan/ratchet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juriejan/ratchet/teams","hooks_url":"https://api.github.com/repos/juriejan/ratchet/hooks","issue_events_url":"https://api.github.com/repos/juriejan/ratchet/issues/events{/number}","events_url":"https://api.github.com/repos/juriejan/ratchet/events","assignees_url":"https://api.github.com/repos/juriejan/ratchet/assignees{/user}","branches_url":"https://api.github.com/repos/juriejan/ratchet/branches{/branch}","tags_url":"https://api.github.com/repos/juriejan/ratchet/tags","blobs_url":"https://api.github.com/repos/juriejan/ratchet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juriejan/ratchet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juriejan/ratchet/git/refs{/sha}","trees_url":"https://api.github.com/repos/juriejan/ratchet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juriejan/ratchet/statuses/{sha}","languages_url":"https://api.github.com/repos/juriejan/ratchet/languages","stargazers_url":"https://api.github.com/repos/juriejan/ratchet/stargazers","contributors_url":"https://api.github.com/repos/juriejan/ratchet/contributors","subscribers_url":"https://api.github.com/repos/juriejan/ratchet/subscribers","subscription_url":"https://api.github.com/repos/juriejan/ratchet/subscription","commits_url":"https://api.github.com/repos/juriejan/ratchet/commits{/sha}","git_commits_url":"https://api.github.com/repos/juriejan/ratchet/git/commits{/sha}","comments_url":"https://api.github.com/repos/juriejan/ratchet/comments{/number}","issue_comment_url":"https://api.github.com/repos/juriejan/ratchet/issues/comments{/number}","contents_url":"https://api.github.com/repos/juriejan/ratchet/contents/{+path}","compare_url":"https://api.github.com/repos/juriejan/ratchet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juriejan/ratchet/merges","archive_url":"https://api.github.com/repos/juriejan/ratchet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juriejan/ratchet/downloads","issues_url":"https://api.github.com/repos/juriejan/ratchet/issues{/number}","pulls_url":"https://api.github.com/repos/juriejan/ratchet/pulls{/number}","milestones_url":"https://api.github.com/repos/juriejan/ratchet/milestones{/number}","notifications_url":"https://api.github.com/repos/juriejan/ratchet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juriejan/ratchet/labels{/name}","releases_url":"https://api.github.com/repos/juriejan/ratchet/releases{/id}","created_at":"2014-12-26T07:40:24Z","updated_at":"2015-04-08T12:49:38Z","pushed_at":"2015-04-21T09:03:58Z","git_url":"git://github.com/juriejan/ratchet.git","ssh_url":"git@github.com:juriejan/ratchet.git","clone_url":"https://github.com/juriejan/ratchet.git","svn_url":"https://github.com/juriejan/ratchet","homepage":"http://goratchet.com","size":14590,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twbs:master","ref":"master","sha":"e0ade9b118d270e7e4499e39a5bf9ca991f5bd9c","user":{"login":"twbs","id":2918581,"avatar_url":"https://avatars.githubusercontent.com/u/2918581?v=3","gravatar_id":"","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"repo":{"id":5448530,"name":"ratchet","full_name":"twbs/ratchet","owner":{"login":"twbs","id":2918581,"avatar_url":"https://avatars.githubusercontent.com/u/2918581?v=3","gravatar_id":"","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twbs/ratchet","description":"Build mobile apps with simple HTML, CSS, and JavaScript components. ","fork":false,"url":"https://api.github.com/repos/twbs/ratchet","forks_url":"https://api.github.com/repos/twbs/ratchet/forks","keys_url":"https://api.github.com/repos/twbs/ratchet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twbs/ratchet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twbs/ratchet/teams","hooks_url":"https://api.github.com/repos/twbs/ratchet/hooks","issue_events_url":"https://api.github.com/repos/twbs/ratchet/issues/events{/number}","events_url":"https://api.github.com/repos/twbs/ratchet/events","assignees_url":"https://api.github.com/repos/twbs/ratchet/assignees{/user}","branches_url":"https://api.github.com/repos/twbs/ratchet/branches{/branch}","tags_url":"https://api.github.com/repos/twbs/ratchet/tags","blobs_url":"https://api.github.com/repos/twbs/ratchet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twbs/ratchet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twbs/ratchet/git/refs{/sha}","trees_url":"https://api.github.com/repos/twbs/ratchet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twbs/ratchet/statuses/{sha}","languages_url":"https://api.github.com/repos/twbs/ratchet/languages","stargazers_url":"https://api.github.com/repos/twbs/ratchet/stargazers","contributors_url":"https://api.github.com/repos/twbs/ratchet/contributors","subscribers_url":"https://api.github.com/repos/twbs/ratchet/subscribers","subscription_url":"https://api.github.com/repos/twbs/ratchet/subscription","commits_url":"https://api.github.com/repos/twbs/ratchet/commits{/sha}","git_commits_url":"https://api.github.com/repos/twbs/ratchet/git/commits{/sha}","comments_url":"https://api.github.com/repos/twbs/ratchet/comments{/number}","issue_comment_url":"https://api.github.com/repos/twbs/ratchet/issues/comments{/number}","contents_url":"https://api.github.com/repos/twbs/ratchet/contents/{+path}","compare_url":"https://api.github.com/repos/twbs/ratchet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twbs/ratchet/merges","archive_url":"https://api.github.com/repos/twbs/ratchet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twbs/ratchet/downloads","issues_url":"https://api.github.com/repos/twbs/ratchet/issues{/number}","pulls_url":"https://api.github.com/repos/twbs/ratchet/pulls{/number}","milestones_url":"https://api.github.com/repos/twbs/ratchet/milestones{/number}","notifications_url":"https://api.github.com/repos/twbs/ratchet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twbs/ratchet/labels{/name}","releases_url":"https://api.github.com/repos/twbs/ratchet/releases{/id}","created_at":"2012-08-17T05:41:57Z","updated_at":"2015-04-21T07:45:23Z","pushed_at":"2015-04-21T09:03:59Z","git_url":"git://github.com/twbs/ratchet.git","ssh_url":"git@github.com:twbs/ratchet.git","clone_url":"https://github.com/twbs/ratchet.git","svn_url":"https://github.com/twbs/ratchet","homepage":"http://goratchet.com","size":19747,"stargazers_count":11108,"watchers_count":11108,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1209,"mirror_url":null,"open_issues_count":184,"forks":1209,"open_issues":184,"watchers":11108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twbs/ratchet/pulls/730"},"html":{"href":"https://github.com/twbs/ratchet/pull/730"},"issue":{"href":"https://api.github.com/repos/twbs/ratchet/issues/730"},"comments":{"href":"https://api.github.com/repos/twbs/ratchet/issues/730/comments"},"review_comments":{"href":"https://api.github.com/repos/twbs/ratchet/pulls/730/comments"},"review_comment":{"href":"https://api.github.com/repos/twbs/ratchet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twbs/ratchet/pulls/730/commits"},"statuses":{"href":"https://api.github.com/repos/twbs/ratchet/statuses/85de75ebb396a66dbe065fd4e63c07b8d91f6198"}}}}