{"action":"opened","issue":{"url":"https://api.github.com/repos/hedaiia/sw2_project/issues/7","labels_url":"https://api.github.com/repos/hedaiia/sw2_project/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/hedaiia/sw2_project/issues/7/comments","events_url":"https://api.github.com/repos/hedaiia/sw2_project/issues/7/events","html_url":"https://github.com/hedaiia/sw2_project/issues/7","id":72499042,"number":7,"title":"issue # 4","user":{"login":"Menna-allah-aly","id":11214667,"avatar_url":"https://avatars.githubusercontent.com/u/11214667?v=3","gravatar_id":"","url":"https://api.github.com/users/Menna-allah-aly","html_url":"https://github.com/Menna-allah-aly","followers_url":"https://api.github.com/users/Menna-allah-aly/followers","following_url":"https://api.github.com/users/Menna-allah-aly/following{/other_user}","gists_url":"https://api.github.com/users/Menna-allah-aly/gists{/gist_id}","starred_url":"https://api.github.com/users/Menna-allah-aly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Menna-allah-aly/subscriptions","organizations_url":"https://api.github.com/users/Menna-allah-aly/orgs","repos_url":"https://api.github.com/users/Menna-allah-aly/repos","events_url":"https://api.github.com/users/Menna-allah-aly/events{/privacy}","received_events_url":"https://api.github.com/users/Menna-allah-aly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-05-01T19:07:29Z","updated_at":"2015-05-01T19:07:29Z","closed_at":null,"body":"Service Package:\r\nDesign Principles \r\n1- The code doesn’t follow SOLID principals.                         Percentage (15%)\r\n2- The class follow object oriented programming (OOP)since the class has many functions ,many objects,  default and parameters constructor , many number of variables and the code contains many number of classes each of it has it’s functionality.                                 Percentage (50%)\r\n3-The code is simple and easy design but this design not followed in the code, they done class diagram only (30%)\r\nCoding Standards\r\n  1-The code understandable / readable (100%)\r\n2- The code has some of the  java documents  (80%)\r\n3-The code follows the indentation properly. (100%)\r\n4-The variable of the code has good names, since the name of each attribute indicate to the functionality of variable.  (100%)\r\n\r\nComments\r\n1-The comments isn’t enough since the comment in the code help the reader to understand the code (80%)\r\n2-some method in this class don’t commented (90%)\r\n 3-some method in this class don’t commented so the comments don’t follow Javadoc style (70%)\r\n     4-They added some new java documents on the old Javadoc which             generated in the code (70%)\r\n5-The code have some comments (70%)\r\n\r\nCode Structure\r\n1- the code doesn't follow the design precisely (10%)\r\n2-The class and the methods short and easy to read. (70%)\r\n3-There is no repeated code (100%)\r\n\r\nError Handling\r\n1-\tThe code doesn't handle all errors and exception in every method. (50%)\r\n2-\tThe code follows defensive programming used to avoid errors which founded in the code (35%).\r\n\r\nLogic\r\n1-There isn’t loops in this part. (0%)\r\n2-There isn’t loops (0%)\r\n\r\nOverall \r\nThe quality of the code isn't good (50%)\r\n"}}