{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/46218479","id":46218479,"diff_hunk":"@@ -40,6 +41,7 @@ QgsAttributeTableModel::QgsAttributeTableModel( QgsVectorLayerCache *layerCache,\n     , mLayerCache( layerCache )\n     , mFieldCount( 0 )\n     , mCachedField( -1 )\n+    , mLoadWorker( NULL )","path":"src/gui/attributetable/qgsattributetablemodel.cpp","position":12,"original_position":12,"commit_id":"12ad4252abfff52620374f26a9f852348860671a","original_commit_id":"12ad4252abfff52620374f26a9f852348860671a","user":{"login":"jef-n","id":238070,"avatar_url":"https://avatars.githubusercontent.com/u/238070?v=3","gravatar_id":"","url":"https://api.github.com/users/jef-n","html_url":"https://github.com/jef-n","followers_url":"https://api.github.com/users/jef-n/followers","following_url":"https://api.github.com/users/jef-n/following{/other_user}","gists_url":"https://api.github.com/users/jef-n/gists{/gist_id}","starred_url":"https://api.github.com/users/jef-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jef-n/subscriptions","organizations_url":"https://api.github.com/users/jef-n/orgs","repos_url":"https://api.github.com/users/jef-n/repos","events_url":"https://api.github.com/users/jef-n/events{/privacy}","received_events_url":"https://api.github.com/users/jef-n/received_events","type":"User","site_admin":false},"body":"No, that doesn't work on old compilers.   0 is fine.","created_at":"2015-11-30T23:10:20Z","updated_at":"2015-11-30T23:10:20Z","html_url":"https://github.com/qgis/QGIS/pull/2518#discussion_r46218479","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/2518","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/46218479"},"html":{"href":"https://github.com/qgis/QGIS/pull/2518#discussion_r46218479"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/2518"}}},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/2518","id":52143279,"html_url":"https://github.com/qgis/QGIS/pull/2518","diff_url":"https://github.com/qgis/QGIS/pull/2518.diff","patch_url":"https://github.com/qgis/QGIS/pull/2518.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/2518","number":2518,"state":"open","locked":false,"title":"QgsAttributeTableModel: Moved feature loader into its own thread","user":{"login":"elpaso","id":142164,"avatar_url":"https://avatars.githubusercontent.com/u/142164?v=3","gravatar_id":"","url":"https://api.github.com/users/elpaso","html_url":"https://github.com/elpaso","followers_url":"https://api.github.com/users/elpaso/followers","following_url":"https://api.github.com/users/elpaso/following{/other_user}","gists_url":"https://api.github.com/users/elpaso/gists{/gist_id}","starred_url":"https://api.github.com/users/elpaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elpaso/subscriptions","organizations_url":"https://api.github.com/users/elpaso/orgs","repos_url":"https://api.github.com/users/elpaso/repos","events_url":"https://api.github.com/users/elpaso/events{/privacy}","received_events_url":"https://api.github.com/users/elpaso/received_events","type":"User","site_admin":false},"body":"Attempt to fix #12926\r\n\r\nThis is an attempt to keep the GUI responsive while loading large datasets into the attribute table, it replaces the current QProgressDialog implementation by moving the loader in its own thread and adding a progress bar and abort button in the main dialog.\r\n\r\nThe original idea is from @jef-n that suggested me a threaded approach in Las Palmas.\r\n\r\nMy thread programming experience is close to 0 so the implementation might be buggy but according to my quick tests on 1^E6 tables, it behaves pretty well.\r\n\r\nComments welcome!\r\n\r\n![qgis_attrtable_worker](https://cloud.githubusercontent.com/assets/142164/11476781/e53c99aa-9784-11e5-837b-64264ae39585.png)\r\n\r\n","created_at":"2015-11-30T16:09:52Z","updated_at":"2015-11-30T23:10:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"659a62822d5e9e44f948941ce79bf4fc60502da4","assignee":{"login":"wonder-sk","id":193367,"avatar_url":"https://avatars.githubusercontent.com/u/193367?v=3","gravatar_id":"","url":"https://api.github.com/users/wonder-sk","html_url":"https://github.com/wonder-sk","followers_url":"https://api.github.com/users/wonder-sk/followers","following_url":"https://api.github.com/users/wonder-sk/following{/other_user}","gists_url":"https://api.github.com/users/wonder-sk/gists{/gist_id}","starred_url":"https://api.github.com/users/wonder-sk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wonder-sk/subscriptions","organizations_url":"https://api.github.com/users/wonder-sk/orgs","repos_url":"https://api.github.com/users/wonder-sk/repos","events_url":"https://api.github.com/users/wonder-sk/events{/privacy}","received_events_url":"https://api.github.com/users/wonder-sk/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/2518/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/2518/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/2518/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/12ad4252abfff52620374f26a9f852348860671a","head":{"label":"elpaso:bugfix-12926-attributetable-speedup","ref":"bugfix-12926-attributetable-speedup","sha":"12ad4252abfff52620374f26a9f852348860671a","user":{"login":"elpaso","id":142164,"avatar_url":"https://avatars.githubusercontent.com/u/142164?v=3","gravatar_id":"","url":"https://api.github.com/users/elpaso","html_url":"https://github.com/elpaso","followers_url":"https://api.github.com/users/elpaso/followers","following_url":"https://api.github.com/users/elpaso/following{/other_user}","gists_url":"https://api.github.com/users/elpaso/gists{/gist_id}","starred_url":"https://api.github.com/users/elpaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elpaso/subscriptions","organizations_url":"https://api.github.com/users/elpaso/orgs","repos_url":"https://api.github.com/users/elpaso/repos","events_url":"https://api.github.com/users/elpaso/events{/privacy}","received_events_url":"https://api.github.com/users/elpaso/received_events","type":"User","site_admin":false},"repo":{"id":15672089,"name":"QGIS","full_name":"elpaso/QGIS","owner":{"login":"elpaso","id":142164,"avatar_url":"https://avatars.githubusercontent.com/u/142164?v=3","gravatar_id":"","url":"https://api.github.com/users/elpaso","html_url":"https://github.com/elpaso","followers_url":"https://api.github.com/users/elpaso/followers","following_url":"https://api.github.com/users/elpaso/following{/other_user}","gists_url":"https://api.github.com/users/elpaso/gists{/gist_id}","starred_url":"https://api.github.com/users/elpaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elpaso/subscriptions","organizations_url":"https://api.github.com/users/elpaso/orgs","repos_url":"https://api.github.com/users/elpaso/repos","events_url":"https://api.github.com/users/elpaso/events{/privacy}","received_events_url":"https://api.github.com/users/elpaso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elpaso/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/elpaso/QGIS","forks_url":"https://api.github.com/repos/elpaso/QGIS/forks","keys_url":"https://api.github.com/repos/elpaso/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elpaso/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elpaso/QGIS/teams","hooks_url":"https://api.github.com/repos/elpaso/QGIS/hooks","issue_events_url":"https://api.github.com/repos/elpaso/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/elpaso/QGIS/events","assignees_url":"https://api.github.com/repos/elpaso/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/elpaso/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/elpaso/QGIS/tags","blobs_url":"https://api.github.com/repos/elpaso/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elpaso/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elpaso/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/elpaso/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elpaso/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/elpaso/QGIS/languages","stargazers_url":"https://api.github.com/repos/elpaso/QGIS/stargazers","contributors_url":"https://api.github.com/repos/elpaso/QGIS/contributors","subscribers_url":"https://api.github.com/repos/elpaso/QGIS/subscribers","subscription_url":"https://api.github.com/repos/elpaso/QGIS/subscription","commits_url":"https://api.github.com/repos/elpaso/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/elpaso/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/elpaso/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/elpaso/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/elpaso/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/elpaso/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elpaso/QGIS/merges","archive_url":"https://api.github.com/repos/elpaso/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elpaso/QGIS/downloads","issues_url":"https://api.github.com/repos/elpaso/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/elpaso/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/elpaso/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/elpaso/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elpaso/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/elpaso/QGIS/releases{/id}","created_at":"2014-01-06T11:12:43Z","updated_at":"2015-05-19T15:44:11Z","pushed_at":"2015-11-30T16:00:09Z","git_url":"git://github.com/elpaso/QGIS.git","ssh_url":"git@github.com:elpaso/QGIS.git","clone_url":"https://github.com/elpaso/QGIS.git","svn_url":"https://github.com/elpaso/QGIS","homepage":"http://qgis.org","size":1178892,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"0b9ac8bd9b399da30fe361951df763460aa9f60e","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","created_at":"2011-05-02T08:06:26Z","updated_at":"2015-11-30T11:25:56Z","pushed_at":"2015-11-30T22:06:12Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1207765,"stargazers_count":810,"watchers_count":810,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":744,"mirror_url":null,"open_issues_count":53,"forks":744,"open_issues":53,"watchers":810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/2518"},"html":{"href":"https://github.com/qgis/QGIS/pull/2518"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/2518"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/2518/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/2518/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/2518/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/12ad4252abfff52620374f26a9f852348860671a"}}}}