{"action":"created","issue":{"url":"https://api.github.com/repos/libvmi/libvmi/issues/247","labels_url":"https://api.github.com/repos/libvmi/libvmi/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/libvmi/libvmi/issues/247/comments","events_url":"https://api.github.com/repos/libvmi/libvmi/issues/247/events","html_url":"https://github.com/libvmi/libvmi/pull/247","id":66025020,"number":247,"title":"0 can be a valid physical address.","user":{"login":"awsaba","id":3173135,"avatar_url":"https://avatars.githubusercontent.com/u/3173135?v=3","gravatar_id":"","url":"https://api.github.com/users/awsaba","html_url":"https://github.com/awsaba","followers_url":"https://api.github.com/users/awsaba/followers","following_url":"https://api.github.com/users/awsaba/following{/other_user}","gists_url":"https://api.github.com/users/awsaba/gists{/gist_id}","starred_url":"https://api.github.com/users/awsaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awsaba/subscriptions","organizations_url":"https://api.github.com/users/awsaba/orgs","repos_url":"https://api.github.com/users/awsaba/repos","events_url":"https://api.github.com/users/awsaba/events{/privacy}","received_events_url":"https://api.github.com/users/awsaba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-02T22:38:54Z","updated_at":"2015-04-03T17:10:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libvmi/libvmi/pulls/247","html_url":"https://github.com/libvmi/libvmi/pull/247","diff_url":"https://github.com/libvmi/libvmi/pull/247.diff","patch_url":"https://github.com/libvmi/libvmi/pull/247.patch"},"body":"Leave it to the driver to fail if it's not.\r\n\r\nI was playing around with other ways to dump guest memory and noticed the discrepancy at 0, which `xc_map_foreign_range` will map just fine, but can't be read by the `dump-memory` example.\r\n\r\nI'd like to get a couple pairs of eyes on this in case there is some place where non-zero is assumed and not otherwise handled.  Using 0 as the key for the memory_cache seems to work fine."},"comment":{"url":"https://api.github.com/repos/libvmi/libvmi/issues/comments/89359560","html_url":"https://github.com/libvmi/libvmi/pull/247#issuecomment-89359560","issue_url":"https://api.github.com/repos/libvmi/libvmi/issues/247","id":89359560,"user":{"login":"tklengyel","id":3172829,"avatar_url":"https://avatars.githubusercontent.com/u/3172829?v=3","gravatar_id":"","url":"https://api.github.com/users/tklengyel","html_url":"https://github.com/tklengyel","followers_url":"https://api.github.com/users/tklengyel/followers","following_url":"https://api.github.com/users/tklengyel/following{/other_user}","gists_url":"https://api.github.com/users/tklengyel/gists{/gist_id}","starred_url":"https://api.github.com/users/tklengyel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklengyel/subscriptions","organizations_url":"https://api.github.com/users/tklengyel/orgs","repos_url":"https://api.github.com/users/tklengyel/repos","events_url":"https://api.github.com/users/tklengyel/events{/privacy}","received_events_url":"https://api.github.com/users/tklengyel/received_events","type":"User","site_admin":false},"created_at":"2015-04-03T17:10:59Z","updated_at":"2015-04-03T17:10:59Z","body":"I think the two patches in this PR could be merged into one, afterwards it would be good to."}}