{"action":"created","issue":{"url":"https://api.github.com/repos/blinkmobile/forms/issues/52","labels_url":"https://api.github.com/repos/blinkmobile/forms/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/blinkmobile/forms/issues/52/comments","events_url":"https://api.github.com/repos/blinkmobile/forms/issues/52/events","html_url":"https://github.com/blinkmobile/forms/pull/52","id":113273295,"number":52,"title":"FORMS-254 # Subform error not clearing for parent subform","user":{"login":"simonmarklar","id":2966718,"avatar_url":"https://avatars.githubusercontent.com/u/2966718?v=3","gravatar_id":"","url":"https://api.github.com/users/simonmarklar","html_url":"https://github.com/simonmarklar","followers_url":"https://api.github.com/users/simonmarklar/followers","following_url":"https://api.github.com/users/simonmarklar/following{/other_user}","gists_url":"https://api.github.com/users/simonmarklar/gists{/gist_id}","starred_url":"https://api.github.com/users/simonmarklar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonmarklar/subscriptions","organizations_url":"https://api.github.com/users/simonmarklar/orgs","repos_url":"https://api.github.com/users/simonmarklar/repos","events_url":"https://api.github.com/users/simonmarklar/events{/privacy}","received_events_url":"https://api.github.com/users/simonmarklar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-26T02:24:55Z","updated_at":"2015-10-26T02:33:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/blinkmobile/forms/pulls/52","html_url":"https://github.com/blinkmobile/forms/pull/52","diff_url":"https://github.com/blinkmobile/forms/pull/52.diff","patch_url":"https://github.com/blinkmobile/forms/pull/52.patch"},"body":"- Removed useless and expensive 'This subform has errors' Error message\r\n    - Moved `updateFieldErrors` function into `validate`\r\n    - Fixed up tests that expected the `SUBFORM` error\r\n- only `invalid` and `valid` events propagate up from subforms to parent form\r\n    - fixed events that tested for `change:value`. They now check for the `valid` event.\r\n    - added a guard in these events so that listener only executes when it is bound to the model that triggered the event.\r\n- Changed views from `model#on` to `view#listenTo` so that views can clean up after themselves automatically\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/blinkmobile/forms/issues/comments/151005259","html_url":"https://github.com/blinkmobile/forms/pull/52#issuecomment-151005259","issue_url":"https://api.github.com/repos/blinkmobile/forms/issues/52","id":151005259,"user":{"login":"simonmarklar","id":2966718,"avatar_url":"https://avatars.githubusercontent.com/u/2966718?v=3","gravatar_id":"","url":"https://api.github.com/users/simonmarklar","html_url":"https://github.com/simonmarklar","followers_url":"https://api.github.com/users/simonmarklar/followers","following_url":"https://api.github.com/users/simonmarklar/following{/other_user}","gists_url":"https://api.github.com/users/simonmarklar/gists{/gist_id}","starred_url":"https://api.github.com/users/simonmarklar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonmarklar/subscriptions","organizations_url":"https://api.github.com/users/simonmarklar/orgs","repos_url":"https://api.github.com/users/simonmarklar/repos","events_url":"https://api.github.com/users/simonmarklar/events{/privacy}","received_events_url":"https://api.github.com/users/simonmarklar/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T02:33:19Z","updated_at":"2015-10-26T02:33:19Z","body":"Timings:\r\n\r\non average the timings appear to be the same as before, perhaps on slightly (a few ms) faster for some things. Ran the test 3 times, the first time for both branches with a cleared cache. However it should be noted that the develop branch does not show the 'SUBFORM' error correctly, which was the issue this pr is meant to address.\r\n\r\n*test/27_1_generated/*\r\n\r\ndevelop branch timings\r\n\r\nchrome:\r\ninitialize, 186.579ms\r\npreloadPromise, 186.938ms\r\nappend, 1.087ms\r\njQueryMobile enhance, 14.086ms\r\npageInjected, 194.919ms\r\nadd subForm31 x4, 825.936ms\r\nadd subForm64 x4, 759.215ms\r\nturn to page[1], 1324.085ms\r\n\r\ninitialize: 126.998ms\r\npreloadPromise: 127.274ms\r\nappend: 1.335ms\r\njQueryMobile enhance: 8.188ms\r\npageInjected: 194.683ms\r\nadd subForm31 x4: 685.429ms\r\nadd subForm64 x4: 615.771ms\r\nturn to page[1]: 965.393ms\r\n\r\n\r\nnitialize: 147.255ms\r\npreloadPromise: 147.565ms\r\nappend: 1.249ms\r\njQueryMobile enhance: 10.166ms\r\npageInjected: 205.080ms\r\nadd subForm31 x4: 625.402ms\r\nadd subForm64 x4: 618.661ms\r\nturn to page[1]: 999.116ms\r\n\r\n\r\nFORMS-254 Branch\r\n\r\nchrome:\r\ninitialize: 151.875ms\r\npreloadPromise: 152.143ms\r\nappend: 1.068ms\r\njQueryMobile enhance: 12.409ms\r\npageInjected: 196.230ms\r\nadd subForm31 x4: 814.638ms\r\nadd subForm64 x4: 505.335ms\r\nturn to page[1]: 1065.029ms\r\n\r\ninitialize: 161.391ms\r\npreloadPromise: 161.856ms\r\nappend: 2.577ms\r\njQueryMobile enhance: 8.430ms\r\npageInjected: 189.998ms\r\nadd subForm31 x4: 661.456ms\r\nadd subForm64 x4: 582.544ms\r\nturn to page[1]: 996.734ms\r\n\r\ninitialize: 168.539ms\r\npreloadPromise: 168.819ms\r\nappend: 1.010ms\r\njQueryMobile enhance: 7.555ms\r\npageInjected: 195.125ms\r\nadd subForm31 x4: 778.929ms\r\nadd subForm64 x4: 600.577ms\r\nturn to page[1]: 1040.862ms"}}