{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments/43331609","id":43331609,"diff_hunk":"@@ -121,35 +127,343 @@\n         ).and be_idempotent\n       end\n \n-      it \"aws_security_group 'test_sg' with inbound and outbound rules works\" do\n+      it \"can specify rules as a mapping from source/destination to port and protocol\" do\n         expect_recipe {\n           aws_security_group 'test_sg' do\n+            # We need to define a list of ports and its easier to use a method than\n+            # have to add a new number when changing this test\n+            def p()","path":"spec/integration/aws_security_group_spec.rb","position":27,"original_position":27,"commit_id":"a0411704bfbedf00415f90c45e20120c58a6a19b","original_commit_id":"a0411704bfbedf00415f90c45e20120c58a6a19b","user":{"login":"tyler-ball","id":2481463,"avatar_url":"https://avatars.githubusercontent.com/u/2481463?v=3","gravatar_id":"","url":"https://api.github.com/users/tyler-ball","html_url":"https://github.com/tyler-ball","followers_url":"https://api.github.com/users/tyler-ball/followers","following_url":"https://api.github.com/users/tyler-ball/following{/other_user}","gists_url":"https://api.github.com/users/tyler-ball/gists{/gist_id}","starred_url":"https://api.github.com/users/tyler-ball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyler-ball/subscriptions","organizations_url":"https://api.github.com/users/tyler-ball/orgs","repos_url":"https://api.github.com/users/tyler-ball/repos","events_url":"https://api.github.com/users/tyler-ball/events{/privacy}","received_events_url":"https://api.github.com/users/tyler-ball/received_events","type":"User","site_admin":false},"body":"Yeah, I changed `p` to `counter` since thats what I wanted - just an incrementing number each time I call it","created_at":"2015-10-28T23:17:40Z","updated_at":"2015-10-28T23:17:40Z","html_url":"https://github.com/chef/chef-provisioning-aws/pull/382#discussion_r43331609","pull_request_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/382","_links":{"self":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments/43331609"},"html":{"href":"https://github.com/chef/chef-provisioning-aws/pull/382#discussion_r43331609"},"pull_request":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/382"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/382","id":49078750,"html_url":"https://github.com/chef/chef-provisioning-aws/pull/382","diff_url":"https://github.com/chef/chef-provisioning-aws/pull/382.diff","patch_url":"https://github.com/chef/chef-provisioning-aws/pull/382.patch","issue_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/382","number":382,"state":"open","locked":false,"title":"Adding full test coverage for security groups, documenting all the ways rules can be defined, fixes #154","user":{"login":"tyler-ball","id":2481463,"avatar_url":"https://avatars.githubusercontent.com/u/2481463?v=3","gravatar_id":"","url":"https://api.github.com/users/tyler-ball","html_url":"https://github.com/tyler-ball","followers_url":"https://api.github.com/users/tyler-ball/followers","following_url":"https://api.github.com/users/tyler-ball/following{/other_user}","gists_url":"https://api.github.com/users/tyler-ball/gists{/gist_id}","starred_url":"https://api.github.com/users/tyler-ball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyler-ball/subscriptions","organizations_url":"https://api.github.com/users/tyler-ball/orgs","repos_url":"https://api.github.com/users/tyler-ball/repos","events_url":"https://api.github.com/users/tyler-ball/events{/privacy}","received_events_url":"https://api.github.com/users/tyler-ball/received_events","type":"User","site_admin":false},"body":"I know the documentation is in the form of a test, which isn't ideal, but at least its something.  And if its ever wrong, it will break the test!\r\n\r\nFixes https://github.com/chef/chef-provisioning-aws/issues/154\r\n\r\n\\cc @dblessing @jkeiser @randomcamel ","created_at":"2015-10-28T22:57:54Z","updated_at":"2015-10-28T23:17:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4edd129db39e60bf701da03f74e23fcc44f66e5","assignee":{"login":"tyler-ball","id":2481463,"avatar_url":"https://avatars.githubusercontent.com/u/2481463?v=3","gravatar_id":"","url":"https://api.github.com/users/tyler-ball","html_url":"https://github.com/tyler-ball","followers_url":"https://api.github.com/users/tyler-ball/followers","following_url":"https://api.github.com/users/tyler-ball/following{/other_user}","gists_url":"https://api.github.com/users/tyler-ball/gists{/gist_id}","starred_url":"https://api.github.com/users/tyler-ball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyler-ball/subscriptions","organizations_url":"https://api.github.com/users/tyler-ball/orgs","repos_url":"https://api.github.com/users/tyler-ball/repos","events_url":"https://api.github.com/users/tyler-ball/events{/privacy}","received_events_url":"https://api.github.com/users/tyler-ball/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/382/commits","review_comments_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/382/comments","review_comment_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/382/comments","statuses_url":"https://api.github.com/repos/chef/chef-provisioning-aws/statuses/a0411704bfbedf00415f90c45e20120c58a6a19b","head":{"label":"chef:tball/sg","ref":"tball/sg","sha":"a0411704bfbedf00415f90c45e20120c58a6a19b","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24198103,"name":"chef-provisioning-aws","full_name":"chef/chef-provisioning-aws","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-provisioning-aws","description":"AWS driver and resources for Chef that uses the AWS SDK","fork":false,"url":"https://api.github.com/repos/chef/chef-provisioning-aws","forks_url":"https://api.github.com/repos/chef/chef-provisioning-aws/forks","keys_url":"https://api.github.com/repos/chef/chef-provisioning-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-provisioning-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-provisioning-aws/teams","hooks_url":"https://api.github.com/repos/chef/chef-provisioning-aws/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-provisioning-aws/events","assignees_url":"https://api.github.com/repos/chef/chef-provisioning-aws/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-provisioning-aws/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-provisioning-aws/tags","blobs_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-provisioning-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-provisioning-aws/languages","stargazers_url":"https://api.github.com/repos/chef/chef-provisioning-aws/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-provisioning-aws/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-provisioning-aws/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-provisioning-aws/subscription","commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-provisioning-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-provisioning-aws/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-provisioning-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-provisioning-aws/merges","archive_url":"https://api.github.com/repos/chef/chef-provisioning-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-provisioning-aws/downloads","issues_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-provisioning-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-provisioning-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-provisioning-aws/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-provisioning-aws/releases{/id}","created_at":"2014-09-18T17:32:40Z","updated_at":"2015-10-22T00:57:28Z","pushed_at":"2015-10-28T22:57:54Z","git_url":"git://github.com/chef/chef-provisioning-aws.git","ssh_url":"git@github.com:chef/chef-provisioning-aws.git","clone_url":"https://github.com/chef/chef-provisioning-aws.git","svn_url":"https://github.com/chef/chef-provisioning-aws","homepage":"","size":4096,"stargazers_count":68,"watchers_count":68,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":77,"forks":54,"open_issues":77,"watchers":68,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"321852bb19874f9f6285eb2c77271308f2d68e3a","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24198103,"name":"chef-provisioning-aws","full_name":"chef/chef-provisioning-aws","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-provisioning-aws","description":"AWS driver and resources for Chef that uses the AWS SDK","fork":false,"url":"https://api.github.com/repos/chef/chef-provisioning-aws","forks_url":"https://api.github.com/repos/chef/chef-provisioning-aws/forks","keys_url":"https://api.github.com/repos/chef/chef-provisioning-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-provisioning-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-provisioning-aws/teams","hooks_url":"https://api.github.com/repos/chef/chef-provisioning-aws/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-provisioning-aws/events","assignees_url":"https://api.github.com/repos/chef/chef-provisioning-aws/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-provisioning-aws/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-provisioning-aws/tags","blobs_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-provisioning-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-provisioning-aws/languages","stargazers_url":"https://api.github.com/repos/chef/chef-provisioning-aws/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-provisioning-aws/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-provisioning-aws/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-provisioning-aws/subscription","commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-provisioning-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-provisioning-aws/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-provisioning-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-provisioning-aws/merges","archive_url":"https://api.github.com/repos/chef/chef-provisioning-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-provisioning-aws/downloads","issues_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-provisioning-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-provisioning-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-provisioning-aws/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-provisioning-aws/releases{/id}","created_at":"2014-09-18T17:32:40Z","updated_at":"2015-10-22T00:57:28Z","pushed_at":"2015-10-28T22:57:54Z","git_url":"git://github.com/chef/chef-provisioning-aws.git","ssh_url":"git@github.com:chef/chef-provisioning-aws.git","clone_url":"https://github.com/chef/chef-provisioning-aws.git","svn_url":"https://github.com/chef/chef-provisioning-aws","homepage":"","size":4096,"stargazers_count":68,"watchers_count":68,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":77,"forks":54,"open_issues":77,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/382"},"html":{"href":"https://github.com/chef/chef-provisioning-aws/pull/382"},"issue":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/382"},"comments":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/382/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/382/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/382/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/statuses/a0411704bfbedf00415f90c45e20120c58a6a19b"}}}}