{"action":"created","comment":{"url":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/comments/48165886","id":48165886,"diff_hunk":"@@ -14,30 +14,42 @@\n <!-- ENDIF -->\n \n <form id=\"acp_phpbb_ideas_settings\" method=\"post\" action=\"{U_ACTION}\">\n-\n-<!-- BEGIN options -->\n-\t<!-- IF options.S_LEGEND -->\n-\t\t<!-- IF not options.S_FIRST_ROW -->\n-\t\t\t</fieldset>\n-\t\t<!-- ENDIF -->\n-\t\t<fieldset>\n-\t\t\t<legend>{options.LEGEND}</legend>\n-\t<!-- ELSE -->\n+\t<fieldset>\n+\t\t<legend>{L_ACP_PHPBB_IDEAS_SETTINGS}</legend>\n \t\t<dl>\n-\t\t\t<dt><label for=\"{options.KEY}\">{options.TITLE}{L_COLON}</label><!-- IF options.S_EXPLAIN --><br /><span>{options.TITLE_EXPLAIN}</span><!-- ENDIF --></dt>\n-\t\t\t<dd>{options.CONTENT}</dd>\n-\t\t\t<!-- IF options.KEY == 'ideas_poster_id' --><dd>[ <a href=\"{U_FIND_USERNAME}\" onclick=\"find_username(this.href); return false;\">{L_FIND_USERNAME}</a> ]</dd><!-- ENDIF -->\n+\t\t\t<dt><label for=\"ideas_forum_id\">{L_ACP_IDEAS_FORUM_ID}{L_COLON}</label><br /><span>{L_ACP_IDEAS_FORUM_ID_EXPLAIN}</span></dt>\n+\t\t\t<dd>{S_FORUM_SELECT_BOX}</dd>\n+\t\t</dl>\n+\t\t<dl>\n+\t\t\t<dt><label for=\"ideas_poster_id\">{L_ACP_IDEAS_POSTER_ID}{L_COLON}</label><br /><span>{L_ACP_IDEAS_POSTER_ID_EXPLAIN}</span></dt>\n+\t\t\t<dd><input id=\"ideas_poster_id\" type=\"text\" size=\"45\" maxlength=\"255\" name=\"config[ideas_poster_id]\" value=\"{IDEAS_POSTER}\" /></dd>\n+\t\t\t<dd>[ <a href=\"{U_FIND_USERNAME}\" onclick=\"find_username(this.href); return false;\">{L_FIND_USERNAME}</a> ]</dd>\n+\t\t</dl>\n+\t\t<dl>\n+\t\t\t<dt><label for=\"ideas_base_url\">{L_ACP_IDEAS_BASE_URL}{L_COLON}</label><br /><span>{L_ACP_IDEAS_BASE_URL_EXPLAIN}</span></dt>\n+\t\t\t<dd><input id=\"ideas_base_url\" type=\"text\" size=\"45\" maxlength=\"255\" name=\"config[ideas_base_url]\" value=\"{IDEAS_BASE_URL}\" /></dd>\n \t\t</dl>\n-\t<!-- ENDIF -->\n-<!-- END options -->\n-</fieldset>\n-\n-<fieldset class=\"submit-buttons\">\n-\t<input class=\"button1\" type=\"submit\" id=\"submit\" name=\"submit\" value=\"{L_SUBMIT}\" />&nbsp;\n-\t<input class=\"button2\" type=\"reset\" id=\"reset\" name=\"reset\" value=\"{L_RESET}\" />\n-\t{S_FORM_TOKEN}\n-</fieldset>\n \n+\t\t<fieldset class=\"submit-buttons\">\n+\t\t\t<input class=\"button1\" type=\"submit\" id=\"submit\" name=\"submit\" value=\"{L_SUBMIT}\" />&nbsp;\n+\t\t\t<input class=\"button2\" type=\"reset\" id=\"reset\" name=\"reset\" value=\"{L_RESET}\" />\n+\t\t\t{S_FORM_TOKEN}\n+\t\t</fieldset>\n+\t</fieldset>\n </form>\n \n+<!-- IF S_IDEAS_FORUM_ID -->","path":"adm/style/acp_phpbb_ideas.html","position":49,"original_position":49,"commit_id":"14b99c9d4f1386aa041500fe89f32c2219200d43","original_commit_id":"14b99c9d4f1386aa041500fe89f32c2219200d43","user":{"login":"VSEphpbb","id":303711,"avatar_url":"https://avatars.githubusercontent.com/u/303711?v=3","gravatar_id":"","url":"https://api.github.com/users/VSEphpbb","html_url":"https://github.com/VSEphpbb","followers_url":"https://api.github.com/users/VSEphpbb/followers","following_url":"https://api.github.com/users/VSEphpbb/following{/other_user}","gists_url":"https://api.github.com/users/VSEphpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/VSEphpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSEphpbb/subscriptions","organizations_url":"https://api.github.com/users/VSEphpbb/orgs","repos_url":"https://api.github.com/users/VSEphpbb/repos","events_url":"https://api.github.com/users/VSEphpbb/events{/privacy}","received_events_url":"https://api.github.com/users/VSEphpbb/received_events","type":"User","site_admin":false},"body":"Well, it's not really an option. Just a button. And our description for it does say \"Note: you have to set the Ideas forum first.\"","created_at":"2015-12-21T16:59:42Z","updated_at":"2015-12-21T16:59:42Z","html_url":"https://github.com/phpbb/phpbb-ideas/pull/39#discussion_r48165886","pull_request_url":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/comments/48165886"},"html":{"href":"https://github.com/phpbb/phpbb-ideas/pull/39#discussion_r48165886"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/39","id":50544142,"html_url":"https://github.com/phpbb/phpbb-ideas/pull/39","diff_url":"https://github.com/phpbb/phpbb-ideas/pull/39.diff","patch_url":"https://github.com/phpbb/phpbb-ideas/pull/39.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb-ideas/issues/39","number":39,"state":"open","locked":false,"title":"Add confirm box to the forum settings button + ajaxify.","user":{"login":"rxu","id":212322,"avatar_url":"https://avatars.githubusercontent.com/u/212322?v=3","gravatar_id":"","url":"https://api.github.com/users/rxu","html_url":"https://github.com/rxu","followers_url":"https://api.github.com/users/rxu/followers","following_url":"https://api.github.com/users/rxu/following{/other_user}","gists_url":"https://api.github.com/users/rxu/gists{/gist_id}","starred_url":"https://api.github.com/users/rxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxu/subscriptions","organizations_url":"https://api.github.com/users/rxu/orgs","repos_url":"https://api.github.com/users/rxu/repos","events_url":"https://api.github.com/users/rxu/events{/privacy}","received_events_url":"https://api.github.com/users/rxu/received_events","type":"User","site_admin":false},"body":"TODO:\r\n- [x] Refactor ACP module to controller\r\n- [x] Split ACP controller into action specific methods\r\n- [x] Cleanup ACP module and controller","created_at":"2015-11-12T17:52:15Z","updated_at":"2015-12-21T16:59:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e4607041153bf338cc02d7224f837346e29dc41","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/39/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/39/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpbb/phpbb-ideas/issues/39/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb-ideas/statuses/14b99c9d4f1386aa041500fe89f32c2219200d43","head":{"label":"rxu:add-ajax-request","ref":"add-ajax-request","sha":"14b99c9d4f1386aa041500fe89f32c2219200d43","user":{"login":"rxu","id":212322,"avatar_url":"https://avatars.githubusercontent.com/u/212322?v=3","gravatar_id":"","url":"https://api.github.com/users/rxu","html_url":"https://github.com/rxu","followers_url":"https://api.github.com/users/rxu/followers","following_url":"https://api.github.com/users/rxu/following{/other_user}","gists_url":"https://api.github.com/users/rxu/gists{/gist_id}","starred_url":"https://api.github.com/users/rxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxu/subscriptions","organizations_url":"https://api.github.com/users/rxu/orgs","repos_url":"https://api.github.com/users/rxu/repos","events_url":"https://api.github.com/users/rxu/events{/privacy}","received_events_url":"https://api.github.com/users/rxu/received_events","type":"User","site_admin":false},"repo":{"id":44487576,"name":"phpbb-ideas","full_name":"rxu/phpbb-ideas","owner":{"login":"rxu","id":212322,"avatar_url":"https://avatars.githubusercontent.com/u/212322?v=3","gravatar_id":"","url":"https://api.github.com/users/rxu","html_url":"https://github.com/rxu","followers_url":"https://api.github.com/users/rxu/followers","following_url":"https://api.github.com/users/rxu/following{/other_user}","gists_url":"https://api.github.com/users/rxu/gists{/gist_id}","starred_url":"https://api.github.com/users/rxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxu/subscriptions","organizations_url":"https://api.github.com/users/rxu/orgs","repos_url":"https://api.github.com/users/rxu/repos","events_url":"https://api.github.com/users/rxu/events{/privacy}","received_events_url":"https://api.github.com/users/rxu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rxu/phpbb-ideas","description":"An idea center for phpBB/phpBB.com (based on WordPress idea center).","fork":true,"url":"https://api.github.com/repos/rxu/phpbb-ideas","forks_url":"https://api.github.com/repos/rxu/phpbb-ideas/forks","keys_url":"https://api.github.com/repos/rxu/phpbb-ideas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rxu/phpbb-ideas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rxu/phpbb-ideas/teams","hooks_url":"https://api.github.com/repos/rxu/phpbb-ideas/hooks","issue_events_url":"https://api.github.com/repos/rxu/phpbb-ideas/issues/events{/number}","events_url":"https://api.github.com/repos/rxu/phpbb-ideas/events","assignees_url":"https://api.github.com/repos/rxu/phpbb-ideas/assignees{/user}","branches_url":"https://api.github.com/repos/rxu/phpbb-ideas/branches{/branch}","tags_url":"https://api.github.com/repos/rxu/phpbb-ideas/tags","blobs_url":"https://api.github.com/repos/rxu/phpbb-ideas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rxu/phpbb-ideas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rxu/phpbb-ideas/git/refs{/sha}","trees_url":"https://api.github.com/repos/rxu/phpbb-ideas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rxu/phpbb-ideas/statuses/{sha}","languages_url":"https://api.github.com/repos/rxu/phpbb-ideas/languages","stargazers_url":"https://api.github.com/repos/rxu/phpbb-ideas/stargazers","contributors_url":"https://api.github.com/repos/rxu/phpbb-ideas/contributors","subscribers_url":"https://api.github.com/repos/rxu/phpbb-ideas/subscribers","subscription_url":"https://api.github.com/repos/rxu/phpbb-ideas/subscription","commits_url":"https://api.github.com/repos/rxu/phpbb-ideas/commits{/sha}","git_commits_url":"https://api.github.com/repos/rxu/phpbb-ideas/git/commits{/sha}","comments_url":"https://api.github.com/repos/rxu/phpbb-ideas/comments{/number}","issue_comment_url":"https://api.github.com/repos/rxu/phpbb-ideas/issues/comments{/number}","contents_url":"https://api.github.com/repos/rxu/phpbb-ideas/contents/{+path}","compare_url":"https://api.github.com/repos/rxu/phpbb-ideas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rxu/phpbb-ideas/merges","archive_url":"https://api.github.com/repos/rxu/phpbb-ideas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rxu/phpbb-ideas/downloads","issues_url":"https://api.github.com/repos/rxu/phpbb-ideas/issues{/number}","pulls_url":"https://api.github.com/repos/rxu/phpbb-ideas/pulls{/number}","milestones_url":"https://api.github.com/repos/rxu/phpbb-ideas/milestones{/number}","notifications_url":"https://api.github.com/repos/rxu/phpbb-ideas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rxu/phpbb-ideas/labels{/name}","releases_url":"https://api.github.com/repos/rxu/phpbb-ideas/releases{/id}","created_at":"2015-10-18T17:06:25Z","updated_at":"2015-10-18T17:06:26Z","pushed_at":"2015-12-21T14:54:24Z","git_url":"git://github.com/rxu/phpbb-ideas.git","ssh_url":"git@github.com:rxu/phpbb-ideas.git","clone_url":"https://github.com/rxu/phpbb-ideas.git","svn_url":"https://github.com/rxu/phpbb-ideas","homepage":null,"size":670,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"31x"}},"base":{"label":"phpbb:master","ref":"master","sha":"1ab646640d2efa0ca48c2f77369e192068d1ded2","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":11393427,"name":"phpbb-ideas","full_name":"phpbb/phpbb-ideas","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb-ideas","description":"An idea center for phpBB/phpBB.com (based on WordPress idea center).","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb-ideas","forks_url":"https://api.github.com/repos/phpbb/phpbb-ideas/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb-ideas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb-ideas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb-ideas/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb-ideas/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb-ideas/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb-ideas/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb-ideas/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb-ideas/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb-ideas/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb-ideas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb-ideas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb-ideas/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb-ideas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb-ideas/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb-ideas/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb-ideas/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb-ideas/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb-ideas/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb-ideas/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb-ideas/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb-ideas/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb-ideas/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb-ideas/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpbb/phpbb-ideas/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb-ideas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb-ideas/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb-ideas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb-ideas/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb-ideas/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb-ideas/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb-ideas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb-ideas/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb-ideas/releases{/id}","created_at":"2013-07-13T19:59:47Z","updated_at":"2015-10-20T01:33:45Z","pushed_at":"2015-12-21T14:54:24Z","git_url":"git://github.com/phpbb/phpbb-ideas.git","ssh_url":"git@github.com:phpbb/phpbb-ideas.git","clone_url":"https://github.com/phpbb/phpbb-ideas.git","svn_url":"https://github.com/phpbb/phpbb-ideas","homepage":null,"size":699,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/39"},"html":{"href":"https://github.com/phpbb/phpbb-ideas/pull/39"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb-ideas/issues/39"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb-ideas/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb-ideas/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb-ideas/statuses/14b99c9d4f1386aa041500fe89f32c2219200d43"}}}}