{"push_id":887842669,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"5592a21a91b0597b101c151e706bac9c2a3cb57d","before":"b1bc5402ed85ef33928c511b4b0a34a2d3abd11a","commits":[{"sha":"5592a21a91b0597b101c151e706bac9c2a3cb57d","author":{"email":"db8246071c18712c07a0bd4c2123c52cde604800@tablexi.com","name":"Dan Rench"},"message":"[#98883] Add Account Manager user role\n\nThis adds a new global user role called Account Manager, which has access to\nthe User administration tab in a cross-facility context, which is something\nthat no other roles (even global admins) have.\n\nPreviously many of the navigation tabs and links used Role checks to determine\ndisplay. The changes here should all use Ability checks instead. This does mean\nwe are now explicitly taking away abilities from the global administrator role,\nbut it shouldn't change the behavior this role has seen all along. For example,\nthe cross-facility Billing tab had a condition to make it visible only to\nBilling Administrators, which also meant it was not visible to global admins.\nConverting this to an Ability check meant removing permissions from global\nadmins, which until now had an across-the-board can(:manage, :all). The Ability\nrestrictions were also the reason behind the spec change in 29bfcd0;\nit's something that probably should have been tested as a Billing Administrator\nall along.\n\nThis change also:\n\n* Refactors the global admin tabs to use the NavTab presenters from #383\n* Removes the unused Role.grant_role! method\n* Adds FacilityAccountOrdersController to replace the \"recent\" case in\n  FacilityAccountsController#show_statement\n* Adds an OrderDetailPresenter, which should help reduce the size of the\n  OrderDetail model and helper methods in general over time\n* Sets a facility for CC accounts in the demo seed\n\nThis change does not include a UI for granting this new role to users.\n\nCloses #397","distinct":true,"url":"https://api.github.com/repos/tablexi/nucore-open/commits/5592a21a91b0597b101c151e706bac9c2a3cb57d"}]}