{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/27525588","id":27525588,"diff_hunk":"@@ -216,13 +269,21 @@ def add_cell(self, row, col, *args, **kwargs):\n         \"\"\" Add a cell to the table. \"\"\"\n         xy = (0, 0)\n \n-        cell = Cell(xy, *args, **kwargs)\n+        cell = CustomCell(xy, visible_edges=self._drawLines, *args, **kwargs)\n         cell.set_figure(self.figure)\n         cell.set_transform(self.get_transform())\n \n         cell.set_clip_on(False)\n         self._cells[(row, col)] = cell\n \n+    @property\n+    def drawLines(self):","path":"lib/matplotlib/table.py","position":87,"original_position":87,"commit_id":"039df4b634c8fc8a5ebb48ab3661709aa5ab880a","original_commit_id":"039df4b634c8fc8a5ebb48ab3661709aa5ab880a","user":{"login":"dkua","id":1531139,"avatar_url":"https://avatars.githubusercontent.com/u/1531139?v=3","gravatar_id":"","url":"https://api.github.com/users/dkua","html_url":"https://github.com/dkua","followers_url":"https://api.github.com/users/dkua/followers","following_url":"https://api.github.com/users/dkua/following{/other_user}","gists_url":"https://api.github.com/users/dkua/gists{/gist_id}","starred_url":"https://api.github.com/users/dkua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkua/subscriptions","organizations_url":"https://api.github.com/users/dkua/orgs","repos_url":"https://api.github.com/users/dkua/repos","events_url":"https://api.github.com/users/dkua/events{/privacy}","received_events_url":"https://api.github.com/users/dkua/received_events","type":"User","site_admin":false},"body":"Okay gotcha","created_at":"2015-03-31T21:34:15Z","updated_at":"2015-03-31T21:34:15Z","html_url":"https://github.com/matplotlib/matplotlib/pull/4259#discussion_r27525588","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4259","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/27525588"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/4259#discussion_r27525588"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4259"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4259","id":31681789,"html_url":"https://github.com/matplotlib/matplotlib/pull/4259","diff_url":"https://github.com/matplotlib/matplotlib/pull/4259.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/4259.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/4259","number":4259,"state":"open","locked":false,"title":"Implementation of Issue #4044. Added ScientificTable and ScientificCell subclasses.","user":{"login":"dkua","id":1531139,"avatar_url":"https://avatars.githubusercontent.com/u/1531139?v=3","gravatar_id":"","url":"https://api.github.com/users/dkua","html_url":"https://github.com/dkua","followers_url":"https://api.github.com/users/dkua/followers","following_url":"https://api.github.com/users/dkua/following{/other_user}","gists_url":"https://api.github.com/users/dkua/gists{/gist_id}","starred_url":"https://api.github.com/users/dkua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkua/subscriptions","organizations_url":"https://api.github.com/users/dkua/orgs","repos_url":"https://api.github.com/users/dkua/repos","events_url":"https://api.github.com/users/dkua/events{/privacy}","received_events_url":"https://api.github.com/users/dkua/received_events","type":"User","site_admin":false},"body":"This implements the requested feature in issue #4044 \r\n\r\nTwo subclasses, `ScientificTable` and `ScientificCell`, were created of `Table` and `Cell` respectively. An extra kwarg was added to the `table()` factory function for choosing the type of `Table` to use.\r\n\r\nThe factory function and the table types were tested with the `test_table_types` test in `test_table.py`. A new test image was also added. The test passes in Ubuntu 12.04 64-bit.\r\n\r\nThe feature was implemented by having `ScientificCell` extend `Cell` with an additional method `get_path()` which simply returns a new `Path` instance that doesn't draw a line when moving between the vertices that make up a vertical line.\r\n\r\nThis works because `Cell.draw()` calls `Rectangle.draw()` which calls `self.get_path()`.  However `Cell` passes into `Rectangle.draw()` the arguments `self, renderer`. So the `self.get_path()` call is actually calling `Cell` but since it doesn't have that method it uses it's super class' definition which is `Rectangle`. By creating the new subclass with our own `get_path()` method we can implement this feature while following the same logic.","created_at":"2015-03-22T02:24:38Z","updated_at":"2015-03-31T21:34:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4938d0c363ee681706c5548e80b6c1e4e3ed014a","assignee":null,"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/18","html_url":"https://github.com/matplotlib/matplotlib/milestones/next%20point%20release","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/18/labels","id":970105,"number":18,"title":"next point release","description":"Next minor release.","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":179,"closed_issues":89,"state":"open","created_at":"2015-02-07T21:22:30Z","updated_at":"2015-03-30T19:57:19Z","due_on":"2015-07-06T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4259/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4259/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/4259/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/039df4b634c8fc8a5ebb48ab3661709aa5ab880a","head":{"label":"dkua:feature_4044","ref":"feature_4044","sha":"039df4b634c8fc8a5ebb48ab3661709aa5ab880a","user":{"login":"dkua","id":1531139,"avatar_url":"https://avatars.githubusercontent.com/u/1531139?v=3","gravatar_id":"","url":"https://api.github.com/users/dkua","html_url":"https://github.com/dkua","followers_url":"https://api.github.com/users/dkua/followers","following_url":"https://api.github.com/users/dkua/following{/other_user}","gists_url":"https://api.github.com/users/dkua/gists{/gist_id}","starred_url":"https://api.github.com/users/dkua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkua/subscriptions","organizations_url":"https://api.github.com/users/dkua/orgs","repos_url":"https://api.github.com/users/dkua/repos","events_url":"https://api.github.com/users/dkua/events{/privacy}","received_events_url":"https://api.github.com/users/dkua/received_events","type":"User","site_admin":false},"repo":{"id":32657850,"name":"matplotlib","full_name":"dkua/matplotlib","owner":{"login":"dkua","id":1531139,"avatar_url":"https://avatars.githubusercontent.com/u/1531139?v=3","gravatar_id":"","url":"https://api.github.com/users/dkua","html_url":"https://github.com/dkua","followers_url":"https://api.github.com/users/dkua/followers","following_url":"https://api.github.com/users/dkua/following{/other_user}","gists_url":"https://api.github.com/users/dkua/gists{/gist_id}","starred_url":"https://api.github.com/users/dkua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkua/subscriptions","organizations_url":"https://api.github.com/users/dkua/orgs","repos_url":"https://api.github.com/users/dkua/repos","events_url":"https://api.github.com/users/dkua/events{/privacy}","received_events_url":"https://api.github.com/users/dkua/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkua/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/dkua/matplotlib","forks_url":"https://api.github.com/repos/dkua/matplotlib/forks","keys_url":"https://api.github.com/repos/dkua/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkua/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkua/matplotlib/teams","hooks_url":"https://api.github.com/repos/dkua/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/dkua/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/dkua/matplotlib/events","assignees_url":"https://api.github.com/repos/dkua/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/dkua/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/dkua/matplotlib/tags","blobs_url":"https://api.github.com/repos/dkua/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkua/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkua/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkua/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkua/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/dkua/matplotlib/languages","stargazers_url":"https://api.github.com/repos/dkua/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/dkua/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/dkua/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/dkua/matplotlib/subscription","commits_url":"https://api.github.com/repos/dkua/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkua/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkua/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkua/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkua/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/dkua/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkua/matplotlib/merges","archive_url":"https://api.github.com/repos/dkua/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkua/matplotlib/downloads","issues_url":"https://api.github.com/repos/dkua/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/dkua/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/dkua/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/dkua/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkua/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/dkua/matplotlib/releases{/id}","created_at":"2015-03-22T01:52:52Z","updated_at":"2015-03-22T01:52:59Z","pushed_at":"2015-03-31T18:40:01Z","git_url":"git://github.com/dkua/matplotlib.git","ssh_url":"git@github.com:dkua/matplotlib.git","clone_url":"https://github.com/dkua/matplotlib.git","svn_url":"https://github.com/dkua/matplotlib","homepage":"http://matplotlib.org/","size":211196,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"166e9ccfe01e981ea3f4985ab962594bf40c63ea","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","created_at":"2011-02-19T03:17:12Z","updated_at":"2015-03-31T11:23:15Z","pushed_at":"2015-03-31T19:37:00Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":262798,"stargazers_count":2381,"watchers_count":2381,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1200,"mirror_url":null,"open_issues_count":491,"forks":1200,"open_issues":491,"watchers":2381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4259"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/4259"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/4259"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/4259/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4259/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4259/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/039df4b634c8fc8a5ebb48ab3661709aa5ab880a"}}}}