{"action":"created","issue":{"url":"https://api.github.com/repos/borismus/keysocket/issues/99","labels_url":"https://api.github.com/repos/borismus/keysocket/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/borismus/keysocket/issues/99/comments","events_url":"https://api.github.com/repos/borismus/keysocket/issues/99/events","html_url":"https://github.com/borismus/keysocket/pull/99","id":59981222,"number":99,"title":"Standardize/Simplify code style and add STOP functionality","user":{"login":"nemchik","id":725456,"avatar_url":"https://avatars.githubusercontent.com/u/725456?v=3","gravatar_id":"","url":"https://api.github.com/users/nemchik","html_url":"https://github.com/nemchik","followers_url":"https://api.github.com/users/nemchik/followers","following_url":"https://api.github.com/users/nemchik/following{/other_user}","gists_url":"https://api.github.com/users/nemchik/gists{/gist_id}","starred_url":"https://api.github.com/users/nemchik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemchik/subscriptions","organizations_url":"https://api.github.com/users/nemchik/orgs","repos_url":"https://api.github.com/users/nemchik/repos","events_url":"https://api.github.com/users/nemchik/events{/privacy}","received_events_url":"https://api.github.com/users/nemchik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-03-05T17:00:03Z","updated_at":"2015-03-07T14:47:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/borismus/keysocket/pulls/99","html_url":"https://github.com/borismus/keysocket/pull/99","diff_url":"https://github.com/borismus/keysocket/pull/99.diff","patch_url":"https://github.com/borismus/keysocket/pull/99.patch"},"body":"I found lots of places where the code has non standard spacing such as if () rather than if()\r\nI also removed the use of variables being declared for each button that needs to be pressed (there is no need to store this in memory).\r\nI also switched everything to querySelector rather than getElementById or class.\r\n\r\nThese commits make it fairly easy to open almost any file and use it as a template to add a new music payer with very minimal code. This also makes updating the keysocket code to accomodate player changes a little bit simpler.\r\n\r\nAnother point of note (forgot previously) is I made sure the if statements for which key is pressed are in alphabetical order and in the same order for each socket (ex next, play, prev, stop)"},"comment":{"url":"https://api.github.com/repos/borismus/keysocket/issues/comments/77692055","html_url":"https://github.com/borismus/keysocket/pull/99#issuecomment-77692055","issue_url":"https://api.github.com/repos/borismus/keysocket/issues/99","id":77692055,"user":{"login":"feedbee","id":1769193,"avatar_url":"https://avatars.githubusercontent.com/u/1769193?v=3","gravatar_id":"","url":"https://api.github.com/users/feedbee","html_url":"https://github.com/feedbee","followers_url":"https://api.github.com/users/feedbee/followers","following_url":"https://api.github.com/users/feedbee/following{/other_user}","gists_url":"https://api.github.com/users/feedbee/gists{/gist_id}","starred_url":"https://api.github.com/users/feedbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedbee/subscriptions","organizations_url":"https://api.github.com/users/feedbee/orgs","repos_url":"https://api.github.com/users/feedbee/repos","events_url":"https://api.github.com/users/feedbee/events{/privacy}","received_events_url":"https://api.github.com/users/feedbee/received_events","type":"User","site_admin":false},"created_at":"2015-03-07T14:47:42Z","updated_at":"2015-03-07T14:47:42Z","body":"OK, now you have to choose one of: rebase/merge you work (which is hard to do other way than to override #100), or to start from the beginning. Git is good tool, but it requires good understanding of it. Otherwise it will drive you mad.\r\n\r\nWhat if to start from the beginning? By the way, it's better to create Pull Requests from branches in forked repository (not from master). So create new branch like `stop-functionality`, make changes which does nothing other than stop functionality. Test it. Commit it in one commit (less commits is better), push create PR. Let this PR be merged.\r\n\r\nAfter, if you want to do refactoring (like removing redundant variables), do it in another branch and create another PR.\r\n\r\nMay be all of this is not my business, but the reasons I write it are to get safe the work I did in PR #100, and to help you contribute new stop functionality."}}