{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/42886503","id":42886503,"diff_hunk":"@@ -408,7 +408,9 @@ static TEE_Result tee_ta_load_check_shdr(struct shdr *shdr)\n \t\t\t\tSHDR_GET_SIG(shdr), shdr->sig_size);\n out:\n \tcrypto_ops.acipher.free_rsa_public_key(&key);\n-\treturn res;\n+\tif (res != TEE_SUCCESS)\n+\t\treturn TEE_ERROR_SECURITY;\n+\treturn TEE_SUCCESS;","path":"core/arch/arm/kernel/tee_ta_manager.c","position":7,"original_position":7,"commit_id":"7d5942d840bb7f1042d431e6996111bfde6d894a","original_commit_id":"7d5942d840bb7f1042d431e6996111bfde6d894a","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"I guess an exception for that would be OK since the return code doesn't depend on the supplied TA.\r\nShould I update the commit message instead or which do you prefer?","created_at":"2015-10-23T16:43:01Z","updated_at":"2015-10-23T16:43:01Z","html_url":"https://github.com/OP-TEE/optee_os/pull/514#discussion_r42886503","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/514","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/42886503"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/514#discussion_r42886503"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/514"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/514","id":48589951,"html_url":"https://github.com/OP-TEE/optee_os/pull/514","diff_url":"https://github.com/OP-TEE/optee_os/pull/514.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/514.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/514","number":514,"state":"open","locked":false,"title":"core: fix error code for corrupt TA","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"Always return TEE_ERROR_SECURITY if tee_ta_load_check_shdr() fails\r\nin any tests.\r\n\r\nSigned-off-by: Jens Wiklander <jens.wiklander@linaro.org>\r\nTested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)","created_at":"2015-10-23T14:55:36Z","updated_at":"2015-10-23T16:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccb4acc01e7e71a647a54a344432104c5f14e48e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/514/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/514/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/514/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/7d5942d840bb7f1042d431e6996111bfde6d894a","head":{"label":"jenswi-linaro:sign_ta","ref":"sign_ta","sha":"7d5942d840bb7f1042d431e6996111bfde6d894a","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"repo":{"id":20770355,"name":"optee_os","full_name":"jenswi-linaro/optee_os","owner":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jenswi-linaro/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/jenswi-linaro/optee_os","forks_url":"https://api.github.com/repos/jenswi-linaro/optee_os/forks","keys_url":"https://api.github.com/repos/jenswi-linaro/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenswi-linaro/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenswi-linaro/optee_os/teams","hooks_url":"https://api.github.com/repos/jenswi-linaro/optee_os/hooks","issue_events_url":"https://api.github.com/repos/jenswi-linaro/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/jenswi-linaro/optee_os/events","assignees_url":"https://api.github.com/repos/jenswi-linaro/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/jenswi-linaro/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/jenswi-linaro/optee_os/tags","blobs_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenswi-linaro/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/jenswi-linaro/optee_os/languages","stargazers_url":"https://api.github.com/repos/jenswi-linaro/optee_os/stargazers","contributors_url":"https://api.github.com/repos/jenswi-linaro/optee_os/contributors","subscribers_url":"https://api.github.com/repos/jenswi-linaro/optee_os/subscribers","subscription_url":"https://api.github.com/repos/jenswi-linaro/optee_os/subscription","commits_url":"https://api.github.com/repos/jenswi-linaro/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenswi-linaro/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenswi-linaro/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenswi-linaro/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/jenswi-linaro/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenswi-linaro/optee_os/merges","archive_url":"https://api.github.com/repos/jenswi-linaro/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenswi-linaro/optee_os/downloads","issues_url":"https://api.github.com/repos/jenswi-linaro/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/jenswi-linaro/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/jenswi-linaro/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/jenswi-linaro/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenswi-linaro/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/jenswi-linaro/optee_os/releases{/id}","created_at":"2014-06-12T14:26:39Z","updated_at":"2015-05-07T19:34:05Z","pushed_at":"2015-10-23T14:51:46Z","git_url":"git://github.com/jenswi-linaro/optee_os.git","ssh_url":"git@github.com:jenswi-linaro/optee_os.git","clone_url":"https://github.com/jenswi-linaro/optee_os.git","svn_url":"https://github.com/jenswi-linaro/optee_os","homepage":null,"size":4421,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"93074435e20e3c99999733e6d683bbbb3f736b21","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","created_at":"2014-05-26T17:18:57Z","updated_at":"2015-10-15T13:18:18Z","pushed_at":"2015-10-23T16:28:25Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":10911,"stargazers_count":68,"watchers_count":68,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":22,"forks":68,"open_issues":22,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/514"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/514"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/514"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/514/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/514/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/514/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/7d5942d840bb7f1042d431e6996111bfde6d894a"}}}}