{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/44972207","id":44972207,"diff_hunk":"@@ -72,7 +72,10 @@ object GenerateMIMAIgnore {\n         val classSymbol = mirror.classSymbol(Class.forName(className, false, classLoader))\n         val moduleSymbol = mirror.staticModule(className)\n         val directlyPrivateSpark =\n-          isPackagePrivate(classSymbol) || isPackagePrivateModule(moduleSymbol)\n+          isPackagePrivate(classSymbol) ||\n+          isPackagePrivateModule(moduleSymbol) ||\n+          classSymbol.isPrivate ||\n+          classSymbol.isProtected","path":"tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala","position":8,"original_position":8,"commit_id":"39a59bd04560a2ddced7028e4e115b4308f6359f","original_commit_id":"39a59bd04560a2ddced7028e4e115b4308f6359f","user":{"login":"thunterdb","id":7594753,"avatar_url":"https://avatars.githubusercontent.com/u/7594753?v=3","gravatar_id":"","url":"https://api.github.com/users/thunterdb","html_url":"https://github.com/thunterdb","followers_url":"https://api.github.com/users/thunterdb/followers","following_url":"https://api.github.com/users/thunterdb/following{/other_user}","gists_url":"https://api.github.com/users/thunterdb/gists{/gist_id}","starred_url":"https://api.github.com/users/thunterdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunterdb/subscriptions","organizations_url":"https://api.github.com/users/thunterdb/orgs","repos_url":"https://api.github.com/users/thunterdb/repos","events_url":"https://api.github.com/users/thunterdb/events{/privacy}","received_events_url":"https://api.github.com/users/thunterdb/received_events","type":"User","site_admin":false},"body":"After checking the scala specs, the `protected` modifier only affects methods, not classes. I am removing it.","created_at":"2015-11-16T19:44:34Z","updated_at":"2015-11-16T19:44:34Z","html_url":"https://github.com/apache/spark/pull/9697#discussion_r44972207","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/9697","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/44972207"},"html":{"href":"https://github.com/apache/spark/pull/9697#discussion_r44972207"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/9697"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/9697","id":50673461,"html_url":"https://github.com/apache/spark/pull/9697","diff_url":"https://github.com/apache/spark/pull/9697.diff","patch_url":"https://github.com/apache/spark/pull/9697.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/9697","number":9697,"state":"open","locked":false,"title":"[SPARK-11732] Removes some MiMa false positives","user":{"login":"thunterdb","id":7594753,"avatar_url":"https://avatars.githubusercontent.com/u/7594753?v=3","gravatar_id":"","url":"https://api.github.com/users/thunterdb","html_url":"https://github.com/thunterdb","followers_url":"https://api.github.com/users/thunterdb/followers","following_url":"https://api.github.com/users/thunterdb/following{/other_user}","gists_url":"https://api.github.com/users/thunterdb/gists{/gist_id}","starred_url":"https://api.github.com/users/thunterdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunterdb/subscriptions","organizations_url":"https://api.github.com/users/thunterdb/orgs","repos_url":"https://api.github.com/users/thunterdb/repos","events_url":"https://api.github.com/users/thunterdb/events{/privacy}","received_events_url":"https://api.github.com/users/thunterdb/received_events","type":"User","site_admin":false},"body":"This adds an extra filter for private or protected classes. We only filter for package private right now.","created_at":"2015-11-13T18:18:57Z","updated_at":"2015-11-16T19:44:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff535b54826ae83f02b68c7a6ce8f5b16b97cbf1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/9697/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/9697/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/9697/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/39a59bd04560a2ddced7028e4e115b4308f6359f","head":{"label":"thunterdb:spark-11732","ref":"spark-11732","sha":"39a59bd04560a2ddced7028e4e115b4308f6359f","user":{"login":"thunterdb","id":7594753,"avatar_url":"https://avatars.githubusercontent.com/u/7594753?v=3","gravatar_id":"","url":"https://api.github.com/users/thunterdb","html_url":"https://github.com/thunterdb","followers_url":"https://api.github.com/users/thunterdb/followers","following_url":"https://api.github.com/users/thunterdb/following{/other_user}","gists_url":"https://api.github.com/users/thunterdb/gists{/gist_id}","starred_url":"https://api.github.com/users/thunterdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunterdb/subscriptions","organizations_url":"https://api.github.com/users/thunterdb/orgs","repos_url":"https://api.github.com/users/thunterdb/repos","events_url":"https://api.github.com/users/thunterdb/events{/privacy}","received_events_url":"https://api.github.com/users/thunterdb/received_events","type":"User","site_admin":false},"repo":{"id":21404403,"name":"spark","full_name":"thunterdb/spark","owner":{"login":"thunterdb","id":7594753,"avatar_url":"https://avatars.githubusercontent.com/u/7594753?v=3","gravatar_id":"","url":"https://api.github.com/users/thunterdb","html_url":"https://github.com/thunterdb","followers_url":"https://api.github.com/users/thunterdb/followers","following_url":"https://api.github.com/users/thunterdb/following{/other_user}","gists_url":"https://api.github.com/users/thunterdb/gists{/gist_id}","starred_url":"https://api.github.com/users/thunterdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunterdb/subscriptions","organizations_url":"https://api.github.com/users/thunterdb/orgs","repos_url":"https://api.github.com/users/thunterdb/repos","events_url":"https://api.github.com/users/thunterdb/events{/privacy}","received_events_url":"https://api.github.com/users/thunterdb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thunterdb/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/thunterdb/spark","forks_url":"https://api.github.com/repos/thunterdb/spark/forks","keys_url":"https://api.github.com/repos/thunterdb/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thunterdb/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thunterdb/spark/teams","hooks_url":"https://api.github.com/repos/thunterdb/spark/hooks","issue_events_url":"https://api.github.com/repos/thunterdb/spark/issues/events{/number}","events_url":"https://api.github.com/repos/thunterdb/spark/events","assignees_url":"https://api.github.com/repos/thunterdb/spark/assignees{/user}","branches_url":"https://api.github.com/repos/thunterdb/spark/branches{/branch}","tags_url":"https://api.github.com/repos/thunterdb/spark/tags","blobs_url":"https://api.github.com/repos/thunterdb/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thunterdb/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thunterdb/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/thunterdb/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thunterdb/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/thunterdb/spark/languages","stargazers_url":"https://api.github.com/repos/thunterdb/spark/stargazers","contributors_url":"https://api.github.com/repos/thunterdb/spark/contributors","subscribers_url":"https://api.github.com/repos/thunterdb/spark/subscribers","subscription_url":"https://api.github.com/repos/thunterdb/spark/subscription","commits_url":"https://api.github.com/repos/thunterdb/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/thunterdb/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/thunterdb/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/thunterdb/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/thunterdb/spark/contents/{+path}","compare_url":"https://api.github.com/repos/thunterdb/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thunterdb/spark/merges","archive_url":"https://api.github.com/repos/thunterdb/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thunterdb/spark/downloads","issues_url":"https://api.github.com/repos/thunterdb/spark/issues{/number}","pulls_url":"https://api.github.com/repos/thunterdb/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/thunterdb/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/thunterdb/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thunterdb/spark/labels{/name}","releases_url":"https://api.github.com/repos/thunterdb/spark/releases{/id}","created_at":"2014-07-01T22:39:51Z","updated_at":"2014-07-01T19:53:22Z","pushed_at":"2015-11-13T18:20:53Z","git_url":"git://github.com/thunterdb/spark.git","ssh_url":"git@github.com:thunterdb/spark.git","clone_url":"https://github.com/thunterdb/spark.git","svn_url":"https://github.com/thunterdb/spark","homepage":null,"size":121407,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"99693fef0a30432d94556154b81872356d921c64","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-11-16T16:51:48Z","pushed_at":"2015-11-16T19:43:56Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":383946,"stargazers_count":6204,"watchers_count":6204,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5722,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":372,"forks":5722,"open_issues":372,"watchers":6204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/9697"},"html":{"href":"https://github.com/apache/spark/pull/9697"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/9697"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/9697/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/9697/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/9697/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/39a59bd04560a2ddced7028e4e115b4308f6359f"}}}}