{"comment":{"url":"https://api.github.com/repos/jirikuncar/invenio/comments/11881055","html_url":"https://github.com/jirikuncar/invenio/commit/48f13ec175f65cb728e82fbe789bbfba9e8f8503#commitcomment-11881055","id":11881055,"user":{"login":"jirikuncar","id":189798,"avatar_url":"https://avatars.githubusercontent.com/u/189798?v=3","gravatar_id":"","url":"https://api.github.com/users/jirikuncar","html_url":"https://github.com/jirikuncar","followers_url":"https://api.github.com/users/jirikuncar/followers","following_url":"https://api.github.com/users/jirikuncar/following{/other_user}","gists_url":"https://api.github.com/users/jirikuncar/gists{/gist_id}","starred_url":"https://api.github.com/users/jirikuncar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirikuncar/subscriptions","organizations_url":"https://api.github.com/users/jirikuncar/orgs","repos_url":"https://api.github.com/users/jirikuncar/repos","events_url":"https://api.github.com/users/jirikuncar/events{/privacy}","received_events_url":"https://api.github.com/users/jirikuncar/received_events","type":"User","site_admin":false},"position":0,"line":null,"path":"invenio/legacy/search_engine/__init__.py","commit_id":"48f13ec175f65cb728e82fbe789bbfba9e8f8503","created_at":"2015-06-26T12:10:27Z","updated_at":"2015-06-26T12:10:27Z","body":"38:1: I100 Imports statements are in the wrong order. import cgi should be before from invenio.utils.deprecation\n38:1: E402 module level import not at top of file\n39:1: E402 module level import not at top of file\n40:1: E402 module level import not at top of file\n41:1: E402 module level import not at top of file\n42:1: E402 module level import not at top of file\n45:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_BASE_URL, CFG_BIBFORMAT_HIDDEN_TAGS, CFG_BIBINDEX_CHARS_PUNCTUATION, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBSORT_BUCKETS, CFG_BIBSORT_ENABLED, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_LOGDIR, CFG_LOGDIR, CFG_OAI_ID_FIELD, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_URL, CFG_SOLR_URL, CFG_WEBSEARCH_DEF_RECORDS_IN_GROUPS, CFG_WEBSEARCH_DETAILED_META_FORMAT, CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS, CFG_WEBSEARCH_FIELDS_CONVERT, CFG_WEBSEARCH_FULLTEXT_SNIPPETS, CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH, CFG_WEBSEARCH_IDXPAIRS_FIELDS, CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT, CFG_WEBSEARCH_SYNONYM_KBRS, CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_XAPIAN_ENABLED\n45:1: F999 redefinition of unused 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' from line 45\n45:1: F999 redefinition of unused 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' from line 45\n45:1: F999 redefinition of unused 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' from line 45\n45:1: F999 redefinition of unused 'CFG_LOGDIR' from line 45\n45:1: F999 redefinition of unused 'CFG_WEBSEARCH_WILDCARD_LIMIT' from line 45\n45:1: F401 'CFG_XAPIAN_ENABLED' imported but unused\n45:1: F401 'CFG_BIBINDEX_CHARS_PUNCTUATION' imported but unused\n45:1: F401 'CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY' imported but unused\n45:1: F401 'CFG_WEBSEARCH_SYNONYM_KBRS' imported but unused\n45:1: F401 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' imported but unused\n45:1: F401 'CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS' imported but unused\n45:1: F401 'CFG_OAI_ID_FIELD' imported but unused\n45:1: F401 'CFG_WEBSEARCH_FIELDS_CONVERT' imported but unused\n45:1: F401 'CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS' imported but unused\n45:1: F401 'CFG_SITE_RECORD' imported but unused\n45:1: F401 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' imported but unused\n45:1: F401 'CFG_INSPIRE_SITE' imported but unused\n45:1: F401 'CFG_BASE_URL' imported but unused\n45:1: F401 'CFG_LOGDIR' imported but unused\n45:1: F401 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' imported but unused\n45:1: F401 'CFG_BIBSORT_ENABLED' imported but unused\n45:1: F401 'CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT' imported but unused\n45:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused\n45:1: F401 'CFG_WEBSEARCH_WILDCARD_LIMIT' imported but unused\n45:1: F401 'CFG_WEBSEARCH_DETAILED_META_FORMAT' imported but unused\n45:1: F401 'CFG_BIBSORT_BUCKETS' imported but unused\n45:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS' imported but unused\n45:1: F401 'CFG_SOLR_URL' imported but unused\n45:1: F401 'CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH' imported but unused\n45:1: F401 'CFG_WEBSEARCH_IDXPAIRS_FIELDS' imported but unused\n45:1: E402 module level import not at top of file\n46:6: E126 continuation line over-indented for hanging indent\n82:1: E402 module level import not at top of file\n83:1: F401 'get_most_popular_field_values' imported but unused\n83:1: E402 module level import not at top of file\n84:1: I101 Imported names are in the wrong order. Should be InvenioWebSearchCitedbyLimitError, InvenioWebSearchReferstoLimitError, InvenioWebSearchUnknownCollectionError, InvenioWebSearchWildcardLimitError\n84:1: I100 Imports statements are in the wrong order. from invenio.modules.search.errors should be before from invenio.modules.search.utils\n84:1: F401 'InvenioWebSearchUnknownCollectionError' imported but unused\n84:1: F401 'InvenioWebSearchReferstoLimitError' imported but unused\n84:1: F401 'InvenioWebSearchCitedbyLimitError' imported but unused\n84:1: F401 'InvenioWebSearchWildcardLimitError' imported but unused\n84:1: E402 module level import not at top of file\n85:6: E126 continuation line over-indented for hanging indent\n89:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.search.errors\n89:1: F401 'get_fieldvalues_alephseq_like' imported but unused\n89:1: E402 module level import not at top of file\n91:1: E402 module level import not at top of file\n92:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from .utils\n92:1: I201 Missing newline before sections or imports.\n92:1: F401 'record_xml_output' imported but unused\n92:1: F401 'create_record' imported but unused\n92:1: E402 module level import not at top of file\n93:1: F401 'DataCacher' imported but unused\n93:1: E402 module level import not at top of file\n94:1: I101 Imported names are in the wrong order. Should be perform_external_collection_search, print_external_results_overview\n94:1: F401 'perform_external_collection_search' imported but unused\n94:1: F401 'print_external_results_overview' imported but unused\n94:1: E402 module level import not at top of file\n95:1: E402 module level import not at top of file\n96:1: I101 Imported names are in the wrong order. Should be CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS, VIEWRESTRCOLL\n96:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused\n96:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused\n96:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused\n96:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused\n96:1: E402 module level import not at top of file\n102:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.modules.access.local_config\n102:1: F401 'intbitset' imported but unused\n102:1: E402 module level import not at top of file\n103:1: I201 Missing newline before sections or imports.\n103:1: F401 'InvenioDbQueryWildcardLimitError' imported but unused\n103:1: E402 module level import not at top of file\n104:1: F401 'deserialize_via_marshal' imported but unused\n104:1: E402 module level import not at top of file\n105:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.utils.serializers\n105:1: F401 'acc_authorize_action' imported but unused\n105:1: E402 module level import not at top of file\n106:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.access.engine\n106:1: F401 'register_exception' imported but unused\n106:1: E402 module level import not at top of file\n107:1: I101 Imported names are in the wrong order. Should be encode_for_xml, strip_accents, wash_for_utf8\n107:1: F401 'encode_for_xml' imported but unused\n107:1: F401 'wash_for_utf8' imported but unused\n107:1: F401 'strip_accents' imported but unused\n107:1: E402 module level import not at top of file\n108:1: I100 Imports statements are in the wrong order. from invenio.legacy should be before from invenio.utils.text\n108:1: F401 'bibrecord' imported but unused\n108:1: E402 module level import not at top of file\n110:1: I101 Imported names are in the wrong order. Should be get_table_update_time, run_sql, run_sql_with_limit, wash_table_column_name\n110:1: F401 'wash_table_column_name' imported but unused\n110:1: F401 'get_table_update_time' imported but unused\n110:1: F401 'run_sql_with_limit' imported but unused\n110:1: E402 module level import not at top of file\n112:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid\n112:1: F401 'collect_user_info' imported but unused\n112:1: E402 module level import not at top of file\n113:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.webuser\n113:1: E402 module level import not at top of file\n115:1: F401 'apache' imported but unused\n115:1: E402 module level import not at top of file\n117:1: F401 'DatabaseError' imported but unused\n117:1: E402 module level import not at top of file\n122:22: E203 whitespace before ':'\n122:14: E225 missing whitespace around operator\n123:24: E203 whitespace before ':'\n124:24: E203 whitespace before ':'\n125:28: E203 whitespace before ':'\n126:30: E203 whitespace before ':'\n127:24: E203 whitespace before ':'\n128:23: E203 whitespace before ':'\n129:29: E203 whitespace before ':'\n130:26: E203 whitespace before ':'\n131:33: E203 whitespace before ':'\n132:30: E203 whitespace before ':'\n133:30: E203 whitespace before ':'\n134:30: E203 whitespace before ':'\n135:30: E203 whitespace before ':'\n136:30: E203 whitespace before ':'\n137:30: E203 whitespace before ':'\n138:41: E703 statement ends with a semicolon\n140:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from sqlalchemy.exc\n140:1: F401 'collection_restricted_p' imported but unused\n140:1: E402 module level import not at top of file\n141:1: F401 'restricted_collection_cache' imported but unused\n141:1: E402 module level import not at top of file\n142:1: F401 'get_permitted_restricted_collections' imported but unused\n142:1: E402 module level import not at top of file\n145:1: F401 'check_user_can_view_record' imported but unused\n145:1: E402 module level import not at top of file\n147:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio_records.access\n147:1: F401 'get_coll_i18nname' imported but unused\n147:1: E402 module level import not at top of file\n148:1: F401 'get_field_i18nname' imported but unused\n148:1: E402 module level import not at top of file\n151: D401 First line should be in imperative mood ('Create', not 'Creates')\n151: D400 First line should end with a period (not 'n')\n151: D205 1 blank line required between summary line and description (found 0)\n158:1: F403 'from invenio.modules.search.washers import *' used; unable to detect undefined names\n158:1: E402 module level import not at top of file\n161: D401 First line should be in imperative mood ('Return', not 'Returns')\n161: D300 Use \"\"\"triple double quotes\"\"\" (found '-quotes)\n182:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.search.washers\n182:1: F401 'get_collection_allchildren' imported but unused\n182:1: E402 module level import not at top of file\n185: D400 First line should end with a period (not 'o')\n185: D205 1 blank line required between summary line and description (found 0)\n185: D208 Docstring is over-indented\n230:1: F403 'from invenio.modules.search.searchext.engines.native import *' used; unable to detect undefined names\n230:1: E402 module level import not at top of file\n233: D209 Multi-line docstring closing quotes should be on a separate line\n233: D400 First line should end with a period (not 'y')\n233: D205 1 blank line required between summary line and description (found 0)\n233: D208 Docstring is over-indented\n246:38: E203 whitespace before ','\n277:1: E302 expected 2 blank lines, found 0\n277: D209 Multi-line docstring closing quotes should be on a separate line\n277: D400 First line should end with a period (not 'g')\n277: D205 1 blank line required between summary line and description (found 0)\n277: D208 Docstring is over-indented\n306: D209 Multi-line docstring closing quotes should be on a separate line\n306: D205 1 blank line required between summary line and description (found 0)\n319:1: E303 too many blank lines (3)\n319: D103 Missing docstring in public function\n329: D401 First line should be in imperative mood ('calculate', not 'calculates')\n329: D209 Multi-line docstring closing quotes should be on a separate line\n329: D202 No blank lines allowed after function docstring (found 1)\n329: D400 First line should end with a period (not 'e')\n329: D205 1 blank line required between summary line and description (found 0)\n340:20: E261 at least two spaces before inline comment\n344:17: E261 at least two spaces before inline comment\n371:1: E302 expected 2 blank lines, found 1\n389: D210 No whitespaces allowed surrounding docstring text\n389: D400 First line should end with a period (not 'n')\n395:25: E261 at least two spaces before inline comment\n396:13: E222 multiple spaces after operator\n419:10: E261 at least two spaces before inline comment\n436:1: E266 too many leading '#' for block comment\n438: D103 Missing docstring in public function\n439:25: E128 continuation line under-indented for visual indent\n440:25: E128 continuation line under-indented for visual indent\n441:25: E128 continuation line under-indented for visual indent\n442:25: E128 continuation line under-indented for visual indent\n459: D401 First line should be in imperative mood ('Set', not 'Sets')\n459: D202 No blank lines allowed after function docstring (found 1)\n459: D400 First line should end with a period (not 'l')\n459: D200 One-line docstring should fit on one line with quotes (found 3)\n460:23: E128 continuation line under-indented for visual indent\n461:23: E128 continuation line under-indented for visual indent\n462:23: E128 continuation line under-indented for visual indent\n463:23: E128 continuation line under-indented for visual indent\n464:23: E128 continuation line under-indented for visual indent\n502:9: B901 blind except: statement"}}