{"action":"created","issue":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Windows/issues/48","labels_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Windows/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Windows/issues/48/comments","events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Windows/issues/48/events","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Windows/pull/48","id":58952196,"number":48,"title":"Instrument SDK code with logging statements","user":{"login":"maliroteh","id":11096533,"avatar_url":"https://avatars.githubusercontent.com/u/11096533?v=3","gravatar_id":"","url":"https://api.github.com/users/maliroteh","html_url":"https://github.com/maliroteh","followers_url":"https://api.github.com/users/maliroteh/followers","following_url":"https://api.github.com/users/maliroteh/following{/other_user}","gists_url":"https://api.github.com/users/maliroteh/gists{/gist_id}","starred_url":"https://api.github.com/users/maliroteh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maliroteh/subscriptions","organizations_url":"https://api.github.com/users/maliroteh/orgs","repos_url":"https://api.github.com/users/maliroteh/repos","events_url":"https://api.github.com/users/maliroteh/events{/privacy}","received_events_url":"https://api.github.com/users/maliroteh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-25T19:00:02Z","updated_at":"2015-02-27T16:18:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Windows/pulls/48","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Windows/pull/48","diff_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Windows/pull/48.diff","patch_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Windows/pull/48.patch"},"body":"@smcnulty-sfdc @wpeter-sfdc @kchitalia\r\n\r\nThis work is to instrument the SDK code with logging calls. Please take a look and give your feedback. Particularly please let me know if there are any customer sensitive data that I'm currently logging which should not be logged. Thanks"},"comment":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Windows/issues/comments/76421144","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Windows/pull/48#issuecomment-76421144","issue_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Windows/issues/48","id":76421144,"user":{"login":"smcnulty-sfdc","id":2816138,"avatar_url":"https://avatars.githubusercontent.com/u/2816138?v=3","gravatar_id":"","url":"https://api.github.com/users/smcnulty-sfdc","html_url":"https://github.com/smcnulty-sfdc","followers_url":"https://api.github.com/users/smcnulty-sfdc/followers","following_url":"https://api.github.com/users/smcnulty-sfdc/following{/other_user}","gists_url":"https://api.github.com/users/smcnulty-sfdc/gists{/gist_id}","starred_url":"https://api.github.com/users/smcnulty-sfdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcnulty-sfdc/subscriptions","organizations_url":"https://api.github.com/users/smcnulty-sfdc/orgs","repos_url":"https://api.github.com/users/smcnulty-sfdc/repos","events_url":"https://api.github.com/users/smcnulty-sfdc/events{/privacy}","received_events_url":"https://api.github.com/users/smcnulty-sfdc/received_events","type":"User","site_admin":false},"created_at":"2015-02-27T16:18:14Z","updated_at":"2015-02-27T16:18:14Z","body":"1) There should be some level of control over how much is logged; right now it's extremely verbose and there is no control over if some of it should only exist in debug builds vs release. For example you log in one method that WipePincode is being called, and then in WipePincode you have an additional 4 log statements.  A better design would be to have a log statement at the start of each method saying it is called, instead of adding a log statement before every instance of the method when it is being used. \r\n\r\n2) I question all of the extra logging being added to the SDK in general.  I support logging when exceptions are being caught, and perhaps adding a log statement for the entry of a method that is considered critical, but not adding a log statement for every line of code.\r\n\r\nI can't approve this as is."}}