{"action":"created","issue":{"url":"https://api.github.com/repos/awesomeWM/awesome/issues/133","labels_url":"https://api.github.com/repos/awesomeWM/awesome/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/issues/133/comments","events_url":"https://api.github.com/repos/awesomeWM/awesome/issues/133/events","html_url":"https://github.com/awesomeWM/awesome/pull/133","id":57754995,"number":133,"title":"Add functional tests via Xephyr/Xvfb/xdotool","user":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/awesomeWM/awesome/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-16T00:56:28Z","updated_at":"2015-02-20T07:54:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/133","html_url":"https://github.com/awesomeWM/awesome/pull/133","diff_url":"https://github.com/awesomeWM/awesome/pull/133.diff","patch_url":"https://github.com/awesomeWM/awesome/pull/133.patch"},"body":"Run it via `t/run.sh`.\r\n\r\nRelated issues: #136 (Travis integration in general).\r\n\r\nBuild status of this branch: [![Build Status](https://travis-ci.org/blueyed/awesome.svg?branch=add-functional-tests)](https://travis-ci.org/blueyed/awesome)\r\n\r\nIt currently uses a pre-built Debian chroot to run the tests in.  A lot of packages are too old on Travis and I've figured that it might be easier to use Debian testing right away.\r\nUsing the pre-built images makes the tests run much faster.  This could be achieved by using Travis' cache facilities, but these are only available for container based environments (where `sudo` would not be available).  `sudo` is required for `chroot` (as long as `fakechroot` or something similar is not installed).\r\n\r\nTODO:\r\n\r\n - [ ] This might make use of `busted` (more), instead of only using the custom runner.  Needs to be investigated / refactored then.\r\n - [ ] `W: awesome: a_dbus_connect:607: D-Bus session bus system failed: Failed to connect to socket /var/run/dbus/system_bus_socket: No such file or directory`: this could be avoided by bind-mounting `/mnt/debian/var/run/dbus` and `/mnt/debian/var/lib/dbus` probably, but it's not an issue really, is it?"},"comment":{"url":"https://api.github.com/repos/awesomeWM/awesome/issues/comments/75201809","html_url":"https://github.com/awesomeWM/awesome/pull/133#issuecomment-75201809","issue_url":"https://api.github.com/repos/awesomeWM/awesome/issues/133","id":75201809,"user":{"login":"psychon","id":89482,"avatar_url":"https://avatars.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"created_at":"2015-02-20T07:54:50Z","updated_at":"2015-02-20T07:54:50Z","body":"Small comments that have for now: Some of this looks fragile, I don't understand why this has to download a debian chroot from the internet for the tests (nor do I really know the envirionment in which travis works) and finally: These files will end up in release tarballs! IMO we should try to make stuff as small as possible."}}