{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/38821661","id":38821661,"diff_hunk":"@@ -74,7 +73,9 @@ var (\n \tdomap = &domainMap{\n \t\tdomains: map[string]*domain.Domain{},\n \t}\n-\tstores = make(map[string]kv.Driver)\n+\tstores    = make(map[string]kv.Driver)","path":"tidb.go","position":17,"original_position":17,"commit_id":"7adf722a535e25c6abc0e605439380b981054e3d","original_commit_id":"7adf722a535e25c6abc0e605439380b981054e3d","user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"body":"That is why I did not comment on your change. We need to change all of them.","created_at":"2015-09-06T13:56:12Z","updated_at":"2015-09-06T13:56:12Z","html_url":"https://github.com/pingcap/tidb/pull/17#discussion_r38821661","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/38821661"},"html":{"href":"https://github.com/pingcap/tidb/pull/17#discussion_r38821661"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/17","id":44300868,"html_url":"https://github.com/pingcap/tidb/pull/17","diff_url":"https://github.com/pingcap/tidb/pull/17.diff","patch_url":"https://github.com/pingcap/tidb/pull/17.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/17","number":17,"state":"closed","locked":false,"title":"Allow uses to shutdown the pprof","user":{"login":"astaxie","id":233907,"avatar_url":"https://avatars.githubusercontent.com/u/233907?v=3","gravatar_id":"","url":"https://api.github.com/users/astaxie","html_url":"https://github.com/astaxie","followers_url":"https://api.github.com/users/astaxie/followers","following_url":"https://api.github.com/users/astaxie/following{/other_user}","gists_url":"https://api.github.com/users/astaxie/gists{/gist_id}","starred_url":"https://api.github.com/users/astaxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaxie/subscriptions","organizations_url":"https://api.github.com/users/astaxie/orgs","repos_url":"https://api.github.com/users/astaxie/repos","events_url":"https://api.github.com/users/astaxie/events{/privacy}","received_events_url":"https://api.github.com/users/astaxie/received_events","type":"User","site_admin":false},"body":"pprof looks like a debug tools. So I think the default should turn off.\r\nAnd if pporf turn on, user can also change the pprof addr.","created_at":"2015-09-06T11:19:19Z","updated_at":"2015-09-06T13:56:12Z","closed_at":"2015-09-06T13:49:37Z","merged_at":"2015-09-06T13:49:37Z","merge_commit_sha":"802be7f322e06f3897135a707ea75391ed8519cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/17/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/17/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/17/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/7adf722a535e25c6abc0e605439380b981054e3d","head":{"label":"astaxie:master","ref":"master","sha":"7adf722a535e25c6abc0e605439380b981054e3d","user":{"login":"astaxie","id":233907,"avatar_url":"https://avatars.githubusercontent.com/u/233907?v=3","gravatar_id":"","url":"https://api.github.com/users/astaxie","html_url":"https://github.com/astaxie","followers_url":"https://api.github.com/users/astaxie/followers","following_url":"https://api.github.com/users/astaxie/following{/other_user}","gists_url":"https://api.github.com/users/astaxie/gists{/gist_id}","starred_url":"https://api.github.com/users/astaxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaxie/subscriptions","organizations_url":"https://api.github.com/users/astaxie/orgs","repos_url":"https://api.github.com/users/astaxie/repos","events_url":"https://api.github.com/users/astaxie/events{/privacy}","received_events_url":"https://api.github.com/users/astaxie/received_events","type":"User","site_admin":false},"repo":{"id":41996346,"name":"tidb","full_name":"astaxie/tidb","owner":{"login":"astaxie","id":233907,"avatar_url":"https://avatars.githubusercontent.com/u/233907?v=3","gravatar_id":"","url":"https://api.github.com/users/astaxie","html_url":"https://github.com/astaxie","followers_url":"https://api.github.com/users/astaxie/followers","following_url":"https://api.github.com/users/astaxie/following{/other_user}","gists_url":"https://api.github.com/users/astaxie/gists{/gist_id}","starred_url":"https://api.github.com/users/astaxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaxie/subscriptions","organizations_url":"https://api.github.com/users/astaxie/orgs","repos_url":"https://api.github.com/users/astaxie/repos","events_url":"https://api.github.com/users/astaxie/events{/privacy}","received_events_url":"https://api.github.com/users/astaxie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/astaxie/tidb","description":"TiDB is a distributed SQL database.","fork":true,"url":"https://api.github.com/repos/astaxie/tidb","forks_url":"https://api.github.com/repos/astaxie/tidb/forks","keys_url":"https://api.github.com/repos/astaxie/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astaxie/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astaxie/tidb/teams","hooks_url":"https://api.github.com/repos/astaxie/tidb/hooks","issue_events_url":"https://api.github.com/repos/astaxie/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/astaxie/tidb/events","assignees_url":"https://api.github.com/repos/astaxie/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/astaxie/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/astaxie/tidb/tags","blobs_url":"https://api.github.com/repos/astaxie/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astaxie/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astaxie/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/astaxie/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astaxie/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/astaxie/tidb/languages","stargazers_url":"https://api.github.com/repos/astaxie/tidb/stargazers","contributors_url":"https://api.github.com/repos/astaxie/tidb/contributors","subscribers_url":"https://api.github.com/repos/astaxie/tidb/subscribers","subscription_url":"https://api.github.com/repos/astaxie/tidb/subscription","commits_url":"https://api.github.com/repos/astaxie/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/astaxie/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/astaxie/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/astaxie/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/astaxie/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/astaxie/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astaxie/tidb/merges","archive_url":"https://api.github.com/repos/astaxie/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astaxie/tidb/downloads","issues_url":"https://api.github.com/repos/astaxie/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/astaxie/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/astaxie/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/astaxie/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astaxie/tidb/labels{/name}","releases_url":"https://api.github.com/repos/astaxie/tidb/releases{/id}","created_at":"2015-09-06T09:15:40Z","updated_at":"2015-09-06T09:15:41Z","pushed_at":"2015-09-06T13:46:45Z","git_url":"git://github.com/astaxie/tidb.git","ssh_url":"git@github.com:astaxie/tidb.git","clone_url":"https://github.com/astaxie/tidb.git","svn_url":"https://github.com/astaxie/tidb","homepage":"","size":993,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"397f8ad39aa51ea8beacfc5c81340fc213fd72f1","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed SQL database.","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","created_at":"2015-09-06T04:01:52Z","updated_at":"2015-09-06T13:51:28Z","pushed_at":"2015-09-06T13:49:37Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"","size":1347,"stargazers_count":452,"watchers_count":452,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":4,"forks":73,"open_issues":4,"watchers":452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/17"},"html":{"href":"https://github.com/pingcap/tidb/pull/17"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/17"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/7adf722a535e25c6abc0e605439380b981054e3d"}}}}