{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/30853285","id":30853285,"diff_hunk":"@@ -1266,9 +1265,10 @@\n    as the factsets will have changed while the transaction was in-flight.\"\n   [{:keys [certname producer_timestamp] :as fact-data} :- facts-schema]\n   (time! (:replace-facts performance-metrics)\n-         (if-let [factset-producer-ts (factset-producer-timestamp certname)]\n-           (when (.before factset-producer-ts (to-timestamp producer_timestamp))\n-             (update-facts! fact-data))\n+         (if-let [local-factset-producer-ts (factset-producer-timestamp certname)]\n+           (if (not (.after local-factset-producer-ts (to-timestamp producer_timestamp)))","path":"src/puppetlabs/puppetdb/scf/storage.clj","position":39,"original_position":39,"commit_id":"ba827fec0519581a20733e3dbd2a9af9be79228e","original_commit_id":"ba827fec0519581a20733e3dbd2a9af9be79228e","user":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"body":"`if-not`","created_at":"2015-05-21T22:09:52Z","updated_at":"2015-05-21T22:09:52Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/1411#discussion_r30853285","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1411","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/30853285"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1411#discussion_r30853285"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1411"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1411","id":35976916,"html_url":"https://github.com/puppetlabs/puppetdb/pull/1411","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1411.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1411.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1411","number":1411,"state":"open","locked":false,"title":"(maint) Fix factset up-to-date checks","user":{"login":"mullr","id":24409,"avatar_url":"https://avatars.githubusercontent.com/u/24409?v=3","gravatar_id":"","url":"https://api.github.com/users/mullr","html_url":"https://github.com/mullr","followers_url":"https://api.github.com/users/mullr/followers","following_url":"https://api.github.com/users/mullr/following{/other_user}","gists_url":"https://api.github.com/users/mullr/gists{/gist_id}","starred_url":"https://api.github.com/users/mullr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mullr/subscriptions","organizations_url":"https://api.github.com/users/mullr/orgs","repos_url":"https://api.github.com/users/mullr/repos","events_url":"https://api.github.com/users/mullr/events{/privacy}","received_events_url":"https://api.github.com/users/mullr/received_events","type":"User","site_admin":false},"body":"To allow sync convergence when there are conflicting writes to two \r\nnodes, the factset up-to-date check needs to allow records whose\r\nproducer_timestamp is equal to the existing producer_timestamp. This is\r\nthe same as the replace-catalog command's current behavior. \r\n\r\nAlso include reports in the deactivate-node up-to-date check, using\r\ntheir producer_timestamp field.","created_at":"2015-05-21T20:58:59Z","updated_at":"2015-05-21T22:09:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63b89c15d7c4ca09efc817db4337a117e5260c04","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1411/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1411/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1411/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/ba827fec0519581a20733e3dbd2a9af9be79228e","head":{"label":"mullr:maint/master/fix-factset-time-check","ref":"maint/master/fix-factset-time-check","sha":"ba827fec0519581a20733e3dbd2a9af9be79228e","user":{"login":"mullr","id":24409,"avatar_url":"https://avatars.githubusercontent.com/u/24409?v=3","gravatar_id":"","url":"https://api.github.com/users/mullr","html_url":"https://github.com/mullr","followers_url":"https://api.github.com/users/mullr/followers","following_url":"https://api.github.com/users/mullr/following{/other_user}","gists_url":"https://api.github.com/users/mullr/gists{/gist_id}","starred_url":"https://api.github.com/users/mullr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mullr/subscriptions","organizations_url":"https://api.github.com/users/mullr/orgs","repos_url":"https://api.github.com/users/mullr/repos","events_url":"https://api.github.com/users/mullr/events{/privacy}","received_events_url":"https://api.github.com/users/mullr/received_events","type":"User","site_admin":false},"repo":{"id":30666123,"name":"puppetdb","full_name":"mullr/puppetdb","owner":{"login":"mullr","id":24409,"avatar_url":"https://avatars.githubusercontent.com/u/24409?v=3","gravatar_id":"","url":"https://api.github.com/users/mullr","html_url":"https://github.com/mullr","followers_url":"https://api.github.com/users/mullr/followers","following_url":"https://api.github.com/users/mullr/following{/other_user}","gists_url":"https://api.github.com/users/mullr/gists{/gist_id}","starred_url":"https://api.github.com/users/mullr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mullr/subscriptions","organizations_url":"https://api.github.com/users/mullr/orgs","repos_url":"https://api.github.com/users/mullr/repos","events_url":"https://api.github.com/users/mullr/events{/privacy}","received_events_url":"https://api.github.com/users/mullr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mullr/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/mullr/puppetdb","forks_url":"https://api.github.com/repos/mullr/puppetdb/forks","keys_url":"https://api.github.com/repos/mullr/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mullr/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mullr/puppetdb/teams","hooks_url":"https://api.github.com/repos/mullr/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/mullr/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/mullr/puppetdb/events","assignees_url":"https://api.github.com/repos/mullr/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/mullr/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/mullr/puppetdb/tags","blobs_url":"https://api.github.com/repos/mullr/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mullr/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mullr/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mullr/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mullr/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/mullr/puppetdb/languages","stargazers_url":"https://api.github.com/repos/mullr/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/mullr/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/mullr/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/mullr/puppetdb/subscription","commits_url":"https://api.github.com/repos/mullr/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mullr/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mullr/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mullr/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mullr/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/mullr/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mullr/puppetdb/merges","archive_url":"https://api.github.com/repos/mullr/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mullr/puppetdb/downloads","issues_url":"https://api.github.com/repos/mullr/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/mullr/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/mullr/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/mullr/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mullr/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/mullr/puppetdb/releases{/id}","created_at":"2015-02-11T19:42:39Z","updated_at":"2015-02-11T19:42:40Z","pushed_at":"2015-05-21T20:58:30Z","git_url":"git://github.com/mullr/puppetdb.git","ssh_url":"git@github.com:mullr/puppetdb.git","clone_url":"https://github.com/mullr/puppetdb.git","svn_url":"https://github.com/mullr/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":12939,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"2fd7904690e1e27d348c2aff6ec67138c09fb507","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","created_at":"2011-08-11T18:54:46Z","updated_at":"2015-05-18T09:33:49Z","pushed_at":"2015-05-21T20:58:59Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":22344,"stargazers_count":158,"watchers_count":158,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":8,"forks":129,"open_issues":8,"watchers":158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1411"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1411"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1411"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1411/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1411/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1411/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/ba827fec0519581a20733e3dbd2a9af9be79228e"}}}}