{"action":"closed","number":491,"pull_request":{"url":"https://api.github.com/repos/grails/grails-core/pulls/491","id":15464510,"html_url":"https://github.com/grails/grails-core/pull/491","diff_url":"https://github.com/grails/grails-core/pull/491.diff","patch_url":"https://github.com/grails/grails-core/pull/491.patch","issue_url":"https://api.github.com/repos/grails/grails-core/issues/491","number":491,"state":"closed","locked":false,"title":"Use a new ClassLoader for each GSP","user":{"login":"candrews","id":194713,"avatar_url":"https://avatars.githubusercontent.com/u/194713?v=3","gravatar_id":"","url":"https://api.github.com/users/candrews","html_url":"https://github.com/candrews","followers_url":"https://api.github.com/users/candrews/followers","following_url":"https://api.github.com/users/candrews/following{/other_user}","gists_url":"https://api.github.com/users/candrews/gists{/gist_id}","starred_url":"https://api.github.com/users/candrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candrews/subscriptions","organizations_url":"https://api.github.com/users/candrews/orgs","repos_url":"https://api.github.com/users/candrews/repos","events_url":"https://api.github.com/users/candrews/events{/privacy}","received_events_url":"https://api.github.com/users/candrews/received_events","type":"User","site_admin":false},"body":"Since ClassLoaders keep references to all classes they load, using one class loader for all GSPs means that all GSPs always stay in memory - even if they're never used again (such as if a new version of that GSP is loaded because its source changed). Using a new ClassLoader for each GSP solves that problem.\r\nThis further improves the memory use of Grails when doing GSP reloading, see \r\nGRAILS-11296","created_at":"2014-05-03T17:35:40Z","updated_at":"2015-01-12T19:26:17Z","closed_at":"2015-01-12T19:26:17Z","merged_at":null,"merge_commit_sha":"afc808572c897bf2a8627605ba6a161ad0ecf27e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grails/grails-core/pulls/491/commits","review_comments_url":"https://api.github.com/repos/grails/grails-core/pulls/491/comments","review_comment_url":"https://api.github.com/repos/grails/grails-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/grails/grails-core/issues/491/comments","statuses_url":"https://api.github.com/repos/grails/grails-core/statuses/cf9bd9ef884fec2e7e087074e1a5d47042f28143","head":{"label":"candrews:patch-9","ref":"patch-9","sha":"cf9bd9ef884fec2e7e087074e1a5d47042f28143","user":{"login":"candrews","id":194713,"avatar_url":"https://avatars.githubusercontent.com/u/194713?v=3","gravatar_id":"","url":"https://api.github.com/users/candrews","html_url":"https://github.com/candrews","followers_url":"https://api.github.com/users/candrews/followers","following_url":"https://api.github.com/users/candrews/following{/other_user}","gists_url":"https://api.github.com/users/candrews/gists{/gist_id}","starred_url":"https://api.github.com/users/candrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candrews/subscriptions","organizations_url":"https://api.github.com/users/candrews/orgs","repos_url":"https://api.github.com/users/candrews/repos","events_url":"https://api.github.com/users/candrews/events{/privacy}","received_events_url":"https://api.github.com/users/candrews/received_events","type":"User","site_admin":false},"repo":{"id":7046374,"name":"grails-core","full_name":"candrews/grails-core","owner":{"login":"candrews","id":194713,"avatar_url":"https://avatars.githubusercontent.com/u/194713?v=3","gravatar_id":"","url":"https://api.github.com/users/candrews","html_url":"https://github.com/candrews","followers_url":"https://api.github.com/users/candrews/followers","following_url":"https://api.github.com/users/candrews/following{/other_user}","gists_url":"https://api.github.com/users/candrews/gists{/gist_id}","starred_url":"https://api.github.com/users/candrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candrews/subscriptions","organizations_url":"https://api.github.com/users/candrews/orgs","repos_url":"https://api.github.com/users/candrews/repos","events_url":"https://api.github.com/users/candrews/events{/privacy}","received_events_url":"https://api.github.com/users/candrews/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/candrews/grails-core","description":"The Grails Web Application Framework","fork":true,"url":"https://api.github.com/repos/candrews/grails-core","forks_url":"https://api.github.com/repos/candrews/grails-core/forks","keys_url":"https://api.github.com/repos/candrews/grails-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candrews/grails-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candrews/grails-core/teams","hooks_url":"https://api.github.com/repos/candrews/grails-core/hooks","issue_events_url":"https://api.github.com/repos/candrews/grails-core/issues/events{/number}","events_url":"https://api.github.com/repos/candrews/grails-core/events","assignees_url":"https://api.github.com/repos/candrews/grails-core/assignees{/user}","branches_url":"https://api.github.com/repos/candrews/grails-core/branches{/branch}","tags_url":"https://api.github.com/repos/candrews/grails-core/tags","blobs_url":"https://api.github.com/repos/candrews/grails-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candrews/grails-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candrews/grails-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/candrews/grails-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candrews/grails-core/statuses/{sha}","languages_url":"https://api.github.com/repos/candrews/grails-core/languages","stargazers_url":"https://api.github.com/repos/candrews/grails-core/stargazers","contributors_url":"https://api.github.com/repos/candrews/grails-core/contributors","subscribers_url":"https://api.github.com/repos/candrews/grails-core/subscribers","subscription_url":"https://api.github.com/repos/candrews/grails-core/subscription","commits_url":"https://api.github.com/repos/candrews/grails-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/candrews/grails-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/candrews/grails-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/candrews/grails-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/candrews/grails-core/contents/{+path}","compare_url":"https://api.github.com/repos/candrews/grails-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candrews/grails-core/merges","archive_url":"https://api.github.com/repos/candrews/grails-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candrews/grails-core/downloads","issues_url":"https://api.github.com/repos/candrews/grails-core/issues{/number}","pulls_url":"https://api.github.com/repos/candrews/grails-core/pulls{/number}","milestones_url":"https://api.github.com/repos/candrews/grails-core/milestones{/number}","notifications_url":"https://api.github.com/repos/candrews/grails-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candrews/grails-core/labels{/name}","releases_url":"https://api.github.com/repos/candrews/grails-core/releases{/id}","created_at":"2012-12-07T02:11:08Z","updated_at":"2014-07-30T19:55:29Z","pushed_at":"2015-01-09T16:07:41Z","git_url":"git://github.com/candrews/grails-core.git","ssh_url":"git@github.com:candrews/grails-core.git","clone_url":"https://github.com/candrews/grails-core.git","svn_url":"https://github.com/candrews/grails-core","homepage":"http://grails.org","size":322586,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grails:2.3.x","ref":"2.3.x","sha":"17319ba219d74798139433bbc79b793f3b372620","user":{"login":"grails","id":64546,"avatar_url":"https://avatars.githubusercontent.com/u/64546?v=3","gravatar_id":"","url":"https://api.github.com/users/grails","html_url":"https://github.com/grails","followers_url":"https://api.github.com/users/grails/followers","following_url":"https://api.github.com/users/grails/following{/other_user}","gists_url":"https://api.github.com/users/grails/gists{/gist_id}","starred_url":"https://api.github.com/users/grails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails/subscriptions","organizations_url":"https://api.github.com/users/grails/orgs","repos_url":"https://api.github.com/users/grails/repos","events_url":"https://api.github.com/users/grails/events{/privacy}","received_events_url":"https://api.github.com/users/grails/received_events","type":"Organization","site_admin":false},"repo":{"id":512295,"name":"grails-core","full_name":"grails/grails-core","owner":{"login":"grails","id":64546,"avatar_url":"https://avatars.githubusercontent.com/u/64546?v=3","gravatar_id":"","url":"https://api.github.com/users/grails","html_url":"https://github.com/grails","followers_url":"https://api.github.com/users/grails/followers","following_url":"https://api.github.com/users/grails/following{/other_user}","gists_url":"https://api.github.com/users/grails/gists{/gist_id}","starred_url":"https://api.github.com/users/grails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails/subscriptions","organizations_url":"https://api.github.com/users/grails/orgs","repos_url":"https://api.github.com/users/grails/repos","events_url":"https://api.github.com/users/grails/events{/privacy}","received_events_url":"https://api.github.com/users/grails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grails/grails-core","description":"The Grails Web Application Framework","fork":false,"url":"https://api.github.com/repos/grails/grails-core","forks_url":"https://api.github.com/repos/grails/grails-core/forks","keys_url":"https://api.github.com/repos/grails/grails-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grails/grails-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grails/grails-core/teams","hooks_url":"https://api.github.com/repos/grails/grails-core/hooks","issue_events_url":"https://api.github.com/repos/grails/grails-core/issues/events{/number}","events_url":"https://api.github.com/repos/grails/grails-core/events","assignees_url":"https://api.github.com/repos/grails/grails-core/assignees{/user}","branches_url":"https://api.github.com/repos/grails/grails-core/branches{/branch}","tags_url":"https://api.github.com/repos/grails/grails-core/tags","blobs_url":"https://api.github.com/repos/grails/grails-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grails/grails-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grails/grails-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/grails/grails-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grails/grails-core/statuses/{sha}","languages_url":"https://api.github.com/repos/grails/grails-core/languages","stargazers_url":"https://api.github.com/repos/grails/grails-core/stargazers","contributors_url":"https://api.github.com/repos/grails/grails-core/contributors","subscribers_url":"https://api.github.com/repos/grails/grails-core/subscribers","subscription_url":"https://api.github.com/repos/grails/grails-core/subscription","commits_url":"https://api.github.com/repos/grails/grails-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/grails/grails-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/grails/grails-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/grails/grails-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/grails/grails-core/contents/{+path}","compare_url":"https://api.github.com/repos/grails/grails-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grails/grails-core/merges","archive_url":"https://api.github.com/repos/grails/grails-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grails/grails-core/downloads","issues_url":"https://api.github.com/repos/grails/grails-core/issues{/number}","pulls_url":"https://api.github.com/repos/grails/grails-core/pulls{/number}","milestones_url":"https://api.github.com/repos/grails/grails-core/milestones{/number}","notifications_url":"https://api.github.com/repos/grails/grails-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grails/grails-core/labels{/name}","releases_url":"https://api.github.com/repos/grails/grails-core/releases{/id}","created_at":"2010-02-10T23:57:57Z","updated_at":"2015-01-12T14:08:39Z","pushed_at":"2015-01-12T14:08:39Z","git_url":"git://github.com/grails/grails-core.git","ssh_url":"git@github.com:grails/grails-core.git","clone_url":"https://github.com/grails/grails-core.git","svn_url":"https://github.com/grails/grails-core","homepage":"http://grails.org","size":404402,"stargazers_count":1144,"watchers_count":1144,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":567,"mirror_url":null,"open_issues_count":12,"forks":567,"open_issues":12,"watchers":1144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grails/grails-core/pulls/491"},"html":{"href":"https://github.com/grails/grails-core/pull/491"},"issue":{"href":"https://api.github.com/repos/grails/grails-core/issues/491"},"comments":{"href":"https://api.github.com/repos/grails/grails-core/issues/491/comments"},"review_comments":{"href":"https://api.github.com/repos/grails/grails-core/pulls/491/comments"},"review_comment":{"href":"https://api.github.com/repos/grails/grails-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/grails/grails-core/pulls/491/commits"},"statuses":{"href":"https://api.github.com/repos/grails/grails-core/statuses/cf9bd9ef884fec2e7e087074e1a5d47042f28143"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":19,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}