{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/23529041","id":23529041,"diff_hunk":"@@ -23,6 +23,7 @@\n \n     <script defer src=\"js/controller_communications.js\"></script>\n     <script defer src=\"js/call_screen_ui_minified.js\"></script>\n+    <script defer src=\"../js/helpers/codec_helper.js\"></script>","path":"app/call_screen/call.html","position":4,"original_position":4,"commit_id":"01c2b6d30fb799fef427cbb75c0f0a82bb32e893","original_commit_id":"01c2b6d30fb799fef427cbb75c0f0a82bb32e893","user":{"login":"jaoo","id":690184,"avatar_url":"https://avatars.githubusercontent.com/u/690184?v=3","gravatar_id":"","url":"https://api.github.com/users/jaoo","html_url":"https://github.com/jaoo","followers_url":"https://api.github.com/users/jaoo/followers","following_url":"https://api.github.com/users/jaoo/following{/other_user}","gists_url":"https://api.github.com/users/jaoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jaoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaoo/subscriptions","organizations_url":"https://api.github.com/users/jaoo/orgs","repos_url":"https://api.github.com/users/jaoo/repos","events_url":"https://api.github.com/users/jaoo/events{/privacy}","received_events_url":"https://api.github.com/users/jaoo/received_events","type":"User","site_admin":false},"body":"Same as we commented at https://github.com/mozilla-b2g/firefoxos-loop-client/pull/498/files#r23528665","created_at":"2015-01-26T13:14:41Z","updated_at":"2015-01-26T13:14:41Z","html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/479#discussion_r23529041","pull_request_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/479","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/23529041"},"html":{"href":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/479#discussion_r23529041"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/479"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/479","id":27619772,"html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/479","diff_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/479.diff","patch_url":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/479.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/479","number":479,"state":"open","locked":false,"title":"Bug 1121338 - [Loop] Audio/Video codec identification for Rooms","user":{"login":"opatinowebrtc","id":9033045,"avatar_url":"https://avatars.githubusercontent.com/u/9033045?v=3","gravatar_id":"","url":"https://api.github.com/users/opatinowebrtc","html_url":"https://github.com/opatinowebrtc","followers_url":"https://api.github.com/users/opatinowebrtc/followers","following_url":"https://api.github.com/users/opatinowebrtc/following{/other_user}","gists_url":"https://api.github.com/users/opatinowebrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/opatinowebrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opatinowebrtc/subscriptions","organizations_url":"https://api.github.com/users/opatinowebrtc/orgs","repos_url":"https://api.github.com/users/opatinowebrtc/repos","events_url":"https://api.github.com/users/opatinowebrtc/events{/privacy}","received_events_url":"https://api.github.com/users/opatinowebrtc/received_events","type":"User","site_admin":false},"body":"This code, for rooms, is exactly the same that the one in call_screen/js/call_manager.js (conversations).\r\nMaybe it should be convenient to create a new file with all video measurements and info in a unique such file so these common functions and constants should be written once?","created_at":"2015-01-19T16:44:03Z","updated_at":"2015-01-26T13:14:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df888dd7e730a4565bac462d9a17da5a68caa4c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/479/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/479/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/479/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/01c2b6d30fb799fef427cbb75c0f0a82bb32e893","head":{"label":"opatinowebrtc:bug1121338_av_codec_identification","ref":"bug1121338_av_codec_identification","sha":"01c2b6d30fb799fef427cbb75c0f0a82bb32e893","user":{"login":"opatinowebrtc","id":9033045,"avatar_url":"https://avatars.githubusercontent.com/u/9033045?v=3","gravatar_id":"","url":"https://api.github.com/users/opatinowebrtc","html_url":"https://github.com/opatinowebrtc","followers_url":"https://api.github.com/users/opatinowebrtc/followers","following_url":"https://api.github.com/users/opatinowebrtc/following{/other_user}","gists_url":"https://api.github.com/users/opatinowebrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/opatinowebrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opatinowebrtc/subscriptions","organizations_url":"https://api.github.com/users/opatinowebrtc/orgs","repos_url":"https://api.github.com/users/opatinowebrtc/repos","events_url":"https://api.github.com/users/opatinowebrtc/events{/privacy}","received_events_url":"https://api.github.com/users/opatinowebrtc/received_events","type":"User","site_admin":false},"repo":{"id":24837956,"name":"firefoxos-loop-client","full_name":"opatinowebrtc/firefoxos-loop-client","owner":{"login":"opatinowebrtc","id":9033045,"avatar_url":"https://avatars.githubusercontent.com/u/9033045?v=3","gravatar_id":"","url":"https://api.github.com/users/opatinowebrtc","html_url":"https://github.com/opatinowebrtc","followers_url":"https://api.github.com/users/opatinowebrtc/followers","following_url":"https://api.github.com/users/opatinowebrtc/following{/other_user}","gists_url":"https://api.github.com/users/opatinowebrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/opatinowebrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opatinowebrtc/subscriptions","organizations_url":"https://api.github.com/users/opatinowebrtc/orgs","repos_url":"https://api.github.com/users/opatinowebrtc/repos","events_url":"https://api.github.com/users/opatinowebrtc/events{/privacy}","received_events_url":"https://api.github.com/users/opatinowebrtc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/opatinowebrtc/firefoxos-loop-client","description":"Firefox OS client for the Loop service","fork":true,"url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client","forks_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/forks","keys_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/teams","hooks_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/hooks","issue_events_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/issues/events{/number}","events_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/events","assignees_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/assignees{/user}","branches_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/branches{/branch}","tags_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/tags","blobs_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/statuses/{sha}","languages_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/languages","stargazers_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/stargazers","contributors_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/contributors","subscribers_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/subscribers","subscription_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/subscription","commits_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/contents/{+path}","compare_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/merges","archive_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/downloads","issues_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/issues{/number}","pulls_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/pulls{/number}","milestones_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/milestones{/number}","notifications_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/labels{/name}","releases_url":"https://api.github.com/repos/opatinowebrtc/firefoxos-loop-client/releases{/id}","created_at":"2014-10-06T07:59:02Z","updated_at":"2015-01-19T10:23:07Z","pushed_at":"2015-01-26T10:28:30Z","git_url":"git://github.com/opatinowebrtc/firefoxos-loop-client.git","ssh_url":"git@github.com:opatinowebrtc/firefoxos-loop-client.git","clone_url":"https://github.com/opatinowebrtc/firefoxos-loop-client.git","svn_url":"https://github.com/opatinowebrtc/firefoxos-loop-client","homepage":null,"size":12746,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"2767dfdbd010659656343ca11216f998c76241b0","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":18225071,"name":"firefoxos-loop-client","full_name":"mozilla-b2g/firefoxos-loop-client","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/firefoxos-loop-client","description":"Firefox OS client for the Loop service","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client","forks_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/releases{/id}","created_at":"2014-03-28T20:10:24Z","updated_at":"2015-01-26T12:02:59Z","pushed_at":"2015-01-26T12:04:33Z","git_url":"git://github.com/mozilla-b2g/firefoxos-loop-client.git","ssh_url":"git@github.com:mozilla-b2g/firefoxos-loop-client.git","clone_url":"https://github.com/mozilla-b2g/firefoxos-loop-client.git","svn_url":"https://github.com/mozilla-b2g/firefoxos-loop-client","homepage":null,"size":17060,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":35,"forks":36,"open_issues":35,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/479"},"html":{"href":"https://github.com/mozilla-b2g/firefoxos-loop-client/pull/479"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/479"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/issues/479/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/479/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/pulls/479/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/firefoxos-loop-client/statuses/01c2b6d30fb799fef427cbb75c0f0a82bb32e893"}}}}