{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1136","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1136/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1136/comments","events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1136/events","html_url":"https://github.com/ipfs/go-ipfs/pull/1136","id":70850938,"number":1136,"title":"Replace coreunix.Add with shell/fsnode's AddFromReader","user":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/backlog","name":"backlog","color":"ededed"},{"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/codereview","name":"codereview","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"milestone":null,"comments":27,"created_at":"2015-04-25T04:18:03Z","updated_at":"2015-06-30T18:14:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/1136","html_url":"https://github.com/ipfs/go-ipfs/pull/1136","diff_url":"https://github.com/ipfs/go-ipfs/pull/1136.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/1136.patch"},"body":"coreunix.Add is basically a wrapper around BuildDagFromReader that\nreturns a string-ified key instead of a DAG node.  Since we'll need\nthe DAG node to add to the directory, converting to a key and then\nlooking that key back up in dirbuilder.AddChild is just extra work.\n\nIn #1127, @whyrusleeping mentioned that the file- and\ndirectory-addition API needed some polishing, and this WIP PR is my\nattempt to grind things down to a more compact API.  I'll probably\njust work up to removing coreunix.Add completely, and then start a new\nPR for whatever function we want to cull next."},"comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments/117288625","html_url":"https://github.com/ipfs/go-ipfs/pull/1136#issuecomment-117288625","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/1136","id":117288625,"user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars.githubusercontent.com/u/1243164?v=3","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"created_at":"2015-06-30T18:14:35Z","updated_at":"2015-06-30T18:14:35Z","body":"@wking whats the status here?"}}