{"action":"created","comment":{"url":"https://api.github.com/repos/whitesmith/rubycritic/pulls/comments/44848568","id":44848568,"diff_hunk":"@@ -16,7 +18,13 @@ def initialize(analysed_modules)\n       def run\n         @analysed_modules.each do |analysed_module|\n           add_smells_to(analysed_module)\n+          print green \".\"\n         end\n+        puts \"\"\n+      end\n+\n+      def to_s\n+        \"flog smells\"","path":"lib/rubycritic/analysers/smells/flog.rb","position":23,"original_position":23,"commit_id":"c7f9c479fc857dd02b313e2a7550bbbadb3a32f8","original_commit_id":"c7f9c479fc857dd02b313e2a7550bbbadb3a32f8","user":{"login":"troessner","id":271109,"avatar_url":"https://avatars.githubusercontent.com/u/271109?v=3","gravatar_id":"","url":"https://api.github.com/users/troessner","html_url":"https://github.com/troessner","followers_url":"https://api.github.com/users/troessner/followers","following_url":"https://api.github.com/users/troessner/following{/other_user}","gists_url":"https://api.github.com/users/troessner/gists{/gist_id}","starred_url":"https://api.github.com/users/troessner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troessner/subscriptions","organizations_url":"https://api.github.com/users/troessner/orgs","repos_url":"https://api.github.com/users/troessner/repos","events_url":"https://api.github.com/users/troessner/events{/privacy}","received_events_url":"https://api.github.com/users/troessner/received_events","type":"User","site_admin":false},"body":"How about doing \r\n\r\n>> self.class.name\r\n\r\ninstead and then put this method into the BaseAnalyzer (see above)?","created_at":"2015-11-14T00:10:05Z","updated_at":"2015-11-14T00:10:05Z","html_url":"https://github.com/whitesmith/rubycritic/pull/36#discussion_r44848568","pull_request_url":"https://api.github.com/repos/whitesmith/rubycritic/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/whitesmith/rubycritic/pulls/comments/44848568"},"html":{"href":"https://github.com/whitesmith/rubycritic/pull/36#discussion_r44848568"},"pull_request":{"href":"https://api.github.com/repos/whitesmith/rubycritic/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/whitesmith/rubycritic/pulls/36","id":31261938,"html_url":"https://github.com/whitesmith/rubycritic/pull/36","diff_url":"https://github.com/whitesmith/rubycritic/pull/36.diff","patch_url":"https://github.com/whitesmith/rubycritic/pull/36.patch","issue_url":"https://api.github.com/repos/whitesmith/rubycritic/issues/36","number":36,"state":"open","locked":false,"title":"first thoughts on progress indication in rubycritic","user":{"login":"natesholland","id":1545957,"avatar_url":"https://avatars.githubusercontent.com/u/1545957?v=3","gravatar_id":"","url":"https://api.github.com/users/natesholland","html_url":"https://github.com/natesholland","followers_url":"https://api.github.com/users/natesholland/followers","following_url":"https://api.github.com/users/natesholland/following{/other_user}","gists_url":"https://api.github.com/users/natesholland/gists{/gist_id}","starred_url":"https://api.github.com/users/natesholland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natesholland/subscriptions","organizations_url":"https://api.github.com/users/natesholland/orgs","repos_url":"https://api.github.com/users/natesholland/repos","events_url":"https://api.github.com/users/natesholland/events{/privacy}","received_events_url":"https://api.github.com/users/natesholland/received_events","type":"User","site_admin":false},"body":"I'm starting with some rough ideas on how to do progress indication in rubycritic. I know the code should be dried out and all that but I mainly want to begin discussing how we should present the information to the user. My first stab at it I showed an indication bar for each analyzer, (flay, flog, churn...) because that's how the code is currently organized. It seems more intuitive to me to show it file by file, but that's not currently how we are iterating through things so it's a bit counter intuitive in the code.\r\n\r\nHere's what my first stab at it looks like:\r\n![screen shot 2015-03-16 at 11 50 36 am](https://cloud.githubusercontent.com/assets/1545957/6671417/0779fdb0-cbd3-11e4-9f60-5672863563ce.png)\r\n","created_at":"2015-03-16T16:53:27Z","updated_at":"2015-11-14T00:10:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54eea682ce30dde051f6cf73970fb4f0d60efb2d","assignee":{"login":"troessner","id":271109,"avatar_url":"https://avatars.githubusercontent.com/u/271109?v=3","gravatar_id":"","url":"https://api.github.com/users/troessner","html_url":"https://github.com/troessner","followers_url":"https://api.github.com/users/troessner/followers","following_url":"https://api.github.com/users/troessner/following{/other_user}","gists_url":"https://api.github.com/users/troessner/gists{/gist_id}","starred_url":"https://api.github.com/users/troessner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troessner/subscriptions","organizations_url":"https://api.github.com/users/troessner/orgs","repos_url":"https://api.github.com/users/troessner/repos","events_url":"https://api.github.com/users/troessner/events{/privacy}","received_events_url":"https://api.github.com/users/troessner/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/whitesmith/rubycritic/pulls/36/commits","review_comments_url":"https://api.github.com/repos/whitesmith/rubycritic/pulls/36/comments","review_comment_url":"https://api.github.com/repos/whitesmith/rubycritic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whitesmith/rubycritic/issues/36/comments","statuses_url":"https://api.github.com/repos/whitesmith/rubycritic/statuses/c7f9c479fc857dd02b313e2a7550bbbadb3a32f8","head":{"label":"natesholland:nh/3/progress-bar","ref":"nh/3/progress-bar","sha":"c7f9c479fc857dd02b313e2a7550bbbadb3a32f8","user":{"login":"natesholland","id":1545957,"avatar_url":"https://avatars.githubusercontent.com/u/1545957?v=3","gravatar_id":"","url":"https://api.github.com/users/natesholland","html_url":"https://github.com/natesholland","followers_url":"https://api.github.com/users/natesholland/followers","following_url":"https://api.github.com/users/natesholland/following{/other_user}","gists_url":"https://api.github.com/users/natesholland/gists{/gist_id}","starred_url":"https://api.github.com/users/natesholland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natesholland/subscriptions","organizations_url":"https://api.github.com/users/natesholland/orgs","repos_url":"https://api.github.com/users/natesholland/repos","events_url":"https://api.github.com/users/natesholland/events{/privacy}","received_events_url":"https://api.github.com/users/natesholland/received_events","type":"User","site_admin":false},"repo":{"id":31677825,"name":"rubycritic","full_name":"natesholland/rubycritic","owner":{"login":"natesholland","id":1545957,"avatar_url":"https://avatars.githubusercontent.com/u/1545957?v=3","gravatar_id":"","url":"https://api.github.com/users/natesholland","html_url":"https://github.com/natesholland","followers_url":"https://api.github.com/users/natesholland/followers","following_url":"https://api.github.com/users/natesholland/following{/other_user}","gists_url":"https://api.github.com/users/natesholland/gists{/gist_id}","starred_url":"https://api.github.com/users/natesholland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natesholland/subscriptions","organizations_url":"https://api.github.com/users/natesholland/orgs","repos_url":"https://api.github.com/users/natesholland/repos","events_url":"https://api.github.com/users/natesholland/events{/privacy}","received_events_url":"https://api.github.com/users/natesholland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natesholland/rubycritic","description":"A Ruby code quality reporter","fork":true,"url":"https://api.github.com/repos/natesholland/rubycritic","forks_url":"https://api.github.com/repos/natesholland/rubycritic/forks","keys_url":"https://api.github.com/repos/natesholland/rubycritic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natesholland/rubycritic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natesholland/rubycritic/teams","hooks_url":"https://api.github.com/repos/natesholland/rubycritic/hooks","issue_events_url":"https://api.github.com/repos/natesholland/rubycritic/issues/events{/number}","events_url":"https://api.github.com/repos/natesholland/rubycritic/events","assignees_url":"https://api.github.com/repos/natesholland/rubycritic/assignees{/user}","branches_url":"https://api.github.com/repos/natesholland/rubycritic/branches{/branch}","tags_url":"https://api.github.com/repos/natesholland/rubycritic/tags","blobs_url":"https://api.github.com/repos/natesholland/rubycritic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natesholland/rubycritic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natesholland/rubycritic/git/refs{/sha}","trees_url":"https://api.github.com/repos/natesholland/rubycritic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natesholland/rubycritic/statuses/{sha}","languages_url":"https://api.github.com/repos/natesholland/rubycritic/languages","stargazers_url":"https://api.github.com/repos/natesholland/rubycritic/stargazers","contributors_url":"https://api.github.com/repos/natesholland/rubycritic/contributors","subscribers_url":"https://api.github.com/repos/natesholland/rubycritic/subscribers","subscription_url":"https://api.github.com/repos/natesholland/rubycritic/subscription","commits_url":"https://api.github.com/repos/natesholland/rubycritic/commits{/sha}","git_commits_url":"https://api.github.com/repos/natesholland/rubycritic/git/commits{/sha}","comments_url":"https://api.github.com/repos/natesholland/rubycritic/comments{/number}","issue_comment_url":"https://api.github.com/repos/natesholland/rubycritic/issues/comments{/number}","contents_url":"https://api.github.com/repos/natesholland/rubycritic/contents/{+path}","compare_url":"https://api.github.com/repos/natesholland/rubycritic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natesholland/rubycritic/merges","archive_url":"https://api.github.com/repos/natesholland/rubycritic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natesholland/rubycritic/downloads","issues_url":"https://api.github.com/repos/natesholland/rubycritic/issues{/number}","pulls_url":"https://api.github.com/repos/natesholland/rubycritic/pulls{/number}","milestones_url":"https://api.github.com/repos/natesholland/rubycritic/milestones{/number}","notifications_url":"https://api.github.com/repos/natesholland/rubycritic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natesholland/rubycritic/labels{/name}","releases_url":"https://api.github.com/repos/natesholland/rubycritic/releases{/id}","created_at":"2015-03-04T20:17:12Z","updated_at":"2015-03-16T16:13:34Z","pushed_at":"2015-03-17T14:37:49Z","git_url":"git://github.com/natesholland/rubycritic.git","ssh_url":"git@github.com:natesholland/rubycritic.git","clone_url":"https://github.com/natesholland/rubycritic.git","svn_url":"https://github.com/natesholland/rubycritic","homepage":"","size":869,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whitesmith:master","ref":"master","sha":"dca21ae2aaa0b85e2bdc30c1ed040591e666e175","user":{"login":"whitesmith","id":5413174,"avatar_url":"https://avatars.githubusercontent.com/u/5413174?v=3","gravatar_id":"","url":"https://api.github.com/users/whitesmith","html_url":"https://github.com/whitesmith","followers_url":"https://api.github.com/users/whitesmith/followers","following_url":"https://api.github.com/users/whitesmith/following{/other_user}","gists_url":"https://api.github.com/users/whitesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/whitesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitesmith/subscriptions","organizations_url":"https://api.github.com/users/whitesmith/orgs","repos_url":"https://api.github.com/users/whitesmith/repos","events_url":"https://api.github.com/users/whitesmith/events{/privacy}","received_events_url":"https://api.github.com/users/whitesmith/received_events","type":"Organization","site_admin":false},"repo":{"id":13445293,"name":"rubycritic","full_name":"whitesmith/rubycritic","owner":{"login":"whitesmith","id":5413174,"avatar_url":"https://avatars.githubusercontent.com/u/5413174?v=3","gravatar_id":"","url":"https://api.github.com/users/whitesmith","html_url":"https://github.com/whitesmith","followers_url":"https://api.github.com/users/whitesmith/followers","following_url":"https://api.github.com/users/whitesmith/following{/other_user}","gists_url":"https://api.github.com/users/whitesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/whitesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitesmith/subscriptions","organizations_url":"https://api.github.com/users/whitesmith/orgs","repos_url":"https://api.github.com/users/whitesmith/repos","events_url":"https://api.github.com/users/whitesmith/events{/privacy}","received_events_url":"https://api.github.com/users/whitesmith/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whitesmith/rubycritic","description":"A Ruby code quality reporter","fork":false,"url":"https://api.github.com/repos/whitesmith/rubycritic","forks_url":"https://api.github.com/repos/whitesmith/rubycritic/forks","keys_url":"https://api.github.com/repos/whitesmith/rubycritic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whitesmith/rubycritic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whitesmith/rubycritic/teams","hooks_url":"https://api.github.com/repos/whitesmith/rubycritic/hooks","issue_events_url":"https://api.github.com/repos/whitesmith/rubycritic/issues/events{/number}","events_url":"https://api.github.com/repos/whitesmith/rubycritic/events","assignees_url":"https://api.github.com/repos/whitesmith/rubycritic/assignees{/user}","branches_url":"https://api.github.com/repos/whitesmith/rubycritic/branches{/branch}","tags_url":"https://api.github.com/repos/whitesmith/rubycritic/tags","blobs_url":"https://api.github.com/repos/whitesmith/rubycritic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whitesmith/rubycritic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whitesmith/rubycritic/git/refs{/sha}","trees_url":"https://api.github.com/repos/whitesmith/rubycritic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whitesmith/rubycritic/statuses/{sha}","languages_url":"https://api.github.com/repos/whitesmith/rubycritic/languages","stargazers_url":"https://api.github.com/repos/whitesmith/rubycritic/stargazers","contributors_url":"https://api.github.com/repos/whitesmith/rubycritic/contributors","subscribers_url":"https://api.github.com/repos/whitesmith/rubycritic/subscribers","subscription_url":"https://api.github.com/repos/whitesmith/rubycritic/subscription","commits_url":"https://api.github.com/repos/whitesmith/rubycritic/commits{/sha}","git_commits_url":"https://api.github.com/repos/whitesmith/rubycritic/git/commits{/sha}","comments_url":"https://api.github.com/repos/whitesmith/rubycritic/comments{/number}","issue_comment_url":"https://api.github.com/repos/whitesmith/rubycritic/issues/comments{/number}","contents_url":"https://api.github.com/repos/whitesmith/rubycritic/contents/{+path}","compare_url":"https://api.github.com/repos/whitesmith/rubycritic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whitesmith/rubycritic/merges","archive_url":"https://api.github.com/repos/whitesmith/rubycritic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whitesmith/rubycritic/downloads","issues_url":"https://api.github.com/repos/whitesmith/rubycritic/issues{/number}","pulls_url":"https://api.github.com/repos/whitesmith/rubycritic/pulls{/number}","milestones_url":"https://api.github.com/repos/whitesmith/rubycritic/milestones{/number}","notifications_url":"https://api.github.com/repos/whitesmith/rubycritic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whitesmith/rubycritic/labels{/name}","releases_url":"https://api.github.com/repos/whitesmith/rubycritic/releases{/id}","created_at":"2013-10-09T14:58:31Z","updated_at":"2015-11-13T20:45:54Z","pushed_at":"2015-11-11T14:12:18Z","git_url":"git://github.com/whitesmith/rubycritic.git","ssh_url":"git@github.com:whitesmith/rubycritic.git","clone_url":"https://github.com/whitesmith/rubycritic.git","svn_url":"https://github.com/whitesmith/rubycritic","homepage":"","size":1877,"stargazers_count":1101,"watchers_count":1101,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":25,"forks":62,"open_issues":25,"watchers":1101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whitesmith/rubycritic/pulls/36"},"html":{"href":"https://github.com/whitesmith/rubycritic/pull/36"},"issue":{"href":"https://api.github.com/repos/whitesmith/rubycritic/issues/36"},"comments":{"href":"https://api.github.com/repos/whitesmith/rubycritic/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/whitesmith/rubycritic/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/whitesmith/rubycritic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whitesmith/rubycritic/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/whitesmith/rubycritic/statuses/c7f9c479fc857dd02b313e2a7550bbbadb3a32f8"}}}}