{"action":"created","issue":{"url":"https://api.github.com/repos/sphereio/sphere-sunrise-scenarios/issues/1","labels_url":"https://api.github.com/repos/sphereio/sphere-sunrise-scenarios/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/sphereio/sphere-sunrise-scenarios/issues/1/comments","events_url":"https://api.github.com/repos/sphereio/sphere-sunrise-scenarios/issues/1/events","html_url":"https://github.com/sphereio/sphere-sunrise-scenarios/pull/1","id":103058017,"number":1,"title":"WIP: Setup fluentlenium tests","user":{"login":"heshamMassoud","id":9512131,"avatar_url":"https://avatars.githubusercontent.com/u/9512131?v=3","gravatar_id":"","url":"https://api.github.com/users/heshamMassoud","html_url":"https://github.com/heshamMassoud","followers_url":"https://api.github.com/users/heshamMassoud/followers","following_url":"https://api.github.com/users/heshamMassoud/following{/other_user}","gists_url":"https://api.github.com/users/heshamMassoud/gists{/gist_id}","starred_url":"https://api.github.com/users/heshamMassoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heshamMassoud/subscriptions","organizations_url":"https://api.github.com/users/heshamMassoud/orgs","repos_url":"https://api.github.com/users/heshamMassoud/repos","events_url":"https://api.github.com/users/heshamMassoud/events{/privacy}","received_events_url":"https://api.github.com/users/heshamMassoud/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-08-25T15:57:24Z","updated_at":"2015-09-02T10:37:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sphereio/sphere-sunrise-scenarios/pulls/1","html_url":"https://github.com/sphereio/sphere-sunrise-scenarios/pull/1","diff_url":"https://github.com/sphereio/sphere-sunrise-scenarios/pull/1.diff","patch_url":"https://github.com/sphereio/sphere-sunrise-scenarios/pull/1.patch"},"body":"Hey guys @schleichardt, @lauraluiz ,\r\n\r\nCould you please checkout this setup for selenium testing:\r\n\r\n1. I've decided to use Fluentlenium rather than Selenide as the wrapper for selenium driver for the following reasons:-\r\n   * Has larger community (More stars on Github repo and more questions on StackOverflow)\r\n   * Documentation is more detailed and has more examples.\r\n   * Explicitly defined and controlled browser life cycle. You can also control the browser per method, per class or one browser for the whole test suite. \r\nBut in the end, as far as I have read the difference between the two APIs is insignificant.\r\n\r\n2. Used the Page Object pattern in the PDP here to encapsulate all the logic of working with page elements in the PageObject itself rather giving the test access to page elements. So the test only gets to use the public methods of the PageObject, whereas the PageObject has all the page elements privately inside of it.\r\n\r\n3. Used the tagging option of cucumber to ignore scenarios or features tagged with `@ignore`\r\n\r\n4. Made a test scenario as proof of concept for checking the Size Guide modal window. The test is ignored because the id of the element is set differently on the actual web shop than in the design Github pages.\r\n\r\nThis is WIP PR for you guys to tell if I am going in the right direction and if the setup/architecture should be changed or modified somehow.\r\n\r\nThanks."},"comment":{"url":"https://api.github.com/repos/sphereio/sphere-sunrise-scenarios/issues/comments/137021361","html_url":"https://github.com/sphereio/sphere-sunrise-scenarios/pull/1#issuecomment-137021361","issue_url":"https://api.github.com/repos/sphereio/sphere-sunrise-scenarios/issues/1","id":137021361,"user":{"login":"heshamMassoud","id":9512131,"avatar_url":"https://avatars.githubusercontent.com/u/9512131?v=3","gravatar_id":"","url":"https://api.github.com/users/heshamMassoud","html_url":"https://github.com/heshamMassoud","followers_url":"https://api.github.com/users/heshamMassoud/followers","following_url":"https://api.github.com/users/heshamMassoud/following{/other_user}","gists_url":"https://api.github.com/users/heshamMassoud/gists{/gist_id}","starred_url":"https://api.github.com/users/heshamMassoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heshamMassoud/subscriptions","organizations_url":"https://api.github.com/users/heshamMassoud/orgs","repos_url":"https://api.github.com/users/heshamMassoud/repos","events_url":"https://api.github.com/users/heshamMassoud/events{/privacy}","received_events_url":"https://api.github.com/users/heshamMassoud/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T10:37:09Z","updated_at":"2015-09-02T10:37:09Z","body":"@schleichardt fixed: 7933f3b"}}