{"action":"created","issue":{"url":"https://api.github.com/repos/strongloop/strong-remoting/issues/256","labels_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/256/labels{/name}","comments_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/256/comments","events_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/256/events","html_url":"https://github.com/strongloop/strong-remoting/pull/256","id":117447206,"number":256,"title":"Close server stream once event-stream consumer disconnects","user":{"login":"kraman","id":449065,"avatar_url":"https://avatars.githubusercontent.com/u/449065?v=3","gravatar_id":"","url":"https://api.github.com/users/kraman","html_url":"https://github.com/kraman","followers_url":"https://api.github.com/users/kraman/followers","following_url":"https://api.github.com/users/kraman/following{/other_user}","gists_url":"https://api.github.com/users/kraman/gists{/gist_id}","starred_url":"https://api.github.com/users/kraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraman/subscriptions","organizations_url":"https://api.github.com/users/kraman/orgs","repos_url":"https://api.github.com/users/kraman/repos","events_url":"https://api.github.com/users/kraman/events{/privacy}","received_events_url":"https://api.github.com/users/kraman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/strongloop/strong-remoting/labels/%23review","name":"#review","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"ritch","id":462228,"avatar_url":"https://avatars.githubusercontent.com/u/462228?v=3","gravatar_id":"","url":"https://api.github.com/users/ritch","html_url":"https://github.com/ritch","followers_url":"https://api.github.com/users/ritch/followers","following_url":"https://api.github.com/users/ritch/following{/other_user}","gists_url":"https://api.github.com/users/ritch/gists{/gist_id}","starred_url":"https://api.github.com/users/ritch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritch/subscriptions","organizations_url":"https://api.github.com/users/ritch/orgs","repos_url":"https://api.github.com/users/ritch/repos","events_url":"https://api.github.com/users/ritch/events{/privacy}","received_events_url":"https://api.github.com/users/ritch/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-11-17T20:51:16Z","updated_at":"2015-11-18T13:24:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/strongloop/strong-remoting/pulls/256","html_url":"https://github.com/strongloop/strong-remoting/pull/256","diff_url":"https://github.com/strongloop/strong-remoting/pull/256.diff","patch_url":"https://github.com/strongloop/strong-remoting/pull/256.patch"},"body":"Connect to strongloop-internal/scrum-nodeops#945"},"comment":{"url":"https://api.github.com/repos/strongloop/strong-remoting/issues/comments/157712229","html_url":"https://github.com/strongloop/strong-remoting/pull/256#issuecomment-157712229","issue_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/256","id":157712229,"user":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T13:24:54Z","updated_at":"2015-11-18T13:24:54Z","body":"@kraman could you please add a unit-test to cover this change? I think it's really important to have an automated test in place, considering the uncertainty about the correctness of the implementation.\r\n\r\n@piscisaureus could you perhaps take a look and let us know if we are doing this correctly? The idea is to detect when the browser client closes our long-living HTTP response stream, so that we can stop producing data that would be discarded."}}