{"action":"closed","number":439,"pull_request":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/439","id":28742887,"html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/439","diff_url":"https://github.com/OpenSCAP/scap-security-guide/pull/439.diff","patch_url":"https://github.com/OpenSCAP/scap-security-guide/pull/439.patch","issue_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/439","number":439,"state":"closed","locked":false,"title":"[Test suite] [RHEL/6] Add initial version of check_instances_test.py Python testing script for RHEL-6 content","user":{"login":"iankko","id":8414918,"avatar_url":"https://avatars.githubusercontent.com/u/8414918?v=3","gravatar_id":"","url":"https://api.github.com/users/iankko","html_url":"https://github.com/iankko","followers_url":"https://api.github.com/users/iankko/followers","following_url":"https://api.github.com/users/iankko/following{/other_user}","gists_url":"https://api.github.com/users/iankko/gists{/gist_id}","starred_url":"https://api.github.com/users/iankko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankko/subscriptions","organizations_url":"https://api.github.com/users/iankko/orgs","repos_url":"https://api.github.com/users/iankko/repos","events_url":"https://api.github.com/users/iankko/events{/privacy}","received_events_url":"https://api.github.com/users/iankko/received_events","type":"User","site_admin":false},"body":"This PR adds initial version of ```check_instances_test.py``` testing script intended for automated testing of\r\nRHEL-6 SSG content regressions wrt to issue: https://github.com/OpenSCAP/scap-security-guide/issues/433\r\n\r\nIt's far from being complete (since there still remain services to be investigated for their behaviour - if they honour just first or all particular config file options when parsing specific config file / file location). But even in current state it's able to report some discrepancies in OVAL textfilecontent54_objects definitions (e.g. for auditd or sysctl.conf rules).\r\n\r\nThe test will be gradually enhanced to cover all locations & once all the service / locations items have been reviewed, it can be configured to become part of existing ```make validate``` test to check when new textfilecontent54_object is added for existing config file / location, if it's ```operation``` and ```instance``` definitions follow the expected behavioural pattern for that service.\r\n\r\nAlso intentionally placed it to be RHEL-6 content specific since the ```verify_record_sanity``` routine from the test contains list of OVAL object exceptions (see MANUALLY_VERIFIED_SAFE_IDS list for further details). Once similar tests for RHEL-7 & Fedora content is created, the test can be enhanced to be one for all products.\r\n\r\nPlease review.\r\n\r\nThank you, Jan.","created_at":"2015-02-05T17:16:51Z","updated_at":"2015-12-10T13:43:35Z","closed_at":"2015-12-10T13:43:35Z","merged_at":"2015-12-10T13:43:35Z","merge_commit_sha":"6c8c8167edf665c961b25b8e2b86eb378407843d","assignee":null,"milestone":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/milestones/19","html_url":"https://github.com/OpenSCAP/scap-security-guide/milestones/0.1.28","labels_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/milestones/19/labels","id":1420069,"number":19,"title":"0.1.28","description":null,"creator":{"login":"iankko","id":8414918,"avatar_url":"https://avatars.githubusercontent.com/u/8414918?v=3","gravatar_id":"","url":"https://api.github.com/users/iankko","html_url":"https://github.com/iankko","followers_url":"https://api.github.com/users/iankko/followers","following_url":"https://api.github.com/users/iankko/following{/other_user}","gists_url":"https://api.github.com/users/iankko/gists{/gist_id}","starred_url":"https://api.github.com/users/iankko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankko/subscriptions","organizations_url":"https://api.github.com/users/iankko/orgs","repos_url":"https://api.github.com/users/iankko/repos","events_url":"https://api.github.com/users/iankko/events{/privacy}","received_events_url":"https://api.github.com/users/iankko/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":2,"state":"open","created_at":"2015-11-19T15:40:26Z","updated_at":"2015-12-10T13:43:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/439/commits","review_comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/439/comments","review_comment_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/439/comments","statuses_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/a3788eee74a0e09e088476f957c83381941ecb94","head":{"label":"iankko:check_instances_test","ref":"check_instances_test","sha":"a3788eee74a0e09e088476f957c83381941ecb94","user":{"login":"iankko","id":8414918,"avatar_url":"https://avatars.githubusercontent.com/u/8414918?v=3","gravatar_id":"","url":"https://api.github.com/users/iankko","html_url":"https://github.com/iankko","followers_url":"https://api.github.com/users/iankko/followers","following_url":"https://api.github.com/users/iankko/following{/other_user}","gists_url":"https://api.github.com/users/iankko/gists{/gist_id}","starred_url":"https://api.github.com/users/iankko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankko/subscriptions","organizations_url":"https://api.github.com/users/iankko/orgs","repos_url":"https://api.github.com/users/iankko/repos","events_url":"https://api.github.com/users/iankko/events{/privacy}","received_events_url":"https://api.github.com/users/iankko/received_events","type":"User","site_admin":false},"repo":{"id":23708376,"name":"scap-security-guide","full_name":"iankko/scap-security-guide","owner":{"login":"iankko","id":8414918,"avatar_url":"https://avatars.githubusercontent.com/u/8414918?v=3","gravatar_id":"","url":"https://api.github.com/users/iankko","html_url":"https://github.com/iankko","followers_url":"https://api.github.com/users/iankko/followers","following_url":"https://api.github.com/users/iankko/following{/other_user}","gists_url":"https://api.github.com/users/iankko/gists{/gist_id}","starred_url":"https://api.github.com/users/iankko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iankko/subscriptions","organizations_url":"https://api.github.com/users/iankko/orgs","repos_url":"https://api.github.com/users/iankko/repos","events_url":"https://api.github.com/users/iankko/events{/privacy}","received_events_url":"https://api.github.com/users/iankko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iankko/scap-security-guide","description":"Baseline compliance content in SCAP formats","fork":true,"url":"https://api.github.com/repos/iankko/scap-security-guide","forks_url":"https://api.github.com/repos/iankko/scap-security-guide/forks","keys_url":"https://api.github.com/repos/iankko/scap-security-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iankko/scap-security-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iankko/scap-security-guide/teams","hooks_url":"https://api.github.com/repos/iankko/scap-security-guide/hooks","issue_events_url":"https://api.github.com/repos/iankko/scap-security-guide/issues/events{/number}","events_url":"https://api.github.com/repos/iankko/scap-security-guide/events","assignees_url":"https://api.github.com/repos/iankko/scap-security-guide/assignees{/user}","branches_url":"https://api.github.com/repos/iankko/scap-security-guide/branches{/branch}","tags_url":"https://api.github.com/repos/iankko/scap-security-guide/tags","blobs_url":"https://api.github.com/repos/iankko/scap-security-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iankko/scap-security-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iankko/scap-security-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/iankko/scap-security-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iankko/scap-security-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/iankko/scap-security-guide/languages","stargazers_url":"https://api.github.com/repos/iankko/scap-security-guide/stargazers","contributors_url":"https://api.github.com/repos/iankko/scap-security-guide/contributors","subscribers_url":"https://api.github.com/repos/iankko/scap-security-guide/subscribers","subscription_url":"https://api.github.com/repos/iankko/scap-security-guide/subscription","commits_url":"https://api.github.com/repos/iankko/scap-security-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/iankko/scap-security-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/iankko/scap-security-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/iankko/scap-security-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/iankko/scap-security-guide/contents/{+path}","compare_url":"https://api.github.com/repos/iankko/scap-security-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iankko/scap-security-guide/merges","archive_url":"https://api.github.com/repos/iankko/scap-security-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iankko/scap-security-guide/downloads","issues_url":"https://api.github.com/repos/iankko/scap-security-guide/issues{/number}","pulls_url":"https://api.github.com/repos/iankko/scap-security-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/iankko/scap-security-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/iankko/scap-security-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iankko/scap-security-guide/labels{/name}","releases_url":"https://api.github.com/repos/iankko/scap-security-guide/releases{/id}","created_at":"2014-09-05T15:38:32Z","updated_at":"2015-05-07T17:09:47Z","pushed_at":"2015-12-10T10:45:01Z","git_url":"git://github.com/iankko/scap-security-guide.git","ssh_url":"git@github.com:iankko/scap-security-guide.git","clone_url":"https://github.com/iankko/scap-security-guide.git","svn_url":"https://github.com/iankko/scap-security-guide","homepage":"https://fedorahosted.org/scap-security-guide/","size":12487,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenSCAP:master","ref":"master","sha":"5ef4bd0513c680111be12808e5cb0cc06c5ecf4a","user":{"login":"OpenSCAP","id":7439934,"avatar_url":"https://avatars.githubusercontent.com/u/7439934?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenSCAP","html_url":"https://github.com/OpenSCAP","followers_url":"https://api.github.com/users/OpenSCAP/followers","following_url":"https://api.github.com/users/OpenSCAP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSCAP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSCAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSCAP/subscriptions","organizations_url":"https://api.github.com/users/OpenSCAP/orgs","repos_url":"https://api.github.com/users/OpenSCAP/repos","events_url":"https://api.github.com/users/OpenSCAP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSCAP/received_events","type":"Organization","site_admin":false},"repo":{"id":19279458,"name":"scap-security-guide","full_name":"OpenSCAP/scap-security-guide","owner":{"login":"OpenSCAP","id":7439934,"avatar_url":"https://avatars.githubusercontent.com/u/7439934?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenSCAP","html_url":"https://github.com/OpenSCAP","followers_url":"https://api.github.com/users/OpenSCAP/followers","following_url":"https://api.github.com/users/OpenSCAP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSCAP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSCAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSCAP/subscriptions","organizations_url":"https://api.github.com/users/OpenSCAP/orgs","repos_url":"https://api.github.com/users/OpenSCAP/repos","events_url":"https://api.github.com/users/OpenSCAP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSCAP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSCAP/scap-security-guide","description":"Baseline compliance content in SCAP formats","fork":false,"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide","forks_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/forks","keys_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/teams","hooks_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/hooks","issue_events_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/events","assignees_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/tags","blobs_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/languages","stargazers_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/stargazers","contributors_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/contributors","subscribers_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/subscribers","subscription_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/subscription","commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/merges","archive_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/downloads","issues_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/labels{/name}","releases_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/releases{/id}","created_at":"2014-04-29T14:32:02Z","updated_at":"2015-12-03T21:00:10Z","pushed_at":"2015-12-10T13:43:35Z","git_url":"git://github.com/OpenSCAP/scap-security-guide.git","ssh_url":"git@github.com:OpenSCAP/scap-security-guide.git","clone_url":"https://github.com/OpenSCAP/scap-security-guide.git","svn_url":"https://github.com/OpenSCAP/scap-security-guide","homepage":"http://www.open-scap.org/security-policies/scap-security-guide","size":14607,"stargazers_count":103,"watchers_count":103,"language":"XSLT","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":189,"forks":61,"open_issues":189,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/439"},"html":{"href":"https://github.com/OpenSCAP/scap-security-guide/pull/439"},"issue":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/439"},"comments":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/439/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/439/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/439/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/a3788eee74a0e09e088476f957c83381941ecb94"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"isimluk","id":6666052,"avatar_url":"https://avatars.githubusercontent.com/u/6666052?v=3","gravatar_id":"","url":"https://api.github.com/users/isimluk","html_url":"https://github.com/isimluk","followers_url":"https://api.github.com/users/isimluk/followers","following_url":"https://api.github.com/users/isimluk/following{/other_user}","gists_url":"https://api.github.com/users/isimluk/gists{/gist_id}","starred_url":"https://api.github.com/users/isimluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isimluk/subscriptions","organizations_url":"https://api.github.com/users/isimluk/orgs","repos_url":"https://api.github.com/users/isimluk/repos","events_url":"https://api.github.com/users/isimluk/events{/privacy}","received_events_url":"https://api.github.com/users/isimluk/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":2,"additions":177,"deletions":0,"changed_files":1}}