{"action":"created","comment":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/comments/27474872","id":27474872,"diff_hunk":"@@ -203,37 +204,22 @@ public void run() {\n         List<MigrationJob> jobs = new ArrayList<>();\n         try {\n             DataFindRequest findRequest = new DataFindRequest(\"migrationJob\", migrationJobEntityVersion);\n-            /*\n-                and:\n-                    whenAvailableDate <= new Date()\n-                    or:\n-                        jobExecutions# = 0\n-                        not:\n-                            jobExecutions.jobStatus $in ['COMPLETED_SUCCESS', 'COMPLETED_PARTIAL']\n-                        and:\n-                            not:\n-                                jobExecutions.jobStatus $not_in ['COMPLETED_SUCCESS', 'COMPLETED_PARTIAL']\n-                            jobExecutions.actualStartDate < (new Date() - expectedExecutionMilliseconds)\n-\n-             */\n+\n             findRequest.where(\n-                and(\n-                    withValue(\"whenAvailableDate <= \" + ClientConstants.getDateFormat().format(new Date())),\n-                    or(\n-                        not(\n-\n-                            withSubfield(\"jobExecutions\", withValue(\"jobStatus $in [COMPLETED_SUCCESS, COMPLETED_PARTIAL]\"))\n-                        ),\n-                        and(\n-                            not(\n-\n-                                    withSubfield(\"jobExecutions\", withValue(\"jobStatus $not_in [COMPLETED_SUCCESS, COMPLETED_PARTIAL]\"))\n-                            ),\n-                            // TODO check how lightblue will handle the next comparison (if it can handle this case), suggestions?\n-                            withValue(\"whenAvailableDate + expectedExecutionMilliseconds < \" + ClientConstants.getDateFormat().format(new Date()))\n-                        )\n+                    and(\n+                            withValue(\"configurationName = \" + configuration.getConfigurationName()),\n+                            withValue(\"whenAvailableDate <= \" + ClientConstants.getDateFormat().format(new Date())),\n+                            or(\n+                                    not(\n+                                            withSubfield(\"jobExecutions\", withValue(\"jobStatus $in [COMPLETED_SUCCESS, COMPLETED_PARTIAL]\"))\n+                                    ),\n+                                    and(\n+                                            not(\n+                                                    withSubfield(\"jobExecutions\", withValue(\"jobStatus $not_in [COMPLETED_SUCCESS, COMPLETED_PARTIAL]\"))","path":"consistency-checker/src/main/java/com/redhat/lightblue/migrator/consistency/ConsistencyChecker.java","position":69,"original_position":69,"commit_id":"bd25c25ea5ca050848aed3509598f5a74b90f2bf","original_commit_id":"bd25c25ea5ca050848aed3509598f5a74b90f2bf","user":{"login":"dcrissman","id":1878960,"avatar_url":"https://avatars.githubusercontent.com/u/1878960?v=3","gravatar_id":"","url":"https://api.github.com/users/dcrissman","html_url":"https://github.com/dcrissman","followers_url":"https://api.github.com/users/dcrissman/followers","following_url":"https://api.github.com/users/dcrissman/following{/other_user}","gists_url":"https://api.github.com/users/dcrissman/gists{/gist_id}","starred_url":"https://api.github.com/users/dcrissman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcrissman/subscriptions","organizations_url":"https://api.github.com/users/dcrissman/orgs","repos_url":"https://api.github.com/users/dcrissman/repos","events_url":"https://api.github.com/users/dcrissman/events{/privacy}","received_events_url":"https://api.github.com/users/dcrissman/received_events","type":"User","site_admin":false},"body":"Why the not $not_in?","created_at":"2015-03-31T12:44:06Z","updated_at":"2015-03-31T12:44:06Z","html_url":"https://github.com/lightblue-platform/lightblue-migrator/pull/146#discussion_r27474872","pull_request_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/146","_links":{"self":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/comments/27474872"},"html":{"href":"https://github.com/lightblue-platform/lightblue-migrator/pull/146#discussion_r27474872"},"pull_request":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/146","id":32274312,"html_url":"https://github.com/lightblue-platform/lightblue-migrator/pull/146","diff_url":"https://github.com/lightblue-platform/lightblue-migrator/pull/146.diff","patch_url":"https://github.com/lightblue-platform/lightblue-migrator/pull/146.patch","issue_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/issues/146","number":146,"state":"open","locked":false,"title":"Fixes #145: Update handling job expiration","user":{"login":"jewzaam","id":480388,"avatar_url":"https://avatars.githubusercontent.com/u/480388?v=3","gravatar_id":"","url":"https://api.github.com/users/jewzaam","html_url":"https://github.com/jewzaam","followers_url":"https://api.github.com/users/jewzaam/followers","following_url":"https://api.github.com/users/jewzaam/following{/other_user}","gists_url":"https://api.github.com/users/jewzaam/gists{/gist_id}","starred_url":"https://api.github.com/users/jewzaam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jewzaam/subscriptions","organizations_url":"https://api.github.com/users/jewzaam/orgs","repos_url":"https://api.github.com/users/jewzaam/repos","events_url":"https://api.github.com/users/jewzaam/events{/privacy}","received_events_url":"https://api.github.com/users/jewzaam/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-30T22:30:35Z","updated_at":"2015-03-31T12:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebe05173805ef4bff59cb0cfd7ca9d731cec9e66","assignee":null,"milestone":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/milestones/1","html_url":"https://github.com/lightblue-platform/lightblue-migrator/milestones/Ana","labels_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/milestones/1/labels","id":878414,"number":1,"title":"Ana","description":"","creator":{"login":"jewzaam","id":480388,"avatar_url":"https://avatars.githubusercontent.com/u/480388?v=3","gravatar_id":"","url":"https://api.github.com/users/jewzaam","html_url":"https://github.com/jewzaam","followers_url":"https://api.github.com/users/jewzaam/followers","following_url":"https://api.github.com/users/jewzaam/following{/other_user}","gists_url":"https://api.github.com/users/jewzaam/gists{/gist_id}","starred_url":"https://api.github.com/users/jewzaam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jewzaam/subscriptions","organizations_url":"https://api.github.com/users/jewzaam/orgs","repos_url":"https://api.github.com/users/jewzaam/repos","events_url":"https://api.github.com/users/jewzaam/events{/privacy}","received_events_url":"https://api.github.com/users/jewzaam/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":28,"state":"open","created_at":"2014-11-24T15:17:35Z","updated_at":"2015-03-30T22:45:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/146/commits","review_comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/146/comments","review_comment_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/issues/146/comments","statuses_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/statuses/bd25c25ea5ca050848aed3509598f5a74b90f2bf","head":{"label":"jewzaam:update-handling-job-expiration-145","ref":"update-handling-job-expiration-145","sha":"bd25c25ea5ca050848aed3509598f5a74b90f2bf","user":{"login":"jewzaam","id":480388,"avatar_url":"https://avatars.githubusercontent.com/u/480388?v=3","gravatar_id":"","url":"https://api.github.com/users/jewzaam","html_url":"https://github.com/jewzaam","followers_url":"https://api.github.com/users/jewzaam/followers","following_url":"https://api.github.com/users/jewzaam/following{/other_user}","gists_url":"https://api.github.com/users/jewzaam/gists{/gist_id}","starred_url":"https://api.github.com/users/jewzaam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jewzaam/subscriptions","organizations_url":"https://api.github.com/users/jewzaam/orgs","repos_url":"https://api.github.com/users/jewzaam/repos","events_url":"https://api.github.com/users/jewzaam/events{/privacy}","received_events_url":"https://api.github.com/users/jewzaam/received_events","type":"User","site_admin":false},"repo":{"id":26761148,"name":"lightblue-migrator","full_name":"jewzaam/lightblue-migrator","owner":{"login":"jewzaam","id":480388,"avatar_url":"https://avatars.githubusercontent.com/u/480388?v=3","gravatar_id":"","url":"https://api.github.com/users/jewzaam","html_url":"https://github.com/jewzaam","followers_url":"https://api.github.com/users/jewzaam/followers","following_url":"https://api.github.com/users/jewzaam/following{/other_user}","gists_url":"https://api.github.com/users/jewzaam/gists{/gist_id}","starred_url":"https://api.github.com/users/jewzaam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jewzaam/subscriptions","organizations_url":"https://api.github.com/users/jewzaam/orgs","repos_url":"https://api.github.com/users/jewzaam/repos","events_url":"https://api.github.com/users/jewzaam/events{/privacy}","received_events_url":"https://api.github.com/users/jewzaam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jewzaam/lightblue-migrator","description":"","fork":true,"url":"https://api.github.com/repos/jewzaam/lightblue-migrator","forks_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/forks","keys_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/teams","hooks_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/hooks","issue_events_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/issues/events{/number}","events_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/events","assignees_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/assignees{/user}","branches_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/branches{/branch}","tags_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/tags","blobs_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/statuses/{sha}","languages_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/languages","stargazers_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/stargazers","contributors_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/contributors","subscribers_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/subscribers","subscription_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/subscription","commits_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/contents/{+path}","compare_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/merges","archive_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/downloads","issues_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/issues{/number}","pulls_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/pulls{/number}","milestones_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/milestones{/number}","notifications_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/labels{/name}","releases_url":"https://api.github.com/repos/jewzaam/lightblue-migrator/releases{/id}","created_at":"2014-11-17T14:49:34Z","updated_at":"2015-03-26T19:42:35Z","pushed_at":"2015-03-30T22:38:59Z","git_url":"git://github.com/jewzaam/lightblue-migrator.git","ssh_url":"git@github.com:jewzaam/lightblue-migrator.git","clone_url":"https://github.com/jewzaam/lightblue-migrator.git","svn_url":"https://github.com/jewzaam/lightblue-migrator","homepage":null,"size":626,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightblue-platform:master","ref":"master","sha":"bd011036235357a220c1fc059ddd914e3677d979","user":{"login":"lightblue-platform","id":7061725,"avatar_url":"https://avatars.githubusercontent.com/u/7061725?v=3","gravatar_id":"","url":"https://api.github.com/users/lightblue-platform","html_url":"https://github.com/lightblue-platform","followers_url":"https://api.github.com/users/lightblue-platform/followers","following_url":"https://api.github.com/users/lightblue-platform/following{/other_user}","gists_url":"https://api.github.com/users/lightblue-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lightblue-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightblue-platform/subscriptions","organizations_url":"https://api.github.com/users/lightblue-platform/orgs","repos_url":"https://api.github.com/users/lightblue-platform/repos","events_url":"https://api.github.com/users/lightblue-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lightblue-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":25266940,"name":"lightblue-migrator","full_name":"lightblue-platform/lightblue-migrator","owner":{"login":"lightblue-platform","id":7061725,"avatar_url":"https://avatars.githubusercontent.com/u/7061725?v=3","gravatar_id":"","url":"https://api.github.com/users/lightblue-platform","html_url":"https://github.com/lightblue-platform","followers_url":"https://api.github.com/users/lightblue-platform/followers","following_url":"https://api.github.com/users/lightblue-platform/following{/other_user}","gists_url":"https://api.github.com/users/lightblue-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lightblue-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightblue-platform/subscriptions","organizations_url":"https://api.github.com/users/lightblue-platform/orgs","repos_url":"https://api.github.com/users/lightblue-platform/repos","events_url":"https://api.github.com/users/lightblue-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lightblue-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightblue-platform/lightblue-migrator","description":"","fork":false,"url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator","forks_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/forks","keys_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/teams","hooks_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/hooks","issue_events_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/issues/events{/number}","events_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/events","assignees_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/assignees{/user}","branches_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/branches{/branch}","tags_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/tags","blobs_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/statuses/{sha}","languages_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/languages","stargazers_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/stargazers","contributors_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/contributors","subscribers_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/subscribers","subscription_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/subscription","commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/contents/{+path}","compare_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/merges","archive_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/downloads","issues_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/issues{/number}","pulls_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls{/number}","milestones_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/milestones{/number}","notifications_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/labels{/name}","releases_url":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/releases{/id}","created_at":"2014-10-15T18:07:22Z","updated_at":"2015-03-30T15:20:18Z","pushed_at":"2015-03-30T22:39:01Z","git_url":"git://github.com/lightblue-platform/lightblue-migrator.git","ssh_url":"git@github.com:lightblue-platform/lightblue-migrator.git","clone_url":"https://github.com/lightblue-platform/lightblue-migrator.git","svn_url":"https://github.com/lightblue-platform/lightblue-migrator","homepage":null,"size":1479,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":17,"forks":5,"open_issues":17,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/146"},"html":{"href":"https://github.com/lightblue-platform/lightblue-migrator/pull/146"},"issue":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/issues/146"},"comments":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-migrator/statuses/bd25c25ea5ca050848aed3509598f5a74b90f2bf"}}}}