{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/mlaphp/mlaphp/pulls/2","id":30346913,"html_url":"https://github.com/mlaphp/mlaphp/pull/2","diff_url":"https://github.com/mlaphp/mlaphp/pull/2.diff","patch_url":"https://github.com/mlaphp/mlaphp/pull/2.patch","issue_url":"https://api.github.com/repos/mlaphp/mlaphp/issues/2","number":2,"state":"open","locked":false,"title":"Convert DIRECTORY_SEPARATOR to / in Router","user":{"login":"redbeardcreator","id":375927,"avatar_url":"https://avatars.githubusercontent.com/u/375927?v=3","gravatar_id":"","url":"https://api.github.com/users/redbeardcreator","html_url":"https://github.com/redbeardcreator","followers_url":"https://api.github.com/users/redbeardcreator/followers","following_url":"https://api.github.com/users/redbeardcreator/following{/other_user}","gists_url":"https://api.github.com/users/redbeardcreator/gists{/gist_id}","starred_url":"https://api.github.com/users/redbeardcreator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbeardcreator/subscriptions","organizations_url":"https://api.github.com/users/redbeardcreator/orgs","repos_url":"https://api.github.com/users/redbeardcreator/repos","events_url":"https://api.github.com/users/redbeardcreator/events{/privacy}","received_events_url":"https://api.github.com/users/redbeardcreator/received_events","type":"User","site_admin":false},"body":"On Windows, `DIRECTORY_SEPARATOR` is `\\`, which is is not compatible with URLs.\r\nHowever, PHP is perfectly content to allow `/` as the user-supplied directory\r\nseparator. So convert `$pages_dir` to always use `/` in the constructor.\r\n\r\nCloses #1.\r\n\r\nI haven't actually tested this on Windows as I don't currently have a Windows install of PHP to work with. But I see no reason why it shouldn't work. Unfortunately, it's difficult if not impossible to write a unit test for this, as `DIRECTORY_SEPARATOR` isn't controllable.","created_at":"2015-03-03T05:03:46Z","updated_at":"2015-03-03T05:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mlaphp/mlaphp/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mlaphp/mlaphp/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mlaphp/mlaphp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlaphp/mlaphp/issues/2/comments","statuses_url":"https://api.github.com/repos/mlaphp/mlaphp/statuses/4308ad725640a6577d231993d8c201ddddb820cf","head":{"label":"redbeardcreator:fix-dir-separator","ref":"fix-dir-separator","sha":"4308ad725640a6577d231993d8c201ddddb820cf","user":{"login":"redbeardcreator","id":375927,"avatar_url":"https://avatars.githubusercontent.com/u/375927?v=3","gravatar_id":"","url":"https://api.github.com/users/redbeardcreator","html_url":"https://github.com/redbeardcreator","followers_url":"https://api.github.com/users/redbeardcreator/followers","following_url":"https://api.github.com/users/redbeardcreator/following{/other_user}","gists_url":"https://api.github.com/users/redbeardcreator/gists{/gist_id}","starred_url":"https://api.github.com/users/redbeardcreator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbeardcreator/subscriptions","organizations_url":"https://api.github.com/users/redbeardcreator/orgs","repos_url":"https://api.github.com/users/redbeardcreator/repos","events_url":"https://api.github.com/users/redbeardcreator/events{/privacy}","received_events_url":"https://api.github.com/users/redbeardcreator/received_events","type":"User","site_admin":false},"repo":{"id":31580053,"name":"mlaphp","full_name":"redbeardcreator/mlaphp","owner":{"login":"redbeardcreator","id":375927,"avatar_url":"https://avatars.githubusercontent.com/u/375927?v=3","gravatar_id":"","url":"https://api.github.com/users/redbeardcreator","html_url":"https://github.com/redbeardcreator","followers_url":"https://api.github.com/users/redbeardcreator/followers","following_url":"https://api.github.com/users/redbeardcreator/following{/other_user}","gists_url":"https://api.github.com/users/redbeardcreator/gists{/gist_id}","starred_url":"https://api.github.com/users/redbeardcreator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbeardcreator/subscriptions","organizations_url":"https://api.github.com/users/redbeardcreator/orgs","repos_url":"https://api.github.com/users/redbeardcreator/repos","events_url":"https://api.github.com/users/redbeardcreator/events{/privacy}","received_events_url":"https://api.github.com/users/redbeardcreator/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/redbeardcreator/mlaphp","description":"Library package for the book.","fork":true,"url":"https://api.github.com/repos/redbeardcreator/mlaphp","forks_url":"https://api.github.com/repos/redbeardcreator/mlaphp/forks","keys_url":"https://api.github.com/repos/redbeardcreator/mlaphp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redbeardcreator/mlaphp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redbeardcreator/mlaphp/teams","hooks_url":"https://api.github.com/repos/redbeardcreator/mlaphp/hooks","issue_events_url":"https://api.github.com/repos/redbeardcreator/mlaphp/issues/events{/number}","events_url":"https://api.github.com/repos/redbeardcreator/mlaphp/events","assignees_url":"https://api.github.com/repos/redbeardcreator/mlaphp/assignees{/user}","branches_url":"https://api.github.com/repos/redbeardcreator/mlaphp/branches{/branch}","tags_url":"https://api.github.com/repos/redbeardcreator/mlaphp/tags","blobs_url":"https://api.github.com/repos/redbeardcreator/mlaphp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redbeardcreator/mlaphp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redbeardcreator/mlaphp/git/refs{/sha}","trees_url":"https://api.github.com/repos/redbeardcreator/mlaphp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redbeardcreator/mlaphp/statuses/{sha}","languages_url":"https://api.github.com/repos/redbeardcreator/mlaphp/languages","stargazers_url":"https://api.github.com/repos/redbeardcreator/mlaphp/stargazers","contributors_url":"https://api.github.com/repos/redbeardcreator/mlaphp/contributors","subscribers_url":"https://api.github.com/repos/redbeardcreator/mlaphp/subscribers","subscription_url":"https://api.github.com/repos/redbeardcreator/mlaphp/subscription","commits_url":"https://api.github.com/repos/redbeardcreator/mlaphp/commits{/sha}","git_commits_url":"https://api.github.com/repos/redbeardcreator/mlaphp/git/commits{/sha}","comments_url":"https://api.github.com/repos/redbeardcreator/mlaphp/comments{/number}","issue_comment_url":"https://api.github.com/repos/redbeardcreator/mlaphp/issues/comments{/number}","contents_url":"https://api.github.com/repos/redbeardcreator/mlaphp/contents/{+path}","compare_url":"https://api.github.com/repos/redbeardcreator/mlaphp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redbeardcreator/mlaphp/merges","archive_url":"https://api.github.com/repos/redbeardcreator/mlaphp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redbeardcreator/mlaphp/downloads","issues_url":"https://api.github.com/repos/redbeardcreator/mlaphp/issues{/number}","pulls_url":"https://api.github.com/repos/redbeardcreator/mlaphp/pulls{/number}","milestones_url":"https://api.github.com/repos/redbeardcreator/mlaphp/milestones{/number}","notifications_url":"https://api.github.com/repos/redbeardcreator/mlaphp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redbeardcreator/mlaphp/labels{/name}","releases_url":"https://api.github.com/repos/redbeardcreator/mlaphp/releases{/id}","created_at":"2015-03-03T04:53:18Z","updated_at":"2015-03-03T05:00:08Z","pushed_at":"2015-03-03T05:00:08Z","git_url":"git://github.com/redbeardcreator/mlaphp.git","ssh_url":"git@github.com:redbeardcreator/mlaphp.git","clone_url":"https://github.com/redbeardcreator/mlaphp.git","svn_url":"https://github.com/redbeardcreator/mlaphp","homepage":null,"size":92,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mlaphp:master","ref":"master","sha":"142d75d35f60d9b6fdfb1e27a5ae75bc2b2b413c","user":{"login":"mlaphp","id":6155009,"avatar_url":"https://avatars.githubusercontent.com/u/6155009?v=3","gravatar_id":"","url":"https://api.github.com/users/mlaphp","html_url":"https://github.com/mlaphp","followers_url":"https://api.github.com/users/mlaphp/followers","following_url":"https://api.github.com/users/mlaphp/following{/other_user}","gists_url":"https://api.github.com/users/mlaphp/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaphp/subscriptions","organizations_url":"https://api.github.com/users/mlaphp/orgs","repos_url":"https://api.github.com/users/mlaphp/repos","events_url":"https://api.github.com/users/mlaphp/events{/privacy}","received_events_url":"https://api.github.com/users/mlaphp/received_events","type":"User","site_admin":false},"repo":{"id":18102797,"name":"mlaphp","full_name":"mlaphp/mlaphp","owner":{"login":"mlaphp","id":6155009,"avatar_url":"https://avatars.githubusercontent.com/u/6155009?v=3","gravatar_id":"","url":"https://api.github.com/users/mlaphp","html_url":"https://github.com/mlaphp","followers_url":"https://api.github.com/users/mlaphp/followers","following_url":"https://api.github.com/users/mlaphp/following{/other_user}","gists_url":"https://api.github.com/users/mlaphp/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaphp/subscriptions","organizations_url":"https://api.github.com/users/mlaphp/orgs","repos_url":"https://api.github.com/users/mlaphp/repos","events_url":"https://api.github.com/users/mlaphp/events{/privacy}","received_events_url":"https://api.github.com/users/mlaphp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlaphp/mlaphp","description":"Library package for the book.","fork":false,"url":"https://api.github.com/repos/mlaphp/mlaphp","forks_url":"https://api.github.com/repos/mlaphp/mlaphp/forks","keys_url":"https://api.github.com/repos/mlaphp/mlaphp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlaphp/mlaphp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlaphp/mlaphp/teams","hooks_url":"https://api.github.com/repos/mlaphp/mlaphp/hooks","issue_events_url":"https://api.github.com/repos/mlaphp/mlaphp/issues/events{/number}","events_url":"https://api.github.com/repos/mlaphp/mlaphp/events","assignees_url":"https://api.github.com/repos/mlaphp/mlaphp/assignees{/user}","branches_url":"https://api.github.com/repos/mlaphp/mlaphp/branches{/branch}","tags_url":"https://api.github.com/repos/mlaphp/mlaphp/tags","blobs_url":"https://api.github.com/repos/mlaphp/mlaphp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlaphp/mlaphp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlaphp/mlaphp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlaphp/mlaphp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlaphp/mlaphp/statuses/{sha}","languages_url":"https://api.github.com/repos/mlaphp/mlaphp/languages","stargazers_url":"https://api.github.com/repos/mlaphp/mlaphp/stargazers","contributors_url":"https://api.github.com/repos/mlaphp/mlaphp/contributors","subscribers_url":"https://api.github.com/repos/mlaphp/mlaphp/subscribers","subscription_url":"https://api.github.com/repos/mlaphp/mlaphp/subscription","commits_url":"https://api.github.com/repos/mlaphp/mlaphp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlaphp/mlaphp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlaphp/mlaphp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlaphp/mlaphp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlaphp/mlaphp/contents/{+path}","compare_url":"https://api.github.com/repos/mlaphp/mlaphp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlaphp/mlaphp/merges","archive_url":"https://api.github.com/repos/mlaphp/mlaphp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlaphp/mlaphp/downloads","issues_url":"https://api.github.com/repos/mlaphp/mlaphp/issues{/number}","pulls_url":"https://api.github.com/repos/mlaphp/mlaphp/pulls{/number}","milestones_url":"https://api.github.com/repos/mlaphp/mlaphp/milestones{/number}","notifications_url":"https://api.github.com/repos/mlaphp/mlaphp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlaphp/mlaphp/labels{/name}","releases_url":"https://api.github.com/repos/mlaphp/mlaphp/releases{/id}","created_at":"2014-03-25T14:18:58Z","updated_at":"2015-01-20T23:25:33Z","pushed_at":"2014-03-25T14:39:07Z","git_url":"git://github.com/mlaphp/mlaphp.git","ssh_url":"git@github.com:mlaphp/mlaphp.git","clone_url":"https://github.com/mlaphp/mlaphp.git","svn_url":"https://github.com/mlaphp/mlaphp","homepage":null,"size":144,"stargazers_count":16,"watchers_count":16,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlaphp/mlaphp/pulls/2"},"html":{"href":"https://github.com/mlaphp/mlaphp/pull/2"},"issue":{"href":"https://api.github.com/repos/mlaphp/mlaphp/issues/2"},"comments":{"href":"https://api.github.com/repos/mlaphp/mlaphp/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mlaphp/mlaphp/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mlaphp/mlaphp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlaphp/mlaphp/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mlaphp/mlaphp/statuses/4308ad725640a6577d231993d8c201ddddb820cf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}