{"action":"created","comment":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/comments/22439868","id":22439868,"diff_hunk":"@@ -0,0 +1,14 @@\n+#include \"DBvModel.h\"\n+\n+DBvModel::DBvModel(float val, float min, float max, float step,\n+\t\t\t\t\t\t\t\t   Model *parent, const QString &displayName,\n+\t\t\t\t\t\t\t\t   bool defaultConstructed) :\n+\t\tFloatModel( val, min, max, step, parent, displayName, defaultConstructed )\n+{\n+\t\tconnect(this, SIGNAL( dataChanged() ), this,SLOT( calcAmp() ) );","path":"plugins/Eq/DBvModel.cpp","position":8,"original_position":8,"commit_id":"420bc1b7eda2ef96cca6bc33c343877738034775","original_commit_id":"420bc1b7eda2ef96cca6bc33c343877738034775","user":{"login":"diizy","id":6368868,"avatar_url":"https://avatars.githubusercontent.com/u/6368868?v=3","gravatar_id":"","url":"https://api.github.com/users/diizy","html_url":"https://github.com/diizy","followers_url":"https://api.github.com/users/diizy/followers","following_url":"https://api.github.com/users/diizy/following{/other_user}","gists_url":"https://api.github.com/users/diizy/gists{/gist_id}","starred_url":"https://api.github.com/users/diizy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diizy/subscriptions","organizations_url":"https://api.github.com/users/diizy/orgs","repos_url":"https://api.github.com/users/diizy/repos","events_url":"https://api.github.com/users/diizy/events{/privacy}","received_events_url":"https://api.github.com/users/diizy/received_events","type":"User","site_admin":false},"body":"Bad idea to use signals for this. Causes more overhead and possible latency. You could look at how I've done the dBV to linear conversion in CrossoverEq: by using the isValueChanged() method, you can remove the need to use signals.","created_at":"2015-01-04T15:09:10Z","updated_at":"2015-01-04T15:09:10Z","html_url":"https://github.com/LMMS/lmms/pull/1528#discussion_r22439868","pull_request_url":"https://api.github.com/repos/LMMS/lmms/pulls/1528","_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments/22439868"},"html":{"href":"https://github.com/LMMS/lmms/pull/1528#discussion_r22439868"},"pull_request":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/1528"}}},"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/1528","id":26663645,"html_url":"https://github.com/LMMS/lmms/pull/1528","diff_url":"https://github.com/LMMS/lmms/pull/1528.diff","patch_url":"https://github.com/LMMS/lmms/pull/1528.patch","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/1528","number":1528,"state":"open","locked":false,"title":"Eq 1443 updates","user":{"login":"curlymorphic","id":7412852,"avatar_url":"https://avatars.githubusercontent.com/u/7412852?v=3","gravatar_id":"","url":"https://api.github.com/users/curlymorphic","html_url":"https://github.com/curlymorphic","followers_url":"https://api.github.com/users/curlymorphic/followers","following_url":"https://api.github.com/users/curlymorphic/following{/other_user}","gists_url":"https://api.github.com/users/curlymorphic/gists{/gist_id}","starred_url":"https://api.github.com/users/curlymorphic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curlymorphic/subscriptions","organizations_url":"https://api.github.com/users/curlymorphic/orgs","repos_url":"https://api.github.com/users/curlymorphic/repos","events_url":"https://api.github.com/users/curlymorphic/events{/privacy}","received_events_url":"https://api.github.com/users/curlymorphic/received_events","type":"User","site_admin":false},"body":"Updated the Eq plugin as per #1443 \r\n\r\nmade shelving filters stable,\r\nremoved oversampling,\r\nThe input and output analysers are now independently switchable, using the labels in the widget\r\nWhile the mouse has focus in the widget, the current frequency for that location is displayed in a TextFloat,\r\nPeaking filters now use bandwidth instead of resonance.\r\n","created_at":"2014-12-29T21:53:25Z","updated_at":"2015-01-04T15:09:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"509ea673630bbb75be44e7af6b5ff011177a5b64","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LMMS/lmms/pulls/1528/commits","review_comments_url":"https://api.github.com/repos/LMMS/lmms/pulls/1528/comments","review_comment_url":"https://api.github.com/repos/LMMS/lmms/pulls/comments/{number}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/1528/comments","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/420bc1b7eda2ef96cca6bc33c343877738034775","head":{"label":"curlymorphic:eq","ref":"eq","sha":"420bc1b7eda2ef96cca6bc33c343877738034775","user":{"login":"curlymorphic","id":7412852,"avatar_url":"https://avatars.githubusercontent.com/u/7412852?v=3","gravatar_id":"","url":"https://api.github.com/users/curlymorphic","html_url":"https://github.com/curlymorphic","followers_url":"https://api.github.com/users/curlymorphic/followers","following_url":"https://api.github.com/users/curlymorphic/following{/other_user}","gists_url":"https://api.github.com/users/curlymorphic/gists{/gist_id}","starred_url":"https://api.github.com/users/curlymorphic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curlymorphic/subscriptions","organizations_url":"https://api.github.com/users/curlymorphic/orgs","repos_url":"https://api.github.com/users/curlymorphic/repos","events_url":"https://api.github.com/users/curlymorphic/events{/privacy}","received_events_url":"https://api.github.com/users/curlymorphic/received_events","type":"User","site_admin":false},"repo":{"id":27809321,"name":"lmms","full_name":"curlymorphic/lmms","owner":{"login":"curlymorphic","id":7412852,"avatar_url":"https://avatars.githubusercontent.com/u/7412852?v=3","gravatar_id":"","url":"https://api.github.com/users/curlymorphic","html_url":"https://github.com/curlymorphic","followers_url":"https://api.github.com/users/curlymorphic/followers","following_url":"https://api.github.com/users/curlymorphic/following{/other_user}","gists_url":"https://api.github.com/users/curlymorphic/gists{/gist_id}","starred_url":"https://api.github.com/users/curlymorphic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curlymorphic/subscriptions","organizations_url":"https://api.github.com/users/curlymorphic/orgs","repos_url":"https://api.github.com/users/curlymorphic/repos","events_url":"https://api.github.com/users/curlymorphic/events{/privacy}","received_events_url":"https://api.github.com/users/curlymorphic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/curlymorphic/lmms","description":"cross-platform music production software","fork":true,"url":"https://api.github.com/repos/curlymorphic/lmms","forks_url":"https://api.github.com/repos/curlymorphic/lmms/forks","keys_url":"https://api.github.com/repos/curlymorphic/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/curlymorphic/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/curlymorphic/lmms/teams","hooks_url":"https://api.github.com/repos/curlymorphic/lmms/hooks","issue_events_url":"https://api.github.com/repos/curlymorphic/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/curlymorphic/lmms/events","assignees_url":"https://api.github.com/repos/curlymorphic/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/curlymorphic/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/curlymorphic/lmms/tags","blobs_url":"https://api.github.com/repos/curlymorphic/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/curlymorphic/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/curlymorphic/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/curlymorphic/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/curlymorphic/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/curlymorphic/lmms/languages","stargazers_url":"https://api.github.com/repos/curlymorphic/lmms/stargazers","contributors_url":"https://api.github.com/repos/curlymorphic/lmms/contributors","subscribers_url":"https://api.github.com/repos/curlymorphic/lmms/subscribers","subscription_url":"https://api.github.com/repos/curlymorphic/lmms/subscription","commits_url":"https://api.github.com/repos/curlymorphic/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/curlymorphic/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/curlymorphic/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/curlymorphic/lmms/issues/comments/{number}","contents_url":"https://api.github.com/repos/curlymorphic/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/curlymorphic/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/curlymorphic/lmms/merges","archive_url":"https://api.github.com/repos/curlymorphic/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/curlymorphic/lmms/downloads","issues_url":"https://api.github.com/repos/curlymorphic/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/curlymorphic/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/curlymorphic/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/curlymorphic/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/curlymorphic/lmms/labels{/name}","releases_url":"https://api.github.com/repos/curlymorphic/lmms/releases{/id}","created_at":"2014-12-10T08:22:40Z","updated_at":"2014-12-13T16:08:16Z","pushed_at":"2014-12-31T12:27:54Z","git_url":"git://github.com/curlymorphic/lmms.git","ssh_url":"git@github.com:curlymorphic/lmms.git","clone_url":"https://github.com/curlymorphic/lmms.git","svn_url":"https://github.com/curlymorphic/lmms","homepage":"http://lmms.io/","size":56536,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LMMS:master","ref":"master","sha":"6045c2c2bc7c2f0e9f6b473c817aedfaaab906d0","user":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?v=3","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15778896,"name":"lmms","full_name":"LMMS/lmms","owner":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?v=3","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMMS/lmms","description":"cross-platform music production software","fork":false,"url":"https://api.github.com/repos/LMMS/lmms","forks_url":"https://api.github.com/repos/LMMS/lmms/forks","keys_url":"https://api.github.com/repos/LMMS/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMMS/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMMS/lmms/teams","hooks_url":"https://api.github.com/repos/LMMS/lmms/hooks","issue_events_url":"https://api.github.com/repos/LMMS/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/LMMS/lmms/events","assignees_url":"https://api.github.com/repos/LMMS/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/LMMS/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/LMMS/lmms/tags","blobs_url":"https://api.github.com/repos/LMMS/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMMS/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMMS/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMMS/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/LMMS/lmms/languages","stargazers_url":"https://api.github.com/repos/LMMS/lmms/stargazers","contributors_url":"https://api.github.com/repos/LMMS/lmms/contributors","subscribers_url":"https://api.github.com/repos/LMMS/lmms/subscribers","subscription_url":"https://api.github.com/repos/LMMS/lmms/subscription","commits_url":"https://api.github.com/repos/LMMS/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMMS/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMMS/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMMS/lmms/issues/comments/{number}","contents_url":"https://api.github.com/repos/LMMS/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/LMMS/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMMS/lmms/merges","archive_url":"https://api.github.com/repos/LMMS/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMMS/lmms/downloads","issues_url":"https://api.github.com/repos/LMMS/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/LMMS/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/LMMS/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/LMMS/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMMS/lmms/labels{/name}","releases_url":"https://api.github.com/repos/LMMS/lmms/releases{/id}","created_at":"2014-01-09T20:43:43Z","updated_at":"2015-01-04T13:41:44Z","pushed_at":"2015-01-04T15:05:15Z","git_url":"git://github.com/LMMS/lmms.git","ssh_url":"git@github.com:LMMS/lmms.git","clone_url":"https://github.com/LMMS/lmms.git","svn_url":"https://github.com/LMMS/lmms","homepage":"http://lmms.io/","size":69998,"stargazers_count":256,"watchers_count":256,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":394,"forks":93,"open_issues":394,"watchers":256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/1528"},"html":{"href":"https://github.com/LMMS/lmms/pull/1528"},"issue":{"href":"https://api.github.com/repos/LMMS/lmms/issues/1528"},"comments":{"href":"https://api.github.com/repos/LMMS/lmms/issues/1528/comments"},"review_comments":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/1528/comments"},"review_comment":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/1528/commits"},"statuses":{"href":"https://api.github.com/repos/LMMS/lmms/statuses/420bc1b7eda2ef96cca6bc33c343877738034775"}}}}