{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/42850588","id":42850588,"diff_hunk":"@@ -10,5 +10,11 @@\n step 'Run lein once so it sets itself up'\n on master, 'chmod a+x /usr/bin/lein && export LEIN_ROOT=ok && /usr/bin/lein'\n \n-step 'Run pcp-broker in trapperkeeper in background (return immediately)'\n-on master, 'cd ~/pcp-broker; export LEIN_ROOT=ok; lein tk </dev/null >/dev/null 2>&1 &'\n+step 'Run lein deps to download dependencies'\n+# 'lein tk' will download dependencies automatically, but downloading them will take\n+# some time and will eat into the polling period we allow for the broker to start\n+on master, 'cd ~/pcp-broker; export LEIN_ROOT=ok; lein deps'\n+\n+step 'Run pcp-broker in trapperkeeper in background and wait for port 8142'\n+on master, 'cd ~/pcp-broker; export LEIN_ROOT=ok; lein tk </dev/null >/var/log/pcp-broker.log 2>&1 &'\n+retry_on(master, \"ss -nap | grep 'LISTEN.*8142'\", {:max_retries => 60})","path":"acceptance/setup/common/010_Setup_Broker.rb","position":13,"original_position":13,"commit_id":"7de5dfdeca7a456061987b950242f646014c34c5","original_commit_id":"7de5dfdeca7a456061987b950242f646014c34c5","user":{"login":"richardc","id":55650,"avatar_url":"https://avatars.githubusercontent.com/u/55650?v=3","gravatar_id":"","url":"https://api.github.com/users/richardc","html_url":"https://github.com/richardc","followers_url":"https://api.github.com/users/richardc/followers","following_url":"https://api.github.com/users/richardc/following{/other_user}","gists_url":"https://api.github.com/users/richardc/gists{/gist_id}","starred_url":"https://api.github.com/users/richardc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardc/subscriptions","organizations_url":"https://api.github.com/users/richardc/orgs","repos_url":"https://api.github.com/users/richardc/repos","events_url":"https://api.github.com/users/richardc/events{/privacy}","received_events_url":"https://api.github.com/users/richardc/received_events","type":"User","site_admin":false},"body":"Possibly better to use `port_open_within?(master, 8142, 120)` https://github.com/puppetlabs/beaker/blob/master/lib/beaker/dsl/helpers/web_helpers.rb#L9-L13","created_at":"2015-10-23T10:15:07Z","updated_at":"2015-10-23T10:15:07Z","html_url":"https://github.com/puppetlabs/pxp-agent/pull/181#discussion_r42850588","pull_request_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/42850588"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/181#discussion_r42850588"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/181","id":48562502,"html_url":"https://github.com/puppetlabs/pxp-agent/pull/181","diff_url":"https://github.com/puppetlabs/pxp-agent/pull/181.diff","patch_url":"https://github.com/puppetlabs/pxp-agent/pull/181.patch","issue_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/181","number":181,"state":"open","locked":false,"title":"(maint) Improve set-up of pcp-broker in acceptance tests","user":{"login":"james-stocks","id":12136665,"avatar_url":"https://avatars.githubusercontent.com/u/12136665?v=3","gravatar_id":"","url":"https://api.github.com/users/james-stocks","html_url":"https://github.com/james-stocks","followers_url":"https://api.github.com/users/james-stocks/followers","following_url":"https://api.github.com/users/james-stocks/following{/other_user}","gists_url":"https://api.github.com/users/james-stocks/gists{/gist_id}","starred_url":"https://api.github.com/users/james-stocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-stocks/subscriptions","organizations_url":"https://api.github.com/users/james-stocks/orgs","repos_url":"https://api.github.com/users/james-stocks/repos","events_url":"https://api.github.com/users/james-stocks/events{/privacy}","received_events_url":"https://api.github.com/users/james-stocks/received_events","type":"User","site_admin":false},"body":"Add polling of port 8142 to confirm the broker has started up.\r\nSend broker's output to /var/log/pcp-broker.log instead of /dev/null so we have output for troubleshooting.\r\nBefore starting the broker, run 'lein deps' as a separate command so that time-consuming downloading of dependencies is separated from start-up time.","created_at":"2015-10-23T10:08:42Z","updated_at":"2015-10-23T10:15:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94ae63714faedb6b1a7c104c50772dfc32abf7b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/181/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/181/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/181/comments","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/7de5dfdeca7a456061987b950242f646014c34c5","head":{"label":"james-stocks:PCP-66","ref":"PCP-66","sha":"7de5dfdeca7a456061987b950242f646014c34c5","user":{"login":"james-stocks","id":12136665,"avatar_url":"https://avatars.githubusercontent.com/u/12136665?v=3","gravatar_id":"","url":"https://api.github.com/users/james-stocks","html_url":"https://github.com/james-stocks","followers_url":"https://api.github.com/users/james-stocks/followers","following_url":"https://api.github.com/users/james-stocks/following{/other_user}","gists_url":"https://api.github.com/users/james-stocks/gists{/gist_id}","starred_url":"https://api.github.com/users/james-stocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-stocks/subscriptions","organizations_url":"https://api.github.com/users/james-stocks/orgs","repos_url":"https://api.github.com/users/james-stocks/repos","events_url":"https://api.github.com/users/james-stocks/events{/privacy}","received_events_url":"https://api.github.com/users/james-stocks/received_events","type":"User","site_admin":false},"repo":{"id":43741364,"name":"pxp-agent","full_name":"james-stocks/pxp-agent","owner":{"login":"james-stocks","id":12136665,"avatar_url":"https://avatars.githubusercontent.com/u/12136665?v=3","gravatar_id":"","url":"https://api.github.com/users/james-stocks","html_url":"https://github.com/james-stocks","followers_url":"https://api.github.com/users/james-stocks/followers","following_url":"https://api.github.com/users/james-stocks/following{/other_user}","gists_url":"https://api.github.com/users/james-stocks/gists{/gist_id}","starred_url":"https://api.github.com/users/james-stocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-stocks/subscriptions","organizations_url":"https://api.github.com/users/james-stocks/orgs","repos_url":"https://api.github.com/users/james-stocks/repos","events_url":"https://api.github.com/users/james-stocks/events{/privacy}","received_events_url":"https://api.github.com/users/james-stocks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/james-stocks/pxp-agent","description":"Puppet eXecution Protocol Agent","fork":true,"url":"https://api.github.com/repos/james-stocks/pxp-agent","forks_url":"https://api.github.com/repos/james-stocks/pxp-agent/forks","keys_url":"https://api.github.com/repos/james-stocks/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/james-stocks/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/james-stocks/pxp-agent/teams","hooks_url":"https://api.github.com/repos/james-stocks/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/james-stocks/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/james-stocks/pxp-agent/events","assignees_url":"https://api.github.com/repos/james-stocks/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/james-stocks/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/james-stocks/pxp-agent/tags","blobs_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/james-stocks/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/james-stocks/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/james-stocks/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/james-stocks/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/james-stocks/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/james-stocks/pxp-agent/subscription","commits_url":"https://api.github.com/repos/james-stocks/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/james-stocks/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/james-stocks/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/james-stocks/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/james-stocks/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/james-stocks/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/james-stocks/pxp-agent/merges","archive_url":"https://api.github.com/repos/james-stocks/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/james-stocks/pxp-agent/downloads","issues_url":"https://api.github.com/repos/james-stocks/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/james-stocks/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/james-stocks/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/james-stocks/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/james-stocks/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/james-stocks/pxp-agent/releases{/id}","created_at":"2015-10-06T09:30:06Z","updated_at":"2015-10-06T09:30:07Z","pushed_at":"2015-10-23T10:07:57Z","git_url":"git://github.com/james-stocks/pxp-agent.git","ssh_url":"git@github.com:james-stocks/pxp-agent.git","clone_url":"https://github.com/james-stocks/pxp-agent.git","svn_url":"https://github.com/james-stocks/pxp-agent","homepage":"","size":8581,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"0f2474d9b26911e7e217579b833e354faaabf284","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":23231786,"name":"pxp-agent","full_name":"puppetlabs/pxp-agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/pxp-agent","description":"PCP eXecution Protocol Agent","fork":false,"url":"https://api.github.com/repos/puppetlabs/pxp-agent","forks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/pxp-agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/pxp-agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/pxp-agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/pxp-agent/releases{/id}","created_at":"2014-08-22T16:25:01Z","updated_at":"2015-10-19T23:27:50Z","pushed_at":"2015-10-23T10:08:43Z","git_url":"git://github.com/puppetlabs/pxp-agent.git","ssh_url":"git@github.com:puppetlabs/pxp-agent.git","clone_url":"https://github.com/puppetlabs/pxp-agent.git","svn_url":"https://github.com/puppetlabs/pxp-agent","homepage":"","size":10184,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/181"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/181"},"issue":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/181"},"comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/7de5dfdeca7a456061987b950242f646014c34c5"}}}}