{"action":"created","comment":{"url":"https://api.github.com/repos/angular/zone.js/pulls/comments/38799694","id":38799694,"diff_hunk":"@@ -1,11 +1,14 @@\n 'use strict';\n \n+var utils = require('../utils');\n+\n // might need similar for object.freeze\n // i regret nothing\n \n var _defineProperty = Object.defineProperty;\n var _getOwnPropertyDescriptor = Object.getOwnPropertyDescriptor;\n var _create = Object.create;\n+var unconfigurablesKey = utils.getKey('unconfigurables');","path":"lib/patch/define-property.js","position":11,"original_position":11,"commit_id":"4387a0e3a10384e3e109abe54cbf50a56f6bc356","original_commit_id":"4387a0e3a10384e3e109abe54cbf50a56f6bc356","user":{"login":"matthewjh","id":489010,"avatar_url":"https://avatars.githubusercontent.com/u/489010?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewjh","html_url":"https://github.com/matthewjh","followers_url":"https://api.github.com/users/matthewjh/followers","following_url":"https://api.github.com/users/matthewjh/following{/other_user}","gists_url":"https://api.github.com/users/matthewjh/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjh/subscriptions","organizations_url":"https://api.github.com/users/matthewjh/orgs","repos_url":"https://api.github.com/users/matthewjh/repos","events_url":"https://api.github.com/users/matthewjh/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjh/received_events","type":"User","site_admin":false},"body":"Good point, I'll factor this out into `keys.js`. utils already has a fair bit of stuff in it.","created_at":"2015-09-04T22:31:10Z","updated_at":"2015-09-04T22:31:10Z","html_url":"https://github.com/angular/zone.js/pull/173#discussion_r38799694","pull_request_url":"https://api.github.com/repos/angular/zone.js/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/angular/zone.js/pulls/comments/38799694"},"html":{"href":"https://github.com/angular/zone.js/pull/173#discussion_r38799694"},"pull_request":{"href":"https://api.github.com/repos/angular/zone.js/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/angular/zone.js/pulls/173","id":44265390,"html_url":"https://github.com/angular/zone.js/pull/173","diff_url":"https://github.com/angular/zone.js/pull/173.diff","patch_url":"https://github.com/angular/zone.js/pull/173.patch","issue_url":"https://api.github.com/repos/angular/zone.js/issues/173","number":173,"state":"open","locked":false,"title":"Use symbols if possible for private properties on exposed objects","user":{"login":"matthewjh","id":489010,"avatar_url":"https://avatars.githubusercontent.com/u/489010?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewjh","html_url":"https://github.com/matthewjh","followers_url":"https://api.github.com/users/matthewjh/followers","following_url":"https://api.github.com/users/matthewjh/following{/other_user}","gists_url":"https://api.github.com/users/matthewjh/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjh/subscriptions","organizations_url":"https://api.github.com/users/matthewjh/orgs","repos_url":"https://api.github.com/users/matthewjh/repos","events_url":"https://api.github.com/users/matthewjh/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjh/received_events","type":"User","site_admin":false},"body":"#172 \r\n\r\nSeeing whether this passes on Travis…","created_at":"2015-09-04T21:57:34Z","updated_at":"2015-09-04T22:31:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1757ad71b946fe3a73499904ac013053cb841eb3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/zone.js/pulls/173/commits","review_comments_url":"https://api.github.com/repos/angular/zone.js/pulls/173/comments","review_comment_url":"https://api.github.com/repos/angular/zone.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/zone.js/issues/173/comments","statuses_url":"https://api.github.com/repos/angular/zone.js/statuses/4387a0e3a10384e3e109abe54cbf50a56f6bc356","head":{"label":"matthewjh:use-symbols","ref":"use-symbols","sha":"4387a0e3a10384e3e109abe54cbf50a56f6bc356","user":{"login":"matthewjh","id":489010,"avatar_url":"https://avatars.githubusercontent.com/u/489010?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewjh","html_url":"https://github.com/matthewjh","followers_url":"https://api.github.com/users/matthewjh/followers","following_url":"https://api.github.com/users/matthewjh/following{/other_user}","gists_url":"https://api.github.com/users/matthewjh/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjh/subscriptions","organizations_url":"https://api.github.com/users/matthewjh/orgs","repos_url":"https://api.github.com/users/matthewjh/repos","events_url":"https://api.github.com/users/matthewjh/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjh/received_events","type":"User","site_admin":false},"repo":{"id":38687361,"name":"zone.js","full_name":"matthewjh/zone.js","owner":{"login":"matthewjh","id":489010,"avatar_url":"https://avatars.githubusercontent.com/u/489010?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewjh","html_url":"https://github.com/matthewjh","followers_url":"https://api.github.com/users/matthewjh/followers","following_url":"https://api.github.com/users/matthewjh/following{/other_user}","gists_url":"https://api.github.com/users/matthewjh/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjh/subscriptions","organizations_url":"https://api.github.com/users/matthewjh/orgs","repos_url":"https://api.github.com/users/matthewjh/repos","events_url":"https://api.github.com/users/matthewjh/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewjh/zone.js","description":"Implements Zones for JavaScript","fork":true,"url":"https://api.github.com/repos/matthewjh/zone.js","forks_url":"https://api.github.com/repos/matthewjh/zone.js/forks","keys_url":"https://api.github.com/repos/matthewjh/zone.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewjh/zone.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewjh/zone.js/teams","hooks_url":"https://api.github.com/repos/matthewjh/zone.js/hooks","issue_events_url":"https://api.github.com/repos/matthewjh/zone.js/issues/events{/number}","events_url":"https://api.github.com/repos/matthewjh/zone.js/events","assignees_url":"https://api.github.com/repos/matthewjh/zone.js/assignees{/user}","branches_url":"https://api.github.com/repos/matthewjh/zone.js/branches{/branch}","tags_url":"https://api.github.com/repos/matthewjh/zone.js/tags","blobs_url":"https://api.github.com/repos/matthewjh/zone.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewjh/zone.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewjh/zone.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewjh/zone.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewjh/zone.js/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewjh/zone.js/languages","stargazers_url":"https://api.github.com/repos/matthewjh/zone.js/stargazers","contributors_url":"https://api.github.com/repos/matthewjh/zone.js/contributors","subscribers_url":"https://api.github.com/repos/matthewjh/zone.js/subscribers","subscription_url":"https://api.github.com/repos/matthewjh/zone.js/subscription","commits_url":"https://api.github.com/repos/matthewjh/zone.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewjh/zone.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewjh/zone.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewjh/zone.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewjh/zone.js/contents/{+path}","compare_url":"https://api.github.com/repos/matthewjh/zone.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewjh/zone.js/merges","archive_url":"https://api.github.com/repos/matthewjh/zone.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewjh/zone.js/downloads","issues_url":"https://api.github.com/repos/matthewjh/zone.js/issues{/number}","pulls_url":"https://api.github.com/repos/matthewjh/zone.js/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewjh/zone.js/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewjh/zone.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewjh/zone.js/labels{/name}","releases_url":"https://api.github.com/repos/matthewjh/zone.js/releases{/id}","created_at":"2015-07-07T12:51:02Z","updated_at":"2015-07-07T12:51:02Z","pushed_at":"2015-09-04T21:51:23Z","git_url":"git://github.com/matthewjh/zone.js.git","ssh_url":"git@github.com:matthewjh/zone.js.git","clone_url":"https://github.com/matthewjh/zone.js.git","svn_url":"https://github.com/matthewjh/zone.js","homepage":"https://github.com/angular/zone.js","size":518,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"18974403845a68dd450180b80c18fe20cb7a7959","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":15467734,"name":"zone.js","full_name":"angular/zone.js","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/zone.js","description":"Implements Zones for JavaScript","fork":false,"url":"https://api.github.com/repos/angular/zone.js","forks_url":"https://api.github.com/repos/angular/zone.js/forks","keys_url":"https://api.github.com/repos/angular/zone.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/zone.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/zone.js/teams","hooks_url":"https://api.github.com/repos/angular/zone.js/hooks","issue_events_url":"https://api.github.com/repos/angular/zone.js/issues/events{/number}","events_url":"https://api.github.com/repos/angular/zone.js/events","assignees_url":"https://api.github.com/repos/angular/zone.js/assignees{/user}","branches_url":"https://api.github.com/repos/angular/zone.js/branches{/branch}","tags_url":"https://api.github.com/repos/angular/zone.js/tags","blobs_url":"https://api.github.com/repos/angular/zone.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/zone.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/zone.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/zone.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/zone.js/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/zone.js/languages","stargazers_url":"https://api.github.com/repos/angular/zone.js/stargazers","contributors_url":"https://api.github.com/repos/angular/zone.js/contributors","subscribers_url":"https://api.github.com/repos/angular/zone.js/subscribers","subscription_url":"https://api.github.com/repos/angular/zone.js/subscription","commits_url":"https://api.github.com/repos/angular/zone.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/zone.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/zone.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/zone.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/zone.js/contents/{+path}","compare_url":"https://api.github.com/repos/angular/zone.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/zone.js/merges","archive_url":"https://api.github.com/repos/angular/zone.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/zone.js/downloads","issues_url":"https://api.github.com/repos/angular/zone.js/issues{/number}","pulls_url":"https://api.github.com/repos/angular/zone.js/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/zone.js/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/zone.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/zone.js/labels{/name}","releases_url":"https://api.github.com/repos/angular/zone.js/releases{/id}","created_at":"2013-12-27T06:08:07Z","updated_at":"2015-09-04T13:02:28Z","pushed_at":"2015-09-04T21:57:34Z","git_url":"git://github.com/angular/zone.js.git","ssh_url":"git@github.com:angular/zone.js.git","clone_url":"https://github.com/angular/zone.js.git","svn_url":"https://github.com/angular/zone.js","homepage":"https://github.com/angular/zone.js","size":1616,"stargazers_count":847,"watchers_count":847,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":47,"forks":64,"open_issues":47,"watchers":847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/zone.js/pulls/173"},"html":{"href":"https://github.com/angular/zone.js/pull/173"},"issue":{"href":"https://api.github.com/repos/angular/zone.js/issues/173"},"comments":{"href":"https://api.github.com/repos/angular/zone.js/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/zone.js/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/zone.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/zone.js/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/angular/zone.js/statuses/4387a0e3a10384e3e109abe54cbf50a56f6bc356"}}}}