{"action":"created","issue":{"url":"https://api.github.com/repos/tornadoweb/tornado/issues/1604","labels_url":"https://api.github.com/repos/tornadoweb/tornado/issues/1604/labels{/name}","comments_url":"https://api.github.com/repos/tornadoweb/tornado/issues/1604/comments","events_url":"https://api.github.com/repos/tornadoweb/tornado/issues/1604/events","html_url":"https://github.com/tornadoweb/tornado/pull/1604","id":122024092,"number":1604,"title":"make kwargs always work in AsyncHTTPClient.fetch()","user":{"login":"liaoxiaorong","id":4261415,"avatar_url":"https://avatars.githubusercontent.com/u/4261415?v=3","gravatar_id":"","url":"https://api.github.com/users/liaoxiaorong","html_url":"https://github.com/liaoxiaorong","followers_url":"https://api.github.com/users/liaoxiaorong/followers","following_url":"https://api.github.com/users/liaoxiaorong/following{/other_user}","gists_url":"https://api.github.com/users/liaoxiaorong/gists{/gist_id}","starred_url":"https://api.github.com/users/liaoxiaorong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liaoxiaorong/subscriptions","organizations_url":"https://api.github.com/users/liaoxiaorong/orgs","repos_url":"https://api.github.com/users/liaoxiaorong/repos","events_url":"https://api.github.com/users/liaoxiaorong/events{/privacy}","received_events_url":"https://api.github.com/users/liaoxiaorong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-14T11:24:31Z","updated_at":"2015-12-18T07:16:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tornadoweb/tornado/pulls/1604","html_url":"https://github.com/tornadoweb/tornado/pull/1604","diff_url":"https://github.com/tornadoweb/tornado/pull/1604.diff","patch_url":"https://github.com/tornadoweb/tornado/pull/1604.patch"},"body":"If request is HTTPRequest, then any kwargs in [fetch](https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py#L206) won't work. And there is no warning or error happen.\r\n\r\nNow we can do something like:\r\n\r\n        req = httpclient.HTTPRequest(url, method=\"POST\", body=data)\r\n        response = httpclient.fetch(req, request_timeout=20)\r\n\r\nI think it is a better fetch."},"comment":{"url":"https://api.github.com/repos/tornadoweb/tornado/issues/comments/165699370","html_url":"https://github.com/tornadoweb/tornado/pull/1604#issuecomment-165699370","issue_url":"https://api.github.com/repos/tornadoweb/tornado/issues/1604","id":165699370,"user":{"login":"liaoxiaorong","id":4261415,"avatar_url":"https://avatars.githubusercontent.com/u/4261415?v=3","gravatar_id":"","url":"https://api.github.com/users/liaoxiaorong","html_url":"https://github.com/liaoxiaorong","followers_url":"https://api.github.com/users/liaoxiaorong/followers","following_url":"https://api.github.com/users/liaoxiaorong/following{/other_user}","gists_url":"https://api.github.com/users/liaoxiaorong/gists{/gist_id}","starred_url":"https://api.github.com/users/liaoxiaorong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liaoxiaorong/subscriptions","organizations_url":"https://api.github.com/users/liaoxiaorong/orgs","repos_url":"https://api.github.com/users/liaoxiaorong/repos","events_url":"https://api.github.com/users/liaoxiaorong/events{/privacy}","received_events_url":"https://api.github.com/users/liaoxiaorong/received_events","type":"User","site_admin":false},"created_at":"2015-12-18T07:16:47Z","updated_at":"2015-12-18T07:16:47Z","body":"If I add a `update` method in `HTTPRequest`, then use this method update `kwargs`. What do your think? @bdarnell "}}