{"action":"created","issue":{"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/296","labels_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/296/labels{/name}","comments_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/296/comments","events_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/296/events","html_url":"https://github.com/UCATLAS/xAODAnaHelpers/issues/296","id":112527693,"number":296,"title":"Use of inheritance for Objection selectors ","user":{"login":"johnda102","id":7108106,"avatar_url":"https://avatars.githubusercontent.com/u/7108106?v=3","gravatar_id":"","url":"https://api.github.com/users/johnda102","html_url":"https://github.com/johnda102","followers_url":"https://api.github.com/users/johnda102/followers","following_url":"https://api.github.com/users/johnda102/following{/other_user}","gists_url":"https://api.github.com/users/johnda102/gists{/gist_id}","starred_url":"https://api.github.com/users/johnda102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnda102/subscriptions","organizations_url":"https://api.github.com/users/johnda102/orgs","repos_url":"https://api.github.com/users/johnda102/repos","events_url":"https://api.github.com/users/johnda102/events{/privacy}","received_events_url":"https://api.github.com/users/johnda102/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"kkrizka","id":177068,"avatar_url":"https://avatars.githubusercontent.com/u/177068?v=3","gravatar_id":"","url":"https://api.github.com/users/kkrizka","html_url":"https://github.com/kkrizka","followers_url":"https://api.github.com/users/kkrizka/followers","following_url":"https://api.github.com/users/kkrizka/following{/other_user}","gists_url":"https://api.github.com/users/kkrizka/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrizka/subscriptions","organizations_url":"https://api.github.com/users/kkrizka/orgs","repos_url":"https://api.github.com/users/kkrizka/repos","events_url":"https://api.github.com/users/kkrizka/events{/privacy}","received_events_url":"https://api.github.com/users/kkrizka/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-10-21T07:31:58Z","updated_at":"2015-10-21T07:40:27Z","closed_at":null,"body":"As we add more different kinds of object selectors (Photons / leptons / truth ect. ) we are duplicating alot of code in the different selectors. \r\n\r\nWe should make an object selector base class and have the specific selectors inherit from it. "},"comment":{"url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/comments/149806106","html_url":"https://github.com/UCATLAS/xAODAnaHelpers/issues/296#issuecomment-149806106","issue_url":"https://api.github.com/repos/UCATLAS/xAODAnaHelpers/issues/296","id":149806106,"user":{"login":"gfacini","id":10064627,"avatar_url":"https://avatars.githubusercontent.com/u/10064627?v=3","gravatar_id":"","url":"https://api.github.com/users/gfacini","html_url":"https://github.com/gfacini","followers_url":"https://api.github.com/users/gfacini/followers","following_url":"https://api.github.com/users/gfacini/following{/other_user}","gists_url":"https://api.github.com/users/gfacini/gists{/gist_id}","starred_url":"https://api.github.com/users/gfacini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfacini/subscriptions","organizations_url":"https://api.github.com/users/gfacini/orgs","repos_url":"https://api.github.com/users/gfacini/repos","events_url":"https://api.github.com/users/gfacini/events{/privacy}","received_events_url":"https://api.github.com/users/gfacini/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T07:40:27Z","updated_at":"2015-10-21T07:40:27Z","body":"Hi Guys,\n\nCareful here - we tried not to make things too convoluted with inherited\nclasses to make the\ncode easy to read for beginners.\n\nI support making the code cleaner but lets not\ngo off the deep end (please).\n\nCheers,\nGabriel\n\nOn Wed, Oct 21, 2015 at 9:36 AM, Karol Krizka <notifications@github.com>\nwrote:\n\n> I plan to do this after I commit the initial PhotonSelector (later today).\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/UCATLAS/xAODAnaHelpers/issues/296#issuecomment-149805359>\n> .\n>\n"}}