{"action":"created","issue":{"url":"https://api.github.com/repos/scalatest/scalatest/issues/631","labels_url":"https://api.github.com/repos/scalatest/scalatest/issues/631/labels{/name}","comments_url":"https://api.github.com/repos/scalatest/scalatest/issues/631/comments","events_url":"https://api.github.com/repos/scalatest/scalatest/issues/631/events","html_url":"https://github.com/scalatest/scalatest/issues/631","id":91765475,"number":631,"title":"Add PropertyChecks for scala.js on 3.0.0","user":{"login":"InTheNow","id":5887373,"avatar_url":"https://avatars.githubusercontent.com/u/5887373?v=3","gravatar_id":"","url":"https://api.github.com/users/InTheNow","html_url":"https://github.com/InTheNow","followers_url":"https://api.github.com/users/InTheNow/followers","following_url":"https://api.github.com/users/InTheNow/following{/other_user}","gists_url":"https://api.github.com/users/InTheNow/gists{/gist_id}","starred_url":"https://api.github.com/users/InTheNow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InTheNow/subscriptions","organizations_url":"https://api.github.com/users/InTheNow/orgs","repos_url":"https://api.github.com/users/InTheNow/repos","events_url":"https://api.github.com/users/InTheNow/events{/privacy}","received_events_url":"https://api.github.com/users/InTheNow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-06-29T10:17:51Z","updated_at":"2015-07-11T11:11:12Z","closed_at":null,"body":"I'm porting typelevel Discipline to sjs and scalcheck integration is a must have. This is also the case for Cats and supporting modules. \r\n\r\nLocally I got this working fine on a local build, but on an older versiion od scalatest-js. Diffs :\r\n\r\n```diff\r\ndiff --git a/project/GenScalaTestJS.scala b/project/GenScalaTestJS.scala\r\nindex 751747b..0ab380c 100644\r\n--- a/project/GenScalaTestJS.scala\r\n+++ b/project/GenScalaTestJS.scala\r\n@@ -371,9 +371,9 @@ object GenScalaTestJS {\r\n       ), targetDir) ++\r\n     copyDir(\"scalatest/src/main/scala/org/scalatest/prop\", \"org/scalatest/prop\",\r\n       List(\r\n-        //\"Configuration.scala\",\r\n-        //\"Checkers.scala\",\r\n-        //\"PropertyChecks.scala\",\r\n+        \"Configuration.scala\",\r\n+        \"Checkers.scala\",\r\n+        \"PropertyChecks.scala\",\r\n         \"Whenever.scala\"\r\n       ), targetDir) ++\r\n     copyDir(\"scalatest/src/main/scala/org/scalatest/concurrent\", \"org/scalatest/concurrent\",\r\n```\r\n\r\n```diff\r\ndiff --git a/scalatest/src/main/scala/org/scalatest/prop/Checkers.scala b/scalatest/src/main/scala/org/scalatest/prop/Checkers.scala\r\nindex a6e1602..dd38bf9 100644\r\n--- a/scalatest/src/main/scala/org/scalatest/prop/Checkers.scala\r\n+++ b/scalatest/src/main/scala/org/scalatest/prop/Checkers.scala\r\n@@ -225,6 +225,7 @@ repeatedly pass generated data to the function. In this case, the test data is c\r\n  *\r\n  * @author Bill Venners\r\n  */\r\n+// SCALATESTJS-ONLY @scala.scalajs.js.annotation.JSExportDescendentClasses(ignoreInvalidDescendants = true)\r\n trait Checkers extends Configuration {\r\n \r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/scalatest/scalatest/issues/comments/120605034","html_url":"https://github.com/scalatest/scalatest/issues/631#issuecomment-120605034","issue_url":"https://api.github.com/repos/scalatest/scalatest/issues/631","id":120605034,"user":{"login":"cheeseng","id":1322009,"avatar_url":"https://avatars.githubusercontent.com/u/1322009?v=3","gravatar_id":"","url":"https://api.github.com/users/cheeseng","html_url":"https://github.com/cheeseng","followers_url":"https://api.github.com/users/cheeseng/followers","following_url":"https://api.github.com/users/cheeseng/following{/other_user}","gists_url":"https://api.github.com/users/cheeseng/gists{/gist_id}","starred_url":"https://api.github.com/users/cheeseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheeseng/subscriptions","organizations_url":"https://api.github.com/users/cheeseng/orgs","repos_url":"https://api.github.com/users/cheeseng/repos","events_url":"https://api.github.com/users/cheeseng/events{/privacy}","received_events_url":"https://api.github.com/users/cheeseng/received_events","type":"User","site_admin":false},"created_at":"2015-07-11T11:11:11Z","updated_at":"2015-07-11T11:11:11Z","body":"Hi Allstair,\n\nSeems like incompatible issue between scalacheck 1.12.3 and 1.12.4, I have\nsubmitted a PR to update to use scalacheck 1.12.4:\n\nhttps://github.com/scalatest/scalatest/pull/639\n\nThe JSExportDescendentClasses that you added to Checkers is not required\nimho, or I could be missing something, do you mind to give the branch a try\nto see if it fixes your problem?\n\nThanks.\n\nChee Seng\n\n\nOn Sat, Jul 11, 2015 at 2:14 AM, Alistair Johnson <notifications@github.com>\nwrote:\n\n> Still no joy with M6, but works with a local, hacked build of scalatest.\n> Build is at https://github.com/InTheNow/discipline/tree/topic/sjs and the\n> diff for branch 3.0.x is:\n>\n> diff --git a/project/scalatest.scala b/project/scalatest.scala\n> index caffb8b..8ab54d2 100644--- a/project/scalatest.scala+++ b/project/scalatest.scala@@ -132,7 +132,7 @@ object ScalatestBuild extends Build {\n>    )\n>\n>    def scalacheckDependency(config: String) =-    \"org.scalacheck\" %% \"scalacheck\" % \"1.12.3\" % config+    \"org.scalacheck\" %% \"scalacheck\" % \"1.12.4\" % config\n>\n>    def crossBuildLibraryDependencies(theScalaVersion: String) =\n>      CrossVersion.partialVersion(theScalaVersion) match {@@ -173,7 +173,8 @@ object ScalatestBuild extends Build {\n>\n>    def scalatestJSLibraryDependencies =\n>      Seq(-      \"org.scala-js\" %% \"scalajs-test-interface\" % \"0.6.4\"+      \"org.scala-js\" %% \"scalajs-test-interface\" % \"0.6.4\",+      \"org.scalacheck\" %% \"scalacheck_sjs0.6\" % \"1.12.4\"\n>      )\n>\n>    def scalatestTestOptions =@@ -499,8 +500,8 @@ object ScalatestBuild extends Build {\n>          (baseDirectory, sourceManaged in Compile, version, scalaVersion) map genFiles(\"gentables\", \"GenTable.scala\")(GenTable.genMainForScalaJS),\n>        sourceGenerators in Compile <+=\n>          (baseDirectory, sourceManaged in Compile, version, scalaVersion) map genFiles(\"genmatchers\", \"MustMatchers.scala\")(GenMatchers.genMainForScalaJS),-      /*genMustMatchersTask,\n>        genGenTask,+      /*genMustMatchersTask,\n>        genTablesTask,\n>        genCodeTask,\n>        genCompatibleClassesTask,diff --git a/scalatest/src/main/scala/org/scalatest/prop/Checkers.scala b/scalatest/src/main/scala/org/scalatest/prop/Checkers.scala\n> index 67fb8f3..326a53d 100644--- a/scalatest/src/main/scala/org/scalatest/prop/Checkers.scala+++ b/scalatest/src/main/scala/org/scalatest/prop/Checkers.scala@@ -228,6 +228,8 @@ repeatedly pass generated data to the function. In this case, the test data is c\n>   *\n>   * @author Bill Venners\n>   */+ // SCALATESTJS-ONLY @scala.scalajs.js.annotation.JSExportDescendentClasses(ignoreInvalidDescendants = true)+\n>  trait Checkers extends Configuration {\n>\n>    /**\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/scalatest/scalatest/issues/631#issuecomment-120483642>\n> .\n>\n"}}