{"action":"created","issue":{"url":"https://api.github.com/repos/spf13/hugo/issues/1573","labels_url":"https://api.github.com/repos/spf13/hugo/issues/1573/labels{/name}","comments_url":"https://api.github.com/repos/spf13/hugo/issues/1573/comments","events_url":"https://api.github.com/repos/spf13/hugo/issues/1573/events","html_url":"https://github.com/spf13/hugo/pull/1573","id":116864121,"number":1573,"title":"Make replaceShortcodeTokens modify the input slice","user":{"login":"bep","id":394382,"avatar_url":"https://avatars.githubusercontent.com/u/394382?v=3","gravatar_id":"","url":"https://api.github.com/users/bep","html_url":"https://github.com/bep","followers_url":"https://api.github.com/users/bep/followers","following_url":"https://api.github.com/users/bep/following{/other_user}","gists_url":"https://api.github.com/users/bep/gists{/gist_id}","starred_url":"https://api.github.com/users/bep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bep/subscriptions","organizations_url":"https://api.github.com/users/bep/orgs","repos_url":"https://api.github.com/users/bep/repos","events_url":"https://api.github.com/users/bep/events{/privacy}","received_events_url":"https://api.github.com/users/bep/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-13T22:15:14Z","updated_at":"2015-11-17T09:47:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spf13/hugo/pulls/1573","html_url":"https://github.com/spf13/hugo/pull/1573","diff_url":"https://github.com/spf13/hugo/pull/1573.diff","patch_url":"https://github.com/spf13/hugo/pull/1573.patch"},"body":"Currently a `[]byte` copy is returned. In most cases this is the safe thing to do, but we should just modify/grow the slice as needed.\n\nIt is better that `Page.rawContent` reflects the content after shortcode expansion, and it is faster and consumes less memory:\n\n```\nbenchmark                             old ns/op     new ns/op     delta\nBenchmarkReplaceShortcodeTokens-4     7350          4419          -39.88%\n\nbenchmark                             old allocs     new allocs     delta\nBenchmarkReplaceShortcodeTokens-4     5              1              -80.00%\n\nbenchmark                             old bytes     new bytes     delta\nBenchmarkReplaceShortcodeTokens-4     4816          1152          -76.08%\n```\n\nFixes #1516"},"comment":{"url":"https://api.github.com/repos/spf13/hugo/issues/comments/157322344","html_url":"https://github.com/spf13/hugo/pull/1573#issuecomment-157322344","issue_url":"https://api.github.com/repos/spf13/hugo/issues/1573","id":157322344,"user":{"login":"bep","id":394382,"avatar_url":"https://avatars.githubusercontent.com/u/394382?v=3","gravatar_id":"","url":"https://api.github.com/users/bep","html_url":"https://github.com/bep","followers_url":"https://api.github.com/users/bep/followers","following_url":"https://api.github.com/users/bep/following{/other_user}","gists_url":"https://api.github.com/users/bep/gists{/gist_id}","starred_url":"https://api.github.com/users/bep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bep/subscriptions","organizations_url":"https://api.github.com/users/bep/orgs","repos_url":"https://api.github.com/users/bep/repos","events_url":"https://api.github.com/users/bep/events{/privacy}","received_events_url":"https://api.github.com/users/bep/received_events","type":"User","site_admin":false},"created_at":"2015-11-17T09:47:57Z","updated_at":"2015-11-17T09:47:57Z","body":"I have to look a little close on this method's many uses -- will do tonight."}}