{"action":"created","comment":{"url":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/comments/36545859","id":36545859,"diff_hunk":"@@ -0,0 +1,73 @@\n+package com.kritsit.casetracker.client.domain.ui.controller;\n+\n+import com.kritsit.casetracker.client.domain.services.IMenuService;\n+import com.kritsit.casetracker.shared.domain.model.Staff;\n+\n+import javafx.collections.FXCollections;\n+import javafx.fxml.FXML;\n+import javafx.scene.control.Alert;\n+import javafx.scene.control.Button;\n+import javafx.scene.control.PasswordField;\n+import javafx.scene.control.Alert.AlertType;\n+\n+public class ChangePasswordController {\n+    \n+    private Staff user;\n+    private IMenuService menuService;\n+    \n+    public ChangePasswordController(Staff user, IMenuService menuService){\n+        this.user=user;\n+        this.menuService=menuService;\n+    }\n+    \n+    public void initialize(){\n+        changePasswordButton.setOnAction(event->{\n+            changePassword(this.user, this.menuService);\n+        });\n+    }\n+\n+    private void changePassword(Staff user, IMenuService menuService){\n+        Alert alert;\n+        if(currentPasswordField.getText().equals(\"\")||newPasswordField.getText().equals(\"\")){","path":"client/src/main/java/com/kritsit/casetracker/client/domain/ui/controller/ChangePasswordController.java","position":31,"original_position":31,"commit_id":"d89c51b6f63895362f119264a5eacc5a6de9c0c1","original_commit_id":"d89c51b6f63895362f119264a5eacc5a6de9c0c1","user":{"login":"paddatrapper","id":7299909,"avatar_url":"https://avatars.githubusercontent.com/u/7299909?v=3","gravatar_id":"","url":"https://api.github.com/users/paddatrapper","html_url":"https://github.com/paddatrapper","followers_url":"https://api.github.com/users/paddatrapper/followers","following_url":"https://api.github.com/users/paddatrapper/following{/other_user}","gists_url":"https://api.github.com/users/paddatrapper/gists{/gist_id}","starred_url":"https://api.github.com/users/paddatrapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paddatrapper/subscriptions","organizations_url":"https://api.github.com/users/paddatrapper/orgs","repos_url":"https://api.github.com/users/paddatrapper/repos","events_url":"https://api.github.com/users/paddatrapper/events{/privacy}","received_events_url":"https://api.github.com/users/paddatrapper/received_events","type":"User","site_admin":false},"body":"Rather here call `curentPasswordField.getText().trim().isEmpty()` and the same for newPasswordField","created_at":"2015-08-07T18:17:37Z","updated_at":"2015-08-07T18:17:37Z","html_url":"https://github.com/paddatrapper/CaseTracker/pull/39#discussion_r36545859","pull_request_url":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/comments/36545859"},"html":{"href":"https://github.com/paddatrapper/CaseTracker/pull/39#discussion_r36545859"},"pull_request":{"href":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/39","id":41417327,"html_url":"https://github.com/paddatrapper/CaseTracker/pull/39","diff_url":"https://github.com/paddatrapper/CaseTracker/pull/39.diff","patch_url":"https://github.com/paddatrapper/CaseTracker/pull/39.patch","issue_url":"https://api.github.com/repos/paddatrapper/CaseTracker/issues/39","number":39,"state":"open","locked":false,"title":"menu bars","user":{"login":"pawc","id":12101381,"avatar_url":"https://avatars.githubusercontent.com/u/12101381?v=3","gravatar_id":"","url":"https://api.github.com/users/pawc","html_url":"https://github.com/pawc","followers_url":"https://api.github.com/users/pawc/followers","following_url":"https://api.github.com/users/pawc/following{/other_user}","gists_url":"https://api.github.com/users/pawc/gists{/gist_id}","starred_url":"https://api.github.com/users/pawc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawc/subscriptions","organizations_url":"https://api.github.com/users/pawc/orgs","repos_url":"https://api.github.com/users/pawc/repos","events_url":"https://api.github.com/users/pawc/events{/privacy}","received_events_url":"https://api.github.com/users/pawc/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-02T12:44:53Z","updated_at":"2015-08-07T18:17:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8059e36fbcce064a84ab233bb1a058dea3e601ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/39/commits","review_comments_url":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/39/comments","review_comment_url":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paddatrapper/CaseTracker/issues/39/comments","statuses_url":"https://api.github.com/repos/paddatrapper/CaseTracker/statuses/d89c51b6f63895362f119264a5eacc5a6de9c0c1","head":{"label":"pawc:master","ref":"master","sha":"d89c51b6f63895362f119264a5eacc5a6de9c0c1","user":{"login":"pawc","id":12101381,"avatar_url":"https://avatars.githubusercontent.com/u/12101381?v=3","gravatar_id":"","url":"https://api.github.com/users/pawc","html_url":"https://github.com/pawc","followers_url":"https://api.github.com/users/pawc/followers","following_url":"https://api.github.com/users/pawc/following{/other_user}","gists_url":"https://api.github.com/users/pawc/gists{/gist_id}","starred_url":"https://api.github.com/users/pawc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawc/subscriptions","organizations_url":"https://api.github.com/users/pawc/orgs","repos_url":"https://api.github.com/users/pawc/repos","events_url":"https://api.github.com/users/pawc/events{/privacy}","received_events_url":"https://api.github.com/users/pawc/received_events","type":"User","site_admin":false},"repo":{"id":37862902,"name":"CaseTracker","full_name":"pawc/CaseTracker","owner":{"login":"pawc","id":12101381,"avatar_url":"https://avatars.githubusercontent.com/u/12101381?v=3","gravatar_id":"","url":"https://api.github.com/users/pawc","html_url":"https://github.com/pawc","followers_url":"https://api.github.com/users/pawc/followers","following_url":"https://api.github.com/users/pawc/following{/other_user}","gists_url":"https://api.github.com/users/pawc/gists{/gist_id}","starred_url":"https://api.github.com/users/pawc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawc/subscriptions","organizations_url":"https://api.github.com/users/pawc/orgs","repos_url":"https://api.github.com/users/pawc/repos","events_url":"https://api.github.com/users/pawc/events{/privacy}","received_events_url":"https://api.github.com/users/pawc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pawc/CaseTracker","description":"Case tracking and management software for the National SPCA","fork":true,"url":"https://api.github.com/repos/pawc/CaseTracker","forks_url":"https://api.github.com/repos/pawc/CaseTracker/forks","keys_url":"https://api.github.com/repos/pawc/CaseTracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pawc/CaseTracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pawc/CaseTracker/teams","hooks_url":"https://api.github.com/repos/pawc/CaseTracker/hooks","issue_events_url":"https://api.github.com/repos/pawc/CaseTracker/issues/events{/number}","events_url":"https://api.github.com/repos/pawc/CaseTracker/events","assignees_url":"https://api.github.com/repos/pawc/CaseTracker/assignees{/user}","branches_url":"https://api.github.com/repos/pawc/CaseTracker/branches{/branch}","tags_url":"https://api.github.com/repos/pawc/CaseTracker/tags","blobs_url":"https://api.github.com/repos/pawc/CaseTracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pawc/CaseTracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pawc/CaseTracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/pawc/CaseTracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pawc/CaseTracker/statuses/{sha}","languages_url":"https://api.github.com/repos/pawc/CaseTracker/languages","stargazers_url":"https://api.github.com/repos/pawc/CaseTracker/stargazers","contributors_url":"https://api.github.com/repos/pawc/CaseTracker/contributors","subscribers_url":"https://api.github.com/repos/pawc/CaseTracker/subscribers","subscription_url":"https://api.github.com/repos/pawc/CaseTracker/subscription","commits_url":"https://api.github.com/repos/pawc/CaseTracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/pawc/CaseTracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/pawc/CaseTracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/pawc/CaseTracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/pawc/CaseTracker/contents/{+path}","compare_url":"https://api.github.com/repos/pawc/CaseTracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pawc/CaseTracker/merges","archive_url":"https://api.github.com/repos/pawc/CaseTracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pawc/CaseTracker/downloads","issues_url":"https://api.github.com/repos/pawc/CaseTracker/issues{/number}","pulls_url":"https://api.github.com/repos/pawc/CaseTracker/pulls{/number}","milestones_url":"https://api.github.com/repos/pawc/CaseTracker/milestones{/number}","notifications_url":"https://api.github.com/repos/pawc/CaseTracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pawc/CaseTracker/labels{/name}","releases_url":"https://api.github.com/repos/pawc/CaseTracker/releases{/id}","created_at":"2015-06-22T15:17:41Z","updated_at":"2015-06-22T15:17:41Z","pushed_at":"2015-08-07T17:32:05Z","git_url":"git://github.com/pawc/CaseTracker.git","ssh_url":"git@github.com:pawc/CaseTracker.git","clone_url":"https://github.com/pawc/CaseTracker.git","svn_url":"https://github.com/pawc/CaseTracker","homepage":null,"size":1173,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paddatrapper:master","ref":"master","sha":"50665aa4ad15ccf288ac5a2a1e0d68d851a88426","user":{"login":"paddatrapper","id":7299909,"avatar_url":"https://avatars.githubusercontent.com/u/7299909?v=3","gravatar_id":"","url":"https://api.github.com/users/paddatrapper","html_url":"https://github.com/paddatrapper","followers_url":"https://api.github.com/users/paddatrapper/followers","following_url":"https://api.github.com/users/paddatrapper/following{/other_user}","gists_url":"https://api.github.com/users/paddatrapper/gists{/gist_id}","starred_url":"https://api.github.com/users/paddatrapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paddatrapper/subscriptions","organizations_url":"https://api.github.com/users/paddatrapper/orgs","repos_url":"https://api.github.com/users/paddatrapper/repos","events_url":"https://api.github.com/users/paddatrapper/events{/privacy}","received_events_url":"https://api.github.com/users/paddatrapper/received_events","type":"User","site_admin":false},"repo":{"id":28605092,"name":"CaseTracker","full_name":"paddatrapper/CaseTracker","owner":{"login":"paddatrapper","id":7299909,"avatar_url":"https://avatars.githubusercontent.com/u/7299909?v=3","gravatar_id":"","url":"https://api.github.com/users/paddatrapper","html_url":"https://github.com/paddatrapper","followers_url":"https://api.github.com/users/paddatrapper/followers","following_url":"https://api.github.com/users/paddatrapper/following{/other_user}","gists_url":"https://api.github.com/users/paddatrapper/gists{/gist_id}","starred_url":"https://api.github.com/users/paddatrapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paddatrapper/subscriptions","organizations_url":"https://api.github.com/users/paddatrapper/orgs","repos_url":"https://api.github.com/users/paddatrapper/repos","events_url":"https://api.github.com/users/paddatrapper/events{/privacy}","received_events_url":"https://api.github.com/users/paddatrapper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paddatrapper/CaseTracker","description":"Case tracking and management software for the National SPCA","fork":false,"url":"https://api.github.com/repos/paddatrapper/CaseTracker","forks_url":"https://api.github.com/repos/paddatrapper/CaseTracker/forks","keys_url":"https://api.github.com/repos/paddatrapper/CaseTracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paddatrapper/CaseTracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paddatrapper/CaseTracker/teams","hooks_url":"https://api.github.com/repos/paddatrapper/CaseTracker/hooks","issue_events_url":"https://api.github.com/repos/paddatrapper/CaseTracker/issues/events{/number}","events_url":"https://api.github.com/repos/paddatrapper/CaseTracker/events","assignees_url":"https://api.github.com/repos/paddatrapper/CaseTracker/assignees{/user}","branches_url":"https://api.github.com/repos/paddatrapper/CaseTracker/branches{/branch}","tags_url":"https://api.github.com/repos/paddatrapper/CaseTracker/tags","blobs_url":"https://api.github.com/repos/paddatrapper/CaseTracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paddatrapper/CaseTracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paddatrapper/CaseTracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/paddatrapper/CaseTracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paddatrapper/CaseTracker/statuses/{sha}","languages_url":"https://api.github.com/repos/paddatrapper/CaseTracker/languages","stargazers_url":"https://api.github.com/repos/paddatrapper/CaseTracker/stargazers","contributors_url":"https://api.github.com/repos/paddatrapper/CaseTracker/contributors","subscribers_url":"https://api.github.com/repos/paddatrapper/CaseTracker/subscribers","subscription_url":"https://api.github.com/repos/paddatrapper/CaseTracker/subscription","commits_url":"https://api.github.com/repos/paddatrapper/CaseTracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/paddatrapper/CaseTracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/paddatrapper/CaseTracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/paddatrapper/CaseTracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/paddatrapper/CaseTracker/contents/{+path}","compare_url":"https://api.github.com/repos/paddatrapper/CaseTracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paddatrapper/CaseTracker/merges","archive_url":"https://api.github.com/repos/paddatrapper/CaseTracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paddatrapper/CaseTracker/downloads","issues_url":"https://api.github.com/repos/paddatrapper/CaseTracker/issues{/number}","pulls_url":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls{/number}","milestones_url":"https://api.github.com/repos/paddatrapper/CaseTracker/milestones{/number}","notifications_url":"https://api.github.com/repos/paddatrapper/CaseTracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paddatrapper/CaseTracker/labels{/name}","releases_url":"https://api.github.com/repos/paddatrapper/CaseTracker/releases{/id}","created_at":"2014-12-29T20:20:37Z","updated_at":"2015-07-28T21:50:02Z","pushed_at":"2015-08-07T17:32:05Z","git_url":"git://github.com/paddatrapper/CaseTracker.git","ssh_url":"git@github.com:paddatrapper/CaseTracker.git","clone_url":"https://github.com/paddatrapper/CaseTracker.git","svn_url":"https://github.com/paddatrapper/CaseTracker","homepage":null,"size":1926,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/39"},"html":{"href":"https://github.com/paddatrapper/CaseTracker/pull/39"},"issue":{"href":"https://api.github.com/repos/paddatrapper/CaseTracker/issues/39"},"comments":{"href":"https://api.github.com/repos/paddatrapper/CaseTracker/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paddatrapper/CaseTracker/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/paddatrapper/CaseTracker/statuses/d89c51b6f63895362f119264a5eacc5a6de9c0c1"}}}}