{"action":"created","issue":{"url":"https://api.github.com/repos/dj-wasabi/puppet-zabbix/issues/38","labels_url":"https://api.github.com/repos/dj-wasabi/puppet-zabbix/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/dj-wasabi/puppet-zabbix/issues/38/comments","events_url":"https://api.github.com/repos/dj-wasabi/puppet-zabbix/issues/38/events","html_url":"https://github.com/dj-wasabi/puppet-zabbix/pull/38","id":53911762,"number":38,"title":"setting manage_repo to false breaks server install","user":{"login":"genebean","id":966789,"avatar_url":"https://avatars.githubusercontent.com/u/966789?v=3","gravatar_id":"","url":"https://api.github.com/users/genebean","html_url":"https://github.com/genebean","followers_url":"https://api.github.com/users/genebean/followers","following_url":"https://api.github.com/users/genebean/following{/other_user}","gists_url":"https://api.github.com/users/genebean/gists{/gist_id}","starred_url":"https://api.github.com/users/genebean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genebean/subscriptions","organizations_url":"https://api.github.com/users/genebean/orgs","repos_url":"https://api.github.com/users/genebean/repos","events_url":"https://api.github.com/users/genebean/events{/privacy}","received_events_url":"https://api.github.com/users/genebean/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-01-09T20:34:42Z","updated_at":"2015-01-12T20:05:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dj-wasabi/puppet-zabbix/pulls/38","html_url":"https://github.com/dj-wasabi/puppet-zabbix/pull/38","diff_url":"https://github.com/dj-wasabi/puppet-zabbix/pull/38.diff","patch_url":"https://github.com/dj-wasabi/puppet-zabbix/pull/38.patch"},"body":"You have this chunk of code in `zabbix::web`\r\n\r\n```puppet\r\n# Check if manage_repo is true.\r\n  if $manage_repo {\r\n    if ! defined(Class['zabbix::repo']) {\r\n      class { 'zabbix::repo':\r\n        zabbix_version => $zabbix_version,\r\n      }\r\n    }\r\n  } # END if $manage_repo\r\n```\r\nbut nothing that ensures it runs before the this chunk in the same file:\r\n\r\n```puppet\r\ndefault : {\r\n      package { \"zabbix-web-${db}\":\r\n        ensure  => $zabbix_package_state,\r\n        before  => [\r\n          File['/etc/zabbix/web/zabbix.conf.php'],\r\n          Package['zabbix-web']\r\n        ],\r\n        require => Class['zabbix::repo'],\r\n      }\r\n```\r\n\r\nThis causes the following error: `Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid relationship: Package[zabbix-web-mysql] { require => Class[Zabbix::Repo] }, because Class[Zabbix::Repo] doesn't seem to be in the catalog`\r\n\r\nI see how to fix this and will be submitting a pull request shortly but wanted to go ahead and list it as a bug in case anyone else is effected by this."},"comment":{"url":"https://api.github.com/repos/dj-wasabi/puppet-zabbix/issues/comments/69635880","html_url":"https://github.com/dj-wasabi/puppet-zabbix/pull/38#issuecomment-69635880","issue_url":"https://api.github.com/repos/dj-wasabi/puppet-zabbix/issues/38","id":69635880,"user":{"login":"dj-wasabi","id":1171720,"avatar_url":"https://avatars.githubusercontent.com/u/1171720?v=3","gravatar_id":"","url":"https://api.github.com/users/dj-wasabi","html_url":"https://github.com/dj-wasabi","followers_url":"https://api.github.com/users/dj-wasabi/followers","following_url":"https://api.github.com/users/dj-wasabi/following{/other_user}","gists_url":"https://api.github.com/users/dj-wasabi/gists{/gist_id}","starred_url":"https://api.github.com/users/dj-wasabi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dj-wasabi/subscriptions","organizations_url":"https://api.github.com/users/dj-wasabi/orgs","repos_url":"https://api.github.com/users/dj-wasabi/repos","events_url":"https://api.github.com/users/dj-wasabi/events{/privacy}","received_events_url":"https://api.github.com/users/dj-wasabi/received_events","type":"User","site_admin":false},"created_at":"2015-01-12T20:05:03Z","updated_at":"2015-01-12T20:05:03Z","body":"Hi Genebean,\r\n\r\nAt the moment, I'm running the 'rake spec' command locally on my Mac, as I'm developing on the mac. I'am however busy with my internal Jenkins instance to run the 'rake spec' automatically with every push I make. It takes some time though. I was testing with puppet 3.4.3 and ruby 2.0.0 and just upgraded to puppet 3.7.3 on my mac. (And I just noticed with the new puppet I have an error.. :-))\r\n\r\nKind regards,\r\nWerner"}}