{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/samuel/go-thrift/pulls/49","id":44616956,"html_url":"https://github.com/samuel/go-thrift/pull/49","diff_url":"https://github.com/samuel/go-thrift/pull/49.diff","patch_url":"https://github.com/samuel/go-thrift/pull/49.patch","issue_url":"https://api.github.com/repos/samuel/go-thrift/issues/49","number":49,"state":"closed","locked":false,"title":"Fix handling of constants with values that are other constant identifiers","user":{"login":"prashantv","id":140159,"avatar_url":"https://avatars.githubusercontent.com/u/140159?v=3","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"body":" - Also add a test to ensure constants are parsed correctly\r\n\r\nThis fixes handling of:\r\n```thrift\r\nconst string MY_CONST = \"1\"\r\nconst string SECOND_CONST = MY_CONST\r\nconst string THIRD_CONST = SECOND_CONST\r\n```\r\n\r\nThis was previously generating:\r\n```go\r\nconst MyConst = \"1\"\r\nconst SecondConst = MY_CONST\r\nconst ThirdConst = SECOND_CONST\r\n```\r\nWhich is incorrect since `MY_CONST` and `SECOND_CONST` do not exist.\r\n\r\nIt now correctly generates:\r\n```go\r\nconst MyConst = \"1\"\r\nconst SecondConst = MyConst\r\nconst ThirdConst = SecondConst\r\n```","created_at":"2015-09-10T00:37:01Z","updated_at":"2015-09-10T18:29:29Z","closed_at":"2015-09-10T18:29:29Z","merged_at":"2015-09-10T18:29:29Z","merge_commit_sha":"ce036707adf201fd1f198f248058c3ff00d8274d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/samuel/go-thrift/pulls/49/commits","review_comments_url":"https://api.github.com/repos/samuel/go-thrift/pulls/49/comments","review_comment_url":"https://api.github.com/repos/samuel/go-thrift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samuel/go-thrift/issues/49/comments","statuses_url":"https://api.github.com/repos/samuel/go-thrift/statuses/b16119e25bfb66aed1c729427fac55f69a1fbd61","head":{"label":"prashantv:constant","ref":"constant","sha":"b16119e25bfb66aed1c729427fac55f69a1fbd61","user":{"login":"prashantv","id":140159,"avatar_url":"https://avatars.githubusercontent.com/u/140159?v=3","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"repo":{"id":42211559,"name":"go-thrift","full_name":"prashantv/go-thrift","owner":{"login":"prashantv","id":140159,"avatar_url":"https://avatars.githubusercontent.com/u/140159?v=3","gravatar_id":"","url":"https://api.github.com/users/prashantv","html_url":"https://github.com/prashantv","followers_url":"https://api.github.com/users/prashantv/followers","following_url":"https://api.github.com/users/prashantv/following{/other_user}","gists_url":"https://api.github.com/users/prashantv/gists{/gist_id}","starred_url":"https://api.github.com/users/prashantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashantv/subscriptions","organizations_url":"https://api.github.com/users/prashantv/orgs","repos_url":"https://api.github.com/users/prashantv/repos","events_url":"https://api.github.com/users/prashantv/events{/privacy}","received_events_url":"https://api.github.com/users/prashantv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prashantv/go-thrift","description":"A native Thrift package for Go","fork":true,"url":"https://api.github.com/repos/prashantv/go-thrift","forks_url":"https://api.github.com/repos/prashantv/go-thrift/forks","keys_url":"https://api.github.com/repos/prashantv/go-thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prashantv/go-thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prashantv/go-thrift/teams","hooks_url":"https://api.github.com/repos/prashantv/go-thrift/hooks","issue_events_url":"https://api.github.com/repos/prashantv/go-thrift/issues/events{/number}","events_url":"https://api.github.com/repos/prashantv/go-thrift/events","assignees_url":"https://api.github.com/repos/prashantv/go-thrift/assignees{/user}","branches_url":"https://api.github.com/repos/prashantv/go-thrift/branches{/branch}","tags_url":"https://api.github.com/repos/prashantv/go-thrift/tags","blobs_url":"https://api.github.com/repos/prashantv/go-thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prashantv/go-thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prashantv/go-thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/prashantv/go-thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prashantv/go-thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/prashantv/go-thrift/languages","stargazers_url":"https://api.github.com/repos/prashantv/go-thrift/stargazers","contributors_url":"https://api.github.com/repos/prashantv/go-thrift/contributors","subscribers_url":"https://api.github.com/repos/prashantv/go-thrift/subscribers","subscription_url":"https://api.github.com/repos/prashantv/go-thrift/subscription","commits_url":"https://api.github.com/repos/prashantv/go-thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/prashantv/go-thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/prashantv/go-thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/prashantv/go-thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/prashantv/go-thrift/contents/{+path}","compare_url":"https://api.github.com/repos/prashantv/go-thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prashantv/go-thrift/merges","archive_url":"https://api.github.com/repos/prashantv/go-thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prashantv/go-thrift/downloads","issues_url":"https://api.github.com/repos/prashantv/go-thrift/issues{/number}","pulls_url":"https://api.github.com/repos/prashantv/go-thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/prashantv/go-thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/prashantv/go-thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prashantv/go-thrift/labels{/name}","releases_url":"https://api.github.com/repos/prashantv/go-thrift/releases{/id}","created_at":"2015-09-10T00:11:10Z","updated_at":"2015-09-10T00:11:10Z","pushed_at":"2015-09-10T01:37:02Z","git_url":"git://github.com/prashantv/go-thrift.git","ssh_url":"git@github.com:prashantv/go-thrift.git","clone_url":"https://github.com/prashantv/go-thrift.git","svn_url":"https://github.com/prashantv/go-thrift","homepage":"","size":867,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samuel:master","ref":"master","sha":"2a15779ed499513233c0277f498da92fdd4141c5","user":{"login":"samuel","id":8503,"avatar_url":"https://avatars.githubusercontent.com/u/8503?v=3","gravatar_id":"","url":"https://api.github.com/users/samuel","html_url":"https://github.com/samuel","followers_url":"https://api.github.com/users/samuel/followers","following_url":"https://api.github.com/users/samuel/following{/other_user}","gists_url":"https://api.github.com/users/samuel/gists{/gist_id}","starred_url":"https://api.github.com/users/samuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuel/subscriptions","organizations_url":"https://api.github.com/users/samuel/orgs","repos_url":"https://api.github.com/users/samuel/repos","events_url":"https://api.github.com/users/samuel/events{/privacy}","received_events_url":"https://api.github.com/users/samuel/received_events","type":"User","site_admin":false},"repo":{"id":4960833,"name":"go-thrift","full_name":"samuel/go-thrift","owner":{"login":"samuel","id":8503,"avatar_url":"https://avatars.githubusercontent.com/u/8503?v=3","gravatar_id":"","url":"https://api.github.com/users/samuel","html_url":"https://github.com/samuel","followers_url":"https://api.github.com/users/samuel/followers","following_url":"https://api.github.com/users/samuel/following{/other_user}","gists_url":"https://api.github.com/users/samuel/gists{/gist_id}","starred_url":"https://api.github.com/users/samuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuel/subscriptions","organizations_url":"https://api.github.com/users/samuel/orgs","repos_url":"https://api.github.com/users/samuel/repos","events_url":"https://api.github.com/users/samuel/events{/privacy}","received_events_url":"https://api.github.com/users/samuel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuel/go-thrift","description":"A native Thrift package for Go","fork":false,"url":"https://api.github.com/repos/samuel/go-thrift","forks_url":"https://api.github.com/repos/samuel/go-thrift/forks","keys_url":"https://api.github.com/repos/samuel/go-thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuel/go-thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuel/go-thrift/teams","hooks_url":"https://api.github.com/repos/samuel/go-thrift/hooks","issue_events_url":"https://api.github.com/repos/samuel/go-thrift/issues/events{/number}","events_url":"https://api.github.com/repos/samuel/go-thrift/events","assignees_url":"https://api.github.com/repos/samuel/go-thrift/assignees{/user}","branches_url":"https://api.github.com/repos/samuel/go-thrift/branches{/branch}","tags_url":"https://api.github.com/repos/samuel/go-thrift/tags","blobs_url":"https://api.github.com/repos/samuel/go-thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuel/go-thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuel/go-thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuel/go-thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuel/go-thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/samuel/go-thrift/languages","stargazers_url":"https://api.github.com/repos/samuel/go-thrift/stargazers","contributors_url":"https://api.github.com/repos/samuel/go-thrift/contributors","subscribers_url":"https://api.github.com/repos/samuel/go-thrift/subscribers","subscription_url":"https://api.github.com/repos/samuel/go-thrift/subscription","commits_url":"https://api.github.com/repos/samuel/go-thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuel/go-thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuel/go-thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuel/go-thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuel/go-thrift/contents/{+path}","compare_url":"https://api.github.com/repos/samuel/go-thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuel/go-thrift/merges","archive_url":"https://api.github.com/repos/samuel/go-thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuel/go-thrift/downloads","issues_url":"https://api.github.com/repos/samuel/go-thrift/issues{/number}","pulls_url":"https://api.github.com/repos/samuel/go-thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/samuel/go-thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/samuel/go-thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuel/go-thrift/labels{/name}","releases_url":"https://api.github.com/repos/samuel/go-thrift/releases{/id}","created_at":"2012-07-09T16:15:09Z","updated_at":"2015-08-31T10:42:18Z","pushed_at":"2015-09-10T18:29:29Z","git_url":"git://github.com/samuel/go-thrift.git","ssh_url":"git@github.com:samuel/go-thrift.git","clone_url":"https://github.com/samuel/go-thrift.git","svn_url":"https://github.com/samuel/go-thrift","homepage":"","size":867,"stargazers_count":137,"watchers_count":137,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":15,"forks":40,"open_issues":15,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samuel/go-thrift/pulls/49"},"html":{"href":"https://github.com/samuel/go-thrift/pull/49"},"issue":{"href":"https://api.github.com/repos/samuel/go-thrift/issues/49"},"comments":{"href":"https://api.github.com/repos/samuel/go-thrift/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/samuel/go-thrift/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/samuel/go-thrift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samuel/go-thrift/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/samuel/go-thrift/statuses/b16119e25bfb66aed1c729427fac55f69a1fbd61"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"samuel","id":8503,"avatar_url":"https://avatars.githubusercontent.com/u/8503?v=3","gravatar_id":"","url":"https://api.github.com/users/samuel","html_url":"https://github.com/samuel","followers_url":"https://api.github.com/users/samuel/followers","following_url":"https://api.github.com/users/samuel/following{/other_user}","gists_url":"https://api.github.com/users/samuel/gists{/gist_id}","starred_url":"https://api.github.com/users/samuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuel/subscriptions","organizations_url":"https://api.github.com/users/samuel/orgs","repos_url":"https://api.github.com/users/samuel/repos","events_url":"https://api.github.com/users/samuel/events{/privacy}","received_events_url":"https://api.github.com/users/samuel/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":33,"deletions":0,"changed_files":2}}