{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/95","labels_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/95/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/95/events","html_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/95","id":58099136,"number":95,"title":"(PUP-4006) Non-Git dependencies use VERSION file","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars.githubusercontent.com/u/394081?v=3","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-18T17:26:26Z","updated_at":"2015-02-18T21:11:23Z","closed_at":"2015-02-18T18:07:02Z","pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/95","html_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/95","diff_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/95.diff","patch_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/95.patch"},"body":" - Previously, for extracted zips, such as CFacter, the versions.txt\r\n   included a `git describe --long` for the directory.  This would\r\n   actually traverse to a parent directory until it found one, in this\r\n   case the puppet_for_the_win repository itself.  As a result, the\r\n   versions.txt would contain the version of the puppet_for_the_win\r\n   repo, instead of the actual dependency.\r\n\r\n   For CFacter, a VERSION file was added as part of:\r\n   https://github.com/puppetlabs/cfacter/commit/26654b3\r\n\r\n   When the current download directory has a .git folder, indicating a\r\n   Git repo, then use `git describe --long` as we always have.\r\n\r\n   Otherwise, read the contents of the `VERSION` file"},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/comments/74948676","html_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/95#issuecomment-74948676","issue_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/95","id":74948676,"user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"created_at":"2015-02-18T21:11:23Z","updated_at":"2015-02-18T21:11:23Z","body":"No worries. It looked like it wasn't going to break anything the way it was done."}}