{"action":"created","issue":{"url":"https://api.github.com/repos/Medium/dynamite/issues/70","labels_url":"https://api.github.com/repos/Medium/dynamite/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/Medium/dynamite/issues/70/comments","events_url":"https://api.github.com/repos/Medium/dynamite/issues/70/events","html_url":"https://github.com/Medium/dynamite/pull/70","id":98433562,"number":70,"title":"Add request statistics to Dynamite","user":{"login":"chaosgame","id":193119,"avatar_url":"https://avatars.githubusercontent.com/u/193119?v=3","gravatar_id":"","url":"https://api.github.com/users/chaosgame","html_url":"https://github.com/chaosgame","followers_url":"https://api.github.com/users/chaosgame/followers","following_url":"https://api.github.com/users/chaosgame/following{/other_user}","gists_url":"https://api.github.com/users/chaosgame/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosgame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosgame/subscriptions","organizations_url":"https://api.github.com/users/chaosgame/orgs","repos_url":"https://api.github.com/users/chaosgame/repos","events_url":"https://api.github.com/users/chaosgame/events{/privacy}","received_events_url":"https://api.github.com/users/chaosgame/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-31T17:20:14Z","updated_at":"2015-08-01T01:21:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Medium/dynamite/pulls/70","html_url":"https://github.com/Medium/dynamite/pull/70","diff_url":"https://github.com/Medium/dynamite/pull/70.diff","patch_url":"https://github.com/Medium/dynamite/pull/70.patch"},"body":"Hello @xiao, @dpup, \n\nPlease review the following commits I made in branch 'nathan-perf'.\n\n6fbf1527d2eda947d9ab58bb6439052fba394b92 (2015-07-31 10:03:39 -0700)\nAdd request statistics to Dynamite\n`httpDone` is the event emitted when we've recieved all data but AWS-SDK\nhasn't parsed it yet.  `complete` emitted aftere the parsing is done (or\nhas failed).  Buffer.byteLength is unfortunately O(n), and is about 13ms\nfor 6MB of data (which should be okay since requests that return 6MB of\ndata are expensive anyways -- the same request took ~140ms to parse).\n\nR=@xiao\nR=@dpup\n\nTest plan: 'not tested'"},"comment":{"url":"https://api.github.com/repos/Medium/dynamite/issues/comments/126845749","html_url":"https://github.com/Medium/dynamite/pull/70#issuecomment-126845749","issue_url":"https://api.github.com/repos/Medium/dynamite/issues/70","id":126845749,"user":{"login":"xiao","id":1677490,"avatar_url":"https://avatars.githubusercontent.com/u/1677490?v=3","gravatar_id":"","url":"https://api.github.com/users/xiao","html_url":"https://github.com/xiao","followers_url":"https://api.github.com/users/xiao/followers","following_url":"https://api.github.com/users/xiao/following{/other_user}","gists_url":"https://api.github.com/users/xiao/gists{/gist_id}","starred_url":"https://api.github.com/users/xiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiao/subscriptions","organizations_url":"https://api.github.com/users/xiao/orgs","repos_url":"https://api.github.com/users/xiao/repos","events_url":"https://api.github.com/users/xiao/events{/privacy}","received_events_url":"https://api.github.com/users/xiao/received_events","type":"User","site_admin":false},"created_at":"2015-08-01T01:21:02Z","updated_at":"2015-08-01T01:21:02Z","body":"To be clear, this requires a little more change, but I thin it's worth the effort. You need to modify [`Builder.request()`](https://github.com/Medium/dynamite/blob/master/lib/Builder.js#L124). Instead of use a node style resolver as the callback, you can implement a function to capture the information you need and pass it to a deferrer promise."}}