{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/ui-grid/issues/3689","labels_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/3689/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/3689/comments","events_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/3689/events","html_url":"https://github.com/angular-ui/ui-grid/issues/3689","id":84973786,"number":3689,"title":"[Grouping] aggregate columns with invalid values show \"undefined\" inside the row","user":{"login":"valepu","id":5619832,"avatar_url":"https://avatars.githubusercontent.com/u/5619832?v=3","gravatar_id":"","url":"https://api.github.com/users/valepu","html_url":"https://github.com/valepu","followers_url":"https://api.github.com/users/valepu/followers","following_url":"https://api.github.com/users/valepu/following{/other_user}","gists_url":"https://api.github.com/users/valepu/gists{/gist_id}","starred_url":"https://api.github.com/users/valepu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valepu/subscriptions","organizations_url":"https://api.github.com/users/valepu/orgs","repos_url":"https://api.github.com/users/valepu/repos","events_url":"https://api.github.com/users/valepu/events{/privacy}","received_events_url":"https://api.github.com/users/valepu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular-ui/ui-grid/labels/grid-grouping","name":"grid-grouping","color":"fad8c7"},{"url":"https://api.github.com/repos/angular-ui/ui-grid/labels/type:%20enhancement","name":"type: enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-06-04T08:05:41Z","updated_at":"2015-11-18T07:01:51Z","closed_at":"2015-11-18T07:01:51Z","body":"Hello,\r\nI have noticed that when you use an aggregation function on a column with invalid values (for example \"Average\" on a column which contains only non numeric fields. It works fine if only some fields are non numeric) then in the cell it will appear, in the case of average, \"avg: undefined\" (this also happens with other functions which only work on numeric values).\r\nI think it's more useful, UX wise, to show either an empty string or an \"Invalid\" label (for example \"No valid values found\" instead of \"avg: undefined\") or let us chose what to show when invalid fields are found, just like the recently implemented \"groupingNullLabel\" option.\r\n\r\nTo reproduce this issue:\r\nUse this plunker http://plnkr.co/edit/I4hNKy6odqLCbCbl75vI?p=preview\r\n1. open the menu for any column\r\n2. click on \"Group\"\r\n3. open the menu for a different colum than the one used for grouping\r\n4. click on \"Agg: Avg\"\r\nIn the fields of the column will appear the text \"avg: undefined\"\r\n\r\nThis happens for all the aggregation functions that expect numeric values (which means all of them except Count)"},"comment":{"url":"https://api.github.com/repos/angular-ui/ui-grid/issues/comments/157627263","html_url":"https://github.com/angular-ui/ui-grid/issues/3689#issuecomment-157627263","issue_url":"https://api.github.com/repos/angular-ui/ui-grid/issues/3689","id":157627263,"user":{"login":"PaulL1","id":5248789,"avatar_url":"https://avatars.githubusercontent.com/u/5248789?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulL1","html_url":"https://github.com/PaulL1","followers_url":"https://api.github.com/users/PaulL1/followers","following_url":"https://api.github.com/users/PaulL1/following{/other_user}","gists_url":"https://api.github.com/users/PaulL1/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulL1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulL1/subscriptions","organizations_url":"https://api.github.com/users/PaulL1/orgs","repos_url":"https://api.github.com/users/PaulL1/repos","events_url":"https://api.github.com/users/PaulL1/events{/privacy}","received_events_url":"https://api.github.com/users/PaulL1/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T07:01:51Z","updated_at":"2015-11-18T07:01:51Z","body":"This is a useful request, but not really in the current roadmap.  We have far too many good ideas in the repository already, giving the impression that we have a project riven with defects.\r\n\r\nAccordingly, I am leaving the enhancement tag on this, but closing it.  If someone would like this functionality, we'd welcome a pull request that adds it."}}