{"action":"created","comment":{"url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/comments/33384066","id":33384066,"diff_hunk":"@@ -1838,9 +1830,9 @@ def ensure_sequences_table() end\n \n       class ODBCColumn < Column #:nodoc:\n \n-        def initialize (name, tableName, default, odbcSqlType, nativeType,\n-            null = true, limit = nil, scale = nil, dbExt = nil,\n-            booleanColSurrogate = nil, nativeTypes = nil)\n+        def initialize(name, default, cast_type, odbcSqlType, nativeType, sql_type = nil, null = true,\n+          scale = nil, dbExt = nil, booleanColSurrogate = nil, nativeTypes = nil, limit=nil)","path":"lib/active_record/connection_adapters/odbc_adapter.rb","position":338,"original_position":338,"commit_id":"3359ce24bfb154cb7d0bfa106527588081a59390","original_commit_id":"3359ce24bfb154cb7d0bfa106527588081a59390","user":{"login":"macasek","id":17492,"avatar_url":"https://avatars.githubusercontent.com/u/17492?v=3","gravatar_id":"","url":"https://api.github.com/users/macasek","html_url":"https://github.com/macasek","followers_url":"https://api.github.com/users/macasek/followers","following_url":"https://api.github.com/users/macasek/following{/other_user}","gists_url":"https://api.github.com/users/macasek/gists{/gist_id}","starred_url":"https://api.github.com/users/macasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macasek/subscriptions","organizations_url":"https://api.github.com/users/macasek/orgs","repos_url":"https://api.github.com/users/macasek/repos","events_url":"https://api.github.com/users/macasek/events{/privacy}","received_events_url":"https://api.github.com/users/macasek/received_events","type":"User","site_admin":false},"body":"The rails version did not put it's defaults in a hash and i was trying not to stray too far from their sytyle","created_at":"2015-06-26T18:46:32Z","updated_at":"2015-06-26T18:46:32Z","html_url":"https://github.com/localytics/activerecord-odbc-adapter/pull/1#discussion_r33384066","pull_request_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/comments/33384066"},"html":{"href":"https://github.com/localytics/activerecord-odbc-adapter/pull/1#discussion_r33384066"},"pull_request":{"href":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/1","id":38672332,"html_url":"https://github.com/localytics/activerecord-odbc-adapter/pull/1","diff_url":"https://github.com/localytics/activerecord-odbc-adapter/pull/1.diff","patch_url":"https://github.com/localytics/activerecord-odbc-adapter/pull/1.patch","issue_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/issues/1","number":1,"state":"open","locked":false,"title":"Update for Rails 4","user":{"login":"macasek","id":17492,"avatar_url":"https://avatars.githubusercontent.com/u/17492?v=3","gravatar_id":"","url":"https://api.github.com/users/macasek","html_url":"https://github.com/macasek","followers_url":"https://api.github.com/users/macasek/followers","following_url":"https://api.github.com/users/macasek/following{/other_user}","gists_url":"https://api.github.com/users/macasek/gists{/gist_id}","starred_url":"https://api.github.com/users/macasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macasek/subscriptions","organizations_url":"https://api.github.com/users/macasek/orgs","repos_url":"https://api.github.com/users/macasek/repos","events_url":"https://api.github.com/users/macasek/events{/privacy}","received_events_url":"https://api.github.com/users/macasek/received_events","type":"User","site_admin":false},"body":"This update is based on the usage by the localytics-rails application. See the PR in that project for details.","created_at":"2015-06-26T17:43:36Z","updated_at":"2015-06-26T18:46:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e32817a9dc8720d7f4e010e84ecc113e37f6de6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/1/commits","review_comments_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/1/comments","review_comment_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/issues/1/comments","statuses_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/statuses/3359ce24bfb154cb7d0bfa106527588081a59390","head":{"label":"localytics:rails4","ref":"rails4","sha":"3359ce24bfb154cb7d0bfa106527588081a59390","user":{"login":"localytics","id":29205,"avatar_url":"https://avatars.githubusercontent.com/u/29205?v=3","gravatar_id":"","url":"https://api.github.com/users/localytics","html_url":"https://github.com/localytics","followers_url":"https://api.github.com/users/localytics/followers","following_url":"https://api.github.com/users/localytics/following{/other_user}","gists_url":"https://api.github.com/users/localytics/gists{/gist_id}","starred_url":"https://api.github.com/users/localytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/localytics/subscriptions","organizations_url":"https://api.github.com/users/localytics/orgs","repos_url":"https://api.github.com/users/localytics/repos","events_url":"https://api.github.com/users/localytics/events{/privacy}","received_events_url":"https://api.github.com/users/localytics/received_events","type":"Organization","site_admin":false},"repo":{"id":8032168,"name":"activerecord-odbc-adapter","full_name":"localytics/activerecord-odbc-adapter","owner":{"login":"localytics","id":29205,"avatar_url":"https://avatars.githubusercontent.com/u/29205?v=3","gravatar_id":"","url":"https://api.github.com/users/localytics","html_url":"https://github.com/localytics","followers_url":"https://api.github.com/users/localytics/followers","following_url":"https://api.github.com/users/localytics/following{/other_user}","gists_url":"https://api.github.com/users/localytics/gists{/gist_id}","starred_url":"https://api.github.com/users/localytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/localytics/subscriptions","organizations_url":"https://api.github.com/users/localytics/orgs","repos_url":"https://api.github.com/users/localytics/repos","events_url":"https://api.github.com/users/localytics/events{/privacy}","received_events_url":"https://api.github.com/users/localytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/localytics/activerecord-odbc-adapter","description":"Fork of dosire/activerecord-odbc-adapter, support for Vertica","fork":true,"url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter","forks_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/forks","keys_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/teams","hooks_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/hooks","issue_events_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/events","assignees_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/tags","blobs_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/languages","stargazers_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/stargazers","contributors_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/contributors","subscribers_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/subscribers","subscription_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/subscription","commits_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/merges","archive_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/downloads","issues_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/labels{/name}","releases_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/releases{/id}","created_at":"2013-02-05T15:50:04Z","updated_at":"2013-06-06T17:49:23Z","pushed_at":"2015-06-26T17:43:36Z","git_url":"git://github.com/localytics/activerecord-odbc-adapter.git","ssh_url":"git@github.com:localytics/activerecord-odbc-adapter.git","clone_url":"https://github.com/localytics/activerecord-odbc-adapter.git","svn_url":"https://github.com/localytics/activerecord-odbc-adapter","homepage":"","size":210,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"localytics:master","ref":"master","sha":"af779ffbade7449ed56eeb7d623caa616979a2ee","user":{"login":"localytics","id":29205,"avatar_url":"https://avatars.githubusercontent.com/u/29205?v=3","gravatar_id":"","url":"https://api.github.com/users/localytics","html_url":"https://github.com/localytics","followers_url":"https://api.github.com/users/localytics/followers","following_url":"https://api.github.com/users/localytics/following{/other_user}","gists_url":"https://api.github.com/users/localytics/gists{/gist_id}","starred_url":"https://api.github.com/users/localytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/localytics/subscriptions","organizations_url":"https://api.github.com/users/localytics/orgs","repos_url":"https://api.github.com/users/localytics/repos","events_url":"https://api.github.com/users/localytics/events{/privacy}","received_events_url":"https://api.github.com/users/localytics/received_events","type":"Organization","site_admin":false},"repo":{"id":8032168,"name":"activerecord-odbc-adapter","full_name":"localytics/activerecord-odbc-adapter","owner":{"login":"localytics","id":29205,"avatar_url":"https://avatars.githubusercontent.com/u/29205?v=3","gravatar_id":"","url":"https://api.github.com/users/localytics","html_url":"https://github.com/localytics","followers_url":"https://api.github.com/users/localytics/followers","following_url":"https://api.github.com/users/localytics/following{/other_user}","gists_url":"https://api.github.com/users/localytics/gists{/gist_id}","starred_url":"https://api.github.com/users/localytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/localytics/subscriptions","organizations_url":"https://api.github.com/users/localytics/orgs","repos_url":"https://api.github.com/users/localytics/repos","events_url":"https://api.github.com/users/localytics/events{/privacy}","received_events_url":"https://api.github.com/users/localytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/localytics/activerecord-odbc-adapter","description":"Fork of dosire/activerecord-odbc-adapter, support for Vertica","fork":true,"url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter","forks_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/forks","keys_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/teams","hooks_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/hooks","issue_events_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/events","assignees_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/tags","blobs_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/languages","stargazers_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/stargazers","contributors_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/contributors","subscribers_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/subscribers","subscription_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/subscription","commits_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/merges","archive_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/downloads","issues_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/labels{/name}","releases_url":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/releases{/id}","created_at":"2013-02-05T15:50:04Z","updated_at":"2013-06-06T17:49:23Z","pushed_at":"2015-06-26T17:43:36Z","git_url":"git://github.com/localytics/activerecord-odbc-adapter.git","ssh_url":"git@github.com:localytics/activerecord-odbc-adapter.git","clone_url":"https://github.com/localytics/activerecord-odbc-adapter.git","svn_url":"https://github.com/localytics/activerecord-odbc-adapter","homepage":"","size":210,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/1"},"html":{"href":"https://github.com/localytics/activerecord-odbc-adapter/pull/1"},"issue":{"href":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/issues/1"},"comments":{"href":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/localytics/activerecord-odbc-adapter/statuses/3359ce24bfb154cb7d0bfa106527588081a59390"}}}}