{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/javascript/pulls/comments/44835146","id":44835146,"diff_hunk":"@@ -8,12 +8,22 @@ module.exports = {\n   'rules': {\n     // Prevent missing displayName in a React component definition\n     'react/display-name': 0,\n+    // Forbid certain propTypes (any, array, object)\n+    'react/forbid-prop-types': 0,","path":"packages/eslint-config-airbnb/rules/react.js","position":5,"original_position":5,"commit_id":"670828de25d0f8c30dbd64300983fb12a2b4400d","original_commit_id":"670828de25d0f8c30dbd64300983fb12a2b4400d","user":{"login":"tikotzky","id":200528,"avatar_url":"https://avatars.githubusercontent.com/u/200528?v=3","gravatar_id":"","url":"https://api.github.com/users/tikotzky","html_url":"https://github.com/tikotzky","followers_url":"https://api.github.com/users/tikotzky/followers","following_url":"https://api.github.com/users/tikotzky/following{/other_user}","gists_url":"https://api.github.com/users/tikotzky/gists{/gist_id}","starred_url":"https://api.github.com/users/tikotzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikotzky/subscriptions","organizations_url":"https://api.github.com/users/tikotzky/orgs","repos_url":"https://api.github.com/users/tikotzky/repos","events_url":"https://api.github.com/users/tikotzky/events{/privacy}","received_events_url":"https://api.github.com/users/tikotzky/received_events","type":"User","site_admin":false},"body":"But what about rules that are disabled? What's the reason to include the default config there?\r\n\r\nIf someone is going to override they'll probably be looking at the docs anyway to see which config they would want to select when enabling. ","created_at":"2015-11-13T21:17:52Z","updated_at":"2015-11-13T21:17:52Z","html_url":"https://github.com/airbnb/javascript/pull/581#discussion_r44835146","pull_request_url":"https://api.github.com/repos/airbnb/javascript/pulls/581","_links":{"self":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/comments/44835146"},"html":{"href":"https://github.com/airbnb/javascript/pull/581#discussion_r44835146"},"pull_request":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/airbnb/javascript/pulls/581","id":50677655,"html_url":"https://github.com/airbnb/javascript/pull/581","diff_url":"https://github.com/airbnb/javascript/pull/581.diff","patch_url":"https://github.com/airbnb/javascript/pull/581.patch","issue_url":"https://api.github.com/repos/airbnb/javascript/issues/581","number":581,"state":"open","locked":false,"title":"add missing rules from eslint-plugin-react (enforcing where necessary )","user":{"login":"tikotzky","id":200528,"avatar_url":"https://avatars.githubusercontent.com/u/200528?v=3","gravatar_id":"","url":"https://api.github.com/users/tikotzky","html_url":"https://github.com/tikotzky","followers_url":"https://api.github.com/users/tikotzky/followers","following_url":"https://api.github.com/users/tikotzky/following{/other_user}","gists_url":"https://api.github.com/users/tikotzky/gists{/gist_id}","starred_url":"https://api.github.com/users/tikotzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikotzky/subscriptions","organizations_url":"https://api.github.com/users/tikotzky/orgs","repos_url":"https://api.github.com/users/tikotzky/repos","events_url":"https://api.github.com/users/tikotzky/events{/privacy}","received_events_url":"https://api.github.com/users/tikotzky/received_events","type":"User","site_admin":false},"body":"Adds all missing rules from `eslint-plugin-react`.\r\n\r\nEnforces [`react/jsx-closing-bracket-location`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-closing-bracket-location.md) and [`react/jsx-indent-props`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-indent-props.md) to match react style guide.","created_at":"2015-11-13T18:57:45Z","updated_at":"2015-11-13T21:17:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4721da7d1222d344b5fd3186e8b6288c55ef571","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/javascript/pulls/581/commits","review_comments_url":"https://api.github.com/repos/airbnb/javascript/pulls/581/comments","review_comment_url":"https://api.github.com/repos/airbnb/javascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/javascript/issues/581/comments","statuses_url":"https://api.github.com/repos/airbnb/javascript/statuses/670828de25d0f8c30dbd64300983fb12a2b4400d","head":{"label":"tikotzky:update-eslint-react","ref":"update-eslint-react","sha":"670828de25d0f8c30dbd64300983fb12a2b4400d","user":{"login":"tikotzky","id":200528,"avatar_url":"https://avatars.githubusercontent.com/u/200528?v=3","gravatar_id":"","url":"https://api.github.com/users/tikotzky","html_url":"https://github.com/tikotzky","followers_url":"https://api.github.com/users/tikotzky/followers","following_url":"https://api.github.com/users/tikotzky/following{/other_user}","gists_url":"https://api.github.com/users/tikotzky/gists{/gist_id}","starred_url":"https://api.github.com/users/tikotzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikotzky/subscriptions","organizations_url":"https://api.github.com/users/tikotzky/orgs","repos_url":"https://api.github.com/users/tikotzky/repos","events_url":"https://api.github.com/users/tikotzky/events{/privacy}","received_events_url":"https://api.github.com/users/tikotzky/received_events","type":"User","site_admin":false},"repo":{"id":46138727,"name":"javascript","full_name":"tikotzky/javascript","owner":{"login":"tikotzky","id":200528,"avatar_url":"https://avatars.githubusercontent.com/u/200528?v=3","gravatar_id":"","url":"https://api.github.com/users/tikotzky","html_url":"https://github.com/tikotzky","followers_url":"https://api.github.com/users/tikotzky/followers","following_url":"https://api.github.com/users/tikotzky/following{/other_user}","gists_url":"https://api.github.com/users/tikotzky/gists{/gist_id}","starred_url":"https://api.github.com/users/tikotzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikotzky/subscriptions","organizations_url":"https://api.github.com/users/tikotzky/orgs","repos_url":"https://api.github.com/users/tikotzky/repos","events_url":"https://api.github.com/users/tikotzky/events{/privacy}","received_events_url":"https://api.github.com/users/tikotzky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tikotzky/javascript","description":"JavaScript Style Guide","fork":true,"url":"https://api.github.com/repos/tikotzky/javascript","forks_url":"https://api.github.com/repos/tikotzky/javascript/forks","keys_url":"https://api.github.com/repos/tikotzky/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tikotzky/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tikotzky/javascript/teams","hooks_url":"https://api.github.com/repos/tikotzky/javascript/hooks","issue_events_url":"https://api.github.com/repos/tikotzky/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/tikotzky/javascript/events","assignees_url":"https://api.github.com/repos/tikotzky/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/tikotzky/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/tikotzky/javascript/tags","blobs_url":"https://api.github.com/repos/tikotzky/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tikotzky/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tikotzky/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/tikotzky/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tikotzky/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/tikotzky/javascript/languages","stargazers_url":"https://api.github.com/repos/tikotzky/javascript/stargazers","contributors_url":"https://api.github.com/repos/tikotzky/javascript/contributors","subscribers_url":"https://api.github.com/repos/tikotzky/javascript/subscribers","subscription_url":"https://api.github.com/repos/tikotzky/javascript/subscription","commits_url":"https://api.github.com/repos/tikotzky/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/tikotzky/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/tikotzky/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/tikotzky/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/tikotzky/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/tikotzky/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tikotzky/javascript/merges","archive_url":"https://api.github.com/repos/tikotzky/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tikotzky/javascript/downloads","issues_url":"https://api.github.com/repos/tikotzky/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/tikotzky/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/tikotzky/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/tikotzky/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tikotzky/javascript/labels{/name}","releases_url":"https://api.github.com/repos/tikotzky/javascript/releases{/id}","created_at":"2015-11-13T18:06:07Z","updated_at":"2015-11-13T18:06:08Z","pushed_at":"2015-11-13T18:52:29Z","git_url":"git://github.com/tikotzky/javascript.git","ssh_url":"git@github.com:tikotzky/javascript.git","clone_url":"https://github.com/tikotzky/javascript.git","svn_url":"https://github.com/tikotzky/javascript","homepage":null,"size":4304,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"60480c05ea6c2d0f172302f845c39f5f62accb8d","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":6498492,"name":"javascript","full_name":"airbnb/javascript","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/javascript","description":"JavaScript Style Guide","fork":false,"url":"https://api.github.com/repos/airbnb/javascript","forks_url":"https://api.github.com/repos/airbnb/javascript/forks","keys_url":"https://api.github.com/repos/airbnb/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/javascript/teams","hooks_url":"https://api.github.com/repos/airbnb/javascript/hooks","issue_events_url":"https://api.github.com/repos/airbnb/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/javascript/events","assignees_url":"https://api.github.com/repos/airbnb/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/javascript/tags","blobs_url":"https://api.github.com/repos/airbnb/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/javascript/languages","stargazers_url":"https://api.github.com/repos/airbnb/javascript/stargazers","contributors_url":"https://api.github.com/repos/airbnb/javascript/contributors","subscribers_url":"https://api.github.com/repos/airbnb/javascript/subscribers","subscription_url":"https://api.github.com/repos/airbnb/javascript/subscription","commits_url":"https://api.github.com/repos/airbnb/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/javascript/merges","archive_url":"https://api.github.com/repos/airbnb/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/javascript/downloads","issues_url":"https://api.github.com/repos/airbnb/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/javascript/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/javascript/releases{/id}","created_at":"2012-11-01T23:13:50Z","updated_at":"2015-11-13T21:00:26Z","pushed_at":"2015-11-13T18:57:45Z","git_url":"git://github.com/airbnb/javascript.git","ssh_url":"git@github.com:airbnb/javascript.git","clone_url":"https://github.com/airbnb/javascript.git","svn_url":"https://github.com/airbnb/javascript","homepage":null,"size":4304,"stargazers_count":26345,"watchers_count":26345,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4879,"mirror_url":null,"open_issues_count":71,"forks":4879,"open_issues":71,"watchers":26345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/581"},"html":{"href":"https://github.com/airbnb/javascript/pull/581"},"issue":{"href":"https://api.github.com/repos/airbnb/javascript/issues/581"},"comments":{"href":"https://api.github.com/repos/airbnb/javascript/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/javascript/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/javascript/statuses/670828de25d0f8c30dbd64300983fb12a2b4400d"}}}}