{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/bitters/pulls/comments/23855524","id":23855524,"diff_hunk":"@@ -16,20 +16,54 @@ $small-spacing: $base-spacing / 2;\n $base-z-index: 0;\n \n // Colors\n-$blue: #477dca;\n-$dark-gray: #333;\n-$medium-gray: #999;\n-$light-gray: #ddd;\n-\n-// Font Colors\n-$base-background-color: #fff;\n-$base-font-color: $dark-gray;\n-$action-color: $blue;\n-\n-// Border\n-$base-border-color: $light-gray;\n+$dark-color: #333;\n+$light-color: #fff;\n+\n+// Background\n+$base-background: #fff;\n+$base-background-inset: darken($base-background, 4%);\n+$base-background-inset-shadow: inset 0 0 2px darken($base-background, 20%);\n+$base-font-color-on-background: $dark-color;\n+\n+// Outline on background\n+$base-outline-color: darken($base-background, 15%);\n+$base-outline: 1px solid $base-outline-color;\n+\n+// Box\n+$base-box-background: darken($base-background, 3%);\n+$base-border-color: darken($base-box-background, 15%);\n $base-border: 1px solid $base-border-color;\n+$base-box-background-inset: darken($base-box-background, 5%);\n+$base-font-color-on-box: #000;\n+$base-box-shadow: 0 1px 2px transparentize($base-font-color-on-box, 0.8);\n+$base-box-shadow-inset: inset 0 2px 2px darken($base-box-background, 10%);\n+\n+// Notification Colors","path":"app/assets/stylesheets/_variables.scss","position":47,"original_position":47,"commit_id":"b1206b2ba09d5f6212cf9f423b29b294fa557665","original_commit_id":"b1206b2ba09d5f6212cf9f423b29b294fa557665","user":{"login":"tysongach","id":903327,"avatar_url":"https://avatars.githubusercontent.com/u/903327?v=3","gravatar_id":"","url":"https://api.github.com/users/tysongach","html_url":"https://github.com/tysongach","followers_url":"https://api.github.com/users/tysongach/followers","following_url":"https://api.github.com/users/tysongach/following{/other_user}","gists_url":"https://api.github.com/users/tysongach/gists{/gist_id}","starred_url":"https://api.github.com/users/tysongach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysongach/subscriptions","organizations_url":"https://api.github.com/users/tysongach/orgs","repos_url":"https://api.github.com/users/tysongach/repos","events_url":"https://api.github.com/users/tysongach/events{/privacy}","received_events_url":"https://api.github.com/users/tysongach/received_events","type":"User","site_admin":false},"body":"These were recently removed from Bitters, because the flash mixin is no longer here either. I don’t Bitters should be cluttered with styles that are only in Refills. It adds unnecessary code if I choose to only use Bitters and not alongside Refills.","created_at":"2015-01-30T17:05:31Z","updated_at":"2015-01-30T17:05:31Z","html_url":"https://github.com/thoughtbot/bitters/pull/149#discussion_r23855524","pull_request_url":"https://api.github.com/repos/thoughtbot/bitters/pulls/149","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/comments/23855524"},"html":{"href":"https://github.com/thoughtbot/bitters/pull/149#discussion_r23855524"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/bitters/pulls/149","id":28362016,"html_url":"https://github.com/thoughtbot/bitters/pull/149","diff_url":"https://github.com/thoughtbot/bitters/pull/149.diff","patch_url":"https://github.com/thoughtbot/bitters/pull/149.patch","issue_url":"https://api.github.com/repos/thoughtbot/bitters/issues/149","number":149,"state":"open","locked":false,"title":"Add variables that set the theme for Refills","user":{"login":"Magnus-G","id":2095625,"avatar_url":"https://avatars.githubusercontent.com/u/2095625?v=3","gravatar_id":"","url":"https://api.github.com/users/Magnus-G","html_url":"https://github.com/Magnus-G","followers_url":"https://api.github.com/users/Magnus-G/followers","following_url":"https://api.github.com/users/Magnus-G/following{/other_user}","gists_url":"https://api.github.com/users/Magnus-G/gists{/gist_id}","starred_url":"https://api.github.com/users/Magnus-G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magnus-G/subscriptions","organizations_url":"https://api.github.com/users/Magnus-G/orgs","repos_url":"https://api.github.com/users/Magnus-G/repos","events_url":"https://api.github.com/users/Magnus-G/events{/privacy}","received_events_url":"https://api.github.com/users/Magnus-G/received_events","type":"User","site_admin":false},"body":"For Refills we are planning on adding a global variable stylesheet to enable the creation of themes. \r\nThe idea is to make all Refills components and patterns depend on the same style rules, so if you change something in the variable file all Refills will be affected.\r\nThis PR adds those variables.\r\n\r\nIf we would find a set of variable names that could apply for both Bitters and Refills I think we would find a nice interface between the two.\r\nRefills would still be independent, but if you add Bitters you get better base styles for things you might add.\r\n\r\nSince Refills only adds a variable stylesheet, the `body` styles are placed in the variables file. \r\nI have a feeling there will be a debate around that but I don't see a better solution right now.\r\n\r\nThe basic idea is to provide rules for:\r\n- The background: Color for background, color for font on background, inset on a background, etc.\r\n- A box (or a container element): Color for box background etc.\r\n- Generic colors\r\n\r\n","created_at":"2015-01-30T13:48:28Z","updated_at":"2015-01-30T17:05:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99f16ee3df2299a4831d5e6c65ac1f3c1adda054","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/bitters/pulls/149/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/bitters/pulls/149/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/bitters/pulls/comments/{number}","comments_url":"https://api.github.com/repos/thoughtbot/bitters/issues/149/comments","statuses_url":"https://api.github.com/repos/thoughtbot/bitters/statuses/b1206b2ba09d5f6212cf9f423b29b294fa557665","head":{"label":"thoughtbot:mg-variables-for-theming-refills","ref":"mg-variables-for-theming-refills","sha":"b1206b2ba09d5f6212cf9f423b29b294fa557665","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":8143643,"name":"bitters","full_name":"thoughtbot/bitters","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/bitters","description":"Add a dash of pre-defined style to your Bourbon.","fork":false,"url":"https://api.github.com/repos/thoughtbot/bitters","forks_url":"https://api.github.com/repos/thoughtbot/bitters/forks","keys_url":"https://api.github.com/repos/thoughtbot/bitters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/bitters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/bitters/teams","hooks_url":"https://api.github.com/repos/thoughtbot/bitters/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/bitters/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/bitters/events","assignees_url":"https://api.github.com/repos/thoughtbot/bitters/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/bitters/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/bitters/tags","blobs_url":"https://api.github.com/repos/thoughtbot/bitters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/bitters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/bitters/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/bitters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/bitters/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/bitters/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/bitters/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/bitters/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/bitters/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/bitters/subscription","commits_url":"https://api.github.com/repos/thoughtbot/bitters/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/bitters/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/bitters/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/bitters/issues/comments/{number}","contents_url":"https://api.github.com/repos/thoughtbot/bitters/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/bitters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/bitters/merges","archive_url":"https://api.github.com/repos/thoughtbot/bitters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/bitters/downloads","issues_url":"https://api.github.com/repos/thoughtbot/bitters/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/bitters/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/bitters/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/bitters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/bitters/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/bitters/releases{/id}","created_at":"2013-02-11T18:24:43Z","updated_at":"2015-01-30T15:27:08Z","pushed_at":"2015-01-30T13:27:56Z","git_url":"git://github.com/thoughtbot/bitters.git","ssh_url":"git@github.com:thoughtbot/bitters.git","clone_url":"https://github.com/thoughtbot/bitters.git","svn_url":"https://github.com/thoughtbot/bitters","homepage":"http://bitters.bourbon.io","size":7032,"stargazers_count":825,"watchers_count":825,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":96,"mirror_url":null,"open_issues_count":9,"forks":96,"open_issues":9,"watchers":825,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"5de1e252df10a98fbe083b1a67eefe163e597dbf","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":8143643,"name":"bitters","full_name":"thoughtbot/bitters","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/bitters","description":"Add a dash of pre-defined style to your Bourbon.","fork":false,"url":"https://api.github.com/repos/thoughtbot/bitters","forks_url":"https://api.github.com/repos/thoughtbot/bitters/forks","keys_url":"https://api.github.com/repos/thoughtbot/bitters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/bitters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/bitters/teams","hooks_url":"https://api.github.com/repos/thoughtbot/bitters/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/bitters/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/bitters/events","assignees_url":"https://api.github.com/repos/thoughtbot/bitters/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/bitters/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/bitters/tags","blobs_url":"https://api.github.com/repos/thoughtbot/bitters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/bitters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/bitters/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/bitters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/bitters/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/bitters/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/bitters/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/bitters/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/bitters/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/bitters/subscription","commits_url":"https://api.github.com/repos/thoughtbot/bitters/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/bitters/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/bitters/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/bitters/issues/comments/{number}","contents_url":"https://api.github.com/repos/thoughtbot/bitters/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/bitters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/bitters/merges","archive_url":"https://api.github.com/repos/thoughtbot/bitters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/bitters/downloads","issues_url":"https://api.github.com/repos/thoughtbot/bitters/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/bitters/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/bitters/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/bitters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/bitters/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/bitters/releases{/id}","created_at":"2013-02-11T18:24:43Z","updated_at":"2015-01-30T15:27:08Z","pushed_at":"2015-01-30T13:27:56Z","git_url":"git://github.com/thoughtbot/bitters.git","ssh_url":"git@github.com:thoughtbot/bitters.git","clone_url":"https://github.com/thoughtbot/bitters.git","svn_url":"https://github.com/thoughtbot/bitters","homepage":"http://bitters.bourbon.io","size":7032,"stargazers_count":825,"watchers_count":825,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":96,"mirror_url":null,"open_issues_count":9,"forks":96,"open_issues":9,"watchers":825,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/149"},"html":{"href":"https://github.com/thoughtbot/bitters/pull/149"},"issue":{"href":"https://api.github.com/repos/thoughtbot/bitters/issues/149"},"comments":{"href":"https://api.github.com/repos/thoughtbot/bitters/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/bitters/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/bitters/statuses/b1206b2ba09d5f6212cf9f423b29b294fa557665"}}}}