{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/46776397","id":46776397,"diff_hunk":"@@ -332,18 +332,41 @@ int64_t\n encode_string(uint8_t *buf_start, const uint8_t *buf_end, const char *value, size_t value_len)\n {\n   uint8_t *p = buf_start;\n+  bool use_huffman = true;","path":"proxy/http2/HPACK.cc","position":4,"original_position":4,"commit_id":"cca6709a4875874668291f35fdb4d1e24374ee88","original_commit_id":"cca6709a4875874668291f35fdb4d1e24374ee88","user":{"login":"bryancall","id":216749,"avatar_url":"https://avatars.githubusercontent.com/u/216749?v=3","gravatar_id":"","url":"https://api.github.com/users/bryancall","html_url":"https://github.com/bryancall","followers_url":"https://api.github.com/users/bryancall/followers","following_url":"https://api.github.com/users/bryancall/following{/other_user}","gists_url":"https://api.github.com/users/bryancall/gists{/gist_id}","starred_url":"https://api.github.com/users/bryancall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryancall/subscriptions","organizations_url":"https://api.github.com/users/bryancall/orgs","repos_url":"https://api.github.com/users/bryancall/repos","events_url":"https://api.github.com/users/bryancall/events{/privacy}","received_events_url":"https://api.github.com/users/bryancall/received_events","type":"User","site_admin":false},"body":"Why have a flat to use huffman if you are not going to change it to false?","created_at":"2015-12-06T21:31:52Z","updated_at":"2015-12-06T21:31:52Z","html_url":"https://github.com/apache/trafficserver/pull/362#discussion_r46776397","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/362","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/46776397"},"html":{"href":"https://github.com/apache/trafficserver/pull/362#discussion_r46776397"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/362"}}},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/362","id":52616415,"html_url":"https://github.com/apache/trafficserver/pull/362","diff_url":"https://github.com/apache/trafficserver/pull/362.diff","patch_url":"https://github.com/apache/trafficserver/pull/362.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/362","number":362,"state":"open","locked":false,"title":"TS-4018: Use HPACK huffman encoding always","user":{"login":"maskit","id":153144,"avatar_url":"https://avatars.githubusercontent.com/u/153144?v=3","gravatar_id":"","url":"https://api.github.com/users/maskit","html_url":"https://github.com/maskit","followers_url":"https://api.github.com/users/maskit/followers","following_url":"https://api.github.com/users/maskit/following{/other_user}","gists_url":"https://api.github.com/users/maskit/gists{/gist_id}","starred_url":"https://api.github.com/users/maskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maskit/subscriptions","organizations_url":"https://api.github.com/users/maskit/orgs","repos_url":"https://api.github.com/users/maskit/repos","events_url":"https://api.github.com/users/maskit/events{/privacy}","received_events_url":"https://api.github.com/users/maskit/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/TS-4018","created_at":"2015-12-04T00:56:31Z","updated_at":"2015-12-06T21:31:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"995fe6bea0d28da7c6cc85603ed7da0bc3873972","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/362/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/362/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/362/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/cca6709a4875874668291f35fdb4d1e24374ee88","head":{"label":"maskit:ts4018","ref":"ts4018","sha":"cca6709a4875874668291f35fdb4d1e24374ee88","user":{"login":"maskit","id":153144,"avatar_url":"https://avatars.githubusercontent.com/u/153144?v=3","gravatar_id":"","url":"https://api.github.com/users/maskit","html_url":"https://github.com/maskit","followers_url":"https://api.github.com/users/maskit/followers","following_url":"https://api.github.com/users/maskit/following{/other_user}","gists_url":"https://api.github.com/users/maskit/gists{/gist_id}","starred_url":"https://api.github.com/users/maskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maskit/subscriptions","organizations_url":"https://api.github.com/users/maskit/orgs","repos_url":"https://api.github.com/users/maskit/repos","events_url":"https://api.github.com/users/maskit/events{/privacy}","received_events_url":"https://api.github.com/users/maskit/received_events","type":"User","site_admin":false},"repo":{"id":14463179,"name":"trafficserver","full_name":"maskit/trafficserver","owner":{"login":"maskit","id":153144,"avatar_url":"https://avatars.githubusercontent.com/u/153144?v=3","gravatar_id":"","url":"https://api.github.com/users/maskit","html_url":"https://github.com/maskit","followers_url":"https://api.github.com/users/maskit/followers","following_url":"https://api.github.com/users/maskit/following{/other_user}","gists_url":"https://api.github.com/users/maskit/gists{/gist_id}","starred_url":"https://api.github.com/users/maskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maskit/subscriptions","organizations_url":"https://api.github.com/users/maskit/orgs","repos_url":"https://api.github.com/users/maskit/repos","events_url":"https://api.github.com/users/maskit/events{/privacy}","received_events_url":"https://api.github.com/users/maskit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maskit/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/maskit/trafficserver","forks_url":"https://api.github.com/repos/maskit/trafficserver/forks","keys_url":"https://api.github.com/repos/maskit/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maskit/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maskit/trafficserver/teams","hooks_url":"https://api.github.com/repos/maskit/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/maskit/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/maskit/trafficserver/events","assignees_url":"https://api.github.com/repos/maskit/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/maskit/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/maskit/trafficserver/tags","blobs_url":"https://api.github.com/repos/maskit/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maskit/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maskit/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/maskit/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maskit/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/maskit/trafficserver/languages","stargazers_url":"https://api.github.com/repos/maskit/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/maskit/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/maskit/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/maskit/trafficserver/subscription","commits_url":"https://api.github.com/repos/maskit/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/maskit/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/maskit/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/maskit/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/maskit/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/maskit/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maskit/trafficserver/merges","archive_url":"https://api.github.com/repos/maskit/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maskit/trafficserver/downloads","issues_url":"https://api.github.com/repos/maskit/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/maskit/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/maskit/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/maskit/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maskit/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/maskit/trafficserver/releases{/id}","created_at":"2013-11-17T07:45:47Z","updated_at":"2015-03-20T13:45:21Z","pushed_at":"2015-12-04T00:55:19Z","git_url":"git://github.com/maskit/trafficserver.git","ssh_url":"git@github.com:maskit/trafficserver.git","clone_url":"https://github.com/maskit/trafficserver.git","svn_url":"https://github.com/maskit/trafficserver","homepage":null,"size":50728,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"74ecfefb0cb09ff1b2b279573672a3788ed7aa8b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","created_at":"2009-10-31T08:00:10Z","updated_at":"2015-12-04T16:55:18Z","pushed_at":"2015-12-06T18:47:00Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":54039,"stargazers_count":344,"watchers_count":344,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":254,"mirror_url":"git://git.apache.org/trafficserver.git","open_issues_count":31,"forks":254,"open_issues":31,"watchers":344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/362"},"html":{"href":"https://github.com/apache/trafficserver/pull/362"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/362"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/cca6709a4875874668291f35fdb4d1e24374ee88"}}}}