{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/29330566","id":29330566,"diff_hunk":"@@ -144,16 +144,9 @@ endif()\n \n install(DIRECTORY \"${CMAKE_CURRENT_SOURCE_DIR}/builtin\" DESTINATION \"${SHAREDIR}\")\n install(DIRECTORY \"${CMAKE_CURRENT_SOURCE_DIR}/client\" DESTINATION \"${SHAREDIR}\")\n-install(DIRECTORY \"${CMAKE_CURRENT_SOURCE_DIR}/games/minimal\" DESTINATION \"${SHAREDIR}/games\")\n-set(MINETEST_GAME_SOURCE \"${CMAKE_CURRENT_SOURCE_DIR}/games/minetest_game\")\n-if(EXISTS ${MINETEST_GAME_SOURCE} AND IS_DIRECTORY ${MINETEST_GAME_SOURCE})\n-\tinstall(FILES ${MINETEST_GAME_SOURCE}/game.conf DESTINATION \"${SHAREDIR}/games/minetest_game/\")\n-\tinstall(FILES ${MINETEST_GAME_SOURCE}/README.txt DESTINATION \"${SHAREDIR}/games/minetest_game/\")\n-\tinstall(DIRECTORY ${MINETEST_GAME_SOURCE}/mods DESTINATION \"${SHAREDIR}/games/minetest_game\")\n-\tinstall(DIRECTORY ${MINETEST_GAME_SOURCE}/menu DESTINATION \"${SHAREDIR}/games/minetest_game\")\n-endif()","path":"CMakeLists.txt","position":11,"original_position":11,"commit_id":"40e509aa7057a1f6054434d099ed965f239a0b75","original_commit_id":"40e509aa7057a1f6054434d099ed965f239a0b75","user":{"login":"neoascetic","id":725836,"avatar_url":"https://avatars.githubusercontent.com/u/725836?v=3","gravatar_id":"","url":"https://api.github.com/users/neoascetic","html_url":"https://github.com/neoascetic","followers_url":"https://api.github.com/users/neoascetic/followers","following_url":"https://api.github.com/users/neoascetic/following{/other_user}","gists_url":"https://api.github.com/users/neoascetic/gists{/gist_id}","starred_url":"https://api.github.com/users/neoascetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neoascetic/subscriptions","organizations_url":"https://api.github.com/users/neoascetic/orgs","repos_url":"https://api.github.com/users/neoascetic/repos","events_url":"https://api.github.com/users/neoascetic/events{/privacy}","received_events_url":"https://api.github.com/users/neoascetic/received_events","type":"User","site_admin":false},"body":"Sorry, didn't get it. Would `MINETEST_GAME_SOURCE` be overridden by the line 148 anyway, wouldn't it?","created_at":"2015-04-29T12:28:33Z","updated_at":"2015-04-29T12:28:33Z","html_url":"https://github.com/minetest/minetest/pull/2485#discussion_r29330566","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/2485","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/29330566"},"html":{"href":"https://github.com/minetest/minetest/pull/2485#discussion_r29330566"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2485"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/2485","id":31117117,"html_url":"https://github.com/minetest/minetest/pull/2485","diff_url":"https://github.com/minetest/minetest/pull/2485.diff","patch_url":"https://github.com/minetest/minetest/pull/2485.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/2485","number":2485,"state":"open","locked":false,"title":"Simplify custom games packaging","user":{"login":"neoascetic","id":725836,"avatar_url":"https://avatars.githubusercontent.com/u/725836?v=3","gravatar_id":"","url":"https://api.github.com/users/neoascetic","html_url":"https://github.com/neoascetic","followers_url":"https://api.github.com/users/neoascetic/followers","following_url":"https://api.github.com/users/neoascetic/following{/other_user}","gists_url":"https://api.github.com/users/neoascetic/gists{/gist_id}","starred_url":"https://api.github.com/users/neoascetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neoascetic/subscriptions","organizations_url":"https://api.github.com/users/neoascetic/orgs","repos_url":"https://api.github.com/users/neoascetic/repos","events_url":"https://api.github.com/users/neoascetic/events{/privacy}","received_events_url":"https://api.github.com/users/neoascetic/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-13T11:10:27Z","updated_at":"2015-04-29T12:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"979d1ff7be439518cdb385b6c137b31330ca6256","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/2485/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/2485/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/2485/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/40e509aa7057a1f6054434d099ed965f239a0b75","head":{"label":"neoascetic:simplify-custom-games-packaging","ref":"simplify-custom-games-packaging","sha":"40e509aa7057a1f6054434d099ed965f239a0b75","user":{"login":"neoascetic","id":725836,"avatar_url":"https://avatars.githubusercontent.com/u/725836?v=3","gravatar_id":"","url":"https://api.github.com/users/neoascetic","html_url":"https://github.com/neoascetic","followers_url":"https://api.github.com/users/neoascetic/followers","following_url":"https://api.github.com/users/neoascetic/following{/other_user}","gists_url":"https://api.github.com/users/neoascetic/gists{/gist_id}","starred_url":"https://api.github.com/users/neoascetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neoascetic/subscriptions","organizations_url":"https://api.github.com/users/neoascetic/orgs","repos_url":"https://api.github.com/users/neoascetic/repos","events_url":"https://api.github.com/users/neoascetic/events{/privacy}","received_events_url":"https://api.github.com/users/neoascetic/received_events","type":"User","site_admin":false},"repo":{"id":25653072,"name":"minetest","full_name":"neoascetic/minetest","owner":{"login":"neoascetic","id":725836,"avatar_url":"https://avatars.githubusercontent.com/u/725836?v=3","gravatar_id":"","url":"https://api.github.com/users/neoascetic","html_url":"https://github.com/neoascetic","followers_url":"https://api.github.com/users/neoascetic/followers","following_url":"https://api.github.com/users/neoascetic/following{/other_user}","gists_url":"https://api.github.com/users/neoascetic/gists{/gist_id}","starred_url":"https://api.github.com/users/neoascetic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neoascetic/subscriptions","organizations_url":"https://api.github.com/users/neoascetic/orgs","repos_url":"https://api.github.com/users/neoascetic/repos","events_url":"https://api.github.com/users/neoascetic/events{/privacy}","received_events_url":"https://api.github.com/users/neoascetic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neoascetic/minetest","description":" Binary releases of Minetest for OS X","fork":true,"url":"https://api.github.com/repos/neoascetic/minetest","forks_url":"https://api.github.com/repos/neoascetic/minetest/forks","keys_url":"https://api.github.com/repos/neoascetic/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neoascetic/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neoascetic/minetest/teams","hooks_url":"https://api.github.com/repos/neoascetic/minetest/hooks","issue_events_url":"https://api.github.com/repos/neoascetic/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/neoascetic/minetest/events","assignees_url":"https://api.github.com/repos/neoascetic/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/neoascetic/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/neoascetic/minetest/tags","blobs_url":"https://api.github.com/repos/neoascetic/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neoascetic/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neoascetic/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/neoascetic/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neoascetic/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/neoascetic/minetest/languages","stargazers_url":"https://api.github.com/repos/neoascetic/minetest/stargazers","contributors_url":"https://api.github.com/repos/neoascetic/minetest/contributors","subscribers_url":"https://api.github.com/repos/neoascetic/minetest/subscribers","subscription_url":"https://api.github.com/repos/neoascetic/minetest/subscription","commits_url":"https://api.github.com/repos/neoascetic/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/neoascetic/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/neoascetic/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/neoascetic/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/neoascetic/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/neoascetic/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neoascetic/minetest/merges","archive_url":"https://api.github.com/repos/neoascetic/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neoascetic/minetest/downloads","issues_url":"https://api.github.com/repos/neoascetic/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/neoascetic/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/neoascetic/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/neoascetic/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neoascetic/minetest/labels{/name}","releases_url":"https://api.github.com/repos/neoascetic/minetest/releases{/id}","created_at":"2014-10-23T18:59:22Z","updated_at":"2015-04-27T21:10:06Z","pushed_at":"2015-04-29T08:30:09Z","git_url":"git://github.com/neoascetic/minetest.git","ssh_url":"git@github.com:neoascetic/minetest.git","clone_url":"https://github.com/neoascetic/minetest.git","svn_url":"https://github.com/neoascetic/minetest","homepage":"https://github.com/neoascetic/minetest/releases","size":35727,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"eec01bc2fabbefbe0d0c008011592d49f8bbd18e","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-04-29T08:08:14Z","pushed_at":"2015-04-29T08:08:13Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":88579,"stargazers_count":1461,"watchers_count":1461,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":481,"mirror_url":null,"open_issues_count":491,"forks":481,"open_issues":491,"watchers":1461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2485"},"html":{"href":"https://github.com/minetest/minetest/pull/2485"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/2485"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/2485/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2485/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2485/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/40e509aa7057a1f6054434d099ed965f239a0b75"}}}}