{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/47412638","id":47412638,"diff_hunk":"@@ -183,6 +187,11 @@ static int sock_ctx_bind_cntr(struct fid *fid, struct fid *bfid, uint64_t flags)\n \tstruct sock_tx_ctx *tx_ctx;\n \tstruct sock_rx_ctx *rx_ctx;\n \n+\tif (flags && !(flags & FI_SEND) && !(flags & FI_RECV) && !(flags & FI_READ) && !(flags & FI_WRITE) && !(flags & FI_REMOTE_READ) && !(flags & FI_REMOTE_WRITE)) {\n+\t\tSOCK_LOG_ERROR(\"Invalid cntr flag\\n\");\n+\t\treturn -FI_EINVAL;\n+\t}\n+","path":"prov/sockets/src/sock_ep.c","position":19,"original_position":19,"commit_id":"81791e28986422c0ff91774fe490dcacf2883501","original_commit_id":"81791e28986422c0ff91774fe490dcacf2883501","user":{"login":"jithinjosepkl","id":6690627,"avatar_url":"https://avatars.githubusercontent.com/u/6690627?v=3","gravatar_id":"","url":"https://api.github.com/users/jithinjosepkl","html_url":"https://github.com/jithinjosepkl","followers_url":"https://api.github.com/users/jithinjosepkl/followers","following_url":"https://api.github.com/users/jithinjosepkl/following{/other_user}","gists_url":"https://api.github.com/users/jithinjosepkl/gists{/gist_id}","starred_url":"https://api.github.com/users/jithinjosepkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jithinjosepkl/subscriptions","organizations_url":"https://api.github.com/users/jithinjosepkl/orgs","repos_url":"https://api.github.com/users/jithinjosepkl/repos","events_url":"https://api.github.com/users/jithinjosepkl/events{/privacy}","received_events_url":"https://api.github.com/users/jithinjosepkl/received_events","type":"User","site_admin":false},"body":"Not sure if this will capture invalid flags. We might just have to create bit masks for CQ and Cntr and check the passed in flags.","created_at":"2015-12-11T22:21:01Z","updated_at":"2015-12-11T22:21:01Z","html_url":"https://github.com/ofiwg/libfabric/pull/1557#discussion_r47412638","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1557","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/47412638"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1557#discussion_r47412638"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1557"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1557","id":53447043,"html_url":"https://github.com/ofiwg/libfabric/pull/1557","diff_url":"https://github.com/ofiwg/libfabric/pull/1557.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/1557.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1557","number":1557,"state":"open","locked":false,"title":"prov/sockets: Return error when fi_ep_bind is called with invalid flags","user":{"login":"shantonu","id":1229120,"avatar_url":"https://avatars.githubusercontent.com/u/1229120?v=3","gravatar_id":"","url":"https://api.github.com/users/shantonu","html_url":"https://github.com/shantonu","followers_url":"https://api.github.com/users/shantonu/followers","following_url":"https://api.github.com/users/shantonu/following{/other_user}","gists_url":"https://api.github.com/users/shantonu/gists{/gist_id}","starred_url":"https://api.github.com/users/shantonu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantonu/subscriptions","organizations_url":"https://api.github.com/users/shantonu/orgs","repos_url":"https://api.github.com/users/shantonu/repos","events_url":"https://api.github.com/users/shantonu/events{/privacy}","received_events_url":"https://api.github.com/users/shantonu/received_events","type":"User","site_admin":false},"body":"- Check for the correct flags for cq and cntr and return error in case of invalid flags\r\nFixes #1552\r\n@jithinjosepkl can you please review?\r\n@agontarek can you check if you get the correct behavior with this fix?\r\n\r\nSigned-off-by: Shantonu Hossain <shantonu.hossain@intel.com>","created_at":"2015-12-11T21:35:15Z","updated_at":"2015-12-11T22:21:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99d1f54a6e3b8c7ae20b9e2a1d9ff36633656515","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1557/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1557/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1557/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/81791e28986422c0ff91774fe490dcacf2883501","head":{"label":"shantonu:pr/sockets-fix","ref":"pr/sockets-fix","sha":"81791e28986422c0ff91774fe490dcacf2883501","user":{"login":"shantonu","id":1229120,"avatar_url":"https://avatars.githubusercontent.com/u/1229120?v=3","gravatar_id":"","url":"https://api.github.com/users/shantonu","html_url":"https://github.com/shantonu","followers_url":"https://api.github.com/users/shantonu/followers","following_url":"https://api.github.com/users/shantonu/following{/other_user}","gists_url":"https://api.github.com/users/shantonu/gists{/gist_id}","starred_url":"https://api.github.com/users/shantonu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantonu/subscriptions","organizations_url":"https://api.github.com/users/shantonu/orgs","repos_url":"https://api.github.com/users/shantonu/repos","events_url":"https://api.github.com/users/shantonu/events{/privacy}","received_events_url":"https://api.github.com/users/shantonu/received_events","type":"User","site_admin":false},"repo":{"id":31289769,"name":"libfabric","full_name":"shantonu/libfabric","owner":{"login":"shantonu","id":1229120,"avatar_url":"https://avatars.githubusercontent.com/u/1229120?v=3","gravatar_id":"","url":"https://api.github.com/users/shantonu","html_url":"https://github.com/shantonu","followers_url":"https://api.github.com/users/shantonu/followers","following_url":"https://api.github.com/users/shantonu/following{/other_user}","gists_url":"https://api.github.com/users/shantonu/gists{/gist_id}","starred_url":"https://api.github.com/users/shantonu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantonu/subscriptions","organizations_url":"https://api.github.com/users/shantonu/orgs","repos_url":"https://api.github.com/users/shantonu/repos","events_url":"https://api.github.com/users/shantonu/events{/privacy}","received_events_url":"https://api.github.com/users/shantonu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shantonu/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/shantonu/libfabric","forks_url":"https://api.github.com/repos/shantonu/libfabric/forks","keys_url":"https://api.github.com/repos/shantonu/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shantonu/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shantonu/libfabric/teams","hooks_url":"https://api.github.com/repos/shantonu/libfabric/hooks","issue_events_url":"https://api.github.com/repos/shantonu/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/shantonu/libfabric/events","assignees_url":"https://api.github.com/repos/shantonu/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/shantonu/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/shantonu/libfabric/tags","blobs_url":"https://api.github.com/repos/shantonu/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shantonu/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shantonu/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/shantonu/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shantonu/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/shantonu/libfabric/languages","stargazers_url":"https://api.github.com/repos/shantonu/libfabric/stargazers","contributors_url":"https://api.github.com/repos/shantonu/libfabric/contributors","subscribers_url":"https://api.github.com/repos/shantonu/libfabric/subscribers","subscription_url":"https://api.github.com/repos/shantonu/libfabric/subscription","commits_url":"https://api.github.com/repos/shantonu/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/shantonu/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/shantonu/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/shantonu/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/shantonu/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/shantonu/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shantonu/libfabric/merges","archive_url":"https://api.github.com/repos/shantonu/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shantonu/libfabric/downloads","issues_url":"https://api.github.com/repos/shantonu/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/shantonu/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/shantonu/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/shantonu/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shantonu/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/shantonu/libfabric/releases{/id}","created_at":"2015-02-25T00:40:49Z","updated_at":"2015-05-05T22:52:16Z","pushed_at":"2015-12-11T21:25:46Z","git_url":"git://github.com/shantonu/libfabric.git","ssh_url":"git@github.com:shantonu/libfabric.git","clone_url":"https://github.com/shantonu/libfabric.git","svn_url":"https://github.com/shantonu/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":8694,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"aeb1a3c146d713fef4bd544f7125df7ababe1807","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","created_at":"2014-08-15T16:45:53Z","updated_at":"2015-11-25T21:01:42Z","pushed_at":"2015-12-11T22:20:23Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":9537,"stargazers_count":53,"watchers_count":53,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":63,"forks":54,"open_issues":63,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1557"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1557"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1557"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1557/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1557/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1557/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/81791e28986422c0ff91774fe490dcacf2883501"}}}}