{"action":"created","comment":{"url":"https://api.github.com/repos/tcdl/msb-java/pulls/comments/38752687","id":38752687,"diff_hunk":"@@ -0,0 +1,61 @@\n+package io.github.tcdl.msb.config;\n+\n+import static org.junit.Assert.assertEquals;\n+import static org.junit.Assert.assertNotNull;\n+import io.github.tcdl.msb.api.exception.ConfigurationException;\n+\n+import org.junit.Test;\n+\n+import com.typesafe.config.Config;\n+import com.typesafe.config.ConfigFactory;\n+\n+public class ServiceDetailsTest {\n+    final String name = \"test_msb\";\n+    final String version = \"1.0.1\";\n+    final String instanceId = \"msbd06a-ed59-4a39-9f95-811c5fb6ab87\";\n+\n+    @Test\n+    public void testServiceDetailsAll() {\n+        String serviceDetailsConfigStr = \"serviceDetails = {name = \\\"\" + name + \"\\\", version = \\\"\" + version + \"\\\", instanceId = \\\"\" + instanceId + \"\\\"}\";","path":"core/src/test/java/io/github/tcdl/msb/config/ServiceDetailsTest.java","position":19,"original_position":19,"commit_id":"be460994d4969b7f683007a40e1ceebd474ba1a7","original_commit_id":"be460994d4969b7f683007a40e1ceebd474ba1a7","user":{"login":"vso-tc","id":11943124,"avatar_url":"https://avatars.githubusercontent.com/u/11943124?v=3","gravatar_id":"","url":"https://api.github.com/users/vso-tc","html_url":"https://github.com/vso-tc","followers_url":"https://api.github.com/users/vso-tc/followers","following_url":"https://api.github.com/users/vso-tc/following{/other_user}","gists_url":"https://api.github.com/users/vso-tc/gists{/gist_id}","starred_url":"https://api.github.com/users/vso-tc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vso-tc/subscriptions","organizations_url":"https://api.github.com/users/vso-tc/orgs","repos_url":"https://api.github.com/users/vso-tc/repos","events_url":"https://api.github.com/users/vso-tc/events{/privacy}","received_events_url":"https://api.github.com/users/vso-tc/received_events","type":"User","site_admin":false},"body":"I would suggest using StringBuilder instead of string concatenation for readability reasons","created_at":"2015-09-04T13:46:15Z","updated_at":"2015-09-04T13:46:15Z","html_url":"https://github.com/tcdl/msb-java/pull/260#discussion_r38752687","pull_request_url":"https://api.github.com/repos/tcdl/msb-java/pulls/260","_links":{"self":{"href":"https://api.github.com/repos/tcdl/msb-java/pulls/comments/38752687"},"html":{"href":"https://github.com/tcdl/msb-java/pull/260#discussion_r38752687"},"pull_request":{"href":"https://api.github.com/repos/tcdl/msb-java/pulls/260"}}},"pull_request":{"url":"https://api.github.com/repos/tcdl/msb-java/pulls/260","id":44217800,"html_url":"https://github.com/tcdl/msb-java/pull/260","diff_url":"https://github.com/tcdl/msb-java/pull/260.diff","patch_url":"https://github.com/tcdl/msb-java/pull/260.patch","issue_url":"https://api.github.com/repos/tcdl/msb-java/issues/260","number":260,"state":"open","locked":false,"title":"Moved InstanceId from mandatory to optional parameter.","user":{"login":"YuriySavchuk","id":12272490,"avatar_url":"https://avatars.githubusercontent.com/u/12272490?v=3","gravatar_id":"","url":"https://api.github.com/users/YuriySavchuk","html_url":"https://github.com/YuriySavchuk","followers_url":"https://api.github.com/users/YuriySavchuk/followers","following_url":"https://api.github.com/users/YuriySavchuk/following{/other_user}","gists_url":"https://api.github.com/users/YuriySavchuk/gists{/gist_id}","starred_url":"https://api.github.com/users/YuriySavchuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuriySavchuk/subscriptions","organizations_url":"https://api.github.com/users/YuriySavchuk/orgs","repos_url":"https://api.github.com/users/YuriySavchuk/repos","events_url":"https://api.github.com/users/YuriySavchuk/events{/privacy}","received_events_url":"https://api.github.com/users/YuriySavchuk/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-04T13:30:46Z","updated_at":"2015-09-04T13:46:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c47030db3e65820dd2d2dae1e6ed67fcb047ddc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tcdl/msb-java/pulls/260/commits","review_comments_url":"https://api.github.com/repos/tcdl/msb-java/pulls/260/comments","review_comment_url":"https://api.github.com/repos/tcdl/msb-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tcdl/msb-java/issues/260/comments","statuses_url":"https://api.github.com/repos/tcdl/msb-java/statuses/be460994d4969b7f683007a40e1ceebd474ba1a7","head":{"label":"tcdl:optional_instance_id","ref":"optional_instance_id","sha":"be460994d4969b7f683007a40e1ceebd474ba1a7","user":{"login":"tcdl","id":11341171,"avatar_url":"https://avatars.githubusercontent.com/u/11341171?v=3","gravatar_id":"","url":"https://api.github.com/users/tcdl","html_url":"https://github.com/tcdl","followers_url":"https://api.github.com/users/tcdl/followers","following_url":"https://api.github.com/users/tcdl/following{/other_user}","gists_url":"https://api.github.com/users/tcdl/gists{/gist_id}","starred_url":"https://api.github.com/users/tcdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcdl/subscriptions","organizations_url":"https://api.github.com/users/tcdl/orgs","repos_url":"https://api.github.com/users/tcdl/repos","events_url":"https://api.github.com/users/tcdl/events{/privacy}","received_events_url":"https://api.github.com/users/tcdl/received_events","type":"Organization","site_admin":false},"repo":{"id":35088538,"name":"msb-java","full_name":"tcdl/msb-java","owner":{"login":"tcdl","id":11341171,"avatar_url":"https://avatars.githubusercontent.com/u/11341171?v=3","gravatar_id":"","url":"https://api.github.com/users/tcdl","html_url":"https://github.com/tcdl","followers_url":"https://api.github.com/users/tcdl/followers","following_url":"https://api.github.com/users/tcdl/following{/other_user}","gists_url":"https://api.github.com/users/tcdl/gists{/gist_id}","starred_url":"https://api.github.com/users/tcdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcdl/subscriptions","organizations_url":"https://api.github.com/users/tcdl/orgs","repos_url":"https://api.github.com/users/tcdl/repos","events_url":"https://api.github.com/users/tcdl/events{/privacy}","received_events_url":"https://api.github.com/users/tcdl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tcdl/msb-java","description":"","fork":false,"url":"https://api.github.com/repos/tcdl/msb-java","forks_url":"https://api.github.com/repos/tcdl/msb-java/forks","keys_url":"https://api.github.com/repos/tcdl/msb-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tcdl/msb-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tcdl/msb-java/teams","hooks_url":"https://api.github.com/repos/tcdl/msb-java/hooks","issue_events_url":"https://api.github.com/repos/tcdl/msb-java/issues/events{/number}","events_url":"https://api.github.com/repos/tcdl/msb-java/events","assignees_url":"https://api.github.com/repos/tcdl/msb-java/assignees{/user}","branches_url":"https://api.github.com/repos/tcdl/msb-java/branches{/branch}","tags_url":"https://api.github.com/repos/tcdl/msb-java/tags","blobs_url":"https://api.github.com/repos/tcdl/msb-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tcdl/msb-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tcdl/msb-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/tcdl/msb-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tcdl/msb-java/statuses/{sha}","languages_url":"https://api.github.com/repos/tcdl/msb-java/languages","stargazers_url":"https://api.github.com/repos/tcdl/msb-java/stargazers","contributors_url":"https://api.github.com/repos/tcdl/msb-java/contributors","subscribers_url":"https://api.github.com/repos/tcdl/msb-java/subscribers","subscription_url":"https://api.github.com/repos/tcdl/msb-java/subscription","commits_url":"https://api.github.com/repos/tcdl/msb-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/tcdl/msb-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/tcdl/msb-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/tcdl/msb-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/tcdl/msb-java/contents/{+path}","compare_url":"https://api.github.com/repos/tcdl/msb-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tcdl/msb-java/merges","archive_url":"https://api.github.com/repos/tcdl/msb-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tcdl/msb-java/downloads","issues_url":"https://api.github.com/repos/tcdl/msb-java/issues{/number}","pulls_url":"https://api.github.com/repos/tcdl/msb-java/pulls{/number}","milestones_url":"https://api.github.com/repos/tcdl/msb-java/milestones{/number}","notifications_url":"https://api.github.com/repos/tcdl/msb-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tcdl/msb-java/labels{/name}","releases_url":"https://api.github.com/repos/tcdl/msb-java/releases{/id}","created_at":"2015-05-05T08:52:35Z","updated_at":"2015-05-15T08:53:24Z","pushed_at":"2015-09-04T13:36:24Z","git_url":"git://github.com/tcdl/msb-java.git","ssh_url":"git@github.com:tcdl/msb-java.git","clone_url":"https://github.com/tcdl/msb-java.git","svn_url":"https://github.com/tcdl/msb-java","homepage":null,"size":4534,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tcdl:master","ref":"master","sha":"deeafcef3727fe9270838a60f8d30ccc59b5eb44","user":{"login":"tcdl","id":11341171,"avatar_url":"https://avatars.githubusercontent.com/u/11341171?v=3","gravatar_id":"","url":"https://api.github.com/users/tcdl","html_url":"https://github.com/tcdl","followers_url":"https://api.github.com/users/tcdl/followers","following_url":"https://api.github.com/users/tcdl/following{/other_user}","gists_url":"https://api.github.com/users/tcdl/gists{/gist_id}","starred_url":"https://api.github.com/users/tcdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcdl/subscriptions","organizations_url":"https://api.github.com/users/tcdl/orgs","repos_url":"https://api.github.com/users/tcdl/repos","events_url":"https://api.github.com/users/tcdl/events{/privacy}","received_events_url":"https://api.github.com/users/tcdl/received_events","type":"Organization","site_admin":false},"repo":{"id":35088538,"name":"msb-java","full_name":"tcdl/msb-java","owner":{"login":"tcdl","id":11341171,"avatar_url":"https://avatars.githubusercontent.com/u/11341171?v=3","gravatar_id":"","url":"https://api.github.com/users/tcdl","html_url":"https://github.com/tcdl","followers_url":"https://api.github.com/users/tcdl/followers","following_url":"https://api.github.com/users/tcdl/following{/other_user}","gists_url":"https://api.github.com/users/tcdl/gists{/gist_id}","starred_url":"https://api.github.com/users/tcdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcdl/subscriptions","organizations_url":"https://api.github.com/users/tcdl/orgs","repos_url":"https://api.github.com/users/tcdl/repos","events_url":"https://api.github.com/users/tcdl/events{/privacy}","received_events_url":"https://api.github.com/users/tcdl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tcdl/msb-java","description":"","fork":false,"url":"https://api.github.com/repos/tcdl/msb-java","forks_url":"https://api.github.com/repos/tcdl/msb-java/forks","keys_url":"https://api.github.com/repos/tcdl/msb-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tcdl/msb-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tcdl/msb-java/teams","hooks_url":"https://api.github.com/repos/tcdl/msb-java/hooks","issue_events_url":"https://api.github.com/repos/tcdl/msb-java/issues/events{/number}","events_url":"https://api.github.com/repos/tcdl/msb-java/events","assignees_url":"https://api.github.com/repos/tcdl/msb-java/assignees{/user}","branches_url":"https://api.github.com/repos/tcdl/msb-java/branches{/branch}","tags_url":"https://api.github.com/repos/tcdl/msb-java/tags","blobs_url":"https://api.github.com/repos/tcdl/msb-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tcdl/msb-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tcdl/msb-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/tcdl/msb-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tcdl/msb-java/statuses/{sha}","languages_url":"https://api.github.com/repos/tcdl/msb-java/languages","stargazers_url":"https://api.github.com/repos/tcdl/msb-java/stargazers","contributors_url":"https://api.github.com/repos/tcdl/msb-java/contributors","subscribers_url":"https://api.github.com/repos/tcdl/msb-java/subscribers","subscription_url":"https://api.github.com/repos/tcdl/msb-java/subscription","commits_url":"https://api.github.com/repos/tcdl/msb-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/tcdl/msb-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/tcdl/msb-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/tcdl/msb-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/tcdl/msb-java/contents/{+path}","compare_url":"https://api.github.com/repos/tcdl/msb-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tcdl/msb-java/merges","archive_url":"https://api.github.com/repos/tcdl/msb-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tcdl/msb-java/downloads","issues_url":"https://api.github.com/repos/tcdl/msb-java/issues{/number}","pulls_url":"https://api.github.com/repos/tcdl/msb-java/pulls{/number}","milestones_url":"https://api.github.com/repos/tcdl/msb-java/milestones{/number}","notifications_url":"https://api.github.com/repos/tcdl/msb-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tcdl/msb-java/labels{/name}","releases_url":"https://api.github.com/repos/tcdl/msb-java/releases{/id}","created_at":"2015-05-05T08:52:35Z","updated_at":"2015-05-15T08:53:24Z","pushed_at":"2015-09-04T13:36:24Z","git_url":"git://github.com/tcdl/msb-java.git","ssh_url":"git@github.com:tcdl/msb-java.git","clone_url":"https://github.com/tcdl/msb-java.git","svn_url":"https://github.com/tcdl/msb-java","homepage":null,"size":4534,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tcdl/msb-java/pulls/260"},"html":{"href":"https://github.com/tcdl/msb-java/pull/260"},"issue":{"href":"https://api.github.com/repos/tcdl/msb-java/issues/260"},"comments":{"href":"https://api.github.com/repos/tcdl/msb-java/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/tcdl/msb-java/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/tcdl/msb-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tcdl/msb-java/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/tcdl/msb-java/statuses/be460994d4969b7f683007a40e1ceebd474ba1a7"}}}}