{"action":"closed","number":41,"pull_request":{"url":"https://api.github.com/repos/videolabs/libdsm/pulls/41","id":50402331,"html_url":"https://github.com/videolabs/libdsm/pull/41","diff_url":"https://github.com/videolabs/libdsm/pull/41.diff","patch_url":"https://github.com/videolabs/libdsm/pull/41.patch","issue_url":"https://api.github.com/repos/videolabs/libdsm/issues/41","number":41,"state":"closed","locked":false,"title":"Fix for issues in #40","user":{"login":"sylverb","id":255405,"avatar_url":"https://avatars.githubusercontent.com/u/255405?v=3","gravatar_id":"","url":"https://api.github.com/users/sylverb","html_url":"https://github.com/sylverb","followers_url":"https://api.github.com/users/sylverb/followers","following_url":"https://api.github.com/users/sylverb/following{/other_user}","gists_url":"https://api.github.com/users/sylverb/gists{/gist_id}","starred_url":"https://api.github.com/users/sylverb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylverb/subscriptions","organizations_url":"https://api.github.com/users/sylverb/orgs","repos_url":"https://api.github.com/users/sylverb/repos","events_url":"https://api.github.com/users/sylverb/events{/privacy}","received_events_url":"https://api.github.com/users/sylverb/received_events","type":"User","site_admin":false},"body":"This commit fix several issues (#40) :\r\n- It was possible to lose some messages if first socket read was reading a keep alive message followed by an answer to a request (this was causing possible file corruption when receiving keepalive message)\r\n- keepalive messages have to be ignored\r\n- reading file data above the 4GiB limit was not working\r\n\r\nTo fix this, I had to use different buffers for sent and received messages as we don't want that a message to send override some data not yet processed in receive buffer.\r\n\r\nI've tested my modifications with a server sending keep alive messages every seconds (instead of every 300s) to make sure that everything is working well ...","created_at":"2015-11-11T16:18:37Z","updated_at":"2015-11-15T00:25:36Z","closed_at":"2015-11-15T00:25:36Z","merged_at":null,"merge_commit_sha":"a52a47d5e3a7b2a9beccd5f2f70a787fc4d27a42","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videolabs/libdsm/pulls/41/commits","review_comments_url":"https://api.github.com/repos/videolabs/libdsm/pulls/41/comments","review_comment_url":"https://api.github.com/repos/videolabs/libdsm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videolabs/libdsm/issues/41/comments","statuses_url":"https://api.github.com/repos/videolabs/libdsm/statuses/f4b98f928fc8f33f58e647285803a24fcdbdf1b4","head":{"label":"sylverb:master","ref":"master","sha":"f4b98f928fc8f33f58e647285803a24fcdbdf1b4","user":{"login":"sylverb","id":255405,"avatar_url":"https://avatars.githubusercontent.com/u/255405?v=3","gravatar_id":"","url":"https://api.github.com/users/sylverb","html_url":"https://github.com/sylverb","followers_url":"https://api.github.com/users/sylverb/followers","following_url":"https://api.github.com/users/sylverb/following{/other_user}","gists_url":"https://api.github.com/users/sylverb/gists{/gist_id}","starred_url":"https://api.github.com/users/sylverb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylverb/subscriptions","organizations_url":"https://api.github.com/users/sylverb/orgs","repos_url":"https://api.github.com/users/sylverb/repos","events_url":"https://api.github.com/users/sylverb/events{/privacy}","received_events_url":"https://api.github.com/users/sylverb/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"videolabs:master","ref":"master","sha":"c046a12fef571c91be981e2af322273792146979","user":{"login":"videolabs","id":6507959,"avatar_url":"https://avatars.githubusercontent.com/u/6507959?v=3","gravatar_id":"","url":"https://api.github.com/users/videolabs","html_url":"https://github.com/videolabs","followers_url":"https://api.github.com/users/videolabs/followers","following_url":"https://api.github.com/users/videolabs/following{/other_user}","gists_url":"https://api.github.com/users/videolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/videolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videolabs/subscriptions","organizations_url":"https://api.github.com/users/videolabs/orgs","repos_url":"https://api.github.com/users/videolabs/repos","events_url":"https://api.github.com/users/videolabs/events{/privacy}","received_events_url":"https://api.github.com/users/videolabs/received_events","type":"Organization","site_admin":false},"repo":{"id":18140593,"name":"libdsm","full_name":"videolabs/libdsm","owner":{"login":"videolabs","id":6507959,"avatar_url":"https://avatars.githubusercontent.com/u/6507959?v=3","gravatar_id":"","url":"https://api.github.com/users/videolabs","html_url":"https://github.com/videolabs","followers_url":"https://api.github.com/users/videolabs/followers","following_url":"https://api.github.com/users/videolabs/following{/other_user}","gists_url":"https://api.github.com/users/videolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/videolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videolabs/subscriptions","organizations_url":"https://api.github.com/users/videolabs/orgs","repos_url":"https://api.github.com/users/videolabs/repos","events_url":"https://api.github.com/users/videolabs/events{/privacy}","received_events_url":"https://api.github.com/users/videolabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videolabs/libdsm","description":"Defective SMb: A minimalist and read-only implementation of SMB using Plain'Ol C","fork":false,"url":"https://api.github.com/repos/videolabs/libdsm","forks_url":"https://api.github.com/repos/videolabs/libdsm/forks","keys_url":"https://api.github.com/repos/videolabs/libdsm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videolabs/libdsm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videolabs/libdsm/teams","hooks_url":"https://api.github.com/repos/videolabs/libdsm/hooks","issue_events_url":"https://api.github.com/repos/videolabs/libdsm/issues/events{/number}","events_url":"https://api.github.com/repos/videolabs/libdsm/events","assignees_url":"https://api.github.com/repos/videolabs/libdsm/assignees{/user}","branches_url":"https://api.github.com/repos/videolabs/libdsm/branches{/branch}","tags_url":"https://api.github.com/repos/videolabs/libdsm/tags","blobs_url":"https://api.github.com/repos/videolabs/libdsm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videolabs/libdsm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videolabs/libdsm/git/refs{/sha}","trees_url":"https://api.github.com/repos/videolabs/libdsm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videolabs/libdsm/statuses/{sha}","languages_url":"https://api.github.com/repos/videolabs/libdsm/languages","stargazers_url":"https://api.github.com/repos/videolabs/libdsm/stargazers","contributors_url":"https://api.github.com/repos/videolabs/libdsm/contributors","subscribers_url":"https://api.github.com/repos/videolabs/libdsm/subscribers","subscription_url":"https://api.github.com/repos/videolabs/libdsm/subscription","commits_url":"https://api.github.com/repos/videolabs/libdsm/commits{/sha}","git_commits_url":"https://api.github.com/repos/videolabs/libdsm/git/commits{/sha}","comments_url":"https://api.github.com/repos/videolabs/libdsm/comments{/number}","issue_comment_url":"https://api.github.com/repos/videolabs/libdsm/issues/comments{/number}","contents_url":"https://api.github.com/repos/videolabs/libdsm/contents/{+path}","compare_url":"https://api.github.com/repos/videolabs/libdsm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videolabs/libdsm/merges","archive_url":"https://api.github.com/repos/videolabs/libdsm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videolabs/libdsm/downloads","issues_url":"https://api.github.com/repos/videolabs/libdsm/issues{/number}","pulls_url":"https://api.github.com/repos/videolabs/libdsm/pulls{/number}","milestones_url":"https://api.github.com/repos/videolabs/libdsm/milestones{/number}","notifications_url":"https://api.github.com/repos/videolabs/libdsm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videolabs/libdsm/labels{/name}","releases_url":"https://api.github.com/repos/videolabs/libdsm/releases{/id}","created_at":"2014-03-26T14:18:53Z","updated_at":"2015-11-04T22:40:38Z","pushed_at":"2015-11-11T16:18:37Z","git_url":"git://github.com/videolabs/libdsm.git","ssh_url":"git@github.com:videolabs/libdsm.git","clone_url":"https://github.com/videolabs/libdsm.git","svn_url":"https://github.com/videolabs/libdsm","homepage":"http://videolabs.github.io/libdsm","size":2059,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videolabs/libdsm/pulls/41"},"html":{"href":"https://github.com/videolabs/libdsm/pull/41"},"issue":{"href":"https://api.github.com/repos/videolabs/libdsm/issues/41"},"comments":{"href":"https://api.github.com/repos/videolabs/libdsm/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/videolabs/libdsm/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/videolabs/libdsm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videolabs/libdsm/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/videolabs/libdsm/statuses/f4b98f928fc8f33f58e647285803a24fcdbdf1b4"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":4,"additions":123,"deletions":56,"changed_files":5}}