{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments/41494963","id":41494963,"diff_hunk":"@@ -129,7 +137,15 @@ def ensure_global_config(self):\n \n         # Configure IPAM directory structures (to ensure confd is able to\n         # watch appropriate directory trees).\n-        self.etcd_client.write(CONFIG_IF_PREF_PATH, IF_PREFIX)\n+        host = socket.gethostname()","path":"calico_containers/pycalico/datastore.py","position":31,"original_position":31,"commit_id":"291030101e1d0c65111a192792bc8c62b9db9dec","original_commit_id":"794810df947aba5acbc535861219f88d1eadc659","user":{"login":"plwhite","id":8448749,"avatar_url":"https://avatars.githubusercontent.com/u/8448749?v=3","gravatar_id":"","url":"https://api.github.com/users/plwhite","html_url":"https://github.com/plwhite","followers_url":"https://api.github.com/users/plwhite/followers","following_url":"https://api.github.com/users/plwhite/following{/other_user}","gists_url":"https://api.github.com/users/plwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/plwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plwhite/subscriptions","organizations_url":"https://api.github.com/users/plwhite/orgs","repos_url":"https://api.github.com/users/plwhite/repos","events_url":"https://api.github.com/users/plwhite/events{/privacy}","received_events_url":"https://api.github.com/users/plwhite/received_events","type":"User","site_admin":false},"body":"I don't think we do, because of the line \"write_global_config\" above that writes the exact same path and value; unless I'm misunderstanding (not without precedent!) this line is effectively a duplicate.","created_at":"2015-10-08T09:47:36Z","updated_at":"2015-10-08T09:47:36Z","html_url":"https://github.com/projectcalico/libcalico/pull/30#discussion_r41494963","pull_request_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments/41494963"},"html":{"href":"https://github.com/projectcalico/libcalico/pull/30#discussion_r41494963"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/libcalico/pulls/30","id":46911024,"html_url":"https://github.com/projectcalico/libcalico/pull/30","diff_url":"https://github.com/projectcalico/libcalico/pull/30.diff","patch_url":"https://github.com/projectcalico/libcalico/pull/30.patch","issue_url":"https://api.github.com/repos/projectcalico/libcalico/issues/30","number":30,"state":"open","locked":false,"title":"Set up host affinity path making code match comment.","user":{"login":"plwhite","id":8448749,"avatar_url":"https://avatars.githubusercontent.com/u/8448749?v=3","gravatar_id":"","url":"https://api.github.com/users/plwhite","html_url":"https://github.com/plwhite","followers_url":"https://api.github.com/users/plwhite/followers","following_url":"https://api.github.com/users/plwhite/following{/other_user}","gists_url":"https://api.github.com/users/plwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/plwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plwhite/subscriptions","organizations_url":"https://api.github.com/users/plwhite/orgs","repos_url":"https://api.github.com/users/plwhite/repos","events_url":"https://api.github.com/users/plwhite/events{/privacy}","received_events_url":"https://api.github.com/users/plwhite/received_events","type":"User","site_admin":false},"body":"Can I get some feedback on this?\r\n\r\nBackground is that there was a comment saying that libcalico would set up the IPAM directories, but it didn't - and this broke my route aggregation code in calico-docker. I put in a trivial fix, but there may be style issues.\r\n\r\nI've not written any new tests because I haven't been able to run them, but if you can point me at some instructions I can extend the tests. However, seems worth getting a sanity check now before I expend time on the tests.","created_at":"2015-10-06T14:37:14Z","updated_at":"2015-10-08T09:47:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf2858d050cb10fcef57d3bebee3ae6f6c64daaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/30/commits","review_comments_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/30/comments","review_comment_url":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/libcalico/issues/30/comments","statuses_url":"https://api.github.com/repos/projectcalico/libcalico/statuses/291030101e1d0c65111a192792bc8c62b9db9dec","head":{"label":"plwhite:master","ref":"master","sha":"291030101e1d0c65111a192792bc8c62b9db9dec","user":{"login":"plwhite","id":8448749,"avatar_url":"https://avatars.githubusercontent.com/u/8448749?v=3","gravatar_id":"","url":"https://api.github.com/users/plwhite","html_url":"https://github.com/plwhite","followers_url":"https://api.github.com/users/plwhite/followers","following_url":"https://api.github.com/users/plwhite/following{/other_user}","gists_url":"https://api.github.com/users/plwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/plwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plwhite/subscriptions","organizations_url":"https://api.github.com/users/plwhite/orgs","repos_url":"https://api.github.com/users/plwhite/repos","events_url":"https://api.github.com/users/plwhite/events{/privacy}","received_events_url":"https://api.github.com/users/plwhite/received_events","type":"User","site_admin":false},"repo":{"id":43747840,"name":"libcalico","full_name":"plwhite/libcalico","owner":{"login":"plwhite","id":8448749,"avatar_url":"https://avatars.githubusercontent.com/u/8448749?v=3","gravatar_id":"","url":"https://api.github.com/users/plwhite","html_url":"https://github.com/plwhite","followers_url":"https://api.github.com/users/plwhite/followers","following_url":"https://api.github.com/users/plwhite/following{/other_user}","gists_url":"https://api.github.com/users/plwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/plwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plwhite/subscriptions","organizations_url":"https://api.github.com/users/plwhite/orgs","repos_url":"https://api.github.com/users/plwhite/repos","events_url":"https://api.github.com/users/plwhite/events{/privacy}","received_events_url":"https://api.github.com/users/plwhite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/plwhite/libcalico","description":"","fork":true,"url":"https://api.github.com/repos/plwhite/libcalico","forks_url":"https://api.github.com/repos/plwhite/libcalico/forks","keys_url":"https://api.github.com/repos/plwhite/libcalico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plwhite/libcalico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plwhite/libcalico/teams","hooks_url":"https://api.github.com/repos/plwhite/libcalico/hooks","issue_events_url":"https://api.github.com/repos/plwhite/libcalico/issues/events{/number}","events_url":"https://api.github.com/repos/plwhite/libcalico/events","assignees_url":"https://api.github.com/repos/plwhite/libcalico/assignees{/user}","branches_url":"https://api.github.com/repos/plwhite/libcalico/branches{/branch}","tags_url":"https://api.github.com/repos/plwhite/libcalico/tags","blobs_url":"https://api.github.com/repos/plwhite/libcalico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plwhite/libcalico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plwhite/libcalico/git/refs{/sha}","trees_url":"https://api.github.com/repos/plwhite/libcalico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plwhite/libcalico/statuses/{sha}","languages_url":"https://api.github.com/repos/plwhite/libcalico/languages","stargazers_url":"https://api.github.com/repos/plwhite/libcalico/stargazers","contributors_url":"https://api.github.com/repos/plwhite/libcalico/contributors","subscribers_url":"https://api.github.com/repos/plwhite/libcalico/subscribers","subscription_url":"https://api.github.com/repos/plwhite/libcalico/subscription","commits_url":"https://api.github.com/repos/plwhite/libcalico/commits{/sha}","git_commits_url":"https://api.github.com/repos/plwhite/libcalico/git/commits{/sha}","comments_url":"https://api.github.com/repos/plwhite/libcalico/comments{/number}","issue_comment_url":"https://api.github.com/repos/plwhite/libcalico/issues/comments{/number}","contents_url":"https://api.github.com/repos/plwhite/libcalico/contents/{+path}","compare_url":"https://api.github.com/repos/plwhite/libcalico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plwhite/libcalico/merges","archive_url":"https://api.github.com/repos/plwhite/libcalico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plwhite/libcalico/downloads","issues_url":"https://api.github.com/repos/plwhite/libcalico/issues{/number}","pulls_url":"https://api.github.com/repos/plwhite/libcalico/pulls{/number}","milestones_url":"https://api.github.com/repos/plwhite/libcalico/milestones{/number}","notifications_url":"https://api.github.com/repos/plwhite/libcalico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plwhite/libcalico/labels{/name}","releases_url":"https://api.github.com/repos/plwhite/libcalico/releases{/id}","created_at":"2015-10-06T12:01:42Z","updated_at":"2015-10-06T12:01:43Z","pushed_at":"2015-10-08T09:29:34Z","git_url":"git://github.com/plwhite/libcalico.git","ssh_url":"git@github.com:plwhite/libcalico.git","clone_url":"https://github.com/plwhite/libcalico.git","svn_url":"https://github.com/plwhite/libcalico","homepage":"http://www.projectcalico.org/","size":2096,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"c30741d10f077fc200fc10526bdb2ec6452571b4","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":39856396,"name":"libcalico","full_name":"projectcalico/libcalico","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/libcalico","description":"","fork":false,"url":"https://api.github.com/repos/projectcalico/libcalico","forks_url":"https://api.github.com/repos/projectcalico/libcalico/forks","keys_url":"https://api.github.com/repos/projectcalico/libcalico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/libcalico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/libcalico/teams","hooks_url":"https://api.github.com/repos/projectcalico/libcalico/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/libcalico/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/libcalico/events","assignees_url":"https://api.github.com/repos/projectcalico/libcalico/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/libcalico/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/libcalico/tags","blobs_url":"https://api.github.com/repos/projectcalico/libcalico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/libcalico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/libcalico/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/libcalico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/libcalico/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/libcalico/languages","stargazers_url":"https://api.github.com/repos/projectcalico/libcalico/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/libcalico/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/libcalico/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/libcalico/subscription","commits_url":"https://api.github.com/repos/projectcalico/libcalico/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/libcalico/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/libcalico/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/libcalico/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/libcalico/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/libcalico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/libcalico/merges","archive_url":"https://api.github.com/repos/projectcalico/libcalico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/libcalico/downloads","issues_url":"https://api.github.com/repos/projectcalico/libcalico/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/libcalico/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/libcalico/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/libcalico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/libcalico/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/libcalico/releases{/id}","created_at":"2015-07-28T20:33:51Z","updated_at":"2015-09-22T16:40:13Z","pushed_at":"2015-10-08T09:29:35Z","git_url":"git://github.com/projectcalico/libcalico.git","ssh_url":"git@github.com:projectcalico/libcalico.git","clone_url":"https://github.com/projectcalico/libcalico.git","svn_url":"https://github.com/projectcalico/libcalico","homepage":"http://www.projectcalico.org/","size":2096,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/30"},"html":{"href":"https://github.com/projectcalico/libcalico/pull/30"},"issue":{"href":"https://api.github.com/repos/projectcalico/libcalico/issues/30"},"comments":{"href":"https://api.github.com/repos/projectcalico/libcalico/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/libcalico/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/libcalico/statuses/291030101e1d0c65111a192792bc8c62b9db9dec"}}}}