{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/promdash/pulls/comments/24235578","id":24235578,"diff_hunk":"@@ -17,10 +17,7 @@ angular.module(\"Prometheus.directives\").directive('inlineFrame', [\"$sce\", \"Varia\n         return WidgetHeightCalculator(element.find(\".js_widget_wrapper\")[0], scope.aspectRatio);\n       }\n \n-      scope.refreshFrame = function() {\n-        var frame = element.find('.frame_container');\n-        frame.html(frame.html());\n-      };\n+      scope.refreshFrame = regenFrame;","path":"app/assets/javascripts/angular/directives/frame.js.erb","position":8,"original_position":8,"commit_id":"240b0855b26a527f4a75936908205ea5de5480d4","original_commit_id":"240b0855b26a527f4a75936908205ea5de5480d4","user":{"login":"juliusv","id":538008,"avatar_url":"https://avatars.githubusercontent.com/u/538008?v=3","gravatar_id":"","url":"https://api.github.com/users/juliusv","html_url":"https://github.com/juliusv","followers_url":"https://api.github.com/users/juliusv/followers","following_url":"https://api.github.com/users/juliusv/following{/other_user}","gists_url":"https://api.github.com/users/juliusv/gists{/gist_id}","starred_url":"https://api.github.com/users/juliusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliusv/subscriptions","organizations_url":"https://api.github.com/users/juliusv/orgs","repos_url":"https://api.github.com/users/juliusv/repos","events_url":"https://api.github.com/users/juliusv/events{/privacy}","received_events_url":"https://api.github.com/users/juliusv/received_events","type":"User","site_admin":false},"body":"Why not put the function directly on the scope instead of having it as a separate name that's then assigned here?","created_at":"2015-02-06T11:37:58Z","updated_at":"2015-02-06T11:37:58Z","html_url":"https://github.com/prometheus/promdash/pull/326#discussion_r24235578","pull_request_url":"https://api.github.com/repos/prometheus/promdash/pulls/326","_links":{"self":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/comments/24235578"},"html":{"href":"https://github.com/prometheus/promdash/pull/326#discussion_r24235578"},"pull_request":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/326"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/promdash/pulls/326","id":28800490,"html_url":"https://github.com/prometheus/promdash/pull/326","diff_url":"https://github.com/prometheus/promdash/pull/326.diff","patch_url":"https://github.com/prometheus/promdash/pull/326.patch","issue_url":"https://api.github.com/repos/prometheus/promdash/issues/326","number":326,"state":"open","locked":false,"title":"Refresh frame with updated endtime/range values.","user":{"login":"stuartnelson3","id":1398104,"avatar_url":"https://avatars.githubusercontent.com/u/1398104?v=3","gravatar_id":"","url":"https://api.github.com/users/stuartnelson3","html_url":"https://github.com/stuartnelson3","followers_url":"https://api.github.com/users/stuartnelson3/followers","following_url":"https://api.github.com/users/stuartnelson3/following{/other_user}","gists_url":"https://api.github.com/users/stuartnelson3/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartnelson3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartnelson3/subscriptions","organizations_url":"https://api.github.com/users/stuartnelson3/orgs","repos_url":"https://api.github.com/users/stuartnelson3/repos","events_url":"https://api.github.com/users/stuartnelson3/events{/privacy}","received_events_url":"https://api.github.com/users/stuartnelson3/received_events","type":"User","site_admin":false},"body":"The refresh was aborting early in the previous commit, causing changes in just endtime/range not to be added to the url. Now, instead of a transient url var, the scope stores the current escaped url. Updated fields e.g. height width from until will be written to this url, which is used as the source for the iframe.\r\n\r\n@juliusv ","created_at":"2015-02-06T11:00:55Z","updated_at":"2015-02-06T11:37:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7158e7767749f184d7361423147e39c102dd8bc5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/promdash/pulls/326/commits","review_comments_url":"https://api.github.com/repos/prometheus/promdash/pulls/326/comments","review_comment_url":"https://api.github.com/repos/prometheus/promdash/pulls/comments/{number}","comments_url":"https://api.github.com/repos/prometheus/promdash/issues/326/comments","statuses_url":"https://api.github.com/repos/prometheus/promdash/statuses/240b0855b26a527f4a75936908205ea5de5480d4","head":{"label":"prometheus:fix-frame-until-range-refresh","ref":"fix-frame-until-range-refresh","sha":"240b0855b26a527f4a75936908205ea5de5480d4","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":13788490,"name":"promdash","full_name":"prometheus/promdash","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/promdash","description":"Prometheus Dashboard Builder","fork":false,"url":"https://api.github.com/repos/prometheus/promdash","forks_url":"https://api.github.com/repos/prometheus/promdash/forks","keys_url":"https://api.github.com/repos/prometheus/promdash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/promdash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/promdash/teams","hooks_url":"https://api.github.com/repos/prometheus/promdash/hooks","issue_events_url":"https://api.github.com/repos/prometheus/promdash/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/promdash/events","assignees_url":"https://api.github.com/repos/prometheus/promdash/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/promdash/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/promdash/tags","blobs_url":"https://api.github.com/repos/prometheus/promdash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/promdash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/promdash/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/promdash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/promdash/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/promdash/languages","stargazers_url":"https://api.github.com/repos/prometheus/promdash/stargazers","contributors_url":"https://api.github.com/repos/prometheus/promdash/contributors","subscribers_url":"https://api.github.com/repos/prometheus/promdash/subscribers","subscription_url":"https://api.github.com/repos/prometheus/promdash/subscription","commits_url":"https://api.github.com/repos/prometheus/promdash/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/promdash/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/promdash/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/promdash/issues/comments/{number}","contents_url":"https://api.github.com/repos/prometheus/promdash/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/promdash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/promdash/merges","archive_url":"https://api.github.com/repos/prometheus/promdash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/promdash/downloads","issues_url":"https://api.github.com/repos/prometheus/promdash/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/promdash/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/promdash/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/promdash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/promdash/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/promdash/releases{/id}","created_at":"2013-10-22T23:15:38Z","updated_at":"2015-02-05T23:13:57Z","pushed_at":"2015-02-06T10:59:45Z","git_url":"git://github.com/prometheus/promdash.git","ssh_url":"git@github.com:prometheus/promdash.git","clone_url":"https://github.com/prometheus/promdash.git","svn_url":"https://github.com/prometheus/promdash","homepage":"http://prometheus.io/","size":5006,"stargazers_count":66,"watchers_count":66,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":49,"forks":5,"open_issues":49,"watchers":66,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"f29edce4ef6d88a87f532d2ce94d3781496ae7ea","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":13788490,"name":"promdash","full_name":"prometheus/promdash","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/promdash","description":"Prometheus Dashboard Builder","fork":false,"url":"https://api.github.com/repos/prometheus/promdash","forks_url":"https://api.github.com/repos/prometheus/promdash/forks","keys_url":"https://api.github.com/repos/prometheus/promdash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/promdash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/promdash/teams","hooks_url":"https://api.github.com/repos/prometheus/promdash/hooks","issue_events_url":"https://api.github.com/repos/prometheus/promdash/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/promdash/events","assignees_url":"https://api.github.com/repos/prometheus/promdash/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/promdash/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/promdash/tags","blobs_url":"https://api.github.com/repos/prometheus/promdash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/promdash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/promdash/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/promdash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/promdash/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/promdash/languages","stargazers_url":"https://api.github.com/repos/prometheus/promdash/stargazers","contributors_url":"https://api.github.com/repos/prometheus/promdash/contributors","subscribers_url":"https://api.github.com/repos/prometheus/promdash/subscribers","subscription_url":"https://api.github.com/repos/prometheus/promdash/subscription","commits_url":"https://api.github.com/repos/prometheus/promdash/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/promdash/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/promdash/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/promdash/issues/comments/{number}","contents_url":"https://api.github.com/repos/prometheus/promdash/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/promdash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/promdash/merges","archive_url":"https://api.github.com/repos/prometheus/promdash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/promdash/downloads","issues_url":"https://api.github.com/repos/prometheus/promdash/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/promdash/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/promdash/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/promdash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/promdash/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/promdash/releases{/id}","created_at":"2013-10-22T23:15:38Z","updated_at":"2015-02-05T23:13:57Z","pushed_at":"2015-02-06T10:59:45Z","git_url":"git://github.com/prometheus/promdash.git","ssh_url":"git@github.com:prometheus/promdash.git","clone_url":"https://github.com/prometheus/promdash.git","svn_url":"https://github.com/prometheus/promdash","homepage":"http://prometheus.io/","size":5006,"stargazers_count":66,"watchers_count":66,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":49,"forks":5,"open_issues":49,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/326"},"html":{"href":"https://github.com/prometheus/promdash/pull/326"},"issue":{"href":"https://api.github.com/repos/prometheus/promdash/issues/326"},"comments":{"href":"https://api.github.com/repos/prometheus/promdash/issues/326/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/326/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/prometheus/promdash/pulls/326/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/promdash/statuses/240b0855b26a527f4a75936908205ea5de5480d4"}}}}