{"action":"created","comment":{"url":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/comments/38409084","id":38409084,"diff_hunk":"@@ -135,7 +130,8 @@ public function actionUpdate(<?= $actionParams ?>)\n      * Deletes an existing <?= $modelClass ?> model.\n      * If deletion is successful, the browser will be redirected to the 'index' page.\n      * <?= implode(\"\\n     * \", $actionParamComments) . \"\\n\" ?>\n-     * @return mixed\n+     * @return \\yii\\web\\Response","path":"generators/crud/default/controller.php","position":109,"original_position":109,"commit_id":"7437e8056fedcdfece69af0ff148bf5525f8345a","original_commit_id":"7437e8056fedcdfece69af0ff148bf5525f8345a","user":{"login":"samdark","id":47294,"avatar_url":"https://avatars.githubusercontent.com/u/47294?v=3","gravatar_id":"","url":"https://api.github.com/users/samdark","html_url":"https://github.com/samdark","followers_url":"https://api.github.com/users/samdark/followers","following_url":"https://api.github.com/users/samdark/following{/other_user}","gists_url":"https://api.github.com/users/samdark/gists{/gist_id}","starred_url":"https://api.github.com/users/samdark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdark/subscriptions","organizations_url":"https://api.github.com/users/samdark/orgs","repos_url":"https://api.github.com/users/samdark/repos","events_url":"https://api.github.com/users/samdark/events{/privacy}","received_events_url":"https://api.github.com/users/samdark/received_events","type":"User","site_admin":false},"body":"In this case it's string.","created_at":"2015-09-01T11:33:06Z","updated_at":"2015-09-01T11:33:06Z","html_url":"https://github.com/yiisoft/yii2-gii/pull/85#discussion_r38409084","pull_request_url":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/comments/38409084"},"html":{"href":"https://github.com/yiisoft/yii2-gii/pull/85#discussion_r38409084"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/85","id":43862672,"html_url":"https://github.com/yiisoft/yii2-gii/pull/85","diff_url":"https://github.com/yiisoft/yii2-gii/pull/85.diff","patch_url":"https://github.com/yiisoft/yii2-gii/pull/85.patch","issue_url":"https://api.github.com/repos/yiisoft/yii2-gii/issues/85","number":85,"state":"open","locked":false,"title":"CRUD code style fixes","user":{"login":"arogachev","id":8326201,"avatar_url":"https://avatars.githubusercontent.com/u/8326201?v=3","gravatar_id":"","url":"https://api.github.com/users/arogachev","html_url":"https://github.com/arogachev","followers_url":"https://api.github.com/users/arogachev/followers","following_url":"https://api.github.com/users/arogachev/following{/other_user}","gists_url":"https://api.github.com/users/arogachev/gists{/gist_id}","starred_url":"https://api.github.com/users/arogachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arogachev/subscriptions","organizations_url":"https://api.github.com/users/arogachev/orgs","repos_url":"https://api.github.com/users/arogachev/repos","events_url":"https://api.github.com/users/arogachev/events{/privacy}","received_events_url":"https://api.github.com/users/arogachev/received_events","type":"User","site_admin":false},"body":"- Corrected imports to be in alphabetical order.\r\n- Removed extra line breaks and added new.\r\n- When the number of params is 1, it should be \"one liner\" for more compact view (except very long line). If the user need to add more, he should add line breaks and extra comma on his own.\r\n- Corrected PHPDoc (missing `@inheritdoc`, `more explicit `@return`, missing `@throws`).\r\n- Prevented reaching max symbols limit in line.\r\n- Encoding of title is redundant by default, because this string is safe and managed by programmer, not user.\r\n- Removed extra concatenation with space.\r\n- Converted double quotes to single used in empty string (`''` instead of `\"\"`).\r\n- Capitalized comments.\r\n- Removed variable assignment in condition, I think it's bad practice and it's better to assign variable separately before, this makes code more clear and easier to read.","created_at":"2015-09-01T11:02:56Z","updated_at":"2015-09-01T11:33:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e64f9e3eb35fdf23ac118db5cd1c0ade6a8f3d0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/85/commits","review_comments_url":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/85/comments","review_comment_url":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yiisoft/yii2-gii/issues/85/comments","statuses_url":"https://api.github.com/repos/yiisoft/yii2-gii/statuses/7437e8056fedcdfece69af0ff148bf5525f8345a","head":{"label":"arogachev:crud-code-style-fixes","ref":"crud-code-style-fixes","sha":"7437e8056fedcdfece69af0ff148bf5525f8345a","user":{"login":"arogachev","id":8326201,"avatar_url":"https://avatars.githubusercontent.com/u/8326201?v=3","gravatar_id":"","url":"https://api.github.com/users/arogachev","html_url":"https://github.com/arogachev","followers_url":"https://api.github.com/users/arogachev/followers","following_url":"https://api.github.com/users/arogachev/following{/other_user}","gists_url":"https://api.github.com/users/arogachev/gists{/gist_id}","starred_url":"https://api.github.com/users/arogachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arogachev/subscriptions","organizations_url":"https://api.github.com/users/arogachev/orgs","repos_url":"https://api.github.com/users/arogachev/repos","events_url":"https://api.github.com/users/arogachev/events{/privacy}","received_events_url":"https://api.github.com/users/arogachev/received_events","type":"User","site_admin":false},"repo":{"id":41730090,"name":"yii2-gii","full_name":"arogachev/yii2-gii","owner":{"login":"arogachev","id":8326201,"avatar_url":"https://avatars.githubusercontent.com/u/8326201?v=3","gravatar_id":"","url":"https://api.github.com/users/arogachev","html_url":"https://github.com/arogachev","followers_url":"https://api.github.com/users/arogachev/followers","following_url":"https://api.github.com/users/arogachev/following{/other_user}","gists_url":"https://api.github.com/users/arogachev/gists{/gist_id}","starred_url":"https://api.github.com/users/arogachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arogachev/subscriptions","organizations_url":"https://api.github.com/users/arogachev/orgs","repos_url":"https://api.github.com/users/arogachev/repos","events_url":"https://api.github.com/users/arogachev/events{/privacy}","received_events_url":"https://api.github.com/users/arogachev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arogachev/yii2-gii","description":"Yii 2 Gii Extension.","fork":true,"url":"https://api.github.com/repos/arogachev/yii2-gii","forks_url":"https://api.github.com/repos/arogachev/yii2-gii/forks","keys_url":"https://api.github.com/repos/arogachev/yii2-gii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arogachev/yii2-gii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arogachev/yii2-gii/teams","hooks_url":"https://api.github.com/repos/arogachev/yii2-gii/hooks","issue_events_url":"https://api.github.com/repos/arogachev/yii2-gii/issues/events{/number}","events_url":"https://api.github.com/repos/arogachev/yii2-gii/events","assignees_url":"https://api.github.com/repos/arogachev/yii2-gii/assignees{/user}","branches_url":"https://api.github.com/repos/arogachev/yii2-gii/branches{/branch}","tags_url":"https://api.github.com/repos/arogachev/yii2-gii/tags","blobs_url":"https://api.github.com/repos/arogachev/yii2-gii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arogachev/yii2-gii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arogachev/yii2-gii/git/refs{/sha}","trees_url":"https://api.github.com/repos/arogachev/yii2-gii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arogachev/yii2-gii/statuses/{sha}","languages_url":"https://api.github.com/repos/arogachev/yii2-gii/languages","stargazers_url":"https://api.github.com/repos/arogachev/yii2-gii/stargazers","contributors_url":"https://api.github.com/repos/arogachev/yii2-gii/contributors","subscribers_url":"https://api.github.com/repos/arogachev/yii2-gii/subscribers","subscription_url":"https://api.github.com/repos/arogachev/yii2-gii/subscription","commits_url":"https://api.github.com/repos/arogachev/yii2-gii/commits{/sha}","git_commits_url":"https://api.github.com/repos/arogachev/yii2-gii/git/commits{/sha}","comments_url":"https://api.github.com/repos/arogachev/yii2-gii/comments{/number}","issue_comment_url":"https://api.github.com/repos/arogachev/yii2-gii/issues/comments{/number}","contents_url":"https://api.github.com/repos/arogachev/yii2-gii/contents/{+path}","compare_url":"https://api.github.com/repos/arogachev/yii2-gii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arogachev/yii2-gii/merges","archive_url":"https://api.github.com/repos/arogachev/yii2-gii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arogachev/yii2-gii/downloads","issues_url":"https://api.github.com/repos/arogachev/yii2-gii/issues{/number}","pulls_url":"https://api.github.com/repos/arogachev/yii2-gii/pulls{/number}","milestones_url":"https://api.github.com/repos/arogachev/yii2-gii/milestones{/number}","notifications_url":"https://api.github.com/repos/arogachev/yii2-gii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arogachev/yii2-gii/labels{/name}","releases_url":"https://api.github.com/repos/arogachev/yii2-gii/releases{/id}","created_at":"2015-09-01T09:40:23Z","updated_at":"2015-09-01T09:40:23Z","pushed_at":"2015-09-01T11:02:15Z","git_url":"git://github.com/arogachev/yii2-gii.git","ssh_url":"git@github.com:arogachev/yii2-gii.git","clone_url":"https://github.com/arogachev/yii2-gii.git","svn_url":"https://github.com/arogachev/yii2-gii","homepage":"http://www.yiiframework.com","size":12523,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft:master","ref":"master","sha":"6519954dc8dd16050d886d1266d6248cbae2d14f","user":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":14080037,"name":"yii2-gii","full_name":"yiisoft/yii2-gii","owner":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yiisoft/yii2-gii","description":"Yii 2 Gii Extension.","fork":false,"url":"https://api.github.com/repos/yiisoft/yii2-gii","forks_url":"https://api.github.com/repos/yiisoft/yii2-gii/forks","keys_url":"https://api.github.com/repos/yiisoft/yii2-gii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft/yii2-gii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft/yii2-gii/teams","hooks_url":"https://api.github.com/repos/yiisoft/yii2-gii/hooks","issue_events_url":"https://api.github.com/repos/yiisoft/yii2-gii/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft/yii2-gii/events","assignees_url":"https://api.github.com/repos/yiisoft/yii2-gii/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft/yii2-gii/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft/yii2-gii/tags","blobs_url":"https://api.github.com/repos/yiisoft/yii2-gii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft/yii2-gii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft/yii2-gii/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft/yii2-gii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft/yii2-gii/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft/yii2-gii/languages","stargazers_url":"https://api.github.com/repos/yiisoft/yii2-gii/stargazers","contributors_url":"https://api.github.com/repos/yiisoft/yii2-gii/contributors","subscribers_url":"https://api.github.com/repos/yiisoft/yii2-gii/subscribers","subscription_url":"https://api.github.com/repos/yiisoft/yii2-gii/subscription","commits_url":"https://api.github.com/repos/yiisoft/yii2-gii/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft/yii2-gii/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft/yii2-gii/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft/yii2-gii/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiisoft/yii2-gii/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft/yii2-gii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft/yii2-gii/merges","archive_url":"https://api.github.com/repos/yiisoft/yii2-gii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft/yii2-gii/downloads","issues_url":"https://api.github.com/repos/yiisoft/yii2-gii/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft/yii2-gii/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft/yii2-gii/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft/yii2-gii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft/yii2-gii/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft/yii2-gii/releases{/id}","created_at":"2013-11-03T04:18:39Z","updated_at":"2015-08-30T14:29:30Z","pushed_at":"2015-09-01T11:02:57Z","git_url":"git://github.com/yiisoft/yii2-gii.git","ssh_url":"git@github.com:yiisoft/yii2-gii.git","clone_url":"https://github.com/yiisoft/yii2-gii.git","svn_url":"https://github.com/yiisoft/yii2-gii","homepage":"http://www.yiiframework.com","size":12523,"stargazers_count":34,"watchers_count":34,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":25,"forks":65,"open_issues":25,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/85"},"html":{"href":"https://github.com/yiisoft/yii2-gii/pull/85"},"issue":{"href":"https://api.github.com/repos/yiisoft/yii2-gii/issues/85"},"comments":{"href":"https://api.github.com/repos/yiisoft/yii2-gii/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft/yii2-gii/statuses/7437e8056fedcdfece69af0ff148bf5525f8345a"}}}}