{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/47973242","id":47973242,"diff_hunk":"@@ -58,6 +59,7 @@ class ZkNodeChangeNotificationListener(private val zkUtils: ZkUtils,\n   def init() {\n     zkUtils.makeSurePersistentPathExists(seqNodeRoot)\n     zkUtils.zkClient.subscribeChildChanges(seqNodeRoot, NodeChangeListener)\n+    zkUtils.zkClient.subscribeStateChanges(ZkStateChangeListener)\n     processAllNotifications()","path":"core/src/main/scala/kafka/common/ZkNodeChangeNotificationListener.scala","position":24,"original_position":24,"commit_id":"10071378d38bab1bcf00aefa0ef678fdb77c8f5b","original_commit_id":"10071378d38bab1bcf00aefa0ef678fdb77c8f5b","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"body":"By the time this class's init method is called the session may or may not have initialized. if its already initialized this class's  ZkStateChangeListener'handleNewSession method will only be called if a reconnection happens or if a child changes. To avoid that delay we call the processAllNotifications() as part of init.\r\n\r\nIf the zkClient is not initialized, I believe all the calls block at ZkClient level for a session to be established so it should not be an issue.","created_at":"2015-12-17T22:53:01Z","updated_at":"2015-12-17T22:53:01Z","html_url":"https://github.com/apache/kafka/pull/679#discussion_r47973242","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/679","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/47973242"},"html":{"href":"https://github.com/apache/kafka/pull/679#discussion_r47973242"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/679"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/679","id":53763379,"html_url":"https://github.com/apache/kafka/pull/679","diff_url":"https://github.com/apache/kafka/pull/679.diff","patch_url":"https://github.com/apache/kafka/pull/679.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/679","number":679,"state":"open","locked":false,"title":"KAFKA-2547: Make DynamicConfigManager to use the ZkNodeChangeNotifica…","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"body":"…tionListener introduced as part of KAFKA-2211","created_at":"2015-12-15T21:17:13Z","updated_at":"2015-12-17T22:53:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ba64ac972a6f66eafc0dbdcee837a3e4913e9fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/679/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/679/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/679/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/10071378d38bab1bcf00aefa0ef678fdb77c8f5b","head":{"label":"Parth-Brahmbhatt:KAFKA-2547","ref":"KAFKA-2547","sha":"10071378d38bab1bcf00aefa0ef678fdb77c8f5b","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"repo":{"id":34346413,"name":"kafka","full_name":"Parth-Brahmbhatt/kafka","owner":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Parth-Brahmbhatt/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka","forks_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/forks","keys_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/teams","hooks_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/hooks","issue_events_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/events","assignees_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/tags","blobs_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/languages","stargazers_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/stargazers","contributors_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/contributors","subscribers_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/subscribers","subscription_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/subscription","commits_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/merges","archive_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/downloads","issues_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/labels{/name}","releases_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/releases{/id}","created_at":"2015-04-21T19:00:48Z","updated_at":"2015-09-10T10:18:32Z","pushed_at":"2015-12-15T21:15:33Z","git_url":"git://github.com/Parth-Brahmbhatt/kafka.git","ssh_url":"git@github.com:Parth-Brahmbhatt/kafka.git","clone_url":"https://github.com/Parth-Brahmbhatt/kafka.git","svn_url":"https://github.com/Parth-Brahmbhatt/kafka","homepage":null,"size":26640,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"0.8.2"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"9545cc88348b78f66c1c7a891449caa35f322a74","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","created_at":"2011-08-15T18:06:16Z","updated_at":"2015-12-17T18:22:55Z","pushed_at":"2015-12-17T22:32:11Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":32616,"stargazers_count":2367,"watchers_count":2367,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1403,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":124,"forks":1403,"open_issues":124,"watchers":2367,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/679"},"html":{"href":"https://github.com/apache/kafka/pull/679"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/679"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/679/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/679/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/679/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/10071378d38bab1bcf00aefa0ef678fdb77c8f5b"}}}}