{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11138","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11138/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11138/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11138/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11138","id":56689286,"number":11138,"title":"Rebalance (and fix) burning of items counted by charges","user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-05T16:03:05Z","updated_at":"2015-02-05T16:48:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11138","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11138","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11138.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11138.patch"},"body":"In master, items that are counted by charges still accumulate burn like other items. They are immediately removed when their burnt value is 3 times their (stacks') volume, but are not otherwise damaged. This doesn't have any ill effects because it only affects liquids, but it makes gauging fuel quality harder and is \"less realistic\".\r\nAnother bug in master is that gasoline and diesel don't burn, but cookoff due to bad logic.\r\n\r\nIn this PR I change burning liquids (and other count_by_charges comestibles) so that they burn gradually, depending on fire size and default stack size. Those items do not accumulate `burnt` value at all.\r\n\r\nI changed the hardcoded alcohol checking (for gin, vodka, brandy etc.) into check for alcohol material. Weak alcoholic drinks are handled by giving them alcohol and water materials and then checking for the alcohol being the only material (a bit of a placeholder here).\r\n\r\nI fixed the gasoline cookoff bug.\r\nI fixed generic (non special-cased) count_by_charge items burning too slow when in big stacks.\r\n\r\nI adjusted two values: smoke value for alcohol (down from 5 to 1) and powder burns 100 times more intensely (older values were incredibly low).\r\n\r\nFlour gets a `\"powder\"` material, so that it burns faster.\r\n\r\nEDIT: Changed gasoline and diesel check into check for new material (named it `hydrocarbons`). This new material has fire resistance 0, meaning it is once again usable by internal furnace."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/73080668","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11138#issuecomment-73080668","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11138","id":73080668,"user":{"login":"Barhandar","id":2338212,"avatar_url":"https://avatars.githubusercontent.com/u/2338212?v=3","gravatar_id":"","url":"https://api.github.com/users/Barhandar","html_url":"https://github.com/Barhandar","followers_url":"https://api.github.com/users/Barhandar/followers","following_url":"https://api.github.com/users/Barhandar/following{/other_user}","gists_url":"https://api.github.com/users/Barhandar/gists{/gist_id}","starred_url":"https://api.github.com/users/Barhandar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Barhandar/subscriptions","organizations_url":"https://api.github.com/users/Barhandar/orgs","repos_url":"https://api.github.com/users/Barhandar/repos","events_url":"https://api.github.com/users/Barhandar/events{/privacy}","received_events_url":"https://api.github.com/users/Barhandar/received_events","type":"User","site_admin":false},"created_at":"2015-02-05T16:48:12Z","updated_at":"2015-02-05T16:48:12Z","body":">Forgot about gasoline furnace, fix'd in next commit.\r\n\r\nYay! How does furnace even interact with it, though? E.g. I have 200 charges of gasoline (1 unit), I eat them, how much bionic power I get? What if 100 charges? 500?"}}