{"action":"created","comment":{"url":"https://api.github.com/repos/webrtc/adapter/pulls/comments/36587633","id":36587633,"diff_hunk":"@@ -46,7 +46,26 @@ function trace(text) {\n   }\n }\n \n-if (typeof window === 'undefined' || !window.navigator) {\n+// In a browser with support for HTMLMediaElement, define srcObject\n+// on the prototype (only once!) for attaching media streams to elements.\n+if (typeof window === 'object' && window.HTMLMediaElement &&\n+    !window.HTMLMediaElement.prototype.hasOwnProperty('srcObject')) {\n+  Object.defineProperty(window.HTMLMediaElement.prototype, 'srcObject', {\n+    get: function() {\n+      return this.mozSrcObject || this._srcObject;\n+    },\n+    set: function(stream) {\n+      if (this.mozSrcObject) {","path":"adapter.js","position":14,"original_position":14,"commit_id":"46de911619335676ec5c0f1c37c8975b7eb1010e","original_commit_id":"46de911619335676ec5c0f1c37c8975b7eb1010e","user":{"login":"fippo","id":289731,"avatar_url":"https://avatars.githubusercontent.com/u/289731?v=3","gravatar_id":"","url":"https://api.github.com/users/fippo","html_url":"https://github.com/fippo","followers_url":"https://api.github.com/users/fippo/followers","following_url":"https://api.github.com/users/fippo/following{/other_user}","gists_url":"https://api.github.com/users/fippo/gists{/gist_id}","starred_url":"https://api.github.com/users/fippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fippo/subscriptions","organizations_url":"https://api.github.com/users/fippo/orgs","repos_url":"https://api.github.com/users/fippo/repos","events_url":"https://api.github.com/users/fippo/events{/privacy}","received_events_url":"https://api.github.com/users/fippo/received_events","type":"User","site_admin":false},"body":"should this be a hasOwnProperty? By default, mozSrcObject is null","created_at":"2015-08-09T12:57:01Z","updated_at":"2015-08-09T12:57:01Z","html_url":"https://github.com/webrtc/adapter/pull/119#discussion_r36587633","pull_request_url":"https://api.github.com/repos/webrtc/adapter/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/comments/36587633"},"html":{"href":"https://github.com/webrtc/adapter/pull/119#discussion_r36587633"},"pull_request":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/119"}}},"pull_request":{"url":"https://api.github.com/repos/webrtc/adapter/pulls/119","id":41802450,"html_url":"https://github.com/webrtc/adapter/pull/119","diff_url":"https://github.com/webrtc/adapter/pull/119.diff","patch_url":"https://github.com/webrtc/adapter/pull/119.patch","issue_url":"https://api.github.com/repos/webrtc/adapter/issues/119","number":119,"state":"open","locked":false,"title":"Make srcObject polyfill more generic","user":{"login":"xdumaine","id":833911,"avatar_url":"https://avatars.githubusercontent.com/u/833911?v=3","gravatar_id":"","url":"https://api.github.com/users/xdumaine","html_url":"https://github.com/xdumaine","followers_url":"https://api.github.com/users/xdumaine/followers","following_url":"https://api.github.com/users/xdumaine/following{/other_user}","gists_url":"https://api.github.com/users/xdumaine/gists{/gist_id}","starred_url":"https://api.github.com/users/xdumaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdumaine/subscriptions","organizations_url":"https://api.github.com/users/xdumaine/orgs","repos_url":"https://api.github.com/users/xdumaine/repos","events_url":"https://api.github.com/users/xdumaine/events{/privacy}","received_events_url":"https://api.github.com/users/xdumaine/received_events","type":"User","site_admin":false},"body":"This will help with firefox unprefixing srcObject h/t @fippo ","created_at":"2015-08-06T15:41:29Z","updated_at":"2015-08-09T12:57:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e5b70efcdae661eeb5968dd37dddc379acfdc28","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/webrtc/adapter/pulls/119/commits","review_comments_url":"https://api.github.com/repos/webrtc/adapter/pulls/119/comments","review_comment_url":"https://api.github.com/repos/webrtc/adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webrtc/adapter/issues/119/comments","statuses_url":"https://api.github.com/repos/webrtc/adapter/statuses/46de911619335676ec5c0f1c37c8975b7eb1010e","head":{"label":"xdumaine:srcObject","ref":"srcObject","sha":"46de911619335676ec5c0f1c37c8975b7eb1010e","user":{"login":"xdumaine","id":833911,"avatar_url":"https://avatars.githubusercontent.com/u/833911?v=3","gravatar_id":"","url":"https://api.github.com/users/xdumaine","html_url":"https://github.com/xdumaine","followers_url":"https://api.github.com/users/xdumaine/followers","following_url":"https://api.github.com/users/xdumaine/following{/other_user}","gists_url":"https://api.github.com/users/xdumaine/gists{/gist_id}","starred_url":"https://api.github.com/users/xdumaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdumaine/subscriptions","organizations_url":"https://api.github.com/users/xdumaine/orgs","repos_url":"https://api.github.com/users/xdumaine/repos","events_url":"https://api.github.com/users/xdumaine/events{/privacy}","received_events_url":"https://api.github.com/users/xdumaine/received_events","type":"User","site_admin":false},"repo":{"id":38447214,"name":"adapter","full_name":"xdumaine/adapter","owner":{"login":"xdumaine","id":833911,"avatar_url":"https://avatars.githubusercontent.com/u/833911?v=3","gravatar_id":"","url":"https://api.github.com/users/xdumaine","html_url":"https://github.com/xdumaine","followers_url":"https://api.github.com/users/xdumaine/followers","following_url":"https://api.github.com/users/xdumaine/following{/other_user}","gists_url":"https://api.github.com/users/xdumaine/gists{/gist_id}","starred_url":"https://api.github.com/users/xdumaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdumaine/subscriptions","organizations_url":"https://api.github.com/users/xdumaine/orgs","repos_url":"https://api.github.com/users/xdumaine/repos","events_url":"https://api.github.com/users/xdumaine/events{/privacy}","received_events_url":"https://api.github.com/users/xdumaine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xdumaine/adapter","description":"Shim to insulate apps from spec changes and prefix differences.","fork":true,"url":"https://api.github.com/repos/xdumaine/adapter","forks_url":"https://api.github.com/repos/xdumaine/adapter/forks","keys_url":"https://api.github.com/repos/xdumaine/adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xdumaine/adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xdumaine/adapter/teams","hooks_url":"https://api.github.com/repos/xdumaine/adapter/hooks","issue_events_url":"https://api.github.com/repos/xdumaine/adapter/issues/events{/number}","events_url":"https://api.github.com/repos/xdumaine/adapter/events","assignees_url":"https://api.github.com/repos/xdumaine/adapter/assignees{/user}","branches_url":"https://api.github.com/repos/xdumaine/adapter/branches{/branch}","tags_url":"https://api.github.com/repos/xdumaine/adapter/tags","blobs_url":"https://api.github.com/repos/xdumaine/adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xdumaine/adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xdumaine/adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/xdumaine/adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xdumaine/adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/xdumaine/adapter/languages","stargazers_url":"https://api.github.com/repos/xdumaine/adapter/stargazers","contributors_url":"https://api.github.com/repos/xdumaine/adapter/contributors","subscribers_url":"https://api.github.com/repos/xdumaine/adapter/subscribers","subscription_url":"https://api.github.com/repos/xdumaine/adapter/subscription","commits_url":"https://api.github.com/repos/xdumaine/adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/xdumaine/adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/xdumaine/adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/xdumaine/adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/xdumaine/adapter/contents/{+path}","compare_url":"https://api.github.com/repos/xdumaine/adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xdumaine/adapter/merges","archive_url":"https://api.github.com/repos/xdumaine/adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xdumaine/adapter/downloads","issues_url":"https://api.github.com/repos/xdumaine/adapter/issues{/number}","pulls_url":"https://api.github.com/repos/xdumaine/adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/xdumaine/adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/xdumaine/adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xdumaine/adapter/labels{/name}","releases_url":"https://api.github.com/repos/xdumaine/adapter/releases{/id}","created_at":"2015-07-02T17:35:03Z","updated_at":"2015-07-02T17:35:03Z","pushed_at":"2015-08-07T20:23:54Z","git_url":"git://github.com/xdumaine/adapter.git","ssh_url":"git@github.com:xdumaine/adapter.git","clone_url":"https://github.com/xdumaine/adapter.git","svn_url":"https://github.com/xdumaine/adapter","homepage":null,"size":2886,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webrtc:master","ref":"master","sha":"b40ca66edbe42092cb609d59777a7d209b7d115e","user":{"login":"webrtc","id":10526312,"avatar_url":"https://avatars.githubusercontent.com/u/10526312?v=3","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"repo":{"id":30027163,"name":"adapter","full_name":"webrtc/adapter","owner":{"login":"webrtc","id":10526312,"avatar_url":"https://avatars.githubusercontent.com/u/10526312?v=3","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webrtc/adapter","description":"Shim to insulate apps from spec changes and prefix differences.","fork":false,"url":"https://api.github.com/repos/webrtc/adapter","forks_url":"https://api.github.com/repos/webrtc/adapter/forks","keys_url":"https://api.github.com/repos/webrtc/adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webrtc/adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webrtc/adapter/teams","hooks_url":"https://api.github.com/repos/webrtc/adapter/hooks","issue_events_url":"https://api.github.com/repos/webrtc/adapter/issues/events{/number}","events_url":"https://api.github.com/repos/webrtc/adapter/events","assignees_url":"https://api.github.com/repos/webrtc/adapter/assignees{/user}","branches_url":"https://api.github.com/repos/webrtc/adapter/branches{/branch}","tags_url":"https://api.github.com/repos/webrtc/adapter/tags","blobs_url":"https://api.github.com/repos/webrtc/adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webrtc/adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webrtc/adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/webrtc/adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webrtc/adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/webrtc/adapter/languages","stargazers_url":"https://api.github.com/repos/webrtc/adapter/stargazers","contributors_url":"https://api.github.com/repos/webrtc/adapter/contributors","subscribers_url":"https://api.github.com/repos/webrtc/adapter/subscribers","subscription_url":"https://api.github.com/repos/webrtc/adapter/subscription","commits_url":"https://api.github.com/repos/webrtc/adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/webrtc/adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/webrtc/adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/webrtc/adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/webrtc/adapter/contents/{+path}","compare_url":"https://api.github.com/repos/webrtc/adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webrtc/adapter/merges","archive_url":"https://api.github.com/repos/webrtc/adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webrtc/adapter/downloads","issues_url":"https://api.github.com/repos/webrtc/adapter/issues{/number}","pulls_url":"https://api.github.com/repos/webrtc/adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/webrtc/adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/webrtc/adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webrtc/adapter/labels{/name}","releases_url":"https://api.github.com/repos/webrtc/adapter/releases{/id}","created_at":"2015-01-29T15:41:40Z","updated_at":"2015-08-07T19:05:41Z","pushed_at":"2015-08-07T20:23:55Z","git_url":"git://github.com/webrtc/adapter.git","ssh_url":"git@github.com:webrtc/adapter.git","clone_url":"https://github.com/webrtc/adapter.git","svn_url":"https://github.com/webrtc/adapter","homepage":null,"size":3881,"stargazers_count":93,"watchers_count":93,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":24,"forks":31,"open_issues":24,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/119"},"html":{"href":"https://github.com/webrtc/adapter/pull/119"},"issue":{"href":"https://api.github.com/repos/webrtc/adapter/issues/119"},"comments":{"href":"https://api.github.com/repos/webrtc/adapter/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/webrtc/adapter/statuses/46de911619335676ec5c0f1c37c8975b7eb1010e"}}}}