{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/12750","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12750/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12750/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12750/events","html_url":"https://github.com/cms-sw/cmssw/pull/12750","id":121517434,"number":12750,"title":"Fix addUserInt and addUserFloat with multiple values on the same key","user":{"login":"gpetruc","id":4643655,"avatar_url":"https://avatars.githubusercontent.com/u/4643655?v=3","gravatar_id":"","url":"https://api.github.com/users/gpetruc","html_url":"https://github.com/gpetruc","followers_url":"https://api.github.com/users/gpetruc/followers","following_url":"https://api.github.com/users/gpetruc/following{/other_user}","gists_url":"https://api.github.com/users/gpetruc/gists{/gist_id}","starred_url":"https://api.github.com/users/gpetruc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpetruc/subscriptions","organizations_url":"https://api.github.com/users/gpetruc/orgs","repos_url":"https://api.github.com/users/gpetruc/repos","events_url":"https://api.github.com/users/gpetruc/events{/privacy}","received_events_url":"https://api.github.com/users/gpetruc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/core-pending","name":"core-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_0_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57/labels","id":1362157,"number":57,"title":"Next CMSSW_8_0_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":394,"state":"open","created_at":"2015-10-18T08:35:44Z","updated_at":"2015-12-17T13:04:58Z","due_on":null,"closed_at":null},"comments":30,"created_at":"2015-12-10T15:54:04Z","updated_at":"2015-12-17T13:05:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12750","html_url":"https://github.com/cms-sw/cmssw/pull/12750","diff_url":"https://github.com/cms-sw/cmssw/pull/12750.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/12750.patch"},"body":"#11574 didn't implement correctly the cases of multiple values on the same key:\r\n * `addUserFloat` was ignoring the `overwrite` parameter\r\n * the `overwrite` parameter was not present in the `addUserInt`, only in `addUserFloat`\r\n * when not overwriting, the code was inserting the new value but not inserting a duplicate label, that was causing the label vector and value vector to go off sync.\r\n\r\nShould not affect MiniAOD production nor MiniAOD analysis, since I believe in those workflows we never write multiple values with the same key.\r\n\r\nIf the investigation of https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3435.html reveals further problems, I will add them in this PR.\r\n\r\nPlease have a look, if satisfactory I can make also 76X backport and, if needed by HI, 75X backport.\r\n\r\n@lgray "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/165447619","html_url":"https://github.com/cms-sw/cmssw/pull/12750#issuecomment-165447619","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12750","id":165447619,"user":{"login":"Dr15Jones","id":3757616,"avatar_url":"https://avatars.githubusercontent.com/u/3757616?v=3","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T13:05:45Z","updated_at":"2015-12-17T13:05:45Z","body":"+1\r\nThe OwnVector changes are fine. \r\nThe test failure is unrelated and comes from the IB. "}}