{"action":"created","issue":{"url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/225","labels_url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/225/labels{/name}","comments_url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/225/comments","events_url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/225/events","html_url":"https://github.com/chris-belcher/joinmarket/pull/225","id":105288297,"number":225,"title":"Crude recovery by taker from unresponsive makers","user":{"login":"chris-belcher","id":8398185,"avatar_url":"https://avatars.githubusercontent.com/u/8398185?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-belcher","html_url":"https://github.com/chris-belcher","followers_url":"https://api.github.com/users/chris-belcher/followers","following_url":"https://api.github.com/users/chris-belcher/following{/other_user}","gists_url":"https://api.github.com/users/chris-belcher/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-belcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-belcher/subscriptions","organizations_url":"https://api.github.com/users/chris-belcher/orgs","repos_url":"https://api.github.com/users/chris-belcher/repos","events_url":"https://api.github.com/users/chris-belcher/events{/privacy}","received_events_url":"https://api.github.com/users/chris-belcher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-09-08T02:26:22Z","updated_at":"2015-09-14T23:40:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chris-belcher/joinmarket/pulls/225","html_url":"https://github.com/chris-belcher/joinmarket/pull/225","diff_url":"https://github.com/chris-belcher/joinmarket/pull/225.diff","patch_url":"https://github.com/chris-belcher/joinmarket/pull/225.patch"},"body":"Implemented changes suggested in #166\r\n\r\nA new thread is started for each CoinJoinTX object, there is a threading condition lock which passes notifications between the two threads. Currently the timeout for maker non-reply is 10 seconds.\r\n\r\nIf a maker doesn't reply, it will be ignored for the rest of lifetime of the Taker instance.\r\n\r\n`sendpayment.py` and `tumbler.py` have been made to work with this.\r\n\r\nTesting welcome. I've tested this on regtest with tumbler, it was able to complete it's run even though one maker never responded to either !fill, !auth or !tx\r\n\r\nSecond attempt at merging, given the derping with the other branch."},"comment":{"url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/comments/140233979","html_url":"https://github.com/chris-belcher/joinmarket/pull/225#issuecomment-140233979","issue_url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/225","id":140233979,"user":{"login":"tailsjoin","id":13171342,"avatar_url":"https://avatars.githubusercontent.com/u/13171342?v=3","gravatar_id":"","url":"https://api.github.com/users/tailsjoin","html_url":"https://github.com/tailsjoin","followers_url":"https://api.github.com/users/tailsjoin/followers","following_url":"https://api.github.com/users/tailsjoin/following{/other_user}","gists_url":"https://api.github.com/users/tailsjoin/gists{/gist_id}","starred_url":"https://api.github.com/users/tailsjoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tailsjoin/subscriptions","organizations_url":"https://api.github.com/users/tailsjoin/orgs","repos_url":"https://api.github.com/users/tailsjoin/repos","events_url":"https://api.github.com/users/tailsjoin/events{/privacy}","received_events_url":"https://api.github.com/users/tailsjoin/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T23:40:18Z","updated_at":"2015-09-14T23:40:18Z","body":"I don't have this log anymore. If it happens again I'll get it to you. "}}