{"action":"opened","number":1099,"pull_request":{"url":"https://api.github.com/repos/ProgVal/Limnoria/pulls/1099","id":34429026,"html_url":"https://github.com/ProgVal/Limnoria/pull/1099","diff_url":"https://github.com/ProgVal/Limnoria/pull/1099.diff","patch_url":"https://github.com/ProgVal/Limnoria/pull/1099.patch","issue_url":"https://api.github.com/repos/ProgVal/Limnoria/issues/1099","number":1099,"state":"open","locked":false,"title":"GPG version check","user":{"login":"Hasimir","id":2611615,"avatar_url":"https://avatars.githubusercontent.com/u/2611615?v=3","gravatar_id":"","url":"https://api.github.com/users/Hasimir","html_url":"https://github.com/Hasimir","followers_url":"https://api.github.com/users/Hasimir/followers","following_url":"https://api.github.com/users/Hasimir/following{/other_user}","gists_url":"https://api.github.com/users/Hasimir/gists{/gist_id}","starred_url":"https://api.github.com/users/Hasimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hasimir/subscriptions","organizations_url":"https://api.github.com/users/Hasimir/orgs","repos_url":"https://api.github.com/users/Hasimir/repos","events_url":"https://api.github.com/users/Hasimir/events{/privacy}","received_events_url":"https://api.github.com/users/Hasimir/received_events","type":"User","site_admin":false},"body":"With the release of GPG 2.1.x as stable (relatively, there are still issues with it), it is now possible for legitimate, but conflicting gnupg.py configuration to be required.  This patch locates the GPG executable on a system (in the $PATH) and determines which series of GPG it is (1.4.x, 2.0.x or 2.1.x) and then sets the variables required by gnupg.py accordingly.\r\n\r\nThough it checks for gpg.exe (as in gpg4usb) and gpg2.exe (as in gpg4win), there has been no Windows testing and there is no indication that it will work (it may not due to the reliance on $PATH).\r\n\r\nMinimal testing indicates there is not, as was first suspected, a conflict between the keyring global set in src/gpg.py and the keyring value specified when gnupg.GPG is called.  There are, however, no guarantees that this will always be the case or that it will prove true under all scenarios.\r\n\r\nPlease note the **major** changes in GPG 2.1.x which include handing control of the keyrings over to gpg-agent and changing the public keyring format.  While this code presently favours the GPG 1.4.x series, which is still the most common on POSIX systems, this must be temporary.  The reason being that a migration to ECC keys over the next few years will occur and the ECC code in the more recent GPG series will **not** be backported to GPG 1.4.x.  Additionally, the current standard for OpenPGP, RFC 4880, is currently under review with the aim to release a new OpenPGP RFC in anticipation of the ECC migration.  The new RFC **will** deprecate a number of functions and algorithms in GPG 1.4.x.\r\n\r\nThis definitely requires additional testing before merging with master, but it is based on existing code I've been running with GPG 1.4.19 and 2.1.3.  It should theoretically work without trouble and is not complex.\r\n","created_at":"2015-04-30T05:14:00Z","updated_at":"2015-04-30T05:14:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ProgVal/Limnoria/pulls/1099/commits","review_comments_url":"https://api.github.com/repos/ProgVal/Limnoria/pulls/1099/comments","review_comment_url":"https://api.github.com/repos/ProgVal/Limnoria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProgVal/Limnoria/issues/1099/comments","statuses_url":"https://api.github.com/repos/ProgVal/Limnoria/statuses/395767aff6dacb194883feafbc343ecb69dd2f7c","head":{"label":"Hasimir:gpg-ver-check","ref":"gpg-ver-check","sha":"395767aff6dacb194883feafbc343ecb69dd2f7c","user":{"login":"Hasimir","id":2611615,"avatar_url":"https://avatars.githubusercontent.com/u/2611615?v=3","gravatar_id":"","url":"https://api.github.com/users/Hasimir","html_url":"https://github.com/Hasimir","followers_url":"https://api.github.com/users/Hasimir/followers","following_url":"https://api.github.com/users/Hasimir/following{/other_user}","gists_url":"https://api.github.com/users/Hasimir/gists{/gist_id}","starred_url":"https://api.github.com/users/Hasimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hasimir/subscriptions","organizations_url":"https://api.github.com/users/Hasimir/orgs","repos_url":"https://api.github.com/users/Hasimir/repos","events_url":"https://api.github.com/users/Hasimir/events{/privacy}","received_events_url":"https://api.github.com/users/Hasimir/received_events","type":"User","site_admin":false},"repo":{"id":29403914,"name":"Limnoria","full_name":"Hasimir/Limnoria","owner":{"login":"Hasimir","id":2611615,"avatar_url":"https://avatars.githubusercontent.com/u/2611615?v=3","gravatar_id":"","url":"https://api.github.com/users/Hasimir","html_url":"https://github.com/Hasimir","followers_url":"https://api.github.com/users/Hasimir/followers","following_url":"https://api.github.com/users/Hasimir/following{/other_user}","gists_url":"https://api.github.com/users/Hasimir/gists{/gist_id}","starred_url":"https://api.github.com/users/Hasimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hasimir/subscriptions","organizations_url":"https://api.github.com/users/Hasimir/orgs","repos_url":"https://api.github.com/users/Hasimir/repos","events_url":"https://api.github.com/users/Hasimir/events{/privacy}","received_events_url":"https://api.github.com/users/Hasimir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hasimir/Limnoria","description":"A modified version of Supybot (an IRC bot) with translations (fr, fi, it, hu, de, ...), embedded web server, bug fixes, and several other enhancements and bug fixes","fork":true,"url":"https://api.github.com/repos/Hasimir/Limnoria","forks_url":"https://api.github.com/repos/Hasimir/Limnoria/forks","keys_url":"https://api.github.com/repos/Hasimir/Limnoria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hasimir/Limnoria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hasimir/Limnoria/teams","hooks_url":"https://api.github.com/repos/Hasimir/Limnoria/hooks","issue_events_url":"https://api.github.com/repos/Hasimir/Limnoria/issues/events{/number}","events_url":"https://api.github.com/repos/Hasimir/Limnoria/events","assignees_url":"https://api.github.com/repos/Hasimir/Limnoria/assignees{/user}","branches_url":"https://api.github.com/repos/Hasimir/Limnoria/branches{/branch}","tags_url":"https://api.github.com/repos/Hasimir/Limnoria/tags","blobs_url":"https://api.github.com/repos/Hasimir/Limnoria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hasimir/Limnoria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hasimir/Limnoria/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hasimir/Limnoria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hasimir/Limnoria/statuses/{sha}","languages_url":"https://api.github.com/repos/Hasimir/Limnoria/languages","stargazers_url":"https://api.github.com/repos/Hasimir/Limnoria/stargazers","contributors_url":"https://api.github.com/repos/Hasimir/Limnoria/contributors","subscribers_url":"https://api.github.com/repos/Hasimir/Limnoria/subscribers","subscription_url":"https://api.github.com/repos/Hasimir/Limnoria/subscription","commits_url":"https://api.github.com/repos/Hasimir/Limnoria/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hasimir/Limnoria/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hasimir/Limnoria/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hasimir/Limnoria/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hasimir/Limnoria/contents/{+path}","compare_url":"https://api.github.com/repos/Hasimir/Limnoria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hasimir/Limnoria/merges","archive_url":"https://api.github.com/repos/Hasimir/Limnoria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hasimir/Limnoria/downloads","issues_url":"https://api.github.com/repos/Hasimir/Limnoria/issues{/number}","pulls_url":"https://api.github.com/repos/Hasimir/Limnoria/pulls{/number}","milestones_url":"https://api.github.com/repos/Hasimir/Limnoria/milestones{/number}","notifications_url":"https://api.github.com/repos/Hasimir/Limnoria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hasimir/Limnoria/labels{/name}","releases_url":"https://api.github.com/repos/Hasimir/Limnoria/releases{/id}","created_at":"2015-01-17T20:05:32Z","updated_at":"2015-04-30T03:14:09Z","pushed_at":"2015-04-30T04:53:53Z","git_url":"git://github.com/Hasimir/Limnoria.git","ssh_url":"git@github.com:Hasimir/Limnoria.git","clone_url":"https://github.com/Hasimir/Limnoria.git","svn_url":"https://github.com/Hasimir/Limnoria","homepage":"http://supybot.aperio.fr","size":32411,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ProgVal:testing","ref":"testing","sha":"b720978a3332793e36d27f0a6731be71349734ed","user":{"login":"ProgVal","id":406946,"avatar_url":"https://avatars.githubusercontent.com/u/406946?v=3","gravatar_id":"","url":"https://api.github.com/users/ProgVal","html_url":"https://github.com/ProgVal","followers_url":"https://api.github.com/users/ProgVal/followers","following_url":"https://api.github.com/users/ProgVal/following{/other_user}","gists_url":"https://api.github.com/users/ProgVal/gists{/gist_id}","starred_url":"https://api.github.com/users/ProgVal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProgVal/subscriptions","organizations_url":"https://api.github.com/users/ProgVal/orgs","repos_url":"https://api.github.com/users/ProgVal/repos","events_url":"https://api.github.com/users/ProgVal/events{/privacy}","received_events_url":"https://api.github.com/users/ProgVal/received_events","type":"User","site_admin":false},"repo":{"id":1663788,"name":"Limnoria","full_name":"ProgVal/Limnoria","owner":{"login":"ProgVal","id":406946,"avatar_url":"https://avatars.githubusercontent.com/u/406946?v=3","gravatar_id":"","url":"https://api.github.com/users/ProgVal","html_url":"https://github.com/ProgVal","followers_url":"https://api.github.com/users/ProgVal/followers","following_url":"https://api.github.com/users/ProgVal/following{/other_user}","gists_url":"https://api.github.com/users/ProgVal/gists{/gist_id}","starred_url":"https://api.github.com/users/ProgVal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProgVal/subscriptions","organizations_url":"https://api.github.com/users/ProgVal/orgs","repos_url":"https://api.github.com/users/ProgVal/repos","events_url":"https://api.github.com/users/ProgVal/events{/privacy}","received_events_url":"https://api.github.com/users/ProgVal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ProgVal/Limnoria","description":"A modified version of Supybot (an IRC bot) with translations (fr, fi, it, hu, de, ...), embedded web server, IRCv3 support, and several other enhancements and bug fixes","fork":false,"url":"https://api.github.com/repos/ProgVal/Limnoria","forks_url":"https://api.github.com/repos/ProgVal/Limnoria/forks","keys_url":"https://api.github.com/repos/ProgVal/Limnoria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProgVal/Limnoria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProgVal/Limnoria/teams","hooks_url":"https://api.github.com/repos/ProgVal/Limnoria/hooks","issue_events_url":"https://api.github.com/repos/ProgVal/Limnoria/issues/events{/number}","events_url":"https://api.github.com/repos/ProgVal/Limnoria/events","assignees_url":"https://api.github.com/repos/ProgVal/Limnoria/assignees{/user}","branches_url":"https://api.github.com/repos/ProgVal/Limnoria/branches{/branch}","tags_url":"https://api.github.com/repos/ProgVal/Limnoria/tags","blobs_url":"https://api.github.com/repos/ProgVal/Limnoria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProgVal/Limnoria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProgVal/Limnoria/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProgVal/Limnoria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProgVal/Limnoria/statuses/{sha}","languages_url":"https://api.github.com/repos/ProgVal/Limnoria/languages","stargazers_url":"https://api.github.com/repos/ProgVal/Limnoria/stargazers","contributors_url":"https://api.github.com/repos/ProgVal/Limnoria/contributors","subscribers_url":"https://api.github.com/repos/ProgVal/Limnoria/subscribers","subscription_url":"https://api.github.com/repos/ProgVal/Limnoria/subscription","commits_url":"https://api.github.com/repos/ProgVal/Limnoria/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProgVal/Limnoria/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProgVal/Limnoria/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProgVal/Limnoria/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProgVal/Limnoria/contents/{+path}","compare_url":"https://api.github.com/repos/ProgVal/Limnoria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProgVal/Limnoria/merges","archive_url":"https://api.github.com/repos/ProgVal/Limnoria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProgVal/Limnoria/downloads","issues_url":"https://api.github.com/repos/ProgVal/Limnoria/issues{/number}","pulls_url":"https://api.github.com/repos/ProgVal/Limnoria/pulls{/number}","milestones_url":"https://api.github.com/repos/ProgVal/Limnoria/milestones{/number}","notifications_url":"https://api.github.com/repos/ProgVal/Limnoria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProgVal/Limnoria/labels{/name}","releases_url":"https://api.github.com/repos/ProgVal/Limnoria/releases{/id}","created_at":"2011-04-26T08:18:00Z","updated_at":"2015-04-29T08:08:01Z","pushed_at":"2015-04-29T08:08:14Z","git_url":"git://github.com/ProgVal/Limnoria.git","ssh_url":"git@github.com:ProgVal/Limnoria.git","clone_url":"https://github.com/ProgVal/Limnoria.git","svn_url":"https://github.com/ProgVal/Limnoria","homepage":"http://supybot.aperio.fr","size":39142,"stargazers_count":181,"watchers_count":181,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":192,"forks":81,"open_issues":192,"watchers":181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProgVal/Limnoria/pulls/1099"},"html":{"href":"https://github.com/ProgVal/Limnoria/pull/1099"},"issue":{"href":"https://api.github.com/repos/ProgVal/Limnoria/issues/1099"},"comments":{"href":"https://api.github.com/repos/ProgVal/Limnoria/issues/1099/comments"},"review_comments":{"href":"https://api.github.com/repos/ProgVal/Limnoria/pulls/1099/comments"},"review_comment":{"href":"https://api.github.com/repos/ProgVal/Limnoria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProgVal/Limnoria/pulls/1099/commits"},"statuses":{"href":"https://api.github.com/repos/ProgVal/Limnoria/statuses/395767aff6dacb194883feafbc343ecb69dd2f7c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":42,"deletions":1,"changed_files":1}}