{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments/47273568","id":47273568,"diff_hunk":"@@ -2092,6 +2068,35 @@ public void populateDAG(LogicalPlan dag)\n \n   }\n \n+  private void populateOperators(AppConf appConf, LogicalPlan dag, Map<OperatorConf, Operator> nodeMap)","path":"engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlanConfiguration.java","position":null,"original_position":75,"commit_id":"7a02a9b410b7330fd7a7e14107f049f393cd5e9c","original_commit_id":"cd6085dd0bb32d610fb84349fd5b3b869f056326","user":{"login":"tweise","id":263695,"avatar_url":"https://avatars.githubusercontent.com/u/263695?v=3","gravatar_id":"","url":"https://api.github.com/users/tweise","html_url":"https://github.com/tweise","followers_url":"https://api.github.com/users/tweise/followers","following_url":"https://api.github.com/users/tweise/following{/other_user}","gists_url":"https://api.github.com/users/tweise/gists{/gist_id}","starred_url":"https://api.github.com/users/tweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweise/subscriptions","organizations_url":"https://api.github.com/users/tweise/orgs","repos_url":"https://api.github.com/users/tweise/repos","events_url":"https://api.github.com/users/tweise/events{/privacy}","received_events_url":"https://api.github.com/users/tweise/received_events","type":"User","site_admin":false},"body":"Thanks, there is no rule that says a method can only have 100 lines. If there is a good case for refactor, then do it as separate change, don't mix it with an already giant and difficult to review pull request. ","created_at":"2015-12-10T19:36:51Z","updated_at":"2015-12-10T19:36:51Z","html_url":"https://github.com/apache/incubator-apex-core/pull/148#discussion_r47273568","pull_request_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/148","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments/47273568"},"html":{"href":"https://github.com/apache/incubator-apex-core/pull/148#discussion_r47273568"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/148"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/148","id":49247194,"html_url":"https://github.com/apache/incubator-apex-core/pull/148","diff_url":"https://github.com/apache/incubator-apex-core/pull/148.diff","patch_url":"https://github.com/apache/incubator-apex-core/pull/148.patch","issue_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/148","number":148,"state":"open","locked":false,"title":"APEX-103: Add module and dag interface in API","user":{"login":"chinmaykolhatkar","id":12393897,"avatar_url":"https://avatars.githubusercontent.com/u/12393897?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmaykolhatkar","html_url":"https://github.com/chinmaykolhatkar","followers_url":"https://api.github.com/users/chinmaykolhatkar/followers","following_url":"https://api.github.com/users/chinmaykolhatkar/following{/other_user}","gists_url":"https://api.github.com/users/chinmaykolhatkar/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaykolhatkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaykolhatkar/subscriptions","organizations_url":"https://api.github.com/users/chinmaykolhatkar/orgs","repos_url":"https://api.github.com/users/chinmaykolhatkar/repos","events_url":"https://api.github.com/users/chinmaykolhatkar/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaykolhatkar/received_events","type":"User","site_admin":false},"body":"- Added module interface and module meta.\r\n- Expanding DAG at logical plan level.\r\n- Exposing of properties of module and setting module properties from DAG.\r\n- Added references of parent module meta in operator, stream and module meta.\r\n- Added proxy ports for using in Modules.\r\n- Added REST APIs for modules for logicalPlan and also corresponding dtcli changes.\r\n- Added Test application for Module having all aboe fetures.\r\n- Added unit tests for properties, module expansion, and connecting streams.\r\n\r\n@vrozov , @tweise , @PramodSSImmaneni , @sandeepdeshmukh : Please review","created_at":"2015-10-30T09:27:29Z","updated_at":"2015-12-10T19:36:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53bc0c3d5a21fc93db167cf9865171024d800d44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/148/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/148/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/148/comments","statuses_url":"https://api.github.com/repos/apache/incubator-apex-core/statuses/7a02a9b410b7330fd7a7e14107f049f393cd5e9c","head":{"label":"chinmaykolhatkar:feature-module","ref":"feature-module","sha":"7a02a9b410b7330fd7a7e14107f049f393cd5e9c","user":{"login":"chinmaykolhatkar","id":12393897,"avatar_url":"https://avatars.githubusercontent.com/u/12393897?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmaykolhatkar","html_url":"https://github.com/chinmaykolhatkar","followers_url":"https://api.github.com/users/chinmaykolhatkar/followers","following_url":"https://api.github.com/users/chinmaykolhatkar/following{/other_user}","gists_url":"https://api.github.com/users/chinmaykolhatkar/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaykolhatkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaykolhatkar/subscriptions","organizations_url":"https://api.github.com/users/chinmaykolhatkar/orgs","repos_url":"https://api.github.com/users/chinmaykolhatkar/repos","events_url":"https://api.github.com/users/chinmaykolhatkar/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaykolhatkar/received_events","type":"User","site_admin":false},"repo":{"id":43486466,"name":"incubator-apex-core","full_name":"chinmaykolhatkar/incubator-apex-core","owner":{"login":"chinmaykolhatkar","id":12393897,"avatar_url":"https://avatars.githubusercontent.com/u/12393897?v=3","gravatar_id":"","url":"https://api.github.com/users/chinmaykolhatkar","html_url":"https://github.com/chinmaykolhatkar","followers_url":"https://api.github.com/users/chinmaykolhatkar/followers","following_url":"https://api.github.com/users/chinmaykolhatkar/following{/other_user}","gists_url":"https://api.github.com/users/chinmaykolhatkar/gists{/gist_id}","starred_url":"https://api.github.com/users/chinmaykolhatkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinmaykolhatkar/subscriptions","organizations_url":"https://api.github.com/users/chinmaykolhatkar/orgs","repos_url":"https://api.github.com/users/chinmaykolhatkar/repos","events_url":"https://api.github.com/users/chinmaykolhatkar/events{/privacy}","received_events_url":"https://api.github.com/users/chinmaykolhatkar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chinmaykolhatkar/incubator-apex-core","description":"Mirror of Apache Apex core (Incubating)","fork":true,"url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core","forks_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/forks","keys_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/teams","hooks_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/hooks","issue_events_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/events","assignees_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/tags","blobs_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/languages","stargazers_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/stargazers","contributors_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/contributors","subscribers_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/subscribers","subscription_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/subscription","commits_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/merges","archive_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/downloads","issues_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/labels{/name}","releases_url":"https://api.github.com/repos/chinmaykolhatkar/incubator-apex-core/releases{/id}","created_at":"2015-10-01T08:42:56Z","updated_at":"2015-10-01T08:43:00Z","pushed_at":"2015-12-10T19:04:39Z","git_url":"git://github.com/chinmaykolhatkar/incubator-apex-core.git","ssh_url":"git@github.com:chinmaykolhatkar/incubator-apex-core.git","clone_url":"https://github.com/chinmaykolhatkar/incubator-apex-core.git","svn_url":"https://github.com/chinmaykolhatkar/incubator-apex-core","homepage":null,"size":11129,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:feature-module","ref":"feature-module","sha":"b85de3d7b73b1219a1243b152cfdfc8ae62a188d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":41348333,"name":"incubator-apex-core","full_name":"apache/incubator-apex-core","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-apex-core","description":"Mirror of Apache Apex core (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-apex-core","forks_url":"https://api.github.com/repos/apache/incubator-apex-core/forks","keys_url":"https://api.github.com/repos/apache/incubator-apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-apex-core/teams","hooks_url":"https://api.github.com/repos/apache/incubator-apex-core/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-apex-core/events","assignees_url":"https://api.github.com/repos/apache/incubator-apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-apex-core/tags","blobs_url":"https://api.github.com/repos/apache/incubator-apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-apex-core/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-apex-core/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-apex-core/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-apex-core/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-apex-core/subscription","commits_url":"https://api.github.com/repos/apache/incubator-apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-apex-core/merges","archive_url":"https://api.github.com/repos/apache/incubator-apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-apex-core/downloads","issues_url":"https://api.github.com/repos/apache/incubator-apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-apex-core/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-apex-core/releases{/id}","created_at":"2015-08-25T07:00:05Z","updated_at":"2015-12-09T06:04:19Z","pushed_at":"2015-12-10T19:32:42Z","git_url":"git://github.com/apache/incubator-apex-core.git","ssh_url":"git@github.com:apache/incubator-apex-core.git","clone_url":"https://github.com/apache/incubator-apex-core.git","svn_url":"https://github.com/apache/incubator-apex-core","homepage":null,"size":11305,"stargazers_count":41,"watchers_count":41,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":"git://git.apache.org/incubator-apex-core.git","open_issues_count":12,"forks":49,"open_issues":12,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/148"},"html":{"href":"https://github.com/apache/incubator-apex-core/pull/148"},"issue":{"href":"https://api.github.com/repos/apache/incubator-apex-core/issues/148"},"comments":{"href":"https://api.github.com/repos/apache/incubator-apex-core/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-apex-core/statuses/7a02a9b410b7330fd7a7e14107f049f393cd5e9c"}}}}