{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/comments/35646527","id":35646527,"diff_hunk":"@@ -28,29 +36,26 @@ function ($, bloomfilter) {\n     return regex.test(password);\n   }\n \n-  return function checkPasswordStrength(password, callback) {\n-    if (password.length < 8) {\n-      return;\n-    }\n-    var bool = false;\n-    var strong = strengthCheck(password.toString());\n-\n-    if (strong) {\n-      // Only if the password has a chance of being strong do we check with the bloom filter\n-      // else, simply reject the password. This helps us to not store all-alpha or all-numeric passwords\n-      // on the bloom filter, reducing space.\n-      bool = bloomfilter.test(password);\n-      callback('Password strength check with bloomfilter triggered');\n-    } else {\n-      bool = true;\n-      callback('Password with all alphabets/numbers detected');\n-    }\n+  return function (password, callback) {\n+    if (password && typeof password === 'string' && password.length > 8) {\n+      var isPasswordWeak = false;\n+      var strong = strengthCheck(password);","path":"src/passwordcheck.js","position":61,"original_position":61,"commit_id":"f14f5089b113d2364f8855e783ee26f31c998c4d","original_commit_id":"f14f5089b113d2364f8855e783ee26f31c998c4d","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"body":"Can you rename `strong` to `isStrong`? I like to preface boolean values with something that indicates it's a truthy value, `is`, `has`, `can`, etc.","created_at":"2015-07-28T13:31:30Z","updated_at":"2015-07-28T13:31:30Z","html_url":"https://github.com/mozilla/fxa-password-strength-checker/pull/12#discussion_r35646527","pull_request_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/comments/35646527"},"html":{"href":"https://github.com/mozilla/fxa-password-strength-checker/pull/12#discussion_r35646527"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/12","id":40954886,"html_url":"https://github.com/mozilla/fxa-password-strength-checker/pull/12","diff_url":"https://github.com/mozilla/fxa-password-strength-checker/pull/12.diff","patch_url":"https://github.com/mozilla/fxa-password-strength-checker/pull/12.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/12","number":12,"state":"open","locked":false,"title":"refactor(src): change verbose messages","user":{"login":"TDA","id":432707,"avatar_url":"https://avatars.githubusercontent.com/u/432707?v=3","gravatar_id":"","url":"https://api.github.com/users/TDA","html_url":"https://github.com/TDA","followers_url":"https://api.github.com/users/TDA/followers","following_url":"https://api.github.com/users/TDA/following{/other_user}","gists_url":"https://api.github.com/users/TDA/gists{/gist_id}","starred_url":"https://api.github.com/users/TDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TDA/subscriptions","organizations_url":"https://api.github.com/users/TDA/orgs","repos_url":"https://api.github.com/users/TDA/repos","events_url":"https://api.github.com/users/TDA/events{/privacy}","received_events_url":"https://api.github.com/users/TDA/received_events","type":"User","site_admin":false},"body":"move reporting logic close to bloom filter logic\r\ncreated a variable called URl to hold the directory data\r\nadded a check for password to be string and non-empty\r\nFixes #4 #8 #9\r\nNEEDS REBASE after the other PR is merged.","created_at":"2015-07-27T22:04:05Z","updated_at":"2015-07-28T13:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57a9348543eccfe9bac341e5e7bb2f18f70c1b23","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/12/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/12/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/12/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/statuses/f14f5089b113d2364f8855e783ee26f31c998c4d","head":{"label":"mozilla:issue-3-verbose","ref":"issue-3-verbose","sha":"f14f5089b113d2364f8855e783ee26f31c998c4d","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":39597972,"name":"fxa-password-strength-checker","full_name":"mozilla/fxa-password-strength-checker","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-password-strength-checker","description":"Utility library for checking the strength of a user's password","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker","forks_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/releases{/id}","created_at":"2015-07-23T22:52:30Z","updated_at":"2015-07-23T23:12:01Z","pushed_at":"2015-07-27T23:20:23Z","git_url":"git://github.com/mozilla/fxa-password-strength-checker.git","ssh_url":"git@github.com:mozilla/fxa-password-strength-checker.git","clone_url":"https://github.com/mozilla/fxa-password-strength-checker.git","svn_url":"https://github.com/mozilla/fxa-password-strength-checker","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"0404a991803cfc35b781a2e83c13fb9f7a603bc7","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":39597972,"name":"fxa-password-strength-checker","full_name":"mozilla/fxa-password-strength-checker","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-password-strength-checker","description":"Utility library for checking the strength of a user's password","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker","forks_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/releases{/id}","created_at":"2015-07-23T22:52:30Z","updated_at":"2015-07-23T23:12:01Z","pushed_at":"2015-07-27T23:20:23Z","git_url":"git://github.com/mozilla/fxa-password-strength-checker.git","ssh_url":"git@github.com:mozilla/fxa-password-strength-checker.git","clone_url":"https://github.com/mozilla/fxa-password-strength-checker.git","svn_url":"https://github.com/mozilla/fxa-password-strength-checker","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/12"},"html":{"href":"https://github.com/mozilla/fxa-password-strength-checker/pull/12"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/12"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-password-strength-checker/statuses/f14f5089b113d2364f8855e783ee26f31c998c4d"}}}}