{"action":"created","issue":{"url":"https://api.github.com/repos/salcode/bootstrap-genesis/issues/46","labels_url":"https://api.github.com/repos/salcode/bootstrap-genesis/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/salcode/bootstrap-genesis/issues/46/comments","events_url":"https://api.github.com/repos/salcode/bootstrap-genesis/issues/46/events","html_url":"https://github.com/salcode/bootstrap-genesis/issues/46","id":59552430,"number":46,"title":"Add additional layout options","user":{"login":"bryanwillis","id":4042621,"avatar_url":"https://avatars.githubusercontent.com/u/4042621?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanwillis","html_url":"https://github.com/bryanwillis","followers_url":"https://api.github.com/users/bryanwillis/followers","following_url":"https://api.github.com/users/bryanwillis/following{/other_user}","gists_url":"https://api.github.com/users/bryanwillis/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanwillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanwillis/subscriptions","organizations_url":"https://api.github.com/users/bryanwillis/orgs","repos_url":"https://api.github.com/users/bryanwillis/repos","events_url":"https://api.github.com/users/bryanwillis/events{/privacy}","received_events_url":"https://api.github.com/users/bryanwillis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/salcode/bootstrap-genesis/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/salcode/bootstrap-genesis/milestones/1","html_url":"https://github.com/salcode/bootstrap-genesis/milestones/Layout%20Options","labels_url":"https://api.github.com/repos/salcode/bootstrap-genesis/milestones/1/labels","id":1005128,"number":1,"title":"Layout Options","description":"Add support for all of the default Genesis layout options.","creator":{"login":"salcode","id":5194588,"avatar_url":"https://avatars.githubusercontent.com/u/5194588?v=3","gravatar_id":"","url":"https://api.github.com/users/salcode","html_url":"https://github.com/salcode","followers_url":"https://api.github.com/users/salcode/followers","following_url":"https://api.github.com/users/salcode/following{/other_user}","gists_url":"https://api.github.com/users/salcode/gists{/gist_id}","starred_url":"https://api.github.com/users/salcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salcode/subscriptions","organizations_url":"https://api.github.com/users/salcode/orgs","repos_url":"https://api.github.com/users/salcode/repos","events_url":"https://api.github.com/users/salcode/events{/privacy}","received_events_url":"https://api.github.com/users/salcode/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-03-04T04:45:32Z","updated_at":"2015-03-04T04:52:54Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-03-02T21:19:00Z","updated_at":"2015-03-04T04:56:34Z","closed_at":null,"body":"This is referring to [pull request](https://github.com/bryanwillis/bootstrap-genesis/pull/1) I wrote for adding additional layouts . I think I did the pull request wrong though. I've done it only once or twice before and was kinda confused about how it worked. \r\n\r\nAnyway, for this to work it needs a main [genesis() override](https://github.com/bryanwillis/bootstrap-genesis/blob/develop/page.php) specifically so `genesis_after_content_sidebar_wrap()` is moved inside of `<div class=\"content-sidebar-wrap\"></div>`. \r\n\r\nThere is probably a better way of doing this, but this seemed like the simplest approach without having to put too much thought into php and overriding too much of genesis and reinforces genesis's semantic markup while still being able to use bootstrap column classes.  \r\n\r\nThere is probably another way to get `genesis_after_content_sidebar_wrap()` inside the wrap either by unhooking and hooking it earlier or maybe `genesis_site_layout()` or filtering `genesis_attr_`-  or the `genesis-structural-wraps` but I was tired last night when I did this and didn't want to mess trying to figure that out.\r\n\r\nAnyway, I can't promise that the **sass** will work because I haven't tried it, but have tried with **less** and it [works fine](https://gist.github.com/bryanwillis/08b64ac92a2bf714417b#file-genesis-bootstrap-layouts-less) although could probably be shortened/cleaned up.\r\n\r\nThis can all be tested here:\r\n\r\n[content-sidebar](http://runningblog.wpengine.com/content-sidebar/)\r\n[sidebar-content](http://runningblog.wpengine.com/sidebar-content/)\r\n[content-sidebar-sidebar](http://runningblog.wpengine.com/content-sidebar-sidebar/)\r\n[sidebar-sidebar-content](http://runningblog.wpengine.com/sidebar-sidebar-content/)\r\n[sidebar-content-sidebar](http://runningblog.wpengine.com/sidebar-sidebar-content/)\r\n[fullwidth](http://runningblog.wpengine.com/fullwidth/)\r\n\r\nAgain this was just me trying some things out so this probably isn't the best way to do it, but it seems simple enough and keeps things clean for the most part. It seemed very complicated to create three column layouts using bootstrap `sidebar-secondary` was outside of the `content-sidebar-wrap` since custom additional rows would have to be added to allow the nesting."},"comment":{"url":"https://api.github.com/repos/salcode/bootstrap-genesis/issues/comments/77097243","html_url":"https://github.com/salcode/bootstrap-genesis/issues/46#issuecomment-77097243","issue_url":"https://api.github.com/repos/salcode/bootstrap-genesis/issues/46","id":77097243,"user":{"login":"salcode","id":5194588,"avatar_url":"https://avatars.githubusercontent.com/u/5194588?v=3","gravatar_id":"","url":"https://api.github.com/users/salcode","html_url":"https://github.com/salcode","followers_url":"https://api.github.com/users/salcode/followers","following_url":"https://api.github.com/users/salcode/following{/other_user}","gists_url":"https://api.github.com/users/salcode/gists{/gist_id}","starred_url":"https://api.github.com/users/salcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salcode/subscriptions","organizations_url":"https://api.github.com/users/salcode/orgs","repos_url":"https://api.github.com/users/salcode/repos","events_url":"https://api.github.com/users/salcode/events{/privacy}","received_events_url":"https://api.github.com/users/salcode/received_events","type":"User","site_admin":false},"created_at":"2015-03-04T04:56:34Z","updated_at":"2015-03-04T04:56:34Z","body":"I've created a feature branch called __feature-layout-choices__.\r\nI'd like to make these changes on that branch and once we're happy with them merge them all in at once."}}