{"action":"created","comment":{"url":"https://api.github.com/repos/RalfJung/rust-101/pulls/comments/45830688","id":45830688,"diff_hunk":"@@ -17,7 +17,7 @@ pub enum SomethingOrNothing<T>  {\n }\n // Instead of writing out all the variants, we can also just import them all at once.\n pub use self::SomethingOrNothing::*;\n-//@ What this does is to define an entire family of types: We can now write\n+//@ What this does is define an entire family of types: We can now write","path":"src/part02.rs","position":5,"original_position":5,"commit_id":"b89eed2cb450e67dd00102d1018adbb9a0cb1cae","original_commit_id":"b89eed2cb450e67dd00102d1018adbb9a0cb1cae","user":{"login":"r0e","id":3118143,"avatar_url":"https://avatars.githubusercontent.com/u/3118143?v=3","gravatar_id":"","url":"https://api.github.com/users/r0e","html_url":"https://github.com/r0e","followers_url":"https://api.github.com/users/r0e/followers","following_url":"https://api.github.com/users/r0e/following{/other_user}","gists_url":"https://api.github.com/users/r0e/gists{/gist_id}","starred_url":"https://api.github.com/users/r0e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0e/subscriptions","organizations_url":"https://api.github.com/users/r0e/orgs","repos_url":"https://api.github.com/users/r0e/repos","events_url":"https://api.github.com/users/r0e/events{/privacy}","received_events_url":"https://api.github.com/users/r0e/received_events","type":"User","site_admin":false},"body":"Yup I'm a native speaker.\r\nIn this case I'm certain that \"is define\" works best here.\r\n\r\nIf you wanted to use \"is defining\" you'd want to write something along the lines of \"What we are doing is defining an entire family of types\"","created_at":"2015-11-25T05:24:59Z","updated_at":"2015-11-25T05:24:59Z","html_url":"https://github.com/RalfJung/rust-101/pull/5#discussion_r45830688","pull_request_url":"https://api.github.com/repos/RalfJung/rust-101/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/RalfJung/rust-101/pulls/comments/45830688"},"html":{"href":"https://github.com/RalfJung/rust-101/pull/5#discussion_r45830688"},"pull_request":{"href":"https://api.github.com/repos/RalfJung/rust-101/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/RalfJung/rust-101/pulls/5","id":51477411,"html_url":"https://github.com/RalfJung/rust-101/pull/5","diff_url":"https://github.com/RalfJung/rust-101/pull/5.diff","patch_url":"https://github.com/RalfJung/rust-101/pull/5.patch","issue_url":"https://api.github.com/repos/RalfJung/rust-101/issues/5","number":5,"state":"open","locked":false,"title":"Small changes and clarification.","user":{"login":"r0e","id":3118143,"avatar_url":"https://avatars.githubusercontent.com/u/3118143?v=3","gravatar_id":"","url":"https://api.github.com/users/r0e","html_url":"https://github.com/r0e","followers_url":"https://api.github.com/users/r0e/followers","following_url":"https://api.github.com/users/r0e/following{/other_user}","gists_url":"https://api.github.com/users/r0e/gists{/gist_id}","starred_url":"https://api.github.com/users/r0e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0e/subscriptions","organizations_url":"https://api.github.com/users/r0e/orgs","repos_url":"https://api.github.com/users/r0e/repos","events_url":"https://api.github.com/users/r0e/events{/privacy}","received_events_url":"https://api.github.com/users/r0e/received_events","type":"User","site_admin":false},"body":"@RalfJung  When I was learning through this tutorial, I had some major confusion as to what function was being referred to in the lifetimes section [here](https://github.com/RalfJung/rust-101/compare/RalfJung:3067763...r0e:b89eed2#diff-b2ab04260fc4b9d88ffad90cf39d9c0cR140).\r\n\r\nI also noticed some other tiny errors as I was reading and thought that I could fix them up for you.\r\n\r\nOverall, the best tutorial I've read so far (especially the lifetimes section).","created_at":"2015-11-22T22:49:03Z","updated_at":"2015-11-25T05:24:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"557f170cc5290fd568c46b0ffae2e57e48a9563d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RalfJung/rust-101/pulls/5/commits","review_comments_url":"https://api.github.com/repos/RalfJung/rust-101/pulls/5/comments","review_comment_url":"https://api.github.com/repos/RalfJung/rust-101/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RalfJung/rust-101/issues/5/comments","statuses_url":"https://api.github.com/repos/RalfJung/rust-101/statuses/b89eed2cb450e67dd00102d1018adbb9a0cb1cae","head":{"label":"r0e:master","ref":"master","sha":"b89eed2cb450e67dd00102d1018adbb9a0cb1cae","user":{"login":"r0e","id":3118143,"avatar_url":"https://avatars.githubusercontent.com/u/3118143?v=3","gravatar_id":"","url":"https://api.github.com/users/r0e","html_url":"https://github.com/r0e","followers_url":"https://api.github.com/users/r0e/followers","following_url":"https://api.github.com/users/r0e/following{/other_user}","gists_url":"https://api.github.com/users/r0e/gists{/gist_id}","starred_url":"https://api.github.com/users/r0e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0e/subscriptions","organizations_url":"https://api.github.com/users/r0e/orgs","repos_url":"https://api.github.com/users/r0e/repos","events_url":"https://api.github.com/users/r0e/events{/privacy}","received_events_url":"https://api.github.com/users/r0e/received_events","type":"User","site_admin":false},"repo":{"id":46649101,"name":"rust-101","full_name":"r0e/rust-101","owner":{"login":"r0e","id":3118143,"avatar_url":"https://avatars.githubusercontent.com/u/3118143?v=3","gravatar_id":"","url":"https://api.github.com/users/r0e","html_url":"https://github.com/r0e","followers_url":"https://api.github.com/users/r0e/followers","following_url":"https://api.github.com/users/r0e/following{/other_user}","gists_url":"https://api.github.com/users/r0e/gists{/gist_id}","starred_url":"https://api.github.com/users/r0e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0e/subscriptions","organizations_url":"https://api.github.com/users/r0e/orgs","repos_url":"https://api.github.com/users/r0e/repos","events_url":"https://api.github.com/users/r0e/events{/privacy}","received_events_url":"https://api.github.com/users/r0e/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/r0e/rust-101","description":"A tutorial for the Rust language","fork":true,"url":"https://api.github.com/repos/r0e/rust-101","forks_url":"https://api.github.com/repos/r0e/rust-101/forks","keys_url":"https://api.github.com/repos/r0e/rust-101/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r0e/rust-101/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r0e/rust-101/teams","hooks_url":"https://api.github.com/repos/r0e/rust-101/hooks","issue_events_url":"https://api.github.com/repos/r0e/rust-101/issues/events{/number}","events_url":"https://api.github.com/repos/r0e/rust-101/events","assignees_url":"https://api.github.com/repos/r0e/rust-101/assignees{/user}","branches_url":"https://api.github.com/repos/r0e/rust-101/branches{/branch}","tags_url":"https://api.github.com/repos/r0e/rust-101/tags","blobs_url":"https://api.github.com/repos/r0e/rust-101/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r0e/rust-101/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r0e/rust-101/git/refs{/sha}","trees_url":"https://api.github.com/repos/r0e/rust-101/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r0e/rust-101/statuses/{sha}","languages_url":"https://api.github.com/repos/r0e/rust-101/languages","stargazers_url":"https://api.github.com/repos/r0e/rust-101/stargazers","contributors_url":"https://api.github.com/repos/r0e/rust-101/contributors","subscribers_url":"https://api.github.com/repos/r0e/rust-101/subscribers","subscription_url":"https://api.github.com/repos/r0e/rust-101/subscription","commits_url":"https://api.github.com/repos/r0e/rust-101/commits{/sha}","git_commits_url":"https://api.github.com/repos/r0e/rust-101/git/commits{/sha}","comments_url":"https://api.github.com/repos/r0e/rust-101/comments{/number}","issue_comment_url":"https://api.github.com/repos/r0e/rust-101/issues/comments{/number}","contents_url":"https://api.github.com/repos/r0e/rust-101/contents/{+path}","compare_url":"https://api.github.com/repos/r0e/rust-101/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r0e/rust-101/merges","archive_url":"https://api.github.com/repos/r0e/rust-101/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r0e/rust-101/downloads","issues_url":"https://api.github.com/repos/r0e/rust-101/issues{/number}","pulls_url":"https://api.github.com/repos/r0e/rust-101/pulls{/number}","milestones_url":"https://api.github.com/repos/r0e/rust-101/milestones{/number}","notifications_url":"https://api.github.com/repos/r0e/rust-101/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r0e/rust-101/labels{/name}","releases_url":"https://api.github.com/repos/r0e/rust-101/releases{/id}","created_at":"2015-11-22T06:18:21Z","updated_at":"2015-11-22T06:18:22Z","pushed_at":"2015-11-22T22:42:33Z","git_url":"git://github.com/r0e/rust-101.git","ssh_url":"git@github.com:r0e/rust-101.git","clone_url":"https://github.com/r0e/rust-101.git","svn_url":"https://github.com/r0e/rust-101","homepage":"https://www.ralfj.de/projects/rust-101/","size":250,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RalfJung:master","ref":"master","sha":"306776311fd5ec57a462ea227c40ba0acb2fec73","user":{"login":"RalfJung","id":330628,"avatar_url":"https://avatars.githubusercontent.com/u/330628?v=3","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"repo":{"id":37064034,"name":"rust-101","full_name":"RalfJung/rust-101","owner":{"login":"RalfJung","id":330628,"avatar_url":"https://avatars.githubusercontent.com/u/330628?v=3","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RalfJung/rust-101","description":"A tutorial for the Rust language","fork":false,"url":"https://api.github.com/repos/RalfJung/rust-101","forks_url":"https://api.github.com/repos/RalfJung/rust-101/forks","keys_url":"https://api.github.com/repos/RalfJung/rust-101/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RalfJung/rust-101/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RalfJung/rust-101/teams","hooks_url":"https://api.github.com/repos/RalfJung/rust-101/hooks","issue_events_url":"https://api.github.com/repos/RalfJung/rust-101/issues/events{/number}","events_url":"https://api.github.com/repos/RalfJung/rust-101/events","assignees_url":"https://api.github.com/repos/RalfJung/rust-101/assignees{/user}","branches_url":"https://api.github.com/repos/RalfJung/rust-101/branches{/branch}","tags_url":"https://api.github.com/repos/RalfJung/rust-101/tags","blobs_url":"https://api.github.com/repos/RalfJung/rust-101/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RalfJung/rust-101/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RalfJung/rust-101/git/refs{/sha}","trees_url":"https://api.github.com/repos/RalfJung/rust-101/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RalfJung/rust-101/statuses/{sha}","languages_url":"https://api.github.com/repos/RalfJung/rust-101/languages","stargazers_url":"https://api.github.com/repos/RalfJung/rust-101/stargazers","contributors_url":"https://api.github.com/repos/RalfJung/rust-101/contributors","subscribers_url":"https://api.github.com/repos/RalfJung/rust-101/subscribers","subscription_url":"https://api.github.com/repos/RalfJung/rust-101/subscription","commits_url":"https://api.github.com/repos/RalfJung/rust-101/commits{/sha}","git_commits_url":"https://api.github.com/repos/RalfJung/rust-101/git/commits{/sha}","comments_url":"https://api.github.com/repos/RalfJung/rust-101/comments{/number}","issue_comment_url":"https://api.github.com/repos/RalfJung/rust-101/issues/comments{/number}","contents_url":"https://api.github.com/repos/RalfJung/rust-101/contents/{+path}","compare_url":"https://api.github.com/repos/RalfJung/rust-101/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RalfJung/rust-101/merges","archive_url":"https://api.github.com/repos/RalfJung/rust-101/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RalfJung/rust-101/downloads","issues_url":"https://api.github.com/repos/RalfJung/rust-101/issues{/number}","pulls_url":"https://api.github.com/repos/RalfJung/rust-101/pulls{/number}","milestones_url":"https://api.github.com/repos/RalfJung/rust-101/milestones{/number}","notifications_url":"https://api.github.com/repos/RalfJung/rust-101/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RalfJung/rust-101/labels{/name}","releases_url":"https://api.github.com/repos/RalfJung/rust-101/releases{/id}","created_at":"2015-06-08T11:56:30Z","updated_at":"2015-11-23T04:31:08Z","pushed_at":"2015-11-22T22:49:03Z","git_url":"git://github.com/RalfJung/rust-101.git","ssh_url":"git@github.com:RalfJung/rust-101.git","clone_url":"https://github.com/RalfJung/rust-101.git","svn_url":"https://github.com/RalfJung/rust-101","homepage":"https://www.ralfj.de/projects/rust-101/","size":453,"stargazers_count":23,"watchers_count":23,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RalfJung/rust-101/pulls/5"},"html":{"href":"https://github.com/RalfJung/rust-101/pull/5"},"issue":{"href":"https://api.github.com/repos/RalfJung/rust-101/issues/5"},"comments":{"href":"https://api.github.com/repos/RalfJung/rust-101/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/RalfJung/rust-101/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/RalfJung/rust-101/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RalfJung/rust-101/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/RalfJung/rust-101/statuses/b89eed2cb450e67dd00102d1018adbb9a0cb1cae"}}}}