{"action":"created","issue":{"url":"https://api.github.com/repos/jpadilla/pyjwt/issues/158","labels_url":"https://api.github.com/repos/jpadilla/pyjwt/issues/158/labels{/name}","comments_url":"https://api.github.com/repos/jpadilla/pyjwt/issues/158/comments","events_url":"https://api.github.com/repos/jpadilla/pyjwt/issues/158/events","html_url":"https://github.com/jpadilla/pyjwt/pull/158","id":74989110,"number":158,"title":"Fix the ECDSA signature serialization format","user":{"login":"esneider","id":667132,"avatar_url":"https://avatars.githubusercontent.com/u/667132?v=3","gravatar_id":"","url":"https://api.github.com/users/esneider","html_url":"https://github.com/esneider","followers_url":"https://api.github.com/users/esneider/followers","following_url":"https://api.github.com/users/esneider/following{/other_user}","gists_url":"https://api.github.com/users/esneider/gists{/gist_id}","starred_url":"https://api.github.com/users/esneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esneider/subscriptions","organizations_url":"https://api.github.com/users/esneider/orgs","repos_url":"https://api.github.com/users/esneider/repos","events_url":"https://api.github.com/users/esneider/events{/privacy}","received_events_url":"https://api.github.com/users/esneider/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jpadilla/pyjwt/labels/bug","name":"bug","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-05-10T19:50:58Z","updated_at":"2015-05-15T21:27:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jpadilla/pyjwt/pulls/158","html_url":"https://github.com/jpadilla/pyjwt/pull/158","diff_url":"https://github.com/jpadilla/pyjwt/pull/158.diff","patch_url":"https://github.com/jpadilla/pyjwt/pull/158.patch"},"body":"According to the [JSON Web Algorithms Draft, section 3.4](https://tools.ietf.org/html/draft-ietf-jose-json-web-algorithms-40#section-3.4) the ECDSA signature should be serialized by concatenating the R and S values.\r\n\r\nThe code was using `ecdsa.util.sigencode_der`, that encodes the signature using the DER serialization format, instead of using `ecdsa.util.sigencode_string`, that does exactly what the draft asks."},"comment":{"url":"https://api.github.com/repos/jpadilla/pyjwt/issues/comments/102529202","html_url":"https://github.com/jpadilla/pyjwt/pull/158#issuecomment-102529202","issue_url":"https://api.github.com/repos/jpadilla/pyjwt/issues/158","id":102529202,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2015-05-15T21:27:29Z","updated_at":"2015-05-15T21:27:29Z","body":"\n[![Coverage Status](https://coveralls.io/builds/2575973/badge)](https://coveralls.io/builds/2575973)\n\nCoverage decreased (-0.4%) to 99.6% when pulling **3c479e21b4cb25ffce925cb554a7468fc9cc409f on esneider:master** into **6c9cada81758cc985a5e4b3d6e1bcadc3852a9a8 on jpadilla:master**.\n"}}