{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/presto/pulls/comments/30756947","id":30756947,"diff_hunk":"@@ -186,7 +205,7 @@ private void fireStateChanged(T newState, List<SettableFuture<T>> futureStateCha\n         checkState(!Thread.holdsLock(this), \"Can not fire state change event while holding a lock on this\");\n \n         executor.execute(() -> {\n-            checkState(!Thread.holdsLock(StateMachine.this), \"Can not notify while holding a lock on this\");\n+            checkState(!Thread.holdsLock(this), \"Can not notify while holding a lock on this\");","path":"presto-main/src/main/java/com/facebook/presto/execution/StateMachine.java","position":54,"original_position":54,"commit_id":"4400e3f7d2c52754d754a045f43f2e87d1f55335","original_commit_id":"4400e3f7d2c52754d754a045f43f2e87d1f55335","user":{"login":"martint","id":14387,"avatar_url":"https://avatars.githubusercontent.com/u/14387?v=3","gravatar_id":"","url":"https://api.github.com/users/martint","html_url":"https://github.com/martint","followers_url":"https://api.github.com/users/martint/followers","following_url":"https://api.github.com/users/martint/following{/other_user}","gists_url":"https://api.github.com/users/martint/gists{/gist_id}","starred_url":"https://api.github.com/users/martint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martint/subscriptions","organizations_url":"https://api.github.com/users/martint/orgs","repos_url":"https://api.github.com/users/martint/repos","events_url":"https://api.github.com/users/martint/events{/privacy}","received_events_url":"https://api.github.com/users/martint/received_events","type":"User","site_admin":false},"body":"Is this intentional? \"this\" in this context is the lambda","created_at":"2015-05-20T22:36:34Z","updated_at":"2015-05-20T22:36:34Z","html_url":"https://github.com/facebook/presto/pull/2959#discussion_r30756947","pull_request_url":"https://api.github.com/repos/facebook/presto/pulls/2959","_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments/30756947"},"html":{"href":"https://github.com/facebook/presto/pull/2959#discussion_r30756947"},"pull_request":{"href":"https://api.github.com/repos/facebook/presto/pulls/2959"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/presto/pulls/2959","id":35880751,"html_url":"https://github.com/facebook/presto/pull/2959","diff_url":"https://github.com/facebook/presto/pull/2959.diff","patch_url":"https://github.com/facebook/presto/pull/2959.patch","issue_url":"https://api.github.com/repos/facebook/presto/issues/2959","number":2959,"state":"open","locked":false,"title":"Fix excessive SettableFuture retention","user":{"login":"cberner","id":842688,"avatar_url":"https://avatars.githubusercontent.com/u/842688?v=3","gravatar_id":"","url":"https://api.github.com/users/cberner","html_url":"https://github.com/cberner","followers_url":"https://api.github.com/users/cberner/followers","following_url":"https://api.github.com/users/cberner/following{/other_user}","gists_url":"https://api.github.com/users/cberner/gists{/gist_id}","starred_url":"https://api.github.com/users/cberner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cberner/subscriptions","organizations_url":"https://api.github.com/users/cberner/orgs","repos_url":"https://api.github.com/users/cberner/repos","events_url":"https://api.github.com/users/cberner/events{/privacy}","received_events_url":"https://api.github.com/users/cberner/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-20T21:59:09Z","updated_at":"2015-05-20T22:36:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a57612f7509f93a27b66cd3c1bba336cff9d2de","assignee":{"login":"dain","id":58298,"avatar_url":"https://avatars.githubusercontent.com/u/58298?v=3","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/facebook/presto/pulls/2959/commits","review_comments_url":"https://api.github.com/repos/facebook/presto/pulls/2959/comments","review_comment_url":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/presto/issues/2959/comments","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/4400e3f7d2c52754d754a045f43f2e87d1f55335","head":{"label":"cberner:statemachine","ref":"statemachine","sha":"4400e3f7d2c52754d754a045f43f2e87d1f55335","user":{"login":"cberner","id":842688,"avatar_url":"https://avatars.githubusercontent.com/u/842688?v=3","gravatar_id":"","url":"https://api.github.com/users/cberner","html_url":"https://github.com/cberner","followers_url":"https://api.github.com/users/cberner/followers","following_url":"https://api.github.com/users/cberner/following{/other_user}","gists_url":"https://api.github.com/users/cberner/gists{/gist_id}","starred_url":"https://api.github.com/users/cberner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cberner/subscriptions","organizations_url":"https://api.github.com/users/cberner/orgs","repos_url":"https://api.github.com/users/cberner/repos","events_url":"https://api.github.com/users/cberner/events{/privacy}","received_events_url":"https://api.github.com/users/cberner/received_events","type":"User","site_admin":false},"repo":{"id":10272630,"name":"presto","full_name":"cberner/presto","owner":{"login":"cberner","id":842688,"avatar_url":"https://avatars.githubusercontent.com/u/842688?v=3","gravatar_id":"","url":"https://api.github.com/users/cberner","html_url":"https://github.com/cberner","followers_url":"https://api.github.com/users/cberner/followers","following_url":"https://api.github.com/users/cberner/following{/other_user}","gists_url":"https://api.github.com/users/cberner/gists{/gist_id}","starred_url":"https://api.github.com/users/cberner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cberner/subscriptions","organizations_url":"https://api.github.com/users/cberner/orgs","repos_url":"https://api.github.com/users/cberner/repos","events_url":"https://api.github.com/users/cberner/events{/privacy}","received_events_url":"https://api.github.com/users/cberner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cberner/presto","description":"","fork":true,"url":"https://api.github.com/repos/cberner/presto","forks_url":"https://api.github.com/repos/cberner/presto/forks","keys_url":"https://api.github.com/repos/cberner/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cberner/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cberner/presto/teams","hooks_url":"https://api.github.com/repos/cberner/presto/hooks","issue_events_url":"https://api.github.com/repos/cberner/presto/issues/events{/number}","events_url":"https://api.github.com/repos/cberner/presto/events","assignees_url":"https://api.github.com/repos/cberner/presto/assignees{/user}","branches_url":"https://api.github.com/repos/cberner/presto/branches{/branch}","tags_url":"https://api.github.com/repos/cberner/presto/tags","blobs_url":"https://api.github.com/repos/cberner/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cberner/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cberner/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/cberner/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cberner/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/cberner/presto/languages","stargazers_url":"https://api.github.com/repos/cberner/presto/stargazers","contributors_url":"https://api.github.com/repos/cberner/presto/contributors","subscribers_url":"https://api.github.com/repos/cberner/presto/subscribers","subscription_url":"https://api.github.com/repos/cberner/presto/subscription","commits_url":"https://api.github.com/repos/cberner/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/cberner/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/cberner/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/cberner/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/cberner/presto/contents/{+path}","compare_url":"https://api.github.com/repos/cberner/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cberner/presto/merges","archive_url":"https://api.github.com/repos/cberner/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cberner/presto/downloads","issues_url":"https://api.github.com/repos/cberner/presto/issues{/number}","pulls_url":"https://api.github.com/repos/cberner/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/cberner/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/cberner/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cberner/presto/labels{/name}","releases_url":"https://api.github.com/repos/cberner/presto/releases{/id}","created_at":"2013-05-24T18:37:52Z","updated_at":"2015-04-30T20:27:46Z","pushed_at":"2015-05-20T22:29:59Z","git_url":"git://github.com/cberner/presto.git","ssh_url":"git@github.com:cberner/presto.git","clone_url":"https://github.com/cberner/presto.git","svn_url":"https://github.com/cberner/presto","homepage":null,"size":40552,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"0ba5e49f7f80ac1bb7dd605c3df5a40d8b049ab4","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"facebook/presto","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/presto","description":"Distributed SQL query engine for running interactive analytic queries against big data sources.","fork":false,"url":"https://api.github.com/repos/facebook/presto","forks_url":"https://api.github.com/repos/facebook/presto/forks","keys_url":"https://api.github.com/repos/facebook/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/presto/teams","hooks_url":"https://api.github.com/repos/facebook/presto/hooks","issue_events_url":"https://api.github.com/repos/facebook/presto/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/presto/events","assignees_url":"https://api.github.com/repos/facebook/presto/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/presto/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/presto/tags","blobs_url":"https://api.github.com/repos/facebook/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/presto/languages","stargazers_url":"https://api.github.com/repos/facebook/presto/stargazers","contributors_url":"https://api.github.com/repos/facebook/presto/contributors","subscribers_url":"https://api.github.com/repos/facebook/presto/subscribers","subscription_url":"https://api.github.com/repos/facebook/presto/subscription","commits_url":"https://api.github.com/repos/facebook/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/presto/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/presto/merges","archive_url":"https://api.github.com/repos/facebook/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/presto/downloads","issues_url":"https://api.github.com/repos/facebook/presto/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/presto/labels{/name}","releases_url":"https://api.github.com/repos/facebook/presto/releases{/id}","created_at":"2012-08-09T01:03:37Z","updated_at":"2015-05-20T12:55:52Z","pushed_at":"2015-05-20T22:30:00Z","git_url":"git://github.com/facebook/presto.git","ssh_url":"git@github.com:facebook/presto.git","clone_url":"https://github.com/facebook/presto.git","svn_url":"https://github.com/facebook/presto","homepage":"https://prestodb.io","size":90595,"stargazers_count":3440,"watchers_count":3440,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":799,"mirror_url":null,"open_issues_count":218,"forks":799,"open_issues":218,"watchers":3440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/presto/pulls/2959"},"html":{"href":"https://github.com/facebook/presto/pull/2959"},"issue":{"href":"https://api.github.com/repos/facebook/presto/issues/2959"},"comments":{"href":"https://api.github.com/repos/facebook/presto/issues/2959/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/presto/pulls/2959/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/presto/pulls/2959/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/presto/statuses/4400e3f7d2c52754d754a045f43f2e87d1f55335"}}}}