{"comment":{"url":"https://api.github.com/repos/mesosphere/hdfs/comments/10157342","html_url":"https://github.com/mesosphere/hdfs/commit/3b3e46ae8dbb6b2d6f470ce3cf631153a0eda205#commitcomment-10157342","id":10157342,"user":{"login":"adam-mesos","id":6456528,"avatar_url":"https://avatars.githubusercontent.com/u/6456528?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-mesos","html_url":"https://github.com/adam-mesos","followers_url":"https://api.github.com/users/adam-mesos/followers","following_url":"https://api.github.com/users/adam-mesos/following{/other_user}","gists_url":"https://api.github.com/users/adam-mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-mesos/subscriptions","organizations_url":"https://api.github.com/users/adam-mesos/orgs","repos_url":"https://api.github.com/users/adam-mesos/repos","events_url":"https://api.github.com/users/adam-mesos/events{/privacy}","received_events_url":"https://api.github.com/users/adam-mesos/received_events","type":"User","site_admin":false},"position":13,"line":110,"path":"src/main/java/org/apache/mesos/hdfs/executor/NameNodeExecutor.java","commit_id":"3b3e46ae8dbb6b2d6f470ce3cf631153a0eda205","created_at":"2015-03-12T05:01:33Z","updated_at":"2015-03-12T05:01:33Z","body":"I think this runCommand(init/bootstrap) does belong up in the else case, since we don't want to reformat the NN metadata if it already exists. The rest of the startProcess(NN + ZKFC) and sendStatusUpdate(RUNNING) lines probably belong outside of the if/else as you have them."}}