{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit/issues/630","labels_url":"https://api.github.com/repos/nunit/nunit/issues/630/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/630/comments","events_url":"https://api.github.com/repos/nunit/nunit/issues/630/events","html_url":"https://github.com/nunit/nunit/pull/630","id":73469108,"number":630,"title":"Issue 621 core engine","user":{"login":"CharliePoole","id":2678661,"avatar_url":"https://avatars.githubusercontent.com/u/2678661?v=3","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":31,"created_at":"2015-05-06T00:10:51Z","updated_at":"2015-05-13T06:35:32Z","closed_at":"2015-05-10T16:38:30Z","pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/630","html_url":"https://github.com/nunit/nunit/pull/630","diff_url":"https://github.com/nunit/nunit/pull/630.diff","patch_url":"https://github.com/nunit/nunit/pull/630.patch"},"body":"**Ready to merge**\r\n\r\nFixes #621\r\n\r\nThis PR creates an nunit.core.engine assembly that has part of the capability of the full engine. Here are some of the key points:\r\n\r\n* The core engine is intended to be referenced by a runner, not loaded dynamically like the full engine.\r\n\r\n* The engine references nunit.engine.api even though some of the interfaces defined there are not actually used. I'm thinking that for the core engine it may make more sense to include the interfaces in the same assembly.\r\n\r\n* We use define CORE_ENGINE for the build as opposed to NUNIT_ENGINE.\r\n\r\n* The only services provided are SettingsService, DomainManager, CoreTestRunnerFactory and DriverService. Only SettingsService is available publicly.\r\n \r\n* The only runners provided are the TestDomainRunner, which creates a test domain, and LocalTestRunner, which does not.\r\n\r\n* Multiple assemblies can be run, but they will all run in the same domain.\r\n\r\nNext steps would be:\r\n\r\n1. Decide if the features here are what we want or at least OK for a starter.\r\n\r\n2. Decide whether to merge classes from nunit.engine.api into nunit.core.engine.\r\n\r\n3. Consider creating some sort of runner that exercises the core engine.\r\n\r\n4. Try to build it as a portable library.\r\n\r\n5. Decide if we want to build it on any other platforms."},"comment":{"url":"https://api.github.com/repos/nunit/nunit/issues/comments/101532645","html_url":"https://github.com/nunit/nunit/pull/630#issuecomment-101532645","issue_url":"https://api.github.com/repos/nunit/nunit/issues/630","id":101532645,"user":{"login":"oznetmaster","id":5798625,"avatar_url":"https://avatars.githubusercontent.com/u/5798625?v=3","gravatar_id":"","url":"https://api.github.com/users/oznetmaster","html_url":"https://github.com/oznetmaster","followers_url":"https://api.github.com/users/oznetmaster/followers","following_url":"https://api.github.com/users/oznetmaster/following{/other_user}","gists_url":"https://api.github.com/users/oznetmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/oznetmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oznetmaster/subscriptions","organizations_url":"https://api.github.com/users/oznetmaster/orgs","repos_url":"https://api.github.com/users/oznetmaster/repos","events_url":"https://api.github.com/users/oznetmaster/events{/privacy}","received_events_url":"https://api.github.com/users/oznetmaster/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T06:35:32Z","updated_at":"2015-05-13T06:35:32Z","body":"To clarify my confusion, the fact that the chart in question showed multiple process support in the core engine actually lead me to believe that the CF engine would either be the core engine (as defined in the spec), or a subset of it.\n\n"}}