{"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/comments/26813542","id":26813542,"diff_hunk":"@@ -854,6 +854,9 @@ SetupSIMD128TypedArrays();\n \n macro DECLARE_TYPED_ARRAY_FUNCTION(NAME)\n function NAMEArrayGet(i) {\n+  if((i < 0)||(i+1 > this.length)) {\n+  throw MakeRangeError('the index of value:' + i + ' is invalid');","path":"src/simd128.js","position":5,"original_position":5,"commit_id":"76146748a7fc9f851054c17cb9b815dcec03d9a5","original_commit_id":"76146748a7fc9f851054c17cb9b815dcec03d9a5","user":{"login":"huningxin","id":1005673,"avatar_url":"https://avatars.githubusercontent.com/u/1005673?v=3","gravatar_id":"","url":"https://api.github.com/users/huningxin","html_url":"https://github.com/huningxin","followers_url":"https://api.github.com/users/huningxin/followers","following_url":"https://api.github.com/users/huningxin/following{/other_user}","gists_url":"https://api.github.com/users/huningxin/gists{/gist_id}","starred_url":"https://api.github.com/users/huningxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huningxin/subscriptions","organizations_url":"https://api.github.com/users/huningxin/orgs","repos_url":"https://api.github.com/users/huningxin/repos","events_url":"https://api.github.com/users/huningxin/events{/privacy}","received_events_url":"https://api.github.com/users/huningxin/received_events","type":"User","site_admin":false},"body":"Please keep the two spaces indention.","created_at":"2015-03-20T01:40:25Z","updated_at":"2015-03-20T01:40:25Z","html_url":"https://github.com/crosswalk-project/v8-crosswalk/pull/89#discussion_r26813542","pull_request_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/comments/26813542"},"html":{"href":"https://github.com/crosswalk-project/v8-crosswalk/pull/89#discussion_r26813542"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/89","id":31402729,"html_url":"https://github.com/crosswalk-project/v8-crosswalk/pull/89","diff_url":"https://github.com/crosswalk-project/v8-crosswalk/pull/89.diff","patch_url":"https://github.com/crosswalk-project/v8-crosswalk/pull/89.patch","issue_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/issues/89","number":89,"state":"open","locked":false,"title":"[simd128.js]     Fix exception thrown when get Float32x4Array invalid in...","user":{"login":"chuan9","id":4636256,"avatar_url":"https://avatars.githubusercontent.com/u/4636256?v=3","gravatar_id":"","url":"https://api.github.com/users/chuan9","html_url":"https://github.com/chuan9","followers_url":"https://api.github.com/users/chuan9/followers","following_url":"https://api.github.com/users/chuan9/following{/other_user}","gists_url":"https://api.github.com/users/chuan9/gists{/gist_id}","starred_url":"https://api.github.com/users/chuan9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuan9/subscriptions","organizations_url":"https://api.github.com/users/chuan9/orgs","repos_url":"https://api.github.com/users/chuan9/repos","events_url":"https://api.github.com/users/chuan9/events{/privacy}","received_events_url":"https://api.github.com/users/chuan9/received_events","type":"User","site_admin":false},"body":"...dex.\r\n\r\n[float32x4.js]   Add test case for exception thrown for Float32x4Array invalid element\r\n\r\nBUG=XWALK-2440","created_at":"2015-03-18T06:04:16Z","updated_at":"2015-03-20T01:40:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff3e3f585e8b1d70a1137a36ec638d43ddf1d7d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/89/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/89/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/issues/89/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/statuses/76146748a7fc9f851054c17cb9b815dcec03d9a5","head":{"label":"chuan9:mydev","ref":"mydev","sha":"76146748a7fc9f851054c17cb9b815dcec03d9a5","user":{"login":"chuan9","id":4636256,"avatar_url":"https://avatars.githubusercontent.com/u/4636256?v=3","gravatar_id":"","url":"https://api.github.com/users/chuan9","html_url":"https://github.com/chuan9","followers_url":"https://api.github.com/users/chuan9/followers","following_url":"https://api.github.com/users/chuan9/following{/other_user}","gists_url":"https://api.github.com/users/chuan9/gists{/gist_id}","starred_url":"https://api.github.com/users/chuan9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuan9/subscriptions","organizations_url":"https://api.github.com/users/chuan9/orgs","repos_url":"https://api.github.com/users/chuan9/repos","events_url":"https://api.github.com/users/chuan9/events{/privacy}","received_events_url":"https://api.github.com/users/chuan9/received_events","type":"User","site_admin":false},"repo":{"id":32370910,"name":"v8-crosswalk","full_name":"chuan9/v8-crosswalk","owner":{"login":"chuan9","id":4636256,"avatar_url":"https://avatars.githubusercontent.com/u/4636256?v=3","gravatar_id":"","url":"https://api.github.com/users/chuan9","html_url":"https://github.com/chuan9","followers_url":"https://api.github.com/users/chuan9/followers","following_url":"https://api.github.com/users/chuan9/following{/other_user}","gists_url":"https://api.github.com/users/chuan9/gists{/gist_id}","starred_url":"https://api.github.com/users/chuan9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuan9/subscriptions","organizations_url":"https://api.github.com/users/chuan9/orgs","repos_url":"https://api.github.com/users/chuan9/repos","events_url":"https://api.github.com/users/chuan9/events{/privacy}","received_events_url":"https://api.github.com/users/chuan9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chuan9/v8-crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/chuan9/v8-crosswalk","forks_url":"https://api.github.com/repos/chuan9/v8-crosswalk/forks","keys_url":"https://api.github.com/repos/chuan9/v8-crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chuan9/v8-crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chuan9/v8-crosswalk/teams","hooks_url":"https://api.github.com/repos/chuan9/v8-crosswalk/hooks","issue_events_url":"https://api.github.com/repos/chuan9/v8-crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/chuan9/v8-crosswalk/events","assignees_url":"https://api.github.com/repos/chuan9/v8-crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/chuan9/v8-crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/chuan9/v8-crosswalk/tags","blobs_url":"https://api.github.com/repos/chuan9/v8-crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chuan9/v8-crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chuan9/v8-crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/chuan9/v8-crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chuan9/v8-crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/chuan9/v8-crosswalk/languages","stargazers_url":"https://api.github.com/repos/chuan9/v8-crosswalk/stargazers","contributors_url":"https://api.github.com/repos/chuan9/v8-crosswalk/contributors","subscribers_url":"https://api.github.com/repos/chuan9/v8-crosswalk/subscribers","subscription_url":"https://api.github.com/repos/chuan9/v8-crosswalk/subscription","commits_url":"https://api.github.com/repos/chuan9/v8-crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/chuan9/v8-crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/chuan9/v8-crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/chuan9/v8-crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/chuan9/v8-crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/chuan9/v8-crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chuan9/v8-crosswalk/merges","archive_url":"https://api.github.com/repos/chuan9/v8-crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chuan9/v8-crosswalk/downloads","issues_url":"https://api.github.com/repos/chuan9/v8-crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/chuan9/v8-crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/chuan9/v8-crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/chuan9/v8-crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chuan9/v8-crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/chuan9/v8-crosswalk/releases{/id}","created_at":"2015-03-17T04:08:01Z","updated_at":"2015-03-17T04:08:14Z","pushed_at":"2015-03-20T01:25:39Z","git_url":"git://github.com/chuan9/v8-crosswalk.git","ssh_url":"git@github.com:chuan9/v8-crosswalk.git","clone_url":"https://github.com/chuan9/v8-crosswalk.git","svn_url":"https://github.com/chuan9/v8-crosswalk","homepage":null,"size":121816,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"e192569693ad7de42287ef9e4a299524a670ce18","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":15861746,"name":"v8-crosswalk","full_name":"crosswalk-project/v8-crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/v8-crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/releases{/id}","created_at":"2014-01-13T08:02:21Z","updated_at":"2015-03-17T01:14:14Z","pushed_at":"2015-03-20T01:25:40Z","git_url":"git://github.com/crosswalk-project/v8-crosswalk.git","ssh_url":"git@github.com:crosswalk-project/v8-crosswalk.git","clone_url":"https://github.com/crosswalk-project/v8-crosswalk.git","svn_url":"https://github.com/crosswalk-project/v8-crosswalk","homepage":null,"size":126792,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":3,"forks":24,"open_issues":3,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/89"},"html":{"href":"https://github.com/crosswalk-project/v8-crosswalk/pull/89"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/issues/89"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/v8-crosswalk/statuses/76146748a7fc9f851054c17cb9b815dcec03d9a5"}}}}