{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/39765143","id":39765143,"diff_hunk":"@@ -196,9 +242,30 @@ bool XAudio2::Start()\n \tm_mastering_voice->SetVolume(m_volume);\n \n \tm_voice_context = std::unique_ptr<StreamingVoiceContext>\n-\t\t(new StreamingVoiceContext(m_xaudio2.get(), m_mixer.get(), m_sound_sync_event));\n+\t\t(new StreamingVoiceContext(m_xaudio2.get(), GetMixer(), SupportSurroundOutput(), !m_enablesoundloop));\n+\n+\treturn SoundStream::Start();\n+}\n+\n+void XAudio2::InitializeSoundLoop()\n+{\n \n-\treturn true;\n+}\n+\n+u32 XAudio2::SamplesNeeded()\n+{\n+\treturn m_voice_context->BufferReady() ? SOUND_FRAME_SIZE : 0;\n+}\n+\n+void XAudio2::WriteSamples(s16 *src, u32 numsamples)","path":"Source/Core/AudioCommon/XAudio2Stream.cpp","position":209,"original_position":209,"commit_id":"ebee3cfc16a6093aae52e53936baf41e57090b1d","original_commit_id":"ebee3cfc16a6093aae52e53936baf41e57090b1d","user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"asterisk against type","created_at":"2015-09-17T16:10:48Z","updated_at":"2015-09-17T16:10:48Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/3053#discussion_r39765143","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3053","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/39765143"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3053#discussion_r39765143"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3053"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3053","id":45306616,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3053","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3053.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3053.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3053","number":3053,"state":"open","locked":false,"title":"Port Time Stretching and ProLogic II decoding to all audio backend -- From Ishiiruka","user":{"login":"phire","id":138484,"avatar_url":"https://avatars.githubusercontent.com/u/138484?v=3","gravatar_id":"","url":"https://api.github.com/users/phire","html_url":"https://github.com/phire","followers_url":"https://api.github.com/users/phire/followers","following_url":"https://api.github.com/users/phire/following{/other_user}","gists_url":"https://api.github.com/users/phire/gists{/gist_id}","starred_url":"https://api.github.com/users/phire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phire/subscriptions","organizations_url":"https://api.github.com/users/phire/orgs","repos_url":"https://api.github.com/users/phire/repos","events_url":"https://api.github.com/users/phire/events{/privacy}","received_events_url":"https://api.github.com/users/phire/received_events","type":"User","site_admin":false},"body":"I pulled this patch out of Tino's custom [Ishiiruka-Dolphin](https://forums.dolphin-emu.org/Thread-unofficial-ishiiruka-dolphin-custom-version?highlight=time+stretching) build.\r\nPreviously Dolphin only supported these features on the OpenAL backend.\r\n\r\nThis also fixes [Issue 7955](https://bugs.dolphin-emu.org/issues/7955). Yes, I extracted this patch just so that issue could be closed.\r\n\r\nI'm assigning attribution of this patch to @Tino, as he did 99% of the work, I just extracted it and did a few formatting changes.","created_at":"2015-09-17T15:44:01Z","updated_at":"2015-09-17T16:10:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25e17099a6b6cc6830e419656e195b182909041f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3053/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3053/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3053/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/ebee3cfc16a6093aae52e53936baf41e57090b1d","head":{"label":"phire:ishiiruka_timestreching","ref":"ishiiruka_timestreching","sha":"ebee3cfc16a6093aae52e53936baf41e57090b1d","user":{"login":"phire","id":138484,"avatar_url":"https://avatars.githubusercontent.com/u/138484?v=3","gravatar_id":"","url":"https://api.github.com/users/phire","html_url":"https://github.com/phire","followers_url":"https://api.github.com/users/phire/followers","following_url":"https://api.github.com/users/phire/following{/other_user}","gists_url":"https://api.github.com/users/phire/gists{/gist_id}","starred_url":"https://api.github.com/users/phire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phire/subscriptions","organizations_url":"https://api.github.com/users/phire/orgs","repos_url":"https://api.github.com/users/phire/repos","events_url":"https://api.github.com/users/phire/events{/privacy}","received_events_url":"https://api.github.com/users/phire/received_events","type":"User","site_admin":false},"repo":{"id":16432729,"name":"dolphin","full_name":"phire/dolphin","owner":{"login":"phire","id":138484,"avatar_url":"https://avatars.githubusercontent.com/u/138484?v=3","gravatar_id":"","url":"https://api.github.com/users/phire","html_url":"https://github.com/phire","followers_url":"https://api.github.com/users/phire/followers","following_url":"https://api.github.com/users/phire/following{/other_user}","gists_url":"https://api.github.com/users/phire/gists{/gist_id}","starred_url":"https://api.github.com/users/phire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phire/subscriptions","organizations_url":"https://api.github.com/users/phire/orgs","repos_url":"https://api.github.com/users/phire/repos","events_url":"https://api.github.com/users/phire/events{/privacy}","received_events_url":"https://api.github.com/users/phire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phire/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/phire/dolphin","forks_url":"https://api.github.com/repos/phire/dolphin/forks","keys_url":"https://api.github.com/repos/phire/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phire/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phire/dolphin/teams","hooks_url":"https://api.github.com/repos/phire/dolphin/hooks","issue_events_url":"https://api.github.com/repos/phire/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/phire/dolphin/events","assignees_url":"https://api.github.com/repos/phire/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/phire/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/phire/dolphin/tags","blobs_url":"https://api.github.com/repos/phire/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phire/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phire/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/phire/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phire/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/phire/dolphin/languages","stargazers_url":"https://api.github.com/repos/phire/dolphin/stargazers","contributors_url":"https://api.github.com/repos/phire/dolphin/contributors","subscribers_url":"https://api.github.com/repos/phire/dolphin/subscribers","subscription_url":"https://api.github.com/repos/phire/dolphin/subscription","commits_url":"https://api.github.com/repos/phire/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/phire/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/phire/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/phire/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/phire/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/phire/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phire/dolphin/merges","archive_url":"https://api.github.com/repos/phire/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phire/dolphin/downloads","issues_url":"https://api.github.com/repos/phire/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/phire/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/phire/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/phire/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phire/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/phire/dolphin/releases{/id}","created_at":"2014-02-01T11:17:19Z","updated_at":"2015-04-16T04:27:36Z","pushed_at":"2015-09-17T15:40:04Z","git_url":"git://github.com/phire/dolphin.git","ssh_url":"git@github.com:phire/dolphin.git","clone_url":"https://github.com/phire/dolphin.git","svn_url":"https://github.com/phire/dolphin","homepage":null,"size":225506,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"52de4cc476429d77240434c4c0c6fcaff353f39a","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-09-17T12:57:02Z","pushed_at":"2015-09-17T15:51:59Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":308437,"stargazers_count":1647,"watchers_count":1647,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":518,"mirror_url":null,"open_issues_count":75,"forks":518,"open_issues":75,"watchers":1647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3053"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3053"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3053"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3053/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3053/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3053/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/ebee3cfc16a6093aae52e53936baf41e57090b1d"}}}}