{"action":"created","comment":{"url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/comments/32587174","id":32587174,"diff_hunk":"@@ -318,7 +320,20 @@ private void parseNextRecordBody(long recordSize, byte tag) throws IOException {\n         if (VERBOSE) {\n           System.out.println(\"Heap dump\");\n         }\n-        new HeapDumpSegmentParser(getPointerSize(), recordSize, currentMainParsePosition, in).run();","path":"src/main/java/org/threadly/heap/parser/HprofParser.java","position":226,"original_position":226,"commit_id":"95481dc1c854e624be084347db4718599cac5ca2","original_commit_id":"95481dc1c854e624be084347db4718599cac5ca2","user":{"login":"jentfoo","id":2165757,"avatar_url":"https://avatars.githubusercontent.com/u/2165757?v=3","gravatar_id":"","url":"https://api.github.com/users/jentfoo","html_url":"https://github.com/jentfoo","followers_url":"https://api.github.com/users/jentfoo/followers","following_url":"https://api.github.com/users/jentfoo/following{/other_user}","gists_url":"https://api.github.com/users/jentfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jentfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jentfoo/subscriptions","organizations_url":"https://api.github.com/users/jentfoo/orgs","repos_url":"https://api.github.com/users/jentfoo/repos","events_url":"https://api.github.com/users/jentfoo/events{/privacy}","received_events_url":"https://api.github.com/users/jentfoo/received_events","type":"User","site_admin":false},"body":"There is no benefit using a RAF or threading this out.  I actually have never found any heap dumps that have this tag....but my understanding is if this tag does exist, there will be only one, so we might as well parse it in thread.\r\n\r\nI would prefer to go back to the simpler logic that I had before hand because of that.","created_at":"2015-06-17T00:44:46Z","updated_at":"2015-06-17T00:44:46Z","html_url":"https://github.com/jentfoo/heapDumpAnalyzer/pull/1#discussion_r32587174","pull_request_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/comments/32587174"},"html":{"href":"https://github.com/jentfoo/heapDumpAnalyzer/pull/1#discussion_r32587174"},"pull_request":{"href":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/1","id":37848158,"html_url":"https://github.com/jentfoo/heapDumpAnalyzer/pull/1","diff_url":"https://github.com/jentfoo/heapDumpAnalyzer/pull/1.diff","patch_url":"https://github.com/jentfoo/heapDumpAnalyzer/pull/1.patch","issue_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/issues/1","number":1,"state":"open","locked":false,"title":"fixed NPE issue on un bound class arrays.  Fixed analyse NPE when the…","user":{"login":"lwahlmeier","id":4663016,"avatar_url":"https://avatars.githubusercontent.com/u/4663016?v=3","gravatar_id":"","url":"https://api.github.com/users/lwahlmeier","html_url":"https://github.com/lwahlmeier","followers_url":"https://api.github.com/users/lwahlmeier/followers","following_url":"https://api.github.com/users/lwahlmeier/following{/other_user}","gists_url":"https://api.github.com/users/lwahlmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/lwahlmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwahlmeier/subscriptions","organizations_url":"https://api.github.com/users/lwahlmeier/orgs","repos_url":"https://api.github.com/users/lwahlmeier/repos","events_url":"https://api.github.com/users/lwahlmeier/events{/privacy}","received_events_url":"https://api.github.com/users/lwahlmeier/received_events","type":"User","site_admin":false},"body":"…re are no parent objects.  Some minor output logging changes and 1 speed up when building large array objects","created_at":"2015-06-16T22:19:50Z","updated_at":"2015-06-17T00:44:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94cc77b5145639b2f15893fec7aa0fee6b944b72","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/issues/1/comments","statuses_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/statuses/95481dc1c854e624be084347db4718599cac5ca2","head":{"label":"lwahlmeier:memory_saver","ref":"memory_saver","sha":"95481dc1c854e624be084347db4718599cac5ca2","user":{"login":"lwahlmeier","id":4663016,"avatar_url":"https://avatars.githubusercontent.com/u/4663016?v=3","gravatar_id":"","url":"https://api.github.com/users/lwahlmeier","html_url":"https://github.com/lwahlmeier","followers_url":"https://api.github.com/users/lwahlmeier/followers","following_url":"https://api.github.com/users/lwahlmeier/following{/other_user}","gists_url":"https://api.github.com/users/lwahlmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/lwahlmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwahlmeier/subscriptions","organizations_url":"https://api.github.com/users/lwahlmeier/orgs","repos_url":"https://api.github.com/users/lwahlmeier/repos","events_url":"https://api.github.com/users/lwahlmeier/events{/privacy}","received_events_url":"https://api.github.com/users/lwahlmeier/received_events","type":"User","site_admin":false},"repo":{"id":37558844,"name":"heapDumpAnalyzer","full_name":"lwahlmeier/heapDumpAnalyzer","owner":{"login":"lwahlmeier","id":4663016,"avatar_url":"https://avatars.githubusercontent.com/u/4663016?v=3","gravatar_id":"","url":"https://api.github.com/users/lwahlmeier","html_url":"https://github.com/lwahlmeier","followers_url":"https://api.github.com/users/lwahlmeier/followers","following_url":"https://api.github.com/users/lwahlmeier/following{/other_user}","gists_url":"https://api.github.com/users/lwahlmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/lwahlmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwahlmeier/subscriptions","organizations_url":"https://api.github.com/users/lwahlmeier/orgs","repos_url":"https://api.github.com/users/lwahlmeier/repos","events_url":"https://api.github.com/users/lwahlmeier/events{/privacy}","received_events_url":"https://api.github.com/users/lwahlmeier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lwahlmeier/heapDumpAnalyzer","description":"High performance analyzer for java heap dump files.","fork":true,"url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer","forks_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/forks","keys_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/teams","hooks_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/hooks","issue_events_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/issues/events{/number}","events_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/events","assignees_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/assignees{/user}","branches_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/branches{/branch}","tags_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/tags","blobs_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/languages","stargazers_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/stargazers","contributors_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/contributors","subscribers_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/subscribers","subscription_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/subscription","commits_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/contents/{+path}","compare_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/merges","archive_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/downloads","issues_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/issues{/number}","pulls_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/labels{/name}","releases_url":"https://api.github.com/repos/lwahlmeier/heapDumpAnalyzer/releases{/id}","created_at":"2015-06-16T22:13:28Z","updated_at":"2015-06-16T22:13:28Z","pushed_at":"2015-06-16T22:19:04Z","git_url":"git://github.com/lwahlmeier/heapDumpAnalyzer.git","ssh_url":"git@github.com:lwahlmeier/heapDumpAnalyzer.git","clone_url":"https://github.com/lwahlmeier/heapDumpAnalyzer.git","svn_url":"https://github.com/lwahlmeier/heapDumpAnalyzer","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jentfoo:memory_saver","ref":"memory_saver","sha":"5f0f49f6e81f9e3c6d224a2732b11b79109cb108","user":{"login":"jentfoo","id":2165757,"avatar_url":"https://avatars.githubusercontent.com/u/2165757?v=3","gravatar_id":"","url":"https://api.github.com/users/jentfoo","html_url":"https://github.com/jentfoo","followers_url":"https://api.github.com/users/jentfoo/followers","following_url":"https://api.github.com/users/jentfoo/following{/other_user}","gists_url":"https://api.github.com/users/jentfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jentfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jentfoo/subscriptions","organizations_url":"https://api.github.com/users/jentfoo/orgs","repos_url":"https://api.github.com/users/jentfoo/repos","events_url":"https://api.github.com/users/jentfoo/events{/privacy}","received_events_url":"https://api.github.com/users/jentfoo/received_events","type":"User","site_admin":false},"repo":{"id":37301401,"name":"heapDumpAnalyzer","full_name":"jentfoo/heapDumpAnalyzer","owner":{"login":"jentfoo","id":2165757,"avatar_url":"https://avatars.githubusercontent.com/u/2165757?v=3","gravatar_id":"","url":"https://api.github.com/users/jentfoo","html_url":"https://github.com/jentfoo","followers_url":"https://api.github.com/users/jentfoo/followers","following_url":"https://api.github.com/users/jentfoo/following{/other_user}","gists_url":"https://api.github.com/users/jentfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jentfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jentfoo/subscriptions","organizations_url":"https://api.github.com/users/jentfoo/orgs","repos_url":"https://api.github.com/users/jentfoo/repos","events_url":"https://api.github.com/users/jentfoo/events{/privacy}","received_events_url":"https://api.github.com/users/jentfoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jentfoo/heapDumpAnalyzer","description":"High performance analyzer for java heap dump files.","fork":false,"url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer","forks_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/forks","keys_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/teams","hooks_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/hooks","issue_events_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/issues/events{/number}","events_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/events","assignees_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/assignees{/user}","branches_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/branches{/branch}","tags_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/tags","blobs_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/languages","stargazers_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/stargazers","contributors_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/contributors","subscribers_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/subscribers","subscription_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/subscription","commits_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/contents/{+path}","compare_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/merges","archive_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/downloads","issues_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/issues{/number}","pulls_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/labels{/name}","releases_url":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/releases{/id}","created_at":"2015-06-12T04:08:52Z","updated_at":"2015-06-16T22:13:25Z","pushed_at":"2015-06-16T22:19:50Z","git_url":"git://github.com/jentfoo/heapDumpAnalyzer.git","ssh_url":"git@github.com:jentfoo/heapDumpAnalyzer.git","clone_url":"https://github.com/jentfoo/heapDumpAnalyzer.git","svn_url":"https://github.com/jentfoo/heapDumpAnalyzer","homepage":null,"size":0,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/1"},"html":{"href":"https://github.com/jentfoo/heapDumpAnalyzer/pull/1"},"issue":{"href":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/issues/1"},"comments":{"href":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jentfoo/heapDumpAnalyzer/statuses/95481dc1c854e624be084347db4718599cac5ca2"}}}}