{"action":"created","comment":{"url":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/comments/29478065","id":29478065,"diff_hunk":"@@ -2,8 +2,13 @@\n require \"datetime_helper/active_model\"\n \n describe DatetimeHelper::Validators::ZuluTimeValidator do\n-  let(:validator) { described_class.new({attributes: [:updated_at]})}\n-  let(:model)     { double('model') }\n+  let(:validator)      { described_class.new({attributes: [:updated_at]})}\n+  let(:model)          { double('model') }\n+\n+  # if, by chance, you happen to be running these tests\n+  # on a machine set to UTC+0 then the local time tests\n+  # won't really be a valid test.\n+  let(:already_in_utc) { Time.now.utc == Time.now.getlocal }","path":"spec/validators/zulu_time_active_model_validator_spec.rb","position":12,"original_position":12,"commit_id":"cc6f453d1ee56cd0502d08751a1abc622f073ea6","original_commit_id":"4af9f5a1e159d8389d145afdca474e82704fd4cb","user":{"login":"gingermusketeer","id":1177034,"avatar_url":"https://avatars.githubusercontent.com/u/1177034?v=3","gravatar_id":"","url":"https://api.github.com/users/gingermusketeer","html_url":"https://github.com/gingermusketeer","followers_url":"https://api.github.com/users/gingermusketeer/followers","following_url":"https://api.github.com/users/gingermusketeer/following{/other_user}","gists_url":"https://api.github.com/users/gingermusketeer/gists{/gist_id}","starred_url":"https://api.github.com/users/gingermusketeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gingermusketeer/subscriptions","organizations_url":"https://api.github.com/users/gingermusketeer/orgs","repos_url":"https://api.github.com/users/gingermusketeer/repos","events_url":"https://api.github.com/users/gingermusketeer/events{/privacy}","received_events_url":"https://api.github.com/users/gingermusketeer/received_events","type":"User","site_admin":false},"body":"Why don't you just set it to a different time zone?","created_at":"2015-04-30T22:50:53Z","updated_at":"2015-04-30T22:50:53Z","html_url":"https://github.com/westfieldlabs/datetime_helper/pull/8#discussion_r29478065","pull_request_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/comments/29478065"},"html":{"href":"https://github.com/westfieldlabs/datetime_helper/pull/8#discussion_r29478065"},"pull_request":{"href":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/8","id":34508374,"html_url":"https://github.com/westfieldlabs/datetime_helper/pull/8","diff_url":"https://github.com/westfieldlabs/datetime_helper/pull/8.diff","patch_url":"https://github.com/westfieldlabs/datetime_helper/pull/8.patch","issue_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/issues/8","number":8,"state":"open","locked":false,"title":"[Optimisation, #7] cleanup spelling, change license, enhance readme","user":{"login":"davesag","id":387098,"avatar_url":"https://avatars.githubusercontent.com/u/387098?v=3","gravatar_id":"","url":"https://api.github.com/users/davesag","html_url":"https://github.com/davesag","followers_url":"https://api.github.com/users/davesag/followers","following_url":"https://api.github.com/users/davesag/following{/other_user}","gists_url":"https://api.github.com/users/davesag/gists{/gist_id}","starred_url":"https://api.github.com/users/davesag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesag/subscriptions","organizations_url":"https://api.github.com/users/davesag/orgs","repos_url":"https://api.github.com/users/davesag/repos","events_url":"https://api.github.com/users/davesag/events{/privacy}","received_events_url":"https://api.github.com/users/davesag/received_events","type":"User","site_admin":false},"body":"Also skip the local time tests in the rare case that the tests are running at UTC+0.  The CI's local time is set to `Australia/Canberra` to avert this issue but there is no predicting where someone else might run the tests.  Other solutions have also been proposed but this is, for now, the absolute simplest.\r\n","created_at":"2015-04-30T22:43:37Z","updated_at":"2015-04-30T22:50:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbb9da01443b36d735202075f7e117d7721e506d","assignee":{"login":"davesag","id":387098,"avatar_url":"https://avatars.githubusercontent.com/u/387098?v=3","gravatar_id":"","url":"https://api.github.com/users/davesag","html_url":"https://github.com/davesag","followers_url":"https://api.github.com/users/davesag/followers","following_url":"https://api.github.com/users/davesag/following{/other_user}","gists_url":"https://api.github.com/users/davesag/gists{/gist_id}","starred_url":"https://api.github.com/users/davesag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesag/subscriptions","organizations_url":"https://api.github.com/users/davesag/orgs","repos_url":"https://api.github.com/users/davesag/repos","events_url":"https://api.github.com/users/davesag/events{/privacy}","received_events_url":"https://api.github.com/users/davesag/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/westfieldlabs/datetime_helper/milestones/4","html_url":"https://github.com/westfieldlabs/datetime_helper/milestones/1.0.0%20release","labels_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/milestones/4/labels","id":1090123,"number":4,"title":"1.0.0 release","description":"I'd like a final few sets of eyes on this before it goes out as V1\r\n","creator":{"login":"davesag","id":387098,"avatar_url":"https://avatars.githubusercontent.com/u/387098?v=3","gravatar_id":"","url":"https://api.github.com/users/davesag","html_url":"https://github.com/davesag","followers_url":"https://api.github.com/users/davesag/followers","following_url":"https://api.github.com/users/davesag/following{/other_user}","gists_url":"https://api.github.com/users/davesag/gists{/gist_id}","starred_url":"https://api.github.com/users/davesag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesag/subscriptions","organizations_url":"https://api.github.com/users/davesag/orgs","repos_url":"https://api.github.com/users/davesag/repos","events_url":"https://api.github.com/users/davesag/events{/privacy}","received_events_url":"https://api.github.com/users/davesag/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-04-29T23:52:46Z","updated_at":"2015-04-30T22:43:37Z","due_on":"2015-04-30T14:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/8/commits","review_comments_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/8/comments","review_comment_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/issues/8/comments","statuses_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/statuses/cc6f453d1ee56cd0502d08751a1abc622f073ea6","head":{"label":"davesag:7_cleanup","ref":"7_cleanup","sha":"cc6f453d1ee56cd0502d08751a1abc622f073ea6","user":{"login":"davesag","id":387098,"avatar_url":"https://avatars.githubusercontent.com/u/387098?v=3","gravatar_id":"","url":"https://api.github.com/users/davesag","html_url":"https://github.com/davesag","followers_url":"https://api.github.com/users/davesag/followers","following_url":"https://api.github.com/users/davesag/following{/other_user}","gists_url":"https://api.github.com/users/davesag/gists{/gist_id}","starred_url":"https://api.github.com/users/davesag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesag/subscriptions","organizations_url":"https://api.github.com/users/davesag/orgs","repos_url":"https://api.github.com/users/davesag/repos","events_url":"https://api.github.com/users/davesag/events{/privacy}","received_events_url":"https://api.github.com/users/davesag/received_events","type":"User","site_admin":false},"repo":{"id":34702801,"name":"datetime_helper","full_name":"davesag/datetime_helper","owner":{"login":"davesag","id":387098,"avatar_url":"https://avatars.githubusercontent.com/u/387098?v=3","gravatar_id":"","url":"https://api.github.com/users/davesag","html_url":"https://github.com/davesag","followers_url":"https://api.github.com/users/davesag/followers","following_url":"https://api.github.com/users/davesag/following{/other_user}","gists_url":"https://api.github.com/users/davesag/gists{/gist_id}","starred_url":"https://api.github.com/users/davesag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesag/subscriptions","organizations_url":"https://api.github.com/users/davesag/orgs","repos_url":"https://api.github.com/users/davesag/repos","events_url":"https://api.github.com/users/davesag/events{/privacy}","received_events_url":"https://api.github.com/users/davesag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davesag/datetime_helper","description":null,"fork":true,"url":"https://api.github.com/repos/davesag/datetime_helper","forks_url":"https://api.github.com/repos/davesag/datetime_helper/forks","keys_url":"https://api.github.com/repos/davesag/datetime_helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davesag/datetime_helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davesag/datetime_helper/teams","hooks_url":"https://api.github.com/repos/davesag/datetime_helper/hooks","issue_events_url":"https://api.github.com/repos/davesag/datetime_helper/issues/events{/number}","events_url":"https://api.github.com/repos/davesag/datetime_helper/events","assignees_url":"https://api.github.com/repos/davesag/datetime_helper/assignees{/user}","branches_url":"https://api.github.com/repos/davesag/datetime_helper/branches{/branch}","tags_url":"https://api.github.com/repos/davesag/datetime_helper/tags","blobs_url":"https://api.github.com/repos/davesag/datetime_helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davesag/datetime_helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davesag/datetime_helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/davesag/datetime_helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davesag/datetime_helper/statuses/{sha}","languages_url":"https://api.github.com/repos/davesag/datetime_helper/languages","stargazers_url":"https://api.github.com/repos/davesag/datetime_helper/stargazers","contributors_url":"https://api.github.com/repos/davesag/datetime_helper/contributors","subscribers_url":"https://api.github.com/repos/davesag/datetime_helper/subscribers","subscription_url":"https://api.github.com/repos/davesag/datetime_helper/subscription","commits_url":"https://api.github.com/repos/davesag/datetime_helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/davesag/datetime_helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/davesag/datetime_helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/davesag/datetime_helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/davesag/datetime_helper/contents/{+path}","compare_url":"https://api.github.com/repos/davesag/datetime_helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davesag/datetime_helper/merges","archive_url":"https://api.github.com/repos/davesag/datetime_helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davesag/datetime_helper/downloads","issues_url":"https://api.github.com/repos/davesag/datetime_helper/issues{/number}","pulls_url":"https://api.github.com/repos/davesag/datetime_helper/pulls{/number}","milestones_url":"https://api.github.com/repos/davesag/datetime_helper/milestones{/number}","notifications_url":"https://api.github.com/repos/davesag/datetime_helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davesag/datetime_helper/labels{/name}","releases_url":"https://api.github.com/repos/davesag/datetime_helper/releases{/id}","created_at":"2015-04-28T02:16:25Z","updated_at":"2015-04-29T23:49:52Z","pushed_at":"2015-04-30T22:49:23Z","git_url":"git://github.com/davesag/datetime_helper.git","ssh_url":"git@github.com:davesag/datetime_helper.git","clone_url":"https://github.com/davesag/datetime_helper.git","svn_url":"https://github.com/davesag/datetime_helper","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"westfieldlabs:master","ref":"master","sha":"4805301e3bbf9c61c292a51452873598e6d5d6af","user":{"login":"westfieldlabs","id":4454594,"avatar_url":"https://avatars.githubusercontent.com/u/4454594?v=3","gravatar_id":"","url":"https://api.github.com/users/westfieldlabs","html_url":"https://github.com/westfieldlabs","followers_url":"https://api.github.com/users/westfieldlabs/followers","following_url":"https://api.github.com/users/westfieldlabs/following{/other_user}","gists_url":"https://api.github.com/users/westfieldlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/westfieldlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westfieldlabs/subscriptions","organizations_url":"https://api.github.com/users/westfieldlabs/orgs","repos_url":"https://api.github.com/users/westfieldlabs/repos","events_url":"https://api.github.com/users/westfieldlabs/events{/privacy}","received_events_url":"https://api.github.com/users/westfieldlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":34700280,"name":"datetime_helper","full_name":"westfieldlabs/datetime_helper","owner":{"login":"westfieldlabs","id":4454594,"avatar_url":"https://avatars.githubusercontent.com/u/4454594?v=3","gravatar_id":"","url":"https://api.github.com/users/westfieldlabs","html_url":"https://github.com/westfieldlabs","followers_url":"https://api.github.com/users/westfieldlabs/followers","following_url":"https://api.github.com/users/westfieldlabs/following{/other_user}","gists_url":"https://api.github.com/users/westfieldlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/westfieldlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/westfieldlabs/subscriptions","organizations_url":"https://api.github.com/users/westfieldlabs/orgs","repos_url":"https://api.github.com/users/westfieldlabs/repos","events_url":"https://api.github.com/users/westfieldlabs/events{/privacy}","received_events_url":"https://api.github.com/users/westfieldlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/westfieldlabs/datetime_helper","description":null,"fork":false,"url":"https://api.github.com/repos/westfieldlabs/datetime_helper","forks_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/forks","keys_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/teams","hooks_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/hooks","issue_events_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/issues/events{/number}","events_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/events","assignees_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/assignees{/user}","branches_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/branches{/branch}","tags_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/tags","blobs_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/statuses/{sha}","languages_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/languages","stargazers_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/stargazers","contributors_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/contributors","subscribers_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/subscribers","subscription_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/subscription","commits_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/contents/{+path}","compare_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/merges","archive_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/downloads","issues_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/issues{/number}","pulls_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls{/number}","milestones_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/milestones{/number}","notifications_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/labels{/name}","releases_url":"https://api.github.com/repos/westfieldlabs/datetime_helper/releases{/id}","created_at":"2015-04-28T01:17:06Z","updated_at":"2015-04-29T23:49:19Z","pushed_at":"2015-04-30T22:49:24Z","git_url":"git://github.com/westfieldlabs/datetime_helper.git","ssh_url":"git@github.com:westfieldlabs/datetime_helper.git","clone_url":"https://github.com/westfieldlabs/datetime_helper.git","svn_url":"https://github.com/westfieldlabs/datetime_helper","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/8"},"html":{"href":"https://github.com/westfieldlabs/datetime_helper/pull/8"},"issue":{"href":"https://api.github.com/repos/westfieldlabs/datetime_helper/issues/8"},"comments":{"href":"https://api.github.com/repos/westfieldlabs/datetime_helper/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/westfieldlabs/datetime_helper/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/westfieldlabs/datetime_helper/statuses/cc6f453d1ee56cd0502d08751a1abc622f073ea6"}}}}