{"action":"created","issue":{"url":"https://api.github.com/repos/OmniLayer/omnicore/issues/3","labels_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/3/comments","events_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/3/events","html_url":"https://github.com/OmniLayer/omnicore/pull/3","id":64224212,"number":3,"title":"Class C support for 0.0.10","user":{"login":"zathras-crypto","id":5633351,"avatar_url":"https://avatars.githubusercontent.com/u/5633351?v=3","gravatar_id":"","url":"https://api.github.com/users/zathras-crypto","html_url":"https://github.com/zathras-crypto","followers_url":"https://api.github.com/users/zathras-crypto/followers","following_url":"https://api.github.com/users/zathras-crypto/following{/other_user}","gists_url":"https://api.github.com/users/zathras-crypto/gists{/gist_id}","starred_url":"https://api.github.com/users/zathras-crypto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zathras-crypto/subscriptions","organizations_url":"https://api.github.com/users/zathras-crypto/orgs","repos_url":"https://api.github.com/users/zathras-crypto/repos","events_url":"https://api.github.com/users/zathras-crypto/events{/privacy}","received_events_url":"https://api.github.com/users/zathras-crypto/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OmniLayer/omnicore/labels/work%20in%20progress","name":"work in progress","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-03-25T09:20:45Z","updated_at":"2015-04-06T00:00:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OmniLayer/omnicore/pulls/3","html_url":"https://github.com/OmniLayer/omnicore/pull/3","diff_url":"https://github.com/OmniLayer/omnicore/pull/3.diff","patch_url":"https://github.com/OmniLayer/omnicore/pull/3.patch"},"body":"Note: Not yet final.\r\nAlso pending outcome of https://github.com/mastercoin-MSC/spec/issues/281.\r\n\r\nThis PR adds Class C support for both encoding and decoding.  Class C in the current context (but open to change) is:\r\n* Data packet moved to OP_RETURN output\r\n* Data packet is not obfuscated\r\n* Exodus marker removed and replaced with ```omni``` bytes at beginning of OP_RETURN output\r\n\r\nA singular send function (```ClassAgnostic_send```) is now used which will default to Class C if the packet is small enough, otherwise falling back to class B.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/OmniLayer/omnicore/issues/comments/89870721","html_url":"https://github.com/OmniLayer/omnicore/pull/3#issuecomment-89870721","issue_url":"https://api.github.com/repos/OmniLayer/omnicore/issues/3","id":89870721,"user":{"login":"zathras-crypto","id":5633351,"avatar_url":"https://avatars.githubusercontent.com/u/5633351?v=3","gravatar_id":"","url":"https://api.github.com/users/zathras-crypto","html_url":"https://github.com/zathras-crypto","followers_url":"https://api.github.com/users/zathras-crypto/followers","following_url":"https://api.github.com/users/zathras-crypto/following{/other_user}","gists_url":"https://api.github.com/users/zathras-crypto/gists{/gist_id}","starred_url":"https://api.github.com/users/zathras-crypto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zathras-crypto/subscriptions","organizations_url":"https://api.github.com/users/zathras-crypto/orgs","repos_url":"https://api.github.com/users/zathras-crypto/repos","events_url":"https://api.github.com/users/zathras-crypto/events{/privacy}","received_events_url":"https://api.github.com/users/zathras-crypto/received_events","type":"User","site_admin":false},"created_at":"2015-04-06T00:00:50Z","updated_at":"2015-04-06T00:00:50Z","body":"Yeah I did already consider the RPC interface, basically ```class*_send``` has been morphed into ```classAgnosticWalletTXBuilder``` and the process is largely to simply do some checks, call ```CreatePayload_type``` and pass that into ```classAgnosticWalletTXBuilder``` from each RPC call (or UI element) that wants to create a transaction.\r\n\r\nThere are bits I put in too like for example you can start with ```---autocommit=false``` and then all send RPC commands will return the raw hex for the created tx instead of committing and broadcasting and returning a txid (figured that would help with testing after talking with @msgilligan).\r\n\r\nI'm fleshing it all out and it'll be ready to push soon, though it's all merged with Class C stuff now so I may close this PR and open another (sadly larger in scope) PR to reflect what I've changed properly.\r\n\r\nSpeaking of RPC, pinging everyone here for commentary on whether the nomenclature is OK?\r\n```\r\nzathras@zlappy:~/github/build/mastercore$ grep _OMNI src/rpcserver.cpp \r\n    { \"omni layer\",   \"send_OMNI\",                    &send_OMNI,                     false,  false,  true },\r\n    { \"omni layer\",   \"senddexsell_OMNI\",             &senddexsell_OMNI,              false,  false,  true },\r\n    { \"omni layer\",   \"senddexaccept_OMNI\",           &senddexaccept_OMNI,            false,  false,  true },\r\n    { \"omni layer\",   \"sendissuancecrowdsale_OMNI\",   &sendissuancecrowdsale_OMNI,    false,  false,  true },\r\n    { \"omni layer\",   \"sendissuancefixed_OMNI\",       &sendissuancefixed_OMNI,        false,  false,  true },\r\n    { \"omni layer\",   \"sendissuancemanual_OMNI\",      &sendissuancemanual_OMNI,       false,  false,  true },\r\n    { \"omni layer\",   \"sendsto_OMNI\",                 &sendsto_OMNI,                  false,  false,  true },\r\n    { \"omni layer\",   \"sendgrant_OMNI\",               &sendgrant_OMNI,                false,  false,  true },\r\n    { \"omni layer\",   \"sendrevoke_OMNI\",              &sendrevoke_OMNI,               false,  false,  true },\r\n    { \"omni layer\",   \"sendclosecrowdsale_OMNI\",      &sendclosecrowdsale_OMNI,       false,  false,  true },\r\n    { \"omni layer\",   \"sendtrade_OMNI\",               &sendtrade_OMNI,                false,  false,  true },\r\n    { \"omni layer\",   \"sendchangeissuer_OMNI\",        &sendchangeissuer_OMNI,         false,  false,  true },\r\n```\r\nNote aliases for ```send_MP``` > ```send_OMNI``` and ```sendtoowners_MP``` > ```sendsto_OMNI``` and so on will be employed for backwards compatibility."}}