{"action":"created","issue":{"url":"https://api.github.com/repos/ably/ably-go/issues/39","labels_url":"https://api.github.com/repos/ably/ably-go/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/ably/ably-go/issues/39/comments","events_url":"https://api.github.com/repos/ably/ably-go/issues/39/events","html_url":"https://github.com/ably/ably-go/pull/39","id":100450442,"number":39,"title":"MsgPack support; reworked Stat data type; updated deps","user":{"login":"rjeczalik","id":1162017,"avatar_url":"https://avatars.githubusercontent.com/u/1162017?v=3","gravatar_id":"","url":"https://api.github.com/users/rjeczalik","html_url":"https://github.com/rjeczalik","followers_url":"https://api.github.com/users/rjeczalik/followers","following_url":"https://api.github.com/users/rjeczalik/following{/other_user}","gists_url":"https://api.github.com/users/rjeczalik/gists{/gist_id}","starred_url":"https://api.github.com/users/rjeczalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjeczalik/subscriptions","organizations_url":"https://api.github.com/users/rjeczalik/orgs","repos_url":"https://api.github.com/users/rjeczalik/repos","events_url":"https://api.github.com/users/rjeczalik/events{/privacy}","received_events_url":"https://api.github.com/users/rjeczalik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-12T02:08:33Z","updated_at":"2015-08-13T11:28:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ably/ably-go/pulls/39","html_url":"https://github.com/ably/ably-go/pull/39","diff_url":"https://github.com/ably/ably-go/pull/39.diff","patch_url":"https://github.com/ably/ably-go/pull/39.patch"},"body":"During adding full support for MsgPack I've encountered a couple of decoding failures, at first though it may be library problems thus I've updated all deps. Then it turned out to be a problem with decoding maps with custom unmarshallers - the problem is workarounded with this CL. Moreover it fixes one nil ptr deref, reworks Stats data struct fixing problems with MsgPack encoding of the old struct and add ones test.\r\n\r\nOriginally I tried to aim at adding more tests to have covered fully the Go Spec for realtime client, but eventually found out I need to fix those blockers first.\r\n\r\n/cc @mattheworiordan @lmars @kouno Please take a look.\r\n\r\nPS Rework of the Go Spec summary is still in progress, I'll update you when I'm done."},"comment":{"url":"https://api.github.com/repos/ably/ably-go/issues/comments/130628874","html_url":"https://github.com/ably/ably-go/pull/39#issuecomment-130628874","issue_url":"https://api.github.com/repos/ably/ably-go/issues/39","id":130628874,"user":{"login":"rjeczalik","id":1162017,"avatar_url":"https://avatars.githubusercontent.com/u/1162017?v=3","gravatar_id":"","url":"https://api.github.com/users/rjeczalik","html_url":"https://github.com/rjeczalik","followers_url":"https://api.github.com/users/rjeczalik/followers","following_url":"https://api.github.com/users/rjeczalik/following{/other_user}","gists_url":"https://api.github.com/users/rjeczalik/gists{/gist_id}","starred_url":"https://api.github.com/users/rjeczalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjeczalik/subscriptions","organizations_url":"https://api.github.com/users/rjeczalik/orgs","repos_url":"https://api.github.com/users/rjeczalik/repos","events_url":"https://api.github.com/users/rjeczalik/events{/privacy}","received_events_url":"https://api.github.com/users/rjeczalik/received_events","type":"User","site_admin":false},"created_at":"2015-08-13T11:28:05Z","updated_at":"2015-08-13T11:28:05Z","body":"@mattheworiordan: I've update Travis, please take a look.\r\n\r\nThe test failure:\r\n\r\n```\r\n--- FAIL: TestRealtimePresence_EnsureChannelIsAttached (3.05s)\r\n\trealtime_presence_test.go:135: clientID=\"client_bool\" not found in presence map\r\n```\r\n\r\nis related to #35, the reworked implementation with sync.Mutex gives flaky results, I'll need to change it back to sync.WaitGroup in seperate PR (@kouno)."}}