{"action":"created","comment":{"url":"https://api.github.com/repos/uber/tchannel-node/pulls/comments/45781635","id":45781635,"diff_hunk":"@@ -41,17 +41,14 @@ function TChannelAsThrift(opts) {\n \n     var self = this;\n \n-    assert(opts && typeof opts.source === 'string',\n-        'must pass source as an argument');\n-\n     self.thriftSource = opts.source;\n-    self.thriftFileName = opts.thriftFileName || 'service.thrift';\n+    self.thriftFileName = path.basename(opts.entryPoint || 'service.thrift');\n     self.spec = new thriftrw.Thrift({\n         entryPoint: opts.entryPoint,\n         idls: opts.idls,\n         source: self.thriftSource,\n         strict: opts.strict,\n-        allowFilesystemAccess: opts.allowFilesystemAccess,\n+        allowFilesystemAccess: true,","path":"as/thrift.js","position":16,"original_position":16,"commit_id":"2da53b1aba1950c9e9fc1d7f1f0effb1df9b4934","original_commit_id":"2da53b1aba1950c9e9fc1d7f1f0effb1df9b4934","user":{"login":"kriskowal","id":60294,"avatar_url":"https://avatars.githubusercontent.com/u/60294?v=3","gravatar_id":"","url":"https://api.github.com/users/kriskowal","html_url":"https://github.com/kriskowal","followers_url":"https://api.github.com/users/kriskowal/followers","following_url":"https://api.github.com/users/kriskowal/following{/other_user}","gists_url":"https://api.github.com/users/kriskowal/gists{/gist_id}","starred_url":"https://api.github.com/users/kriskowal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriskowal/subscriptions","organizations_url":"https://api.github.com/users/kriskowal/orgs","repos_url":"https://api.github.com/users/kriskowal/repos","events_url":"https://api.github.com/users/kriskowal/events{/privacy}","received_events_url":"https://api.github.com/users/kriskowal/received_events","type":"User","site_admin":false},"body":"Let’s assume not for now and provide the opposite option later if needed. The only case we would disallow filesystem access for includes is when we construct Thrift from Meta::thriftIDLs, which we only intend to do in tools like tcurl/tcap.","created_at":"2015-11-24T19:24:23Z","updated_at":"2015-11-24T19:24:23Z","html_url":"https://github.com/uber/tchannel-node/pull/210#discussion_r45781635","pull_request_url":"https://api.github.com/repos/uber/tchannel-node/pulls/210","_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/comments/45781635"},"html":{"href":"https://github.com/uber/tchannel-node/pull/210#discussion_r45781635"},"pull_request":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-node/pulls/210","id":51599903,"html_url":"https://github.com/uber/tchannel-node/pull/210","diff_url":"https://github.com/uber/tchannel-node/pull/210.diff","patch_url":"https://github.com/uber/tchannel-node/pull/210.patch","issue_url":"https://api.github.com/repos/uber/tchannel-node/issues/210","number":210,"state":"open","locked":false,"title":"Defer to ThriftRW to assert source/entryPoint option pattern","user":{"login":"kriskowal","id":60294,"avatar_url":"https://avatars.githubusercontent.com/u/60294?v=3","gravatar_id":"","url":"https://api.github.com/users/kriskowal","html_url":"https://github.com/kriskowal","followers_url":"https://api.github.com/users/kriskowal/followers","following_url":"https://api.github.com/users/kriskowal/following{/other_user}","gists_url":"https://api.github.com/users/kriskowal/gists{/gist_id}","starred_url":"https://api.github.com/users/kriskowal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriskowal/subscriptions","organizations_url":"https://api.github.com/users/kriskowal/orgs","repos_url":"https://api.github.com/users/kriskowal/repos","events_url":"https://api.github.com/users/kriskowal/events{/privacy}","received_events_url":"https://api.github.com/users/kriskowal/received_events","type":"User","site_admin":false},"body":"r @malandrew","created_at":"2015-11-24T00:09:50Z","updated_at":"2015-11-24T19:24:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b394ce4d3338170094d73273974625f1042d377f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel-node/pulls/210/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel-node/pulls/210/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel-node/issues/210/comments","statuses_url":"https://api.github.com/repos/uber/tchannel-node/statuses/2da53b1aba1950c9e9fc1d7f1f0effb1df9b4934","head":{"label":"uber:thrift-source-assert","ref":"thrift-source-assert","sha":"2da53b1aba1950c9e9fc1d7f1f0effb1df9b4934","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42619114,"name":"tchannel-node","full_name":"uber/tchannel-node","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-node","description":"","fork":false,"url":"https://api.github.com/repos/uber/tchannel-node","forks_url":"https://api.github.com/repos/uber/tchannel-node/forks","keys_url":"https://api.github.com/repos/uber/tchannel-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-node/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-node/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-node/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-node/events","assignees_url":"https://api.github.com/repos/uber/tchannel-node/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-node/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-node/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-node/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-node/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-node/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-node/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-node/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-node/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-node/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-node/merges","archive_url":"https://api.github.com/repos/uber/tchannel-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-node/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-node/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-node/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-node/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-node/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-node/releases{/id}","created_at":"2015-09-16T23:37:37Z","updated_at":"2015-11-21T16:18:59Z","pushed_at":"2015-11-24T03:02:41Z","git_url":"git://github.com/uber/tchannel-node.git","ssh_url":"git@github.com:uber/tchannel-node.git","clone_url":"https://github.com/uber/tchannel-node.git","svn_url":"https://github.com/uber/tchannel-node","homepage":null,"size":4382,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":33,"forks":1,"open_issues":33,"watchers":24,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"b46dff28c66aa8149772b8487982a52159bbd6e6","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42619114,"name":"tchannel-node","full_name":"uber/tchannel-node","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-node","description":"","fork":false,"url":"https://api.github.com/repos/uber/tchannel-node","forks_url":"https://api.github.com/repos/uber/tchannel-node/forks","keys_url":"https://api.github.com/repos/uber/tchannel-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-node/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-node/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-node/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-node/events","assignees_url":"https://api.github.com/repos/uber/tchannel-node/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-node/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-node/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-node/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-node/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-node/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-node/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-node/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-node/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-node/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-node/merges","archive_url":"https://api.github.com/repos/uber/tchannel-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-node/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-node/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-node/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-node/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-node/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-node/releases{/id}","created_at":"2015-09-16T23:37:37Z","updated_at":"2015-11-21T16:18:59Z","pushed_at":"2015-11-24T03:02:41Z","git_url":"git://github.com/uber/tchannel-node.git","ssh_url":"git@github.com:uber/tchannel-node.git","clone_url":"https://github.com/uber/tchannel-node.git","svn_url":"https://github.com/uber/tchannel-node","homepage":null,"size":4382,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":33,"forks":1,"open_issues":33,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/210"},"html":{"href":"https://github.com/uber/tchannel-node/pull/210"},"issue":{"href":"https://api.github.com/repos/uber/tchannel-node/issues/210"},"comments":{"href":"https://api.github.com/repos/uber/tchannel-node/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel-node/statuses/2da53b1aba1950c9e9fc1d7f1f0effb1df9b4934"}}}}