{"action":"created","comment":{"url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/comments/41981574","id":41981574,"diff_hunk":"@@ -1,84 +0,0 @@\n-package com.acme.tamada_bayanist.rest;\n-\n-import java.io.IOException;\n-import java.net.MalformedURLException;\n-import java.net.URL;\n-import java.util.Scanner;\n-import java.util.concurrent.Callable;\n-import java.util.concurrent.ExecutionException;\n-import java.util.concurrent.TimeUnit;\n-\n-import javax.annotation.PostConstruct;\n-import javax.annotation.PreDestroy;\n-import javax.xml.xpath.XPathExpressionException;\n-\n-import org.joda.time.DateTime;\n-import org.slf4j.Logger;\n-import org.slf4j.LoggerFactory;\n-import org.springframework.beans.factory.annotation.Autowired;\n-import org.springframework.stereotype.Service;\n-import org.xml.sax.SAXException;\n-\n-import com.acme.tamada_bayanist.XmlUtils;\n-import com.acme.tamada_bayanist.properties.CbrProperties;\n-import com.google.common.base.Preconditions;\n-import com.google.common.cache.Cache;\n-import com.google.common.cache.CacheBuilder;\n-\n-/**\n- * <pre>\n- * Рекомендации по работе с веб-сервисами сайта Банка России:\n-- минимизируйте количество вызовов;\n-- минимизируйте количество передаваемой информации;\n-- оптимизируйте логику работы с нашими веб-сервисами;\n-- при использовании полученных данных в своих приложениях и особенно для публикации их на своих интернет или интранет серверах используйте промежуточное хранение информации!\n- * </pre>\n- */\n-@Service\n-public final class CbrService {\n-\n-\tprivate final Cache<String, String> url_xml = CacheBuilder.newBuilder().maximumSize(100).expireAfterWrite(2, TimeUnit.HOURS).build();\n-\n-\tprivate static final Logger log = LoggerFactory.getLogger(CbrService.class);\n-\n-\t@Autowired\n-\tCbrProperties props;\n-\n-\t@PostConstruct\n-\tpublic void init() {\n-\n-\t}\n-\n-\t@PreDestroy\n-\tpublic void shutdown() {","path":"src/main/java/com/acme/tamada_bayanist/rest/CbrService.java","position":53,"original_position":53,"commit_id":"0b61fa35b375629f4d3c475ed3aa1462cb034073","original_commit_id":"0b61fa35b375629f4d3c475ed3aa1462cb034073","user":{"login":"nullpointer-review","id":14871305,"avatar_url":"https://avatars.githubusercontent.com/u/14871305?v=3","gravatar_id":"","url":"https://api.github.com/users/nullpointer-review","html_url":"https://github.com/nullpointer-review","followers_url":"https://api.github.com/users/nullpointer-review/followers","following_url":"https://api.github.com/users/nullpointer-review/following{/other_user}","gists_url":"https://api.github.com/users/nullpointer-review/gists{/gist_id}","starred_url":"https://api.github.com/users/nullpointer-review/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullpointer-review/subscriptions","organizations_url":"https://api.github.com/users/nullpointer-review/orgs","repos_url":"https://api.github.com/users/nullpointer-review/repos","events_url":"https://api.github.com/users/nullpointer-review/events{/privacy}","received_events_url":"https://api.github.com/users/nullpointer-review/received_events","type":"User","site_admin":false},"body":"Это лишнее","created_at":"2015-10-14T11:22:18Z","updated_at":"2015-10-14T11:22:18Z","html_url":"https://github.com/nullpointer-review/currency-rate-api-olimpiks/pull/1#discussion_r41981574","pull_request_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/comments/41981574"},"html":{"href":"https://github.com/nullpointer-review/currency-rate-api-olimpiks/pull/1#discussion_r41981574"},"pull_request":{"href":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/1","id":47637009,"html_url":"https://github.com/nullpointer-review/currency-rate-api-olimpiks/pull/1","diff_url":"https://github.com/nullpointer-review/currency-rate-api-olimpiks/pull/1.diff","patch_url":"https://github.com/nullpointer-review/currency-rate-api-olimpiks/pull/1.patch","issue_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/issues/1","number":1,"state":"open","locked":false,"title":"Code review","user":{"login":"nullpointer-review","id":14871305,"avatar_url":"https://avatars.githubusercontent.com/u/14871305?v=3","gravatar_id":"","url":"https://api.github.com/users/nullpointer-review","html_url":"https://github.com/nullpointer-review","followers_url":"https://api.github.com/users/nullpointer-review/followers","following_url":"https://api.github.com/users/nullpointer-review/following{/other_user}","gists_url":"https://api.github.com/users/nullpointer-review/gists{/gist_id}","starred_url":"https://api.github.com/users/nullpointer-review/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullpointer-review/subscriptions","organizations_url":"https://api.github.com/users/nullpointer-review/orgs","repos_url":"https://api.github.com/users/nullpointer-review/repos","events_url":"https://api.github.com/users/nullpointer-review/events{/privacy}","received_events_url":"https://api.github.com/users/nullpointer-review/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-14T09:39:16Z","updated_at":"2015-10-14T11:22:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e8030232665315ec041dfa9621153d547992c61","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/1/commits","review_comments_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/1/comments","review_comment_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/issues/1/comments","statuses_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/statuses/0b61fa35b375629f4d3c475ed3aa1462cb034073","head":{"label":"nullpointer-review:code_review","ref":"code_review","sha":"0b61fa35b375629f4d3c475ed3aa1462cb034073","user":{"login":"nullpointer-review","id":14871305,"avatar_url":"https://avatars.githubusercontent.com/u/14871305?v=3","gravatar_id":"","url":"https://api.github.com/users/nullpointer-review","html_url":"https://github.com/nullpointer-review","followers_url":"https://api.github.com/users/nullpointer-review/followers","following_url":"https://api.github.com/users/nullpointer-review/following{/other_user}","gists_url":"https://api.github.com/users/nullpointer-review/gists{/gist_id}","starred_url":"https://api.github.com/users/nullpointer-review/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullpointer-review/subscriptions","organizations_url":"https://api.github.com/users/nullpointer-review/orgs","repos_url":"https://api.github.com/users/nullpointer-review/repos","events_url":"https://api.github.com/users/nullpointer-review/events{/privacy}","received_events_url":"https://api.github.com/users/nullpointer-review/received_events","type":"User","site_admin":false},"repo":{"id":44238195,"name":"currency-rate-api-olimpiks","full_name":"nullpointer-review/currency-rate-api-olimpiks","owner":{"login":"nullpointer-review","id":14871305,"avatar_url":"https://avatars.githubusercontent.com/u/14871305?v=3","gravatar_id":"","url":"https://api.github.com/users/nullpointer-review","html_url":"https://github.com/nullpointer-review","followers_url":"https://api.github.com/users/nullpointer-review/followers","following_url":"https://api.github.com/users/nullpointer-review/following{/other_user}","gists_url":"https://api.github.com/users/nullpointer-review/gists{/gist_id}","starred_url":"https://api.github.com/users/nullpointer-review/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullpointer-review/subscriptions","organizations_url":"https://api.github.com/users/nullpointer-review/orgs","repos_url":"https://api.github.com/users/nullpointer-review/repos","events_url":"https://api.github.com/users/nullpointer-review/events{/privacy}","received_events_url":"https://api.github.com/users/nullpointer-review/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nullpointer-review/currency-rate-api-olimpiks","description":"","fork":false,"url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks","forks_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/forks","keys_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/teams","hooks_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/hooks","issue_events_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/issues/events{/number}","events_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/events","assignees_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/assignees{/user}","branches_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/branches{/branch}","tags_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/tags","blobs_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/git/refs{/sha}","trees_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/statuses/{sha}","languages_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/languages","stargazers_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/stargazers","contributors_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/contributors","subscribers_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/subscribers","subscription_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/subscription","commits_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/commits{/sha}","git_commits_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/git/commits{/sha}","comments_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/comments{/number}","issue_comment_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/issues/comments{/number}","contents_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/contents/{+path}","compare_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/merges","archive_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/downloads","issues_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/issues{/number}","pulls_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls{/number}","milestones_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/milestones{/number}","notifications_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/labels{/name}","releases_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/releases{/id}","created_at":"2015-10-14T09:37:58Z","updated_at":"2015-10-14T09:38:17Z","pushed_at":"2015-10-14T09:39:16Z","git_url":"git://github.com/nullpointer-review/currency-rate-api-olimpiks.git","ssh_url":"git@github.com:nullpointer-review/currency-rate-api-olimpiks.git","clone_url":"https://github.com/nullpointer-review/currency-rate-api-olimpiks.git","svn_url":"https://github.com/nullpointer-review/currency-rate-api-olimpiks","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nullpointer-review:master","ref":"master","sha":"258a5e50fba5ba150156d370c7923495a3afc776","user":{"login":"nullpointer-review","id":14871305,"avatar_url":"https://avatars.githubusercontent.com/u/14871305?v=3","gravatar_id":"","url":"https://api.github.com/users/nullpointer-review","html_url":"https://github.com/nullpointer-review","followers_url":"https://api.github.com/users/nullpointer-review/followers","following_url":"https://api.github.com/users/nullpointer-review/following{/other_user}","gists_url":"https://api.github.com/users/nullpointer-review/gists{/gist_id}","starred_url":"https://api.github.com/users/nullpointer-review/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullpointer-review/subscriptions","organizations_url":"https://api.github.com/users/nullpointer-review/orgs","repos_url":"https://api.github.com/users/nullpointer-review/repos","events_url":"https://api.github.com/users/nullpointer-review/events{/privacy}","received_events_url":"https://api.github.com/users/nullpointer-review/received_events","type":"User","site_admin":false},"repo":{"id":44238195,"name":"currency-rate-api-olimpiks","full_name":"nullpointer-review/currency-rate-api-olimpiks","owner":{"login":"nullpointer-review","id":14871305,"avatar_url":"https://avatars.githubusercontent.com/u/14871305?v=3","gravatar_id":"","url":"https://api.github.com/users/nullpointer-review","html_url":"https://github.com/nullpointer-review","followers_url":"https://api.github.com/users/nullpointer-review/followers","following_url":"https://api.github.com/users/nullpointer-review/following{/other_user}","gists_url":"https://api.github.com/users/nullpointer-review/gists{/gist_id}","starred_url":"https://api.github.com/users/nullpointer-review/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullpointer-review/subscriptions","organizations_url":"https://api.github.com/users/nullpointer-review/orgs","repos_url":"https://api.github.com/users/nullpointer-review/repos","events_url":"https://api.github.com/users/nullpointer-review/events{/privacy}","received_events_url":"https://api.github.com/users/nullpointer-review/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nullpointer-review/currency-rate-api-olimpiks","description":"","fork":false,"url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks","forks_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/forks","keys_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/teams","hooks_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/hooks","issue_events_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/issues/events{/number}","events_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/events","assignees_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/assignees{/user}","branches_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/branches{/branch}","tags_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/tags","blobs_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/git/refs{/sha}","trees_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/statuses/{sha}","languages_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/languages","stargazers_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/stargazers","contributors_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/contributors","subscribers_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/subscribers","subscription_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/subscription","commits_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/commits{/sha}","git_commits_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/git/commits{/sha}","comments_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/comments{/number}","issue_comment_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/issues/comments{/number}","contents_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/contents/{+path}","compare_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/merges","archive_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/downloads","issues_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/issues{/number}","pulls_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls{/number}","milestones_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/milestones{/number}","notifications_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/labels{/name}","releases_url":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/releases{/id}","created_at":"2015-10-14T09:37:58Z","updated_at":"2015-10-14T09:38:17Z","pushed_at":"2015-10-14T09:39:16Z","git_url":"git://github.com/nullpointer-review/currency-rate-api-olimpiks.git","ssh_url":"git@github.com:nullpointer-review/currency-rate-api-olimpiks.git","clone_url":"https://github.com/nullpointer-review/currency-rate-api-olimpiks.git","svn_url":"https://github.com/nullpointer-review/currency-rate-api-olimpiks","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/1"},"html":{"href":"https://github.com/nullpointer-review/currency-rate-api-olimpiks/pull/1"},"issue":{"href":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/issues/1"},"comments":{"href":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/nullpointer-review/currency-rate-api-olimpiks/statuses/0b61fa35b375629f4d3c475ed3aa1462cb034073"}}}}