{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/47263705","id":47263705,"diff_hunk":"@@ -126,10 +126,8 @@ func (b *gitRepoVolumeBuilder) SetUp() error {\n \treturn b.SetUpAt(b.GetPath())\n }\n \n-// This is the spec for the volume that this plugin wraps.\n-var wrappedVolumeSpec = &volume.Spec{\n-\tVolume: &api.Volume{VolumeSource: api.VolumeSource{EmptyDir: &api.EmptyDirVolumeSource{}}},\n-}\n+// This is the name for the volume that this plugin wraps, will be generated with random value in SetUpAt(..).\n+var wrapperVolumeName string","path":"pkg/volume/git_repo/git_repo.go","position":9,"original_position":9,"commit_id":"882fbf145399412b6e602f07084f867d0d770123","original_commit_id":"882fbf145399412b6e602f07084f867d0d770123","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"This can't be a global.  Every call to SetUpAt() will overwrite it, which means TearDown() will fail.  It has to be attached to each volume.  But then random doesn't work because Builder/Cleaner have different amounts of information.\r\n\r\nI think it has to be determinable from the volName.  I left us an affordance here - the API enforces that volume names are DNS_LABEL formatted.  That gives us (I hope) freedome to use things like _ in the implementation (which we do in Docker container names, for example).\r\n\r\nWhat if we simply named the wrapee \"wrapped_\" + volName ?\r\n","created_at":"2015-12-10T18:25:44Z","updated_at":"2015-12-10T18:25:44Z","html_url":"https://github.com/kubernetes/kubernetes/pull/18445#discussion_r47263705","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18445","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/47263705"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18445#discussion_r47263705"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18445"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18445","id":53144011,"html_url":"https://github.com/kubernetes/kubernetes/pull/18445","diff_url":"https://github.com/kubernetes/kubernetes/pull/18445.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/18445.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18445","number":18445,"state":"open","locked":false,"title":"Fix emptyDir confuse gitRepo","user":{"login":"resouer","id":1701782,"avatar_url":"https://avatars.githubusercontent.com/u/1701782?v=3","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false},"body":"Fixes: #18167\r\n\r\nWe need to set name of wrapper volume, so plugins will not \"share\" the same empty_dir they rely on.","created_at":"2015-12-09T16:38:23Z","updated_at":"2015-12-10T18:25:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5501b436bed53f0568e71977ae69e4d54db2a385","assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18445/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18445/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18445/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/882fbf145399412b6e602f07084f867d0d770123","head":{"label":"resouer:fix-emptydir","ref":"fix-emptydir","sha":"882fbf145399412b6e602f07084f867d0d770123","user":{"login":"resouer","id":1701782,"avatar_url":"https://avatars.githubusercontent.com/u/1701782?v=3","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false},"repo":{"id":28023343,"name":"kubernetes","full_name":"resouer/kubernetes","owner":{"login":"resouer","id":1701782,"avatar_url":"https://avatars.githubusercontent.com/u/1701782?v=3","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/resouer/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/resouer/kubernetes","forks_url":"https://api.github.com/repos/resouer/kubernetes/forks","keys_url":"https://api.github.com/repos/resouer/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resouer/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resouer/kubernetes/teams","hooks_url":"https://api.github.com/repos/resouer/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/resouer/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/resouer/kubernetes/events","assignees_url":"https://api.github.com/repos/resouer/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/resouer/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/resouer/kubernetes/tags","blobs_url":"https://api.github.com/repos/resouer/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resouer/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resouer/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/resouer/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resouer/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/resouer/kubernetes/languages","stargazers_url":"https://api.github.com/repos/resouer/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/resouer/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/resouer/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/resouer/kubernetes/subscription","commits_url":"https://api.github.com/repos/resouer/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/resouer/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/resouer/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/resouer/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/resouer/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/resouer/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resouer/kubernetes/merges","archive_url":"https://api.github.com/repos/resouer/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resouer/kubernetes/downloads","issues_url":"https://api.github.com/repos/resouer/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/resouer/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/resouer/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/resouer/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resouer/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/resouer/kubernetes/releases{/id}","created_at":"2014-12-15T06:15:28Z","updated_at":"2015-02-24T09:55:39Z","pushed_at":"2015-12-10T10:07:49Z","git_url":"git://github.com/resouer/kubernetes.git","ssh_url":"git@github.com:resouer/kubernetes.git","clone_url":"https://github.com/resouer/kubernetes.git","svn_url":"https://github.com/resouer/kubernetes","homepage":null,"size":136304,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"05394f93016cf7884605736a38d2a06361ed20fd","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-12-10T18:22:04Z","pushed_at":"2015-12-10T18:25:24Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":290693,"stargazers_count":11714,"watchers_count":11714,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3176,"mirror_url":null,"open_issues_count":2543,"forks":3176,"open_issues":2543,"watchers":11714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18445"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18445"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18445"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18445/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18445/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18445/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/882fbf145399412b6e602f07084f867d0d770123"}}}}