{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/40620009","id":40620009,"diff_hunk":"@@ -0,0 +1,68 @@\n+/*\n+Copyright 2015 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package delay\n+\n+// Decide whether an item in a delay-queue should be rescheduled if an item with the\n+// same UniqueID is added/offered. Rescheduling does not effect the Item value.\n+type SchedulingPolicy int\n+\n+const (\n+\tPreferLatest SchedulingPolicy = iota\n+\tPreferEarliest\n+)\n+\n+func (dp SchedulingPolicy) EventTime(a, b Priority) (result Priority) {","path":"contrib/mesos/pkg/queue/delay/policy.go","position":28,"original_position":28,"commit_id":"5684ac7feb1be9ceb05790ed98a981bf20343396","original_commit_id":"5684ac7feb1be9ceb05790ed98a981bf20343396","user":{"login":"karlkfi","id":3980984,"avatar_url":"https://avatars.githubusercontent.com/u/3980984?v=3","gravatar_id":"","url":"https://api.github.com/users/karlkfi","html_url":"https://github.com/karlkfi","followers_url":"https://api.github.com/users/karlkfi/followers","following_url":"https://api.github.com/users/karlkfi/following{/other_user}","gists_url":"https://api.github.com/users/karlkfi/gists{/gist_id}","starred_url":"https://api.github.com/users/karlkfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlkfi/subscriptions","organizations_url":"https://api.github.com/users/karlkfi/orgs","repos_url":"https://api.github.com/users/karlkfi/repos","events_url":"https://api.github.com/users/karlkfi/events{/privacy}","received_events_url":"https://api.github.com/users/karlkfi/received_events","type":"User","site_admin":false},"body":"Yeah the name isn't optimal. `Prioritize` could work but I feel like \"Prioritizing\" a list gives you a list...","created_at":"2015-09-28T23:44:02Z","updated_at":"2015-09-28T23:44:02Z","html_url":"https://github.com/kubernetes/kubernetes/pull/14610#discussion_r40620009","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14610","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/40620009"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/14610#discussion_r40620009"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14610"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14610","id":46076425,"html_url":"https://github.com/kubernetes/kubernetes/pull/14610","diff_url":"https://github.com/kubernetes/kubernetes/pull/14610.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/14610.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14610","number":14610,"state":"open","locked":false,"title":"MESOS: DelayQueue cleanup","user":{"login":"karlkfi","id":3980984,"avatar_url":"https://avatars.githubusercontent.com/u/3980984?v=3","gravatar_id":"","url":"https://api.github.com/users/karlkfi","html_url":"https://github.com/karlkfi","followers_url":"https://api.github.com/users/karlkfi/followers","following_url":"https://api.github.com/users/karlkfi/following{/other_user}","gists_url":"https://api.github.com/users/karlkfi/gists{/gist_id}","starred_url":"https://api.github.com/users/karlkfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlkfi/subscriptions","organizations_url":"https://api.github.com/users/karlkfi/orgs","repos_url":"https://api.github.com/users/karlkfi/repos","events_url":"https://api.github.com/users/karlkfi/events{/privacy}","received_events_url":"https://api.github.com/users/karlkfi/received_events","type":"User","site_admin":false},"body":"Man, this code is a pile of spaghetti... Trying to whip it into something slightly more testable and maintainable.\r\n\r\nEventually I hope to make the timed tests more deterministic and less flakey.\r\n\r\nxref: #11857, #11821, https://github.com/mesosphere/kubernetes-mesos/issues/432","created_at":"2015-09-26T06:12:44Z","updated_at":"2015-09-28T23:44:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4614ff7032d44f167a372c86c12debc3f4ba4bf4","assignee":{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14610/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14610/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14610/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5684ac7feb1be9ceb05790ed98a981bf20343396","head":{"label":"mesosphere:delay-queue","ref":"delay-queue","sha":"5684ac7feb1be9ceb05790ed98a981bf20343396","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":22277046,"name":"kubernetes","full_name":"mesosphere/kubernetes","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/mesosphere/kubernetes","forks_url":"https://api.github.com/repos/mesosphere/kubernetes/forks","keys_url":"https://api.github.com/repos/mesosphere/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/kubernetes/teams","hooks_url":"https://api.github.com/repos/mesosphere/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/kubernetes/events","assignees_url":"https://api.github.com/repos/mesosphere/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/kubernetes/tags","blobs_url":"https://api.github.com/repos/mesosphere/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mesosphere/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/kubernetes/subscription","commits_url":"https://api.github.com/repos/mesosphere/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/kubernetes/merges","archive_url":"https://api.github.com/repos/mesosphere/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/kubernetes/downloads","issues_url":"https://api.github.com/repos/mesosphere/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/kubernetes/releases{/id}","created_at":"2014-07-26T02:50:13Z","updated_at":"2015-09-13T18:46:43Z","pushed_at":"2015-09-28T19:08:10Z","git_url":"git://github.com/mesosphere/kubernetes.git","ssh_url":"git@github.com:mesosphere/kubernetes.git","clone_url":"https://github.com/mesosphere/kubernetes.git","svn_url":"https://github.com/mesosphere/kubernetes","homepage":null,"size":113208,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":9,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f8a9943d9073d688620b2bdd7c4eca3a953ab075","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-09-28T22:29:51Z","pushed_at":"2015-09-28T23:27:46Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":434635,"stargazers_count":10479,"watchers_count":10479,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2611,"mirror_url":null,"open_issues_count":1945,"forks":2611,"open_issues":1945,"watchers":10479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14610"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/14610"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/14610"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/14610/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14610/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14610/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5684ac7feb1be9ceb05790ed98a981bf20343396"}}}}