{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezoracle/pulls/comments/41891982","id":41891982,"diff_hunk":"@@ -1269,14 +1255,19 @@ protected function _fail( $value, $text = false )\n         return new eZMySQLBackendError( $value, $text );\n     }\n \n+    protected function _queryAndCommit( $query, $fname = false, $reportError = true, $bindparams = array(), $return_type = self::RETURN_BOOL )","path":"clusterfilehandlers/dfsbackends/oracle.php","position":85,"original_position":85,"commit_id":"7630f31a3269d8203fe2f72bbc3444a0e20b331a","original_commit_id":"7630f31a3269d8203fe2f72bbc3444a0e20b331a","user":{"login":"gggeek","id":308634,"avatar_url":"https://avatars.githubusercontent.com/u/308634?v=3","gravatar_id":"","url":"https://api.github.com/users/gggeek","html_url":"https://github.com/gggeek","followers_url":"https://api.github.com/users/gggeek/followers","following_url":"https://api.github.com/users/gggeek/following{/other_user}","gists_url":"https://api.github.com/users/gggeek/gists{/gist_id}","starred_url":"https://api.github.com/users/gggeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gggeek/subscriptions","organizations_url":"https://api.github.com/users/gggeek/orgs","repos_url":"https://api.github.com/users/gggeek/repos","events_url":"https://api.github.com/users/gggeek/events{/privacy}","received_events_url":"https://api.github.com/users/gggeek/received_events","type":"User","site_admin":false},"body":"yes. I wanted to keep the callers of this as clean as possible, and there's already too many params in the middle with default values. The name of the method is also a good hint for when you find it used in code","created_at":"2015-10-13T16:42:38Z","updated_at":"2015-10-13T16:42:38Z","html_url":"https://github.com/ezsystems/ezoracle/pull/24#discussion_r41891982","pull_request_url":"https://api.github.com/repos/ezsystems/ezoracle/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezoracle/pulls/comments/41891982"},"html":{"href":"https://github.com/ezsystems/ezoracle/pull/24#discussion_r41891982"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezoracle/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezoracle/pulls/24","id":47555059,"html_url":"https://github.com/ezsystems/ezoracle/pull/24","diff_url":"https://github.com/ezsystems/ezoracle/pull/24.diff","patch_url":"https://github.com/ezsystems/ezoracle/pull/24.patch","issue_url":"https://api.github.com/repos/ezsystems/ezoracle/issues/24","number":24,"state":"open","locked":false,"title":"Issue 24763","user":{"login":"gggeek","id":308634,"avatar_url":"https://avatars.githubusercontent.com/u/308634?v=3","gravatar_id":"","url":"https://api.github.com/users/gggeek","html_url":"https://github.com/gggeek","followers_url":"https://api.github.com/users/gggeek/followers","following_url":"https://api.github.com/users/gggeek/following{/other_user}","gists_url":"https://api.github.com/users/gggeek/gists{/gist_id}","starred_url":"https://api.github.com/users/gggeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gggeek/subscriptions","organizations_url":"https://api.github.com/users/gggeek/orgs","repos_url":"https://api.github.com/users/gggeek/repos","events_url":"https://api.github.com/users/gggeek/events{/privacy}","received_events_url":"https://api.github.com/users/gggeek/received_events","type":"User","site_admin":false},"body":"A couple of minor issues fixed as well, all reported by our friend PhpStorm","created_at":"2015-10-13T16:17:51Z","updated_at":"2015-10-13T16:42:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaa181be31f444724dcadefb3cdb8f87ac6c4201","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezoracle/pulls/24/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezoracle/pulls/24/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezoracle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/ezoracle/issues/24/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezoracle/statuses/7630f31a3269d8203fe2f72bbc3444a0e20b331a","head":{"label":"gggeek:issue_24763","ref":"issue_24763","sha":"7630f31a3269d8203fe2f72bbc3444a0e20b331a","user":{"login":"gggeek","id":308634,"avatar_url":"https://avatars.githubusercontent.com/u/308634?v=3","gravatar_id":"","url":"https://api.github.com/users/gggeek","html_url":"https://github.com/gggeek","followers_url":"https://api.github.com/users/gggeek/followers","following_url":"https://api.github.com/users/gggeek/following{/other_user}","gists_url":"https://api.github.com/users/gggeek/gists{/gist_id}","starred_url":"https://api.github.com/users/gggeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gggeek/subscriptions","organizations_url":"https://api.github.com/users/gggeek/orgs","repos_url":"https://api.github.com/users/gggeek/repos","events_url":"https://api.github.com/users/gggeek/events{/privacy}","received_events_url":"https://api.github.com/users/gggeek/received_events","type":"User","site_admin":false},"repo":{"id":4050687,"name":"ezoracle","full_name":"gggeek/ezoracle","owner":{"login":"gggeek","id":308634,"avatar_url":"https://avatars.githubusercontent.com/u/308634?v=3","gravatar_id":"","url":"https://api.github.com/users/gggeek","html_url":"https://github.com/gggeek","followers_url":"https://api.github.com/users/gggeek/followers","following_url":"https://api.github.com/users/gggeek/following{/other_user}","gists_url":"https://api.github.com/users/gggeek/gists{/gist_id}","starred_url":"https://api.github.com/users/gggeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gggeek/subscriptions","organizations_url":"https://api.github.com/users/gggeek/orgs","repos_url":"https://api.github.com/users/gggeek/repos","events_url":"https://api.github.com/users/gggeek/events{/privacy}","received_events_url":"https://api.github.com/users/gggeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gggeek/ezoracle","description":"This extension adds support for the Oracle database to eZ Publish (Legacy Stack)","fork":true,"url":"https://api.github.com/repos/gggeek/ezoracle","forks_url":"https://api.github.com/repos/gggeek/ezoracle/forks","keys_url":"https://api.github.com/repos/gggeek/ezoracle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gggeek/ezoracle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gggeek/ezoracle/teams","hooks_url":"https://api.github.com/repos/gggeek/ezoracle/hooks","issue_events_url":"https://api.github.com/repos/gggeek/ezoracle/issues/events{/number}","events_url":"https://api.github.com/repos/gggeek/ezoracle/events","assignees_url":"https://api.github.com/repos/gggeek/ezoracle/assignees{/user}","branches_url":"https://api.github.com/repos/gggeek/ezoracle/branches{/branch}","tags_url":"https://api.github.com/repos/gggeek/ezoracle/tags","blobs_url":"https://api.github.com/repos/gggeek/ezoracle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gggeek/ezoracle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gggeek/ezoracle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gggeek/ezoracle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gggeek/ezoracle/statuses/{sha}","languages_url":"https://api.github.com/repos/gggeek/ezoracle/languages","stargazers_url":"https://api.github.com/repos/gggeek/ezoracle/stargazers","contributors_url":"https://api.github.com/repos/gggeek/ezoracle/contributors","subscribers_url":"https://api.github.com/repos/gggeek/ezoracle/subscribers","subscription_url":"https://api.github.com/repos/gggeek/ezoracle/subscription","commits_url":"https://api.github.com/repos/gggeek/ezoracle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gggeek/ezoracle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gggeek/ezoracle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gggeek/ezoracle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gggeek/ezoracle/contents/{+path}","compare_url":"https://api.github.com/repos/gggeek/ezoracle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gggeek/ezoracle/merges","archive_url":"https://api.github.com/repos/gggeek/ezoracle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gggeek/ezoracle/downloads","issues_url":"https://api.github.com/repos/gggeek/ezoracle/issues{/number}","pulls_url":"https://api.github.com/repos/gggeek/ezoracle/pulls{/number}","milestones_url":"https://api.github.com/repos/gggeek/ezoracle/milestones{/number}","notifications_url":"https://api.github.com/repos/gggeek/ezoracle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gggeek/ezoracle/labels{/name}","releases_url":"https://api.github.com/repos/gggeek/ezoracle/releases{/id}","created_at":"2012-04-17T09:12:10Z","updated_at":"2015-01-30T12:59:57Z","pushed_at":"2015-10-13T16:12:41Z","git_url":"git://github.com/gggeek/ezoracle.git","ssh_url":"git@github.com:gggeek/ezoracle.git","clone_url":"https://github.com/gggeek/ezoracle.git","svn_url":"https://github.com/gggeek/ezoracle","homepage":"","size":1318,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ezsystems:stable-2.4","ref":"stable-2.4","sha":"ad835853dcc464f38ec8ec02bb6a0db6a3f022b4","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":997427,"name":"ezoracle","full_name":"ezsystems/ezoracle","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezoracle","description":"","fork":false,"url":"https://api.github.com/repos/ezsystems/ezoracle","forks_url":"https://api.github.com/repos/ezsystems/ezoracle/forks","keys_url":"https://api.github.com/repos/ezsystems/ezoracle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezoracle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezoracle/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezoracle/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezoracle/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezoracle/events","assignees_url":"https://api.github.com/repos/ezsystems/ezoracle/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezoracle/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezoracle/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezoracle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezoracle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezoracle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezoracle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezoracle/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezoracle/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezoracle/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezoracle/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezoracle/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezoracle/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezoracle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezoracle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezoracle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezoracle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/ezoracle/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezoracle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezoracle/merges","archive_url":"https://api.github.com/repos/ezsystems/ezoracle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezoracle/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezoracle/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezoracle/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezoracle/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezoracle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezoracle/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezoracle/releases{/id}","created_at":"2010-10-18T12:25:37Z","updated_at":"2015-01-16T16:46:20Z","pushed_at":"2015-10-13T16:17:52Z","git_url":"git://github.com/ezsystems/ezoracle.git","ssh_url":"git@github.com:ezsystems/ezoracle.git","clone_url":"https://github.com/ezsystems/ezoracle.git","svn_url":"https://github.com/ezsystems/ezoracle","homepage":"","size":1727,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezoracle/pulls/24"},"html":{"href":"https://github.com/ezsystems/ezoracle/pull/24"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezoracle/issues/24"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezoracle/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezoracle/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezoracle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezoracle/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezoracle/statuses/7630f31a3269d8203fe2f72bbc3444a0e20b331a"}}}}