{"action":"created","issue":{"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/557","labels_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/557/labels{/name}","comments_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/557/comments","events_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/557/events","html_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/557","id":64029195,"number":557,"title":"Sa1307 is reported on read only fields","user":{"login":"pdelvo","id":1710209,"avatar_url":"https://avatars.githubusercontent.com/u/1710209?v=3","gravatar_id":"","url":"https://api.github.com/users/pdelvo","html_url":"https://github.com/pdelvo","followers_url":"https://api.github.com/users/pdelvo/followers","following_url":"https://api.github.com/users/pdelvo/following{/other_user}","gists_url":"https://api.github.com/users/pdelvo/gists{/gist_id}","starred_url":"https://api.github.com/users/pdelvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdelvo/subscriptions","organizations_url":"https://api.github.com/users/pdelvo/orgs","repos_url":"https://api.github.com/users/pdelvo/repos","events_url":"https://api.github.com/users/pdelvo/events{/privacy}","received_events_url":"https://api.github.com/users/pdelvo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/labels/code%20review","name":"code review","color":"f7c6c7"},{"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/labels/needs%20discussion","name":"needs discussion","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/milestones/6","html_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/milestones/1.0.0%20Alpha%205","labels_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/milestones/6/labels","id":996186,"number":6,"title":"1.0.0 Alpha 5","description":"","creator":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars.githubusercontent.com/u/1408396?v=3","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":49,"state":"open","created_at":"2015-02-26T02:13:28Z","updated_at":"2015-03-24T20:59:02Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-03-24T15:40:04Z","updated_at":"2015-03-24T21:15:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/pulls/557","html_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/557","diff_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/557.diff","patch_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/557.patch"},"body":"We usually try to reduce the number of diagnostic reported for the same issue. Read only fields are reported by SA1304 so we should not report SA1307 here. We have a test that makes sure that read only fields are not reported, but the test is currently broken because of the roslyn bug that made us disable a bunch of tests. So we have a regression test when we have rc2.\r\nI also changed that the diagnostic was reported on the whole declarator and not on the identifier directly."},"comment":{"url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/comments/85693982","html_url":"https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/557#issuecomment-85693982","issue_url":"https://api.github.com/repos/DotNetAnalyzers/StyleCopAnalyzers/issues/557","id":85693982,"user":{"login":"vweijsters","id":10659991,"avatar_url":"https://avatars.githubusercontent.com/u/10659991?v=3","gravatar_id":"","url":"https://api.github.com/users/vweijsters","html_url":"https://github.com/vweijsters","followers_url":"https://api.github.com/users/vweijsters/followers","following_url":"https://api.github.com/users/vweijsters/following{/other_user}","gists_url":"https://api.github.com/users/vweijsters/gists{/gist_id}","starred_url":"https://api.github.com/users/vweijsters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vweijsters/subscriptions","organizations_url":"https://api.github.com/users/vweijsters/orgs","repos_url":"https://api.github.com/users/vweijsters/repos","events_url":"https://api.github.com/users/vweijsters/events{/privacy}","received_events_url":"https://api.github.com/users/vweijsters/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T21:15:43Z","updated_at":"2015-03-24T21:15:43Z","body":"I think that SA1307 has the better message and always reporting the same message will give a better understanding by users most of the time.\r\nIt would effectively render SA1304 useless for anything but protected fields. Not sure about protected internal fields though, my gut feeling says that protected internal should be treated the same as internal."}}