{"action":"created","comment":{"url":"https://api.github.com/repos/carllerche/mio/pulls/comments/46477193","id":46477193,"diff_hunk":"@@ -494,6 +518,9 @@ impl ListenerImp {\n             State::Empty => {}\n             _ => return\n         }\n+\n+        me.iocp.unset_readiness(EventSet::readable());","path":"src/sys/windows/tcp.rs","position":127,"original_position":127,"commit_id":"557154850be433a4726aca619dff03daaac1c3b8","original_commit_id":"557154850be433a4726aca619dff03daaac1c3b8","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"I think this may want to be deferred until the actual `mem::forget` below. If the `me.iocp.defer` branch is taken the readiness should still be applicable.","created_at":"2015-12-02T21:22:19Z","updated_at":"2015-12-02T21:22:19Z","html_url":"https://github.com/carllerche/mio/pull/313#discussion_r46477193","pull_request_url":"https://api.github.com/repos/carllerche/mio/pulls/313","_links":{"self":{"href":"https://api.github.com/repos/carllerche/mio/pulls/comments/46477193"},"html":{"href":"https://github.com/carllerche/mio/pull/313#discussion_r46477193"},"pull_request":{"href":"https://api.github.com/repos/carllerche/mio/pulls/313"}}},"pull_request":{"url":"https://api.github.com/repos/carllerche/mio/pulls/313","id":52356263,"html_url":"https://github.com/carllerche/mio/pull/313","diff_url":"https://github.com/carllerche/mio/pull/313.diff","patch_url":"https://github.com/carllerche/mio/pull/313.patch","issue_url":"https://api.github.com/repos/carllerche/mio/issues/313","number":313,"state":"open","locked":false,"title":"WIP - Implement level triggering for windows","user":{"login":"carllerche","id":6180,"avatar_url":"https://avatars.githubusercontent.com/u/6180?v=3","gravatar_id":"","url":"https://api.github.com/users/carllerche","html_url":"https://github.com/carllerche","followers_url":"https://api.github.com/users/carllerche/followers","following_url":"https://api.github.com/users/carllerche/following{/other_user}","gists_url":"https://api.github.com/users/carllerche/gists{/gist_id}","starred_url":"https://api.github.com/users/carllerche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllerche/subscriptions","organizations_url":"https://api.github.com/users/carllerche/orgs","repos_url":"https://api.github.com/users/carllerche/repos","events_url":"https://api.github.com/users/carllerche/events{/privacy}","received_events_url":"https://api.github.com/users/carllerche/received_events","type":"User","site_admin":false},"body":"The windows selector uses a linked list of currently active level-triggered events. When an event arrives and the socket is registered with level-triggered, the event is tracked in this linked list. Every call to select events will include all elements in this list. When an operation is performed on the socket such that the socket is no longer ready, the event is removed from the linked list.\r\n\r\nCloses #241\r\n\r\n## Remaining\r\n\r\n- [x] Move calls to `unset_readiness` into `schedule_foo` functions.\r\n- [x] Possibly combine `Registration::deregister` & `deregister2`\r\n- [ ] UDP support\r\n- [ ] Uncomment prior tests using level","created_at":"2015-12-02T05:46:55Z","updated_at":"2015-12-02T21:22:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4779ce5c94c02824e6b80766f91815ba7bf98888","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/carllerche/mio/pulls/313/commits","review_comments_url":"https://api.github.com/repos/carllerche/mio/pulls/313/comments","review_comment_url":"https://api.github.com/repos/carllerche/mio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/carllerche/mio/issues/313/comments","statuses_url":"https://api.github.com/repos/carllerche/mio/statuses/557154850be433a4726aca619dff03daaac1c3b8","head":{"label":"carllerche:win-level","ref":"win-level","sha":"557154850be433a4726aca619dff03daaac1c3b8","user":{"login":"carllerche","id":6180,"avatar_url":"https://avatars.githubusercontent.com/u/6180?v=3","gravatar_id":"","url":"https://api.github.com/users/carllerche","html_url":"https://github.com/carllerche","followers_url":"https://api.github.com/users/carllerche/followers","following_url":"https://api.github.com/users/carllerche/following{/other_user}","gists_url":"https://api.github.com/users/carllerche/gists{/gist_id}","starred_url":"https://api.github.com/users/carllerche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllerche/subscriptions","organizations_url":"https://api.github.com/users/carllerche/orgs","repos_url":"https://api.github.com/users/carllerche/repos","events_url":"https://api.github.com/users/carllerche/events{/privacy}","received_events_url":"https://api.github.com/users/carllerche/received_events","type":"User","site_admin":false},"repo":{"id":23138984,"name":"mio","full_name":"carllerche/mio","owner":{"login":"carllerche","id":6180,"avatar_url":"https://avatars.githubusercontent.com/u/6180?v=3","gravatar_id":"","url":"https://api.github.com/users/carllerche","html_url":"https://github.com/carllerche","followers_url":"https://api.github.com/users/carllerche/followers","following_url":"https://api.github.com/users/carllerche/following{/other_user}","gists_url":"https://api.github.com/users/carllerche/gists{/gist_id}","starred_url":"https://api.github.com/users/carllerche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllerche/subscriptions","organizations_url":"https://api.github.com/users/carllerche/orgs","repos_url":"https://api.github.com/users/carllerche/repos","events_url":"https://api.github.com/users/carllerche/events{/privacy}","received_events_url":"https://api.github.com/users/carllerche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carllerche/mio","description":"Metal IO library for Rust","fork":false,"url":"https://api.github.com/repos/carllerche/mio","forks_url":"https://api.github.com/repos/carllerche/mio/forks","keys_url":"https://api.github.com/repos/carllerche/mio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carllerche/mio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carllerche/mio/teams","hooks_url":"https://api.github.com/repos/carllerche/mio/hooks","issue_events_url":"https://api.github.com/repos/carllerche/mio/issues/events{/number}","events_url":"https://api.github.com/repos/carllerche/mio/events","assignees_url":"https://api.github.com/repos/carllerche/mio/assignees{/user}","branches_url":"https://api.github.com/repos/carllerche/mio/branches{/branch}","tags_url":"https://api.github.com/repos/carllerche/mio/tags","blobs_url":"https://api.github.com/repos/carllerche/mio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carllerche/mio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carllerche/mio/git/refs{/sha}","trees_url":"https://api.github.com/repos/carllerche/mio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carllerche/mio/statuses/{sha}","languages_url":"https://api.github.com/repos/carllerche/mio/languages","stargazers_url":"https://api.github.com/repos/carllerche/mio/stargazers","contributors_url":"https://api.github.com/repos/carllerche/mio/contributors","subscribers_url":"https://api.github.com/repos/carllerche/mio/subscribers","subscription_url":"https://api.github.com/repos/carllerche/mio/subscription","commits_url":"https://api.github.com/repos/carllerche/mio/commits{/sha}","git_commits_url":"https://api.github.com/repos/carllerche/mio/git/commits{/sha}","comments_url":"https://api.github.com/repos/carllerche/mio/comments{/number}","issue_comment_url":"https://api.github.com/repos/carllerche/mio/issues/comments{/number}","contents_url":"https://api.github.com/repos/carllerche/mio/contents/{+path}","compare_url":"https://api.github.com/repos/carllerche/mio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carllerche/mio/merges","archive_url":"https://api.github.com/repos/carllerche/mio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carllerche/mio/downloads","issues_url":"https://api.github.com/repos/carllerche/mio/issues{/number}","pulls_url":"https://api.github.com/repos/carllerche/mio/pulls{/number}","milestones_url":"https://api.github.com/repos/carllerche/mio/milestones{/number}","notifications_url":"https://api.github.com/repos/carllerche/mio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carllerche/mio/labels{/name}","releases_url":"https://api.github.com/repos/carllerche/mio/releases{/id}","created_at":"2014-08-20T06:52:12Z","updated_at":"2015-12-02T09:00:52Z","pushed_at":"2015-12-02T20:16:18Z","git_url":"git://github.com/carllerche/mio.git","ssh_url":"git@github.com:carllerche/mio.git","clone_url":"https://github.com/carllerche/mio.git","svn_url":"https://github.com/carllerche/mio","homepage":"","size":1022,"stargazers_count":901,"watchers_count":901,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":28,"forks":127,"open_issues":28,"watchers":901,"default_branch":"master"}},"base":{"label":"carllerche:master","ref":"master","sha":"bedcfd0cd2c73ebcd5c7675aa6b9aea55102de1c","user":{"login":"carllerche","id":6180,"avatar_url":"https://avatars.githubusercontent.com/u/6180?v=3","gravatar_id":"","url":"https://api.github.com/users/carllerche","html_url":"https://github.com/carllerche","followers_url":"https://api.github.com/users/carllerche/followers","following_url":"https://api.github.com/users/carllerche/following{/other_user}","gists_url":"https://api.github.com/users/carllerche/gists{/gist_id}","starred_url":"https://api.github.com/users/carllerche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllerche/subscriptions","organizations_url":"https://api.github.com/users/carllerche/orgs","repos_url":"https://api.github.com/users/carllerche/repos","events_url":"https://api.github.com/users/carllerche/events{/privacy}","received_events_url":"https://api.github.com/users/carllerche/received_events","type":"User","site_admin":false},"repo":{"id":23138984,"name":"mio","full_name":"carllerche/mio","owner":{"login":"carllerche","id":6180,"avatar_url":"https://avatars.githubusercontent.com/u/6180?v=3","gravatar_id":"","url":"https://api.github.com/users/carllerche","html_url":"https://github.com/carllerche","followers_url":"https://api.github.com/users/carllerche/followers","following_url":"https://api.github.com/users/carllerche/following{/other_user}","gists_url":"https://api.github.com/users/carllerche/gists{/gist_id}","starred_url":"https://api.github.com/users/carllerche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllerche/subscriptions","organizations_url":"https://api.github.com/users/carllerche/orgs","repos_url":"https://api.github.com/users/carllerche/repos","events_url":"https://api.github.com/users/carllerche/events{/privacy}","received_events_url":"https://api.github.com/users/carllerche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carllerche/mio","description":"Metal IO library for Rust","fork":false,"url":"https://api.github.com/repos/carllerche/mio","forks_url":"https://api.github.com/repos/carllerche/mio/forks","keys_url":"https://api.github.com/repos/carllerche/mio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carllerche/mio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carllerche/mio/teams","hooks_url":"https://api.github.com/repos/carllerche/mio/hooks","issue_events_url":"https://api.github.com/repos/carllerche/mio/issues/events{/number}","events_url":"https://api.github.com/repos/carllerche/mio/events","assignees_url":"https://api.github.com/repos/carllerche/mio/assignees{/user}","branches_url":"https://api.github.com/repos/carllerche/mio/branches{/branch}","tags_url":"https://api.github.com/repos/carllerche/mio/tags","blobs_url":"https://api.github.com/repos/carllerche/mio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carllerche/mio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carllerche/mio/git/refs{/sha}","trees_url":"https://api.github.com/repos/carllerche/mio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carllerche/mio/statuses/{sha}","languages_url":"https://api.github.com/repos/carllerche/mio/languages","stargazers_url":"https://api.github.com/repos/carllerche/mio/stargazers","contributors_url":"https://api.github.com/repos/carllerche/mio/contributors","subscribers_url":"https://api.github.com/repos/carllerche/mio/subscribers","subscription_url":"https://api.github.com/repos/carllerche/mio/subscription","commits_url":"https://api.github.com/repos/carllerche/mio/commits{/sha}","git_commits_url":"https://api.github.com/repos/carllerche/mio/git/commits{/sha}","comments_url":"https://api.github.com/repos/carllerche/mio/comments{/number}","issue_comment_url":"https://api.github.com/repos/carllerche/mio/issues/comments{/number}","contents_url":"https://api.github.com/repos/carllerche/mio/contents/{+path}","compare_url":"https://api.github.com/repos/carllerche/mio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carllerche/mio/merges","archive_url":"https://api.github.com/repos/carllerche/mio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carllerche/mio/downloads","issues_url":"https://api.github.com/repos/carllerche/mio/issues{/number}","pulls_url":"https://api.github.com/repos/carllerche/mio/pulls{/number}","milestones_url":"https://api.github.com/repos/carllerche/mio/milestones{/number}","notifications_url":"https://api.github.com/repos/carllerche/mio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carllerche/mio/labels{/name}","releases_url":"https://api.github.com/repos/carllerche/mio/releases{/id}","created_at":"2014-08-20T06:52:12Z","updated_at":"2015-12-02T09:00:52Z","pushed_at":"2015-12-02T20:16:18Z","git_url":"git://github.com/carllerche/mio.git","ssh_url":"git@github.com:carllerche/mio.git","clone_url":"https://github.com/carllerche/mio.git","svn_url":"https://github.com/carllerche/mio","homepage":"","size":1022,"stargazers_count":901,"watchers_count":901,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":28,"forks":127,"open_issues":28,"watchers":901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/carllerche/mio/pulls/313"},"html":{"href":"https://github.com/carllerche/mio/pull/313"},"issue":{"href":"https://api.github.com/repos/carllerche/mio/issues/313"},"comments":{"href":"https://api.github.com/repos/carllerche/mio/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/carllerche/mio/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/carllerche/mio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/carllerche/mio/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/carllerche/mio/statuses/557154850be433a4726aca619dff03daaac1c3b8"}}}}