{"push_id":579023304,"size":88,"distinct_size":85,"ref":"refs/heads/upgrade-to-rails-4","head":"82ff04cac65d8d830d194a4a16b2b0f285304fa4","before":"0bbb477839159ce31f75ded0565a1eb8fe4deba3","commits":[{"sha":"6fa5bbe02f688b3f0430ee23741562d4987db572","author":{"email":"eef16ec869f7c47862e858ad0bde918d09cef193@digital.cabinet-office.gov.uk","name":"David Heath"},"message":"Merge pull request #1979 from alphagov/perforance-improvements-to-document-searches-controller\n\nPerforance improvements to document searches controller","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/6fa5bbe02f688b3f0430ee23741562d4987db572"},{"sha":"3f2a376ea75380098fb629e9c03f38359d4a3f4e","author":{"email":"eef16ec869f7c47862e858ad0bde918d09cef193@digital.cabinet-office.gov.uk","name":"David Heath"},"message":"Preemptively add primary_locale to editions\n\nthis is to avoid a race condition when deploying the rails 4 upgrade.\n\nI noticed errors when deploying to preview which I think occured because the\nwhitehall-frontend apps restarted before the schema change had propogated to\nthe slave. So the frontend apps saw the old schema and thought that Editions\ndid not have a `primary_locale` attribute.\n\nWe can pre-emptively add and populate this field.\n\nA migration included in the rails 4 branch will update the field to ensure that\nit contains the latest data at the time of switchover. Adding it pre-emptively\nto the database schema avoids the race condition.","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/3f2a376ea75380098fb629e9c03f38359d4a3f4e"},{"sha":"cf9ce75017a52188eb901cf532d3da2379f6b640","author":{"email":"eef16ec869f7c47862e858ad0bde918d09cef193@digital.cabinet-office.gov.uk","name":"David Heath"},"message":"Merge pull request #1981 from alphagov/preemptively-add-primary-locale-to-editions\n\nPreemptively add primary_locale to editions","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/cf9ce75017a52188eb901cf532d3da2379f6b640"},{"sha":"d215782886cfee49d41364d9f06855aed6ffb59b","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Update Gemfile for Rails 4.0.13\n\nUpdating one major Rails release at a time to take advantage of all deprecation\nwarnings.\n\nA change was also required to how webmock is loaded. Also, active_resource is no\nlonger part of Rails. As it isn't used by the app, we can remove it entirely.","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/d215782886cfee49d41364d9f06855aed6ffb59b"},{"sha":"55b634463ff35bee91e6f522d21461d7fa1c80c2","author":{"email":"eef16ec869f7c47862e858ad0bde918d09cef193@digital.cabinet-office.gov.uk","name":"David Heath"},"message":"Regenerate db/schema.rb\n\nRails 4.0.x changes the schema syntax in a few ways:\n- uses ruby 1.9 hash syntax\n- explicitly declares index types on indexes\n\nThis commit regenerates the schema to use the new syntax without\nchanging the actual semantic content.","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/55b634463ff35bee91e6f522d21461d7fa1c80c2"},{"sha":"7bfb8ebdc613a97c0dc86e0a361b7fd0226e209e","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Temporarily comment out localised routing patch\n\nThis is not compatible with Rails 4 so commenting out for the time being.","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/7bfb8ebdc613a97c0dc86e0a361b7fd0226e209e"},{"sha":"4ec533af03ae229f3af16031729fe83193fe7571","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Re-nest PublishingApiPresenters::Edition\n\nThis was causing a circular dependency issue. Whitespace-only changes","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/4ec533af03ae229f3af16031729fe83193fe7571"},{"sha":"6041b3d7cffe70f1ce9d8bedb3a0d12730e4d5dc","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Update app config for Rails 4 compatibility\n\nThis was mainly a case of generating a fresh Rails 4 app to see what the new\ndefault configuration looks like and removing any configurations that are now\ndeprecated.","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/6041b3d7cffe70f1ce9d8bedb3a0d12730e4d5dc"},{"sha":"98cbb8707034a52a2fb8b6efa330307be99c8ce6","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Get rid of assets group in Gemfile\n\nThe assets group was removed from Gemfile by Rails 4. For more information, see\nhttp://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-3-2-to-rails-4-0-gemfile\nand https://github.com/rails/rails/commit/49c4af43ec5819d8f5c1a91f9b84296c927ce6e7#commitcomment-3119162","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/98cbb8707034a52a2fb8b6efa330307be99c8ce6"},{"sha":"df3c5209e208acd26881857a1a87b97e705c83c5","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Remove unnecessary script/rails file\n\nbundler/rails does the right thing","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/df3c5209e208acd26881857a1a87b97e705c83c5"},{"sha":"2829f26fd3537837b74c76deb5b54d8f9d859742","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Remove unnecessary rake task hack\n\nThis is no longer required in Rails 4","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/2829f26fd3537837b74c76deb5b54d8f9d859742"},{"sha":"886c74f0472d73ae4de35899bb15ef72963e9790","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"ActiveRecord::Base#scoped is deprecated\n\nThe `all` method now returns a scope, use that instead.","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/886c74f0472d73ae4de35899bb15ef72963e9790"},{"sha":"14a19690c9e07dafd7f0a3b486adcb40340c8a44","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Disable deprecated implicit join references\n\nActiveRecord has deprecated implicit join references in the queries it\ngenerates, e.g. it will no longer automatically join other tables that are\nreferenced in the WHERE clause. Instead, the reference should now be explicitly\nincludes using the `references` scope.\n\nThis pull request also explicitly turns them off so that any code that would\nresult in an implicit join raises an exception so that we can catch them all now\nbefore they are removed permanently.","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/14a19690c9e07dafd7f0a3b486adcb40340c8a44"},{"sha":"93e21d8fb6db4556e8cb5c5b11b7d6f74d3776e7","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Don't call deprecated `all` method on scopes\n\nEither `load` or `to_a` should be used, depending on whether the scope should be\nused.","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/93e21d8fb6db4556e8cb5c5b11b7d6f74d3776e7"},{"sha":"3312302e50db2c3a20da230e9e174c15161d358f","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Don't use deprecated `assert_present` method","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/3312302e50db2c3a20da230e9e174c15161d358f"},{"sha":"016615973e5cbba922660fc1b8281b8561956913","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Don't use deprecated magic find_by_* helpers\n\nThe find_by() method should be used instead. Note that the active record-like\ninterfaces define their own explicit find_by_* methods. I'd suggest these be\nrenamed to something else to avoid confusion, e.g. `by_slug` instead of\n`find_by_slug`.","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/016615973e5cbba922660fc1b8281b8561956913"},{"sha":"d384132ad1ee5e9e193b329e6a588af8658a9363","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Ensure all scopes are lambdas","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/d384132ad1ee5e9e193b329e6a588af8658a9363"},{"sha":"b7b82b771dd0246641f3065f5f29687d8f9d08d5","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Use new association syntax\n\nWhere available, scopes should now be used to define the conditions, ordering,\netc on associations","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/b7b82b771dd0246641f3065f5f29687d8f9d08d5"},{"sha":"fa7bce2955d5b0a858e477e0c1a2875c943215ab","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Update the localised routing patch for Rails 4.\n\nThis had to be rewritten to work with the new routing code in Rails 4. Because\nthe app is now running on Ruby 2, we can make use of the Module#prepend method\nto avoid the alias method chaining.","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/fa7bce2955d5b0a858e477e0c1a2875c943215ab"},{"sha":"2469458b254dd9dfda64cd23a1f9b3806e5c6d9b","author":{"email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk","name":"Tekin Suleyman"},"message":"Disable deprecated implicit join references","distinct":true,"url":"https://api.github.com/repos/alphagov/whitehall/commits/2469458b254dd9dfda64cd23a1f9b3806e5c6d9b"}]}