{"action":"created","comment":{"url":"https://api.github.com/repos/gem/oq-risklib/pulls/comments/44406789","id":44406789,"diff_hunk":"@@ -379,8 +414,35 @@ def apply_uncertainty(self, value, source):\n         if not self.filter_source(source):\n             # source didn't pass the filter\n             return\n-\n-        self._apply_uncertainty_to_mfd(source.mfd, value)\n+        if self.uncertainty_type in MFD_UNCERTAINTY_TYPES:\n+            self._apply_uncertainty_to_mfd(source.mfd, value)\n+        elif self.uncertainty_type in GEOMETRY_UNCERTAINTY_TYPES:\n+            self._apply_uncertainty_to_geometry(source, value)\n+        else:\n+            pass","path":"openquake/commonlib/logictree.py","position":74,"original_position":74,"commit_id":"b69d161cdf9e635c4db256745b167a419093e45f","original_commit_id":"b69d161cdf9e635c4db256745b167a419093e45f","user":{"login":"g-weatherill","id":496400,"avatar_url":"https://avatars.githubusercontent.com/u/496400?v=3","gravatar_id":"","url":"https://api.github.com/users/g-weatherill","html_url":"https://github.com/g-weatherill","followers_url":"https://api.github.com/users/g-weatherill/followers","following_url":"https://api.github.com/users/g-weatherill/following{/other_user}","gists_url":"https://api.github.com/users/g-weatherill/gists{/gist_id}","starred_url":"https://api.github.com/users/g-weatherill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-weatherill/subscriptions","organizations_url":"https://api.github.com/users/g-weatherill/orgs","repos_url":"https://api.github.com/users/g-weatherill/repos","events_url":"https://api.github.com/users/g-weatherill/events{/privacy}","received_events_url":"https://api.github.com/users/g-weatherill/received_events","type":"User","site_admin":false},"body":"It should be an error (I will add it)","created_at":"2015-11-10T13:43:00Z","updated_at":"2015-11-10T13:43:00Z","html_url":"https://github.com/gem/oq-risklib/pull/514#discussion_r44406789","pull_request_url":"https://api.github.com/repos/gem/oq-risklib/pulls/514","_links":{"self":{"href":"https://api.github.com/repos/gem/oq-risklib/pulls/comments/44406789"},"html":{"href":"https://github.com/gem/oq-risklib/pull/514#discussion_r44406789"},"pull_request":{"href":"https://api.github.com/repos/gem/oq-risklib/pulls/514"}}},"pull_request":{"url":"https://api.github.com/repos/gem/oq-risklib/pulls/514","id":49972413,"html_url":"https://github.com/gem/oq-risklib/pull/514","diff_url":"https://github.com/gem/oq-risklib/pull/514.diff","patch_url":"https://github.com/gem/oq-risklib/pull/514.patch","issue_url":"https://api.github.com/repos/gem/oq-risklib/issues/514","number":514,"state":"open","locked":false,"title":"Adds epistemic uncertainties on fault geometry into the Source Model Logic Tree","user":{"login":"g-weatherill","id":496400,"avatar_url":"https://avatars.githubusercontent.com/u/496400?v=3","gravatar_id":"","url":"https://api.github.com/users/g-weatherill","html_url":"https://github.com/g-weatherill","followers_url":"https://api.github.com/users/g-weatherill/followers","following_url":"https://api.github.com/users/g-weatherill/following{/other_user}","gists_url":"https://api.github.com/users/g-weatherill/gists{/gist_id}","starred_url":"https://api.github.com/users/g-weatherill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-weatherill/subscriptions","organizations_url":"https://api.github.com/users/g-weatherill/orgs","repos_url":"https://api.github.com/users/g-weatherill/repos","events_url":"https://api.github.com/users/g-weatherill/events{/privacy}","received_events_url":"https://api.github.com/users/g-weatherill/received_events","type":"User","site_admin":false},"body":"This PR adds support for a new family of epistemic uncertainties on the source model, specifically the ability to define different fault geometries for a given fault source (simple, complex and characteristic). \r\n\r\nThe new epistemic uncertainties include:\r\ni) `simpleFaultDipRelative` - increases or decreases a fault dip on a simple fault by a given amount\r\n\r\nii) `simpleFaultDipAbsolute` - replaces the dip on a simple fault with the specified value\r\n\r\niii) `simpleFaultGeometryAbsolute` - replaces the simple fault geometry with a different configuration\r\n\r\niv) `complexFaultGeometryAbsolute` - replaces the complex fault geometry with a different configuration\r\n\r\nv) `characteristicFaultGeometryAbsolute` - replaces the characteristic fault geometry with a different configuration\r\n\r\nThese features accompany the changes in the oq-hazardlib introduced here: https://github.com/gem/oq-hazardlib/pull/388\r\n\r\nFurther modification was made to the `openquake.commonlib.logictree.BaseLogicTree` class to allow it to support LiteralNode instances in the `uncertaintyModel` node, rather than only text. This the epistemic uncertainties can be input as nrml SimpleFaultGeometry, ComplexFaultGeometry and CharacteristicFaultGeometry representations. With this functionality, also modified here is the logic tree representations of `incrementalMFDAbsolute` (introduced here https://github.com/gem/oq-risklib/pull/467) to return the incremental MFD representation to its full nrml format rather than the arbitrary string format adopted previously.","created_at":"2015-11-06T16:14:49Z","updated_at":"2015-11-10T13:43:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"019117b320a1dab6d968d8674a5dffb814dd956b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gem/oq-risklib/pulls/514/commits","review_comments_url":"https://api.github.com/repos/gem/oq-risklib/pulls/514/comments","review_comment_url":"https://api.github.com/repos/gem/oq-risklib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gem/oq-risklib/issues/514/comments","statuses_url":"https://api.github.com/repos/gem/oq-risklib/statuses/b69d161cdf9e635c4db256745b167a419093e45f","head":{"label":"gem:modify_flt_geom","ref":"modify_flt_geom","sha":"b69d161cdf9e635c4db256745b167a419093e45f","user":{"login":"gem","id":316546,"avatar_url":"https://avatars.githubusercontent.com/u/316546?v=3","gravatar_id":"","url":"https://api.github.com/users/gem","html_url":"https://github.com/gem","followers_url":"https://api.github.com/users/gem/followers","following_url":"https://api.github.com/users/gem/following{/other_user}","gists_url":"https://api.github.com/users/gem/gists{/gist_id}","starred_url":"https://api.github.com/users/gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gem/subscriptions","organizations_url":"https://api.github.com/users/gem/orgs","repos_url":"https://api.github.com/users/gem/repos","events_url":"https://api.github.com/users/gem/events{/privacy}","received_events_url":"https://api.github.com/users/gem/received_events","type":"Organization","site_admin":false},"repo":{"id":5856509,"name":"oq-risklib","full_name":"gem/oq-risklib","owner":{"login":"gem","id":316546,"avatar_url":"https://avatars.githubusercontent.com/u/316546?v=3","gravatar_id":"","url":"https://api.github.com/users/gem","html_url":"https://github.com/gem","followers_url":"https://api.github.com/users/gem/followers","following_url":"https://api.github.com/users/gem/following{/other_user}","gists_url":"https://api.github.com/users/gem/gists{/gist_id}","starred_url":"https://api.github.com/users/gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gem/subscriptions","organizations_url":"https://api.github.com/users/gem/orgs","repos_url":"https://api.github.com/users/gem/repos","events_url":"https://api.github.com/users/gem/events{/privacy}","received_events_url":"https://api.github.com/users/gem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gem/oq-risklib","description":"OpenQuake Risk Library","fork":false,"url":"https://api.github.com/repos/gem/oq-risklib","forks_url":"https://api.github.com/repos/gem/oq-risklib/forks","keys_url":"https://api.github.com/repos/gem/oq-risklib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gem/oq-risklib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gem/oq-risklib/teams","hooks_url":"https://api.github.com/repos/gem/oq-risklib/hooks","issue_events_url":"https://api.github.com/repos/gem/oq-risklib/issues/events{/number}","events_url":"https://api.github.com/repos/gem/oq-risklib/events","assignees_url":"https://api.github.com/repos/gem/oq-risklib/assignees{/user}","branches_url":"https://api.github.com/repos/gem/oq-risklib/branches{/branch}","tags_url":"https://api.github.com/repos/gem/oq-risklib/tags","blobs_url":"https://api.github.com/repos/gem/oq-risklib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gem/oq-risklib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gem/oq-risklib/git/refs{/sha}","trees_url":"https://api.github.com/repos/gem/oq-risklib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gem/oq-risklib/statuses/{sha}","languages_url":"https://api.github.com/repos/gem/oq-risklib/languages","stargazers_url":"https://api.github.com/repos/gem/oq-risklib/stargazers","contributors_url":"https://api.github.com/repos/gem/oq-risklib/contributors","subscribers_url":"https://api.github.com/repos/gem/oq-risklib/subscribers","subscription_url":"https://api.github.com/repos/gem/oq-risklib/subscription","commits_url":"https://api.github.com/repos/gem/oq-risklib/commits{/sha}","git_commits_url":"https://api.github.com/repos/gem/oq-risklib/git/commits{/sha}","comments_url":"https://api.github.com/repos/gem/oq-risklib/comments{/number}","issue_comment_url":"https://api.github.com/repos/gem/oq-risklib/issues/comments{/number}","contents_url":"https://api.github.com/repos/gem/oq-risklib/contents/{+path}","compare_url":"https://api.github.com/repos/gem/oq-risklib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gem/oq-risklib/merges","archive_url":"https://api.github.com/repos/gem/oq-risklib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gem/oq-risklib/downloads","issues_url":"https://api.github.com/repos/gem/oq-risklib/issues{/number}","pulls_url":"https://api.github.com/repos/gem/oq-risklib/pulls{/number}","milestones_url":"https://api.github.com/repos/gem/oq-risklib/milestones{/number}","notifications_url":"https://api.github.com/repos/gem/oq-risklib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gem/oq-risklib/labels{/name}","releases_url":"https://api.github.com/repos/gem/oq-risklib/releases{/id}","created_at":"2012-09-18T13:07:14Z","updated_at":"2015-11-05T16:05:21Z","pushed_at":"2015-11-10T12:51:41Z","git_url":"git://github.com/gem/oq-risklib.git","ssh_url":"git@github.com:gem/oq-risklib.git","clone_url":"https://github.com/gem/oq-risklib.git","svn_url":"https://github.com/gem/oq-risklib","homepage":"http://www.globalquakemodel.org/openquake/","size":32249,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":29,"forks":15,"open_issues":29,"watchers":10,"default_branch":"master"}},"base":{"label":"gem:master","ref":"master","sha":"d1729ba1e9f8a9dc1c3bd1d7f787addf0333a2ff","user":{"login":"gem","id":316546,"avatar_url":"https://avatars.githubusercontent.com/u/316546?v=3","gravatar_id":"","url":"https://api.github.com/users/gem","html_url":"https://github.com/gem","followers_url":"https://api.github.com/users/gem/followers","following_url":"https://api.github.com/users/gem/following{/other_user}","gists_url":"https://api.github.com/users/gem/gists{/gist_id}","starred_url":"https://api.github.com/users/gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gem/subscriptions","organizations_url":"https://api.github.com/users/gem/orgs","repos_url":"https://api.github.com/users/gem/repos","events_url":"https://api.github.com/users/gem/events{/privacy}","received_events_url":"https://api.github.com/users/gem/received_events","type":"Organization","site_admin":false},"repo":{"id":5856509,"name":"oq-risklib","full_name":"gem/oq-risklib","owner":{"login":"gem","id":316546,"avatar_url":"https://avatars.githubusercontent.com/u/316546?v=3","gravatar_id":"","url":"https://api.github.com/users/gem","html_url":"https://github.com/gem","followers_url":"https://api.github.com/users/gem/followers","following_url":"https://api.github.com/users/gem/following{/other_user}","gists_url":"https://api.github.com/users/gem/gists{/gist_id}","starred_url":"https://api.github.com/users/gem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gem/subscriptions","organizations_url":"https://api.github.com/users/gem/orgs","repos_url":"https://api.github.com/users/gem/repos","events_url":"https://api.github.com/users/gem/events{/privacy}","received_events_url":"https://api.github.com/users/gem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gem/oq-risklib","description":"OpenQuake Risk Library","fork":false,"url":"https://api.github.com/repos/gem/oq-risklib","forks_url":"https://api.github.com/repos/gem/oq-risklib/forks","keys_url":"https://api.github.com/repos/gem/oq-risklib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gem/oq-risklib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gem/oq-risklib/teams","hooks_url":"https://api.github.com/repos/gem/oq-risklib/hooks","issue_events_url":"https://api.github.com/repos/gem/oq-risklib/issues/events{/number}","events_url":"https://api.github.com/repos/gem/oq-risklib/events","assignees_url":"https://api.github.com/repos/gem/oq-risklib/assignees{/user}","branches_url":"https://api.github.com/repos/gem/oq-risklib/branches{/branch}","tags_url":"https://api.github.com/repos/gem/oq-risklib/tags","blobs_url":"https://api.github.com/repos/gem/oq-risklib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gem/oq-risklib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gem/oq-risklib/git/refs{/sha}","trees_url":"https://api.github.com/repos/gem/oq-risklib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gem/oq-risklib/statuses/{sha}","languages_url":"https://api.github.com/repos/gem/oq-risklib/languages","stargazers_url":"https://api.github.com/repos/gem/oq-risklib/stargazers","contributors_url":"https://api.github.com/repos/gem/oq-risklib/contributors","subscribers_url":"https://api.github.com/repos/gem/oq-risklib/subscribers","subscription_url":"https://api.github.com/repos/gem/oq-risklib/subscription","commits_url":"https://api.github.com/repos/gem/oq-risklib/commits{/sha}","git_commits_url":"https://api.github.com/repos/gem/oq-risklib/git/commits{/sha}","comments_url":"https://api.github.com/repos/gem/oq-risklib/comments{/number}","issue_comment_url":"https://api.github.com/repos/gem/oq-risklib/issues/comments{/number}","contents_url":"https://api.github.com/repos/gem/oq-risklib/contents/{+path}","compare_url":"https://api.github.com/repos/gem/oq-risklib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gem/oq-risklib/merges","archive_url":"https://api.github.com/repos/gem/oq-risklib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gem/oq-risklib/downloads","issues_url":"https://api.github.com/repos/gem/oq-risklib/issues{/number}","pulls_url":"https://api.github.com/repos/gem/oq-risklib/pulls{/number}","milestones_url":"https://api.github.com/repos/gem/oq-risklib/milestones{/number}","notifications_url":"https://api.github.com/repos/gem/oq-risklib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gem/oq-risklib/labels{/name}","releases_url":"https://api.github.com/repos/gem/oq-risklib/releases{/id}","created_at":"2012-09-18T13:07:14Z","updated_at":"2015-11-05T16:05:21Z","pushed_at":"2015-11-10T12:51:41Z","git_url":"git://github.com/gem/oq-risklib.git","ssh_url":"git@github.com:gem/oq-risklib.git","clone_url":"https://github.com/gem/oq-risklib.git","svn_url":"https://github.com/gem/oq-risklib","homepage":"http://www.globalquakemodel.org/openquake/","size":32249,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":29,"forks":15,"open_issues":29,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gem/oq-risklib/pulls/514"},"html":{"href":"https://github.com/gem/oq-risklib/pull/514"},"issue":{"href":"https://api.github.com/repos/gem/oq-risklib/issues/514"},"comments":{"href":"https://api.github.com/repos/gem/oq-risklib/issues/514/comments"},"review_comments":{"href":"https://api.github.com/repos/gem/oq-risklib/pulls/514/comments"},"review_comment":{"href":"https://api.github.com/repos/gem/oq-risklib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gem/oq-risklib/pulls/514/commits"},"statuses":{"href":"https://api.github.com/repos/gem/oq-risklib/statuses/b69d161cdf9e635c4db256745b167a419093e45f"}}}}