{"push_id":733914923,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"4040f194f528c76c88be70b119cf9d7d6fcea99b","before":"f8b741d705d6219a69875e3ca1b05605957bae61","commits":[{"sha":"4040f194f528c76c88be70b119cf9d7d6fcea99b","author":{"email":"7658bca979a635f8885feb26fcbf4288a9fb3170@apache.org","name":"Robert Muir"},"message":"Refactor pluginservice\n\nCloses #12367\n\nSquashed commit of the following:\n\ncommit 9453c411798121aa5439c52e95301f60a022ba5f\nMerge: 3511a9c 828d8c7\nAuthor: Robert Muir <rmuir@apache.org>\nDate:   Wed Jul 22 08:22:41 2015 -0400\n\n    Merge branch 'master' into refactor_pluginservice\n\ncommit 3511a9c616503c447de9f0df9b4e9db3e22abd58\nAuthor: Ryan Ernst <ryan@iernst.net>\nDate:   Tue Jul 21 21:50:15 2015 -0700\n\n    Remove duplicated constant\n\ncommit 4a9b5b4621b0ef2e74c1e017d9c8cf624dd27713\nAuthor: Ryan Ernst <ryan@iernst.net>\nDate:   Tue Jul 21 21:01:57 2015 -0700\n\n    Add check that plugin must specify at least site or jvm\n\ncommit 19aef2f0596153a549ef4b7f4483694de41e101b\nAuthor: Ryan Ernst <ryan@iernst.net>\nDate:   Tue Jul 21 20:52:58 2015 -0700\n\n    Change plugin \"plugin\" property to \"classname\"\n\ncommit 07ae396f30ed592b7499a086adca72d3f327fe4c\nAuthor: Robert Muir <rmuir@apache.org>\nDate:   Tue Jul 21 23:36:05 2015 -0400\n\n    remove test with no methods\n\ncommit 550e73bf3d0f94562f4dde95239409dc5a24ce25\nAuthor: Robert Muir <rmuir@apache.org>\nDate:   Tue Jul 21 23:31:58 2015 -0400\n\n    fix loading to use classname\n\ncommit 04463aed12046da0da5cac2a24c3ace51a79f799\nAuthor: Robert Muir <rmuir@apache.org>\nDate:   Tue Jul 21 23:24:19 2015 -0400\n\n    rename to classname\n\ncommit 9f3afadd1caf89448c2eb913757036da48758b2d\nAuthor: Ryan Ernst <ryan@iernst.net>\nDate:   Tue Jul 21 20:18:46 2015 -0700\n\n    moved PluginInfo and refactored parsing from properties file\n\ncommit df63ccc1b8b7cc64d3e59d23f6c8e827825eba87\nAuthor: Robert Muir <rmuir@apache.org>\nDate:   Tue Jul 21 23:08:26 2015 -0400\n\n    fix test\n\ncommit c7febd844be358707823186a8c7a2d21e37540c9\nAuthor: Robert Muir <rmuir@apache.org>\nDate:   Tue Jul 21 23:03:44 2015 -0400\n\n    remove test\n\ncommit 017b3410cf9d2b7fca1b8653e6f1ebe2f2519257\nAuthor: Robert Muir <rmuir@apache.org>\nDate:   Tue Jul 21 22:58:31 2015 -0400\n\n    fix test\n\ncommit c9922938df48041ad43bbb3ed6746f71bc846629\nMerge: ad59af4 01ea89a\nAuthor: Robert Muir <rmuir@apache.org>\nDate:   Tue Jul 21 22:37:28 2015 -0400\n\n    Merge branch 'master' into refactor_pluginservice\n\ncommit ad59af465e1f1ac58897e63e0c25fcce641148a7\nAuthor: Areek Zillur <areek.zillur@elasticsearch.com>\nDate:   Tue Jul 21 19:30:26 2015 -0400\n\n    [TEST] Verify expected number of nodes in cluster before issuing shardStores request\n\ncommit f0f5a1e087255215b93656550fbc6bd89b8b3205\nAuthor: Lee Hinman <lee@writequit.org>\nDate:   Tue Jul 21 11:27:28 2015 -0600\n\n    Ignore EngineClosedException during translog fysnc\n\n    When performing an operation on a primary, the state is captured and the\n    operation is performed on the primary shard. The original request is\n    then modified to increment the version of the operation as preparation\n    for it to be sent to the replicas.\n\n    If the request first fails on the primary during the translog sync\n    (because the Engine is already closed due to shadow primaries closing\n    the engine on relocation), then the operation is retried on the new primary\n    after being modified for the replica shards. It will then fail due to the\n    version being incorrect (the document does not yet exist but the request\n    expects a version of \"1\").\n\n    Order of operations:\n\n    - Request is executed against primary\n    - Request is modified (version incremented) so it can be sent to replicas\n    - Engine's translog is fsync'd if necessary (failing, and throwing an exception)\n    - Modified request is retried against new primary\n\n    This change ignores the exception where the engine is already closed\n    when syncing the translog (similar to how we ignore exceptions when\n    refreshing the shard if the ?refresh=true flag is used).\n\ncommit 4ac68bb1658688550ced0c4f479dee6d8b617777\nAuthor: Shay Banon <kimchy@gmail.com>\nDate:   Tue Jul 21 22:37:29 2015 +0200\n\n    Replica allocator unit tests\n    First batch of unit tests to verify the behavior of replica allocator\n\ncommit 94609fc5943c8d85adc751b553847ab4cebe58a3\nAuthor: Jason Tedor <jason@tedor.me>\nDate:   Tue Jul 21 14:04:46 2015 -0400\n\n    Correctly list blobs in Azure storage to prevent snapshot corruption and do not unnecessarily duplicate Lucene segments in Azure Storage\n\n    This commit addresses an issue that was leading to snapshot corruption for snapshots stored as blobs in Azure Storage.\n\n    The underlying issue is that in cases when multiple snapshots of an index were taken and persisted into Azure Storage, snapshots subsequent\n    to the first would repeatedly overwrite the snapshot files. This issue does render useless all snapshots except the final snapshot.\n\n    The root cause of this is due to String concatenation involving null. In particular, to list all of the blobs in a snapshot directory in\n    Azure the code would use the method listBlobsByPrefix where the prefix is null. In the listBlobsByPrefix method, the path keyPath + prefix\n    is constructed. However, per 5.1.11, 5.4 and 15.18.1 of the Java Language Specification, the reference null is first converted to the string\n    \"null\" before performing the concatenation. This leads to no blobs being returned and therefore the snapshot mechanism would operate as if\n    it were writing the first snapshot of the index. The fix is simply to check if prefix is null and handle the concatenation accordingly.\n\n    Upon fixing this issue so that subsequent snapshots would no longer overwrite earlier snapshots, it was discovered that the snapshot metadata\n    returned by the listBlobsByPrefix method was not sufficient for the snapshot layer to detect whether or not the Lucene segments had already\n    been copied to the Azure storage layer in an earlier snapshot. This led the snapshot layer to unnecessarily duplicate these Lucene segments\n    in Azure Storage.\n\n    The root cause of this is due to known behavior in the CloudBlobContainer.getBlockBlobReference method in the Azure API. Namely, this method\n    does not fetch blob attributes from Azure. As such, the lengths of all the blobs appeared to the snapshot layer to be of length zero and\n    therefore they would compare as not equal to any new blobs that the snapshot layer is going to persist. To remediate this, the method\n    CloudBlockBlob.downloadAttributes must be invoked. This will fetch the attributes from Azure Storage so that a proper comparison of the\n    blobs can be performed.\n\n    Closes elastic/elasticsearch-cloud-azure#51, closes elastic/elasticsearch-cloud-azure#99\n\ncommit cf1d481ce5dda0a45805e42f3b2e0e1e5d028b9e\nAuthor: Lee Hinman <lee@writequit.org>\nDate:   Mon Jul 20 08:41:55 2015 -0600\n\n    Unit tests for `nodesAndVersions` on shared filesystems\n\n    With the `recover_on_any_node` setting, these unit tests check that the\n    correct node list and versions are returned.\n\ncommit 3c27cc32395c3624f7c794904d9ea4faf2eccbfb\nAuthor: Robert Muir <rmuir@apache.org>\nDate:   Tue Jul 21 14:15:59 2015 -0400\n\n    don't fail junit4 integration tests if there are no tests.\n\n    instead fail the failsafe plugin, which means the external cluster will still get shut down\n\ncommit 95d2756c5a8c21a157fa844273fc83dfa3c00aea\nAuthor: Alexander Reelsen <alexander@reelsen.net>\nDate:   Tue Jul 21 17:16:53 2015 +0200\n\n    Testing: Fix help displaying tests under windows\n\n    The help files are using a unix based file separator, where as\n    the test relies on the help being based on the file system separator.\n\n    This commit fixes the test to remove all `\\r` characters before\n    comparing strings.\n\n    The test has also been moved into its own CliToolTestCase, as it does\n    not need to be an integration test.\n\ncommit 944f06ea36bd836f007f8eaade8f571d6140aad9\nAuthor: Clinton Gormley <clint@traveljury.com>\nDate:   Tue Jul 21 18:04:52 2015 +0200\n\n    Refactored check_license_and_sha.pl to accept a license dir and package path\n\n    In preparation for the move to building the core zip, tar.gz, rpm, and deb as separate modules, refactored check_license_and_sha.pl to:\n\n    * accept a license dir and path to the package to check on the command line\n    * to be able to extract zip, tar.gz, deb, and rpm\n    * all packages except rpm will work on Windows\n\ncommit 2585431e8dfa5c82a2cc5b304cd03eee9bed7a4c\nAuthor: Chris Earle <pickypg@users.noreply.github.com>\nDate:   Tue Jul 21 08:35:28 2015 -0700\n\n    Updating breaking changes\n\n    - field names cannot be mapped with `.` in them\n    - fixed asciidoc issue where the list was not recognized as a list\n\ncommit de299b9d3f4615b12e2226a1e2eff5a38ecaf15f\nAuthor: Shay Banon <kimchy@gmail.com>\nDate:   Tue Jul 21 13:27:52 2015 +0200\n\n    Replace primaryPostAllocated flag and use UnassignedInfo\n    There is no need to maintain additional state as to if a primary was allocated post api creation on the index routing table, we hold all this information already in the UnassignedInfo class.\n    closes #12374\n\ncommit 43080bff40f60bedce5bdbc92df302f73aeb9cae\nAuthor: Alexander Reelsen <alexander@reelsen.net>\nDate:   Tue Jul 21 15:45:05 2015 +0200\n\n    PluginManager: Fix bin/plugin calls in scripts/bats test\n\n    The release and smoke test python scripts used to install\n    plugins in the old fashion.\n\n    Also the BATS testing suite installed/removed plugins in that\n    way. Here the marvel tests have been removed, as marvel currently\n    does not work with the master branch.\n\n    In addition documentation has been updated as well, where it was\n    still missing.\n\ncommit b81ccba48993bc13c7678e6d979fd96998499233\nAuthor: Boaz Leskes <b.leskes@gmail.com>\nDate:   Tue Jul 21 11:37:50 2015 +0200\n\n    Discovery: make sure NodeJoinController.ElectionCallback is always called from the update cluster state thread\n\n    This is important for correct handling of the joining thread. This causes assertions to trip in our test runs. See http://build-us-00.elastic.co/job/es_g1gc_master_metal/11653/ as an example\n\n    Closes #12372\n\ncommit 331853790bf29e34fb248ebc4c1ba585b44f5cab\nAuthor: Boaz Leskes <b.leskes@gmail.com>\nDate:   Tue Jul 21 15:54:36 2015 +0200\n\n    Remove left over no commit from TransportReplicationAction\n\n    It asks to double check thread pool rejection. I did and don't see problems with it.\n\ncommit e5724931bbc1603e37faa977af4235507f4811f5\nAuthor: Alexander Reelsen <alexander@reelsen.net>\nDate:   Tue Jul 21 15:31:57 2015 +0200\n\n    CliTool: Various PluginManager fixes\n\n    The new plugin manager parser was not called correctly in the scripts.\n    In addition the plugin manager now creates a plugins/ directory in case\n    it does not exist.\n\n    Also the integration tests called the plugin manager in the deprecated way.\n\ncommit 7a815a370f83ff12ffb12717ac2fe62571311279\nAuthor: Alexander Reelsen <alexander@reelsen.net>\nDate:   Tue Jul 21 13:54:18 2015 +0200\n\n    CLITool: Port PluginManager to use CLITool\n\n    In order to unify the handling and reuse the CLITool infrastructure\n    the plugin manager should make use of this as well.\n\n    This obsolets the -i and --install options but requires the user\n    to use `install` as the first argument of the CLI.\n\n    This is basically just a port of the existing functionality, which\n    is also the reason why this is not a refactoring of the plugin manager,\n    which will come in a separate commit.\n\ncommit 7f171eba7b71ac5682a355684b6da703ffbfccc7\nAuthor: Martijn van Groningen <martijn.v.groningen@gmail.com>\nDate:   Tue Jul 21 10:44:21 2015 +0200\n\n    Remove custom execute local logic in TransportSingleShardAction and TransportInstanceSingleOperationAction and rely on transport service to execute locally. (forking thread etc.)\n\n    Change TransportInstanceSingleOperationAction to have shardActionHandler to, so we can execute locally without endless spinning.\n\ncommit 0f38e3eca6b570f74b552e70b4673f47934442e1\nAuthor: Ryan Ernst <ryan@iernst.net>\nDate:   Tue Jul 21 17:36:12 2015 -0700\n\n    More readMetadata tests and pickiness\n\ncommit 880b47281bd69bd37807e8252934321b089c9f8e\nAuthor: Ryan Ernst <ryan@iernst.net>\nDate:   Tue Jul 21 14:42:09 2015 -0700\n\n    Started unit tests for plugin service\n\ncommit cd7c8ddd7b8c4f3457824b493bffb19c156c7899\nAuthor: Robert Muir <rmuir@apache.org>\nDate:   Tue Jul 21 07:21:07 2015 -0400\n\n    fix tests\n\ncommit 673454f0b14f072f66ed70e32110fae4f7aad642\nAuthor: Robert Muir <rmuir@apache.org>\nDate:   Tue Jul 21 06:58:25 2015 -0400\n\n    refactor pluginservice","distinct":true,"url":"https://api.github.com/repos/elastic/elasticsearch/commits/4040f194f528c76c88be70b119cf9d7d6fcea99b"}]}