{"action":"created","issue":{"url":"https://api.github.com/repos/dunglas/DunglasApiBundle/issues/279","labels_url":"https://api.github.com/repos/dunglas/DunglasApiBundle/issues/279/labels{/name}","comments_url":"https://api.github.com/repos/dunglas/DunglasApiBundle/issues/279/comments","events_url":"https://api.github.com/repos/dunglas/DunglasApiBundle/issues/279/events","html_url":"https://github.com/dunglas/DunglasApiBundle/pull/279","id":107589030,"number":279,"title":"Fix IriConverterInterface return value","user":{"login":"theofidry","id":5175937,"avatar_url":"https://avatars.githubusercontent.com/u/5175937?v=3","gravatar_id":"","url":"https://api.github.com/users/theofidry","html_url":"https://github.com/theofidry","followers_url":"https://api.github.com/users/theofidry/followers","following_url":"https://api.github.com/users/theofidry/following{/other_user}","gists_url":"https://api.github.com/users/theofidry/gists{/gist_id}","starred_url":"https://api.github.com/users/theofidry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theofidry/subscriptions","organizations_url":"https://api.github.com/users/theofidry/orgs","repos_url":"https://api.github.com/users/theofidry/repos","events_url":"https://api.github.com/users/theofidry/events{/privacy}","received_events_url":"https://api.github.com/users/theofidry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-09-21T20:10:22Z","updated_at":"2015-10-04T17:42:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dunglas/DunglasApiBundle/pulls/279","html_url":"https://github.com/dunglas/DunglasApiBundle/pull/279","diff_url":"https://github.com/dunglas/DunglasApiBundle/pull/279.diff","patch_url":"https://github.com/dunglas/DunglasApiBundle/pull/279.patch"},"body":"The DataProvider can return `null`, (specified in [`DataProviderInterface`](https://github.com/dunglas/DunglasApiBundle/blob/master/Model/DataProviderInterface.php#L30)), so it's only logical that the [`IriConverterInterface`](https://github.com/dunglas/DunglasApiBundle/blob/master/Api/IriConverterInterface.php#L30) does the same. Also from the current implementation of [`SearchFilter::getFilterValueFromUrl()`](https://github.com/dunglas/DunglasApiBundle/blob/master/Doctrine/Orm/Filter/SearchFilter.php#L190-L192) rely on this result.\r\n\r\nCan also be merged back to the 1.0."},"comment":{"url":"https://api.github.com/repos/dunglas/DunglasApiBundle/issues/comments/145368594","html_url":"https://github.com/dunglas/DunglasApiBundle/pull/279#issuecomment-145368594","issue_url":"https://api.github.com/repos/dunglas/DunglasApiBundle/issues/279","id":145368594,"user":{"login":"theofidry","id":5175937,"avatar_url":"https://avatars.githubusercontent.com/u/5175937?v=3","gravatar_id":"","url":"https://api.github.com/users/theofidry","html_url":"https://github.com/theofidry","followers_url":"https://api.github.com/users/theofidry/followers","following_url":"https://api.github.com/users/theofidry/following{/other_user}","gists_url":"https://api.github.com/users/theofidry/gists{/gist_id}","starred_url":"https://api.github.com/users/theofidry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theofidry/subscriptions","organizations_url":"https://api.github.com/users/theofidry/orgs","repos_url":"https://api.github.com/users/theofidry/repos","events_url":"https://api.github.com/users/theofidry/events{/privacy}","received_events_url":"https://api.github.com/users/theofidry/received_events","type":"User","site_admin":false},"created_at":"2015-10-04T17:42:01Z","updated_at":"2015-10-04T17:42:01Z","body":">but using null values is acceptable IMO.\r\n\r\nAnd more consistent ;)"}}