{"push_id":693871976,"size":22,"distinct_size":22,"ref":"refs/heads/master","head":"ffd3159e3ca0a473d8f206d38da249ce513e177d","before":"fee9e7887868e93177bade5534eec065b713fd07","commits":[{"sha":"92e868c2fef9350983f8d03555087cea4872584b","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Disable the \"Edit Project\" button for users without edit permissions\n\nSummary: Self-explanatory.\n\nTest Plan: Viewed the project page as a user without edit permissions and saw the link greyed out.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nDifferential Revision: https://secure.phabricator.com/D13255","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/92e868c2fef9350983f8d03555087cea4872584b"},{"sha":"c461e5f3d932647169b698b3f95ec5edcbdf2fa2","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"FreeBSD prefers 8 space tabs rather than 2","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/c461e5f3d932647169b698b3f95ec5edcbdf2fa2"},{"sha":"23a0ba069e3182ffe97204d7de00befab718b2ab","author":{"email":"aeb8da9b93f4f35c2ddc1280821f190e432a94e3@freebsd.org","name":"Ed Maste"},"message":"Avoid \"ready to land\" terminology\n\nReport only that a change has had a positive review, allowing the\nsubmitter to follow usual workflow conventions in FreeBSD. We use\nPhabricator as a standalone tool to facilitate review if desired,\nbut its use is not required, and does not dictate our workflow.\n\nClaiming a change is \"ready to land\" after one positive review does not\nmesh with the usual workflow in the FreeBSD community. Some changes may\nrequire more than one reviewer or additional testing, for example.","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/23a0ba069e3182ffe97204d7de00befab718b2ab"},{"sha":"b9f7f6a68181bdf976301866a452dc31256128de","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"Permit to join IRC channels with keys","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/b9f7f6a68181bdf976301866a452dc31256128de"},{"sha":"532a9db5d2e06785fc6aedd3f2ce19b0759c7bd7","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"Freebsd custom patch for user auth\n\nSince we want usernames to depend on the email provided, hack are way\nthrough it.  An extension can not handle this level of intrusiveness\n\nI'm sorry oh coding gods","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/532a9db5d2e06785fc6aedd3f2ce19b0759c7bd7"},{"sha":"9b5a2cded2ab881946ba1401b10087c94d37065e","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"Teach PhabricatorBotObjectNameHandler not to respond to C* states","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/9b5a2cded2ab881946ba1401b10087c94d37065e"},{"sha":"e17e771919da85a0f39e788697f999ea08c07e30","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"Add two new herald extensions\n\nAdd two extensions, stolen from\nhttps://github.com/haskell-infra/libphutil-haskell to do more things\nwith Herald.","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/e17e771919da85a0f39e788697f999ea08c07e30"},{"sha":"dcd0706892ac8f7554d6314b3bb2e3b5f1d7a80a","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"Don't ignore extensions in the FreeBSD install\n\nwe use them, so don't ignore them by default","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/dcd0706892ac8f7554d6314b3bb2e3b5f1d7a80a"},{"sha":"c906388c4fc2e2f506feae6501826ca2d1e799cc","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"Unbreak notification handler","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/c906388c4fc2e2f506feae6501826ca2d1e799cc"},{"sha":"dc98d0cd83e3429d78fb9b72eb5011ef240fd2fd","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Allow Aphlict admin server to be specified\n\nSummary:\nAllow flags to be passed to `./bin/aphlict` to specify the hostname and port for the admin server. On our install, `notification.server-uri` is set to `notify.phabricator.mydomain.com` and, as such, the NodeJS server is started with `--admin-host=notify.phabricator.mydomain.com` instead of the desired `--admin-host=0.0.0.0`.\n\nThis is essentially another take on D11359.\n\nTest Plan: Ran `./bin/aphlict debug` with a bunch of different arguments.\n\nReviewers: #blessed_reviewers, epriestley\n\nSubscribers: epriestley\n\nDifferential Revision: https://secure.phabricator.com/D13148","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/dc98d0cd83e3429d78fb9b72eb5011ef240fd2fd"},{"sha":"ecbdee67574846619b4485e26d71ce842054e52e","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Migrate differential hunks to modern storage\n\nSummary: Fixes T8475. A long time ago (in D9290), a new hunk storage was added. From this point, new #differential diffs were written to the \"modern\" storage, whilst existing diffs were kept in \"legacy\" storage. A command line script (`./bin/hunks migrate`) was provided to migrate data from legacy storage to modern storage, but this script only migrates one-hunk-at-a-time. Given that this code has proven to be stable (all of the hunks on our install were migrated over 6 months ago, and @epriestley mentioned that https://secure.phabricator.com did the same), we should force all installs to migrate hunks to modern storage.\n\nTest Plan:\nChecked out the following versions of the code base:\n\n| Repository | Commit |\n|------------|---------|\n| {rARC} | rARC50caec620a8ed45c54323cb71fee72fd0d935115 |\n| {rPHU} | rPHU1e025a87a4cbd987ecabf9924d20412e24e6cf87 |\n| {rP} | rP4b9765b89672d5d592580d6001e6763db5ee0358 |\n\nCreated a few diffs and then upgraded to `HEAD`. Applied migrations successfully and then browsed around migrated diffs in the UI.\n\nReviewers: #blessed_reviewers, epriestley\n\nSubscribers: epriestley, Korvin\n\nManiphest Tasks: T8475\n\nDifferential Revision: https://secure.phabricator.com/D13222","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/ecbdee67574846619b4485e26d71ce842054e52e"},{"sha":"0f77146395087d5334b16038819f71f84ddff616","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Allow different policy rules for different types of objects\n\nSummary:\nRef T5681. Policy rules can now select objects they can apply to, so a rule like \"task author\" only shows up where it makes sense (when defining task policies).\n\nThis will let us define rules like \"members of thread\" in Conpherence, \"subscribers\", etc., to make custom policies more flexible.\n\nNotes:\n\n  - Per D13251, we need to do a little work to get the right options for policies like \"Maniphest > Default View Policy\". This should allow \"task\" policies.\n  - This implements a \"task author\" policy as a simple example.\n  - The `willApplyRule()` signature now accepts `$objects` to support bulk-loading things like subscribers.\n\nTest Plan:\n  - Defined a task to be \"visible to: task author\", verified author could see it and other users could not.\n  - `var_dump()`'d willApplyRule() inputs, verified they were correct (exactly the objects which use the rule).\n  - Set `default view policy` to a task-specific policy.\n  - Verified that other policies like \"Can Use Bulk Editor\" don't have these options.\n\nReviewers: btrahan\n\nReviewed By: btrahan\n\nSubscribers: epriestley\n\nManiphest Tasks: T5681\n\nDifferential Revision: https://secure.phabricator.com/D13252","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/0f77146395087d5334b16038819f71f84ddff616"},{"sha":"f5d57e1612444e58ff8f64508ffce536d6d18bfa","author":{"email":"25b6170de171dac8b38030674da0d668d8db4286@uber.com","name":"Povilas Balzaravicius Pawka"},"message":"Fix exception when same tag as primary slug is provided during project creation.\n\nSummary: T8509\n\nTest Plan: Follow steps described in T8509.\n\nReviewers: #blessed_reviewers, eadler\n\nReviewed By: eadler\n\nSubscribers: epriestley\n\nManiphest Tasks: T8509\n\nDifferential Revision: https://secure.phabricator.com/D13244","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/f5d57e1612444e58ff8f64508ffce536d6d18bfa"},{"sha":"a43b9b54934bd851efb9c3e9797b2674abbc0ffa","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Allow PolicyRules to serve as \"Object Policies\"\n\nSummary:\nRef T5681. Ref T8488. This allows policy rules to provide \"Object Policies\", which are similar to the global/basic policies:\n\n  - They show up directly in the dropdown (you don't have to create a custom rule).\n  - They don't need to create or load anything in the database.\n\nTo implement one, you just add a couple methods on an existing PolicyRule that let Phabricator know it can work as an object policy rule.\n\n{F494764}\n\nThese rules only show up where they make sense. For example, the \"Task Author\" rule is only available in Maniphest, and in \"Default View Policy\" / \"Default Edit Policy\" of the Application config.\n\nThis should make T8488 easier by letting us set the default policies to \"Members of Thread\", without having to create a dedicated custom policy for every thread.\n\nTest Plan:\n  - Set tasks to \"Task Author\" policy.\n  - Tried to view them as other users.\n  - Viewed transaction change strings.\n  - Viewed policy errors.\n  - Set them as default policies.\n  - Verified they don't leak into other policy controls.\n\nReviewers: btrahan\n\nReviewed By: btrahan\n\nSubscribers: epriestley\n\nManiphest Tasks: T5681, T8488\n\nDifferential Revision: https://secure.phabricator.com/D13257","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/a43b9b54934bd851efb9c3e9797b2674abbc0ffa"},{"sha":"2a956e038d4b09194874d9b5ab030461e6dee899","author":{"email":"bc4bd52f99de2e3a917136da4aaf9cc42f1711b5@gmail.com","name":"Aviv Eyal"},"message":"lose help cursor on blur\n\nSummary:\nFixes T8501.\nWhen losing focus while holding ctrl, we never get a key-up event; ctrl-f/d/tab make the browser tab lose focus.\nSo treat 'blur' (unfocus) as if the user released ctrl.\n\nTest Plan: ctrl-f/ctrl-d/ctrl-tab, ctrl-click-outside-of-window, and move mouse over the content - see no help suggestions.\n\nReviewers: #blessed_reviewers\n\nSubscribers: epriestley\n\nManiphest Tasks: T8501\n\nDifferential Revision: https://secure.phabricator.com/D13260","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/2a956e038d4b09194874d9b5ab030461e6dee899"},{"sha":"aebbce9191e53dcf81d4adff1028fd1b9bd5ab1d","author":{"email":"c1f3d977f9d8aee323707c2bed0ad77fa19e3dbc@gmail.com","name":"Byron Grobe"},"message":"Added instructions for configuring Postfix\n\nSummary: This adds instructions to aid in configuring Postfix mail receipt and delivery.\n\nTest Plan: Read and review.\n\nReviewers: #blessed_reviewers\n\nSubscribers: cburroughs, epriestley\n\nDifferential Revision: https://secure.phabricator.com/D12445","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/aebbce9191e53dcf81d4adff1028fd1b9bd5ab1d"},{"sha":"8d698e8c1febc055eaa878d89cc95452d8489155","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Allow differential changesets to be marked as generated via diff properties\n\nSummary:\nRef T784. Allow differential changesets to be marked as generated with a `DifferentialDiffProperty`. The expectation is that `arc diff` will submit an `arc:generated` diff property (which will be populated out of the local `.arcconfig` file). These paths will then be automatically marked as generated when rendering the differential changeset.\n\nCurrently, the only way to achieve this is with `differential.generated-paths`. The main issue with `differential.generated-paths` is that it is a global setting and cannot be varied across repositories. A natural extension from `differential.generated-paths` would be to move this configuration into the per-repository configuration, however I feel that this approach would be too inflexible to be useful. Specifically, this setting would need to be updated whenever generated paths are added/removed/changed for a particular repository (although I would expect this to be a fairly infrequent occurrence).\n\nUnfortunately, this functionality will not be retrofitted to existing differentials. We //could// possibly add a migration which populates `arc:generated` for all existing differentials based on the value of `differential.generated-paths`, although I'm not convinced that this is worth pursuing.\n\nTest Plan:\nUploaded a diff (using `arc diff`) and set paths for `arc:generated` with `arc call-conduit 'differential.setdiffproperty'`. Loaded the differential in the UI and noticed that the paths were marked as generated as expected.\n\nOne interesting thing to note (I'm not sure if I would consider this to be a bug or expected behavior) is that lint messages takes a higher precedence over generated paths. If a path matches a regular expression in `arc:generated` but has some linter messages associated with that path, then the file will //not// be shown as generated in the UI. This is mainly an issue until after D11537.\n\nReviewers: epriestley, #blessed_reviewers\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T784\n\nDifferential Revision: https://secure.phabricator.com/D11535","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/8d698e8c1febc055eaa878d89cc95452d8489155"},{"sha":"1b0adb7df1788968f3e643b6e20c6bbdcdbf644e","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"Remove deprecated generated paths configuration\n\nSummary: Ref T784. The `differential.generated-paths` configuration is deprecated in favor of using the `generated-paths` setting in a project's `.arcconfig` file. Depends on D11535.\n\nTest Plan: Not entirely sure how to test this.\n\nReviewers: epriestley, #blessed_reviewers\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T784\n\nDifferential Revision: https://secure.phabricator.com/D11538","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/1b0adb7df1788968f3e643b6e20c6bbdcdbf644e"},{"sha":"376e6f88a9a45e43290ac46f68fb6e6743b5bd71","author":{"email":"a35f9abe9153679d6785d3abe801ca381209e572@siemens.com","name":"David Schumann"},"message":"Fixed T7000\n\nSummary: Fixed T7000\n\nTest Plan:\n1) Create repository with limited access for only one user\n2) Make phabricator public\n3) Push/Pull to the repository\n\nReviewers: #blessed_reviewers, epriestley\n\nSubscribers: joshuaspence, epriestley\n\nManiphest Tasks: T7000\n\nDifferential Revision: https://secure.phabricator.com/D11462","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/376e6f88a9a45e43290ac46f68fb6e6743b5bd71"},{"sha":"d9d8706fd294fedf943e6f19606d82835bb12624","author":{"email":"e2d743f4419ca2fe77d9cd7ed477fc3369433991@gmail.com","name":"Alexander Obuhovich"},"message":"Show SVN property changes on commit page\n\nSummary:\nAllows to see changes within SVN properties on commit page.\n\nThis is actually the improved version of D8478, that supports also SVN 1.6 clients.\nIf this diff is to be merged, then that one needs to be closed.\n\nFixes T4255\n\nTest Plan:\n# make a commit where SVN properties are added/changed/removed\n# open commit detail page\n# see that SVN property changes are supported\n\nReviewers: #blessed_reviewers\n\nSubscribers: altendky, epriestley\n\nManiphest Tasks: T4255\n\nDifferential Revision: https://secure.phabricator.com/D10977","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/d9d8706fd294fedf943e6f19606d82835bb12624"}]}