{"action":"created","issue":{"url":"https://api.github.com/repos/berndbischl/mlr/issues/323","labels_url":"https://api.github.com/repos/berndbischl/mlr/issues/323/labels{/name}","comments_url":"https://api.github.com/repos/berndbischl/mlr/issues/323/comments","events_url":"https://api.github.com/repos/berndbischl/mlr/issues/323/events","html_url":"https://github.com/berndbischl/mlr/pull/323","id":86731499,"number":323,"title":"interface consistency","user":{"login":"zmjones","id":1114501,"avatar_url":"https://avatars.githubusercontent.com/u/1114501?v=3","gravatar_id":"","url":"https://api.github.com/users/zmjones","html_url":"https://github.com/zmjones","followers_url":"https://api.github.com/users/zmjones/followers","following_url":"https://api.github.com/users/zmjones/following{/other_user}","gists_url":"https://api.github.com/users/zmjones/gists{/gist_id}","starred_url":"https://api.github.com/users/zmjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmjones/subscriptions","organizations_url":"https://api.github.com/users/zmjones/orgs","repos_url":"https://api.github.com/users/zmjones/repos","events_url":"https://api.github.com/users/zmjones/events{/privacy}","received_events_url":"https://api.github.com/users/zmjones/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-09T20:51:03Z","updated_at":"2015-06-09T21:59:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/berndbischl/mlr/pulls/323","html_url":"https://github.com/berndbischl/mlr/pull/323","diff_url":"https://github.com/berndbischl/mlr/pull/323.diff","patch_url":"https://github.com/berndbischl/mlr/pull/323.patch"},"body":"had to merge the branches to finish up the interface consistency changes. i guess i should have instead branched off of the branch that i wrote `generateThreshVsPerfData` in? that would be the best way to have done this?"},"comment":{"url":"https://api.github.com/repos/berndbischl/mlr/issues/comments/110517046","html_url":"https://github.com/berndbischl/mlr/pull/323#issuecomment-110517046","issue_url":"https://api.github.com/repos/berndbischl/mlr/issues/323","id":110517046,"user":{"login":"larskotthoff","id":579233,"avatar_url":"https://avatars.githubusercontent.com/u/579233?v=3","gravatar_id":"","url":"https://api.github.com/users/larskotthoff","html_url":"https://github.com/larskotthoff","followers_url":"https://api.github.com/users/larskotthoff/followers","following_url":"https://api.github.com/users/larskotthoff/following{/other_user}","gists_url":"https://api.github.com/users/larskotthoff/gists{/gist_id}","starred_url":"https://api.github.com/users/larskotthoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larskotthoff/subscriptions","organizations_url":"https://api.github.com/users/larskotthoff/orgs","repos_url":"https://api.github.com/users/larskotthoff/repos","events_url":"https://api.github.com/users/larskotthoff/events{/privacy}","received_events_url":"https://api.github.com/users/larskotthoff/received_events","type":"User","site_admin":false},"created_at":"2015-06-09T21:59:27Z","updated_at":"2015-06-09T21:59:27Z","body":"I would have made the two changes completely separately, but don't worry about it now. Again the interface changes to make them more consistent is something that should be mentioned in NEWS, in particular what functions are affected.\r\n\r\nRegarding the build, you could use cheaper classifiers in the tests as they're not testing anything directly related to the classifiers. You could even create some very cheap mock classifiers (although this might be something that should be done separately)."}}