{"action":"created","issue":{"url":"https://api.github.com/repos/L7labs/sinon-bluebird/issues/3","labels_url":"https://api.github.com/repos/L7labs/sinon-bluebird/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/L7labs/sinon-bluebird/issues/3/comments","events_url":"https://api.github.com/repos/L7labs/sinon-bluebird/issues/3/events","html_url":"https://github.com/L7labs/sinon-bluebird/issues/3","id":59649105,"number":3,"title":"Declares sinon as a dependency, and sometimes monkey-patches its own copy","user":{"login":"rprieto","id":189105,"avatar_url":"https://avatars.githubusercontent.com/u/189105?v=3","gravatar_id":"","url":"https://api.github.com/users/rprieto","html_url":"https://github.com/rprieto","followers_url":"https://api.github.com/users/rprieto/followers","following_url":"https://api.github.com/users/rprieto/following{/other_user}","gists_url":"https://api.github.com/users/rprieto/gists{/gist_id}","starred_url":"https://api.github.com/users/rprieto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rprieto/subscriptions","organizations_url":"https://api.github.com/users/rprieto/orgs","repos_url":"https://api.github.com/users/rprieto/repos","events_url":"https://api.github.com/users/rprieto/events{/privacy}","received_events_url":"https://api.github.com/users/rprieto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-03T14:31:20Z","updated_at":"2015-03-03T19:43:06Z","closed_at":null,"body":"It seems sinon is declared as a `dependency`. Since we use `sinon < 1.12`, sinon-bluebird was getting its own copy in `sinon-bluebird/node_modules`, and attaching the new keywords there.\r\n\r\n```\r\n{\r\n  \"dependencies\": {\r\n    \"bluebird\": \"^2.9.12\",\r\n    \"sinon\": \"^1.12.2\"\r\n  },\r\n  \"peerDependencies\": {\r\n    \"sinon\": \"1.x\"\r\n  }\r\n}\r\n```\r\n\r\nIt's also declared as a `peerDependency`, which sounds good, so maybe `dependencies` is an accident? Since it's used in the tests, should it be a `devDependency` instead?\r\n"},"comment":{"url":"https://api.github.com/repos/L7labs/sinon-bluebird/issues/comments/77018995","html_url":"https://github.com/L7labs/sinon-bluebird/issues/3#issuecomment-77018995","issue_url":"https://api.github.com/repos/L7labs/sinon-bluebird/issues/3","id":77018995,"user":{"login":"rprieto","id":189105,"avatar_url":"https://avatars.githubusercontent.com/u/189105?v=3","gravatar_id":"","url":"https://api.github.com/users/rprieto","html_url":"https://github.com/rprieto","followers_url":"https://api.github.com/users/rprieto/followers","following_url":"https://api.github.com/users/rprieto/following{/other_user}","gists_url":"https://api.github.com/users/rprieto/gists{/gist_id}","starred_url":"https://api.github.com/users/rprieto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rprieto/subscriptions","organizations_url":"https://api.github.com/users/rprieto/orgs","repos_url":"https://api.github.com/users/rprieto/repos","events_url":"https://api.github.com/users/rprieto/events{/privacy}","received_events_url":"https://api.github.com/users/rprieto/received_events","type":"User","site_admin":false},"created_at":"2015-03-03T19:43:06Z","updated_at":"2015-03-03T19:43:06Z","body":"That sounds great to me :+1:  Thanks for the quick reply!\r\n\r\n*Note:* probably worth following the `npm` conversations about peerDependencies, looks like there will be changes at some point but for now that makes sense to me.\r\n"}}