{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1812","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1812/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1812/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1812/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/1812","id":53247634,"number":1812,"title":"Fix various issues with NanoByte's port of neobrain's zfreeze branch.","user":{"login":"phire","id":138484,"avatar_url":"https://avatars.githubusercontent.com/u/138484?v=3","gravatar_id":"","url":"https://api.github.com/users/phire","html_url":"https://github.com/phire","followers_url":"https://api.github.com/users/phire/followers","following_url":"https://api.github.com/users/phire/following{/other_user}","gists_url":"https://api.github.com/users/phire/gists{/gist_id}","starred_url":"https://api.github.com/users/phire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phire/subscriptions","organizations_url":"https://api.github.com/users/phire/orgs","repos_url":"https://api.github.com/users/phire/repos","events_url":"https://api.github.com/users/phire/events{/privacy}","received_events_url":"https://api.github.com/users/phire/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":25,"created_at":"2015-01-02T11:13:24Z","updated_at":"2015-01-10T10:06:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1812","html_url":"https://github.com/dolphin-emu/dolphin/pull/1812","diff_url":"https://github.com/dolphin-emu/dolphin/pull/1812.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/1812.patch"},"body":"This is now pretty functional. Could do with some code cleanups and/or optimisations.\r\n\r\n * Don't cull CULLALL primitives so early so they can be used as reference\r\n        planes.\r\n * Convert CalculateZSlope to screenspace coordinates.\r\n * Convert Pixelshader to screenspace coordinates (instead of worldspace\r\n        xy coordinates, which is totally wrong)\r\n * Divide depth by 2^24 instead of clamping to 0.0-1.0 as was done\r\n        before.\r\n\r\nWorks in all known games with zfreeze.\r\n\r\n## Known Issues:\r\n- [ ] The Delfino Plaza court in Mario Power Tennis has zfighting issues. These may be unfixable.\r\n\r\n## Todo:\r\n - [ ] Don't update the constants uniform buffer before every drawcall.\r\n - [ ] Cleanup CULLALL mode code path.\r\n - [ ] Make sure this isn't broken on anyone's video card."},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/69450619","html_url":"https://github.com/dolphin-emu/dolphin/pull/1812#issuecomment-69450619","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1812","id":69450619,"user":{"login":"NanoByte011","id":8997598,"avatar_url":"https://avatars.githubusercontent.com/u/8997598?v=3","gravatar_id":"","url":"https://api.github.com/users/NanoByte011","html_url":"https://github.com/NanoByte011","followers_url":"https://api.github.com/users/NanoByte011/followers","following_url":"https://api.github.com/users/NanoByte011/following{/other_user}","gists_url":"https://api.github.com/users/NanoByte011/gists{/gist_id}","starred_url":"https://api.github.com/users/NanoByte011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanoByte011/subscriptions","organizations_url":"https://api.github.com/users/NanoByte011/orgs","repos_url":"https://api.github.com/users/NanoByte011/repos","events_url":"https://api.github.com/users/NanoByte011/events{/privacy}","received_events_url":"https://api.github.com/users/NanoByte011/received_events","type":"User","site_admin":false},"created_at":"2015-01-10T10:06:18Z","updated_at":"2015-01-10T10:06:18Z","body":"For JMC47 :)\r\nSo I have fixes in the works for zfreeze with FastDepthCalc enabled and should fix remaining games, just have to cleanup code and port changes to OGL backend from the D3D side I'm working in ( I'll make a PR from this PR when done... probably tomorrow night ).\r\n![rmap01-4](https://cloud.githubusercontent.com/assets/8997598/5691127/d024f900-9874-11e4-9360-9bddcb31e568.png)\r\n\r\nAs another side note... it looks like the lighting for the main characters are inversed?  (They seem dim)... same with the menus... is there a bug filed on this?  ... hmmm I hope some light position isn't based on zfreeze!"}}