{"push_id":641042294,"size":8,"distinct_size":8,"ref":"refs/heads/report-a-problem-refactoring","head":"bb6a7841ea1071f4503fc6b6d3f50b5c056bf2f7","before":"ea8c4e2029d871c37f8d45fd7ddd24e60693e856","commits":[{"sha":"8661d856ce91249d055e90a8637264819e70d8fe","author":{"email":"4587b71a81b1a01d774ffa648ef57e13aebc6730@gmail.com","name":"Jake Benilov"},"message":"report-a-problem: split responsibilities\n\n`window.GOVUK.reportAProblem` has been split into a `ReportAProblem` class\n(which is responsible for the entire report-a-problem widget) and a\n`ReportAProblemForm`, which is scoped to just the form. This refactoring\nmakes the code less procedural.","distinct":true,"url":"https://api.github.com/repos/alphagov/static/commits/8661d856ce91249d055e90a8637264819e70d8fe"},{"sha":"3dbd39656a214dee86a3a4f61d3908c148e63939","author":{"email":"4587b71a81b1a01d774ffa648ef57e13aebc6730@gmail.com","name":"Jake Benilov"},"message":"report-a-problem: increase test coverage","distinct":true,"url":"https://api.github.com/repos/alphagov/static/commits/3dbd39656a214dee86a3a4f61d3908c148e63939"},{"sha":"1bdd02bc344570ce2642ea61a959718f79b7b4df","author":{"email":"12ca95a439b13b609744183b9d2f79ca5b64ed8f@users.noreply.github.com","name":"Paul Hayes"},"message":"Move `show` message methods into form\n\nRemove last use of `reportAProblem`","distinct":true,"url":"https://api.github.com/repos/alphagov/static/commits/1bdd02bc344570ce2642ea61a959718f79b7b4df"},{"sha":"2debdfdd7169b691b47183bfeeb748ace40eaf72","author":{"email":"12ca95a439b13b609744183b9d2f79ca5b64ed8f@users.noreply.github.com","name":"Paul Hayes"},"message":"Move ReportAProblemForm into file\n\nSplit ReportAProblemForm and ReportAProblem into two files for clarity.","distinct":true,"url":"https://api.github.com/repos/alphagov/static/commits/2debdfdd7169b691b47183bfeeb748ace40eaf72"},{"sha":"57202c332eee99a337bfdacef6f9e575b0a1d654","author":{"email":"12ca95a439b13b609744183b9d2f79ca5b64ed8f@users.noreply.github.com","name":"Paul Hayes"},"message":"Cleanup addToggleLink method\n\n* Don’t concatenate string, use `\\` line break\n* Move `var` declaration to top\n* Keep quotes consistent","distinct":true,"url":"https://api.github.com/repos/alphagov/static/commits/57202c332eee99a337bfdacef6f9e575b0a1d654"},{"sha":"d878d21381009b066b0c9d84736574775a62c700","author":{"email":"12ca95a439b13b609744183b9d2f79ca5b64ed8f@users.noreply.github.com","name":"Paul Hayes"},"message":"Minimise use of `this` in report a problem\n\nImprove readability of module","distinct":true,"url":"https://api.github.com/repos/alphagov/static/commits/d878d21381009b066b0c9d84736574775a62c700"},{"sha":"4045b903e3f052e2269f1a53de172f08d3146179","author":{"email":"12ca95a439b13b609744183b9d2f79ca5b64ed8f@users.noreply.github.com","name":"Paul Hayes"},"message":"Move error and confirmation to ReportAProblem\n\nThe error and confirmation messages affect HTML beyond the scope of the\nform module, instead trigger events and allow ReportAProblem module to\ndetermine how to handle these situations.\n\n* Also use smart quotes for error message","distinct":true,"url":"https://api.github.com/repos/alphagov/static/commits/4045b903e3f052e2269f1a53de172f08d3146179"},{"sha":"bb6a7841ea1071f4503fc6b6d3f50b5c056bf2f7","author":{"email":"12ca95a439b13b609744183b9d2f79ca5b64ed8f@users.noreply.github.com","name":"Paul Hayes"},"message":"Use a familiar `submit` listener\n\nImprove readability and make it clear that there’s an ‘on submit’\nlistener.","distinct":true,"url":"https://api.github.com/repos/alphagov/static/commits/bb6a7841ea1071f4503fc6b6d3f50b5c056bf2f7"}]}