{"action":"created","comment":{"url":"https://api.github.com/repos/ropensci/plotly/pulls/comments/26530197","id":26530197,"diff_hunk":"@@ -322,14 +322,18 @@ toBasic <- list(\n     })\n     group2NA(g, \"path\")\n   },\n-  polygon=function(g){\n-    if(is.null(g$params$fill)){\n-      g\n-    }else if(is.na(g$params$fill)){\n-      group2NA(g, \"path\")\n-    }else{\n-      g\n-    }","path":"R/trace_generation.R","position":11,"original_position":11,"commit_id":"8b03e902806699a74bf956f4f2a7351f3102c43c","original_commit_id":"8b03e902806699a74bf956f4f2a7351f3102c43c","user":{"login":"tdhock","id":932850,"avatar_url":"https://avatars.githubusercontent.com/u/932850?v=3","gravatar_id":"","url":"https://api.github.com/users/tdhock","html_url":"https://github.com/tdhock","followers_url":"https://api.github.com/users/tdhock/followers","following_url":"https://api.github.com/users/tdhock/following{/other_user}","gists_url":"https://api.github.com/users/tdhock/gists{/gist_id}","starred_url":"https://api.github.com/users/tdhock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdhock/subscriptions","organizations_url":"https://api.github.com/users/tdhock/orgs","repos_url":"https://api.github.com/users/tdhock/repos","events_url":"https://api.github.com/users/tdhock/events{/privacy}","received_events_url":"https://api.github.com/users/tdhock/received_events","type":"User","site_admin":false},"body":"geom_polygons are now treated as a basic type so this code is no longer necessary","created_at":"2015-03-16T21:37:16Z","updated_at":"2015-03-16T21:37:16Z","html_url":"https://github.com/ropensci/plotly/pull/178#discussion_r26530197","pull_request_url":"https://api.github.com/repos/ropensci/plotly/pulls/178","_links":{"self":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/comments/26530197"},"html":{"href":"https://github.com/ropensci/plotly/pull/178#discussion_r26530197"},"pull_request":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/178"}}},"pull_request":{"url":"https://api.github.com/repos/ropensci/plotly/pulls/178","id":30693800,"html_url":"https://github.com/ropensci/plotly/pull/178","diff_url":"https://github.com/ropensci/plotly/pull/178.diff","patch_url":"https://github.com/ropensci/plotly/pull/178.patch","issue_url":"https://api.github.com/repos/ropensci/plotly/issues/178","number":178,"state":"open","locked":false,"title":"Toby rect","user":{"login":"tdhock","id":932850,"avatar_url":"https://avatars.githubusercontent.com/u/932850?v=3","gravatar_id":"","url":"https://api.github.com/users/tdhock","html_url":"https://github.com/tdhock","followers_url":"https://api.github.com/users/tdhock/followers","following_url":"https://api.github.com/users/tdhock/following{/other_user}","gists_url":"https://api.github.com/users/tdhock/gists{/gist_id}","starred_url":"https://api.github.com/users/tdhock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdhock/subscriptions","organizations_url":"https://api.github.com/users/tdhock/orgs","repos_url":"https://api.github.com/users/tdhock/repos","events_url":"https://api.github.com/users/tdhock/events{/privacy}","received_events_url":"https://api.github.com/users/tdhock/received_events","type":"User","site_admin":false},"body":"I implemented geom_rect conversion by treating it as a basic version of a polygon, which is transformed into a trace with mode=\"lines\", type=\"scatter\", fill=\"tozerox\"","created_at":"2015-03-07T01:19:00Z","updated_at":"2015-03-16T21:37:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c74af25047c3b5988e8852d8be0fcdeff9f5440","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ropensci/plotly/pulls/178/commits","review_comments_url":"https://api.github.com/repos/ropensci/plotly/pulls/178/comments","review_comment_url":"https://api.github.com/repos/ropensci/plotly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ropensci/plotly/issues/178/comments","statuses_url":"https://api.github.com/repos/ropensci/plotly/statuses/8b03e902806699a74bf956f4f2a7351f3102c43c","head":{"label":"ropensci:toby-rect","ref":"toby-rect","sha":"8b03e902806699a74bf956f4f2a7351f3102c43c","user":{"login":"ropensci","id":1200269,"avatar_url":"https://avatars.githubusercontent.com/u/1200269?v=3","gravatar_id":"","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"repo":{"id":14579179,"name":"plotly","full_name":"ropensci/plotly","owner":{"login":"ropensci","id":1200269,"avatar_url":"https://avatars.githubusercontent.com/u/1200269?v=3","gravatar_id":"","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ropensci/plotly","description":"Create beautiful, interactive, online Plotly graphs with R and ggplot2","fork":false,"url":"https://api.github.com/repos/ropensci/plotly","forks_url":"https://api.github.com/repos/ropensci/plotly/forks","keys_url":"https://api.github.com/repos/ropensci/plotly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ropensci/plotly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ropensci/plotly/teams","hooks_url":"https://api.github.com/repos/ropensci/plotly/hooks","issue_events_url":"https://api.github.com/repos/ropensci/plotly/issues/events{/number}","events_url":"https://api.github.com/repos/ropensci/plotly/events","assignees_url":"https://api.github.com/repos/ropensci/plotly/assignees{/user}","branches_url":"https://api.github.com/repos/ropensci/plotly/branches{/branch}","tags_url":"https://api.github.com/repos/ropensci/plotly/tags","blobs_url":"https://api.github.com/repos/ropensci/plotly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ropensci/plotly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ropensci/plotly/git/refs{/sha}","trees_url":"https://api.github.com/repos/ropensci/plotly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ropensci/plotly/statuses/{sha}","languages_url":"https://api.github.com/repos/ropensci/plotly/languages","stargazers_url":"https://api.github.com/repos/ropensci/plotly/stargazers","contributors_url":"https://api.github.com/repos/ropensci/plotly/contributors","subscribers_url":"https://api.github.com/repos/ropensci/plotly/subscribers","subscription_url":"https://api.github.com/repos/ropensci/plotly/subscription","commits_url":"https://api.github.com/repos/ropensci/plotly/commits{/sha}","git_commits_url":"https://api.github.com/repos/ropensci/plotly/git/commits{/sha}","comments_url":"https://api.github.com/repos/ropensci/plotly/comments{/number}","issue_comment_url":"https://api.github.com/repos/ropensci/plotly/issues/comments{/number}","contents_url":"https://api.github.com/repos/ropensci/plotly/contents/{+path}","compare_url":"https://api.github.com/repos/ropensci/plotly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ropensci/plotly/merges","archive_url":"https://api.github.com/repos/ropensci/plotly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ropensci/plotly/downloads","issues_url":"https://api.github.com/repos/ropensci/plotly/issues{/number}","pulls_url":"https://api.github.com/repos/ropensci/plotly/pulls{/number}","milestones_url":"https://api.github.com/repos/ropensci/plotly/milestones{/number}","notifications_url":"https://api.github.com/repos/ropensci/plotly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ropensci/plotly/labels{/name}","releases_url":"https://api.github.com/repos/ropensci/plotly/releases{/id}","created_at":"2013-11-21T05:56:51Z","updated_at":"2015-03-16T18:03:09Z","pushed_at":"2015-03-16T21:28:18Z","git_url":"git://github.com/ropensci/plotly.git","ssh_url":"git@github.com:ropensci/plotly.git","clone_url":"https://github.com/ropensci/plotly.git","svn_url":"https://github.com/ropensci/plotly","homepage":"https://plot.ly/ggplot2/","size":40598,"stargazers_count":137,"watchers_count":137,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":35,"forks":38,"open_issues":35,"watchers":137,"default_branch":"master"}},"base":{"label":"ropensci:master","ref":"master","sha":"09f9dac265ca6013b1498b6239fa9c70564455ae","user":{"login":"ropensci","id":1200269,"avatar_url":"https://avatars.githubusercontent.com/u/1200269?v=3","gravatar_id":"","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"repo":{"id":14579179,"name":"plotly","full_name":"ropensci/plotly","owner":{"login":"ropensci","id":1200269,"avatar_url":"https://avatars.githubusercontent.com/u/1200269?v=3","gravatar_id":"","url":"https://api.github.com/users/ropensci","html_url":"https://github.com/ropensci","followers_url":"https://api.github.com/users/ropensci/followers","following_url":"https://api.github.com/users/ropensci/following{/other_user}","gists_url":"https://api.github.com/users/ropensci/gists{/gist_id}","starred_url":"https://api.github.com/users/ropensci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ropensci/subscriptions","organizations_url":"https://api.github.com/users/ropensci/orgs","repos_url":"https://api.github.com/users/ropensci/repos","events_url":"https://api.github.com/users/ropensci/events{/privacy}","received_events_url":"https://api.github.com/users/ropensci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ropensci/plotly","description":"Create beautiful, interactive, online Plotly graphs with R and ggplot2","fork":false,"url":"https://api.github.com/repos/ropensci/plotly","forks_url":"https://api.github.com/repos/ropensci/plotly/forks","keys_url":"https://api.github.com/repos/ropensci/plotly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ropensci/plotly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ropensci/plotly/teams","hooks_url":"https://api.github.com/repos/ropensci/plotly/hooks","issue_events_url":"https://api.github.com/repos/ropensci/plotly/issues/events{/number}","events_url":"https://api.github.com/repos/ropensci/plotly/events","assignees_url":"https://api.github.com/repos/ropensci/plotly/assignees{/user}","branches_url":"https://api.github.com/repos/ropensci/plotly/branches{/branch}","tags_url":"https://api.github.com/repos/ropensci/plotly/tags","blobs_url":"https://api.github.com/repos/ropensci/plotly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ropensci/plotly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ropensci/plotly/git/refs{/sha}","trees_url":"https://api.github.com/repos/ropensci/plotly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ropensci/plotly/statuses/{sha}","languages_url":"https://api.github.com/repos/ropensci/plotly/languages","stargazers_url":"https://api.github.com/repos/ropensci/plotly/stargazers","contributors_url":"https://api.github.com/repos/ropensci/plotly/contributors","subscribers_url":"https://api.github.com/repos/ropensci/plotly/subscribers","subscription_url":"https://api.github.com/repos/ropensci/plotly/subscription","commits_url":"https://api.github.com/repos/ropensci/plotly/commits{/sha}","git_commits_url":"https://api.github.com/repos/ropensci/plotly/git/commits{/sha}","comments_url":"https://api.github.com/repos/ropensci/plotly/comments{/number}","issue_comment_url":"https://api.github.com/repos/ropensci/plotly/issues/comments{/number}","contents_url":"https://api.github.com/repos/ropensci/plotly/contents/{+path}","compare_url":"https://api.github.com/repos/ropensci/plotly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ropensci/plotly/merges","archive_url":"https://api.github.com/repos/ropensci/plotly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ropensci/plotly/downloads","issues_url":"https://api.github.com/repos/ropensci/plotly/issues{/number}","pulls_url":"https://api.github.com/repos/ropensci/plotly/pulls{/number}","milestones_url":"https://api.github.com/repos/ropensci/plotly/milestones{/number}","notifications_url":"https://api.github.com/repos/ropensci/plotly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ropensci/plotly/labels{/name}","releases_url":"https://api.github.com/repos/ropensci/plotly/releases{/id}","created_at":"2013-11-21T05:56:51Z","updated_at":"2015-03-16T18:03:09Z","pushed_at":"2015-03-16T21:28:18Z","git_url":"git://github.com/ropensci/plotly.git","ssh_url":"git@github.com:ropensci/plotly.git","clone_url":"https://github.com/ropensci/plotly.git","svn_url":"https://github.com/ropensci/plotly","homepage":"https://plot.ly/ggplot2/","size":40598,"stargazers_count":137,"watchers_count":137,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":35,"forks":38,"open_issues":35,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/178"},"html":{"href":"https://github.com/ropensci/plotly/pull/178"},"issue":{"href":"https://api.github.com/repos/ropensci/plotly/issues/178"},"comments":{"href":"https://api.github.com/repos/ropensci/plotly/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ropensci/plotly/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/ropensci/plotly/statuses/8b03e902806699a74bf956f4f2a7351f3102c43c"}}}}