{"action":"created","issue":{"url":"https://api.github.com/repos/serbanghita/Mobile-Detect/issues/483","labels_url":"https://api.github.com/repos/serbanghita/Mobile-Detect/issues/483/labels{/name}","comments_url":"https://api.github.com/repos/serbanghita/Mobile-Detect/issues/483/comments","events_url":"https://api.github.com/repos/serbanghita/Mobile-Detect/issues/483/events","html_url":"https://github.com/serbanghita/Mobile-Detect/pull/483","id":118884524,"number":483,"title":"Combining the regexes for performance","user":{"login":"frickelbruder","id":1835775,"avatar_url":"https://avatars.githubusercontent.com/u/1835775?v=3","gravatar_id":"","url":"https://api.github.com/users/frickelbruder","html_url":"https://github.com/frickelbruder","followers_url":"https://api.github.com/users/frickelbruder/followers","following_url":"https://api.github.com/users/frickelbruder/following{/other_user}","gists_url":"https://api.github.com/users/frickelbruder/gists{/gist_id}","starred_url":"https://api.github.com/users/frickelbruder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frickelbruder/subscriptions","organizations_url":"https://api.github.com/users/frickelbruder/orgs","repos_url":"https://api.github.com/users/frickelbruder/repos","events_url":"https://api.github.com/users/frickelbruder/events{/privacy}","received_events_url":"https://api.github.com/users/frickelbruder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-25T17:18:41Z","updated_at":"2015-11-25T17:35:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/serbanghita/Mobile-Detect/pulls/483","html_url":"https://github.com/serbanghita/Mobile-Detect/pull/483","diff_url":"https://github.com/serbanghita/Mobile-Detect/pull/483.diff","patch_url":"https://github.com/serbanghita/Mobile-Detect/pull/483.patch"},"body":"Hi there,\r\n\r\nI achieved a nive performance gain of somewhat between 2 and 5 seconds when executing phpunit. I just combined the regexes to one big regex. This means, there is also at least a small performance gain on websites.\r\n\r\nRegards,\r\nfrickelbruder"},"comment":{"url":"https://api.github.com/repos/serbanghita/Mobile-Detect/issues/comments/159683065","html_url":"https://github.com/serbanghita/Mobile-Detect/pull/483#issuecomment-159683065","issue_url":"https://api.github.com/repos/serbanghita/Mobile-Detect/issues/483","id":159683065,"user":{"login":"hgoebl","id":1008705,"avatar_url":"https://avatars.githubusercontent.com/u/1008705?v=3","gravatar_id":"","url":"https://api.github.com/users/hgoebl","html_url":"https://github.com/hgoebl","followers_url":"https://api.github.com/users/hgoebl/followers","following_url":"https://api.github.com/users/hgoebl/following{/other_user}","gists_url":"https://api.github.com/users/hgoebl/gists{/gist_id}","starred_url":"https://api.github.com/users/hgoebl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgoebl/subscriptions","organizations_url":"https://api.github.com/users/hgoebl/orgs","repos_url":"https://api.github.com/users/hgoebl/repos","events_url":"https://api.github.com/users/hgoebl/events{/privacy}","received_events_url":"https://api.github.com/users/hgoebl/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T17:35:25Z","updated_at":"2015-11-25T17:35:25Z","body":"But then we'd loose a detection of different vendors, right? Only mobile or not mobile."}}