{"action":"created","comment":{"url":"https://api.github.com/repos/01org/libyami/pulls/comments/24650854","id":24650854,"diff_hunk":"@@ -206,10 +206,18 @@ bool DecodeOutputFileDump::config(const char* dir, const char* source, const cha\n         if (s)\n             baseFileName = s+1;\n         assert(dir);\n-        m_name<<dir<<\"/\"<<baseFileName;\n-        m_appendSize = true;\n+        struct stat buf;\n+        int r = stat(dir, &buf);\n+        if (r == 0 && buf.st_mode & S_IFDIR){","path":"tests/decodeoutput.cpp","position":31,"original_position":31,"commit_id":"3cdc54b899d4fbfa5c7ee2f29364928c657c0f31","original_commit_id":"3cdc54b899d4fbfa5c7ee2f29364928c657c0f31","user":{"login":"xuguangxin","id":6667546,"avatar_url":"https://avatars.githubusercontent.com/u/6667546?v=3","gravatar_id":"","url":"https://api.github.com/users/xuguangxin","html_url":"https://github.com/xuguangxin","followers_url":"https://api.github.com/users/xuguangxin/followers","following_url":"https://api.github.com/users/xuguangxin/following{/other_user}","gists_url":"https://api.github.com/users/xuguangxin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuguangxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuguangxin/subscriptions","organizations_url":"https://api.github.com/users/xuguangxin/orgs","repos_url":"https://api.github.com/users/xuguangxin/repos","events_url":"https://api.github.com/users/xuguangxin/events{/privacy}","received_events_url":"https://api.github.com/users/xuguangxin/received_events","type":"User","site_admin":false},"body":"why we need this judgement? source file's parent must be a directory, right?","created_at":"2015-02-13T08:46:36Z","updated_at":"2015-02-13T08:46:36Z","html_url":"https://github.com/01org/libyami/pull/185#discussion_r24650854","pull_request_url":"https://api.github.com/repos/01org/libyami/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments/24650854"},"html":{"href":"https://github.com/01org/libyami/pull/185#discussion_r24650854"},"pull_request":{"href":"https://api.github.com/repos/01org/libyami/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/01org/libyami/pulls/185","id":29247840,"html_url":"https://github.com/01org/libyami/pull/185","diff_url":"https://github.com/01org/libyami/pull/185.diff","patch_url":"https://github.com/01org/libyami/pull/185.patch","issue_url":"https://api.github.com/repos/01org/libyami/issues/185","number":185,"state":"open","locked":false,"title":"fix decodeoutput.cpp for the outputfile can output to file and directory","user":{"login":"luokunrock","id":10443414,"avatar_url":"https://avatars.githubusercontent.com/u/10443414?v=3","gravatar_id":"","url":"https://api.github.com/users/luokunrock","html_url":"https://github.com/luokunrock","followers_url":"https://api.github.com/users/luokunrock/followers","following_url":"https://api.github.com/users/luokunrock/following{/other_user}","gists_url":"https://api.github.com/users/luokunrock/gists{/gist_id}","starred_url":"https://api.github.com/users/luokunrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luokunrock/subscriptions","organizations_url":"https://api.github.com/users/luokunrock/orgs","repos_url":"https://api.github.com/users/luokunrock/repos","events_url":"https://api.github.com/users/luokunrock/events{/privacy}","received_events_url":"https://api.github.com/users/luokunrock/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-13T08:36:12Z","updated_at":"2015-02-13T08:46:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66a1d1c8bdb77e44df64e756f5dfa961368ee27f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/01org/libyami/pulls/185/commits","review_comments_url":"https://api.github.com/repos/01org/libyami/pulls/185/comments","review_comment_url":"https://api.github.com/repos/01org/libyami/pulls/comments/{number}","comments_url":"https://api.github.com/repos/01org/libyami/issues/185/comments","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/3cdc54b899d4fbfa5c7ee2f29364928c657c0f31","head":{"label":"luokunrock:master","ref":"master","sha":"3cdc54b899d4fbfa5c7ee2f29364928c657c0f31","user":{"login":"luokunrock","id":10443414,"avatar_url":"https://avatars.githubusercontent.com/u/10443414?v=3","gravatar_id":"","url":"https://api.github.com/users/luokunrock","html_url":"https://github.com/luokunrock","followers_url":"https://api.github.com/users/luokunrock/followers","following_url":"https://api.github.com/users/luokunrock/following{/other_user}","gists_url":"https://api.github.com/users/luokunrock/gists{/gist_id}","starred_url":"https://api.github.com/users/luokunrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luokunrock/subscriptions","organizations_url":"https://api.github.com/users/luokunrock/orgs","repos_url":"https://api.github.com/users/luokunrock/repos","events_url":"https://api.github.com/users/luokunrock/events{/privacy}","received_events_url":"https://api.github.com/users/luokunrock/received_events","type":"User","site_admin":false},"repo":{"id":28944275,"name":"libyami","full_name":"luokunrock/libyami","owner":{"login":"luokunrock","id":10443414,"avatar_url":"https://avatars.githubusercontent.com/u/10443414?v=3","gravatar_id":"","url":"https://api.github.com/users/luokunrock","html_url":"https://github.com/luokunrock","followers_url":"https://api.github.com/users/luokunrock/followers","following_url":"https://api.github.com/users/luokunrock/following{/other_user}","gists_url":"https://api.github.com/users/luokunrock/gists{/gist_id}","starred_url":"https://api.github.com/users/luokunrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luokunrock/subscriptions","organizations_url":"https://api.github.com/users/luokunrock/orgs","repos_url":"https://api.github.com/users/luokunrock/repos","events_url":"https://api.github.com/users/luokunrock/events{/privacy}","received_events_url":"https://api.github.com/users/luokunrock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luokunrock/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":true,"url":"https://api.github.com/repos/luokunrock/libyami","forks_url":"https://api.github.com/repos/luokunrock/libyami/forks","keys_url":"https://api.github.com/repos/luokunrock/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luokunrock/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luokunrock/libyami/teams","hooks_url":"https://api.github.com/repos/luokunrock/libyami/hooks","issue_events_url":"https://api.github.com/repos/luokunrock/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/luokunrock/libyami/events","assignees_url":"https://api.github.com/repos/luokunrock/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/luokunrock/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/luokunrock/libyami/tags","blobs_url":"https://api.github.com/repos/luokunrock/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luokunrock/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luokunrock/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/luokunrock/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luokunrock/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/luokunrock/libyami/languages","stargazers_url":"https://api.github.com/repos/luokunrock/libyami/stargazers","contributors_url":"https://api.github.com/repos/luokunrock/libyami/contributors","subscribers_url":"https://api.github.com/repos/luokunrock/libyami/subscribers","subscription_url":"https://api.github.com/repos/luokunrock/libyami/subscription","commits_url":"https://api.github.com/repos/luokunrock/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/luokunrock/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/luokunrock/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/luokunrock/libyami/issues/comments/{number}","contents_url":"https://api.github.com/repos/luokunrock/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/luokunrock/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luokunrock/libyami/merges","archive_url":"https://api.github.com/repos/luokunrock/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luokunrock/libyami/downloads","issues_url":"https://api.github.com/repos/luokunrock/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/luokunrock/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/luokunrock/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/luokunrock/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luokunrock/libyami/labels{/name}","releases_url":"https://api.github.com/repos/luokunrock/libyami/releases{/id}","created_at":"2015-01-08T02:11:09Z","updated_at":"2015-02-13T08:35:05Z","pushed_at":"2015-02-13T08:35:04Z","git_url":"git://github.com/luokunrock/libyami.git","ssh_url":"git@github.com:luokunrock/libyami.git","clone_url":"https://github.com/luokunrock/libyami.git","svn_url":"https://github.com/luokunrock/libyami","homepage":null,"size":1570,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"637553f57d42120c60f3992585c720736e3c0ef5","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":18320220,"name":"libyami","full_name":"01org/libyami","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":false,"url":"https://api.github.com/repos/01org/libyami","forks_url":"https://api.github.com/repos/01org/libyami/forks","keys_url":"https://api.github.com/repos/01org/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/libyami/teams","hooks_url":"https://api.github.com/repos/01org/libyami/hooks","issue_events_url":"https://api.github.com/repos/01org/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/01org/libyami/events","assignees_url":"https://api.github.com/repos/01org/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/01org/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/01org/libyami/tags","blobs_url":"https://api.github.com/repos/01org/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/libyami/languages","stargazers_url":"https://api.github.com/repos/01org/libyami/stargazers","contributors_url":"https://api.github.com/repos/01org/libyami/contributors","subscribers_url":"https://api.github.com/repos/01org/libyami/subscribers","subscription_url":"https://api.github.com/repos/01org/libyami/subscription","commits_url":"https://api.github.com/repos/01org/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/libyami/issues/comments/{number}","contents_url":"https://api.github.com/repos/01org/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/01org/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/libyami/merges","archive_url":"https://api.github.com/repos/01org/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/libyami/downloads","issues_url":"https://api.github.com/repos/01org/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/01org/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/libyami/labels{/name}","releases_url":"https://api.github.com/repos/01org/libyami/releases{/id}","created_at":"2014-04-01T06:44:19Z","updated_at":"2015-02-13T02:58:32Z","pushed_at":"2015-02-13T02:58:32Z","git_url":"git://github.com/01org/libyami.git","ssh_url":"git@github.com:01org/libyami.git","clone_url":"https://github.com/01org/libyami.git","svn_url":"https://github.com/01org/libyami","homepage":null,"size":2996,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":17,"forks":18,"open_issues":17,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/185"},"html":{"href":"https://github.com/01org/libyami/pull/185"},"issue":{"href":"https://api.github.com/repos/01org/libyami/issues/185"},"comments":{"href":"https://api.github.com/repos/01org/libyami/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/libyami/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/01org/libyami/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/01org/libyami/statuses/3cdc54b899d4fbfa5c7ee2f29364928c657c0f31"}}}}