{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/44959211","id":44959211,"diff_hunk":"@@ -80,10 +90,28 @@ public ClientBase(InetSocketAddress address, TachyonConf tachyonConf, String mod\n   protected abstract String getServiceName();\n \n   /**\n+   * Checks that the service version is compatible with the client.\n+   */\n+  protected void checkVersion(TachyonService.Client client, long version) throws IOException {\n+    if (mServiceVersion == Constants.UNKNOWN_SERVICE_VERSION) {\n+      try {\n+        mServiceVersion = client.getServiceVersion();\n+      } catch (TException e) {\n+        throw new IOException(e.getMessage());\n+      }\n+      if (mServiceVersion != Constants.BLOCK_MASTER_SERVICE_VERSION) {","path":"common/src/main/java/tachyon/ClientBase.java","position":57,"original_position":57,"commit_id":"18fbcaea7553861226143368fe5ed83a85a00f16","original_commit_id":"18fbcaea7553861226143368fe5ed83a85a00f16","user":{"login":"jsimsa","id":1072079,"avatar_url":"https://avatars.githubusercontent.com/u/1072079?v=3","gravatar_id":"","url":"https://api.github.com/users/jsimsa","html_url":"https://github.com/jsimsa","followers_url":"https://api.github.com/users/jsimsa/followers","following_url":"https://api.github.com/users/jsimsa/following{/other_user}","gists_url":"https://api.github.com/users/jsimsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsimsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsimsa/subscriptions","organizations_url":"https://api.github.com/users/jsimsa/orgs","repos_url":"https://api.github.com/users/jsimsa/repos","events_url":"https://api.github.com/users/jsimsa/events{/privacy}","received_events_url":"https://api.github.com/users/jsimsa/received_events","type":"User","site_admin":false},"body":"=_= ... done","created_at":"2015-11-16T18:10:23Z","updated_at":"2015-11-16T18:10:23Z","html_url":"https://github.com/amplab/tachyon/pull/2045#discussion_r44959211","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/2045","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/44959211"},"html":{"href":"https://github.com/amplab/tachyon/pull/2045#discussion_r44959211"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2045"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/2045","id":50584169,"html_url":"https://github.com/amplab/tachyon/pull/2045","diff_url":"https://github.com/amplab/tachyon/pull/2045.diff","patch_url":"https://github.com/amplab/tachyon/pull/2045.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/2045","number":2045,"state":"open","locked":false,"title":"[TACHYON-1273] Detect incompatible Thrift RPC versions","user":{"login":"jsimsa","id":1072079,"avatar_url":"https://avatars.githubusercontent.com/u/1072079?v=3","gravatar_id":"","url":"https://api.github.com/users/jsimsa","html_url":"https://github.com/jsimsa","followers_url":"https://api.github.com/users/jsimsa/followers","following_url":"https://api.github.com/users/jsimsa/following{/other_user}","gists_url":"https://api.github.com/users/jsimsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsimsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsimsa/subscriptions","organizations_url":"https://api.github.com/users/jsimsa/orgs","repos_url":"https://api.github.com/users/jsimsa/repos","events_url":"https://api.github.com/users/jsimsa/events{/privacy}","received_events_url":"https://api.github.com/users/jsimsa/received_events","type":"User","site_admin":false},"body":"This PR addresses https://tachyon.atlassian.net/browse/TACHYON-1273","created_at":"2015-11-12T23:29:15Z","updated_at":"2015-11-16T18:10:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46594b3b3af3a47f435d099a119f21c2ccec9f1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/2045/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/2045/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/2045/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/18fbcaea7553861226143368fe5ed83a85a00f16","head":{"label":"jsimsa:version","ref":"version","sha":"18fbcaea7553861226143368fe5ed83a85a00f16","user":{"login":"jsimsa","id":1072079,"avatar_url":"https://avatars.githubusercontent.com/u/1072079?v=3","gravatar_id":"","url":"https://api.github.com/users/jsimsa","html_url":"https://github.com/jsimsa","followers_url":"https://api.github.com/users/jsimsa/followers","following_url":"https://api.github.com/users/jsimsa/following{/other_user}","gists_url":"https://api.github.com/users/jsimsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsimsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsimsa/subscriptions","organizations_url":"https://api.github.com/users/jsimsa/orgs","repos_url":"https://api.github.com/users/jsimsa/repos","events_url":"https://api.github.com/users/jsimsa/events{/privacy}","received_events_url":"https://api.github.com/users/jsimsa/received_events","type":"User","site_admin":false},"repo":{"id":41324456,"name":"tachyon","full_name":"jsimsa/tachyon","owner":{"login":"jsimsa","id":1072079,"avatar_url":"https://avatars.githubusercontent.com/u/1072079?v=3","gravatar_id":"","url":"https://api.github.com/users/jsimsa","html_url":"https://github.com/jsimsa","followers_url":"https://api.github.com/users/jsimsa/followers","following_url":"https://api.github.com/users/jsimsa/following{/other_user}","gists_url":"https://api.github.com/users/jsimsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsimsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsimsa/subscriptions","organizations_url":"https://api.github.com/users/jsimsa/orgs","repos_url":"https://api.github.com/users/jsimsa/repos","events_url":"https://api.github.com/users/jsimsa/events{/privacy}","received_events_url":"https://api.github.com/users/jsimsa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsimsa/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/jsimsa/tachyon","forks_url":"https://api.github.com/repos/jsimsa/tachyon/forks","keys_url":"https://api.github.com/repos/jsimsa/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsimsa/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsimsa/tachyon/teams","hooks_url":"https://api.github.com/repos/jsimsa/tachyon/hooks","issue_events_url":"https://api.github.com/repos/jsimsa/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/jsimsa/tachyon/events","assignees_url":"https://api.github.com/repos/jsimsa/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/jsimsa/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/jsimsa/tachyon/tags","blobs_url":"https://api.github.com/repos/jsimsa/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsimsa/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsimsa/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsimsa/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsimsa/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/jsimsa/tachyon/languages","stargazers_url":"https://api.github.com/repos/jsimsa/tachyon/stargazers","contributors_url":"https://api.github.com/repos/jsimsa/tachyon/contributors","subscribers_url":"https://api.github.com/repos/jsimsa/tachyon/subscribers","subscription_url":"https://api.github.com/repos/jsimsa/tachyon/subscription","commits_url":"https://api.github.com/repos/jsimsa/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsimsa/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsimsa/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsimsa/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsimsa/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/jsimsa/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsimsa/tachyon/merges","archive_url":"https://api.github.com/repos/jsimsa/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsimsa/tachyon/downloads","issues_url":"https://api.github.com/repos/jsimsa/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/jsimsa/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/jsimsa/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/jsimsa/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsimsa/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/jsimsa/tachyon/releases{/id}","created_at":"2015-08-24T20:06:14Z","updated_at":"2015-08-24T20:06:16Z","pushed_at":"2015-11-16T17:23:44Z","git_url":"git://github.com/jsimsa/tachyon.git","ssh_url":"git@github.com:jsimsa/tachyon.git","clone_url":"https://github.com/jsimsa/tachyon.git","svn_url":"https://github.com/jsimsa/tachyon","homepage":"http://tachyon-project.org","size":29962,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"26b35c1129364d93c4c99d97c83864b5f7b5eac6","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":"Memory Centric Reliable Distributed Storage","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-11-16T06:40:17Z","pushed_at":"2015-11-16T17:43:29Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":60711,"stargazers_count":1737,"watchers_count":1737,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":685,"mirror_url":null,"open_issues_count":33,"forks":685,"open_issues":33,"watchers":1737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2045"},"html":{"href":"https://github.com/amplab/tachyon/pull/2045"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2045"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2045/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2045/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2045/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/18fbcaea7553861226143368fe5ed83a85a00f16"}}}}