{"action":"created","comment":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/35611112","id":35611112,"diff_hunk":"@@ -66,11 +66,11 @@ void TestActionTimeline::onEnter()\n {\n     ActionTimelineBaseTest::onEnter();\n \n-    Node* node = CSLoader::createNode(\"ActionTimeline/DemoPlayer.csb\");\n-    ActionTimeline* action = CSLoader::createTimeline(\"ActionTimeline/DemoPlayer.csb\");\n+    Data data = FileUtils::getInstance()->getDataFromFile(\"ActionTimeline/DemoPlayer.csb\");\n+    Node* node = CSLoader::createNodeWithDataBuffer(data);\n+    ActionTimeline* action = CSLoader::createTimelineWithDataBuffer(data, \"ActionTimeline/DemoPlayer.csb\");","path":"tests/cpp-tests/Classes/ExtensionsTest/CocoStudioActionTimelineTest/ActionTimelineTestScene.cpp","position":8,"original_position":8,"commit_id":"09d9fcf4d6bc25af39c70fe2bd9553766805826f","original_commit_id":"09d9fcf4d6bc25af39c70fe2bd9553766805826f","user":{"login":"fusijie","id":5085300,"avatar_url":"https://avatars.githubusercontent.com/u/5085300?v=3","gravatar_id":"","url":"https://api.github.com/users/fusijie","html_url":"https://github.com/fusijie","followers_url":"https://api.github.com/users/fusijie/followers","following_url":"https://api.github.com/users/fusijie/following{/other_user}","gists_url":"https://api.github.com/users/fusijie/gists{/gist_id}","starred_url":"https://api.github.com/users/fusijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusijie/subscriptions","organizations_url":"https://api.github.com/users/fusijie/orgs","repos_url":"https://api.github.com/users/fusijie/repos","events_url":"https://api.github.com/users/fusijie/events{/privacy}","received_events_url":"https://api.github.com/users/fusijie/received_events","type":"User","site_admin":false},"body":"The better way to create node and timeline is:  \r\n```cpp\r\nData data = FileUtils::getInstance()->getDataFromFile(\"ActionTimeline/DemoPlayer.csb\");\r\nNode* node = CSLoader::createNode(data);//overload.\r\nActionTimeline* action = CSLoader::createTimeline(data);//overload, and remove filename string.\r\n```\r\nSo some methods need to split.","created_at":"2015-07-28T03:10:16Z","updated_at":"2015-07-28T03:10:16Z","html_url":"https://github.com/cocos2d/cocos2d-x/pull/13032#discussion_r35611112","pull_request_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13032","_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/35611112"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/13032#discussion_r35611112"},"pull_request":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13032"}}},"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13032","id":40868716,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/13032","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/13032.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/13032.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/13032","number":13032,"state":"open","locked":false,"title":"Fix issue https://github.com/cocos2d/cocos2d-x/issues/12968","user":{"login":"xiaofeng11","id":11676879,"avatar_url":"https://avatars.githubusercontent.com/u/11676879?v=3","gravatar_id":"","url":"https://api.github.com/users/xiaofeng11","html_url":"https://github.com/xiaofeng11","followers_url":"https://api.github.com/users/xiaofeng11/followers","following_url":"https://api.github.com/users/xiaofeng11/following{/other_user}","gists_url":"https://api.github.com/users/xiaofeng11/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaofeng11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaofeng11/subscriptions","organizations_url":"https://api.github.com/users/xiaofeng11/orgs","repos_url":"https://api.github.com/users/xiaofeng11/repos","events_url":"https://api.github.com/users/xiaofeng11/events{/privacy}","received_events_url":"https://api.github.com/users/xiaofeng11/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-27T03:57:53Z","updated_at":"2015-07-28T03:10:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d04aec5709c70c24d29ce10e433a9248bac7f4a1","assignee":{"login":"fusijie","id":5085300,"avatar_url":"https://avatars.githubusercontent.com/u/5085300?v=3","gravatar_id":"","url":"https://api.github.com/users/fusijie","html_url":"https://github.com/fusijie","followers_url":"https://api.github.com/users/fusijie/followers","following_url":"https://api.github.com/users/fusijie/following{/other_user}","gists_url":"https://api.github.com/users/fusijie/gists{/gist_id}","starred_url":"https://api.github.com/users/fusijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusijie/subscriptions","organizations_url":"https://api.github.com/users/fusijie/orgs","repos_url":"https://api.github.com/users/fusijie/repos","events_url":"https://api.github.com/users/fusijie/events{/privacy}","received_events_url":"https://api.github.com/users/fusijie/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13032/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13032/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/13032/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/09d9fcf4d6bc25af39c70fe2bd9553766805826f","head":{"label":"xiaofeng11:v3","ref":"v3","sha":"09d9fcf4d6bc25af39c70fe2bd9553766805826f","user":{"login":"xiaofeng11","id":11676879,"avatar_url":"https://avatars.githubusercontent.com/u/11676879?v=3","gravatar_id":"","url":"https://api.github.com/users/xiaofeng11","html_url":"https://github.com/xiaofeng11","followers_url":"https://api.github.com/users/xiaofeng11/followers","following_url":"https://api.github.com/users/xiaofeng11/following{/other_user}","gists_url":"https://api.github.com/users/xiaofeng11/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaofeng11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaofeng11/subscriptions","organizations_url":"https://api.github.com/users/xiaofeng11/orgs","repos_url":"https://api.github.com/users/xiaofeng11/repos","events_url":"https://api.github.com/users/xiaofeng11/events{/privacy}","received_events_url":"https://api.github.com/users/xiaofeng11/received_events","type":"User","site_admin":false},"repo":{"id":33107666,"name":"cocos2d-x","full_name":"xiaofeng11/cocos2d-x","owner":{"login":"xiaofeng11","id":11676879,"avatar_url":"https://avatars.githubusercontent.com/u/11676879?v=3","gravatar_id":"","url":"https://api.github.com/users/xiaofeng11","html_url":"https://github.com/xiaofeng11","followers_url":"https://api.github.com/users/xiaofeng11/followers","following_url":"https://api.github.com/users/xiaofeng11/following{/other_user}","gists_url":"https://api.github.com/users/xiaofeng11/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaofeng11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaofeng11/subscriptions","organizations_url":"https://api.github.com/users/xiaofeng11/orgs","repos_url":"https://api.github.com/users/xiaofeng11/repos","events_url":"https://api.github.com/users/xiaofeng11/events{/privacy}","received_events_url":"https://api.github.com/users/xiaofeng11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiaofeng11/cocos2d-x","description":"cocos2d-x for C++","fork":true,"url":"https://api.github.com/repos/xiaofeng11/cocos2d-x","forks_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/forks","keys_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/events","assignees_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/merges","archive_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/xiaofeng11/cocos2d-x/releases{/id}","created_at":"2015-03-30T06:50:57Z","updated_at":"2015-04-23T08:51:50Z","pushed_at":"2015-07-27T13:25:04Z","git_url":"git://github.com/xiaofeng11/cocos2d-x.git","ssh_url":"git@github.com:xiaofeng11/cocos2d-x.git","clone_url":"https://github.com/xiaofeng11/cocos2d-x.git","svn_url":"https://github.com/xiaofeng11/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":256065,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"v3.7-release"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"bd0bdae5309d0034779ccd6818a1a1d3e688cb1d","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","created_at":"2010-11-18T23:17:00Z","updated_at":"2015-07-27T11:50:52Z","pushed_at":"2015-07-28T03:10:05Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1517627,"stargazers_count":6304,"watchers_count":6304,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4506,"mirror_url":null,"open_issues_count":757,"forks":4506,"open_issues":757,"watchers":6304,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13032"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/13032"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/13032"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/13032/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13032/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/13032/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/09d9fcf4d6bc25af39c70fe2bd9553766805826f"}}}}