{"action":"created","issue":{"url":"https://api.github.com/repos/micropython/micropython/issues/1362","labels_url":"https://api.github.com/repos/micropython/micropython/issues/1362/labels{/name}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/1362/comments","events_url":"https://api.github.com/repos/micropython/micropython/issues/1362/events","html_url":"https://github.com/micropython/micropython/pull/1362","id":92768682,"number":1362,"title":"stmhal: Add I2S support to make-pins.py","user":{"login":"dhylands","id":127500,"avatar_url":"https://avatars.githubusercontent.com/u/127500?v=3","gravatar_id":"","url":"https://api.github.com/users/dhylands","html_url":"https://github.com/dhylands","followers_url":"https://api.github.com/users/dhylands/followers","following_url":"https://api.github.com/users/dhylands/following{/other_user}","gists_url":"https://api.github.com/users/dhylands/gists{/gist_id}","starred_url":"https://api.github.com/users/dhylands/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhylands/subscriptions","organizations_url":"https://api.github.com/users/dhylands/orgs","repos_url":"https://api.github.com/users/dhylands/repos","events_url":"https://api.github.com/users/dhylands/events{/privacy}","received_events_url":"https://api.github.com/users/dhylands/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-07-03T01:07:16Z","updated_at":"2015-07-07T15:56:02Z","closed_at":"2015-07-07T09:17:10Z","pull_request":{"url":"https://api.github.com/repos/micropython/micropython/pulls/1362","html_url":"https://github.com/micropython/micropython/pull/1362","diff_url":"https://github.com/micropython/micropython/pull/1362.diff","patch_url":"https://github.com/micropython/micropython/pull/1362.patch"},"body":"This adds support for I2S pins (which adds 400 bytes to the image when I2S is enabled).\r\n\r\nI also introduced the notion of conditional pins. For example, if MICROPY_HW_ENABLE_SPI3 is set to 0, then it won't define the alternate functions for SPI3.\r\n\r\nThe addition of conditional pins drops 264 bytes off the pyboard image (without I2S), and saves 92 bytes on the ESPRUINO_PICO image."},"comment":{"url":"https://api.github.com/repos/micropython/micropython/issues/comments/119247516","html_url":"https://github.com/micropython/micropython/pull/1362#issuecomment-119247516","issue_url":"https://api.github.com/repos/micropython/micropython/issues/1362","id":119247516,"user":{"login":"dpgeorge","id":6187689,"avatar_url":"https://avatars.githubusercontent.com/u/6187689?v=3","gravatar_id":"","url":"https://api.github.com/users/dpgeorge","html_url":"https://github.com/dpgeorge","followers_url":"https://api.github.com/users/dpgeorge/followers","following_url":"https://api.github.com/users/dpgeorge/following{/other_user}","gists_url":"https://api.github.com/users/dpgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgeorge/subscriptions","organizations_url":"https://api.github.com/users/dpgeorge/orgs","repos_url":"https://api.github.com/users/dpgeorge/repos","events_url":"https://api.github.com/users/dpgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/dpgeorge/received_events","type":"User","site_admin":false},"created_at":"2015-07-07T15:56:02Z","updated_at":"2015-07-07T15:56:02Z","body":"> I think it makes sense to make the PIN_TYPE_xxx values unique as part of your patch, since this is where the function to use them would be introduced.\r\n\r\nBut at least make them a separate commit."}}