{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/30547679","id":30547679,"diff_hunk":"@@ -41,27 +41,34 @@\n   left: 0;\n \n   background-color: $primary-text;\n+\n+  @extend .vjs-icon-circle;\n+\n+  &:before {\n+    position: absolute;\n+  }\n }\n \n-.video-js .vjs-slider-vertical .vjs-volume-level { width: 0.3em; }\n-.video-js .vjs-slider-horizontal .vjs-volume-level { height: 0.3em; }\n+.video-js .vjs-slider-vertical .vjs-volume-level {\n+  width: 0.3em;\n+\n+  &:before {","path":"src/css/components/_volume.scss","position":17,"original_position":17,"commit_id":"deb7ad84be6c06ad37c1b4ef2c70bd75aab92034","original_commit_id":"deb7ad84be6c06ad37c1b4ef2c70bd75aab92034","user":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"body":"It might be helpful to add some comments around these to make it clear that it's the handle being affected here. It's not obvious at first glance.","created_at":"2015-05-18T21:09:58Z","updated_at":"2015-05-18T21:09:58Z","html_url":"https://github.com/videojs/video.js/pull/2132#discussion_r30547679","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/2132","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/30547679"},"html":{"href":"https://github.com/videojs/video.js/pull/2132#discussion_r30547679"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2132"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/2132","id":34972506,"html_url":"https://github.com/videojs/video.js/pull/2132","diff_url":"https://github.com/videojs/video.js/pull/2132.diff","patch_url":"https://github.com/videojs/video.js/pull/2132.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/2132","number":2132,"state":"open","locked":false,"title":"Pure css slider handles","user":{"login":"mmcc","id":794988,"avatar_url":"https://avatars.githubusercontent.com/u/794988?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcc","html_url":"https://github.com/mmcc","followers_url":"https://api.github.com/users/mmcc/followers","following_url":"https://api.github.com/users/mmcc/following{/other_user}","gists_url":"https://api.github.com/users/mmcc/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcc/subscriptions","organizations_url":"https://api.github.com/users/mmcc/orgs","repos_url":"https://api.github.com/users/mmcc/repos","events_url":"https://api.github.com/users/mmcc/events{/privacy}","received_events_url":"https://api.github.com/users/mmcc/received_events","type":"User","site_admin":false},"body":"# Opening to review the idea, do not merge\r\n\r\nWe've talked about this in the past, but in starting to work on #2117 I realized that this would simplify my work there. We've talked about this in the past, but I just wanted to formally open this conversation and get feedback.\r\n\r\n## Pros\r\n- Simple, general CSS (after cleanup)\r\n- Can remove all the slider handle update logic\r\n\r\n## Cons\r\n- Full width skins (such as the default 4.0 skin) become more difficult","created_at":"2015-05-08T00:53:32Z","updated_at":"2015-05-18T21:09:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a78220e68295a4b18ece41377b2451a15bf18056","assignee":null,"milestone":{"url":"https://api.github.com/repos/videojs/video.js/milestones/4","html_url":"https://github.com/videojs/video.js/milestones/v5.0.0","labels_url":"https://api.github.com/repos/videojs/video.js/milestones/4/labels","id":496725,"number":4,"title":"v5.0.0","description":"","creator":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":27,"state":"open","created_at":"2013-11-26T00:05:50Z","updated_at":"2015-05-18T18:55:21Z","due_on":"2015-05-29T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/2132/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/2132/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/2132/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/deb7ad84be6c06ad37c1b4ef2c70bd75aab92034","head":{"label":"mmcc:css-only-slider-handle","ref":"css-only-slider-handle","sha":"deb7ad84be6c06ad37c1b4ef2c70bd75aab92034","user":{"login":"mmcc","id":794988,"avatar_url":"https://avatars.githubusercontent.com/u/794988?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcc","html_url":"https://github.com/mmcc","followers_url":"https://api.github.com/users/mmcc/followers","following_url":"https://api.github.com/users/mmcc/following{/other_user}","gists_url":"https://api.github.com/users/mmcc/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcc/subscriptions","organizations_url":"https://api.github.com/users/mmcc/orgs","repos_url":"https://api.github.com/users/mmcc/repos","events_url":"https://api.github.com/users/mmcc/events{/privacy}","received_events_url":"https://api.github.com/users/mmcc/received_events","type":"User","site_admin":false},"repo":{"id":13422289,"name":"video.js","full_name":"mmcc/video.js","owner":{"login":"mmcc","id":794988,"avatar_url":"https://avatars.githubusercontent.com/u/794988?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcc","html_url":"https://github.com/mmcc","followers_url":"https://api.github.com/users/mmcc/followers","following_url":"https://api.github.com/users/mmcc/following{/other_user}","gists_url":"https://api.github.com/users/mmcc/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcc/subscriptions","organizations_url":"https://api.github.com/users/mmcc/orgs","repos_url":"https://api.github.com/users/mmcc/repos","events_url":"https://api.github.com/users/mmcc/events{/privacy}","received_events_url":"https://api.github.com/users/mmcc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmcc/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":true,"url":"https://api.github.com/repos/mmcc/video.js","forks_url":"https://api.github.com/repos/mmcc/video.js/forks","keys_url":"https://api.github.com/repos/mmcc/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmcc/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmcc/video.js/teams","hooks_url":"https://api.github.com/repos/mmcc/video.js/hooks","issue_events_url":"https://api.github.com/repos/mmcc/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/mmcc/video.js/events","assignees_url":"https://api.github.com/repos/mmcc/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/mmcc/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/mmcc/video.js/tags","blobs_url":"https://api.github.com/repos/mmcc/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmcc/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmcc/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmcc/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmcc/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mmcc/video.js/languages","stargazers_url":"https://api.github.com/repos/mmcc/video.js/stargazers","contributors_url":"https://api.github.com/repos/mmcc/video.js/contributors","subscribers_url":"https://api.github.com/repos/mmcc/video.js/subscribers","subscription_url":"https://api.github.com/repos/mmcc/video.js/subscription","commits_url":"https://api.github.com/repos/mmcc/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmcc/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmcc/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmcc/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmcc/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/mmcc/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmcc/video.js/merges","archive_url":"https://api.github.com/repos/mmcc/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmcc/video.js/downloads","issues_url":"https://api.github.com/repos/mmcc/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/mmcc/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mmcc/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mmcc/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmcc/video.js/labels{/name}","releases_url":"https://api.github.com/repos/mmcc/video.js/releases{/id}","created_at":"2013-10-08T18:43:18Z","updated_at":"2015-05-06T21:09:59Z","pushed_at":"2015-05-18T20:56:09Z","git_url":"git://github.com/mmcc/video.js.git","ssh_url":"git@github.com:mmcc/video.js.git","clone_url":"https://github.com/mmcc/video.js.git","svn_url":"https://github.com/mmcc/video.js","homepage":"www.videojs.com","size":15950,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"dc083f8cf44821dea3548f1173f4e3c8080f13db","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","created_at":"2010-05-14T18:45:10Z","updated_at":"2015-05-18T20:19:47Z","pushed_at":"2015-05-18T20:56:10Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":36115,"stargazers_count":8961,"watchers_count":8961,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2497,"mirror_url":null,"open_issues_count":197,"forks":2497,"open_issues":197,"watchers":8961,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2132"},"html":{"href":"https://github.com/videojs/video.js/pull/2132"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/2132"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/2132/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2132/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2132/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/deb7ad84be6c06ad37c1b4ef2c70bd75aab92034"}}}}