{"action":"created","issue":{"url":"https://api.github.com/repos/cozy-labs/konnectors/issues/33","labels_url":"https://api.github.com/repos/cozy-labs/konnectors/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/cozy-labs/konnectors/issues/33/comments","events_url":"https://api.github.com/repos/cozy-labs/konnectors/issues/33/events","html_url":"https://github.com/cozy-labs/konnectors/pull/33","id":56357062,"number":33,"title":"Changed: notification behaviour","user":{"login":"jsilvestre","id":568111,"avatar_url":"https://avatars.githubusercontent.com/u/568111?v=3","gravatar_id":"","url":"https://api.github.com/users/jsilvestre","html_url":"https://github.com/jsilvestre","followers_url":"https://api.github.com/users/jsilvestre/followers","following_url":"https://api.github.com/users/jsilvestre/following{/other_user}","gists_url":"https://api.github.com/users/jsilvestre/gists{/gist_id}","starred_url":"https://api.github.com/users/jsilvestre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsilvestre/subscriptions","organizations_url":"https://api.github.com/users/jsilvestre/orgs","repos_url":"https://api.github.com/users/jsilvestre/repos","events_url":"https://api.github.com/users/jsilvestre/events{/privacy}","received_events_url":"https://api.github.com/users/jsilvestre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-03T10:06:48Z","updated_at":"2015-02-03T12:25:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cozy-labs/konnectors/pulls/33","html_url":"https://github.com/cozy-labs/konnectors/pull/33","diff_url":"https://github.com/cozy-labs/konnectors/pull/33.diff","patch_url":"https://github.com/cozy-labs/konnectors/pull/33.patch"},"body":"* each konnector is now responsible for creating its success notification\r\n* the failure notification is handled generically\r\n* there is no \"successful import\" permanent notification anymore\r\n* if there is an error notification, then a latter import is successful, the error notification is removed (or replaced, if the konnector provided a notification content)"},"comment":{"url":"https://api.github.com/repos/cozy-labs/konnectors/issues/comments/72642053","html_url":"https://github.com/cozy-labs/konnectors/pull/33#issuecomment-72642053","issue_url":"https://api.github.com/repos/cozy-labs/konnectors/issues/33","id":72642053,"user":{"login":"jsilvestre","id":568111,"avatar_url":"https://avatars.githubusercontent.com/u/568111?v=3","gravatar_id":"","url":"https://api.github.com/users/jsilvestre","html_url":"https://github.com/jsilvestre","followers_url":"https://api.github.com/users/jsilvestre/followers","following_url":"https://api.github.com/users/jsilvestre/following{/other_user}","gists_url":"https://api.github.com/users/jsilvestre/gists{/gist_id}","starred_url":"https://api.github.com/users/jsilvestre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsilvestre/subscriptions","organizations_url":"https://api.github.com/users/jsilvestre/orgs","repos_url":"https://api.github.com/users/jsilvestre/repos","events_url":"https://api.github.com/users/jsilvestre/events{/privacy}","received_events_url":"https://api.github.com/users/jsilvestre/received_events","type":"User","site_admin":false},"created_at":"2015-02-03T12:25:53Z","updated_at":"2015-02-03T12:25:53Z","body":"As of today, yes. The thing is that it won't break with previous behaviour except for the non permanent and annoying notification \"it all went okay\" if you had enabled the auto-import. If, as I think, this is the right way to handle this (I want to try with the ISEN konnectors which is more complex), I will add notifications for other konnectors.\r\n\r\nSince I want to iterate and try to make it as generic as possible, to avoid putting to much things into the konnectors themselves, I want to work on the ISEN konnectors (as I said, it's more complex) on order to acknowledge my implementation or do changes accordingly."}}