{"action":"closed","number":72,"pull_request":{"url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/pulls/72","id":43467848,"html_url":"https://github.com/ParsePlatform/Parse-SDK-Android/pull/72","diff_url":"https://github.com/ParsePlatform/Parse-SDK-Android/pull/72.diff","patch_url":"https://github.com/ParsePlatform/Parse-SDK-Android/pull/72.patch","issue_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/issues/72","number":72,"state":"closed","locked":false,"title":"Fix signUp and linkWith with an anonymous user","user":{"login":"grantland","id":277030,"avatar_url":"https://avatars.githubusercontent.com/u/277030?v=3","gravatar_id":"","url":"https://api.github.com/users/grantland","html_url":"https://github.com/grantland","followers_url":"https://api.github.com/users/grantland/followers","following_url":"https://api.github.com/users/grantland/following{/other_user}","gists_url":"https://api.github.com/users/grantland/gists{/gist_id}","starred_url":"https://api.github.com/users/grantland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantland/subscriptions","organizations_url":"https://api.github.com/users/grantland/orgs","repos_url":"https://api.github.com/users/grantland/repos","events_url":"https://api.github.com/users/grantland/events{/privacy}","received_events_url":"https://api.github.com/users/grantland/received_events","type":"User","site_admin":false},"body":"Fixes integration test failures caused by #52\r\n\r\nWe strip anonymity in `signUp` and `linkWith` before calling into\r\n`saveAsync` where there's a fork in logic for `isLazy()`. Since we now\r\ndetermine `isLazy()` based off `objectId != null &&\r\nParseAnonymousUtils.isLinked(this)`,\r\n`isLazy()` returns the incorrect value for these logic paths.\r\n\r\nThe solution is to get the value of `isLazy()` before stripping anonymity\r\nand passing it through to `saveAsync()`.\r\n\r\n* Callers of resolveLazinessAsync never use it's return value, might as well make it `Void`\r\n* Make signUp more robust by reverting current user's password on failure if that's how it originally was\r\n* Make signUp more robust by reverting the current user's password on success","created_at":"2015-08-27T00:30:06Z","updated_at":"2015-08-27T18:42:02Z","closed_at":"2015-08-27T18:42:02Z","merged_at":"2015-08-27T18:42:02Z","merge_commit_sha":"aee3379c85c1d6209d5e807b114e6949246a335c","assignee":{"login":"grantland","id":277030,"avatar_url":"https://avatars.githubusercontent.com/u/277030?v=3","gravatar_id":"","url":"https://api.github.com/users/grantland","html_url":"https://github.com/grantland","followers_url":"https://api.github.com/users/grantland/followers","following_url":"https://api.github.com/users/grantland/following{/other_user}","gists_url":"https://api.github.com/users/grantland/gists{/gist_id}","starred_url":"https://api.github.com/users/grantland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantland/subscriptions","organizations_url":"https://api.github.com/users/grantland/orgs","repos_url":"https://api.github.com/users/grantland/repos","events_url":"https://api.github.com/users/grantland/events{/privacy}","received_events_url":"https://api.github.com/users/grantland/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/pulls/72/commits","review_comments_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/pulls/72/comments","review_comment_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/issues/72/comments","statuses_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/statuses/fc249c024dee8a3a10f9e0f79e4c93f8ecadbeff","head":{"label":"ParsePlatform:grantland.lazy","ref":"grantland.lazy","sha":"fc249c024dee8a3a10f9e0f79e4c93f8ecadbeff","user":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":40628209,"name":"Parse-SDK-Android","full_name":"ParsePlatform/Parse-SDK-Android","owner":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParsePlatform/Parse-SDK-Android","description":"Parse SDK for Android","fork":false,"url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android","forks_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/forks","keys_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/teams","hooks_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/hooks","issue_events_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/events","assignees_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/tags","blobs_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/languages","stargazers_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/stargazers","contributors_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/contributors","subscribers_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/subscribers","subscription_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/subscription","commits_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/merges","archive_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/downloads","issues_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/releases{/id}","created_at":"2015-08-12T22:57:48Z","updated_at":"2015-08-27T17:15:59Z","pushed_at":"2015-08-27T18:42:03Z","git_url":"git://github.com/ParsePlatform/Parse-SDK-Android.git","ssh_url":"git@github.com:ParsePlatform/Parse-SDK-Android.git","clone_url":"https://github.com/ParsePlatform/Parse-SDK-Android.git","svn_url":"https://github.com/ParsePlatform/Parse-SDK-Android","homepage":"https://parse.com","size":1260,"stargazers_count":673,"watchers_count":673,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":34,"forks":92,"open_issues":34,"watchers":673,"default_branch":"master"}},"base":{"label":"ParsePlatform:master","ref":"master","sha":"4f93715ecc8b939a5cae4702a79514170c9701ac","user":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":40628209,"name":"Parse-SDK-Android","full_name":"ParsePlatform/Parse-SDK-Android","owner":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParsePlatform/Parse-SDK-Android","description":"Parse SDK for Android","fork":false,"url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android","forks_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/forks","keys_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/teams","hooks_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/hooks","issue_events_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/events","assignees_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/tags","blobs_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/languages","stargazers_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/stargazers","contributors_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/contributors","subscribers_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/subscribers","subscription_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/subscription","commits_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/merges","archive_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/downloads","issues_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/releases{/id}","created_at":"2015-08-12T22:57:48Z","updated_at":"2015-08-27T17:15:59Z","pushed_at":"2015-08-27T18:42:03Z","git_url":"git://github.com/ParsePlatform/Parse-SDK-Android.git","ssh_url":"git@github.com:ParsePlatform/Parse-SDK-Android.git","clone_url":"https://github.com/ParsePlatform/Parse-SDK-Android.git","svn_url":"https://github.com/ParsePlatform/Parse-SDK-Android","homepage":"https://parse.com","size":1260,"stargazers_count":673,"watchers_count":673,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":34,"forks":92,"open_issues":34,"watchers":673,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/pulls/72"},"html":{"href":"https://github.com/ParsePlatform/Parse-SDK-Android/pull/72"},"issue":{"href":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/issues/72"},"comments":{"href":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/ParsePlatform/Parse-SDK-Android/statuses/fc249c024dee8a3a10f9e0f79e4c93f8ecadbeff"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"grantland","id":277030,"avatar_url":"https://avatars.githubusercontent.com/u/277030?v=3","gravatar_id":"","url":"https://api.github.com/users/grantland","html_url":"https://github.com/grantland","followers_url":"https://api.github.com/users/grantland/followers","following_url":"https://api.github.com/users/grantland/following{/other_user}","gists_url":"https://api.github.com/users/grantland/gists{/gist_id}","starred_url":"https://api.github.com/users/grantland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantland/subscriptions","organizations_url":"https://api.github.com/users/grantland/orgs","repos_url":"https://api.github.com/users/grantland/repos","events_url":"https://api.github.com/users/grantland/events{/privacy}","received_events_url":"https://api.github.com/users/grantland/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":73,"deletions":85,"changed_files":2}}