{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/29467499","id":29467499,"diff_hunk":"@@ -112,167 +109,141 @@ public sealed override int GetHashCode ()\n \t\t// </summary>\n \t\tpublic sealed override Delegate[] GetInvocationList ()\n \t\t{\n-\t\t\tMulticastDelegate d;\n-\t\t\td = (MulticastDelegate) this.Clone ();\n-\t\t\tfor (d.kpm_next = null; d.prev != null; d = d.prev)\n-\t\t\t\td.prev.kpm_next = d;\n-\n-\t\t\tif (d.kpm_next == null) {\n-\t\t\t\tMulticastDelegate other = (MulticastDelegate) d.Clone ();\n-\t\t\t\tother.prev = null;\n-\t\t\t\tother.kpm_next = null;\t\t\t\t\n-\t\t\t\treturn new Delegate [1] { other };\n-\t\t\t}\n-\n-\t\t\tvar list = new List<Delegate> ();\n-\t\t\tfor (; d != null; d = d.kpm_next) {\n-\t\t\t\tMulticastDelegate other = (MulticastDelegate) d.Clone ();\n-\t\t\t\tother.prev = null;\n-\t\t\t\tother.kpm_next = null;\n-\t\t\t\tlist.Add (other);\n-\t\t\t}\n-\n-\t\t\treturn list.ToArray ();\n+\t\t\treturn delegates;\n \t\t}\n \n \t\t// <summary>\n-\t\t//   Combines this MulticastDelegate with the (Multicast)Delegate `follow'.\n+\t\t//   Combines this MulticastDelegate with the (Multicast)Delegate `other'.\n \t\t//   This does _not_ combine with Delegates. ECMA states the whole delegate\n \t\t//   thing should have better been a simple System.Delegate class.\n \t\t//   Compiler generated delegates are always MulticastDelegates.\n \t\t// </summary>\n-\t\tprotected sealed override Delegate CombineImpl (Delegate follow)\n+\t\tprotected override sealed Delegate CombineImpl (Delegate v)","path":"mcs/class/corlib/System/MulticastDelegate.cs","position":96,"original_position":96,"commit_id":"ddacfe06a30514149a384eb6d1d0ac0d0df7b9d3","original_commit_id":"ddacfe06a30514149a384eb6d1d0ac0d0df7b9d3","user":{"login":"ludovic-henry","id":660779,"avatar_url":"https://avatars.githubusercontent.com/u/660779?v=3","gravatar_id":"","url":"https://api.github.com/users/ludovic-henry","html_url":"https://github.com/ludovic-henry","followers_url":"https://api.github.com/users/ludovic-henry/followers","following_url":"https://api.github.com/users/ludovic-henry/following{/other_user}","gists_url":"https://api.github.com/users/ludovic-henry/gists{/gist_id}","starred_url":"https://api.github.com/users/ludovic-henry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludovic-henry/subscriptions","organizations_url":"https://api.github.com/users/ludovic-henry/orgs","repos_url":"https://api.github.com/users/ludovic-henry/repos","events_url":"https://api.github.com/users/ludovic-henry/events{/privacy}","received_events_url":"https://api.github.com/users/ludovic-henry/received_events","type":"User","site_admin":false},"body":"ok, let me revert that then","created_at":"2015-04-30T20:36:29Z","updated_at":"2015-04-30T20:36:29Z","html_url":"https://github.com/mono/mono/pull/1757#discussion_r29467499","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/1757","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/29467499"},"html":{"href":"https://github.com/mono/mono/pull/1757#discussion_r29467499"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/1757"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/1757","id":34493048,"html_url":"https://github.com/mono/mono/pull/1757","diff_url":"https://github.com/mono/mono/pull/1757.diff","patch_url":"https://github.com/mono/mono/pull/1757.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/1757","number":1757,"state":"open","locked":false,"title":"[delegate] Replace multicast delegate implementation","user":{"login":"ludovic-henry","id":660779,"avatar_url":"https://avatars.githubusercontent.com/u/660779?v=3","gravatar_id":"","url":"https://api.github.com/users/ludovic-henry","html_url":"https://github.com/ludovic-henry","followers_url":"https://api.github.com/users/ludovic-henry/followers","following_url":"https://api.github.com/users/ludovic-henry/following{/other_user}","gists_url":"https://api.github.com/users/ludovic-henry/gists{/gist_id}","starred_url":"https://api.github.com/users/ludovic-henry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludovic-henry/subscriptions","organizations_url":"https://api.github.com/users/ludovic-henry/orgs","repos_url":"https://api.github.com/users/ludovic-henry/repos","events_url":"https://api.github.com/users/ludovic-henry/events{/privacy}","received_events_url":"https://api.github.com/users/ludovic-henry/received_events","type":"User","site_admin":false},"body":"Replace the reversed linked implementation by an array based implementation. This improve Combine performance, as well as ease delegate to virtual function optimization.","created_at":"2015-04-30T19:32:52Z","updated_at":"2015-04-30T20:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b6bd3bbc9186b65a40256ff6597944c6502c269","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/1757/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/1757/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/1757/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/ddacfe06a30514149a384eb6d1d0ac0d0df7b9d3","head":{"label":"ludovic-henry:delegate-multicast-array-2","ref":"delegate-multicast-array-2","sha":"ddacfe06a30514149a384eb6d1d0ac0d0df7b9d3","user":{"login":"ludovic-henry","id":660779,"avatar_url":"https://avatars.githubusercontent.com/u/660779?v=3","gravatar_id":"","url":"https://api.github.com/users/ludovic-henry","html_url":"https://github.com/ludovic-henry","followers_url":"https://api.github.com/users/ludovic-henry/followers","following_url":"https://api.github.com/users/ludovic-henry/following{/other_user}","gists_url":"https://api.github.com/users/ludovic-henry/gists{/gist_id}","starred_url":"https://api.github.com/users/ludovic-henry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludovic-henry/subscriptions","organizations_url":"https://api.github.com/users/ludovic-henry/orgs","repos_url":"https://api.github.com/users/ludovic-henry/repos","events_url":"https://api.github.com/users/ludovic-henry/events{/privacy}","received_events_url":"https://api.github.com/users/ludovic-henry/received_events","type":"User","site_admin":false},"repo":{"id":18306049,"name":"mono","full_name":"ludovic-henry/mono","owner":{"login":"ludovic-henry","id":660779,"avatar_url":"https://avatars.githubusercontent.com/u/660779?v=3","gravatar_id":"","url":"https://api.github.com/users/ludovic-henry","html_url":"https://github.com/ludovic-henry","followers_url":"https://api.github.com/users/ludovic-henry/followers","following_url":"https://api.github.com/users/ludovic-henry/following{/other_user}","gists_url":"https://api.github.com/users/ludovic-henry/gists{/gist_id}","starred_url":"https://api.github.com/users/ludovic-henry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludovic-henry/subscriptions","organizations_url":"https://api.github.com/users/ludovic-henry/orgs","repos_url":"https://api.github.com/users/ludovic-henry/repos","events_url":"https://api.github.com/users/ludovic-henry/events{/privacy}","received_events_url":"https://api.github.com/users/ludovic-henry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ludovic-henry/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/ludovic-henry/mono","forks_url":"https://api.github.com/repos/ludovic-henry/mono/forks","keys_url":"https://api.github.com/repos/ludovic-henry/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ludovic-henry/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ludovic-henry/mono/teams","hooks_url":"https://api.github.com/repos/ludovic-henry/mono/hooks","issue_events_url":"https://api.github.com/repos/ludovic-henry/mono/issues/events{/number}","events_url":"https://api.github.com/repos/ludovic-henry/mono/events","assignees_url":"https://api.github.com/repos/ludovic-henry/mono/assignees{/user}","branches_url":"https://api.github.com/repos/ludovic-henry/mono/branches{/branch}","tags_url":"https://api.github.com/repos/ludovic-henry/mono/tags","blobs_url":"https://api.github.com/repos/ludovic-henry/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ludovic-henry/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ludovic-henry/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/ludovic-henry/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ludovic-henry/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/ludovic-henry/mono/languages","stargazers_url":"https://api.github.com/repos/ludovic-henry/mono/stargazers","contributors_url":"https://api.github.com/repos/ludovic-henry/mono/contributors","subscribers_url":"https://api.github.com/repos/ludovic-henry/mono/subscribers","subscription_url":"https://api.github.com/repos/ludovic-henry/mono/subscription","commits_url":"https://api.github.com/repos/ludovic-henry/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/ludovic-henry/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/ludovic-henry/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/ludovic-henry/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/ludovic-henry/mono/contents/{+path}","compare_url":"https://api.github.com/repos/ludovic-henry/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ludovic-henry/mono/merges","archive_url":"https://api.github.com/repos/ludovic-henry/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ludovic-henry/mono/downloads","issues_url":"https://api.github.com/repos/ludovic-henry/mono/issues{/number}","pulls_url":"https://api.github.com/repos/ludovic-henry/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/ludovic-henry/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/ludovic-henry/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ludovic-henry/mono/labels{/name}","releases_url":"https://api.github.com/repos/ludovic-henry/mono/releases{/id}","created_at":"2014-03-31T19:55:14Z","updated_at":"2015-04-28T20:30:37Z","pushed_at":"2015-04-30T20:16:35Z","git_url":"git://github.com/ludovic-henry/mono.git","ssh_url":"git@github.com:ludovic-henry/mono.git","clone_url":"https://github.com/ludovic-henry/mono.git","svn_url":"https://github.com/ludovic-henry/mono","homepage":"http://www.mono-project.com/","size":426537,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"52d90792138cf5ec9f20dc86dcbabce33e767cb7","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","created_at":"2010-07-22T18:06:36Z","updated_at":"2015-04-30T19:40:53Z","pushed_at":"2015-04-30T20:16:39Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":1375287,"stargazers_count":3336,"watchers_count":3336,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1673,"mirror_url":null,"open_issues_count":103,"forks":1673,"open_issues":103,"watchers":3336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/1757"},"html":{"href":"https://github.com/mono/mono/pull/1757"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/1757"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/1757/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/1757/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/1757/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/ddacfe06a30514149a384eb6d1d0ac0d0df7b9d3"}}}}