{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-app-android/issues/430","labels_url":"https://api.github.com/repos/edx/edx-app-android/issues/430/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-app-android/issues/430/comments","events_url":"https://api.github.com/repos/edx/edx-app-android/issues/430/events","html_url":"https://github.com/edx/edx-app-android/pull/430","id":117085004,"number":430,"title":"Hide unloaded courseware menu","user":{"login":"1zaman","id":4244109,"avatar_url":"https://avatars.githubusercontent.com/u/4244109?v=3","gravatar_id":"","url":"https://api.github.com/users/1zaman","html_url":"https://github.com/1zaman","followers_url":"https://api.github.com/users/1zaman/followers","following_url":"https://api.github.com/users/1zaman/following{/other_user}","gists_url":"https://api.github.com/users/1zaman/gists{/gist_id}","starred_url":"https://api.github.com/users/1zaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1zaman/subscriptions","organizations_url":"https://api.github.com/users/1zaman/orgs","repos_url":"https://api.github.com/users/1zaman/repos","events_url":"https://api.github.com/users/1zaman/events{/privacy}","received_events_url":"https://api.github.com/users/1zaman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-16T09:41:03Z","updated_at":"2015-11-16T13:38:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-app-android/pulls/430","html_url":"https://github.com/edx/edx-app-android/pull/430","diff_url":"https://github.com/edx/edx-app-android/pull/430.diff","patch_url":"https://github.com/edx/edx-app-android/pull/430.patch"},"body":"Until the course data has been loaded, the filter menu is not useful and the website link is not available, so there is no point in displaying the menu. This also removes the need for a null check on the course data in the \"View on Web\" menu.\r\n\r\nThe filtering menu initialization logic has been changed to use the color selector resource as the icon color, to take advantage of the support for color selectors in `IconDrawable` that was introduced in commit f5a0609baf19f46141ff676a37fb6f44cb5ff602. Also, the filter menu icon is now directly toggled upon selection, instead of causing the whole menu to be rebuilt.\r\n\r\nThere is also a bug fix for `MenuPopupHelper` to have it's presenter added to the top-level submenus as well as the base menu, as those are also flattened as top-level items. The presenter is required for providing data on the menu items, and refreshing them on state change. Since there is not callback on submenu additions, we ensure the presenter for submenus in the adapter callbacks, which are called right before display.\r\n\r\nThere are also small formatting and structural improvements in the menu creation logic, and the per-second `onTick()` callback handling also been optimized and refined.\r\n\r\nhttps://openedx.atlassian.net/browse/MA-1653"},"comment":{"url":"https://api.github.com/repos/edx/edx-app-android/issues/comments/157028604","html_url":"https://github.com/edx/edx-app-android/pull/430#issuecomment-157028604","issue_url":"https://api.github.com/repos/edx/edx-app-android/issues/430","id":157028604,"user":{"login":"1zaman","id":4244109,"avatar_url":"https://avatars.githubusercontent.com/u/4244109?v=3","gravatar_id":"","url":"https://api.github.com/users/1zaman","html_url":"https://github.com/1zaman","followers_url":"https://api.github.com/users/1zaman/followers","following_url":"https://api.github.com/users/1zaman/following{/other_user}","gists_url":"https://api.github.com/users/1zaman/gists{/gist_id}","starred_url":"https://api.github.com/users/1zaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1zaman/subscriptions","organizations_url":"https://api.github.com/users/1zaman/orgs","repos_url":"https://api.github.com/users/1zaman/repos","events_url":"https://api.github.com/users/1zaman/events{/privacy}","received_events_url":"https://api.github.com/users/1zaman/received_events","type":"User","site_admin":false},"created_at":"2015-11-16T13:38:11Z","updated_at":"2015-11-16T13:38:11Z","body":"@bguertin, @miankhalid, please review"}}