{"action":"closed","number":1881,"pull_request":{"url":"https://api.github.com/repos/nitlang/nit/pulls/1881","id":53009951,"html_url":"https://github.com/nitlang/nit/pull/1881","diff_url":"https://github.com/nitlang/nit/pull/1881.diff","patch_url":"https://github.com/nitlang/nit/pull/1881.patch","issue_url":"https://api.github.com/repos/nitlang/nit/issues/1881","number":1881,"state":"closed","locked":false,"title":"Inline binops","user":{"login":"R4PaSs","id":1444825,"avatar_url":"https://avatars.githubusercontent.com/u/1444825?v=3","gravatar_id":"","url":"https://api.github.com/users/R4PaSs","html_url":"https://github.com/R4PaSs","followers_url":"https://api.github.com/users/R4PaSs/followers","following_url":"https://api.github.com/users/R4PaSs/following{/other_user}","gists_url":"https://api.github.com/users/R4PaSs/gists{/gist_id}","starred_url":"https://api.github.com/users/R4PaSs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R4PaSs/subscriptions","organizations_url":"https://api.github.com/users/R4PaSs/orgs","repos_url":"https://api.github.com/users/R4PaSs/repos","events_url":"https://api.github.com/users/R4PaSs/events{/privacy}","received_events_url":"https://api.github.com/users/R4PaSs/received_events","type":"User","site_admin":false},"body":"This PR re-introduces several binary operations implemented as intern to avoid indirection through FFI in some specific cases to improve performance notably in `core/text/native`\r\n\r\nAlso a style change for `abs` which could easily be inlined and burned by eyes when I saw it, I can remove the commit if someone objects to the modification","created_at":"2015-12-08T17:15:36Z","updated_at":"2015-12-09T12:58:06Z","closed_at":"2015-12-09T12:58:06Z","merged_at":"2015-12-09T12:58:06Z","merge_commit_sha":"123b480eefdc2cc73045d71e92fd3048d64d1fd5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nitlang/nit/pulls/1881/commits","review_comments_url":"https://api.github.com/repos/nitlang/nit/pulls/1881/comments","review_comment_url":"https://api.github.com/repos/nitlang/nit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nitlang/nit/issues/1881/comments","statuses_url":"https://api.github.com/repos/nitlang/nit/statuses/5b44ff8caa05efc3f73a4c43c618f84438f1f589","head":{"label":"R4PaSs:inline_binops","ref":"inline_binops","sha":"5b44ff8caa05efc3f73a4c43c618f84438f1f589","user":{"login":"R4PaSs","id":1444825,"avatar_url":"https://avatars.githubusercontent.com/u/1444825?v=3","gravatar_id":"","url":"https://api.github.com/users/R4PaSs","html_url":"https://github.com/R4PaSs","followers_url":"https://api.github.com/users/R4PaSs/followers","following_url":"https://api.github.com/users/R4PaSs/following{/other_user}","gists_url":"https://api.github.com/users/R4PaSs/gists{/gist_id}","starred_url":"https://api.github.com/users/R4PaSs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R4PaSs/subscriptions","organizations_url":"https://api.github.com/users/R4PaSs/orgs","repos_url":"https://api.github.com/users/R4PaSs/repos","events_url":"https://api.github.com/users/R4PaSs/events{/privacy}","received_events_url":"https://api.github.com/users/R4PaSs/received_events","type":"User","site_admin":false},"repo":{"id":4930337,"name":"nit","full_name":"R4PaSs/nit","owner":{"login":"R4PaSs","id":1444825,"avatar_url":"https://avatars.githubusercontent.com/u/1444825?v=3","gravatar_id":"","url":"https://api.github.com/users/R4PaSs","html_url":"https://github.com/R4PaSs","followers_url":"https://api.github.com/users/R4PaSs/followers","following_url":"https://api.github.com/users/R4PaSs/following{/other_user}","gists_url":"https://api.github.com/users/R4PaSs/gists{/gist_id}","starred_url":"https://api.github.com/users/R4PaSs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/R4PaSs/subscriptions","organizations_url":"https://api.github.com/users/R4PaSs/orgs","repos_url":"https://api.github.com/users/R4PaSs/repos","events_url":"https://api.github.com/users/R4PaSs/events{/privacy}","received_events_url":"https://api.github.com/users/R4PaSs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/R4PaSs/nit","description":"Nit language","fork":true,"url":"https://api.github.com/repos/R4PaSs/nit","forks_url":"https://api.github.com/repos/R4PaSs/nit/forks","keys_url":"https://api.github.com/repos/R4PaSs/nit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/R4PaSs/nit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/R4PaSs/nit/teams","hooks_url":"https://api.github.com/repos/R4PaSs/nit/hooks","issue_events_url":"https://api.github.com/repos/R4PaSs/nit/issues/events{/number}","events_url":"https://api.github.com/repos/R4PaSs/nit/events","assignees_url":"https://api.github.com/repos/R4PaSs/nit/assignees{/user}","branches_url":"https://api.github.com/repos/R4PaSs/nit/branches{/branch}","tags_url":"https://api.github.com/repos/R4PaSs/nit/tags","blobs_url":"https://api.github.com/repos/R4PaSs/nit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/R4PaSs/nit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/R4PaSs/nit/git/refs{/sha}","trees_url":"https://api.github.com/repos/R4PaSs/nit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/R4PaSs/nit/statuses/{sha}","languages_url":"https://api.github.com/repos/R4PaSs/nit/languages","stargazers_url":"https://api.github.com/repos/R4PaSs/nit/stargazers","contributors_url":"https://api.github.com/repos/R4PaSs/nit/contributors","subscribers_url":"https://api.github.com/repos/R4PaSs/nit/subscribers","subscription_url":"https://api.github.com/repos/R4PaSs/nit/subscription","commits_url":"https://api.github.com/repos/R4PaSs/nit/commits{/sha}","git_commits_url":"https://api.github.com/repos/R4PaSs/nit/git/commits{/sha}","comments_url":"https://api.github.com/repos/R4PaSs/nit/comments{/number}","issue_comment_url":"https://api.github.com/repos/R4PaSs/nit/issues/comments{/number}","contents_url":"https://api.github.com/repos/R4PaSs/nit/contents/{+path}","compare_url":"https://api.github.com/repos/R4PaSs/nit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/R4PaSs/nit/merges","archive_url":"https://api.github.com/repos/R4PaSs/nit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/R4PaSs/nit/downloads","issues_url":"https://api.github.com/repos/R4PaSs/nit/issues{/number}","pulls_url":"https://api.github.com/repos/R4PaSs/nit/pulls{/number}","milestones_url":"https://api.github.com/repos/R4PaSs/nit/milestones{/number}","notifications_url":"https://api.github.com/repos/R4PaSs/nit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/R4PaSs/nit/labels{/name}","releases_url":"https://api.github.com/repos/R4PaSs/nit/releases{/id}","created_at":"2012-07-06T19:56:01Z","updated_at":"2014-12-09T16:44:12Z","pushed_at":"2015-12-08T20:47:00Z","git_url":"git://github.com/R4PaSs/nit.git","ssh_url":"git@github.com:R4PaSs/nit.git","clone_url":"https://github.com/R4PaSs/nit.git","svn_url":"https://github.com/R4PaSs/nit","homepage":"http://nitlanguage.org","size":73383,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"nitlang:master","ref":"master","sha":"aa7a350ac367b3c154755cc372dfed10319eb704","user":{"login":"nitlang","id":5420298,"avatar_url":"https://avatars.githubusercontent.com/u/5420298?v=3","gravatar_id":"","url":"https://api.github.com/users/nitlang","html_url":"https://github.com/nitlang","followers_url":"https://api.github.com/users/nitlang/followers","following_url":"https://api.github.com/users/nitlang/following{/other_user}","gists_url":"https://api.github.com/users/nitlang/gists{/gist_id}","starred_url":"https://api.github.com/users/nitlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitlang/subscriptions","organizations_url":"https://api.github.com/users/nitlang/orgs","repos_url":"https://api.github.com/users/nitlang/repos","events_url":"https://api.github.com/users/nitlang/events{/privacy}","received_events_url":"https://api.github.com/users/nitlang/received_events","type":"Organization","site_admin":false},"repo":{"id":328597,"name":"nit","full_name":"nitlang/nit","owner":{"login":"nitlang","id":5420298,"avatar_url":"https://avatars.githubusercontent.com/u/5420298?v=3","gravatar_id":"","url":"https://api.github.com/users/nitlang","html_url":"https://github.com/nitlang","followers_url":"https://api.github.com/users/nitlang/followers","following_url":"https://api.github.com/users/nitlang/following{/other_user}","gists_url":"https://api.github.com/users/nitlang/gists{/gist_id}","starred_url":"https://api.github.com/users/nitlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitlang/subscriptions","organizations_url":"https://api.github.com/users/nitlang/orgs","repos_url":"https://api.github.com/users/nitlang/repos","events_url":"https://api.github.com/users/nitlang/events{/privacy}","received_events_url":"https://api.github.com/users/nitlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nitlang/nit","description":"Nit language","fork":false,"url":"https://api.github.com/repos/nitlang/nit","forks_url":"https://api.github.com/repos/nitlang/nit/forks","keys_url":"https://api.github.com/repos/nitlang/nit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nitlang/nit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nitlang/nit/teams","hooks_url":"https://api.github.com/repos/nitlang/nit/hooks","issue_events_url":"https://api.github.com/repos/nitlang/nit/issues/events{/number}","events_url":"https://api.github.com/repos/nitlang/nit/events","assignees_url":"https://api.github.com/repos/nitlang/nit/assignees{/user}","branches_url":"https://api.github.com/repos/nitlang/nit/branches{/branch}","tags_url":"https://api.github.com/repos/nitlang/nit/tags","blobs_url":"https://api.github.com/repos/nitlang/nit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nitlang/nit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nitlang/nit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nitlang/nit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nitlang/nit/statuses/{sha}","languages_url":"https://api.github.com/repos/nitlang/nit/languages","stargazers_url":"https://api.github.com/repos/nitlang/nit/stargazers","contributors_url":"https://api.github.com/repos/nitlang/nit/contributors","subscribers_url":"https://api.github.com/repos/nitlang/nit/subscribers","subscription_url":"https://api.github.com/repos/nitlang/nit/subscription","commits_url":"https://api.github.com/repos/nitlang/nit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nitlang/nit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nitlang/nit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nitlang/nit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nitlang/nit/contents/{+path}","compare_url":"https://api.github.com/repos/nitlang/nit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nitlang/nit/merges","archive_url":"https://api.github.com/repos/nitlang/nit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nitlang/nit/downloads","issues_url":"https://api.github.com/repos/nitlang/nit/issues{/number}","pulls_url":"https://api.github.com/repos/nitlang/nit/pulls{/number}","milestones_url":"https://api.github.com/repos/nitlang/nit/milestones{/number}","notifications_url":"https://api.github.com/repos/nitlang/nit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nitlang/nit/labels{/name}","releases_url":"https://api.github.com/repos/nitlang/nit/releases{/id}","created_at":"2009-10-06T15:03:00Z","updated_at":"2015-12-08T14:15:07Z","pushed_at":"2015-12-09T12:58:04Z","git_url":"git://github.com/nitlang/nit.git","ssh_url":"git@github.com:nitlang/nit.git","clone_url":"https://github.com/nitlang/nit.git","svn_url":"https://github.com/nitlang/nit","homepage":"http://nitlanguage.org","size":92732,"stargazers_count":83,"watchers_count":83,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":142,"forks":46,"open_issues":142,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nitlang/nit/pulls/1881"},"html":{"href":"https://github.com/nitlang/nit/pull/1881"},"issue":{"href":"https://api.github.com/repos/nitlang/nit/issues/1881"},"comments":{"href":"https://api.github.com/repos/nitlang/nit/issues/1881/comments"},"review_comments":{"href":"https://api.github.com/repos/nitlang/nit/pulls/1881/comments"},"review_comment":{"href":"https://api.github.com/repos/nitlang/nit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nitlang/nit/pulls/1881/commits"},"statuses":{"href":"https://api.github.com/repos/nitlang/nit/statuses/5b44ff8caa05efc3f73a4c43c618f84438f1f589"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"privat","id":135828,"avatar_url":"https://avatars.githubusercontent.com/u/135828?v=3","gravatar_id":"","url":"https://api.github.com/users/privat","html_url":"https://github.com/privat","followers_url":"https://api.github.com/users/privat/followers","following_url":"https://api.github.com/users/privat/following{/other_user}","gists_url":"https://api.github.com/users/privat/gists{/gist_id}","starred_url":"https://api.github.com/users/privat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privat/subscriptions","organizations_url":"https://api.github.com/users/privat/orgs","repos_url":"https://api.github.com/users/privat/repos","events_url":"https://api.github.com/users/privat/events{/privacy}","received_events_url":"https://api.github.com/users/privat/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"commits":3,"additions":72,"deletions":30,"changed_files":8}}