{"action":"created","issue":{"url":"https://api.github.com/repos/Gamua/Sparrow-Framework/issues/46","labels_url":"https://api.github.com/repos/Gamua/Sparrow-Framework/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/Gamua/Sparrow-Framework/issues/46/comments","events_url":"https://api.github.com/repos/Gamua/Sparrow-Framework/issues/46/events","html_url":"https://github.com/Gamua/Sparrow-Framework/pull/46","id":102945224,"number":46,"title":"Added support for Xcode 6","user":{"login":"MrLarryLi","id":8570900,"avatar_url":"https://avatars.githubusercontent.com/u/8570900?v=3","gravatar_id":"","url":"https://api.github.com/users/MrLarryLi","html_url":"https://github.com/MrLarryLi","followers_url":"https://api.github.com/users/MrLarryLi/followers","following_url":"https://api.github.com/users/MrLarryLi/following{/other_user}","gists_url":"https://api.github.com/users/MrLarryLi/gists{/gist_id}","starred_url":"https://api.github.com/users/MrLarryLi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrLarryLi/subscriptions","organizations_url":"https://api.github.com/users/MrLarryLi/orgs","repos_url":"https://api.github.com/users/MrLarryLi/repos","events_url":"https://api.github.com/users/MrLarryLi/events{/privacy}","received_events_url":"https://api.github.com/users/MrLarryLi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-25T04:07:43Z","updated_at":"2015-08-25T17:29:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Gamua/Sparrow-Framework/pulls/46","html_url":"https://github.com/Gamua/Sparrow-Framework/pull/46","diff_url":"https://github.com/Gamua/Sparrow-Framework/pull/46.diff","patch_url":"https://github.com/Gamua/Sparrow-Framework/pull/46.patch"},"body":"Hello,\r\n\r\nThank you for the feedback. I managed to redo my fork so now it's cleaner. \r\n\r\n1) I changed glBufferData() because I noticed that it always sends the entire buffer. I do not know how much it impacts performance, but it makes it easier for me to debug.\r\n2) I changed the colors to have alpha because I ran into situations where SPColorWhite wasn't equal to SPColorMakeARGB(255,255,255,255). \r\n3) As for NSCopying, I did encounter a situation where I called \"copy\" on one of my sprites. It called the SPSprite \"copy\" method and didn't call my copyWithZone: method (I can't remember for sure). I did notice something wrong in my game when it happened. That's why I changed them all. It could also be that I don't call [super copy] on my sprites because SPSprite didn't used to implement it. \r\n\r\nPlease let me know if there are other things I should do. "},"comment":{"url":"https://api.github.com/repos/Gamua/Sparrow-Framework/issues/comments/134678349","html_url":"https://github.com/Gamua/Sparrow-Framework/pull/46#issuecomment-134678349","issue_url":"https://api.github.com/repos/Gamua/Sparrow-Framework/issues/46","id":134678349,"user":{"login":"racarone","id":1103284,"avatar_url":"https://avatars.githubusercontent.com/u/1103284?v=3","gravatar_id":"","url":"https://api.github.com/users/racarone","html_url":"https://github.com/racarone","followers_url":"https://api.github.com/users/racarone/followers","following_url":"https://api.github.com/users/racarone/following{/other_user}","gists_url":"https://api.github.com/users/racarone/gists{/gist_id}","starred_url":"https://api.github.com/users/racarone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racarone/subscriptions","organizations_url":"https://api.github.com/users/racarone/orgs","repos_url":"https://api.github.com/users/racarone/repos","events_url":"https://api.github.com/users/racarone/events{/privacy}","received_events_url":"https://api.github.com/users/racarone/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T17:29:09Z","updated_at":"2015-08-25T17:29:09Z","body":"Perfect! \r\n\r\n1.) Yeah uploading the full buffer is actually more efficient, at least on iOS devices.\r\n2.) Makes sense, will merge this.\r\n3.) I understand how that can occur now, will merge. =)\r\n\r\nThanks Larry!"}}