{"action":"created","issue":{"url":"https://api.github.com/repos/react-bootstrap/react-overlays/issues/17","labels_url":"https://api.github.com/repos/react-bootstrap/react-overlays/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/react-bootstrap/react-overlays/issues/17/comments","events_url":"https://api.github.com/repos/react-bootstrap/react-overlays/issues/17/events","html_url":"https://github.com/react-bootstrap/react-overlays/pull/17","id":102081895,"number":17,"title":"DO NOT MERGE: Add OverlayTrigger","user":{"login":"cesarandreu","id":656870,"avatar_url":"https://avatars.githubusercontent.com/u/656870?v=3","gravatar_id":"","url":"https://api.github.com/users/cesarandreu","html_url":"https://github.com/cesarandreu","followers_url":"https://api.github.com/users/cesarandreu/followers","following_url":"https://api.github.com/users/cesarandreu/following{/other_user}","gists_url":"https://api.github.com/users/cesarandreu/gists{/gist_id}","starred_url":"https://api.github.com/users/cesarandreu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesarandreu/subscriptions","organizations_url":"https://api.github.com/users/cesarandreu/orgs","repos_url":"https://api.github.com/users/cesarandreu/repos","events_url":"https://api.github.com/users/cesarandreu/events{/privacy}","received_events_url":"https://api.github.com/users/cesarandreu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-08-20T07:43:38Z","updated_at":"2015-08-21T00:29:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/react-bootstrap/react-overlays/pulls/17","html_url":"https://github.com/react-bootstrap/react-overlays/pull/17","diff_url":"https://github.com/react-bootstrap/react-overlays/pull/17.diff","patch_url":"https://github.com/react-bootstrap/react-overlays/pull/17.patch"},"body":"I needed it, so I ripped it out from react-bootstrap.\r\nThis needs to get cleaned up, but I figure having a PR doesn't hurt.\r\n\r\nThe examples server wasn't working for some reason, so I converted the two loaders to ES5 and used webpack-dev-server from the CLI.\r\n\r\nUsing npm v3.3.0, I managed to install all dependencies and generate a new example bundle. I was getting errors and updating all outdated dependencies somehow solved it. Re-added the jquense/component-playground package to get stuff working again.\r\n\r\nIn OverlayTrigger I removed the reference to react-bootstrap from the warning message. In OverlayTriggerSpec I removed the overlay types, since there's no tooltips / popovers here. Probably need to add a new test-case for that. \r\n\r\nReduced the Transition timeout from 5 seconds to 1 second, because otherwise the test would time out. Increased the wait-time for that test to 5 seconds as well.\r\n\r\nYou can confirm that it works by checking out by branch, and running a file-server from the examples folder. "},"comment":{"url":"https://api.github.com/repos/react-bootstrap/react-overlays/issues/comments/133226619","html_url":"https://github.com/react-bootstrap/react-overlays/pull/17#issuecomment-133226619","issue_url":"https://api.github.com/repos/react-bootstrap/react-overlays/issues/17","id":133226619,"user":{"login":"jquense","id":339286,"avatar_url":"https://avatars.githubusercontent.com/u/339286?v=3","gravatar_id":"","url":"https://api.github.com/users/jquense","html_url":"https://github.com/jquense","followers_url":"https://api.github.com/users/jquense/followers","following_url":"https://api.github.com/users/jquense/following{/other_user}","gists_url":"https://api.github.com/users/jquense/gists{/gist_id}","starred_url":"https://api.github.com/users/jquense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquense/subscriptions","organizations_url":"https://api.github.com/users/jquense/orgs","repos_url":"https://api.github.com/users/jquense/repos","events_url":"https://api.github.com/users/jquense/events{/privacy}","received_events_url":"https://api.github.com/users/jquense/received_events","type":"User","site_admin":false},"created_at":"2015-08-21T00:29:04Z","updated_at":"2015-08-21T00:29:04Z","body":"I don't have a chance to do a real technical review but I do want to talk about whether this actually makes sense here. Would we remove it from RB itself? I sort of feel like this is too specialized a component for here, but i historically don't like this component to begin with :P \r\n\r\nPractically I am a bit concerned about the possible churn moving this here might introduce only to just re-export in RB, I don;t know that it makes sense to remove _all_ generic things from there, but i'm open to others thoughts about it."}}