{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/37279947","id":37279947,"diff_hunk":"@@ -78,17 +79,42 @@\n         node[:crowbar_wall][:boot_device] = \"disk/by-id/#{bootdisk}\"\n       end\n     end\n+\n     # If we still have a /dev/disk/by-path name in boot_device here and the\n     # devices looks like a virtio device it is safer to use the base device\n     # name for bootdisk instead of the by-path name. According to:\n     #  https://www.mail-archive.com/systemd-devel@lists.freedesktop.org/msg20607.html\n     # the by-path names for virtio device are not stable and don't even exist\n-    # anymore with newer udev releases, e.g. on SLES12\n+    # anymore with newer udev releases\n+    # This is only needed for SLE_11_SP3 sleshammer. On SLE_12 based image \n+    # directory \"disk/by-path\" with virtio disks driver doesn't exist \n     if File.dirname(node[:crowbar_wall][:boot_device]) == \"disk/by-path\" and\n         File.basename(node[:crowbar_wall][:boot_device]) =~ /-virtio-/\n       Chef::Log.debug(\"#{node[:crowbar_wall][:boot_device]} appears to be a virtio device, falling back to simple device name #{dev}\")\n-      node[:crowbar_wall][:boot_device] = dev\n+       node[:crowbar_wall][:boot_device] = dev","path":"chef/cookbooks/provisioner/recipes/bootdisk.rb","position":74,"original_position":74,"commit_id":"60ad2ab789888f31992b67fb2580d20b1c3a870e","original_commit_id":"60ad2ab789888f31992b67fb2580d20b1c3a870e","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Style/IndentationConsistency: Inconsistent indentation detected.","created_at":"2015-08-18T09:28:22Z","updated_at":"2015-08-18T09:28:22Z","html_url":"https://github.com/crowbar/crowbar-core/pull/6#discussion_r37279947","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/37279947"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/6#discussion_r37279947"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/6","id":42677901,"html_url":"https://github.com/crowbar/crowbar-core/pull/6","diff_url":"https://github.com/crowbar/crowbar-core/pull/6.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/6.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/6","number":6,"state":"open","locked":false,"title":"Changes for SLES_12 based sleshammer","user":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"body":"This pull request adopt barclamp-provisioner for SLES_12 based images","created_at":"2015-08-18T09:28:19Z","updated_at":"2015-08-18T09:28:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb7201f78b22a45de9fb58ebfb338f9e661de9c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/6/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/6/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/6/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/60ad2ab789888f31992b67fb2580d20b1c3a870e","head":{"label":"mjura:sle12_sleshammer","ref":"sle12_sleshammer","sha":"60ad2ab789888f31992b67fb2580d20b1c3a870e","user":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"repo":{"id":40959763,"name":"crowbar-core","full_name":"mjura/crowbar-core","owner":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjura/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/mjura/crowbar-core","forks_url":"https://api.github.com/repos/mjura/crowbar-core/forks","keys_url":"https://api.github.com/repos/mjura/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjura/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjura/crowbar-core/teams","hooks_url":"https://api.github.com/repos/mjura/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/mjura/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/mjura/crowbar-core/events","assignees_url":"https://api.github.com/repos/mjura/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/mjura/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/mjura/crowbar-core/tags","blobs_url":"https://api.github.com/repos/mjura/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjura/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjura/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjura/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjura/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/mjura/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/mjura/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/mjura/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/mjura/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/mjura/crowbar-core/subscription","commits_url":"https://api.github.com/repos/mjura/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjura/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjura/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjura/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjura/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/mjura/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjura/crowbar-core/merges","archive_url":"https://api.github.com/repos/mjura/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjura/crowbar-core/downloads","issues_url":"https://api.github.com/repos/mjura/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/mjura/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/mjura/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/mjura/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjura/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/mjura/crowbar-core/releases{/id}","created_at":"2015-08-18T08:21:27Z","updated_at":"2015-08-18T08:21:32Z","pushed_at":"2015-08-18T09:26:53Z","git_url":"git://github.com/mjura/crowbar-core.git","ssh_url":"git@github.com:mjura/crowbar-core.git","clone_url":"https://github.com/mjura/crowbar-core.git","svn_url":"https://github.com/mjura/crowbar-core","homepage":null,"size":118331,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"3ee493198ead87d85ae4e462452828550b79ecb1","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","created_at":"2015-07-13T09:31:28Z","updated_at":"2015-07-13T12:35:48Z","pushed_at":"2015-08-18T09:28:19Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":118331,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/6"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/6"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/6"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/60ad2ab789888f31992b67fb2580d20b1c3a870e"}}}}