{"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/pulls/14","id":47598884,"html_url":"https://github.com/serilog/serilog-sinks-amazonkinesis/pull/14","diff_url":"https://github.com/serilog/serilog-sinks-amazonkinesis/pull/14.diff","patch_url":"https://github.com/serilog/serilog-sinks-amazonkinesis/pull/14.patch","issue_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/issues/14","number":14,"state":"open","locked":false,"title":"Fix IO exceptions being swallowed","user":{"login":"endofcake","id":5790049,"avatar_url":"https://avatars.githubusercontent.com/u/5790049?v=3","gravatar_id":"","url":"https://api.github.com/users/endofcake","html_url":"https://github.com/endofcake","followers_url":"https://api.github.com/users/endofcake/followers","following_url":"https://api.github.com/users/endofcake/following{/other_user}","gists_url":"https://api.github.com/users/endofcake/gists{/gist_id}","starred_url":"https://api.github.com/users/endofcake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endofcake/subscriptions","organizations_url":"https://api.github.com/users/endofcake/orgs","repos_url":"https://api.github.com/users/endofcake/repos","events_url":"https://api.github.com/users/endofcake/events{/privacy}","received_events_url":"https://api.github.com/users/endofcake/received_events","type":"User","site_admin":false},"body":"* Only check if the file is locked when 2 other conditions are satisfied.\r\nThis will reduce the number of IO exceptions dramatically.\r\n\r\n* Error code 32 is actually an IO exception which happens when a file is\r\nlocked by another process. As the code is now, this exception is being\r\ncaught and then it's being swallowed (no rethrows here).\r\nThis should be ==, not !=, see how @nblumhardt does it here:\r\nhttps://github.com/serilog/serilog-dnx-prerelease/blob/master/src/Serilog.Dnx.Prerelease/Sinks/RollingFile/RollingFileSink.cs#L150","created_at":"2015-10-13T22:48:23Z","updated_at":"2015-10-13T22:48:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/pulls/14/commits","review_comments_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/pulls/14/comments","review_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/issues/14/comments","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/statuses/b9cc87b8f3cd2e8454f041628a1229987af34bd2","head":{"label":"endofcake:ioexceptions","ref":"ioexceptions","sha":"b9cc87b8f3cd2e8454f041628a1229987af34bd2","user":{"login":"endofcake","id":5790049,"avatar_url":"https://avatars.githubusercontent.com/u/5790049?v=3","gravatar_id":"","url":"https://api.github.com/users/endofcake","html_url":"https://github.com/endofcake","followers_url":"https://api.github.com/users/endofcake/followers","following_url":"https://api.github.com/users/endofcake/following{/other_user}","gists_url":"https://api.github.com/users/endofcake/gists{/gist_id}","starred_url":"https://api.github.com/users/endofcake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endofcake/subscriptions","organizations_url":"https://api.github.com/users/endofcake/orgs","repos_url":"https://api.github.com/users/endofcake/repos","events_url":"https://api.github.com/users/endofcake/events{/privacy}","received_events_url":"https://api.github.com/users/endofcake/received_events","type":"User","site_admin":false},"repo":{"id":42221435,"name":"serilog-sinks-amazonkinesis","full_name":"endofcake/serilog-sinks-amazonkinesis","owner":{"login":"endofcake","id":5790049,"avatar_url":"https://avatars.githubusercontent.com/u/5790049?v=3","gravatar_id":"","url":"https://api.github.com/users/endofcake","html_url":"https://github.com/endofcake","followers_url":"https://api.github.com/users/endofcake/followers","following_url":"https://api.github.com/users/endofcake/following{/other_user}","gists_url":"https://api.github.com/users/endofcake/gists{/gist_id}","starred_url":"https://api.github.com/users/endofcake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endofcake/subscriptions","organizations_url":"https://api.github.com/users/endofcake/orgs","repos_url":"https://api.github.com/users/endofcake/repos","events_url":"https://api.github.com/users/endofcake/events{/privacy}","received_events_url":"https://api.github.com/users/endofcake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endofcake/serilog-sinks-amazonkinesis","description":"A Serilog sink that logs to Amazon Kinesis","fork":true,"url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis","forks_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/forks","keys_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/teams","hooks_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/hooks","issue_events_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/issues/events{/number}","events_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/events","assignees_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/assignees{/user}","branches_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/branches{/branch}","tags_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/tags","blobs_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/git/refs{/sha}","trees_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/statuses/{sha}","languages_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/languages","stargazers_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/stargazers","contributors_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/contributors","subscribers_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/subscribers","subscription_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/subscription","commits_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/commits{/sha}","git_commits_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/git/commits{/sha}","comments_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/comments{/number}","issue_comment_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/issues/comments{/number}","contents_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/contents/{+path}","compare_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/merges","archive_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/downloads","issues_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/issues{/number}","pulls_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/pulls{/number}","milestones_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/milestones{/number}","notifications_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/labels{/name}","releases_url":"https://api.github.com/repos/endofcake/serilog-sinks-amazonkinesis/releases{/id}","created_at":"2015-09-10T04:11:54Z","updated_at":"2015-09-10T04:11:54Z","pushed_at":"2015-10-13T22:47:22Z","git_url":"git://github.com/endofcake/serilog-sinks-amazonkinesis.git","ssh_url":"git@github.com:endofcake/serilog-sinks-amazonkinesis.git","clone_url":"https://github.com/endofcake/serilog-sinks-amazonkinesis.git","svn_url":"https://github.com/endofcake/serilog-sinks-amazonkinesis","homepage":null,"size":139,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serilog:master","ref":"master","sha":"8061797a1d7bb9fea9ad028dba57b909f14e8621","user":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"repo":{"id":34421207,"name":"serilog-sinks-amazonkinesis","full_name":"serilog/serilog-sinks-amazonkinesis","owner":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serilog/serilog-sinks-amazonkinesis","description":"A Serilog sink that logs to Amazon Kinesis","fork":false,"url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis","forks_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/forks","keys_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/teams","hooks_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/hooks","issue_events_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/issues/events{/number}","events_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/events","assignees_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/assignees{/user}","branches_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/branches{/branch}","tags_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/tags","blobs_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/git/refs{/sha}","trees_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/statuses/{sha}","languages_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/languages","stargazers_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/stargazers","contributors_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/contributors","subscribers_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/subscribers","subscription_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/subscription","commits_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/commits{/sha}","git_commits_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/git/commits{/sha}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/comments{/number}","issue_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/issues/comments{/number}","contents_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/contents/{+path}","compare_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/merges","archive_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/downloads","issues_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/issues{/number}","pulls_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/pulls{/number}","milestones_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/milestones{/number}","notifications_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/labels{/name}","releases_url":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/releases{/id}","created_at":"2015-04-22T23:11:45Z","updated_at":"2015-06-15T02:43:56Z","pushed_at":"2015-10-11T22:33:16Z","git_url":"git://github.com/serilog/serilog-sinks-amazonkinesis.git","ssh_url":"git@github.com:serilog/serilog-sinks-amazonkinesis.git","clone_url":"https://github.com/serilog/serilog-sinks-amazonkinesis.git","svn_url":"https://github.com/serilog/serilog-sinks-amazonkinesis","homepage":null,"size":304,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/pulls/14"},"html":{"href":"https://github.com/serilog/serilog-sinks-amazonkinesis/pull/14"},"issue":{"href":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/issues/14"},"comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/serilog/serilog-sinks-amazonkinesis/statuses/b9cc87b8f3cd2e8454f041628a1229987af34bd2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":20,"deletions":11,"changed_files":1}}