{"action":"reopened","number":1667,"pull_request":{"url":"https://api.github.com/repos/heroku/heroku/pulls/1667","id":40602995,"html_url":"https://github.com/heroku/heroku/pull/1667","diff_url":"https://github.com/heroku/heroku/pull/1667.diff","patch_url":"https://github.com/heroku/heroku/pull/1667.patch","issue_url":"https://api.github.com/repos/heroku/heroku/issues/1667","number":1667,"state":"open","locked":false,"title":"Fix spaces with default org","user":{"login":"ryanbrainard","id":966764,"avatar_url":"https://avatars.githubusercontent.com/u/966764?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanbrainard","html_url":"https://github.com/ryanbrainard","followers_url":"https://api.github.com/users/ryanbrainard/followers","following_url":"https://api.github.com/users/ryanbrainard/following{/other_user}","gists_url":"https://api.github.com/users/ryanbrainard/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbrainard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbrainard/subscriptions","organizations_url":"https://api.github.com/users/ryanbrainard/orgs","repos_url":"https://api.github.com/users/ryanbrainard/repos","events_url":"https://api.github.com/users/ryanbrainard/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbrainard/received_events","type":"User","site_admin":false},"body":"This fixes the new apps's spaces commands to work with the `HEROKU_ORGANIZATION` env to set default org. The changes are as follows:\r\n\r\n - Users can explicitly specify `--space` or `--org`, but not both.\r\n - If the `HEROKU_ORGANIZATION` is set, it is ignored when using `--space`. The reason being that `--org` overrides `HEROKU_ORGANIZATION`, so `--space` (which is in an org) should too. In the future we might want to do something fancy where we look up the org from the space to reconcile these two, but since space names are globally unique, there's probably little reason users would want that.\r\n - Added `shared_examples` tests with and without a default org for app space commands. \r\n\r\n/cc @geemus @markpundsack ","created_at":"2015-07-22T19:37:39Z","updated_at":"2015-07-22T21:49:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f321873425507cd3c9d3ff1949203cdbcf439f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/heroku/heroku/pulls/1667/commits","review_comments_url":"https://api.github.com/repos/heroku/heroku/pulls/1667/comments","review_comment_url":"https://api.github.com/repos/heroku/heroku/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heroku/heroku/issues/1667/comments","statuses_url":"https://api.github.com/repos/heroku/heroku/statuses/e2c0106c5a588ef79267439656bc6fe23aeb2371","head":{"label":"heroku:fix-spaces-with-default-org","ref":"fix-spaces-with-default-org","sha":"e2c0106c5a588ef79267439656bc6fe23aeb2371","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":153204,"name":"heroku","full_name":"heroku/heroku","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/heroku","description":"Heroku CLI","fork":false,"url":"https://api.github.com/repos/heroku/heroku","forks_url":"https://api.github.com/repos/heroku/heroku/forks","keys_url":"https://api.github.com/repos/heroku/heroku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/heroku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/heroku/teams","hooks_url":"https://api.github.com/repos/heroku/heroku/hooks","issue_events_url":"https://api.github.com/repos/heroku/heroku/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/heroku/events","assignees_url":"https://api.github.com/repos/heroku/heroku/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/heroku/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/heroku/tags","blobs_url":"https://api.github.com/repos/heroku/heroku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/heroku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/heroku/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/heroku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/heroku/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/heroku/languages","stargazers_url":"https://api.github.com/repos/heroku/heroku/stargazers","contributors_url":"https://api.github.com/repos/heroku/heroku/contributors","subscribers_url":"https://api.github.com/repos/heroku/heroku/subscribers","subscription_url":"https://api.github.com/repos/heroku/heroku/subscription","commits_url":"https://api.github.com/repos/heroku/heroku/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/heroku/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/heroku/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/heroku/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/heroku/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/heroku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/heroku/merges","archive_url":"https://api.github.com/repos/heroku/heroku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/heroku/downloads","issues_url":"https://api.github.com/repos/heroku/heroku/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/heroku/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/heroku/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/heroku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/heroku/labels{/name}","releases_url":"https://api.github.com/repos/heroku/heroku/releases{/id}","created_at":"2009-03-18T01:21:53Z","updated_at":"2015-07-21T11:04:28Z","pushed_at":"2015-07-22T19:37:40Z","git_url":"git://github.com/heroku/heroku.git","ssh_url":"git@github.com:heroku/heroku.git","clone_url":"https://github.com/heroku/heroku.git","svn_url":"https://github.com/heroku/heroku","homepage":"https://devcenter.heroku.com/articles/heroku-command","size":14453,"stargazers_count":1161,"watchers_count":1161,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":327,"mirror_url":null,"open_issues_count":245,"forks":327,"open_issues":245,"watchers":1161,"default_branch":"master"}},"base":{"label":"heroku:master","ref":"master","sha":"98b0217125f2741ea1befe574a481075cb0b06a2","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":153204,"name":"heroku","full_name":"heroku/heroku","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/heroku","description":"Heroku CLI","fork":false,"url":"https://api.github.com/repos/heroku/heroku","forks_url":"https://api.github.com/repos/heroku/heroku/forks","keys_url":"https://api.github.com/repos/heroku/heroku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/heroku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/heroku/teams","hooks_url":"https://api.github.com/repos/heroku/heroku/hooks","issue_events_url":"https://api.github.com/repos/heroku/heroku/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/heroku/events","assignees_url":"https://api.github.com/repos/heroku/heroku/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/heroku/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/heroku/tags","blobs_url":"https://api.github.com/repos/heroku/heroku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/heroku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/heroku/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/heroku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/heroku/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/heroku/languages","stargazers_url":"https://api.github.com/repos/heroku/heroku/stargazers","contributors_url":"https://api.github.com/repos/heroku/heroku/contributors","subscribers_url":"https://api.github.com/repos/heroku/heroku/subscribers","subscription_url":"https://api.github.com/repos/heroku/heroku/subscription","commits_url":"https://api.github.com/repos/heroku/heroku/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/heroku/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/heroku/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/heroku/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/heroku/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/heroku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/heroku/merges","archive_url":"https://api.github.com/repos/heroku/heroku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/heroku/downloads","issues_url":"https://api.github.com/repos/heroku/heroku/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/heroku/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/heroku/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/heroku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/heroku/labels{/name}","releases_url":"https://api.github.com/repos/heroku/heroku/releases{/id}","created_at":"2009-03-18T01:21:53Z","updated_at":"2015-07-21T11:04:28Z","pushed_at":"2015-07-22T19:37:40Z","git_url":"git://github.com/heroku/heroku.git","ssh_url":"git@github.com:heroku/heroku.git","clone_url":"https://github.com/heroku/heroku.git","svn_url":"https://github.com/heroku/heroku","homepage":"https://devcenter.heroku.com/articles/heroku-command","size":14453,"stargazers_count":1161,"watchers_count":1161,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":327,"mirror_url":null,"open_issues_count":245,"forks":327,"open_issues":245,"watchers":1161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heroku/heroku/pulls/1667"},"html":{"href":"https://github.com/heroku/heroku/pull/1667"},"issue":{"href":"https://api.github.com/repos/heroku/heroku/issues/1667"},"comments":{"href":"https://api.github.com/repos/heroku/heroku/issues/1667/comments"},"review_comments":{"href":"https://api.github.com/repos/heroku/heroku/pulls/1667/comments"},"review_comment":{"href":"https://api.github.com/repos/heroku/heroku/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heroku/heroku/pulls/1667/commits"},"statuses":{"href":"https://api.github.com/repos/heroku/heroku/statuses/e2c0106c5a588ef79267439656bc6fe23aeb2371"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"commits":2,"additions":130,"deletions":78,"changed_files":3}}