{"action":"closed","issue":{"url":"https://api.github.com/repos/atom/node-keytar/issues/13","labels_url":"https://api.github.com/repos/atom/node-keytar/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/atom/node-keytar/issues/13/comments","events_url":"https://api.github.com/repos/atom/node-keytar/issues/13/events","html_url":"https://github.com/atom/node-keytar/issues/13","id":44350064,"number":13,"title":"Use of deprecated GNOME keyring functions","user":{"login":"majcherek2048","id":8823470,"avatar_url":"https://avatars.githubusercontent.com/u/8823470?v=3","gravatar_id":"","url":"https://api.github.com/users/majcherek2048","html_url":"https://github.com/majcherek2048","followers_url":"https://api.github.com/users/majcherek2048/followers","following_url":"https://api.github.com/users/majcherek2048/following{/other_user}","gists_url":"https://api.github.com/users/majcherek2048/gists{/gist_id}","starred_url":"https://api.github.com/users/majcherek2048/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majcherek2048/subscriptions","organizations_url":"https://api.github.com/users/majcherek2048/orgs","repos_url":"https://api.github.com/users/majcherek2048/repos","events_url":"https://api.github.com/users/majcherek2048/events{/privacy}","received_events_url":"https://api.github.com/users/majcherek2048/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2014-09-29T20:13:22Z","updated_at":"2015-11-26T09:59:57Z","closed_at":"2015-11-26T09:59:57Z","body":"Hi there.\r\n\r\nGot this one while trying to build Atom.\r\nOS: ```Debian Jessie```\r\nAtom version: ```v0.132.0```\r\n\r\n```\r\n$ script/build \r\nNode: v0.10.29\r\nnpm: v1.4.20\r\nInstalling build modules...\r\nInstalling apm...\r\n../src/keytar_posix.cc: In function ‘bool keytar::AddPassword(const string&, const string&, const string&)’:\r\n../src/keytar_posix.cc:23:31: warning: ‘GnomeKeyringResult gnome_keyring_store_password_sync(const GnomeKeyringPasswordSchema*, const gchar*, const gchar*, const gchar*, ...)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:483): Use 'secret_password_store_sync' instead [-Wdeprecated-declarations]\r\n   GnomeKeyringResult result = gnome_keyring_store_password_sync(\r\n                               ^\r\n../src/keytar_posix.cc:30:11: warning: ‘GnomeKeyringResult gnome_keyring_store_password_sync(const GnomeKeyringPasswordSchema*, const gchar*, const gchar*, const gchar*, ...)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:483): Use 'secret_password_store_sync' instead [-Wdeprecated-declarations]\r\n       NULL);\r\n           ^\r\n../src/keytar_posix.cc: In function ‘bool keytar::GetPassword(const string&, const string&, std::string*)’:\r\n../src/keytar_posix.cc:38:31: warning: ‘GnomeKeyringResult gnome_keyring_find_password_sync(const GnomeKeyringPasswordSchema*, gchar**, ...)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:497): Use 'secret_password_lookup_sync' instead [-Wdeprecated-declarations]\r\n   GnomeKeyringResult result = gnome_keyring_find_password_sync(\r\n                               ^\r\n../src/keytar_posix.cc:43:11: warning: ‘GnomeKeyringResult gnome_keyring_find_password_sync(const GnomeKeyringPasswordSchema*, gchar**, ...)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:497): Use 'secret_password_lookup_sync' instead [-Wdeprecated-declarations]\r\n       NULL);\r\n           ^\r\n../src/keytar_posix.cc:49:3: warning: ‘void gnome_keyring_free_password(gchar*)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:513): Use 'secret_password_free' instead [-Wdeprecated-declarations]\r\n   gnome_keyring_free_password(raw_passwords);\r\n   ^\r\n../src/keytar_posix.cc:49:44: warning: ‘void gnome_keyring_free_password(gchar*)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:513): Use 'secret_password_free' instead [-Wdeprecated-declarations]\r\n   gnome_keyring_free_password(raw_passwords);\r\n                                            ^\r\n../src/keytar_posix.cc: In function ‘bool keytar::DeletePassword(const string&, const string&)’:\r\n../src/keytar_posix.cc:54:10: warning: ‘GnomeKeyringResult gnome_keyring_delete_password_sync(const GnomeKeyringPasswordSchema*, ...)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:509): Use 'secret_password_clear_sync' instead [-Wdeprecated-declarations]\r\n   return gnome_keyring_delete_password_sync(\r\n          ^\r\n../src/keytar_posix.cc:58:11: warning: ‘GnomeKeyringResult gnome_keyring_delete_password_sync(const GnomeKeyringPasswordSchema*, ...)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:509): Use 'secret_password_clear_sync' instead [-Wdeprecated-declarations]\r\n       NULL) == GNOME_KEYRING_RESULT_OK;\r\n           ^\r\n../src/keytar_posix.cc: In function ‘bool keytar::FindPassword(const string&, std::string*)’:\r\n../src/keytar_posix.cc:63:31: warning: ‘GnomeKeyringResult gnome_keyring_find_password_sync(const GnomeKeyringPasswordSchema*, gchar**, ...)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:497): Use 'secret_password_lookup_sync' instead [-Wdeprecated-declarations]\r\n   GnomeKeyringResult result = gnome_keyring_find_password_sync(\r\n                               ^\r\n../src/keytar_posix.cc:67:11: warning: ‘GnomeKeyringResult gnome_keyring_find_password_sync(const GnomeKeyringPasswordSchema*, gchar**, ...)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:497): Use 'secret_password_lookup_sync' instead [-Wdeprecated-declarations]\r\n       NULL);\r\n           ^\r\n../src/keytar_posix.cc:73:3: warning: ‘void gnome_keyring_free_password(gchar*)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:513): Use 'secret_password_free' instead [-Wdeprecated-declarations]\r\n   gnome_keyring_free_password(raw_passwords);\r\n   ^\r\n../src/keytar_posix.cc:73:44: warning: ‘void gnome_keyring_free_password(gchar*)’ is deprecated (declared at /usr/include/gnome-keyring-1/gnome-keyring.h:513): Use 'secret_password_free' instead [-Wdeprecated-declarations]\r\n   gnome_keyring_free_password(raw_passwords);\r\n```\r\n\r\nAfter that, the rest is fine.\r\nBuild is reported as successful, and Atom seems to be working just fine.\r\n\r\nProbably relevant information:\r\n```\r\n$ dpkg -l | grep -i \"libgnome-keyring\"\r\nii  libgnome-keyring-common                      3.12.0-1                        all          GNOME keyring services library - data files\r\nii  libgnome-keyring-dev                         3.12.0-1                        amd64        Development files for GNOME keyring service\r\nii  libgnome-keyring0:amd64                      3.12.0-1                        amd64        GNOME keyring services library\r\n```\r\n\r\nEDIT: Seems like gnome-keyring is completely deprecated and node-keytar should be using Libsecret instead."}}