{"action":"closed","number":26,"pull_request":{"url":"https://api.github.com/repos/golang/protobuf/pulls/26","id":34108773,"html_url":"https://github.com/golang/protobuf/pull/26","diff_url":"https://github.com/golang/protobuf/pull/26.diff","patch_url":"https://github.com/golang/protobuf/pull/26.patch","issue_url":"https://api.github.com/repos/golang/protobuf/issues/26","number":26,"state":"closed","locked":false,"title":"add bson note after json comment, \"xx, omitempty\"","user":{"login":"ishare","id":1309607,"avatar_url":"https://avatars.githubusercontent.com/u/1309607?v=3","gravatar_id":"","url":"https://api.github.com/users/ishare","html_url":"https://github.com/ishare","followers_url":"https://api.github.com/users/ishare/followers","following_url":"https://api.github.com/users/ishare/following{/other_user}","gists_url":"https://api.github.com/users/ishare/gists{/gist_id}","starred_url":"https://api.github.com/users/ishare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishare/subscriptions","organizations_url":"https://api.github.com/users/ishare/orgs","repos_url":"https://api.github.com/users/ishare/repos","events_url":"https://api.github.com/users/ishare/events{/privacy}","received_events_url":"https://api.github.com/users/ishare/received_events","type":"User","site_admin":false},"body":"bson is widely used in golang communicate with mongodb, for example protobuf escape _id to Xid, but in mongodb `_id` is the primary key, so it need to add bson comment for column definition. \r\nSo I suggest adding `bson` note for struct define, it benefit users using mongo, without any bad effect on others.","created_at":"2015-04-25T16:27:17Z","updated_at":"2015-04-25T20:59:20Z","closed_at":"2015-04-25T20:59:20Z","merged_at":null,"merge_commit_sha":"c0f38297f5060b79c7a99687566978db959c9601","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/golang/protobuf/pulls/26/commits","review_comments_url":"https://api.github.com/repos/golang/protobuf/pulls/26/comments","review_comment_url":"https://api.github.com/repos/golang/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/golang/protobuf/issues/26/comments","statuses_url":"https://api.github.com/repos/golang/protobuf/statuses/9f37944d719d55a06fb9b632c473c85225fa35cd","head":{"label":"ishare:patch-3","ref":"patch-3","sha":"9f37944d719d55a06fb9b632c473c85225fa35cd","user":{"login":"ishare","id":1309607,"avatar_url":"https://avatars.githubusercontent.com/u/1309607?v=3","gravatar_id":"","url":"https://api.github.com/users/ishare","html_url":"https://github.com/ishare","followers_url":"https://api.github.com/users/ishare/followers","following_url":"https://api.github.com/users/ishare/following{/other_user}","gists_url":"https://api.github.com/users/ishare/gists{/gist_id}","starred_url":"https://api.github.com/users/ishare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishare/subscriptions","organizations_url":"https://api.github.com/users/ishare/orgs","repos_url":"https://api.github.com/users/ishare/repos","events_url":"https://api.github.com/users/ishare/events{/privacy}","received_events_url":"https://api.github.com/users/ishare/received_events","type":"User","site_admin":false},"repo":{"id":33904950,"name":"protobuf","full_name":"ishare/protobuf","owner":{"login":"ishare","id":1309607,"avatar_url":"https://avatars.githubusercontent.com/u/1309607?v=3","gravatar_id":"","url":"https://api.github.com/users/ishare","html_url":"https://github.com/ishare","followers_url":"https://api.github.com/users/ishare/followers","following_url":"https://api.github.com/users/ishare/following{/other_user}","gists_url":"https://api.github.com/users/ishare/gists{/gist_id}","starred_url":"https://api.github.com/users/ishare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishare/subscriptions","organizations_url":"https://api.github.com/users/ishare/orgs","repos_url":"https://api.github.com/users/ishare/repos","events_url":"https://api.github.com/users/ishare/events{/privacy}","received_events_url":"https://api.github.com/users/ishare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ishare/protobuf","description":"Go support for Google's protocol buffers","fork":true,"url":"https://api.github.com/repos/ishare/protobuf","forks_url":"https://api.github.com/repos/ishare/protobuf/forks","keys_url":"https://api.github.com/repos/ishare/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ishare/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ishare/protobuf/teams","hooks_url":"https://api.github.com/repos/ishare/protobuf/hooks","issue_events_url":"https://api.github.com/repos/ishare/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/ishare/protobuf/events","assignees_url":"https://api.github.com/repos/ishare/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/ishare/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/ishare/protobuf/tags","blobs_url":"https://api.github.com/repos/ishare/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ishare/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ishare/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/ishare/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ishare/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/ishare/protobuf/languages","stargazers_url":"https://api.github.com/repos/ishare/protobuf/stargazers","contributors_url":"https://api.github.com/repos/ishare/protobuf/contributors","subscribers_url":"https://api.github.com/repos/ishare/protobuf/subscribers","subscription_url":"https://api.github.com/repos/ishare/protobuf/subscription","commits_url":"https://api.github.com/repos/ishare/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/ishare/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/ishare/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/ishare/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/ishare/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/ishare/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ishare/protobuf/merges","archive_url":"https://api.github.com/repos/ishare/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ishare/protobuf/downloads","issues_url":"https://api.github.com/repos/ishare/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/ishare/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/ishare/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/ishare/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ishare/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/ishare/protobuf/releases{/id}","created_at":"2015-04-14T01:57:41Z","updated_at":"2015-04-14T03:30:15Z","pushed_at":"2015-04-25T16:26:54Z","git_url":"git://github.com/ishare/protobuf.git","ssh_url":"git@github.com:ishare/protobuf.git","clone_url":"https://github.com/ishare/protobuf.git","svn_url":"https://github.com/ishare/protobuf","homepage":null,"size":638,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"golang:master","ref":"master","sha":"655cdfa588ea190e901bc5590e65d5621688847c","user":{"login":"golang","id":4314092,"avatar_url":"https://avatars.githubusercontent.com/u/4314092?v=3","gravatar_id":"","url":"https://api.github.com/users/golang","html_url":"https://github.com/golang","followers_url":"https://api.github.com/users/golang/followers","following_url":"https://api.github.com/users/golang/following{/other_user}","gists_url":"https://api.github.com/users/golang/gists{/gist_id}","starred_url":"https://api.github.com/users/golang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golang/subscriptions","organizations_url":"https://api.github.com/users/golang/orgs","repos_url":"https://api.github.com/users/golang/repos","events_url":"https://api.github.com/users/golang/events{/privacy}","received_events_url":"https://api.github.com/users/golang/received_events","type":"Organization","site_admin":false},"repo":{"id":27051771,"name":"protobuf","full_name":"golang/protobuf","owner":{"login":"golang","id":4314092,"avatar_url":"https://avatars.githubusercontent.com/u/4314092?v=3","gravatar_id":"","url":"https://api.github.com/users/golang","html_url":"https://github.com/golang","followers_url":"https://api.github.com/users/golang/followers","following_url":"https://api.github.com/users/golang/following{/other_user}","gists_url":"https://api.github.com/users/golang/gists{/gist_id}","starred_url":"https://api.github.com/users/golang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golang/subscriptions","organizations_url":"https://api.github.com/users/golang/orgs","repos_url":"https://api.github.com/users/golang/repos","events_url":"https://api.github.com/users/golang/events{/privacy}","received_events_url":"https://api.github.com/users/golang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golang/protobuf","description":"Go support for Google's protocol buffers","fork":false,"url":"https://api.github.com/repos/golang/protobuf","forks_url":"https://api.github.com/repos/golang/protobuf/forks","keys_url":"https://api.github.com/repos/golang/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golang/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golang/protobuf/teams","hooks_url":"https://api.github.com/repos/golang/protobuf/hooks","issue_events_url":"https://api.github.com/repos/golang/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/golang/protobuf/events","assignees_url":"https://api.github.com/repos/golang/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/golang/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/golang/protobuf/tags","blobs_url":"https://api.github.com/repos/golang/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golang/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golang/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/golang/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golang/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/golang/protobuf/languages","stargazers_url":"https://api.github.com/repos/golang/protobuf/stargazers","contributors_url":"https://api.github.com/repos/golang/protobuf/contributors","subscribers_url":"https://api.github.com/repos/golang/protobuf/subscribers","subscription_url":"https://api.github.com/repos/golang/protobuf/subscription","commits_url":"https://api.github.com/repos/golang/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/golang/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/golang/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/golang/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/golang/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/golang/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golang/protobuf/merges","archive_url":"https://api.github.com/repos/golang/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golang/protobuf/downloads","issues_url":"https://api.github.com/repos/golang/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/golang/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/golang/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/golang/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golang/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/golang/protobuf/releases{/id}","created_at":"2014-11-23T23:07:23Z","updated_at":"2015-04-22T12:48:12Z","pushed_at":"2015-04-25T16:27:17Z","git_url":"git://github.com/golang/protobuf.git","ssh_url":"git@github.com:golang/protobuf.git","clone_url":"https://github.com/golang/protobuf.git","svn_url":"https://github.com/golang/protobuf","homepage":null,"size":995,"stargazers_count":329,"watchers_count":329,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":5,"forks":43,"open_issues":5,"watchers":329,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/golang/protobuf/pulls/26"},"html":{"href":"https://github.com/golang/protobuf/pull/26"},"issue":{"href":"https://api.github.com/repos/golang/protobuf/issues/26"},"comments":{"href":"https://api.github.com/repos/golang/protobuf/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/golang/protobuf/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/golang/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/golang/protobuf/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/golang/protobuf/statuses/9f37944d719d55a06fb9b632c473c85225fa35cd"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}