{"action":"created","comment":{"url":"https://api.github.com/repos/mmottl/lacaml/pulls/comments/42931644","id":42931644,"diff_hunk":"@@ -158,6 +158,60 @@ let to_col_vecs mat =\n     for i = 2 to n do ar.(i - 1) <- col mat i done;\n     ar\n \n+let of_col_vecs_list = function\n+  | [] -> create 0 0","path":"lib/mat_SDCZ.ml","position":5,"original_position":5,"commit_id":"77094f135e9bb81c3844fcfc36f7546d51e94016","original_commit_id":"77094f135e9bb81c3844fcfc36f7546d51e94016","user":{"login":"Chris00","id":1255665,"avatar_url":"https://avatars.githubusercontent.com/u/1255665?v=3","gravatar_id":"","url":"https://api.github.com/users/Chris00","html_url":"https://github.com/Chris00","followers_url":"https://api.github.com/users/Chris00/followers","following_url":"https://api.github.com/users/Chris00/following{/other_user}","gists_url":"https://api.github.com/users/Chris00/gists{/gist_id}","starred_url":"https://api.github.com/users/Chris00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chris00/subscriptions","organizations_url":"https://api.github.com/users/Chris00/orgs","repos_url":"https://api.github.com/users/Chris00/repos","events_url":"https://api.github.com/users/Chris00/events{/privacy}","received_events_url":"https://api.github.com/users/Chris00/received_events","type":"User","site_admin":false},"body":"Please use `empty` (as in `of_col_vecs`).","created_at":"2015-10-24T07:48:41Z","updated_at":"2015-10-24T07:48:41Z","html_url":"https://github.com/mmottl/lacaml/pull/10#discussion_r42931644","pull_request_url":"https://api.github.com/repos/mmottl/lacaml/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/mmottl/lacaml/pulls/comments/42931644"},"html":{"href":"https://github.com/mmottl/lacaml/pull/10#discussion_r42931644"},"pull_request":{"href":"https://api.github.com/repos/mmottl/lacaml/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/mmottl/lacaml/pulls/10","id":48649241,"html_url":"https://github.com/mmottl/lacaml/pull/10","diff_url":"https://github.com/mmottl/lacaml/pull/10.diff","patch_url":"https://github.com/mmottl/lacaml/pull/10.patch","issue_url":"https://api.github.com/repos/mmottl/lacaml/issues/10","number":10,"state":"open","locked":false,"title":"Add mat of col lists","user":{"login":"rleonid","id":6570317,"avatar_url":"https://avatars.githubusercontent.com/u/6570317?v=3","gravatar_id":"","url":"https://api.github.com/users/rleonid","html_url":"https://github.com/rleonid","followers_url":"https://api.github.com/users/rleonid/followers","following_url":"https://api.github.com/users/rleonid/following{/other_user}","gists_url":"https://api.github.com/users/rleonid/gists{/gist_id}","starred_url":"https://api.github.com/users/rleonid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleonid/subscriptions","organizations_url":"https://api.github.com/users/rleonid/orgs","repos_url":"https://api.github.com/users/rleonid/repos","events_url":"https://api.github.com/users/rleonid/events{/privacy}","received_events_url":"https://api.github.com/users/rleonid/received_events","type":"User","site_admin":false},"body":"This address #2. Note that these methods fail like their array counterparts for matrices off odd sizes such as (0,1) or (1,0).","created_at":"2015-10-24T05:22:33Z","updated_at":"2015-10-24T07:48:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"001f2c279d18e943ee9f0371dc59893fef838c88","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mmottl/lacaml/pulls/10/commits","review_comments_url":"https://api.github.com/repos/mmottl/lacaml/pulls/10/comments","review_comment_url":"https://api.github.com/repos/mmottl/lacaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mmottl/lacaml/issues/10/comments","statuses_url":"https://api.github.com/repos/mmottl/lacaml/statuses/77094f135e9bb81c3844fcfc36f7546d51e94016","head":{"label":"rleonid:add_mat_of_col_lists","ref":"add_mat_of_col_lists","sha":"77094f135e9bb81c3844fcfc36f7546d51e94016","user":{"login":"rleonid","id":6570317,"avatar_url":"https://avatars.githubusercontent.com/u/6570317?v=3","gravatar_id":"","url":"https://api.github.com/users/rleonid","html_url":"https://github.com/rleonid","followers_url":"https://api.github.com/users/rleonid/followers","following_url":"https://api.github.com/users/rleonid/following{/other_user}","gists_url":"https://api.github.com/users/rleonid/gists{/gist_id}","starred_url":"https://api.github.com/users/rleonid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleonid/subscriptions","organizations_url":"https://api.github.com/users/rleonid/orgs","repos_url":"https://api.github.com/users/rleonid/repos","events_url":"https://api.github.com/users/rleonid/events{/privacy}","received_events_url":"https://api.github.com/users/rleonid/received_events","type":"User","site_admin":false},"repo":{"id":42277036,"name":"lacaml","full_name":"rleonid/lacaml","owner":{"login":"rleonid","id":6570317,"avatar_url":"https://avatars.githubusercontent.com/u/6570317?v=3","gravatar_id":"","url":"https://api.github.com/users/rleonid","html_url":"https://github.com/rleonid","followers_url":"https://api.github.com/users/rleonid/followers","following_url":"https://api.github.com/users/rleonid/following{/other_user}","gists_url":"https://api.github.com/users/rleonid/gists{/gist_id}","starred_url":"https://api.github.com/users/rleonid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleonid/subscriptions","organizations_url":"https://api.github.com/users/rleonid/orgs","repos_url":"https://api.github.com/users/rleonid/repos","events_url":"https://api.github.com/users/rleonid/events{/privacy}","received_events_url":"https://api.github.com/users/rleonid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rleonid/lacaml","description":"OCaml bindings for BLAS/LAPACK (high-performance linear algebra Fortran libraries)","fork":true,"url":"https://api.github.com/repos/rleonid/lacaml","forks_url":"https://api.github.com/repos/rleonid/lacaml/forks","keys_url":"https://api.github.com/repos/rleonid/lacaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rleonid/lacaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rleonid/lacaml/teams","hooks_url":"https://api.github.com/repos/rleonid/lacaml/hooks","issue_events_url":"https://api.github.com/repos/rleonid/lacaml/issues/events{/number}","events_url":"https://api.github.com/repos/rleonid/lacaml/events","assignees_url":"https://api.github.com/repos/rleonid/lacaml/assignees{/user}","branches_url":"https://api.github.com/repos/rleonid/lacaml/branches{/branch}","tags_url":"https://api.github.com/repos/rleonid/lacaml/tags","blobs_url":"https://api.github.com/repos/rleonid/lacaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rleonid/lacaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rleonid/lacaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/rleonid/lacaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rleonid/lacaml/statuses/{sha}","languages_url":"https://api.github.com/repos/rleonid/lacaml/languages","stargazers_url":"https://api.github.com/repos/rleonid/lacaml/stargazers","contributors_url":"https://api.github.com/repos/rleonid/lacaml/contributors","subscribers_url":"https://api.github.com/repos/rleonid/lacaml/subscribers","subscription_url":"https://api.github.com/repos/rleonid/lacaml/subscription","commits_url":"https://api.github.com/repos/rleonid/lacaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/rleonid/lacaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/rleonid/lacaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/rleonid/lacaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/rleonid/lacaml/contents/{+path}","compare_url":"https://api.github.com/repos/rleonid/lacaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rleonid/lacaml/merges","archive_url":"https://api.github.com/repos/rleonid/lacaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rleonid/lacaml/downloads","issues_url":"https://api.github.com/repos/rleonid/lacaml/issues{/number}","pulls_url":"https://api.github.com/repos/rleonid/lacaml/pulls{/number}","milestones_url":"https://api.github.com/repos/rleonid/lacaml/milestones{/number}","notifications_url":"https://api.github.com/repos/rleonid/lacaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rleonid/lacaml/labels{/name}","releases_url":"https://api.github.com/repos/rleonid/lacaml/releases{/id}","created_at":"2015-09-10T23:55:18Z","updated_at":"2015-09-10T23:55:19Z","pushed_at":"2015-10-24T05:22:03Z","git_url":"git://github.com/rleonid/lacaml.git","ssh_url":"git@github.com:rleonid/lacaml.git","clone_url":"https://github.com/rleonid/lacaml.git","svn_url":"https://github.com/rleonid/lacaml","homepage":null,"size":820,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mmottl:master","ref":"master","sha":"3e55c35d1717ccc278f99902209b483b23928dc6","user":{"login":"mmottl","id":1189131,"avatar_url":"https://avatars.githubusercontent.com/u/1189131?v=3","gravatar_id":"","url":"https://api.github.com/users/mmottl","html_url":"https://github.com/mmottl","followers_url":"https://api.github.com/users/mmottl/followers","following_url":"https://api.github.com/users/mmottl/following{/other_user}","gists_url":"https://api.github.com/users/mmottl/gists{/gist_id}","starred_url":"https://api.github.com/users/mmottl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmottl/subscriptions","organizations_url":"https://api.github.com/users/mmottl/orgs","repos_url":"https://api.github.com/users/mmottl/repos","events_url":"https://api.github.com/users/mmottl/events{/privacy}","received_events_url":"https://api.github.com/users/mmottl/received_events","type":"User","site_admin":false},"repo":{"id":21401121,"name":"lacaml","full_name":"mmottl/lacaml","owner":{"login":"mmottl","id":1189131,"avatar_url":"https://avatars.githubusercontent.com/u/1189131?v=3","gravatar_id":"","url":"https://api.github.com/users/mmottl","html_url":"https://github.com/mmottl","followers_url":"https://api.github.com/users/mmottl/followers","following_url":"https://api.github.com/users/mmottl/following{/other_user}","gists_url":"https://api.github.com/users/mmottl/gists{/gist_id}","starred_url":"https://api.github.com/users/mmottl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmottl/subscriptions","organizations_url":"https://api.github.com/users/mmottl/orgs","repos_url":"https://api.github.com/users/mmottl/repos","events_url":"https://api.github.com/users/mmottl/events{/privacy}","received_events_url":"https://api.github.com/users/mmottl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmottl/lacaml","description":"OCaml bindings for BLAS/LAPACK (high-performance linear algebra Fortran libraries)","fork":false,"url":"https://api.github.com/repos/mmottl/lacaml","forks_url":"https://api.github.com/repos/mmottl/lacaml/forks","keys_url":"https://api.github.com/repos/mmottl/lacaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmottl/lacaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmottl/lacaml/teams","hooks_url":"https://api.github.com/repos/mmottl/lacaml/hooks","issue_events_url":"https://api.github.com/repos/mmottl/lacaml/issues/events{/number}","events_url":"https://api.github.com/repos/mmottl/lacaml/events","assignees_url":"https://api.github.com/repos/mmottl/lacaml/assignees{/user}","branches_url":"https://api.github.com/repos/mmottl/lacaml/branches{/branch}","tags_url":"https://api.github.com/repos/mmottl/lacaml/tags","blobs_url":"https://api.github.com/repos/mmottl/lacaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmottl/lacaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmottl/lacaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmottl/lacaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmottl/lacaml/statuses/{sha}","languages_url":"https://api.github.com/repos/mmottl/lacaml/languages","stargazers_url":"https://api.github.com/repos/mmottl/lacaml/stargazers","contributors_url":"https://api.github.com/repos/mmottl/lacaml/contributors","subscribers_url":"https://api.github.com/repos/mmottl/lacaml/subscribers","subscription_url":"https://api.github.com/repos/mmottl/lacaml/subscription","commits_url":"https://api.github.com/repos/mmottl/lacaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmottl/lacaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmottl/lacaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmottl/lacaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmottl/lacaml/contents/{+path}","compare_url":"https://api.github.com/repos/mmottl/lacaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmottl/lacaml/merges","archive_url":"https://api.github.com/repos/mmottl/lacaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmottl/lacaml/downloads","issues_url":"https://api.github.com/repos/mmottl/lacaml/issues{/number}","pulls_url":"https://api.github.com/repos/mmottl/lacaml/pulls{/number}","milestones_url":"https://api.github.com/repos/mmottl/lacaml/milestones{/number}","notifications_url":"https://api.github.com/repos/mmottl/lacaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmottl/lacaml/labels{/name}","releases_url":"https://api.github.com/repos/mmottl/lacaml/releases{/id}","created_at":"2014-07-01T20:13:59Z","updated_at":"2015-10-03T17:50:00Z","pushed_at":"2015-10-24T05:22:33Z","git_url":"git://github.com/mmottl/lacaml.git","ssh_url":"git@github.com:mmottl/lacaml.git","clone_url":"https://github.com/mmottl/lacaml.git","svn_url":"https://github.com/mmottl/lacaml","homepage":null,"size":1066,"stargazers_count":27,"watchers_count":27,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mmottl/lacaml/pulls/10"},"html":{"href":"https://github.com/mmottl/lacaml/pull/10"},"issue":{"href":"https://api.github.com/repos/mmottl/lacaml/issues/10"},"comments":{"href":"https://api.github.com/repos/mmottl/lacaml/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/mmottl/lacaml/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/mmottl/lacaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mmottl/lacaml/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/mmottl/lacaml/statuses/77094f135e9bb81c3844fcfc36f7546d51e94016"}}}}