{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/47878337","id":47878337,"diff_hunk":"@@ -1,22 +1,41 @@\n+<!-- https://www.playframework.com/documentation/latest/SettingsLogger -->\n <configuration>\n \n   <conversionRule conversionWord=\"coloredLevel\" converterClass=\"play.api.libs.logback.ColoredLevel\" />\n \n+  <appender name=\"FILE\" class=\"ch.qos.logback.core.FileAppender\">\n+     <file>${application.home}/logs/application.log</file>","path":"templates/play-java-intro/conf/logback.xml","position":7,"original_position":7,"commit_id":"56a6e51ddbb7697a57838ed875576755763fea4c","original_commit_id":"56a6e51ddbb7697a57838ed875576755763fea4c","user":{"login":"benmccann","id":322311,"avatar_url":"https://avatars.githubusercontent.com/u/322311?v=3","gravatar_id":"","url":"https://api.github.com/users/benmccann","html_url":"https://github.com/benmccann","followers_url":"https://api.github.com/users/benmccann/followers","following_url":"https://api.github.com/users/benmccann/following{/other_user}","gists_url":"https://api.github.com/users/benmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/benmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmccann/subscriptions","organizations_url":"https://api.github.com/users/benmccann/orgs","repos_url":"https://api.github.com/users/benmccann/repos","events_url":"https://api.github.com/users/benmccann/events{/privacy}","received_events_url":"https://api.github.com/users/benmccann/received_events","type":"User","site_admin":false},"body":"I've always found it more annoying than useful, but I'm curious what others feel. Maybe a good compromised would be to add it commented out, so that folks who want it can easily enable it?","created_at":"2015-12-17T08:02:27Z","updated_at":"2015-12-17T08:02:27Z","html_url":"https://github.com/playframework/playframework/pull/5391#discussion_r47878337","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/5391","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/47878337"},"html":{"href":"https://github.com/playframework/playframework/pull/5391#discussion_r47878337"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5391"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/5391","id":53619366,"html_url":"https://github.com/playframework/playframework/pull/5391","diff_url":"https://github.com/playframework/playframework/pull/5391.diff","patch_url":"https://github.com/playframework/playframework/pull/5391.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/5391","number":5391,"state":"open","locked":false,"title":"Configure templates with default logback.xml template","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"body":"The documentation points to a logback.xml configuration that uses an ASYNCFILE / ASYNCSTDOUT appender, but the tempates use straight stdout and no file.  This is confusing -- they should all start from the same place, and there's no reason (that I can tell) that you'd want to remove file logging.\r\n\r\nhttps://www.playframework.com/documentation/2.4.x/SettingsLogger#Default-configuration","created_at":"2015-12-14T20:46:32Z","updated_at":"2015-12-17T08:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c8dabb3eea717c5e4dfbb2029eed326259f9347","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/5391/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/5391/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/5391/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/56a6e51ddbb7697a57838ed875576755763fea4c","head":{"label":"wsargent:better-logback-templates","ref":"better-logback-templates","sha":"56a6e51ddbb7697a57838ed875576755763fea4c","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"repo":{"id":11010009,"name":"playframework","full_name":"wsargent/playframework","owner":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wsargent/playframework","description":"Play framework 2.x","fork":true,"url":"https://api.github.com/repos/wsargent/playframework","forks_url":"https://api.github.com/repos/wsargent/playframework/forks","keys_url":"https://api.github.com/repos/wsargent/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wsargent/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wsargent/playframework/teams","hooks_url":"https://api.github.com/repos/wsargent/playframework/hooks","issue_events_url":"https://api.github.com/repos/wsargent/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/wsargent/playframework/events","assignees_url":"https://api.github.com/repos/wsargent/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/wsargent/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/wsargent/playframework/tags","blobs_url":"https://api.github.com/repos/wsargent/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wsargent/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wsargent/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wsargent/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wsargent/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/wsargent/playframework/languages","stargazers_url":"https://api.github.com/repos/wsargent/playframework/stargazers","contributors_url":"https://api.github.com/repos/wsargent/playframework/contributors","subscribers_url":"https://api.github.com/repos/wsargent/playframework/subscribers","subscription_url":"https://api.github.com/repos/wsargent/playframework/subscription","commits_url":"https://api.github.com/repos/wsargent/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wsargent/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wsargent/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wsargent/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wsargent/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/wsargent/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wsargent/playframework/merges","archive_url":"https://api.github.com/repos/wsargent/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wsargent/playframework/downloads","issues_url":"https://api.github.com/repos/wsargent/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/wsargent/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/wsargent/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/wsargent/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wsargent/playframework/labels{/name}","releases_url":"https://api.github.com/repos/wsargent/playframework/releases{/id}","created_at":"2013-06-27T22:58:23Z","updated_at":"2015-04-15T18:06:45Z","pushed_at":"2015-12-16T17:53:40Z","git_url":"git://github.com/wsargent/playframework.git","ssh_url":"git@github.com:wsargent/playframework.git","clone_url":"https://github.com/wsargent/playframework.git","svn_url":"https://github.com/wsargent/playframework","homepage":"http://www.playframework.org/","size":77766,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"879597660cbdb7cfb6609d45b8024650df856c5d","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","created_at":"2011-09-07T09:24:08Z","updated_at":"2015-12-17T07:40:13Z","pushed_at":"2015-12-17T07:51:41Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":84061,"stargazers_count":7195,"watchers_count":7195,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2546,"mirror_url":null,"open_issues_count":326,"forks":2546,"open_issues":326,"watchers":7195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5391"},"html":{"href":"https://github.com/playframework/playframework/pull/5391"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/5391"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/5391/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5391/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/5391/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/56a6e51ddbb7697a57838ed875576755763fea4c"}}}}