{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/32209027","id":32209027,"diff_hunk":"@@ -0,0 +1,116 @@\n+<?php\n+\n+class UnconvertedInfoboxesPage extends PageQueryPage {\n+\tconst LIMIT = 1000;\n+\n+\tfunction __construct( $name = 'UnconvertedInfoboxes' ) {\n+\t\tparent::__construct( $name );\n+\t}\n+\n+\tpublic function isListed() {\n+\t\treturn false;\n+\t}\n+\n+\tpublic function sortDescending() {\n+\t\treturn true;\n+\t}\n+\n+\tpublic function isExpensive() {\n+\t\treturn true;\n+\t}\n+\n+\tpublic function doQuery( $offset = false, $limit = self::LIMIT ) {\n+\t\treturn $this->fetchFromCache( $limit, $offset );\n+\t}\n+\n+\tpublic function recache( $limit = false, $ignoreErrors = true ) {\n+\t\t$dbw = wfGetDB( DB_MASTER );\n+\n+\t\t/**\n+\t\t * 1. Get the new data first\n+\t\t */\n+\t\t$nonportableTemplates = $this->reallyDoQuery();\n+\t\t$dbw->begin();\n+\n+\t\t/**\n+\t\t * 2. Delete the existing records\n+\t\t */\n+\t\t( new WikiaSQL() )\n+\t\t\t->DELETE( 'querycache' )\n+\t\t\t->WHERE( 'qc_type' )->EQUAL_TO( $this->getName() )\n+\t\t\t->run( $dbw );\n+\n+\t\t/**\n+\t\t * 3. Insert the new records if the $nonportableTemplates array is not empty\n+\t\t */\n+\t\t$num = 0;\n+\t\tif ( !empty( $nonportableTemplates ) ) {\n+\n+\t\t\t( new WikiaSQL() )\n+\t\t\t\t->INSERT()->INTO( 'querycache', [\n+\t\t\t\t\t'qc_type',\n+\t\t\t\t\t'qc_value',\n+\t\t\t\t\t'qc_namespace',\n+\t\t\t\t\t'qc_title'\n+\t\t\t\t] )\n+\t\t\t\t->VALUES( $nonportableTemplates )\n+\t\t\t\t->run( $dbw );\n+\n+\t\t\t$num = $dbw->affectedRows();\n+\t\t\tif ( $num === 0 ) {\n+\t\t\t\t$dbw->rollback();\n+\t\t\t\t$num = false;\n+\t\t\t} else {\n+\t\t\t\t$dbw->commit();\n+\t\t\t}\n+\t\t}\n+\n+\t\treturn $num;\n+\t}\n+\n+\tpublic function reallyDoQuery( $limit = false, $offset = false ) {\n+\t\t$dbr = wfGetDB( DB_SLAVE, [ $this->getName(), __METHOD__, 'vslow' ] );\n+\n+\t\t$nonportableTemplates = ( new WikiaSQL() )\n+\t\t\t->SELECT( 'page_title as title' )\n+\t\t\t->FROM( 'page' )\n+\t\t\t->WHERE( 'page_namespace' )->EQUAL_TO( NS_TEMPLATE )\n+\t\t\t->runLoop( $dbr, function( &$nonportableTemplates, $row ) {\n+\t\t\t\t$title = Title::newFromText( $row->title, NS_TEMPLATE );\n+\n+\t\t\t\tif ( $title !== null && self::isTitleWithNonportableInfobox( $title ) ) {\n+\t\t\t\t\t$links = $title->getIndirectLinks();\n+\t\t\t\t\t$nonportableTemplates[] = [\n+\t\t\t\t\t\t$this->getName(),\n+\t\t\t\t\t\tcount( $links ),\n+\t\t\t\t\t\tNS_TEMPLATE,\n+\t\t\t\t\t\t$row->title,\n+\t\t\t\t\t];\n+\t\t\t\t}\n+\t\t\t} );\n+\n+\t\treturn $nonportableTemplates;\n+\t}\n+\n+\tpublic static function isTitleWithNonportableInfobox( Title $title ) {\n+\t\t$content = ( new WikiPage( $title ) )->getText();\n+\n+\t\t$titleRegEx = '/infobox/i';\n+\t\t$titleRegExMatch = preg_match( $titleRegEx, $title->getText() );","path":"extensions/wikia/Insights/specials/UnconvertedInfoboxesPage.class.php","position":99,"original_position":99,"commit_id":"b5d0f25caa1a3a5ab4412dc171c83d9c3a84ce5a","original_commit_id":"b5d0f25caa1a3a5ab4412dc171c83d9c3a84ce5a","user":{"login":"Grunny","id":230630,"avatar_url":"https://avatars.githubusercontent.com/u/230630?v=3","gravatar_id":"","url":"https://api.github.com/users/Grunny","html_url":"https://github.com/Grunny","followers_url":"https://api.github.com/users/Grunny/followers","following_url":"https://api.github.com/users/Grunny/following{/other_user}","gists_url":"https://api.github.com/users/Grunny/gists{/gist_id}","starred_url":"https://api.github.com/users/Grunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grunny/subscriptions","organizations_url":"https://api.github.com/users/Grunny/orgs","repos_url":"https://api.github.com/users/Grunny/repos","events_url":"https://api.github.com/users/Grunny/events{/privacy}","received_events_url":"https://api.github.com/users/Grunny/received_events","type":"User","site_admin":false},"body":"No need for a regex here, `stripos` would do the job.","created_at":"2015-06-11T10:45:55Z","updated_at":"2015-06-11T10:45:55Z","html_url":"https://github.com/Wikia/app/pull/7479#discussion_r32209027","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/7479","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/32209027"},"html":{"href":"https://github.com/Wikia/app/pull/7479#discussion_r32209027"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/7479"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/7479","id":37443559,"html_url":"https://github.com/Wikia/app/pull/7479","diff_url":"https://github.com/Wikia/app/pull/7479.diff","patch_url":"https://github.com/Wikia/app/pull/7479.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/7479","number":7479,"state":"open","locked":false,"title":"CE-1720 Non-portable infoboxes Insights list","user":{"login":"adamkarminski","id":5011775,"avatar_url":"https://avatars.githubusercontent.com/u/5011775?v=3","gravatar_id":"","url":"https://api.github.com/users/adamkarminski","html_url":"https://github.com/adamkarminski","followers_url":"https://api.github.com/users/adamkarminski/followers","following_url":"https://api.github.com/users/adamkarminski/following{/other_user}","gists_url":"https://api.github.com/users/adamkarminski/gists{/gist_id}","starred_url":"https://api.github.com/users/adamkarminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamkarminski/subscriptions","organizations_url":"https://api.github.com/users/adamkarminski/orgs","repos_url":"https://api.github.com/users/adamkarminski/repos","events_url":"https://api.github.com/users/adamkarminski/events{/privacy}","received_events_url":"https://api.github.com/users/adamkarminski/received_events","type":"User","site_admin":false},"body":"Hello @Wikia/community-engineering !\r\n\r\nThis PR brings a new Insights list of non-portable infoboxes to life. It includes:\r\n\r\n* A limited version of a `QueryPage` subclass - `UnconvertedInfoboxesPage.class.php` - that is not listed on `Special:SpecialPages`. It handles recognizing the non-portable infoboxes in the `isTitleWithNonportableInfobox()` method.\r\n* An `InsightsQuerypageModel` subclass that is responsible for creating a nice list with an amount of articles linking to the templates.\r\n* Transfering a method that gets articles linking to a given page from `MoveNotice.php` to a new trait - `TitleTrait`. This allows using in different contexts directly from a Title object.\r\n* Minor tweaks to Insights\r\n\r\n**IMPORTANT! The wording is still in progress from the PO side so please skip it when reviewing.** :)\r\n\r\nHave fun!","created_at":"2015-06-11T09:18:54Z","updated_at":"2015-06-11T10:45:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"589c5d6217a1da7b1eebd362c48ced4433c040e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/7479/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/7479/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/7479/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/b5d0f25caa1a3a5ab4412dc171c83d9c3a84ce5a","head":{"label":"Wikia:CE-1720-non-portable-infoboxes","ref":"CE-1720-non-portable-infoboxes","sha":"b5d0f25caa1a3a5ab4412dc171c83d9c3a84ce5a","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-06-01T12:38:38Z","pushed_at":"2015-06-11T10:39:07Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1375210,"stargazers_count":79,"watchers_count":79,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":81,"forks":56,"open_issues":81,"watchers":79,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"3b1f7f8c98c7cfe311d69c988a13e17ec035371e","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-06-01T12:38:38Z","pushed_at":"2015-06-11T10:39:07Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1375210,"stargazers_count":79,"watchers_count":79,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":81,"forks":56,"open_issues":81,"watchers":79,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/7479"},"html":{"href":"https://github.com/Wikia/app/pull/7479"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/7479"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/7479/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/7479/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/7479/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/b5d0f25caa1a3a5ab4412dc171c83d9c3a84ce5a"}}}}