{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/23076661","id":23076661,"diff_hunk":"@@ -7,76 +5,32 @@ class Sqlmap < Formula\n   head \"https://github.com/sqlmapproject/sqlmap.git\"\n   revision 1\n \n-  option \"with-mysql\", \"Install with support for direct connection to MySQL\"\n-  option \"with-postgresql\", \"Install with support for direct connection to PostgreSQL\"\n-  option \"with-unixodbc\", \"Install with ODBC driver\"\n-\n-  depends_on :python if MacOS.version <= :snow_leopard\n-  depends_on \"mysql\" => :optional\n-  depends_on \"postgresql\" => :optional\n-  depends_on \"unixodbc\" => :optional\n-\n-  resource \"ibm-db\" do\n-    url \"https://pypi.python.org/packages/source/i/ibm-db-sa-py3/ibm-db-sa-py3-0.3.0-1.tar.gz\"\n-    sha1 \"a48bc74ea0aafba5c56c6981db5213a23c55a33c\"\n-  end\n-\n-  resource \"impacket\" do\n-    url \"https://pypi.python.org/packages/source/i/impacket/impacket-0.9.11.tar.gz\"\n-    sha1 \"c78855be24f7730182c7914a64b9895f8b244ea2\"\n-  end\n-\n-  resource \"mysql-python\" do\n-    url \"https://pypi.python.org/packages/source/M/MySQL-python/MySQL-python-1.2.4.zip\"\n-    sha1 \"9af66e09713a79a08a312a7da87f0f0dccfc0a91\"\n-  end\n-\n-  resource \"ntlm\" do\n-    url \"https://pypi.python.org/packages/source/p/python-ntlm/python-ntlm-1.0.1.tar.gz\"\n-    sha1 \"91644247682f9fe128ce63496cf77b53605f085d\"\n-  end\n-\n-  resource \"pyodbc\" do\n-    url \"http://pyodbc.googlecode.com/files/pyodbc-3.0.7.zip\"\n-    sha1 \"88cb519411116012402aa0a0d5d7484949ddd99c\"\n-  end\n-\n-  resource \"psycopg2\" do\n-    url \"https://pypi.python.org/packages/source/p/psycopg2/psycopg2-2.5.2.tar.gz\"\n-    sha1 \"96d071f8e4faa07810976640078742b0a944cd13\"\n-  end\n-\n-  resource \"pysqlite\" do\n-    url \"https://pypi.python.org/packages/source/p/pysqlite/pysqlite-2.6.3.tar.gz\"\n-    sha1 \"b1eed16107232aebec1826b671c99a76e26afa7b\"\n-  end\n-\n   def install\n-    ENV[\"PYTHONPATH\"] = lib+\"python2.7/site-packages\"\n-    ENV.prepend_create_path \"PYTHONPATH\", libexec+\"lib/python2.7/site-packages\"\n-    install_args = [ \"setup.py\", \"install\", \"--prefix=#{libexec}\" ]\n-\n-    res = %w{ibm-db impacket ntlm pysqlite}\n-    res << \"mysql-python\" if build.with? \"mysql\"\n-    res << \"psycopg2\" if build.with? \"postgresql\"\n-    res << \"pyodbc\" if build.with? \"unixodbc\"\n+    libexec.install Dir[\"*\"]\n \n-    res.each do |r|\n-      resource(r).stage { system \"python\", *install_args }\n-    end\n+    bin.install_symlink libexec/\"sqlmap.py\"","path":"Library/Formula/sqlmap.rb","position":68,"original_position":68,"commit_id":"0aa316871ce6b36c1e36b0ed6de676eb30fe718c","original_commit_id":"0aa316871ce6b36c1e36b0ed6de676eb30fe718c","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"Should we maybe just name the original symlink `sqlmap`?","created_at":"2015-01-16T12:03:54Z","updated_at":"2015-01-16T12:03:54Z","html_url":"https://github.com/Homebrew/homebrew/pull/35921#discussion_r23076661","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/35921","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/23076661"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/35921#discussion_r23076661"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/35921"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/35921","id":27471326,"html_url":"https://github.com/Homebrew/homebrew/pull/35921","diff_url":"https://github.com/Homebrew/homebrew/pull/35921.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/35921.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/35921","number":35921,"state":"open","locked":false,"title":"sqlmap: modernize and remove outdated dependencies","user":{"login":"youtux","id":778703,"avatar_url":"https://avatars.githubusercontent.com/u/778703?v=3","gravatar_id":"","url":"https://api.github.com/users/youtux","html_url":"https://github.com/youtux","followers_url":"https://api.github.com/users/youtux/followers","following_url":"https://api.github.com/users/youtux/following{/other_user}","gists_url":"https://api.github.com/users/youtux/gists{/gist_id}","starred_url":"https://api.github.com/users/youtux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtux/subscriptions","organizations_url":"https://api.github.com/users/youtux/orgs","repos_url":"https://api.github.com/users/youtux/repos","events_url":"https://api.github.com/users/youtux/events{/privacy}","received_events_url":"https://api.github.com/users/youtux/received_events","type":"User","site_admin":false},"body":"I've rewritten the formula, since all the dependencies are not needed anymore (they are included in the repository). Furthermore sqlmap developers claim that it's compatible with python 2.6 and 2.7, so there's no need of the python dependency I think.\r\n\r\nShould I include a caveat that recommend the user to install sqlmap with the `--HEAD` switch? Because this is the preferred way according to the developers, and sqlmap 0.9 is pretty outdated (April 2011) and lacks a lot of features.","created_at":"2015-01-15T23:15:13Z","updated_at":"2015-01-16T12:03:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a19d41d46566dcf5c62ae151e2f5e53e0edc89a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/35921/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/35921/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/35921/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/0aa316871ce6b36c1e36b0ed6de676eb30fe718c","head":{"label":"youtux:sqlmap-refactor","ref":"sqlmap-refactor","sha":"0aa316871ce6b36c1e36b0ed6de676eb30fe718c","user":{"login":"youtux","id":778703,"avatar_url":"https://avatars.githubusercontent.com/u/778703?v=3","gravatar_id":"","url":"https://api.github.com/users/youtux","html_url":"https://github.com/youtux","followers_url":"https://api.github.com/users/youtux/followers","following_url":"https://api.github.com/users/youtux/following{/other_user}","gists_url":"https://api.github.com/users/youtux/gists{/gist_id}","starred_url":"https://api.github.com/users/youtux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtux/subscriptions","organizations_url":"https://api.github.com/users/youtux/orgs","repos_url":"https://api.github.com/users/youtux/repos","events_url":"https://api.github.com/users/youtux/events{/privacy}","received_events_url":"https://api.github.com/users/youtux/received_events","type":"User","site_admin":false},"repo":{"id":29011565,"name":"homebrew","full_name":"youtux/homebrew","owner":{"login":"youtux","id":778703,"avatar_url":"https://avatars.githubusercontent.com/u/778703?v=3","gravatar_id":"","url":"https://api.github.com/users/youtux","html_url":"https://github.com/youtux","followers_url":"https://api.github.com/users/youtux/followers","following_url":"https://api.github.com/users/youtux/following{/other_user}","gists_url":"https://api.github.com/users/youtux/gists{/gist_id}","starred_url":"https://api.github.com/users/youtux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtux/subscriptions","organizations_url":"https://api.github.com/users/youtux/orgs","repos_url":"https://api.github.com/users/youtux/repos","events_url":"https://api.github.com/users/youtux/events{/privacy}","received_events_url":"https://api.github.com/users/youtux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/youtux/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/youtux/homebrew","forks_url":"https://api.github.com/repos/youtux/homebrew/forks","keys_url":"https://api.github.com/repos/youtux/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtux/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtux/homebrew/teams","hooks_url":"https://api.github.com/repos/youtux/homebrew/hooks","issue_events_url":"https://api.github.com/repos/youtux/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/youtux/homebrew/events","assignees_url":"https://api.github.com/repos/youtux/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/youtux/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/youtux/homebrew/tags","blobs_url":"https://api.github.com/repos/youtux/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtux/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtux/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtux/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtux/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/youtux/homebrew/languages","stargazers_url":"https://api.github.com/repos/youtux/homebrew/stargazers","contributors_url":"https://api.github.com/repos/youtux/homebrew/contributors","subscribers_url":"https://api.github.com/repos/youtux/homebrew/subscribers","subscription_url":"https://api.github.com/repos/youtux/homebrew/subscription","commits_url":"https://api.github.com/repos/youtux/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtux/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtux/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtux/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/youtux/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/youtux/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtux/homebrew/merges","archive_url":"https://api.github.com/repos/youtux/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtux/homebrew/downloads","issues_url":"https://api.github.com/repos/youtux/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/youtux/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/youtux/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/youtux/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtux/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/youtux/homebrew/releases{/id}","created_at":"2015-01-09T10:17:42Z","updated_at":"2015-01-15T22:30:05Z","pushed_at":"2015-01-16T11:22:03Z","git_url":"git://github.com/youtux/homebrew.git","ssh_url":"git@github.com:youtux/homebrew.git","clone_url":"https://github.com/youtux/homebrew.git","svn_url":"https://github.com/youtux/homebrew","homepage":"http://brew.sh","size":53492,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"acf1cefd2bdf14d16c8cec9d85336991dc52f8aa","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":"The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments/{number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2015-01-16T11:12:41Z","pushed_at":"2015-01-16T08:50:06Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1155959,"stargazers_count":21029,"watchers_count":21029,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":10493,"mirror_url":null,"open_issues_count":278,"forks":10493,"open_issues":278,"watchers":21029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/35921"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/35921"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/35921"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/35921/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/35921/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/35921/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/0aa316871ce6b36c1e36b0ed6de676eb30fe718c"}}}}