{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments/46876024","id":46876024,"diff_hunk":"@@ -39,5 +39,34 @@ private static ICollection<string> GetAddresses(IConfiguration configuration)\n \n             return addresses;\n         }\n+\n+        private static int GetThreadCount(IConfiguration configuration)\n+        {\n+            var threadCountString = configuration[\"server.threadCount\"];\n+\n+            int threadCount;\n+            if (string.IsNullOrEmpty(threadCountString) || !int.TryParse(threadCountString, out threadCount))","path":"src/Microsoft.AspNet.Server.Kestrel/KestrelServerInformation.cs","position":23,"original_position":23,"commit_id":"bfad32f22321117e6044f3a666a935ab9adc60b2","original_commit_id":"bfad32f22321117e6044f3a666a935ab9adc60b2","user":{"login":"khellang","id":582487,"avatar_url":"https://avatars.githubusercontent.com/u/582487?v=3","gravatar_id":"","url":"https://api.github.com/users/khellang","html_url":"https://github.com/khellang","followers_url":"https://api.github.com/users/khellang/followers","following_url":"https://api.github.com/users/khellang/following{/other_user}","gists_url":"https://api.github.com/users/khellang/gists{/gist_id}","starred_url":"https://api.github.com/users/khellang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khellang/subscriptions","organizations_url":"https://api.github.com/users/khellang/orgs","repos_url":"https://api.github.com/users/khellang/repos","events_url":"https://api.github.com/users/khellang/events{/privacy}","received_events_url":"https://api.github.com/users/khellang/received_events","type":"User","site_admin":false},"body":"What if I move the check into the ThreadCount setter? That way it would ensure that the value is always valid?","created_at":"2015-12-07T20:57:01Z","updated_at":"2015-12-07T20:57:01Z","html_url":"https://github.com/aspnet/KestrelHttpServer/pull/457#discussion_r46876024","pull_request_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/457","_links":{"self":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments/46876024"},"html":{"href":"https://github.com/aspnet/KestrelHttpServer/pull/457#discussion_r46876024"},"pull_request":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/457","id":52846525,"html_url":"https://github.com/aspnet/KestrelHttpServer/pull/457","diff_url":"https://github.com/aspnet/KestrelHttpServer/pull/457.diff","patch_url":"https://github.com/aspnet/KestrelHttpServer/pull/457.patch","issue_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/457","number":457,"state":"open","locked":false,"title":"Configurable thread count","user":{"login":"khellang","id":582487,"avatar_url":"https://avatars.githubusercontent.com/u/582487?v=3","gravatar_id":"","url":"https://api.github.com/users/khellang","html_url":"https://github.com/khellang","followers_url":"https://api.github.com/users/khellang/followers","following_url":"https://api.github.com/users/khellang/following{/other_user}","gists_url":"https://api.github.com/users/khellang/gists{/gist_id}","starred_url":"https://api.github.com/users/khellang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khellang/subscriptions","organizations_url":"https://api.github.com/users/khellang/orgs","repos_url":"https://api.github.com/users/khellang/repos","events_url":"https://api.github.com/users/khellang/events{/privacy}","received_events_url":"https://api.github.com/users/khellang/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-07T13:50:34Z","updated_at":"2015-12-07T20:57:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0560113ffb82c6c907ec721ba0a7794511900924","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/457/commits","review_comments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/457/comments","review_comment_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/457/comments","statuses_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/statuses/bfad32f22321117e6044f3a666a935ab9adc60b2","head":{"label":"khellang:configurable-thread-count","ref":"configurable-thread-count","sha":"bfad32f22321117e6044f3a666a935ab9adc60b2","user":{"login":"khellang","id":582487,"avatar_url":"https://avatars.githubusercontent.com/u/582487?v=3","gravatar_id":"","url":"https://api.github.com/users/khellang","html_url":"https://github.com/khellang","followers_url":"https://api.github.com/users/khellang/followers","following_url":"https://api.github.com/users/khellang/following{/other_user}","gists_url":"https://api.github.com/users/khellang/gists{/gist_id}","starred_url":"https://api.github.com/users/khellang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khellang/subscriptions","organizations_url":"https://api.github.com/users/khellang/orgs","repos_url":"https://api.github.com/users/khellang/repos","events_url":"https://api.github.com/users/khellang/events{/privacy}","received_events_url":"https://api.github.com/users/khellang/received_events","type":"User","site_admin":false},"repo":{"id":46356941,"name":"KestrelHttpServer","full_name":"khellang/KestrelHttpServer","owner":{"login":"khellang","id":582487,"avatar_url":"https://avatars.githubusercontent.com/u/582487?v=3","gravatar_id":"","url":"https://api.github.com/users/khellang","html_url":"https://github.com/khellang","followers_url":"https://api.github.com/users/khellang/followers","following_url":"https://api.github.com/users/khellang/following{/other_user}","gists_url":"https://api.github.com/users/khellang/gists{/gist_id}","starred_url":"https://api.github.com/users/khellang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khellang/subscriptions","organizations_url":"https://api.github.com/users/khellang/orgs","repos_url":"https://api.github.com/users/khellang/repos","events_url":"https://api.github.com/users/khellang/events{/privacy}","received_events_url":"https://api.github.com/users/khellang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khellang/KestrelHttpServer","description":"A web server for ASP.NET 5 based on libuv.","fork":true,"url":"https://api.github.com/repos/khellang/KestrelHttpServer","forks_url":"https://api.github.com/repos/khellang/KestrelHttpServer/forks","keys_url":"https://api.github.com/repos/khellang/KestrelHttpServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khellang/KestrelHttpServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khellang/KestrelHttpServer/teams","hooks_url":"https://api.github.com/repos/khellang/KestrelHttpServer/hooks","issue_events_url":"https://api.github.com/repos/khellang/KestrelHttpServer/issues/events{/number}","events_url":"https://api.github.com/repos/khellang/KestrelHttpServer/events","assignees_url":"https://api.github.com/repos/khellang/KestrelHttpServer/assignees{/user}","branches_url":"https://api.github.com/repos/khellang/KestrelHttpServer/branches{/branch}","tags_url":"https://api.github.com/repos/khellang/KestrelHttpServer/tags","blobs_url":"https://api.github.com/repos/khellang/KestrelHttpServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khellang/KestrelHttpServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khellang/KestrelHttpServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/khellang/KestrelHttpServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khellang/KestrelHttpServer/statuses/{sha}","languages_url":"https://api.github.com/repos/khellang/KestrelHttpServer/languages","stargazers_url":"https://api.github.com/repos/khellang/KestrelHttpServer/stargazers","contributors_url":"https://api.github.com/repos/khellang/KestrelHttpServer/contributors","subscribers_url":"https://api.github.com/repos/khellang/KestrelHttpServer/subscribers","subscription_url":"https://api.github.com/repos/khellang/KestrelHttpServer/subscription","commits_url":"https://api.github.com/repos/khellang/KestrelHttpServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/khellang/KestrelHttpServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/khellang/KestrelHttpServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/khellang/KestrelHttpServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/khellang/KestrelHttpServer/contents/{+path}","compare_url":"https://api.github.com/repos/khellang/KestrelHttpServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khellang/KestrelHttpServer/merges","archive_url":"https://api.github.com/repos/khellang/KestrelHttpServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khellang/KestrelHttpServer/downloads","issues_url":"https://api.github.com/repos/khellang/KestrelHttpServer/issues{/number}","pulls_url":"https://api.github.com/repos/khellang/KestrelHttpServer/pulls{/number}","milestones_url":"https://api.github.com/repos/khellang/KestrelHttpServer/milestones{/number}","notifications_url":"https://api.github.com/repos/khellang/KestrelHttpServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khellang/KestrelHttpServer/labels{/name}","releases_url":"https://api.github.com/repos/khellang/KestrelHttpServer/releases{/id}","created_at":"2015-11-17T15:41:51Z","updated_at":"2015-11-17T15:41:52Z","pushed_at":"2015-12-07T20:51:58Z","git_url":"git://github.com/khellang/KestrelHttpServer.git","ssh_url":"git@github.com:khellang/KestrelHttpServer.git","clone_url":"https://github.com/khellang/KestrelHttpServer.git","svn_url":"https://github.com/khellang/KestrelHttpServer","homepage":"","size":1728,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"706ff041606ca745c71abde269bb2e668b8bb9d1","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":20344662,"name":"KestrelHttpServer","full_name":"aspnet/KestrelHttpServer","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/KestrelHttpServer","description":"A web server for ASP.NET 5 based on libuv.","fork":false,"url":"https://api.github.com/repos/aspnet/KestrelHttpServer","forks_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/forks","keys_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/teams","hooks_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/hooks","issue_events_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/events","assignees_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/tags","blobs_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/languages","stargazers_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/stargazers","contributors_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/contributors","subscribers_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/subscribers","subscription_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/subscription","commits_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/merges","archive_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/downloads","issues_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/KestrelHttpServer/releases{/id}","created_at":"2014-05-30T22:46:28Z","updated_at":"2015-12-07T14:33:34Z","pushed_at":"2015-12-07T20:00:10Z","git_url":"git://github.com/aspnet/KestrelHttpServer.git","ssh_url":"git@github.com:aspnet/KestrelHttpServer.git","clone_url":"https://github.com/aspnet/KestrelHttpServer.git","svn_url":"https://github.com/aspnet/KestrelHttpServer","homepage":"","size":3102,"stargazers_count":515,"watchers_count":515,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":72,"forks":106,"open_issues":72,"watchers":515,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/457"},"html":{"href":"https://github.com/aspnet/KestrelHttpServer/pull/457"},"issue":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/457"},"comments":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/KestrelHttpServer/statuses/bfad32f22321117e6044f3a666a935ab9adc60b2"}}}}