{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/25096359","id":25096359,"diff_hunk":"@@ -396,19 +390,24 @@ private void StartAsynchronousComputation(AsynchronousComputationToStart computa\n                         requestToCompleteSynchronously.CompleteFromTaskSynchronously(task);\n                     }\n                 }\n-                catch (Exception e) when(FatalError.ReportUnlessCanceled(e))\n-                {\n-                    throw ExceptionUtilities.Unreachable;\n-                }\n-                }\n-                catch (OperationCanceledException oce) when(CrashIfCanceledWithDifferentToken(oce, cancellationToken))\n+                catch (Exception e) when (FatalError.ReportUnlessCanceled(e))\n                 {\n-                    // As long as it's the right token, this means that our thread was the first thread\n-                    // to start an asynchronous computation, but the requestor cancelled as we were starting up\n-                    // the computation.\n                     throw ExceptionUtilities.Unreachable;\n                 }\n-                }\n+            }\n+            catch (OperationCanceledException oce) when (CrashIfCanceledWithDifferentToken(oce, cancellationToken))\n+            {\n+                // The underlying computation cancelled with the correct token, but we must ourselves ensure that the caller","path":"src/Workspaces/Core/Portable/Utilities/AsyncLazy`1.cs","position":79,"original_position":79,"commit_id":"92ced40266b359c8ae437ced1624203523268f37","original_commit_id":"92ced40266b359c8ae437ced1624203523268f37","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"canceled?","created_at":"2015-02-20T19:35:22Z","updated_at":"2015-02-20T19:35:22Z","html_url":"https://github.com/dotnet/roslyn/pull/706#discussion_r25096359","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/706","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/25096359"},"html":{"href":"https://github.com/dotnet/roslyn/pull/706#discussion_r25096359"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/706"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/706","id":29668571,"html_url":"https://github.com/dotnet/roslyn/pull/706","diff_url":"https://github.com/dotnet/roslyn/pull/706.diff","patch_url":"https://github.com/dotnet/roslyn/pull/706.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/706","number":706,"state":"open","locked":false,"title":"Fix AsyncLazy CancellationToken handling","user":{"login":"jasonmalinowski","id":201340,"avatar_url":"https://avatars.githubusercontent.com/u/201340?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmalinowski","html_url":"https://github.com/jasonmalinowski","followers_url":"https://api.github.com/users/jasonmalinowski/followers","following_url":"https://api.github.com/users/jasonmalinowski/following{/other_user}","gists_url":"https://api.github.com/users/jasonmalinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmalinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmalinowski/subscriptions","organizations_url":"https://api.github.com/users/jasonmalinowski/orgs","repos_url":"https://api.github.com/users/jasonmalinowski/repos","events_url":"https://api.github.com/users/jasonmalinowski/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmalinowski/received_events","type":"User","site_admin":false},"body":"Address several issues with AsyncLazy and it's handling of CancellationTokens. This addresses issue #447 and by extension Microsoft/TypeScript#2058.","created_at":"2015-02-20T02:19:29Z","updated_at":"2015-02-20T19:35:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e14cff5d18a3bee114fb52a721dd965ef497afe","assignee":{"login":"jasonmalinowski","id":201340,"avatar_url":"https://avatars.githubusercontent.com/u/201340?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmalinowski","html_url":"https://github.com/jasonmalinowski","followers_url":"https://api.github.com/users/jasonmalinowski/followers","following_url":"https://api.github.com/users/jasonmalinowski/following{/other_user}","gists_url":"https://api.github.com/users/jasonmalinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmalinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmalinowski/subscriptions","organizations_url":"https://api.github.com/users/jasonmalinowski/orgs","repos_url":"https://api.github.com/users/jasonmalinowski/repos","events_url":"https://api.github.com/users/jasonmalinowski/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmalinowski/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/706/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/706/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/706/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/92ced40266b359c8ae437ced1624203523268f37","head":{"label":"jasonmalinowski:fix-asynclazy-cancellationtoken","ref":"fix-asynclazy-cancellationtoken","sha":"92ced40266b359c8ae437ced1624203523268f37","user":{"login":"jasonmalinowski","id":201340,"avatar_url":"https://avatars.githubusercontent.com/u/201340?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmalinowski","html_url":"https://github.com/jasonmalinowski","followers_url":"https://api.github.com/users/jasonmalinowski/followers","following_url":"https://api.github.com/users/jasonmalinowski/following{/other_user}","gists_url":"https://api.github.com/users/jasonmalinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmalinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmalinowski/subscriptions","organizations_url":"https://api.github.com/users/jasonmalinowski/orgs","repos_url":"https://api.github.com/users/jasonmalinowski/repos","events_url":"https://api.github.com/users/jasonmalinowski/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmalinowski/received_events","type":"User","site_admin":false},"repo":{"id":30048558,"name":"roslyn","full_name":"jasonmalinowski/roslyn","owner":{"login":"jasonmalinowski","id":201340,"avatar_url":"https://avatars.githubusercontent.com/u/201340?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmalinowski","html_url":"https://github.com/jasonmalinowski","followers_url":"https://api.github.com/users/jasonmalinowski/followers","following_url":"https://api.github.com/users/jasonmalinowski/following{/other_user}","gists_url":"https://api.github.com/users/jasonmalinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmalinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmalinowski/subscriptions","organizations_url":"https://api.github.com/users/jasonmalinowski/orgs","repos_url":"https://api.github.com/users/jasonmalinowski/repos","events_url":"https://api.github.com/users/jasonmalinowski/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmalinowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonmalinowski/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/jasonmalinowski/roslyn","forks_url":"https://api.github.com/repos/jasonmalinowski/roslyn/forks","keys_url":"https://api.github.com/repos/jasonmalinowski/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonmalinowski/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonmalinowski/roslyn/teams","hooks_url":"https://api.github.com/repos/jasonmalinowski/roslyn/hooks","issue_events_url":"https://api.github.com/repos/jasonmalinowski/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/jasonmalinowski/roslyn/events","assignees_url":"https://api.github.com/repos/jasonmalinowski/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/jasonmalinowski/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/jasonmalinowski/roslyn/tags","blobs_url":"https://api.github.com/repos/jasonmalinowski/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonmalinowski/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonmalinowski/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonmalinowski/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonmalinowski/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonmalinowski/roslyn/languages","stargazers_url":"https://api.github.com/repos/jasonmalinowski/roslyn/stargazers","contributors_url":"https://api.github.com/repos/jasonmalinowski/roslyn/contributors","subscribers_url":"https://api.github.com/repos/jasonmalinowski/roslyn/subscribers","subscription_url":"https://api.github.com/repos/jasonmalinowski/roslyn/subscription","commits_url":"https://api.github.com/repos/jasonmalinowski/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonmalinowski/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonmalinowski/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonmalinowski/roslyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/jasonmalinowski/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/jasonmalinowski/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonmalinowski/roslyn/merges","archive_url":"https://api.github.com/repos/jasonmalinowski/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonmalinowski/roslyn/downloads","issues_url":"https://api.github.com/repos/jasonmalinowski/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/jasonmalinowski/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonmalinowski/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonmalinowski/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonmalinowski/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/jasonmalinowski/roslyn/releases{/id}","created_at":"2015-01-30T00:33:25Z","updated_at":"2015-02-20T18:01:27Z","pushed_at":"2015-02-20T18:21:19Z","git_url":"git://github.com/jasonmalinowski/roslyn.git","ssh_url":"git@github.com:jasonmalinowski/roslyn.git","clone_url":"https://github.com/jasonmalinowski/roslyn.git","svn_url":"https://github.com/jasonmalinowski/roslyn","homepage":"","size":50548,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"de93c18d33205c101fb401cfabf01a1469b6b61a","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-02-20T19:10:14Z","pushed_at":"2015-02-20T19:10:14Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":71124,"stargazers_count":1250,"watchers_count":1250,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":237,"mirror_url":null,"open_issues_count":425,"forks":237,"open_issues":425,"watchers":1250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/706"},"html":{"href":"https://github.com/dotnet/roslyn/pull/706"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/706"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/706/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/706/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/706/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/92ced40266b359c8ae437ced1624203523268f37"}}}}