{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/states-of-matter/issues/75","labels_url":"https://api.github.com/repos/phetsims/states-of-matter/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/states-of-matter/issues/75/comments","events_url":"https://api.github.com/repos/phetsims/states-of-matter/issues/75/events","html_url":"https://github.com/phetsims/states-of-matter/issues/75","id":65756818,"number":75,"title":"DualAtomModel.moleculeTypeProperty should be renamed","user":{"login":"jbphet","id":3082831,"avatar_url":"https://avatars.githubusercontent.com/u/3082831?v=3","gravatar_id":"","url":"https://api.github.com/users/jbphet","html_url":"https://github.com/jbphet","followers_url":"https://api.github.com/users/jbphet/followers","following_url":"https://api.github.com/users/jbphet/following{/other_user}","gists_url":"https://api.github.com/users/jbphet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbphet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbphet/subscriptions","organizations_url":"https://api.github.com/users/jbphet/orgs","repos_url":"https://api.github.com/users/jbphet/repos","events_url":"https://api.github.com/users/jbphet/events{/privacy}","received_events_url":"https://api.github.com/users/jbphet/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phetsims/states-of-matter/labels/code%20review","name":"code review","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-01T19:07:40Z","updated_at":"2015-04-01T19:17:16Z","closed_at":null,"body":"The configuration of the atoms shown on the Atomic Interactions screen is currently controlled by a variable named \"moleculeType\" in the PropertySet call.  Potential values are NEON_NEON, NEON_OXYGEN, ARGON_ARGON, and so forth.  These are not molecule types - they are pairs of atoms that are in most cases not bound to one another - so the name is misleading.  I suggest renaming this property to \"atomPair\".\r\n\r\nThis was found during code review, see #30."},"comment":{"url":"https://api.github.com/repos/phetsims/states-of-matter/issues/comments/88599221","html_url":"https://github.com/phetsims/states-of-matter/issues/75#issuecomment-88599221","issue_url":"https://api.github.com/repos/phetsims/states-of-matter/issues/75","id":88599221,"user":{"login":"jbphet","id":3082831,"avatar_url":"https://avatars.githubusercontent.com/u/3082831?v=3","gravatar_id":"","url":"https://api.github.com/users/jbphet","html_url":"https://github.com/jbphet","followers_url":"https://api.github.com/users/jbphet/followers","following_url":"https://api.github.com/users/jbphet/following{/other_user}","gists_url":"https://api.github.com/users/jbphet/gists{/gist_id}","starred_url":"https://api.github.com/users/jbphet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbphet/subscriptions","organizations_url":"https://api.github.com/users/jbphet/orgs","repos_url":"https://api.github.com/users/jbphet/repos","events_url":"https://api.github.com/users/jbphet/events{/privacy}","received_events_url":"https://api.github.com/users/jbphet/received_events","type":"User","site_admin":false},"created_at":"2015-04-01T19:17:16Z","updated_at":"2015-04-01T19:17:16Z","body":"I did this one myself because I need to log some other tickets related to this property, and it will be less confusing if the name is changed now.  Assigning to @kmsravindra so that his team can review and be aware of the change.  He or someone on his dev team can close once reviewed."}}