{"push_id":836978332,"size":24,"distinct_size":24,"ref":"refs/heads/master","head":"9b96872ec9ac1a548399a4e657a6cc85805d55fb","before":"155f2195c50e4e5217c68e5643254a0d7f845621","commits":[{"sha":"3428dc9e92a5422106ed1adf3c19304e62357c06","author":{"email":"3269a793d567baa2fa5b041e3e5e0a5039790a2f@google.com","name":"Han-Wen Nienhuys"},"message":"Open source more tests for packages/\n\nTested:\n  bazel test on merge-to-os-blaze.sh\n  checked total test method count on\n     blaze test //javatests/com/google/devtools/build/lib:PackagesTests //third_party/bazel/src/test/java/com/google/devtools/build/lib:packages-tests\n\n--\nMOS_MIGRATED_REVID=105963077","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/3428dc9e92a5422106ed1adf3c19304e62357c06"},{"sha":"0b97b91ab4afb101fa2d54f1f7ca5d56b5ff026e","author":{"email":"b7c7c32d38cef000474280cffaa0786fbb76634d@google.com","name":"Michajlo Matijkiw"},"message":"Narrow return type of ContainingPackageLookupValue.withContainingPackage\n\n--\nMOS_MIGRATED_REVID=105969015","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/0b97b91ab4afb101fa2d54f1f7ca5d56b5ff026e"},{"sha":"86ea967e3449e354f32484d1fbaebb169a4e7b03","author":{"email":"1505422b2465e9a84f6fdfaa161078890c593f06@google.com","name":"Googler"},"message":"Remove transitive data from Android Studio aspect.\n\nThe cost-benefit isn't there to pay a square cost to roll these up on\nthe blaze side. Android Studio has to do it on its end instead.\n\n--\nMOS_MIGRATED_REVID=105971068","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/86ea967e3449e354f32484d1fbaebb169a4e7b03"},{"sha":"6266229e4a4e4cc7f096a2a087fe691fdc2743a7","author":{"email":"1505422b2465e9a84f6fdfaa161078890c593f06@google.com","name":"Googler"},"message":"Description redacted.\n--\nMOS_MIGRATED_REVID=105975871","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/6266229e4a4e4cc7f096a2a087fe691fdc2743a7"},{"sha":"24ed98d3fa2de85505d7bd5b9a7c4485bb2105fb","author":{"email":"5db6c4a43c5c57bd52ce58f0168003799239e751@google.com","name":"Mark Schaller"},"message":"Retain first error message during transitive traversal\n\nPreviously, a TransitiveTraversalFunction computed a value that\ncontained an exception only if the exception resulted from a failure\nto load the function's immediate target. If the target had transitive\ndependencies on other targets, those other targets would be loaded, but\nany errors resulting from loading those targets would not be retained.\n\nSkyQueryEnvironment impromperly used a SkyFrame mechanism (which was\nsolely intended to ensure equivalent semantics between keep-going and\nno-keep-going evaluations) to discover errors in the set of transitive\nchildren of TransitiveTraversal nodes.\n\nIn order to transition SkyQueryEnvironment away from that mechanism,\nthis CL changes TransitiveTraversalFunction to remember the first error\nmessage encountered while loading its target and its transitive\ndependencies.\n\nBy remembering just the error message as a string, and not the full\nexception object, this also helps TransitiveTraversalValue have more\nconsistent equality semantics for change-pruning.\n\n--\nMOS_MIGRATED_REVID=105977182","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/24ed98d3fa2de85505d7bd5b9a7c4485bb2105fb"},{"sha":"c031a000321a49aa2bbdfb427cb2fe4061ee613c","author":{"email":"5db6c4a43c5c57bd52ce58f0168003799239e751@google.com","name":"Mark Schaller"},"message":"In SkyQueryEnvironment, check TransitiveTraversalValues for errors\n\nIn SkyQueryEnvironment, the buildTransitiveClosure method ignored the\nerror messages in successfully evaluated TransitiveTraversalValues,\nunder the belief that any such error messages are also obtainable by\ncalling getMissingAndExceptions. This happens to be true right now,\nbut may not be true in the future.\n\nIf, in particular, the TransitiveTraversal skyfunction inlines its\ncall to the TargetMarker skyfunction, those error messages won't be\navailable through getMissingAndExceptions.\n\n--\nMOS_MIGRATED_REVID=105980430","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/c031a000321a49aa2bbdfb427cb2fe4061ee613c"},{"sha":"908f4c91b4b5c1f996f1b177ab5886b1468cb6a9","author":{"email":"5db6c4a43c5c57bd52ce58f0168003799239e751@google.com","name":"Mark Schaller"},"message":"Minor cleanups to GraphTester\n\nRefactors SkyFunction map creation into the tester from tests.\nEncapsulates modifiedValues better.\n\n--\nMOS_MIGRATED_REVID=105982046","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/908f4c91b4b5c1f996f1b177ab5886b1468cb6a9"},{"sha":"8ff064545b5c286209c07a66eee430747a401a0e","author":{"email":"27c6c371f59f8662a1353bcf7c14fa08877a3832@google.com","name":"Dmitry Lomov"},"message":"Introduce an AspectClass: a representation of a class of aspects.\n\nFor native aspects, AspectClass is a facade for Class<AspectFactory<...>>.\n\n--\nMOS_MIGRATED_REVID=105986390","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/8ff064545b5c286209c07a66eee430747a401a0e"},{"sha":"f5143ecc7751acd076d61564842e26664fc5a50a","author":{"email":"27c6c371f59f8662a1353bcf7c14fa08877a3832@google.com","name":"Dmitry Lomov"},"message":"Add Skylark aspect tests.\n\n--\nMOS_MIGRATED_REVID=105986411","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/f5143ecc7751acd076d61564842e26664fc5a50a"},{"sha":"06568808db8ccb6ca4bb0d663da4e3e1a9b1a308","author":{"email":"5db6c4a43c5c57bd52ce58f0168003799239e751@google.com","name":"Mark Schaller"},"message":"Remove wildcard of SkyFunctionName, as it is final\n\nNothing can extend SkyFunctionName. It's final.\n\n--\nMOS_MIGRATED_REVID=105989976","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/06568808db8ccb6ca4bb0d663da4e3e1a9b1a308"},{"sha":"b12c5d435bd089d348a30295ef7341b9c5024c10","author":{"email":"11e89f34e74a3a49159471e2a90ff11426b4bd13@google.com","name":"Miguel Alcon Pinto"},"message":"Memoize TRANSITIVE_TRAVERSAL nodes to save memory.\n\n--\nMOS_MIGRATED_REVID=105994907","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/b12c5d435bd089d348a30295ef7341b9c5024c10"},{"sha":"933da07a90a3e6bc60475591dfd18ce801b9c901","author":{"email":"cd11aa6affd4400fb7013c004b7582acd84f45f9@google.com","name":"Janak Ramakrishnan"},"message":"Process tasks in the AbstractQueueVisitor in LIFO order as opposed to FIFO order. In general, there's no advantage in Blaze to FIFO, and it means that we effectively do breadth-first graph traversal. When we must hold state for incomplete nodes (as we do with action execution, or more generally, as we do in Skyframe), this increases our memory footprint.\n\nLIFO is not exactly depth-first traversal, since we are multithreaded, but to a first approximation, it looks like a depth-first traversal with \"width\" the number of threads (at each level of the graph, #(threads) nodes are visited).\n\n--\nMOS_MIGRATED_REVID=105995014","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/933da07a90a3e6bc60475591dfd18ce801b9c901"},{"sha":"3e66b6e8163bdf49a65a02d422d109ffba170d26","author":{"email":"693bce8e40ec7d6c6caab7f657d2590334ff9b08@google.com","name":"Eric Fellheimer"},"message":"Fix broken / backwards logic in the blaze launcher when trying to kill a running server (because startup flags changed, different Blaze version, etc.). Currently, we do a SIGTERM then fallback to a SIGKILL. Our logic to check if the server was still up after the fallback was backwards, so in some cases we would connect to the old server even though we just sent it a SIGKILL. Not really ideal.\n\nNote that this only occurred if the SIGTERM failed to kill the Blaze process within 10s, so this failure mode happened rarely.\n\nAlso: Check for the expected errno from the kill(), and exit with an \"internal error\" exit code instead of \"1\" if we are unable to kill the old server.\n\n--\nMOS_MIGRATED_REVID=105999230","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/3e66b6e8163bdf49a65a02d422d109ffba170d26"},{"sha":"f7deff91dec0acba4a9199cb2f953be6b421d0bd","author":{"email":"0dee14ed770eda600e5d9531029572381739c329@google.com","name":"Alex Humesky"},"message":"Description redacted.\n--\nMOS_MIGRATED_REVID=105999401","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/f7deff91dec0acba4a9199cb2f953be6b421d0bd"},{"sha":"f69f1b06edecd12c925f334c31e70e1ba71b05b6","author":{"email":"b7c7c32d38cef000474280cffaa0786fbb76634d@google.com","name":"Michajlo Matijkiw"},"message":"Singleton-ify ErrorTransienceValue\n\nWe rely on ErrorTransienceValue being different across evaluations by\nway of java reference inequality, instead make it a singleton and make\nit so that ErrorTransienceValue compares equal to nothing, including itself.\n\nAlternatively we could attach the corresponding Version to ErrorTransienceValue\nand use that to force inequality across evaluations. However this gets into\nthe different possible Version implementations and their varying semantics, so\ngo with the simplest approach first and see how it works out.\n\n--\nMOS_MIGRATED_REVID=106001826","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/f69f1b06edecd12c925f334c31e70e1ba71b05b6"},{"sha":"f16107b92049f640f347e1ef5fa8841681bfe2a8","author":{"email":"d1383e89a6fc7cb81e22c5ae5f34ca88b6e954a5@google.com","name":"Francois-Rene Rideau"},"message":"Have @SkylarkCallable methods accept Iterable instead of Collection\n\nThis makes it possible to call these methods with lists from Skylark, which are internally Iterable<>'s but not Collection<>'s.\n\n--\nMOS_MIGRATED_REVID=106003065","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/f16107b92049f640f347e1ef5fa8841681bfe2a8"},{"sha":"2b4e38971b3a8fbd07db2f7ef3a90a17d1f65e70","author":{"email":"5db6c4a43c5c57bd52ce58f0168003799239e751@google.com","name":"Mark Schaller"},"message":"Increase visibility of BuildingState method\n\n--\nMOS_MIGRATED_REVID=106004898","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/2b4e38971b3a8fbd07db2f7ef3a90a17d1f65e70"},{"sha":"16f10837a224df9d792cba563dbee138a0789cb7","author":{"email":"4068f0880b399410602d694b3cc711c8a8f4727e@choosemuse.com","name":"Steven Dee"},"message":"Add missing dash for -finline-limit=300\n\n--\nChange-Id: Ic19a8292e1c57623085daa6ce3cbf280cdf7129e\nReviewed-on: https://bazel-review.googlesource.com/2180\nMOS_MIGRATED_REVID=106035838","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/16f10837a224df9d792cba563dbee138a0789cb7"},{"sha":"854b72dddb80a4c8da6bf0ac9dbd683951875541","author":{"email":"54fb3d7cbb881b8b9642a8c2398d08d455dbc5f0@google.com","name":"David Chen"},"message":"[jsonnet] Add jsonnet_to_json_test rule for testing Jsonnet code.\n\nRELNOTES: [jsonnet] Add jsonnet_to_json_test rule for testing Jsonnet code.\n\n--\nMOS_MIGRATED_REVID=106040951","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/854b72dddb80a4c8da6bf0ac9dbd683951875541"},{"sha":"fac21e564c9a9fe5288431f05e4ae6b5c19d35bf","author":{"email":"67713928c27e36e00cc15ff4702b1e0d0e6cc8cf@gmail.com","name":"Brian Silverman"},"message":"Set sharding and tmpdir environment variables for googletest\n\nThe patch for googletest to prefer GTEST_TMP_DIR is\ngoogle/googletest#619 and should be merged soon.\n\n--\nChange-Id: If48220e8e1e4e78a8768aeb14b5b58e4f246c8c3\nReviewed-on: https://bazel-review.googlesource.com/#/c/2170/\nMOS_MIGRATED_REVID=106043714","distinct":true,"url":"https://api.github.com/repos/bazelbuild/bazel/commits/fac21e564c9a9fe5288431f05e4ae6b5c19d35bf"}]}