{"action":"created","issue":{"url":"https://api.github.com/repos/riyadparvez/data-structures-csharp/issues/2","labels_url":"https://api.github.com/repos/riyadparvez/data-structures-csharp/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/riyadparvez/data-structures-csharp/issues/2/comments","events_url":"https://api.github.com/repos/riyadparvez/data-structures-csharp/issues/2/events","html_url":"https://github.com/riyadparvez/data-structures-csharp/pull/2","id":53328787,"number":2,"title":"Added New Changes to BinarySearchTree","user":{"login":"mohanprasathsj","id":10070327,"avatar_url":"https://avatars.githubusercontent.com/u/10070327?v=3","gravatar_id":"","url":"https://api.github.com/users/mohanprasathsj","html_url":"https://github.com/mohanprasathsj","followers_url":"https://api.github.com/users/mohanprasathsj/followers","following_url":"https://api.github.com/users/mohanprasathsj/following{/other_user}","gists_url":"https://api.github.com/users/mohanprasathsj/gists{/gist_id}","starred_url":"https://api.github.com/users/mohanprasathsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohanprasathsj/subscriptions","organizations_url":"https://api.github.com/users/mohanprasathsj/orgs","repos_url":"https://api.github.com/users/mohanprasathsj/repos","events_url":"https://api.github.com/users/mohanprasathsj/events{/privacy}","received_events_url":"https://api.github.com/users/mohanprasathsj/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-04T07:39:58Z","updated_at":"2015-01-05T05:34:50Z","closed_at":"2015-01-05T00:33:31Z","pull_request":{"url":"https://api.github.com/repos/riyadparvez/data-structures-csharp/pulls/2","html_url":"https://github.com/riyadparvez/data-structures-csharp/pull/2","diff_url":"https://github.com/riyadparvez/data-structures-csharp/pull/2.diff","patch_url":"https://github.com/riyadparvez/data-structures-csharp/pull/2.patch"},"body":"Added changes to BinarySearchTree.  \r\nFollowing things are modified under this change.\r\n1. Changed the BinarySearchTree to Partial class\r\n2. Modified Contract of Add, so that if the same is added twice it just updates the value rather than adding a new Node\r\n3. Changed the FindSplitNode- Node is considered to be correct when there is difference between start and end is less and greater respectively.\r\n4. Modified GetAllNodes- Now the function will return all the nodes in In-Order format\r\n5. Modified GetAllNodes in Range- Now the function will return all the nodes within the range in In-Order Traversal."},"comment":{"url":"https://api.github.com/repos/riyadparvez/data-structures-csharp/issues/comments/68670109","html_url":"https://github.com/riyadparvez/data-structures-csharp/pull/2#issuecomment-68670109","issue_url":"https://api.github.com/repos/riyadparvez/data-structures-csharp/issues/2","id":68670109,"user":{"login":"riyadparvez","id":494783,"avatar_url":"https://avatars.githubusercontent.com/u/494783?v=3","gravatar_id":"","url":"https://api.github.com/users/riyadparvez","html_url":"https://github.com/riyadparvez","followers_url":"https://api.github.com/users/riyadparvez/followers","following_url":"https://api.github.com/users/riyadparvez/following{/other_user}","gists_url":"https://api.github.com/users/riyadparvez/gists{/gist_id}","starred_url":"https://api.github.com/users/riyadparvez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riyadparvez/subscriptions","organizations_url":"https://api.github.com/users/riyadparvez/orgs","repos_url":"https://api.github.com/users/riyadparvez/repos","events_url":"https://api.github.com/users/riyadparvez/events{/privacy}","received_events_url":"https://api.github.com/users/riyadparvez/received_events","type":"User","site_admin":false},"created_at":"2015-01-05T05:34:50Z","updated_at":"2015-01-05T05:34:50Z","body":"Thanks for the PR.\r\n\r\n* Please put coding style changes in a separate PR.\r\n* I didn't like the eliminating contract in adding new node. One thing you can do when the BST has no nodes, set the root to a `NullNode`. You have to create a null object class for `Node`. Please have a look at: http://en.wikipedia.org/wiki/Null_Object_pattern\r\n"}}