{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/300","labels_url":"https://api.github.com/repos/apache/flink/issues/300/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/300/comments","events_url":"https://api.github.com/repos/apache/flink/issues/300/events","html_url":"https://github.com/apache/flink/pull/300","id":54082999,"number":300,"title":"Add [FLINK-1376] Add proper shared slot release in case of a fatal TaskManager failure","user":{"login":"tillrohrmann","id":5756858,"avatar_url":"https://avatars.githubusercontent.com/u/5756858?v=3","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-12T17:37:54Z","updated_at":"2015-01-13T20:17:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/300","html_url":"https://github.com/apache/flink/pull/300","diff_url":"https://github.com/apache/flink/pull/300.diff","patch_url":"https://github.com/apache/flink/pull/300.patch"},"body":"This PR introduces SharedSlots as being a special Slot type and as such being released properly in case an Instance has been marked dead. This fixes the problem that a dead instance, which has not been shutdown properly, causes a job not being removed properly from the system, because it is not aware of the SubSlots.\r\n\r\nAdds test cases where only the heartbeat is disabled to see if the job is properly failed.\r\n\r\n@StephanEwen: Would be great if you could take a close look at the code because of the delicate synchronization mechanism. What I've done in the end is to synchronize most of the calls by passing them through the SlotSharingGroupAssignment."},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/69811875","html_url":"https://github.com/apache/flink/pull/300#issuecomment-69811875","issue_url":"https://api.github.com/repos/apache/flink/issues/300","id":69811875,"user":{"login":"tillrohrmann","id":5756858,"avatar_url":"https://avatars.githubusercontent.com/u/5756858?v=3","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"created_at":"2015-01-13T20:17:25Z","updated_at":"2015-01-13T20:17:25Z","body":"There is still a concurrent modification somewhere.\r\nOn Jan 13, 2015 5:03 PM, \"Stephan Ewen\" <notifications@github.com> wrote:\r\n\r\n> Thanks Till, this is a pretty involved patch. I'll try to look over it\r\n> tomorrow or Thursday.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/apache/flink/pull/300#issuecomment-69767682>.\r\n>"}}