{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/43923635","id":43923635,"diff_hunk":"@@ -99,6 +103,14 @@ func (e *HookExecutor) executeExecNewPod(hook *deployapi.LifecycleHook, deployme\n \t\treturn err\n \t}\n \n+\tconfig, err := deployutil.DecodeDeploymentConfig(deployment, e.Codec)","path":"pkg/deploy/strategy/support/lifecycle.go","position":null,"original_position":34,"commit_id":"41f88b93e4317be6147e409f02f0fbce67723bc4","original_commit_id":"ca5e16a17e64b899bffd0f3afd0e8892bab9c016","user":{"login":"pedro-r-marques","id":5280518,"avatar_url":"https://avatars.githubusercontent.com/u/5280518?v=3","gravatar_id":"","url":"https://api.github.com/users/pedro-r-marques","html_url":"https://github.com/pedro-r-marques","followers_url":"https://api.github.com/users/pedro-r-marques/followers","following_url":"https://api.github.com/users/pedro-r-marques/following{/other_user}","gists_url":"https://api.github.com/users/pedro-r-marques/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-r-marques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-r-marques/subscriptions","organizations_url":"https://api.github.com/users/pedro-r-marques/orgs","repos_url":"https://api.github.com/users/pedro-r-marques/repos","events_url":"https://api.github.com/users/pedro-r-marques/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-r-marques/received_events","type":"User","site_admin":false},"body":"done","created_at":"2015-11-04T19:06:52Z","updated_at":"2015-11-04T19:06:52Z","html_url":"https://github.com/openshift/origin/pull/5149#discussion_r43923635","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/5149","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/43923635"},"html":{"href":"https://github.com/openshift/origin/pull/5149#discussion_r43923635"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/5149"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/5149","id":47838121,"html_url":"https://github.com/openshift/origin/pull/5149","diff_url":"https://github.com/openshift/origin/pull/5149.diff","patch_url":"https://github.com/openshift/origin/pull/5149.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/5149","number":5149,"state":"open","locked":false,"title":"Add labels/annotations to DeploymentStrategy","user":{"login":"pedro-r-marques","id":5280518,"avatar_url":"https://avatars.githubusercontent.com/u/5280518?v=3","gravatar_id":"","url":"https://api.github.com/users/pedro-r-marques","html_url":"https://github.com/pedro-r-marques","followers_url":"https://api.github.com/users/pedro-r-marques/followers","following_url":"https://api.github.com/users/pedro-r-marques/following{/other_user}","gists_url":"https://api.github.com/users/pedro-r-marques/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-r-marques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-r-marques/subscriptions","organizations_url":"https://api.github.com/users/pedro-r-marques/orgs","repos_url":"https://api.github.com/users/pedro-r-marques/repos","events_url":"https://api.github.com/users/pedro-r-marques/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-r-marques/received_events","type":"User","site_admin":false},"body":"This PR allows for the deployer to work in a scenario where an application is using per-tier network segmentation.\r\n\r\nFor instance, the rails-postgresql-example app sets the label \"name\": rails-postgresql-example. OpenContrail creates a network segment for this project/tier. The postgresql database sits in the network \"default\" (by the fact that no label is specified).\r\n\r\nThe deploymentConfig uses the following labels:\r\n```\r\n+        \"labels\": {\r\n+          \"name\": \"rails-postgresql-example\",\r\n+          \"uses\": \"default\"\r\n+        },\r\n```\r\n\r\nThis allows the deployer to be in the same application as the application front-end and deployer-hook to access the postgresql db.\r\n","created_at":"2015-10-15T20:36:28Z","updated_at":"2015-11-04T19:06:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70d0467f586b972e9d87ac08abd89256bb199a66","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/5149/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/5149/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/5149/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/41f88b93e4317be6147e409f02f0fbce67723bc4","head":{"label":"pedro-r-marques:deploy-labels","ref":"deploy-labels","sha":"41f88b93e4317be6147e409f02f0fbce67723bc4","user":{"login":"pedro-r-marques","id":5280518,"avatar_url":"https://avatars.githubusercontent.com/u/5280518?v=3","gravatar_id":"","url":"https://api.github.com/users/pedro-r-marques","html_url":"https://github.com/pedro-r-marques","followers_url":"https://api.github.com/users/pedro-r-marques/followers","following_url":"https://api.github.com/users/pedro-r-marques/following{/other_user}","gists_url":"https://api.github.com/users/pedro-r-marques/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-r-marques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-r-marques/subscriptions","organizations_url":"https://api.github.com/users/pedro-r-marques/orgs","repos_url":"https://api.github.com/users/pedro-r-marques/repos","events_url":"https://api.github.com/users/pedro-r-marques/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-r-marques/received_events","type":"User","site_admin":false},"repo":{"id":44292038,"name":"origin","full_name":"pedro-r-marques/origin","owner":{"login":"pedro-r-marques","id":5280518,"avatar_url":"https://avatars.githubusercontent.com/u/5280518?v=3","gravatar_id":"","url":"https://api.github.com/users/pedro-r-marques","html_url":"https://github.com/pedro-r-marques","followers_url":"https://api.github.com/users/pedro-r-marques/followers","following_url":"https://api.github.com/users/pedro-r-marques/following{/other_user}","gists_url":"https://api.github.com/users/pedro-r-marques/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro-r-marques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro-r-marques/subscriptions","organizations_url":"https://api.github.com/users/pedro-r-marques/orgs","repos_url":"https://api.github.com/users/pedro-r-marques/repos","events_url":"https://api.github.com/users/pedro-r-marques/events{/privacy}","received_events_url":"https://api.github.com/users/pedro-r-marques/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pedro-r-marques/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/pedro-r-marques/origin","forks_url":"https://api.github.com/repos/pedro-r-marques/origin/forks","keys_url":"https://api.github.com/repos/pedro-r-marques/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedro-r-marques/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedro-r-marques/origin/teams","hooks_url":"https://api.github.com/repos/pedro-r-marques/origin/hooks","issue_events_url":"https://api.github.com/repos/pedro-r-marques/origin/issues/events{/number}","events_url":"https://api.github.com/repos/pedro-r-marques/origin/events","assignees_url":"https://api.github.com/repos/pedro-r-marques/origin/assignees{/user}","branches_url":"https://api.github.com/repos/pedro-r-marques/origin/branches{/branch}","tags_url":"https://api.github.com/repos/pedro-r-marques/origin/tags","blobs_url":"https://api.github.com/repos/pedro-r-marques/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedro-r-marques/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedro-r-marques/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedro-r-marques/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedro-r-marques/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/pedro-r-marques/origin/languages","stargazers_url":"https://api.github.com/repos/pedro-r-marques/origin/stargazers","contributors_url":"https://api.github.com/repos/pedro-r-marques/origin/contributors","subscribers_url":"https://api.github.com/repos/pedro-r-marques/origin/subscribers","subscription_url":"https://api.github.com/repos/pedro-r-marques/origin/subscription","commits_url":"https://api.github.com/repos/pedro-r-marques/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedro-r-marques/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedro-r-marques/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedro-r-marques/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pedro-r-marques/origin/contents/{+path}","compare_url":"https://api.github.com/repos/pedro-r-marques/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedro-r-marques/origin/merges","archive_url":"https://api.github.com/repos/pedro-r-marques/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedro-r-marques/origin/downloads","issues_url":"https://api.github.com/repos/pedro-r-marques/origin/issues{/number}","pulls_url":"https://api.github.com/repos/pedro-r-marques/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/pedro-r-marques/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/pedro-r-marques/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedro-r-marques/origin/labels{/name}","releases_url":"https://api.github.com/repos/pedro-r-marques/origin/releases{/id}","created_at":"2015-10-15T03:39:31Z","updated_at":"2015-10-15T03:39:57Z","pushed_at":"2015-11-04T19:06:28Z","git_url":"git://github.com/pedro-r-marques/origin.git","ssh_url":"git@github.com:pedro-r-marques/origin.git","clone_url":"https://github.com/pedro-r-marques/origin.git","svn_url":"https://github.com/pedro-r-marques/origin","homepage":"http://www.openshift.org","size":176813,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"ed74c309b11ba62c1c2c9aec2ff4a8c956532537","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-11-04T15:47:54Z","pushed_at":"2015-11-04T19:06:28Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":300129,"stargazers_count":788,"watchers_count":788,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":486,"mirror_url":null,"open_issues_count":627,"forks":486,"open_issues":627,"watchers":788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/5149"},"html":{"href":"https://github.com/openshift/origin/pull/5149"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/5149"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/5149/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/5149/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/5149/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/41f88b93e4317be6147e409f02f0fbce67723bc4"}}}}