{"push_id":859045479,"size":44,"distinct_size":44,"ref":"refs/heads/develop","head":"42e51a933434c2eba583190b6e408699e1c3cd23","before":"0512cbaa1754bd67567622b025be1c3a88128183","commits":[{"sha":"89bb1eb232b34318657481ba6b9f628fba4bafc1","author":{"email":"eff0e6b3b55c42f655c864be9b27028ce9b2d31b@twitter.com","name":"Vladimir Kostyukov"},"message":"finagle: Log exceptions occurred in the server stack\n\nProblem\nUnhandled exceptions from the Finagle server stack are silently dropped.\n\nSolution\nReplaced `DefaultMonitor` with `RootMonitor`, which logs all the unhandled\nexceptions.\n\nRB_ID=728585","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/89bb1eb232b34318657481ba6b9f628fba4bafc1"},{"sha":"485a4ae9ed8dd025a51a30d224c772860dedfffb","author":{"email":"eff0e6b3b55c42f655c864be9b27028ce9b2d31b@twitter.com","name":"Vladimir Kostyukov"},"message":"finagle|util: Fix broken changelogs\n\n- Dublicated section \"Runtime Behavior Changes\" under the 6.30.0 relase in finagle.\n- Wrong idenetation in util's cahngelog.\n- Missing changelog for TwitterServer.\n\nRB_ID=756329","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/485a4ae9ed8dd025a51a30d224c772860dedfffb"},{"sha":"169a91946b13fb6e5c062f8e159eb9313ca8a414","author":{"email":"742f145aa19389f78cee99748e3ac7d981219b29@gmail.com","name":"Arnar Þór Sveinsson"},"message":"finagle: Adding QuizUp to adopters list\n\nSigned-off-by: Vladimir Kostyukov <vkostyukov@twitter.com>\n\nRB_ID=756337","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/169a91946b13fb6e5c062f8e159eb9313ca8a414"},{"sha":"e917f276bb3c9c17c67f1aa345eabe8355356565","author":{"email":"eff0e6b3b55c42f655c864be9b27028ce9b2d31b@twitter.com","name":"Vladimir Kostyukov"},"message":"finagle-http: Check for potential integer overflow of the HTTP message size\n\nRB_ID=756352","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/e917f276bb3c9c17c67f1aa345eabe8355356565"},{"sha":"eb3b0f8f1f9384d75f8df42a739918ceb1efe636","author":{"email":"24a54edd064a4908b8cc046e2ca1a8dcab73c61c@twitter.com","name":"Kevin Oliver"},"message":"finagle, scrooge: Remove caliper\n\nMotivation\n\nWe have moved to JMH from Caliper for microbenchmarks. A few\nreferences and benchmarks remained.\n\nSolution\n\nPort the one interesting benchmark to JMH and remove the others.\n\nRB_ID=756942","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/eb3b0f8f1f9384d75f8df42a739918ceb1efe636"},{"sha":"2b83fa5e29c64721dfb7a90c3eca4bde2751a343","author":{"email":"a13b1135e6f2f8530e85bc2896cd5ed89a6ed863@twitter.com","name":"David Turner"},"message":"Revert \"finagle-http: Check for potential integer overflow of the HTTP message size\"\n\nThis is breaking the build.\n\nRB_ID=757293\nTBR=true\nNO-QUEUE=true","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/2b83fa5e29c64721dfb7a90c3eca4bde2751a343"},{"sha":"c5049b1413daae63cd2defbf408bcc03c5819df8","author":{"email":"24a54edd064a4908b8cc046e2ca1a8dcab73c61c@twitter.com","name":"Kevin Oliver"},"message":"finagle: Flaky tests\n\nCleanup for some flaky tests\n\nRB_ID=756955","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/c5049b1413daae63cd2defbf408bcc03c5819df8"},{"sha":"47925f5543932ee09ff47933c165ea3a8009713e","author":{"email":"24a54edd064a4908b8cc046e2ca1a8dcab73c61c@twitter.com","name":"Kevin Oliver"},"message":"util-core: Timers should propagate Locals\n\nMotivation\n\n`com.twitter.util.Timer` typically runs code in a different execution\ncontext from where they scheduled. If the corresponding\n`com.twitter.util.Locals` are not propagated, this can lead to\nunexpected behavior. Finagle's most commonly used `Timer`\nimplementation is `com.twitter.finagle.util.HashedWheelTimer` which\nhas this behavior. However, two other implementations, `JavaTimer` and\n`ScheduledThreadPoolTimer`, did not.\n\nSolution\n\n`Timer` now has final implementations for `schedule` which delegate to\nnew protected `scheduleOnce` and `schedulePeriodically` methods. This\nis done to ensure that `Locals` are captured when the task is\nscheduled and then used when the task is run. Existing `Timer`\nimplementations should rename their existing `schedule` methods to\nwork with the new interface.\n\nResult\n\n`Locals` are available when the task is run, as would be expected.\n\nRB_ID=755387\nTBR=true","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/47925f5543932ee09ff47933c165ea3a8009713e"},{"sha":"d998a16bc501effa079f35c60abcf8c00177150e","author":{"email":"eff0e6b3b55c42f655c864be9b27028ce9b2d31b@twitter.com","name":"Vladimir Kostyukov"},"message":"finagle-http: Check for potential integer overflow of the HTTP message size\n\nProblem\nIf HTTP server or client are configured with request/response size bigger than 2Gb,\nthey will fail at runtime (when `ListenningServer` or `Transporter` are constructed)\nand will drop the connection.\n\nSolution\nFail fast instead of instantiating a wrongly configured server/client.\n\nRB_ID=757256","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/d998a16bc501effa079f35c60abcf8c00177150e"},{"sha":"ab5a3b145b190fff602229371d2159576518cec4","author":{"email":"afc5e40f7e0ce50d0caf1701580b337509dfc04f@twitter.com","name":"Daniel Schobel"},"message":"finagle-core: fix protocol library name configuration in builders\nProblem\n\nThe global registry can't access the protocol name for CodecFactory#Client\nand CodecFactory#Service instances which leads to unspecified\nprotocols even for CodecFactory's with defined protocols names.\n\nSolution\n\nConfigure the protocol name at stack eval time.\n\nResult\n\nFewer unregistered protocols.\n\nRB_ID=757260","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/ab5a3b145b190fff602229371d2159576518cec4"},{"sha":"b4a26f83eb8058189ecfc0b5b75a796a92ba8739","author":{"email":"0474aee45985f5ae829f53849df476200e876990@twitter.com","name":"Alex Yarmula"},"message":"loadServiceDenied: fix the usage comment to properly use global flag\n\nThere are two ways to use loadServiceDenied:\n\n(runtime flag) java MyClass -com.twitter.finagle.util.loadServiceDenied=com.twitter.finagle.stats.OstrichStatsReceiver\n(global flag) java -Dcom.twitter.finagle.util.loadServiceDenied=com.twitter.finagle.stats.OstrichStatsReceiver MyClass\n\nBoth ways start the process, but due to initialization order, the first way doesn't achieve the desired filtering.\n\nThis RB fixes the comment that implicitly advises the syntax of the first way. It also adds OstrichExporter to examples too as it's loaded too and is commonly added to denied list.\n\nRB_ID=758031","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/b4a26f83eb8058189ecfc0b5b75a796a92ba8739"},{"sha":"75bf9853f85cc61078b3f2611d45d3783492ae0a","author":{"email":"7047f4780c29ac24150c1010b697fe8556488e80@twitter.com","name":"Alex Leong"},"message":"Replace macaw group with api group.  Cleanup OWNERS and GROUPS files accordingly.\n\nRB_ID=758183","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/75bf9853f85cc61078b3f2611d45d3783492ae0a"},{"sha":"2627735b5d9ee1dde73d68114bdd02c8d7892d12","author":{"email":"ccc9d04961e5acc3041df4c85091b0af91b6102c@twitter.com","name":"Bing Wei"},"message":"finagle-core: ClientRegistry cleans up duplicates when service closes\n\nProblem\n\nClientRegistry does not remove entries from a duplicate\nlist it maintains. It can causes memory leak if services\ncreate lots of clients.\n\nSolution\n\nclean up the duplicate buffer when client closes.\n\nRB_ID=757874","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/2627735b5d9ee1dde73d68114bdd02c8d7892d12"},{"sha":"1f144b7046b675b458d396d5dc1f5bc71d1665de","author":{"email":"ccc9d04961e5acc3041df4c85091b0af91b6102c@twitter.com","name":"Bing Wei"},"message":"finagle: revert two recent failureAccrual changes\nProblem\n\nWe introduced a bug for Memcache when hostEjection is on. Once a host\nis ejected from cache ring, there is no way for failureAccrual probe\nto work, thus the node is never added back into the ring.\n\nSolution\n\nFor now revert two related commits:\n\nRevert \"finagle/finagle-core:: Revived FailureAccrualFactory must satisfy a request before accepting more\"\nRevert \"finagle/finage-core: Make FailureAccrual markDeadFor use exponential backoff by default\"\n\nRB_ID=758383\nNO-QUEUE=true","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/1f144b7046b675b458d396d5dc1f5bc71d1665de"},{"sha":"462bbcf7a53769ce6452bde86f7e6c391504f683","author":{"email":"27622d0d92573d88f123cba4968250797d9e766b@twitter.com","name":"whe"},"message":"finagle-exp: Increment timeouts counter when the original request exceeds cutoff and causes a backup request to be issued in BackupRequestFilter\n\nProblem\n\nWhen the original request exceeds cutoff and causes a backup request to be issued, BackupRequestFilter forgets to increment the 'timeouts' counter.\n\nSolution\n\nIncrement the counter right before issuing the backup request.\n\nRB_ID=758716","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/462bbcf7a53769ce6452bde86f7e6c391504f683"},{"sha":"8adde8077b3d8939386d0f0cee23c9f2282b9d10","author":{"email":"eff0e6b3b55c42f655c864be9b27028ce9b2d31b@twitter.com","name":"Vladimir Kostyukov"},"message":"finagle-http: Add vkostyukov to the finagle-http owners\n\nRB_ID=758804","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/8adde8077b3d8939386d0f0cee23c9f2282b9d10"},{"sha":"c334cc3e6086e1173afd17cf632e00081cb404e8","author":{"email":"24a54edd064a4908b8cc046e2ca1a8dcab73c61c@twitter.com","name":"Kevin Oliver"},"message":"finagle-core: DefaultMonitor respects Failure.logLevel\n\nMotivation\n\nExceptions that propagate to the default `Monitor` became logged at\nWarning level. This lead to excessive logging for `BackupRequestLost`.\n\nSolution\n\n`DefaultMonitor` is now the default `Monitor` and it respects\n`Failure.logLevel`. This also necessitated a change so that\n`BackupRequestLost` is no longer a singleton Exception. Instead, use\n`BackupRequestLost.Exception`.\n\nRB_ID=758056","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/c334cc3e6086e1173afd17cf632e00081cb404e8"},{"sha":"f10f2d76142eb9a273b5cf6b689c6ca5c42e82ab","author":{"email":"eff0e6b3b55c42f655c864be9b27028ce9b2d31b@twitter.com","name":"Vladimir Kostyukov"},"message":"util-stats: Remove deprecated methods on StatsReceiver\n\nRB_ID=757414\nTBR=true","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/f10f2d76142eb9a273b5cf6b689c6ca5c42e82ab"},{"sha":"5558d648a261f5f6b5c7b2912f67dbcda46ec55f","author":{"email":"7047f4780c29ac24150c1010b697fe8556488e80@twitter.com","name":"Alex Leong"},"message":"finagle-core: Add a serveAndAnnounce variant that accepts a SocketAddress.\n\nProblem\nServer#serveAndAnnounce does not have a variant that accepts a SocketAddress.\n\nSolution\nAdd a Server#serveAndAnnounce variant that accepts a SocketAddress.\n\nRB_ID=758862","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/5558d648a261f5f6b5c7b2912f67dbcda46ec55f"},{"sha":"571bbe4a0168f582d725698ca8880321d465618d","author":{"email":"eff0e6b3b55c42f655c864be9b27028ce9b2d31b@twitter.com","name":"Vladimir Kostyukov"},"message":"finagle-http: Convert unhandled exceptions into 500s\n\nProblem\nAny unhandled excpetion from the HTTP stack results into\na closed channel (drops connection) instead of sending out\na very basic HTTP 500 response.\n\nSolution\nTurn any unhandled exceptions into 500s.\n\nResult\nHTTP services buit with Finagle behave healthier in the\ndefault configuration.\n\nRB_ID=755846","distinct":true,"url":"https://api.github.com/repos/zfy0701/finagle/commits/571bbe4a0168f582d725698ca8880321d465618d"}]}