{"action":"created","comment":{"url":"https://api.github.com/repos/hhvm/oss-performance/pulls/comments/28704895","id":28704895,"diff_hunk":"@@ -91,12 +91,10 @@ protected function getArguments(): Vector<string> {\n     if (!$this->options->noTimeLimit) {\n       $arguments = Vector {\n         // See Siege::getExecutablePath()  - these arguments get passed to\n-        // 'timeout'\n-        '-k', '5m',\n         '5m',\n         parent::getExecutablePath(),\n       };\n-    };\n+    }","path":"base/Siege.php","position":12,"original_position":10,"commit_id":"41ffdb8ff5bb642e67e1565a11ad54c9c4369f6d","original_commit_id":"d675b72f42d2ab7eea8b585a9b76da383fe1b283","user":{"login":"fredemmott","id":360927,"avatar_url":"https://avatars.githubusercontent.com/u/360927?v=3","gravatar_id":"","url":"https://api.github.com/users/fredemmott","html_url":"https://github.com/fredemmott","followers_url":"https://api.github.com/users/fredemmott/followers","following_url":"https://api.github.com/users/fredemmott/following{/other_user}","gists_url":"https://api.github.com/users/fredemmott/gists{/gist_id}","starred_url":"https://api.github.com/users/fredemmott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredemmott/subscriptions","organizations_url":"https://api.github.com/users/fredemmott/orgs","repos_url":"https://api.github.com/users/fredemmott/repos","events_url":"https://api.github.com/users/fredemmott/events{/privacy}","received_events_url":"https://api.github.com/users/fredemmott/received_events","type":"User","site_admin":false},"body":"This isn't ideal :( we could put timeout in timeout? :p","created_at":"2015-04-20T16:34:23Z","updated_at":"2015-04-20T16:34:23Z","html_url":"https://github.com/hhvm/oss-performance/pull/28#discussion_r28704895","pull_request_url":"https://api.github.com/repos/hhvm/oss-performance/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/hhvm/oss-performance/pulls/comments/28704895"},"html":{"href":"https://github.com/hhvm/oss-performance/pull/28#discussion_r28704895"},"pull_request":{"href":"https://api.github.com/repos/hhvm/oss-performance/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/hhvm/oss-performance/pulls/28","id":33637585,"html_url":"https://github.com/hhvm/oss-performance/pull/28","diff_url":"https://github.com/hhvm/oss-performance/pull/28.diff","patch_url":"https://github.com/hhvm/oss-performance/pull/28.patch","issue_url":"https://api.github.com/repos/hhvm/oss-performance/issues/28","number":28,"state":"open","locked":false,"title":"Add new profling options for Facebook/hhvm","user":{"login":"paulbiss","id":1039792,"avatar_url":"https://avatars.githubusercontent.com/u/1039792?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbiss","html_url":"https://github.com/paulbiss","followers_url":"https://api.github.com/users/paulbiss/followers","following_url":"https://api.github.com/users/paulbiss/following{/other_user}","gists_url":"https://api.github.com/users/paulbiss/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbiss/subscriptions","organizations_url":"https://api.github.com/users/paulbiss/orgs","repos_url":"https://api.github.com/users/paulbiss/repos","events_url":"https://api.github.com/users/paulbiss/events{/privacy}","received_events_url":"https://api.github.com/users/paulbiss/received_events","type":"User","site_admin":false},"body":"Summary: This is commit adds a hand full of convenience options for:\r\n- Enabling/disabling the FileCache and RepoAuthoritative mode during profiling\r\n- Generating TCDumps (optionally of the top functions/translations)\r\n- Profiling bytecodes (as opposed to PHP functions)\r\n- Keeping the server on online after profiling is complete\r\n- Running repo-mode with AllVolatile enabled (hoisting is technically broken...sigh)\r\n- Adjusting the PCRE caching scheme, and cache size\r\n- Dumping the contents of the PCRE cache\r\n- Interpreting all pseudomains (guard relaxation is broken for pseudomains...sigh)\r\n- fbcode option to use an fbcode build of hhvm/tc-print (the latter being for TCDumps)\r\n\r\nThe following changes were also made:\r\n- Run 300 serial warmup requests\r\n- Run one round of parallel requests before benchmarking\r\n- Write the pid file path to nginx.conf (useful for testing)\r\n- Remove the check for connectivity in wordpress (was unnecessary, and proxies suck)\r\n- Remove the -k option for timeout (not supported on devservers)\r\n\r\nThe following is still broken on devservers:\r\n- Cannot create databases with MyISAM tables (not sure of the best fix but we do need to fix this)\r\n\r\nThe following features would be useful in a followup PR:\r\n- Option to run linux perf tool\r\n- Option to run rollup tool (integrated with fbcode option)\r\n- Option to dump repo\r\n- Option to dump file-cache\r\n\r\nThe additional warmup time was added after inspecting the tc-filling behavior and discovering that tc size was still dramatically increasing after 50 warmup requests. The additional serial warmup requests ensure near optimal tc layout, while the extra complete run of parallel requests is for a handful of frameworks that continue to substantially JIT even after a high volume of single threaded requests (mostly in conjunction with broken pseudomain JITing). While inconvenient the added warmup should ensure better consistency (this was certainly observed in testing). It's also particularly important in repo-auth mode where hot functions are JITed into Ahot after appropriate profiling which may further delay warmup. \r\n\r\nTest Plan: Tested all new options, ran hh_client","created_at":"2015-04-20T06:03:47Z","updated_at":"2015-04-20T16:34:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78019a5d63adf04c8efb87424918f58be8d27367","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hhvm/oss-performance/pulls/28/commits","review_comments_url":"https://api.github.com/repos/hhvm/oss-performance/pulls/28/comments","review_comment_url":"https://api.github.com/repos/hhvm/oss-performance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hhvm/oss-performance/issues/28/comments","statuses_url":"https://api.github.com/repos/hhvm/oss-performance/statuses/41ffdb8ff5bb642e67e1565a11ad54c9c4369f6d","head":{"label":"paulbiss:perf-options","ref":"perf-options","sha":"41ffdb8ff5bb642e67e1565a11ad54c9c4369f6d","user":{"login":"paulbiss","id":1039792,"avatar_url":"https://avatars.githubusercontent.com/u/1039792?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbiss","html_url":"https://github.com/paulbiss","followers_url":"https://api.github.com/users/paulbiss/followers","following_url":"https://api.github.com/users/paulbiss/following{/other_user}","gists_url":"https://api.github.com/users/paulbiss/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbiss/subscriptions","organizations_url":"https://api.github.com/users/paulbiss/orgs","repos_url":"https://api.github.com/users/paulbiss/repos","events_url":"https://api.github.com/users/paulbiss/events{/privacy}","received_events_url":"https://api.github.com/users/paulbiss/received_events","type":"User","site_admin":false},"repo":{"id":34239899,"name":"oss-performance","full_name":"paulbiss/oss-performance","owner":{"login":"paulbiss","id":1039792,"avatar_url":"https://avatars.githubusercontent.com/u/1039792?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbiss","html_url":"https://github.com/paulbiss","followers_url":"https://api.github.com/users/paulbiss/followers","following_url":"https://api.github.com/users/paulbiss/following{/other_user}","gists_url":"https://api.github.com/users/paulbiss/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbiss/subscriptions","organizations_url":"https://api.github.com/users/paulbiss/orgs","repos_url":"https://api.github.com/users/paulbiss/repos","events_url":"https://api.github.com/users/paulbiss/events{/privacy}","received_events_url":"https://api.github.com/users/paulbiss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulbiss/oss-performance","description":"Scripts for benchmarking various PHP implementations when running open source software.","fork":true,"url":"https://api.github.com/repos/paulbiss/oss-performance","forks_url":"https://api.github.com/repos/paulbiss/oss-performance/forks","keys_url":"https://api.github.com/repos/paulbiss/oss-performance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulbiss/oss-performance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulbiss/oss-performance/teams","hooks_url":"https://api.github.com/repos/paulbiss/oss-performance/hooks","issue_events_url":"https://api.github.com/repos/paulbiss/oss-performance/issues/events{/number}","events_url":"https://api.github.com/repos/paulbiss/oss-performance/events","assignees_url":"https://api.github.com/repos/paulbiss/oss-performance/assignees{/user}","branches_url":"https://api.github.com/repos/paulbiss/oss-performance/branches{/branch}","tags_url":"https://api.github.com/repos/paulbiss/oss-performance/tags","blobs_url":"https://api.github.com/repos/paulbiss/oss-performance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulbiss/oss-performance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulbiss/oss-performance/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulbiss/oss-performance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulbiss/oss-performance/statuses/{sha}","languages_url":"https://api.github.com/repos/paulbiss/oss-performance/languages","stargazers_url":"https://api.github.com/repos/paulbiss/oss-performance/stargazers","contributors_url":"https://api.github.com/repos/paulbiss/oss-performance/contributors","subscribers_url":"https://api.github.com/repos/paulbiss/oss-performance/subscribers","subscription_url":"https://api.github.com/repos/paulbiss/oss-performance/subscription","commits_url":"https://api.github.com/repos/paulbiss/oss-performance/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulbiss/oss-performance/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulbiss/oss-performance/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulbiss/oss-performance/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulbiss/oss-performance/contents/{+path}","compare_url":"https://api.github.com/repos/paulbiss/oss-performance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulbiss/oss-performance/merges","archive_url":"https://api.github.com/repos/paulbiss/oss-performance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulbiss/oss-performance/downloads","issues_url":"https://api.github.com/repos/paulbiss/oss-performance/issues{/number}","pulls_url":"https://api.github.com/repos/paulbiss/oss-performance/pulls{/number}","milestones_url":"https://api.github.com/repos/paulbiss/oss-performance/milestones{/number}","notifications_url":"https://api.github.com/repos/paulbiss/oss-performance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulbiss/oss-performance/labels{/name}","releases_url":"https://api.github.com/repos/paulbiss/oss-performance/releases{/id}","created_at":"2015-04-20T05:28:08Z","updated_at":"2015-04-20T05:28:09Z","pushed_at":"2015-04-20T15:45:56Z","git_url":"git://github.com/paulbiss/oss-performance.git","ssh_url":"git@github.com:paulbiss/oss-performance.git","clone_url":"https://github.com/paulbiss/oss-performance.git","svn_url":"https://github.com/paulbiss/oss-performance","homepage":null,"size":96216,"stargazers_count":0,"watchers_count":0,"language":"Hack","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hhvm:master","ref":"master","sha":"3b33a20e082ed4ff2d44db64b3b26832e741ebef","user":{"login":"hhvm","id":4553654,"avatar_url":"https://avatars.githubusercontent.com/u/4553654?v=3","gravatar_id":"","url":"https://api.github.com/users/hhvm","html_url":"https://github.com/hhvm","followers_url":"https://api.github.com/users/hhvm/followers","following_url":"https://api.github.com/users/hhvm/following{/other_user}","gists_url":"https://api.github.com/users/hhvm/gists{/gist_id}","starred_url":"https://api.github.com/users/hhvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhvm/subscriptions","organizations_url":"https://api.github.com/users/hhvm/orgs","repos_url":"https://api.github.com/users/hhvm/repos","events_url":"https://api.github.com/users/hhvm/events{/privacy}","received_events_url":"https://api.github.com/users/hhvm/received_events","type":"Organization","site_admin":false},"repo":{"id":24893187,"name":"oss-performance","full_name":"hhvm/oss-performance","owner":{"login":"hhvm","id":4553654,"avatar_url":"https://avatars.githubusercontent.com/u/4553654?v=3","gravatar_id":"","url":"https://api.github.com/users/hhvm","html_url":"https://github.com/hhvm","followers_url":"https://api.github.com/users/hhvm/followers","following_url":"https://api.github.com/users/hhvm/following{/other_user}","gists_url":"https://api.github.com/users/hhvm/gists{/gist_id}","starred_url":"https://api.github.com/users/hhvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhvm/subscriptions","organizations_url":"https://api.github.com/users/hhvm/orgs","repos_url":"https://api.github.com/users/hhvm/repos","events_url":"https://api.github.com/users/hhvm/events{/privacy}","received_events_url":"https://api.github.com/users/hhvm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hhvm/oss-performance","description":"Scripts for benchmarking various PHP implementations when running open source software.","fork":false,"url":"https://api.github.com/repos/hhvm/oss-performance","forks_url":"https://api.github.com/repos/hhvm/oss-performance/forks","keys_url":"https://api.github.com/repos/hhvm/oss-performance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhvm/oss-performance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhvm/oss-performance/teams","hooks_url":"https://api.github.com/repos/hhvm/oss-performance/hooks","issue_events_url":"https://api.github.com/repos/hhvm/oss-performance/issues/events{/number}","events_url":"https://api.github.com/repos/hhvm/oss-performance/events","assignees_url":"https://api.github.com/repos/hhvm/oss-performance/assignees{/user}","branches_url":"https://api.github.com/repos/hhvm/oss-performance/branches{/branch}","tags_url":"https://api.github.com/repos/hhvm/oss-performance/tags","blobs_url":"https://api.github.com/repos/hhvm/oss-performance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhvm/oss-performance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhvm/oss-performance/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhvm/oss-performance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhvm/oss-performance/statuses/{sha}","languages_url":"https://api.github.com/repos/hhvm/oss-performance/languages","stargazers_url":"https://api.github.com/repos/hhvm/oss-performance/stargazers","contributors_url":"https://api.github.com/repos/hhvm/oss-performance/contributors","subscribers_url":"https://api.github.com/repos/hhvm/oss-performance/subscribers","subscription_url":"https://api.github.com/repos/hhvm/oss-performance/subscription","commits_url":"https://api.github.com/repos/hhvm/oss-performance/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhvm/oss-performance/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhvm/oss-performance/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhvm/oss-performance/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhvm/oss-performance/contents/{+path}","compare_url":"https://api.github.com/repos/hhvm/oss-performance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhvm/oss-performance/merges","archive_url":"https://api.github.com/repos/hhvm/oss-performance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhvm/oss-performance/downloads","issues_url":"https://api.github.com/repos/hhvm/oss-performance/issues{/number}","pulls_url":"https://api.github.com/repos/hhvm/oss-performance/pulls{/number}","milestones_url":"https://api.github.com/repos/hhvm/oss-performance/milestones{/number}","notifications_url":"https://api.github.com/repos/hhvm/oss-performance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhvm/oss-performance/labels{/name}","releases_url":"https://api.github.com/repos/hhvm/oss-performance/releases{/id}","created_at":"2014-10-07T14:10:34Z","updated_at":"2015-04-17T17:26:37Z","pushed_at":"2015-04-20T15:45:56Z","git_url":"git://github.com/hhvm/oss-performance.git","ssh_url":"git@github.com:hhvm/oss-performance.git","clone_url":"https://github.com/hhvm/oss-performance.git","svn_url":"https://github.com/hhvm/oss-performance","homepage":null,"size":96216,"stargazers_count":33,"watchers_count":33,"language":"Hack","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hhvm/oss-performance/pulls/28"},"html":{"href":"https://github.com/hhvm/oss-performance/pull/28"},"issue":{"href":"https://api.github.com/repos/hhvm/oss-performance/issues/28"},"comments":{"href":"https://api.github.com/repos/hhvm/oss-performance/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/hhvm/oss-performance/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/hhvm/oss-performance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hhvm/oss-performance/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/hhvm/oss-performance/statuses/41ffdb8ff5bb642e67e1565a11ad54c9c4369f6d"}}}}