{"action":"closed","number":186,"pull_request":{"url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/186","id":27976692,"html_url":"https://github.com/letsencrypt/lets-encrypt-preview/pull/186","diff_url":"https://github.com/letsencrypt/lets-encrypt-preview/pull/186.diff","patch_url":"https://github.com/letsencrypt/lets-encrypt-preview/pull/186.patch","issue_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/186","number":186,"state":"closed","locked":false,"title":"Pylint 10/10","user":{"login":"kuba","id":106176,"avatar_url":"https://avatars.githubusercontent.com/u/106176?v=3","gravatar_id":"","url":"https://api.github.com/users/kuba","html_url":"https://github.com/kuba","followers_url":"https://api.github.com/users/kuba/followers","following_url":"https://api.github.com/users/kuba/following{/other_user}","gists_url":"https://api.github.com/users/kuba/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba/subscriptions","organizations_url":"https://api.github.com/users/kuba/orgs","repos_url":"https://api.github.com/users/kuba/repos","events_url":"https://api.github.com/users/kuba/events{/privacy}","received_events_url":"https://api.github.com/users/kuba/received_events","type":"User","site_admin":false},"body":"Fixes #178.\r\n\r\nChanges to .pylintrc:\r\n- longer function/method names (especially important for unit tests)\r\n- docstrings unnecessary for unittest classes\r\n- `unused_` prefix for unused arguments\r\n- allow locally disabling pylint messages\r\n- disable warnings on \"fixme\" comments\r\n\r\nFixed remaining pylint errors and decided to locally disable `missing-docstring` to make Travis happily green :) This way only new offending code will fail. At the same time, we should strive to replace `# pylint: disable missing-docstring` with meaningful docstrings. Since you know the code the most, @jdkasten, would you be able to fix this? Provided PR is accepted I will create necessary tracking bug report.","created_at":"2015-01-24T13:49:45Z","updated_at":"2015-01-25T03:17:57Z","closed_at":"2015-01-25T03:17:57Z","merged_at":"2015-01-25T03:17:57Z","merge_commit_sha":"4f1be4a8fde91474d39640ae49174f455e332a5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/186/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/186/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/comments/{number}","comments_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/186/comments","statuses_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/statuses/f12ef3b933932db9dc84a6374d9ca9bbaf87d8da","head":{"label":"kuba:pylint","ref":"pylint","sha":"f12ef3b933932db9dc84a6374d9ca9bbaf87d8da","user":{"login":"kuba","id":106176,"avatar_url":"https://avatars.githubusercontent.com/u/106176?v=3","gravatar_id":"","url":"https://api.github.com/users/kuba","html_url":"https://github.com/kuba","followers_url":"https://api.github.com/users/kuba/followers","following_url":"https://api.github.com/users/kuba/following{/other_user}","gists_url":"https://api.github.com/users/kuba/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba/subscriptions","organizations_url":"https://api.github.com/users/kuba/orgs","repos_url":"https://api.github.com/users/kuba/repos","events_url":"https://api.github.com/users/kuba/events{/privacy}","received_events_url":"https://api.github.com/users/kuba/received_events","type":"User","site_admin":false},"repo":{"id":26831060,"name":"lets-encrypt-preview","full_name":"kuba/lets-encrypt-preview","owner":{"login":"kuba","id":106176,"avatar_url":"https://avatars.githubusercontent.com/u/106176?v=3","gravatar_id":"","url":"https://api.github.com/users/kuba","html_url":"https://github.com/kuba","followers_url":"https://api.github.com/users/kuba/followers","following_url":"https://api.github.com/users/kuba/following{/other_user}","gists_url":"https://api.github.com/users/kuba/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba/subscriptions","organizations_url":"https://api.github.com/users/kuba/orgs","repos_url":"https://api.github.com/users/kuba/repos","events_url":"https://api.github.com/users/kuba/events{/privacy}","received_events_url":"https://api.github.com/users/kuba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kuba/lets-encrypt-preview","description":"An ACME client that can update Apache configurations (developer preview) ","fork":true,"url":"https://api.github.com/repos/kuba/lets-encrypt-preview","forks_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/forks","keys_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/teams","hooks_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/hooks","issue_events_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/issues/events{/number}","events_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/events","assignees_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/assignees{/user}","branches_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/branches{/branch}","tags_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/tags","blobs_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/statuses/{sha}","languages_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/languages","stargazers_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/stargazers","contributors_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/contributors","subscribers_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/subscribers","subscription_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/subscription","commits_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/issues/comments/{number}","contents_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/contents/{+path}","compare_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/merges","archive_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/downloads","issues_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/issues{/number}","pulls_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/pulls{/number}","milestones_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/milestones{/number}","notifications_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/labels{/name}","releases_url":"https://api.github.com/repos/kuba/lets-encrypt-preview/releases{/id}","created_at":"2014-11-18T21:34:04Z","updated_at":"2014-12-23T10:40:56Z","pushed_at":"2015-01-24T20:35:25Z","git_url":"git://github.com/kuba/lets-encrypt-preview.git","ssh_url":"git@github.com:kuba/lets-encrypt-preview.git","clone_url":"https://github.com/kuba/lets-encrypt-preview.git","svn_url":"https://github.com/kuba/lets-encrypt-preview","homepage":null,"size":1923,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"5fa42b200a61fec15001cdf1e3225c9b7d58cd5d","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"lets-encrypt-preview","full_name":"letsencrypt/lets-encrypt-preview","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/lets-encrypt-preview","description":"An ACME client that can update Apache configurations (developer preview) ","fork":false,"url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview","forks_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/forks","keys_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/teams","hooks_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/events","assignees_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/tags","blobs_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/subscription","commits_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/comments/{number}","contents_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/merges","archive_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/downloads","issues_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/releases{/id}","created_at":"2014-11-12T02:52:20Z","updated_at":"2015-01-25T03:17:58Z","pushed_at":"2015-01-25T03:17:57Z","git_url":"git://github.com/letsencrypt/lets-encrypt-preview.git","ssh_url":"git@github.com:letsencrypt/lets-encrypt-preview.git","clone_url":"https://github.com/letsencrypt/lets-encrypt-preview.git","svn_url":"https://github.com/letsencrypt/lets-encrypt-preview","homepage":null,"size":3476,"stargazers_count":1326,"watchers_count":1326,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":39,"forks":88,"open_issues":39,"watchers":1326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/186"},"html":{"href":"https://github.com/letsencrypt/lets-encrypt-preview/pull/186"},"issue":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/186"},"comments":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/lets-encrypt-preview/statuses/f12ef3b933932db9dc84a6374d9ca9bbaf87d8da"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jdkasten","id":1581662,"avatar_url":"https://avatars.githubusercontent.com/u/1581662?v=3","gravatar_id":"","url":"https://api.github.com/users/jdkasten","html_url":"https://github.com/jdkasten","followers_url":"https://api.github.com/users/jdkasten/followers","following_url":"https://api.github.com/users/jdkasten/following{/other_user}","gists_url":"https://api.github.com/users/jdkasten/gists{/gist_id}","starred_url":"https://api.github.com/users/jdkasten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdkasten/subscriptions","organizations_url":"https://api.github.com/users/jdkasten/orgs","repos_url":"https://api.github.com/users/jdkasten/repos","events_url":"https://api.github.com/users/jdkasten/events{/privacy}","received_events_url":"https://api.github.com/users/jdkasten/received_events","type":"User","site_admin":false},"comments":4,"review_comments":14,"commits":11,"additions":187,"deletions":182,"changed_files":26}}