{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/4810","labels_url":"https://api.github.com/repos/openshift/origin/issues/4810/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4810/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/4810/events","html_url":"https://github.com/openshift/origin/issues/4810","id":108435851,"number":4810,"title":"Build Labels are not namespaced","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-26T03:02:19Z","updated_at":"2015-09-28T13:57:32Z","closed_at":null,"body":"After creating a build, if you look at the contents:\r\n```sh\r\n$ oc get build openldap-2 -o json\r\n{\r\n    \"kind\": \"Build\",\r\n    \"apiVersion\": \"v1\",\r\n    \"metadata\": {\r\n        \"name\": \"openldap-2\",\r\n        \"namespace\": \"ldap\",\r\n        \"selfLink\": \"/oapi/v1/namespaces/ldap/builds/openldap-2\",\r\n        \"uid\": \"9c4bd9e5-63fa-11e5-94a4-54ee753e2644\",\r\n        \"resourceVersion\": \"3674\",\r\n        \"creationTimestamp\": \"2015-09-26T02:59:31Z\",\r\n        \"labels\": {\r\n            \"buildconfig\": \"openldap\",\r\n            \"name\": \"openldap\"\r\n        },\r\n        \"annotations\": {\r\n            \"openshift.io/build.number\": \"2\"\r\n        }\r\n    },\r\n```\r\n\r\nLabels are not namespaced with `openshift.io`, whereas the annotations are. Should both be?\r\ncc: @bparees @csrwng "},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/143750397","html_url":"https://github.com/openshift/origin/issues/4810#issuecomment-143750397","issue_url":"https://api.github.com/repos/openshift/origin/issues/4810","id":143750397,"user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T13:57:32Z","updated_at":"2015-09-28T13:57:32Z","body":">  If we are going to switch anyway, should we be using a label or an annotation?\r\n\r\ni think we still want the buildconfig to be a label since it's a grouping concept.  the name..well it was probably done as a label originally also to aid in selection/grouping, but i think that's more an artifact of us not having a selector for annotations than it making logical sense as a label.\r\n\r\n@csrwng makes a good point about whether we namespace labels elsewhere and that's probably why we didn't do it here, but i don't know that that means we chose correctly in the other places either.\r\n\r\nprobably need to pull @smarterclayton in to assess if this is something we'd want to change.  the OCD side of me does like the idea of namespacing them.\r\n"}}