{"action":"opened","number":226,"pull_request":{"url":"https://api.github.com/repos/buildout/buildout/pulls/226","id":26937027,"html_url":"https://github.com/buildout/buildout/pull/226","diff_url":"https://github.com/buildout/buildout/pull/226.diff","patch_url":"https://github.com/buildout/buildout/pull/226.patch","issue_url":"https://api.github.com/repos/buildout/buildout/issues/226","number":226,"state":"open","locked":false,"title":"Fix for issue 176: extends with increments can result in missing values","user":{"login":"distributist","id":9948535,"avatar_url":"https://avatars.githubusercontent.com/u/9948535?v=3","gravatar_id":"","url":"https://api.github.com/users/distributist","html_url":"https://github.com/distributist","followers_url":"https://api.github.com/users/distributist/followers","following_url":"https://api.github.com/users/distributist/following{/other_user}","gists_url":"https://api.github.com/users/distributist/gists{/gist_id}","starred_url":"https://api.github.com/users/distributist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/distributist/subscriptions","organizations_url":"https://api.github.com/users/distributist/orgs","repos_url":"https://api.github.com/users/distributist/repos","events_url":"https://api.github.com/users/distributist/events{/privacy}","received_events_url":"https://api.github.com/users/distributist/received_events","type":"User","site_admin":false},"body":"This is a suggested fix for issue 176. I've added a test case based on the one presented in that issue, but have expanded it to test various combinations of operations. \r\n\r\nThe basic approach is to parse all the extended files before applying them, so that nothing gets lost along the way. Additionally, all annotations are kept so that even if a = overrides previous settings, the operation is captured so the problem can more easily be found.\r\n\r\nI believe the fix behaves consistently, so that =, -= and += behave as expected within the order of extends operations. As the test case shows, you can do some stupid things, but it does them consistently. ;-)","created_at":"2015-01-07T04:20:36Z","updated_at":"2015-01-07T04:20:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildout/buildout/pulls/226/commits","review_comments_url":"https://api.github.com/repos/buildout/buildout/pulls/226/comments","review_comment_url":"https://api.github.com/repos/buildout/buildout/pulls/comments/{number}","comments_url":"https://api.github.com/repos/buildout/buildout/issues/226/comments","statuses_url":"https://api.github.com/repos/buildout/buildout/statuses/49a3908c66f96ecbfd9d2ebb80a038b00ee6629f","head":{"label":"whtc:master","ref":"master","sha":"49a3908c66f96ecbfd9d2ebb80a038b00ee6629f","user":{"login":"whtc","id":9948544,"avatar_url":"https://avatars.githubusercontent.com/u/9948544?v=3","gravatar_id":"","url":"https://api.github.com/users/whtc","html_url":"https://github.com/whtc","followers_url":"https://api.github.com/users/whtc/followers","following_url":"https://api.github.com/users/whtc/following{/other_user}","gists_url":"https://api.github.com/users/whtc/gists{/gist_id}","starred_url":"https://api.github.com/users/whtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whtc/subscriptions","organizations_url":"https://api.github.com/users/whtc/orgs","repos_url":"https://api.github.com/users/whtc/repos","events_url":"https://api.github.com/users/whtc/events{/privacy}","received_events_url":"https://api.github.com/users/whtc/received_events","type":"Organization","site_admin":false},"repo":{"id":28897402,"name":"buildout","full_name":"whtc/buildout","owner":{"login":"whtc","id":9948544,"avatar_url":"https://avatars.githubusercontent.com/u/9948544?v=3","gravatar_id":"","url":"https://api.github.com/users/whtc","html_url":"https://github.com/whtc","followers_url":"https://api.github.com/users/whtc/followers","following_url":"https://api.github.com/users/whtc/following{/other_user}","gists_url":"https://api.github.com/users/whtc/gists{/gist_id}","starred_url":"https://api.github.com/users/whtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whtc/subscriptions","organizations_url":"https://api.github.com/users/whtc/orgs","repos_url":"https://api.github.com/users/whtc/repos","events_url":"https://api.github.com/users/whtc/events{/privacy}","received_events_url":"https://api.github.com/users/whtc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whtc/buildout","description":"","fork":true,"url":"https://api.github.com/repos/whtc/buildout","forks_url":"https://api.github.com/repos/whtc/buildout/forks","keys_url":"https://api.github.com/repos/whtc/buildout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whtc/buildout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whtc/buildout/teams","hooks_url":"https://api.github.com/repos/whtc/buildout/hooks","issue_events_url":"https://api.github.com/repos/whtc/buildout/issues/events{/number}","events_url":"https://api.github.com/repos/whtc/buildout/events","assignees_url":"https://api.github.com/repos/whtc/buildout/assignees{/user}","branches_url":"https://api.github.com/repos/whtc/buildout/branches{/branch}","tags_url":"https://api.github.com/repos/whtc/buildout/tags","blobs_url":"https://api.github.com/repos/whtc/buildout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whtc/buildout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whtc/buildout/git/refs{/sha}","trees_url":"https://api.github.com/repos/whtc/buildout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whtc/buildout/statuses/{sha}","languages_url":"https://api.github.com/repos/whtc/buildout/languages","stargazers_url":"https://api.github.com/repos/whtc/buildout/stargazers","contributors_url":"https://api.github.com/repos/whtc/buildout/contributors","subscribers_url":"https://api.github.com/repos/whtc/buildout/subscribers","subscription_url":"https://api.github.com/repos/whtc/buildout/subscription","commits_url":"https://api.github.com/repos/whtc/buildout/commits{/sha}","git_commits_url":"https://api.github.com/repos/whtc/buildout/git/commits{/sha}","comments_url":"https://api.github.com/repos/whtc/buildout/comments{/number}","issue_comment_url":"https://api.github.com/repos/whtc/buildout/issues/comments/{number}","contents_url":"https://api.github.com/repos/whtc/buildout/contents/{+path}","compare_url":"https://api.github.com/repos/whtc/buildout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whtc/buildout/merges","archive_url":"https://api.github.com/repos/whtc/buildout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whtc/buildout/downloads","issues_url":"https://api.github.com/repos/whtc/buildout/issues{/number}","pulls_url":"https://api.github.com/repos/whtc/buildout/pulls{/number}","milestones_url":"https://api.github.com/repos/whtc/buildout/milestones{/number}","notifications_url":"https://api.github.com/repos/whtc/buildout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whtc/buildout/labels{/name}","releases_url":"https://api.github.com/repos/whtc/buildout/releases{/id}","created_at":"2015-01-07T03:56:47Z","updated_at":"2015-01-07T04:11:08Z","pushed_at":"2015-01-07T04:11:07Z","git_url":"git://github.com/whtc/buildout.git","ssh_url":"git@github.com:whtc/buildout.git","clone_url":"https://github.com/whtc/buildout.git","svn_url":"https://github.com/whtc/buildout","homepage":"www.buildout.org","size":5729,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buildout:master","ref":"master","sha":"f4dad6b6241b850b64cc29e2283c6ebf72e9d02f","user":{"login":"buildout","id":1574305,"avatar_url":"https://avatars.githubusercontent.com/u/1574305?v=3","gravatar_id":"","url":"https://api.github.com/users/buildout","html_url":"https://github.com/buildout","followers_url":"https://api.github.com/users/buildout/followers","following_url":"https://api.github.com/users/buildout/following{/other_user}","gists_url":"https://api.github.com/users/buildout/gists{/gist_id}","starred_url":"https://api.github.com/users/buildout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildout/subscriptions","organizations_url":"https://api.github.com/users/buildout/orgs","repos_url":"https://api.github.com/users/buildout/repos","events_url":"https://api.github.com/users/buildout/events{/privacy}","received_events_url":"https://api.github.com/users/buildout/received_events","type":"Organization","site_admin":false},"repo":{"id":3827595,"name":"buildout","full_name":"buildout/buildout","owner":{"login":"buildout","id":1574305,"avatar_url":"https://avatars.githubusercontent.com/u/1574305?v=3","gravatar_id":"","url":"https://api.github.com/users/buildout","html_url":"https://github.com/buildout","followers_url":"https://api.github.com/users/buildout/followers","following_url":"https://api.github.com/users/buildout/following{/other_user}","gists_url":"https://api.github.com/users/buildout/gists{/gist_id}","starred_url":"https://api.github.com/users/buildout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildout/subscriptions","organizations_url":"https://api.github.com/users/buildout/orgs","repos_url":"https://api.github.com/users/buildout/repos","events_url":"https://api.github.com/users/buildout/events{/privacy}","received_events_url":"https://api.github.com/users/buildout/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildout/buildout","description":"","fork":false,"url":"https://api.github.com/repos/buildout/buildout","forks_url":"https://api.github.com/repos/buildout/buildout/forks","keys_url":"https://api.github.com/repos/buildout/buildout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildout/buildout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildout/buildout/teams","hooks_url":"https://api.github.com/repos/buildout/buildout/hooks","issue_events_url":"https://api.github.com/repos/buildout/buildout/issues/events{/number}","events_url":"https://api.github.com/repos/buildout/buildout/events","assignees_url":"https://api.github.com/repos/buildout/buildout/assignees{/user}","branches_url":"https://api.github.com/repos/buildout/buildout/branches{/branch}","tags_url":"https://api.github.com/repos/buildout/buildout/tags","blobs_url":"https://api.github.com/repos/buildout/buildout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildout/buildout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildout/buildout/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildout/buildout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildout/buildout/statuses/{sha}","languages_url":"https://api.github.com/repos/buildout/buildout/languages","stargazers_url":"https://api.github.com/repos/buildout/buildout/stargazers","contributors_url":"https://api.github.com/repos/buildout/buildout/contributors","subscribers_url":"https://api.github.com/repos/buildout/buildout/subscribers","subscription_url":"https://api.github.com/repos/buildout/buildout/subscription","commits_url":"https://api.github.com/repos/buildout/buildout/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildout/buildout/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildout/buildout/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildout/buildout/issues/comments/{number}","contents_url":"https://api.github.com/repos/buildout/buildout/contents/{+path}","compare_url":"https://api.github.com/repos/buildout/buildout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildout/buildout/merges","archive_url":"https://api.github.com/repos/buildout/buildout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildout/buildout/downloads","issues_url":"https://api.github.com/repos/buildout/buildout/issues{/number}","pulls_url":"https://api.github.com/repos/buildout/buildout/pulls{/number}","milestones_url":"https://api.github.com/repos/buildout/buildout/milestones{/number}","notifications_url":"https://api.github.com/repos/buildout/buildout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildout/buildout/labels{/name}","releases_url":"https://api.github.com/repos/buildout/buildout/releases{/id}","created_at":"2012-03-25T21:47:18Z","updated_at":"2015-01-06T13:34:36Z","pushed_at":"2015-01-06T13:34:34Z","git_url":"git://github.com/buildout/buildout.git","ssh_url":"git@github.com:buildout/buildout.git","clone_url":"https://github.com/buildout/buildout.git","svn_url":"https://github.com/buildout/buildout","homepage":"www.buildout.org","size":5729,"stargazers_count":161,"watchers_count":161,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":93,"forks":89,"open_issues":93,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildout/buildout/pulls/226"},"html":{"href":"https://github.com/buildout/buildout/pull/226"},"issue":{"href":"https://api.github.com/repos/buildout/buildout/issues/226"},"comments":{"href":"https://api.github.com/repos/buildout/buildout/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/buildout/buildout/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/buildout/buildout/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/buildout/buildout/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/buildout/buildout/statuses/49a3908c66f96ecbfd9d2ebb80a038b00ee6629f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":117,"deletions":9,"changed_files":2}}