{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/28909193","id":28909193,"diff_hunk":"@@ -516,6 +550,82 @@ internal void ProcessDto(ModelBindingContext bindingContext, ComplexModelDto dto\n             }\n         }\n \n+        // Neither [DefaultValue] nor [Required] is relevant for a non-settable collection.\n+        private void AddToProperty(\n+            ModelBindingContext bindingContext,\n+            ModelExplorer modelExplorer,\n+            PropertyInfo property,\n+            ModelBindingResult dtoResult)\n+        {\n+            var propertyExplorer = modelExplorer.GetExplorerForProperty(property.Name);\n+\n+            var target = propertyExplorer.Model;\n+            var source = dtoResult.Model;\n+            if (!dtoResult.IsModelSet || target == null || source == null)\n+            {\n+                // Cannot copy to or from a null collection.\n+                return;\n+            }\n+\n+            // Determine T if this is an ICollection<T> property. No need for a T[] case because CanUpdateProperty()\n+            // ensures property is either settable or not an array. Underlying assumption is that CanUpdateProperty()\n+            // and SetProperty() are overridden together.\n+            var elementTypeArray = propertyExplorer.ModelType\n+                .ExtractGenericInterface(typeof(ICollection<>))\n+                ?.GenericTypeArguments;\n+            if (elementTypeArray == null)\n+            {\n+                // Not a collection model.\n+                return;\n+            }\n+\n+            var propertyAddRange = CallPropertyAddRangeOpenGenericMethod.MakeGenericMethod(elementTypeArray);\n+            TryAction(\n+                bindingContext,\n+                dtoResult,\n+                () => propertyAddRange.Invoke(obj: null, parameters: new[] { target, source }));\n+        }\n+\n+        // Called via reflection.\n+        private static void CallPropertyAddRange<TElement>(object target, object source)\n+        {\n+            var targetCollection = (ICollection<TElement>)target;\n+            var sourceCollection = source as IEnumerable<TElement>;\n+            if (sourceCollection != null && !targetCollection.IsReadOnly)\n+            {\n+                targetCollection.Clear();\n+                foreach (var item in sourceCollection)\n+                {\n+                    targetCollection.Add(item);\n+                }\n+            }\n+        }\n+\n+        private static void TryAction(ModelBindingContext bindingContext, ModelBindingResult dtoResult, Action action)\n+        {\n+            try\n+            {\n+                action();","path":"src/Microsoft.AspNet.Mvc.ModelBinding/Binders/MutableObjectModelBinder.cs","position":220,"original_position":220,"commit_id":"555093e650c942e330ef92b36fdf0de086dc2210","original_commit_id":"555093e650c942e330ef92b36fdf0de086dc2210","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars.githubusercontent.com/u/1430011?v=3","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"I'm really not a big fan of this pattern because it makes the debugging experience pretty poor.  How would you feel about factoring out the code inside the catch block to a private method instead?","created_at":"2015-04-22T20:02:26Z","updated_at":"2015-04-22T20:02:26Z","html_url":"https://github.com/aspnet/Mvc/pull/2405#discussion_r28909193","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2405","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/28909193"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2405#discussion_r28909193"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2405"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/2405","id":33624100,"html_url":"https://github.com/aspnet/Mvc/pull/2405","diff_url":"https://github.com/aspnet/Mvc/pull/2405.diff","patch_url":"https://github.com/aspnet/Mvc/pull/2405.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/2405","number":2405,"state":"open","locked":false,"title":"Bind to readonly non-`null` collections","user":{"login":"dougbu","id":6431421,"avatar_url":"https://avatars.githubusercontent.com/u/6431421?v=3","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"body":"- parts 1/3 and 2/3 of #2294\r\n- fill readonly gaps in `CollectionModelBinder` and `MutableObjectModelBinder`\r\n - `CollectionModelBinder.CopyToModel()` and `MutableObjectModelBinder.AddToProperty()` methods\r\n - add `CopyToModel()` override in `ArrayModelBinder`\r\n- avoid NREs in `GetModel()` overrides\r\n\r\nTest handling of readonly collections\r\n- previous tests barely touched this scenario\r\n\r\nnits:\r\n- add missing `[NotNull]` attributes\r\n- add missing doc comments\r\n- consolidate a few `[Fact]`s into `[Theory]`s\r\n- simplify some wrapping; shorten a few lines","created_at":"2015-04-19T19:15:01Z","updated_at":"2015-04-22T20:02:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9056dd691c21accc3290d5d38b70305c113bc61d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2405/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2405/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/2405/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/555093e650c942e330ef92b36fdf0de086dc2210","head":{"label":"aspnet:dougbu/model.binding.gaps.2294","ref":"dougbu/model.binding.gaps.2294","sha":"555093e650c942e330ef92b36fdf0de086dc2210","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-04-22T19:51:24Z","pushed_at":"2015-04-22T19:51:24Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":112783,"stargazers_count":1630,"watchers_count":1630,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":538,"mirror_url":null,"open_issues_count":227,"forks":538,"open_issues":227,"watchers":1630,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"323ec2fdc7de3f86ce707d95fcdf887adcea35fe","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-04-22T19:51:24Z","pushed_at":"2015-04-22T19:51:24Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":112783,"stargazers_count":1630,"watchers_count":1630,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":538,"mirror_url":null,"open_issues_count":227,"forks":538,"open_issues":227,"watchers":1630,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2405"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2405"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2405"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2405/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2405/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2405/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/555093e650c942e330ef92b36fdf0de086dc2210"}}}}