{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/44884026","id":44884026,"diff_hunk":"@@ -372,6 +372,8 @@\n \t\t<Unit filename=\"src/coordinates.h\" />\n \t\t<Unit filename=\"src/crafting.cpp\" />\n \t\t<Unit filename=\"src/crafting.h\" />\n+\t\t<Unit filename=\"src/crafting_GUI.cpp\" />","path":"CataclysmWin.cbp","position":4,"original_position":4,"commit_id":"bf3ee07df805b607482f14a9674f9ff94b6622cd","original_commit_id":"bf3ee07df805b607482f14a9674f9ff94b6622cd","user":{"login":"kevingranade","id":860276,"avatar_url":"https://avatars.githubusercontent.com/u/860276?v=3","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"body":"No need to all-caps \"gu\"i, just crafting_ui.bla would fit in better.","created_at":"2015-11-16T02:24:08Z","updated_at":"2015-11-16T02:24:08Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14047#discussion_r44884026","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14047","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/44884026"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14047#discussion_r44884026"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14047"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14047","id":50753754,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14047","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14047.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14047.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14047","number":14047,"state":"open","locked":false,"title":"Put the crafting gui code into it's own module.","user":{"login":"JornVernee","id":5962029,"avatar_url":"https://avatars.githubusercontent.com/u/5962029?v=3","gravatar_id":"","url":"https://api.github.com/users/JornVernee","html_url":"https://github.com/JornVernee","followers_url":"https://api.github.com/users/JornVernee/followers","following_url":"https://api.github.com/users/JornVernee/following{/other_user}","gists_url":"https://api.github.com/users/JornVernee/gists{/gist_id}","starred_url":"https://api.github.com/users/JornVernee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JornVernee/subscriptions","organizations_url":"https://api.github.com/users/JornVernee/orgs","repos_url":"https://api.github.com/users/JornVernee/repos","events_url":"https://api.github.com/users/JornVernee/events{/privacy}","received_events_url":"https://api.github.com/users/JornVernee/received_events","type":"User","site_admin":false},"body":"Let's shorten crafting.cpp further, and separate logic code from gui code.\r\n\r\nI think there's a lot of changes to the gui code that can be made to make it easier to understand/maintain (e.g. splitting the ~300 lines of ```select_crafting_recipe``` into several functions, so we can at the very least keep track of indentation a little better). I think putting it in it's own module is a good first step.\r\n\r\nThe only thing that's kind of weird right now is that the crafting category and crafting sub-category containers are still used by both files. These containers are a part of the model, not the view (imho). It might make sense to put them in the recipe dictionary module.","created_at":"2015-11-15T19:25:28Z","updated_at":"2015-11-16T02:24:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1e25748a5609495caabc62da7adb9a18ca00485","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14047/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14047/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14047/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/bf3ee07df805b607482f14a9674f9ff94b6622cd","head":{"label":"JornVernee:extract-craftingGUI","ref":"extract-craftingGUI","sha":"bf3ee07df805b607482f14a9674f9ff94b6622cd","user":{"login":"JornVernee","id":5962029,"avatar_url":"https://avatars.githubusercontent.com/u/5962029?v=3","gravatar_id":"","url":"https://api.github.com/users/JornVernee","html_url":"https://github.com/JornVernee","followers_url":"https://api.github.com/users/JornVernee/followers","following_url":"https://api.github.com/users/JornVernee/following{/other_user}","gists_url":"https://api.github.com/users/JornVernee/gists{/gist_id}","starred_url":"https://api.github.com/users/JornVernee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JornVernee/subscriptions","organizations_url":"https://api.github.com/users/JornVernee/orgs","repos_url":"https://api.github.com/users/JornVernee/repos","events_url":"https://api.github.com/users/JornVernee/events{/privacy}","received_events_url":"https://api.github.com/users/JornVernee/received_events","type":"User","site_admin":false},"repo":{"id":45788399,"name":"Cataclysm-DDA","full_name":"JornVernee/Cataclysm-DDA","owner":{"login":"JornVernee","id":5962029,"avatar_url":"https://avatars.githubusercontent.com/u/5962029?v=3","gravatar_id":"","url":"https://api.github.com/users/JornVernee","html_url":"https://github.com/JornVernee","followers_url":"https://api.github.com/users/JornVernee/followers","following_url":"https://api.github.com/users/JornVernee/following{/other_user}","gists_url":"https://api.github.com/users/JornVernee/gists{/gist_id}","starred_url":"https://api.github.com/users/JornVernee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JornVernee/subscriptions","organizations_url":"https://api.github.com/users/JornVernee/orgs","repos_url":"https://api.github.com/users/JornVernee/repos","events_url":"https://api.github.com/users/JornVernee/events{/privacy}","received_events_url":"https://api.github.com/users/JornVernee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JornVernee/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA","forks_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/JornVernee/Cataclysm-DDA/releases{/id}","created_at":"2015-11-08T16:25:39Z","updated_at":"2015-11-08T16:26:34Z","pushed_at":"2015-11-15T21:53:36Z","git_url":"git://github.com/JornVernee/Cataclysm-DDA.git","ssh_url":"git@github.com:JornVernee/Cataclysm-DDA.git","clone_url":"https://github.com/JornVernee/Cataclysm-DDA.git","svn_url":"https://github.com/JornVernee/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":562782,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"e98a0e18cf90ab5c71ac9c325a99dbe7775d9b79","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-11-15T20:33:58Z","pushed_at":"2015-11-16T00:21:18Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":867594,"stargazers_count":784,"watchers_count":784,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":798,"mirror_url":null,"open_issues_count":1137,"forks":798,"open_issues":1137,"watchers":784,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14047"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14047"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14047"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14047/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14047/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14047/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/bf3ee07df805b607482f14a9674f9ff94b6622cd"}}}}