{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/45577147","id":45577147,"diff_hunk":"@@ -40,7 +40,31 @@ public void Created(Actor self)\n \n \t\tpublic IEnumerable<Pair<CPos, Color>> RadarSignatureCells(Actor self)\n \t\t{\n-\t\t\tvar color = modifier != null ? modifier.RadarColorOverride(self) : self.Owner.Color.RGB;\n+\t\t\tvar player = self.World.RenderPlayer ?? self.World.LocalPlayer;\n+\t\t\tvar color = self.Owner.Color.RGB;\n+\n+\t\t\tif (modifier != null)\n+\t\t\t\tcolor = modifier.RadarColorOverride(self);\n+\n+\t\t\tif (Game.Settings.Game.AllianceDisplay && player != null && !player.Spectating)","path":"OpenRA.Mods.Common/Traits/AppearsOnRadar.cs","position":11,"original_position":11,"commit_id":"af994dfc2a01156e5fef373c45544eb8de721d24","original_commit_id":"af994dfc2a01156e5fef373c45544eb8de721d24","user":{"login":"r34ch","id":3636652,"avatar_url":"https://avatars.githubusercontent.com/u/3636652?v=3","gravatar_id":"","url":"https://api.github.com/users/r34ch","html_url":"https://github.com/r34ch","followers_url":"https://api.github.com/users/r34ch/followers","following_url":"https://api.github.com/users/r34ch/following{/other_user}","gists_url":"https://api.github.com/users/r34ch/gists{/gist_id}","starred_url":"https://api.github.com/users/r34ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r34ch/subscriptions","organizations_url":"https://api.github.com/users/r34ch/orgs","repos_url":"https://api.github.com/users/r34ch/repos","events_url":"https://api.github.com/users/r34ch/events{/privacy}","received_events_url":"https://api.github.com/users/r34ch/received_events","type":"User","site_admin":false},"body":"@pchote where should I put this helper method so it can be shared across here and health bars?","created_at":"2015-11-23T07:37:03Z","updated_at":"2015-11-23T07:37:03Z","html_url":"https://github.com/OpenRA/OpenRA/pull/9801#discussion_r45577147","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9801","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/45577147"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9801#discussion_r45577147"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9801"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9801","id":49209095,"html_url":"https://github.com/OpenRA/OpenRA/pull/9801","diff_url":"https://github.com/OpenRA/OpenRA/pull/9801.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/9801.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9801","number":9801,"state":"open","locked":false,"title":"Display team colors on radar.","user":{"login":"r34ch","id":3636652,"avatar_url":"https://avatars.githubusercontent.com/u/3636652?v=3","gravatar_id":"","url":"https://api.github.com/users/r34ch","html_url":"https://github.com/r34ch","followers_url":"https://api.github.com/users/r34ch/followers","following_url":"https://api.github.com/users/r34ch/following{/other_user}","gists_url":"https://api.github.com/users/r34ch/gists{/gist_id}","starred_url":"https://api.github.com/users/r34ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r34ch/subscriptions","organizations_url":"https://api.github.com/users/r34ch/orgs","repos_url":"https://api.github.com/users/r34ch/repos","events_url":"https://api.github.com/users/r34ch/events{/privacy}","received_events_url":"https://api.github.com/users/r34ch/received_events","type":"User","site_admin":false},"body":"Adds an option to display actors on radar in colors denoting their diplomatic stance toward the player.\r\n![team-radar](https://cloud.githubusercontent.com/assets/3636652/10833737/1e8e19ca-7e8c-11e5-92b9-b60cef6d0a86.png)\r\n\r\nThis means players who use colors similar to the terrain are on equal terms with players who opt for bright contrasting colours.\r\n\r\nCurrently hotkey is 'm'.","created_at":"2015-10-29T22:29:39Z","updated_at":"2015-11-23T07:37:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7533c18aa24e5b8d8ac4ae704188b202d8c31f00","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9801/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9801/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/9801/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/af994dfc2a01156e5fef373c45544eb8de721d24","head":{"label":"r34ch:team-radar-colors","ref":"team-radar-colors","sha":"af994dfc2a01156e5fef373c45544eb8de721d24","user":{"login":"r34ch","id":3636652,"avatar_url":"https://avatars.githubusercontent.com/u/3636652?v=3","gravatar_id":"","url":"https://api.github.com/users/r34ch","html_url":"https://github.com/r34ch","followers_url":"https://api.github.com/users/r34ch/followers","following_url":"https://api.github.com/users/r34ch/following{/other_user}","gists_url":"https://api.github.com/users/r34ch/gists{/gist_id}","starred_url":"https://api.github.com/users/r34ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r34ch/subscriptions","organizations_url":"https://api.github.com/users/r34ch/orgs","repos_url":"https://api.github.com/users/r34ch/repos","events_url":"https://api.github.com/users/r34ch/events{/privacy}","received_events_url":"https://api.github.com/users/r34ch/received_events","type":"User","site_admin":false},"repo":{"id":41880269,"name":"OpenRA","full_name":"r34ch/OpenRA","owner":{"login":"r34ch","id":3636652,"avatar_url":"https://avatars.githubusercontent.com/u/3636652?v=3","gravatar_id":"","url":"https://api.github.com/users/r34ch","html_url":"https://github.com/r34ch","followers_url":"https://api.github.com/users/r34ch/followers","following_url":"https://api.github.com/users/r34ch/following{/other_user}","gists_url":"https://api.github.com/users/r34ch/gists{/gist_id}","starred_url":"https://api.github.com/users/r34ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r34ch/subscriptions","organizations_url":"https://api.github.com/users/r34ch/orgs","repos_url":"https://api.github.com/users/r34ch/repos","events_url":"https://api.github.com/users/r34ch/events{/privacy}","received_events_url":"https://api.github.com/users/r34ch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/r34ch/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":true,"url":"https://api.github.com/repos/r34ch/OpenRA","forks_url":"https://api.github.com/repos/r34ch/OpenRA/forks","keys_url":"https://api.github.com/repos/r34ch/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r34ch/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r34ch/OpenRA/teams","hooks_url":"https://api.github.com/repos/r34ch/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/r34ch/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/r34ch/OpenRA/events","assignees_url":"https://api.github.com/repos/r34ch/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/r34ch/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/r34ch/OpenRA/tags","blobs_url":"https://api.github.com/repos/r34ch/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r34ch/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r34ch/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/r34ch/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r34ch/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/r34ch/OpenRA/languages","stargazers_url":"https://api.github.com/repos/r34ch/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/r34ch/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/r34ch/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/r34ch/OpenRA/subscription","commits_url":"https://api.github.com/repos/r34ch/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/r34ch/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/r34ch/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/r34ch/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/r34ch/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/r34ch/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r34ch/OpenRA/merges","archive_url":"https://api.github.com/repos/r34ch/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r34ch/OpenRA/downloads","issues_url":"https://api.github.com/repos/r34ch/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/r34ch/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/r34ch/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/r34ch/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r34ch/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/r34ch/OpenRA/releases{/id}","created_at":"2015-09-03T19:43:55Z","updated_at":"2015-09-03T19:44:01Z","pushed_at":"2015-11-22T18:30:26Z","git_url":"git://github.com/r34ch/OpenRA.git","ssh_url":"git@github.com:r34ch/OpenRA.git","clone_url":"https://github.com/r34ch/OpenRA.git","svn_url":"https://github.com/r34ch/OpenRA","homepage":"http://www.openra.net","size":97860,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"214945a61fba48d247ede0e7051265973639bfcc","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-11-21T21:05:29Z","pushed_at":"2015-11-22T23:27:39Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":138786,"stargazers_count":2319,"watchers_count":2319,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":823,"mirror_url":null,"open_issues_count":909,"forks":823,"open_issues":909,"watchers":2319,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9801"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/9801"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9801"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/9801/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9801/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/9801/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/af994dfc2a01156e5fef373c45544eb8de721d24"}}}}