{"action":"created","comment":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/comments/26589844","id":26589844,"diff_hunk":"@@ -165,6 +189,9 @@ export default Base.extend({\n     var expires = Ember.isEmpty(expiration) ? '' : '; expires=' + new Date(expiration).toUTCString();\n     var secure  = !!this._secureCookies ? ';secure' : '';\n     document.cookie = this.cookieName + '=' + encodeURIComponent(value) + domain + path + expires + secure;\n+    if(expiration !== null){ console.log('renewed to expire at : ' + new Date(expiration));","path":"packages/ember-simple-auth-cookie-store/lib/simple-auth-cookie-store/stores/cookie.js","position":52,"original_position":52,"commit_id":"889b1aa2af4b501a6ec1d2bf2b6381a41db09e05","original_commit_id":"889b1aa2af4b501a6ec1d2bf2b6381a41db09e05","user":{"login":"marcoow","id":1510,"avatar_url":"https://avatars.githubusercontent.com/u/1510?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoow","html_url":"https://github.com/marcoow","followers_url":"https://api.github.com/users/marcoow/followers","following_url":"https://api.github.com/users/marcoow/following{/other_user}","gists_url":"https://api.github.com/users/marcoow/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoow/subscriptions","organizations_url":"https://api.github.com/users/marcoow/orgs","repos_url":"https://api.github.com/users/marcoow/repos","events_url":"https://api.github.com/users/marcoow/events{/privacy}","received_events_url":"https://api.github.com/users/marcoow/received_events","type":"User","site_admin":false},"body":"leftover debug code","created_at":"2015-03-17T16:36:24Z","updated_at":"2015-03-17T16:36:24Z","html_url":"https://github.com/simplabs/ember-simple-auth/pull/451#discussion_r26589844","pull_request_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/451","_links":{"self":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/comments/26589844"},"html":{"href":"https://github.com/simplabs/ember-simple-auth/pull/451#discussion_r26589844"},"pull_request":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/451"}}},"pull_request":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/451","id":30006554,"html_url":"https://github.com/simplabs/ember-simple-auth/pull/451","diff_url":"https://github.com/simplabs/ember-simple-auth/pull/451.diff","patch_url":"https://github.com/simplabs/ember-simple-auth/pull/451.patch","issue_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/451","number":451,"state":"open","locked":false,"title":"Fix Cookie-Expiration","user":{"login":"msalahz","id":3384518,"avatar_url":"https://avatars.githubusercontent.com/u/3384518?v=3","gravatar_id":"","url":"https://api.github.com/users/msalahz","html_url":"https://github.com/msalahz","followers_url":"https://api.github.com/users/msalahz/followers","following_url":"https://api.github.com/users/msalahz/following{/other_user}","gists_url":"https://api.github.com/users/msalahz/gists{/gist_id}","starred_url":"https://api.github.com/users/msalahz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msalahz/subscriptions","organizations_url":"https://api.github.com/users/msalahz/orgs","repos_url":"https://api.github.com/users/msalahz/repos","events_url":"https://api.github.com/users/msalahz/events{/privacy}","received_events_url":"https://api.github.com/users/msalahz/received_events","type":"User","site_admin":false},"body":"I'm proposing the following fix for cookie expiration issue discussed in the following issue https://github.com/simplabs/ember-simple-auth/issues/395\r\n\r\nI did the following to fix the issue : \r\n1- Caching cookie expiration lifetime in a new cookie with name [cookie name]:expiration-time.\r\n2- Using cached cookie expiration for overriding session cookie in case session data changed.\r\n3- Using cached cookie expiration for renew session cookie lifetime on session store ```read``` and ```persist```.","created_at":"2015-02-25T17:20:03Z","updated_at":"2015-03-17T16:36:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f368e27503c658b69b2fd9ba58df3f27801a7bf9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/451/commits","review_comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/451/comments","review_comment_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/451/comments","statuses_url":"https://api.github.com/repos/simplabs/ember-simple-auth/statuses/889b1aa2af4b501a6ec1d2bf2b6381a41db09e05","head":{"label":"msalahz:master","ref":"master","sha":"889b1aa2af4b501a6ec1d2bf2b6381a41db09e05","user":{"login":"msalahz","id":3384518,"avatar_url":"https://avatars.githubusercontent.com/u/3384518?v=3","gravatar_id":"","url":"https://api.github.com/users/msalahz","html_url":"https://github.com/msalahz","followers_url":"https://api.github.com/users/msalahz/followers","following_url":"https://api.github.com/users/msalahz/following{/other_user}","gists_url":"https://api.github.com/users/msalahz/gists{/gist_id}","starred_url":"https://api.github.com/users/msalahz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msalahz/subscriptions","organizations_url":"https://api.github.com/users/msalahz/orgs","repos_url":"https://api.github.com/users/msalahz/repos","events_url":"https://api.github.com/users/msalahz/events{/privacy}","received_events_url":"https://api.github.com/users/msalahz/received_events","type":"User","site_admin":false},"repo":{"id":31322583,"name":"ember-simple-auth","full_name":"msalahz/ember-simple-auth","owner":{"login":"msalahz","id":3384518,"avatar_url":"https://avatars.githubusercontent.com/u/3384518?v=3","gravatar_id":"","url":"https://api.github.com/users/msalahz","html_url":"https://github.com/msalahz","followers_url":"https://api.github.com/users/msalahz/followers","following_url":"https://api.github.com/users/msalahz/following{/other_user}","gists_url":"https://api.github.com/users/msalahz/gists{/gist_id}","starred_url":"https://api.github.com/users/msalahz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msalahz/subscriptions","organizations_url":"https://api.github.com/users/msalahz/orgs","repos_url":"https://api.github.com/users/msalahz/repos","events_url":"https://api.github.com/users/msalahz/events{/privacy}","received_events_url":"https://api.github.com/users/msalahz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msalahz/ember-simple-auth","description":"A lightweight library for implementing authentication/authorization in Ember.js applications.","fork":true,"url":"https://api.github.com/repos/msalahz/ember-simple-auth","forks_url":"https://api.github.com/repos/msalahz/ember-simple-auth/forks","keys_url":"https://api.github.com/repos/msalahz/ember-simple-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msalahz/ember-simple-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msalahz/ember-simple-auth/teams","hooks_url":"https://api.github.com/repos/msalahz/ember-simple-auth/hooks","issue_events_url":"https://api.github.com/repos/msalahz/ember-simple-auth/issues/events{/number}","events_url":"https://api.github.com/repos/msalahz/ember-simple-auth/events","assignees_url":"https://api.github.com/repos/msalahz/ember-simple-auth/assignees{/user}","branches_url":"https://api.github.com/repos/msalahz/ember-simple-auth/branches{/branch}","tags_url":"https://api.github.com/repos/msalahz/ember-simple-auth/tags","blobs_url":"https://api.github.com/repos/msalahz/ember-simple-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msalahz/ember-simple-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msalahz/ember-simple-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/msalahz/ember-simple-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msalahz/ember-simple-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/msalahz/ember-simple-auth/languages","stargazers_url":"https://api.github.com/repos/msalahz/ember-simple-auth/stargazers","contributors_url":"https://api.github.com/repos/msalahz/ember-simple-auth/contributors","subscribers_url":"https://api.github.com/repos/msalahz/ember-simple-auth/subscribers","subscription_url":"https://api.github.com/repos/msalahz/ember-simple-auth/subscription","commits_url":"https://api.github.com/repos/msalahz/ember-simple-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/msalahz/ember-simple-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/msalahz/ember-simple-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/msalahz/ember-simple-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/msalahz/ember-simple-auth/contents/{+path}","compare_url":"https://api.github.com/repos/msalahz/ember-simple-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msalahz/ember-simple-auth/merges","archive_url":"https://api.github.com/repos/msalahz/ember-simple-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msalahz/ember-simple-auth/downloads","issues_url":"https://api.github.com/repos/msalahz/ember-simple-auth/issues{/number}","pulls_url":"https://api.github.com/repos/msalahz/ember-simple-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/msalahz/ember-simple-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/msalahz/ember-simple-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msalahz/ember-simple-auth/labels{/name}","releases_url":"https://api.github.com/repos/msalahz/ember-simple-auth/releases{/id}","created_at":"2015-02-25T16:16:17Z","updated_at":"2015-03-17T15:10:09Z","pushed_at":"2015-03-17T15:10:08Z","git_url":"git://github.com/msalahz/ember-simple-auth.git","ssh_url":"git@github.com:msalahz/ember-simple-auth.git","clone_url":"https://github.com/msalahz/ember-simple-auth.git","svn_url":"https://github.com/msalahz/ember-simple-auth","homepage":"http://ember-simple-auth.com","size":5369,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simplabs:master","ref":"master","sha":"c38be0ce0eb209769cb1a5efc135d7a5731468a4","user":{"login":"simplabs","id":56627,"avatar_url":"https://avatars.githubusercontent.com/u/56627?v=3","gravatar_id":"","url":"https://api.github.com/users/simplabs","html_url":"https://github.com/simplabs","followers_url":"https://api.github.com/users/simplabs/followers","following_url":"https://api.github.com/users/simplabs/following{/other_user}","gists_url":"https://api.github.com/users/simplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/simplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplabs/subscriptions","organizations_url":"https://api.github.com/users/simplabs/orgs","repos_url":"https://api.github.com/users/simplabs/repos","events_url":"https://api.github.com/users/simplabs/events{/privacy}","received_events_url":"https://api.github.com/users/simplabs/received_events","type":"Organization","site_admin":false},"repo":{"id":12570984,"name":"ember-simple-auth","full_name":"simplabs/ember-simple-auth","owner":{"login":"simplabs","id":56627,"avatar_url":"https://avatars.githubusercontent.com/u/56627?v=3","gravatar_id":"","url":"https://api.github.com/users/simplabs","html_url":"https://github.com/simplabs","followers_url":"https://api.github.com/users/simplabs/followers","following_url":"https://api.github.com/users/simplabs/following{/other_user}","gists_url":"https://api.github.com/users/simplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/simplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplabs/subscriptions","organizations_url":"https://api.github.com/users/simplabs/orgs","repos_url":"https://api.github.com/users/simplabs/repos","events_url":"https://api.github.com/users/simplabs/events{/privacy}","received_events_url":"https://api.github.com/users/simplabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simplabs/ember-simple-auth","description":"A lightweight library for implementing authentication/authorization in Ember.js applications.","fork":false,"url":"https://api.github.com/repos/simplabs/ember-simple-auth","forks_url":"https://api.github.com/repos/simplabs/ember-simple-auth/forks","keys_url":"https://api.github.com/repos/simplabs/ember-simple-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simplabs/ember-simple-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simplabs/ember-simple-auth/teams","hooks_url":"https://api.github.com/repos/simplabs/ember-simple-auth/hooks","issue_events_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/events{/number}","events_url":"https://api.github.com/repos/simplabs/ember-simple-auth/events","assignees_url":"https://api.github.com/repos/simplabs/ember-simple-auth/assignees{/user}","branches_url":"https://api.github.com/repos/simplabs/ember-simple-auth/branches{/branch}","tags_url":"https://api.github.com/repos/simplabs/ember-simple-auth/tags","blobs_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simplabs/ember-simple-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/simplabs/ember-simple-auth/languages","stargazers_url":"https://api.github.com/repos/simplabs/ember-simple-auth/stargazers","contributors_url":"https://api.github.com/repos/simplabs/ember-simple-auth/contributors","subscribers_url":"https://api.github.com/repos/simplabs/ember-simple-auth/subscribers","subscription_url":"https://api.github.com/repos/simplabs/ember-simple-auth/subscription","commits_url":"https://api.github.com/repos/simplabs/ember-simple-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/simplabs/ember-simple-auth/contents/{+path}","compare_url":"https://api.github.com/repos/simplabs/ember-simple-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simplabs/ember-simple-auth/merges","archive_url":"https://api.github.com/repos/simplabs/ember-simple-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simplabs/ember-simple-auth/downloads","issues_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues{/number}","pulls_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/simplabs/ember-simple-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/simplabs/ember-simple-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simplabs/ember-simple-auth/labels{/name}","releases_url":"https://api.github.com/repos/simplabs/ember-simple-auth/releases{/id}","created_at":"2013-09-03T18:03:26Z","updated_at":"2015-03-17T15:03:01Z","pushed_at":"2015-03-16T20:47:23Z","git_url":"git://github.com/simplabs/ember-simple-auth.git","ssh_url":"git@github.com:simplabs/ember-simple-auth.git","clone_url":"https://github.com/simplabs/ember-simple-auth.git","svn_url":"https://github.com/simplabs/ember-simple-auth","homepage":"http://ember-simple-auth.com","size":8451,"stargazers_count":852,"watchers_count":852,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":171,"mirror_url":null,"open_issues_count":9,"forks":171,"open_issues":9,"watchers":852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/451"},"html":{"href":"https://github.com/simplabs/ember-simple-auth/pull/451"},"issue":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/451"},"comments":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/451/comments"},"review_comments":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/451/comments"},"review_comment":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/451/commits"},"statuses":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/statuses/889b1aa2af4b501a6ec1d2bf2b6381a41db09e05"}}}}