{"action":"created","issue":{"url":"https://api.github.com/repos/googlegenomics/dataflow-java/issues/77","labels_url":"https://api.github.com/repos/googlegenomics/dataflow-java/issues/77/labels{/name}","comments_url":"https://api.github.com/repos/googlegenomics/dataflow-java/issues/77/comments","events_url":"https://api.github.com/repos/googlegenomics/dataflow-java/issues/77/events","html_url":"https://github.com/googlegenomics/dataflow-java/pull/77","id":75982197,"number":77,"title":"Refactor auth","user":{"login":"davidadamsphd","id":12084283,"avatar_url":"https://avatars.githubusercontent.com/u/12084283?v=3","gravatar_id":"","url":"https://api.github.com/users/davidadamsphd","html_url":"https://github.com/davidadamsphd","followers_url":"https://api.github.com/users/davidadamsphd/followers","following_url":"https://api.github.com/users/davidadamsphd/following{/other_user}","gists_url":"https://api.github.com/users/davidadamsphd/gists{/gist_id}","starred_url":"https://api.github.com/users/davidadamsphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidadamsphd/subscriptions","organizations_url":"https://api.github.com/users/davidadamsphd/orgs","repos_url":"https://api.github.com/users/davidadamsphd/repos","events_url":"https://api.github.com/users/davidadamsphd/events{/privacy}","received_events_url":"https://api.github.com/users/davidadamsphd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jean-philippe-martin","id":10458949,"avatar_url":"https://avatars.githubusercontent.com/u/10458949?v=3","gravatar_id":"","url":"https://api.github.com/users/jean-philippe-martin","html_url":"https://github.com/jean-philippe-martin","followers_url":"https://api.github.com/users/jean-philippe-martin/followers","following_url":"https://api.github.com/users/jean-philippe-martin/following{/other_user}","gists_url":"https://api.github.com/users/jean-philippe-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/jean-philippe-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jean-philippe-martin/subscriptions","organizations_url":"https://api.github.com/users/jean-philippe-martin/orgs","repos_url":"https://api.github.com/users/jean-philippe-martin/repos","events_url":"https://api.github.com/users/jean-philippe-martin/events{/privacy}","received_events_url":"https://api.github.com/users/jean-philippe-martin/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-05-13T13:23:22Z","updated_at":"2015-05-13T15:01:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/googlegenomics/dataflow-java/pulls/77","html_url":"https://github.com/googlegenomics/dataflow-java/pull/77","diff_url":"https://github.com/googlegenomics/dataflow-java/pull/77.diff","patch_url":"https://github.com/googlegenomics/dataflow-java/pull/77.patch"},"body":"This refactor moves the offline authentication properly into this library code. Before this change clients needed to create offline authentication classes. The authentication can/should be derived from the Options that are associated with the pipeline. This refactor creates the OfflineAuth where it's needed in GCSOptions.java. ReadBAMTransform.java now no longer has any references to OfflineAuth.\r\n\r\nThere are two main consequences for the client:\r\n1) The ReadBAMTransform API has changed to no longer accept OfflineAuth, so this is not a no-op for client code. (Note that I didn't remove the existing functions in GCSOptions so it's still possible to pass in OfflineAuth to createStorageClient).\r\n2) Because we're creating the OfflineAuth using GenomicsOptions.Methods.getGenomicsAuth, ReadBAMTransform now throws GeneralSecurityException.\r\n\r\nI've run mvn clean install: everything builds and all tests pass."},"comment":{"url":"https://api.github.com/repos/googlegenomics/dataflow-java/issues/comments/101704435","html_url":"https://github.com/googlegenomics/dataflow-java/pull/77#issuecomment-101704435","issue_url":"https://api.github.com/repos/googlegenomics/dataflow-java/issues/77","id":101704435,"user":{"login":"davidadamsphd","id":12084283,"avatar_url":"https://avatars.githubusercontent.com/u/12084283?v=3","gravatar_id":"","url":"https://api.github.com/users/davidadamsphd","html_url":"https://github.com/davidadamsphd","followers_url":"https://api.github.com/users/davidadamsphd/followers","following_url":"https://api.github.com/users/davidadamsphd/following{/other_user}","gists_url":"https://api.github.com/users/davidadamsphd/gists{/gist_id}","starred_url":"https://api.github.com/users/davidadamsphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidadamsphd/subscriptions","organizations_url":"https://api.github.com/users/davidadamsphd/orgs","repos_url":"https://api.github.com/users/davidadamsphd/repos","events_url":"https://api.github.com/users/davidadamsphd/events{/privacy}","received_events_url":"https://api.github.com/users/davidadamsphd/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T15:01:13Z","updated_at":"2015-05-13T15:01:13Z","body":"I signed it!\r\n(and switched my email to davidada@google.com, which should hopefully help)."}}