{"action":"created","issue":{"url":"https://api.github.com/repos/uqbar-project/wollok/issues/376","labels_url":"https://api.github.com/repos/uqbar-project/wollok/issues/376/labels{/name}","comments_url":"https://api.github.com/repos/uqbar-project/wollok/issues/376/comments","events_url":"https://api.github.com/repos/uqbar-project/wollok/issues/376/events","html_url":"https://github.com/uqbar-project/wollok/pull/376","id":116247337,"number":376,"title":"100% natives objects now coded in wollok as part of the SDK","user":{"login":"javierfernandes","id":4428120,"avatar_url":"https://avatars.githubusercontent.com/u/4428120?v=3","gravatar_id":"","url":"https://api.github.com/users/javierfernandes","html_url":"https://github.com/javierfernandes","followers_url":"https://api.github.com/users/javierfernandes/followers","following_url":"https://api.github.com/users/javierfernandes/following{/other_user}","gists_url":"https://api.github.com/users/javierfernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/javierfernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierfernandes/subscriptions","organizations_url":"https://api.github.com/users/javierfernandes/orgs","repos_url":"https://api.github.com/users/javierfernandes/repos","events_url":"https://api.github.com/users/javierfernandes/events{/privacy}","received_events_url":"https://api.github.com/users/javierfernandes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/uqbar-project/wollok/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-11T02:19:48Z","updated_at":"2015-11-11T20:08:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uqbar-project/wollok/pulls/376","html_url":"https://github.com/uqbar-project/wollok/pull/376","diff_url":"https://github.com/uqbar-project/wollok/pull/376.diff","patch_url":"https://github.com/uqbar-project/wollok/pull/376.patch"},"body":"SDK now includes: Collection, List, Set, Object, Integer, Number, Double, Range, Boolean, String, and InstanceVariableMirror.\r\n\r\nThey have minor behaviour, because still the methods are native, but this native impl is consistent with the users level native objects.\r\n\r\nNow the interpreter doesn't have any special treatment for this objects"},"comment":{"url":"https://api.github.com/repos/uqbar-project/wollok/issues/comments/155896867","html_url":"https://github.com/uqbar-project/wollok/pull/376#issuecomment-155896867","issue_url":"https://api.github.com/repos/uqbar-project/wollok/issues/376","id":155896867,"user":{"login":"npasserini","id":4633913,"avatar_url":"https://avatars.githubusercontent.com/u/4633913?v=3","gravatar_id":"","url":"https://api.github.com/users/npasserini","html_url":"https://github.com/npasserini","followers_url":"https://api.github.com/users/npasserini/followers","following_url":"https://api.github.com/users/npasserini/following{/other_user}","gists_url":"https://api.github.com/users/npasserini/gists{/gist_id}","starred_url":"https://api.github.com/users/npasserini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npasserini/subscriptions","organizations_url":"https://api.github.com/users/npasserini/orgs","repos_url":"https://api.github.com/users/npasserini/repos","events_url":"https://api.github.com/users/npasserini/events{/privacy}","received_events_url":"https://api.github.com/users/npasserini/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T20:08:47Z","updated_at":"2015-11-11T20:08:47Z","body":"Yeah, it looks right to me too!\n\nOn Wed, Nov 11, 2015 at 2:55 PM, javierfernandes <notifications@github.com>\nwrote:\n\n> It is highly probably that with this change I have broken something in the\n> collections behavior, so we need to test it manually and increase junit\n> tests.\n>\n> Here is a potential problem that I worked around. The \"detect\" method was\n> implemented like this\n>\n>         method detect(predicate) = this.fold(null, [ acc, e | if (acc == null && predicate.apply(e)) e else acc ])\n>\n> But tests failed, things like returning the last object when it should\n> return null because none were supposed to match, or returning the previous\n> call value (really weird).\n> Refactoring to this worked fine\n>\n>         method detect(predicate) = this.fold(null, [ acc, e |\n>              if (acc != null)\n>                 acc\n>              else\n>                 if (predicate.apply(e)) e else null\n>         ])\n>\n> Let me know if you have an idea on what could be the cause. I was not able\n> to find any problem looking at this code. Seems right\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/uqbar-project/wollok/pull/376#issuecomment-155861087>.\n>\n"}}