{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/specs/pulls/comments/38988374","id":38988374,"diff_hunk":"@@ -21,6 +21,9 @@ type LinuxRuntime struct {\n \t// Resources contain cgroup information for handling resource constraints\n \t// for the container\n \tResources Resources `json:\"resources\"`\n+\t// CgroupsPath specifies the path to cgroups that are created and/or joined by the container.\n+\t// The path is expected to be relative to the cgroups mountpoint.\n+\tCgroupsPath string `json:\"cgroupsPath\"`","path":"runtime_config_linux.go","position":6,"original_position":6,"commit_id":"be6ec5ff5eb02ed7db071fd914e390c88cea08f1","original_commit_id":"be6ec5ff5eb02ed7db071fd914e390c88cea08f1","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"body":"@mrunalp: Your reasoning is sound! I see use cases for both `exec` and `resource updates`. Would making `Resources` optional resolve the issue? ","created_at":"2015-09-08T22:30:41Z","updated_at":"2015-09-08T22:30:41Z","html_url":"https://github.com/opencontainers/specs/pull/137#discussion_r38988374","pull_request_url":"https://api.github.com/repos/opencontainers/specs/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/specs/pulls/comments/38988374"},"html":{"href":"https://github.com/opencontainers/specs/pull/137#discussion_r38988374"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/specs/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/specs/pulls/137","id":44048263,"html_url":"https://github.com/opencontainers/specs/pull/137","diff_url":"https://github.com/opencontainers/specs/pull/137.diff","patch_url":"https://github.com/opencontainers/specs/pull/137.patch","issue_url":"https://api.github.com/repos/opencontainers/specs/issues/137","number":137,"state":"open","locked":false,"title":"Adding cgroups path to the Spec.","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"body":"Related to #114\r\nThis change should be useful for exec'ing new processes in an existing container.\r\n\r\n","created_at":"2015-09-02T22:02:45Z","updated_at":"2015-09-08T22:30:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c968cdd75cf59daa95c30f4273bccaffa10e005","assignee":null,"milestone":{"url":"https://api.github.com/repos/opencontainers/specs/milestones/1","html_url":"https://github.com/opencontainers/specs/milestones/draft","labels_url":"https://api.github.com/repos/opencontainers/specs/milestones/1/labels","id":1180186,"number":1,"title":"draft","description":"Initial version of the spec that covers running a bundle. This includes the runtime, bundle layout and configuration.","creator":{"login":"philips","id":33544,"avatar_url":"https://avatars.githubusercontent.com/u/33544?v=3","gravatar_id":"","url":"https://api.github.com/users/philips","html_url":"https://github.com/philips","followers_url":"https://api.github.com/users/philips/followers","following_url":"https://api.github.com/users/philips/following{/other_user}","gists_url":"https://api.github.com/users/philips/gists{/gist_id}","starred_url":"https://api.github.com/users/philips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philips/subscriptions","organizations_url":"https://api.github.com/users/philips/orgs","repos_url":"https://api.github.com/users/philips/repos","events_url":"https://api.github.com/users/philips/events{/privacy}","received_events_url":"https://api.github.com/users/philips/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":5,"state":"open","created_at":"2015-06-25T00:11:58Z","updated_at":"2015-09-08T18:50:12Z","due_on":"2015-09-09T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/opencontainers/specs/pulls/137/commits","review_comments_url":"https://api.github.com/repos/opencontainers/specs/pulls/137/comments","review_comment_url":"https://api.github.com/repos/opencontainers/specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/specs/issues/137/comments","statuses_url":"https://api.github.com/repos/opencontainers/specs/statuses/be6ec5ff5eb02ed7db071fd914e390c88cea08f1","head":{"label":"vishh:cgroups-path","ref":"cgroups-path","sha":"be6ec5ff5eb02ed7db071fd914e390c88cea08f1","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"repo":{"id":41815189,"name":"specs","full_name":"vishh/specs","owner":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vishh/specs","description":"Open Container Specifications","fork":true,"url":"https://api.github.com/repos/vishh/specs","forks_url":"https://api.github.com/repos/vishh/specs/forks","keys_url":"https://api.github.com/repos/vishh/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vishh/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vishh/specs/teams","hooks_url":"https://api.github.com/repos/vishh/specs/hooks","issue_events_url":"https://api.github.com/repos/vishh/specs/issues/events{/number}","events_url":"https://api.github.com/repos/vishh/specs/events","assignees_url":"https://api.github.com/repos/vishh/specs/assignees{/user}","branches_url":"https://api.github.com/repos/vishh/specs/branches{/branch}","tags_url":"https://api.github.com/repos/vishh/specs/tags","blobs_url":"https://api.github.com/repos/vishh/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vishh/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vishh/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/vishh/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vishh/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/vishh/specs/languages","stargazers_url":"https://api.github.com/repos/vishh/specs/stargazers","contributors_url":"https://api.github.com/repos/vishh/specs/contributors","subscribers_url":"https://api.github.com/repos/vishh/specs/subscribers","subscription_url":"https://api.github.com/repos/vishh/specs/subscription","commits_url":"https://api.github.com/repos/vishh/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/vishh/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/vishh/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/vishh/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/vishh/specs/contents/{+path}","compare_url":"https://api.github.com/repos/vishh/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vishh/specs/merges","archive_url":"https://api.github.com/repos/vishh/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vishh/specs/downloads","issues_url":"https://api.github.com/repos/vishh/specs/issues{/number}","pulls_url":"https://api.github.com/repos/vishh/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/vishh/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/vishh/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vishh/specs/labels{/name}","releases_url":"https://api.github.com/repos/vishh/specs/releases{/id}","created_at":"2015-09-02T17:19:33Z","updated_at":"2015-09-02T17:19:34Z","pushed_at":"2015-09-02T22:00:32Z","git_url":"git://github.com/vishh/specs.git","ssh_url":"git@github.com:vishh/specs.git","clone_url":"https://github.com/vishh/specs.git","svn_url":"https://github.com/vishh/specs","homepage":"http://www.opencontainers.org","size":181,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"138deee1418d2376a4e9d4966e9f1543e717a641","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":36960293,"name":"specs","full_name":"opencontainers/specs","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/specs","description":"Open Container Specifications","fork":false,"url":"https://api.github.com/repos/opencontainers/specs","forks_url":"https://api.github.com/repos/opencontainers/specs/forks","keys_url":"https://api.github.com/repos/opencontainers/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/specs/teams","hooks_url":"https://api.github.com/repos/opencontainers/specs/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/specs/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/specs/events","assignees_url":"https://api.github.com/repos/opencontainers/specs/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/specs/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/specs/tags","blobs_url":"https://api.github.com/repos/opencontainers/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/specs/languages","stargazers_url":"https://api.github.com/repos/opencontainers/specs/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/specs/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/specs/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/specs/subscription","commits_url":"https://api.github.com/repos/opencontainers/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/specs/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/specs/merges","archive_url":"https://api.github.com/repos/opencontainers/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/specs/downloads","issues_url":"https://api.github.com/repos/opencontainers/specs/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/specs/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/specs/releases{/id}","created_at":"2015-06-05T23:30:10Z","updated_at":"2015-09-07T11:56:46Z","pushed_at":"2015-09-08T18:50:12Z","git_url":"git://github.com/opencontainers/specs.git","ssh_url":"git@github.com:opencontainers/specs.git","clone_url":"https://github.com/opencontainers/specs.git","svn_url":"https://github.com/opencontainers/specs","homepage":"http://www.opencontainers.org","size":1292,"stargazers_count":420,"watchers_count":420,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":46,"forks":66,"open_issues":46,"watchers":420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/specs/pulls/137"},"html":{"href":"https://github.com/opencontainers/specs/pull/137"},"issue":{"href":"https://api.github.com/repos/opencontainers/specs/issues/137"},"comments":{"href":"https://api.github.com/repos/opencontainers/specs/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/specs/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/specs/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/specs/statuses/be6ec5ff5eb02ed7db071fd914e390c88cea08f1"}}}}