{"action":"created","issue":{"url":"https://api.github.com/repos/ninjaframework/ninja/issues/416","labels_url":"https://api.github.com/repos/ninjaframework/ninja/issues/416/labels{/name}","comments_url":"https://api.github.com/repos/ninjaframework/ninja/issues/416/comments","events_url":"https://api.github.com/repos/ninjaframework/ninja/issues/416/events","html_url":"https://github.com/ninjaframework/ninja/pull/416","id":112894942,"number":416,"title":"Allow remember me functionality via session cookie","user":{"login":"watsonmw","id":515091,"avatar_url":"https://avatars.githubusercontent.com/u/515091?v=3","gravatar_id":"","url":"https://api.github.com/users/watsonmw","html_url":"https://github.com/watsonmw","followers_url":"https://api.github.com/users/watsonmw/followers","following_url":"https://api.github.com/users/watsonmw/following{/other_user}","gists_url":"https://api.github.com/users/watsonmw/gists{/gist_id}","starred_url":"https://api.github.com/users/watsonmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watsonmw/subscriptions","organizations_url":"https://api.github.com/users/watsonmw/orgs","repos_url":"https://api.github.com/users/watsonmw/repos","events_url":"https://api.github.com/users/watsonmw/events{/privacy}","received_events_url":"https://api.github.com/users/watsonmw/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":25,"created_at":"2015-10-22T21:25:27Z","updated_at":"2015-12-18T22:23:41Z","closed_at":"2015-10-29T13:05:50Z","pull_request":{"url":"https://api.github.com/repos/ninjaframework/ninja/pulls/416","html_url":"https://github.com/ninjaframework/ninja/pull/416","diff_url":"https://github.com/ninjaframework/ninja/pull/416.diff","patch_url":"https://github.com/ninjaframework/ninja/pull/416.patch"},"body":"https://github.com/ninjaframework/ninja/issues/415\r\n\r\nAdded Session.setExpiryTime() for setting the expiry time of sessions.\r\n\r\nAdded 'remember me' toggle to the JPA blog to demonstrate Session.setExpiryTime()."},"comment":{"url":"https://api.github.com/repos/ninjaframework/ninja/issues/comments/165910722","html_url":"https://github.com/ninjaframework/ninja/pull/416#issuecomment-165910722","issue_url":"https://api.github.com/repos/ninjaframework/ninja/issues/416","id":165910722,"user":{"login":"watsonmw","id":515091,"avatar_url":"https://avatars.githubusercontent.com/u/515091?v=3","gravatar_id":"","url":"https://api.github.com/users/watsonmw","html_url":"https://github.com/watsonmw","followers_url":"https://api.github.com/users/watsonmw/followers","following_url":"https://api.github.com/users/watsonmw/following{/other_user}","gists_url":"https://api.github.com/users/watsonmw/gists{/gist_id}","starred_url":"https://api.github.com/users/watsonmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watsonmw/subscriptions","organizations_url":"https://api.github.com/users/watsonmw/orgs","repos_url":"https://api.github.com/users/watsonmw/repos","events_url":"https://api.github.com/users/watsonmw/events{/privacy}","received_events_url":"https://api.github.com/users/watsonmw/received_events","type":"User","site_admin":false},"created_at":"2015-12-18T22:23:41Z","updated_at":"2015-12-18T22:23:41Z","body":"Only things I can think of:\n\n- You clear the cookies in the logout request (request a), while another\nrequest is being processed (request b), request b never sees the cleared\ncookie, so saves and extends the timeout again. Whatever request b is,\nneeds to leave the cookies alone so logout can occur.\n\n- The same SessionImpl is used twice, not sure how this would inadvertently\nhappen, the guice injection code, always grabs a new one the way things are\nsetup.\n\n\nOn 18 December 2015 at 14:06, Daniel SAWAN <notifications@github.com> wrote:\n\n> I think i gonna make a sample app with no filters / extractors etc...\n> But i don't think this a code i made which generate the bug because then\n> why it is a Ninja option which create / make disapear the bug then ? I a\n> 100% sure i only create session in one place the Login page.\n>\n> But you are right i should simplify the problem by creating a simple app\n> maybe. But before i wanted to see if someone else manage to generate this\n> bug with your own applications.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/ninjaframework/ninja/pull/416#issuecomment-165907939>.\n>\n"}}