{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/32177410","id":32177410,"diff_hunk":"@@ -698,7 +698,7 @@ pub fn import_codemap(local_codemap: &codemap::CodeMap,\n             return false;\n         }\n \n-        for (&line1, &line2) in lines1.iter().zip(lines2.iter()) {\n+        for (&line1, &line2) in lines1.iter().zip(&*lines2) {","path":"src/librustc/metadata/creader.rs","position":5,"original_position":5,"commit_id":"ca7418b84658fc1c723672c462aa0a7878d88b64","original_commit_id":"ca7418b84658fc1c723672c462aa0a7878d88b64","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"Similar to @steveklabnik's concern above, I'd stick to `.iter()` here as it seems more clear than `&*`","created_at":"2015-06-10T23:27:50Z","updated_at":"2015-06-10T23:27:50Z","html_url":"https://github.com/rust-lang/rust/pull/26190#discussion_r32177410","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/26190","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/32177410"},"html":{"href":"https://github.com/rust-lang/rust/pull/26190#discussion_r32177410"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/26190"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/26190","id":37399802,"html_url":"https://github.com/rust-lang/rust/pull/26190","diff_url":"https://github.com/rust-lang/rust/pull/26190.diff","patch_url":"https://github.com/rust-lang/rust/pull/26190.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/26190","number":26190,"state":"open","locked":false,"title":"Remove pointless calls to *iter() and iter_mut()","user":{"login":"Veedrac","id":2867413,"avatar_url":"https://avatars.githubusercontent.com/u/2867413?v=3","gravatar_id":"","url":"https://api.github.com/users/Veedrac","html_url":"https://github.com/Veedrac","followers_url":"https://api.github.com/users/Veedrac/followers","following_url":"https://api.github.com/users/Veedrac/following{/other_user}","gists_url":"https://api.github.com/users/Veedrac/gists{/gist_id}","starred_url":"https://api.github.com/users/Veedrac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Veedrac/subscriptions","organizations_url":"https://api.github.com/users/Veedrac/orgs","repos_url":"https://api.github.com/users/Veedrac/repos","events_url":"https://api.github.com/users/Veedrac/events{/privacy}","received_events_url":"https://api.github.com/users/Veedrac/received_events","type":"User","site_admin":false},"body":"Pull request for #26188.","created_at":"2015-06-10T20:18:14Z","updated_at":"2015-06-10T23:27:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3bdfe9286ab0ba8c4f952200bebabbaeecf885d","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/26190/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/26190/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/26190/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/ca7418b84658fc1c723672c462aa0a7878d88b64","head":{"label":"Veedrac:no-iter","ref":"no-iter","sha":"ca7418b84658fc1c723672c462aa0a7878d88b64","user":{"login":"Veedrac","id":2867413,"avatar_url":"https://avatars.githubusercontent.com/u/2867413?v=3","gravatar_id":"","url":"https://api.github.com/users/Veedrac","html_url":"https://github.com/Veedrac","followers_url":"https://api.github.com/users/Veedrac/followers","following_url":"https://api.github.com/users/Veedrac/following{/other_user}","gists_url":"https://api.github.com/users/Veedrac/gists{/gist_id}","starred_url":"https://api.github.com/users/Veedrac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Veedrac/subscriptions","organizations_url":"https://api.github.com/users/Veedrac/orgs","repos_url":"https://api.github.com/users/Veedrac/repos","events_url":"https://api.github.com/users/Veedrac/events{/privacy}","received_events_url":"https://api.github.com/users/Veedrac/received_events","type":"User","site_admin":false},"repo":{"id":37135594,"name":"rust","full_name":"Veedrac/rust","owner":{"login":"Veedrac","id":2867413,"avatar_url":"https://avatars.githubusercontent.com/u/2867413?v=3","gravatar_id":"","url":"https://api.github.com/users/Veedrac","html_url":"https://github.com/Veedrac","followers_url":"https://api.github.com/users/Veedrac/followers","following_url":"https://api.github.com/users/Veedrac/following{/other_user}","gists_url":"https://api.github.com/users/Veedrac/gists{/gist_id}","starred_url":"https://api.github.com/users/Veedrac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Veedrac/subscriptions","organizations_url":"https://api.github.com/users/Veedrac/orgs","repos_url":"https://api.github.com/users/Veedrac/repos","events_url":"https://api.github.com/users/Veedrac/events{/privacy}","received_events_url":"https://api.github.com/users/Veedrac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Veedrac/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/Veedrac/rust","forks_url":"https://api.github.com/repos/Veedrac/rust/forks","keys_url":"https://api.github.com/repos/Veedrac/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Veedrac/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Veedrac/rust/teams","hooks_url":"https://api.github.com/repos/Veedrac/rust/hooks","issue_events_url":"https://api.github.com/repos/Veedrac/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Veedrac/rust/events","assignees_url":"https://api.github.com/repos/Veedrac/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Veedrac/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Veedrac/rust/tags","blobs_url":"https://api.github.com/repos/Veedrac/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Veedrac/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Veedrac/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Veedrac/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Veedrac/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Veedrac/rust/languages","stargazers_url":"https://api.github.com/repos/Veedrac/rust/stargazers","contributors_url":"https://api.github.com/repos/Veedrac/rust/contributors","subscribers_url":"https://api.github.com/repos/Veedrac/rust/subscribers","subscription_url":"https://api.github.com/repos/Veedrac/rust/subscription","commits_url":"https://api.github.com/repos/Veedrac/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Veedrac/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Veedrac/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Veedrac/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Veedrac/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Veedrac/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Veedrac/rust/merges","archive_url":"https://api.github.com/repos/Veedrac/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Veedrac/rust/downloads","issues_url":"https://api.github.com/repos/Veedrac/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Veedrac/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Veedrac/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Veedrac/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Veedrac/rust/labels{/name}","releases_url":"https://api.github.com/repos/Veedrac/rust/releases{/id}","created_at":"2015-06-09T14:02:50Z","updated_at":"2015-06-09T14:03:20Z","pushed_at":"2015-06-10T21:38:24Z","git_url":"git://github.com/Veedrac/rust.git","ssh_url":"git@github.com:Veedrac/rust.git","clone_url":"https://github.com/Veedrac/rust.git","svn_url":"https://github.com/Veedrac/rust","homepage":"http://www.rust-lang.org","size":296752,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"d8a9570154dfbc4032cb3a6ba8b51c6256518dcd","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-06-10T23:13:54Z","pushed_at":"2015-06-10T23:16:39Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":622365,"stargazers_count":12141,"watchers_count":12141,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2336,"mirror_url":null,"open_issues_count":2109,"forks":2336,"open_issues":2109,"watchers":12141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/26190"},"html":{"href":"https://github.com/rust-lang/rust/pull/26190"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/26190"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/26190/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/26190/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/26190/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/ca7418b84658fc1c723672c462aa0a7878d88b64"}}}}