{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/42894037","id":42894037,"diff_hunk":"@@ -5,15 +5,32 @@ namespace System.Net\n {\n     internal class StreamSizes\n     {\n+        private static readonly int s_header;\n+        private static readonly int s_trailer;\n+        private static readonly int s_maximumMessage;\n+\n         public int header;\n         public int trailer;\n         public int maximumMessage;\n \n-        internal StreamSizes(int headerSize, int trailerSize, int maxMessageSize)\n+        static StreamSizes()\n+        {\n+            // TODO (Issue #3362) : Trailer size requirement is changing based on protocol\n+            //       SSL3/TLS1.0 - 68, TLS1.1 - 37 and TLS1.2 - 24\n+            //       Current usage is only to compute max input buffer size for\n+            //       encryption and so the native code returns the max","path":"src/Common/src/Interop/Unix/libssl/StreamSizes.cs","position":18,"original_position":18,"commit_id":"9ff5207e5114791836d3dfb0baeba513cf6bec74","original_commit_id":"9ff5207e5114791836d3dfb0baeba513cf6bec74","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"I put it both here in managed code and in the native code. Officially it only belongs with the native code, but I also copied it here in case whoever is looking for TODO Issue #3362 comments only search in *.cs or in the VS solution. This way it still gets picked up.","created_at":"2015-10-23T17:52:04Z","updated_at":"2015-10-23T17:52:04Z","html_url":"https://github.com/dotnet/corefx/pull/4088#discussion_r42894037","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/4088","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/42894037"},"html":{"href":"https://github.com/dotnet/corefx/pull/4088#discussion_r42894037"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4088"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/4088","id":48528095,"html_url":"https://github.com/dotnet/corefx/pull/4088","diff_url":"https://github.com/dotnet/corefx/pull/4088.diff","patch_url":"https://github.com/dotnet/corefx/pull/4088.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/4088","number":4088,"state":"open","locked":false,"title":"Add shims for the remaining libssl methods.","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"This change completely removes all managed code direct dependencies on libssl.\r\nInstead, all calls are now invoked through our native shims.\r\n\r\n@stephentoub @nguerrera @bartonjs @vijaykota @rajansingh10 @shrutigarg","created_at":"2015-10-22T23:54:08Z","updated_at":"2015-10-23T17:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ebf189773d36041deba0b9a11e2977ada11199b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/4088/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/4088/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/4088/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/9ff5207e5114791836d3dfb0baeba513cf6bec74","head":{"label":"eerhardt:LibSsl","ref":"LibSsl","sha":"9ff5207e5114791836d3dfb0baeba513cf6bec74","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"repo":{"id":38781378,"name":"corefx","full_name":"eerhardt/corefx","owner":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eerhardt/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/eerhardt/corefx","forks_url":"https://api.github.com/repos/eerhardt/corefx/forks","keys_url":"https://api.github.com/repos/eerhardt/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eerhardt/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eerhardt/corefx/teams","hooks_url":"https://api.github.com/repos/eerhardt/corefx/hooks","issue_events_url":"https://api.github.com/repos/eerhardt/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/eerhardt/corefx/events","assignees_url":"https://api.github.com/repos/eerhardt/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/eerhardt/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/eerhardt/corefx/tags","blobs_url":"https://api.github.com/repos/eerhardt/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eerhardt/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eerhardt/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/eerhardt/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eerhardt/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/eerhardt/corefx/languages","stargazers_url":"https://api.github.com/repos/eerhardt/corefx/stargazers","contributors_url":"https://api.github.com/repos/eerhardt/corefx/contributors","subscribers_url":"https://api.github.com/repos/eerhardt/corefx/subscribers","subscription_url":"https://api.github.com/repos/eerhardt/corefx/subscription","commits_url":"https://api.github.com/repos/eerhardt/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/eerhardt/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/eerhardt/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/eerhardt/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/eerhardt/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/eerhardt/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eerhardt/corefx/merges","archive_url":"https://api.github.com/repos/eerhardt/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eerhardt/corefx/downloads","issues_url":"https://api.github.com/repos/eerhardt/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/eerhardt/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/eerhardt/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/eerhardt/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eerhardt/corefx/labels{/name}","releases_url":"https://api.github.com/repos/eerhardt/corefx/releases{/id}","created_at":"2015-07-08T21:38:15Z","updated_at":"2015-07-08T21:38:34Z","pushed_at":"2015-10-22T23:53:11Z","git_url":"git://github.com/eerhardt/corefx.git","ssh_url":"git@github.com:eerhardt/corefx.git","clone_url":"https://github.com/eerhardt/corefx.git","svn_url":"https://github.com/eerhardt/corefx","homepage":"http://dotnet.github.io/core/","size":37664,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a3050bacc9b716f52f086751bfb4bf0384019f53","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-10-23T16:45:19Z","pushed_at":"2015-10-23T17:50:08Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":86052,"stargazers_count":8484,"watchers_count":8484,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1863,"mirror_url":null,"open_issues_count":674,"forks":1863,"open_issues":674,"watchers":8484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4088"},"html":{"href":"https://github.com/dotnet/corefx/pull/4088"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4088"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4088/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4088/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4088/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/9ff5207e5114791836d3dfb0baeba513cf6bec74"}}}}