{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/active_merchant/pulls/comments/28905174","id":28905174,"diff_hunk":"@@ -426,6 +445,10 @@ def json_error(raw_response)\n       def non_fractional_currency?(currency)\n         CURRENCIES_WITHOUT_FRACTIONS.include?(currency.to_s)\n       end\n+\n+      def emv_payment?(payment)","path":"lib/active_merchant/billing/gateways/stripe.rb","position":144,"original_position":144,"commit_id":"4e3bd603ab5d5778ea962bbab9d372ee245ffb1f","original_commit_id":"5f57a1405fa158f9899752907da437e28df2d48d","user":{"login":"bizla","id":4581564,"avatar_url":"https://avatars.githubusercontent.com/u/4581564?v=3","gravatar_id":"","url":"https://api.github.com/users/bizla","html_url":"https://github.com/bizla","followers_url":"https://api.github.com/users/bizla/followers","following_url":"https://api.github.com/users/bizla/following{/other_user}","gists_url":"https://api.github.com/users/bizla/gists{/gist_id}","starred_url":"https://api.github.com/users/bizla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bizla/subscriptions","organizations_url":"https://api.github.com/users/bizla/orgs","repos_url":"https://api.github.com/users/bizla/repos","events_url":"https://api.github.com/users/bizla/events{/privacy}","received_events_url":"https://api.github.com/users/bizla/received_events","type":"User","site_admin":false},"body":":ok: Done!","created_at":"2015-04-22T19:16:02Z","updated_at":"2015-04-22T19:16:02Z","html_url":"https://github.com/Shopify/active_merchant/pull/1659#discussion_r28905174","pull_request_url":"https://api.github.com/repos/Shopify/active_merchant/pulls/1659","_links":{"self":{"href":"https://api.github.com/repos/Shopify/active_merchant/pulls/comments/28905174"},"html":{"href":"https://github.com/Shopify/active_merchant/pull/1659#discussion_r28905174"},"pull_request":{"href":"https://api.github.com/repos/Shopify/active_merchant/pulls/1659"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/active_merchant/pulls/1659","id":33871372,"html_url":"https://github.com/Shopify/active_merchant/pull/1659","diff_url":"https://github.com/Shopify/active_merchant/pull/1659.diff","patch_url":"https://github.com/Shopify/active_merchant/pull/1659.patch","issue_url":"https://api.github.com/repos/Shopify/active_merchant/issues/1659","number":1659,"state":"open","locked":false,"title":"[Stripe] Add EMV \"chip & sign\", \"chip & offline PIN\" and Maestro support","user":{"login":"bizla","id":4581564,"avatar_url":"https://avatars.githubusercontent.com/u/4581564?v=3","gravatar_id":"","url":"https://api.github.com/users/bizla","html_url":"https://github.com/bizla","followers_url":"https://api.github.com/users/bizla/followers","following_url":"https://api.github.com/users/bizla/following{/other_user}","gists_url":"https://api.github.com/users/bizla/gists{/gist_id}","starred_url":"https://api.github.com/users/bizla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bizla/subscriptions","organizations_url":"https://api.github.com/users/bizla/orgs","repos_url":"https://api.github.com/users/bizla/repos","events_url":"https://api.github.com/users/bizla/events{/privacy}","received_events_url":"https://api.github.com/users/bizla/received_events","type":"User","site_admin":false},"body":"We've worked with Stripe to establish an EMV \"Chip & offline PIN\", and \"chip & sign\" API. This augments the Stripe integration to pass a chip card reader's TLV-BER strings through to Stripe. This also adds Maestro as a supported card type. \r\n\r\nA couple small things were added/changed to \"core\" ActiveMerchant too: \r\n- `CreditCard` now includes `icc_data` and `fallback_reason` fields, i.e. we've added an EMV chip to the credit card we're modelling. \r\n- VISA cards can have 19 digit PANs in the UK, so the regex has been modified.\r\n\r\nPlease review @j-mutter @girasquid @ntalbott ","created_at":"2015-04-22T15:42:22Z","updated_at":"2015-04-22T19:16:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be226b3769b1c61b41ab29ad472c2487dddc9067","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/active_merchant/pulls/1659/commits","review_comments_url":"https://api.github.com/repos/Shopify/active_merchant/pulls/1659/comments","review_comment_url":"https://api.github.com/repos/Shopify/active_merchant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/active_merchant/issues/1659/comments","statuses_url":"https://api.github.com/repos/Shopify/active_merchant/statuses/4e3bd603ab5d5778ea962bbab9d372ee245ffb1f","head":{"label":"Shopify:stripe_icc_data","ref":"stripe_icc_data","sha":"4e3bd603ab5d5778ea962bbab9d372ee245ffb1f","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":18294,"name":"active_merchant","full_name":"Shopify/active_merchant","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/active_merchant","description":"Active Merchant is a simple payment abstraction library extracted from Shopify. The aim of the project is to feel natural to Ruby users and to abstract as many parts as possible away from the user to offer a consistent interface across all supported gateways.","fork":false,"url":"https://api.github.com/repos/Shopify/active_merchant","forks_url":"https://api.github.com/repos/Shopify/active_merchant/forks","keys_url":"https://api.github.com/repos/Shopify/active_merchant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/active_merchant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/active_merchant/teams","hooks_url":"https://api.github.com/repos/Shopify/active_merchant/hooks","issue_events_url":"https://api.github.com/repos/Shopify/active_merchant/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/active_merchant/events","assignees_url":"https://api.github.com/repos/Shopify/active_merchant/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/active_merchant/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/active_merchant/tags","blobs_url":"https://api.github.com/repos/Shopify/active_merchant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/active_merchant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/active_merchant/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/active_merchant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/active_merchant/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/active_merchant/languages","stargazers_url":"https://api.github.com/repos/Shopify/active_merchant/stargazers","contributors_url":"https://api.github.com/repos/Shopify/active_merchant/contributors","subscribers_url":"https://api.github.com/repos/Shopify/active_merchant/subscribers","subscription_url":"https://api.github.com/repos/Shopify/active_merchant/subscription","commits_url":"https://api.github.com/repos/Shopify/active_merchant/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/active_merchant/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/active_merchant/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/active_merchant/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/active_merchant/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/active_merchant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/active_merchant/merges","archive_url":"https://api.github.com/repos/Shopify/active_merchant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/active_merchant/downloads","issues_url":"https://api.github.com/repos/Shopify/active_merchant/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/active_merchant/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/active_merchant/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/active_merchant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/active_merchant/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/active_merchant/releases{/id}","created_at":"2008-05-20T13:53:26Z","updated_at":"2015-04-22T16:22:25Z","pushed_at":"2015-04-22T19:11:37Z","git_url":"git://github.com/Shopify/active_merchant.git","ssh_url":"git@github.com:Shopify/active_merchant.git","clone_url":"https://github.com/Shopify/active_merchant.git","svn_url":"https://github.com/Shopify/active_merchant","homepage":"http://activemerchant.org","size":35817,"stargazers_count":3027,"watchers_count":3027,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1658,"mirror_url":null,"open_issues_count":42,"forks":1658,"open_issues":42,"watchers":3027,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"74cfc7b2a1d46ee535bcd2c1556fcda71d8929bf","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":18294,"name":"active_merchant","full_name":"Shopify/active_merchant","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/active_merchant","description":"Active Merchant is a simple payment abstraction library extracted from Shopify. The aim of the project is to feel natural to Ruby users and to abstract as many parts as possible away from the user to offer a consistent interface across all supported gateways.","fork":false,"url":"https://api.github.com/repos/Shopify/active_merchant","forks_url":"https://api.github.com/repos/Shopify/active_merchant/forks","keys_url":"https://api.github.com/repos/Shopify/active_merchant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/active_merchant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/active_merchant/teams","hooks_url":"https://api.github.com/repos/Shopify/active_merchant/hooks","issue_events_url":"https://api.github.com/repos/Shopify/active_merchant/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/active_merchant/events","assignees_url":"https://api.github.com/repos/Shopify/active_merchant/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/active_merchant/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/active_merchant/tags","blobs_url":"https://api.github.com/repos/Shopify/active_merchant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/active_merchant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/active_merchant/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/active_merchant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/active_merchant/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/active_merchant/languages","stargazers_url":"https://api.github.com/repos/Shopify/active_merchant/stargazers","contributors_url":"https://api.github.com/repos/Shopify/active_merchant/contributors","subscribers_url":"https://api.github.com/repos/Shopify/active_merchant/subscribers","subscription_url":"https://api.github.com/repos/Shopify/active_merchant/subscription","commits_url":"https://api.github.com/repos/Shopify/active_merchant/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/active_merchant/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/active_merchant/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/active_merchant/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/active_merchant/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/active_merchant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/active_merchant/merges","archive_url":"https://api.github.com/repos/Shopify/active_merchant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/active_merchant/downloads","issues_url":"https://api.github.com/repos/Shopify/active_merchant/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/active_merchant/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/active_merchant/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/active_merchant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/active_merchant/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/active_merchant/releases{/id}","created_at":"2008-05-20T13:53:26Z","updated_at":"2015-04-22T16:22:25Z","pushed_at":"2015-04-22T19:11:37Z","git_url":"git://github.com/Shopify/active_merchant.git","ssh_url":"git@github.com:Shopify/active_merchant.git","clone_url":"https://github.com/Shopify/active_merchant.git","svn_url":"https://github.com/Shopify/active_merchant","homepage":"http://activemerchant.org","size":35817,"stargazers_count":3027,"watchers_count":3027,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1658,"mirror_url":null,"open_issues_count":42,"forks":1658,"open_issues":42,"watchers":3027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/active_merchant/pulls/1659"},"html":{"href":"https://github.com/Shopify/active_merchant/pull/1659"},"issue":{"href":"https://api.github.com/repos/Shopify/active_merchant/issues/1659"},"comments":{"href":"https://api.github.com/repos/Shopify/active_merchant/issues/1659/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/active_merchant/pulls/1659/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/active_merchant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/active_merchant/pulls/1659/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/active_merchant/statuses/4e3bd603ab5d5778ea962bbab9d372ee245ffb1f"}}}}