{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/36615739","id":36615739,"diff_hunk":"@@ -830,6 +831,38 @@ public function isAbstract()\n     }\n \n     /**\n+     * Whether this definition is deprecated, that means it should not be called\n+     * anymore.\n+     *\n+     * @param bool $boolean\n+     *\n+     * @return Definition the current instance\n+     *\n+     * @todo Support a suggested definition instead ?\n+     *\n+     * @api\n+     */\n+    public function setDeprecated($boolean = true)\n+    {\n+        $this->deprecated = (bool) $boolean;","path":"src/Symfony/Component/DependencyInjection/Definition.php","position":25,"original_position":25,"commit_id":"17a72c0352eb7414db7b62f0181dc1c617fe06ca","original_commit_id":"17a72c0352eb7414db7b62f0181dc1c617fe06ca","user":{"login":"Taluu","id":239685,"avatar_url":"https://avatars.githubusercontent.com/u/239685?v=3","gravatar_id":"","url":"https://api.github.com/users/Taluu","html_url":"https://github.com/Taluu","followers_url":"https://api.github.com/users/Taluu/followers","following_url":"https://api.github.com/users/Taluu/following{/other_user}","gists_url":"https://api.github.com/users/Taluu/gists{/gist_id}","starred_url":"https://api.github.com/users/Taluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taluu/subscriptions","organizations_url":"https://api.github.com/users/Taluu/orgs","repos_url":"https://api.github.com/users/Taluu/repos","events_url":"https://api.github.com/users/Taluu/events{/privacy}","received_events_url":"https://api.github.com/users/Taluu/received_events","type":"User","site_admin":false},"body":"I'm not quite sure we should remove that, as this is purely a boolean flag (it is deprecated / it is not). Look at how it is handled for the `abstract` property...\r\n\r\nI can change this (see @nicolas-grekas' comment on the message and all) to be more flexible ?","created_at":"2015-08-10T09:49:06Z","updated_at":"2015-08-10T09:49:06Z","html_url":"https://github.com/symfony/symfony/pull/15491#discussion_r36615739","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/15491","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/36615739"},"html":{"href":"https://github.com/symfony/symfony/pull/15491#discussion_r36615739"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15491"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/15491","id":41911358,"html_url":"https://github.com/symfony/symfony/pull/15491","diff_url":"https://github.com/symfony/symfony/pull/15491.diff","patch_url":"https://github.com/symfony/symfony/pull/15491.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/15491","number":15491,"state":"open","locked":false,"title":"Add support for deprecated definitions","user":{"login":"Taluu","id":239685,"avatar_url":"https://avatars.githubusercontent.com/u/239685?v=3","gravatar_id":"","url":"https://api.github.com/users/Taluu","html_url":"https://github.com/Taluu","followers_url":"https://api.github.com/users/Taluu/followers","following_url":"https://api.github.com/users/Taluu/following{/other_user}","gists_url":"https://api.github.com/users/Taluu/gists{/gist_id}","starred_url":"https://api.github.com/users/Taluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taluu/subscriptions","organizations_url":"https://api.github.com/users/Taluu/orgs","repos_url":"https://api.github.com/users/Taluu/repos","events_url":"https://api.github.com/users/Taluu/events{/privacy}","received_events_url":"https://api.github.com/users/Taluu/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #14307\r\n| License       | MIT\r\n| Doc PR        | ~\r\n\r\nThis add a sort of marker in the Definition of a service that marks it as \"deprecated\". This is useful when we have a bunch of service and a bunch of where it is used, and we need to track if there are any uses before removing it (in a later version or right now). I was not sure if the `trigger_error` would be enough, or if I should log them instead.\r\n\r\nThis is more a WIP on a POC than anything currently, hence why I haven't made any PR to the docs. But I'm first waiting for feedbacks :}\r\n\r\nI was not sure if it should target 2.8 or master (3.0) though.","created_at":"2015-08-07T16:50:29Z","updated_at":"2015-08-10T09:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ac29ec1f1b9131f85fdaefa54c138f2af591292","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/15491/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/15491/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/15491/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/17a72c0352eb7414db7b62f0181dc1c617fe06ca","head":{"label":"Taluu:container-deprecated","ref":"container-deprecated","sha":"17a72c0352eb7414db7b62f0181dc1c617fe06ca","user":{"login":"Taluu","id":239685,"avatar_url":"https://avatars.githubusercontent.com/u/239685?v=3","gravatar_id":"","url":"https://api.github.com/users/Taluu","html_url":"https://github.com/Taluu","followers_url":"https://api.github.com/users/Taluu/followers","following_url":"https://api.github.com/users/Taluu/following{/other_user}","gists_url":"https://api.github.com/users/Taluu/gists{/gist_id}","starred_url":"https://api.github.com/users/Taluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taluu/subscriptions","organizations_url":"https://api.github.com/users/Taluu/orgs","repos_url":"https://api.github.com/users/Taluu/repos","events_url":"https://api.github.com/users/Taluu/events{/privacy}","received_events_url":"https://api.github.com/users/Taluu/received_events","type":"User","site_admin":false},"repo":{"id":2191230,"name":"symfony","full_name":"Taluu/symfony","owner":{"login":"Taluu","id":239685,"avatar_url":"https://avatars.githubusercontent.com/u/239685?v=3","gravatar_id":"","url":"https://api.github.com/users/Taluu","html_url":"https://github.com/Taluu","followers_url":"https://api.github.com/users/Taluu/followers","following_url":"https://api.github.com/users/Taluu/following{/other_user}","gists_url":"https://api.github.com/users/Taluu/gists{/gist_id}","starred_url":"https://api.github.com/users/Taluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taluu/subscriptions","organizations_url":"https://api.github.com/users/Taluu/orgs","repos_url":"https://api.github.com/users/Taluu/repos","events_url":"https://api.github.com/users/Taluu/events{/privacy}","received_events_url":"https://api.github.com/users/Taluu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Taluu/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/Taluu/symfony","forks_url":"https://api.github.com/repos/Taluu/symfony/forks","keys_url":"https://api.github.com/repos/Taluu/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Taluu/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Taluu/symfony/teams","hooks_url":"https://api.github.com/repos/Taluu/symfony/hooks","issue_events_url":"https://api.github.com/repos/Taluu/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/Taluu/symfony/events","assignees_url":"https://api.github.com/repos/Taluu/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/Taluu/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/Taluu/symfony/tags","blobs_url":"https://api.github.com/repos/Taluu/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Taluu/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Taluu/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/Taluu/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Taluu/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/Taluu/symfony/languages","stargazers_url":"https://api.github.com/repos/Taluu/symfony/stargazers","contributors_url":"https://api.github.com/repos/Taluu/symfony/contributors","subscribers_url":"https://api.github.com/repos/Taluu/symfony/subscribers","subscription_url":"https://api.github.com/repos/Taluu/symfony/subscription","commits_url":"https://api.github.com/repos/Taluu/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/Taluu/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/Taluu/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/Taluu/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/Taluu/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/Taluu/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Taluu/symfony/merges","archive_url":"https://api.github.com/repos/Taluu/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Taluu/symfony/downloads","issues_url":"https://api.github.com/repos/Taluu/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/Taluu/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/Taluu/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/Taluu/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Taluu/symfony/labels{/name}","releases_url":"https://api.github.com/repos/Taluu/symfony/releases{/id}","created_at":"2011-08-11T13:20:40Z","updated_at":"2014-03-25T22:04:54Z","pushed_at":"2015-08-10T09:29:44Z","git_url":"git://github.com/Taluu/symfony.git","ssh_url":"git@github.com:Taluu/symfony.git","clone_url":"https://github.com/Taluu/symfony.git","svn_url":"https://github.com/Taluu/symfony","homepage":"symfony.com","size":57752,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"7f745d72c004dc37572bb57cb772df1f2d8ac146","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-08-10T09:15:41Z","pushed_at":"2015-08-10T09:47:55Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":235893,"stargazers_count":10605,"watchers_count":10605,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4202,"mirror_url":null,"open_issues_count":889,"forks":4202,"open_issues":889,"watchers":10605,"default_branch":"2.8"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15491"},"html":{"href":"https://github.com/symfony/symfony/pull/15491"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/15491"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/15491/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15491/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15491/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/17a72c0352eb7414db7b62f0181dc1c617fe06ca"}}}}