{"action":"created","issue":{"url":"https://api.github.com/repos/sherpa/sherpa/issues/70","labels_url":"https://api.github.com/repos/sherpa/sherpa/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/sherpa/sherpa/issues/70/comments","events_url":"https://api.github.com/repos/sherpa/sherpa/issues/70/events","html_url":"https://github.com/sherpa/sherpa/pull/70","id":96853405,"number":70,"title":"Fixes and PEP 8/pyflakes updates for utils","user":{"login":"DougBurke","id":224638,"avatar_url":"https://avatars.githubusercontent.com/u/224638?v=3","gravatar_id":"","url":"https://api.github.com/users/DougBurke","html_url":"https://github.com/DougBurke","followers_url":"https://api.github.com/users/DougBurke/followers","following_url":"https://api.github.com/users/DougBurke/following{/other_user}","gists_url":"https://api.github.com/users/DougBurke/gists{/gist_id}","starred_url":"https://api.github.com/users/DougBurke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougBurke/subscriptions","organizations_url":"https://api.github.com/users/DougBurke/orgs","repos_url":"https://api.github.com/users/DougBurke/repos","events_url":"https://api.github.com/users/DougBurke/events{/privacy}","received_events_url":"https://api.github.com/users/DougBurke/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sherpa/sherpa/labels/3%20%20-%20Working","name":"3  - Working","color":"ededed"},{"url":"https://api.github.com/repos/sherpa/sherpa/labels/area:code","name":"area:code","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-23T16:31:17Z","updated_at":"2015-07-23T23:36:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sherpa/sherpa/pulls/70","html_url":"https://github.com/sherpa/sherpa/pull/70","diff_url":"https://github.com/sherpa/sherpa/pull/70.diff","patch_url":"https://github.com/sherpa/sherpa/pull/70.patch"},"body":"These commits fix a potential error, in that `OutOfBoundErr` exceptions were not being caught (although it's not actually clear that this is ever thrown). There were several places where screen output used either `print` or `sys.stderr.write`: these have been changed to use the `debug` and `warning` loggers instead (respectively). Several routines which use `min` and `max` as variable names have been changed. There are very-minor documentation changes for Sphinx (mainly change `:` to `::` when introducing some maths).\r\n\r\nIt also addresses a number of pyflakes/PEP-8 violations: more Pythonic use of boolean variables (e.g. `not xxx` rather than `False == xxx`); add spaces between operators; remove spaces before/after various brackets; line length; two blank lines between top-level declarations; explicit module export; remove blank characters at the ends of lines.\r\n\r\nThe commits have been broken up into separate sections to try and make reviewing the changes somewhat easier.\r\n\r\nThe reason for these changes is that I want to make some changes to the test class code, but found a number of issues that were being flagged up by\r\n\r\n```\r\npyflakes \"$1\"\r\npep8 --ignore=E221,E701,E202 --repeat \"$1\"\r\n```\r\n\r\nso decided to clean these up first."},"comment":{"url":"https://api.github.com/repos/sherpa/sherpa/issues/comments/124268722","html_url":"https://github.com/sherpa/sherpa/pull/70#issuecomment-124268722","issue_url":"https://api.github.com/repos/sherpa/sherpa/issues/70","id":124268722,"user":{"login":"DougBurke","id":224638,"avatar_url":"https://avatars.githubusercontent.com/u/224638?v=3","gravatar_id":"","url":"https://api.github.com/users/DougBurke","html_url":"https://github.com/DougBurke","followers_url":"https://api.github.com/users/DougBurke/followers","following_url":"https://api.github.com/users/DougBurke/following{/other_user}","gists_url":"https://api.github.com/users/DougBurke/gists{/gist_id}","starred_url":"https://api.github.com/users/DougBurke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougBurke/subscriptions","organizations_url":"https://api.github.com/users/DougBurke/orgs","repos_url":"https://api.github.com/users/DougBurke/repos","events_url":"https://api.github.com/users/DougBurke/events{/privacy}","received_events_url":"https://api.github.com/users/DougBurke/received_events","type":"User","site_admin":false},"created_at":"2015-07-23T23:36:13Z","updated_at":"2015-07-23T23:36:13Z","body":"I think that some form of rebasing is going to be needed once #59 is\nmerged. One reason for keeping them separate is that it might be a bit\ncleaner to review the changes broken up this way (i.e. two PRs), but I\ndon't have a strong opinion on this.\n\nOn Thu, Jul 23, 2015 at 5:35 PM Omar Laurino <notifications@github.com>\nwrote:\n\n> @DougBurke <https://github.com/DougBurke> Thanks for noting it. In\n> general, we should avoid dependencies between PRs, but sometimes that's\n> just the way to go, as long as we know that one PR has to be merged before\n> the other.\n>\n> In this case, I wonder if we shouldn't close #70\n> <https://github.com/sherpa/sherpa/pull/70> and work with #71\n> <https://github.com/sherpa/sherpa/pull/71> as a single clean-up PR.\n> Otherwise I would suggest we rebase #71\n> <https://github.com/sherpa/sherpa/pull/71> on top of master and keep them\n> separate, since they do not overlap.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/sherpa/sherpa/pull/70#issuecomment-124246071>.\n>\n"}}