{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/pulls/16","id":31684690,"html_url":"https://github.com/tuxnsk/nodejs_libmodbus/pull/16","diff_url":"https://github.com/tuxnsk/nodejs_libmodbus/pull/16.diff","patch_url":"https://github.com/tuxnsk/nodejs_libmodbus/pull/16.patch","issue_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/issues/16","number":16,"state":"closed","locked":false,"title":"fix(build:binding.gyp): remove OS-specific conditions","user":{"login":"ProteusCortex","id":1230251,"avatar_url":"https://avatars.githubusercontent.com/u/1230251?v=3","gravatar_id":"","url":"https://api.github.com/users/ProteusCortex","html_url":"https://github.com/ProteusCortex","followers_url":"https://api.github.com/users/ProteusCortex/followers","following_url":"https://api.github.com/users/ProteusCortex/following{/other_user}","gists_url":"https://api.github.com/users/ProteusCortex/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteusCortex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteusCortex/subscriptions","organizations_url":"https://api.github.com/users/ProteusCortex/orgs","repos_url":"https://api.github.com/users/ProteusCortex/repos","events_url":"https://api.github.com/users/ProteusCortex/events{/privacy}","received_events_url":"https://api.github.com/users/ProteusCortex/received_events","type":"User","site_admin":false},"body":"The defined parameters are working just fine in other OSes too. I\r\nhaven't tested this in Windows yet, but it should work anywhere with\r\nNode v0.10.x.\r\n\r\nCloses #4","created_at":"2015-03-22T08:08:17Z","updated_at":"2015-03-27T04:26:24Z","closed_at":"2015-03-27T04:26:24Z","merged_at":"2015-03-27T04:26:24Z","merge_commit_sha":"0057e630e0bdf69304c685c0da8c8befa8ab0a9d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/pulls/16/commits","review_comments_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/pulls/16/comments","review_comment_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/issues/16/comments","statuses_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/statuses/30b0dd0054800f48cc585f21b899ad872db63eba","head":{"label":"ProteusCortex:master","ref":"master","sha":"30b0dd0054800f48cc585f21b899ad872db63eba","user":{"login":"ProteusCortex","id":1230251,"avatar_url":"https://avatars.githubusercontent.com/u/1230251?v=3","gravatar_id":"","url":"https://api.github.com/users/ProteusCortex","html_url":"https://github.com/ProteusCortex","followers_url":"https://api.github.com/users/ProteusCortex/followers","following_url":"https://api.github.com/users/ProteusCortex/following{/other_user}","gists_url":"https://api.github.com/users/ProteusCortex/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteusCortex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteusCortex/subscriptions","organizations_url":"https://api.github.com/users/ProteusCortex/orgs","repos_url":"https://api.github.com/users/ProteusCortex/repos","events_url":"https://api.github.com/users/ProteusCortex/events{/privacy}","received_events_url":"https://api.github.com/users/ProteusCortex/received_events","type":"User","site_admin":false},"repo":{"id":32667239,"name":"nodejs_libmodbus","full_name":"ProteusCortex/nodejs_libmodbus","owner":{"login":"ProteusCortex","id":1230251,"avatar_url":"https://avatars.githubusercontent.com/u/1230251?v=3","gravatar_id":"","url":"https://api.github.com/users/ProteusCortex","html_url":"https://github.com/ProteusCortex","followers_url":"https://api.github.com/users/ProteusCortex/followers","following_url":"https://api.github.com/users/ProteusCortex/following{/other_user}","gists_url":"https://api.github.com/users/ProteusCortex/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteusCortex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteusCortex/subscriptions","organizations_url":"https://api.github.com/users/ProteusCortex/orgs","repos_url":"https://api.github.com/users/ProteusCortex/repos","events_url":"https://api.github.com/users/ProteusCortex/events{/privacy}","received_events_url":"https://api.github.com/users/ProteusCortex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ProteusCortex/nodejs_libmodbus","description":"libmodbus binding for nodejs","fork":true,"url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus","forks_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/forks","keys_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/teams","hooks_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/hooks","issue_events_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/issues/events{/number}","events_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/events","assignees_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/assignees{/user}","branches_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/branches{/branch}","tags_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/tags","blobs_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/statuses/{sha}","languages_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/languages","stargazers_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/stargazers","contributors_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/contributors","subscribers_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/subscribers","subscription_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/subscription","commits_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/contents/{+path}","compare_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/merges","archive_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/downloads","issues_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/issues{/number}","pulls_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/pulls{/number}","milestones_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/milestones{/number}","notifications_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/labels{/name}","releases_url":"https://api.github.com/repos/ProteusCortex/nodejs_libmodbus/releases{/id}","created_at":"2015-03-22T08:02:00Z","updated_at":"2015-03-24T11:39:12Z","pushed_at":"2015-03-24T11:39:12Z","git_url":"git://github.com/ProteusCortex/nodejs_libmodbus.git","ssh_url":"git@github.com:ProteusCortex/nodejs_libmodbus.git","clone_url":"https://github.com/ProteusCortex/nodejs_libmodbus.git","svn_url":"https://github.com/ProteusCortex/nodejs_libmodbus","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tuxnsk:master","ref":"master","sha":"3081bf0093f2dff21255b5d424a06545448d9e99","user":{"login":"tuxnsk","id":2098042,"avatar_url":"https://avatars.githubusercontent.com/u/2098042?v=3","gravatar_id":"","url":"https://api.github.com/users/tuxnsk","html_url":"https://github.com/tuxnsk","followers_url":"https://api.github.com/users/tuxnsk/followers","following_url":"https://api.github.com/users/tuxnsk/following{/other_user}","gists_url":"https://api.github.com/users/tuxnsk/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxnsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxnsk/subscriptions","organizations_url":"https://api.github.com/users/tuxnsk/orgs","repos_url":"https://api.github.com/users/tuxnsk/repos","events_url":"https://api.github.com/users/tuxnsk/events{/privacy}","received_events_url":"https://api.github.com/users/tuxnsk/received_events","type":"User","site_admin":false},"repo":{"id":5303533,"name":"nodejs_libmodbus","full_name":"tuxnsk/nodejs_libmodbus","owner":{"login":"tuxnsk","id":2098042,"avatar_url":"https://avatars.githubusercontent.com/u/2098042?v=3","gravatar_id":"","url":"https://api.github.com/users/tuxnsk","html_url":"https://github.com/tuxnsk","followers_url":"https://api.github.com/users/tuxnsk/followers","following_url":"https://api.github.com/users/tuxnsk/following{/other_user}","gists_url":"https://api.github.com/users/tuxnsk/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxnsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxnsk/subscriptions","organizations_url":"https://api.github.com/users/tuxnsk/orgs","repos_url":"https://api.github.com/users/tuxnsk/repos","events_url":"https://api.github.com/users/tuxnsk/events{/privacy}","received_events_url":"https://api.github.com/users/tuxnsk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tuxnsk/nodejs_libmodbus","description":"libmodbus binding for nodejs","fork":false,"url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus","forks_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/forks","keys_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/teams","hooks_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/hooks","issue_events_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/issues/events{/number}","events_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/events","assignees_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/assignees{/user}","branches_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/branches{/branch}","tags_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/tags","blobs_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/statuses/{sha}","languages_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/languages","stargazers_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/stargazers","contributors_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/contributors","subscribers_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/subscribers","subscription_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/subscription","commits_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/contents/{+path}","compare_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/merges","archive_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/downloads","issues_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/issues{/number}","pulls_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/pulls{/number}","milestones_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/milestones{/number}","notifications_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/labels{/name}","releases_url":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/releases{/id}","created_at":"2012-08-05T12:56:05Z","updated_at":"2015-03-27T03:54:56Z","pushed_at":"2015-03-27T04:26:24Z","git_url":"git://github.com/tuxnsk/nodejs_libmodbus.git","ssh_url":"git@github.com:tuxnsk/nodejs_libmodbus.git","clone_url":"https://github.com/tuxnsk/nodejs_libmodbus.git","svn_url":"https://github.com/tuxnsk/nodejs_libmodbus","homepage":null,"size":356,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/pulls/16"},"html":{"href":"https://github.com/tuxnsk/nodejs_libmodbus/pull/16"},"issue":{"href":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/issues/16"},"comments":{"href":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/tuxnsk/nodejs_libmodbus/statuses/30b0dd0054800f48cc585f21b899ad872db63eba"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tuxnsk","id":2098042,"avatar_url":"https://avatars.githubusercontent.com/u/2098042?v=3","gravatar_id":"","url":"https://api.github.com/users/tuxnsk","html_url":"https://github.com/tuxnsk","followers_url":"https://api.github.com/users/tuxnsk/followers","following_url":"https://api.github.com/users/tuxnsk/following{/other_user}","gists_url":"https://api.github.com/users/tuxnsk/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxnsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxnsk/subscriptions","organizations_url":"https://api.github.com/users/tuxnsk/orgs","repos_url":"https://api.github.com/users/tuxnsk/repos","events_url":"https://api.github.com/users/tuxnsk/events{/privacy}","received_events_url":"https://api.github.com/users/tuxnsk/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":3,"additions":55,"deletions":27,"changed_files":3}}