{"action":"created","comment":{"url":"https://api.github.com/repos/vgno/roc-web-react/pulls/comments/47008381","id":47008381,"diff_hunk":"@@ -1,31 +1,31 @@\n-/* global ROC_REACT_ROUTES ROC_REACT_REDUCERS HAS_REDUCERS HAS_MIDDLEWARES ROC_REACT_MIDDLEWARES USE_DEFAULT_REDUCERS\n-    USE_DEFAULT_MIDDLEWARES USE_DEFAULT_ROUTES __CLIENT__\n+/* global REACT_ROUTER_ROUTES REDUX_REDUCERS HAS_REDUX_REDUCERS HAS_REDUX_MIDDLEWARES REDUX_MIDDLEWARES","path":"src/default/get-routes-and-store.js","position":3,"original_position":3,"commit_id":"682866de8bc844b8869123f7dd94b865bc7573b9","original_commit_id":"682866de8bc844b8869123f7dd94b865bc7573b9","user":{"login":"andreasrs","id":726573,"avatar_url":"https://avatars.githubusercontent.com/u/726573?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasrs","html_url":"https://github.com/andreasrs","followers_url":"https://api.github.com/users/andreasrs/followers","following_url":"https://api.github.com/users/andreasrs/following{/other_user}","gists_url":"https://api.github.com/users/andreasrs/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasrs/subscriptions","organizations_url":"https://api.github.com/users/andreasrs/orgs","repos_url":"https://api.github.com/users/andreasrs/repos","events_url":"https://api.github.com/users/andreasrs/events{/privacy}","received_events_url":"https://api.github.com/users/andreasrs/received_events","type":"User","site_admin":false},"body":"Again. I think it's time to mention DefinePlugin explicitly. It will help clarify questions that _will_ pop up when others start reading the code.","created_at":"2015-12-08T20:24:49Z","updated_at":"2015-12-08T20:24:49Z","html_url":"https://github.com/vgno/roc-web-react/pull/25#discussion_r47008381","pull_request_url":"https://api.github.com/repos/vgno/roc-web-react/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/vgno/roc-web-react/pulls/comments/47008381"},"html":{"href":"https://github.com/vgno/roc-web-react/pull/25#discussion_r47008381"},"pull_request":{"href":"https://api.github.com/repos/vgno/roc-web-react/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/vgno/roc-web-react/pulls/25","id":52987490,"html_url":"https://github.com/vgno/roc-web-react/pull/25","diff_url":"https://github.com/vgno/roc-web-react/pull/25.diff","patch_url":"https://github.com/vgno/roc-web-react/pull/25.patch","issue_url":"https://api.github.com/repos/vgno/roc-web-react/issues/25","number":25,"state":"open","locked":false,"title":"Better names for Webpack varaibles to work with new Koa middlewares","user":{"login":"DLMR","id":2854610,"avatar_url":"https://avatars.githubusercontent.com/u/2854610?v=3","gravatar_id":"","url":"https://api.github.com/users/DLMR","html_url":"https://github.com/DLMR","followers_url":"https://api.github.com/users/DLMR/followers","following_url":"https://api.github.com/users/DLMR/following{/other_user}","gists_url":"https://api.github.com/users/DLMR/gists{/gist_id}","starred_url":"https://api.github.com/users/DLMR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DLMR/subscriptions","organizations_url":"https://api.github.com/users/DLMR/orgs","repos_url":"https://api.github.com/users/DLMR/repos","events_url":"https://api.github.com/users/DLMR/events{/privacy}","received_events_url":"https://api.github.com/users/DLMR/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-08T14:34:03Z","updated_at":"2015-12-08T20:24:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e53fe09118a559e8750a12ec2bc87745103c4e9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vgno/roc-web-react/pulls/25/commits","review_comments_url":"https://api.github.com/repos/vgno/roc-web-react/pulls/25/comments","review_comment_url":"https://api.github.com/repos/vgno/roc-web-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vgno/roc-web-react/issues/25/comments","statuses_url":"https://api.github.com/repos/vgno/roc-web-react/statuses/682866de8bc844b8869123f7dd94b865bc7573b9","head":{"label":"vgno:refactor/better-naming","ref":"refactor/better-naming","sha":"682866de8bc844b8869123f7dd94b865bc7573b9","user":{"login":"vgno","id":586889,"avatar_url":"https://avatars.githubusercontent.com/u/586889?v=3","gravatar_id":"","url":"https://api.github.com/users/vgno","html_url":"https://github.com/vgno","followers_url":"https://api.github.com/users/vgno/followers","following_url":"https://api.github.com/users/vgno/following{/other_user}","gists_url":"https://api.github.com/users/vgno/gists{/gist_id}","starred_url":"https://api.github.com/users/vgno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgno/subscriptions","organizations_url":"https://api.github.com/users/vgno/orgs","repos_url":"https://api.github.com/users/vgno/repos","events_url":"https://api.github.com/users/vgno/events{/privacy}","received_events_url":"https://api.github.com/users/vgno/received_events","type":"Organization","site_admin":false},"repo":{"id":46725254,"name":"roc-web-react","full_name":"vgno/roc-web-react","owner":{"login":"vgno","id":586889,"avatar_url":"https://avatars.githubusercontent.com/u/586889?v=3","gravatar_id":"","url":"https://api.github.com/users/vgno","html_url":"https://github.com/vgno","followers_url":"https://api.github.com/users/vgno/followers","following_url":"https://api.github.com/users/vgno/following{/other_user}","gists_url":"https://api.github.com/users/vgno/gists{/gist_id}","starred_url":"https://api.github.com/users/vgno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgno/subscriptions","organizations_url":"https://api.github.com/users/vgno/orgs","repos_url":"https://api.github.com/users/vgno/repos","events_url":"https://api.github.com/users/vgno/events{/privacy}","received_events_url":"https://api.github.com/users/vgno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vgno/roc-web-react","description":"","fork":false,"url":"https://api.github.com/repos/vgno/roc-web-react","forks_url":"https://api.github.com/repos/vgno/roc-web-react/forks","keys_url":"https://api.github.com/repos/vgno/roc-web-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vgno/roc-web-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vgno/roc-web-react/teams","hooks_url":"https://api.github.com/repos/vgno/roc-web-react/hooks","issue_events_url":"https://api.github.com/repos/vgno/roc-web-react/issues/events{/number}","events_url":"https://api.github.com/repos/vgno/roc-web-react/events","assignees_url":"https://api.github.com/repos/vgno/roc-web-react/assignees{/user}","branches_url":"https://api.github.com/repos/vgno/roc-web-react/branches{/branch}","tags_url":"https://api.github.com/repos/vgno/roc-web-react/tags","blobs_url":"https://api.github.com/repos/vgno/roc-web-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vgno/roc-web-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vgno/roc-web-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/vgno/roc-web-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vgno/roc-web-react/statuses/{sha}","languages_url":"https://api.github.com/repos/vgno/roc-web-react/languages","stargazers_url":"https://api.github.com/repos/vgno/roc-web-react/stargazers","contributors_url":"https://api.github.com/repos/vgno/roc-web-react/contributors","subscribers_url":"https://api.github.com/repos/vgno/roc-web-react/subscribers","subscription_url":"https://api.github.com/repos/vgno/roc-web-react/subscription","commits_url":"https://api.github.com/repos/vgno/roc-web-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/vgno/roc-web-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/vgno/roc-web-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/vgno/roc-web-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/vgno/roc-web-react/contents/{+path}","compare_url":"https://api.github.com/repos/vgno/roc-web-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vgno/roc-web-react/merges","archive_url":"https://api.github.com/repos/vgno/roc-web-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vgno/roc-web-react/downloads","issues_url":"https://api.github.com/repos/vgno/roc-web-react/issues{/number}","pulls_url":"https://api.github.com/repos/vgno/roc-web-react/pulls{/number}","milestones_url":"https://api.github.com/repos/vgno/roc-web-react/milestones{/number}","notifications_url":"https://api.github.com/repos/vgno/roc-web-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vgno/roc-web-react/labels{/name}","releases_url":"https://api.github.com/repos/vgno/roc-web-react/releases{/id}","created_at":"2015-11-23T14:21:14Z","updated_at":"2015-12-04T10:11:02Z","pushed_at":"2015-12-08T20:12:59Z","git_url":"git://github.com/vgno/roc-web-react.git","ssh_url":"git@github.com:vgno/roc-web-react.git","clone_url":"https://github.com/vgno/roc-web-react.git","svn_url":"https://github.com/vgno/roc-web-react","homepage":null,"size":315,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"vgno:master","ref":"master","sha":"d0e7e81b59cf95b5648b6c9fab6687e9f666c9cd","user":{"login":"vgno","id":586889,"avatar_url":"https://avatars.githubusercontent.com/u/586889?v=3","gravatar_id":"","url":"https://api.github.com/users/vgno","html_url":"https://github.com/vgno","followers_url":"https://api.github.com/users/vgno/followers","following_url":"https://api.github.com/users/vgno/following{/other_user}","gists_url":"https://api.github.com/users/vgno/gists{/gist_id}","starred_url":"https://api.github.com/users/vgno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgno/subscriptions","organizations_url":"https://api.github.com/users/vgno/orgs","repos_url":"https://api.github.com/users/vgno/repos","events_url":"https://api.github.com/users/vgno/events{/privacy}","received_events_url":"https://api.github.com/users/vgno/received_events","type":"Organization","site_admin":false},"repo":{"id":46725254,"name":"roc-web-react","full_name":"vgno/roc-web-react","owner":{"login":"vgno","id":586889,"avatar_url":"https://avatars.githubusercontent.com/u/586889?v=3","gravatar_id":"","url":"https://api.github.com/users/vgno","html_url":"https://github.com/vgno","followers_url":"https://api.github.com/users/vgno/followers","following_url":"https://api.github.com/users/vgno/following{/other_user}","gists_url":"https://api.github.com/users/vgno/gists{/gist_id}","starred_url":"https://api.github.com/users/vgno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgno/subscriptions","organizations_url":"https://api.github.com/users/vgno/orgs","repos_url":"https://api.github.com/users/vgno/repos","events_url":"https://api.github.com/users/vgno/events{/privacy}","received_events_url":"https://api.github.com/users/vgno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vgno/roc-web-react","description":"","fork":false,"url":"https://api.github.com/repos/vgno/roc-web-react","forks_url":"https://api.github.com/repos/vgno/roc-web-react/forks","keys_url":"https://api.github.com/repos/vgno/roc-web-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vgno/roc-web-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vgno/roc-web-react/teams","hooks_url":"https://api.github.com/repos/vgno/roc-web-react/hooks","issue_events_url":"https://api.github.com/repos/vgno/roc-web-react/issues/events{/number}","events_url":"https://api.github.com/repos/vgno/roc-web-react/events","assignees_url":"https://api.github.com/repos/vgno/roc-web-react/assignees{/user}","branches_url":"https://api.github.com/repos/vgno/roc-web-react/branches{/branch}","tags_url":"https://api.github.com/repos/vgno/roc-web-react/tags","blobs_url":"https://api.github.com/repos/vgno/roc-web-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vgno/roc-web-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vgno/roc-web-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/vgno/roc-web-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vgno/roc-web-react/statuses/{sha}","languages_url":"https://api.github.com/repos/vgno/roc-web-react/languages","stargazers_url":"https://api.github.com/repos/vgno/roc-web-react/stargazers","contributors_url":"https://api.github.com/repos/vgno/roc-web-react/contributors","subscribers_url":"https://api.github.com/repos/vgno/roc-web-react/subscribers","subscription_url":"https://api.github.com/repos/vgno/roc-web-react/subscription","commits_url":"https://api.github.com/repos/vgno/roc-web-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/vgno/roc-web-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/vgno/roc-web-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/vgno/roc-web-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/vgno/roc-web-react/contents/{+path}","compare_url":"https://api.github.com/repos/vgno/roc-web-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vgno/roc-web-react/merges","archive_url":"https://api.github.com/repos/vgno/roc-web-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vgno/roc-web-react/downloads","issues_url":"https://api.github.com/repos/vgno/roc-web-react/issues{/number}","pulls_url":"https://api.github.com/repos/vgno/roc-web-react/pulls{/number}","milestones_url":"https://api.github.com/repos/vgno/roc-web-react/milestones{/number}","notifications_url":"https://api.github.com/repos/vgno/roc-web-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vgno/roc-web-react/labels{/name}","releases_url":"https://api.github.com/repos/vgno/roc-web-react/releases{/id}","created_at":"2015-11-23T14:21:14Z","updated_at":"2015-12-04T10:11:02Z","pushed_at":"2015-12-08T20:12:59Z","git_url":"git://github.com/vgno/roc-web-react.git","ssh_url":"git@github.com:vgno/roc-web-react.git","clone_url":"https://github.com/vgno/roc-web-react.git","svn_url":"https://github.com/vgno/roc-web-react","homepage":null,"size":315,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vgno/roc-web-react/pulls/25"},"html":{"href":"https://github.com/vgno/roc-web-react/pull/25"},"issue":{"href":"https://api.github.com/repos/vgno/roc-web-react/issues/25"},"comments":{"href":"https://api.github.com/repos/vgno/roc-web-react/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/vgno/roc-web-react/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/vgno/roc-web-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vgno/roc-web-react/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/vgno/roc-web-react/statuses/682866de8bc844b8869123f7dd94b865bc7573b9"}}}}