{"action":"closed","number":24987,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/24987","id":38614554,"html_url":"https://github.com/saltstack/salt/pull/24987","diff_url":"https://github.com/saltstack/salt/pull/24987.diff","patch_url":"https://github.com/saltstack/salt/pull/24987.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/24987","number":24987,"state":"closed","locked":false,"title":"Don't try to cache a template when it's not a file","user":{"login":"heewa","id":232685,"avatar_url":"https://avatars.githubusercontent.com/u/232685?v=3","gravatar_id":"","url":"https://api.github.com/users/heewa","html_url":"https://github.com/heewa","followers_url":"https://api.github.com/users/heewa/followers","following_url":"https://api.github.com/users/heewa/following{/other_user}","gists_url":"https://api.github.com/users/heewa/gists{/gist_id}","starred_url":"https://api.github.com/users/heewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heewa/subscriptions","organizations_url":"https://api.github.com/users/heewa/orgs","repos_url":"https://api.github.com/users/heewa/repos","events_url":"https://api.github.com/users/heewa/events{/privacy}","received_events_url":"https://api.github.com/users/heewa/received_events","type":"User","site_admin":false},"body":"When trying to use `file.managed` without a source file, just `contents`, with templating, `modules/file.py` tries to cache the template itself, but in this case it's not a file, so an Exception is raised when it tries to do string stuff to a `None`, which gets caught and turned into a confusing string error, shown to the user.\r\n\r\nThis PR fixes this issue by avoiding trying to cache a nonexistent file.","created_at":"2015-06-26T03:30:30Z","updated_at":"2015-06-29T14:02:59Z","closed_at":"2015-06-29T14:02:59Z","merged_at":"2015-06-29T14:02:59Z","merge_commit_sha":"5875ef05a7e12cc2342ea8c27ea8c761d0729c94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/24987/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/24987/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/24987/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/9ae0c78ffcb070b43d45e96b7ac0ca3c07c3cad3","head":{"label":"heewa:fix-trying-to-cache-no-file","ref":"fix-trying-to-cache-no-file","sha":"9ae0c78ffcb070b43d45e96b7ac0ca3c07c3cad3","user":{"login":"heewa","id":232685,"avatar_url":"https://avatars.githubusercontent.com/u/232685?v=3","gravatar_id":"","url":"https://api.github.com/users/heewa","html_url":"https://github.com/heewa","followers_url":"https://api.github.com/users/heewa/followers","following_url":"https://api.github.com/users/heewa/following{/other_user}","gists_url":"https://api.github.com/users/heewa/gists{/gist_id}","starred_url":"https://api.github.com/users/heewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heewa/subscriptions","organizations_url":"https://api.github.com/users/heewa/orgs","repos_url":"https://api.github.com/users/heewa/repos","events_url":"https://api.github.com/users/heewa/events{/privacy}","received_events_url":"https://api.github.com/users/heewa/received_events","type":"User","site_admin":false},"repo":{"id":14119941,"name":"salt","full_name":"heewa/salt","owner":{"login":"heewa","id":232685,"avatar_url":"https://avatars.githubusercontent.com/u/232685?v=3","gravatar_id":"","url":"https://api.github.com/users/heewa","html_url":"https://github.com/heewa","followers_url":"https://api.github.com/users/heewa/followers","following_url":"https://api.github.com/users/heewa/following{/other_user}","gists_url":"https://api.github.com/users/heewa/gists{/gist_id}","starred_url":"https://api.github.com/users/heewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heewa/subscriptions","organizations_url":"https://api.github.com/users/heewa/orgs","repos_url":"https://api.github.com/users/heewa/repos","events_url":"https://api.github.com/users/heewa/events{/privacy}","received_events_url":"https://api.github.com/users/heewa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heewa/salt","description":"Central system and configuration manager ","fork":true,"url":"https://api.github.com/repos/heewa/salt","forks_url":"https://api.github.com/repos/heewa/salt/forks","keys_url":"https://api.github.com/repos/heewa/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heewa/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heewa/salt/teams","hooks_url":"https://api.github.com/repos/heewa/salt/hooks","issue_events_url":"https://api.github.com/repos/heewa/salt/issues/events{/number}","events_url":"https://api.github.com/repos/heewa/salt/events","assignees_url":"https://api.github.com/repos/heewa/salt/assignees{/user}","branches_url":"https://api.github.com/repos/heewa/salt/branches{/branch}","tags_url":"https://api.github.com/repos/heewa/salt/tags","blobs_url":"https://api.github.com/repos/heewa/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heewa/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heewa/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/heewa/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heewa/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/heewa/salt/languages","stargazers_url":"https://api.github.com/repos/heewa/salt/stargazers","contributors_url":"https://api.github.com/repos/heewa/salt/contributors","subscribers_url":"https://api.github.com/repos/heewa/salt/subscribers","subscription_url":"https://api.github.com/repos/heewa/salt/subscription","commits_url":"https://api.github.com/repos/heewa/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/heewa/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/heewa/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/heewa/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/heewa/salt/contents/{+path}","compare_url":"https://api.github.com/repos/heewa/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heewa/salt/merges","archive_url":"https://api.github.com/repos/heewa/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heewa/salt/downloads","issues_url":"https://api.github.com/repos/heewa/salt/issues{/number}","pulls_url":"https://api.github.com/repos/heewa/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/heewa/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/heewa/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heewa/salt/labels{/name}","releases_url":"https://api.github.com/repos/heewa/salt/releases{/id}","created_at":"2013-11-04T18:40:36Z","updated_at":"2015-06-26T00:46:10Z","pushed_at":"2015-06-26T03:28:24Z","git_url":"git://github.com/heewa/salt.git","ssh_url":"git@github.com:heewa/salt.git","clone_url":"https://github.com/heewa/salt.git","svn_url":"https://github.com/heewa/salt","homepage":"saltstack.org","size":108929,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:2015.5","ref":"2015.5","sha":"a791b23ff9e9d8453915aaa6e808e076b63723d4","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2015-06-29T08:40:31Z","pushed_at":"2015-06-29T14:02:59Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":228913,"stargazers_count":5346,"watchers_count":5346,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2264,"mirror_url":null,"open_issues_count":2720,"forks":2264,"open_issues":2720,"watchers":5346,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/24987"},"html":{"href":"https://github.com/saltstack/salt/pull/24987"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/24987"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/24987/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/24987/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/24987/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/9ae0c78ffcb070b43d45e96b7ac0ca3c07c3cad3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}