{"action":"created","issue":{"url":"https://api.github.com/repos/RJacksonm1/node-dota2/issues/105","labels_url":"https://api.github.com/repos/RJacksonm1/node-dota2/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/RJacksonm1/node-dota2/issues/105/comments","events_url":"https://api.github.com/repos/RJacksonm1/node-dota2/issues/105/events","html_url":"https://github.com/RJacksonm1/node-dota2/issues/105","id":106186196,"number":105,"title":"crash when attempt to sendclienthello without steam connection","user":{"login":"howardchung","id":3134520,"avatar_url":"https://avatars.githubusercontent.com/u/3134520?v=3","gravatar_id":"","url":"https://api.github.com/users/howardchung","html_url":"https://github.com/howardchung","followers_url":"https://api.github.com/users/howardchung/followers","following_url":"https://api.github.com/users/howardchung/following{/other_user}","gists_url":"https://api.github.com/users/howardchung/gists{/gist_id}","starred_url":"https://api.github.com/users/howardchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardchung/subscriptions","organizations_url":"https://api.github.com/users/howardchung/orgs","repos_url":"https://api.github.com/users/howardchung/repos","events_url":"https://api.github.com/users/howardchung/events{/privacy}","received_events_url":"https://api.github.com/users/howardchung/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RJacksonm1/node-dota2/labels/non-critical%20bug","name":"non-critical bug","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-12T21:41:43Z","updated_at":"2015-10-16T01:13:40Z","closed_at":null,"body":"Apparently it's possible for node-dota2 to attempt to sendclienthello when its underlying Steam connection is down or otherwise unavailable, which causes a crash.  It should probably handle exceptions.\r\n\r\nTrace:\r\n```\r\n2015-09-12T21:26:08.052730+00:00 app[web.1]: /app/node_modules/steam/lib/steam_client.js:124\r\n2015-09-12T21:26:08.052733+00:00 app[web.1]:   this._connection.send(Buffer.concat([header.toBuffer(), body]));\r\n2015-09-12T21:26:08.052734+00:00 app[web.1]:                   ^\r\n2015-09-12T21:26:08.052735+00:00 app[web.1]: TypeError: Cannot read property 'send' of undefined\r\n2015-09-12T21:26:08.032350+00:00 app[web.1]: acct 67 ready, 31/105\r\n2015-09-12T21:26:08.052737+00:00 app[web.1]:     at SteamClient._send (/app/node_modules/steam/lib/steam_client.js:124:19)\r\n2015-09-12T21:26:08.045996+00:00 app[web.1]: acct 9 ready, 33/105\r\n2015-09-12T21:26:08.052738+00:00 app[web.1]:     at SteamClient.send (/app/node_modules/steam/lib/steam_client.js:133:8)\r\n2015-09-12T21:26:08.052739+00:00 app[web.1]:     at SteamGameCoordinator._send (/app/node_modules/steam/lib/handlers/game_coordinator/index.js:49:16)\r\n2015-09-12T21:26:08.082368+00:00 app[web.1]: npm ERR! Linux 3.13.0-61-generic\r\n2015-09-12T21:26:08.052740+00:00 app[web.1]:     at SteamGameCoordinator.send (/app/node_modules/steam/lib/handlers/game_coordinator/index.js:67:8)\r\n2015-09-12T21:26:08.083799+00:00 app[web.1]: npm ERR! code ELIFECYCLE\r\n2015-09-12T21:26:08.083955+00:00 app[web.1]: npm ERR! yasp@3.1.0 start: `node index.js`\r\n2015-09-12T21:26:08.052741+00:00 app[web.1]:     at Dota2Client._sendClientHello [as _onTimeout] (/app/node_modules/dota2/index.js:93:16)\r\n2015-09-12T21:26:08.084089+00:00 app[web.1]: npm ERR! Exit status 1\r\n2015-09-12T21:26:08.052743+00:00 app[web.1]:     at Timer.listOnTimeout (timers.js:119:15)\r\n```"},"comment":{"url":"https://api.github.com/repos/RJacksonm1/node-dota2/issues/comments/148565519","html_url":"https://github.com/RJacksonm1/node-dota2/issues/105#issuecomment-148565519","issue_url":"https://api.github.com/repos/RJacksonm1/node-dota2/issues/105","id":148565519,"user":{"login":"jimmydorry","id":5135141,"avatar_url":"https://avatars.githubusercontent.com/u/5135141?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmydorry","html_url":"https://github.com/jimmydorry","followers_url":"https://api.github.com/users/jimmydorry/followers","following_url":"https://api.github.com/users/jimmydorry/following{/other_user}","gists_url":"https://api.github.com/users/jimmydorry/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmydorry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmydorry/subscriptions","organizations_url":"https://api.github.com/users/jimmydorry/orgs","repos_url":"https://api.github.com/users/jimmydorry/repos","events_url":"https://api.github.com/users/jimmydorry/events{/privacy}","received_events_url":"https://api.github.com/users/jimmydorry/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T01:13:40Z","updated_at":"2015-10-16T01:13:40Z","body":"Was a fix applied for handling the exception? At the very least, node-dota2 shouldn't crash from an un-handled exception... unless we document that.\r\n\r\nhttps://github.com/RJacksonm1/node-dota2/issues/102 Issue for README update"}}