{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/globalize/pulls/comments/26811040","id":26811040,"diff_hunk":"@@ -0,0 +1,90 @@\n+define([\n+\t\"globalize\",\n+\t\"json!cldr-data/supplemental/likelySubtags.json\",\n+\t\"json!cldr-data/supplemental/postalCodeData.json\",\n+\t\"../../util\",\n+\n+\t\"globalize/postalcode\"\n+\n+], function( Globalize, likelySubtags, postalcode, util ) {\n+\n+\tQUnit.module( \".validatePostalCode( value )\", {\n+\t\tsetup: function() {\n+\t\t\tGlobalize.load( likelySubtags, {\n+\t\t\t\tmain: {\n+\t\t\t\t\tko: {}\n+\t\t\t\t}\n+\t\t\t});\n+\t\t\tGlobalize.locale( \"ko-KR\" );\n+\t\t},\n+\t\tteardown: util.resetCldrContent\n+\t});\n+\n+\tQUnit.test( \"should validate parameters\", function( assert ) {\n+\t\tutil.assertParameterPresence( assert, \"value\", function() {\n+\t\t\tGlobalize.validatePostalCode();\n+\t\t});\n+\n+\t\tutil.assertStringParameter( assert, \"value\", function( invalidValue ) {\n+\t\t\treturn function() {\n+\t\t\t\tGlobalize.validatePostalCode( invalidValue );\n+\t\t\t};\n+\t\t});\n+\t});\n+\n+\tQUnit.test( \"should validate CLDR content\", function( assert ) {\n+\t\tutil.assertCldrContent( assert, function() {\n+\t\t\tGlobalize.validatePostalCode( \"427-090\" );\n+\t\t});\n+\t});\n+\tQUnit.test( \"should return boolean\", function( assert ) {\n+\t\tGlobalize.load( postalcode );\n+\t\tassert.strictEqual( Globalize.validatePostalCode( \"427-090\" ), true );","path":"test/functional/postalcode/postalcode.js","position":42,"original_position":42,"commit_id":"b772d943ca40843fd1d85432a72b8e3c1f574e12","original_commit_id":"b772d943ca40843fd1d85432a72b8e3c1f574e12","user":{"login":"rxaviers","id":967155,"avatar_url":"https://avatars.githubusercontent.com/u/967155?v=3","gravatar_id":"","url":"https://api.github.com/users/rxaviers","html_url":"https://github.com/rxaviers","followers_url":"https://api.github.com/users/rxaviers/followers","following_url":"https://api.github.com/users/rxaviers/following{/other_user}","gists_url":"https://api.github.com/users/rxaviers/gists{/gist_id}","starred_url":"https://api.github.com/users/rxaviers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxaviers/subscriptions","organizations_url":"https://api.github.com/users/rxaviers/orgs","repos_url":"https://api.github.com/users/rxaviers/repos","events_url":"https://api.github.com/users/rxaviers/events{/privacy}","received_events_url":"https://api.github.com/users/rxaviers/received_events","type":"User","site_admin":false},"body":"How does this test pass? It misses the required `region`. Right?","created_at":"2015-03-20T00:29:47Z","updated_at":"2015-03-20T00:29:47Z","html_url":"https://github.com/jquery/globalize/pull/418#discussion_r26811040","pull_request_url":"https://api.github.com/repos/jquery/globalize/pulls/418","_links":{"self":{"href":"https://api.github.com/repos/jquery/globalize/pulls/comments/26811040"},"html":{"href":"https://github.com/jquery/globalize/pull/418#discussion_r26811040"},"pull_request":{"href":"https://api.github.com/repos/jquery/globalize/pulls/418"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/globalize/pulls/418","id":31202206,"html_url":"https://github.com/jquery/globalize/pull/418","diff_url":"https://github.com/jquery/globalize/pull/418.diff","patch_url":"https://github.com/jquery/globalize/pull/418.patch","issue_url":"https://api.github.com/repos/jquery/globalize/issues/418","number":418,"state":"open","locked":false,"title":"PostalCode: Add postalcode validator and alias","user":{"login":"mwmw7","id":1140031,"avatar_url":"https://avatars.githubusercontent.com/u/1140031?v=3","gravatar_id":"","url":"https://api.github.com/users/mwmw7","html_url":"https://github.com/mwmw7","followers_url":"https://api.github.com/users/mwmw7/followers","following_url":"https://api.github.com/users/mwmw7/following{/other_user}","gists_url":"https://api.github.com/users/mwmw7/gists{/gist_id}","starred_url":"https://api.github.com/users/mwmw7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwmw7/subscriptions","organizations_url":"https://api.github.com/users/mwmw7/orgs","repos_url":"https://api.github.com/users/mwmw7/repos","events_url":"https://api.github.com/users/mwmw7/events{/privacy}","received_events_url":"https://api.github.com/users/mwmw7/received_events","type":"User","site_admin":false},"body":"Partially fixes #407","created_at":"2015-03-15T15:53:26Z","updated_at":"2015-03-20T00:29:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42354a15baf201adc4db98ca2145a61b6929e306","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/globalize/pulls/418/commits","review_comments_url":"https://api.github.com/repos/jquery/globalize/pulls/418/comments","review_comment_url":"https://api.github.com/repos/jquery/globalize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/globalize/issues/418/comments","statuses_url":"https://api.github.com/repos/jquery/globalize/statuses/b772d943ca40843fd1d85432a72b8e3c1f574e12","head":{"label":"mwmw7:postalcode-globalize-407","ref":"postalcode-globalize-407","sha":"b772d943ca40843fd1d85432a72b8e3c1f574e12","user":{"login":"mwmw7","id":1140031,"avatar_url":"https://avatars.githubusercontent.com/u/1140031?v=3","gravatar_id":"","url":"https://api.github.com/users/mwmw7","html_url":"https://github.com/mwmw7","followers_url":"https://api.github.com/users/mwmw7/followers","following_url":"https://api.github.com/users/mwmw7/following{/other_user}","gists_url":"https://api.github.com/users/mwmw7/gists{/gist_id}","starred_url":"https://api.github.com/users/mwmw7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwmw7/subscriptions","organizations_url":"https://api.github.com/users/mwmw7/orgs","repos_url":"https://api.github.com/users/mwmw7/repos","events_url":"https://api.github.com/users/mwmw7/events{/privacy}","received_events_url":"https://api.github.com/users/mwmw7/received_events","type":"User","site_admin":false},"repo":{"id":32017230,"name":"globalize","full_name":"mwmw7/globalize","owner":{"login":"mwmw7","id":1140031,"avatar_url":"https://avatars.githubusercontent.com/u/1140031?v=3","gravatar_id":"","url":"https://api.github.com/users/mwmw7","html_url":"https://github.com/mwmw7","followers_url":"https://api.github.com/users/mwmw7/followers","following_url":"https://api.github.com/users/mwmw7/following{/other_user}","gists_url":"https://api.github.com/users/mwmw7/gists{/gist_id}","starred_url":"https://api.github.com/users/mwmw7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwmw7/subscriptions","organizations_url":"https://api.github.com/users/mwmw7/orgs","repos_url":"https://api.github.com/users/mwmw7/repos","events_url":"https://api.github.com/users/mwmw7/events{/privacy}","received_events_url":"https://api.github.com/users/mwmw7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwmw7/globalize","description":"A JavaScript library for internationalization and localization that leverage the official Unicode CLDR JSON data","fork":true,"url":"https://api.github.com/repos/mwmw7/globalize","forks_url":"https://api.github.com/repos/mwmw7/globalize/forks","keys_url":"https://api.github.com/repos/mwmw7/globalize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwmw7/globalize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwmw7/globalize/teams","hooks_url":"https://api.github.com/repos/mwmw7/globalize/hooks","issue_events_url":"https://api.github.com/repos/mwmw7/globalize/issues/events{/number}","events_url":"https://api.github.com/repos/mwmw7/globalize/events","assignees_url":"https://api.github.com/repos/mwmw7/globalize/assignees{/user}","branches_url":"https://api.github.com/repos/mwmw7/globalize/branches{/branch}","tags_url":"https://api.github.com/repos/mwmw7/globalize/tags","blobs_url":"https://api.github.com/repos/mwmw7/globalize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwmw7/globalize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwmw7/globalize/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwmw7/globalize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwmw7/globalize/statuses/{sha}","languages_url":"https://api.github.com/repos/mwmw7/globalize/languages","stargazers_url":"https://api.github.com/repos/mwmw7/globalize/stargazers","contributors_url":"https://api.github.com/repos/mwmw7/globalize/contributors","subscribers_url":"https://api.github.com/repos/mwmw7/globalize/subscribers","subscription_url":"https://api.github.com/repos/mwmw7/globalize/subscription","commits_url":"https://api.github.com/repos/mwmw7/globalize/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwmw7/globalize/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwmw7/globalize/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwmw7/globalize/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwmw7/globalize/contents/{+path}","compare_url":"https://api.github.com/repos/mwmw7/globalize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwmw7/globalize/merges","archive_url":"https://api.github.com/repos/mwmw7/globalize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwmw7/globalize/downloads","issues_url":"https://api.github.com/repos/mwmw7/globalize/issues{/number}","pulls_url":"https://api.github.com/repos/mwmw7/globalize/pulls{/number}","milestones_url":"https://api.github.com/repos/mwmw7/globalize/milestones{/number}","notifications_url":"https://api.github.com/repos/mwmw7/globalize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwmw7/globalize/labels{/name}","releases_url":"https://api.github.com/repos/mwmw7/globalize/releases{/id}","created_at":"2015-03-11T12:48:46Z","updated_at":"2015-03-15T15:30:05Z","pushed_at":"2015-03-20T00:01:49Z","git_url":"git://github.com/mwmw7/globalize.git","ssh_url":"git@github.com:mwmw7/globalize.git","clone_url":"https://github.com/mwmw7/globalize.git","svn_url":"https://github.com/mwmw7/globalize","homepage":"","size":5115,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"0eebc186c426c59f7b0376dfbdcbf1ec4caacbf1","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":946945,"name":"globalize","full_name":"jquery/globalize","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/globalize","description":"A JavaScript library for internationalization and localization that leverage the official Unicode CLDR JSON data","fork":false,"url":"https://api.github.com/repos/jquery/globalize","forks_url":"https://api.github.com/repos/jquery/globalize/forks","keys_url":"https://api.github.com/repos/jquery/globalize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/globalize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/globalize/teams","hooks_url":"https://api.github.com/repos/jquery/globalize/hooks","issue_events_url":"https://api.github.com/repos/jquery/globalize/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/globalize/events","assignees_url":"https://api.github.com/repos/jquery/globalize/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/globalize/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/globalize/tags","blobs_url":"https://api.github.com/repos/jquery/globalize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/globalize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/globalize/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/globalize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/globalize/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/globalize/languages","stargazers_url":"https://api.github.com/repos/jquery/globalize/stargazers","contributors_url":"https://api.github.com/repos/jquery/globalize/contributors","subscribers_url":"https://api.github.com/repos/jquery/globalize/subscribers","subscription_url":"https://api.github.com/repos/jquery/globalize/subscription","commits_url":"https://api.github.com/repos/jquery/globalize/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/globalize/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/globalize/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/globalize/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/globalize/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/globalize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/globalize/merges","archive_url":"https://api.github.com/repos/jquery/globalize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/globalize/downloads","issues_url":"https://api.github.com/repos/jquery/globalize/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/globalize/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/globalize/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/globalize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/globalize/labels{/name}","releases_url":"https://api.github.com/repos/jquery/globalize/releases{/id}","created_at":"2010-09-28T23:01:58Z","updated_at":"2015-03-20T00:24:37Z","pushed_at":"2015-03-20T00:24:37Z","git_url":"git://github.com/jquery/globalize.git","ssh_url":"git@github.com:jquery/globalize.git","clone_url":"https://github.com/jquery/globalize.git","svn_url":"https://github.com/jquery/globalize","homepage":"","size":9427,"stargazers_count":1565,"watchers_count":1565,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":356,"mirror_url":null,"open_issues_count":64,"forks":356,"open_issues":64,"watchers":1565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/globalize/pulls/418"},"html":{"href":"https://github.com/jquery/globalize/pull/418"},"issue":{"href":"https://api.github.com/repos/jquery/globalize/issues/418"},"comments":{"href":"https://api.github.com/repos/jquery/globalize/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/globalize/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/globalize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/globalize/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/globalize/statuses/b772d943ca40843fd1d85432a72b8e3c1f574e12"}}}}