{"action":"created","issue":{"url":"https://api.github.com/repos/mesosphere/serenity/issues/55","labels_url":"https://api.github.com/repos/mesosphere/serenity/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/mesosphere/serenity/issues/55/comments","events_url":"https://api.github.com/repos/mesosphere/serenity/issues/55/events","html_url":"https://github.com/mesosphere/serenity/pull/55","id":99188984,"number":55,"title":"Added tags for some filters, specifying on which type of module it's working.","user":{"login":"Bplotka","id":6950331,"avatar_url":"https://avatars.githubusercontent.com/u/6950331?v=3","gravatar_id":"","url":"https://api.github.com/users/Bplotka","html_url":"https://github.com/Bplotka","followers_url":"https://api.github.com/users/Bplotka/followers","following_url":"https://api.github.com/users/Bplotka/following{/other_user}","gists_url":"https://api.github.com/users/Bplotka/gists{/gist_id}","starred_url":"https://api.github.com/users/Bplotka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bplotka/subscriptions","organizations_url":"https://api.github.com/users/Bplotka/orgs","repos_url":"https://api.github.com/users/Bplotka/repos","events_url":"https://api.github.com/users/Bplotka/events{/privacy}","received_events_url":"https://api.github.com/users/Bplotka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nqn","id":897374,"avatar_url":"https://avatars.githubusercontent.com/u/897374?v=3","gravatar_id":"","url":"https://api.github.com/users/nqn","html_url":"https://github.com/nqn","followers_url":"https://api.github.com/users/nqn/followers","following_url":"https://api.github.com/users/nqn/following{/other_user}","gists_url":"https://api.github.com/users/nqn/gists{/gist_id}","starred_url":"https://api.github.com/users/nqn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nqn/subscriptions","organizations_url":"https://api.github.com/users/nqn/orgs","repos_url":"https://api.github.com/users/nqn/repos","events_url":"https://api.github.com/users/nqn/events{/privacy}","received_events_url":"https://api.github.com/users/nqn/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-08-05T12:03:31Z","updated_at":"2015-08-06T08:32:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mesosphere/serenity/pulls/55","html_url":"https://github.com/mesosphere/serenity/pull/55","diff_url":"https://github.com/mesosphere/serenity/pull/55.diff","patch_url":"https://github.com/mesosphere/serenity/pull/55.patch"},"body":"TODO: That was the hardest filter todo. Introduce this change on all filters. (5 min work)\r\n\r\n<in prog>\r\n\r\nSigned-off-by: bplotka <bwplotka@gmail.com>"},"comment":{"url":"https://api.github.com/repos/mesosphere/serenity/issues/comments/128291515","html_url":"https://github.com/mesosphere/serenity/pull/55#issuecomment-128291515","issue_url":"https://api.github.com/repos/mesosphere/serenity/issues/55","id":128291515,"user":{"login":"skonefal","id":10141081,"avatar_url":"https://avatars.githubusercontent.com/u/10141081?v=3","gravatar_id":"","url":"https://api.github.com/users/skonefal","html_url":"https://github.com/skonefal","followers_url":"https://api.github.com/users/skonefal/followers","following_url":"https://api.github.com/users/skonefal/following{/other_user}","gists_url":"https://api.github.com/users/skonefal/gists{/gist_id}","starred_url":"https://api.github.com/users/skonefal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skonefal/subscriptions","organizations_url":"https://api.github.com/users/skonefal/orgs","repos_url":"https://api.github.com/users/skonefal/repos","events_url":"https://api.github.com/users/skonefal/events{/privacy}","received_events_url":"https://api.github.com/users/skonefal/received_events","type":"User","site_admin":false},"created_at":"2015-08-06T08:32:28Z","updated_at":"2015-08-06T08:32:28Z","body":"From Serenity logging perspective we would have to tackle problem of having multiple instances of the same class and all of those does the same - but little bit different job. For example multiple EMA filters, or multiple time series export. Same class, many objects, different purposes.\r\n\r\nWith tagging, we could name all the components in pipeline (and also in \"fiuture\" PipleineConf file) and we could pinpoint exact filter that caused error.\r\n\r\nAlso if glog does not support file:line loggin we should add __FILE__:__LINE__ macros to serenity_log()"}}