{"action":"created","issue":{"url":"https://api.github.com/repos/fzaninotto/Faker/issues/798","labels_url":"https://api.github.com/repos/fzaninotto/Faker/issues/798/labels{/name}","comments_url":"https://api.github.com/repos/fzaninotto/Faker/issues/798/comments","events_url":"https://api.github.com/repos/fzaninotto/Faker/issues/798/events","html_url":"https://github.com/fzaninotto/Faker/pull/798","id":124133975,"number":798,"title":"Factory refactor + testing, define Locale and Provider constants","user":{"login":"pr0ggy","id":10563539,"avatar_url":"https://avatars.githubusercontent.com/u/10563539?v=3","gravatar_id":"","url":"https://api.github.com/users/pr0ggy","html_url":"https://github.com/pr0ggy","followers_url":"https://api.github.com/users/pr0ggy/followers","following_url":"https://api.github.com/users/pr0ggy/following{/other_user}","gists_url":"https://api.github.com/users/pr0ggy/gists{/gist_id}","starred_url":"https://api.github.com/users/pr0ggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pr0ggy/subscriptions","organizations_url":"https://api.github.com/users/pr0ggy/orgs","repos_url":"https://api.github.com/users/pr0ggy/repos","events_url":"https://api.github.com/users/pr0ggy/events{/privacy}","received_events_url":"https://api.github.com/users/pr0ggy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-28T22:13:15Z","updated_at":"2015-12-28T22:27:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fzaninotto/Faker/pulls/798","html_url":"https://github.com/fzaninotto/Faker/pull/798","diff_url":"https://github.com/fzaninotto/Faker/pull/798.diff","patch_url":"https://github.com/fzaninotto/Faker/pull/798.patch"},"body":"Wanted to make **`Faker\\Factory`** a bit more SRP-friendly...broke out separate **`Locale`** objects and associated factory, as well as an object to handle locale qualification.  Full unit tests included ([code coverage report](https://github.com/fzaninotto/Faker/files/73583/code-coverage.zip) attached).  These are injected into the **`Faker\\Factory`** via a new `init.php`, required from `Faker/Factory.php`.  Also pulled Locale and Provider ID constants out into `const.php`.  Unit tests make use of the Mockery engine, which has been included in `composer.json`.\r\n\r\nNo actual functionality changes should result, Faker creation and usage is exactly as before.  Ran multi-thousand iteration comparison runs, no appreciable performance impact."},"comment":{"url":"https://api.github.com/repos/fzaninotto/Faker/issues/comments/167669542","html_url":"https://github.com/fzaninotto/Faker/pull/798#issuecomment-167669542","issue_url":"https://api.github.com/repos/fzaninotto/Faker/issues/798","id":167669542,"user":{"login":"pr0ggy","id":10563539,"avatar_url":"https://avatars.githubusercontent.com/u/10563539?v=3","gravatar_id":"","url":"https://api.github.com/users/pr0ggy","html_url":"https://github.com/pr0ggy","followers_url":"https://api.github.com/users/pr0ggy/followers","following_url":"https://api.github.com/users/pr0ggy/following{/other_user}","gists_url":"https://api.github.com/users/pr0ggy/gists{/gist_id}","starred_url":"https://api.github.com/users/pr0ggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pr0ggy/subscriptions","organizations_url":"https://api.github.com/users/pr0ggy/orgs","repos_url":"https://api.github.com/users/pr0ggy/repos","events_url":"https://api.github.com/users/pr0ggy/events{/privacy}","received_events_url":"https://api.github.com/users/pr0ggy/received_events","type":"User","site_admin":false},"created_at":"2015-12-28T22:27:17Z","updated_at":"2015-12-28T22:27:17Z","body":"Bah forgot to squash the last merge, will correct"}}