{"action":"closed","number":377,"pull_request":{"url":"https://api.github.com/repos/clutchski/coffeelint/pulls/377","id":29070033,"html_url":"https://github.com/clutchski/coffeelint/pull/377","diff_url":"https://github.com/clutchski/coffeelint/pull/377.diff","patch_url":"https://github.com/clutchski/coffeelint/pull/377.patch","issue_url":"https://api.github.com/repos/clutchski/coffeelint/issues/377","number":377,"state":"closed","locked":false,"title":"Update to CoffeeScript 1.9.1","user":{"login":"swang","id":49867,"avatar_url":"https://avatars.githubusercontent.com/u/49867?v=3","gravatar_id":"","url":"https://api.github.com/users/swang","html_url":"https://github.com/swang","followers_url":"https://api.github.com/users/swang/followers","following_url":"https://api.github.com/users/swang/following{/other_user}","gists_url":"https://api.github.com/users/swang/gists{/gist_id}","starred_url":"https://api.github.com/users/swang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swang/subscriptions","organizations_url":"https://api.github.com/users/swang/orgs","repos_url":"https://api.github.com/users/swang/repos","events_url":"https://api.github.com/users/swang/events{/privacy}","received_events_url":"https://api.github.com/users/swang/received_events","type":"User","site_admin":false},"body":"# This shouldn't be merged yet as-is since package.json is pointing to jashkenas/coffeescript and not the npm version of coffeescript\r\n\r\nThis PR is for people to look over and test out so it can be released once CoffeeScript updates past 1.9.0 I also updated browserify/coffeeify to get them running again but since I don't use that functionality in coffeelint someone else will have to verify that it builds out correctly for their use-cases.\r\n\r\n------------------------------------------------------------------------\r\n\r\nThe new lexer was merged from PR made in jashkenas/coffeescript#3770\r\n\r\nAlso closes #372\r\n\r\nno_unnecessary_double_quotes\r\n\r\n- Removed Block RegExp Fix that was originally patched in PR #340.\r\n  Thanks to the new PR, this is no longer needed\r\n- Shortened function name `containsSingleQuote` to `hasSingleQuote`\r\n- Changed how we detect if we're inside an interpolated string to be\r\n  more like the way we handle interpolation in space_operators\r\n\r\nno_trailing_semicolons rule\r\n\r\n- Due to the new way tokens are generated, we now check for 'STRING_END'\r\n  token rather than a 'CALL_END' token\r\n\r\nspace_operators\r\n\r\n- Removed old code that assumed an interpolated string always begins\r\n  with empty quotes. Due to new changes in CoffeeScript lexer, we can\r\n  now use 'STRING_START' to determine the beginning of an interpolated\r\n  string\r\n- Renamed lintParens, lintCall to trackParens, trackCall respectively","created_at":"2015-02-11T06:05:50Z","updated_at":"2015-02-20T05:57:43Z","closed_at":"2015-02-20T05:57:43Z","merged_at":"2015-02-20T05:57:43Z","merge_commit_sha":"3ac0eb52b0faebca054d2dc166eb879b50c33efc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clutchski/coffeelint/pulls/377/commits","review_comments_url":"https://api.github.com/repos/clutchski/coffeelint/pulls/377/comments","review_comment_url":"https://api.github.com/repos/clutchski/coffeelint/pulls/comments/{number}","comments_url":"https://api.github.com/repos/clutchski/coffeelint/issues/377/comments","statuses_url":"https://api.github.com/repos/clutchski/coffeelint/statuses/c2acdbcaa8b00952608311c6a7e555e6256e248e","head":{"label":"swang:update_to_cs1.9","ref":"update_to_cs1.9","sha":"c2acdbcaa8b00952608311c6a7e555e6256e248e","user":{"login":"swang","id":49867,"avatar_url":"https://avatars.githubusercontent.com/u/49867?v=3","gravatar_id":"","url":"https://api.github.com/users/swang","html_url":"https://github.com/swang","followers_url":"https://api.github.com/users/swang/followers","following_url":"https://api.github.com/users/swang/following{/other_user}","gists_url":"https://api.github.com/users/swang/gists{/gist_id}","starred_url":"https://api.github.com/users/swang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swang/subscriptions","organizations_url":"https://api.github.com/users/swang/orgs","repos_url":"https://api.github.com/users/swang/repos","events_url":"https://api.github.com/users/swang/events{/privacy}","received_events_url":"https://api.github.com/users/swang/received_events","type":"User","site_admin":false},"repo":{"id":7496490,"name":"coffeelint","full_name":"swang/coffeelint","owner":{"login":"swang","id":49867,"avatar_url":"https://avatars.githubusercontent.com/u/49867?v=3","gravatar_id":"","url":"https://api.github.com/users/swang","html_url":"https://github.com/swang","followers_url":"https://api.github.com/users/swang/followers","following_url":"https://api.github.com/users/swang/following{/other_user}","gists_url":"https://api.github.com/users/swang/gists{/gist_id}","starred_url":"https://api.github.com/users/swang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swang/subscriptions","organizations_url":"https://api.github.com/users/swang/orgs","repos_url":"https://api.github.com/users/swang/repos","events_url":"https://api.github.com/users/swang/events{/privacy}","received_events_url":"https://api.github.com/users/swang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swang/coffeelint","description":"Lint your CoffeeScript.","fork":true,"url":"https://api.github.com/repos/swang/coffeelint","forks_url":"https://api.github.com/repos/swang/coffeelint/forks","keys_url":"https://api.github.com/repos/swang/coffeelint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swang/coffeelint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swang/coffeelint/teams","hooks_url":"https://api.github.com/repos/swang/coffeelint/hooks","issue_events_url":"https://api.github.com/repos/swang/coffeelint/issues/events{/number}","events_url":"https://api.github.com/repos/swang/coffeelint/events","assignees_url":"https://api.github.com/repos/swang/coffeelint/assignees{/user}","branches_url":"https://api.github.com/repos/swang/coffeelint/branches{/branch}","tags_url":"https://api.github.com/repos/swang/coffeelint/tags","blobs_url":"https://api.github.com/repos/swang/coffeelint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swang/coffeelint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swang/coffeelint/git/refs{/sha}","trees_url":"https://api.github.com/repos/swang/coffeelint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swang/coffeelint/statuses/{sha}","languages_url":"https://api.github.com/repos/swang/coffeelint/languages","stargazers_url":"https://api.github.com/repos/swang/coffeelint/stargazers","contributors_url":"https://api.github.com/repos/swang/coffeelint/contributors","subscribers_url":"https://api.github.com/repos/swang/coffeelint/subscribers","subscription_url":"https://api.github.com/repos/swang/coffeelint/subscription","commits_url":"https://api.github.com/repos/swang/coffeelint/commits{/sha}","git_commits_url":"https://api.github.com/repos/swang/coffeelint/git/commits{/sha}","comments_url":"https://api.github.com/repos/swang/coffeelint/comments{/number}","issue_comment_url":"https://api.github.com/repos/swang/coffeelint/issues/comments/{number}","contents_url":"https://api.github.com/repos/swang/coffeelint/contents/{+path}","compare_url":"https://api.github.com/repos/swang/coffeelint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swang/coffeelint/merges","archive_url":"https://api.github.com/repos/swang/coffeelint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swang/coffeelint/downloads","issues_url":"https://api.github.com/repos/swang/coffeelint/issues{/number}","pulls_url":"https://api.github.com/repos/swang/coffeelint/pulls{/number}","milestones_url":"https://api.github.com/repos/swang/coffeelint/milestones{/number}","notifications_url":"https://api.github.com/repos/swang/coffeelint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swang/coffeelint/labels{/name}","releases_url":"https://api.github.com/repos/swang/coffeelint/releases{/id}","created_at":"2013-01-08T05:59:36Z","updated_at":"2014-07-16T08:38:35Z","pushed_at":"2015-02-20T05:54:43Z","git_url":"git://github.com/swang/coffeelint.git","ssh_url":"git@github.com:swang/coffeelint.git","clone_url":"https://github.com/swang/coffeelint.git","svn_url":"https://github.com/swang/coffeelint","homepage":"http://www.coffeelint.org","size":1360,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clutchski:master","ref":"master","sha":"7e2d12599dcec4ca39d61761df1756a98c782213","user":{"login":"clutchski","id":92482,"avatar_url":"https://avatars.githubusercontent.com/u/92482?v=3","gravatar_id":"","url":"https://api.github.com/users/clutchski","html_url":"https://github.com/clutchski","followers_url":"https://api.github.com/users/clutchski/followers","following_url":"https://api.github.com/users/clutchski/following{/other_user}","gists_url":"https://api.github.com/users/clutchski/gists{/gist_id}","starred_url":"https://api.github.com/users/clutchski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clutchski/subscriptions","organizations_url":"https://api.github.com/users/clutchski/orgs","repos_url":"https://api.github.com/users/clutchski/repos","events_url":"https://api.github.com/users/clutchski/events{/privacy}","received_events_url":"https://api.github.com/users/clutchski/received_events","type":"User","site_admin":false},"repo":{"id":2920221,"name":"coffeelint","full_name":"clutchski/coffeelint","owner":{"login":"clutchski","id":92482,"avatar_url":"https://avatars.githubusercontent.com/u/92482?v=3","gravatar_id":"","url":"https://api.github.com/users/clutchski","html_url":"https://github.com/clutchski","followers_url":"https://api.github.com/users/clutchski/followers","following_url":"https://api.github.com/users/clutchski/following{/other_user}","gists_url":"https://api.github.com/users/clutchski/gists{/gist_id}","starred_url":"https://api.github.com/users/clutchski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clutchski/subscriptions","organizations_url":"https://api.github.com/users/clutchski/orgs","repos_url":"https://api.github.com/users/clutchski/repos","events_url":"https://api.github.com/users/clutchski/events{/privacy}","received_events_url":"https://api.github.com/users/clutchski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clutchski/coffeelint","description":"Lint your CoffeeScript.","fork":false,"url":"https://api.github.com/repos/clutchski/coffeelint","forks_url":"https://api.github.com/repos/clutchski/coffeelint/forks","keys_url":"https://api.github.com/repos/clutchski/coffeelint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clutchski/coffeelint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clutchski/coffeelint/teams","hooks_url":"https://api.github.com/repos/clutchski/coffeelint/hooks","issue_events_url":"https://api.github.com/repos/clutchski/coffeelint/issues/events{/number}","events_url":"https://api.github.com/repos/clutchski/coffeelint/events","assignees_url":"https://api.github.com/repos/clutchski/coffeelint/assignees{/user}","branches_url":"https://api.github.com/repos/clutchski/coffeelint/branches{/branch}","tags_url":"https://api.github.com/repos/clutchski/coffeelint/tags","blobs_url":"https://api.github.com/repos/clutchski/coffeelint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clutchski/coffeelint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clutchski/coffeelint/git/refs{/sha}","trees_url":"https://api.github.com/repos/clutchski/coffeelint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clutchski/coffeelint/statuses/{sha}","languages_url":"https://api.github.com/repos/clutchski/coffeelint/languages","stargazers_url":"https://api.github.com/repos/clutchski/coffeelint/stargazers","contributors_url":"https://api.github.com/repos/clutchski/coffeelint/contributors","subscribers_url":"https://api.github.com/repos/clutchski/coffeelint/subscribers","subscription_url":"https://api.github.com/repos/clutchski/coffeelint/subscription","commits_url":"https://api.github.com/repos/clutchski/coffeelint/commits{/sha}","git_commits_url":"https://api.github.com/repos/clutchski/coffeelint/git/commits{/sha}","comments_url":"https://api.github.com/repos/clutchski/coffeelint/comments{/number}","issue_comment_url":"https://api.github.com/repos/clutchski/coffeelint/issues/comments/{number}","contents_url":"https://api.github.com/repos/clutchski/coffeelint/contents/{+path}","compare_url":"https://api.github.com/repos/clutchski/coffeelint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clutchski/coffeelint/merges","archive_url":"https://api.github.com/repos/clutchski/coffeelint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clutchski/coffeelint/downloads","issues_url":"https://api.github.com/repos/clutchski/coffeelint/issues{/number}","pulls_url":"https://api.github.com/repos/clutchski/coffeelint/pulls{/number}","milestones_url":"https://api.github.com/repos/clutchski/coffeelint/milestones{/number}","notifications_url":"https://api.github.com/repos/clutchski/coffeelint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clutchski/coffeelint/labels{/name}","releases_url":"https://api.github.com/repos/clutchski/coffeelint/releases{/id}","created_at":"2011-12-05T21:53:01Z","updated_at":"2015-02-19T23:02:32Z","pushed_at":"2015-02-20T05:57:43Z","git_url":"git://github.com/clutchski/coffeelint.git","ssh_url":"git@github.com:clutchski/coffeelint.git","clone_url":"https://github.com/clutchski/coffeelint.git","svn_url":"https://github.com/clutchski/coffeelint","homepage":"http://www.coffeelint.org","size":2945,"stargazers_count":618,"watchers_count":618,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":112,"mirror_url":null,"open_issues_count":49,"forks":112,"open_issues":49,"watchers":618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clutchski/coffeelint/pulls/377"},"html":{"href":"https://github.com/clutchski/coffeelint/pull/377"},"issue":{"href":"https://api.github.com/repos/clutchski/coffeelint/issues/377"},"comments":{"href":"https://api.github.com/repos/clutchski/coffeelint/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/clutchski/coffeelint/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/clutchski/coffeelint/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/clutchski/coffeelint/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/clutchski/coffeelint/statuses/c2acdbcaa8b00952608311c6a7e555e6256e248e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"swang","id":49867,"avatar_url":"https://avatars.githubusercontent.com/u/49867?v=3","gravatar_id":"","url":"https://api.github.com/users/swang","html_url":"https://github.com/swang","followers_url":"https://api.github.com/users/swang/followers","following_url":"https://api.github.com/users/swang/following{/other_user}","gists_url":"https://api.github.com/users/swang/gists{/gist_id}","starred_url":"https://api.github.com/users/swang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swang/subscriptions","organizations_url":"https://api.github.com/users/swang/orgs","repos_url":"https://api.github.com/users/swang/repos","events_url":"https://api.github.com/users/swang/events{/privacy}","received_events_url":"https://api.github.com/users/swang/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":3,"additions":51,"deletions":107,"changed_files":8}}