{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/32937138","id":32937138,"diff_hunk":"@@ -60,13 +60,17 @@\n \t\tif(top_atom != source_atom)\n \t\t\tif(!top_atom.light_sources) top_atom.light_sources = list()\n \t\t\ttop_atom.light_sources += src\n-\tlighting_update_lights += src\n-\tneeds_update = 1\n+\n+\tif(!needs_update)\n+\t\tlighting_update_lights += src\n+\t\tneeds_update = 1\n \n /datum/light_source/proc/force_update()\n \tneeds_update = 1\n \tforce_update = 1\n-\tlighting_update_lights += src\n+\tif(!needs_update)\n+\t\tlighting_update_lights += src\n+\t\tneeds_update = 1","path":"code/modules/lighting/light_source.dm","position":17,"original_position":17,"commit_id":"f37d8bd807e0354f3a1f167d3bbdbe83a8041c67","original_commit_id":"f37d8bd807e0354f3a1f167d3bbdbe83a8041c67","user":{"login":"mwerezak","id":242428,"avatar_url":"https://avatars.githubusercontent.com/u/242428?v=3","gravatar_id":"","url":"https://api.github.com/users/mwerezak","html_url":"https://github.com/mwerezak","followers_url":"https://api.github.com/users/mwerezak/followers","following_url":"https://api.github.com/users/mwerezak/following{/other_user}","gists_url":"https://api.github.com/users/mwerezak/gists{/gist_id}","starred_url":"https://api.github.com/users/mwerezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwerezak/subscriptions","organizations_url":"https://api.github.com/users/mwerezak/orgs","repos_url":"https://api.github.com/users/mwerezak/repos","events_url":"https://api.github.com/users/mwerezak/events{/privacy}","received_events_url":"https://api.github.com/users/mwerezak/received_events","type":"User","site_admin":false},"body":"Is this if-block intentional? You set the variable right before checking it. It's never going to execute.","created_at":"2015-06-22T14:08:13Z","updated_at":"2015-06-22T14:08:13Z","html_url":"https://github.com/Baystation12/Baystation12/pull/9889#discussion_r32937138","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/9889","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/32937138"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/9889#discussion_r32937138"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/9889"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/9889","id":38191413,"html_url":"https://github.com/Baystation12/Baystation12/pull/9889","diff_url":"https://github.com/Baystation12/Baystation12/pull/9889.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/9889.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/9889","number":9889,"state":"open","locked":false,"title":"Lighting optimizations + NVG meson fix","user":{"login":"PJB3005","id":8107459,"avatar_url":"https://avatars.githubusercontent.com/u/8107459?v=3","gravatar_id":"","url":"https://api.github.com/users/PJB3005","html_url":"https://github.com/PJB3005","followers_url":"https://api.github.com/users/PJB3005/followers","following_url":"https://api.github.com/users/PJB3005/following{/other_user}","gists_url":"https://api.github.com/users/PJB3005/gists{/gist_id}","starred_url":"https://api.github.com/users/PJB3005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PJB3005/subscriptions","organizations_url":"https://api.github.com/users/PJB3005/orgs","repos_url":"https://api.github.com/users/PJB3005/repos","events_url":"https://api.github.com/users/PJB3005/events{/privacy}","received_events_url":"https://api.github.com/users/PJB3005/received_events","type":"User","site_admin":false},"body":"#### Changes:\r\n* Removes multi res lighting since Mloc was removing it anyways.\r\n* Adds a direct reference to the lighting overlay on turfs.\r\n* Uses the above to optimize a lot of loops.\r\n* Prevents adding lighting overlays and their turfs if the strength from falloff() is 0\r\n* Adds math to update_lumcount() to prevent adding the overlay to the update queue if there's no effect, visually.\r\n* Prevents duplicates in the update lists.\r\n* Fixes mesons like how they were before.\r\n* Pooling for lighting overlays.\r\n* Probably some other stuff I can't think of off the top of my head.\r\n\r\n#### Notes:\r\n* **Still testing this, DNM.**\r\n  * Oh boy stuff's broken indeed!","created_at":"2015-06-21T21:54:27Z","updated_at":"2015-06-22T14:08:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef6190af2921d6d81d0232f8ae433c165fcf88d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/9889/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/9889/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/9889/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/f37d8bd807e0354f3a1f167d3bbdbe83a8041c67","head":{"label":"PJB3005:bay-lights","ref":"bay-lights","sha":"f37d8bd807e0354f3a1f167d3bbdbe83a8041c67","user":{"login":"PJB3005","id":8107459,"avatar_url":"https://avatars.githubusercontent.com/u/8107459?v=3","gravatar_id":"","url":"https://api.github.com/users/PJB3005","html_url":"https://github.com/PJB3005","followers_url":"https://api.github.com/users/PJB3005/followers","following_url":"https://api.github.com/users/PJB3005/following{/other_user}","gists_url":"https://api.github.com/users/PJB3005/gists{/gist_id}","starred_url":"https://api.github.com/users/PJB3005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PJB3005/subscriptions","organizations_url":"https://api.github.com/users/PJB3005/orgs","repos_url":"https://api.github.com/users/PJB3005/repos","events_url":"https://api.github.com/users/PJB3005/events{/privacy}","received_events_url":"https://api.github.com/users/PJB3005/received_events","type":"User","site_admin":false},"repo":{"id":26824993,"name":"vgstation13","full_name":"PJB3005/vgstation13","owner":{"login":"PJB3005","id":8107459,"avatar_url":"https://avatars.githubusercontent.com/u/8107459?v=3","gravatar_id":"","url":"https://api.github.com/users/PJB3005","html_url":"https://github.com/PJB3005","followers_url":"https://api.github.com/users/PJB3005/followers","following_url":"https://api.github.com/users/PJB3005/following{/other_user}","gists_url":"https://api.github.com/users/PJB3005/gists{/gist_id}","starred_url":"https://api.github.com/users/PJB3005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PJB3005/subscriptions","organizations_url":"https://api.github.com/users/PJB3005/orgs","repos_url":"https://api.github.com/users/PJB3005/repos","events_url":"https://api.github.com/users/PJB3005/events{/privacy}","received_events_url":"https://api.github.com/users/PJB3005/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PJB3005/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/PJB3005/vgstation13","forks_url":"https://api.github.com/repos/PJB3005/vgstation13/forks","keys_url":"https://api.github.com/repos/PJB3005/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PJB3005/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PJB3005/vgstation13/teams","hooks_url":"https://api.github.com/repos/PJB3005/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/PJB3005/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/PJB3005/vgstation13/events","assignees_url":"https://api.github.com/repos/PJB3005/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/PJB3005/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/PJB3005/vgstation13/tags","blobs_url":"https://api.github.com/repos/PJB3005/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PJB3005/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PJB3005/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/PJB3005/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PJB3005/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/PJB3005/vgstation13/languages","stargazers_url":"https://api.github.com/repos/PJB3005/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/PJB3005/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/PJB3005/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/PJB3005/vgstation13/subscription","commits_url":"https://api.github.com/repos/PJB3005/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/PJB3005/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/PJB3005/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/PJB3005/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/PJB3005/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/PJB3005/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PJB3005/vgstation13/merges","archive_url":"https://api.github.com/repos/PJB3005/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PJB3005/vgstation13/downloads","issues_url":"https://api.github.com/repos/PJB3005/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/PJB3005/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/PJB3005/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/PJB3005/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PJB3005/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/PJB3005/vgstation13/releases{/id}","created_at":"2014-11-18T19:01:04Z","updated_at":"2015-06-01T15:04:46Z","pushed_at":"2015-06-21T21:54:08Z","git_url":"git://github.com/PJB3005/vgstation13.git","ssh_url":"git@github.com:PJB3005/vgstation13.git","clone_url":"https://github.com/PJB3005/vgstation13.git","svn_url":"https://github.com/PJB3005/vgstation13","homepage":"","size":1028718,"stargazers_count":1,"watchers_count":1,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"Bleeding-Edge"}},"base":{"label":"Baystation12:dev-freeze","ref":"dev-freeze","sha":"ac7378b21cd1a939cfa85c3710bd933352d32634","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","created_at":"2011-11-05T16:12:41Z","updated_at":"2015-06-17T01:07:43Z","pushed_at":"2015-06-22T14:03:30Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":1542088,"stargazers_count":194,"watchers_count":194,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":761,"mirror_url":null,"open_issues_count":225,"forks":761,"open_issues":225,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/9889"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/9889"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/9889"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/9889/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/9889/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/9889/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/f37d8bd807e0354f3a1f167d3bbdbe83a8041c67"}}}}