{"action":"created","issue":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/648","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/648/labels{/name}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/648/comments","events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/648/events","html_url":"https://github.com/checkstyle/checkstyle/pull/648","id":57833766,"number":648,"title":"FOR_EACH_CLAUSE variable is not declared final","user":{"login":"Bhavik3","id":8848873,"avatar_url":"https://avatars.githubusercontent.com/u/8848873?v=3","gravatar_id":"","url":"https://api.github.com/users/Bhavik3","html_url":"https://github.com/Bhavik3","followers_url":"https://api.github.com/users/Bhavik3/followers","following_url":"https://api.github.com/users/Bhavik3/following{/other_user}","gists_url":"https://api.github.com/users/Bhavik3/gists{/gist_id}","starred_url":"https://api.github.com/users/Bhavik3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bhavik3/subscriptions","organizations_url":"https://api.github.com/users/Bhavik3/orgs","repos_url":"https://api.github.com/users/Bhavik3/repos","events_url":"https://api.github.com/users/Bhavik3/events{/privacy}","received_events_url":"https://api.github.com/users/Bhavik3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":62,"created_at":"2015-02-16T17:51:22Z","updated_at":"2015-02-27T23:58:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/648","html_url":"https://github.com/checkstyle/checkstyle/pull/648","diff_url":"https://github.com/checkstyle/checkstyle/pull/648.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/648.patch"},"body":"...69939c84cd69cd/src/test/resources/com/puppycrawl/tools/checkstyle/coding/InputFinalLocalVariable.java#L134 should be declared final.\r\n\r\n    FinalLocalVariableCheck.java is not checking for this variable (because it is not checking for FOR_EACH_CLAUSE variable). following is the line of code:\r\n\r\n    https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheck.java#L112\r\n\r\n    so, I remove this line. as there is not any conflict with removing this line.\r\n\r\n    now there are many places where FOR_EACH_CLAUSE variable is not declared final in source code. so I changed it."},"comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments/76495437","html_url":"https://github.com/checkstyle/checkstyle/pull/648#issuecomment-76495437","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/648","id":76495437,"user":{"login":"romani","id":812984,"avatar_url":"https://avatars.githubusercontent.com/u/812984?v=3","gravatar_id":"","url":"https://api.github.com/users/romani","html_url":"https://github.com/romani","followers_url":"https://api.github.com/users/romani/followers","following_url":"https://api.github.com/users/romani/following{/other_user}","gists_url":"https://api.github.com/users/romani/gists{/gist_id}","starred_url":"https://api.github.com/users/romani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romani/subscriptions","organizations_url":"https://api.github.com/users/romani/orgs","repos_url":"https://api.github.com/users/romani/repos","events_url":"https://api.github.com/users/romani/events{/privacy}","received_events_url":"https://api.github.com/users/romani/received_events","type":"User","site_admin":false},"created_at":"2015-02-27T23:58:57Z","updated_at":"2015-02-27T23:58:57Z","body":"1)\r\n> FinalLocalVariableCheck.java\r\n\r\nno update for Javadoc is NOT acceptable, one day we will generate xdoc from javadoc\r\n\r\n2)\r\n> ``` <td>Controls whether to check enhanced for-loop variable.</td>```\r\n\r\nPlease make a link to JDK specification for \"enhanced for-loop\", not all Checkstyle users are that smart to understand that term, even I was surprised on how it is named actually.\r\n\r\n3)\r\n> \r\n```\r\n+ private boolean validateEnhancedForLoopVariable;\r\n+ /**\r\n```\r\nPelase make empty line between declarations"}}