{"action":"created","issue":{"url":"https://api.github.com/repos/ged-lab/khmer/issues/897","labels_url":"https://api.github.com/repos/ged-lab/khmer/issues/897/labels{/name}","comments_url":"https://api.github.com/repos/ged-lab/khmer/issues/897/comments","events_url":"https://api.github.com/repos/ged-lab/khmer/issues/897/events","html_url":"https://github.com/ged-lab/khmer/pull/897","id":65913987,"number":897,"title":"Throw exception on weird seqan parsing of truncated file","user":{"login":"kdmurray91","id":1560490,"avatar_url":"https://avatars.githubusercontent.com/u/1560490?v=3","gravatar_id":"","url":"https://api.github.com/users/kdmurray91","html_url":"https://github.com/kdmurray91","followers_url":"https://api.github.com/users/kdmurray91/followers","following_url":"https://api.github.com/users/kdmurray91/following{/other_user}","gists_url":"https://api.github.com/users/kdmurray91/gists{/gist_id}","starred_url":"https://api.github.com/users/kdmurray91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdmurray91/subscriptions","organizations_url":"https://api.github.com/users/kdmurray91/orgs","repos_url":"https://api.github.com/users/kdmurray91/repos","events_url":"https://api.github.com/users/kdmurray91/events{/privacy}","received_events_url":"https://api.github.com/users/kdmurray91/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-02T12:16:47Z","updated_at":"2015-04-04T06:28:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ged-lab/khmer/pulls/897","html_url":"https://github.com/ged-lab/khmer/pull/897","diff_url":"https://github.com/ged-lab/khmer/pull/897.diff","patch_url":"https://github.com/ged-lab/khmer/pull/897.patch"},"body":"Half workaround, half bugfix\r\n\r\nIn #884, I noticed that truncated fastq files cause an empty read to be emitted from the parser. This throws an exception to work around this. Seqan fixes this in 2.0.\r\n\r\n\r\n\r\n- [ ] Is it mergeable?\r\n- [x] Did it pass the tests?\r\n- [x] If it introduces new functionality in scripts/ is it tested?\r\n  Check for code coverage with `make clean diff-cover`\r\n- [ ] Is it well formatted? Look at `make pep8`, `make diff_pylint_report`,\r\n  `make cppcheck`, and `make doc` output. Use `make format` and manual\r\n  fixing as needed.\r\n- [x] Did it change the command-line interface? Only additions are allowed\r\n  without a major version increment. Changing file formats also requires a\r\n  major version number increment.\r\n- [ ] Is it documented in the ChangeLog?\r\n  http://en.wikipedia.org/wiki/Changelog#Format\r\n- [ ] Was a spellchecker run on the source code and documentation after\r\n  changes were made?"},"comment":{"url":"https://api.github.com/repos/ged-lab/khmer/issues/comments/89512717","html_url":"https://github.com/ged-lab/khmer/pull/897#issuecomment-89512717","issue_url":"https://api.github.com/repos/ged-lab/khmer/issues/897","id":89512717,"user":{"login":"kdmurray91","id":1560490,"avatar_url":"https://avatars.githubusercontent.com/u/1560490?v=3","gravatar_id":"","url":"https://api.github.com/users/kdmurray91","html_url":"https://github.com/kdmurray91","followers_url":"https://api.github.com/users/kdmurray91/followers","following_url":"https://api.github.com/users/kdmurray91/following{/other_user}","gists_url":"https://api.github.com/users/kdmurray91/gists{/gist_id}","starred_url":"https://api.github.com/users/kdmurray91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdmurray91/subscriptions","organizations_url":"https://api.github.com/users/kdmurray91/orgs","repos_url":"https://api.github.com/users/kdmurray91/repos","events_url":"https://api.github.com/users/kdmurray91/events{/privacy}","received_events_url":"https://api.github.com/users/kdmurray91/received_events","type":"User","site_admin":false},"created_at":"2015-04-04T06:28:48Z","updated_at":"2015-04-04T06:28:48Z","body":"that should be better, now everything's inside the spinlocks except the `throw` calls."}}