{"action":"closed","number":127,"pull_request":{"url":"https://api.github.com/repos/ARMmbed/ble/pulls/127","id":52379236,"html_url":"https://github.com/ARMmbed/ble/pull/127","diff_url":"https://github.com/ARMmbed/ble/pull/127.diff","patch_url":"https://github.com/ARMmbed/ble/pull/127.patch","issue_url":"https://api.github.com/repos/ARMmbed/ble/issues/127","number":127,"state":"closed","locked":false,"title":"Allow GattAttributes to have variable length","user":{"login":"andresag01","id":3746901,"avatar_url":"https://avatars.githubusercontent.com/u/3746901?v=3","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},"body":"Previously the concepts of initLength and lenth were clearly separated. However, this was at the cost of registering all characteristics in the SoftDevice as having variable length. Clearly, this is not the desired behaviour. Therefore, an additional field '_hasVariableLen' is added to the GattAttribute to address the problem. Also, the GattAttribute and GattCharacteristic constructors have been modified to take a boolean that sets '_hasVariableLen'.\r\n@rgrover ","created_at":"2015-12-02T10:43:37Z","updated_at":"2015-12-02T11:44:32Z","closed_at":"2015-12-02T11:44:32Z","merged_at":"2015-12-02T11:44:32Z","merge_commit_sha":"ce8e56f749d989119f8bd0f04afc819f9634e012","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/ble/pulls/127/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/ble/pulls/127/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/ble/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/ble/issues/127/comments","statuses_url":"https://api.github.com/repos/ARMmbed/ble/statuses/46b05925f9cf2c491efa02bc91696d3a3b288426","head":{"label":"andresag01:develop","ref":"develop","sha":"46b05925f9cf2c491efa02bc91696d3a3b288426","user":{"login":"andresag01","id":3746901,"avatar_url":"https://avatars.githubusercontent.com/u/3746901?v=3","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},"repo":{"id":47254409,"name":"ble","full_name":"andresag01/ble","owner":{"login":"andresag01","id":3746901,"avatar_url":"https://avatars.githubusercontent.com/u/3746901?v=3","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andresag01/ble","description":"API to abstract working with Bluetooth Smart Controllers","fork":true,"url":"https://api.github.com/repos/andresag01/ble","forks_url":"https://api.github.com/repos/andresag01/ble/forks","keys_url":"https://api.github.com/repos/andresag01/ble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresag01/ble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresag01/ble/teams","hooks_url":"https://api.github.com/repos/andresag01/ble/hooks","issue_events_url":"https://api.github.com/repos/andresag01/ble/issues/events{/number}","events_url":"https://api.github.com/repos/andresag01/ble/events","assignees_url":"https://api.github.com/repos/andresag01/ble/assignees{/user}","branches_url":"https://api.github.com/repos/andresag01/ble/branches{/branch}","tags_url":"https://api.github.com/repos/andresag01/ble/tags","blobs_url":"https://api.github.com/repos/andresag01/ble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresag01/ble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresag01/ble/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresag01/ble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresag01/ble/statuses/{sha}","languages_url":"https://api.github.com/repos/andresag01/ble/languages","stargazers_url":"https://api.github.com/repos/andresag01/ble/stargazers","contributors_url":"https://api.github.com/repos/andresag01/ble/contributors","subscribers_url":"https://api.github.com/repos/andresag01/ble/subscribers","subscription_url":"https://api.github.com/repos/andresag01/ble/subscription","commits_url":"https://api.github.com/repos/andresag01/ble/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresag01/ble/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresag01/ble/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresag01/ble/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresag01/ble/contents/{+path}","compare_url":"https://api.github.com/repos/andresag01/ble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresag01/ble/merges","archive_url":"https://api.github.com/repos/andresag01/ble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresag01/ble/downloads","issues_url":"https://api.github.com/repos/andresag01/ble/issues{/number}","pulls_url":"https://api.github.com/repos/andresag01/ble/pulls{/number}","milestones_url":"https://api.github.com/repos/andresag01/ble/milestones{/number}","notifications_url":"https://api.github.com/repos/andresag01/ble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresag01/ble/labels{/name}","releases_url":"https://api.github.com/repos/andresag01/ble/releases{/id}","created_at":"2015-12-02T10:37:10Z","updated_at":"2015-12-02T10:37:11Z","pushed_at":"2015-12-02T11:26:34Z","git_url":"git://github.com/andresag01/ble.git","ssh_url":"git@github.com:andresag01/ble.git","clone_url":"https://github.com/andresag01/ble.git","svn_url":"https://github.com/andresag01/ble","homepage":null,"size":1333,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:develop","ref":"develop","sha":"7317670ba49b45760b9031ab424e8b525a1276b1","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":26317661,"name":"ble","full_name":"ARMmbed/ble","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/ble","description":"API to abstract working with Bluetooth Smart Controllers","fork":false,"url":"https://api.github.com/repos/ARMmbed/ble","forks_url":"https://api.github.com/repos/ARMmbed/ble/forks","keys_url":"https://api.github.com/repos/ARMmbed/ble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/ble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/ble/teams","hooks_url":"https://api.github.com/repos/ARMmbed/ble/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/ble/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/ble/events","assignees_url":"https://api.github.com/repos/ARMmbed/ble/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/ble/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/ble/tags","blobs_url":"https://api.github.com/repos/ARMmbed/ble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/ble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/ble/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/ble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/ble/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/ble/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/ble/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/ble/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/ble/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/ble/subscription","commits_url":"https://api.github.com/repos/ARMmbed/ble/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/ble/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/ble/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/ble/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/ble/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/ble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/ble/merges","archive_url":"https://api.github.com/repos/ARMmbed/ble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/ble/downloads","issues_url":"https://api.github.com/repos/ARMmbed/ble/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/ble/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/ble/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/ble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/ble/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/ble/releases{/id}","created_at":"2014-11-07T11:50:32Z","updated_at":"2015-11-23T21:15:07Z","pushed_at":"2015-12-02T11:44:32Z","git_url":"git://github.com/ARMmbed/ble.git","ssh_url":"git@github.com:ARMmbed/ble.git","clone_url":"https://github.com/ARMmbed/ble.git","svn_url":"https://github.com/ARMmbed/ble","homepage":null,"size":1856,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":21,"forks":42,"open_issues":21,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/ble/pulls/127"},"html":{"href":"https://github.com/ARMmbed/ble/pull/127"},"issue":{"href":"https://api.github.com/repos/ARMmbed/ble/issues/127"},"comments":{"href":"https://api.github.com/repos/ARMmbed/ble/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/ble/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/ble/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/ble/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/ble/statuses/46b05925f9cf2c491efa02bc91696d3a3b288426"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rgrover","id":112704,"avatar_url":"https://avatars.githubusercontent.com/u/112704?v=3","gravatar_id":"","url":"https://api.github.com/users/rgrover","html_url":"https://github.com/rgrover","followers_url":"https://api.github.com/users/rgrover/followers","following_url":"https://api.github.com/users/rgrover/following{/other_user}","gists_url":"https://api.github.com/users/rgrover/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrover/subscriptions","organizations_url":"https://api.github.com/users/rgrover/orgs","repos_url":"https://api.github.com/users/rgrover/repos","events_url":"https://api.github.com/users/rgrover/events{/privacy}","received_events_url":"https://api.github.com/users/rgrover/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":3,"additions":23,"deletions":16,"changed_files":2}}