{"action":"created","issue":{"url":"https://api.github.com/repos/libgit2/libgit2/issues/3054","labels_url":"https://api.github.com/repos/libgit2/libgit2/issues/3054/labels{/name}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/3054/comments","events_url":"https://api.github.com/repos/libgit2/libgit2/issues/3054/events","html_url":"https://github.com/libgit2/libgit2/pull/3054","id":69179114,"number":3054,"title":"Performance Improvements to Status on Windows","user":{"login":"whoisj","id":11578325,"avatar_url":"https://avatars.githubusercontent.com/u/11578325?v=3","gravatar_id":"","url":"https://api.github.com/users/whoisj","html_url":"https://github.com/whoisj","followers_url":"https://api.github.com/users/whoisj/followers","following_url":"https://api.github.com/users/whoisj/following{/other_user}","gists_url":"https://api.github.com/users/whoisj/gists{/gist_id}","starred_url":"https://api.github.com/users/whoisj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whoisj/subscriptions","organizations_url":"https://api.github.com/users/whoisj/orgs","repos_url":"https://api.github.com/users/whoisj/repos","events_url":"https://api.github.com/users/whoisj/events{/privacy}","received_events_url":"https://api.github.com/users/whoisj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-04-17T17:18:06Z","updated_at":"2015-04-21T20:29:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/3054","html_url":"https://github.com/libgit2/libgit2/pull/3054","diff_url":"https://github.com/libgit2/libgit2/pull/3054.diff","patch_url":"https://github.com/libgit2/libgit2/pull/3054.patch"},"body":"Improves status on Win32 systems by a rather large margin. Brings libgit2 status on Win32 inline with git.git w/ core.fscache and core.preloadindex enabled."},"comment":{"url":"https://api.github.com/repos/libgit2/libgit2/issues/comments/94930422","html_url":"https://github.com/libgit2/libgit2/pull/3054#issuecomment-94930422","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/3054","id":94930422,"user":{"login":"ethomson","id":1130014,"avatar_url":"https://avatars.githubusercontent.com/u/1130014?v=3","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"created_at":"2015-04-21T20:29:12Z","updated_at":"2015-04-21T20:29:12Z","body":"Cooooool.  This is looking great.  I have a couple of minor comments.  I would also like to point out that `git_win32_path_dirload_with_stat` is not very in keeping with our style.  We use the git.git style, which is the Linux Kernel style:\r\n\r\nSo we try to keep operators on the original line when wrapping, eg:\r\n\r\n    a = b +\r\n        c\r\n\r\ninstead of:\r\n\r\n    a = b\r\n        + c\r\n\r\nWe try to keep braces on the original line, eg:\r\n\r\n    if (foo) {\r\n        good;\r\n        good;\r\n    }\r\n\r\ninstead of:\r\n\r\n    if (foo)\r\n    {\r\n        bad;\r\n    }\r\n\r\nNote that the above is also bad because we don't use braces for single statements (unless we need to use braces elsewhere.)  Which is to say:\r\n\r\n    if (foo) {\r\n         one_liner;\r\n    } else {\r\n        this;\r\n        and_this;\r\n    }\r\n\r\nis good style, but:\r\n\r\n    if (foo)\r\n        one_liner;\r\n    else\r\n    {\r\n        foo;\r\n    }\r\n\r\nis less good.\r\n\r\nI didn't want to nitpick all the lines, but I can if you want.  Sometimes it takes a little bit of time for a code style to jive.  But docs are at [https://www.kernel.org/doc/Documentation/CodingStyle](https://www.kernel.org/doc/Documentation/CodingStyle)."}}