{"action":"closed","number":6794,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/6794","id":50812081,"html_url":"https://github.com/dotnet/roslyn/pull/6794","diff_url":"https://github.com/dotnet/roslyn/pull/6794.diff","patch_url":"https://github.com/dotnet/roslyn/pull/6794.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/6794","number":6794,"state":"closed","locked":false,"title":"[VB Compiler Scanner] Perf Tweaks","user":{"login":"AdamSpeight2008","id":900107,"avatar_url":"https://avatars.githubusercontent.com/u/900107?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamSpeight2008","html_url":"https://github.com/AdamSpeight2008","followers_url":"https://api.github.com/users/AdamSpeight2008/followers","following_url":"https://api.github.com/users/AdamSpeight2008/following{/other_user}","gists_url":"https://api.github.com/users/AdamSpeight2008/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamSpeight2008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamSpeight2008/subscriptions","organizations_url":"https://api.github.com/users/AdamSpeight2008/orgs","repos_url":"https://api.github.com/users/AdamSpeight2008/repos","events_url":"https://api.github.com/users/AdamSpeight2008/events{/privacy}","received_events_url":"https://api.github.com/users/AdamSpeight2008/received_events","type":"User","site_admin":false},"body":"This PR implements the following set of changes.\r\n* Change `IntegralLiteralCharacterValue` to use a dictionary lookup.\r\n* Tweaks to conditionals.\r\n* Remove redundant / unreachable code.\r\n* Simplify a couple of array initialisations. eg `DaysToMonth365(13-1)` to `DaysToMonth365(12)`","created_at":"2015-11-16T13:51:24Z","updated_at":"2015-11-22T20:41:00Z","closed_at":"2015-11-22T20:41:00Z","merged_at":null,"merge_commit_sha":"9dfb1a0e40e2d32903f060549ba944cf819d77dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6794/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/6794/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/6794/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/044a4b825164d5b587c98f16dcc8750c7d3bcefb","head":{"label":"AdamSpeight2008:Scanner(CharacterInfo)","ref":"Scanner(CharacterInfo)","sha":"044a4b825164d5b587c98f16dcc8750c7d3bcefb","user":{"login":"AdamSpeight2008","id":900107,"avatar_url":"https://avatars.githubusercontent.com/u/900107?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamSpeight2008","html_url":"https://github.com/AdamSpeight2008","followers_url":"https://api.github.com/users/AdamSpeight2008/followers","following_url":"https://api.github.com/users/AdamSpeight2008/following{/other_user}","gists_url":"https://api.github.com/users/AdamSpeight2008/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamSpeight2008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamSpeight2008/subscriptions","organizations_url":"https://api.github.com/users/AdamSpeight2008/orgs","repos_url":"https://api.github.com/users/AdamSpeight2008/repos","events_url":"https://api.github.com/users/AdamSpeight2008/events{/privacy}","received_events_url":"https://api.github.com/users/AdamSpeight2008/received_events","type":"User","site_admin":false},"repo":{"id":30550436,"name":"roslyn-AdamSpeight2008","full_name":"AdamSpeight2008/roslyn-AdamSpeight2008","owner":{"login":"AdamSpeight2008","id":900107,"avatar_url":"https://avatars.githubusercontent.com/u/900107?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamSpeight2008","html_url":"https://github.com/AdamSpeight2008","followers_url":"https://api.github.com/users/AdamSpeight2008/followers","following_url":"https://api.github.com/users/AdamSpeight2008/following{/other_user}","gists_url":"https://api.github.com/users/AdamSpeight2008/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamSpeight2008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamSpeight2008/subscriptions","organizations_url":"https://api.github.com/users/AdamSpeight2008/orgs","repos_url":"https://api.github.com/users/AdamSpeight2008/repos","events_url":"https://api.github.com/users/AdamSpeight2008/events{/privacy}","received_events_url":"https://api.github.com/users/AdamSpeight2008/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdamSpeight2008/roslyn-AdamSpeight2008","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008","forks_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/forks","keys_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/teams","hooks_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/hooks","issue_events_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/issues/events{/number}","events_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/events","assignees_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/assignees{/user}","branches_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/branches{/branch}","tags_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/tags","blobs_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/statuses/{sha}","languages_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/languages","stargazers_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/stargazers","contributors_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/contributors","subscribers_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/subscribers","subscription_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/subscription","commits_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/contents/{+path}","compare_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/merges","archive_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/downloads","issues_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/issues{/number}","pulls_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/pulls{/number}","milestones_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/milestones{/number}","notifications_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/labels{/name}","releases_url":"https://api.github.com/repos/AdamSpeight2008/roslyn-AdamSpeight2008/releases{/id}","created_at":"2015-02-09T18:12:45Z","updated_at":"2015-03-20T22:30:55Z","pushed_at":"2015-11-21T02:09:24Z","git_url":"git://github.com/AdamSpeight2008/roslyn-AdamSpeight2008.git","ssh_url":"git@github.com:AdamSpeight2008/roslyn-AdamSpeight2008.git","clone_url":"https://github.com/AdamSpeight2008/roslyn-AdamSpeight2008.git","svn_url":"https://github.com/AdamSpeight2008/roslyn-AdamSpeight2008","homepage":"","size":109783,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5a97d296d3dedbe6cc7c580835da32adb3252d23","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-11-22T20:25:44Z","pushed_at":"2015-11-22T19:20:32Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":136914,"stargazers_count":3797,"watchers_count":3797,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":913,"mirror_url":null,"open_issues_count":1640,"forks":913,"open_issues":1640,"watchers":3797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6794"},"html":{"href":"https://github.com/dotnet/roslyn/pull/6794"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/6794"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/6794/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6794/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/6794/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/044a4b825164d5b587c98f16dcc8750c7d3bcefb"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":11,"review_comments":0,"commits":1,"additions":130,"deletions":154,"changed_files":1}}