{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/44874737","id":44874737,"diff_hunk":"@@ -32,10 +32,10 @@ The target values are stored in a scipy CSR sparse matrix, with 804414 samples a\n Each sample can be identified by its ID, ranging (with gaps) from 2286 to 810596::\n \n     >>> rcv1.sample_id[:3]\n-    array([2286, 2287, 2288], dtype=int32)\n+    array([2286, 2287, 2288], dtype=uint32)","path":"doc/datasets/rcv1.rst","position":5,"original_position":5,"commit_id":"beb7b93420f3735d8e8aaf0c19c233266350cc92","original_commit_id":"beb7b93420f3735d8e8aaf0c19c233266350cc92","user":{"login":"giorgiop","id":2871319,"avatar_url":"https://avatars.githubusercontent.com/u/2871319?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgiop","html_url":"https://github.com/giorgiop","followers_url":"https://api.github.com/users/giorgiop/followers","following_url":"https://api.github.com/users/giorgiop/following{/other_user}","gists_url":"https://api.github.com/users/giorgiop/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiop/subscriptions","organizations_url":"https://api.github.com/users/giorgiop/orgs","repos_url":"https://api.github.com/users/giorgiop/repos","events_url":"https://api.github.com/users/giorgiop/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiop/received_events","type":"User","site_admin":false},"body":"That doc test was failing locally. Not sure why actually.","created_at":"2015-11-15T17:20:13Z","updated_at":"2015-11-15T17:20:13Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5357#discussion_r44874737","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5357","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/44874737"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5357#discussion_r44874737"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5357"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5357","id":47033843,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/5357","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/5357.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/5357.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5357","number":5357,"state":"open","locked":false,"title":"[MRG]: MAINT center_data for linear models","user":{"login":"giorgiop","id":2871319,"avatar_url":"https://avatars.githubusercontent.com/u/2871319?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgiop","html_url":"https://github.com/giorgiop","followers_url":"https://api.github.com/users/giorgiop/followers","following_url":"https://api.github.com/users/giorgiop/following{/other_user}","gists_url":"https://api.github.com/users/giorgiop/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiop/subscriptions","organizations_url":"https://api.github.com/users/giorgiop/orgs","repos_url":"https://api.github.com/users/giorgiop/repos","events_url":"https://api.github.com/users/giorgiop/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiop/received_events","type":"User","site_admin":false},"body":"~~Fixes #2601~~ no more.\r\n\r\nTO DO\r\n- [x] update the docstring saying that we do normalization, to reduce surprise\r\n- [x] clean and factor `center_data` and `sparse_center_data` into a new private function, and deprecate them\r\n- [x] add necessary deprecation, update docs\r\n- [x] review all the TODO and XXX\r\n\r\nAND NOT TO DO (see #2601 and discussion below):\r\n- deprecate `normalize` (signature and property) and introduce `standardize` behaviour\r\n- introduce the same behaviour for every class calling `center_data` internally + related tests\r\n-  make sense of [this old test](https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/linear_model/tests/test_base.py#L63) on `sample_weights` with unused variables (a) . Done in https://github.com/scikit-learn/scikit-learn/pull/5526\r\n- change `center_data` behaviour w.r.t. `fit_intercept`. Currently, [input data is not touched](https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/linear_model/base.py#L119) if we not are fitting the intercept. See separate PR #5799\r\n\r\n![3459513455_d1288a14b9_o](https://cloud.githubusercontent.com/assets/2871319/10516143/1afb092a-7357-11e5-81e9-a2835af3aacf.jpeg)","created_at":"2015-10-07T14:24:59Z","updated_at":"2015-11-15T17:20:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0613cea17e674dda45e4d91fc4ae9d0ac99b015","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5357/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5357/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5357/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/beb7b93420f3735d8e8aaf0c19c233266350cc92","head":{"label":"giorgiop:center-data-normalization","ref":"center-data-normalization","sha":"beb7b93420f3735d8e8aaf0c19c233266350cc92","user":{"login":"giorgiop","id":2871319,"avatar_url":"https://avatars.githubusercontent.com/u/2871319?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgiop","html_url":"https://github.com/giorgiop","followers_url":"https://api.github.com/users/giorgiop/followers","following_url":"https://api.github.com/users/giorgiop/following{/other_user}","gists_url":"https://api.github.com/users/giorgiop/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiop/subscriptions","organizations_url":"https://api.github.com/users/giorgiop/orgs","repos_url":"https://api.github.com/users/giorgiop/repos","events_url":"https://api.github.com/users/giorgiop/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiop/received_events","type":"User","site_admin":false},"repo":{"id":34982360,"name":"scikit-learn","full_name":"giorgiop/scikit-learn","owner":{"login":"giorgiop","id":2871319,"avatar_url":"https://avatars.githubusercontent.com/u/2871319?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgiop","html_url":"https://github.com/giorgiop","followers_url":"https://api.github.com/users/giorgiop/followers","following_url":"https://api.github.com/users/giorgiop/following{/other_user}","gists_url":"https://api.github.com/users/giorgiop/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiop/subscriptions","organizations_url":"https://api.github.com/users/giorgiop/orgs","repos_url":"https://api.github.com/users/giorgiop/repos","events_url":"https://api.github.com/users/giorgiop/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/giorgiop/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/giorgiop/scikit-learn","forks_url":"https://api.github.com/repos/giorgiop/scikit-learn/forks","keys_url":"https://api.github.com/repos/giorgiop/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giorgiop/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giorgiop/scikit-learn/teams","hooks_url":"https://api.github.com/repos/giorgiop/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/giorgiop/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/giorgiop/scikit-learn/events","assignees_url":"https://api.github.com/repos/giorgiop/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/giorgiop/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/giorgiop/scikit-learn/tags","blobs_url":"https://api.github.com/repos/giorgiop/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giorgiop/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giorgiop/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/giorgiop/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giorgiop/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/giorgiop/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/giorgiop/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/giorgiop/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/giorgiop/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/giorgiop/scikit-learn/subscription","commits_url":"https://api.github.com/repos/giorgiop/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/giorgiop/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/giorgiop/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/giorgiop/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/giorgiop/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/giorgiop/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giorgiop/scikit-learn/merges","archive_url":"https://api.github.com/repos/giorgiop/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giorgiop/scikit-learn/downloads","issues_url":"https://api.github.com/repos/giorgiop/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/giorgiop/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/giorgiop/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/giorgiop/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giorgiop/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/giorgiop/scikit-learn/releases{/id}","created_at":"2015-05-03T10:39:46Z","updated_at":"2015-09-08T14:16:19Z","pushed_at":"2015-11-13T15:06:16Z","git_url":"git://github.com/giorgiop/scikit-learn.git","ssh_url":"git@github.com:giorgiop/scikit-learn.git","clone_url":"https://github.com/giorgiop/scikit-learn.git","svn_url":"https://github.com/giorgiop/scikit-learn","homepage":"http://scikit-learn.org","size":70523,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"5bba3d0a9773ec1d5c7f18b729c68a69ae06dff5","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-11-15T10:57:06Z","pushed_at":"2015-11-15T14:26:18Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":142133,"stargazers_count":8262,"watchers_count":8262,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4912,"mirror_url":null,"open_issues_count":872,"forks":4912,"open_issues":872,"watchers":8262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5357"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5357"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5357"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5357/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5357/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5357/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/beb7b93420f3735d8e8aaf0c19c233266350cc92"}}}}