{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-DOE/pyart/pulls/comments/35343243","id":35343243,"diff_hunk":"@@ -1096,3 +1096,105 @@\n     'chl': chl_field_mapping,\n     'gamic': gamic_field_mapping,\n }\n+\n+\n+def velocity_limit(container=None, selection=0):\n+    import pyart\n+    if isinstance(container, pyart.core.Radar):\n+        try:\n+            if selection >= 0 and selection < container.nsweeps:\n+                vel = container.get_nyquist_vel(selection,\n+                                                check_uniform=False)\n+            else:\n+                vel = container.get_nyquist_vel(0, check_uniform=False)\n+            return (-vel, vel)\n+        except LookupError:\n+            return (-30., 30.)\n+    else:\n+        return (-30., 30.)\n+\n+\n+def spectrum_width_limit(container=None, selection=0):\n+    import pyart\n+    if isinstance(container, pyart.core.Radar):\n+        try:\n+            if selection >= 0 and selection < container.nsweeps:\n+                vel = container.get_nyquist_vel(selection,\n+                                                check_uniform=False)\n+            else:\n+                vel = container.get_nyquist_vel(0, check_uniform=False)\n+            return (0, vel)\n+        except LookupError:\n+            return (0, 30.)\n+    else:\n+        return (0, 30.)\n+\n+# map each field to a colormap\n+\n+DEFAULT_FIELD_COLORMAP = {\n+    # field name : colormap","path":"pyart/default_config.py","position":40,"original_position":40,"commit_id":"3a5449bfa3a60cde15ce399ec4e1c4a423578d0b","original_commit_id":"d22f9a473470dd2c28a010cab37147705f296f46","user":{"login":"gamaanderson","id":7915525,"avatar_url":"https://avatars.githubusercontent.com/u/7915525?v=3","gravatar_id":"","url":"https://api.github.com/users/gamaanderson","html_url":"https://github.com/gamaanderson","followers_url":"https://api.github.com/users/gamaanderson/followers","following_url":"https://api.github.com/users/gamaanderson/following{/other_user}","gists_url":"https://api.github.com/users/gamaanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamaanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamaanderson/subscriptions","organizations_url":"https://api.github.com/users/gamaanderson/orgs","repos_url":"https://api.github.com/users/gamaanderson/repos","events_url":"https://api.github.com/users/gamaanderson/events{/privacy}","received_events_url":"https://api.github.com/users/gamaanderson/received_events","type":"User","site_admin":false},"body":"ok, that was a miss understanding. Any way it is right now!","created_at":"2015-07-23T16:47:02Z","updated_at":"2015-07-23T16:47:02Z","html_url":"https://github.com/ARM-DOE/pyart/pull/336#discussion_r35343243","pull_request_url":"https://api.github.com/repos/ARM-DOE/pyart/pulls/336","_links":{"self":{"href":"https://api.github.com/repos/ARM-DOE/pyart/pulls/comments/35343243"},"html":{"href":"https://github.com/ARM-DOE/pyart/pull/336#discussion_r35343243"},"pull_request":{"href":"https://api.github.com/repos/ARM-DOE/pyart/pulls/336"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-DOE/pyart/pulls/336","id":40680739,"html_url":"https://github.com/ARM-DOE/pyart/pull/336","diff_url":"https://github.com/ARM-DOE/pyart/pull/336.diff","patch_url":"https://github.com/ARM-DOE/pyart/pull/336.patch","issue_url":"https://api.github.com/repos/ARM-DOE/pyart/issues/336","number":336,"state":"open","locked":false,"title":"ENH: Default limits and colormap","user":{"login":"gamaanderson","id":7915525,"avatar_url":"https://avatars.githubusercontent.com/u/7915525?v=3","gravatar_id":"","url":"https://api.github.com/users/gamaanderson","html_url":"https://github.com/gamaanderson","followers_url":"https://api.github.com/users/gamaanderson/followers","following_url":"https://api.github.com/users/gamaanderson/following{/other_user}","gists_url":"https://api.github.com/users/gamaanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamaanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamaanderson/subscriptions","organizations_url":"https://api.github.com/users/gamaanderson/orgs","repos_url":"https://api.github.com/users/gamaanderson/repos","events_url":"https://api.github.com/users/gamaanderson/events{/privacy}","received_events_url":"https://api.github.com/users/gamaanderson/received_events","type":"User","site_admin":false},"body":"add `pyart.config.get_field_colormap` and `pyart.config.get_field_limits` as discussed in issues #329 \r\n\r\n@jjhelmus  @scollis @nguy The default values I choose are based in current artview and some personal experience, so they need some revision, in especial 'differential_reflectivity' and 'differential_phase' may need more attention\r\n\r\nI made a fast implementation in a branch of artview so it can also be tested there [gamaanderson/artview/colormap](https://github.com/gamaanderson/artview/tree/colormap)\r\n\r\nFinally I just want to say that this is an enhancement, both for pyart and artview, so it is not a priority. Lets give every one the time they need","created_at":"2015-07-23T14:54:26Z","updated_at":"2015-07-23T16:47:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86dfc9e7b8a38ea3bbe662d967dbd6abd627ee31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ARM-DOE/pyart/pulls/336/commits","review_comments_url":"https://api.github.com/repos/ARM-DOE/pyart/pulls/336/comments","review_comment_url":"https://api.github.com/repos/ARM-DOE/pyart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-DOE/pyart/issues/336/comments","statuses_url":"https://api.github.com/repos/ARM-DOE/pyart/statuses/3a5449bfa3a60cde15ce399ec4e1c4a423578d0b","head":{"label":"gamaanderson:colormap","ref":"colormap","sha":"3a5449bfa3a60cde15ce399ec4e1c4a423578d0b","user":{"login":"gamaanderson","id":7915525,"avatar_url":"https://avatars.githubusercontent.com/u/7915525?v=3","gravatar_id":"","url":"https://api.github.com/users/gamaanderson","html_url":"https://github.com/gamaanderson","followers_url":"https://api.github.com/users/gamaanderson/followers","following_url":"https://api.github.com/users/gamaanderson/following{/other_user}","gists_url":"https://api.github.com/users/gamaanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamaanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamaanderson/subscriptions","organizations_url":"https://api.github.com/users/gamaanderson/orgs","repos_url":"https://api.github.com/users/gamaanderson/repos","events_url":"https://api.github.com/users/gamaanderson/events{/privacy}","received_events_url":"https://api.github.com/users/gamaanderson/received_events","type":"User","site_admin":false},"repo":{"id":39389546,"name":"pyart","full_name":"gamaanderson/pyart","owner":{"login":"gamaanderson","id":7915525,"avatar_url":"https://avatars.githubusercontent.com/u/7915525?v=3","gravatar_id":"","url":"https://api.github.com/users/gamaanderson","html_url":"https://github.com/gamaanderson","followers_url":"https://api.github.com/users/gamaanderson/followers","following_url":"https://api.github.com/users/gamaanderson/following{/other_user}","gists_url":"https://api.github.com/users/gamaanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamaanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamaanderson/subscriptions","organizations_url":"https://api.github.com/users/gamaanderson/orgs","repos_url":"https://api.github.com/users/gamaanderson/repos","events_url":"https://api.github.com/users/gamaanderson/events{/privacy}","received_events_url":"https://api.github.com/users/gamaanderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gamaanderson/pyart","description":"The Python-ARM Radar Toolkit. An data model driven interactive toolkit for working with weather radar data. ","fork":true,"url":"https://api.github.com/repos/gamaanderson/pyart","forks_url":"https://api.github.com/repos/gamaanderson/pyart/forks","keys_url":"https://api.github.com/repos/gamaanderson/pyart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gamaanderson/pyart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gamaanderson/pyart/teams","hooks_url":"https://api.github.com/repos/gamaanderson/pyart/hooks","issue_events_url":"https://api.github.com/repos/gamaanderson/pyart/issues/events{/number}","events_url":"https://api.github.com/repos/gamaanderson/pyart/events","assignees_url":"https://api.github.com/repos/gamaanderson/pyart/assignees{/user}","branches_url":"https://api.github.com/repos/gamaanderson/pyart/branches{/branch}","tags_url":"https://api.github.com/repos/gamaanderson/pyart/tags","blobs_url":"https://api.github.com/repos/gamaanderson/pyart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gamaanderson/pyart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gamaanderson/pyart/git/refs{/sha}","trees_url":"https://api.github.com/repos/gamaanderson/pyart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gamaanderson/pyart/statuses/{sha}","languages_url":"https://api.github.com/repos/gamaanderson/pyart/languages","stargazers_url":"https://api.github.com/repos/gamaanderson/pyart/stargazers","contributors_url":"https://api.github.com/repos/gamaanderson/pyart/contributors","subscribers_url":"https://api.github.com/repos/gamaanderson/pyart/subscribers","subscription_url":"https://api.github.com/repos/gamaanderson/pyart/subscription","commits_url":"https://api.github.com/repos/gamaanderson/pyart/commits{/sha}","git_commits_url":"https://api.github.com/repos/gamaanderson/pyart/git/commits{/sha}","comments_url":"https://api.github.com/repos/gamaanderson/pyart/comments{/number}","issue_comment_url":"https://api.github.com/repos/gamaanderson/pyart/issues/comments{/number}","contents_url":"https://api.github.com/repos/gamaanderson/pyart/contents/{+path}","compare_url":"https://api.github.com/repos/gamaanderson/pyart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gamaanderson/pyart/merges","archive_url":"https://api.github.com/repos/gamaanderson/pyart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gamaanderson/pyart/downloads","issues_url":"https://api.github.com/repos/gamaanderson/pyart/issues{/number}","pulls_url":"https://api.github.com/repos/gamaanderson/pyart/pulls{/number}","milestones_url":"https://api.github.com/repos/gamaanderson/pyart/milestones{/number}","notifications_url":"https://api.github.com/repos/gamaanderson/pyart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gamaanderson/pyart/labels{/name}","releases_url":"https://api.github.com/repos/gamaanderson/pyart/releases{/id}","created_at":"2015-07-20T14:44:53Z","updated_at":"2015-07-20T14:44:53Z","pushed_at":"2015-07-23T16:42:16Z","git_url":"git://github.com/gamaanderson/pyart.git","ssh_url":"git@github.com:gamaanderson/pyart.git","clone_url":"https://github.com/gamaanderson/pyart.git","svn_url":"https://github.com/gamaanderson/pyart","homepage":"http://arm-doe.github.io/pyart/","size":53276,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-DOE:master","ref":"master","sha":"503ea5329edf300bf5e35d75b9e92b6be32dceca","user":{"login":"ARM-DOE","id":2540600,"avatar_url":"https://avatars.githubusercontent.com/u/2540600?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-DOE","html_url":"https://github.com/ARM-DOE","followers_url":"https://api.github.com/users/ARM-DOE/followers","following_url":"https://api.github.com/users/ARM-DOE/following{/other_user}","gists_url":"https://api.github.com/users/ARM-DOE/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-DOE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-DOE/subscriptions","organizations_url":"https://api.github.com/users/ARM-DOE/orgs","repos_url":"https://api.github.com/users/ARM-DOE/repos","events_url":"https://api.github.com/users/ARM-DOE/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-DOE/received_events","type":"Organization","site_admin":false},"repo":{"id":6248645,"name":"pyart","full_name":"ARM-DOE/pyart","owner":{"login":"ARM-DOE","id":2540600,"avatar_url":"https://avatars.githubusercontent.com/u/2540600?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-DOE","html_url":"https://github.com/ARM-DOE","followers_url":"https://api.github.com/users/ARM-DOE/followers","following_url":"https://api.github.com/users/ARM-DOE/following{/other_user}","gists_url":"https://api.github.com/users/ARM-DOE/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-DOE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-DOE/subscriptions","organizations_url":"https://api.github.com/users/ARM-DOE/orgs","repos_url":"https://api.github.com/users/ARM-DOE/repos","events_url":"https://api.github.com/users/ARM-DOE/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-DOE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-DOE/pyart","description":"The Python-ARM Radar Toolkit. An data model driven interactive toolkit for working with weather radar data. ","fork":false,"url":"https://api.github.com/repos/ARM-DOE/pyart","forks_url":"https://api.github.com/repos/ARM-DOE/pyart/forks","keys_url":"https://api.github.com/repos/ARM-DOE/pyart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-DOE/pyart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-DOE/pyart/teams","hooks_url":"https://api.github.com/repos/ARM-DOE/pyart/hooks","issue_events_url":"https://api.github.com/repos/ARM-DOE/pyart/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-DOE/pyart/events","assignees_url":"https://api.github.com/repos/ARM-DOE/pyart/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-DOE/pyart/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-DOE/pyart/tags","blobs_url":"https://api.github.com/repos/ARM-DOE/pyart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-DOE/pyart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-DOE/pyart/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-DOE/pyart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-DOE/pyart/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-DOE/pyart/languages","stargazers_url":"https://api.github.com/repos/ARM-DOE/pyart/stargazers","contributors_url":"https://api.github.com/repos/ARM-DOE/pyart/contributors","subscribers_url":"https://api.github.com/repos/ARM-DOE/pyart/subscribers","subscription_url":"https://api.github.com/repos/ARM-DOE/pyart/subscription","commits_url":"https://api.github.com/repos/ARM-DOE/pyart/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-DOE/pyart/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-DOE/pyart/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-DOE/pyart/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-DOE/pyart/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-DOE/pyart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-DOE/pyart/merges","archive_url":"https://api.github.com/repos/ARM-DOE/pyart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-DOE/pyart/downloads","issues_url":"https://api.github.com/repos/ARM-DOE/pyart/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-DOE/pyart/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-DOE/pyart/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-DOE/pyart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-DOE/pyart/labels{/name}","releases_url":"https://api.github.com/repos/ARM-DOE/pyart/releases{/id}","created_at":"2012-10-16T17:51:30Z","updated_at":"2015-07-23T13:32:38Z","pushed_at":"2015-07-23T16:45:02Z","git_url":"git://github.com/ARM-DOE/pyart.git","ssh_url":"git@github.com:ARM-DOE/pyart.git","clone_url":"https://github.com/ARM-DOE/pyart.git","svn_url":"https://github.com/ARM-DOE/pyart","homepage":"http://arm-doe.github.io/pyart/","size":55466,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":46,"forks":39,"open_issues":46,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-DOE/pyart/pulls/336"},"html":{"href":"https://github.com/ARM-DOE/pyart/pull/336"},"issue":{"href":"https://api.github.com/repos/ARM-DOE/pyart/issues/336"},"comments":{"href":"https://api.github.com/repos/ARM-DOE/pyart/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-DOE/pyart/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-DOE/pyart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-DOE/pyart/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-DOE/pyart/statuses/3a5449bfa3a60cde15ce399ec4e1c4a423578d0b"}}}}