{"action":"opened","number":636,"pull_request":{"url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/636","id":32641472,"html_url":"https://github.com/GlowstoneMC/Glowstone/pull/636","diff_url":"https://github.com/GlowstoneMC/Glowstone/pull/636.diff","patch_url":"https://github.com/GlowstoneMC/Glowstone/pull/636.patch","issue_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/636","number":636,"state":"open","locked":false,"title":"Added some water/lava physics","user":{"login":"SamNosliw","id":1645671,"avatar_url":"https://avatars.githubusercontent.com/u/1645671?v=3","gravatar_id":"","url":"https://api.github.com/users/SamNosliw","html_url":"https://github.com/SamNosliw","followers_url":"https://api.github.com/users/SamNosliw/followers","following_url":"https://api.github.com/users/SamNosliw/following{/other_user}","gists_url":"https://api.github.com/users/SamNosliw/gists{/gist_id}","starred_url":"https://api.github.com/users/SamNosliw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamNosliw/subscriptions","organizations_url":"https://api.github.com/users/SamNosliw/orgs","repos_url":"https://api.github.com/users/SamNosliw/repos","events_url":"https://api.github.com/users/SamNosliw/events{/privacy}","received_events_url":"https://api.github.com/users/SamNosliw/received_events","type":"User","site_admin":false},"body":"I've managed to get water/lava working pretty well, I believe the same as vanilla Minecraft. I don't know what your plans are, but I would just like to offer this to you.\r\n\r\nI also added a requestPulse function into the world, this allow water to update in a similar manor to normal Minecraft, they are a way to regulate updates. A block can request to be pulsed on every X game ticks, and then unsubscribe from this list, so that it doesn't keep pulsing without need, I plan to make the world save all the pulse requests of a chunk when it unloads however, so that it can restore them on loading, and not freeze any growth when this occurs. Anyway, here is the code if you want to have a look, please tell me if I missed out any code or haven't explained it well, the lack of comments is a bad habit of mine, thanks for your time.","created_at":"2015-04-04T23:43:35Z","updated_at":"2015-04-04T23:43:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/636/commits","review_comments_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/636/comments","review_comment_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/636/comments","statuses_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/statuses/b72ff3fd0771aa7d090a32f0130b39aa17452ba9","head":{"label":"SamNosliw:master","ref":"master","sha":"b72ff3fd0771aa7d090a32f0130b39aa17452ba9","user":{"login":"SamNosliw","id":1645671,"avatar_url":"https://avatars.githubusercontent.com/u/1645671?v=3","gravatar_id":"","url":"https://api.github.com/users/SamNosliw","html_url":"https://github.com/SamNosliw","followers_url":"https://api.github.com/users/SamNosliw/followers","following_url":"https://api.github.com/users/SamNosliw/following{/other_user}","gists_url":"https://api.github.com/users/SamNosliw/gists{/gist_id}","starred_url":"https://api.github.com/users/SamNosliw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamNosliw/subscriptions","organizations_url":"https://api.github.com/users/SamNosliw/orgs","repos_url":"https://api.github.com/users/SamNosliw/repos","events_url":"https://api.github.com/users/SamNosliw/events{/privacy}","received_events_url":"https://api.github.com/users/SamNosliw/received_events","type":"User","site_admin":false},"repo":{"id":33423829,"name":"Glowstone","full_name":"SamNosliw/Glowstone","owner":{"login":"SamNosliw","id":1645671,"avatar_url":"https://avatars.githubusercontent.com/u/1645671?v=3","gravatar_id":"","url":"https://api.github.com/users/SamNosliw","html_url":"https://github.com/SamNosliw","followers_url":"https://api.github.com/users/SamNosliw/followers","following_url":"https://api.github.com/users/SamNosliw/following{/other_user}","gists_url":"https://api.github.com/users/SamNosliw/gists{/gist_id}","starred_url":"https://api.github.com/users/SamNosliw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamNosliw/subscriptions","organizations_url":"https://api.github.com/users/SamNosliw/orgs","repos_url":"https://api.github.com/users/SamNosliw/repos","events_url":"https://api.github.com/users/SamNosliw/events{/privacy}","received_events_url":"https://api.github.com/users/SamNosliw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamNosliw/Glowstone","description":"An open-source server for the Bukkit Minecraft modding interface.","fork":true,"url":"https://api.github.com/repos/SamNosliw/Glowstone","forks_url":"https://api.github.com/repos/SamNosliw/Glowstone/forks","keys_url":"https://api.github.com/repos/SamNosliw/Glowstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamNosliw/Glowstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamNosliw/Glowstone/teams","hooks_url":"https://api.github.com/repos/SamNosliw/Glowstone/hooks","issue_events_url":"https://api.github.com/repos/SamNosliw/Glowstone/issues/events{/number}","events_url":"https://api.github.com/repos/SamNosliw/Glowstone/events","assignees_url":"https://api.github.com/repos/SamNosliw/Glowstone/assignees{/user}","branches_url":"https://api.github.com/repos/SamNosliw/Glowstone/branches{/branch}","tags_url":"https://api.github.com/repos/SamNosliw/Glowstone/tags","blobs_url":"https://api.github.com/repos/SamNosliw/Glowstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamNosliw/Glowstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamNosliw/Glowstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamNosliw/Glowstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamNosliw/Glowstone/statuses/{sha}","languages_url":"https://api.github.com/repos/SamNosliw/Glowstone/languages","stargazers_url":"https://api.github.com/repos/SamNosliw/Glowstone/stargazers","contributors_url":"https://api.github.com/repos/SamNosliw/Glowstone/contributors","subscribers_url":"https://api.github.com/repos/SamNosliw/Glowstone/subscribers","subscription_url":"https://api.github.com/repos/SamNosliw/Glowstone/subscription","commits_url":"https://api.github.com/repos/SamNosliw/Glowstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamNosliw/Glowstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamNosliw/Glowstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamNosliw/Glowstone/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamNosliw/Glowstone/contents/{+path}","compare_url":"https://api.github.com/repos/SamNosliw/Glowstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamNosliw/Glowstone/merges","archive_url":"https://api.github.com/repos/SamNosliw/Glowstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamNosliw/Glowstone/downloads","issues_url":"https://api.github.com/repos/SamNosliw/Glowstone/issues{/number}","pulls_url":"https://api.github.com/repos/SamNosliw/Glowstone/pulls{/number}","milestones_url":"https://api.github.com/repos/SamNosliw/Glowstone/milestones{/number}","notifications_url":"https://api.github.com/repos/SamNosliw/Glowstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamNosliw/Glowstone/labels{/name}","releases_url":"https://api.github.com/repos/SamNosliw/Glowstone/releases{/id}","created_at":"2015-04-04T23:24:57Z","updated_at":"2015-04-04T23:39:05Z","pushed_at":"2015-04-04T23:39:03Z","git_url":"git://github.com/SamNosliw/Glowstone.git","ssh_url":"git@github.com:SamNosliw/Glowstone.git","clone_url":"https://github.com/SamNosliw/Glowstone.git","svn_url":"https://github.com/SamNosliw/Glowstone","homepage":"http://www.glowstone.net/","size":22475,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GlowstoneMC:master","ref":"master","sha":"16cb7d5dcb0134961966aa6116a7090de79227c5","user":{"login":"GlowstoneMC","id":8682517,"avatar_url":"https://avatars.githubusercontent.com/u/8682517?v=3","gravatar_id":"","url":"https://api.github.com/users/GlowstoneMC","html_url":"https://github.com/GlowstoneMC","followers_url":"https://api.github.com/users/GlowstoneMC/followers","following_url":"https://api.github.com/users/GlowstoneMC/following{/other_user}","gists_url":"https://api.github.com/users/GlowstoneMC/gists{/gist_id}","starred_url":"https://api.github.com/users/GlowstoneMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlowstoneMC/subscriptions","organizations_url":"https://api.github.com/users/GlowstoneMC/orgs","repos_url":"https://api.github.com/users/GlowstoneMC/repos","events_url":"https://api.github.com/users/GlowstoneMC/events{/privacy}","received_events_url":"https://api.github.com/users/GlowstoneMC/received_events","type":"Organization","site_admin":false},"repo":{"id":1501888,"name":"Glowstone","full_name":"GlowstoneMC/Glowstone","owner":{"login":"GlowstoneMC","id":8682517,"avatar_url":"https://avatars.githubusercontent.com/u/8682517?v=3","gravatar_id":"","url":"https://api.github.com/users/GlowstoneMC","html_url":"https://github.com/GlowstoneMC","followers_url":"https://api.github.com/users/GlowstoneMC/followers","following_url":"https://api.github.com/users/GlowstoneMC/following{/other_user}","gists_url":"https://api.github.com/users/GlowstoneMC/gists{/gist_id}","starred_url":"https://api.github.com/users/GlowstoneMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlowstoneMC/subscriptions","organizations_url":"https://api.github.com/users/GlowstoneMC/orgs","repos_url":"https://api.github.com/users/GlowstoneMC/repos","events_url":"https://api.github.com/users/GlowstoneMC/events{/privacy}","received_events_url":"https://api.github.com/users/GlowstoneMC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GlowstoneMC/Glowstone","description":"An open-source server for the Bukkit Minecraft modding interface.","fork":false,"url":"https://api.github.com/repos/GlowstoneMC/Glowstone","forks_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/forks","keys_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/teams","hooks_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/hooks","issue_events_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/events{/number}","events_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/events","assignees_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/assignees{/user}","branches_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/branches{/branch}","tags_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/tags","blobs_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/statuses/{sha}","languages_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/languages","stargazers_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/stargazers","contributors_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/contributors","subscribers_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/subscribers","subscription_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/subscription","commits_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/comments{/number}","contents_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/contents/{+path}","compare_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/merges","archive_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/downloads","issues_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues{/number}","pulls_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls{/number}","milestones_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/milestones{/number}","notifications_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/labels{/name}","releases_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/releases{/id}","created_at":"2011-03-20T01:40:35Z","updated_at":"2015-04-04T20:41:58Z","pushed_at":"2015-02-08T06:13:47Z","git_url":"git://github.com/GlowstoneMC/Glowstone.git","ssh_url":"git@github.com:GlowstoneMC/Glowstone.git","clone_url":"https://github.com/GlowstoneMC/Glowstone.git","svn_url":"https://github.com/GlowstoneMC/Glowstone","homepage":"http://www.glowstone.net/","size":22475,"stargazers_count":407,"watchers_count":407,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":108,"forks":185,"open_issues":108,"watchers":407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/636"},"html":{"href":"https://github.com/GlowstoneMC/Glowstone/pull/636"},"issue":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/636"},"comments":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/GlowstoneMC/Glowstone/statuses/b72ff3fd0771aa7d090a32f0130b39aa17452ba9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":294,"deletions":29,"changed_files":3}}