{"action":"closed","number":222,"pull_request":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/222","id":44804295,"html_url":"https://github.com/01org/parameter-framework/pull/222","diff_url":"https://github.com/01org/parameter-framework/pull/222.diff","patch_url":"https://github.com/01org/parameter-framework/pull/222.patch","issue_url":"https://api.github.com/repos/01org/parameter-framework/issues/222","number":222,"state":"closed","locked":false,"title":"Rework parameter handle access check","user":{"login":"krocard","id":6862950,"avatar_url":"https://avatars.githubusercontent.com/u/6862950?v=3","gravatar_id":"","url":"https://api.github.com/users/krocard","html_url":"https://github.com/krocard","followers_url":"https://api.github.com/users/krocard/followers","following_url":"https://api.github.com/users/krocard/following{/other_user}","gists_url":"https://api.github.com/users/krocard/gists{/gist_id}","starred_url":"https://api.github.com/users/krocard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krocard/subscriptions","organizations_url":"https://api.github.com/users/krocard/orgs","repos_url":"https://api.github.com/users/krocard/repos","events_url":"https://api.github.com/users/krocard/events{/privacy}","received_events_url":"https://api.github.com/users/krocard/received_events","type":"User","site_admin":false},"body":"Fix a warning on windows where -1 was casted to unsigned to size_t.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/01org/parameter-framework/pull/222%23discussion_r39292361%22%5D%2C%20%22comments%22%3A%20%7B%22Pull%20c1cc501cd1c8afdd57bfd0eb95a817bf33e05a1d%20parameter/ParameterHandle.cpp%20236%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/222%23discussion_r39292361%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22missing%20quotes%20around%20the%20path.%22%2C%20%22created_at%22%3A%20%222015-09-11T17%3A03%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/ParameterHandle.cpp%3AL474-513%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-Pull c1cc501cd1c8afdd57bfd0eb95a817bf33e05a1d parameter/ParameterHandle.cpp 236'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/222#discussion_r39292361'>File: parameter/ParameterHandle.cpp:L474-513</a></b>\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> missing quotes around the path.\n\n\n<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/222?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/222?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/01org/parameter-framework/pull/222'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2015-09-11T16:50:17Z","updated_at":"2015-09-11T17:33:02Z","closed_at":"2015-09-11T17:33:02Z","merged_at":"2015-09-11T17:33:02Z","merge_commit_sha":"100ceeb631e0ed0263a82a387de0d9eaf92fd1ce","assignee":null,"milestone":{"url":"https://api.github.com/repos/01org/parameter-framework/milestones/3","html_url":"https://github.com/01org/parameter-framework/milestones/Windows%20port","labels_url":"https://api.github.com/repos/01org/parameter-framework/milestones/3/labels","id":1297260,"number":3,"title":"Windows port","description":"Have the Parameter Framework compile on Windows.","creator":{"login":"dawagner","id":6430928,"avatar_url":"https://avatars.githubusercontent.com/u/6430928?v=3","gravatar_id":"","url":"https://api.github.com/users/dawagner","html_url":"https://github.com/dawagner","followers_url":"https://api.github.com/users/dawagner/followers","following_url":"https://api.github.com/users/dawagner/following{/other_user}","gists_url":"https://api.github.com/users/dawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawagner/subscriptions","organizations_url":"https://api.github.com/users/dawagner/orgs","repos_url":"https://api.github.com/users/dawagner/repos","events_url":"https://api.github.com/users/dawagner/events{/privacy}","received_events_url":"https://api.github.com/users/dawagner/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":33,"state":"open","created_at":"2015-09-09T08:28:52Z","updated_at":"2015-09-11T17:33:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/01org/parameter-framework/pulls/222/commits","review_comments_url":"https://api.github.com/repos/01org/parameter-framework/pulls/222/comments","review_comment_url":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/parameter-framework/issues/222/comments","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/d76223c00f44a24ea76f44dc7f9899d560975b8f","head":{"label":"krocard:rework_parameter_handle","ref":"rework_parameter_handle","sha":"d76223c00f44a24ea76f44dc7f9899d560975b8f","user":{"login":"krocard","id":6862950,"avatar_url":"https://avatars.githubusercontent.com/u/6862950?v=3","gravatar_id":"","url":"https://api.github.com/users/krocard","html_url":"https://github.com/krocard","followers_url":"https://api.github.com/users/krocard/followers","following_url":"https://api.github.com/users/krocard/following{/other_user}","gists_url":"https://api.github.com/users/krocard/gists{/gist_id}","starred_url":"https://api.github.com/users/krocard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krocard/subscriptions","organizations_url":"https://api.github.com/users/krocard/orgs","repos_url":"https://api.github.com/users/krocard/repos","events_url":"https://api.github.com/users/krocard/events{/privacy}","received_events_url":"https://api.github.com/users/krocard/received_events","type":"User","site_admin":false},"repo":{"id":24673385,"name":"parameter-framework","full_name":"krocard/parameter-framework","owner":{"login":"krocard","id":6862950,"avatar_url":"https://avatars.githubusercontent.com/u/6862950?v=3","gravatar_id":"","url":"https://api.github.com/users/krocard","html_url":"https://github.com/krocard","followers_url":"https://api.github.com/users/krocard/followers","following_url":"https://api.github.com/users/krocard/following{/other_user}","gists_url":"https://api.github.com/users/krocard/gists{/gist_id}","starred_url":"https://api.github.com/users/krocard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krocard/subscriptions","organizations_url":"https://api.github.com/users/krocard/orgs","repos_url":"https://api.github.com/users/krocard/repos","events_url":"https://api.github.com/users/krocard/events{/privacy}","received_events_url":"https://api.github.com/users/krocard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krocard/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":true,"url":"https://api.github.com/repos/krocard/parameter-framework","forks_url":"https://api.github.com/repos/krocard/parameter-framework/forks","keys_url":"https://api.github.com/repos/krocard/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krocard/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krocard/parameter-framework/teams","hooks_url":"https://api.github.com/repos/krocard/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/krocard/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/krocard/parameter-framework/events","assignees_url":"https://api.github.com/repos/krocard/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/krocard/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/krocard/parameter-framework/tags","blobs_url":"https://api.github.com/repos/krocard/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krocard/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krocard/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/krocard/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krocard/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/krocard/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/krocard/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/krocard/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/krocard/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/krocard/parameter-framework/subscription","commits_url":"https://api.github.com/repos/krocard/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/krocard/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/krocard/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/krocard/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/krocard/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/krocard/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krocard/parameter-framework/merges","archive_url":"https://api.github.com/repos/krocard/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krocard/parameter-framework/downloads","issues_url":"https://api.github.com/repos/krocard/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/krocard/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/krocard/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/krocard/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krocard/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/krocard/parameter-framework/releases{/id}","created_at":"2014-10-01T09:54:18Z","updated_at":"2015-04-13T15:36:05Z","pushed_at":"2015-09-11T17:27:57Z","git_url":"git://github.com/krocard/parameter-framework.git","ssh_url":"git@github.com:krocard/parameter-framework.git","clone_url":"https://github.com/krocard/parameter-framework.git","svn_url":"https://github.com/krocard/parameter-framework","homepage":"","size":4105,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:windows_port","ref":"windows_port","sha":"c2ab92a8ccca7e9459cfbfb7e4227aa4d5fb1fe0","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":16009363,"name":"parameter-framework","full_name":"01org/parameter-framework","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":false,"url":"https://api.github.com/repos/01org/parameter-framework","forks_url":"https://api.github.com/repos/01org/parameter-framework/forks","keys_url":"https://api.github.com/repos/01org/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/parameter-framework/teams","hooks_url":"https://api.github.com/repos/01org/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/01org/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/01org/parameter-framework/events","assignees_url":"https://api.github.com/repos/01org/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/01org/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/01org/parameter-framework/tags","blobs_url":"https://api.github.com/repos/01org/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/01org/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/01org/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/01org/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/01org/parameter-framework/subscription","commits_url":"https://api.github.com/repos/01org/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/01org/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/parameter-framework/merges","archive_url":"https://api.github.com/repos/01org/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/parameter-framework/downloads","issues_url":"https://api.github.com/repos/01org/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/01org/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/01org/parameter-framework/releases{/id}","created_at":"2014-01-17T19:24:01Z","updated_at":"2015-09-09T08:16:08Z","pushed_at":"2015-09-11T17:33:02Z","git_url":"git://github.com/01org/parameter-framework.git","ssh_url":"git@github.com:01org/parameter-framework.git","clone_url":"https://github.com/01org/parameter-framework.git","svn_url":"https://github.com/01org/parameter-framework","homepage":"","size":49342,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":28,"forks":22,"open_issues":28,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/222"},"html":{"href":"https://github.com/01org/parameter-framework/pull/222"},"issue":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/222"},"comments":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/01org/parameter-framework/statuses/d76223c00f44a24ea76f44dc7f9899d560975b8f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dawagner","id":6430928,"avatar_url":"https://avatars.githubusercontent.com/u/6430928?v=3","gravatar_id":"","url":"https://api.github.com/users/dawagner","html_url":"https://github.com/dawagner","followers_url":"https://api.github.com/users/dawagner/followers","following_url":"https://api.github.com/users/dawagner/following{/other_user}","gists_url":"https://api.github.com/users/dawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawagner/subscriptions","organizations_url":"https://api.github.com/users/dawagner/orgs","repos_url":"https://api.github.com/users/dawagner/repos","events_url":"https://api.github.com/users/dawagner/events{/privacy}","received_events_url":"https://api.github.com/users/dawagner/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"commits":1,"additions":59,"deletions":44,"changed_files":2}}