{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/jissues/issues/683","labels_url":"https://api.github.com/repos/joomla/jissues/issues/683/labels{/name}","comments_url":"https://api.github.com/repos/joomla/jissues/issues/683/comments","events_url":"https://api.github.com/repos/joomla/jissues/issues/683/events","html_url":"https://github.com/joomla/jissues/pull/683","id":96092572,"number":683,"title":"User test sha","user":{"login":"elkuku","id":33978,"avatar_url":"https://avatars.githubusercontent.com/u/33978?v=3","gravatar_id":"","url":"https://api.github.com/users/elkuku","html_url":"https://github.com/elkuku","followers_url":"https://api.github.com/users/elkuku/followers","following_url":"https://api.github.com/users/elkuku/following{/other_user}","gists_url":"https://api.github.com/users/elkuku/gists{/gist_id}","starred_url":"https://api.github.com/users/elkuku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elkuku/subscriptions","organizations_url":"https://api.github.com/users/elkuku/orgs","repos_url":"https://api.github.com/users/elkuku/repos","events_url":"https://api.github.com/users/elkuku/events{/privacy}","received_events_url":"https://api.github.com/users/elkuku/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-07-20T15:46:43Z","updated_at":"2015-08-18T17:01:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/jissues/pulls/683","html_url":"https://github.com/joomla/jissues/pull/683","diff_url":"https://github.com/joomla/jissues/pull/683.diff","patch_url":"https://github.com/joomla/jissues/pull/683.patch"},"body":"I think we should improve our user test facility as it is one of those things we really add to the GitHub tracker.\r\n\r\nI think we should start treating the user tests like the other automated test results (if possible). For this it is necessary to record the information **when** the PR has been tested. In terms of git this would be the git SHA hash corresponding to the last commit. (You may read more about it [here](https://schacon.github.io/gitbook/1_the_git_object_model.html), [here](https://git-scm.com/book/en/v2/Git-Internals-Git-Objects) or [here](http://blog.thoughtram.io/git/2014/11/18/the-anatomy-of-a-git-commit.html)).\r\n\r\nThis information has not to be entered by the user, but it is displayed (for verification) like this:\r\n\r\n![jtester tests 44 update testx txt](https://cloud.githubusercontent.com/assets/33978/8779760/9c8240ca-2eca-11e5-9ef6-ea2a2e8864dc.png)\r\n \r\nThe testers might verify this SHA to ensure they are testing the latest commit.\r\n\r\nThe SHA can be obtained using the information provided by the users IDE, the command line or we can adapt com_patchtester to show it in the list:\r\n\r\n![bildschirmfoto vom 2015 07 10 09 28 42](https://cloud.githubusercontent.com/assets/33978/8779757/97c0d9f2-2eca-11e5-85bf-e4df503bc59f.png)\r\n\r\nThe result of this change is that now every new commit to a PR will require all testers to resubmit their test results (!)\r\n\r\nUI wise This PR also moves the elements for testing in the issue view from the right \"module\" to a sliding panel to unclutter the UI.\r\n\r\nA comment box has been added to submit an additional comment and the test options have been removed from the comment box at the bottom.\r\n\r\nI also think we should report back the test results to the GitHub tracker as in #596 <del>but I'm quite unsure about the implementation...</del>see #695"},"comment":{"url":"https://api.github.com/repos/joomla/jissues/issues/comments/132279590","html_url":"https://github.com/joomla/jissues/pull/683#issuecomment-132279590","issue_url":"https://api.github.com/repos/joomla/jissues/issues/683","id":132279590,"user":{"login":"elkuku","id":33978,"avatar_url":"https://avatars.githubusercontent.com/u/33978?v=3","gravatar_id":"","url":"https://api.github.com/users/elkuku","html_url":"https://github.com/elkuku","followers_url":"https://api.github.com/users/elkuku/followers","following_url":"https://api.github.com/users/elkuku/following{/other_user}","gists_url":"https://api.github.com/users/elkuku/gists{/gist_id}","starred_url":"https://api.github.com/users/elkuku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elkuku/subscriptions","organizations_url":"https://api.github.com/users/elkuku/orgs","repos_url":"https://api.github.com/users/elkuku/repos","events_url":"https://api.github.com/users/elkuku/events{/privacy}","received_events_url":"https://api.github.com/users/elkuku/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T17:01:46Z","updated_at":"2015-08-18T17:01:46Z","body":"> hmm it looks like that it don't work with the sha / \"Please retest\" message?\r\n\r\nOK this will give me another round of headache :cry: \r\nProblem here is that the commits for a PR are not fetched if the PR gets added by a web hook...\r\nThis will require another 20+ lines of c&p from the CLI script where the commit history is fetched...\r\nI'll give that some thinking later today and post an update :wink: \r\n\r\n> The sha is also missed there.\r\n\r\nSame here :cry: \r\n\r\n> And the human test result is not on github?\r\n\r\nThis will start working after #695 :wink: \r\n\r\nI'll also do some thinking about the rest of your comments - thanks again for your input :)"}}