{"action":"created","issue":{"url":"https://api.github.com/repos/burzum/cakephp-html-purifier/issues/25","labels_url":"https://api.github.com/repos/burzum/cakephp-html-purifier/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/burzum/cakephp-html-purifier/issues/25/comments","events_url":"https://api.github.com/repos/burzum/cakephp-html-purifier/issues/25/events","html_url":"https://github.com/burzum/cakephp-html-purifier/pull/25","id":114130642,"number":25,"title":"Fixed some issues in the Behavior and updated 1.x branch to most recent lib version","user":{"login":"TJ-Compton","id":12659465,"avatar_url":"https://avatars.githubusercontent.com/u/12659465?v=3","gravatar_id":"","url":"https://api.github.com/users/TJ-Compton","html_url":"https://github.com/TJ-Compton","followers_url":"https://api.github.com/users/TJ-Compton/followers","following_url":"https://api.github.com/users/TJ-Compton/following{/other_user}","gists_url":"https://api.github.com/users/TJ-Compton/gists{/gist_id}","starred_url":"https://api.github.com/users/TJ-Compton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TJ-Compton/subscriptions","organizations_url":"https://api.github.com/users/TJ-Compton/orgs","repos_url":"https://api.github.com/users/TJ-Compton/repos","events_url":"https://api.github.com/users/TJ-Compton/events{/privacy}","received_events_url":"https://api.github.com/users/TJ-Compton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-29T19:42:08Z","updated_at":"2015-10-29T21:27:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/burzum/cakephp-html-purifier/pulls/25","html_url":"https://github.com/burzum/cakephp-html-purifier/pull/25","diff_url":"https://github.com/burzum/cakephp-html-purifier/pull/25.diff","patch_url":"https://github.com/burzum/cakephp-html-purifier/pull/25.patch"},"body":"Fixed an issue in HtmlPurifierBehavior where cleanFields was looping on an uninitialized variable, beforeValidate was checking for wrong callback value (afterSave), and added more callback options for when toinvoke cleanFields (all but beforeFind, beforeDelete, afterDelete now valid).\r\n\r\nAlso updated HTMLPurifier libs to 4.7, removed reference to version number from directory path for smoother updates in the future, and backported .travis.yml from the master branch."},"comment":{"url":"https://api.github.com/repos/burzum/cakephp-html-purifier/issues/comments/152333304","html_url":"https://github.com/burzum/cakephp-html-purifier/pull/25#issuecomment-152333304","issue_url":"https://api.github.com/repos/burzum/cakephp-html-purifier/issues/25","id":152333304,"user":{"login":"burzum","id":162789,"avatar_url":"https://avatars.githubusercontent.com/u/162789?v=3","gravatar_id":"","url":"https://api.github.com/users/burzum","html_url":"https://github.com/burzum","followers_url":"https://api.github.com/users/burzum/followers","following_url":"https://api.github.com/users/burzum/following{/other_user}","gists_url":"https://api.github.com/users/burzum/gists{/gist_id}","starred_url":"https://api.github.com/users/burzum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burzum/subscriptions","organizations_url":"https://api.github.com/users/burzum/orgs","repos_url":"https://api.github.com/users/burzum/repos","events_url":"https://api.github.com/users/burzum/events{/privacy}","received_events_url":"https://api.github.com/users/burzum/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T21:27:46Z","updated_at":"2015-10-29T21:27:46Z","body":"Hey, thank you for your contribution!\r\n\r\nJust one thing: I really dislike updating the library that way. We now have composer for some years and it has become nearly a standard way of installing dependencies.\r\n\r\nCould you please instead make a new PR *without* updating the HTMLPurifier lib, but instead *removing* it from the repo and *adding* it to composer.json?\r\n\r\nEdit: I've just noticed that I already have a composer.json which should already checkout the latest version of HTMLPurifier."}}