{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/ifraixedes/hugo-resources/pulls/2","id":53237688,"html_url":"https://github.com/ifraixedes/hugo-resources/pull/2","diff_url":"https://github.com/ifraixedes/hugo-resources/pull/2.diff","patch_url":"https://github.com/ifraixedes/hugo-resources/pull/2.patch","issue_url":"https://api.github.com/repos/ifraixedes/hugo-resources/issues/2","number":2,"state":"open","locked":false,"title":"Bhberson social short codes","user":{"login":"ifraixedes","id":1731633,"avatar_url":"https://avatars.githubusercontent.com/u/1731633?v=3","gravatar_id":"","url":"https://api.github.com/users/ifraixedes","html_url":"https://github.com/ifraixedes","followers_url":"https://api.github.com/users/ifraixedes/followers","following_url":"https://api.github.com/users/ifraixedes/following{/other_user}","gists_url":"https://api.github.com/users/ifraixedes/gists{/gist_id}","starred_url":"https://api.github.com/users/ifraixedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifraixedes/subscriptions","organizations_url":"https://api.github.com/users/ifraixedes/orgs","repos_url":"https://api.github.com/users/ifraixedes/repos","events_url":"https://api.github.com/users/ifraixedes/events{/privacy}","received_events_url":"https://api.github.com/users/ifraixedes/received_events","type":"User","site_admin":false},"body":"This PR overtake #1 to provide examples, provide more doc and fix issues that.\r\n\r\n@bhberson I would like to ask to discuss with you a few things:\r\n\r\n1. I couldn't make \"Pinterestes pinit\" shortcode works using [positional parameters](https://gohugo.io/extras/shortcodes/). The problem is that the option to use positional parameters call functions which are available in [Node or Page](https://gohugo.io/templates/variables/) so it crash to call them.\r\n2. Due the issue mentioned in (1) I would prefer not to have two options to use the shortcode, the implementation is simple and it's less confusing how to use them. I would follow the suggestion mentioned in [Creating your own shortcodes](https://gohugo.io/extras/shortcodes/#creating-your-own-shortcodes:10ef41a6c37b90d6a6452868d5ba00ba).\r\nIn this case it seems that the \"facebook share\" is fine to use a positional parameter and the rest are fine using named parameters which I like the checks that you have used to set or not the property.\r\n\r\nWhat do you think?","created_at":"2015-12-10T10:07:28Z","updated_at":"2015-12-10T10:07:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ifraixedes/hugo-resources/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ifraixedes/hugo-resources/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ifraixedes/hugo-resources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ifraixedes/hugo-resources/issues/2/comments","statuses_url":"https://api.github.com/repos/ifraixedes/hugo-resources/statuses/a6fe32cbdb966185de0968c1e768f38f978d898e","head":{"label":"ifraixedes:bhberson-social-short-codes","ref":"bhberson-social-short-codes","sha":"a6fe32cbdb966185de0968c1e768f38f978d898e","user":{"login":"ifraixedes","id":1731633,"avatar_url":"https://avatars.githubusercontent.com/u/1731633?v=3","gravatar_id":"","url":"https://api.github.com/users/ifraixedes","html_url":"https://github.com/ifraixedes","followers_url":"https://api.github.com/users/ifraixedes/followers","following_url":"https://api.github.com/users/ifraixedes/following{/other_user}","gists_url":"https://api.github.com/users/ifraixedes/gists{/gist_id}","starred_url":"https://api.github.com/users/ifraixedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifraixedes/subscriptions","organizations_url":"https://api.github.com/users/ifraixedes/orgs","repos_url":"https://api.github.com/users/ifraixedes/repos","events_url":"https://api.github.com/users/ifraixedes/events{/privacy}","received_events_url":"https://api.github.com/users/ifraixedes/received_events","type":"User","site_admin":false},"repo":{"id":47425480,"name":"hugo-resources","full_name":"ifraixedes/hugo-resources","owner":{"login":"ifraixedes","id":1731633,"avatar_url":"https://avatars.githubusercontent.com/u/1731633?v=3","gravatar_id":"","url":"https://api.github.com/users/ifraixedes","html_url":"https://github.com/ifraixedes","followers_url":"https://api.github.com/users/ifraixedes/followers","following_url":"https://api.github.com/users/ifraixedes/following{/other_user}","gists_url":"https://api.github.com/users/ifraixedes/gists{/gist_id}","starred_url":"https://api.github.com/users/ifraixedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifraixedes/subscriptions","organizations_url":"https://api.github.com/users/ifraixedes/orgs","repos_url":"https://api.github.com/users/ifraixedes/repos","events_url":"https://api.github.com/users/ifraixedes/events{/privacy}","received_events_url":"https://api.github.com/users/ifraixedes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ifraixedes/hugo-resources","description":"Generic resources as partials, shortcodes, etc. for Hugo static site generator (http://gohugo.io)","fork":false,"url":"https://api.github.com/repos/ifraixedes/hugo-resources","forks_url":"https://api.github.com/repos/ifraixedes/hugo-resources/forks","keys_url":"https://api.github.com/repos/ifraixedes/hugo-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifraixedes/hugo-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifraixedes/hugo-resources/teams","hooks_url":"https://api.github.com/repos/ifraixedes/hugo-resources/hooks","issue_events_url":"https://api.github.com/repos/ifraixedes/hugo-resources/issues/events{/number}","events_url":"https://api.github.com/repos/ifraixedes/hugo-resources/events","assignees_url":"https://api.github.com/repos/ifraixedes/hugo-resources/assignees{/user}","branches_url":"https://api.github.com/repos/ifraixedes/hugo-resources/branches{/branch}","tags_url":"https://api.github.com/repos/ifraixedes/hugo-resources/tags","blobs_url":"https://api.github.com/repos/ifraixedes/hugo-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifraixedes/hugo-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifraixedes/hugo-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifraixedes/hugo-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifraixedes/hugo-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/ifraixedes/hugo-resources/languages","stargazers_url":"https://api.github.com/repos/ifraixedes/hugo-resources/stargazers","contributors_url":"https://api.github.com/repos/ifraixedes/hugo-resources/contributors","subscribers_url":"https://api.github.com/repos/ifraixedes/hugo-resources/subscribers","subscription_url":"https://api.github.com/repos/ifraixedes/hugo-resources/subscription","commits_url":"https://api.github.com/repos/ifraixedes/hugo-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifraixedes/hugo-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifraixedes/hugo-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifraixedes/hugo-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifraixedes/hugo-resources/contents/{+path}","compare_url":"https://api.github.com/repos/ifraixedes/hugo-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifraixedes/hugo-resources/merges","archive_url":"https://api.github.com/repos/ifraixedes/hugo-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifraixedes/hugo-resources/downloads","issues_url":"https://api.github.com/repos/ifraixedes/hugo-resources/issues{/number}","pulls_url":"https://api.github.com/repos/ifraixedes/hugo-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/ifraixedes/hugo-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/ifraixedes/hugo-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifraixedes/hugo-resources/labels{/name}","releases_url":"https://api.github.com/repos/ifraixedes/hugo-resources/releases{/id}","created_at":"2015-12-04T19:48:45Z","updated_at":"2015-12-10T05:34:28Z","pushed_at":"2015-12-10T09:58:40Z","git_url":"git://github.com/ifraixedes/hugo-resources.git","ssh_url":"git@github.com:ifraixedes/hugo-resources.git","clone_url":"https://github.com/ifraixedes/hugo-resources.git","svn_url":"https://github.com/ifraixedes/hugo-resources","homepage":null,"size":13,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"ifraixedes:master","ref":"master","sha":"a916b078a857abcbaef7b3bcd7a3e1bab4e61913","user":{"login":"ifraixedes","id":1731633,"avatar_url":"https://avatars.githubusercontent.com/u/1731633?v=3","gravatar_id":"","url":"https://api.github.com/users/ifraixedes","html_url":"https://github.com/ifraixedes","followers_url":"https://api.github.com/users/ifraixedes/followers","following_url":"https://api.github.com/users/ifraixedes/following{/other_user}","gists_url":"https://api.github.com/users/ifraixedes/gists{/gist_id}","starred_url":"https://api.github.com/users/ifraixedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifraixedes/subscriptions","organizations_url":"https://api.github.com/users/ifraixedes/orgs","repos_url":"https://api.github.com/users/ifraixedes/repos","events_url":"https://api.github.com/users/ifraixedes/events{/privacy}","received_events_url":"https://api.github.com/users/ifraixedes/received_events","type":"User","site_admin":false},"repo":{"id":47425480,"name":"hugo-resources","full_name":"ifraixedes/hugo-resources","owner":{"login":"ifraixedes","id":1731633,"avatar_url":"https://avatars.githubusercontent.com/u/1731633?v=3","gravatar_id":"","url":"https://api.github.com/users/ifraixedes","html_url":"https://github.com/ifraixedes","followers_url":"https://api.github.com/users/ifraixedes/followers","following_url":"https://api.github.com/users/ifraixedes/following{/other_user}","gists_url":"https://api.github.com/users/ifraixedes/gists{/gist_id}","starred_url":"https://api.github.com/users/ifraixedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifraixedes/subscriptions","organizations_url":"https://api.github.com/users/ifraixedes/orgs","repos_url":"https://api.github.com/users/ifraixedes/repos","events_url":"https://api.github.com/users/ifraixedes/events{/privacy}","received_events_url":"https://api.github.com/users/ifraixedes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ifraixedes/hugo-resources","description":"Generic resources as partials, shortcodes, etc. for Hugo static site generator (http://gohugo.io)","fork":false,"url":"https://api.github.com/repos/ifraixedes/hugo-resources","forks_url":"https://api.github.com/repos/ifraixedes/hugo-resources/forks","keys_url":"https://api.github.com/repos/ifraixedes/hugo-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifraixedes/hugo-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifraixedes/hugo-resources/teams","hooks_url":"https://api.github.com/repos/ifraixedes/hugo-resources/hooks","issue_events_url":"https://api.github.com/repos/ifraixedes/hugo-resources/issues/events{/number}","events_url":"https://api.github.com/repos/ifraixedes/hugo-resources/events","assignees_url":"https://api.github.com/repos/ifraixedes/hugo-resources/assignees{/user}","branches_url":"https://api.github.com/repos/ifraixedes/hugo-resources/branches{/branch}","tags_url":"https://api.github.com/repos/ifraixedes/hugo-resources/tags","blobs_url":"https://api.github.com/repos/ifraixedes/hugo-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifraixedes/hugo-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifraixedes/hugo-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifraixedes/hugo-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifraixedes/hugo-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/ifraixedes/hugo-resources/languages","stargazers_url":"https://api.github.com/repos/ifraixedes/hugo-resources/stargazers","contributors_url":"https://api.github.com/repos/ifraixedes/hugo-resources/contributors","subscribers_url":"https://api.github.com/repos/ifraixedes/hugo-resources/subscribers","subscription_url":"https://api.github.com/repos/ifraixedes/hugo-resources/subscription","commits_url":"https://api.github.com/repos/ifraixedes/hugo-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifraixedes/hugo-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifraixedes/hugo-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifraixedes/hugo-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifraixedes/hugo-resources/contents/{+path}","compare_url":"https://api.github.com/repos/ifraixedes/hugo-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifraixedes/hugo-resources/merges","archive_url":"https://api.github.com/repos/ifraixedes/hugo-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifraixedes/hugo-resources/downloads","issues_url":"https://api.github.com/repos/ifraixedes/hugo-resources/issues{/number}","pulls_url":"https://api.github.com/repos/ifraixedes/hugo-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/ifraixedes/hugo-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/ifraixedes/hugo-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifraixedes/hugo-resources/labels{/name}","releases_url":"https://api.github.com/repos/ifraixedes/hugo-resources/releases{/id}","created_at":"2015-12-04T19:48:45Z","updated_at":"2015-12-10T05:34:28Z","pushed_at":"2015-12-10T09:58:40Z","git_url":"git://github.com/ifraixedes/hugo-resources.git","ssh_url":"git@github.com:ifraixedes/hugo-resources.git","clone_url":"https://github.com/ifraixedes/hugo-resources.git","svn_url":"https://github.com/ifraixedes/hugo-resources","homepage":null,"size":13,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ifraixedes/hugo-resources/pulls/2"},"html":{"href":"https://github.com/ifraixedes/hugo-resources/pull/2"},"issue":{"href":"https://api.github.com/repos/ifraixedes/hugo-resources/issues/2"},"comments":{"href":"https://api.github.com/repos/ifraixedes/hugo-resources/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ifraixedes/hugo-resources/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ifraixedes/hugo-resources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ifraixedes/hugo-resources/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ifraixedes/hugo-resources/statuses/a6fe32cbdb966185de0968c1e768f38f978d898e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":96,"deletions":10,"changed_files":13}}