{"action":"created","issue":{"url":"https://api.github.com/repos/gliderlabs/logspout/issues/61","labels_url":"https://api.github.com/repos/gliderlabs/logspout/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/gliderlabs/logspout/issues/61/comments","events_url":"https://api.github.com/repos/gliderlabs/logspout/issues/61/events","html_url":"https://github.com/gliderlabs/logspout/pull/61","id":63903072,"number":61,"title":"Kafka logspout adapter","user":{"login":"dylanmei","id":109874,"avatar_url":"https://avatars.githubusercontent.com/u/109874?v=3","gravatar_id":"","url":"https://api.github.com/users/dylanmei","html_url":"https://github.com/dylanmei","followers_url":"https://api.github.com/users/dylanmei/followers","following_url":"https://api.github.com/users/dylanmei/following{/other_user}","gists_url":"https://api.github.com/users/dylanmei/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanmei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanmei/subscriptions","organizations_url":"https://api.github.com/users/dylanmei/orgs","repos_url":"https://api.github.com/users/dylanmei/repos","events_url":"https://api.github.com/users/dylanmei/events{/privacy}","received_events_url":"https://api.github.com/users/dylanmei/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2015-03-24T04:57:24Z","updated_at":"2015-03-24T15:07:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gliderlabs/logspout/pulls/61","html_url":"https://github.com/gliderlabs/logspout/pull/61","diff_url":"https://github.com/gliderlabs/logspout/pull/61.diff","patch_url":"https://github.com/gliderlabs/logspout/pull/61.patch"},"body":"This is a cut of the Kafka adapter/module discussed in #35.\r\n\r\nSome things to discuss:\r\n\r\n- I've overloaded route \"address\" with multiple brokers separated by \",\" followed by a \"/\" and a Kafka topic. (i.e., broker1:9020,broker2:9020/topic) The topic is so important here that it doesn't seem to fit well as a route \"option\".\r\n- There are tons of Kafka producer options that can be added. I've setup \"compression codec\" but not gone any further yet.\r\n- `adapters/raw` has `RAW_FORMAT`, which is a go template, and `adapters/syslog` has `SYSLOG_FORMAT` which is very much not a go template. Wondering if `KAFKA_FORMAT` is actually appropriate.\r\n- Master branch is completely unusable for me, not sure if it's just me yet. The magic of `make dev` is gone. Most of what is in this PR worked great before the 'adapters' change, but I can't expect a merge until things settle down.\r\n\r\nHappy to make changes, move it, etc."},"comment":{"url":"https://api.github.com/repos/gliderlabs/logspout/issues/comments/85543972","html_url":"https://github.com/gliderlabs/logspout/pull/61#issuecomment-85543972","issue_url":"https://api.github.com/repos/gliderlabs/logspout/issues/61","id":85543972,"user":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=3","gravatar_id":"","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T15:07:22Z","updated_at":"2015-03-24T15:07:22Z","body":"Yeah unless we can get sarama to support a public API for key value properties (which I suspect they might internally), I'd say we should just point to sarama config docs as well as Kafka config docs."}}