{"action":"created","issue":{"url":"https://api.github.com/repos/mdunisch/lololodash/issues/15","labels_url":"https://api.github.com/repos/mdunisch/lololodash/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/mdunisch/lololodash/issues/15/comments","events_url":"https://api.github.com/repos/mdunisch/lololodash/issues/15/events","html_url":"https://github.com/mdunisch/lololodash/pull/15","id":54697999,"number":15,"title":"Make Todo-Template run/verify better conform to problem description","user":{"login":"tdd","id":3752,"avatar_url":"https://avatars.githubusercontent.com/u/3752?v=3","gravatar_id":"","url":"https://api.github.com/users/tdd","html_url":"https://github.com/tdd","followers_url":"https://api.github.com/users/tdd/followers","following_url":"https://api.github.com/users/tdd/following{/other_user}","gists_url":"https://api.github.com/users/tdd/gists{/gist_id}","starred_url":"https://api.github.com/users/tdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdd/subscriptions","organizations_url":"https://api.github.com/users/tdd/orgs","repos_url":"https://api.github.com/users/tdd/repos","events_url":"https://api.github.com/users/tdd/events{/privacy}","received_events_url":"https://api.github.com/users/tdd/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-18T14:24:42Z","updated_at":"2015-02-01T12:38:01Z","closed_at":"2015-02-01T12:36:19Z","pull_request":{"url":"https://api.github.com/repos/mdunisch/lololodash/pulls/15","html_url":"https://github.com/mdunisch/lololodash/pull/15","diff_url":"https://github.com/mdunisch/lololodash/pull/15.diff","patch_url":"https://github.com/mdunisch/lololodash/pull/15.patch"},"body":"Hi there!\r\n\r\nThe problem desc for 9_todo_template states we get pure JSON as input, with dates as ISO Strings. But the exercice code sends Moment instances in, which will not work on any submitted code that assumes the passed info is indeed strings, and doesn't attempt to convert it back to `Date`.\r\n\r\nFor instance, the most performant solution here would be to compute the ISO String for \"in 2 days\" once and for all, and use `String` comparison after that, ISO Strings being lexically comparable. No need to convert the passed `todo.date` back as a `Date` object.\r\n\r\nThere's a masked requirement on solution implementation here, that favors less-performant solutions to boot.\r\n\r\nI just changed the exercise code so that it does indeed pass pure JSON in, as per the problem description, so as not to limit solution code.\r\n\r\nCheers!"},"comment":{"url":"https://api.github.com/repos/mdunisch/lololodash/issues/comments/72363122","html_url":"https://github.com/mdunisch/lololodash/pull/15#issuecomment-72363122","issue_url":"https://api.github.com/repos/mdunisch/lololodash/issues/15","id":72363122,"user":{"login":"mdunisch","id":5655305,"avatar_url":"https://avatars.githubusercontent.com/u/5655305?v=3","gravatar_id":"","url":"https://api.github.com/users/mdunisch","html_url":"https://github.com/mdunisch","followers_url":"https://api.github.com/users/mdunisch/followers","following_url":"https://api.github.com/users/mdunisch/following{/other_user}","gists_url":"https://api.github.com/users/mdunisch/gists{/gist_id}","starred_url":"https://api.github.com/users/mdunisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdunisch/subscriptions","organizations_url":"https://api.github.com/users/mdunisch/orgs","repos_url":"https://api.github.com/users/mdunisch/repos","events_url":"https://api.github.com/users/mdunisch/events{/privacy}","received_events_url":"https://api.github.com/users/mdunisch/received_events","type":"User","site_admin":false},"created_at":"2015-02-01T12:38:01Z","updated_at":"2015-02-01T12:38:01Z","body":"thank you @tdd\r\n\r\nSorry that it take so long - I'm very busy right now but I really appreciate your time invest in this project!"}}