{"action":"opened","number":13519,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/13519","id":27989188,"html_url":"https://github.com/symfony/symfony/pull/13519","diff_url":"https://github.com/symfony/symfony/pull/13519.diff","patch_url":"https://github.com/symfony/symfony/pull/13519.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/13519","number":13519,"state":"open","locked":false,"title":"[DependencyInjection] fixed service resolution for factories","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #13455\r\n| License       | MIT\r\n| Doc PR        | n/a\r\n\r\nIn the service container, factories can be defined with a class/method pair or a service/method pair.\r\n\r\nThe class or service value can be a container parameter, but it was not supported everywhere, this PR fixes that.\r\n\r\nNote that the method can never be a container parameter as this is supported nowhere in the current code, so this has not been changed.\r\n\r\nAnother PR will fix the 2.6 way of configuring a factory.\r\n","created_at":"2015-01-25T08:11:31Z","updated_at":"2015-01-25T08:11:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/13519/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/13519/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/13519/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/76ccf15eb40fe0e65b95ce3eab2eae5bdad1a9a2","head":{"label":"fabpot:resolve-factory-parameters","ref":"resolve-factory-parameters","sha":"76ccf15eb40fe0e65b95ce3eab2eae5bdad1a9a2","user":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"repo":{"id":458135,"name":"symfony","full_name":"fabpot/symfony","owner":{"login":"fabpot","id":47313,"avatar_url":"https://avatars.githubusercontent.com/u/47313?v=3","gravatar_id":"","url":"https://api.github.com/users/fabpot","html_url":"https://github.com/fabpot","followers_url":"https://api.github.com/users/fabpot/followers","following_url":"https://api.github.com/users/fabpot/following{/other_user}","gists_url":"https://api.github.com/users/fabpot/gists{/gist_id}","starred_url":"https://api.github.com/users/fabpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabpot/subscriptions","organizations_url":"https://api.github.com/users/fabpot/orgs","repos_url":"https://api.github.com/users/fabpot/repos","events_url":"https://api.github.com/users/fabpot/events{/privacy}","received_events_url":"https://api.github.com/users/fabpot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabpot/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/fabpot/symfony","forks_url":"https://api.github.com/repos/fabpot/symfony/forks","keys_url":"https://api.github.com/repos/fabpot/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabpot/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabpot/symfony/teams","hooks_url":"https://api.github.com/repos/fabpot/symfony/hooks","issue_events_url":"https://api.github.com/repos/fabpot/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/fabpot/symfony/events","assignees_url":"https://api.github.com/repos/fabpot/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/fabpot/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/fabpot/symfony/tags","blobs_url":"https://api.github.com/repos/fabpot/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabpot/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabpot/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabpot/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabpot/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/fabpot/symfony/languages","stargazers_url":"https://api.github.com/repos/fabpot/symfony/stargazers","contributors_url":"https://api.github.com/repos/fabpot/symfony/contributors","subscribers_url":"https://api.github.com/repos/fabpot/symfony/subscribers","subscription_url":"https://api.github.com/repos/fabpot/symfony/subscription","commits_url":"https://api.github.com/repos/fabpot/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabpot/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabpot/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabpot/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/fabpot/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/fabpot/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabpot/symfony/merges","archive_url":"https://api.github.com/repos/fabpot/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabpot/symfony/downloads","issues_url":"https://api.github.com/repos/fabpot/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/fabpot/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/fabpot/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/fabpot/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabpot/symfony/labels{/name}","releases_url":"https://api.github.com/repos/fabpot/symfony/releases{/id}","created_at":"2010-01-04T15:41:06Z","updated_at":"2015-01-25T03:50:02Z","pushed_at":"2015-01-25T08:07:53Z","git_url":"git://github.com/fabpot/symfony.git","ssh_url":"git@github.com:fabpot/symfony.git","clone_url":"https://github.com/fabpot/symfony.git","svn_url":"https://github.com/fabpot/symfony","homepage":"http://symfony.com/","size":57384,"stargazers_count":327,"watchers_count":327,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":0,"forks":47,"open_issues":0,"watchers":327,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"51983d058333d4d28ad107b463691db58bc28575","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-01-25T05:59:28Z","pushed_at":"2015-01-25T05:59:28Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":188435,"stargazers_count":9561,"watchers_count":9561,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3730,"mirror_url":null,"open_issues_count":784,"forks":3730,"open_issues":784,"watchers":9561,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13519"},"html":{"href":"https://github.com/symfony/symfony/pull/13519"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/13519"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/13519/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13519/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13519/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/76ccf15eb40fe0e65b95ce3eab2eae5bdad1a9a2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":32,"deletions":11,"changed_files":8}}