{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/osquery/issues/1589","labels_url":"https://api.github.com/repos/facebook/osquery/issues/1589/labels{/name}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/1589/comments","events_url":"https://api.github.com/repos/facebook/osquery/issues/1589/events","html_url":"https://github.com/facebook/osquery/pull/1589","id":112046289,"number":1589,"title":"[Fix #1578] Support OPENSSL_NO_SSV3","user":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/osquery/labels/os%20x","name":"os x","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-18T22:28:06Z","updated_at":"2015-10-19T02:44:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/1589","html_url":"https://github.com/facebook/osquery/pull/1589","diff_url":"https://github.com/facebook/osquery/pull/1589.diff","patch_url":"https://github.com/facebook/osquery/pull/1589.patch"},"body":"1. Check for SSLv3 methods in the OpenSSL static library implementation.\r\n2. If SSLv3 methods are not included, add basic declarations for Boost's ASIO library.\r\n3. Since we are removing support for SSLv3 explicitly using `OPENSSL_NO_SSLV3`, and since ASIO does not respect this feature selection, we must add no-op symbols for several SSLv3 methods."},"comment":{"url":"https://api.github.com/repos/facebook/osquery/issues/comments/149080986","html_url":"https://github.com/facebook/osquery/pull/1589#issuecomment-149080986","issue_url":"https://api.github.com/repos/facebook/osquery/issues/1589","id":149080986,"user":{"login":"sharvilshah","id":819943,"avatar_url":"https://avatars.githubusercontent.com/u/819943?v=3","gravatar_id":"","url":"https://api.github.com/users/sharvilshah","html_url":"https://github.com/sharvilshah","followers_url":"https://api.github.com/users/sharvilshah/followers","following_url":"https://api.github.com/users/sharvilshah/following{/other_user}","gists_url":"https://api.github.com/users/sharvilshah/gists{/gist_id}","starred_url":"https://api.github.com/users/sharvilshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharvilshah/subscriptions","organizations_url":"https://api.github.com/users/sharvilshah/orgs","repos_url":"https://api.github.com/users/sharvilshah/repos","events_url":"https://api.github.com/users/sharvilshah/events{/privacy}","received_events_url":"https://api.github.com/users/sharvilshah/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T02:44:28Z","updated_at":"2015-10-19T02:44:28Z","body":"Spoke a little too soon, linker errors:\r\n\r\n```\r\nUndefined symbols for architecture x86_64:\r\n  \"_SSLv2_client_method\", referenced from:\r\n      boost::asio::ssl::context::context(boost::asio::ssl::context_base::method) in libcppnetlib-client-connections.a(client.cpp.o)\r\n  \"_SSLv2_method\", referenced from:\r\n      boost::asio::ssl::context::context(boost::asio::ssl::context_base::method) in libcppnetlib-client-connections.a(client.cpp.o)\r\n  \"_SSLv2_server_method\", referenced from:\r\n      boost::asio::ssl::context::context(boost::asio::ssl::context_base::method) in libcppnetlib-client-connections.a(client.cpp.o)\r\nld: symbol(s) not found for architecture x86_64\r\n```\r\n\r\nDo you think we still need to define `OPENSSL_NO_SSL2`?"}}