{"action":"created","comment":{"url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/comments/44338104","id":44338104,"diff_hunk":"@@ -63,6 +63,12 @@ protected function getConfig(array $config)\n      */\n     protected function getAdapter(array $config)\n     {\n-        return new Local($config['path']);\n+        // Pull parameters from config and set defaults for optional values\n+        $path = $config['path'];\n+        $writeFlags = isset($config['write_flags']) ? $config['write_flags'] : LOCK_EX;","path":"src/Adapters/LocalConnector.php","position":16,"original_position":16,"commit_id":"afeff844fa9e7455081de2eb521488b8d16b112e","original_commit_id":"afeff844fa9e7455081de2eb521488b8d16b112e","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"you should probably use array_get in all these places","created_at":"2015-11-09T21:53:23Z","updated_at":"2015-11-09T21:53:23Z","html_url":"https://github.com/GrahamCampbell/Laravel-Flysystem/pull/66#discussion_r44338104","pull_request_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/comments/44338104"},"html":{"href":"https://github.com/GrahamCampbell/Laravel-Flysystem/pull/66#discussion_r44338104"},"pull_request":{"href":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/66","id":50170057,"html_url":"https://github.com/GrahamCampbell/Laravel-Flysystem/pull/66","diff_url":"https://github.com/GrahamCampbell/Laravel-Flysystem/pull/66.diff","patch_url":"https://github.com/GrahamCampbell/Laravel-Flysystem/pull/66.patch","issue_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/66","number":66,"state":"open","locked":false,"title":"Allow for greater configuration of local connections","user":{"login":"darrylkuhn","id":3458313,"avatar_url":"https://avatars.githubusercontent.com/u/3458313?v=3","gravatar_id":"","url":"https://api.github.com/users/darrylkuhn","html_url":"https://github.com/darrylkuhn","followers_url":"https://api.github.com/users/darrylkuhn/followers","following_url":"https://api.github.com/users/darrylkuhn/following{/other_user}","gists_url":"https://api.github.com/users/darrylkuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/darrylkuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrylkuhn/subscriptions","organizations_url":"https://api.github.com/users/darrylkuhn/orgs","repos_url":"https://api.github.com/users/darrylkuhn/repos","events_url":"https://api.github.com/users/darrylkuhn/events{/privacy}","received_events_url":"https://api.github.com/users/darrylkuhn/received_events","type":"User","site_admin":false},"body":"In my case in particular I wanted to be able to specify the default file/directory umask. Couldn't see an easy way of doing that so I'm made this patch. Change is backward compatible. Simply allows callers to pass config options via .env / conf file, defaults are used if not explicitly set in config.","created_at":"2015-11-09T20:03:59Z","updated_at":"2015-11-09T21:53:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ba3e2b3eb78aad0982e5b1bfd49170ac8966f84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/66/commits","review_comments_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/66/comments","review_comment_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/66/comments","statuses_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/statuses/afeff844fa9e7455081de2eb521488b8d16b112e","head":{"label":"darrylkuhn:master","ref":"master","sha":"afeff844fa9e7455081de2eb521488b8d16b112e","user":{"login":"darrylkuhn","id":3458313,"avatar_url":"https://avatars.githubusercontent.com/u/3458313?v=3","gravatar_id":"","url":"https://api.github.com/users/darrylkuhn","html_url":"https://github.com/darrylkuhn","followers_url":"https://api.github.com/users/darrylkuhn/followers","following_url":"https://api.github.com/users/darrylkuhn/following{/other_user}","gists_url":"https://api.github.com/users/darrylkuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/darrylkuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrylkuhn/subscriptions","organizations_url":"https://api.github.com/users/darrylkuhn/orgs","repos_url":"https://api.github.com/users/darrylkuhn/repos","events_url":"https://api.github.com/users/darrylkuhn/events{/privacy}","received_events_url":"https://api.github.com/users/darrylkuhn/received_events","type":"User","site_admin":false},"repo":{"id":45709202,"name":"Laravel-Flysystem","full_name":"darrylkuhn/Laravel-Flysystem","owner":{"login":"darrylkuhn","id":3458313,"avatar_url":"https://avatars.githubusercontent.com/u/3458313?v=3","gravatar_id":"","url":"https://api.github.com/users/darrylkuhn","html_url":"https://github.com/darrylkuhn","followers_url":"https://api.github.com/users/darrylkuhn/followers","following_url":"https://api.github.com/users/darrylkuhn/following{/other_user}","gists_url":"https://api.github.com/users/darrylkuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/darrylkuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrylkuhn/subscriptions","organizations_url":"https://api.github.com/users/darrylkuhn/orgs","repos_url":"https://api.github.com/users/darrylkuhn/repos","events_url":"https://api.github.com/users/darrylkuhn/events{/privacy}","received_events_url":"https://api.github.com/users/darrylkuhn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darrylkuhn/Laravel-Flysystem","description":"A Flysystem bridge for Laravel 5","fork":true,"url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem","forks_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/forks","keys_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/teams","hooks_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/hooks","issue_events_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/issues/events{/number}","events_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/events","assignees_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/assignees{/user}","branches_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/branches{/branch}","tags_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/tags","blobs_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/statuses/{sha}","languages_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/languages","stargazers_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/stargazers","contributors_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/contributors","subscribers_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/subscribers","subscription_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/subscription","commits_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/contents/{+path}","compare_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/merges","archive_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/downloads","issues_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/issues{/number}","pulls_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/pulls{/number}","milestones_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/milestones{/number}","notifications_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/labels{/name}","releases_url":"https://api.github.com/repos/darrylkuhn/Laravel-Flysystem/releases{/id}","created_at":"2015-11-06T21:38:01Z","updated_at":"2015-11-06T21:38:02Z","pushed_at":"2015-11-09T20:07:40Z","git_url":"git://github.com/darrylkuhn/Laravel-Flysystem.git","ssh_url":"git@github.com:darrylkuhn/Laravel-Flysystem.git","clone_url":"https://github.com/darrylkuhn/Laravel-Flysystem.git","svn_url":"https://github.com/darrylkuhn/Laravel-Flysystem","homepage":"https://gjcampbell.co.uk/","size":551,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GrahamCampbell:master","ref":"master","sha":"1d65d20c40586aa9d18e9133c784c441d7acd9b1","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"repo":{"id":15766264,"name":"Laravel-Flysystem","full_name":"GrahamCampbell/Laravel-Flysystem","owner":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GrahamCampbell/Laravel-Flysystem","description":"A Flysystem bridge for Laravel 5","fork":false,"url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem","forks_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/forks","keys_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/teams","hooks_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/hooks","issue_events_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/events{/number}","events_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/events","assignees_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/assignees{/user}","branches_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/branches{/branch}","tags_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/tags","blobs_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/git/refs{/sha}","trees_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/statuses/{sha}","languages_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/languages","stargazers_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/stargazers","contributors_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/contributors","subscribers_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/subscribers","subscription_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/subscription","commits_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/commits{/sha}","git_commits_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/git/commits{/sha}","comments_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/comments{/number}","issue_comment_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/comments{/number}","contents_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/contents/{+path}","compare_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/merges","archive_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/downloads","issues_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues{/number}","pulls_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls{/number}","milestones_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/milestones{/number}","notifications_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/labels{/name}","releases_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/releases{/id}","created_at":"2014-01-09T12:35:17Z","updated_at":"2015-11-09T08:42:15Z","pushed_at":"2015-11-09T20:07:41Z","git_url":"git://github.com/GrahamCampbell/Laravel-Flysystem.git","ssh_url":"git@github.com:GrahamCampbell/Laravel-Flysystem.git","clone_url":"https://github.com/GrahamCampbell/Laravel-Flysystem.git","svn_url":"https://github.com/GrahamCampbell/Laravel-Flysystem","homepage":"https://gjcampbell.co.uk/","size":1587,"stargazers_count":190,"watchers_count":190,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":1,"forks":40,"open_issues":1,"watchers":190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/66"},"html":{"href":"https://github.com/GrahamCampbell/Laravel-Flysystem/pull/66"},"issue":{"href":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/66"},"comments":{"href":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/GrahamCampbell/Laravel-Flysystem/statuses/afeff844fa9e7455081de2eb521488b8d16b112e"}}}}