{"action":"created","comment":{"url":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/comments/32093106","id":32093106,"diff_hunk":"@@ -6,13 +6,35 @@\n  * @param <Type> return type of getValue()\n  */\n public abstract class DataValue<Type> {\n-\n+\tprivate boolean isNull;\n+\t\n \tpublic abstract Type getValue();\n \tpublic abstract String toString();\n-\n+\t\n \t@Override\n-\tpublic abstract boolean equals(Object obj);\n+\tpublic boolean equals(Object obj) {\n+\t\tif (!(obj instanceof DataValue)) {\n+\t\t\treturn false;\n+\t\t}\n+\t\tif (this.getClass() != obj.getClass()) {\n+\t\t\treturn false;\n+\t\t}\n+\t\tif (isNull || ((DataValue) obj).isNull()) {\n+\t\t\treturn false;\n+\t\t}\n+\t\treturn doEquals(obj);\n+\t}\n \n \t@Override\n \tpublic abstract int hashCode();\n+\t\n+\tpublic boolean isNull() {\n+\t\treturn isNull;\n+\t}\n+\t\n+\tprotected void setNull(boolean val) {\n+\t\tisNull = val;\n+\t}\n+\t\n+\tprotected abstract boolean doEquals(Object obj);","path":"src/main/java/model/data/value/DataValue.java","position":37,"original_position":37,"commit_id":"8fa57cf73b00f443270eb122b7ec6ad95c815df7","original_commit_id":"8fa57cf73b00f443270eb122b7ec6ad95c815df7","user":{"login":"Boudewijn26","id":2896917,"avatar_url":"https://avatars.githubusercontent.com/u/2896917?v=3","gravatar_id":"","url":"https://api.github.com/users/Boudewijn26","html_url":"https://github.com/Boudewijn26","followers_url":"https://api.github.com/users/Boudewijn26/followers","following_url":"https://api.github.com/users/Boudewijn26/following{/other_user}","gists_url":"https://api.github.com/users/Boudewijn26/gists{/gist_id}","starred_url":"https://api.github.com/users/Boudewijn26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Boudewijn26/subscriptions","organizations_url":"https://api.github.com/users/Boudewijn26/orgs","repos_url":"https://api.github.com/users/Boudewijn26/repos","events_url":"https://api.github.com/users/Boudewijn26/events{/privacy}","received_events_url":"https://api.github.com/users/Boudewijn26/received_events","type":"User","site_admin":false},"body":"Hier ook?","created_at":"2015-06-10T07:13:28Z","updated_at":"2015-06-10T07:13:28Z","html_url":"https://github.com/clanghout/Health-Informatics-3/pull/169#discussion_r32093106","pull_request_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/comments/32093106"},"html":{"href":"https://github.com/clanghout/Health-Informatics-3/pull/169#discussion_r32093106"},"pull_request":{"href":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/169","id":37296045,"html_url":"https://github.com/clanghout/Health-Informatics-3/pull/169","diff_url":"https://github.com/clanghout/Health-Informatics-3/pull/169.diff","patch_url":"https://github.com/clanghout/Health-Informatics-3/pull/169.patch","issue_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/issues/169","number":169,"state":"open","locked":false,"title":"Null values","user":{"login":"louisgosschalk","id":6196430,"avatar_url":"https://avatars.githubusercontent.com/u/6196430?v=3","gravatar_id":"","url":"https://api.github.com/users/louisgosschalk","html_url":"https://github.com/louisgosschalk","followers_url":"https://api.github.com/users/louisgosschalk/followers","following_url":"https://api.github.com/users/louisgosschalk/following{/other_user}","gists_url":"https://api.github.com/users/louisgosschalk/gists{/gist_id}","starred_url":"https://api.github.com/users/louisgosschalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louisgosschalk/subscriptions","organizations_url":"https://api.github.com/users/louisgosschalk/orgs","repos_url":"https://api.github.com/users/louisgosschalk/repos","events_url":"https://api.github.com/users/louisgosschalk/events{/privacy}","received_events_url":"https://api.github.com/users/louisgosschalk/received_events","type":"User","site_admin":false},"body":"Minimale code herhaling en correcte afhandeling van compare tussen null\nen 0","created_at":"2015-06-09T20:29:07Z","updated_at":"2015-06-10T07:13:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d849d3dd26976220cc8a6ae050e549d3289bc55b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/169/commits","review_comments_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/169/comments","review_comment_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/issues/169/comments","statuses_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/statuses/8fa57cf73b00f443270eb122b7ec6ad95c815df7","head":{"label":"clanghout:null-values","ref":"null-values","sha":"8fa57cf73b00f443270eb122b7ec6ad95c815df7","user":{"login":"clanghout","id":5969237,"avatar_url":"https://avatars.githubusercontent.com/u/5969237?v=3","gravatar_id":"","url":"https://api.github.com/users/clanghout","html_url":"https://github.com/clanghout","followers_url":"https://api.github.com/users/clanghout/followers","following_url":"https://api.github.com/users/clanghout/following{/other_user}","gists_url":"https://api.github.com/users/clanghout/gists{/gist_id}","starred_url":"https://api.github.com/users/clanghout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clanghout/subscriptions","organizations_url":"https://api.github.com/users/clanghout/orgs","repos_url":"https://api.github.com/users/clanghout/repos","events_url":"https://api.github.com/users/clanghout/events{/privacy}","received_events_url":"https://api.github.com/users/clanghout/received_events","type":"User","site_admin":false},"repo":{"id":34447605,"name":"Health-Informatics-3","full_name":"clanghout/Health-Informatics-3","owner":{"login":"clanghout","id":5969237,"avatar_url":"https://avatars.githubusercontent.com/u/5969237?v=3","gravatar_id":"","url":"https://api.github.com/users/clanghout","html_url":"https://github.com/clanghout","followers_url":"https://api.github.com/users/clanghout/followers","following_url":"https://api.github.com/users/clanghout/following{/other_user}","gists_url":"https://api.github.com/users/clanghout/gists{/gist_id}","starred_url":"https://api.github.com/users/clanghout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clanghout/subscriptions","organizations_url":"https://api.github.com/users/clanghout/orgs","repos_url":"https://api.github.com/users/clanghout/repos","events_url":"https://api.github.com/users/clanghout/events{/privacy}","received_events_url":"https://api.github.com/users/clanghout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clanghout/Health-Informatics-3","description":"","fork":false,"url":"https://api.github.com/repos/clanghout/Health-Informatics-3","forks_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/forks","keys_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/teams","hooks_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/hooks","issue_events_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/issues/events{/number}","events_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/events","assignees_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/assignees{/user}","branches_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/branches{/branch}","tags_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/tags","blobs_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/statuses/{sha}","languages_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/languages","stargazers_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/stargazers","contributors_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/contributors","subscribers_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/subscribers","subscription_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/subscription","commits_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/contents/{+path}","compare_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/merges","archive_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/downloads","issues_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/issues{/number}","pulls_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls{/number}","milestones_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/milestones{/number}","notifications_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/labels{/name}","releases_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/releases{/id}","created_at":"2015-04-23T09:44:17Z","updated_at":"2015-05-28T09:00:34Z","pushed_at":"2015-06-10T07:07:55Z","git_url":"git://github.com/clanghout/Health-Informatics-3.git","ssh_url":"git@github.com:clanghout/Health-Informatics-3.git","clone_url":"https://github.com/clanghout/Health-Informatics-3.git","svn_url":"https://github.com/clanghout/Health-Informatics-3","homepage":null,"size":16294,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":6,"default_branch":"master"}},"base":{"label":"clanghout:master","ref":"master","sha":"114ce4a6edf3753af2dcf028b78d3a3ed68153dc","user":{"login":"clanghout","id":5969237,"avatar_url":"https://avatars.githubusercontent.com/u/5969237?v=3","gravatar_id":"","url":"https://api.github.com/users/clanghout","html_url":"https://github.com/clanghout","followers_url":"https://api.github.com/users/clanghout/followers","following_url":"https://api.github.com/users/clanghout/following{/other_user}","gists_url":"https://api.github.com/users/clanghout/gists{/gist_id}","starred_url":"https://api.github.com/users/clanghout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clanghout/subscriptions","organizations_url":"https://api.github.com/users/clanghout/orgs","repos_url":"https://api.github.com/users/clanghout/repos","events_url":"https://api.github.com/users/clanghout/events{/privacy}","received_events_url":"https://api.github.com/users/clanghout/received_events","type":"User","site_admin":false},"repo":{"id":34447605,"name":"Health-Informatics-3","full_name":"clanghout/Health-Informatics-3","owner":{"login":"clanghout","id":5969237,"avatar_url":"https://avatars.githubusercontent.com/u/5969237?v=3","gravatar_id":"","url":"https://api.github.com/users/clanghout","html_url":"https://github.com/clanghout","followers_url":"https://api.github.com/users/clanghout/followers","following_url":"https://api.github.com/users/clanghout/following{/other_user}","gists_url":"https://api.github.com/users/clanghout/gists{/gist_id}","starred_url":"https://api.github.com/users/clanghout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clanghout/subscriptions","organizations_url":"https://api.github.com/users/clanghout/orgs","repos_url":"https://api.github.com/users/clanghout/repos","events_url":"https://api.github.com/users/clanghout/events{/privacy}","received_events_url":"https://api.github.com/users/clanghout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clanghout/Health-Informatics-3","description":"","fork":false,"url":"https://api.github.com/repos/clanghout/Health-Informatics-3","forks_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/forks","keys_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/teams","hooks_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/hooks","issue_events_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/issues/events{/number}","events_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/events","assignees_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/assignees{/user}","branches_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/branches{/branch}","tags_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/tags","blobs_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/statuses/{sha}","languages_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/languages","stargazers_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/stargazers","contributors_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/contributors","subscribers_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/subscribers","subscription_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/subscription","commits_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/contents/{+path}","compare_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/merges","archive_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/downloads","issues_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/issues{/number}","pulls_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls{/number}","milestones_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/milestones{/number}","notifications_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/labels{/name}","releases_url":"https://api.github.com/repos/clanghout/Health-Informatics-3/releases{/id}","created_at":"2015-04-23T09:44:17Z","updated_at":"2015-05-28T09:00:34Z","pushed_at":"2015-06-10T07:07:55Z","git_url":"git://github.com/clanghout/Health-Informatics-3.git","ssh_url":"git@github.com:clanghout/Health-Informatics-3.git","clone_url":"https://github.com/clanghout/Health-Informatics-3.git","svn_url":"https://github.com/clanghout/Health-Informatics-3","homepage":null,"size":16294,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/169"},"html":{"href":"https://github.com/clanghout/Health-Informatics-3/pull/169"},"issue":{"href":"https://api.github.com/repos/clanghout/Health-Informatics-3/issues/169"},"comments":{"href":"https://api.github.com/repos/clanghout/Health-Informatics-3/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clanghout/Health-Informatics-3/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/clanghout/Health-Informatics-3/statuses/8fa57cf73b00f443270eb122b7ec6ad95c815df7"}}}}