{"action":"created","issue":{"url":"https://api.github.com/repos/Brainsware/puppet-crashdump/issues/4","labels_url":"https://api.github.com/repos/Brainsware/puppet-crashdump/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/Brainsware/puppet-crashdump/issues/4/comments","events_url":"https://api.github.com/repos/Brainsware/puppet-crashdump/issues/4/events","html_url":"https://github.com/Brainsware/puppet-crashdump/pull/4","id":66121911,"number":4,"title":"Make crashkernel size configurable with reasonable defaults","user":{"login":"antaflos","id":1441852,"avatar_url":"https://avatars.githubusercontent.com/u/1441852?v=3","gravatar_id":"","url":"https://api.github.com/users/antaflos","html_url":"https://github.com/antaflos","followers_url":"https://api.github.com/users/antaflos/followers","following_url":"https://api.github.com/users/antaflos/following{/other_user}","gists_url":"https://api.github.com/users/antaflos/gists{/gist_id}","starred_url":"https://api.github.com/users/antaflos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antaflos/subscriptions","organizations_url":"https://api.github.com/users/antaflos/orgs","repos_url":"https://api.github.com/users/antaflos/repos","events_url":"https://api.github.com/users/antaflos/events{/privacy}","received_events_url":"https://api.github.com/users/antaflos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-03T10:19:32Z","updated_at":"2015-04-03T10:20:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Brainsware/puppet-crashdump/pulls/4","html_url":"https://github.com/Brainsware/puppet-crashdump/pull/4","diff_url":"https://github.com/Brainsware/puppet-crashdump/pull/4.diff","patch_url":"https://github.com/Brainsware/puppet-crashdump/pull/4.patch"},"body":"Add a class parameter `crashdump::crashkernel_size` that can be set by\r\nthe user. Its default value is based on `$::memorysize_mb`: for systems\r\nwith less than 2GB of memory crashkernel=128M is enough, for systems\r\nwith 2GB to 4GB we need crashkernel=256M and for systems with more than\r\n4GB crashkernel=512M. This might need to be extended for systems with\r\neven more memory.\r\n\r\nThis logic might be flawed for systems with \"weird\" amounts of memory,\r\nand because `$::memorysize_mb` shrinks by the amount of reserved\r\ncrashkernel memory, possibly causing a flip-flop effect when setting the\r\ncrashkernel size.\r\n\r\nAddresses #3."},"comment":{"url":"https://api.github.com/repos/Brainsware/puppet-crashdump/issues/comments/89248482","html_url":"https://github.com/Brainsware/puppet-crashdump/pull/4#issuecomment-89248482","issue_url":"https://api.github.com/repos/Brainsware/puppet-crashdump/issues/4","id":89248482,"user":{"login":"antaflos","id":1441852,"avatar_url":"https://avatars.githubusercontent.com/u/1441852?v=3","gravatar_id":"","url":"https://api.github.com/users/antaflos","html_url":"https://github.com/antaflos","followers_url":"https://api.github.com/users/antaflos/followers","following_url":"https://api.github.com/users/antaflos/following{/other_user}","gists_url":"https://api.github.com/users/antaflos/gists{/gist_id}","starred_url":"https://api.github.com/users/antaflos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antaflos/subscriptions","organizations_url":"https://api.github.com/users/antaflos/orgs","repos_url":"https://api.github.com/users/antaflos/repos","events_url":"https://api.github.com/users/antaflos/events{/privacy}","received_events_url":"https://api.github.com/users/antaflos/received_events","type":"User","site_admin":false},"created_at":"2015-04-03T10:20:52Z","updated_at":"2015-04-03T10:20:52Z","body":"Please note that I haven't even tested this yet because I have to go offline for the day and I am already late :)"}}