{"action":"opened","number":911,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/911","id":32905588,"html_url":"https://github.com/puppetlabs/facter/pull/911","diff_url":"https://github.com/puppetlabs/facter/pull/911.diff","patch_url":"https://github.com/puppetlabs/facter/pull/911.patch","issue_url":"https://api.github.com/repos/puppetlabs/facter/issues/911","number":911,"state":"open","locked":false,"title":"(FACT-900) Use GetUserProfileDirectory","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Previously, we queried environment variables to find the User's profile\r\ndirectory. This followed logic used in Puppet to do the same. That was\r\nmore error-prone and required querying multiple environment variables.\r\n\r\nUse GetUserProfileDirectory to get the path instead, which should work on\r\nall platforms. In particular this will be better supported in future\r\nWindows versions.","created_at":"2015-04-08T21:47:33Z","updated_at":"2015-04-08T21:47:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/facter/pulls/911/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/facter/pulls/911/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/facter/issues/911/comments","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/243b20d56e0da99244eb58e76d23d4f49fe24348","head":{"label":"MikaelSmith:bug/master/FACT-900-avoid-envvars","ref":"bug/master/FACT-900-avoid-envvars","sha":"243b20d56e0da99244eb58e76d23d4f49fe24348","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"repo":{"id":22081123,"name":"facter","full_name":"MikaelSmith/facter","owner":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikaelSmith/facter","description":"Collect and display system facts","fork":true,"url":"https://api.github.com/repos/MikaelSmith/facter","forks_url":"https://api.github.com/repos/MikaelSmith/facter/forks","keys_url":"https://api.github.com/repos/MikaelSmith/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikaelSmith/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikaelSmith/facter/teams","hooks_url":"https://api.github.com/repos/MikaelSmith/facter/hooks","issue_events_url":"https://api.github.com/repos/MikaelSmith/facter/issues/events{/number}","events_url":"https://api.github.com/repos/MikaelSmith/facter/events","assignees_url":"https://api.github.com/repos/MikaelSmith/facter/assignees{/user}","branches_url":"https://api.github.com/repos/MikaelSmith/facter/branches{/branch}","tags_url":"https://api.github.com/repos/MikaelSmith/facter/tags","blobs_url":"https://api.github.com/repos/MikaelSmith/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikaelSmith/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikaelSmith/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikaelSmith/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikaelSmith/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/MikaelSmith/facter/languages","stargazers_url":"https://api.github.com/repos/MikaelSmith/facter/stargazers","contributors_url":"https://api.github.com/repos/MikaelSmith/facter/contributors","subscribers_url":"https://api.github.com/repos/MikaelSmith/facter/subscribers","subscription_url":"https://api.github.com/repos/MikaelSmith/facter/subscription","commits_url":"https://api.github.com/repos/MikaelSmith/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikaelSmith/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikaelSmith/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikaelSmith/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikaelSmith/facter/contents/{+path}","compare_url":"https://api.github.com/repos/MikaelSmith/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikaelSmith/facter/merges","archive_url":"https://api.github.com/repos/MikaelSmith/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikaelSmith/facter/downloads","issues_url":"https://api.github.com/repos/MikaelSmith/facter/issues{/number}","pulls_url":"https://api.github.com/repos/MikaelSmith/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/MikaelSmith/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/MikaelSmith/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikaelSmith/facter/labels{/name}","releases_url":"https://api.github.com/repos/MikaelSmith/facter/releases{/id}","created_at":"2014-07-21T21:35:12Z","updated_at":"2015-04-08T21:07:00Z","pushed_at":"2015-04-08T21:42:54Z","git_url":"git://github.com/MikaelSmith/facter.git","ssh_url":"git@github.com:MikaelSmith/facter.git","clone_url":"https://github.com/MikaelSmith/facter.git","svn_url":"https://github.com/MikaelSmith/facter","homepage":"https://tickets.puppetlabs.com/browse/FACT","size":11225,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"81fd63c0493f08fcf743f2c878e5a58c9b1c7139","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910757,"name":"facter","full_name":"puppetlabs/facter","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/facter","description":"Collect and display system facts","fork":false,"url":"https://api.github.com/repos/puppetlabs/facter","forks_url":"https://api.github.com/repos/puppetlabs/facter/forks","keys_url":"https://api.github.com/repos/puppetlabs/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/facter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/facter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/facter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/facter/events","assignees_url":"https://api.github.com/repos/puppetlabs/facter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/facter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/facter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/facter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/facter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/facter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/facter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/facter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/facter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/facter/merges","archive_url":"https://api.github.com/repos/puppetlabs/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/facter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/facter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/facter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/facter/releases{/id}","created_at":"2010-09-14T19:31:04Z","updated_at":"2015-04-08T20:52:52Z","pushed_at":"2015-04-08T20:52:52Z","git_url":"git://github.com/puppetlabs/facter.git","ssh_url":"git@github.com:puppetlabs/facter.git","clone_url":"https://github.com/puppetlabs/facter.git","svn_url":"https://github.com/puppetlabs/facter","homepage":"https://tickets.puppetlabs.com/browse/FACT","size":19098,"stargazers_count":367,"watchers_count":367,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":357,"mirror_url":null,"open_issues_count":2,"forks":357,"open_issues":2,"watchers":367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/911"},"html":{"href":"https://github.com/puppetlabs/facter/pull/911"},"issue":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/911"},"comments":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/911/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/911/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/911/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/facter/statuses/243b20d56e0da99244eb58e76d23d4f49fe24348"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":29,"deletions":19,"changed_files":4}}