{"action":"created","issue":{"url":"https://api.github.com/repos/concord-consortium/drawing-tool/issues/3","labels_url":"https://api.github.com/repos/concord-consortium/drawing-tool/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/concord-consortium/drawing-tool/issues/3/comments","events_url":"https://api.github.com/repos/concord-consortium/drawing-tool/issues/3/events","html_url":"https://github.com/concord-consortium/drawing-tool/pull/3","id":70191202,"number":3,"title":"Use FabricJS v1.5.0","user":{"login":"pjanik","id":767857,"avatar_url":"https://avatars.githubusercontent.com/u/767857?v=3","gravatar_id":"","url":"https://api.github.com/users/pjanik","html_url":"https://github.com/pjanik","followers_url":"https://api.github.com/users/pjanik/followers","following_url":"https://api.github.com/users/pjanik/following{/other_user}","gists_url":"https://api.github.com/users/pjanik/gists{/gist_id}","starred_url":"https://api.github.com/users/pjanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjanik/subscriptions","organizations_url":"https://api.github.com/users/pjanik/orgs","repos_url":"https://api.github.com/users/pjanik/repos","events_url":"https://api.github.com/users/pjanik/events{/privacy}","received_events_url":"https://api.github.com/users/pjanik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-04-22T17:44:27Z","updated_at":"2015-04-28T16:41:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/concord-consortium/drawing-tool/pulls/3","html_url":"https://github.com/concord-consortium/drawing-tool/pull/3","diff_url":"https://github.com/concord-consortium/drawing-tool/pull/3.diff","patch_url":"https://github.com/concord-consortium/drawing-tool/pull/3.patch"},"body":"1. https://www.pivotaltracker.com/story/show/90693952 if fixed now.\r\n\r\n2. New FabricJS introduces some non-backward compatible changes related to paths (free hand draw tool). Resizing of paths has been updated to fix it.\r\n\r\n3. New JSON format is incompatible with the old one (paths), so I've implement versioning of JSON state and automatic conversion from old JSON format to new one. The same pattern can be used in the future in case of need.\r\n\r\n4. New FabricJS fixes SVG rendering, so finally we can use stamps with gradient and we don't have to provide weird tweaks to SVG images. This has a bad side effect though - if user loads old JSON with old stamps, they will look a bit incorrect. That could be theoretically handled in conversion script mentioned above, but I don't think it's worth it. Stamps will be visible, still meaningful, but some of their elements will be shifted a bit. If you try to add some stamps from \"Molecules\" category [on this page](http://concord-consortium.github.io/drawing-tool/examples/), you will see exactly what user is going to see if he loads his old image. \"Molecules (gradient)\" stamps don't have any tweaks related to old FabricJS bugs, so we should use them once this branch is merged.\r\n\r\nThis branch is deployed to:\r\nhttp://concord-consortium.github.io/drawing-tool/examples/\r\nso you can test it and take a look at stamps."},"comment":{"url":"https://api.github.com/repos/concord-consortium/drawing-tool/issues/comments/97131068","html_url":"https://github.com/concord-consortium/drawing-tool/pull/3#issuecomment-97131068","issue_url":"https://api.github.com/repos/concord-consortium/drawing-tool/issues/3","id":97131068,"user":{"login":"psndcsrv","id":61614,"avatar_url":"https://avatars.githubusercontent.com/u/61614?v=3","gravatar_id":"","url":"https://api.github.com/users/psndcsrv","html_url":"https://github.com/psndcsrv","followers_url":"https://api.github.com/users/psndcsrv/followers","following_url":"https://api.github.com/users/psndcsrv/following{/other_user}","gists_url":"https://api.github.com/users/psndcsrv/gists{/gist_id}","starred_url":"https://api.github.com/users/psndcsrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psndcsrv/subscriptions","organizations_url":"https://api.github.com/users/psndcsrv/orgs","repos_url":"https://api.github.com/users/psndcsrv/repos","events_url":"https://api.github.com/users/psndcsrv/events{/privacy}","received_events_url":"https://api.github.com/users/psndcsrv/received_events","type":"User","site_admin":false},"created_at":"2015-04-28T16:41:25Z","updated_at":"2015-04-28T16:41:25Z","body":"Whoops. They really shouldn't have a \"Close and comment\" button!"}}