{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/46022785","id":46022785,"diff_hunk":"@@ -0,0 +1,256 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package backtype.storm.blobstore;\n+\n+import backtype.storm.Config;\n+import backtype.storm.generated.AuthorizationException;\n+import backtype.storm.generated.KeyAlreadyExistsException;\n+import backtype.storm.generated.KeyNotFoundException;\n+import backtype.storm.generated.ReadableBlobMeta;\n+import backtype.storm.nimbus.NimbusInfo;\n+import backtype.storm.security.auth.NimbusPrincipal;\n+import backtype.storm.utils.NimbusClient;\n+import backtype.storm.utils.Utils;\n+import backtype.storm.utils.ZookeeperAuthInfo;\n+import org.apache.curator.framework.CuratorFramework;\n+import org.apache.thrift.transport.TTransportException;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+\n+import javax.security.auth.Subject;\n+import java.io.IOException;\n+import java.util.ArrayList;\n+import java.util.HashSet;\n+import java.util.Iterator;\n+import java.util.List;\n+import java.util.Map;\n+import java.util.Set;\n+\n+public class BlobStoreUtils {\n+    private static final String BLOBSTORE_SUBTREE=\"/blobstore\";\n+    private static final Logger LOG = LoggerFactory.getLogger(Utils.class);\n+\n+    public static CuratorFramework createZKClient(Map conf) {\n+        List<String> zkServers = (List<String>) conf.get(Config.STORM_ZOOKEEPER_SERVERS);\n+        Object port = conf.get(Config.STORM_ZOOKEEPER_PORT);\n+        ZookeeperAuthInfo zkAuthInfo = new ZookeeperAuthInfo(conf);\n+        CuratorFramework zkClient = Utils.newCurator(conf, zkServers, port, (String) conf.get(Config.STORM_ZOOKEEPER_ROOT), zkAuthInfo);\n+        zkClient.start();\n+        return zkClient;\n+    }\n+\n+    public static Subject getNimbusSubject() {\n+        Subject subject = new Subject();\n+        subject.getPrincipals().add(new NimbusPrincipal());\n+        return subject;\n+    }\n+\n+    // Normalize state\n+    public static BlobKeySequenceInfo normalizeNimbusHostPortSequenceNumberInfo(String nimbusSeqNumberInfo) {\n+        BlobKeySequenceInfo keySequenceInfo = new BlobKeySequenceInfo();\n+        int lastIndex = nimbusSeqNumberInfo.lastIndexOf(\"-\");\n+        keySequenceInfo.setNimbusHostPort(nimbusSeqNumberInfo.substring(0, lastIndex));\n+        keySequenceInfo.setSequenceNumber(nimbusSeqNumberInfo.substring(lastIndex + 1));\n+        return keySequenceInfo;\n+    }\n+\n+    // Check for latest sequence number of a key inside zookeeper and return nimbodes containing the latest sequence number\n+    public static Set<NimbusInfo> getNimbodesWithLatestSequenceNumberOfBlob(CuratorFramework zkClient, String key) throws Exception {\n+        List<String> stateInfoList = zkClient.getChildren().forPath(\"/blobstore/\" + key);\n+        Set<NimbusInfo> nimbusInfoSet = new HashSet<NimbusInfo>();\n+        int latestSeqNumber = getLatestSequenceNumber(stateInfoList);\n+        LOG.debug(\"getNimbodesWithLatestSequenceNumberOfBlob stateInfo {} version {}\", stateInfoList, latestSeqNumber);\n+        // Get the nimbodes with the latest version\n+        for(String state : stateInfoList) {\n+            BlobKeySequenceInfo sequenceInfo = normalizeNimbusHostPortSequenceNumberInfo(state);\n+            if (latestSeqNumber == Integer.parseInt(sequenceInfo.getSequenceNumber())) {\n+                nimbusInfoSet.add(NimbusInfo.parse(sequenceInfo.getNimbusHostPort()));\n+            }\n+        }\n+        LOG.debug(\"nimbusInfoList {}\", nimbusInfoSet);\n+        return nimbusInfoSet;\n+    }\n+\n+    // Get sequence number details from latest sequence number of the blob\n+    public static int getLatestSequenceNumber(List<String> stateInfoList) {\n+        int seqNumber = 0;\n+        // Get latest sequence number of the blob present in the zookeeper --> possible to refactor this piece of code\n+        for (String state : stateInfoList) {\n+            BlobKeySequenceInfo sequenceInfo = normalizeNimbusHostPortSequenceNumberInfo(state);\n+            if (seqNumber < Integer.parseInt(sequenceInfo.getSequenceNumber())) {\n+                seqNumber = Integer.parseInt(sequenceInfo.getSequenceNumber());\n+                LOG.debug(\"Sequence Info {}\", seqNumber);\n+            }\n+        }\n+        LOG.debug(\"Latest Sequence Number {}\", seqNumber);\n+        return seqNumber;\n+    }\n+\n+    // Download missing blobs from potential nimbodes\n+    public static boolean downloadMissingBlob(Map conf, BlobStore blobStore, String key, Set<NimbusInfo> nimbusInfos)\n+            throws TTransportException {\n+        NimbusClient client = null;\n+        ReadableBlobMeta rbm = null;\n+        ClientBlobStore remoteBlobStore = null;\n+        InputStreamWithMeta in = null;\n+        Boolean isSuccess = false;\n+        LOG.debug(\"Download blob NimbusInfos {}\", nimbusInfos);\n+        for (NimbusInfo nimbusInfo : nimbusInfos) {\n+            if(isSuccess) {\n+                break;\n+            }\n+            try {\n+                client = new NimbusClient(conf, nimbusInfo.getHost(), nimbusInfo.getPort(), null);\n+                rbm = client.getClient().getBlobMeta(key);\n+                remoteBlobStore = new NimbusBlobStore();\n+                remoteBlobStore.setClient(conf, client);\n+                in = remoteBlobStore.getBlob(key);\n+                blobStore.createBlob(key, in, rbm.get_settable(), getNimbusSubject());\n+                // if key already exists while creating the blob else update it\n+                Iterator<String> keyIterator = blobStore.listKeys();\n+                while (keyIterator.hasNext()) {\n+                    if (keyIterator.next().equals(key)) {\n+                        LOG.debug(\"Success creating key, {}\", key);\n+                        isSuccess = true;\n+                        break;\n+                    }\n+                }\n+            } catch (IOException | AuthorizationException exception) {\n+                throw new RuntimeException(exception);\n+            } catch (KeyAlreadyExistsException kae) {\n+                LOG.info(\"KeyAlreadyExistsException Key: {} {}\", key, kae);\n+            } catch (KeyNotFoundException knf) {\n+                // Catching and logging KeyNotFoundException because, if\n+                // there is a subsequent update and delete, the non-leader\n+                // nimbodes might throw an exception.\n+                LOG.info(\"KeyNotFoundException Key: {} {}\", key, knf);\n+            } catch (Exception exp) {\n+                // Logging an exception while client is connecting\n+                LOG.error(\"Exception {}\", exp);\n+            }\n+        }\n+\n+        if (!isSuccess) {\n+            LOG.error(\"Could not download blob with key\" + key);\n+            return false;\n+        }\n+        return isSuccess;\n+    }\n+\n+    // Download updated blobs from potential nimbodes\n+    public static boolean downloadUpdatedBlob(Map conf, BlobStore blobStore, String key, Set<NimbusInfo> nimbusInfos)\n+            throws TTransportException {\n+        NimbusClient client = null;\n+        ClientBlobStore remoteBlobStore = null;\n+        InputStreamWithMeta in = null;\n+        AtomicOutputStream out = null;\n+        Boolean isSuccess = false;","path":"storm-core/src/jvm/backtype/storm/blobstore/BlobStoreUtils.java","position":162,"original_position":162,"commit_id":"642ae2dc3bf1ebdd505a0b827956d3af89f4cba6","original_commit_id":"642ae2dc3bf1ebdd505a0b827956d3af89f4cba6","user":{"login":"unsleepy22","id":631361,"avatar_url":"https://avatars.githubusercontent.com/u/631361?v=3","gravatar_id":"","url":"https://api.github.com/users/unsleepy22","html_url":"https://github.com/unsleepy22","followers_url":"https://api.github.com/users/unsleepy22/followers","following_url":"https://api.github.com/users/unsleepy22/following{/other_user}","gists_url":"https://api.github.com/users/unsleepy22/gists{/gist_id}","starred_url":"https://api.github.com/users/unsleepy22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unsleepy22/subscriptions","organizations_url":"https://api.github.com/users/unsleepy22/orgs","repos_url":"https://api.github.com/users/unsleepy22/repos","events_url":"https://api.github.com/users/unsleepy22/events{/privacy}","received_events_url":"https://api.github.com/users/unsleepy22/received_events","type":"User","site_admin":false},"body":"boolean","created_at":"2015-11-27T07:40:23Z","updated_at":"2015-11-27T07:40:23Z","html_url":"https://github.com/apache/storm/pull/845#discussion_r46022785","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/845","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/46022785"},"html":{"href":"https://github.com/apache/storm/pull/845#discussion_r46022785"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/845"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/845","id":49518946,"html_url":"https://github.com/apache/storm/pull/845","diff_url":"https://github.com/apache/storm/pull/845.diff","patch_url":"https://github.com/apache/storm/pull/845.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/845","number":845,"state":"open","locked":false,"title":"[STORM-876] Blobstore API","user":{"login":"redsanket","id":8295799,"avatar_url":"https://avatars.githubusercontent.com/u/8295799?v=3","gravatar_id":"","url":"https://api.github.com/users/redsanket","html_url":"https://github.com/redsanket","followers_url":"https://api.github.com/users/redsanket/followers","following_url":"https://api.github.com/users/redsanket/following{/other_user}","gists_url":"https://api.github.com/users/redsanket/gists{/gist_id}","starred_url":"https://api.github.com/users/redsanket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redsanket/subscriptions","organizations_url":"https://api.github.com/users/redsanket/orgs","repos_url":"https://api.github.com/users/redsanket/repos","events_url":"https://api.github.com/users/redsanket/events{/privacy}","received_events_url":"https://api.github.com/users/redsanket/received_events","type":"User","site_admin":false},"body":"Please take a look at the blobstore API. The design docs have been uploaded earlier under the same JIRA. Currently, the blobstore API also works with Nimbus-HA. Apart from the unit tests written for blobstore and nimbus leader election, I have performed few manual tests. Having the PR early looking for suggestions and any missed failover scenarios while the work continues on other additional integration tests and better interface. The manual tests that have been performed are\r\n1. CRUD operations for the blobstore API. Tested for the Local and Hdfs blobstore operations to work with Nimbus-HA and whether the other nimbodes mirror the operations performed on master nimbus.\r\n2. Brought up 3 nimbodes and launched a word count topology. Killed the leader daemon and checked whether other non-leader takes up the leadership and continues to run.\r\n3. Tested whether topology waits for replication to take place before it is launched. For hdfs blobstore the blobstore.replication should be set greater than or equal to topology.min.replication to work effectively.\r\n4. The blobstore with nimbus-ha does not guarantee updates to sync effectively in the case of failover.\r\n\r\nFollow up code to be written.\r\n1. Integration test for blobstore with nimbus-ha\r\n2. Move the sync thread in nimbus to blobstore. Waiting on pacemaker push back as it uses some of its code and write the callback code for blobstore","created_at":"2015-11-03T04:38:15Z","updated_at":"2015-11-27T07:40:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03b6d8263759958c033e8e4b376844faa8a04c98","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/845/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/845/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/845/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/642ae2dc3bf1ebdd505a0b827956d3af89f4cba6","head":{"label":"redsanket:blobstore","ref":"blobstore","sha":"642ae2dc3bf1ebdd505a0b827956d3af89f4cba6","user":{"login":"redsanket","id":8295799,"avatar_url":"https://avatars.githubusercontent.com/u/8295799?v=3","gravatar_id":"","url":"https://api.github.com/users/redsanket","html_url":"https://github.com/redsanket","followers_url":"https://api.github.com/users/redsanket/followers","following_url":"https://api.github.com/users/redsanket/following{/other_user}","gists_url":"https://api.github.com/users/redsanket/gists{/gist_id}","starred_url":"https://api.github.com/users/redsanket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redsanket/subscriptions","organizations_url":"https://api.github.com/users/redsanket/orgs","repos_url":"https://api.github.com/users/redsanket/repos","events_url":"https://api.github.com/users/redsanket/events{/privacy}","received_events_url":"https://api.github.com/users/redsanket/received_events","type":"User","site_admin":false},"repo":{"id":33564601,"name":"storm","full_name":"redsanket/storm","owner":{"login":"redsanket","id":8295799,"avatar_url":"https://avatars.githubusercontent.com/u/8295799?v=3","gravatar_id":"","url":"https://api.github.com/users/redsanket","html_url":"https://github.com/redsanket","followers_url":"https://api.github.com/users/redsanket/followers","following_url":"https://api.github.com/users/redsanket/following{/other_user}","gists_url":"https://api.github.com/users/redsanket/gists{/gist_id}","starred_url":"https://api.github.com/users/redsanket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redsanket/subscriptions","organizations_url":"https://api.github.com/users/redsanket/orgs","repos_url":"https://api.github.com/users/redsanket/repos","events_url":"https://api.github.com/users/redsanket/events{/privacy}","received_events_url":"https://api.github.com/users/redsanket/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/redsanket/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/redsanket/storm","forks_url":"https://api.github.com/repos/redsanket/storm/forks","keys_url":"https://api.github.com/repos/redsanket/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redsanket/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redsanket/storm/teams","hooks_url":"https://api.github.com/repos/redsanket/storm/hooks","issue_events_url":"https://api.github.com/repos/redsanket/storm/issues/events{/number}","events_url":"https://api.github.com/repos/redsanket/storm/events","assignees_url":"https://api.github.com/repos/redsanket/storm/assignees{/user}","branches_url":"https://api.github.com/repos/redsanket/storm/branches{/branch}","tags_url":"https://api.github.com/repos/redsanket/storm/tags","blobs_url":"https://api.github.com/repos/redsanket/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redsanket/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redsanket/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/redsanket/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redsanket/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/redsanket/storm/languages","stargazers_url":"https://api.github.com/repos/redsanket/storm/stargazers","contributors_url":"https://api.github.com/repos/redsanket/storm/contributors","subscribers_url":"https://api.github.com/repos/redsanket/storm/subscribers","subscription_url":"https://api.github.com/repos/redsanket/storm/subscription","commits_url":"https://api.github.com/repos/redsanket/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/redsanket/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/redsanket/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/redsanket/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/redsanket/storm/contents/{+path}","compare_url":"https://api.github.com/repos/redsanket/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redsanket/storm/merges","archive_url":"https://api.github.com/repos/redsanket/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redsanket/storm/downloads","issues_url":"https://api.github.com/repos/redsanket/storm/issues{/number}","pulls_url":"https://api.github.com/repos/redsanket/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/redsanket/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/redsanket/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redsanket/storm/labels{/name}","releases_url":"https://api.github.com/repos/redsanket/storm/releases{/id}","created_at":"2015-04-07T19:46:48Z","updated_at":"2015-04-21T14:57:07Z","pushed_at":"2015-11-25T17:36:39Z","git_url":"git://github.com/redsanket/storm.git","ssh_url":"git@github.com:redsanket/storm.git","clone_url":"https://github.com/redsanket/storm.git","svn_url":"https://github.com/redsanket/storm","homepage":null,"size":26359,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"74cd042152df6ff0ea982340ac14e16c1d940161","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2015-11-27T06:59:01Z","pushed_at":"2015-11-26T21:06:20Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":155033,"stargazers_count":2585,"watchers_count":2585,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1911,"mirror_url":"git://git.apache.org/incubator-storm.git","open_issues_count":78,"forks":1911,"open_issues":78,"watchers":2585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/845"},"html":{"href":"https://github.com/apache/storm/pull/845"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/845"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/845/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/845/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/845/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/642ae2dc3bf1ebdd505a0b827956d3af89f4cba6"}}}}