{"action":"created","comment":{"url":"https://api.github.com/repos/gparmer/Composite/pulls/comments/43467676","id":43467676,"diff_hunk":"@@ -0,0 +1,38 @@\n+#include <printc.h>\n+#include <cos_component.h>\n+#include <cbuf_mgr.h>\n+#include <assert.h>\n+\n+#define NUM 1024\n+char *mptr[NUM];\n+\n+void\n+cos_init(void *args)\n+{\n+\tint err=0;\n+\n+\tint i, j;\n+\n+\tfor (i = 0; i < NUM; i++) \n+    {\n+        printc(\"Call to new malloc:\\n\");\n+\t\tmptr[i] = (char *)malloc((i+1) * sizeof(int));\n+        \n+\t\tassert(mptr[i]);\n+\t\t\n+        printc(\"Call to new free:\\n\");\n+        for (j = 0; j < i; j++)\n+        {\n+            mptr[i][j] = j;\n+        }\n+        \n+        for (j = 0; j < i; j++)\n+        {\n+            printc(\"%d,\", mptr[i][j]);\n+        }\n+        printc(\"\\n\");\n+\t\tfree(mptr[i]);\n+\t}\n+\n+\treturn !!err;","path":"src/components/implementation/tests/unit_cbufmalloc/posix_test.c","position":37,"original_position":37,"commit_id":"2ab60a328073cb1bacdd1f6a4fc6d6bdb97383d4","original_commit_id":"2ab60a328073cb1bacdd1f6a4fc6d6bdb97383d4","user":{"login":"gparmer","id":454733,"avatar_url":"https://avatars.githubusercontent.com/u/454733?v=3","gravatar_id":"","url":"https://api.github.com/users/gparmer","html_url":"https://github.com/gparmer","followers_url":"https://api.github.com/users/gparmer/followers","following_url":"https://api.github.com/users/gparmer/following{/other_user}","gists_url":"https://api.github.com/users/gparmer/gists{/gist_id}","starred_url":"https://api.github.com/users/gparmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gparmer/subscriptions","organizations_url":"https://api.github.com/users/gparmer/orgs","repos_url":"https://api.github.com/users/gparmer/repos","events_url":"https://api.github.com/users/gparmer/events{/privacy}","received_events_url":"https://api.github.com/users/gparmer/received_events","type":"User","site_admin":false},"body":"How is this not returning an error?  `return` statement in a function that returns `void`.","created_at":"2015-10-30T02:53:48Z","updated_at":"2015-10-30T02:53:48Z","html_url":"https://github.com/gparmer/Composite/pull/155#discussion_r43467676","pull_request_url":"https://api.github.com/repos/gparmer/Composite/pulls/155","_links":{"self":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/comments/43467676"},"html":{"href":"https://github.com/gparmer/Composite/pull/155#discussion_r43467676"},"pull_request":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/155"}}},"pull_request":{"url":"https://api.github.com/repos/gparmer/Composite/pulls/155","id":49173729,"html_url":"https://github.com/gparmer/Composite/pull/155","diff_url":"https://github.com/gparmer/Composite/pull/155.diff","patch_url":"https://github.com/gparmer/Composite/pull/155.patch","issue_url":"https://api.github.com/repos/gparmer/Composite/issues/155","number":155,"state":"open","locked":false,"title":"Code review for free()","user":{"login":"georgit","id":1581580,"avatar_url":"https://avatars.githubusercontent.com/u/1581580?v=3","gravatar_id":"","url":"https://api.github.com/users/georgit","html_url":"https://github.com/georgit","followers_url":"https://api.github.com/users/georgit/followers","following_url":"https://api.github.com/users/georgit/following{/other_user}","gists_url":"https://api.github.com/users/georgit/gists{/gist_id}","starred_url":"https://api.github.com/users/georgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgit/subscriptions","organizations_url":"https://api.github.com/users/georgit/orgs","repos_url":"https://api.github.com/users/georgit/repos","events_url":"https://api.github.com/users/georgit/events{/privacy}","received_events_url":"https://api.github.com/users/georgit/received_events","type":"User","site_admin":false},"body":"Still figuring out pull requests. But at least I didn't make a georgit branch this time. So there's that.","created_at":"2015-10-29T17:36:46Z","updated_at":"2015-10-30T02:53:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c993626a60dde5e041cff0f1be9f718e7f39097","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gparmer/Composite/pulls/155/commits","review_comments_url":"https://api.github.com/repos/gparmer/Composite/pulls/155/comments","review_comment_url":"https://api.github.com/repos/gparmer/Composite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gparmer/Composite/issues/155/comments","statuses_url":"https://api.github.com/repos/gparmer/Composite/statuses/2ab60a328073cb1bacdd1f6a4fc6d6bdb97383d4","head":{"label":"georgit:master","ref":"master","sha":"2ab60a328073cb1bacdd1f6a4fc6d6bdb97383d4","user":{"login":"georgit","id":1581580,"avatar_url":"https://avatars.githubusercontent.com/u/1581580?v=3","gravatar_id":"","url":"https://api.github.com/users/georgit","html_url":"https://github.com/georgit","followers_url":"https://api.github.com/users/georgit/followers","following_url":"https://api.github.com/users/georgit/following{/other_user}","gists_url":"https://api.github.com/users/georgit/gists{/gist_id}","starred_url":"https://api.github.com/users/georgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgit/subscriptions","organizations_url":"https://api.github.com/users/georgit/orgs","repos_url":"https://api.github.com/users/georgit/repos","events_url":"https://api.github.com/users/georgit/events{/privacy}","received_events_url":"https://api.github.com/users/georgit/received_events","type":"User","site_admin":false},"repo":{"id":42125038,"name":"Composite","full_name":"georgit/Composite","owner":{"login":"georgit","id":1581580,"avatar_url":"https://avatars.githubusercontent.com/u/1581580?v=3","gravatar_id":"","url":"https://api.github.com/users/georgit","html_url":"https://github.com/georgit","followers_url":"https://api.github.com/users/georgit/followers","following_url":"https://api.github.com/users/georgit/following{/other_user}","gists_url":"https://api.github.com/users/georgit/gists{/gist_id}","starred_url":"https://api.github.com/users/georgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgit/subscriptions","organizations_url":"https://api.github.com/users/georgit/orgs","repos_url":"https://api.github.com/users/georgit/repos","events_url":"https://api.github.com/users/georgit/events{/privacy}","received_events_url":"https://api.github.com/users/georgit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/georgit/Composite","description":"A component-based OS","fork":true,"url":"https://api.github.com/repos/georgit/Composite","forks_url":"https://api.github.com/repos/georgit/Composite/forks","keys_url":"https://api.github.com/repos/georgit/Composite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georgit/Composite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georgit/Composite/teams","hooks_url":"https://api.github.com/repos/georgit/Composite/hooks","issue_events_url":"https://api.github.com/repos/georgit/Composite/issues/events{/number}","events_url":"https://api.github.com/repos/georgit/Composite/events","assignees_url":"https://api.github.com/repos/georgit/Composite/assignees{/user}","branches_url":"https://api.github.com/repos/georgit/Composite/branches{/branch}","tags_url":"https://api.github.com/repos/georgit/Composite/tags","blobs_url":"https://api.github.com/repos/georgit/Composite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georgit/Composite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georgit/Composite/git/refs{/sha}","trees_url":"https://api.github.com/repos/georgit/Composite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georgit/Composite/statuses/{sha}","languages_url":"https://api.github.com/repos/georgit/Composite/languages","stargazers_url":"https://api.github.com/repos/georgit/Composite/stargazers","contributors_url":"https://api.github.com/repos/georgit/Composite/contributors","subscribers_url":"https://api.github.com/repos/georgit/Composite/subscribers","subscription_url":"https://api.github.com/repos/georgit/Composite/subscription","commits_url":"https://api.github.com/repos/georgit/Composite/commits{/sha}","git_commits_url":"https://api.github.com/repos/georgit/Composite/git/commits{/sha}","comments_url":"https://api.github.com/repos/georgit/Composite/comments{/number}","issue_comment_url":"https://api.github.com/repos/georgit/Composite/issues/comments{/number}","contents_url":"https://api.github.com/repos/georgit/Composite/contents/{+path}","compare_url":"https://api.github.com/repos/georgit/Composite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georgit/Composite/merges","archive_url":"https://api.github.com/repos/georgit/Composite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georgit/Composite/downloads","issues_url":"https://api.github.com/repos/georgit/Composite/issues{/number}","pulls_url":"https://api.github.com/repos/georgit/Composite/pulls{/number}","milestones_url":"https://api.github.com/repos/georgit/Composite/milestones{/number}","notifications_url":"https://api.github.com/repos/georgit/Composite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georgit/Composite/labels{/name}","releases_url":"https://api.github.com/repos/georgit/Composite/releases{/id}","created_at":"2015-09-08T16:33:56Z","updated_at":"2015-09-08T16:34:03Z","pushed_at":"2015-10-29T17:33:47Z","git_url":"git://github.com/georgit/Composite.git","ssh_url":"git@github.com:georgit/Composite.git","clone_url":"https://github.com/georgit/Composite.git","svn_url":"https://github.com/georgit/Composite","homepage":"composite.seas.gwu.edu","size":17049,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gparmer:master","ref":"master","sha":"8dcf3b5126ad3b75544bce0c5cf3f6467b775b02","user":{"login":"gparmer","id":454733,"avatar_url":"https://avatars.githubusercontent.com/u/454733?v=3","gravatar_id":"","url":"https://api.github.com/users/gparmer","html_url":"https://github.com/gparmer","followers_url":"https://api.github.com/users/gparmer/followers","following_url":"https://api.github.com/users/gparmer/following{/other_user}","gists_url":"https://api.github.com/users/gparmer/gists{/gist_id}","starred_url":"https://api.github.com/users/gparmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gparmer/subscriptions","organizations_url":"https://api.github.com/users/gparmer/orgs","repos_url":"https://api.github.com/users/gparmer/repos","events_url":"https://api.github.com/users/gparmer/events{/privacy}","received_events_url":"https://api.github.com/users/gparmer/received_events","type":"User","site_admin":false},"repo":{"id":3140667,"name":"Composite","full_name":"gparmer/Composite","owner":{"login":"gparmer","id":454733,"avatar_url":"https://avatars.githubusercontent.com/u/454733?v=3","gravatar_id":"","url":"https://api.github.com/users/gparmer","html_url":"https://github.com/gparmer","followers_url":"https://api.github.com/users/gparmer/followers","following_url":"https://api.github.com/users/gparmer/following{/other_user}","gists_url":"https://api.github.com/users/gparmer/gists{/gist_id}","starred_url":"https://api.github.com/users/gparmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gparmer/subscriptions","organizations_url":"https://api.github.com/users/gparmer/orgs","repos_url":"https://api.github.com/users/gparmer/repos","events_url":"https://api.github.com/users/gparmer/events{/privacy}","received_events_url":"https://api.github.com/users/gparmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gparmer/Composite","description":"A component-based OS","fork":false,"url":"https://api.github.com/repos/gparmer/Composite","forks_url":"https://api.github.com/repos/gparmer/Composite/forks","keys_url":"https://api.github.com/repos/gparmer/Composite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gparmer/Composite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gparmer/Composite/teams","hooks_url":"https://api.github.com/repos/gparmer/Composite/hooks","issue_events_url":"https://api.github.com/repos/gparmer/Composite/issues/events{/number}","events_url":"https://api.github.com/repos/gparmer/Composite/events","assignees_url":"https://api.github.com/repos/gparmer/Composite/assignees{/user}","branches_url":"https://api.github.com/repos/gparmer/Composite/branches{/branch}","tags_url":"https://api.github.com/repos/gparmer/Composite/tags","blobs_url":"https://api.github.com/repos/gparmer/Composite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gparmer/Composite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gparmer/Composite/git/refs{/sha}","trees_url":"https://api.github.com/repos/gparmer/Composite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gparmer/Composite/statuses/{sha}","languages_url":"https://api.github.com/repos/gparmer/Composite/languages","stargazers_url":"https://api.github.com/repos/gparmer/Composite/stargazers","contributors_url":"https://api.github.com/repos/gparmer/Composite/contributors","subscribers_url":"https://api.github.com/repos/gparmer/Composite/subscribers","subscription_url":"https://api.github.com/repos/gparmer/Composite/subscription","commits_url":"https://api.github.com/repos/gparmer/Composite/commits{/sha}","git_commits_url":"https://api.github.com/repos/gparmer/Composite/git/commits{/sha}","comments_url":"https://api.github.com/repos/gparmer/Composite/comments{/number}","issue_comment_url":"https://api.github.com/repos/gparmer/Composite/issues/comments{/number}","contents_url":"https://api.github.com/repos/gparmer/Composite/contents/{+path}","compare_url":"https://api.github.com/repos/gparmer/Composite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gparmer/Composite/merges","archive_url":"https://api.github.com/repos/gparmer/Composite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gparmer/Composite/downloads","issues_url":"https://api.github.com/repos/gparmer/Composite/issues{/number}","pulls_url":"https://api.github.com/repos/gparmer/Composite/pulls{/number}","milestones_url":"https://api.github.com/repos/gparmer/Composite/milestones{/number}","notifications_url":"https://api.github.com/repos/gparmer/Composite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gparmer/Composite/labels{/name}","releases_url":"https://api.github.com/repos/gparmer/Composite/releases{/id}","created_at":"2012-01-09T22:20:27Z","updated_at":"2015-09-15T14:12:15Z","pushed_at":"2015-10-30T02:42:17Z","git_url":"git://github.com/gparmer/Composite.git","ssh_url":"git@github.com:gparmer/Composite.git","clone_url":"https://github.com/gparmer/Composite.git","svn_url":"https://github.com/gparmer/Composite","homepage":"composite.seas.gwu.edu","size":20053,"stargazers_count":33,"watchers_count":33,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":35,"forks":26,"open_issues":35,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/155"},"html":{"href":"https://github.com/gparmer/Composite/pull/155"},"issue":{"href":"https://api.github.com/repos/gparmer/Composite/issues/155"},"comments":{"href":"https://api.github.com/repos/gparmer/Composite/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gparmer/Composite/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/gparmer/Composite/statuses/2ab60a328073cb1bacdd1f6a4fc6d6bdb97383d4"}}}}