{"action":"opened","number":9919,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/9919","id":27163808,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/9919","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/9919.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/9919.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/9919","number":9919,"state":"open","locked":false,"title":"Lua load chunks from zip supports folder structured lua","user":{"login":"edwardzhou","id":278801,"avatar_url":"https://avatars.githubusercontent.com/u/278801?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardzhou","html_url":"https://github.com/edwardzhou","followers_url":"https://api.github.com/users/edwardzhou/followers","following_url":"https://api.github.com/users/edwardzhou/following{/other_user}","gists_url":"https://api.github.com/users/edwardzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardzhou/subscriptions","organizations_url":"https://api.github.com/users/edwardzhou/orgs","repos_url":"https://api.github.com/users/edwardzhou/repos","events_url":"https://api.github.com/users/edwardzhou/events{/privacy}","received_events_url":"https://api.github.com/users/edwardzhou/received_events","type":"User","site_admin":false},"body":"suppose the lua files was in following structure:\r\n\r\nfolderA/sample.lua\r\n\r\nand package with zip command as normal zip file.\r\nCurrent luaLoadChunksFromZIP will load it into _G['preload'] as 'folderA/sample.lua', it will fail to be require with require('folderA.sample').\r\n\r\nthis patch will remove the extension name (.lua & .luac), and replace folder seperator ('/' '\\') with '.' .","created_at":"2015-01-11T15:09:14Z","updated_at":"2015-01-11T15:09:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/9919/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/9919/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/9919/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/c2929a30d519e59a21317a784d0478d7457a903e","head":{"label":"edwardzhou:luaLoadChunksFromZIP_supports_folder_structured_lua","ref":"luaLoadChunksFromZIP_supports_folder_structured_lua","sha":"c2929a30d519e59a21317a784d0478d7457a903e","user":{"login":"edwardzhou","id":278801,"avatar_url":"https://avatars.githubusercontent.com/u/278801?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardzhou","html_url":"https://github.com/edwardzhou","followers_url":"https://api.github.com/users/edwardzhou/followers","following_url":"https://api.github.com/users/edwardzhou/following{/other_user}","gists_url":"https://api.github.com/users/edwardzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardzhou/subscriptions","organizations_url":"https://api.github.com/users/edwardzhou/orgs","repos_url":"https://api.github.com/users/edwardzhou/repos","events_url":"https://api.github.com/users/edwardzhou/events{/privacy}","received_events_url":"https://api.github.com/users/edwardzhou/received_events","type":"User","site_admin":false},"repo":{"id":29079538,"name":"cocos2d-x","full_name":"edwardzhou/cocos2d-x","owner":{"login":"edwardzhou","id":278801,"avatar_url":"https://avatars.githubusercontent.com/u/278801?v=3","gravatar_id":"","url":"https://api.github.com/users/edwardzhou","html_url":"https://github.com/edwardzhou","followers_url":"https://api.github.com/users/edwardzhou/followers","following_url":"https://api.github.com/users/edwardzhou/following{/other_user}","gists_url":"https://api.github.com/users/edwardzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardzhou/subscriptions","organizations_url":"https://api.github.com/users/edwardzhou/orgs","repos_url":"https://api.github.com/users/edwardzhou/repos","events_url":"https://api.github.com/users/edwardzhou/events{/privacy}","received_events_url":"https://api.github.com/users/edwardzhou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edwardzhou/cocos2d-x","description":"cocos2d-x for C++","fork":true,"url":"https://api.github.com/repos/edwardzhou/cocos2d-x","forks_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/forks","keys_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/events","assignees_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/issues/comments/{number}","contents_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/merges","archive_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/edwardzhou/cocos2d-x/releases{/id}","created_at":"2015-01-11T03:04:57Z","updated_at":"2015-01-11T03:05:11Z","pushed_at":"2015-01-11T15:01:30Z","git_url":"git://github.com/edwardzhou/cocos2d-x.git","ssh_url":"git@github.com:edwardzhou/cocos2d-x.git","clone_url":"https://github.com/edwardzhou/cocos2d-x.git","svn_url":"https://github.com/edwardzhou/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1316692,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"6984e7097fe4f6474564f766a28b6e73955243b8","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments/{number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","created_at":"2010-11-18T23:17:00Z","updated_at":"2015-01-11T14:14:04Z","pushed_at":"2015-01-09T14:15:11Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1316692,"stargazers_count":4986,"watchers_count":4986,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3717,"mirror_url":null,"open_issues_count":583,"forks":3717,"open_issues":583,"watchers":4986,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/9919"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/9919"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/9919"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/9919/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/9919/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/9919/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/c2929a30d519e59a21317a784d0478d7457a903e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":13,"deletions":0,"changed_files":1}}