{"action":"created","issue":{"url":"https://api.github.com/repos/krischer/instaseis/issues/13","labels_url":"https://api.github.com/repos/krischer/instaseis/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/krischer/instaseis/issues/13/comments","events_url":"https://api.github.com/repos/krischer/instaseis/issues/13/events","html_url":"https://github.com/krischer/instaseis/pull/13","id":100995999,"number":13,"title":"Sc greens functions","user":{"login":"martinvandriel","id":2306288,"avatar_url":"https://avatars.githubusercontent.com/u/2306288?v=3","gravatar_id":"","url":"https://api.github.com/users/martinvandriel","html_url":"https://github.com/martinvandriel","followers_url":"https://api.github.com/users/martinvandriel/followers","following_url":"https://api.github.com/users/martinvandriel/following{/other_user}","gists_url":"https://api.github.com/users/martinvandriel/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvandriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvandriel/subscriptions","organizations_url":"https://api.github.com/users/martinvandriel/orgs","repos_url":"https://api.github.com/users/martinvandriel/repos","events_url":"https://api.github.com/users/martinvandriel/events{/privacy}","received_events_url":"https://api.github.com/users/martinvandriel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-14T11:50:03Z","updated_at":"2015-08-19T12:49:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/krischer/instaseis/pulls/13","html_url":"https://github.com/krischer/instaseis/pull/13","diff_url":"https://github.com/krischer/instaseis/pull/13.diff","patch_url":"https://github.com/krischer/instaseis/pull/13.patch"},"body":"This pull requests adds a route to request Greens Functions in the decomposition of Minson & Dreger (2008).\r\n\r\nThere might be some room to avoid code duplication, but I am unsure how best to do it. Essentially there are a few functions in GreensHandler and SeismogramHandler which are the same or very similar (and some overlap with seismograms_raw as well):\r\n - parse arguments: checking for duplicates and required arguments as well as default values is the same in the three routes\r\n - parse_time_settings is the same in /greens and /seismogram\r\n - set_headers ist the same in /greens and /seismogram, besides the default label\r\n - get_ttime is the same in /greens and /seismogram\r\n - validate geometry is the same in /greens and /seismogram, where it could be simplified in /greens, because greens only works with reciprocal DBs. On the other hand, we can use the same function for both without problem."},"comment":{"url":"https://api.github.com/repos/krischer/instaseis/issues/comments/132579675","html_url":"https://github.com/krischer/instaseis/pull/13#issuecomment-132579675","issue_url":"https://api.github.com/repos/krischer/instaseis/issues/13","id":132579675,"user":{"login":"krischer","id":800487,"avatar_url":"https://avatars.githubusercontent.com/u/800487?v=3","gravatar_id":"","url":"https://api.github.com/users/krischer","html_url":"https://github.com/krischer","followers_url":"https://api.github.com/users/krischer/followers","following_url":"https://api.github.com/users/krischer/following{/other_user}","gists_url":"https://api.github.com/users/krischer/gists{/gist_id}","starred_url":"https://api.github.com/users/krischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krischer/subscriptions","organizations_url":"https://api.github.com/users/krischer/orgs","repos_url":"https://api.github.com/users/krischer/repos","events_url":"https://api.github.com/users/krischer/events{/privacy}","received_events_url":"https://api.github.com/users/krischer/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T12:49:59Z","updated_at":"2015-08-19T12:49:59Z","body":"> I can't reproduce these failing tests for 2.7 on my local machine, could this be a problem with the travis setup?\r\n\r\nI'm surprised it worked on Python 3.x and your local machine - but you already figured the issue out so its all good now.\r\n"}}