{"action":"created","issue":{"url":"https://api.github.com/repos/rnmp/salvattore/issues/70","labels_url":"https://api.github.com/repos/rnmp/salvattore/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/rnmp/salvattore/issues/70/comments","events_url":"https://api.github.com/repos/rnmp/salvattore/issues/70/events","html_url":"https://github.com/rnmp/salvattore/pull/70","id":29859537,"number":70,"title":"\"Balanced columns\" algorithm","user":{"login":"MoOx","id":157534,"avatar_url":"https://avatars.githubusercontent.com/u/157534?v=3","gravatar_id":"","url":"https://api.github.com/users/MoOx","html_url":"https://github.com/MoOx","followers_url":"https://api.github.com/users/MoOx/followers","following_url":"https://api.github.com/users/MoOx/following{/other_user}","gists_url":"https://api.github.com/users/MoOx/gists{/gist_id}","starred_url":"https://api.github.com/users/MoOx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoOx/subscriptions","organizations_url":"https://api.github.com/users/MoOx/orgs","repos_url":"https://api.github.com/users/MoOx/repos","events_url":"https://api.github.com/users/MoOx/events{/privacy}","received_events_url":"https://api.github.com/users/MoOx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":50,"created_at":"2014-03-20T21:27:29Z","updated_at":"2015-05-24T19:37:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rnmp/salvattore/pulls/70","html_url":"https://github.com/rnmp/salvattore/pull/70","diff_url":"https://github.com/rnmp/salvattore/pull/70.diff","patch_url":"https://github.com/rnmp/salvattore/pull/70.patch"},"body":"This commit include a new algorithm that handle elements height during\r\nthe repartition of the items.\r\nThe previous algorithm was pretty simple (just balance same amount of\r\nitems in each columns), and this can create visual issue if lots of\r\nitems have different heights.\r\nI currently have an implementation that can use more than 5000 items, &\r\nwith this amount the differences are too big. Checkout an ![commented\r\nexample](http://cl.ly/image/1c0N2o181932/Screen%20Shot%202014-03-20%20at\r\n%2021.53.23.png)\r\n\r\nHere is a new algorithm that include a small process to retrieve\r\ncorrect height (by appending them in a additional column\r\nshowing/retrieving value/removing ). Using a wrapper to append & remove\r\nfrom the dom make this very fast. I don’t get any lag with lots of\r\nitems on my current board.\r\n\r\nShould close #4 (& so close #52 )\r\n\r\nA 2nd (simple) commit include fix for latest Chrome (Close #69 & close #40 )\r\n\r\nIt jshint ok (I've used default grunt) & it should be ok with your coding style. I hope so :)\r\n\r\nIt not _really_ better on your example (in the repo) since the images doesn't have the appropriate height during loading, but in my case it give something really great (fyi I use https://github.com/suitcss/flex-embed/ to prepare my css to avoid issue like that, very nice for rwd).\r\n\r\nThis algorithm part should be easily skipped if wrapper in a conditional part (that can be enabled with an option)."},"comment":{"url":"https://api.github.com/repos/rnmp/salvattore/issues/comments/105055992","html_url":"https://github.com/rnmp/salvattore/pull/70#issuecomment-105055992","issue_url":"https://api.github.com/repos/rnmp/salvattore/issues/70","id":105055992,"user":{"login":"witrin","id":1394346,"avatar_url":"https://avatars.githubusercontent.com/u/1394346?v=3","gravatar_id":"","url":"https://api.github.com/users/witrin","html_url":"https://github.com/witrin","followers_url":"https://api.github.com/users/witrin/followers","following_url":"https://api.github.com/users/witrin/following{/other_user}","gists_url":"https://api.github.com/users/witrin/gists{/gist_id}","starred_url":"https://api.github.com/users/witrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witrin/subscriptions","organizations_url":"https://api.github.com/users/witrin/orgs","repos_url":"https://api.github.com/users/witrin/repos","events_url":"https://api.github.com/users/witrin/events{/privacy}","received_events_url":"https://api.github.com/users/witrin/received_events","type":"User","site_admin":false},"created_at":"2015-05-24T19:37:29Z","updated_at":"2015-05-24T19:37:29Z","body":"To anybody who is able to merge this: The HEAD of https://github.com/witrin/salvattore allows to auto merge. The reason why merging here is pain in the ass is because of the minified version `salvattore.min.js` which is part of this repository. Separate such stuff in a bower repo and contribution will be easier."}}