{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/35492474","id":35492474,"diff_hunk":"@@ -199,7 +195,6 @@ Helpers\n */\n \n /obj/machinery/atmospherics/components/proc/update_parents()\n-\tfor(var/P in parents)\n-\t\tvar/datum/pipeline/parent = parents[\"[P]\"]\n-\t\tif (parent && istype(parent))\n-\t\t\tparent.update = 1\n\\ No newline at end of file\n+\tfor(var/I = 1; I <= device_type; I++)\n+\t\tvar/datum/pipeline/parent = parents[\"p[I]\"]\n+\t\tparent.update = 1","path":"code/ATMOSPHERICS/components/components_base.dm","position":76,"original_position":76,"commit_id":"dde57d8267a2a1cca3a918f2cec04e34d795311d","original_commit_id":"dde57d8267a2a1cca3a918f2cec04e34d795311d","user":{"login":"Aranclanos","id":701959,"avatar_url":"https://avatars.githubusercontent.com/u/701959?v=3","gravatar_id":"","url":"https://api.github.com/users/Aranclanos","html_url":"https://github.com/Aranclanos","followers_url":"https://api.github.com/users/Aranclanos/followers","following_url":"https://api.github.com/users/Aranclanos/following{/other_user}","gists_url":"https://api.github.com/users/Aranclanos/gists{/gist_id}","starred_url":"https://api.github.com/users/Aranclanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aranclanos/subscriptions","organizations_url":"https://api.github.com/users/Aranclanos/orgs","repos_url":"https://api.github.com/users/Aranclanos/repos","events_url":"https://api.github.com/users/Aranclanos/events{/privacy}","received_events_url":"https://api.github.com/users/Aranclanos/received_events","type":"User","site_admin":false},"body":"its pretty good at runtiming like hell when there's a bug, so it can stay temporally(TM)\r\nplus consistency with the rest of these procs under this section","created_at":"2015-07-26T12:40:46Z","updated_at":"2015-07-26T12:40:46Z","html_url":"https://github.com/tgstation/-tg-station/pull/10864#discussion_r35492474","pull_request_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/10864","_links":{"self":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/35492474"},"html":{"href":"https://github.com/tgstation/-tg-station/pull/10864#discussion_r35492474"},"pull_request":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/10864"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/10864","id":40848897,"html_url":"https://github.com/tgstation/-tg-station/pull/10864","diff_url":"https://github.com/tgstation/-tg-station/pull/10864.diff","patch_url":"https://github.com/tgstation/-tg-station/pull/10864.patch","issue_url":"https://api.github.com/repos/tgstation/-tg-station/issues/10864","number":10864,"state":"open","locked":false,"title":"Atmos fixes and tweaks.","user":{"login":"MrStonedOne","id":7069733,"avatar_url":"https://avatars.githubusercontent.com/u/7069733?v=3","gravatar_id":"","url":"https://api.github.com/users/MrStonedOne","html_url":"https://github.com/MrStonedOne","followers_url":"https://api.github.com/users/MrStonedOne/followers","following_url":"https://api.github.com/users/MrStonedOne/following{/other_user}","gists_url":"https://api.github.com/users/MrStonedOne/gists{/gist_id}","starred_url":"https://api.github.com/users/MrStonedOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrStonedOne/subscriptions","organizations_url":"https://api.github.com/users/MrStonedOne/orgs","repos_url":"https://api.github.com/users/MrStonedOne/repos","events_url":"https://api.github.com/users/MrStonedOne/events{/privacy}","received_events_url":"https://api.github.com/users/MrStonedOne/received_events","type":"User","site_admin":false},"body":"So basically, one pr caused a bug where firelocks would not let atmos pass thru them when open, to fix it, I had to re-fix the bug that pr was fixing, fixing that caused a bug that hadn't been known because the aforementioned fixed bug broke pipenet code in a minor and not immediately noticeable way, this chain continued until FINALLY I was able to fix firedoors, 7 hours later.\r\n\r\nAnywho, Atom as fuck changes:\r\n\r\nMostly reverted #9896 for causing #10828\r\nMoved pipenet setup out of obj/initialize and into its own proc called from MC's initialize.\r\nRemoved obj/initialize anything in atmos machinery.\r\nFixed a bug in atmospherics/components/Destroy() that prevented garbage collection of nearby nodes (again)\r\nFixed a bug in atmospherics/components/disconnect() that would prevent garbage collection of recently disconnected pipes as well as make pipenet code think they were still connected.\r\nFixed a bug in atmospherics/components/disconnect() that would null out a pipenet that was still valid and in use.\r\nFixed a bug in atmospherics/components/nullifyPipenet() that would prevent a pipenet from getting nulled out and garbage collected.\r\nFixed a bug in atmospherics/components/pipeline_expansion() that would cause it to return the letter \"n\" rather than a node.\r\nFixed a bug in atmospherics/components/pipeline_expansion() that would cause it to return all of its nodes rather than the node connected to the given pipenet.\r\nFixed a bug in atmospherics/components/pipeline_expansion() that would cause it to return null rather than a null list if the node wasn't connected.\r\nFixed a bug in atmospherics/components/replacePipenet() where it didn't actually do anything because it was assigning the new pipenet to the typecasted local var, not the object's pipenet list.\r\nReverted my change in #10593 to atmospherics/components/proc/update_parents() because I fixed all the bugs that made it necessary (hopefully)\r\n\r\nFixes #10682 \r\nFixes #10753\r\nFixes #10828\r\n","created_at":"2015-07-26T06:35:26Z","updated_at":"2015-07-26T12:40:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64ff67cfe37d7a567096b016cdaef3ad04d92773","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/10864/commits","review_comments_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/10864/comments","review_comment_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/issues/10864/comments","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/dde57d8267a2a1cca3a918f2cec04e34d795311d","head":{"label":"MrStonedOne:firelockatmosfix","ref":"firelockatmosfix","sha":"dde57d8267a2a1cca3a918f2cec04e34d795311d","user":{"login":"MrStonedOne","id":7069733,"avatar_url":"https://avatars.githubusercontent.com/u/7069733?v=3","gravatar_id":"","url":"https://api.github.com/users/MrStonedOne","html_url":"https://github.com/MrStonedOne","followers_url":"https://api.github.com/users/MrStonedOne/followers","following_url":"https://api.github.com/users/MrStonedOne/following{/other_user}","gists_url":"https://api.github.com/users/MrStonedOne/gists{/gist_id}","starred_url":"https://api.github.com/users/MrStonedOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrStonedOne/subscriptions","organizations_url":"https://api.github.com/users/MrStonedOne/orgs","repos_url":"https://api.github.com/users/MrStonedOne/repos","events_url":"https://api.github.com/users/MrStonedOne/events{/privacy}","received_events_url":"https://api.github.com/users/MrStonedOne/received_events","type":"User","site_admin":false},"repo":{"id":18158463,"name":"-tg-station","full_name":"MrStonedOne/-tg-station","owner":{"login":"MrStonedOne","id":7069733,"avatar_url":"https://avatars.githubusercontent.com/u/7069733?v=3","gravatar_id":"","url":"https://api.github.com/users/MrStonedOne","html_url":"https://github.com/MrStonedOne","followers_url":"https://api.github.com/users/MrStonedOne/followers","following_url":"https://api.github.com/users/MrStonedOne/following{/other_user}","gists_url":"https://api.github.com/users/MrStonedOne/gists{/gist_id}","starred_url":"https://api.github.com/users/MrStonedOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrStonedOne/subscriptions","organizations_url":"https://api.github.com/users/MrStonedOne/orgs","repos_url":"https://api.github.com/users/MrStonedOne/repos","events_url":"https://api.github.com/users/MrStonedOne/events{/privacy}","received_events_url":"https://api.github.com/users/MrStonedOne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrStonedOne/-tg-station","description":"/tg/'s SS13 branch","fork":true,"url":"https://api.github.com/repos/MrStonedOne/-tg-station","forks_url":"https://api.github.com/repos/MrStonedOne/-tg-station/forks","keys_url":"https://api.github.com/repos/MrStonedOne/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrStonedOne/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrStonedOne/-tg-station/teams","hooks_url":"https://api.github.com/repos/MrStonedOne/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/MrStonedOne/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/MrStonedOne/-tg-station/events","assignees_url":"https://api.github.com/repos/MrStonedOne/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/MrStonedOne/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/MrStonedOne/-tg-station/tags","blobs_url":"https://api.github.com/repos/MrStonedOne/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrStonedOne/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrStonedOne/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrStonedOne/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrStonedOne/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/MrStonedOne/-tg-station/languages","stargazers_url":"https://api.github.com/repos/MrStonedOne/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/MrStonedOne/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/MrStonedOne/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/MrStonedOne/-tg-station/subscription","commits_url":"https://api.github.com/repos/MrStonedOne/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrStonedOne/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrStonedOne/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrStonedOne/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrStonedOne/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/MrStonedOne/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrStonedOne/-tg-station/merges","archive_url":"https://api.github.com/repos/MrStonedOne/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrStonedOne/-tg-station/downloads","issues_url":"https://api.github.com/repos/MrStonedOne/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/MrStonedOne/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/MrStonedOne/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/MrStonedOne/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrStonedOne/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/MrStonedOne/-tg-station/releases{/id}","created_at":"2014-03-26T23:58:37Z","updated_at":"2015-05-07T22:47:55Z","pushed_at":"2015-07-26T06:20:06Z","git_url":"git://github.com/MrStonedOne/-tg-station.git","ssh_url":"git@github.com:MrStonedOne/-tg-station.git","clone_url":"https://github.com/MrStonedOne/-tg-station.git","svn_url":"https://github.com/MrStonedOne/-tg-station","homepage":"","size":533600,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"7c903ca027303ed3843719782d8732106052f3d5","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"-tg-station","full_name":"tgstation/-tg-station","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/-tg-station","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/-tg-station","forks_url":"https://api.github.com/repos/tgstation/-tg-station/forks","keys_url":"https://api.github.com/repos/tgstation/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/-tg-station/teams","hooks_url":"https://api.github.com/repos/tgstation/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/tgstation/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/-tg-station/events","assignees_url":"https://api.github.com/repos/tgstation/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/-tg-station/tags","blobs_url":"https://api.github.com/repos/tgstation/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/-tg-station/languages","stargazers_url":"https://api.github.com/repos/tgstation/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/tgstation/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/tgstation/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/tgstation/-tg-station/subscription","commits_url":"https://api.github.com/repos/tgstation/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/-tg-station/merges","archive_url":"https://api.github.com/repos/tgstation/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/-tg-station/downloads","issues_url":"https://api.github.com/repos/tgstation/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/-tg-station/releases{/id}","created_at":"2012-01-21T17:32:47Z","updated_at":"2015-07-23T14:30:35Z","pushed_at":"2015-07-26T11:21:31Z","git_url":"git://github.com/tgstation/-tg-station.git","ssh_url":"git@github.com:tgstation/-tg-station.git","clone_url":"https://github.com/tgstation/-tg-station.git","svn_url":"https://github.com/tgstation/-tg-station","homepage":"http://www.tgstation13.org/","size":729805,"stargazers_count":234,"watchers_count":234,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":790,"mirror_url":null,"open_issues_count":874,"forks":790,"open_issues":874,"watchers":234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/10864"},"html":{"href":"https://github.com/tgstation/-tg-station/pull/10864"},"issue":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/10864"},"comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/10864/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/10864/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/10864/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/-tg-station/statuses/dde57d8267a2a1cca3a918f2cec04e34d795311d"}}}}