{"action":"created","comment":{"url":"https://api.github.com/repos/wdidc/attendance/pulls/comments/37974708","id":37974708,"diff_hunk":"@@ -6,25 +6,53 @@ Visit http://attendance.wdidc.org/\n \n When logging in, grant access to the wdidc organization if you have not done so.\n \n+For development, use the \"example\" weekday: http://localhost:4567/example\n+\n ## Local Setup\n \n-**Clone the repo:**\n+### Clone the repo:\n \n-    $ git clone https://github.com/jshawl/sinatra-login-with-github.git\n+    $ git clone git@github.com:wdidc/attendance.git\n+    $ cd attendance\n \n-**Install Dependencies**\n+### Install Dependencies\n \n-    $ cd sinatra-login-with-github/\n     $ bundle install\n-    \n-**Set ENV variables**\n \n-I keep my ENV variables in a local env.rb file, much like this one:\n+No local database required.  It persists via API calls.\n+\n+### Register a new GitHub Developer Application\n+\n+- Visit https://github.com/settings/developers\n+- Choose \"Register new application\"\n+  - Fill in \"Application Name\"\n+    - dev (recommend): 'dev-wdi-attendance'\n+    - production: 'attendance.wdidc.org'\n+  - Fill in \"Authorization callback URL\" using the app's callback path.\n+    - dev (probably): 'http://localhost:4567/auth/github/callback'\n+    - production: 'http://attendance.wdidc.org/auth/github/callback'\n+  - the rest are optional\n+\n+- Gotcha: The path for Authorization callback url used to be `callback`.  Update it to the standard oAuth path seen above.\n+\n+\n+### Set ENV variables\n+\n+This app loads ENV variables from the (uncommitted) env.rb file.  \n+- Copy \"env.example.rb\" to \"env.rb\" and","path":"README.md","position":44,"original_position":44,"commit_id":"52d66a4dfd35c49f3337630692235e838a2da017","original_commit_id":"52d66a4dfd35c49f3337630692235e838a2da017","user":{"login":"jshawl","id":3824954,"avatar_url":"https://avatars.githubusercontent.com/u/3824954?v=3","gravatar_id":"","url":"https://api.github.com/users/jshawl","html_url":"https://github.com/jshawl","followers_url":"https://api.github.com/users/jshawl/followers","following_url":"https://api.github.com/users/jshawl/following{/other_user}","gists_url":"https://api.github.com/users/jshawl/gists{/gist_id}","starred_url":"https://api.github.com/users/jshawl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshawl/subscriptions","organizations_url":"https://api.github.com/users/jshawl/orgs","repos_url":"https://api.github.com/users/jshawl/repos","events_url":"https://api.github.com/users/jshawl/events{/privacy}","received_events_url":"https://api.github.com/users/jshawl/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2015-08-26T12:19:10Z","updated_at":"2015-08-26T12:19:10Z","html_url":"https://github.com/wdidc/attendance/pull/7#discussion_r37974708","pull_request_url":"https://api.github.com/repos/wdidc/attendance/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/wdidc/attendance/pulls/comments/37974708"},"html":{"href":"https://github.com/wdidc/attendance/pull/7#discussion_r37974708"},"pull_request":{"href":"https://api.github.com/repos/wdidc/attendance/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/wdidc/attendance/pulls/7","id":43359775,"html_url":"https://github.com/wdidc/attendance/pull/7","diff_url":"https://github.com/wdidc/attendance/pull/7.diff","patch_url":"https://github.com/wdidc/attendance/pull/7.patch","issue_url":"https://api.github.com/repos/wdidc/attendance/issues/7","number":7,"state":"open","locked":false,"title":"Use standard path for oauth callback.  Update docs, including upgrade steps.","user":{"login":"mattscilipoti","id":31929,"avatar_url":"https://avatars.githubusercontent.com/u/31929?v=3","gravatar_id":"","url":"https://api.github.com/users/mattscilipoti","html_url":"https://github.com/mattscilipoti","followers_url":"https://api.github.com/users/mattscilipoti/followers","following_url":"https://api.github.com/users/mattscilipoti/following{/other_user}","gists_url":"https://api.github.com/users/mattscilipoti/gists{/gist_id}","starred_url":"https://api.github.com/users/mattscilipoti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattscilipoti/subscriptions","organizations_url":"https://api.github.com/users/mattscilipoti/orgs","repos_url":"https://api.github.com/users/mattscilipoti/repos","events_url":"https://api.github.com/users/mattscilipoti/events{/privacy}","received_events_url":"https://api.github.com/users/mattscilipoti/received_events","type":"User","site_admin":false},"body":"- session: use SESSION_SECRET (this isn’t GH related)\n-  auth: use standard oath callback url, update doc\n- fail early and often\n - use #fetch\n - raise RestClient failure (was hiding invalid callback uri messages and\nsimilar)\n- use existing variables instead of referencing ENV multiple locations\n(especially since there were typos)\n- extract github_oauth_callback_url, github_oauth_authorize_url","created_at":"2015-08-26T03:03:55Z","updated_at":"2015-08-26T12:19:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4cc5f1d59f6dcb5d0adbd40a409aff69a3b06e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wdidc/attendance/pulls/7/commits","review_comments_url":"https://api.github.com/repos/wdidc/attendance/pulls/7/comments","review_comment_url":"https://api.github.com/repos/wdidc/attendance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wdidc/attendance/issues/7/comments","statuses_url":"https://api.github.com/repos/wdidc/attendance/statuses/52d66a4dfd35c49f3337630692235e838a2da017","head":{"label":"wdidc:standard_oauth","ref":"standard_oauth","sha":"52d66a4dfd35c49f3337630692235e838a2da017","user":{"login":"wdidc","id":12504889,"avatar_url":"https://avatars.githubusercontent.com/u/12504889?v=3","gravatar_id":"","url":"https://api.github.com/users/wdidc","html_url":"https://github.com/wdidc","followers_url":"https://api.github.com/users/wdidc/followers","following_url":"https://api.github.com/users/wdidc/following{/other_user}","gists_url":"https://api.github.com/users/wdidc/gists{/gist_id}","starred_url":"https://api.github.com/users/wdidc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdidc/subscriptions","organizations_url":"https://api.github.com/users/wdidc/orgs","repos_url":"https://api.github.com/users/wdidc/repos","events_url":"https://api.github.com/users/wdidc/events{/privacy}","received_events_url":"https://api.github.com/users/wdidc/received_events","type":"Organization","site_admin":false},"repo":{"id":36672079,"name":"attendance","full_name":"wdidc/attendance","owner":{"login":"wdidc","id":12504889,"avatar_url":"https://avatars.githubusercontent.com/u/12504889?v=3","gravatar_id":"","url":"https://api.github.com/users/wdidc","html_url":"https://github.com/wdidc","followers_url":"https://api.github.com/users/wdidc/followers","following_url":"https://api.github.com/users/wdidc/following{/other_user}","gists_url":"https://api.github.com/users/wdidc/gists{/gist_id}","starred_url":"https://api.github.com/users/wdidc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdidc/subscriptions","organizations_url":"https://api.github.com/users/wdidc/orgs","repos_url":"https://api.github.com/users/wdidc/repos","events_url":"https://api.github.com/users/wdidc/events{/privacy}","received_events_url":"https://api.github.com/users/wdidc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wdidc/attendance","description":"","fork":false,"url":"https://api.github.com/repos/wdidc/attendance","forks_url":"https://api.github.com/repos/wdidc/attendance/forks","keys_url":"https://api.github.com/repos/wdidc/attendance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wdidc/attendance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wdidc/attendance/teams","hooks_url":"https://api.github.com/repos/wdidc/attendance/hooks","issue_events_url":"https://api.github.com/repos/wdidc/attendance/issues/events{/number}","events_url":"https://api.github.com/repos/wdidc/attendance/events","assignees_url":"https://api.github.com/repos/wdidc/attendance/assignees{/user}","branches_url":"https://api.github.com/repos/wdidc/attendance/branches{/branch}","tags_url":"https://api.github.com/repos/wdidc/attendance/tags","blobs_url":"https://api.github.com/repos/wdidc/attendance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wdidc/attendance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wdidc/attendance/git/refs{/sha}","trees_url":"https://api.github.com/repos/wdidc/attendance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wdidc/attendance/statuses/{sha}","languages_url":"https://api.github.com/repos/wdidc/attendance/languages","stargazers_url":"https://api.github.com/repos/wdidc/attendance/stargazers","contributors_url":"https://api.github.com/repos/wdidc/attendance/contributors","subscribers_url":"https://api.github.com/repos/wdidc/attendance/subscribers","subscription_url":"https://api.github.com/repos/wdidc/attendance/subscription","commits_url":"https://api.github.com/repos/wdidc/attendance/commits{/sha}","git_commits_url":"https://api.github.com/repos/wdidc/attendance/git/commits{/sha}","comments_url":"https://api.github.com/repos/wdidc/attendance/comments{/number}","issue_comment_url":"https://api.github.com/repos/wdidc/attendance/issues/comments{/number}","contents_url":"https://api.github.com/repos/wdidc/attendance/contents/{+path}","compare_url":"https://api.github.com/repos/wdidc/attendance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wdidc/attendance/merges","archive_url":"https://api.github.com/repos/wdidc/attendance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wdidc/attendance/downloads","issues_url":"https://api.github.com/repos/wdidc/attendance/issues{/number}","pulls_url":"https://api.github.com/repos/wdidc/attendance/pulls{/number}","milestones_url":"https://api.github.com/repos/wdidc/attendance/milestones{/number}","notifications_url":"https://api.github.com/repos/wdidc/attendance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wdidc/attendance/labels{/name}","releases_url":"https://api.github.com/repos/wdidc/attendance/releases{/id}","created_at":"2015-06-01T16:02:35Z","updated_at":"2015-06-01T16:03:04Z","pushed_at":"2015-08-26T11:44:55Z","git_url":"git://github.com/wdidc/attendance.git","ssh_url":"git@github.com:wdidc/attendance.git","clone_url":"https://github.com/wdidc/attendance.git","svn_url":"https://github.com/wdidc/attendance","homepage":null,"size":202,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"wdidc:master","ref":"master","sha":"210e6234024babba8db9b1d4c9e6de6e5227b0a1","user":{"login":"wdidc","id":12504889,"avatar_url":"https://avatars.githubusercontent.com/u/12504889?v=3","gravatar_id":"","url":"https://api.github.com/users/wdidc","html_url":"https://github.com/wdidc","followers_url":"https://api.github.com/users/wdidc/followers","following_url":"https://api.github.com/users/wdidc/following{/other_user}","gists_url":"https://api.github.com/users/wdidc/gists{/gist_id}","starred_url":"https://api.github.com/users/wdidc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdidc/subscriptions","organizations_url":"https://api.github.com/users/wdidc/orgs","repos_url":"https://api.github.com/users/wdidc/repos","events_url":"https://api.github.com/users/wdidc/events{/privacy}","received_events_url":"https://api.github.com/users/wdidc/received_events","type":"Organization","site_admin":false},"repo":{"id":36672079,"name":"attendance","full_name":"wdidc/attendance","owner":{"login":"wdidc","id":12504889,"avatar_url":"https://avatars.githubusercontent.com/u/12504889?v=3","gravatar_id":"","url":"https://api.github.com/users/wdidc","html_url":"https://github.com/wdidc","followers_url":"https://api.github.com/users/wdidc/followers","following_url":"https://api.github.com/users/wdidc/following{/other_user}","gists_url":"https://api.github.com/users/wdidc/gists{/gist_id}","starred_url":"https://api.github.com/users/wdidc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdidc/subscriptions","organizations_url":"https://api.github.com/users/wdidc/orgs","repos_url":"https://api.github.com/users/wdidc/repos","events_url":"https://api.github.com/users/wdidc/events{/privacy}","received_events_url":"https://api.github.com/users/wdidc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wdidc/attendance","description":"","fork":false,"url":"https://api.github.com/repos/wdidc/attendance","forks_url":"https://api.github.com/repos/wdidc/attendance/forks","keys_url":"https://api.github.com/repos/wdidc/attendance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wdidc/attendance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wdidc/attendance/teams","hooks_url":"https://api.github.com/repos/wdidc/attendance/hooks","issue_events_url":"https://api.github.com/repos/wdidc/attendance/issues/events{/number}","events_url":"https://api.github.com/repos/wdidc/attendance/events","assignees_url":"https://api.github.com/repos/wdidc/attendance/assignees{/user}","branches_url":"https://api.github.com/repos/wdidc/attendance/branches{/branch}","tags_url":"https://api.github.com/repos/wdidc/attendance/tags","blobs_url":"https://api.github.com/repos/wdidc/attendance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wdidc/attendance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wdidc/attendance/git/refs{/sha}","trees_url":"https://api.github.com/repos/wdidc/attendance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wdidc/attendance/statuses/{sha}","languages_url":"https://api.github.com/repos/wdidc/attendance/languages","stargazers_url":"https://api.github.com/repos/wdidc/attendance/stargazers","contributors_url":"https://api.github.com/repos/wdidc/attendance/contributors","subscribers_url":"https://api.github.com/repos/wdidc/attendance/subscribers","subscription_url":"https://api.github.com/repos/wdidc/attendance/subscription","commits_url":"https://api.github.com/repos/wdidc/attendance/commits{/sha}","git_commits_url":"https://api.github.com/repos/wdidc/attendance/git/commits{/sha}","comments_url":"https://api.github.com/repos/wdidc/attendance/comments{/number}","issue_comment_url":"https://api.github.com/repos/wdidc/attendance/issues/comments{/number}","contents_url":"https://api.github.com/repos/wdidc/attendance/contents/{+path}","compare_url":"https://api.github.com/repos/wdidc/attendance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wdidc/attendance/merges","archive_url":"https://api.github.com/repos/wdidc/attendance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wdidc/attendance/downloads","issues_url":"https://api.github.com/repos/wdidc/attendance/issues{/number}","pulls_url":"https://api.github.com/repos/wdidc/attendance/pulls{/number}","milestones_url":"https://api.github.com/repos/wdidc/attendance/milestones{/number}","notifications_url":"https://api.github.com/repos/wdidc/attendance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wdidc/attendance/labels{/name}","releases_url":"https://api.github.com/repos/wdidc/attendance/releases{/id}","created_at":"2015-06-01T16:02:35Z","updated_at":"2015-06-01T16:03:04Z","pushed_at":"2015-08-26T11:44:55Z","git_url":"git://github.com/wdidc/attendance.git","ssh_url":"git@github.com:wdidc/attendance.git","clone_url":"https://github.com/wdidc/attendance.git","svn_url":"https://github.com/wdidc/attendance","homepage":null,"size":202,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wdidc/attendance/pulls/7"},"html":{"href":"https://github.com/wdidc/attendance/pull/7"},"issue":{"href":"https://api.github.com/repos/wdidc/attendance/issues/7"},"comments":{"href":"https://api.github.com/repos/wdidc/attendance/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/wdidc/attendance/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/wdidc/attendance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wdidc/attendance/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/wdidc/attendance/statuses/52d66a4dfd35c49f3337630692235e838a2da017"}}}}