{"action":"created","issue":{"url":"https://api.github.com/repos/iojs/io.js/issues/1066","labels_url":"https://api.github.com/repos/iojs/io.js/issues/1066/labels{/name}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/1066/comments","events_url":"https://api.github.com/repos/iojs/io.js/issues/1066/events","html_url":"https://github.com/iojs/io.js/pull/1066","id":59892799,"number":1066,"title":"win,test: fix test-tls-over-http-tunnel","user":{"login":"piscisaureus","id":218257,"avatar_url":"https://avatars.githubusercontent.com/u/218257?v=3","gravatar_id":"","url":"https://api.github.com/users/piscisaureus","html_url":"https://github.com/piscisaureus","followers_url":"https://api.github.com/users/piscisaureus/followers","following_url":"https://api.github.com/users/piscisaureus/following{/other_user}","gists_url":"https://api.github.com/users/piscisaureus/gists{/gist_id}","starred_url":"https://api.github.com/users/piscisaureus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piscisaureus/subscriptions","organizations_url":"https://api.github.com/users/piscisaureus/orgs","repos_url":"https://api.github.com/users/piscisaureus/repos","events_url":"https://api.github.com/users/piscisaureus/events{/privacy}","received_events_url":"https://api.github.com/users/piscisaureus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-05T01:52:14Z","updated_at":"2015-03-05T02:22:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/1066","html_url":"https://github.com/iojs/io.js/pull/1066","diff_url":"https://github.com/iojs/io.js/pull/1066.diff","patch_url":"https://github.com/iojs/io.js/pull/1066.patch"},"body":"This patch fixes an ECONNRESET error on Windows by:\r\n  * Fixing the spelling of the 'Connection' and 'Proxy-Connection'\r\n    headers in the proxy response.\r\n  * Adding a 'Connection: keep-alive' header to the request that gets\r\n    sent through the tunnel, so the receiving end doesn't destroy the\r\n    connection after the transaction is complete.\r\n\r\nIn addition this patch replaces some uses of `Socket.destroy()` by the\r\nslightly more graceful `destroySoon()`, which ensures that all write\r\nbuffers are fully flushed before destroying a connection.\r\n\r\n@tellnes I'm not sure if I worded the commit message correctly. Can you review it?\r\n\r\nR=@tellnes\r\nR=@rvagg\r\nR=@iojs/platform-windows"},"comment":{"url":"https://api.github.com/repos/iojs/io.js/issues/comments/77294186","html_url":"https://github.com/iojs/io.js/pull/1066#issuecomment-77294186","issue_url":"https://api.github.com/repos/iojs/io.js/issues/1066","id":77294186,"user":{"login":"piscisaureus","id":218257,"avatar_url":"https://avatars.githubusercontent.com/u/218257?v=3","gravatar_id":"","url":"https://api.github.com/users/piscisaureus","html_url":"https://github.com/piscisaureus","followers_url":"https://api.github.com/users/piscisaureus/followers","following_url":"https://api.github.com/users/piscisaureus/following{/other_user}","gists_url":"https://api.github.com/users/piscisaureus/gists{/gist_id}","starred_url":"https://api.github.com/users/piscisaureus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piscisaureus/subscriptions","organizations_url":"https://api.github.com/users/piscisaureus/orgs","repos_url":"https://api.github.com/users/piscisaureus/repos","events_url":"https://api.github.com/users/piscisaureus/events{/privacy}","received_events_url":"https://api.github.com/users/piscisaureus/received_events","type":"User","site_admin":false},"created_at":"2015-03-05T02:22:00Z","updated_at":"2015-03-05T02:22:00Z","body":"@domenic I don't know. Strangely enough this test was originally written on windows by @igorzi so it likely passed at some point. But it seems that something in the tls or http implementations has changed such that a connection is now closed (as it should) if the `connection: keep-alive` header isn't set.\r\n\r\n@indutny Maybe knows more...\r\n\r\n@tellnes I noticed you were the last person touching this test so I added you as a reviewer. If you don't know, nevermind."}}