{"action":"created","issue":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/352","labels_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/352/labels{/name}","comments_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/352/comments","events_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/352/events","html_url":"https://github.com/rcbops/rpc-openstack/pull/352","id":101671688,"number":352,"title":"Fix MaaS testing","user":{"login":"git-harry","id":687171,"avatar_url":"https://avatars.githubusercontent.com/u/687171?v=3","gravatar_id":"","url":"https://api.github.com/users/git-harry","html_url":"https://github.com/git-harry","followers_url":"https://api.github.com/users/git-harry/followers","following_url":"https://api.github.com/users/git-harry/following{/other_user}","gists_url":"https://api.github.com/users/git-harry/gists{/gist_id}","starred_url":"https://api.github.com/users/git-harry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/git-harry/subscriptions","organizations_url":"https://api.github.com/users/git-harry/orgs","repos_url":"https://api.github.com/users/git-harry/repos","events_url":"https://api.github.com/users/git-harry/events{/privacy}","received_events_url":"https://api.github.com/users/git-harry/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rcbops/rpc-openstack/labels/prio-3","name":"prio-3","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-18T14:36:45Z","updated_at":"2015-11-25T16:14:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/pulls/352","html_url":"https://github.com/rcbops/rpc-openstack/pull/352","diff_url":"https://github.com/rcbops/rpc-openstack/pull/352.diff","patch_url":"https://github.com/rcbops/rpc-openstack/pull/352.patch"},"body":"Rackspace Cloud have made two recent changes that break the testing:\r\n  1. Rackspace Cloud servers automatically get a ping check created\r\n  2. MaaS remote checks have a new attribute called collectors\r\n\r\nCurrently the MaaS testing does not form part of a gate, a recent update\r\nto a RabbitMQ check has not been reflected in the appropriate test file.\r\n\r\nThis commit addresses the aforementioned issues.\r\n\r\nThe test-maas.yml playbook will delete any existing checks from the\r\nentities.\r\n\r\nThe collectors attribute will be removed because it does not need\r\nverifying.\r\n\r\nThe generate-definitions.py script has been updated to allow specific\r\nattributes to be templated. This is required to allow a password in the\r\nRabbitMQ check to be replaced.\r\n\r\nCloses-Issue: https://github.com/rcbops/rpc-openstack/issues/351"},"comment":{"url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/comments/159658972","html_url":"https://github.com/rcbops/rpc-openstack/pull/352#issuecomment-159658972","issue_url":"https://api.github.com/repos/rcbops/rpc-openstack/issues/352","id":159658972,"user":{"login":"git-harry","id":687171,"avatar_url":"https://avatars.githubusercontent.com/u/687171?v=3","gravatar_id":"","url":"https://api.github.com/users/git-harry","html_url":"https://github.com/git-harry","followers_url":"https://api.github.com/users/git-harry/followers","following_url":"https://api.github.com/users/git-harry/following{/other_user}","gists_url":"https://api.github.com/users/git-harry/gists{/gist_id}","starred_url":"https://api.github.com/users/git-harry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/git-harry/subscriptions","organizations_url":"https://api.github.com/users/git-harry/orgs","repos_url":"https://api.github.com/users/git-harry/repos","events_url":"https://api.github.com/users/git-harry/events{/privacy}","received_events_url":"https://api.github.com/users/git-harry/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T16:14:38Z","updated_at":"2015-11-25T16:14:38Z","body":"@d34dh0r53 - I did update the patch but it will all fail again because of all the recent MaaS stuff. I don't know if the MaaS rewrite has made it redundant or if they were looking to do it a better way."}}