{"action":"reopened","number":24,"pull_request":{"url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/pulls/24","id":31332193,"html_url":"https://github.com/sanger-pathogens/gff3toembl/pull/24","diff_url":"https://github.com/sanger-pathogens/gff3toembl/pull/24.diff","patch_url":"https://github.com/sanger-pathogens/gff3toembl/pull/24.patch","issue_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/issues/24","number":24,"state":"open","locked":false,"title":"Refactor / rewrite / remove convert.py","user":{"login":"bewt85","id":1088023,"avatar_url":"https://avatars.githubusercontent.com/u/1088023?v=3","gravatar_id":"","url":"https://api.github.com/users/bewt85","html_url":"https://github.com/bewt85","followers_url":"https://api.github.com/users/bewt85/followers","following_url":"https://api.github.com/users/bewt85/following{/other_user}","gists_url":"https://api.github.com/users/bewt85/gists{/gist_id}","starred_url":"https://api.github.com/users/bewt85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bewt85/subscriptions","organizations_url":"https://api.github.com/users/bewt85/orgs","repos_url":"https://api.github.com/users/bewt85/repos","events_url":"https://api.github.com/users/bewt85/events{/privacy}","received_events_url":"https://api.github.com/users/bewt85/received_events","type":"User","site_admin":false},"body":"As suggested, I've mostly focused on `convert.py` and made minimal changes elsewhere.\r\n\r\nI've gone for something a like a `Factory` without going too class mad.  I could probably have added something like `FeatureFactory` or `Attributes` or an `AttributeFactory` but I don't think it would make things any readable yet.\r\n\r\nThere is probably a little bit more that could be done in `EMBLWriter`.  I'd consider little changes like passing around file handles rather than filenames which means that you could use a `StringIO` in the tests (rather than writing to disk).\r\n\r\nComments / suggested changes are welcome though :)","created_at":"2015-03-17T12:57:25Z","updated_at":"2015-03-17T15:53:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99bfcf2348326fc98288ff027d92857ac1bc86c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/pulls/24/commits","review_comments_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/pulls/24/comments","review_comment_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/issues/24/comments","statuses_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/statuses/cab93e709781791f8d4851b29917d52929ec185b","head":{"label":"bewt85:BT5_refactoring","ref":"BT5_refactoring","sha":"cab93e709781791f8d4851b29917d52929ec185b","user":{"login":"bewt85","id":1088023,"avatar_url":"https://avatars.githubusercontent.com/u/1088023?v=3","gravatar_id":"","url":"https://api.github.com/users/bewt85","html_url":"https://github.com/bewt85","followers_url":"https://api.github.com/users/bewt85/followers","following_url":"https://api.github.com/users/bewt85/following{/other_user}","gists_url":"https://api.github.com/users/bewt85/gists{/gist_id}","starred_url":"https://api.github.com/users/bewt85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bewt85/subscriptions","organizations_url":"https://api.github.com/users/bewt85/orgs","repos_url":"https://api.github.com/users/bewt85/repos","events_url":"https://api.github.com/users/bewt85/events{/privacy}","received_events_url":"https://api.github.com/users/bewt85/received_events","type":"User","site_admin":false},"repo":{"id":32008928,"name":"gff3toembl","full_name":"bewt85/gff3toembl","owner":{"login":"bewt85","id":1088023,"avatar_url":"https://avatars.githubusercontent.com/u/1088023?v=3","gravatar_id":"","url":"https://api.github.com/users/bewt85","html_url":"https://github.com/bewt85","followers_url":"https://api.github.com/users/bewt85/followers","following_url":"https://api.github.com/users/bewt85/following{/other_user}","gists_url":"https://api.github.com/users/bewt85/gists{/gist_id}","starred_url":"https://api.github.com/users/bewt85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bewt85/subscriptions","organizations_url":"https://api.github.com/users/bewt85/orgs","repos_url":"https://api.github.com/users/bewt85/repos","events_url":"https://api.github.com/users/bewt85/events{/privacy}","received_events_url":"https://api.github.com/users/bewt85/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bewt85/gff3toembl","description":"Convert a GFF3 file to a format acceptable for submission to EMBL","fork":true,"url":"https://api.github.com/repos/bewt85/gff3toembl","forks_url":"https://api.github.com/repos/bewt85/gff3toembl/forks","keys_url":"https://api.github.com/repos/bewt85/gff3toembl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bewt85/gff3toembl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bewt85/gff3toembl/teams","hooks_url":"https://api.github.com/repos/bewt85/gff3toembl/hooks","issue_events_url":"https://api.github.com/repos/bewt85/gff3toembl/issues/events{/number}","events_url":"https://api.github.com/repos/bewt85/gff3toembl/events","assignees_url":"https://api.github.com/repos/bewt85/gff3toembl/assignees{/user}","branches_url":"https://api.github.com/repos/bewt85/gff3toembl/branches{/branch}","tags_url":"https://api.github.com/repos/bewt85/gff3toembl/tags","blobs_url":"https://api.github.com/repos/bewt85/gff3toembl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bewt85/gff3toembl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bewt85/gff3toembl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bewt85/gff3toembl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bewt85/gff3toembl/statuses/{sha}","languages_url":"https://api.github.com/repos/bewt85/gff3toembl/languages","stargazers_url":"https://api.github.com/repos/bewt85/gff3toembl/stargazers","contributors_url":"https://api.github.com/repos/bewt85/gff3toembl/contributors","subscribers_url":"https://api.github.com/repos/bewt85/gff3toembl/subscribers","subscription_url":"https://api.github.com/repos/bewt85/gff3toembl/subscription","commits_url":"https://api.github.com/repos/bewt85/gff3toembl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bewt85/gff3toembl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bewt85/gff3toembl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bewt85/gff3toembl/issues/comments{/number}","contents_url":"https://api.github.com/repos/bewt85/gff3toembl/contents/{+path}","compare_url":"https://api.github.com/repos/bewt85/gff3toembl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bewt85/gff3toembl/merges","archive_url":"https://api.github.com/repos/bewt85/gff3toembl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bewt85/gff3toembl/downloads","issues_url":"https://api.github.com/repos/bewt85/gff3toembl/issues{/number}","pulls_url":"https://api.github.com/repos/bewt85/gff3toembl/pulls{/number}","milestones_url":"https://api.github.com/repos/bewt85/gff3toembl/milestones{/number}","notifications_url":"https://api.github.com/repos/bewt85/gff3toembl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bewt85/gff3toembl/labels{/name}","releases_url":"https://api.github.com/repos/bewt85/gff3toembl/releases{/id}","created_at":"2015-03-11T09:25:46Z","updated_at":"2015-03-11T09:25:47Z","pushed_at":"2015-03-17T15:52:19Z","git_url":"git://github.com/bewt85/gff3toembl.git","ssh_url":"git@github.com:bewt85/gff3toembl.git","clone_url":"https://github.com/bewt85/gff3toembl.git","svn_url":"https://github.com/bewt85/gff3toembl","homepage":null,"size":929,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sanger-pathogens:master","ref":"master","sha":"9e909f6d6c175b64291d77a5827f4329f39bfaa6","user":{"login":"sanger-pathogens","id":130803,"avatar_url":"https://avatars.githubusercontent.com/u/130803?v=3","gravatar_id":"","url":"https://api.github.com/users/sanger-pathogens","html_url":"https://github.com/sanger-pathogens","followers_url":"https://api.github.com/users/sanger-pathogens/followers","following_url":"https://api.github.com/users/sanger-pathogens/following{/other_user}","gists_url":"https://api.github.com/users/sanger-pathogens/gists{/gist_id}","starred_url":"https://api.github.com/users/sanger-pathogens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanger-pathogens/subscriptions","organizations_url":"https://api.github.com/users/sanger-pathogens/orgs","repos_url":"https://api.github.com/users/sanger-pathogens/repos","events_url":"https://api.github.com/users/sanger-pathogens/events{/privacy}","received_events_url":"https://api.github.com/users/sanger-pathogens/received_events","type":"Organization","site_admin":false},"repo":{"id":24674325,"name":"gff3toembl","full_name":"sanger-pathogens/gff3toembl","owner":{"login":"sanger-pathogens","id":130803,"avatar_url":"https://avatars.githubusercontent.com/u/130803?v=3","gravatar_id":"","url":"https://api.github.com/users/sanger-pathogens","html_url":"https://github.com/sanger-pathogens","followers_url":"https://api.github.com/users/sanger-pathogens/followers","following_url":"https://api.github.com/users/sanger-pathogens/following{/other_user}","gists_url":"https://api.github.com/users/sanger-pathogens/gists{/gist_id}","starred_url":"https://api.github.com/users/sanger-pathogens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanger-pathogens/subscriptions","organizations_url":"https://api.github.com/users/sanger-pathogens/orgs","repos_url":"https://api.github.com/users/sanger-pathogens/repos","events_url":"https://api.github.com/users/sanger-pathogens/events{/privacy}","received_events_url":"https://api.github.com/users/sanger-pathogens/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sanger-pathogens/gff3toembl","description":"Convert a GFF3 file to a format acceptable for submission to EMBL","fork":false,"url":"https://api.github.com/repos/sanger-pathogens/gff3toembl","forks_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/forks","keys_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/teams","hooks_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/hooks","issue_events_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/issues/events{/number}","events_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/events","assignees_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/assignees{/user}","branches_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/branches{/branch}","tags_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/tags","blobs_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/statuses/{sha}","languages_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/languages","stargazers_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/stargazers","contributors_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/contributors","subscribers_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/subscribers","subscription_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/subscription","commits_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/contents/{+path}","compare_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/merges","archive_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/downloads","issues_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/issues{/number}","pulls_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/pulls{/number}","milestones_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/milestones{/number}","notifications_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/labels{/name}","releases_url":"https://api.github.com/repos/sanger-pathogens/gff3toembl/releases{/id}","created_at":"2014-10-01T10:28:25Z","updated_at":"2015-03-10T16:40:21Z","pushed_at":"2015-03-10T16:40:21Z","git_url":"git://github.com/sanger-pathogens/gff3toembl.git","ssh_url":"git@github.com:sanger-pathogens/gff3toembl.git","clone_url":"https://github.com/sanger-pathogens/gff3toembl.git","svn_url":"https://github.com/sanger-pathogens/gff3toembl","homepage":null,"size":870,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sanger-pathogens/gff3toembl/pulls/24"},"html":{"href":"https://github.com/sanger-pathogens/gff3toembl/pull/24"},"issue":{"href":"https://api.github.com/repos/sanger-pathogens/gff3toembl/issues/24"},"comments":{"href":"https://api.github.com/repos/sanger-pathogens/gff3toembl/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/sanger-pathogens/gff3toembl/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/sanger-pathogens/gff3toembl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sanger-pathogens/gff3toembl/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/sanger-pathogens/gff3toembl/statuses/cab93e709781791f8d4851b29917d52929ec185b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":68,"additions":1536,"deletions":568,"changed_files":11}}