{"push_id":919876552,"size":2,"distinct_size":2,"ref":"refs/heads/GC_adapter_trash_change","head":"52addadbfbd461ba118f684f4bce82b26022d5ec","before":"05115783918f1a4880164b88f2e237998dd94607","commits":[{"sha":"26dd6e6f0f188a210509b2cbc04ab929a629a702","author":{"email":"33d7cd4a1f0d888153f3d082cbe6845e291b1c76@gmail.com","name":"Ryan Houdek"},"message":"Make the Wii U Gamecube adapter work with less magic.\n\nThe Wii U Gamecube controller adapter setup has always been a bit weird. It tries to be as automatic as possible to make the user experience as easy\nas possible.\nThe problem with this approach is that it brings a large disconnect in the user experience because you have the Gamecube controller setup with regular\ngamepads and then for some reason below that you have a \"direct connect\" option which will cause the Gamecube Adapter to overwrite the regular inputs\nif something was connected.\nWhile this works and allows the user to only click one checkbox to get the device working, it breaks the user's experience because they don't really\nknow what \"direct connect\" means and won't look it up to figure out what it is. Just expecting the device to work (At least one occurence of this in\nthe IRC channel in the last week).\n\nThis way around also had the terrible nature of making the code more filthy than it needed to be. The GCAdapter namespace was parasitic and hooked in\nto the regular GC Controller SI class to overwrite the data that it was getting from the default configuration.\nNow instead we have a specific SIDevice class for the Wii U Gamecube adapter. This class is fairly simple and is a child of the regular SI Gamecube\nPad device and only reimplements what it needs to.\nThis also gives the ability to configure controllers individually, which allows the user to configure rumble individually per pad input.\n\nOverall the code is cleaner, and it fits more in line with how the rest of Dolphin works.","distinct":true,"url":"https://api.github.com/repos/Sonicadvance1/dolphin/commits/26dd6e6f0f188a210509b2cbc04ab929a629a702"},{"sha":"52addadbfbd461ba118f684f4bce82b26022d5ec","author":{"email":"33d7cd4a1f0d888153f3d082cbe6845e291b1c76@gmail.com","name":"Ryan Houdek"},"message":"Fix GCPad recalibration shortcut.\n\nDolphin has supported the recalibration shortcut (X+Y+Start) for quite a long while. So if someont's axises are terrible, you could easily\nrecalibrate.\nGames even get the initial calibration upon boot(Most of the time).\n\nWhile changing over the GCAdapter code, I was testing to make sure the reset and calibration shortcuts still worked, turns out they didn't work at\nall.\nLooking in to the problem, we capture the combination properly, and we wait three seconds until we actually fire that off recalibration.\nThe problem is for Nintendo's SDK to properly handle recalibrating, we need to send back data saying that it needs to recalibrate.\nOn hardware this is done as part of the 64bits of data the controller sends back to us.\nOn holding of the controller, bit 61 of the return value is set, which the Nintendo SDK catches, and then signals immediately afterwards a CMD_ORIGIN\ncommand in order to recalibrate the controller.\nWe were outright ignoring this bit, so the library wasn't ever recalibrating. I suspect in the past the class itself used to use the calibration data\nto to offset the data, but somewhere along the lines it got munged out of existence.\n\nThe Gamecube adapter does this shortcut in a bit of a unique way, instead of sending the command and having the library support it and what have you.\nOnce holding the shortcut for the amount of time, the adapter reports back that the controller has actually been disconnected. Then when you let go of\nthe combination, the adapter states that a new device has been connected to that port, and the recalibration happens because a new device is\n\"connected.\"\n\nThis fixes controller calibration for both emulated GC controllers and also the Wii Gamecube Adapter.","distinct":true,"url":"https://api.github.com/repos/Sonicadvance1/dolphin/commits/52addadbfbd461ba118f684f4bce82b26022d5ec"}]}