{"action":"opened","issue":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/issues/3524","labels_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/issues/3524/labels{/name}","comments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/issues/3524/comments","events_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI/issues/3524/events","html_url":"https://github.com/Semantic-Org/Semantic-UI/issues/3524","id":124221423,"number":3524,"title":"Modal onApprove still closes if returning false","user":{"login":"DHNCarlos","id":2259381,"avatar_url":"https://avatars.githubusercontent.com/u/2259381?v=3","gravatar_id":"","url":"https://api.github.com/users/DHNCarlos","html_url":"https://github.com/DHNCarlos","followers_url":"https://api.github.com/users/DHNCarlos/followers","following_url":"https://api.github.com/users/DHNCarlos/following{/other_user}","gists_url":"https://api.github.com/users/DHNCarlos/gists{/gist_id}","starred_url":"https://api.github.com/users/DHNCarlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DHNCarlos/subscriptions","organizations_url":"https://api.github.com/users/DHNCarlos/orgs","repos_url":"https://api.github.com/users/DHNCarlos/repos","events_url":"https://api.github.com/users/DHNCarlos/events{/privacy}","received_events_url":"https://api.github.com/users/DHNCarlos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-12-29T14:56:05Z","updated_at":"2015-12-29T14:56:05Z","closed_at":null,"body":"Reading from the docs, I found out that I can cancel an `onApprove` from hiding the modal by returning false and from another issue (#2351) I found that it only works on buttons that have the `.approve` class so that is what I have done.\r\n\r\nI have an `.approve` button inside the modal `.actions`:\r\n\r\n```\r\n<button class=\"ui green approve new repo button\">Create</button>\r\n```\r\n\r\nI added some logging to my modal as well as set it to verbose logging (`verbose: true`).\r\nSo as a quick test I did\r\n\r\n```\r\nonApprove: function (click) {\r\n        console.log(\"Reached onApprove\", click);\r\n        return false;\r\n}\r\n```\r\n\r\nFrom my browser output I can see that `onApprove does get triggered by the button`\r\n\r\n```\r\nReached onApprove [button.ui.green.approve.new.repo.button, context: button.ui.green.approve.new.repo.button]\r\n```\r\n\r\nBut for some reason onApprove still closes the modal and compeltely ignores my false return. \r\n\r\nFrom the source it seems that when I return false, then it should verbosely log that false was returned but I'm not getting that verbose log entry in my browser."}}