{"push_id":785959666,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"1c8d86fc4d7117b234e3602424974d1d25648c6d","before":"4c8a92fbf503acb35df3ec12a78092bc03e41ad7","commits":[{"sha":"1c8d86fc4d7117b234e3602424974d1d25648c6d","author":{"email":"d95b56ce41a2e1ac4cecdd398defd7414407cc08@review.openstack.org","name":"Jenkins"},"message":"Updated openstack/openstack\nProject: openstack/ceilometer  2e96b159cf7c885e089028bdae94406d1ed0e3ed\n\nremove duplicate log exception message\n\nCurrently, when we poll hardware related metrics, if Keystone(Apache) or\nNova is down, the central agent will print many exception logs such as:\nConnectionError: ('Connection aborted.', error(111, 'ECONNREFUSED'))\nwith very long stack trace, but they are all same information.\n\nThis is because when we poll metrics, we discover the resources first,\nif succeed, then we cache it, if fail, we do not cache it. So in such case,\neach metrics will fail at discover steps, then log exception each time.\n\nAnd actually we have wrapped instance_get_all with a log decorator, which\nmeans each metrics will log twice.\n\nSo this patch removes duplicate exception messages by adding a try...except\nblock in hardware discovery, if there is any exception, we just return an\nempty list, so agent can record this result in cache. Finally the log file\nwill only have one full stack trace exception message for all the hardware\nmetrics.\n\nThe disadvantage of such change is that when Keystone and Nova suddenly become\nOK, then we will lose some data can possible collect. But from another\nperspective, if in a singe interval, some hardware metrics have data but some\nnot is not a consistent thing to end user, so I think in such case we drop some\npart of data (especially it is in start process or unstable status) is acceptable.\n\nChange-Id: I0045a556cde274be8e4ba6c155d3f59b4e0d5b2c\nCloses-Bug: #1493057","distinct":true,"url":"https://api.github.com/repos/openstack/openstack/commits/1c8d86fc4d7117b234e3602424974d1d25648c6d"}]}