{"action":"created","comment":{"url":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/comments/39806043","id":39806043,"diff_hunk":"@@ -0,0 +1,34 @@\n+require 'rspec-steps/dsl'\n+\n+module RSpec::Steps\n+  class Hook < Struct.new(:type, :kind, :action)\n+    def rspec_kind\n+      case kind\n+      when :each\n+        warn_about_promotion(type)\n+        :all\n+      when :step\n+        :each\n+      else\n+        kind\n+      end\n+    end\n+\n+    def warn_about_promotion(scope_name)\n+      RSpec::Steps.warnings[\n+        \"#{scope_name} :each blocks declared for steps are always treated as \" +","path":"lib/rspec-steps/hook.rb","position":19,"original_position":19,"commit_id":"43dea299d959579e60997a1e73e010892f1846bb","original_commit_id":"43dea299d959579e60997a1e73e010892f1846bb","user":{"login":"nyarly","id":127548,"avatar_url":"https://avatars.githubusercontent.com/u/127548?v=3","gravatar_id":"","url":"https://api.github.com/users/nyarly","html_url":"https://github.com/nyarly","followers_url":"https://api.github.com/users/nyarly/followers","following_url":"https://api.github.com/users/nyarly/following{/other_user}","gists_url":"https://api.github.com/users/nyarly/gists{/gist_id}","starred_url":"https://api.github.com/users/nyarly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyarly/subscriptions","organizations_url":"https://api.github.com/users/nyarly/orgs","repos_url":"https://api.github.com/users/nyarly/repos","events_url":"https://api.github.com/users/nyarly/events{/privacy}","received_events_url":"https://api.github.com/users/nyarly/received_events","type":"User","site_admin":false},"body":"`before :step` used to have a particular and important meaning. You can still use it in your own code (mostly to reduce the degree to which we'd have to re-write steps code) but I discovered that e.g. waterpig cannot (because reasons.)\r\n\r\nAll that said: it's better not to use `before :step` and at some future time we might remove it entirely.\r\n\r\nWhat do you think?","created_at":"2015-09-17T22:18:25Z","updated_at":"2015-09-17T22:18:25Z","html_url":"https://github.com/LRDesign/rspec-steps/pull/20#discussion_r39806043","pull_request_url":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/comments/39806043"},"html":{"href":"https://github.com/LRDesign/rspec-steps/pull/20#discussion_r39806043"},"pull_request":{"href":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/20","id":43581556,"html_url":"https://github.com/LRDesign/rspec-steps/pull/20","diff_url":"https://github.com/LRDesign/rspec-steps/pull/20.diff","patch_url":"https://github.com/LRDesign/rspec-steps/pull/20.patch","issue_url":"https://api.github.com/repos/LRDesign/rspec-steps/issues/20","number":20,"state":"open","locked":false,"title":"Complete overall avoids touching RSpec innards","user":{"login":"nyarly","id":127548,"avatar_url":"https://avatars.githubusercontent.com/u/127548?v=3","gravatar_id":"","url":"https://api.github.com/users/nyarly","html_url":"https://github.com/nyarly","followers_url":"https://api.github.com/users/nyarly/followers","following_url":"https://api.github.com/users/nyarly/following{/other_user}","gists_url":"https://api.github.com/users/nyarly/gists{/gist_id}","starred_url":"https://api.github.com/users/nyarly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyarly/subscriptions","organizations_url":"https://api.github.com/users/nyarly/orgs","repos_url":"https://api.github.com/users/nyarly/repos","events_url":"https://api.github.com/users/nyarly/events{/privacy}","received_events_url":"https://api.github.com/users/nyarly/received_events","type":"User","site_admin":false},"body":"Compatible now with RSpec 3.0-3.3+, and forseeable versions of RSpec.\n\nExperience with current code suggests that *at worst* we may have to update the\ntest suite for rspec-steps to keep it working","created_at":"2015-08-28T00:10:03Z","updated_at":"2015-09-17T22:18:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d54f9ffdf68578f1ce0f428731f0121f196dfc4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/20/commits","review_comments_url":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/20/comments","review_comment_url":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LRDesign/rspec-steps/issues/20/comments","statuses_url":"https://api.github.com/repos/LRDesign/rspec-steps/statuses/43dea299d959579e60997a1e73e010892f1846bb","head":{"label":"LRDesign:compatible_version","ref":"compatible_version","sha":"43dea299d959579e60997a1e73e010892f1846bb","user":{"login":"LRDesign","id":9498,"avatar_url":"https://avatars.githubusercontent.com/u/9498?v=3","gravatar_id":"","url":"https://api.github.com/users/LRDesign","html_url":"https://github.com/LRDesign","followers_url":"https://api.github.com/users/LRDesign/followers","following_url":"https://api.github.com/users/LRDesign/following{/other_user}","gists_url":"https://api.github.com/users/LRDesign/gists{/gist_id}","starred_url":"https://api.github.com/users/LRDesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LRDesign/subscriptions","organizations_url":"https://api.github.com/users/LRDesign/orgs","repos_url":"https://api.github.com/users/LRDesign/repos","events_url":"https://api.github.com/users/LRDesign/events{/privacy}","received_events_url":"https://api.github.com/users/LRDesign/received_events","type":"Organization","site_admin":false},"repo":{"id":2193925,"name":"rspec-steps","full_name":"LRDesign/rspec-steps","owner":{"login":"LRDesign","id":9498,"avatar_url":"https://avatars.githubusercontent.com/u/9498?v=3","gravatar_id":"","url":"https://api.github.com/users/LRDesign","html_url":"https://github.com/LRDesign","followers_url":"https://api.github.com/users/LRDesign/followers","following_url":"https://api.github.com/users/LRDesign/following{/other_user}","gists_url":"https://api.github.com/users/LRDesign/gists{/gist_id}","starred_url":"https://api.github.com/users/LRDesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LRDesign/subscriptions","organizations_url":"https://api.github.com/users/LRDesign/orgs","repos_url":"https://api.github.com/users/LRDesign/repos","events_url":"https://api.github.com/users/LRDesign/events{/privacy}","received_events_url":"https://api.github.com/users/LRDesign/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LRDesign/rspec-steps","description":"Stepwise operation for rspec","fork":true,"url":"https://api.github.com/repos/LRDesign/rspec-steps","forks_url":"https://api.github.com/repos/LRDesign/rspec-steps/forks","keys_url":"https://api.github.com/repos/LRDesign/rspec-steps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LRDesign/rspec-steps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LRDesign/rspec-steps/teams","hooks_url":"https://api.github.com/repos/LRDesign/rspec-steps/hooks","issue_events_url":"https://api.github.com/repos/LRDesign/rspec-steps/issues/events{/number}","events_url":"https://api.github.com/repos/LRDesign/rspec-steps/events","assignees_url":"https://api.github.com/repos/LRDesign/rspec-steps/assignees{/user}","branches_url":"https://api.github.com/repos/LRDesign/rspec-steps/branches{/branch}","tags_url":"https://api.github.com/repos/LRDesign/rspec-steps/tags","blobs_url":"https://api.github.com/repos/LRDesign/rspec-steps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LRDesign/rspec-steps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LRDesign/rspec-steps/git/refs{/sha}","trees_url":"https://api.github.com/repos/LRDesign/rspec-steps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LRDesign/rspec-steps/statuses/{sha}","languages_url":"https://api.github.com/repos/LRDesign/rspec-steps/languages","stargazers_url":"https://api.github.com/repos/LRDesign/rspec-steps/stargazers","contributors_url":"https://api.github.com/repos/LRDesign/rspec-steps/contributors","subscribers_url":"https://api.github.com/repos/LRDesign/rspec-steps/subscribers","subscription_url":"https://api.github.com/repos/LRDesign/rspec-steps/subscription","commits_url":"https://api.github.com/repos/LRDesign/rspec-steps/commits{/sha}","git_commits_url":"https://api.github.com/repos/LRDesign/rspec-steps/git/commits{/sha}","comments_url":"https://api.github.com/repos/LRDesign/rspec-steps/comments{/number}","issue_comment_url":"https://api.github.com/repos/LRDesign/rspec-steps/issues/comments{/number}","contents_url":"https://api.github.com/repos/LRDesign/rspec-steps/contents/{+path}","compare_url":"https://api.github.com/repos/LRDesign/rspec-steps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LRDesign/rspec-steps/merges","archive_url":"https://api.github.com/repos/LRDesign/rspec-steps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LRDesign/rspec-steps/downloads","issues_url":"https://api.github.com/repos/LRDesign/rspec-steps/issues{/number}","pulls_url":"https://api.github.com/repos/LRDesign/rspec-steps/pulls{/number}","milestones_url":"https://api.github.com/repos/LRDesign/rspec-steps/milestones{/number}","notifications_url":"https://api.github.com/repos/LRDesign/rspec-steps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LRDesign/rspec-steps/labels{/name}","releases_url":"https://api.github.com/repos/LRDesign/rspec-steps/releases{/id}","created_at":"2011-08-11T21:40:36Z","updated_at":"2015-07-01T12:51:56Z","pushed_at":"2015-09-17T00:38:25Z","git_url":"git://github.com/LRDesign/rspec-steps.git","ssh_url":"git@github.com:LRDesign/rspec-steps.git","clone_url":"https://github.com/LRDesign/rspec-steps.git","svn_url":"https://github.com/LRDesign/rspec-steps","homepage":"","size":737,"stargazers_count":43,"watchers_count":43,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":43,"default_branch":"master"}},"base":{"label":"LRDesign:master","ref":"master","sha":"b27c361dc5dd09fbaa2be036643ffdf4772a123f","user":{"login":"LRDesign","id":9498,"avatar_url":"https://avatars.githubusercontent.com/u/9498?v=3","gravatar_id":"","url":"https://api.github.com/users/LRDesign","html_url":"https://github.com/LRDesign","followers_url":"https://api.github.com/users/LRDesign/followers","following_url":"https://api.github.com/users/LRDesign/following{/other_user}","gists_url":"https://api.github.com/users/LRDesign/gists{/gist_id}","starred_url":"https://api.github.com/users/LRDesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LRDesign/subscriptions","organizations_url":"https://api.github.com/users/LRDesign/orgs","repos_url":"https://api.github.com/users/LRDesign/repos","events_url":"https://api.github.com/users/LRDesign/events{/privacy}","received_events_url":"https://api.github.com/users/LRDesign/received_events","type":"Organization","site_admin":false},"repo":{"id":2193925,"name":"rspec-steps","full_name":"LRDesign/rspec-steps","owner":{"login":"LRDesign","id":9498,"avatar_url":"https://avatars.githubusercontent.com/u/9498?v=3","gravatar_id":"","url":"https://api.github.com/users/LRDesign","html_url":"https://github.com/LRDesign","followers_url":"https://api.github.com/users/LRDesign/followers","following_url":"https://api.github.com/users/LRDesign/following{/other_user}","gists_url":"https://api.github.com/users/LRDesign/gists{/gist_id}","starred_url":"https://api.github.com/users/LRDesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LRDesign/subscriptions","organizations_url":"https://api.github.com/users/LRDesign/orgs","repos_url":"https://api.github.com/users/LRDesign/repos","events_url":"https://api.github.com/users/LRDesign/events{/privacy}","received_events_url":"https://api.github.com/users/LRDesign/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LRDesign/rspec-steps","description":"Stepwise operation for rspec","fork":true,"url":"https://api.github.com/repos/LRDesign/rspec-steps","forks_url":"https://api.github.com/repos/LRDesign/rspec-steps/forks","keys_url":"https://api.github.com/repos/LRDesign/rspec-steps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LRDesign/rspec-steps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LRDesign/rspec-steps/teams","hooks_url":"https://api.github.com/repos/LRDesign/rspec-steps/hooks","issue_events_url":"https://api.github.com/repos/LRDesign/rspec-steps/issues/events{/number}","events_url":"https://api.github.com/repos/LRDesign/rspec-steps/events","assignees_url":"https://api.github.com/repos/LRDesign/rspec-steps/assignees{/user}","branches_url":"https://api.github.com/repos/LRDesign/rspec-steps/branches{/branch}","tags_url":"https://api.github.com/repos/LRDesign/rspec-steps/tags","blobs_url":"https://api.github.com/repos/LRDesign/rspec-steps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LRDesign/rspec-steps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LRDesign/rspec-steps/git/refs{/sha}","trees_url":"https://api.github.com/repos/LRDesign/rspec-steps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LRDesign/rspec-steps/statuses/{sha}","languages_url":"https://api.github.com/repos/LRDesign/rspec-steps/languages","stargazers_url":"https://api.github.com/repos/LRDesign/rspec-steps/stargazers","contributors_url":"https://api.github.com/repos/LRDesign/rspec-steps/contributors","subscribers_url":"https://api.github.com/repos/LRDesign/rspec-steps/subscribers","subscription_url":"https://api.github.com/repos/LRDesign/rspec-steps/subscription","commits_url":"https://api.github.com/repos/LRDesign/rspec-steps/commits{/sha}","git_commits_url":"https://api.github.com/repos/LRDesign/rspec-steps/git/commits{/sha}","comments_url":"https://api.github.com/repos/LRDesign/rspec-steps/comments{/number}","issue_comment_url":"https://api.github.com/repos/LRDesign/rspec-steps/issues/comments{/number}","contents_url":"https://api.github.com/repos/LRDesign/rspec-steps/contents/{+path}","compare_url":"https://api.github.com/repos/LRDesign/rspec-steps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LRDesign/rspec-steps/merges","archive_url":"https://api.github.com/repos/LRDesign/rspec-steps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LRDesign/rspec-steps/downloads","issues_url":"https://api.github.com/repos/LRDesign/rspec-steps/issues{/number}","pulls_url":"https://api.github.com/repos/LRDesign/rspec-steps/pulls{/number}","milestones_url":"https://api.github.com/repos/LRDesign/rspec-steps/milestones{/number}","notifications_url":"https://api.github.com/repos/LRDesign/rspec-steps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LRDesign/rspec-steps/labels{/name}","releases_url":"https://api.github.com/repos/LRDesign/rspec-steps/releases{/id}","created_at":"2011-08-11T21:40:36Z","updated_at":"2015-07-01T12:51:56Z","pushed_at":"2015-09-17T00:38:25Z","git_url":"git://github.com/LRDesign/rspec-steps.git","ssh_url":"git@github.com:LRDesign/rspec-steps.git","clone_url":"https://github.com/LRDesign/rspec-steps.git","svn_url":"https://github.com/LRDesign/rspec-steps","homepage":"","size":737,"stargazers_count":43,"watchers_count":43,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/20"},"html":{"href":"https://github.com/LRDesign/rspec-steps/pull/20"},"issue":{"href":"https://api.github.com/repos/LRDesign/rspec-steps/issues/20"},"comments":{"href":"https://api.github.com/repos/LRDesign/rspec-steps/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LRDesign/rspec-steps/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/LRDesign/rspec-steps/statuses/43dea299d959579e60997a1e73e010892f1846bb"}}}}