{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/713","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/713/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/713/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/713/events","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/713","id":51623713,"number":713,"title":"better way of setting access token for android","user":{"login":"jfirebaugh","id":98601,"avatar_url":"https://avatars.githubusercontent.com/u/98601?v=3","gravatar_id":"","url":"https://api.github.com/users/jfirebaugh","html_url":"https://github.com/jfirebaugh","followers_url":"https://api.github.com/users/jfirebaugh/followers","following_url":"https://api.github.com/users/jfirebaugh/following{/other_user}","gists_url":"https://api.github.com/users/jfirebaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/jfirebaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfirebaugh/subscriptions","organizations_url":"https://api.github.com/users/jfirebaugh/orgs","repos_url":"https://api.github.com/users/jfirebaugh/repos","events_url":"https://api.github.com/users/jfirebaugh/events{/privacy}","received_events_url":"https://api.github.com/users/jfirebaugh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/Android","name":"Android","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/4","html_url":"https://github.com/mapbox/mapbox-gl-native/milestones/Android%20merge","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones/4/labels","id":865624,"number":4,"title":"Android merge","description":"Steps towards https://github.com/mapbox/mapbox-gl-native/issues/595","creator":{"login":"ljbade","id":1215089,"avatar_url":"https://avatars.githubusercontent.com/u/1215089?v=3","gravatar_id":"","url":"https://api.github.com/users/ljbade","html_url":"https://github.com/ljbade","followers_url":"https://api.github.com/users/ljbade/followers","following_url":"https://api.github.com/users/ljbade/following{/other_user}","gists_url":"https://api.github.com/users/ljbade/gists{/gist_id}","starred_url":"https://api.github.com/users/ljbade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljbade/subscriptions","organizations_url":"https://api.github.com/users/ljbade/orgs","repos_url":"https://api.github.com/users/ljbade/repos","events_url":"https://api.github.com/users/ljbade/events{/privacy}","received_events_url":"https://api.github.com/users/ljbade/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":20,"state":"closed","created_at":"2014-11-13T19:53:05Z","updated_at":"2015-10-05T17:44:08Z","due_on":null,"closed_at":"2015-02-13T19:23:43Z"},"comments":29,"created_at":"2014-12-10T23:05:50Z","updated_at":"2015-10-05T17:44:08Z","closed_at":null,"body":"The README on recommends setting the access token by editing a string in MapFragment.java. This means there's a modified file that you have to remember not to check in. Instead, setting the access token should be done via some mechanism that's not under source control."},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments/145609956","html_url":"https://github.com/mapbox/mapbox-gl-native/issues/713#issuecomment-145609956","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/713","id":145609956,"user":{"login":"tobrun","id":2151639,"avatar_url":"https://avatars.githubusercontent.com/u/2151639?v=3","gravatar_id":"","url":"https://api.github.com/users/tobrun","html_url":"https://github.com/tobrun","followers_url":"https://api.github.com/users/tobrun/followers","following_url":"https://api.github.com/users/tobrun/following{/other_user}","gists_url":"https://api.github.com/users/tobrun/gists{/gist_id}","starred_url":"https://api.github.com/users/tobrun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobrun/subscriptions","organizations_url":"https://api.github.com/users/tobrun/orgs","repos_url":"https://api.github.com/users/tobrun/repos","events_url":"https://api.github.com/users/tobrun/events{/privacy}","received_events_url":"https://api.github.com/users/tobrun/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T17:44:08Z","updated_at":"2015-10-05T17:44:08Z","body":"@ljbade @bleege \r\n\r\nI want to pick up this discussion again.\r\n\r\nIn my opinion, when we ship we should support one of the following mechanisms:\r\n - token in res/config.xml with a non-translatable String resource\r\n - token in AndroidManifest with a meta-data tag \r\n\r\nMotivation behind this is that Android developers expect this kind of configuration. \r\nUsing a txt file is bit unconventional. \r\n\r\nTaking in account that we want a gitignored config. I'm suggesting supporting both current implementation and one mentioned above by implementing this at SDK level. The former will only be used by us during development. The latter will only be used by end developers. \r\n\r\n\r\n\r\n\r\n\r\n\r\n"}}