{"action":"closed","number":228,"pull_request":{"url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/pulls/228","id":38455585,"html_url":"https://github.com/campreilly/UnderSeaModelingLibrary/pull/228","diff_url":"https://github.com/campreilly/UnderSeaModelingLibrary/pull/228.diff","patch_url":"https://github.com/campreilly/UnderSeaModelingLibrary/pull/228.patch","issue_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/228","number":228,"state":"closed","locked":false,"title":"Fix USML Visual Studio 2010 Compilation Errors","user":{"login":"campreilly","id":1370874,"avatar_url":"https://avatars.githubusercontent.com/u/1370874?v=3","gravatar_id":"","url":"https://api.github.com/users/campreilly","html_url":"https://github.com/campreilly","followers_url":"https://api.github.com/users/campreilly/followers","following_url":"https://api.github.com/users/campreilly/following{/other_user}","gists_url":"https://api.github.com/users/campreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/campreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campreilly/subscriptions","organizations_url":"https://api.github.com/users/campreilly/orgs","repos_url":"https://api.github.com/users/campreilly/repos","events_url":"https://api.github.com/users/campreilly/events{/privacy}","received_events_url":"https://api.github.com/users/campreilly/received_events","type":"User","site_admin":false},"body":"Resolve issue #224 in which Northrup Grumman complained of several problems getting Visual Studio 2010 to compile USML 2.0 on the master branch as of June 3rd, 2015. Note that these items seem to be working correctly in both Linux and Visual Studio 2012.\r\n\r\nFixes include:\r\n\r\n* Casts had be be added in several places.  For example, VS2010 could not resolve sqrt(n) if \"n\" was an integer.  Changing this to sqrt((double)n) fixed this.\r\n* The variable name \"interface\" was used in several parts of the eigenverb package, but this is a reserved word in VS2010.  Replaced instances of \"interface\" with \"interface_num\".\r\n* Temporarily back out changes from the ```extend_data_grid``` branch.  These are the changes which allowed data_grid to operate on non-scalar fields.But VS2010 is having a problem with initialize::zero().  Plan to fix this in the ```extend_data_grid``` branch and then re-integrate.\r\n* Fixed a problem in seq_augment where not all of the \"middle\" elements were getting copied by memcpy().  Replaced memcpy with a loop.\r\n* The assignment operator for orientation objects was failing in sensor_model::update_sensor() because the tilt angle/direction of the constructor was not initializing _axis().\r\n","created_at":"2015-06-24T15:37:52Z","updated_at":"2015-07-06T17:52:35Z","closed_at":"2015-07-06T17:52:34Z","merged_at":"2015-07-06T17:52:34Z","merge_commit_sha":"adf07bcbca66c73dd3fd0770dc698f47a34dd337","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/pulls/228/commits","review_comments_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/pulls/228/comments","review_comment_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/228/comments","statuses_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/statuses/3d5fc9979044f7623542613ef699c142ae777cfd","head":{"label":"campreilly:vs2010errors","ref":"vs2010errors","sha":"3d5fc9979044f7623542613ef699c142ae777cfd","user":{"login":"campreilly","id":1370874,"avatar_url":"https://avatars.githubusercontent.com/u/1370874?v=3","gravatar_id":"","url":"https://api.github.com/users/campreilly","html_url":"https://github.com/campreilly","followers_url":"https://api.github.com/users/campreilly/followers","following_url":"https://api.github.com/users/campreilly/following{/other_user}","gists_url":"https://api.github.com/users/campreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/campreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campreilly/subscriptions","organizations_url":"https://api.github.com/users/campreilly/orgs","repos_url":"https://api.github.com/users/campreilly/repos","events_url":"https://api.github.com/users/campreilly/events{/privacy}","received_events_url":"https://api.github.com/users/campreilly/received_events","type":"User","site_admin":false},"repo":{"id":3640368,"name":"UnderSeaModelingLibrary","full_name":"campreilly/UnderSeaModelingLibrary","owner":{"login":"campreilly","id":1370874,"avatar_url":"https://avatars.githubusercontent.com/u/1370874?v=3","gravatar_id":"","url":"https://api.github.com/users/campreilly","html_url":"https://github.com/campreilly","followers_url":"https://api.github.com/users/campreilly/followers","following_url":"https://api.github.com/users/campreilly/following{/other_user}","gists_url":"https://api.github.com/users/campreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/campreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campreilly/subscriptions","organizations_url":"https://api.github.com/users/campreilly/orgs","repos_url":"https://api.github.com/users/campreilly/repos","events_url":"https://api.github.com/users/campreilly/events{/privacy}","received_events_url":"https://api.github.com/users/campreilly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/campreilly/UnderSeaModelingLibrary","description":"The Under Sea Modeling Library (USML) is a collection of C++ software development modules for sonar modeling and simulation.","fork":false,"url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary","forks_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/forks","keys_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/teams","hooks_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/hooks","issue_events_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/events{/number}","events_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/events","assignees_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/assignees{/user}","branches_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/branches{/branch}","tags_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/tags","blobs_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/git/refs{/sha}","trees_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/statuses/{sha}","languages_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/languages","stargazers_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/stargazers","contributors_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/contributors","subscribers_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/subscribers","subscription_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/subscription","commits_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/commits{/sha}","git_commits_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/git/commits{/sha}","comments_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/comments{/number}","issue_comment_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/comments{/number}","contents_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/contents/{+path}","compare_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/merges","archive_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/downloads","issues_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues{/number}","pulls_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/pulls{/number}","milestones_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/milestones{/number}","notifications_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/labels{/name}","releases_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/releases{/id}","created_at":"2012-03-06T17:08:24Z","updated_at":"2015-05-23T12:26:59Z","pushed_at":"2015-07-06T17:52:35Z","git_url":"git://github.com/campreilly/UnderSeaModelingLibrary.git","ssh_url":"git@github.com:campreilly/UnderSeaModelingLibrary.git","clone_url":"https://github.com/campreilly/UnderSeaModelingLibrary.git","svn_url":"https://github.com/campreilly/UnderSeaModelingLibrary","homepage":"","size":1068961,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":14,"forks":8,"open_issues":14,"watchers":10,"default_branch":"master"}},"base":{"label":"campreilly:master","ref":"master","sha":"808c391ecc617c68847d87f22891f58e23bf1af5","user":{"login":"campreilly","id":1370874,"avatar_url":"https://avatars.githubusercontent.com/u/1370874?v=3","gravatar_id":"","url":"https://api.github.com/users/campreilly","html_url":"https://github.com/campreilly","followers_url":"https://api.github.com/users/campreilly/followers","following_url":"https://api.github.com/users/campreilly/following{/other_user}","gists_url":"https://api.github.com/users/campreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/campreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campreilly/subscriptions","organizations_url":"https://api.github.com/users/campreilly/orgs","repos_url":"https://api.github.com/users/campreilly/repos","events_url":"https://api.github.com/users/campreilly/events{/privacy}","received_events_url":"https://api.github.com/users/campreilly/received_events","type":"User","site_admin":false},"repo":{"id":3640368,"name":"UnderSeaModelingLibrary","full_name":"campreilly/UnderSeaModelingLibrary","owner":{"login":"campreilly","id":1370874,"avatar_url":"https://avatars.githubusercontent.com/u/1370874?v=3","gravatar_id":"","url":"https://api.github.com/users/campreilly","html_url":"https://github.com/campreilly","followers_url":"https://api.github.com/users/campreilly/followers","following_url":"https://api.github.com/users/campreilly/following{/other_user}","gists_url":"https://api.github.com/users/campreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/campreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campreilly/subscriptions","organizations_url":"https://api.github.com/users/campreilly/orgs","repos_url":"https://api.github.com/users/campreilly/repos","events_url":"https://api.github.com/users/campreilly/events{/privacy}","received_events_url":"https://api.github.com/users/campreilly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/campreilly/UnderSeaModelingLibrary","description":"The Under Sea Modeling Library (USML) is a collection of C++ software development modules for sonar modeling and simulation.","fork":false,"url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary","forks_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/forks","keys_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/teams","hooks_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/hooks","issue_events_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/events{/number}","events_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/events","assignees_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/assignees{/user}","branches_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/branches{/branch}","tags_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/tags","blobs_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/git/refs{/sha}","trees_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/statuses/{sha}","languages_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/languages","stargazers_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/stargazers","contributors_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/contributors","subscribers_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/subscribers","subscription_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/subscription","commits_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/commits{/sha}","git_commits_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/git/commits{/sha}","comments_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/comments{/number}","issue_comment_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/comments{/number}","contents_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/contents/{+path}","compare_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/merges","archive_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/downloads","issues_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues{/number}","pulls_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/pulls{/number}","milestones_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/milestones{/number}","notifications_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/labels{/name}","releases_url":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/releases{/id}","created_at":"2012-03-06T17:08:24Z","updated_at":"2015-05-23T12:26:59Z","pushed_at":"2015-07-06T17:52:35Z","git_url":"git://github.com/campreilly/UnderSeaModelingLibrary.git","ssh_url":"git@github.com:campreilly/UnderSeaModelingLibrary.git","clone_url":"https://github.com/campreilly/UnderSeaModelingLibrary.git","svn_url":"https://github.com/campreilly/UnderSeaModelingLibrary","homepage":"","size":1068961,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":14,"forks":8,"open_issues":14,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/pulls/228"},"html":{"href":"https://github.com/campreilly/UnderSeaModelingLibrary/pull/228"},"issue":{"href":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/228"},"comments":{"href":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/campreilly/UnderSeaModelingLibrary/statuses/3d5fc9979044f7623542613ef699c142ae777cfd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"campreilly","id":1370874,"avatar_url":"https://avatars.githubusercontent.com/u/1370874?v=3","gravatar_id":"","url":"https://api.github.com/users/campreilly","html_url":"https://github.com/campreilly","followers_url":"https://api.github.com/users/campreilly/followers","following_url":"https://api.github.com/users/campreilly/following{/other_user}","gists_url":"https://api.github.com/users/campreilly/gists{/gist_id}","starred_url":"https://api.github.com/users/campreilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campreilly/subscriptions","organizations_url":"https://api.github.com/users/campreilly/orgs","repos_url":"https://api.github.com/users/campreilly/repos","events_url":"https://api.github.com/users/campreilly/events{/privacy}","received_events_url":"https://api.github.com/users/campreilly/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":9,"additions":28,"deletions":28,"changed_files":12}}