{"action":"created","issue":{"url":"https://api.github.com/repos/ericmj/postgrex/issues/120","labels_url":"https://api.github.com/repos/ericmj/postgrex/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/ericmj/postgrex/issues/120/comments","events_url":"https://api.github.com/repos/ericmj/postgrex/issues/120/events","html_url":"https://github.com/ericmj/postgrex/pull/120","id":119312070,"number":120,"title":"Start to separate the notifications API","user":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-11-28T18:38:15Z","updated_at":"2015-11-29T23:16:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ericmj/postgrex/pulls/120","html_url":"https://github.com/ericmj/postgrex/pull/120","diff_url":"https://github.com/ericmj/postgrex/pull/120.diff","patch_url":"https://github.com/ericmj/postgrex/pull/120.patch"},"body":"This is the WIP for the separation of the notifications API into `Postgrex.Notifications.Connection`. I'm starting to open the PR now so that you can have a look at how it's going, I was unfamiliar with the postgrex codebase before this so I don't feel super confident :)\r\n\r\nI only have one failing test that I'll try and debug tomorrow, but all the other tests (including `test/postgrex/notification_test.exs`) are green.\r\n\r\nThe thing I'm the most unsure about is handling TCP packets that do not form complete responses. I guess this is handled by `Postgrex.Protocol`, but this is the thing I'm the most unsure about.\r\n\r\nAlso, note that some refactoring/cleanup could be done to `Postgrex.Notifications.Connection` and I still haven't started writing docs."},"comment":{"url":"https://api.github.com/repos/ericmj/postgrex/issues/comments/160480420","html_url":"https://github.com/ericmj/postgrex/pull/120#issuecomment-160480420","issue_url":"https://api.github.com/repos/ericmj/postgrex/issues/120","id":160480420,"user":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"created_at":"2015-11-29T23:16:25Z","updated_at":"2015-11-29T23:16:25Z","body":"@ericmj addressed all the comments and moved to `Postgrex.Notifications`. Ready for review!"}}