{"action":"closed","number":81,"pull_request":{"url":"https://api.github.com/repos/ros2/rmw_opensplice/pulls/81","id":44249641,"html_url":"https://github.com/ros2/rmw_opensplice/pull/81","diff_url":"https://github.com/ros2/rmw_opensplice/pull/81.diff","patch_url":"https://github.com/ros2/rmw_opensplice/pull/81.patch","issue_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/81","number":81,"state":"closed","locked":false,"title":"Support changing the ROS_DOMAIN_ID in OpenSplice without changing the config file","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"Currently you have to update the system installed OpenSplice config file, or override it using `OSPL_URI` in order to use a different `ROS_DOMAIN_ID`. This is out of sync with the other implementations and inconvenient.\r\n\r\nSo this pull request works around this issue by copying the default configuration for OpenSplice into the `opensplice_cmake_module` package, replacing the default domain id (`0`) with `${ROS_DOMAIN_ID}`, installing it to the workspace, and changing the environment hooks to default to referencing this file rather than the built-in one. This means that when this config file is evaluated by OpenSplice it will substitute the `${ROS_DOMAIN_ID}` in the config file with what ever is in the environment. This strategy is based on the feedback I got on their forum:\r\n\r\nhttp://forums.opensplice.org/index.php?/topic/2591-programmatically-choosing-the-domain-id/#entry4471\r\n\r\nThe other thing we have to do is to ensure that the `ROS_DOMAIN_ID` is set before trying to use OpenSplice, and therefore forcing the configuration file to be evaluated. See https://github.com/ros2/rclcpp/pull/102\r\n\r\nStill testing, not quite ready for review.","created_at":"2015-09-04T18:47:56Z","updated_at":"2015-09-17T21:20:05Z","closed_at":"2015-09-17T21:20:05Z","merged_at":"2015-09-17T21:20:05Z","merge_commit_sha":"d4b288d3732ea72f56b0e920ca6c49bd2cb76af7","assignee":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rmw_opensplice/pulls/81/commits","review_comments_url":"https://api.github.com/repos/ros2/rmw_opensplice/pulls/81/comments","review_comment_url":"https://api.github.com/repos/ros2/rmw_opensplice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/81/comments","statuses_url":"https://api.github.com/repos/ros2/rmw_opensplice/statuses/bdd82d246e2b0c2e7da884c91429074f672ed781","head":{"label":"ros2:opensplice_dynamic_ros_domain_id","ref":"opensplice_dynamic_ros_domain_id","sha":"bdd82d246e2b0c2e7da884c91429074f672ed781","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":22737337,"name":"rmw_opensplice","full_name":"ros2/rmw_opensplice","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rmw_opensplice","description":"Implementation of the ROS Middleware (rmw) interface using PrismTech's OpenSplice DDS.","fork":false,"url":"https://api.github.com/repos/ros2/rmw_opensplice","forks_url":"https://api.github.com/repos/ros2/rmw_opensplice/forks","keys_url":"https://api.github.com/repos/ros2/rmw_opensplice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw_opensplice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw_opensplice/teams","hooks_url":"https://api.github.com/repos/ros2/rmw_opensplice/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw_opensplice/events","assignees_url":"https://api.github.com/repos/ros2/rmw_opensplice/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw_opensplice/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw_opensplice/tags","blobs_url":"https://api.github.com/repos/ros2/rmw_opensplice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw_opensplice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw_opensplice/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw_opensplice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw_opensplice/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw_opensplice/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw_opensplice/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw_opensplice/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw_opensplice/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw_opensplice/subscription","commits_url":"https://api.github.com/repos/ros2/rmw_opensplice/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw_opensplice/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw_opensplice/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw_opensplice/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw_opensplice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw_opensplice/merges","archive_url":"https://api.github.com/repos/ros2/rmw_opensplice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw_opensplice/downloads","issues_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw_opensplice/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw_opensplice/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw_opensplice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw_opensplice/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw_opensplice/releases{/id}","created_at":"2014-08-07T21:36:52Z","updated_at":"2015-04-30T00:26:57Z","pushed_at":"2015-09-17T21:20:05Z","git_url":"git://github.com/ros2/rmw_opensplice.git","ssh_url":"git@github.com:ros2/rmw_opensplice.git","clone_url":"https://github.com/ros2/rmw_opensplice.git","svn_url":"https://github.com/ros2/rmw_opensplice","homepage":"","size":1544,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"51547ce27b84bb8d129e6e485f24d082826a6466","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":22737337,"name":"rmw_opensplice","full_name":"ros2/rmw_opensplice","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rmw_opensplice","description":"Implementation of the ROS Middleware (rmw) interface using PrismTech's OpenSplice DDS.","fork":false,"url":"https://api.github.com/repos/ros2/rmw_opensplice","forks_url":"https://api.github.com/repos/ros2/rmw_opensplice/forks","keys_url":"https://api.github.com/repos/ros2/rmw_opensplice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw_opensplice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw_opensplice/teams","hooks_url":"https://api.github.com/repos/ros2/rmw_opensplice/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw_opensplice/events","assignees_url":"https://api.github.com/repos/ros2/rmw_opensplice/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw_opensplice/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw_opensplice/tags","blobs_url":"https://api.github.com/repos/ros2/rmw_opensplice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw_opensplice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw_opensplice/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw_opensplice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw_opensplice/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw_opensplice/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw_opensplice/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw_opensplice/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw_opensplice/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw_opensplice/subscription","commits_url":"https://api.github.com/repos/ros2/rmw_opensplice/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw_opensplice/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw_opensplice/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw_opensplice/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw_opensplice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw_opensplice/merges","archive_url":"https://api.github.com/repos/ros2/rmw_opensplice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw_opensplice/downloads","issues_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw_opensplice/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw_opensplice/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw_opensplice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw_opensplice/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw_opensplice/releases{/id}","created_at":"2014-08-07T21:36:52Z","updated_at":"2015-04-30T00:26:57Z","pushed_at":"2015-09-17T21:20:05Z","git_url":"git://github.com/ros2/rmw_opensplice.git","ssh_url":"git@github.com:ros2/rmw_opensplice.git","clone_url":"https://github.com/ros2/rmw_opensplice.git","svn_url":"https://github.com/ros2/rmw_opensplice","homepage":"","size":1544,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rmw_opensplice/pulls/81"},"html":{"href":"https://github.com/ros2/rmw_opensplice/pull/81"},"issue":{"href":"https://api.github.com/repos/ros2/rmw_opensplice/issues/81"},"comments":{"href":"https://api.github.com/repos/ros2/rmw_opensplice/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rmw_opensplice/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rmw_opensplice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rmw_opensplice/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rmw_opensplice/statuses/bdd82d246e2b0c2e7da884c91429074f672ed781"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"comments":11,"review_comments":11,"commits":1,"additions":154,"deletions":7,"changed_files":5}}