{"action":"created","issue":{"url":"https://api.github.com/repos/cyclus/cycamore/issues/318","labels_url":"https://api.github.com/repos/cyclus/cycamore/issues/318/labels{/name}","comments_url":"https://api.github.com/repos/cyclus/cycamore/issues/318/comments","events_url":"https://api.github.com/repos/cyclus/cycamore/issues/318/events","html_url":"https://github.com/cyclus/cycamore/pull/318","id":68768887,"number":318,"title":"Policy","user":{"login":"gidden","id":1392657,"avatar_url":"https://avatars.githubusercontent.com/u/1392657?v=3","gravatar_id":"","url":"https://api.github.com/users/gidden","html_url":"https://github.com/gidden","followers_url":"https://api.github.com/users/gidden/followers","following_url":"https://api.github.com/users/gidden/following{/other_user}","gists_url":"https://api.github.com/users/gidden/gists{/gist_id}","starred_url":"https://api.github.com/users/gidden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gidden/subscriptions","organizations_url":"https://api.github.com/users/gidden/orgs","repos_url":"https://api.github.com/users/gidden/repos","events_url":"https://api.github.com/users/gidden/events{/privacy}","received_events_url":"https://api.github.com/users/gidden/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cyclus/cycamore/milestones/14","html_url":"https://github.com/cyclus/cycamore/milestones/v1.4","labels_url":"https://api.github.com/repos/cyclus/cycamore/milestones/14/labels","id":1077347,"number":14,"title":"v1.4","description":null,"creator":{"login":"mbmcgarry","id":8630709,"avatar_url":"https://avatars.githubusercontent.com/u/8630709?v=3","gravatar_id":"","url":"https://api.github.com/users/mbmcgarry","html_url":"https://github.com/mbmcgarry","followers_url":"https://api.github.com/users/mbmcgarry/followers","following_url":"https://api.github.com/users/mbmcgarry/following{/other_user}","gists_url":"https://api.github.com/users/mbmcgarry/gists{/gist_id}","starred_url":"https://api.github.com/users/mbmcgarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbmcgarry/subscriptions","organizations_url":"https://api.github.com/users/mbmcgarry/orgs","repos_url":"https://api.github.com/users/mbmcgarry/repos","events_url":"https://api.github.com/users/mbmcgarry/events{/privacy}","received_events_url":"https://api.github.com/users/mbmcgarry/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":1,"state":"open","created_at":"2015-04-21T15:22:54Z","updated_at":"2015-04-27T15:08:09Z","due_on":null,"closed_at":null},"comments":16,"created_at":"2015-04-15T19:33:12Z","updated_at":"2015-04-27T15:08:09Z","closed_at":"2015-04-27T15:08:09Z","pull_request":{"url":"https://api.github.com/repos/cyclus/cycamore/pulls/318","html_url":"https://github.com/cyclus/cycamore/pull/318","diff_url":"https://github.com/cyclus/cycamore/pull/318.diff","patch_url":"https://github.com/cyclus/cycamore/pull/318.patch"},"body":"This PR updates the Source to use a buy policy and the Sink to use a sell policy. All tests pass! I removed tests that are no longer needed as they are covered by the objects used. 46 additions, 307 deletions!\r\n\r\nThe possible deal breaker for this PR deals with the source and how it uses the sell policy. Specifically, it must fill a buffer with tracked material upon entering the simulation, which becomes a problem *if* no output recipe is specified (we don't allow empty compositions). For now, I fill it with hydrogen. I'm open to other ideas. Note that in conjunction with how the sell policy works, the composition will be transmuted when traded anyway. In other words, it works, but it may not work *exactly* like we want. Again, open to suggestions."},"comment":{"url":"https://api.github.com/repos/cyclus/cycamore/issues/comments/96694653","html_url":"https://github.com/cyclus/cycamore/pull/318#issuecomment-96694653","issue_url":"https://api.github.com/repos/cyclus/cycamore/issues/318","id":96694653,"user":{"login":"gidden","id":1392657,"avatar_url":"https://avatars.githubusercontent.com/u/1392657?v=3","gravatar_id":"","url":"https://api.github.com/users/gidden","html_url":"https://github.com/gidden","followers_url":"https://api.github.com/users/gidden/followers","following_url":"https://api.github.com/users/gidden/following{/other_user}","gists_url":"https://api.github.com/users/gidden/gists{/gist_id}","starred_url":"https://api.github.com/users/gidden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gidden/subscriptions","organizations_url":"https://api.github.com/users/gidden/orgs","repos_url":"https://api.github.com/users/gidden/repos","events_url":"https://api.github.com/users/gidden/events{/privacy}","received_events_url":"https://api.github.com/users/gidden/received_events","type":"User","site_admin":false},"created_at":"2015-04-27T15:08:09Z","updated_at":"2015-04-27T15:08:09Z","body":"I don't disagree that this is requiring some gymnastics. I've opened #326 which includes only the sink portion of this PR.\r\n\r\nThanks for the discussion all, I think it was really valuable to hash through some of these ideas."}}