{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/RxJS/issues/787","labels_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/787/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/787/comments","events_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/787/events","html_url":"https://github.com/ReactiveX/RxJS/issues/787","id":118890168,"number":787,"title":"Rename `fromCallback` to `factoryFromCallback`","user":{"login":"blesh","id":1540597,"avatar_url":"https://avatars.githubusercontent.com/u/1540597?v=3","gravatar_id":"","url":"https://api.github.com/users/blesh","html_url":"https://github.com/blesh","followers_url":"https://api.github.com/users/blesh/followers","following_url":"https://api.github.com/users/blesh/following{/other_user}","gists_url":"https://api.github.com/users/blesh/gists{/gist_id}","starred_url":"https://api.github.com/users/blesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blesh/subscriptions","organizations_url":"https://api.github.com/users/blesh/orgs","repos_url":"https://api.github.com/users/blesh/repos","events_url":"https://api.github.com/users/blesh/events{/privacy}","received_events_url":"https://api.github.com/users/blesh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ReactiveX/RxJS/labels/type:%20discussion","name":"type: discussion","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":34,"created_at":"2015-11-25T17:49:34Z","updated_at":"2015-12-03T18:24:32Z","closed_at":null,"body":"Since `Observable.fromCallback` doesn't really create an Observable, but rather creates a function, the name is a little confusing. `Observable.factoryFromCallback` makes a little more sense, as suggested by @staltz.\r\n\r\nRelated discussion in #729 is around whether or not it should be in Rx \"core\". It adds a lot of weight for limited value, IMO. I personally have never used this method, but perhaps it's more popular than I know.\r\n\r\n- Should we rename it to `factoryFromCallback`?\r\n- Should it be core?"},"comment":{"url":"https://api.github.com/repos/ReactiveX/RxJS/issues/comments/161738781","html_url":"https://github.com/ReactiveX/RxJS/issues/787#issuecomment-161738781","issue_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/787","id":161738781,"user":{"login":"blesh","id":1540597,"avatar_url":"https://avatars.githubusercontent.com/u/1540597?v=3","gravatar_id":"","url":"https://api.github.com/users/blesh","html_url":"https://github.com/blesh","followers_url":"https://api.github.com/users/blesh/followers","following_url":"https://api.github.com/users/blesh/following{/other_user}","gists_url":"https://api.github.com/users/blesh/gists{/gist_id}","starred_url":"https://api.github.com/users/blesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blesh/subscriptions","organizations_url":"https://api.github.com/users/blesh/orgs","repos_url":"https://api.github.com/users/blesh/repos","events_url":"https://api.github.com/users/blesh/events{/privacy}","received_events_url":"https://api.github.com/users/blesh/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T18:24:32Z","updated_at":"2015-12-03T18:24:32Z","body":"> In terms of consistency I think it might be worth adding since all native methods have it.\r\n\r\nThat's fine, I'm willing to keep it on the methods that match native signature names: `filter`, `map`, `reduce`, `forEach`, only for consistency's sake.\r\n\r\n> What I'd really want is an observifyAll\r\n\r\nI agree this would be a very cool feature, and I'd also like to see this. Make an issue (or better, submit a PR) and we'll get it in."}}