{"action":"closed","number":310,"pull_request":{"url":"https://api.github.com/repos/splitrb/split/pulls/310","id":33387279,"html_url":"https://github.com/splitrb/split/pull/310","diff_url":"https://github.com/splitrb/split/pull/310.diff","patch_url":"https://github.com/splitrb/split/pull/310.patch","issue_url":"https://api.github.com/repos/splitrb/split/issues/310","number":310,"state":"closed","locked":false,"title":"If the DNS resolution fails for your redis server, ruby will throw a SocketError, which is currently not rescued by the ab_test helper","user":{"login":"fusion2004","id":192395,"avatar_url":"https://avatars.githubusercontent.com/u/192395?v=3","gravatar_id":"","url":"https://api.github.com/users/fusion2004","html_url":"https://github.com/fusion2004","followers_url":"https://api.github.com/users/fusion2004/followers","following_url":"https://api.github.com/users/fusion2004/following{/other_user}","gists_url":"https://api.github.com/users/fusion2004/gists{/gist_id}","starred_url":"https://api.github.com/users/fusion2004/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusion2004/subscriptions","organizations_url":"https://api.github.com/users/fusion2004/orgs","repos_url":"https://api.github.com/users/fusion2004/repos","events_url":"https://api.github.com/users/fusion2004/events{/privacy}","received_events_url":"https://api.github.com/users/fusion2004/received_events","type":"User","site_admin":false},"body":"Protip: Don't delete a redis instance your production server is currently using.\r\n\r\nIf wanted, I can add both:\r\n1. Checking for the specific error message DNS resolution failures produce: `getaddrinfo: Name or service not known`\r\n2. A test for raising this specific error, though I'm not exactly where it should go. The `helper_spec.rb` file does have tests for redis being unavailable, but it currently only tests the raise of `Errno::ECONNREFUSED` and not `Redis::CannotConnectError`.","created_at":"2015-04-15T19:18:53Z","updated_at":"2015-04-15T23:16:30Z","closed_at":"2015-04-15T23:16:30Z","merged_at":"2015-04-15T23:16:30Z","merge_commit_sha":"0cf01fba70830b531e2a88c9004b400d07c9e8d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/splitrb/split/pulls/310/commits","review_comments_url":"https://api.github.com/repos/splitrb/split/pulls/310/comments","review_comment_url":"https://api.github.com/repos/splitrb/split/pulls/comments{/number}","comments_url":"https://api.github.com/repos/splitrb/split/issues/310/comments","statuses_url":"https://api.github.com/repos/splitrb/split/statuses/79aee0ee240ac172ce530d9e9a660df694974e64","head":{"label":"fusion2004:handle-dns-resolving-errors","ref":"handle-dns-resolving-errors","sha":"79aee0ee240ac172ce530d9e9a660df694974e64","user":{"login":"fusion2004","id":192395,"avatar_url":"https://avatars.githubusercontent.com/u/192395?v=3","gravatar_id":"","url":"https://api.github.com/users/fusion2004","html_url":"https://github.com/fusion2004","followers_url":"https://api.github.com/users/fusion2004/followers","following_url":"https://api.github.com/users/fusion2004/following{/other_user}","gists_url":"https://api.github.com/users/fusion2004/gists{/gist_id}","starred_url":"https://api.github.com/users/fusion2004/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusion2004/subscriptions","organizations_url":"https://api.github.com/users/fusion2004/orgs","repos_url":"https://api.github.com/users/fusion2004/repos","events_url":"https://api.github.com/users/fusion2004/events{/privacy}","received_events_url":"https://api.github.com/users/fusion2004/received_events","type":"User","site_admin":false},"repo":{"id":34013152,"name":"split","full_name":"fusion2004/split","owner":{"login":"fusion2004","id":192395,"avatar_url":"https://avatars.githubusercontent.com/u/192395?v=3","gravatar_id":"","url":"https://api.github.com/users/fusion2004","html_url":"https://github.com/fusion2004","followers_url":"https://api.github.com/users/fusion2004/followers","following_url":"https://api.github.com/users/fusion2004/following{/other_user}","gists_url":"https://api.github.com/users/fusion2004/gists{/gist_id}","starred_url":"https://api.github.com/users/fusion2004/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusion2004/subscriptions","organizations_url":"https://api.github.com/users/fusion2004/orgs","repos_url":"https://api.github.com/users/fusion2004/repos","events_url":"https://api.github.com/users/fusion2004/events{/privacy}","received_events_url":"https://api.github.com/users/fusion2004/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fusion2004/split","description":":chart_with_upwards_trend: The Rack Based AB testing framework","fork":true,"url":"https://api.github.com/repos/fusion2004/split","forks_url":"https://api.github.com/repos/fusion2004/split/forks","keys_url":"https://api.github.com/repos/fusion2004/split/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fusion2004/split/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fusion2004/split/teams","hooks_url":"https://api.github.com/repos/fusion2004/split/hooks","issue_events_url":"https://api.github.com/repos/fusion2004/split/issues/events{/number}","events_url":"https://api.github.com/repos/fusion2004/split/events","assignees_url":"https://api.github.com/repos/fusion2004/split/assignees{/user}","branches_url":"https://api.github.com/repos/fusion2004/split/branches{/branch}","tags_url":"https://api.github.com/repos/fusion2004/split/tags","blobs_url":"https://api.github.com/repos/fusion2004/split/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fusion2004/split/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fusion2004/split/git/refs{/sha}","trees_url":"https://api.github.com/repos/fusion2004/split/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fusion2004/split/statuses/{sha}","languages_url":"https://api.github.com/repos/fusion2004/split/languages","stargazers_url":"https://api.github.com/repos/fusion2004/split/stargazers","contributors_url":"https://api.github.com/repos/fusion2004/split/contributors","subscribers_url":"https://api.github.com/repos/fusion2004/split/subscribers","subscription_url":"https://api.github.com/repos/fusion2004/split/subscription","commits_url":"https://api.github.com/repos/fusion2004/split/commits{/sha}","git_commits_url":"https://api.github.com/repos/fusion2004/split/git/commits{/sha}","comments_url":"https://api.github.com/repos/fusion2004/split/comments{/number}","issue_comment_url":"https://api.github.com/repos/fusion2004/split/issues/comments{/number}","contents_url":"https://api.github.com/repos/fusion2004/split/contents/{+path}","compare_url":"https://api.github.com/repos/fusion2004/split/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fusion2004/split/merges","archive_url":"https://api.github.com/repos/fusion2004/split/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fusion2004/split/downloads","issues_url":"https://api.github.com/repos/fusion2004/split/issues{/number}","pulls_url":"https://api.github.com/repos/fusion2004/split/pulls{/number}","milestones_url":"https://api.github.com/repos/fusion2004/split/milestones{/number}","notifications_url":"https://api.github.com/repos/fusion2004/split/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fusion2004/split/labels{/name}","releases_url":"https://api.github.com/repos/fusion2004/split/releases{/id}","created_at":"2015-04-15T19:08:12Z","updated_at":"2015-04-15T19:08:12Z","pushed_at":"2015-04-15T19:15:06Z","git_url":"git://github.com/fusion2004/split.git","ssh_url":"git@github.com:fusion2004/split.git","clone_url":"https://github.com/fusion2004/split.git","svn_url":"https://github.com/fusion2004/split","homepage":"http://libraries.io/rubygems/split","size":2096,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"splitrb:master","ref":"master","sha":"004be4225d9fa5840fc1e7fed02c17983c191deb","user":{"login":"splitrb","id":11708074,"avatar_url":"https://avatars.githubusercontent.com/u/11708074?v=3","gravatar_id":"","url":"https://api.github.com/users/splitrb","html_url":"https://github.com/splitrb","followers_url":"https://api.github.com/users/splitrb/followers","following_url":"https://api.github.com/users/splitrb/following{/other_user}","gists_url":"https://api.github.com/users/splitrb/gists{/gist_id}","starred_url":"https://api.github.com/users/splitrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitrb/subscriptions","organizations_url":"https://api.github.com/users/splitrb/orgs","repos_url":"https://api.github.com/users/splitrb/repos","events_url":"https://api.github.com/users/splitrb/events{/privacy}","received_events_url":"https://api.github.com/users/splitrb/received_events","type":"Organization","site_admin":false},"repo":{"id":1748446,"name":"split","full_name":"splitrb/split","owner":{"login":"splitrb","id":11708074,"avatar_url":"https://avatars.githubusercontent.com/u/11708074?v=3","gravatar_id":"","url":"https://api.github.com/users/splitrb","html_url":"https://github.com/splitrb","followers_url":"https://api.github.com/users/splitrb/followers","following_url":"https://api.github.com/users/splitrb/following{/other_user}","gists_url":"https://api.github.com/users/splitrb/gists{/gist_id}","starred_url":"https://api.github.com/users/splitrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitrb/subscriptions","organizations_url":"https://api.github.com/users/splitrb/orgs","repos_url":"https://api.github.com/users/splitrb/repos","events_url":"https://api.github.com/users/splitrb/events{/privacy}","received_events_url":"https://api.github.com/users/splitrb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/splitrb/split","description":":chart_with_upwards_trend: The Rack Based AB testing framework","fork":false,"url":"https://api.github.com/repos/splitrb/split","forks_url":"https://api.github.com/repos/splitrb/split/forks","keys_url":"https://api.github.com/repos/splitrb/split/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splitrb/split/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splitrb/split/teams","hooks_url":"https://api.github.com/repos/splitrb/split/hooks","issue_events_url":"https://api.github.com/repos/splitrb/split/issues/events{/number}","events_url":"https://api.github.com/repos/splitrb/split/events","assignees_url":"https://api.github.com/repos/splitrb/split/assignees{/user}","branches_url":"https://api.github.com/repos/splitrb/split/branches{/branch}","tags_url":"https://api.github.com/repos/splitrb/split/tags","blobs_url":"https://api.github.com/repos/splitrb/split/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splitrb/split/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splitrb/split/git/refs{/sha}","trees_url":"https://api.github.com/repos/splitrb/split/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splitrb/split/statuses/{sha}","languages_url":"https://api.github.com/repos/splitrb/split/languages","stargazers_url":"https://api.github.com/repos/splitrb/split/stargazers","contributors_url":"https://api.github.com/repos/splitrb/split/contributors","subscribers_url":"https://api.github.com/repos/splitrb/split/subscribers","subscription_url":"https://api.github.com/repos/splitrb/split/subscription","commits_url":"https://api.github.com/repos/splitrb/split/commits{/sha}","git_commits_url":"https://api.github.com/repos/splitrb/split/git/commits{/sha}","comments_url":"https://api.github.com/repos/splitrb/split/comments{/number}","issue_comment_url":"https://api.github.com/repos/splitrb/split/issues/comments{/number}","contents_url":"https://api.github.com/repos/splitrb/split/contents/{+path}","compare_url":"https://api.github.com/repos/splitrb/split/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splitrb/split/merges","archive_url":"https://api.github.com/repos/splitrb/split/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splitrb/split/downloads","issues_url":"https://api.github.com/repos/splitrb/split/issues{/number}","pulls_url":"https://api.github.com/repos/splitrb/split/pulls{/number}","milestones_url":"https://api.github.com/repos/splitrb/split/milestones{/number}","notifications_url":"https://api.github.com/repos/splitrb/split/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splitrb/split/labels{/name}","releases_url":"https://api.github.com/repos/splitrb/split/releases{/id}","created_at":"2011-05-14T18:05:47Z","updated_at":"2015-04-12T17:14:30Z","pushed_at":"2015-04-15T23:16:30Z","git_url":"git://github.com/splitrb/split.git","ssh_url":"git@github.com:splitrb/split.git","clone_url":"https://github.com/splitrb/split.git","svn_url":"https://github.com/splitrb/split","homepage":"http://libraries.io/rubygems/split","size":2096,"stargazers_count":1447,"watchers_count":1447,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":187,"mirror_url":null,"open_issues_count":24,"forks":187,"open_issues":24,"watchers":1447,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/splitrb/split/pulls/310"},"html":{"href":"https://github.com/splitrb/split/pull/310"},"issue":{"href":"https://api.github.com/repos/splitrb/split/issues/310"},"comments":{"href":"https://api.github.com/repos/splitrb/split/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/splitrb/split/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/splitrb/split/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/splitrb/split/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/splitrb/split/statuses/79aee0ee240ac172ce530d9e9a660df694974e64"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andrew","id":1060,"avatar_url":"https://avatars.githubusercontent.com/u/1060?v=3","gravatar_id":"","url":"https://api.github.com/users/andrew","html_url":"https://github.com/andrew","followers_url":"https://api.github.com/users/andrew/followers","following_url":"https://api.github.com/users/andrew/following{/other_user}","gists_url":"https://api.github.com/users/andrew/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew/subscriptions","organizations_url":"https://api.github.com/users/andrew/orgs","repos_url":"https://api.github.com/users/andrew/repos","events_url":"https://api.github.com/users/andrew/events{/privacy}","received_events_url":"https://api.github.com/users/andrew/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}