{"action":"created","comment":{"url":"https://api.github.com/repos/Originate/guide/pulls/comments/35661958","id":35661958,"diff_hunk":"@@ -154,27 +165,31 @@ Please read the [Scala Style Guide] carefully. The main points to consider are:\n     ```scala\n     package foo.bar\n \n-    // bad\n+    // Bad\n     import baz.Qux\n \n-    // good\n+    // Good\n     import foo.bar.baz.Qux\n     ```\n \n+0. Avoid wildcard-importing entire packages: `import package._`\n+\n 0. The bigger the scope, the more descriptive the name. Only for very small, local scopes may single-letter mnemonics be used.\n \n 0. Use `_` for simple, single line functions:\n \n     ```scala\n-    seq filter (_ % 2 == 0)\n+    val bad = seq filter (number => number % 2 == 0)\n+\n+    val good = seq filter (_ % 2 == 0)","path":"scala/README.md","position":143,"original_position":143,"commit_id":"a87193288b3f81fe64956ce21f138de7863fe7ed","original_commit_id":"a87193288b3f81fe64956ce21f138de7863fe7ed","user":{"login":"matthandlersux","id":72524,"avatar_url":"https://avatars.githubusercontent.com/u/72524?v=3","gravatar_id":"","url":"https://api.github.com/users/matthandlersux","html_url":"https://github.com/matthandlersux","followers_url":"https://api.github.com/users/matthandlersux/followers","following_url":"https://api.github.com/users/matthandlersux/following{/other_user}","gists_url":"https://api.github.com/users/matthandlersux/gists{/gist_id}","starred_url":"https://api.github.com/users/matthandlersux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthandlersux/subscriptions","organizations_url":"https://api.github.com/users/matthandlersux/orgs","repos_url":"https://api.github.com/users/matthandlersux/repos","events_url":"https://api.github.com/users/matthandlersux/events{/privacy}","received_events_url":"https://api.github.com/users/matthandlersux/received_events","type":"User","site_admin":false},"body":"can't remember, do we mention somewhere in this document to use `()` over `{}` for simple single line functions? ","created_at":"2015-07-28T15:37:39Z","updated_at":"2015-07-28T15:37:39Z","html_url":"https://github.com/Originate/guide/pull/3#discussion_r35661958","pull_request_url":"https://api.github.com/repos/Originate/guide/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/Originate/guide/pulls/comments/35661958"},"html":{"href":"https://github.com/Originate/guide/pull/3#discussion_r35661958"},"pull_request":{"href":"https://api.github.com/repos/Originate/guide/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/Originate/guide/pulls/3","id":40815374,"html_url":"https://github.com/Originate/guide/pull/3","diff_url":"https://github.com/Originate/guide/pull/3.diff","patch_url":"https://github.com/Originate/guide/pull/3.patch","issue_url":"https://api.github.com/repos/Originate/guide/issues/3","number":3,"state":"open","locked":false,"title":"Scala Style Guide assorted additions and edits","user":{"login":"marconilanna","id":363009,"avatar_url":"https://avatars.githubusercontent.com/u/363009?v=3","gravatar_id":"","url":"https://api.github.com/users/marconilanna","html_url":"https://github.com/marconilanna","followers_url":"https://api.github.com/users/marconilanna/followers","following_url":"https://api.github.com/users/marconilanna/following{/other_user}","gists_url":"https://api.github.com/users/marconilanna/gists{/gist_id}","starred_url":"https://api.github.com/users/marconilanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marconilanna/subscriptions","organizations_url":"https://api.github.com/users/marconilanna/orgs","repos_url":"https://api.github.com/users/marconilanna/repos","events_url":"https://api.github.com/users/marconilanna/events{/privacy}","received_events_url":"https://api.github.com/users/marconilanna/received_events","type":"User","site_admin":false},"body":"@matthandlersux @a-wortman @aquin @jarhart @chrizkim @malexandert: A new round of assorted changes","created_at":"2015-07-24T21:00:04Z","updated_at":"2015-07-28T15:37:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"799b2e3018ddc7a2815d2446f8d0f71409281da9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Originate/guide/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Originate/guide/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Originate/guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Originate/guide/issues/3/comments","statuses_url":"https://api.github.com/repos/Originate/guide/statuses/a87193288b3f81fe64956ce21f138de7863fe7ed","head":{"label":"Originate:marconi/scala_style_guide","ref":"marconi/scala_style_guide","sha":"a87193288b3f81fe64956ce21f138de7863fe7ed","user":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"repo":{"id":20503692,"name":"guide","full_name":"Originate/guide","owner":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Originate/guide","description":"","fork":false,"url":"https://api.github.com/repos/Originate/guide","forks_url":"https://api.github.com/repos/Originate/guide/forks","keys_url":"https://api.github.com/repos/Originate/guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Originate/guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Originate/guide/teams","hooks_url":"https://api.github.com/repos/Originate/guide/hooks","issue_events_url":"https://api.github.com/repos/Originate/guide/issues/events{/number}","events_url":"https://api.github.com/repos/Originate/guide/events","assignees_url":"https://api.github.com/repos/Originate/guide/assignees{/user}","branches_url":"https://api.github.com/repos/Originate/guide/branches{/branch}","tags_url":"https://api.github.com/repos/Originate/guide/tags","blobs_url":"https://api.github.com/repos/Originate/guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Originate/guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Originate/guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/Originate/guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Originate/guide/statuses/{sha}","languages_url":"https://api.github.com/repos/Originate/guide/languages","stargazers_url":"https://api.github.com/repos/Originate/guide/stargazers","contributors_url":"https://api.github.com/repos/Originate/guide/contributors","subscribers_url":"https://api.github.com/repos/Originate/guide/subscribers","subscription_url":"https://api.github.com/repos/Originate/guide/subscription","commits_url":"https://api.github.com/repos/Originate/guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/Originate/guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/Originate/guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/Originate/guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/Originate/guide/contents/{+path}","compare_url":"https://api.github.com/repos/Originate/guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Originate/guide/merges","archive_url":"https://api.github.com/repos/Originate/guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Originate/guide/downloads","issues_url":"https://api.github.com/repos/Originate/guide/issues{/number}","pulls_url":"https://api.github.com/repos/Originate/guide/pulls{/number}","milestones_url":"https://api.github.com/repos/Originate/guide/milestones{/number}","notifications_url":"https://api.github.com/repos/Originate/guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Originate/guide/labels{/name}","releases_url":"https://api.github.com/repos/Originate/guide/releases{/id}","created_at":"2014-06-04T22:43:09Z","updated_at":"2015-06-15T19:16:29Z","pushed_at":"2015-07-27T18:07:55Z","git_url":"git://github.com/Originate/guide.git","ssh_url":"git@github.com:Originate/guide.git","clone_url":"https://github.com/Originate/guide.git","svn_url":"https://github.com/Originate/guide","homepage":null,"size":383,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":14,"default_branch":"master"}},"base":{"label":"Originate:master","ref":"master","sha":"2aac3ac0427fbdbb68c25c1819926fb3d71cfa6e","user":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"repo":{"id":20503692,"name":"guide","full_name":"Originate/guide","owner":{"login":"Originate","id":1627168,"avatar_url":"https://avatars.githubusercontent.com/u/1627168?v=3","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Originate/guide","description":"","fork":false,"url":"https://api.github.com/repos/Originate/guide","forks_url":"https://api.github.com/repos/Originate/guide/forks","keys_url":"https://api.github.com/repos/Originate/guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Originate/guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Originate/guide/teams","hooks_url":"https://api.github.com/repos/Originate/guide/hooks","issue_events_url":"https://api.github.com/repos/Originate/guide/issues/events{/number}","events_url":"https://api.github.com/repos/Originate/guide/events","assignees_url":"https://api.github.com/repos/Originate/guide/assignees{/user}","branches_url":"https://api.github.com/repos/Originate/guide/branches{/branch}","tags_url":"https://api.github.com/repos/Originate/guide/tags","blobs_url":"https://api.github.com/repos/Originate/guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Originate/guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Originate/guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/Originate/guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Originate/guide/statuses/{sha}","languages_url":"https://api.github.com/repos/Originate/guide/languages","stargazers_url":"https://api.github.com/repos/Originate/guide/stargazers","contributors_url":"https://api.github.com/repos/Originate/guide/contributors","subscribers_url":"https://api.github.com/repos/Originate/guide/subscribers","subscription_url":"https://api.github.com/repos/Originate/guide/subscription","commits_url":"https://api.github.com/repos/Originate/guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/Originate/guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/Originate/guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/Originate/guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/Originate/guide/contents/{+path}","compare_url":"https://api.github.com/repos/Originate/guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Originate/guide/merges","archive_url":"https://api.github.com/repos/Originate/guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Originate/guide/downloads","issues_url":"https://api.github.com/repos/Originate/guide/issues{/number}","pulls_url":"https://api.github.com/repos/Originate/guide/pulls{/number}","milestones_url":"https://api.github.com/repos/Originate/guide/milestones{/number}","notifications_url":"https://api.github.com/repos/Originate/guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Originate/guide/labels{/name}","releases_url":"https://api.github.com/repos/Originate/guide/releases{/id}","created_at":"2014-06-04T22:43:09Z","updated_at":"2015-06-15T19:16:29Z","pushed_at":"2015-07-27T18:07:55Z","git_url":"git://github.com/Originate/guide.git","ssh_url":"git@github.com:Originate/guide.git","clone_url":"https://github.com/Originate/guide.git","svn_url":"https://github.com/Originate/guide","homepage":null,"size":383,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Originate/guide/pulls/3"},"html":{"href":"https://github.com/Originate/guide/pull/3"},"issue":{"href":"https://api.github.com/repos/Originate/guide/issues/3"},"comments":{"href":"https://api.github.com/repos/Originate/guide/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Originate/guide/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Originate/guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Originate/guide/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Originate/guide/statuses/a87193288b3f81fe64956ce21f138de7863fe7ed"}}}}