{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3049","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3049/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3049/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3049/events","html_url":"https://github.com/cockroachdb/cockroach/pull/3049","id":115786988,"number":3049,"title":"Add support for regexp_extract and SUBSTRING builtin functions","user":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-11-09T04:03:12Z","updated_at":"2015-11-09T16:49:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/3049","html_url":"https://github.com/cockroachdb/cockroach/pull/3049","diff_url":"https://github.com/cockroachdb/cockroach/pull/3049.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/3049.patch"},"body":"See #2042\r\n\r\nNote that the substring functions do not support `substring(string for int)`. `substring(string for int from int)` is also not supported (yet?) because it is not valid SQL99.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/3049)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/155120283","html_url":"https://github.com/cockroachdb/cockroach/pull/3049#issuecomment-155120283","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3049","id":155120283,"user":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"created_at":"2015-11-09T16:49:30Z","updated_at":"2015-11-09T16:49:30Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n<sup>**[sql/parser/sql.y, line 3110 \\[r4\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3049#-K2gn2P_ifLRQ-zMIXvj)** ([raw file](https://github.com/cockroachdb/cockroach/blob/77a53267ad432e0368c7cd1a3efb8bbd83c5f412/sql/parser/sql.y#L3110)):</sup>\nStrange, the only checkmark I'm seeing doesn't seem to be related to resolving the discussion, only to the current message's response requirements. It still says the overall discussion is waiting for a response from Peter.\n<!-- Reviewable comment -K2h80JU6mflDqv6s1y1:-1036353427 -->\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/3049)\n<!-- Sent from Reviewable.io -->\n"}}