{"comment":{"url":"https://api.github.com/repos/bpwook/auto-cert-kit/comments/9811172","html_url":"https://github.com/bpwook/auto-cert-kit/commit/72e117c58b24e7b5e8598a8c1b1b13c36682aa6e#commitcomment-9811172","id":9811172,"user":{"login":"bpwook","id":3729315,"avatar_url":"https://avatars.githubusercontent.com/u/3729315?v=3","gravatar_id":"","url":"https://api.github.com/users/bpwook","html_url":"https://github.com/bpwook","followers_url":"https://api.github.com/users/bpwook/followers","following_url":"https://api.github.com/users/bpwook/following{/other_user}","gists_url":"https://api.github.com/users/bpwook/gists{/gist_id}","starred_url":"https://api.github.com/users/bpwook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpwook/subscriptions","organizations_url":"https://api.github.com/users/bpwook/orgs","repos_url":"https://api.github.com/users/bpwook/repos","events_url":"https://api.github.com/users/bpwook/events{/privacy}","received_events_url":"https://api.github.com/users/bpwook/received_events","type":"User","site_admin":false},"position":6,"line":363,"path":"plugins/autocertkit","commit_id":"72e117c58b24e7b5e8598a8c1b1b13c36682aa6e","created_at":"2015-02-18T23:34:58Z","updated_at":"2015-02-18T23:34:58Z","body":"I think aim of the functions are slightly different.\r\n\r\n'_get_local_device' is to retrieve information of NIC such as IP, MAC and etc. It is more likely to be used when NIC is properly set up, rather than to check link is up or not while get_iface_linkstate is to check whether NIC is up and running.\r\nBut I do feel it needs to have different name that is using 'local_device' instead of 'face' for readability (and uni-toned names of functions.)\r\n"}}