{"action":"created","issue":{"url":"https://api.github.com/repos/psecio/parse/issues/63","labels_url":"https://api.github.com/repos/psecio/parse/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/psecio/parse/issues/63/comments","events_url":"https://api.github.com/repos/psecio/parse/issues/63/events","html_url":"https://github.com/psecio/parse/pull/63","id":56131841,"number":63,"title":"Update IsFunctionCallTrait (IsFunctionTrait)","user":{"login":"hanneskod","id":1369274,"avatar_url":"https://avatars.githubusercontent.com/u/1369274?v=3","gravatar_id":"","url":"https://api.github.com/users/hanneskod","html_url":"https://github.com/hanneskod","followers_url":"https://api.github.com/users/hanneskod/followers","following_url":"https://api.github.com/users/hanneskod/following{/other_user}","gists_url":"https://api.github.com/users/hanneskod/gists{/gist_id}","starred_url":"https://api.github.com/users/hanneskod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanneskod/subscriptions","organizations_url":"https://api.github.com/users/hanneskod/orgs","repos_url":"https://api.github.com/users/hanneskod/repos","events_url":"https://api.github.com/users/hanneskod/events{/privacy}","received_events_url":"https://api.github.com/users/hanneskod/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-31T17:22:43Z","updated_at":"2015-02-08T17:44:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/psecio/parse/pulls/63","html_url":"https://github.com/psecio/parse/pull/63","diff_url":"https://github.com/psecio/parse/pull/63.diff","patch_url":"https://github.com/psecio/parse/pull/63.patch"},"body":"The scrutinizer tool finds a number of issues in parse. See https://scrutinizer-ci.com/g/hanneskod/parse/.\r\n\r\nThis pr targets the scrutinizr issues in `IsFunctionCallTrait` (renamed, formerly `IsFunctionTrait`). The `PhpParser` interface isn't always easy to work with... This adds some instance checks and makes `isFunctionCall()` more versatile.\r\n\r\nOne change requires extra comments:\r\n\r\nI have removed the ability of `isFunctionCall()` to parse variable names and return true if the function call is from an array. Maybe I am missunderstanding something, but these checks seem mistaken to me.\r\n\r\n```php\r\n$session_regenerate_id();\r\n```\r\nshould not cause an error, as we do not know the contents of the variable.."},"comment":{"url":"https://api.github.com/repos/psecio/parse/issues/comments/73421837","html_url":"https://github.com/psecio/parse/pull/63#issuecomment-73421837","issue_url":"https://api.github.com/repos/psecio/parse/issues/63","id":73421837,"user":{"login":"hanneskod","id":1369274,"avatar_url":"https://avatars.githubusercontent.com/u/1369274?v=3","gravatar_id":"","url":"https://api.github.com/users/hanneskod","html_url":"https://github.com/hanneskod","followers_url":"https://api.github.com/users/hanneskod/followers","following_url":"https://api.github.com/users/hanneskod/following{/other_user}","gists_url":"https://api.github.com/users/hanneskod/gists{/gist_id}","starred_url":"https://api.github.com/users/hanneskod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanneskod/subscriptions","organizations_url":"https://api.github.com/users/hanneskod/orgs","repos_url":"https://api.github.com/users/hanneskod/repos","events_url":"https://api.github.com/users/hanneskod/events{/privacy}","received_events_url":"https://api.github.com/users/hanneskod/received_events","type":"User","site_admin":false},"created_at":"2015-02-08T17:44:33Z","updated_at":"2015-02-08T17:44:33Z","body":"> This commit has some really great stuff. However, it does a whole lot more than rename IsFunctionTraittoIsFunctionCallTrait` as the commit message says.\r\n\r\nYes that is absolutely true, I was a bit sloppy here. Thanx for the reminder :smile:\r\n\r\nI think this is done, and, if you are happy (despite the big commit), ready to merge.\r\n\r\n(For future reference: This is also related to #24. Using the phpparser interface is really hard! Some kind of simple and testable wrapper is probably a good idea.)"}}