{"action":"created","comment":{"url":"https://api.github.com/repos/rubycas/rubycas-client/pulls/comments/27769304","id":27769304,"diff_hunk":"@@ -90,4 +90,12 @@\n       end\n     end\n   end\n+\n+  describe 'logout_url' do\n+    it 'should tolerate oddly formed URIs' do\n+      destination_url = 'https://foo.com/path/to/page?&sort=date_received.DESC'\n+      \n+      client.logout_url(destination_url)","path":"spec/casclient/client_spec.rb","position":9,"original_position":9,"commit_id":"c2a7c5690fa94b1ff357e19d7947f46fd3de74a4","original_commit_id":"c2a7c5690fa94b1ff357e19d7947f46fd3de74a4","user":{"login":"CloCkWeRX","id":365751,"avatar_url":"https://avatars.githubusercontent.com/u/365751?v=3","gravatar_id":"","url":"https://api.github.com/users/CloCkWeRX","html_url":"https://github.com/CloCkWeRX","followers_url":"https://api.github.com/users/CloCkWeRX/followers","following_url":"https://api.github.com/users/CloCkWeRX/following{/other_user}","gists_url":"https://api.github.com/users/CloCkWeRX/gists{/gist_id}","starred_url":"https://api.github.com/users/CloCkWeRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloCkWeRX/subscriptions","organizations_url":"https://api.github.com/users/CloCkWeRX/orgs","repos_url":"https://api.github.com/users/CloCkWeRX/repos","events_url":"https://api.github.com/users/CloCkWeRX/events{/privacy}","received_events_url":"https://api.github.com/users/CloCkWeRX/received_events","type":"User","site_admin":false},"body":"Ugh, it's been three years and the underlying bug is still present - https://github.com/rubycas/rubycas-client/blob/master/lib/casclient/client.rb#L286","created_at":"2015-04-04T14:34:45Z","updated_at":"2015-04-04T14:34:45Z","html_url":"https://github.com/rubycas/rubycas-client/pull/53#discussion_r27769304","pull_request_url":"https://api.github.com/repos/rubycas/rubycas-client/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/rubycas/rubycas-client/pulls/comments/27769304"},"html":{"href":"https://github.com/rubycas/rubycas-client/pull/53#discussion_r27769304"},"pull_request":{"href":"https://api.github.com/repos/rubycas/rubycas-client/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/rubycas/rubycas-client/pulls/53","id":2657320,"html_url":"https://github.com/rubycas/rubycas-client/pull/53","diff_url":"https://github.com/rubycas/rubycas-client/pull/53.diff","patch_url":"https://github.com/rubycas/rubycas-client/pull/53.patch","issue_url":"https://api.github.com/repos/rubycas/rubycas-client/issues/53","number":53,"state":"open","locked":false,"title":"Fix deprecation warning, fix private method `gsub' called for nil:NilClass error on 1.8.7","user":{"login":"CloCkWeRX","id":365751,"avatar_url":"https://avatars.githubusercontent.com/u/365751?v=3","gravatar_id":"","url":"https://api.github.com/users/CloCkWeRX","html_url":"https://github.com/CloCkWeRX","followers_url":"https://api.github.com/users/CloCkWeRX/followers","following_url":"https://api.github.com/users/CloCkWeRX/following{/other_user}","gists_url":"https://api.github.com/users/CloCkWeRX/gists{/gist_id}","starred_url":"https://api.github.com/users/CloCkWeRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloCkWeRX/subscriptions","organizations_url":"https://api.github.com/users/CloCkWeRX/orgs","repos_url":"https://api.github.com/users/CloCkWeRX/repos","events_url":"https://api.github.com/users/CloCkWeRX/events{/privacy}","received_events_url":"https://api.github.com/users/CloCkWeRX/received_events","type":"User","site_admin":false},"body":"Was https://github.com/rubycas/rubycas-client-rails/issues/20\r\n\r\nWith certain URIs, it's possible to have a blank key, causing a private method `gsub' called for nil:NilClass error on 1.8.7\r\n\r\n","created_at":"2012-10-15T23:22:06Z","updated_at":"2015-04-04T14:34:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rubycas/rubycas-client/pulls/53/commits","review_comments_url":"https://api.github.com/repos/rubycas/rubycas-client/pulls/53/comments","review_comment_url":"https://api.github.com/repos/rubycas/rubycas-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubycas/rubycas-client/issues/53/comments","statuses_url":"https://api.github.com/repos/rubycas/rubycas-client/statuses/c2a7c5690fa94b1ff357e19d7947f46fd3de74a4","head":{"label":"CloCkWeRX:master","ref":"master","sha":"c2a7c5690fa94b1ff357e19d7947f46fd3de74a4","user":{"login":"CloCkWeRX","id":365751,"avatar_url":"https://avatars.githubusercontent.com/u/365751?v=3","gravatar_id":"","url":"https://api.github.com/users/CloCkWeRX","html_url":"https://github.com/CloCkWeRX","followers_url":"https://api.github.com/users/CloCkWeRX/followers","following_url":"https://api.github.com/users/CloCkWeRX/following{/other_user}","gists_url":"https://api.github.com/users/CloCkWeRX/gists{/gist_id}","starred_url":"https://api.github.com/users/CloCkWeRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloCkWeRX/subscriptions","organizations_url":"https://api.github.com/users/CloCkWeRX/orgs","repos_url":"https://api.github.com/users/CloCkWeRX/repos","events_url":"https://api.github.com/users/CloCkWeRX/events{/privacy}","received_events_url":"https://api.github.com/users/CloCkWeRX/received_events","type":"User","site_admin":false},"repo":{"id":5308277,"name":"rubycas-client","full_name":"CloCkWeRX/rubycas-client","owner":{"login":"CloCkWeRX","id":365751,"avatar_url":"https://avatars.githubusercontent.com/u/365751?v=3","gravatar_id":"","url":"https://api.github.com/users/CloCkWeRX","html_url":"https://github.com/CloCkWeRX","followers_url":"https://api.github.com/users/CloCkWeRX/followers","following_url":"https://api.github.com/users/CloCkWeRX/following{/other_user}","gists_url":"https://api.github.com/users/CloCkWeRX/gists{/gist_id}","starred_url":"https://api.github.com/users/CloCkWeRX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloCkWeRX/subscriptions","organizations_url":"https://api.github.com/users/CloCkWeRX/orgs","repos_url":"https://api.github.com/users/CloCkWeRX/repos","events_url":"https://api.github.com/users/CloCkWeRX/events{/privacy}","received_events_url":"https://api.github.com/users/CloCkWeRX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CloCkWeRX/rubycas-client","description":"Ruby  client for Yale's Central Authentication Service protocol -- an open source enterprise single sign on system for web applications.","fork":true,"url":"https://api.github.com/repos/CloCkWeRX/rubycas-client","forks_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/forks","keys_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/teams","hooks_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/hooks","issue_events_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/issues/events{/number}","events_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/events","assignees_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/assignees{/user}","branches_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/branches{/branch}","tags_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/tags","blobs_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/statuses/{sha}","languages_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/languages","stargazers_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/stargazers","contributors_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/contributors","subscribers_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/subscribers","subscription_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/subscription","commits_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/contents/{+path}","compare_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/merges","archive_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/downloads","issues_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/issues{/number}","pulls_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/pulls{/number}","milestones_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/milestones{/number}","notifications_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/labels{/name}","releases_url":"https://api.github.com/repos/CloCkWeRX/rubycas-client/releases{/id}","created_at":"2012-08-06T00:34:37Z","updated_at":"2013-01-11T14:47:44Z","pushed_at":"2012-10-15T23:19:33Z","git_url":"git://github.com/CloCkWeRX/rubycas-client.git","ssh_url":"git@github.com:CloCkWeRX/rubycas-client.git","clone_url":"https://github.com/CloCkWeRX/rubycas-client.git","svn_url":"https://github.com/CloCkWeRX/rubycas-client","homepage":"http://code.google.com/p/rubycas-client/","size":3056,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rubycas:master","ref":"master","sha":"3c8adc5b69971f1da4c52f08e637258cf092759c","user":{"login":"rubycas","id":976572,"avatar_url":"https://avatars.githubusercontent.com/u/976572?v=3","gravatar_id":"","url":"https://api.github.com/users/rubycas","html_url":"https://github.com/rubycas","followers_url":"https://api.github.com/users/rubycas/followers","following_url":"https://api.github.com/users/rubycas/following{/other_user}","gists_url":"https://api.github.com/users/rubycas/gists{/gist_id}","starred_url":"https://api.github.com/users/rubycas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubycas/subscriptions","organizations_url":"https://api.github.com/users/rubycas/orgs","repos_url":"https://api.github.com/users/rubycas/repos","events_url":"https://api.github.com/users/rubycas/events{/privacy}","received_events_url":"https://api.github.com/users/rubycas/received_events","type":"Organization","site_admin":false},"repo":{"id":77844,"name":"rubycas-client","full_name":"rubycas/rubycas-client","owner":{"login":"rubycas","id":976572,"avatar_url":"https://avatars.githubusercontent.com/u/976572?v=3","gravatar_id":"","url":"https://api.github.com/users/rubycas","html_url":"https://github.com/rubycas","followers_url":"https://api.github.com/users/rubycas/followers","following_url":"https://api.github.com/users/rubycas/following{/other_user}","gists_url":"https://api.github.com/users/rubycas/gists{/gist_id}","starred_url":"https://api.github.com/users/rubycas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubycas/subscriptions","organizations_url":"https://api.github.com/users/rubycas/orgs","repos_url":"https://api.github.com/users/rubycas/repos","events_url":"https://api.github.com/users/rubycas/events{/privacy}","received_events_url":"https://api.github.com/users/rubycas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubycas/rubycas-client","description":"Ruby  client for Yale's Central Authentication Service protocol -- an open source enterprise single sign on system for web applications.","fork":false,"url":"https://api.github.com/repos/rubycas/rubycas-client","forks_url":"https://api.github.com/repos/rubycas/rubycas-client/forks","keys_url":"https://api.github.com/repos/rubycas/rubycas-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubycas/rubycas-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubycas/rubycas-client/teams","hooks_url":"https://api.github.com/repos/rubycas/rubycas-client/hooks","issue_events_url":"https://api.github.com/repos/rubycas/rubycas-client/issues/events{/number}","events_url":"https://api.github.com/repos/rubycas/rubycas-client/events","assignees_url":"https://api.github.com/repos/rubycas/rubycas-client/assignees{/user}","branches_url":"https://api.github.com/repos/rubycas/rubycas-client/branches{/branch}","tags_url":"https://api.github.com/repos/rubycas/rubycas-client/tags","blobs_url":"https://api.github.com/repos/rubycas/rubycas-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubycas/rubycas-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubycas/rubycas-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubycas/rubycas-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubycas/rubycas-client/statuses/{sha}","languages_url":"https://api.github.com/repos/rubycas/rubycas-client/languages","stargazers_url":"https://api.github.com/repos/rubycas/rubycas-client/stargazers","contributors_url":"https://api.github.com/repos/rubycas/rubycas-client/contributors","subscribers_url":"https://api.github.com/repos/rubycas/rubycas-client/subscribers","subscription_url":"https://api.github.com/repos/rubycas/rubycas-client/subscription","commits_url":"https://api.github.com/repos/rubycas/rubycas-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubycas/rubycas-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubycas/rubycas-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubycas/rubycas-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubycas/rubycas-client/contents/{+path}","compare_url":"https://api.github.com/repos/rubycas/rubycas-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubycas/rubycas-client/merges","archive_url":"https://api.github.com/repos/rubycas/rubycas-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubycas/rubycas-client/downloads","issues_url":"https://api.github.com/repos/rubycas/rubycas-client/issues{/number}","pulls_url":"https://api.github.com/repos/rubycas/rubycas-client/pulls{/number}","milestones_url":"https://api.github.com/repos/rubycas/rubycas-client/milestones{/number}","notifications_url":"https://api.github.com/repos/rubycas/rubycas-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubycas/rubycas-client/labels{/name}","releases_url":"https://api.github.com/repos/rubycas/rubycas-client/releases{/id}","created_at":"2008-11-18T21:07:21Z","updated_at":"2015-03-16T14:07:14Z","pushed_at":"2014-08-31T17:56:13Z","git_url":"git://github.com/rubycas/rubycas-client.git","ssh_url":"git@github.com:rubycas/rubycas-client.git","clone_url":"https://github.com/rubycas/rubycas-client.git","svn_url":"https://github.com/rubycas/rubycas-client","homepage":"http://code.google.com/p/rubycas-client/","size":3731,"stargazers_count":278,"watchers_count":278,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":183,"mirror_url":null,"open_issues_count":26,"forks":183,"open_issues":26,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubycas/rubycas-client/pulls/53"},"html":{"href":"https://github.com/rubycas/rubycas-client/pull/53"},"issue":{"href":"https://api.github.com/repos/rubycas/rubycas-client/issues/53"},"comments":{"href":"https://api.github.com/repos/rubycas/rubycas-client/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/rubycas/rubycas-client/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/rubycas/rubycas-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubycas/rubycas-client/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/rubycas/rubycas-client/statuses/c2a7c5690fa94b1ff357e19d7947f46fd3de74a4"}}}}