{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/17500","labels_url":"https://api.github.com/repos/owncloud/core/issues/17500/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/17500/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/17500/events","html_url":"https://github.com/owncloud/core/pull/17500","id":93835354,"number":17500,"title":"Only clean up if migration finished succesfully","user":{"login":"schiesbn","id":1589737,"avatar_url":"https://avatars.githubusercontent.com/u/1589737?v=3","gravatar_id":"","url":"https://api.github.com/users/schiesbn","html_url":"https://github.com/schiesbn","followers_url":"https://api.github.com/users/schiesbn/followers","following_url":"https://api.github.com/users/schiesbn/following{/other_user}","gists_url":"https://api.github.com/users/schiesbn/gists{/gist_id}","starred_url":"https://api.github.com/users/schiesbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schiesbn/subscriptions","organizations_url":"https://api.github.com/users/schiesbn/orgs","repos_url":"https://api.github.com/users/schiesbn/repos","events_url":"https://api.github.com/users/schiesbn/events{/privacy}","received_events_url":"https://api.github.com/users/schiesbn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/app:encryption","name":"app:encryption","color":"02d7e1"},{"url":"https://api.github.com/repos/owncloud/core/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/owncloud/core/labels/sev1-critical","name":"sev1-critical","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/46","html_url":"https://github.com/owncloud/core/milestones/8.1.1-current-maintenance","labels_url":"https://api.github.com/repos/owncloud/core/milestones/46/labels","id":1167392,"number":46,"title":"8.1.1-current-maintenance","description":"","creator":{"login":"cmonteroluque","id":879976,"avatar_url":"https://avatars.githubusercontent.com/u/879976?v=3","gravatar_id":"","url":"https://api.github.com/users/cmonteroluque","html_url":"https://github.com/cmonteroluque","followers_url":"https://api.github.com/users/cmonteroluque/followers","following_url":"https://api.github.com/users/cmonteroluque/following{/other_user}","gists_url":"https://api.github.com/users/cmonteroluque/gists{/gist_id}","starred_url":"https://api.github.com/users/cmonteroluque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmonteroluque/subscriptions","organizations_url":"https://api.github.com/users/cmonteroluque/orgs","repos_url":"https://api.github.com/users/cmonteroluque/repos","events_url":"https://api.github.com/users/cmonteroluque/events{/privacy}","received_events_url":"https://api.github.com/users/cmonteroluque/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":10,"state":"open","created_at":"2015-06-16T19:39:31Z","updated_at":"2015-07-09T08:10:30Z","due_on":"2015-08-03T22:00:00Z","closed_at":null},"comments":6,"created_at":"2015-07-08T16:34:54Z","updated_at":"2015-07-09T08:35:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/17500","html_url":"https://github.com/owncloud/core/pull/17500","diff_url":"https://github.com/owncloud/core/pull/17500.diff","patch_url":"https://github.com/owncloud/core/pull/17500.patch"},"body":"- Move the final clean up from the destructor to a separate method. If the migration fails it can happen that the destructor gets called to early. This way we make sure that we really clean up the remaining keys and config settings only at the end of the migration process.\r\n\r\n- only create new key pair if both keys, private and public, are missing\r\n\r\nFixes issues like described here https://github.com/owncloud/core/issues/16928"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/119874449","html_url":"https://github.com/owncloud/core/pull/17500#issuecomment-119874449","issue_url":"https://api.github.com/repos/owncloud/core/issues/17500","id":119874449,"user":{"login":"owncloud-bot","id":2709266,"avatar_url":"https://avatars.githubusercontent.com/u/2709266?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud-bot","html_url":"https://github.com/owncloud-bot","followers_url":"https://api.github.com/users/owncloud-bot/followers","following_url":"https://api.github.com/users/owncloud-bot/following{/other_user}","gists_url":"https://api.github.com/users/owncloud-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud-bot/subscriptions","organizations_url":"https://api.github.com/users/owncloud-bot/orgs","repos_url":"https://api.github.com/users/owncloud-bot/repos","events_url":"https://api.github.com/users/owncloud-bot/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud-bot/received_events","type":"User","site_admin":false},"created_at":"2015-07-09T08:35:43Z","updated_at":"2015-07-09T08:35:43Z","body":":bomb: Test FAILed. :bomb:\n![nooo432](https://cloud.githubusercontent.com/assets/1005065/6687475/9f3ddeae-ccab-11e4-836c-b1def1add2f1.jpg)\n\n"}}