{"action":"created","issue":{"url":"https://api.github.com/repos/marijnh/acorn/issues/314","labels_url":"https://api.github.com/repos/marijnh/acorn/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/marijnh/acorn/issues/314/comments","events_url":"https://api.github.com/repos/marijnh/acorn/issues/314/events","html_url":"https://github.com/marijnh/acorn/pull/314","id":108518933,"number":314,"title":"Fix support for some ES2015 identifiers","user":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars.githubusercontent.com/u/1538624?v=3","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-27T07:00:12Z","updated_at":"2015-09-27T14:56:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/marijnh/acorn/pulls/314","html_url":"https://github.com/marijnh/acorn/pull/314","diff_url":"https://github.com/marijnh/acorn/pull/314.diff","patch_url":"https://github.com/marijnh/acorn/pull/314.patch"},"body":"The second commit causes the output of `onToken` and `tokenizer` to be different: the former outputs a `name` token with value `let` while the latter outputs a `let` token.\r\n\r\nThere is also the question of the validity of `const let`. ES2015 [13.3.1.1](http://www.ecma-international.org/ecma-262/6.0/#sec-let-and-const-declarations-static-semantics-early-errors) says:\r\n\r\n> *LexicalDeclaration* **:** *LetOrConst* *BindingList* **;**\r\n>\r\n> - It is a Syntax Error if the BoundNames of *BindingList* contains `\"let\"`.\r\n> - It is a Syntax Error if the BoundNames of *BindingList* contains any duplicate entries.\r\n\r\nIf I'm understanding this passage correctly, it's saying that `let let` and `const let` are both not valid. Esprima supports this claim.\r\n\r\nIn V8 however `const let = 0` works fine.\r\n\r\nFixes part of #227. `var yield` still fails to parse."},"comment":{"url":"https://api.github.com/repos/marijnh/acorn/issues/comments/143564107","html_url":"https://github.com/marijnh/acorn/pull/314#issuecomment-143564107","issue_url":"https://api.github.com/repos/marijnh/acorn/issues/314","id":143564107,"user":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars.githubusercontent.com/u/1538624?v=3","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"created_at":"2015-09-27T14:56:01Z","updated_at":"2015-09-27T14:56:01Z","body":"> We might have to drop the `let` token type and make it a contextual keyword.\r\n\r\nThat sounds like the way to go."}}